William Godbe [Tue, 26 Feb 2019 21:54:54 +0000 (13:54 -0800)]
Merge pull request dotnet/corefx#35572 from wtgodbe/UpdateStando
[master] Trigger manual DARC update
Commit migrated from https://github.com/dotnet/corefx/commit/
7c37cfbd03d058b966160fdc39cd902ef3b2782c
Essam Almohammadi [Sat, 9 Feb 2019 10:55:56 +0000 (11:55 +0100)]
Add string overloads to DbDataReader.Get*()
Implement dotnet/corefx#31595
Commit migrated from https://github.com/dotnet/corefx/commit/
b30fc2b4ee302e449e3580ae39cb083a76b813c9
wtgodbe [Tue, 26 Feb 2019 00:26:29 +0000 (16:26 -0800)]
Update ApiCompat baselines
Commit migrated from https://github.com/dotnet/corefx/commit/
01ef5e6cbb395709c02436538018d44c61cfdcc8
Vance Morrison [Tue, 26 Feb 2019 15:51:19 +0000 (07:51 -0800)]
Changes to support W3C style IDs and propagation (dotnet/corefx#33207)
* First set of changes to support W3C style IDs and propagation
see https://w3c.github.io/trace-context
This is mostly for discussion purposes.
* Changed UseW3CFormat to be DefaultIdFormat
* Review feedback
* More comments. Small Renames
* Added Sampling Support, Review feedback.
* Added placeholder for SetRecordingDesired
* Separated out the Sampling support into its own PR.
* Remove more sampling support
* Fix IsWC3Id -> IdFormat
* Added Sampling Support, Review feedback.
* Separated out the Sampling support into its own PR.
* Add ForceW3C option.
* Introduce ForceDefaultIdFormat
* Adding SpanId and TraceId support
* Change ulong->long in SpanID (probably temporary)
* Remove undesired file changes
* Fix up reference assembly.
Note complete because of questions about Span<byte>, but closer now.
* Turn on code that used Span<byte>
* Defer setting IDFormat until start.
This insures that the IDFormat property is either unknown or a given value (that never changes from there).
* More implementation, made the interface more uniform.
* Support to avoid using strings whenever possible
Basically Id, SpanId TraceId properties are set lazily and only converted lazily.
* Added some tests
* First round of testing (and bugfixes)
* More testing
* Added Equality operators
* Rename SpanId -> ActivitySpanId TraceId ->ActivityTraceId
* Add Comments
* Fix bad XML comment
* Review feedback
* Change AsBytes -> CopyTo
Lifetime issues prevent returning Span<T> (which is what AsBytes does. Reverting to CopyTo instead.
Also added System.Memory ref in attempt to resolve build errors (that don't reproduce locally).
* Attempt to fix build break in netfx build
* Deal with Verification errors.
* Provide full namespace for SecuritySafeCriticalAttribute
* More securitySafeCritical annotations to fix test failures on desktop
* Another attempt on setting SecuritySafeCritical
* Remove the readonly ref (to avoid perf issue)
* Fix most -buildAllConfigurations issues
* Tentative change to see if testing works if we ignore the older netstandard configs.
* Workaround package cycle involving DiagnosticSource and Memory
* Satisfy dangling System.Memory dangling reference in package tests
* Add notes to remove the workarounds when Unsafe is fixed.
* Review feedback
Uses Utf8 helpers where possible.
Commit migrated from https://github.com/dotnet/corefx/commit/
fa07e4f0a8e564f33ef8e2de86dc9087a53bdf26
Tomas Weinfurt [Tue, 26 Feb 2019 07:02:20 +0000 (23:02 -0800)]
improve Ssl3 detection (dotnet/corefx#35574)
* improve sslv3 detection
* updates to pass all tests
* correct catch
Commit migrated from https://github.com/dotnet/corefx/commit/
0fa22d4b6753c47b6139980255e932341353179e
Jeremy Barton [Tue, 26 Feb 2019 06:02:02 +0000 (22:02 -0800)]
Add doc comments to JsonDocument (and friends)
* Add doc comments to all public members of JsonDocument, JsonElement, JsonProperty, and JsonValueType.
* Add "do not use this" doc comments on all internal members, because of source-package concerns.
* Change JsonElement.TokenType from internal to private because it could.
Commit migrated from https://github.com/dotnet/corefx/commit/
81e9045dca63ccea9b4fe31f8ac3a035b1b1f86d
Tomas Weinfurt [Tue, 26 Feb 2019 05:28:18 +0000 (21:28 -0800)]
disable AllSubscriberStress test on ARM64 untill we get more resources to run it (dotnet/corefx#35575)
Commit migrated from https://github.com/dotnet/corefx/commit/
dedb0f8e93661d13f18c9afcae6c2883b28a2d68
Erhan Atesoglu [Tue, 26 Feb 2019 03:05:07 +0000 (19:05 -0800)]
Removed GetRootLength Helper Function from PathInternalWindows.cs (dotnet/corefx#35568)
Commit migrated from https://github.com/dotnet/corefx/commit/
6b262c30165fe7c39d9fb582495c76c704c0a0d6
Filip Navara [Tue, 26 Feb 2019 02:47:18 +0000 (03:47 +0100)]
Add temporary resources and copy of Thread implementation to unblock merge of shared CoreLib (dotnet/corefx#35553)
Commit migrated from https://github.com/dotnet/corefx/commit/
facf731986511cb0cc0ceb181b6c7d846afa0743
Adeel Mujahid [Tue, 26 Feb 2019 02:44:03 +0000 (04:44 +0200)]
Use NativeLibrary.TryLoad and prefer RTLD_LAZY over RTLD_NOW (dotnet/corefx#35548)
* Use NativeLibrary.TryLoad in ODBC test
* Use RTLD_LAZY instead of RTLD_NOW
* Add missing using statement
* More RTLD_NOW -> RTLD_LAZY
* Remove unused RTLD_NOW constant
* Use NativeLibrary.TryLoad instead of P/Invoke dlopen
* Inline method body in property
* Add fallback for netcoreapp2x and below
* Reduce visibility of const
Commit migrated from https://github.com/dotnet/corefx/commit/
863b9bff2d77669b426b52dcb1bf7ba9246729e0
Anirudh Agnihotry [Sun, 24 Feb 2019 22:31:51 +0000 (14:31 -0800)]
Removing restriction of first 8 character being different from lognames (dotnet/corefx#35532)
Commit migrated from https://github.com/dotnet/corefx/commit/
26b932e3c56702382d13ece010b300d3181d2891
Stephen Toub [Sat, 23 Feb 2019 10:00:31 +0000 (05:00 -0500)]
Remove Task{CompletionSource} allocations from Http2Stream (dotnet/corefx#35522)
* Remove Task{CompletionSource} allocations from Http2Stream
This change makes the Http2Stream instance itself awaitable via ValueTask, such that we don't need to allocate any additional TaskCompletionSource or Task objects for such internal await'ing, regardless of how many times the Http2Connection or Http2ReadStream needs to wait for headers or response data to arrive.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
aacff5212204ee54e3b3e0172fcf364c3fe253e3
Jan Kotas [Sat, 23 Feb 2019 05:07:03 +0000 (21:07 -0800)]
Use product version in RuntimeInformation.FrameworkDescription (dotnet/corefx#35516)
* Use product version in RuntimeInformation.FrameworkDescription
* Include FrameworkDescription in the Assert
* Strip the git hash in the fallback
Commit migrated from https://github.com/dotnet/corefx/commit/
db95b37fa3218e20ff639b232a41202b24ddcb39
Erhan Atesoglu [Sat, 23 Feb 2019 02:53:24 +0000 (18:53 -0800)]
Removed "Argument_InvalidPathChars" Resource String (dotnet/corefx#35534)
Commit migrated from https://github.com/dotnet/corefx/commit/
bd52650a7ba05b16c5cabf37cb69511cbccc35b9
Jeremy Barton [Sat, 23 Feb 2019 02:37:22 +0000 (18:37 -0800)]
Add #define alias for local_X509_STORE_CTX_get0_store for RHEL6 build
Commit migrated from https://github.com/dotnet/corefx/commit/
eaafb6fd980f161c94c16b7036a73ed3df5871ae
Eric StJohn [Sat, 23 Feb 2019 02:20:16 +0000 (18:20 -0800)]
Make System.Runtime.CompilerServices.Unsafe inbox (dotnet/corefx#35526)
* Make System.Runtime.CompilerServices.Unsafe inbox
Fix a couple places where we wanted to use it from other inbox assemblies but couldn't.
Unsafe remains as a package and newer versions of Unsafe will replace the inbox Version,
permitting us to add API over time.
* Update Rune tests to use TryEncodeToUtf8Bytes directly
* Add temporary suppression to package tests
Commit migrated from https://github.com/dotnet/corefx/commit/
9074d9f5b513a95b7eac9ba1112069c29230d1d2
Santiago Fernandez Madero [Sat, 23 Feb 2019 01:00:31 +0000 (17:00 -0800)]
Disable azure pipelines reporter for official builds (dotnet/corefx#35540)
Commit migrated from https://github.com/dotnet/corefx/commit/
a41629b2604a9dc92305f4df067898a377f72b17
Matt Galbraith [Fri, 22 Feb 2019 22:20:15 +0000 (14:20 -0800)]
Merge pull request dotnet/corefx#35533 from dotnet/Add-Alpine-3-9
Adding Alpine 3.9 Runs to official
Commit migrated from https://github.com/dotnet/corefx/commit/
dc6dfe11752a00136df36b5c62f6b891322068e6
Matt Galbraith [Fri, 22 Feb 2019 22:07:50 +0000 (14:07 -0800)]
Adding Alpine 3.9 Runs to official
There may be a little more work to be done here for displaying what actually ran, but I believe we're ready to use the new Helix Client docker work.
Commit migrated from https://github.com/dotnet/corefx/commit/
eeaeb1a11f244dc13e827decd3ab0c810089f747
Jeremy Barton [Fri, 22 Feb 2019 20:51:22 +0000 (12:51 -0800)]
Add support for OCSP on Linux, overhaul Linux X509Chain processing
This change moves a lot of the chain building work from managed code into the native shim, largely to cut down on the number of P/Invokes required to set up the chain builder.
Once a chain has been built to a point where only one issuer will be considered, if revocation was requested and a CRL is not available, attempt an OCSP request if the certificate indicates the CA has an OCSP endpoint.
Based on CA/Browser Forum's requirements this expects CRL for all intermediates and only attempts OCSP for the end-entity certificate.
"Conforming" OCSP requests are opportunistically cached on the basis that local filesystem re-reads are more reliable (and faster) than doing a live request to the CA.
Commit migrated from https://github.com/dotnet/corefx/commit/
0fbbb68a3f7be82d26e4b2dff5c25c192e3a2023
Stephen Toub [Fri, 22 Feb 2019 18:51:14 +0000 (13:51 -0500)]
Avoid some 1st-chance exceptions on Linux in GetAllNetworkInterfaces (dotnet/corefx#35523)
Commit migrated from https://github.com/dotnet/corefx/commit/
cbf462058cf0aa96c171f84604e575be9f41830a
Marco Rossignoli [Fri, 22 Feb 2019 13:57:42 +0000 (14:57 +0100)]
Fix bug: Process.OutputDataReceived not firing (dotnet/corefx#33974)
* fix bug
* address PR feedback
* remove flaky assertions
* remove test for Uap
* update test
* nit: remove empty line
* add test to outerloop
* try deterministic test with fileSystem lock
* update test
* update test
* add cleanup to test
* update test
* update test comment
* refactor test
* address PR feedback
* address PR feedback
* Address PR feedback
* update tests
* try anonymous pipe
* remove FileSystemLock
* fix test
* try tu run on UAP
* try to run on UAP
* updates
* uap experiment
* uap experiment
* uap experiment
* remove uap from tests
* updates
* update tests
* fix test name
* avoid uap compile error
* apply Stephen steps
* Update ProcessStreamReadTests.cs
Add comment
* update comment
Commit migrated from https://github.com/dotnet/corefx/commit/
7817a109400b5b22c02ae6667706cda8a7f3d168
Jan Kotas [Fri, 22 Feb 2019 10:55:41 +0000 (02:55 -0800)]
Update Environment.Version test to not expect hardcoded version (dotnet/corefx#35512)
* Update Environment.Version test to not expect hardcoded version
Contributes to https://github.com/dotnet/corefx/issues/31099
* Fix nit
Commit migrated from https://github.com/dotnet/corefx/commit/
d8473a7bab7cb9b26344281913c488b7475644bb
Stephen Toub [Fri, 22 Feb 2019 03:16:04 +0000 (22:16 -0500)]
Use a pooled buffer in BrotliStream (dotnet/corefx#35492)
* Use a pooled buffer in BrotliStream
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
bca44089343cf14cffd3cb0982b7e209692f6731
David Fowler [Fri, 22 Feb 2019 03:15:41 +0000 (19:15 -0800)]
Reduce the amount of exceptions throw in Advance (dotnet/corefx#35509)
* Reduce the amount of exceptions throw in Advance
- Advance checks for 3 error conditions today, no writing head (no body called GetMemory()), bytesWritten being a positive number and that Advance is called with a bytesWritten between 0 and _writingMemory.Length. Instead, just unify those into a single ArgumentOutOfRangeException.
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
498a7e169a452d3e53a061c1433aea637506a14a
Santiago Fernandez Madero [Fri, 22 Feb 2019 02:32:07 +0000 (18:32 -0800)]
Restore optional tooling for windows to use optimization data (dotnet/corefx#35433)
Commit migrated from https://github.com/dotnet/corefx/commit/
c839a4d5b1cb8889e6251d47aed3fdfd098586ef
Stephen Toub [Fri, 22 Feb 2019 02:17:11 +0000 (21:17 -0500)]
Reduce PLINQ outerloop test execution time (dotnet/corefx#35510)
Our PLINQ test suite has a ridiculously large number of test cases, in particular in outerloop (~200K), and as such it takes a long time to run. In outerloop CI legs on some machines we're currently bumping up against time limits, causing spurious failures. While more may be needed, these two small tweaks shrink execution time on my machine by 50%.
Commit migrated from https://github.com/dotnet/corefx/commit/
bec9e1ec77306f339fd2b34d0e9b6013b5555c39
Jan Kotas [Fri, 22 Feb 2019 02:08:30 +0000 (18:08 -0800)]
Use the .NET Core product version for informational version description (dotnet/corefx#35436)
* Use the .NET Core product version for informational version description
The 4.X.Y.Z versions that we use for file and assembly versions are confusing. We can make the situation better by including the official .NET Core version in the informational assembly version description at least.
* Move ProductVersion to Versions.props
* Move Packaging.props to later
Commit migrated from https://github.com/dotnet/corefx/commit/
0577135efa86fec33f1cc9bb10808d31e302a94f
Mike McLaughlin [Fri, 22 Feb 2019 00:43:56 +0000 (16:43 -0800)]
Publish corefx test assets (dotnet/corefx#35473)
* Publish corefx test assets
So coreclr and other repos can run the corefx tests.
New step to publish the test zip files to dotnet-core blob storage.
Publishes the build manifest from above to blob storage path:
https://dotnetfeed.blob.core.windows.net/dotnet-core/corefx-tests/$(Version)/$(TargetOS).$(ArchGroup)/$(TargetGroup)/corefx-test-assets.xml
Declare DotNet-Blob-Feed only in official builds
* Code review feedback.
The blob path should NOT be Normalized.
* WIP
Commit migrated from https://github.com/dotnet/corefx/commit/
bfb495d39e2d7b5d7cc0b571ed504670b2faa68c
Geoff Kizer [Fri, 22 Feb 2019 00:03:00 +0000 (16:03 -0800)]
Merge pull request dotnet/corefx#35485 from geoffkizer/http2streamstate
add StreamState and rework HTTP2 stream state handling
Commit migrated from https://github.com/dotnet/corefx/commit/
cab8d6bbfe49c7571f682234622f4ea3bfcf5010
David Fowler [Thu, 21 Feb 2019 23:31:23 +0000 (15:31 -0800)]
Override WriteAsync on the DefaultPipeWriter (dotnet/corefx#35484)
- Today we're using an extension method on IBufferWrite<T> to implement
copying the input buffer to the underlying PipeWriter. Luckily this
method is virtual so we can optimize using the Pipe's internal structures
directly rather than going through GetMemory and Advance
Commit migrated from https://github.com/dotnet/corefx/commit/
a0bbeb7f2143a063eb5e944026787974362c8b3d
Tomas Weinfurt [Thu, 21 Feb 2019 23:01:02 +0000 (15:01 -0800)]
fix ping TTL option for OSX (dotnet/corefx#35506)
Commit migrated from https://github.com/dotnet/corefx/commit/
ecad65740b41b1502188ac6b412ade53fb54ba3e
Geoff Kizer [Thu, 21 Feb 2019 21:52:02 +0000 (13:52 -0800)]
address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
333fabaffeabf3b4de5d6ba45e54b2078f57adcf
ericstj [Thu, 21 Feb 2019 00:54:05 +0000 (16:54 -0800)]
Make restore of external 2-pass
Commit migrated from https://github.com/dotnet/corefx/commit/
c8e44c3d027d0539e7f9091336cc48e59e7d03e8
Eric St. John [Wed, 20 Feb 2019 00:35:49 +0000 (16:35 -0800)]
Restore IBC data and embed during Windows release builds
See the following docs.
https://github.com/dotnet/arcade/blob/dotnet/corefx@
bac85242024ba867b6204b90c1522793093f5e31/Documentation/ArcadeSdk.md#ibc-optimization-data-embedding
We are using IBC data produced by our perf team and embedding into all builds of a DLL;
currently we don't distinguish cross-compiles of the same DLL, nor does arcade define any
conventions to do so. I've disabled it for references and not-supported assemblies.
Commit migrated from https://github.com/dotnet/corefx/commit/
96661fad0e63a7869539fa0981c8b8be2f3824d3
Stephen Toub [Thu, 21 Feb 2019 17:16:35 +0000 (12:16 -0500)]
Disable two Socket.Begin/EndSendFile tests (dotnet/corefx#35494)
Commit migrated from https://github.com/dotnet/corefx/commit/
1c802d6d8c06b727c102c00e5eb4224de9608a16
Jan Kotas [Thu, 21 Feb 2019 17:15:56 +0000 (09:15 -0800)]
Omit Environment.Version from CodeDom generated files (dotnet/corefx#35458)
* Omit Environment.Version from CodeDom generated files
Contributes to https://github.com/dotnet/coreclr/pull/22664
* Disable tests on .NET Framework
Commit migrated from https://github.com/dotnet/corefx/commit/
89f72f6edb0d4ec18afa8e8138d1f12fdde09e5d
Stephen Toub [Thu, 21 Feb 2019 16:46:00 +0000 (11:46 -0500)]
Merge pull request dotnet/corefx#35489 from dotnet/darc-master-
f2564df9-8df7-4569-8e31-
4500b86d8bfa
[master] Update dependencies from dotnet/coreclr
Commit migrated from https://github.com/dotnet/corefx/commit/
3ec07dba620c98da2a53856ab756d9322972d953
Viktor Hofer [Thu, 21 Feb 2019 14:42:16 +0000 (15:42 +0100)]
Update publish.yml
Commit migrated from https://github.com/dotnet/corefx/commit/
4762671d7034adced7320f8e8f9b4f1d53c88450
Stephen Toub [Thu, 21 Feb 2019 14:30:40 +0000 (09:30 -0500)]
Fix ArgumentOutOfRangeException validation in GregorianCalendarTests.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
07116a67cacaa2965479429a1bfd19fb60fcd53f
Stephen Toub [Thu, 21 Feb 2019 14:27:43 +0000 (09:27 -0500)]
Merge branch 'master' into darc-master-
f2564df9-8df7-4569-8e31-
4500b86d8bfa
Commit migrated from https://github.com/dotnet/corefx/commit/
fb4bcafc113a208da4ba60b8f56bc58689d624b3
Viktor Hofer [Thu, 21 Feb 2019 14:18:47 +0000 (15:18 +0100)]
Add test targets to build script (dotnet/corefx#34385)
* Add test targets to build script
* Remove few manual copy targets in projects
* Remove PlatformAbstractions dependency
* Update ArchiveTests type to enum
* Set warnaserror false on arm/arm64
* Update docs
* Darc update from build '
20190221.4'
Commit migrated from https://github.com/dotnet/corefx/commit/
a619534cac9b7d000f0899248656d232cb44f61f
dotnet-maestro-bot [Thu, 21 Feb 2019 12:22:00 +0000 (04:22 -0800)]
Update CoreFxOptimizationData to master-
20190221.1 (dotnet/corefx#35482)
Commit migrated from https://github.com/dotnet/corefx/commit/
d86f48243bdd9ec9b187d6e142e209a0adccc761
Geoff Kizer [Wed, 20 Feb 2019 20:54:39 +0000 (12:54 -0800)]
add StreamState and rework HTTP2 stream state handling
cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
1eba83637d47fde09c8e1748b0ebb4ca42da5ca4
Santiago Fernandez Madero [Thu, 21 Feb 2019 02:41:48 +0000 (18:41 -0800)]
Remove unused upload-tests.proj (dotnet/corefx#35475)
Commit migrated from https://github.com/dotnet/corefx/commit/
8a9dd52ae5bab85ec3bd1d3cf73ba165668332f0
OmariO [Thu, 21 Feb 2019 02:25:20 +0000 (02:25 +0000)]
Improve BitArray's Get, Set, SetAll and Not methods performance (dotnet/corefx#35364)
* Improve BitArray's Get, Set, Set All and Not methods performance. The generated code is smaller and allows to use AggressiveInlining for Get and Set.
* Update BitArray.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
2b8e77e0b1e8699db7e3656a6ad86d181317a155
Filip Navara [Thu, 21 Feb 2019 02:23:41 +0000 (03:23 +0100)]
Move Thread to shared CoreLib (dotnet/corefx#35462)
Commit migrated from https://github.com/dotnet/corefx/commit/
694eeba312046e2097c731d40f32c1cac675aa03
Geoff Kizer [Thu, 21 Feb 2019 02:23:19 +0000 (18:23 -0800)]
don't dispose the HTTP2 connection writer lock, to avoid race (dotnet/corefx#35468)
* don't dispose the writer lock, to avoid race
* Update Http2Connection.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
c4c8f72cd8d18d6ec00afea6644ae2077d442869
Ahson Khan [Thu, 21 Feb 2019 00:29:57 +0000 (16:29 -0800)]
Update intellisense files for S.Mem, S.T.Json, S.Runtime based on (dotnet/corefx#35467)
02-14-2019 doc build.
Commit migrated from https://github.com/dotnet/corefx/commit/
84b4bed23b55d47adb8da0134dc6346b622ca8eb
Stephen Toub [Thu, 21 Feb 2019 00:24:39 +0000 (19:24 -0500)]
Factor IPAddress.Loopback.MapToIPv6() into IPAddress.IsLooback (dotnet/corefx#35463)
Simply change to check for IPAddress.Loopback.MapToIPv6() in addition to IPAddress.Loopback and IPAddress.IPv6Loopback in IPAddress.IsLoopback. Doing so caused a small regression in throughput for IPAddress.Equals, so I made a few other tweaks to avoid the regression.
Commit migrated from https://github.com/dotnet/corefx/commit/
a8945a36bb2d6068dc2e6b07573f0207e4eb8b85
Stephen Toub [Wed, 20 Feb 2019 23:55:04 +0000 (18:55 -0500)]
Fix xNodeBuilder test (again) (dotnet/corefx#35464)
They're failing on netfx after my previous test fix, because on netfx float.MaxValue.ToString() != float.MaxValue.ToString("R").
Commit migrated from https://github.com/dotnet/corefx/commit/
16e56860466ec2eb32f8544a5fb1b4b8aafadcf8
Stephen Toub [Wed, 20 Feb 2019 23:54:35 +0000 (18:54 -0500)]
Simplify ProcessorCount tests to fix sporadic failures (dotnet/corefx#35465)
We do complicated logic based on a variety of conditions to detect the processor count on Unix; trying to duplicate that logic in the test would essentially just be a copy and paste of the shipping code, which isn't particularly useful. Until we can do something better, I'm simplifying the tests to just check that we get a valid count out of ProcessorCount.
Commit migrated from https://github.com/dotnet/corefx/commit/
fc3a20282c73f2b4a5c582c0e3be441d7301b4d8
dotnet-maestro-bot [Wed, 20 Feb 2019 21:47:10 +0000 (13:47 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27421-00, beta-27421-00, respectively (dotnet/corefx#35461)
Commit migrated from https://github.com/dotnet/corefx/commit/
16ba574ccebea1175ff5b20139b76c4a68022856
Tom Deseyn [Wed, 20 Feb 2019 20:45:09 +0000 (21:45 +0100)]
Process.KillTree: Unix: don't throw for processes that have exited already (dotnet/corefx#35452)
Commit migrated from https://github.com/dotnet/corefx/commit/
ac3ccfe29a9ecb675e779c1548386ee050a072cd
Jeremy Barton [Wed, 20 Feb 2019 19:43:18 +0000 (11:43 -0800)]
Bump S.S.C.Pkcs AssemblyVersion Minor version (dotnet/corefx#35429)
* Bump S.S.C.Pkcs AssemblyVersion Minor version
New API was added for .NET Core 3.0, so the assembly minor needs to bump.
* Fix packaging validation errors
* Apply review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
b4f94abd2bc7c8f3167cd7301147a08cbf2ea3df
Stephen Toub [Wed, 20 Feb 2019 19:38:31 +0000 (14:38 -0500)]
Simplify ConnectHelper.ConnectAsync to just return Stream (dotnet/corefx#35411)
* Simplify ConnectHelper.ConnectAsync to just return Stream
SocketsHttpHandler's ConnectHelper.ConnectAsync currently returns a tuple of (Socket, Stream). We can instead just have it return the Stream and allow the call site to fish out the Socket from the Stream if it can. This is slightly more efficient memory-wise, in that the state machine involved will be smaller, but it also allows for a potential extensibility point that's simpler (abstracting out the ConnectAsync as a callback) and potentially allows us to in the future get a Socket in more cases, e.g. any connection helper handing back a NetworkStream.
Unfortunately, NetworkStream.Socket is protected rather than public. Until such time that there's a public property for this, there are two options here:
1. Use reflection to create a delegate we can then use to get at the property; "Socket" is part of the exposed surface area, so the only dependency here is on documented surface area.
2. Create a custom NetworkStream-derived type that exposes the protected as a public.
I started with (2), which works fine for our own internal needs currently, but shifted to (1), as it's more flexible.
* Don't use reflection
Commit migrated from https://github.com/dotnet/corefx/commit/
d9cdbc3cca0f75e5d7692f9ae03978dd0ed9b2e9
Stephen Toub [Wed, 20 Feb 2019 19:35:52 +0000 (14:35 -0500)]
Stop blocking thread pool threads in VirtualNetwork-based tests (dotnet/corefx#35453)
The SslStream tests and others use an internal VirtualNetwork helper. It's stream's ReadAsync method currently queues a work item to the thread pool that then blocks. This results in spurious failures and timeouts as all of the threads in the pool get blocked under load.
Commit migrated from https://github.com/dotnet/corefx/commit/
6b2628c69abaafda37dcd4fcb57e173a4f689e0c
Geoff Kizer [Wed, 20 Feb 2019 19:26:12 +0000 (11:26 -0800)]
Merge pull request dotnet/corefx#35432 from geoffkizer/windowupdatethreshold
defer sending WINDOW_UDPATE frames until a minimum threshold has been met
Commit migrated from https://github.com/dotnet/corefx/commit/
852602a3cebc2bfa14199cf6c39368bad1903c6c
Viktor Hofer [Wed, 20 Feb 2019 17:52:01 +0000 (18:52 +0100)]
Add net472 build3260 blobs (dotnet/corefx#35448)
Commit migrated from https://github.com/dotnet/corefx/commit/
b018ced265fe099679be0ec1e7afa805a154d49a
Konstantin Baladurin [Wed, 20 Feb 2019 16:53:12 +0000 (19:53 +0300)]
Fix tizen rootfs building (dotnet/corefx#35450)
Move tizen-release package from base to unified repo
Commit migrated from https://github.com/dotnet/corefx/commit/
17344dbf36ab683804eb69a173f61c66de1a605d
dotnet-maestro-bot [Wed, 20 Feb 2019 15:38:19 +0000 (07:38 -0800)]
Update CoreFxOptimizationData, ProjectNTfs, ProjectNTfsTestILC to master-
20190220.1, beta-27420-00, beta-27420-00, respectively (dotnet/corefx#35440)
Commit migrated from https://github.com/dotnet/corefx/commit/
c71537350eeb786e80326473bfa5d7fcab172988
David Fowler [Wed, 20 Feb 2019 11:56:06 +0000 (03:56 -0800)]
Added some doc comments to AsStream (dotnet/corefx#35442)
Commit migrated from https://github.com/dotnet/corefx/commit/
817d0557250ba0ea57f3aeba10934e1188fc0e88
Viktor Hofer [Wed, 20 Feb 2019 09:16:12 +0000 (10:16 +0100)]
Merge pull request dotnet/corefx#35415 from ViktorHofer/UWP-CI
Reenable UWP CI legs and upgrade to RS5
Commit migrated from https://github.com/dotnet/corefx/commit/
5385874fa7ab20f9e33997ebd20f31ae272bf7c5
Geoff Kizer [Wed, 20 Feb 2019 03:54:30 +0000 (19:54 -0800)]
PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
8b4d2f58cd89efbe0d0b2a487d5ce96353c83150
dotnet-maestro-bot [Wed, 20 Feb 2019 01:50:37 +0000 (17:50 -0800)]
Update CoreFxOptimizationData to master-
20190219.1 (dotnet/corefx#35431)
Commit migrated from https://github.com/dotnet/corefx/commit/
a92b750a5edd4d262422e16260c4223ef7771c39
Max Kerr [Wed, 20 Feb 2019 01:29:37 +0000 (17:29 -0800)]
Disallow dangerous Unicode decompositions (dotnet/corefx#35428)
* Merged PR 159084: [2.2 Servicing] MSRC 47421: Disallow dangerous Unicode decompositions in System.Uri
This is a direct port of PR 158405.
This change blocks any Unicode decompositions that change the semantics of a URI. See the comments included in the change for more details.
Unlike the netfx implementation of this change, there is no mechanism for users to disable the fix. I believe that this is the correct choice for two reasons:
(1) Domain name registrars have disallowed these characters for almost as long as they have allowed punycode, so it's unlikely there are legitimate domains using them.
(2) The consequences of disabling the fix are significant, and are likely non-obvious to most users.
* Temporarily disable test on netfx
* Add a note on why the test is disabled on netfx.
Commit migrated from https://github.com/dotnet/corefx/commit/
b8654425442fef4ba4b58510be53d9859887be1a
Stephen Toub [Wed, 20 Feb 2019 01:27:49 +0000 (20:27 -0500)]
Make Http2Connection.SendFrameAsync return ValueTask (dotnet/corefx#35426)
This method frequently completes synchronously, and in such cases we can avoid the task allocation.
Commit migrated from https://github.com/dotnet/corefx/commit/
52993e52f9d3ab30da54884f7c5e0cdea2518e28
Alaa Masoud [Wed, 20 Feb 2019 01:04:45 +0000 (04:04 +0300)]
Remove dead code (dotnet/corefx#35430)
Commit migrated from https://github.com/dotnet/corefx/commit/
000aa2e0740524bdc2db690201e1b3521dd417a3
Geoff Kizer [Tue, 19 Feb 2019 09:43:27 +0000 (01:43 -0800)]
defer sending WINDOW_UDPATE frames until a minimum threshold has been met
Commit migrated from https://github.com/dotnet/corefx/commit/
99f8d99738f78b6791e2b30b9fababa9f8daa643
David Shulman [Tue, 19 Feb 2019 22:33:43 +0000 (14:33 -0800)]
Improve HTTP2 connection diagnostics in SocketsHttpHandler (dotnet/corefx#35423)
Modified the top-level exception being returned (HttpRequestException) to always include
the inner exception.
Contributes to dotnet/corefx#35422
Commit migrated from https://github.com/dotnet/corefx/commit/
fcf46bea903c78accd9586fa2fb355ade70c485e
David Fowler [Tue, 19 Feb 2019 22:24:50 +0000 (14:24 -0800)]
Added AsStream to PipeReader and PipeWriter (dotnet/corefx#35399)
- This adds a new virtual member to PipeReader and PipeWriter to get a read only or write only stream from the PipeReader and PipeWriter
- This introduces a new field on the base types
- Added tests
Commit migrated from https://github.com/dotnet/corefx/commit/
968a6a4450ca5acd3aed6a6f6e1f8b445348e729
Matt Mitchell [Tue, 19 Feb 2019 18:29:21 +0000 (10:29 -0800)]
Use SourceBranch vs. SourceBranchName (dotnet/corefx#35413)
* Use SourceBranch vs. SourceBranchName
SourceBranchName only evaluates to the last path name of the branch:
- 3.0 in release/3.0
We want the full branch, with refs/heads for consistency with the rest of the repos
Commit migrated from https://github.com/dotnet/corefx/commit/
36167bc544b968ed0bd67915f6512043a07734e0
Alaa Masoud [Tue, 19 Feb 2019 17:54:29 +0000 (20:54 +0300)]
Remove dead code (dotnet/corefx#35405)
Commit migrated from https://github.com/dotnet/corefx/commit/
9ccba7612721c347c8373cd4d226b1ac1329a73f
Viktor [Tue, 19 Feb 2019 17:20:35 +0000 (18:20 +0100)]
Upgrade uwp windows machines to RS5
Commit migrated from https://github.com/dotnet/corefx/commit/
56ad4b45a23b13f289fb9145c6eb5dca1969a1cc
Viktor [Tue, 19 Feb 2019 17:18:06 +0000 (18:18 +0100)]
Revert "Don't run tests on uap PR leg"
This reverts commit dotnet/corefx@
c34a9be660974ca1461a5f87d99e6750ae8dcb6b.
Commit migrated from https://github.com/dotnet/corefx/commit/
e8d186bc8eff2878ebe4a129cfba61a23343b516
David Shulman [Tue, 19 Feb 2019 17:14:44 +0000 (09:14 -0800)]
Fix Negotiate/SPNEGO Kerberos to NTLM fallback on Linux (dotnet/corefx#35383)
This PR adds support to our Linux gssapi layer so that we properly handle the Negotiate
protocol (SPNEGO) being able to to fall back from Kerberos to NTLM.
Windows Negotiate SSPI implements the SPNEGO protocol. However, it has built-in error
handling for dealing with quick fallback from Kerberos to NTLM in error cases such as where
the client is not on a domain/Kerberos realm, the client is using a local credential, the
client is talking to a non-domain server, etc.
However, the Linux implementation of SPNEGO doesn't handle those error cases very well.
So, I added the proper retry logic when generating the initial context token. Now, we will
be able to fall back from SPNEGO-wrapped Kerberos to SPNEGO-wrapped NTLM protocol blobs.
A similar bug exists in libcurl which is why Curl and CurlHandler are unable to connect to
Negotiate servers when not part of the Kerberos realm. I am considering proposing my fixes
to the libcurl repo as well.
I added more tests to support this PR and did manual testing. I added some additional
EventSource tracing as well.
Contributes to dotnet/corefx#34878
Commit migrated from https://github.com/dotnet/corefx/commit/
1fd3ba126538c2fed76d2279db26dc7ba5ceed41
Jan Kotas [Tue, 19 Feb 2019 16:18:53 +0000 (08:18 -0800)]
Fix product name included in the binaries (dotnet/corefx#35408)
Commit migrated from https://github.com/dotnet/corefx/commit/
6999d5e9809c22be73b71ab1f16d83721cc245e4
dotnet-maestro-bot [Tue, 19 Feb 2019 15:07:11 +0000 (07:07 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27419-00, beta-27419-00, respectively (dotnet/corefx#35402)
Commit migrated from https://github.com/dotnet/corefx/commit/
d9e276e451a8f4dded8272822d13001555a28ff3
Stephen Toub [Tue, 19 Feb 2019 05:38:07 +0000 (00:38 -0500)]
Use Environment.TickCount instead of DateTime{Offset}.UtcNow in SocketsHttpHandler (dotnet/corefx#35401)
We don't need the accuracy of UtcNow nor the absolute time when getting a time stamp in order to determine whether a connection should be retired; rather, we only need an approximate difference in time. This means the resolution of TickCount is fine, and the worst that happens if a connection happens to be alive for more than its ~49 day period is we may allow the connection to then live even longer than we otherwise would. In exchange, we get a much cheaper mechanism (~20x on Windows) mechanism for computing the connection age.
Commit migrated from https://github.com/dotnet/corefx/commit/
dca39727b02ceb4413d0fde11467965099ab4a2f
Viktor Hofer [Tue, 19 Feb 2019 02:40:02 +0000 (03:40 +0100)]
Remove old TestCategories property (dotnet/corefx#35397)
Commit migrated from https://github.com/dotnet/corefx/commit/
18452453fe8de55a065841798eb5e7a56c3436cb
Alaa Masoud [Tue, 19 Feb 2019 02:39:38 +0000 (05:39 +0300)]
Remove dead code in IpHlpApi (dotnet/corefx#35398)
Commit migrated from https://github.com/dotnet/corefx/commit/
24b8e537c4e880942bae2fbfe87d78c19ca60d44
Grant [Mon, 18 Feb 2019 19:40:46 +0000 (11:40 -0800)]
Unit tests for BitOps (dotnet/corefx#35193)
Commit migrated from https://github.com/dotnet/corefx/commit/
23f36ed60cd5afa6bafd4ed8e976f37fc2b07613
dotnet-maestro-bot [Mon, 18 Feb 2019 08:22:18 +0000 (00:22 -0800)]
Update ProjectNTfs, ProjectNTfsTestILC to beta-27418-00, beta-27418-00, respectively (dotnet/corefx#35389)
Commit migrated from https://github.com/dotnet/corefx/commit/
638ddfb1c6e625e5a702600c8d42bc6e254e2eb5
Ben Adams [Sun, 17 Feb 2019 15:40:48 +0000 (15:40 +0000)]
Skip lock in GetMemory/GetSpan if memory available (dotnet/corefx#35234)
Commit migrated from https://github.com/dotnet/corefx/commit/
c8f93fdd5e5f32ba854782714531af6737e5e26c
Francis Nguyen [Sun, 17 Feb 2019 11:45:20 +0000 (04:45 -0700)]
Collections cleanup (dotnet/corefx#35339)
* Removed dead strings for System.Collection.NonGeneric (dotnet/corefx#17905)
* Removed dead private ctor for LinkedList<T>.Enumerator
Commit migrated from https://github.com/dotnet/corefx/commit/
2086662ac52143972fdde887be506485115db503
Vladimir Sadov [Sun, 17 Feb 2019 05:15:33 +0000 (21:15 -0800)]
Merge pull request dotnet/corefx#35373 from VSadov/SslTestTimeout
Updating timeout in `SslStream_SameCertUsedForClientAndServer_Ok` test
Commit migrated from https://github.com/dotnet/corefx/commit/
7fe70b715c8535145c8aa7a39af7b507e005443a
Vladimir Sadov [Sun, 17 Feb 2019 00:10:44 +0000 (16:10 -0800)]
Updating timeout in `SslStream_SameCertUsedForClientAndServer_Ok` to match the rest of the tests in the area.
All other passing tests standardise on `TestConfiguration.PassingTestTimeoutMilliseconds`
There seems to be no reasons for SslStream_SameCertUsedForClientAndServer_Ok` to use a hardcoded timeout.
Also the hardcoded timeout is significantly shorter and occasionally leads to failures on low-spec test VMs.
Commit migrated from https://github.com/dotnet/corefx/commit/
8919cbdd960f41ba2f87c210d5f85d0d8a3c1276
Stephen Toub [Fri, 15 Feb 2019 23:13:47 +0000 (18:13 -0500)]
Merge pull request dotnet/corefx#35324 from stephentoub/http2allocs
Remove more Http2Connection/Stream allocations
Commit migrated from https://github.com/dotnet/corefx/commit/
55f7269536eb9c072cabd8bbcdd7644cd18bd001
dotnet-maestro-bot [Fri, 15 Feb 2019 20:40:25 +0000 (12:40 -0800)]
Update BuildTools, ProjectNTfs, ProjectNTfsTestILC to preview1-03715-01, beta-27415-00, beta-27415-00, respectively (dotnet/corefx#35353)
Commit migrated from https://github.com/dotnet/corefx/commit/
f40cb8ea05d8b1f3d9acdcd8cf257c764ef56693
Stephen Toub [Fri, 15 Feb 2019 16:40:17 +0000 (11:40 -0500)]
Address PR feedback and additional cleanup
Commit migrated from https://github.com/dotnet/corefx/commit/
c0f24cf4136f22e508e1b9289062e541bad6af88
Santiago Fernandez Madero [Fri, 15 Feb 2019 20:16:34 +0000 (14:16 -0600)]
Remove groovy and json files for unused pipelines (dotnet/corefx#35355)
Commit migrated from https://github.com/dotnet/corefx/commit/
babb33b15afe35d5ce8dd06d9f2f6f16ea4b71be
Stephen Toub [Fri, 15 Feb 2019 19:17:55 +0000 (14:17 -0500)]
Fix some XML comments in Base64Encoder/Decoder (dotnet/corefx#35354)
* Fix some XML comments in Base64Encoder/Decoder
* Update Base64Encoder.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
ec34e99b876ea1119f37986ead894f4eded1a19a
Stephen Toub [Fri, 15 Feb 2019 02:43:21 +0000 (21:43 -0500)]
Remove uap config from System.Net.Http UnitTests
These tests are compiling in internal sources and running tests against them directly. The only configuration we need is netcoreapp.
Commit migrated from https://github.com/dotnet/corefx/commit/
f9d1057321c17d8692e829b311c925660e23f8db
Stephen Toub [Fri, 15 Feb 2019 02:20:59 +0000 (21:20 -0500)]
Use StaticTable for writing known headers
Commit migrated from https://github.com/dotnet/corefx/commit/
65a101d6968bac28f343ed2e352cf54f8e122f21
Geoff Kizer [Thu, 14 Feb 2019 22:26:49 +0000 (17:26 -0500)]
Implement static table for writing some headers
Commit migrated from https://github.com/dotnet/corefx/commit/
1b0b62a3a6fa0ea0fa301b0bac9b9c350ad6c14c
Stephen Toub [Thu, 14 Feb 2019 22:23:12 +0000 (17:23 -0500)]
Don't pool Http2Connection buffers
Http2Connection keeps these buffers for a really long time; we don't want it to starve the pool. It also leads to lifetime issues, as the buffers need to be (but currently aren't) released back to the pool, yet work can end up accessing the ArrayBuffer after the connection is logically disposed.
Commit migrated from https://github.com/dotnet/corefx/commit/
847f64fa812362e75dfcbd0bdcf41541921d607c
Stephen Toub [Thu, 14 Feb 2019 17:55:31 +0000 (12:55 -0500)]
Avoid per-request HeaderCallback delegate allocation
Commit migrated from https://github.com/dotnet/corefx/commit/
14ef1be63af22bc610223eab337bdab99e6af4a8
Stephen Toub [Thu, 14 Feb 2019 18:04:03 +0000 (13:04 -0500)]
Avoid lock object allocation in CreditManager
Commit migrated from https://github.com/dotnet/corefx/commit/
701102c5c0282b3d29edc76aca12d985af8ff70f
Stephen Toub [Thu, 14 Feb 2019 02:55:46 +0000 (21:55 -0500)]
Avoid syncobj object allocation in Http2Connection
Just use one of the other readonly objects.
Commit migrated from https://github.com/dotnet/corefx/commit/
d74108c671abffa3d314b011b7269806eedb7df7
Santiago Fernandez Madero [Fri, 15 Feb 2019 17:37:04 +0000 (11:37 -0600)]
Disable jenkins legs as we transition to use azure devops. (dotnet/corefx#35326)
* Disable jenkins legs to transition to azure devops
* Don't run tests on uap PR leg
Commit migrated from https://github.com/dotnet/corefx/commit/
af90ef6e49e766f8062eca740b4b3d03cf2745b5