Armin Novak [Fri, 11 May 2018 09:00:01 +0000 (11:00 +0200)]
Fixed compiler warnings (unused)
Armin Novak [Fri, 11 May 2018 08:37:50 +0000 (10:37 +0200)]
VS2017 support: set pdb output directory for Ninja generator.
Martin Fleisz [Fri, 4 May 2018 11:28:18 +0000 (13:28 +0200)]
Merge pull request #4610 from akallabeth/cmd_strtol_fix
Fix #4597: Do string argument checks before a possible strtol
Martin Fleisz [Fri, 4 May 2018 11:08:45 +0000 (13:08 +0200)]
Merge pull request #4623 from akallabeth/mac_sound_backend_fix
Fixed mac sound backend initialization.
Martin Fleisz [Fri, 4 May 2018 11:07:01 +0000 (13:07 +0200)]
Merge pull request #4627 from akallabeth/clang_warning_fixes
Clang warning fixes
Armin Novak [Fri, 4 May 2018 10:36:29 +0000 (12:36 +0200)]
Fixed uninitialized return and early resource cleanup.
Armin Novak [Fri, 4 May 2018 10:36:18 +0000 (12:36 +0200)]
Fixed uninitialized value.
Armin Novak [Fri, 4 May 2018 10:35:51 +0000 (12:35 +0200)]
Fixed missing NULL pointer checks.
Martin Fleisz [Fri, 4 May 2018 09:59:21 +0000 (11:59 +0200)]
Merge pull request #4624 from akallabeth/pth_fix
Fixed /pth: Consistently treat the hash offset to password length.
Armin Novak [Fri, 4 May 2018 07:54:49 +0000 (09:54 +0200)]
Do not set password to identity if pth is used.
Martin Fleisz [Fri, 4 May 2018 08:06:42 +0000 (10:06 +0200)]
Merge pull request #4611 from akallabeth/argument_warnings
Argument warnings
akallabeth [Fri, 4 May 2018 08:04:37 +0000 (10:04 +0200)]
Merge pull request #4625 from dualmoon/fix-hisher-pronouns
First person "they" pronouns in logoff message
Armin Novak [Fri, 4 May 2018 07:44:06 +0000 (09:44 +0200)]
Fixed formats supported by backend.
Armin Novak [Fri, 4 May 2018 07:10:31 +0000 (09:10 +0200)]
Added error log messages.
Ashley Davis [Thu, 3 May 2018 16:11:13 +0000 (12:11 -0400)]
First person "they" pronouns in logoff message
Armin Novak [Thu, 3 May 2018 15:49:14 +0000 (17:49 +0200)]
Fixed /pth: Consistently treat the hash offset to password length.
Armin Novak [Thu, 3 May 2018 14:12:12 +0000 (16:12 +0200)]
Fixed mac sound backend initialization.
Martin Fleisz [Thu, 3 May 2018 11:35:20 +0000 (13:35 +0200)]
Merge pull request #4620 from akallabeth/bio_ctrl_fix
Bio ctrl fix
Armin Novak [Thu, 3 May 2018 10:25:52 +0000 (12:25 +0200)]
Fixed formatting.
Armin Novak [Thu, 3 May 2018 10:24:16 +0000 (12:24 +0200)]
Fixed #4476: broken casts/variable sizes for custom BIO calls.
David Fort [Thu, 3 May 2018 09:56:58 +0000 (11:56 +0200)]
Merge pull request #4453 from akallabeth/sound_channel_refactor
Sound channel refactoring
akallabeth [Thu, 3 May 2018 09:55:03 +0000 (11:55 +0200)]
Merge pull request #4617 from kevans91/spurious
Upstream the rest of our local FreeBSD patching
akallabeth [Thu, 3 May 2018 09:31:54 +0000 (11:31 +0200)]
Merge pull request #4613 from kevans91/file64
Enable 64-bit file support on FreeBSD as well
akallabeth [Thu, 3 May 2018 08:56:04 +0000 (10:56 +0200)]
Merge pull request #4616 from kevans91/timerfd-nonblock
Pass TFD_NONBLOCK to timerfd_create to avoid later fcntl
Martin Fleisz [Thu, 3 May 2018 08:23:12 +0000 (10:23 +0200)]
Merge pull request #4596 from p-pautov/rdg_ssl_fixes
RDG related fixes for better compatibility with mstsc
Armin Novak [Thu, 3 May 2018 08:08:56 +0000 (10:08 +0200)]
Fixed treat_wave sample length and checks.
akallabeth [Thu, 3 May 2018 07:49:31 +0000 (09:49 +0200)]
Merge pull request #4614 from kevans91/cmakemod
Abstract away CMake module installation setting, install differently on FreeBSD
akallabeth [Thu, 3 May 2018 06:55:23 +0000 (08:55 +0200)]
Merge pull request #4618 from kevans91/buildtest
Pull in the libepoll-shim includes for libwinpr's synch/test
Kyle Evans [Thu, 3 May 2018 04:19:44 +0000 (23:19 -0500)]
Pull in the libepoll-shim includes for libwinpr's synch/test
This allows FreeBSD to successfully build with BUILD_TESTING enabled. Currently,
only 3/184 tests fail:
13 - TestLibraryLoadLibrary (Failed)
14 - TestLibraryGetProcAddress (Failed)
15 - TestLibraryGetModuleFileName (Failed)
These failures are probably due to a lack of GetModuleFileNameA implementation
on FreeBSD.
Kyle Evans [Wed, 2 May 2018 15:57:16 +0000 (10:57 -0500)]
Upstream the rest of our local FreeBSD patching
FreeBSD/DragonflyBSD are also UNIX platforms, as far as trio is concerned, and
we don't need to be setting the CMAKE_INSTALL_RPATH on FreeBSD.
Kyle Evans [Thu, 3 May 2018 02:03:49 +0000 (21:03 -0500)]
Pass TFD_NONBLOCK to timerfd_create to avoid later fcntl
akallabeth [Wed, 2 May 2018 15:59:10 +0000 (17:59 +0200)]
Merge pull request #4576 from ccpp/bugfix-rdg-poll
Fix polling in RDG
akallabeth [Wed, 2 May 2018 15:54:57 +0000 (17:54 +0200)]
Merge pull request #4612 from kevans91/mandest
Follow OpenBSD convention when installing manpages on FreeBSD
Kyle Evans [Wed, 2 May 2018 14:59:33 +0000 (09:59 -0500)]
Enable 64-bit file support on FreeBSD as well
Kyle Evans [Wed, 2 May 2018 15:03:53 +0000 (10:03 -0500)]
Use SetFreeRDPCMakeInstallDir where CMake modules are installed
Kyle Evans [Wed, 2 May 2018 15:32:26 +0000 (10:32 -0500)]
Add SetFreeRDPCMakeInstallDir function to abstract away platform differences
Different platforms/systems may install CMake modules into different places. For
instance, FreeBSD will install modules into ${PREFIX}/share/cmake/Modules while
Linux distributions might install into ${PREFIX}/lib/cmake.
This leaves us with a useful abstraction- consumers only need to care about
the name of their subdirectory, and only one place needs to be patched to change
where this subdirectory lands.
Kyle Evans [Wed, 2 May 2018 14:31:19 +0000 (09:31 -0500)]
Follow OpenBSD convention when installing manpages on FreeBSD
Both OS install third party man pages into ${PREFIX}/man/man${SECTION}, rather
than the convention established in the base system of share/man/man${SECTION}.
Armin Novak [Wed, 2 May 2018 11:08:30 +0000 (13:08 +0200)]
Fixed invalid argument parameter
Armin Novak [Wed, 2 May 2018 11:08:17 +0000 (13:08 +0200)]
Fixed argument warning.
Armin Novak [Wed, 2 May 2018 10:57:34 +0000 (12:57 +0200)]
Fix #4597: Do string argument checks before a possible strtol
strtol sets errno, which must be reset if it is no abort condition.
Invert the comparisons to avoid that.
Martin Fleisz [Wed, 2 May 2018 10:11:24 +0000 (12:11 +0200)]
Merge pull request #4608 from akallabeth/posix_timer_cmake_check
Determine posix timer use by function availability
David Fort [Wed, 2 May 2018 10:09:55 +0000 (12:09 +0200)]
Merge pull request #4570 from akallabeth/toolchain_fix
android Toolchain fix
Martin Fleisz [Wed, 2 May 2018 09:26:13 +0000 (11:26 +0200)]
Merge pull request #4603 from hardening/socksplus
SOCKS5 proxy support
Armin Novak [Wed, 2 May 2018 06:40:30 +0000 (08:40 +0200)]
Determine posix timer availability by function availability
To avoid having to whitelist every os starting to implement posix
timer API just detect if the functions are available.
David Fort [Sun, 29 Apr 2018 19:25:28 +0000 (21:25 +0200)]
proxy: cleanup SOCKS support and add user/password support
David Fort [Wed, 2 May 2018 08:39:22 +0000 (10:39 +0200)]
Merge pull request #4606 from kevans91/libressl-fixes
Pull in the LibreSSL compatibility patches from FreeBSD
Martin Fleisz [Wed, 2 May 2018 08:10:55 +0000 (10:10 +0200)]
Merge pull request #4609 from akallabeth/clipboard_return_check
Added proper return value checks for clipboard data.
David Fort [Wed, 2 May 2018 07:47:17 +0000 (09:47 +0200)]
Merge pull request #4607 from kevans91/epoll
FreeBSD: epoll/timerfd support
Jiri Sasek [Mon, 23 Apr 2018 18:30:08 +0000 (20:30 +0200)]
socks proxy reply fix
Armin Novak [Wed, 2 May 2018 07:21:42 +0000 (09:21 +0200)]
Added proper return value checks for clipboard data.
Kyle Evans [Wed, 2 May 2018 04:50:15 +0000 (23:50 -0500)]
Use shared memory instead of temp files on FreeBSD-compatible OS
Kyle Evans [Wed, 2 May 2018 04:42:25 +0000 (23:42 -0500)]
Pull in libepoll-shim for the bits that require timerfd/epoll
libepoll-shim is our implementation of this API on top of kevent. It supplies
the same headers and a library, but we don't install it in any of the default
include search paths when it comes in through ports on an as-needed basis.
This set of changes is restricted to FREEBSD-compatible OS, which includes
DragonflyBSD and FreeBSD.
Kyle Evans [Wed, 2 May 2018 04:38:48 +0000 (23:38 -0500)]
Set BSD/FREEBSD for DragonflyBSD
DragonflyBSD was a fork of FreeBSD once upon a time. As far as FreeRDP is
concerned, DragonflyBSD is FreeBSD-compatible and DragonflyBSD in-fact uses
the FreeBSD ports tree (+ patches)
Kyle Evans [Tue, 1 May 2018 13:43:36 +0000 (08:43 -0500)]
Pull in the LibreSSL compatibility patches from FreeBSD
Armin Novak [Fri, 27 Apr 2018 09:28:37 +0000 (11:28 +0200)]
Added libavcodec version check for dsp-ffmpeg component.
Abort compilation with a specific error if the libavcodec module
detected is too old.
David Fort [Fri, 27 Apr 2018 07:39:30 +0000 (09:39 +0200)]
Merge pull request #4548 from akallabeth/autoreconnect_fix
Autoreconnect fix
David Fort [Thu, 26 Apr 2018 09:59:15 +0000 (11:59 +0200)]
Merge pull request #4589 from oshogbo/token
Recognize only the cookie format anything else treat as token.
p-pautov [Thu, 26 Apr 2018 09:11:04 +0000 (02:11 -0700)]
Fix Windows build.
Pavel Pautov [Wed, 18 Apr 2018 00:05:20 +0000 (17:05 -0700)]
Fallback to RDG RPC transport only if server does not support RDG HTTP and
error out in other cases - invalid RDG SSL cert, bad credentials, PAA failue, etc.
Pavel Pautov [Mon, 16 Apr 2018 21:23:13 +0000 (14:23 -0700)]
Remove some unused functions.
Pavel Pautov [Thu, 12 Apr 2018 20:05:04 +0000 (13:05 -0700)]
Apply "authentication level" RDP property only to non-RDG connections (as mstsc does).
Pavel Pautov [Thu, 12 Apr 2018 03:02:44 +0000 (20:02 -0700)]
Don't use CertificateName setting for RDG connections.
akallabeth [Wed, 25 Apr 2018 07:00:52 +0000 (09:00 +0200)]
Merge pull request #4586 from Awingu/cbytes-fix
Fix inconsistent cchReaderLen value between WinScard and pcsc-lite.
akallabeth [Wed, 25 Apr 2018 06:54:59 +0000 (08:54 +0200)]
Merge pull request #4588 from oshogbo/tokencookie
Fix comments where is cookie and where is token.
Christian Plattner [Tue, 24 Apr 2018 18:45:52 +0000 (20:45 +0200)]
Fail on unimplemented BIO_ctrl for /gt:rpc
Christian Plattner [Tue, 24 Apr 2018 14:35:04 +0000 (16:35 +0200)]
Implement BIO_ctrl more correctly for RDG
See #3602
This change is discussed in https://github.com/FreeRDP/FreeRDP/pull/4576#pullrequestreview-
113381733
Christian Plattner [Tue, 24 Apr 2018 14:20:42 +0000 (16:20 +0200)]
Revert useless part of the bugfix
This reverts commit
589d2ec62a6efc3af18b628c5f545c73c90dd331.
https://github.com/FreeRDP/FreeRDP/pull/4576#pullrequestreview-
113378805
Mariusz Zaborski [Tue, 24 Apr 2018 13:00:00 +0000 (15:00 +0200)]
Recognize only the cookie format anything else treat as token.
If in the RDP file we will set loadbalanceinfo.
Instead of getting the cookie value we will get load balance info.
For example:
0000 03 00 00 2a 25 e0 00 00 00 00 00 74 73 76 3a 2f ...*%......tsv:/
0010 2f 56 4d 52 65 73 6f 75 72 63 65 2e 31 2e 41 48 /VMResource.1.AH
0020 0d 0a 01 00 08 00 0b 00 00 00 ..........
The MSFT-SDLBTS document don't describe this behavior.
For this reason lets treat the token as anything ended with seqance
CR and CL. To be honest we already did that because in the core/connection.c
file where we are seting the routing_token to the LoadBalanceInfo.
Mariusz Zaborski [Tue, 24 Apr 2018 12:34:45 +0000 (14:34 +0200)]
Fix comments where is cookie and where is token.
Ruben De Visscher [Tue, 24 Apr 2018 08:33:44 +0000 (10:33 +0200)]
Fix inconsistent cBytes value between WinScard and pcsc-lite.
Jiri Sasek [Fri, 18 Aug 2017 17:17:17 +0000 (19:17 +0200)]
SOCKS proxy support
Martin Fleisz [Thu, 19 Apr 2018 09:04:08 +0000 (11:04 +0200)]
Merge pull request #4539 from p-pautov/rdg_fixes
RDG HTTP transport fixes and refactoring
Christian Plattner [Wed, 18 Apr 2018 19:50:47 +0000 (21:50 +0200)]
Fix BIO_get_fd for RDG, again.
Martin Fleisz [Wed, 18 Apr 2018 12:50:31 +0000 (14:50 +0200)]
Merge pull request #4543 from oshogbo/master
Fix variable passsed to HashCallback with MIC.
Christian Plattner [Wed, 18 Apr 2018 08:47:06 +0000 (10:47 +0200)]
Fix #3602 by implementing BIO_get_fd correctly for RDG
Christian Plattner [Wed, 18 Apr 2018 08:38:42 +0000 (10:38 +0200)]
Fix timeout for polling (partly fixes #3602)
Mariusz Zaborski [Tue, 17 Apr 2018 13:03:27 +0000 (15:03 +0200)]
Remove MessageIntegrityCheck from context.
akallabeth [Tue, 17 Apr 2018 08:51:49 +0000 (10:51 +0200)]
Merge pull request #4572 from weberhofer/patch-1
Include geometry.h in video channel
Johannes Weberhofer [Tue, 17 Apr 2018 06:20:54 +0000 (08:20 +0200)]
Include geometry.h in video channel
Fix for #4562
Pavel Pautov [Thu, 5 Apr 2018 20:12:20 +0000 (13:12 -0700)]
Avoid buffer to struct cast.
Pavel Pautov [Thu, 5 Apr 2018 02:08:26 +0000 (19:08 -0700)]
Send correct packet size in case of PAA. Some cleanup.
Pavel Pautov [Thu, 5 Apr 2018 02:08:20 +0000 (19:08 -0700)]
Content-Length and Transfer-Encoding are mutually exclusive.
Pavel Pautov [Thu, 5 Apr 2018 02:08:08 +0000 (19:08 -0700)]
Consolidate IN/OUT data connections establishment into common function and clean up related code.
Pavel Pautov [Thu, 5 Apr 2018 02:08:00 +0000 (19:08 -0700)]
Move NTLM auth related code into dedicated functions.
Pavel Pautov [Thu, 5 Apr 2018 02:07:52 +0000 (19:07 -0700)]
Consolidate rdg_tls_out_connect/rdg_tls_in_connect into single function. This also fixes connections to RDG server via proxy.
Pavel Pautov [Thu, 5 Apr 2018 02:07:33 +0000 (19:07 -0700)]
Removed unused "readEvent" - no one checks if it was set.
Removed needless rdg_check_event_handles declaration.
Pavel Pautov [Thu, 5 Apr 2018 02:07:25 +0000 (19:07 -0700)]
Consolidate rdg_send_in_channel_request/rdg_send_out_channel_request into single function.
Pavel Pautov [Thu, 5 Apr 2018 02:07:11 +0000 (19:07 -0700)]
Explicitly skip "seed" payload on RDG OUT connection, to avoid issues when it's split over several SSL records.
Pavel Pautov [Thu, 5 Apr 2018 02:06:59 +0000 (19:06 -0700)]
Moved some repeated "read all" code into function.
Armin Novak [Mon, 16 Apr 2018 14:45:00 +0000 (16:45 +0200)]
Fixed redirection with session brokers.
* Only reconnect channels on redirect, if they have already been connected.
* Prefer TargetNetAddress over FQDN to connect.
Armin Novak [Mon, 16 Apr 2018 09:39:36 +0000 (11:39 +0200)]
Add default values for keystore variables.
Armin Novak [Mon, 16 Apr 2018 08:22:24 +0000 (10:22 +0200)]
Ensure audin channel uses supported protocol version 1.
David Fort [Mon, 16 Apr 2018 06:56:09 +0000 (08:56 +0200)]
rdpsnd: add support for wave2 PDU in client (#2)
To achieve this the announced version number is bumped to 8.
Armin Novak [Thu, 12 Apr 2018 14:52:33 +0000 (16:52 +0200)]
Updated OpenSSL version in build scripts.
Armin Novak [Thu, 12 Apr 2018 14:49:18 +0000 (16:49 +0200)]
Added patch from f-droid repo. (Christian Plattner)
Bernhard Miklautz [Thu, 12 Apr 2018 13:52:38 +0000 (15:52 +0200)]
Merge pull request #4567 from akallabeth/sanitizer_checks_refined
Refined checks for sanitizers.
David Fort [Thu, 12 Apr 2018 13:25:35 +0000 (15:25 +0200)]
Merge pull request #4568 from akallabeth/rails_bad_window_fix
Check for window existence in remote app mode before access
Armin Novak [Thu, 12 Apr 2018 12:39:37 +0000 (14:39 +0200)]
Check for window existence in remote app mode before access
X11 is asynchronous, so events arriving in xf_event_PropertyNotify
may access a window that has already been discarded. Check that before
reading properties.
Armin Novak [Thu, 12 Apr 2018 09:49:43 +0000 (11:49 +0200)]
Refined checks for sanitizers.
Martin Fleisz [Thu, 12 Apr 2018 10:10:56 +0000 (12:10 +0200)]
Merge pull request #4557 from akallabeth/connect_error_fix
Set connection error if TCP connect fails.