Bowon Ryu [Tue, 30 Apr 2024 01:56:04 +0000 (10:56 +0900)]
[Tizen] Fix text autoscroll multi line issue
This patch fixes issues that arise when relayout is executed during auto-scrolling.
- relayout not executed after the scroll finish callback
- stop scrolling fails in certain situations in finish loop mode
- scroll finish being called twice during immediate mode stop
Change-Id: Ib44883380a79ad13c576d18c11171ae9f1f670c3
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Bowon Ryu [Thu, 18 Apr 2024 07:46:55 +0000 (16:46 +0900)]
[Tizen] Text controller checks data type of the clipboard
IsClipboardEmpty works meaningfully.
Temporary code has been applied to paste html type.
Once multiple types and data can be stored in the clipboard, this code should be removed.
Change-Id: I29b279acf19dd1c3397568b55e0567d314c41990
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Bowon Ryu [Thu, 25 Apr 2024 11:28:13 +0000 (20:28 +0900)]
[Tizen] Add offset to text outline
Change-Id: I280ed148384325cfa83e2d48fae15a387bc81fcd
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
ANZ1217 [Mon, 8 Apr 2024 11:46:52 +0000 (20:46 +0900)]
[Tizen] Fix Crash when the InsertText event is executed multiple times between Relayout.
When using IME, InsertText may be executed multiple times within one relayout.
Fix the problem that length of the text cannot be calculated correctly.
Change-Id: Id47f7bbacf90a098055fc7b6ae0d4931a9facde2
Eunki, Hong [Fri, 12 Apr 2024 13:07:07 +0000 (22:07 +0900)]
[Tizen] Force call KeepRendering when lottie animation stopped, or frame changed
Change-Id: Ie9c44a8a3997a644080c934d36e99c8aee804bf2
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
huiyu.eun [Wed, 3 Apr 2024 06:08:22 +0000 (15:08 +0900)]
[Tizen] Fix hit-test RenderTask error
There is a problem that the hit-test does not work properly because the
RenderTask is always fetched with a fixed index from the RenderTaskList.
It is fixed by passing the corresponding SceneView's RenderTask.
Change-Id: Id114c839455613fc4ed6437e2cb8482ee6677be9
Signed-off-by: huiyu.eun <huiyu.eun@samsung.com>
sunghyun kim [Mon, 8 Apr 2024 06:09:59 +0000 (06:09 +0000)]
Merge "[Tizen] Fix bug in transition effect" into tizen_8.0
Eunki, Hong [Fri, 5 Apr 2024 13:28:08 +0000 (22:28 +0900)]
[Tizen](Vector) Let we send finished signal only for matched sent play/stop from visual
It is possible that AnimationFinished trigger comes "after" event thread Play action comes.
If then, user's Play action be skipped.
To avoid this case, let we give the id when play state changed to Play / Pause / Stop.
And send finished signal only if the id is matched what visual know.
Change-Id: I03409e65d2f6b947940ea5591959b106ff8de2bd
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
sunghyun kim [Wed, 27 Mar 2024 07:33:59 +0000 (16:33 +0900)]
[Tizen] Fix bug in transition effect
Image view provides transitoin effect when image is replaced.
but this function has some bugs, so i fixed them.
Below is the issue list
1.Sometimes, some of view play transition effect when image is not replaced.
2.Sometimes, Don't play transition effect when image is replaced.
3.Focus items show transition effect even if resource is not changed.
Change-Id: I610ef472c3046177c5e3f76dd4d854497805168c
Eunki Hong [Tue, 2 Apr 2024 15:46:50 +0000 (00:46 +0900)]
[Tizen] Revert "Do not call malloc during terminate"
This reverts commit
4136ad045e9fec48e66b45999fb8ac19e325812f.
Change-Id: I0ba7d5ba19ab0c05506165332bccc814b02a8147
Eunki, Hong [Thu, 25 Jan 2024 04:24:24 +0000 (13:24 +0900)]
[Tizen] Make ModelNode / Light don't work A11y + Clean code lines
Let we make ModelNode and Light disable to create ControlAccessible as default.
And also, let we seperate the header file API override comes from.
It will make easy to find where it is comes from.
Change-Id: I477a2c34e247681df45120d83edd84b67fc22a9e
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 4 Mar 2024 06:39:55 +0000 (15:39 +0900)]
[Tizen] Fix coverity issues what we resolved at tizen_9.0
This is a combination of 3 commits.
Lock mutex when we queue offscreen texture at GlView
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Ensure image visual shaderType is in range
Let we make assert if we try to use invalid native shader feature
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Fix svace issue phase2 : Need to check Property::Value.Get() return
It is possible that user set invalid value type.
If then, we need to skip given value setter.
Change-Id: I7538533f9c915d6f392b3a92569df28b6ed96051
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
sunghyun kim [Thu, 21 Mar 2024 05:13:48 +0000 (14:13 +0900)]
[Tizen] Apply premultiply on initial time in animated visual
Change-Id: I7ce10be72455c659f5b5d09c3ce303f39dd13102
Eunki, Hong [Tue, 12 Mar 2024 05:12:22 +0000 (14:12 +0900)]
[Tizen] (Vector) Change shader at visual side
Let we change animated vector visual shader at visual side, instead of dali-extension.
Now we can use cached shader.
Change-Id: Ie530f295227ce55b9d374bc4ddfd1a09361905a4
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
sunghyun kim [Fri, 12 Jan 2024 05:21:31 +0000 (14:21 +0900)]
[Tizen] Change Property name USE_FIXED_CACHE to ENABLE_FRAME_CACHE
existing name is ambiguous in meaning, so we change it to a more clear name.
Change-Id: I8a797dee0378ffbc6ab2547f63d9360f8a2da2b5
Eunki, Hong [Tue, 12 Mar 2024 07:44:58 +0000 (16:44 +0900)]
[Tizen] (AutomatedTests) Let we make adaptor invalidate if adaptor stop
Change-Id: I1436b6dcb86810821abdf90eff9c9a9d63e8ee0a
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
sunghyun kim [Tue, 12 Mar 2024 11:39:09 +0000 (20:39 +0900)]
[Tizen] Change TransitionEffect
The existing effect was rather slow and unnatural.
therefore, some of the settings have been modified to make the effect more natural.
Change-Id: I42ef237dd831dd210766bf670b2d3061def69c44
joogab.yun [Tue, 12 Mar 2024 04:48:35 +0000 (13:48 +0900)]
[Tizen] The canvas view defaults to SYNCHRONOUS_LOADING.
A crash occurs when multiple CanvasViews are operated async.
So, we change it to operate synchronously by default.
The problem of async operation when using a multi-canvas view should be resolved later.
Change-Id: I9bb4c8165b69ebdd93753211214fcadf06a3f456
Eunki, Hong [Tue, 5 Mar 2024 00:43:05 +0000 (09:43 +0900)]
[Tizen] Fix svace issue : Need to check Property::Value.Get() return
It is possible that user set invalid value type. If then, we need to skip
given value setter.
Change-Id: I8bc339f30b969c049a0b07bda152c4d24593bb48
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Seungho Baek [Mon, 4 Mar 2024 09:08:27 +0000 (18:08 +0900)]
[Tizen] Add CastShadow and ReceiveShadow for Model and ModelNode
- CastShadow can be used to make an object cast shadow or not.
- ReceiveShadow can be used to make an object be not drawn any shadow on its surface.
- Model and ModelNode have the methods.
- If Model's method is called, it is inherited to its current child ModelNode.
- If ModelNode's method is called, it is only affects the ModelNode itself.
- The ModelNode's property changes do not affect its parent Model's property.
Change-Id: I8ebeeed9ed814718a38ad7f69c43a4814a5a70ae
Signed-off-by: Seungho Baek <sbsh.baek@samsung.com>
Eunki, Hong [Mon, 4 Mar 2024 07:50:23 +0000 (16:50 +0900)]
[Tizen] Fix many svace issues at dali-toolkit (integer overflow + etc)
This is a combination of 3 commits.
Let we remove many cases of dali-toolkit when we can be call 0u - 1u, which is undefined behavior.
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
(Scene3D) Fix svace issue : convert uint32_t to std::streamoff + minor
Fix svace issue when we try to convert from 32bit unsigned integer
to (might) 64bit signed integer.
+
Fix the name of function collision issue
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Fix svace issue : Avoid to divide by zero cases
Change-Id: If11884693253cd86f89cb98704e93473166faca1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 7 Mar 2024 06:21:03 +0000 (15:21 +0900)]
[Tizen] Let we use legacy rounded blur algorithm for gles2.0 + remove GL keyword
Since low spec device also want to use rounded blur color visual,
let we make them use some old legacy code, which required low calculation.
Change-Id: I50ad32c09da384e9ddc8a18423e67681f8824a5c
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 28 Feb 2024 12:51:32 +0000 (21:51 +0900)]
[Tizen] Do not call malloc during terminate
There was some strange crash issue during application terminate.
That crash comes at malloc.c during destruct JsonParser.
So, let we just remove some potential of mallocate memory during terminate,
what might not neccessary.
Change-Id: I93dc70b0c069f90a94e526f7916f9c54e1565a7f
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Adeel Kazmi [Wed, 28 Feb 2024 17:43:24 +0000 (17:43 +0000)]
[Tizen] (Automated Tests) Use github link instead of w3 for SVG image
Change-Id: I801f86b265f0101c5c906ccfcb221c477aee9484
Eunki, Hong [Mon, 4 Mar 2024 01:54:19 +0000 (10:54 +0900)]
[Tizen] Assume memory allocation failed cases
Let we consider malloc return null.
Change-Id: I5bafbf1cd47880ca5bc488cea264b88d742a7861
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 29 Feb 2024 05:25:04 +0000 (14:25 +0900)]
[Tizen] ImageVisualShader debug script make to add custom attribute / varying / uniform
Let we allow to set some extra uniform and attribute , varying if user need to debug.
Change-Id: I0c98358fe22e6678fcfa352d33c61308597bcfe0
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Fri, 16 Feb 2024 12:54:48 +0000 (21:54 +0900)]
[Tizen] Fix bug when we try to load two image s.t. premultyOnLoad difference
Let we seperate cache between
"Could-be-premultiplied, but not loaded yet" VS "Do not premultiplied"
Currently, we check both of them as same item.
Change-Id: Idfb68580e5a321745ee3accf9bb61d3845a39067
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Fri, 16 Feb 2024 11:25:09 +0000 (20:25 +0900)]
[Tizen] Emit ResourceReady if we call Reload even if it was ready visual.
If the visual was already ready state, and if we call Reload, the visual state
still ResourceReady. So ResourceReady signal was not be emitted.
Since someone might need to know the timing of resource loaded after Reload(),
Make we reset status as PREPARE, and wait callback again.
Change-Id: Id0ddb6523c4d9fcd58aab63a2fb07d27fdd9c5b5
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Tue, 27 Feb 2024 09:27:30 +0000 (18:27 +0900)]
[Tizen] (Vector) Change ConditionalWait as Mutex at lottie task
Change-Id: I1f652c440945a9b40a88a992018e14ae0746bc9d
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Mon, 26 Feb 2024 12:03:16 +0000 (12:03 +0000)]
Merge changes If2e7cd12,Ia9440c98 into tizen_8.0
* changes:
[Tizen] Fix Shadow crash issue during SceneOff
[Tizen] Change precision of corner radius relative shader codes as highp
Eunki, Hong [Thu, 22 Feb 2024 08:31:25 +0000 (17:31 +0900)]
[Tizen] Fix Shadow crash issue during SceneOff
Change-Id: If2e7cd12212d6207f7b9e582c8105574df0dd3c7
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 26 Feb 2024 09:31:22 +0000 (18:31 +0900)]
[Tizen] Change precision of corner radius relative shader codes as highp
There was some visual defect when view size is near 20,000 in target.
Change-Id: Ia9440c98e20a873664d09493cc9d645f1f7a91b1
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
seungho baek [Thu, 22 Feb 2024 13:08:44 +0000 (22:08 +0900)]
[Tizen] Change precision of shader variable
Change-Id: I4138a170c0ba9bea240a0fd0fcfab36afc2d182b
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Adam Bialogonski [Fri, 16 Feb 2024 16:11:14 +0000 (16:11 +0000)]
[Tizen] Added UNSAFE_RENDERING_DIRECT backend mode for GLView.
UNSAFE_RENDERING_DIRECT mode allows injecting the GL calls
directly into window context. This method is considered unsafe
and should be used cautiously as it may alter GL state of the
main DALi pipeline (ie. affect UI rendering).
Change-Id: Idd36a26541f9af56657c1eef72ee7e83e2a45581
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
Eunki, Hong [Mon, 5 Feb 2024 10:06:34 +0000 (19:06 +0900)]
[Tizen] Support CornerBlur and Scene3D gles2.0
This is a combination of 3 commits.
Ignore corner blur radius if glsl version is low
Let we make to not blur rounded corner if gles version is too low
Change-Id: I1ed43633d97e63a0b4d843ce692e7db28db22e0d
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Revert "[Tizen] Do not access undefineded transform uniform"
This reverts commit
6d81a8a25d046a707a00543b416902e1e75dedb5.
Support Scene3D on gles 2.0
Let we support Scene3D::Model under gles 2.0 devices.
Note : Since glsl doesnt support textureLod, we cannot support roughness.
Change-Id: If518bf48361331eb47b0f8a5a2ef265ba3fee488
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 19 Feb 2024 13:31:11 +0000 (22:31 +0900)]
[Tizen] Print image process duration when we trace it
Change-Id: Ic9dba03a2f18743ea253ccf9e1234bd1bda78239
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 19 Feb 2024 13:08:19 +0000 (22:08 +0900)]
[Tizen] Reduce the length of log during image trace
Change-Id: Id5ec87c10021a3d391295d88fbef2a88e1750150
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
seungho baek [Wed, 31 Jan 2024 06:20:57 +0000 (15:20 +0900)]
[Tizen] Create Shadow RenderTask only shadow is required.
- By using OrderIndex, Shadow RenderTask can be created only it is required.
Change-Id: I65a14ff4db167b1aa546be81f80238008322e7b5
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Eunki, Hong [Wed, 17 Jan 2024 02:54:38 +0000 (11:54 +0900)]
[Tizen] (Scene3D) Optimize AnimatedProperty's KeyFrame values after load complete
Let we reduce the total key frame of MotionValue what we parse.
Since both json and bvh store the data by framerate.
So, there might be useless values are included.
If the number of keyframe is large, it might give some overhead to core.
So let we reduce useless keyframe for MotionValue and Model's internal animation.
Change-Id: I04b86b0341125cef1f60d3da68150c9367655169
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Fri, 2 Feb 2024 07:26:35 +0000 (16:26 +0900)]
[Tizen] Make uShadowBias highp
Change-Id: I29a72fb8e7a3756d7e672ec4b06a5ae86c93a5b7
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
David Steele [Thu, 1 Feb 2024 14:15:23 +0000 (14:15 +0000)]
[Tizen] GraphicsBackend clean up backport
This is a combination of 2 commits.
Test harness sync
Test harness sync
Change-Id: Id9097935cbac664b75d9fe64049117bab42bf096
Adam Bialogonski [Thu, 11 Jan 2024 11:04:54 +0000 (11:04 +0000)]
[Tizen] Test harness update.
"uColor" uniform added as first.
Custom uniforms are added before default uniforms in the reflection.
Change-Id: Ifb837b5e18c80afb94f24cf9372c5c60d840b477
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
Eunki, Hong [Wed, 7 Feb 2024 11:15:16 +0000 (20:15 +0900)]
[Tizen] Apply some missing shader names
Change-Id: Iafce95d1725bd05e9c64a249d3de9e565b5d761b
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 5 Feb 2024 04:48:16 +0000 (13:48 +0900)]
[Tizen] Fix wrong order of linear enumeration
Since Fitting mode have FIT_HEIGHT = 4 and FIT_WIDTH = 5, we need to follow up the order of enum
Change-Id: I63be4fdb114be28c20716fd3eaad01f061049f92
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 5 Feb 2024 08:25:47 +0000 (17:25 +0900)]
[Tizen] Make model load task priority as low
Since gltf model load spend a lots of time, let we make it priority low
Change-Id: I4af0711d74b5836f4c7b039217463e13ce5c5220
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Mon, 5 Feb 2024 08:54:05 +0000 (17:54 +0900)]
[Tizen] Add precompiled shader names
Let we allow to use precompiled shader also use shader name
Change-Id: I701627ffc53b8450e286c31b8ac8e348e2a81cb0
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Fri, 2 Feb 2024 10:25:18 +0000 (19:25 +0900)]
[Tizen] Add name of shader what we generate as default
Let we use the feature of shader name for our dali side default shaders.
Change-Id: Ic2b33c53192075e78cb68aef0eb1401069b65e13
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 1 Feb 2024 03:44:42 +0000 (12:44 +0900)]
[Tizen] Let we make WebView invisible if window is hide
Since we didn't check window visibility changed during webview is on scene
+
We don't check whether webview is on scene or not,
it could be make WebEngine keep rendering infinitly.
Let we make web engine visible only if we can assume that it is visible now.
TODO : We cannot check parent visibility changed for current system correctly,
without any overhead. Todo in future
Change-Id: I86ca4cf816eb718a45cc0b5146217eb82f373fa0
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
huayong.xu [Fri, 2 Feb 2024 06:54:15 +0000 (14:54 +0800)]
[Tizen] Add a WebView API for notifying orientation change.
Change-Id: I74d7f99e28b4a681f918a45a109bc25d7a46371b
Eunki Hong [Wed, 31 Jan 2024 09:30:51 +0000 (09:30 +0000)]
Merge "[Tizen] Fix editable text font size update issue" into tizen_8.0
Eunki, Hong [Tue, 30 Jan 2024 12:16:41 +0000 (21:16 +0900)]
[Tizen] Fix decorator cursor size didn't changed issue
Since dali don't change the size during Relayout callback working,
the cursor size was not applied at 'current' relayout result.
So there was some issue that the cursor size applied well after 1 event loop working.
To avoid this issue, let we 'add' some relayout required actor to container.
It will call Relayout internally, at this loop.
TODO : Is there any other actor to be changed during relayout?
Change-Id: I88f48c7b64e76644ea8738abce4245a584c83cc9
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Bowon Ryu [Wed, 31 Jan 2024 04:44:10 +0000 (13:44 +0900)]
[Tizen] Fix editable text font size update issue
There is an issue that the font runs of the editable text area are separated
when the font size is updated.
If the editable text is an active state and the font size is updated,
the input font size should also be updated.
And due to the feature that changes the selected area's font size when the input font size is updated,
unintended font run separation and font size change occur if there is selected text when updating the font size.
This patch fixed so that the selection-related logic is not executed
when SetInputFontPointSize is called due to an update of the default font size.
Change-Id: I1a5f5190d00a25291a8cafc215f5bf0df2cd71f7
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki, Hong [Tue, 23 Jan 2024 03:44:52 +0000 (12:44 +0900)]
[Tizen] Call idle functions what we might be failed to add
Since AddIdle could be failed at ecore side, we need to call given callback
synchronously, or need to print some error logs for some cases.
Change-Id: Ie0afd1fd7ddb92d43e2fdc03592144c8dae711e2
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 24 Jan 2024 07:30:56 +0000 (16:30 +0900)]
[Tizen] Make we use valid geometry if broken image was n-patch and reloaded
It is possible that we use broken image not matched with given visual,
and then Reload API call it, and successed.
For this case, we need to change to use valid geometry again.
Change-Id: I2df7fb8b6123361b515b8f9ac9c1fafc77f665b6
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Wed, 24 Jan 2024 05:13:38 +0000 (05:13 +0000)]
Merge "[Tizen] Make method to get VisualUrl shorter." into tizen_8.0
Eunki, Hong [Tue, 23 Jan 2024 04:12:59 +0000 (13:12 +0900)]
[Tizen] (Scene3D) Guard cache impl will not be re-created at terminate case
Since LifecycleController could be called first before Model / ModelCache destroy,
re-create the image resource cache at terminate time was possible.
Since we don't check the validation of this item, it will make crash.
So let we ensure that we call those API under same thread with adaptor.
Change-Id: I995c509f070b56f99214689e5a9f3e66514d5f91
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Bowon Ryu [Thu, 18 Jan 2024 09:19:17 +0000 (18:19 +0900)]
[Tizen] Fix decorator color update issue
After a text decorator is created,
changing the related color causes only the property to be changed.
This patch fixes an issue where the actual actor's color was not changed.
Change-Id: I4778d9a51fa0cd128e24a4362354cebb81b2b2e9
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki, Hong [Mon, 22 Jan 2024 08:03:06 +0000 (17:03 +0900)]
[Tizen] Make method to get VisualUrl shorter.
Let we allow to get only the last 20 character of URL name
when we don't need to print full URL.
Change-Id: Id7203bff84fdf61a7950cec1c79ebce48b1a9a43
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Sat, 13 Jan 2024 00:28:27 +0000 (09:28 +0900)]
[Tizen] Remove cubemap cache temperary + Fix bug when Uploaded PixelData resue after Texture GC
If we create NewPixelDataWithReleaseAfterUpload and Upload to texture,
and if that texture reference count become 1 and GC,
the key of PixelData is not valid anymore.
To avoid this cases, Let we collect all PixelData container if some texture removed.
And also, since PixelData could be key of Texture cache, we should check the
reference count is less than 2.
+
Since current cubemap cache not works well reasonable, just remove it.
We will reopen it after we implement PixelDataList cache system again.
+
Print more log information if we need.
Change-Id: I6693ceab9b03cc20e1c6a42282ef39af38344e27
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Fri, 12 Jan 2024 06:25:03 +0000 (15:25 +0900)]
[Tizen] (Vector) Use mutex instead of ConditionalWait for EventhThreadCallback
Since worker thread can call AddEventTriggerCallback freely,
we should make some lock between workerthread and
main thread(RemoveEventTriggerCallbacks, GetNextEventCallback, ~VectorAnimationThread).
ConditionalWait used only for AsyncTask rasterization, and sleep thread.
We'd better seperate those job locker.
Change-Id: I543ba7f0bdf54036a8127d1815dda18cafca54e7
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Tue, 9 Jan 2024 13:13:26 +0000 (22:13 +0900)]
[Tizen] Remove build warning at gcc-13
Remove build warning when we build dali-csharp-binder by gcc-13
Change-Id: Ib331ca7ce62ff54d0db5311bcf9420e1b6e1cd0e
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
ANZ1217 [Fri, 29 Dec 2023 01:01:13 +0000 (10:01 +0900)]
[Tizen] Improve Textfit performance
We can assume point size of text and size of text's layout
are directly proportional.
So the size of the largest text point size
can be calculated by O(1) operations.
Previously, this was O(logn) operations.
Change-Id: Ie5aae28e949738ce0f67e389f3e920663f4e19bc
jmm [Wed, 10 Jan 2024 03:44:49 +0000 (12:44 +0900)]
[Tizen] Fix svace issue
Change-Id: I2646aae8db36a5471915e6ee4101beef4a51c9ba
Eunki, Hong [Mon, 15 Jan 2024 02:25:24 +0000 (11:25 +0900)]
[Tizen] Fix the 3D model rendering issue after the KHR_texture_transform etension support
Revert "[Tizen] Fix bug that IBLFactor / Roughness not works well when we change material"
This reverts commit
519b293f4452ddb4177af714e841c2b68a7335e5.
Fix the 3D model rendering issue after the KHR_texture_transform extension support
Fix bug that IBLFactor / Roughness not works well when we change material
There was some bug when we change Material info, uMaxLOD and uIblIntensity does not applied what primitive has.
This is because Material's SetUniform API overwrite the value of those uniform.
This patch make we ensure the order of uniform register, so let we use correct LOD and IBL intensity.
Change-Id: Id8e11744a9767402aa0e36e112093b79fb9b8f3f
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
ANZ1217 [Thu, 11 Jan 2024 11:36:48 +0000 (20:36 +0900)]
[Tizen] Fix Text Anchor don't work properly
When the text component is vertical aligned as center or bottom,
The y offset was not calculated at anchor event.
Now, it works properly.
Change-Id: I31f2530122d28e07a32c8a75875a77bcc69353ee
Eunki, Hong [Mon, 8 Jan 2024 04:35:28 +0000 (13:35 +0900)]
[Tizen][Scene3D] Let we allow to release PixelData memory after upload for 3D cache
Since we use PixelData as key of cached Texture, it might make some
CPU memory allocated even if we upload finished.
To avoid this behavior, let we make PixelData release memory
after upload to Texture for Scene3D case.
Change-Id: Id43e92d5b4a816fe76890c7ca58f6c43b6dab761
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
seungho baek [Mon, 8 Jan 2024 11:41:59 +0000 (20:41 +0900)]
[Tizen] To prevent segmentation fault in AnimatedVectorImageVisual
Change-Id: I4c5c94eb9faeffd4727b5879254527692fe93be2
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Eunki Hong [Sun, 7 Jan 2024 00:55:59 +0000 (09:55 +0900)]
[Tizen] Do not access undefineded transform uniform
Usually, we didn't register texture transform matrix if it is not avaliable.
But even it is not avaliable, we use that value.
If that matrix has some NaN value, the result also could be breakdown.
This patch make some safe guard for that case.
Change-Id: I32ae35d5e632ce72d9784691fd254ad47ff03321
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki Hong [Fri, 5 Jan 2024 16:01:50 +0000 (01:01 +0900)]
[Tizen] Fix bug that IBLFactor / Roughness not works well when we change material
There was some bug when we change Material info, uMaxLOD and uIblIntensity does not applied what primitive has.
This is because Material's SetUniform API overwrite the value of those uniform.
This patch make we ensure the order of uniform register, so let we use correct LOD and IBL intensity.
Change-Id: Ic14b7f9b6c0e443ac17188a8968ac71a7c6328d6
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Fri, 5 Jan 2024 09:55:29 +0000 (18:55 +0900)]
[Tizen][Tizen_8.0] Make ModelNode and Light as Control
Since we need to use some control features (like KeyboardFocus) let we make
ModelNode and Light as Control, instead of CustomActor.
Change-Id: Iab43b46068c0a676b3cef850bace629142680316
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 4 Jan 2024 12:23:07 +0000 (21:23 +0900)]
[Tizen] Make SceneView's SetResolution works well
Let we change codes that might need to check whether the size of render target
is inputed by App side, by the API SetResolution.
We usually use it to reduce memory of SceneView FBO usage. So let we also make
ShadowMap size will relative with resolution.
Change-Id: Ic243dae41da04f5adea95998b5e49d863b92ba86
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Thu, 4 Jan 2024 11:05:55 +0000 (20:05 +0900)]
[Tizen] Fix Rasterize not works when SetTransform is first time
It is possible that SVG load complete, and after than layout executed.
If then, mDefaultSize of SVG is not zero, and rasterize task not requested.
Unfortunatly, if fitting mode settup into image view, the required size
of resterize might not correct. So, ImageView try to re-layout once again
at it's OnResourceReady signal.
This patch make we send rasterize signal at least one time, So let we ensure
the ImageView resource ready signal comes at least one time.
Change-Id: I3edb6a1a681898b007ef1b70470993da5c68c289
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki Hong [Wed, 3 Jan 2024 16:10:12 +0000 (01:10 +0900)]
[Tizen] Fix reorder warning on text-label
Change-Id: Ic635d991c50e70bac6d2ea5d2547b50f3579367d
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
ANZ1217 [Wed, 3 Jan 2024 06:51:34 +0000 (15:51 +0900)]
[Tizen] Fix TextFit do not work properly
When check for textfit, it doesn't distinguish between cases
where the layout does not change because text is too large
and the layout does not change because text is too small.
Now CheckForTextFit returns false when text is too large.
Change-Id: I03a414406ee336ec7bf24c8d067fc73379d119f7
seungho baek [Thu, 26 Oct 2023 09:17:02 +0000 (18:17 +0900)]
[Tizen] Fixed Cache for AnimatedVectorImageVisual
Change-Id: I22bab282652f5377b95ce1d34db4564398be0ae8
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
ANZ1217 [Wed, 20 Dec 2023 06:23:18 +0000 (15:23 +0900)]
[Tizen] Clear font cache when locale changed
Fix the problem that the font does not change because the font cache of the multi-language-support and text-controller does not disappear when the language is changed.
Change-Id: Ib6afee3101d87cd09a1a0c9af5c9f33b16bf84cb
Eunki Hong [Thu, 21 Dec 2023 13:54:32 +0000 (22:54 +0900)]
[Tizen] Use trace macro with message generator function
Change-Id: Iac15dac7e023e150f48ef60c3a256edae08cf016
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Bowon Ryu [Fri, 29 Dec 2023 05:49:36 +0000 (14:49 +0900)]
[Tizen] Fix cursor position issue
This patch fixes an issue where the cursor position is incorrectly positioned
when padding is set for the textfield text editor.
It is a problem caused by the wrong location of the cursor layer.
Change-Id: Ifa0e9b752160761dfd6806cfc18dbf98576c71e3
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki, Hong [Thu, 28 Dec 2023 05:28:32 +0000 (14:28 +0900)]
[Tizen] Remove guard codes for memory corruption
Change-Id: I3df3dbab64439505bb613495940d68c6e9370258
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 27 Dec 2023 05:11:43 +0000 (14:11 +0900)]
[Tizen] Reset EmptyTexture object when application stopped
We should not re-use old texture item if application stoped and re-start.
This can be happened when we use offscreen application
Change-Id: I162d380259d7644fe0f817412581658010df0d47
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
joogab.yun [Tue, 19 Dec 2023 10:48:40 +0000 (19:48 +0900)]
[Tizen] If it is a key event that occurred in another window, it skipped
Change-Id: I32973650a1a7974f1ee58ecc2afe2cd5c53e570a
Eunki, Hong [Wed, 20 Dec 2023 04:02:14 +0000 (13:02 +0900)]
[Tizen] Fix svace issue (accessible null check)
Change-Id: I71afc8e98a9e8eef985130757091cd8e5fed4182
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 8 Nov 2023 13:10:53 +0000 (22:10 +0900)]
[Tizen] (A11y) Connect PropertySet signal only if highlighed
Notify when ACCESSIBILITY_NAME or ACCESSIBILITY_DESCRIPTION changed cases are
only need for highlighted control. So let we ensure to connect property set signal
only if control has ben grabed at least one time.
It will be useful when never be highlighted Actor's Accessible creation / destruct time.
Change-Id: I0c719a4576d02db9914a0e7b53a266ba4845cee2
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 20 Dec 2023 08:22:42 +0000 (17:22 +0900)]
[Tizen] Add more guard code to detect memory corruption
Change-Id: Ia4799ac86c49dbb515ad5c7fc13b3b6192773975
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Tue, 19 Dec 2023 03:20:57 +0000 (12:20 +0900)]
[Tizen] Print Processor and AsyncTask name
Change-Id: Id857319423092faea102b9f8e5acb37a92bec7c6
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Bowon Ryu [Mon, 18 Dec 2023 09:44:11 +0000 (18:44 +0900)]
[Tizen] Add AnchorColor Property
AnchorColor(or AnchorClickedColor) property is
used as the default color of the markup anchor tag.
If there is a color attribute in the markup anchor tag,
the markup attribute takes precedence.
Change-Id: Idc938495036319f74764b9ddadc2441d46eed159
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
Eunki, Hong [Mon, 18 Dec 2023 04:28:01 +0000 (13:28 +0900)]
[Tizen] Trace log when remove texture caches + VectorAnimationManager
Print some more logs when we has a lots number of events to execute during
post processor.
Change-Id: If2c2d8d62dc6969befb5d71ea84973a47b951af2
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Adam Bialogonski [Thu, 14 Dec 2023 09:56:35 +0000 (09:56 +0000)]
[Tizen] Coverity issue fix
- removed unused 'mesh' parameter
Change-Id: I07505bab4da485578882ee63a0211703b2cac4a6
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
seungho baek [Tue, 5 Dec 2023 08:37:37 +0000 (17:37 +0900)]
[Tizen] Use DepthIndex for 3D rendering order
Change-Id: Id722744a3db4aa1504ae45894b6edcc4039994d7
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Eunki Hong [Thu, 7 Dec 2023 15:12:47 +0000 (00:12 +0900)]
[Tizen] Remove gcc-13 build warning [-Wpessimizing-move]
/home/leaf/work/dali-toolkit/dali-toolkit/internal/visuals/image-visual-shader-debug.cpp: In function ‘void Dali::Toolkit::Internal::ImageVisualShaderDebug::ApplyImageVisualShaderDebugScriptCode(std::string&)’:
/home/leaf/work/dali-toolkit/dali-toolkit/internal/visuals/image-visual-shader-debug.cpp:289:70: warning: moving a temporary object prevents copy elision [-Wpessimizing-move]
289 | RedefineMacro(fragmentShader, std::move(key.stringKey), std::move(value.Get<std::string>()));
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
/home/leaf/work/dali-toolkit/dali-toolkit/internal/visuals/image-visual-shader-debug.cpp:289:70: note: remove ‘std::mov’ call
Change-Id: I7327933872cca94879b39ab52f904f0d580d29b0
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Wed, 6 Dec 2023 08:00:55 +0000 (17:00 +0900)]
[Tizen] (Vector) Erase all EventThreadCallbacks with same pointer
Due to some logical issue, there might be happend that we apply multiple
EventThread callback into VectorAnimationThread.
And if VectorAnimationTask destructor called, we remove only single callback.
If error case occured, EventThread can execute dead callback.
Change-Id: I9e3895180916a292bbca838997ae3053ee8799b5
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
Eunki, Hong [Tue, 28 Nov 2023 09:32:00 +0000 (18:32 +0900)]
[Tizen] Add visualization option for check texture and visual size
To support some visualize debugging for app, let we make special
environment value and json script.
By change the json script files by app side, we can debug image visuals freely.
Change-Id: If78d8eb0057ea28ad1b5e0f5f70809c966f2cf3e
Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
joogab.yun [Tue, 5 Dec 2023 05:34:45 +0000 (14:34 +0900)]
[Tizen] Add log for FocusLost
Change-Id: If73db96299b5a8e280fdece3da1df3ab4071a9bb
Adeel Kazmi [Tue, 5 Dec 2023 16:37:55 +0000 (16:37 +0000)]
[Tizen] Fixed SVACE errors
Change-Id: Ie5f9420aee93ffc35136378926328934c9b39045
seungho baek [Tue, 21 Nov 2023 07:27:44 +0000 (16:27 +0900)]
[Tizen] Support RootTranslationOnly option for motion capture data
Change-Id: I4058c891336a6f802c6e70efe87e06ffdaabb1f5
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
seungho baek [Tue, 28 Nov 2023 07:13:21 +0000 (16:13 +0900)]
[Tizen] Add SetResolution method to SceneView
Change-Id: Ib3b9ea2352457eb3d8d6085eed2ad58300fb24e5
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
seungho baek [Wed, 25 Oct 2023 05:45:17 +0000 (14:45 +0900)]
[Tizen] Enable masking for Scene3D::SceneView
Change-Id: Ia725f8a19a96d6020e1247cc49b9568a5f562215
Signed-off-by: seungho baek <sbsh.baek@samsung.com>
Eunki Hong [Wed, 29 Nov 2023 14:02:08 +0000 (23:02 +0900)]
[Tizen] (Scene3D) Ensure remove image-resource-loader cache when app terminated
Since ImageResourceLoader use static global value internally,
it might have some problem when we use OffscreenApplication multiple time.
Since even Dali::Application destroyed, the static value can be alived.
At this time, If we create new Dali::Application one more time, the cache
system break down.
To ensure we follow up the cache system, let we connect the signal to
LifecycleController, and then delete self.
It will ensure we can re-create this cache after Dali::Application recreated.
Change-Id: I6178a91dfff2a435eb95d11e7ca8ef7479c125ed
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
Adam Bialogonski [Thu, 30 Nov 2023 10:27:06 +0000 (10:27 +0000)]
[Tizen] Fixed ColliderMesh issue for NUI
The collider mesh was not registered correctly upon adding the node to the Model.
Change-Id: Id9ca71070d892017915f610b79c4ab13447b7d51
Signed-off-by: Adam Bialogonski <adam.b@samsung.com>
seungho baek [Tue, 24 Oct 2023 10:09:38 +0000 (19:09 +0900)]
[Tizen] To stop animated image visual when it become invisible.
Change-Id: I48ba87d31ba6db63489879cb4a7940da8714a29f
Signed-off-by: seungho baek <sbsh.baek@samsung.com>