platform/upstream/libSkiaSharp.git
11 years agobench_util: allow optional whitespace in CSV format
epoger@google.com [Tue, 13 Aug 2013 15:12:33 +0000 (15:12 +0000)]
bench_util: allow optional whitespace in CSV format
BUG=https://code.google.com/p/skia/issues/detail?id=1500
R=bensong@google.com

Review URL: https://codereview.chromium.org/23069003

git-svn-id: http://skia.googlecode.com/svn/trunk@10692 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoexpose instance methods on SkTypefaceCache
reed@google.com [Tue, 13 Aug 2013 14:59:17 +0000 (14:59 +0000)]
expose instance methods on SkTypefaceCache

BUG=
R=bungeman@google.com

Review URL: https://codereview.chromium.org/23067003

git-svn-id: http://skia.googlecode.com/svn/trunk@10691 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix mac build errors related to new gm
djsollen@google.com [Tue, 13 Aug 2013 14:48:09 +0000 (14:48 +0000)]
fix mac build errors related to new gm

Review URL: https://codereview.chromium.org/22937005

git-svn-id: http://skia.googlecode.com/svn/trunk@10690 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPrevent picture recording from over optimizing the culling of clips.
djsollen@google.com [Tue, 13 Aug 2013 14:29:06 +0000 (14:29 +0000)]
Prevent picture recording from over optimizing the culling of clips.

BUG=skia:1496
R=mtklein@google.com, reed@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/22875008

git-svn-id: http://skia.googlecode.com/svn/trunk@10689 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove uncalled local functions
reed@google.com [Tue, 13 Aug 2013 13:25:09 +0000 (13:25 +0000)]
remove uncalled local functions

BUG=

Review URL: https://codereview.chromium.org/22924004

git-svn-id: http://skia.googlecode.com/svn/trunk@10688 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake android_run_skia exit with the correct code
borenet@google.com [Mon, 12 Aug 2013 17:21:43 +0000 (17:21 +0000)]
Make android_run_skia exit with the correct code

R=djsollen@google.com

Review URL: https://codereview.chromium.org/22812003

git-svn-id: http://skia.googlecode.com/svn/trunk@10684 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Add SkCanvas::drawPosTextBounded."
reed@google.com [Mon, 12 Aug 2013 15:40:11 +0000 (15:40 +0000)]
Revert "Add SkCanvas::drawPosTextBounded."

This reverts commit e158aea941a6202a40b75fcee013d002089854bb.

This was an experimental API change. We will reintroduce this feature
with a different API approach, and support it w/ detailed testing
and performance measurements.

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22861002

git-svn-id: http://skia.googlecode.com/svn/trunk@10680 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix malformed gypi file that was missing commas
djsollen@google.com [Mon, 12 Aug 2013 14:57:54 +0000 (14:57 +0000)]
fix malformed gypi file that was missing commas

R=torne@chromium.org

Review URL: https://codereview.chromium.org/22841003

git-svn-id: http://skia.googlecode.com/svn/trunk@10678 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSkTDynamicHash
mtklein@google.com [Mon, 12 Aug 2013 14:51:25 +0000 (14:51 +0000)]
SkTDynamicHash
  - add validate()
  - make add() and remove() strict
  - fill in maybeShrink()
  - make grow and shrink thresholds configurable.
  - fix issue where we were getting filled with deleted items - we need to count them as occupied when determining if we should grow

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/22571010

git-svn-id: http://skia.googlecode.com/svn/trunk@10677 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIf any change is made to the public API then make sure there is an LGTM from an owner.
rmistry@google.com [Mon, 12 Aug 2013 14:51:20 +0000 (14:51 +0000)]
If any change is made to the public API then make sure there is an LGTM from an owner.

This feature has been requested by reed@.

If no LGTM is found from an owner then the following msg is displayed:

** Presubmit ERRORS **
Since the CL is editing public API, you must have an LGTM from one of: ('reed@chromium.org', 'reed@google.com', 'bsalomon@chromium.org', 'bsalomon@google.com')

(SkipBuildbotRuns)

R=borenet@google.com

Review URL: https://codereview.chromium.org/22453004

git-svn-id: http://skia.googlecode.com/svn/trunk@10676 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate Skia Android tools.
djsollen@google.com [Mon, 12 Aug 2013 12:30:04 +0000 (12:30 +0000)]
Update Skia Android tools.

This CL moves the skia_launcher out of the system/bin and into
/data/local/tmp; removes the need to package our shared libs in an
apk; and updates all the scripts to work in the new environment.

R=mtklein@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/22617002

git-svn-id: http://skia.googlecode.com/svn/trunk@10673 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert of r10671 (Experiments on calculating reciprocal of square root) due to bots...
robertphillips@google.com [Mon, 12 Aug 2013 12:02:28 +0000 (12:02 +0000)]
Revert of r10671 (Experiments on calculating reciprocal of square root) due to bots failures:

Win7: http://108.170.217.252:10117/builders/Build-Win7-VS2010-x86-Debug/builds/715/steps/BuildMost/logs/stdio
Win8: http://108.170.217.252:10117/builders/Build-Win8-VS2012-x86-Debug/builds/383/steps/BuildMost/logs/stdio
Mac10.6: http://108.170.217.252:10117/builders/Build-Mac10.6-GCC-x86-Debug/builds/1259/steps/BuildMost/logs/stdio

git-svn-id: http://skia.googlecode.com/svn/trunk@10672 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoExperiments on calculating reciprocal of square root
commit-bot@chromium.org [Mon, 12 Aug 2013 08:37:51 +0000 (08:37 +0000)]
Experiments on calculating reciprocal of square root

BUG=
R=reed@google.com, rmistry@chromium.org, bsalomon@google.com, tomhudson@chromium.org, tomhudson@google.com

Author: yang.gu@intel.com

Review URL: https://chromiumcodereview.appspot.com/21755002

git-svn-id: http://skia.googlecode.com/svn/trunk@10671 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agor10473 introduced a space between bench values; adjusting the corresponding regexp...
bensong@google.com [Sun, 11 Aug 2013 21:59:01 +0000 (21:59 +0000)]
r10473 introduced a space between bench values; adjusting the corresponding regexp. (SkipBuildbotRuns).
Review URL: https://codereview.chromium.org/22447004

git-svn-id: http://skia.googlecode.com/svn/trunk@10670 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverted r10654 (Fix crash when querying a runtime config that is defined in environm...
robertphillips@google.com [Sun, 11 Aug 2013 13:20:18 +0000 (13:20 +0000)]
Reverted r10654 (Fix crash when querying a runtime config that is defined in environment) due to compilation failure on Chromium win_layout bot

git-svn-id: http://skia.googlecode.com/svn/trunk@10669 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 10 Aug 2013 07:01:19 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10668 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10659: Add a map homogenous points to SkMatrix
jvanverth@google.com [Fri, 9 Aug 2013 21:06:38 +0000 (21:06 +0000)]
Revert r10659: Add a map homogenous points to SkMatrix

git-svn-id: http://skia.googlecode.com/svn/trunk@10667 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAll rSomethingTo() immediately following a close() are relative to the point we close...
commit-bot@chromium.org [Fri, 9 Aug 2013 19:48:26 +0000 (19:48 +0000)]
All rSomethingTo() immediately following a close() are relative to the point we closed from, not the point we close to.  Fix that.

Seems like this has been broken since the stone ages.

BUG=skia:1474, code.google.com/p/android/issues/detail?id=41216
R=bsalomon@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/22681006

git-svn-id: http://skia.googlecode.com/svn/trunk@10666 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReland "Make WebP decoding independent of stream length."
scroggo@google.com [Fri, 9 Aug 2013 19:22:00 +0000 (19:22 +0000)]
Reland "Make WebP decoding independent of stream length."

This reverts commit 1de924955b103c4f5dc9c46a06527d6a37e6cb70.

When reading the stream, only read as much as will fit in the
allocated buffer.

BUG=skia:1495

Review URL: https://codereview.chromium.org/22629010

git-svn-id: http://skia.googlecode.com/svn/trunk@10665 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove include from the header paths
djsollen@google.com [Fri, 9 Aug 2013 16:11:36 +0000 (16:11 +0000)]
remove include from the header paths

R=robertphillips@google.com, torne@chromium.org

Review URL: https://codereview.chromium.org/22450005

git-svn-id: http://skia.googlecode.com/svn/trunk@10664 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoallow NULL in writeString/readString
commit-bot@chromium.org [Fri, 9 Aug 2013 16:03:05 +0000 (16:03 +0000)]
allow NULL in writeString/readString

BUG=skia:1469, code.google.com/p/android/issues/detail?id=58257
R=scroggo@google.com

Author: mtklein@google.com

Review URL: https://chromiumcodereview.appspot.com/22359003

git-svn-id: http://skia.googlecode.com/svn/trunk@10662 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove exported headers and add all public headers into dictionary for reference...
djsollen@google.com [Fri, 9 Aug 2013 15:45:35 +0000 (15:45 +0000)]
Remove exported headers and add all public headers into dictionary for reference by clients.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22613003

git-svn-id: http://skia.googlecode.com/svn/trunk@10661 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTemporarily disable pathinterior_gpu on Nexus-10.
jvanverth@google.com [Fri, 9 Aug 2013 15:24:01 +0000 (15:24 +0000)]
Temporarily disable pathinterior_gpu on Nexus-10.

git-svn-id: http://skia.googlecode.com/svn/trunk@10660 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a map homogenous points to SkMatrix
egdaniel@google.com [Fri, 9 Aug 2013 15:07:10 +0000 (15:07 +0000)]
Add a map homogenous points to SkMatrix

BUG=
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/22330004

git-svn-id: http://skia.googlecode.com/svn/trunk@10659 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd initial baselines for new GM xfermodes3
bsalomon@google.com [Fri, 9 Aug 2013 14:32:46 +0000 (14:32 +0000)]
Add initial baselines for new GM xfermodes3

git-svn-id: http://skia.googlecode.com/svn/trunk@10658 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemoving deprecated constructors and setDevice from SkDeferredCanvas
commit-bot@chromium.org [Fri, 9 Aug 2013 14:24:59 +0000 (14:24 +0000)]
Removing deprecated constructors and setDevice from SkDeferredCanvas

R=senorblanco@google.com, senorblanco@chromium.org
BUR=crbug.com/270143

Author: junov@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22385011

git-svn-id: http://skia.googlecode.com/svn/trunk@10657 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r10651: Make WebP decoding independent of stream length.
jvanverth@google.com [Fri, 9 Aug 2013 14:24:30 +0000 (14:24 +0000)]
Reverting r10651: Make WebP decoding independent of stream length.

git-svn-id: http://skia.googlecode.com/svn/trunk@10656 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoremove uneeded SK_API declaration.
djsollen@google.com [Fri, 9 Aug 2013 13:49:13 +0000 (13:49 +0000)]
remove uneeded SK_API declaration.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22432005

git-svn-id: http://skia.googlecode.com/svn/trunk@10655 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix crash when querying a runtime config that is defined in environment
commit-bot@chromium.org [Fri, 9 Aug 2013 13:23:56 +0000 (13:23 +0000)]
Fix crash when querying a runtime config that is defined in environment

Fix crash when querying a runtime config in case when there's no
skia.conf file and the config variable is still defined in the
environment.

Runs the added SkRTConf::UnitTest test as part of new "UnitTest" test.

BUG=skia:1494
R=bsalomon@google.com, humper@google.com

Author: kkinnunen@nvidia.com

Review URL: https://chromiumcodereview.appspot.com/22650007

git-svn-id: http://skia.googlecode.com/svn/trunk@10654 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNexus 7 Performance trigger rebaseline
robertphillips@google.com [Fri, 9 Aug 2013 12:43:02 +0000 (12:43 +0000)]
Nexus 7 Performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10653 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCleanup the ARM blitrow optimizations
djsollen@google.com [Fri, 9 Aug 2013 12:35:08 +0000 (12:35 +0000)]
Cleanup the ARM blitrow optimizations

R=mtklein@google.com

Review URL: https://codereview.chromium.org/22229002

git-svn-id: http://skia.googlecode.com/svn/trunk@10652 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake WebP decoding independent of stream length.
djsollen@google.com [Fri, 9 Aug 2013 12:32:48 +0000 (12:32 +0000)]
Make WebP decoding independent of stream length.

There's a case in Android, when the SkStream passed to WebP decoder may have
incorrect length (stream->getLength()). This is observed, if the App decodes
an image (size > 80KB) using: 'ParcelFileDescriptor --> BitmapFactory.decodeStream()'.
This CL updates the WebP incremental decoding loop to not rely on stream->getLength().

R=scroggo@google.com, vikasa@google.com

Review URL: https://codereview.chromium.org/22672003

git-svn-id: http://skia.googlecode.com/svn/trunk@10651 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 9 Aug 2013 07:01:22 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10650 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis attempts to replicate some bad cache behavior Mozilla reported.
commit-bot@chromium.org [Thu, 8 Aug 2013 22:55:21 +0000 (22:55 +0000)]
This attempts to replicate some bad cache behavior Mozilla reported.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/22411005

git-svn-id: http://skia.googlecode.com/svn/trunk@10649 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert rebaselines for r10640.
jvanverth@google.com [Thu, 8 Aug 2013 22:44:13 +0000 (22:44 +0000)]
Revert rebaselines for r10640.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10648 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10640: Fix hairline pathrenderer for Nexus-10.
jvanverth@google.com [Thu, 8 Aug 2013 22:42:37 +0000 (22:42 +0000)]
Revert r10640: Fix hairline pathrenderer for Nexus-10.

git-svn-id: http://skia.googlecode.com/svn/trunk@10647 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline Nexus-S and Nexus-4 GMs for r10640. Disabled complexclip_bw_layer_gpu
jvanverth@google.com [Thu, 8 Aug 2013 21:24:41 +0000 (21:24 +0000)]
Rebaseline Nexus-S and Nexus-4 GMs for r10640. Disabled complexclip_bw_layer_gpu
for Nexus-S due to glitch.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10646 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd new GM to targeted at rect->clear optimization with different xfermodes.
commit-bot@chromium.org [Thu, 8 Aug 2013 21:13:38 +0000 (21:13 +0000)]
Add new GM to targeted at rect->clear optimization with different xfermodes.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22264010

git-svn-id: http://skia.googlecode.com/svn/trunk@10645 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore rebaselines for r10640. Unreviewed.
jvanverth@google.com [Thu, 8 Aug 2013 20:42:19 +0000 (20:42 +0000)]
More rebaselines for r10640. Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10644 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline images for r10640. Unreviewed.
jvanverth@google.com [Thu, 8 Aug 2013 20:07:12 +0000 (20:07 +0000)]
Rebaseline images for r10640. Unreviewed.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10643 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding 2 functions to the Skia API
commit-bot@chromium.org [Thu, 8 Aug 2013 19:20:05 +0000 (19:20 +0000)]
Adding 2 functions to the Skia API

I need wrappers for both SkOrderedReadBuffer and SkOrderedWriteBuffer inside Chromium in order to do the IPC serialization of Skia SkImageFilter objects.

See https://codereview.chromium.org/21271002/

BUG=
R=djsollen@google.com, scroggo@google.com, reed@google.com

Author: sugoi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22591002

git-svn-id: http://skia.googlecode.com/svn/trunk@10642 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaseline images for r10535. Reviewed by djsollen.
jvanverth@google.com [Thu, 8 Aug 2013 18:54:12 +0000 (18:54 +0000)]
Rebaseline images for r10535. Reviewed by djsollen.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10641 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix hairline pathrenderer for Nexus-10. Switches to using additional
commit-bot@chromium.org [Thu, 8 Aug 2013 18:22:07 +0000 (18:22 +0000)]
Fix hairline pathrenderer for Nexus-10. Switches to using additional
geometry and passing in the coverage value instead.

BUG=
R=robertphillips@google.com, bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/22486003

git-svn-id: http://skia.googlecode.com/svn/trunk@10640 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: remove text save/restore (not needed) and verify that colorspace dictionar...
edisonn@google.com [Thu, 8 Aug 2013 12:54:01 +0000 (12:54 +0000)]
pdfviewer: remove text save/restore (not needed) and verify that colorspace dictionary exists before using it

Review URL: https://codereview.chromium.org/22436003

git-svn-id: http://skia.googlecode.com/svn/trunk@10639 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: add ability to run on gpu
edisonn@google.com [Thu, 8 Aug 2013 12:42:13 +0000 (12:42 +0000)]
pdfviewer: add ability to run on gpu

Review URL: https://codereview.chromium.org/22684002

git-svn-id: http://skia.googlecode.com/svn/trunk@10638 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCreate a gypi that contains all the SK_API header files for use by clients (i.e....
djsollen@google.com [Thu, 8 Aug 2013 12:31:05 +0000 (12:31 +0000)]
Create a gypi that contains all the SK_API header files for use by clients (i.e. chromium).

R=robertphillips@google.com, torne@chromium.org

Review URL: https://codereview.chromium.org/22474010

git-svn-id: http://skia.googlecode.com/svn/trunk@10637 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: remove save/restore used with q/Q operators (we already do there save...
edisonn@google.com [Thu, 8 Aug 2013 11:40:26 +0000 (11:40 +0000)]
pdfviewer: remove save/restore used with q/Q operators (we already do there save and restore)

Review URL: https://codereview.chromium.org/22678003

git-svn-id: http://skia.googlecode.com/svn/trunk@10636 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoARM Skia NEON patches - 11 - Blitter_RGB16
commit-bot@chromium.org [Thu, 8 Aug 2013 10:51:45 +0000 (10:51 +0000)]
ARM Skia NEON patches - 11 - Blitter_RGB16

Blitter_RGB16: fixes and improvements

- fix alpha calculation: it was still using the old version of
  SkAlpha255To256. 11 more tests pass in gm.

- clean a lot the code: the existing code was "a bit" messy with
  a lot of duplicated hardcoded constants, got rid of all this.

- improve speed a little: part of it as a side-effect of the change
  in the way alpha is calculated but also by grouping loads and stores.

One "issue" was present and still remains: the NEON code doesn't give
the same result as the black blitter on black. It accounts for dozens
of mismatches in gm. Is this considered "not too bad"? Would you be
interested in a NEON version of the black blitter? The current
comments seem to indicate that the black blitter is here only to give
a performance boost when NEON is not presents so I didn't write a NEON
version.

BUG=
R=djsollen@google.com, tomhudson@google.com, reed@google.com

Author: kevin.petit.arm@gmail.com

Review URL: https://chromiumcodereview.appspot.com/18666005

git-svn-id: http://skia.googlecode.com/svn/trunk@10635 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 8 Aug 2013 07:01:20 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10634 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse Path Ops to generate PDF clips
commit-bot@chromium.org [Thu, 8 Aug 2013 02:52:05 +0000 (02:52 +0000)]
Use Path Ops to generate PDF clips

R=vandebo@chromium.org, edisonn@google.com, caryclark@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/21161003

git-svn-id: http://skia.googlecode.com/svn/trunk@10633 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10603 (Remove operator== from SkPaint) due to Chrome failures
robertphillips@google.com [Wed, 7 Aug 2013 22:36:29 +0000 (22:36 +0000)]
Revert r10603 (Remove operator== from SkPaint) due to Chrome failures

git-svn-id: http://skia.googlecode.com/svn/trunk@10632 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNew baselines for imagefiltersbase, after r10626.
senorblanco@chromium.org [Wed, 7 Aug 2013 21:36:15 +0000 (21:36 +0000)]
New baselines for imagefiltersbase, after r10626.

TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/22623004

git-svn-id: http://skia.googlecode.com/svn/trunk@10631 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: absolute minimal; to al least render (even if poorly) ICC based color...
edisonn@google.com [Wed, 7 Aug 2013 21:11:57 +0000 (21:11 +0000)]
pdfviewer: absolute minimal; to al least render (even if poorly) ICC based color spaces, based on RGB

Review URL: https://codereview.chromium.org/22624002

git-svn-id: http://skia.googlecode.com/svn/trunk@10630 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBeginning work to refactor jpeg tile decoding.
scroggo@google.com [Wed, 7 Aug 2013 21:09:13 +0000 (21:09 +0000)]
Beginning work to refactor jpeg tile decoding.

Keep common code together, so we can fix bugs in tile and normal decode
simultaneously.

Convert if-then chains to switch statements for readability.

Add getBitmapConfig, common to both normal and tile decode, which
ensures that they behave the same. getBitmapConfig uses the code
originally in onDecode, so subsetting grayscale into A8 now works.

In getBitmapConfig, handle JCS_YCCK properly.

Fix a bug where requesting A8 from a JCS_CMYK image would
result in a total failure to decode, since we would change
out_color_space to an invalid choice.

Factor common code for applying dither and changing the
out_color_space into apply_dither_mode (final name TBD). Skips
CMYK like normal decoding did before.

BUG=skia:1472
BUG=https://b.corp.google.com/issue?id=9466275
BUG=https://b.corp.google.com/issue?id=9189955
R=mtklein@google.com

Review URL: https://codereview.chromium.org/22290002

git-svn-id: http://skia.googlecode.com/svn/trunk@10629 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix failure exits from JPEG onBuildTileIndex.
scroggo@google.com [Wed, 7 Aug 2013 21:02:32 +0000 (21:02 +0000)]
Fix failure exits from JPEG onBuildTileIndex.

The setjmp exited without deleting the SkJPEGImageIndex, and
another exit condition deleted the huffman index even though
it had not been created yet. Create member functions on
SkJPEGImageIndex to make the jpeg calls so it can keep track
of what has been created, and avoid destroying anything else.

Remove unnecessary lines to set values to their default values.

Move all SkJPEGImageIndex code entirely inside #ifdef ANDROID
blocks, since no piece of it is used except by ANDROID only
code.

BUG=skia:1471
R=djsollen@google.com, mtklein@google.com

Review URL: https://codereview.chromium.org/21891007

git-svn-id: http://skia.googlecode.com/svn/trunk@10628 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate GM baselines for 8888->4444 fix.
scroggo@google.com [Wed, 7 Aug 2013 20:23:26 +0000 (20:23 +0000)]
Update GM baselines for 8888->4444 fix.

Review URL: https://codereview.chromium.org/22621002

git-svn-id: http://skia.googlecode.com/svn/trunk@10627 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpstreaming DropShadowImageFilter into skia, from Blink
junov@chromium.org [Wed, 7 Aug 2013 20:00:55 +0000 (20:00 +0000)]
Upstreaming DropShadowImageFilter into skia, from Blink

GM imagefiltersbase will need rebaselining after this change

R=senorblanco@chromium.org

Committed: https://code.google.com/p/skia/source/detail?r=10583

Review URL: https://codereview.chromium.org/22258005

git-svn-id: http://skia.googlecode.com/svn/trunk@10626 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSupport decoding subsets from JPG on Android.
scroggo@google.com [Wed, 7 Aug 2013 19:53:53 +0000 (19:53 +0000)]
Support decoding subsets from JPG on Android.

Previously we only supported it for the framework. Making this
change allows us to test subset decoding in skimage, to make sure
we don't break it.

Will require rebaselining android skimage results.

R=djsollen@google.com

Review URL: https://codereview.chromium.org/21612003

git-svn-id: http://skia.googlecode.com/svn/trunk@10625 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix BGRA readback on Android
commit-bot@chromium.org [Wed, 7 Aug 2013 19:43:45 +0000 (19:43 +0000)]
Fix BGRA readback on Android

R=bsalomon@google.com, robertphillips@google.com

Author: snorp@snorp.net

Review URL: https://chromiumcodereview.appspot.com/22522002

git-svn-id: http://skia.googlecode.com/svn/trunk@10624 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix build.
scroggo@google.com [Wed, 7 Aug 2013 19:39:56 +0000 (19:39 +0000)]
Fix build.

Use SkIntToScalar.

Reflect that 8888 can be copied to 4444 in BitmapCopyTest.

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10623 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRestore SkPath(const SkPath&) to copy the generation ID on Android.
mtklein@google.com [Wed, 7 Aug 2013 19:17:53 +0000 (19:17 +0000)]
Restore SkPath(const SkPath&) to copy the generation ID on Android.

BUG=
R=bsalomon@google.com, bungeman@google.com, reed@google.com

Review URL: https://codereview.chromium.org/22471002

git-svn-id: http://skia.googlecode.com/svn/trunk@10622 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd downsample from 8888 to 4444.
scroggo@google.com [Wed, 7 Aug 2013 19:16:05 +0000 (19:16 +0000)]
Add downsample from 8888 to 4444.

Extend SkBitmap::copyTo to copy from a source with
SkARGB_8888_Config to a destination bitmap with
SkARGB_4444_Config.

BUG=http://code.google.com/p/chromium/issues/detail?id=245774
R=reed@google.com

Review URL: https://codereview.chromium.org/22350003

git-svn-id: http://skia.googlecode.com/svn/trunk@10621 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore GM rebaselines
jvanverth@google.com [Wed, 7 Aug 2013 18:57:24 +0000 (18:57 +0000)]
More GM rebaselines

git-svn-id: http://skia.googlecode.com/svn/trunk@10620 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRebaselining GM's for gradient GM change.
dierk@google.com [Wed, 7 Aug 2013 18:12:46 +0000 (18:12 +0000)]
Rebaselining GM's for gradient GM change.

rebaselining gm's

BUG=

Review URL: https://codereview.chromium.org/22391004

git-svn-id: http://skia.googlecode.com/svn/trunk@10619 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd ui for mutli-rebaselining
zachr@google.com [Wed, 7 Aug 2013 18:06:39 +0000 (18:06 +0000)]
add ui for mutli-rebaselining

R=epoger@google.com

Review URL: https://codereview.chromium.org/22580004

git-svn-id: http://skia.googlecode.com/svn/trunk@10618 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: fix font rotation issues
edisonn@google.com [Wed, 7 Aug 2013 18:04:15 +0000 (18:04 +0000)]
pdfviewer: fix font rotation issues

Review URL: https://codereview.chromium.org/22407005

git-svn-id: http://skia.googlecode.com/svn/trunk@10617 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMark dashing gpu as expected to fail on win7/gpu/intel
bsalomon@google.com [Wed, 7 Aug 2013 17:43:05 +0000 (17:43 +0000)]
Mark dashing gpu as expected to fail on win7/gpu/intel

R=jvanverth@google.com

Review URL: https://codereview.chromium.org/22407004

git-svn-id: http://skia.googlecode.com/svn/trunk@10616 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd getFamilyNames to SkTypeface.
bungeman@google.com [Wed, 7 Aug 2013 17:09:22 +0000 (17:09 +0000)]
Add getFamilyNames to SkTypeface.

Committed: https://code.google.com/p/skia/source/detail?r=10589

Committed: https://code.google.com/p/skia/source/detail?r=10592

Committed: https://code.google.com/p/skia/source/detail?r=10608

Review URL: https://codereview.chromium.org/21716005

git-svn-id: http://skia.googlecode.com/svn/trunk@10615 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm/bitmapcopy: create the bitmap in a secondary canvas, since the one in which we...
commit-bot@chromium.org [Wed, 7 Aug 2013 17:03:09 +0000 (17:03 +0000)]
gm/bitmapcopy: create the bitmap in a secondary canvas, since the one in which we draw might be backed by PDF and then accessBitmap does not work.

R=borenet@google.com, jvanverth@google.com

Author: edisonn@google.com

Review URL: https://chromiumcodereview.appspot.com/22353006

git-svn-id: http://skia.googlecode.com/svn/trunk@10614 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIgnore gif_test.gif, take two. Add missing comma.
jvanverth@google.com [Wed, 7 Aug 2013 16:52:05 +0000 (16:52 +0000)]
Ignore gif_test.gif, take two. Add missing comma.

Unreviewed.

git-svn-id: http://skia.googlecode.com/svn/trunk@10613 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd SkCanvas::drawPosTextBounded.
commit-bot@chromium.org [Wed, 7 Aug 2013 16:22:47 +0000 (16:22 +0000)]
Add SkCanvas::drawPosTextBounded.

This allows subclasses which need bounding box information to get it
from the caller if it has already been computed.

BUG=chromium:269080
R=reed@google.com, tomhudson@chromium.org, tomhudson@google.com

Author: jbroman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22585002

git-svn-id: http://skia.googlecode.com/svn/trunk@10612 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTry to ignore gif_test.gif in skimage test
jvanverth@google.com [Wed, 7 Aug 2013 16:07:43 +0000 (16:07 +0000)]
Try to ignore gif_test.gif in skimage test

git-svn-id: http://skia.googlecode.com/svn/trunk@10610 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r10608 (Add getFamilyNames to SkTypeface) due to compilation failures
robertphillips@google.com [Wed, 7 Aug 2013 15:56:51 +0000 (15:56 +0000)]
Reverting r10608 (Add getFamilyNames to SkTypeface) due to compilation failures

git-svn-id: http://skia.googlecode.com/svn/trunk@10609 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd getFamilyNames to SkTypeface.
bungeman@google.com [Wed, 7 Aug 2013 15:46:29 +0000 (15:46 +0000)]
Add getFamilyNames to SkTypeface.

Committed: https://code.google.com/p/skia/source/detail?r=10589

Committed: https://code.google.com/p/skia/source/detail?r=10592

Review URL: https://codereview.chromium.org/21716005

git-svn-id: http://skia.googlecode.com/svn/trunk@10608 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodownload and rebaseline images using server
zachr@google.com [Wed, 7 Aug 2013 15:43:04 +0000 (15:43 +0000)]
download and rebaseline images using server

BUG=
R=epoger@google.com

Review URL: https://codereview.chromium.org/20654006

git-svn-id: http://skia.googlecode.com/svn/trunk@10607 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow multiple images for flaky dashing GM on intel/win7/gpu
bsalomon@google.com [Wed, 7 Aug 2013 15:35:35 +0000 (15:35 +0000)]
Allow multiple images for flaky dashing GM on intel/win7/gpu

R=epoger@google.com

Review URL: https://codereview.chromium.org/22327004

git-svn-id: http://skia.googlecode.com/svn/trunk@10606 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoenable SK_FONTHOST_USES_FONTMGR for mac and win. linux fontmgr not ready
reed@google.com [Wed, 7 Aug 2013 15:30:09 +0000 (15:30 +0000)]
enable SK_FONTHOST_USES_FONTMGR for mac and win. linux fontmgr not ready

BUG=

Review URL: https://codereview.chromium.org/22406004

git-svn-id: http://skia.googlecode.com/svn/trunk@10605 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMozilla diabolical clamp case added to gm/gradients.cpp
commit-bot@chromium.org [Wed, 7 Aug 2013 15:22:13 +0000 (15:22 +0000)]
Mozilla diabolical clamp case added to gm/gradients.cpp

Added diabolical clamp case.

BUG=
R=reed@google.com

Author: dierk@google.com

Review URL: https://chromiumcodereview.appspot.com/22484002

git-svn-id: http://skia.googlecode.com/svn/trunk@10604 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove operator== from SkPaint
commit-bot@chromium.org [Wed, 7 Aug 2013 15:22:05 +0000 (15:22 +0000)]
Remove operator== from SkPaint

R=mtklein@google.com, reed@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/21949007

git-svn-id: http://skia.googlecode.com/svn/trunk@10603 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "rebaseline gpu dashing on win7"
bsalomon@google.com [Wed, 7 Aug 2013 13:34:26 +0000 (13:34 +0000)]
Revert "rebaseline gpu dashing on win7"

This reverts commit r10577.

git-svn-id: http://skia.googlecode.com/svn/trunk@10602 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Add blend optimization helpers and use to convert rect draws to clears."
bsalomon@google.com [Wed, 7 Aug 2013 13:34:14 +0000 (13:34 +0000)]
Revert "Add blend optimization helpers and use to convert rect draws to clears."

This reverts commit r10537.

git-svn-id: http://skia.googlecode.com/svn/trunk@10601 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Sanitizing source files in Housekeeper-Nightly"
bsalomon@google.com [Wed, 7 Aug 2013 13:34:08 +0000 (13:34 +0000)]
Revert "Sanitizing source files in Housekeeper-Nightly"

This reverts commit r10594.

git-svn-id: http://skia.googlecode.com/svn/trunk@10600 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Rebaseline flaky non AA lines on intel/win/gpu"
bsalomon@google.com [Wed, 7 Aug 2013 13:34:01 +0000 (13:34 +0000)]
Revert "Rebaseline flaky non AA lines on intel/win/gpu"

This reverts commit r10566.

git-svn-id: http://skia.googlecode.com/svn/trunk@10599 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: /Pattern color space, uses the matrix of the last content stream, not...
edisonn@google.com [Wed, 7 Aug 2013 11:56:16 +0000 (11:56 +0000)]
pdfviewer: /Pattern color space, uses the matrix of the last content stream, not the global matrix.

Review URL: https://codereview.chromium.org/22460004

git-svn-id: http://skia.googlecode.com/svn/trunk@10595 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 7 Aug 2013 07:00:58 +0000 (07:00 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10594 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWork around broken SkFontMgr_fontconfig.cpp for test.
bungeman@google.com [Wed, 7 Aug 2013 03:17:12 +0000 (03:17 +0000)]
Work around broken SkFontMgr_fontconfig.cpp for test.

git-svn-id: http://skia.googlecode.com/svn/trunk@10593 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd getFamilyNames to SkTypeface.
bungeman@google.com [Wed, 7 Aug 2013 02:45:25 +0000 (02:45 +0000)]
Add getFamilyNames to SkTypeface.

Committed: https://code.google.com/p/skia/source/detail?r=10589

Review URL: https://codereview.chromium.org/21716005

git-svn-id: http://skia.googlecode.com/svn/trunk@10592 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove SkComposeImageFilter into its own {.h, .cpp} files
commit-bot@chromium.org [Wed, 7 Aug 2013 00:07:51 +0000 (00:07 +0000)]
Move SkComposeImageFilter into its own {.h, .cpp} files

In http://crrev.com/21154002, SkComposeImageFilter will be used
outside of tests. Consequently, this moves SkComposeImageFilter from
SkTestImageFilters.{h, cpp} into its own {.h, .cpp} files.

BUG=181613
R=senorblanco@chromium.org

Author: ajuma@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22438003

git-svn-id: http://skia.googlecode.com/svn/trunk@10591 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r10589: Add getFamilyNames to SkTypeface
jvanverth@google.com [Tue, 6 Aug 2013 23:31:44 +0000 (23:31 +0000)]
Reverting r10589: Add getFamilyNames to SkTypeface

git-svn-id: http://skia.googlecode.com/svn/trunk@10590 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd getFamilyNames to SkTypeface.
bungeman@google.com [Tue, 6 Aug 2013 22:53:04 +0000 (22:53 +0000)]
Add getFamilyNames to SkTypeface.

Review URL: https://codereview.chromium.org/21716005

git-svn-id: http://skia.googlecode.com/svn/trunk@10589 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: load image pain settings (like transparency), pass the page number, report...
edisonn@google.com [Tue, 6 Aug 2013 21:48:44 +0000 (21:48 +0000)]
pdfviewer: load image pain settings (like transparency), pass the page number, report failure if at least one render fails, and check that xref section starts with xref keyword.

Review URL: https://codereview.chromium.org/22465006

git-svn-id: http://skia.googlecode.com/svn/trunk@10588 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReverting r10583: Upstreaming DropShadowImageFilter into skia, from Blink
jvanverth@google.com [Tue, 6 Aug 2013 21:12:59 +0000 (21:12 +0000)]
Reverting r10583: Upstreaming DropShadowImageFilter into skia, from Blink

git-svn-id: http://skia.googlecode.com/svn/trunk@10587 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRegenerate bitmaps before each draw in tilemodes_npot GM
bsalomon@google.com [Tue, 6 Aug 2013 20:47:52 +0000 (20:47 +0000)]
Regenerate bitmaps before each draw in tilemodes_npot GM

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/22415004

git-svn-id: http://skia.googlecode.com/svn/trunk@10586 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRe-organize Android scripts
borenet@google.com [Tue, 6 Aug 2013 20:32:29 +0000 (20:32 +0000)]
Re-organize Android scripts

Addresses https://code.google.com/p/skia/issues/detail?id=1486

R=djsollen@google.com

Review URL: https://codereview.chromium.org/22411004

git-svn-id: http://skia.googlecode.com/svn/trunk@10585 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange SkPreConfig.h to recognise uppercase PPC/PPC64.
george@mozilla.com [Tue, 6 Aug 2013 20:16:34 +0000 (20:16 +0000)]
Change SkPreConfig.h to recognise uppercase PPC/PPC64.

git-svn-id: http://skia.googlecode.com/svn/trunk@10584 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpstreaming DropShadowImageFilter into skia, from Blink
junov@chromium.org [Tue, 6 Aug 2013 20:01:40 +0000 (20:01 +0000)]
Upstreaming DropShadowImageFilter into skia, from Blink

GM imagefiltersbase will need rebaselining after this change

R=senorblanco@chromium.org

Review URL: https://codereview.chromium.org/22258005

git-svn-id: http://skia.googlecode.com/svn/trunk@10583 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove invalid expectation.
scroggo@google.com [Tue, 6 Aug 2013 19:35:48 +0000 (19:35 +0000)]
Remove invalid expectation.

Fixes build.

git-svn-id: http://skia.googlecode.com/svn/trunk@10582 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd config option to skimage.
scroggo@google.com [Tue, 6 Aug 2013 18:56:53 +0000 (18:56 +0000)]
Add config option to skimage.

Allows testing 565 and A8, in addition to 8888.

Also makes the preference consistent for each test (in one run).

BUG=skia:1465
R=djsollen@google.com

Review URL: https://codereview.chromium.org/22297007

git-svn-id: http://skia.googlecode.com/svn/trunk@10579 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoDo not fail skimage on missing expectations.
scroggo@google.com [Tue, 6 Aug 2013 18:51:30 +0000 (18:51 +0000)]
Do not fail skimage on missing expectations.

This will allow adding new images to test without turning the bots
red.

R=epoger@google.com

Review URL: https://codereview.chromium.org/22301006

git-svn-id: http://skia.googlecode.com/svn/trunk@10578 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorebaseline gpu dashing on win7
bsalomon@google.com [Tue, 6 Aug 2013 18:46:56 +0000 (18:46 +0000)]
rebaseline gpu dashing on win7

git-svn-id: http://skia.googlecode.com/svn/trunk@10577 2bbb7eff-a529-9590-31e7-b0007b416f81