Daniel Juyung Seo [Sun, 23 Mar 2014 08:57:08 +0000 (17:57 +0900)]
macros: Fixed wrong ELM_RECTS_INCLUDE logic.
Daniel Zaoui [Sat, 22 Mar 2014 17:44:29 +0000 (19:44 +0200)]
Eolian: Integration of Entry
Daniel Zaoui [Fri, 21 Mar 2014 15:27:17 +0000 (17:27 +0200)]
Eolian: Integration of Disk Selector
Daniel Zaoui [Fri, 21 Mar 2014 14:01:48 +0000 (16:01 +0200)]
Eolian: Integration of Day Selector
Daniel Juyung Seo [Sun, 23 Mar 2014 07:53:08 +0000 (16:53 +0900)]
test_genlist, test_gengrid: Added more callbacks to genlist/gengrid for a
better testing.
Daniel Juyung Seo [Sun, 23 Mar 2014 07:48:10 +0000 (16:48 +0900)]
list/genlist/gengrid: Handle on_focus event on focus set only for key
event.
When you use mouse(touch) that triggers mouse up event, the
focus/selection movement is done by mouse up callback, so don't need to
handle on_focus event when mouse(touch) is used.
You can reproduce the bug by the following step.
1. launch elementary_test -> list focus, genlist focus, gengrid focus
2. focus an item (by touch, by key)
3. move focus to left button (by touch, by key)
4. click an another item (by touch)
5. previously focused item will be unfocused again even it was unfocused
at step #3/
Special thanks to Amitesh for the report.
zmike [Sun, 23 Mar 2014 07:10:15 +0000 (03:10 -0400)]
genlist needs to iterate exactly once over a fixed list when deselcting all items
the selected items list can be modified during deselect from the smart callback, which can cause an infinite loop here
@fix
Daniel Juyung Seo [Sat, 22 Mar 2014 17:07:20 +0000 (02:07 +0900)]
gengrid: Commented out some temporarily unused code.
This code will be used later when the item selection on key press becomes
optional. So do not remove this.
Daniel Juyung Seo [Sat, 22 Mar 2014 17:05:16 +0000 (02:05 +0900)]
elm: Fixed shadow variable build warning.
declaration of 'access' shadows a global declaration
Daniel Juyung Seo [Sat, 22 Mar 2014 16:35:00 +0000 (01:35 +0900)]
test_list: Added focus move policy set example to test_list.
Daniel Juyung Seo [Thu, 20 Mar 2014 14:50:46 +0000 (23:50 +0900)]
focus: Added optional focus feature - focus movement by mouse_in.
Focus is moved by mouse click by default. This patch makes moving focus
by mouse_in optionally by configuration and API. Widget item focus
movement is not applied yet. Need to do that as well.
- configuration: "focus_move_policy"
- API: elm_config_focus_move_policy_set/get
- enum
ELM_FOCUS_MOVE_POLICY_CLICK
ELM_FOCUS_MOVE_POLICY_IN
@feature
Daniel Juyung Seo [Sat, 22 Mar 2014 15:49:41 +0000 (00:49 +0900)]
test_genlist/gengrid: Renamed 'item focus' test to just 'focus'.
Daniel Juyung Seo [Sat, 22 Mar 2014 15:42:59 +0000 (00:42 +0900)]
focus: Set the focus target as NULL on focus highlight init.
Only elementary object can be a candidate for elementary focus.
Daniel Juyung Seo [Sat, 22 Mar 2014 15:38:01 +0000 (00:38 +0900)]
test_genlist: Flourish genlist focus test case to reveal more bugs.
- Added focus highlight enable/disable option.
- Added a button to set the focus to 2nd item after 1.5 seconds.
- Added a button to select the 2nd item after 1.5 seconds.
- Removed unnecessary frame and lable for the test.
Daniel Juyung Seo [Sat, 22 Mar 2014 15:13:58 +0000 (00:13 +0900)]
test_genlist: Merged 'Genlist Focus' and 'Genlist Item Focus' test.
There is no reason to have two different focus example for genlist.
Daniel Juyung Seo [Sat, 22 Mar 2014 14:51:52 +0000 (23:51 +0900)]
gengrid: Fixed broken gengrid item focus support.
This commit is a gengrid version of
7d43205a0.
Now it works so much better than before.
- Fixed the separate behavior between selected item and focused item.
- Fixed wrong focus set when gengrid is focused first time by mouse.
- Fixed wrong scroll movement when the focus highlight is disabled.
- Item selection sets that item focused. So when an item is selected, do
not need to set the focus again.
Daniel Juyung Seo [Sat, 22 Mar 2014 14:28:19 +0000 (23:28 +0900)]
genlist: Fixed broken genlist item focus support.
Now it works so much better than before.
- Fixed the separate behavior between selected item and focused item.
- Fixed wrong focus set when genlist is focused first time by mouse.
- Fixed wrong scroll movement when the focus highlight is disabled.
- Item selection sets that item focused. So when an item is selected, do
not need to set the focus again.
- Fixed wrong call for _elm_genlist_item_content_focus_set on deleted
item.
Daniel Juyung Seo [Sat, 22 Mar 2014 12:50:21 +0000 (21:50 +0900)]
list: Added missing return from my previous commit ac0b3c.
Daniel Juyung Seo [Sat, 22 Mar 2014 10:21:38 +0000 (19:21 +0900)]
mobile config: Added key bindings to mobile profile.
We can still use keyboards with Mobile profile when you attach your
keyboard with bluetooth or connect the keyboard physically.
Daniel Juyung Seo [Sat, 22 Mar 2014 10:17:01 +0000 (19:17 +0900)]
test_list: Added clicked callback to buttons and made focus highlight optional.
Daniel Juyung Seo [Sat, 22 Mar 2014 10:10:27 +0000 (19:10 +0900)]
genlist/gengrid: Used item callback infrastructure.
Daniel Juyung Seo [Sat, 22 Mar 2014 09:38:00 +0000 (18:38 +0900)]
list/genlist/gengrid: Call item_show not bring_in on focus.
Elm 1.9 does item_show not bring_in so let's keep the consistency. I
will make this optional later.
Daniel Juyung Seo [Sat, 22 Mar 2014 09:30:45 +0000 (18:30 +0900)]
list: Fixed heavily broken list item focus/selection movement.
Item selection also sets the focus automatically so do not need to set
focus twice. This code needs to be changed later again when the
selection by key arrow becomes optional.
Daniel Juyung Seo [Sat, 22 Mar 2014 09:07:27 +0000 (18:07 +0900)]
list: Select the first item when the list widget is just focused first time.
Select the first item if there is no last_focused_item,
last_selected_item, and if this focus is done by key event.
Daniel Juyung Seo [Sat, 22 Mar 2014 09:06:42 +0000 (18:06 +0900)]
list: Fixed formatting before fixing a bug.
Daniel Juyung Seo [Sat, 22 Mar 2014 09:01:22 +0000 (18:01 +0900)]
list: Fixed item focus logic correctly by checking mouse down instead
of highlighted_item.
highlighted_item will be NULL after the first click and it is not
useful. To avoid first item focus -> first item unfocus -> clicked
item focus on the first focus to list widget, this patch is needed.
Thanks for the report Ceolin.
Daniel Juyung Seo [Sat, 22 Mar 2014 08:54:49 +0000 (17:54 +0900)]
flip, index: Renamed smart data member 'down' to 'mouse_down' and used
EINA_TRUE/FALSE.
This commit is for consistency inside elementary.
Daniel Juyung Seo [Sat, 22 Mar 2014 07:25:34 +0000 (16:25 +0900)]
button: Check return value of _elm_config_key_binding_call.
This fixes severely broken focus movement.
ChunEon Park [Sat, 22 Mar 2014 06:40:07 +0000 (15:40 +0900)]
win - revert the revert.
1974aff066a10df59750a6d52fd9933333eb0ee3
I missed this already puhsed in the 1.9 release. :(
ChunEon Park [Sat, 22 Mar 2014 06:19:28 +0000 (15:19 +0900)]
win - removed unknown type.
ChunEon Park [Sat, 22 Mar 2014 06:17:00 +0000 (15:17 +0900)]
Revert "Revert "win: Add a API, elm_win_type_get.""
This reverts commit
1fae5b440457948a048007fbb24171f90e6aab30.
sorry i didn't intend reverting this commit.
ChunEon Park [Sat, 22 Mar 2014 06:10:55 +0000 (15:10 +0900)]
Revert "win: Add a API, elm_win_type_get."
This reverts commit
313eaab843194083d5dee11f053a156f88c6c219.
we don't agree this unknown type of window.
it should be always known type.
ChunEon Park [Sat, 22 Mar 2014 06:10:40 +0000 (15:10 +0900)]
Revert "elm_win: Unbreak the ABI break of window type."
This reverts commit
79d2df12fe5e4d57d7a6247975feac1f0793ec72.
ChunEon Park [Sat, 22 Mar 2014 05:40:48 +0000 (14:40 +0900)]
scroller content type is not always widget.
Jaeun Choi [Sat, 22 Mar 2014 05:31:49 +0000 (14:31 +0900)]
elm_button: apply key binding
Summary: This patch applies key binding to elm_button.
Test Plan: elementary_test > Button > check key events
Reviewers: Hermet, raster
Reviewed By: Hermet
Differential Revision: https://phab.enlightenment.org/D646
Subhransu Sekhar Mohanty [Sat, 22 Mar 2014 05:22:32 +0000 (14:22 +0900)]
naviframe : Fixed the overlap issue during multiple push.
Summary:
Currently there is a overlap issue in naviframe in case of multiple push.
This issue will occur if the naviframe edc implements push,defered for
the item transition. The issue occurs becoz of cur,push,deffered is not being
called to the current and intermediate items during multiple item push.
To fix the above issue pass the data as current item that needs to be
out of the aviframe during creating the animator job.
@fix
Reviewers: Jaehyun, seoz, Hermet
Reviewed By: Hermet
CC: raster
Differential Revision: https://phab.enlightenment.org/D645
nirajkr [Fri, 21 Mar 2014 08:00:46 +0000 (17:00 +0900)]
gengrid : Implementation for gengrid item focus support
Summary:
Implemented the following API to support gengrid item_focus
1. _elm_gengrid_focus_highlight_geometry_get
2. _elm_gengrid_focused_item_get
3. _item_focus_up
4. _item_focus_down
5. _item_focus_right
6. _item_focus_down
7. _item_focus_set_hook
8. _item_focus_get_hook
9. _item_focused
10. _item_unfocused
11. Changes in the smart_event, pan_calculation, smart_on_focus to support item focus
Reviewers: seoz, woohyun, singh.amitesh, raster
CC: raster
Differential Revision: https://phab.enlightenment.org/D550
Carsten Haitzler (Rasterman) [Fri, 21 Mar 2014 03:20:43 +0000 (12:20 +0900)]
fix scrollbar to be clickable even if vieport is tiny compared to content
@fix
Daniel Juyung Seo [Thu, 20 Mar 2014 17:35:29 +0000 (02:35 +0900)]
test_dnd: Fixed memory leak. Free item's data on item deletion.
This fixes coverity CID 1193246: Resource leak (RESOURCE_LEAK).
Daniel Juyung Seo [Thu, 20 Mar 2014 17:33:22 +0000 (02:33 +0900)]
access: Fixed memory leak.
This fixes coverity CID 1193244: Resource leak (RESOURCE_LEAK).
@fix
Daniel Juyung Seo [Thu, 20 Mar 2014 15:55:31 +0000 (00:55 +0900)]
index: Set variable to NULL after free.
Then NULL check for this variable is not valid.
This fixes coverity CID 1193250: Use after free (USE_AFTER_FREE).
@fix
Daniel Juyung Seo [Thu, 20 Mar 2014 15:49:52 +0000 (00:49 +0900)]
atspi_object: Added missing comma.
This fixes coverity CID 1193238: Missing comma in a string array
initialization (MISSING_COMMA)
@fix
Daniel Juyung Seo [Thu, 20 Mar 2014 15:46:47 +0000 (00:46 +0900)]
diskselector: Compare correct variables.
It was comparing the same variable.
Fixed coverity CID 1193236: Pointless string comparison
(CONSTANT_EXPRESSION_RESULT)
@fix
Ryuan Choi [Thu, 20 Mar 2014 14:28:53 +0000 (23:28 +0900)]
test_web: Improve fullscreen test case.
Improved fullscreen api tests not to show other widgets when web page requires fullscreen.
Daniel Zaoui [Thu, 20 Mar 2014 13:17:55 +0000 (15:17 +0200)]
Eolian: Integration of Datetime
Daniel Zaoui [Thu, 20 Mar 2014 13:06:33 +0000 (15:06 +0200)]
Eolian: Integration of Ctx Popup
Daniel Zaoui [Thu, 20 Mar 2014 12:37:43 +0000 (14:37 +0200)]
Eolian: Integration of Conformant
Daniel Zaoui [Thu, 20 Mar 2014 12:29:12 +0000 (14:29 +0200)]
Eolian: Integration of Color Selector
Daniel Zaoui [Thu, 20 Mar 2014 09:11:48 +0000 (11:11 +0200)]
Eolian: Integration of Clock
Daniel Zaoui [Thu, 20 Mar 2014 08:27:21 +0000 (10:27 +0200)]
Eolian: Integration of Check
Daniel Zaoui [Thu, 20 Mar 2014 07:44:34 +0000 (09:44 +0200)]
Eolian: Integration of Calendar
Daniel Zaoui [Thu, 20 Mar 2014 06:40:43 +0000 (08:40 +0200)]
Eolian: Integration of Button
Daniel Zaoui [Thu, 20 Mar 2014 06:40:07 +0000 (08:40 +0200)]
Eolian: Integration of Bubble
Daniel Zaoui [Thu, 20 Mar 2014 05:58:37 +0000 (07:58 +0200)]
Eolian: Integration of Box
Bora Hwang [Thu, 20 Mar 2014 11:12:02 +0000 (20:12 +0900)]
clear up the documentation of tooltip
Summary: Since explanations of tooltip's APIs are scattered in header or source code, these needs to be cleared up.
Reviewers: seoz, Hermet, woohyun, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D644
Thiep Ha [Thu, 20 Mar 2014 10:33:42 +0000 (19:33 +0900)]
[Elm_Entry] Update selection handlers position and its visibility when scrolling
Summary:
Selection handlers' position are not updated when entry is scrolled.
You can check on elementary_test -> Entry 3 (or Entry 4 which is scrollable) -> Select some text -> Scroll entry and see.
This patch is submitted to fix this bug. It update selection handlers' position when entry is scrolled and hide them if needed.
@fix
Reviewers: raster
Differential Revision: https://phab.enlightenment.org/D640
Jaeun Choi [Thu, 20 Mar 2014 09:42:20 +0000 (18:42 +0900)]
config: add a field in key binding data structure
Summary:
This patch adds a field "no_string" in key binding data structure.
It is necessary for checking "string" field in evas key down event.
Test Plan: None
Reviewers: Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D641
Daniel Juyung Seo [Thu, 20 Mar 2014 05:54:38 +0000 (14:54 +0900)]
list: Focus a selected item.
Daniel Zaoui [Wed, 19 Mar 2014 13:27:27 +0000 (15:27 +0200)]
Eolian: Integration of Bg
Daniel Zaoui [Wed, 19 Mar 2014 13:07:26 +0000 (15:07 +0200)]
Eolian: Integration of Atspi Object
Daniel Zaoui [Wed, 19 Mar 2014 11:42:15 +0000 (13:42 +0200)]
Eolian: Integration of Atspi Window Interface
Daniel Zaoui [Wed, 19 Mar 2014 11:26:12 +0000 (13:26 +0200)]
Eolian: Integration of Atspi Component Interface
Daniel Zaoui [Wed, 19 Mar 2014 09:24:22 +0000 (11:24 +0200)]
Eolian: Integration of App Server View
Daniel Zaoui [Wed, 19 Mar 2014 09:01:17 +0000 (11:01 +0200)]
Eolian: Integration of App Server
Daniel Zaoui [Thu, 20 Mar 2014 05:12:16 +0000 (07:12 +0200)]
Fix logically dead code.
CID 1193237
Before Eolian, a Eina_List ** was used and checking ret value was
mandatory. Now that we have a normal Eina_List *, we don't need to check
that anymore.
WooHyun Jung [Thu, 20 Mar 2014 05:14:20 +0000 (14:14 +0900)]
elm_win: Fix wrong animation of focus highlight.
When focus is changed, focus highlight animation should be started
from the original position of focus highlight object. Not from the
previous focused object's position.
Daniel Juyung Seo [Thu, 20 Mar 2014 04:48:49 +0000 (13:48 +0900)]
list: better structure packing for list smart data.
WooHyun Jung [Thu, 20 Mar 2014 03:55:28 +0000 (12:55 +0900)]
elm_widget: Restore removed codes while eolian work.
Daniel Juyung Seo [Wed, 19 Mar 2014 19:08:52 +0000 (04:08 +0900)]
cnp: Fixed cnp build warning by adding ifdef to cnp_debug.
This looks better.
Special thanks to barbieri for the suggestion.
Daniel Juyung Seo [Wed, 19 Mar 2014 19:04:12 +0000 (04:04 +0900)]
elm_widget: Call widget APIs only for widgets.
'cur' object can be non-widget object when calling
elm_widget_focus_direction_get and elm_widget_parent_get.
Daniel Juyung Seo [Wed, 19 Mar 2014 19:02:08 +0000 (04:02 +0900)]
test_list: Added focus/selection API test for list focus test case.
Added two buttons.
1. focus 3rd list item by elm_object_item_focus_set() API after 1.5 seconds.
2. select 3rd list item by elm_list_item_selected_set() API after 1.5 seconds.
Daniel Juyung Seo [Wed, 19 Mar 2014 18:44:47 +0000 (03:44 +0900)]
test_list: Used frame for focus option box.
Daniel Juyung Seo [Wed, 19 Mar 2014 17:13:41 +0000 (02:13 +0900)]
toolbar: Fixed wrong parameter for elm_widget_sub_object_del.
Remove the icon from the sub object list for a widget not for an edje object.
Daniel Juyung Seo [Wed, 19 Mar 2014 17:13:03 +0000 (02:13 +0900)]
scroller: Fixed wrong widget call to non-widget object.
content can be a non-widget object.
Daniel Juyung Seo [Wed, 19 Mar 2014 17:10:08 +0000 (02:10 +0900)]
cnp: Fixed build warning.
elm_cnp.c: In function '_x11_dnd_leave':
elm_cnp.c:1547:69: warning: unused parameter 'ev' [-Wunused-parameter]
Tom Hacohen [Wed, 19 Mar 2014 09:43:07 +0000 (09:43 +0000)]
Eolian helper: Update to regenerate if generator is updated.
This is a sync from efl.git
6a66af39cb388c308fe585c8f6d41c032c747c67
Thiep Ha [Wed, 19 Mar 2014 06:59:13 +0000 (15:59 +0900)]
[Elm_Dnd] Fix type matching of drag and drop target objects in X11.
Summary:
Type matching for drag and drop targets does not consider drop target objects' types.
For example, we have drag object which provides image type and drop target object which only accepts text type.
For current code, in _x11_dnd_drop function, we only check savedtypes.types with _x11_atoms.
As result, we allows the image to be dropped into text. You can refer to the test in D617.
This path fixes this issue by matching drag object's type with drop targets' types to find suitable one.
@fix
Reviewers: raster, JackDanielZ, seoz, woohyun
Differential Revision: https://phab.enlightenment.org/D628
Daniel Zaoui [Wed, 19 Mar 2014 06:34:16 +0000 (08:34 +0200)]
Eolian: fix dependency for .eo.c/h files.
When Eolian generator is updated, the .eo.c/h files of Elementary must be
regenerated.
Daniel Zaoui [Tue, 18 Mar 2014 15:37:44 +0000 (17:37 +0200)]
Eolian: Integration of App Client View
Daniel Zaoui [Tue, 18 Mar 2014 14:40:24 +0000 (16:40 +0200)]
Eolian: Integration of App Client
Daniel Zaoui [Tue, 18 Mar 2014 14:13:12 +0000 (16:13 +0200)]
Eolian: Fix ctor/dtor generation
Daniel Zaoui [Tue, 18 Mar 2014 12:27:07 +0000 (14:27 +0200)]
Eolian: Integration of Actionslider
Daniel Zaoui [Tue, 18 Mar 2014 11:47:23 +0000 (13:47 +0200)]
Eolian: Integration of Access
Flavio Ceolin [Tue, 18 Mar 2014 20:37:31 +0000 (17:37 -0300)]
list: Avoiding the same item receive focus twice
When the item was activated by double click it received the focus twice
and the second is after had emitted the activated signal.
Flavio Ceolin [Tue, 18 Mar 2014 20:15:36 +0000 (17:15 -0300)]
list: Fixing the focus on keyboard movement
Problem introduced on: fb13ad2
Daniel Juyung Seo [Tue, 18 Mar 2014 15:48:07 +0000 (00:48 +0900)]
genlist: Fixed annoying autoscrolling bug in genlist item focus.
Now, genlist does not autoscroll to last focused/selected item when the genlist
is focused. It tries to find the nearest visible item instead of the
last focused/selected item.
Daniel Zaoui [Tue, 18 Mar 2014 11:59:21 +0000 (13:59 +0200)]
Accessibility: unref the object only if it exists.
If the type returned by evas_object_type_get is "", no object will be
created. There is no reason why unref would be invoked.
It removes all the bad prints in accessibility tests about obj_id NULL.
@fix
Daniel Juyung Seo [Tue, 18 Mar 2014 10:14:39 +0000 (19:14 +0900)]
list/genlist: Fixed Home and End key event handling routine.
Move focus and selection when Home or End key is pressed.
@fix
This needs a partial backport to elementary-1.9
Daniel Juyung Seo [Tue, 18 Mar 2014 10:04:56 +0000 (19:04 +0900)]
elm_widget: Removed unnecessary if statement.
Daniel Juyung Seo [Tue, 18 Mar 2014 10:02:04 +0000 (19:02 +0900)]
elm_widget: Call elm_widget functions only for widgets.
Daniel Juyung Seo [Tue, 18 Mar 2014 05:09:01 +0000 (14:09 +0900)]
Revert "genlist no longer scrolls crazily"
This reverts commit
7a653914ad048c00871d2ef71a56185e5a7fb1ca.
I will fix this in another way.
Daniel Juyung Seo [Tue, 18 Mar 2014 05:08:41 +0000 (14:08 +0900)]
Revert "genlist now uses uniform item showing behavior when selecting items with keyboard"
This reverts commit
85332555e8d3e5b981cde10ba9a1675ef6a4936e.
I will fix this in another way.
Carsten Haitzler (Rasterman) [Tue, 18 Mar 2014 08:22:04 +0000 (17:22 +0900)]
warning--
Subhransu Sekhar Mohanty [Tue, 18 Mar 2014 08:18:09 +0000 (17:18 +0900)]
elm_theme: Added a cache in elm_theme for styles that are failed to load.
Summary:
Currenlty loading a style that is not present in the system hits the worst case path in elm_theme as it searches through all hirarchy before
reporting that the style is not there. if those styles requested frequently it will be a overhead as it will goes through all the theme files again.
To avoid that I have added a cache which will keep track of the styles whose loading were not sucessfull so that for future request we can simply check the
cache before looking into the hirarchy of theme files.
Reviewers: seoz, raster
Reviewed By: raster
CC: raster
Differential Revision: https://phab.enlightenment.org/D601
Carsten Haitzler (Rasterman) [Tue, 18 Mar 2014 06:33:07 +0000 (15:33 +0900)]
add soem more cb's for testign win state
Daniel Zaoui [Mon, 17 Mar 2014 14:48:52 +0000 (16:48 +0200)]
Eolian: Integration of Hover
Daniel Zaoui [Tue, 18 Mar 2014 07:01:28 +0000 (09:01 +0200)]
Eolian: Integration of Frame
Daniel Zaoui [Mon, 17 Mar 2014 13:52:41 +0000 (15:52 +0200)]
Eolian: Integration of Pan
Daniel Zaoui [Mon, 17 Mar 2014 11:44:40 +0000 (13:44 +0200)]
Eolian: Integration of Scrollable Interface
Daniel Zaoui [Tue, 18 Mar 2014 06:07:14 +0000 (08:07 +0200)]
Focus: fix segfault due to bad call to Eo function.
Due to Eolian auto-generation, legacy parameters are directly
transferred to Eo functions without conversion.
In this case, is_next was Eina_Bool in legacy and Eina_Bool * in Eo.
The logic code was expecting a pointer but was receiving a Eina_Bool.
The fix consists in giving the logic code the Eina_Bool instead of the
pointer.
@fix