Reid Kleckner [Fri, 3 Apr 2020 20:42:23 +0000 (13:42 -0700)]
[MS] Fix assert handling enum forward decls in hasVisibleDefinition
An enum may be considered to be a complete type if it was forward
declared. It may be declared with a fixed underlying type, or, in MSVC
compatiblity mode, with no type at all.
Previously, the code was written with special handling for fixed enums.
I generalized the code to check if the underlying integer type is known,
which should be the case when targetting the MSVC C++ ABI.
Fixes PR45409
Joerg Sonnenberger [Fri, 3 Apr 2020 22:48:02 +0000 (00:48 +0200)]
Avoid using std::max_align_t in pre-C++11 mode
Always depend on the compiler to have a correct implementation of
max_align_t in stddef.h and don't provide a fallback. For pre-C++11,
require __STDCPP_NEW_ALIGNMENT__ in <new> as provided by clang in all
standard modes. Adjust test cases to avoid testing or using max_align_t
in pre-C++11 mode and also to better deal with alignof(max_align_t)>16.
Document requirements of the alignment tests around natural alignment of
power-of-two-sized types.
Differential revision: https://reviews.llvm.org/D73245
Volodymyr Sapsai [Fri, 3 Apr 2020 23:25:37 +0000 (16:25 -0700)]
[ObjC generics] Fix not inheriting type bounds in categories/extensions.
When a category/extension doesn't repeat a type bound, corresponding
type parameter is substituted with `id` when used as a type argument. As
a result, in the added test case it was causing errors like
> type argument 'T' (aka 'id') does not satisfy the bound ('id<NSCopying>') of type parameter 'T'
We are already checking that type parameters should be consistent
everywhere (see `checkTypeParamListConsistency`) and update
`ObjCTypeParamDecl` to have correct underlying type. And when we use the
type parameter as a method return type or a method parameter type, it is
substituted to the bounded type. But when we use the type parameter as a
type argument, we check `ObjCTypeParamType` that wasn't updated and
remains `id`.
Fix by updating not only `ObjCTypeParamDecl` UnderlyingType but also
TypeForDecl as we use the underlying type to create a canonical type for
`ObjCTypeParamType` (see `ASTContext::getObjCTypeParamType`).
This is a different approach to fixing the issue. The previous one was
02c2ab3d8872416589bd1a6ca3dfb96ba373a3b9 which was reverted in
4c539e8da1b3de38a53ef3f7497f5c45a3243b61. The problem with the previous
approach was that `ObjCTypeParamType::desugar` was returning underlying
type for `ObjCTypeParamDecl` without applying any protocols stored in
`ObjCTypeParamType`. It caused inconsistencies in comparing types before
and after desugaring.
rdar://problem/
54329242
Reviewed By: erik.pilkington
Differential Revision: https://reviews.llvm.org/D72872
Francis Visoiu Mistrih [Fri, 3 Apr 2020 19:29:54 +0000 (12:29 -0700)]
[Driver] Handle all optimization-record options for Darwin LTO
clang with -flto does not handle -foptimization-record-path=<path>
This dulicates the code from ToolChains/Clang.cpp with modifications to
support everything in the same fashion.
Paula Toth [Fri, 3 Apr 2020 22:14:33 +0000 (15:14 -0700)]
[libc] Fix memcpy to adhere to qualified calls.
Summary: Switched to using the new memcpy implementation.
Reviewers: sivachandra, abrachet, gchatelet
Reviewed By: abrachet, gchatelet
Subscribers: mgorny, MaskRay, tschuett, libc-commits
Tags: #libc-project
Differential Revision: https://reviews.llvm.org/D77277
Jan Kratochvil [Fri, 3 Apr 2020 22:12:59 +0000 (00:12 +0200)]
[lldb] Findtypes -gmodules fix for too many matches
Apparently the intention was to copy the condition above:
if (types.GetSize() >= max_matches)
break;
So that if the iteration stopped because of too many matches we do not
add even more matches in this 'Clang modules' block downward.
It was implemented by:
SymbolFileDWARF: Unconditionally scan through clang modules. NFCish
fe9eaadd68307347d97698fd0a1646827eafd290
Differential Revision: https://reviews.llvm.org/D77336
Paula Toth [Fri, 3 Apr 2020 21:47:15 +0000 (14:47 -0700)]
[libc] Add strlen implementation.
Summary: This should fix the call to a non internal libc function.
Reviewers: sivachandra, abrachet
Reviewed By: sivachandra
Subscribers: xbolva00, mgorny, MaskRay, tschuett, libc-commits
Tags: #libc-project
Differential Revision: https://reviews.llvm.org/D77279
Jim Ingham [Wed, 18 Mar 2020 19:05:08 +0000 (12:05 -0700)]
Allow the ThreadPlanStackMap to hold the thread plans for threads
that were not reported by the OS plugin. To facilitate this, move
adding/updating the ThreadPlans for a Thread to the ThreadPlanStackMap.
Also move dumping thread plans there as well.
Added some tests for "thread plan list" and "thread plan discard" since
I didn't seem to have written any originally.
Differential Revision: https://reviews.llvm.org/D76814
Jim Ingham [Tue, 10 Mar 2020 23:18:11 +0000 (16:18 -0700)]
Move thread plan stacks into the Process, indexed by TID.
Differential Revision: https://reviews.llvm.org/D75880
Jim Ingham [Tue, 10 Mar 2020 21:04:42 +0000 (14:04 -0700)]
Make ThreadPlanTracers use TID & Process rather than Thread *.
Differential Revision: https://reviews.llvm.org/D75720
Jim Ingham [Tue, 10 Mar 2020 21:03:53 +0000 (14:03 -0700)]
Make ThreadPlans use TID and Process, rather than Thread *.
Differential Revision: https://reviews.llvm.org/D75711
Louis Dionne [Fri, 3 Apr 2020 21:50:39 +0000 (17:50 -0400)]
[libc++] Lit: Add default values for most arguments of test executors
Alex Zinenko [Fri, 3 Apr 2020 17:55:48 +0000 (19:55 +0200)]
[mlir] LoopToStandard conversion: support "if/else" with results
Summary:
A recent extension allowed the `loop.if` operation to return results yielded by
its regions. However, such operations could not be lowered to a CFG of standard
operations because it would have required to modify the argument list of a
block, which is not allowed in a conversion pattern. Now that the conversion
infrastructure supports block creation, use it to create a block with an
argument list that dominates the operations following the `loop.if` and forward
the results as arguments of this block.
Depends On D77416
Differential Revision: https://reviews.llvm.org/D77418
Sanjay Patel [Fri, 3 Apr 2020 21:09:38 +0000 (17:09 -0400)]
[InstCombine] add tests for freelyNegateValue with 'not'; NFC
Nico Weber [Fri, 3 Apr 2020 21:15:09 +0000 (17:15 -0400)]
Fix standalone clang builds after
fb80b6b2d58.
When clang is built against a prebuilt LLVM, LLVM_SOURCE_DIR is
empty, which due to a cmake quirk caused list lengths to get out
of sync. Add a workaround.
Nick Desaulniers [Fri, 3 Apr 2020 21:07:16 +0000 (14:07 -0700)]
[test] preformat test with update_llc_test_checks.py NFC
Summary:
Prior to landing D76961, preprocess via:
$ llvm/utils/update_llc_test_checks.py \
llvm/test/CodeGen/X86/callbr-asm-outputs.ll
Reviewers: void, MaskRay
Reviewed By: void, MaskRay
Subscribers: MaskRay, llvm-commits, srhines
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D77356
Scott Constable [Fri, 3 Apr 2020 20:41:34 +0000 (13:41 -0700)]
[X86] Add Support for Load Hardening to Mitigate Load Value Injection (LVI)
After finding all such gadgets in a given function, the pass minimally inserts
LFENCE instructions in such a manner that the following property is satisfied:
for all SOURCE+SINK pairs, all paths in the CFG from SOURCE to SINK contain at
least one LFENCE instruction. The algorithm that implements this minimal
insertion is influenced by an academic paper that minimally inserts memory
fences for high-performance concurrent programs:
http://www.cs.ucr.edu/~lesani/companion/oopsla15/OOPSLA15.pdf
The algorithm implemented in this pass is as follows:
1. Build a condensed CFG (i.e., a GadgetGraph) consisting only of the following components:
-SOURCE instructions (also includes function arguments)
-SINK instructions
-Basic block entry points
-Basic block terminators
-LFENCE instructions
2. Analyze the GadgetGraph to determine which SOURCE+SINK pairs (i.e., gadgets) are already mitigated by existing LFENCEs. If all gadgets have been mitigated, go to step 6.
3. Use a heuristic or plugin to approximate minimal LFENCE insertion.
4. Insert one LFENCE along each CFG edge that was cut in step 3.
5. Go to step 2.
6. If any LFENCEs were inserted, return true from runOnFunction() to tell LLVM that the function was modified.
By default, the heuristic used in Step 3 is a greedy heuristic that avoids
inserting LFENCEs into loops unless absolutely necessary. There is also a
CLI option to load a plugin that can provide even better optimization,
inserting fewer fences, while still mitigating all of the LVI gadgets.
The plugin can be found here: https://github.com/intel/lvi-llvm-optimization-plugin,
and a description of the pass's behavior with the plugin can be found here:
https://software.intel.com/security-software-guidance/insights/optimized-mitigation-approach-load-value-injection.
Differential Revision: https://reviews.llvm.org/D75937
Reid Kleckner [Fri, 3 Apr 2020 19:35:30 +0000 (12:35 -0700)]
[OpenMP][NFC] Remove the need to include `OpenMPClause.h`
See rational here: https://reviews.llvm.org/D76173#1922916
Time to compile Attr.h in isolation goes from 2.6s to 1.8s.
Original patch by Johannes, plus some additions from Reid to fix some
clang tooling targets.
Effect on transitive includes is marginal, though:
$ diff -u <(sort thedeps-before.txt) <(sort thedeps-after.txt) \
| grep '^[-+] ' | sort | uniq -c | sort -nr
104 - /usr/local/google/home/rnk/llvm-project/clang/include/clang/AST/OpenMPClause.h
87 - /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/Frontend/OpenMP/OMPContext.h
19 - /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/ADT/SmallSet.h
19 - /usr/local/google/home/rnk/llvm-project/llvm/include/llvm/ADT/SetVector.h
14 - /usr/include/c++/9/set
...
Differential Revision: https://reviews.llvm.org/D76184
Nicolas Vasilache [Fri, 3 Apr 2020 04:08:22 +0000 (00:08 -0400)]
[mlir][Linalg] Employ finer-grained control of C interface emission
Summary:
Linalg makes it possible to interface codegen with externally precompiled HPC libraries. The mechanism to allow such interop uses a normalized ABI and the emission of C interface wrappers.
The mechanism controlling these C interface emission is too aggressive and makes it very easy to obtained undefined symbols for external function (e.g. the ones coming from libm).
This revision uses the newly introduced llvm.emit_c_interface function attribute which allows controlling this behavior at a function granularity. As a consequence LinalgToLLVM does not need to activate the C wrapper emission when adding the StdToLLVM patterns.
Differential Revision: https://reviews.llvm.org/D77364
LLVM GN Syncbot [Fri, 3 Apr 2020 20:07:19 +0000 (20:07 +0000)]
[gn build] Port
c74dd640fd7
Julian Lettner [Thu, 24 Oct 2019 06:36:29 +0000 (23:36 -0700)]
[lit] Cleanly exit on user keyboard interrupt
Graceful lit shutdown on user keyboard interrupt [Ctrl+C] was a
longstanding goal of mine. After a few refactorings this revision
finally enables it. We use the following strategy to deal with
KeyboardInterrupt:
https://noswap.com/blog/python-multiprocessing-keyboardinterrupt
Printing of a helpful summary for interrupted runs (just as the one for
completed runs) will be tackled in future revisions.
Reviewed By: serge-sans-paille, rnk
Differential Revision: https://reviews.llvm.org/D77365
Scott Constable [Fri, 3 Apr 2020 19:12:51 +0000 (12:12 -0700)]
[X86] Add a Pass that builds a Condensed CFG for Load Value Injection (LVI) Gadgets
Adds a new data structure, ImmutableGraph, and uses RDF to find LVI gadgets and add them to a MachineGadgetGraph.
More specifically, a new X86 machine pass finds Load Value Injection (LVI) gadgets consisting of a load from memory (i.e., SOURCE), and any operation that may transmit the value loaded from memory over a covert channel, or use the value loaded from memory to determine a branch/call target (i.e., SINK).
Also adds a new target feature to X86: +lvi-load-hardening
The feature can be added via the clang CLI using -mlvi-hardening.
Differential Revision: https://reviews.llvm.org/D75936
Jan Kratochvil [Fri, 3 Apr 2020 19:58:11 +0000 (21:58 +0200)]
[nfc] [lldb] Unindent code - obvious part
It is an obvious part of D77326.
It removes some needless deep indentation and some redundant statements.
It prepares the code for a more clean next patch - DWARF index callbacks
in D77327.
LLVM GN Syncbot [Fri, 3 Apr 2020 19:47:51 +0000 (19:47 +0000)]
[gn build] Port
f95a67d8b8a
Kevin P. Neal [Fri, 3 Apr 2020 19:41:37 +0000 (15:41 -0400)]
Revert "[PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins"
The new test case causes bot failures.
This reverts commit
ba87430cadb2d5d0ee8e4b75101d7abcf6b321bf.
Andrew Ng [Fri, 3 Apr 2020 19:41:14 +0000 (15:41 -0400)]
Don't use relpaths in lit cfg if build/source dir are on different drives.
See discussion on https://reviews.llvm.org/D77184.
Paul Robinson [Fri, 3 Apr 2020 19:36:37 +0000 (12:36 -0700)]
Test had incorrect check for nonzero count
Lang Hames [Fri, 3 Apr 2020 19:25:32 +0000 (12:25 -0700)]
[ORC] Improve documention of memory ownership in the new Orc C bindings.
Kevin P. Neal [Fri, 3 Apr 2020 19:21:33 +0000 (15:21 -0400)]
Fix typo in test.
Differential Revision: https://reviews.llvm.org/D76949
Alina Sbirlea [Fri, 27 Mar 2020 22:02:23 +0000 (15:02 -0700)]
[GraphDiff] Extend GraphDiff to track a list of updates.
Summary:
This patch includes two extensions:
1. It extends the GraphDiff to also keep the original list of updates
after legalization, not just the deletes/insert vectors.
It also provides an API to pop the first update (the updates are store
in reverse, such that the first update is at the end of the list)
2. It adds a bool to mark whether the given updates should be applied as
given, or applied in reverse. This moves the task of reversing the
updates (when the caller needs this) to a functionality inside
GraphDiff, versus having the caller do this.
The two changes could be split into two patches, but they seemed
reasonably small to be reviewed together.
Reviewers: kuhar, dblaikie
Subscribers: hiraditya, george.burgess.iv, mgrang, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D77167
Scott Constable [Fri, 3 Apr 2020 17:58:38 +0000 (10:58 -0700)]
[X86] Add RET-hardening Support to mitigate Load Value Injection (LVI)
Adding a pass that replaces every ret instruction with the sequence:
pop <scratch-reg>
lfence
jmp *<scratch-reg>
where <scratch-reg> is some available scratch register, according to the
calling convention of the function being mitigated.
Differential Revision: https://reviews.llvm.org/D75935
Andrew Wock [Fri, 3 Apr 2020 18:55:27 +0000 (14:55 -0400)]
[PowerPC] Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins
This patch adds a test for the PowerPC fma compiler builtins, some variations
of which negate inputs and outputs. The code to generate IR for these
builtins was untested before this patch.
Originally, the code used the outdated method of subtracting floating point
values from -0.0 as floating point negation. This patch remedies that.
Patch by: Drew Wock <drew.wock@sas.com>
Differential Revision: https://reviews.llvm.org/D76949
Riyaz V Puthiyapurayil [Fri, 27 Mar 2020 23:17:52 +0000 (16:17 -0700)]
[compiler-rt] Build with correct ABI (PR38025)
Summary:
This patch fixes [[ https://bugs.llvm.org/show_bug.cgi?id=38025 | PR38025 ]]:
Wrong ABI used when building compiler-rt
Differential Revision: https://reviews.llvm.org/D74133
Matt Arsenault [Sun, 6 Mar 2016 19:48:28 +0000 (11:48 -0800)]
Support: Add specializations for reverseBits to use builtin
Matt Arsenault [Fri, 3 Apr 2020 17:22:51 +0000 (13:22 -0400)]
CodeGen: Convert some TII hooks to use Register
Matt Arsenault [Fri, 3 Apr 2020 17:07:00 +0000 (13:07 -0400)]
AMDGPU: Use Register in more places
Matt Arsenault [Fri, 3 Apr 2020 16:50:04 +0000 (12:50 -0400)]
AMDGPU: Remove redundant virtual
Louis Dionne [Fri, 3 Apr 2020 18:42:35 +0000 (14:42 -0400)]
[libc++] NFC: Remove unused CMake option
That option seems to be a remnant that has now been replaced by the
LIBCXXABI_STATICALLY_LINK_UNWINDER_IN_SHARED_LIBRARY setting.
Fixes PR45347.
Nathan James [Fri, 3 Apr 2020 18:40:59 +0000 (19:40 +0100)]
[clang-tidy] Address false positive in modernize-use-default-member-init
Summary: Fixes [[ https://bugs.llvm.org/show_bug.cgi?id=45363 | incorrect warning emitted by "modernize-use-default-member-init" (new to 10.0.0) ]].
Reviewers: aaron.ballman, alexfh, gribozavr2
Reviewed By: aaron.ballman
Subscribers: xazax.hun, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D77199
Stanislav Mekhanoshin [Fri, 3 Apr 2020 18:36:32 +0000 (11:36 -0700)]
[AMDGPU] Added label to test. NFC.
Alex Zinenko [Fri, 3 Apr 2020 17:53:13 +0000 (19:53 +0200)]
[mlir] DialectConversion: support block creation in ConversionPatternRewriter
PatternRewriter and derived classes provide a set of virtual methods to
manipulate blocks, which ConversionPatternRewriter overrides to keep track of
the manipulations and undo them in case the conversion fails. However, one can
currently create a block only by splitting another block into two. This not
only makes the API inconsistent (`splitBlock` is allowed in conversion
patterns, but `createBlock` is not), but it also make it impossible for one to
create blocks with argument lists different from those of already existing
blocks since in-place block updates are not supported either. Such
functionality precludes dialect conversion infrastructure from being used more
extensively on region-containing ops, for example, for value-returning "if"
operations. At the same time, ConversionPatternRewriter already allows one to
undo block creation as block creation is one of the primitive operations in
already supported region inlining.
Support block creation in conversion patterns by hooking `createBlock` on the
block action undo mechanism. This requires to make `Builder::createBlock`
virtual, similarly to Op insertion. This is a minimal change to the Builder
infrastructure that will later help support additional use cases such as block
signature changes. `createBlock` now additionally takes the types of the block
arguments that are added immediately so as to avoid in-place argument list
manipulation that would be illegal in conversion patterns.
Christopher Tetreault [Fri, 3 Apr 2020 18:24:59 +0000 (11:24 -0700)]
Clean up usages of asserting vector getters in Type
Summary:
Remove usages of asserting vector getters in Type in preparation for the
VectorType refactor. The existence of these functions complicates the
refactor while adding little value.
Reviewers: kparzysz, sdesmalen, efriedma
Reviewed By: kparzysz
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D77267
Stephen Neuendorffer [Tue, 31 Mar 2020 18:45:59 +0000 (11:45 -0700)]
[CMAKE] Plumb include_directories() into tablegen()
Previously, the tablegen() cmake command, which defines custom
commands for running tablegen, included several hardcoded paths. This
becomes unwieldy as there are more users for which these paths are
insufficient. For most targets, cmake uses include_directories() and
the INCLUDE_DIRECTORIES directory property to specify include paths.
This change picks up the INCLUDE_DIRECTORIES property and adds it
to the include path used when running tablegen. As a side effect, this
allows us to remove several hard coded paths to tablegen that are redundant
with specified include_directories().
I haven't removed the hardcoded path to CMAKE_CURRENT_SOURCE_DIR, which
seems generically useful. There are several users in clang which apparently
don't have the current directory as an include_directories(). This could
be considered separately.
The new version of this path uses list APPEND rather than list TRANSFORM,
in order to be compatible with cmake 3.4.3. If we update to cmake 3.12 then
we can use list TRANSFORM instead.
Differential Revision: https://reviews.llvm.org/D77156
Stanislav Mekhanoshin [Thu, 2 Apr 2020 23:06:45 +0000 (16:06 -0700)]
[AMDGPU] Propagate AGPR RC from PHI to its PHI operands
We can fix register class of PHI based on its all AGPR uses.
That leaves behind all PHIs which were already processed
earlier. Propagate RC back to PHI operands of a PHI.
Differential Revision: https://reviews.llvm.org/D77344
Louis Dionne [Fri, 3 Apr 2020 18:08:53 +0000 (14:08 -0400)]
[libc++] Remove support for specifying LIBCXX_CXX_ABI_SYSTEM manually
This was only kept until Chromium fixed their build of libc++, which
they have now done according to
https://bugs.chromium.org/p/chromium/issues/detail?id=1067216
Simon Pilgrim [Fri, 3 Apr 2020 17:53:38 +0000 (18:53 +0100)]
[YAMLParser] Scanner::setError - ensure we use the StringRef::iterator argument (PR45043)
As detailed on PR45043, static analysis was warning that the StringRef::iterator Position argument was being ignored and the function was hardwired to use the Current iterator.
This patch ensures we use the provided iterator and removes the (barely necessary) setError wrapper that always used Current.
Differential Revision: https://reviews.llvm.org/D76512
Sanjay Patel [Fri, 3 Apr 2020 17:53:54 +0000 (13:53 -0400)]
[VectorCombine] try to form a better extractelement
Extracting to the same index that we are going to insert back into
allows forming select ("blend") shuffles and enables further transforms.
Admittedly, this is a quick-fix for a more general problem that I'm
hoping to solve by adding transforms for patterns that start with an
insertelement.
But this might resolve some regressions known to be caused by the
extract-extract transform (although I have not gotten more details on
those yet).
In the motivating case from PR34724:
https://bugs.llvm.org/show_bug.cgi?id=34724
The combination of subsequent instcombine and codegen transforms gets us this improvement:
vmovshdup %xmm0, %xmm2 ## xmm2 = xmm0[1,1,3,3]
vhaddps %xmm1, %xmm1, %xmm4
vmovshdup %xmm1, %xmm3 ## xmm3 = xmm1[1,1,3,3]
vaddps %xmm0, %xmm2, %xmm0
vaddps %xmm1, %xmm3, %xmm1
vshufps $200, %xmm4, %xmm0, %xmm0 ## xmm0 = xmm0[0,2],xmm4[0,3]
vinsertps $177, %xmm1, %xmm0, %xmm0 ## xmm0 = zero,xmm0[1,2],xmm1[2]
-->
vmovshdup %xmm0, %xmm2 ## xmm2 = xmm0[1,1,3,3]
vhaddps %xmm1, %xmm1, %xmm1
vaddps %xmm0, %xmm2, %xmm0
vshufps $200, %xmm1, %xmm0, %xmm0 ## xmm0 = xmm0[0,2],xmm1[0,3]
Differential Revision: https://reviews.llvm.org/D76623
Sylvain Audi [Tue, 31 Mar 2020 21:21:31 +0000 (17:21 -0400)]
[Support/Path] sys::path::replace_path_prefix fix and simplifications
Added unit tests for 2 scenarios that were failing.
Made replace_path_prefix back to 3 parameters instead of 5, simplifying the implementation. The other 2 were always used with the default value.
This commit is intended to be the first of 3:
1) simplify/fix replace_path_prefix.
2) use it in the context of -fdebug-prefix-map and -fmacro-prefix-map (see D76869).
3) Make Windows version of replace_path_prefix insensitive to both case and separators (slash vs backslash).
Differential Revision: https://reviews.llvm.org/D77223
Louis Dionne [Fri, 3 Apr 2020 17:17:57 +0000 (13:17 -0400)]
[libc++] Remove useless nothing_to_do.pass.cpp tests
The testing script used to test libc++ historically did not like directories
without any testing files, so these tests had been added. Since this is
not necessary anymore, we can now remove these files. This has the benefit
that the total number of tests reflects the real number of tests more
closely, and we also skip some unnecessary work (especially relevant when
running tests over SSH).
However, some nothing_to_do.pass.cpp tests actually serve the purpose of
documenting that an area of the Standard doesn't need to be tested, or is
tested elsewhere. These files are not removed by this commit.
Removal done with:
import os
import itertools
for (dirpath, dirnames, filenames) in itertools.chain(os.walk('./libcxx/test'),
os.walk('./libcxxabi/test')):
if len(filenames + dirnames) > 1 and \
any(p == 'nothing_to_do.pass.cpp' for p in filenames):
os.remove(os.path.join(dirpath, 'nothing_to_do.pass.cpp'))
Stephen Neuendorffer [Fri, 3 Apr 2020 17:47:36 +0000 (10:47 -0700)]
Revert "[CMAKE] Plumb include_directories() into tablegen()"
This reverts commit
ae044c5b0caa095602b6ef4cca40d57efc26a8f6.
This breaks the buildbots, which use an older version of cmake.
Stephen Neuendorffer [Tue, 31 Mar 2020 18:45:59 +0000 (11:45 -0700)]
[CMAKE] Plumb include_directories() into tablegen()
Previously, the tablegen() cmake command, which defines custom
commands for running tablegen, included several hardcoded paths. This
becomes unwieldy as there are more users for which these paths are
insufficient. For most targets, cmake uses include_directories() and
the INCLUDE_DIRECTORIES directory property to specify include paths.
This change picks up the INCLUDE_DIRECTORIES property and adds it
to the include path used when running tablegen. As a side effect, this
allows us to remove several hard coded paths to tablegen that are redundant
with specified include_directories().
I haven't removed the hardcoded path to CMAKE_CURRENT_SOURCE_DIR, which
seems generically useful. There are several users in clang which apparently
don't have the current directory as an include_directories(). This could
be considered separately.
Differential Revision: https://reviews.llvm.org/D77156
Simon Pilgrim [Fri, 3 Apr 2020 17:25:53 +0000 (18:25 +0100)]
[X86][SSE] lowerShuffleWithPACK - extend to use chained PACKs for larger truncations
Extend lowerShuffleWithPACK/matchShuffleWithPACK/createPackShuffleMask to handle compaction style shuffle masks that can be lowered to chains of PACKSS/PACKUS if their inputs are suitably sign/zero extended.
This helps avoid PSHUFB (and its mask load) for short shuffle chains, shuffle combining will still replace with a PSHUFB if we have enough shuffles as getFauxShuffleMask should recognise the PACKSS/PACKUS chains.
Roman Lebedev [Fri, 3 Apr 2020 16:59:47 +0000 (19:59 +0300)]
Revert "[SCEV] rewriteLoopExitValues(): even if have hard uses, still rewrite if cheap (PR44668)"
As discussed in post-commit review in https://reviews.llvm.org/D73501
if the goal of this is to help vectorizer, then we should actually
be teaching vectorizer to do this, because right now this rewrite
is still budget-limited, which isn't what we'd want.
Additionally, while the rest of the patch series was universally profitable,
this particular patch is reportedly (https://reviews.llvm.org/D73501#1905171)
exposing cost-modeling issues on ARM.
So let's just back this particular patch out. Once there's an undo transform,
this could be considered for reintegration.
This reverts commit
44edc6fd2c63b7db43e13cc8caf1fee79bebdb5f.
Roman Lebedev [Fri, 3 Apr 2020 16:30:38 +0000 (19:30 +0300)]
[NFC] Move ARM `opt -indvars` test from Codegen into Transforms
They are really not codegen tests.
Simon Pilgrim [Fri, 3 Apr 2020 17:09:44 +0000 (18:09 +0100)]
[LoopStrengthReduce] Fix test checks to fix issue reported on D77227
Michael Liao [Fri, 3 Apr 2020 14:17:06 +0000 (10:17 -0400)]
[cuda][hip] Fix `RegisterVar` function prototype.
Summary:
- `RegisterVar` has `void` return type and `size_t` in its variable size
parameter in HIP or CUDA 9.0+.
Reviewers: tra, yaxunl
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D77398
Simon Pilgrim [Fri, 3 Apr 2020 16:48:05 +0000 (17:48 +0100)]
[AArch64] Fix swap-compare-operands test names to fix issue reported on D77354
Load of copy+paste errors in the label checks that needed fixing before the missing ":" could be added
Sanjay Patel [Fri, 3 Apr 2020 16:21:34 +0000 (12:21 -0400)]
[PhaseOrdering] add shuffle tests based on D40633; NFC
We got some of the potential optimizations with D76727 and D76844.
There are 2 likely enhancements that we could add to -vector-combine
to get most of the remaining cases:
1. Allow bitcasted shuffle mask narrowing (widen the elements).
2. Combine shuffle-of-shuffle into a single shuffle.
This is already partly handled by the x86 backend, but the
tests here show that we still miss some of the potential
combines.
John Brawn [Mon, 16 Mar 2020 17:28:11 +0000 (17:28 +0000)]
[ARM] Fix incorrect handling of big-endian vmov.i64
Currently when the target is big-endian vmov.i64 reverses the order of the two
words of the vector. This is correct only when the underlying element type is
32-bit, as actually what it should be doing is considering it a vector of the
underlying type and reversing the elements of that.
Differential Revision: https://reviews.llvm.org/D76515
John Brawn [Tue, 17 Mar 2020 17:58:04 +0000 (17:58 +0000)]
[ARM] Avoid pointless vrev of element-wise vmov
If we have an element-wise vmov immediate instruction then a subsequent vrev
with width greater or equal to the vmov element width, then that vrev won't do
anything. Add a DAG combine to convert bitcasts that would become such vrevs
into vector_reg_casts instead.
Differential Revision: https://reviews.llvm.org/D76514
John Brawn [Thu, 2 Apr 2020 17:20:16 +0000 (18:20 +0100)]
Run update_llc_test on test/CodeGen/ARM/vmov.ll
This is in preparation for D76514
Simon Pilgrim [Fri, 3 Apr 2020 16:29:06 +0000 (17:29 +0100)]
[InstSimplify] Regenerate compares tests to fix issue reported on D77354
Jonas Devlieghere [Fri, 3 Apr 2020 16:18:47 +0000 (09:18 -0700)]
[lldb/Support] Treat empty FileSpec as an invalid file.
LLDB relies on empty FileSpecs being invalid files, for example, they
don't exists. Currently this assumption does not always hold during
reproducer replay, because we pass the result of GetPath to the VFS.
This is an empty string, which the VFS converts to an absolute directory
by prepending the current working directory, before looking it up in the
YAML mapping. This means that an empty FileSpec will exist when the
current working directory does. This breaks at least one test
(TestAddDsymCommand.py) when ran from replay.
This patch special cases empty FileSpecs and returns a sensible result
before calling GetPath and forwarding the call.
Differential revision: https://reviews.llvm.org/D77351
Jonas Devlieghere [Fri, 3 Apr 2020 15:33:55 +0000 (08:33 -0700)]
[lldb/Symbol] Reimplement Symbols::FindSymbolFileInBundle to use the VFS
This reimplements Symbols::FindSymbolFileInBundle to use the VFS-aware
recursive directory iterator. This is needed for reproducer replay.
Differential revision: https://reviews.llvm.org/D77337
Simon Pilgrim [Fri, 3 Apr 2020 16:21:37 +0000 (17:21 +0100)]
[LoopRotate] Cleanup test checks to fix issue reported on D77354
Simon Pilgrim [Fri, 3 Apr 2020 16:00:17 +0000 (17:00 +0100)]
[PowerPC] Regenerate f128 test to fix issue reported on D77354
I had to manually edit the file as the update script won't strip checks that don't have the ":" immediately after the prefix
Matt Arsenault [Fri, 3 Apr 2020 15:09:19 +0000 (11:09 -0400)]
InstCombine: Reduce minnum/maxnum if inputs are casted
Fangrui Song [Fri, 3 Apr 2020 05:10:43 +0000 (22:10 -0700)]
[ELF] Allow invalid sh_size%sh_entsize!=0 for non-SHF_MERGE sections
Fixes https://bugs.llvm.org/show_bug.cgi?id=45370
Fixes https://github.com/Clozure/ccl/issues/273
.stab holds a table of 12-byte entries. GNU as before 2.35 incorrectly
sets sh_entsize(.stab) to 20 on 64-bit architectures:
https://sourceware.org/bugzilla/show_bug.cgi?id=25768
We should not emit the confusing error:
"SHF_MERGE section size (...) must be a multiple of sh_entsize (20)
Reviewed By: grimar, psmith
Differential Revision: https://reviews.llvm.org/D77368
Simon Pilgrim [Fri, 3 Apr 2020 15:45:56 +0000 (16:45 +0100)]
[X86] Remove defunct section checks from emulated TLS tests to fix issue reported on D77354
Louis Dionne [Mon, 30 Mar 2020 20:25:24 +0000 (16:25 -0400)]
[libc++] Add an alternative Lit test format
This new test format is simpler and more flexible. It creates Lit ShTests
on the fly that reuse existing substitutions (like %{cxx}) instead of
having complex logic in Python to run the tests. This has the benefit
that virtually no coding is required to customize how the test suite is
run -- one can achieve pretty much anything by defining the appropriate
substitutions in a simple lit.cfg file.
For example, in order to run the tests on an embedded device after
building with a specific SDK, one can set the %{cxx} and %{compile_flags}
substitutions to use that SDK, and the %{exec} substitution to the ssh.py
script currently used for .sh.cpp tests with a remote executor. Dealing with
the SSHExecutor becomes unnecessary, since all tests are treated like ShTests.
As a side effect of this design, configuration files for the test
suite can be as simple as:
config.substitutions.append(('%{cxx}', '<path-to-compiler>'))
config.substitutions.append(('%{compile_flags}', '<flags>'))
config.substitutions.append(('%{link_flags}', '<flags>'))
config.substitutions.append(('%{exec}', '<script-to-execute>'))
This should allow storing lit.cfg files for various configurations
directly in the repository instead of relying on complicated logic
in config.py to set up the right flags. I've found numerous problems
in that logic in the past years, and it seems like having simple and
explicit configuration files for the configurations we support is
going to solve most of these problems. Specifically, I am hoping to
store configuration files for testing other Standard Libraries in
the repository.
Improving the interaction with the test suite configuration is still a
work in progress, so for now this test format reuses the substitutions and
available features that are set up by the current config.py.
This new test format should support pretty much everything that the current
test format supports, however it will not be enabled by default at first to
make sure we're satisfied with it. For a short period of time, the new format
will require `--param=use_new_format=True` to be enabled, however it is a very
short term goal to replace the current testing format entirely and to simplify
the configuration accordingly.
Differential Revision: https://reviews.llvm.org/D77338
Sam McCall [Thu, 2 Apr 2020 20:53:01 +0000 (22:53 +0200)]
[AST] clang::VectorType supports any size (that fits in unsigned)
Summary:
This matches llvm::VectorType.
It moves the size from the type bitfield into VectorType, increasing size by 8
bytes (including padding of 4). This is OK as we don't expect to create terribly
many of these types.
c.f. D77313 which enables large power-of-two sizes without growing VectorType.
Reviewers: efriedma, hokein
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D77335
Ilya Leoshkevich [Fri, 3 Apr 2020 13:15:06 +0000 (15:15 +0200)]
[MSan] Add COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED
Summary:
MSan not implementing COMMON_INTERCEPTOR_NOTHING_IS_INITIALIZED looks
like an omission - this macro makes it possible for those intercepted
functions, which libc needs very early, to work before interceptors are
initialized (i.e. before REAL() is usable).
While currently there are no observable practical problems in this
area, changes in libc or in MSan runtime may provoke them. Therefore,
change MSan to work like ASan and TSan already do - use internal
functions in certain interceptors when initialization is not complete.
Reviewers: eugenis, vitalybuka
Reviewed By: eugenis
Subscribers: #sanitizers
Tags: #sanitizers
Differential Revision: https://reviews.llvm.org/D76969
Simon Pilgrim [Fri, 3 Apr 2020 15:14:47 +0000 (16:14 +0100)]
[X86] Fix weak global label issue reported on D77354
Simon Pilgrim [Fri, 3 Apr 2020 15:09:17 +0000 (16:09 +0100)]
[X86] Fix gisel copy tests to fix issue reported on D77354
Simon Pilgrim [Fri, 3 Apr 2020 14:37:18 +0000 (15:37 +0100)]
[X86] Fix strong local function/global label issue reported on D77354
Simon Pilgrim [Fri, 3 Apr 2020 14:15:17 +0000 (15:15 +0100)]
[X86] Cleanup emulated TLS test checks. NFC
Benjamin Kramer [Fri, 3 Apr 2020 15:12:40 +0000 (17:12 +0200)]
[LoopOps] Return ArrayRefs from accessors instead of iterator_ranges
Same funcitonality, but a bit friendlier for users passing it along to
APIs that take ArrayRefs.
Louis Dionne [Fri, 3 Apr 2020 15:06:26 +0000 (11:06 -0400)]
[libc++] Fix is_pointer support for Objective-C++
This test regressed with
5ade17e0ca8b, but we never noticed it because
.pass.mm tests were skipped due to a bug in our Lit config. This commit
fixes is_pointer (by essentially reverting tha part of
5ade17e0ca8b) and
also adds .pass.mm tests to the list of supported test suffixes.
We can explore how to support __is_pointer with Objective-C++ qualifiers
as a follow-up -- the main goal of this commit is to fix the regression
quickly and make sure all tests of the suite are run.
Guillaume Chatelet [Fri, 3 Apr 2020 14:16:09 +0000 (14:16 +0000)]
[Alignment][NFC] Remove documentation and FIXME for deprecated functions
Louis Dionne [Thu, 2 Apr 2020 22:28:21 +0000 (18:28 -0400)]
[libc++] Add REQUIRES for tests that need -fblocks and -fobjc-arc
AppleClang seems to support these extensions by default, but other
compilers don't.
Yaxun (Sam) Liu [Fri, 3 Apr 2020 13:24:58 +0000 (09:24 -0400)]
Fix __builtin_amdgcn_workgroup_size_x/y/z return type
https://reviews.llvm.org/D77390
Simon Pilgrim [Fri, 3 Apr 2020 13:55:13 +0000 (14:55 +0100)]
[X86] Regenerate soft fp legalization test to fix issue reported on D77354
Simon Pilgrim [Fri, 3 Apr 2020 13:52:24 +0000 (14:52 +0100)]
[X86] Regenerate stack clash test to fix issue reported on D77354
Sid Manning [Thu, 2 Apr 2020 17:08:53 +0000 (12:08 -0500)]
[Hexagon] Fix issue with non-preemptible STT_TLS symbols
A PC-relative relocation referencing a non-preemptible absolute symbol
(due to STT_TLS) is not representable in -pie/-shared mode.
Differential Revision: https://reviews.llvm.org/D77021
LLVM GN Syncbot [Fri, 3 Apr 2020 13:41:09 +0000 (13:41 +0000)]
[gn build] Port
d65557d15d4
Sam McCall [Thu, 2 Apr 2020 23:41:40 +0000 (01:41 +0200)]
[clangd] Enable some nice clang-tidy checks by default.
Reviewers: hokein
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D77348
Kadir Cetinkaya [Fri, 3 Apr 2020 13:34:37 +0000 (15:34 +0200)]
Revert "Use git-clang-format as Arcanist linter"
This reverts commit
31b6e182f2ce957c86b961e21b9eb82bbcea7c59.
As it was breaking `arc diff` workflow for multiple people.
jasonliu [Fri, 3 Apr 2020 13:13:13 +0000 (13:13 +0000)]
[NFC][XCOFF][AIX] Refactor get/setContainingCsect
Summary:
For current architect, we always require setContainingCsect to be
called on every MCSymbol got used in XCOFF context.
This is very hard to achieve because symbols gets created everywhere
and other MCSymbol types(ELF, COFF) do not have similar rules.
It's very easy to miss setting the containing csect, and we would
need to add a lot of XCOFF specialized code around some common code area.
This patch intendeds to do
1. Rely on getFragment().getParent() to get csect from labels.
2. Only use get/setRepresentedCsect (was get/setContainingCsect)
if symbol itself represents a csect.
Reviewers: DiggerLin, hubert.reinterpretcast, daltenty
Differential Revision: https://reviews.llvm.org/D77080
Simon Atanasyan [Fri, 3 Apr 2020 13:20:09 +0000 (16:20 +0300)]
[mips][test] Remove redundant and invalid `CHECK-NOT` directives. NFC
1. It's redundant to explicitly check that string does not contain `PAUSE_MM`
token if check that the `PAUSE` token is followed by an angle bracket.
2. The removed `CHECK-NOT` directives do not have trailing colons.
Guillaume Chatelet [Thu, 2 Apr 2020 15:10:30 +0000 (15:10 +0000)]
[Alignment][NFC] Deprecate InstrTypes getRetAlignment/getParamAlignment
Summary:
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D77312
Simon Pilgrim [Fri, 3 Apr 2020 12:50:41 +0000 (13:50 +0100)]
[X86][AVX] Add tests showing failure to use chained PACKSS/PACKUS for multi-stage compaction shuffles
The sign/zero extended top bits mean that we could use chained PACK*S ops here
Yaxun (Sam) Liu [Thu, 2 Apr 2020 21:16:03 +0000 (17:16 -0400)]
[AMDGPU] Allow AGPR in inline asm
Differential Revision: https://reviews.llvm.org/D77329
Konrad Kleine [Fri, 3 Apr 2020 12:49:47 +0000 (14:49 +0200)]
[lldb][nfc] early exit/continue
Summary:
This commit just tries to invert some `if`'s logic to
`return`/`continue` early.
Reviewers: jankratochvil, teemperor
Reviewed By: jankratochvil, teemperor
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D77377
Martin Probst [Thu, 2 Apr 2020 14:53:17 +0000 (16:53 +0200)]
clang-format: [JS] detect C++ keywords.
Summary:
C++ defines a number of keywords that are regular identifiers in
JavaScript, e.g. `concept`:
const concept = 1; // legit JS
This change expands the existing `IsJavaScriptIdentifier(Tok)` function
to return false for C++ keywords that aren't keywords in JS.
Reviewers: krasimir
Subscribers: jfb, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D77311
Denis Khalikov [Fri, 3 Apr 2020 09:03:00 +0000 (12:03 +0300)]
[mlir][vulkan-runner] Add support for 3D memrefs.
Summary:
Add support for 3D memrefs in mlir-vulkan-runner and simple test.
Differential Revision: https://reviews.llvm.org/D77157
Benjamin Kramer [Fri, 3 Apr 2020 10:46:05 +0000 (12:46 +0200)]
Drop unused diagnostic. NFC.
Benjamin Kramer [Fri, 3 Apr 2020 10:45:18 +0000 (12:45 +0200)]
Make helpers static. NFC.
Peter Smith [Mon, 30 Mar 2020 14:04:26 +0000 (15:04 +0100)]
[LLD][ELF][ARM] use .reloc directive for Thumb assembler tests
In the near future llvm-mc will resolve the fixups that generate
R_ARM_THUMB_PC8 and R_ARM_THUMB_PC12 at assembly time (see comments in
D72892), and forbid inter-section references. Change the LLD tests for
these relocations to use .inst and .reloc to avoid LLD tests failing when
this happens. The tests generate the same instructions, relocations
and symbols.
I will need to make equivalent changes for D75349 Arm equivalent
relocations, but this is still in review so these don't need changing
before llvm-mc.
Differential Revision: https://reviews.llvm.org/D77200
Guillaume Chatelet [Thu, 2 Apr 2020 12:24:51 +0000 (12:24 +0000)]
[Alignment][NFC] Remove unused private functions
Summary:
This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D77297
Jay Foad [Fri, 3 Apr 2020 09:06:34 +0000 (10:06 +0100)]
[AMDGPU] Fix CHECK lines