platform/core/api/webapi-plugins.git
5 years agoMerge "[messaging][bugfix] Don't convert filter's matchValue to String" into tizen
Piotr Kosko [Fri, 18 Oct 2019 11:37:12 +0000 (11:37 +0000)]
Merge "[messaging][bugfix] Don't convert filter's matchValue to String" into tizen

5 years ago[messaging][bugfix] Don't convert filter's matchValue to String 64/211864/3
Pawel Wasowski [Wed, 27 Feb 2019 16:06:45 +0000 (17:06 +0100)]
[messaging][bugfix] Don't convert filter's matchValue to String

Due to a conversion of matchValue to String, filters with boolean
matchValues did not match objects.

[Verification] All subtest cases, dealing with boolean attributes,
introduced in TCT in commit
https://review.tizen.org/gerrit/#/c/test/tct/web/api/+/199159/
passed.

This commit has already been reviewed:
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/200661/
Change-Id of the original change was:
I72fc83328e92529455460469c5dbc1aadc6ce07e

Signed-off-by: Pawel Wasowski <p.wasowski2@samsung.com>
Change-Id: Ia8d769b1a9694defdcb403761cff9c2565f5f52b

5 years agoMerge "[mediacontroller][fix] fix small issues" into tizen
Piotr Kosko [Fri, 18 Oct 2019 11:32:39 +0000 (11:32 +0000)]
Merge "[mediacontroller][fix] fix small issues" into tizen

5 years ago[mediacontroller][fix] fix small issues 37/215837/3
Dawid Juszczak [Wed, 16 Oct 2019 09:37:11 +0000 (11:37 +0200)]
[mediacontroller][fix] fix small issues

issues:
- startup state of server's repeat state was REPEAT_OFF,
  should be REPEAT_ALL
- if client sent request to change attribute to
  currently set value, callback was not invoked. Now
  it is fixed.
- add repeatState to playbackInfo returned by
  playbackInfo getter

[Verification]
tct-mediacontroller-tizen-tests 100% PASS

Change-Id: Iebdbf2ca3af1d395c2ba10753e0ef7efcdc11953
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
5 years ago[mediacontroller][5.5] fix method to update playback item 98/215898/2 accepted/tizen_5.5_unified_mobile_hotfix tizen_5.5_mobile_hotfix accepted/tizen/5.5/unified/20191031.030714 accepted/tizen/5.5/unified/mobile/hotfix/20201027.065403 accepted/tizen/unified/20191018.054156 submit/tizen/20191017.093445 submit/tizen_5.5/20191031.000002 submit/tizen_5.5_mobile_hotfix/20201026.185102 tizen_5.5.m2_release
Dawid Juszczak [Thu, 17 Oct 2019 09:02:32 +0000 (11:02 +0200)]
[mediacontroller][5.5] fix method to update playback item

[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-240

[description]
removed checking if playlist exists on device, because
some 3rd party application can get the playlist
from the 3rd party server(such as cloud) directly and we
don't have any information about its name and index

[verification]
MediaControllerServer_updatePlaybackItem_invalid.html - only
this testcase fails (from tct-mediacontroller-tizen-tests).
It needs to be changed/removed

Change-Id: I7809b662a2eb9b99af3690892133e85ed9b41865
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
5 years ago[mediacontroller] Autoformatting changes in mediacontroller. 07/215607/1
Michal Michalski [Fri, 11 Oct 2019 09:15:08 +0000 (11:15 +0200)]
[mediacontroller] Autoformatting changes in mediacontroller.

Autoformatting of changes in mediacontroller.

Change-Id: I8e576444123cdc98766c41ae014073964757fc0e
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
5 years ago[mediacontroller] SendEvent() js tests fixed + code autoformat. 82/215482/5 accepted/tizen/unified/20191016.000334 submit/tizen/20191011.083112
Michal Michalski [Wed, 9 Oct 2019 08:26:10 +0000 (10:26 +0200)]
[mediacontroller] SendEvent() js tests fixed + code autoformat.

+ Executed ./code_format script on mediacontroller source code.
+ Fixed invalid tests for MediaControllerClientInfo::sendEvent() method.
+ Fixed minor issues from earlier reviews.
+ initialized all JsonCallbacks to nullptr in constructors of MediaControllerClient/Server

[Verification] tests from test_custom_event.js 100% pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9514897908e8221ed6f1c8eb1c1ed0083bad0996

5 years ago[version] 2.53 76/215476/1 accepted/tizen/unified/20191011.015355 submit/tizen/20191009.054725
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Wed, 9 Oct 2019 05:46:11 +0000 (07:46 +0200)]
[version] 2.53

Change-Id: I91b439ad78c3c11da5ed5622ce55d0e84a3253fb

5 years ago[utils][mediacontroller] SendEvent() method implementation. 72/215472/5
Michal Michalski [Tue, 8 Oct 2019 15:10:04 +0000 (17:10 +0200)]
[utils][mediacontroller] SendEvent() method implementation.

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209

SendEvent()
SendReply()

[Verification] TCT: mediacontroller and deprecated API 100% pass.
  New features tested in chrome console.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: If2230979c33f253fbd80171937ac64a8d90d4215

5 years ago[mediacontroller] Add UnsetCustomEventListener() method. 70/215470/3
Michal Michalski [Tue, 8 Oct 2019 13:45:45 +0000 (15:45 +0200)]
[mediacontroller] Add UnsetCustomEventListener() method.

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209

MediaControllerClient::UnsetCustomEventListener() method implementation.

[Verification] Will be done later with SendEvent().

Change-Id: I7c92243b0abe211dfa11735a11dc29b1fa0496dd
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
5 years ago[mediacontroller] Add MediaControllerClient::SetCustomEventListener() 68/215468/3
Michal Michalski [Tue, 8 Oct 2019 13:10:50 +0000 (15:10 +0200)]
[mediacontroller] Add MediaControllerClient::SetCustomEventListener()

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209

MediaControllerClient::SetCustomEventListener() method implementation.

[Verification] Will be verified later with SendEvent().

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Id30be750edc940e331053c353dc0944ef7d2f18a

5 years ago[mediacontroller] Add MediaControllerClientInfo interface. 64/215464/5
Michal Michalski [Tue, 8 Oct 2019 11:19:00 +0000 (13:19 +0200)]
[mediacontroller] Add MediaControllerClientInfo interface.

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209

+ MediaControllerClientInfo:
+ attribute name: string

MediaControllerServer:
+ getAllClientsInfo()

[Verification] Unit tests for MediaControllerClientInfo pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I321865c99059a21b02f6bdf9f48f9f001fbf2642

5 years ago[mediacontroller][ut] Custom events tests. 63/215463/3
Michal Michalski [Tue, 8 Oct 2019 09:53:19 +0000 (11:53 +0200)]
[mediacontroller][ut] Custom events tests.

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-209

Tests for custom events feature of media controller.

[Verification] none.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5069f64fc9ff6514ebe830eec30c1777b99bdffe

5 years ago[version] 2.52 30/215230/1 accepted/tizen/unified/20191004.003652 submit/tizen/20191003.122907
Lukasz Bardeli [Thu, 3 Oct 2019 11:37:03 +0000 (13:37 +0200)]
[version] 2.52

Change-Id: Ic95f124aaf9c015dc6f17d528d88ab32d2ea14b6
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
5 years ago[mediacontroller][fix] fix metadata issue 18/215218/5
Dawid Juszczak [Wed, 2 Oct 2019 14:25:12 +0000 (16:25 +0200)]
[mediacontroller][fix] fix metadata issue

Problem was connected to PlaybackInfo.metadata.
It was throwing an error while null value was set as encoded attributes
like resolution, episode and season. Now it is fixed by checking if
value is null before decoding it.

[Verification]
tested manually on chrome console
tct-deprecatedapi-tizen-tests 100% PASS
tct-mediacontroller-tizen-tests 100% PASS

Change-Id: Ibc0f44591b75dd53348ff1db2900e3da581534a0
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
5 years agoMerge "[fix][mediacontroller] fix error with new metadata features" into tizen accepted/tizen/unified/20191001.064828 submit/tizen/20190930.141103
Piotr Kosko [Mon, 30 Sep 2019 14:03:03 +0000 (14:03 +0000)]
Merge "[fix][mediacontroller] fix error with new metadata features" into tizen

5 years ago[fix][mediacontroller] fix error with new metadata features 92/214992/1
Dawid Juszczak [Mon, 30 Sep 2019 14:01:35 +0000 (16:01 +0200)]
[fix][mediacontroller] fix error with new metadata features

Change-Id: I957a41a84d1a8382c060ea615485c0c0f4d18602
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
5 years agoMerge "[mediacontroller] add api for new metadata features" into tizen
Piotr Kosko [Mon, 30 Sep 2019 13:44:44 +0000 (13:44 +0000)]
Merge "[mediacontroller] add api for new metadata features" into tizen

5 years ago[mediacontroller] add api for new metadata features 14/214814/5
Dawid Juszczak [Thu, 26 Sep 2019 14:23:22 +0000 (16:23 +0200)]
[mediacontroller] add api for new metadata features

[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-238

[Verification]
tested manually on chrome console
tct-mediacontroller-tizen-tests 100% PASS

Change-Id: I459724bfa88ab9a37a97be55eda0bd2e01e83add
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
5 years agoMerge changes I5e7e74fa,Icc3aa5bb into tizen
Piotr Kosko [Mon, 30 Sep 2019 10:46:50 +0000 (10:46 +0000)]
Merge changes I5e7e74fa,Icc3aa5bb into tizen

* changes:
  [mediacontroller] Check for errors added.
  [mediacontroller] Magic strings to constants.

5 years ago[mediacontroller] Check for errors added. 13/214913/4
Michal Michalski [Fri, 27 Sep 2019 10:48:45 +0000 (12:48 +0200)]
[mediacontroller] Check for errors added.

+ Result of native call to SendCommand was not checked for failure.
This commit adds this validation.

+ Added return after error occured in AddPlaybackInfoChangeList().

[Verification] All tests pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5e7e74faa1c8902f35e45278c7c05778094867c4

5 years ago[mediacontroller] Magic strings to constants. 15/214515/3
Michal Michalski [Mon, 23 Sep 2019 13:35:42 +0000 (15:35 +0200)]
[mediacontroller] Magic strings to constants.

Keys of args passed from JS to instance methods were used
as inline strings, rather than constants.

[Verification] MediaController TCT tests 20190920 100% pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Icc3aa5bb5bd947cf6bb680d15f4edc077901361b

5 years agoMerge branch 'tizen_5.0' into tizen 10/214910/1
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Fri, 27 Sep 2019 10:16:12 +0000 (12:16 +0200)]
Merge branch 'tizen_5.0' into tizen

Change-Id: I02a3c6d93c0924a0cf313110a3f79c4b67a7def8

5 years agoMerge branch 'tizen_4.0' into tizen_5.0 06/214906/1
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Fri, 27 Sep 2019 09:59:38 +0000 (11:59 +0200)]
Merge branch 'tizen_4.0' into tizen_5.0

Change-Id: I6307aead894899f049bacde9cb8af54febe91251

5 years agoMerge branch 'tizen_3.0' into tizen_4.0 01/214901/1
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Fri, 27 Sep 2019 09:15:05 +0000 (11:15 +0200)]
Merge branch 'tizen_3.0' into tizen_4.0

Change-Id: Iea1a8a0914572301a28c53d54bf64c795237ce44

5 years ago[version] 2.35 80/214880/1
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Fri, 27 Sep 2019 08:36:20 +0000 (10:36 +0200)]
[version] 2.35

Change-Id: Ifc5a4e534e395579031af9d3d115389b7545ab77

5 years ago[Filesystem] Source code auto-formatting 79/214879/1
Rafal Walczyna [Fri, 27 Sep 2019 08:33:30 +0000 (10:33 +0200)]
[Filesystem] Source code auto-formatting

Used: ./code_format src/ -c -js

Change-Id: I1a27efa220445342ec42ef5327d06ac7bdd40ca9
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
5 years ago[Archive] Fix for retrieving virtual roots 54/214854/2
Szymon Jastrzebski [Fri, 12 Jan 2018 10:07:53 +0000 (11:07 +0100)]
[Archive] Fix for retrieving virtual roots

Current implmentation gets only internal virtual roots. This change adds
getting external roots as well.

[Verification] TCT Archive passed with 100% p.r.

Change-Id: Ia961dd276901ed31d42b22d93148d51066276163
Signed-off-by: Szymon Jastrzebski <s.jastrzebsk@partner.samsung.com>
5 years ago[Filesystem] List of virtual roots for resolve function fixed. 53/214853/2
Rafal Walczyna [Tue, 24 Sep 2019 14:23:38 +0000 (16:23 +0200)]
[Filesystem] List of virtual roots for resolve function fixed.

Current implementation of virtual roots list did not include internal0 or
external memory i.e. SDCard or USBDrive. It results in not working resolve()
function, when location to resolve was on external memory.

Verification: TCT - 100 % pass.

Change-Id: I11c2537a7f5643f8c9ccfe2f45be9f3bce3edf00
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
5 years ago[mediacontroller][fix] fixed error with subscribe method 04/214504/1
Dawid Juszczak [Mon, 23 Sep 2019 09:58:34 +0000 (11:58 +0200)]
[mediacontroller][fix] fixed error with subscribe method

before that commit, if subscribed method was executed
on already subscribed server then unknown error was thrown
Now it is fixed.

[verification]
tested manually on chrome console

Change-Id: I7d5fe3d0d09eb95d6542ebfb2e163ca32c5d01a0
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
5 years ago[version] 2.50 74/214274/1 accepted/tizen/unified/20190920.065316 submit/tizen/20190919.123326
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Thu, 19 Sep 2019 12:31:55 +0000 (14:31 +0200)]
[version] 2.50

Change-Id: I397c4edbc48cebaf72582a9a60d547256bcd6d6d

5 years ago[mediacontroller] Add display rotation abilities 48/214148/4
Lukasz Bardeli [Wed, 18 Sep 2019 10:17:51 +0000 (12:17 +0200)]
[mediacontroller] Add display rotation abilities

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-234

[Verification]
tested manually on chrome console

Change-Id: I226a84bcb17757e900bfce64058180dec812af95
Signed-off-by: Lukasz Bardeli <l.bardeli@samsung.com>
5 years ago[mediacontroller] Add display mode abilities 45/213545/8
Dawid Juszczak [Fri, 6 Sep 2019 11:18:46 +0000 (13:18 +0200)]
[mediacontroller] Add display mode abilities

[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-233

[Verification]
tct-mediacontroller-tizen-tests 100% PASS
tested manually on chrome console

Change-Id: I816d97c38f0ce4fe2f894da1672b748a491cc913
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
5 years ago[Mediacontroller] added display rotation feature 28/213828/13
Rafal Walczyna [Fri, 13 Sep 2019 13:23:21 +0000 (15:23 +0200)]
[Mediacontroller] added display rotation feature

[Verification] Code compiles without errors.
Basic test in chrome console works properly.

/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(clientName, rotation)
{
  console.log("Display rotation change requested to: " + rotation + " by " + clientName);
  return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Success"}), 0);
};
watcherId = mcServer.displayRotation.addChangeRequestListener(changeListener);

/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var rotation = "ROTATION_180";
mcServerInfo.displayRotation.sendRequest(rotation,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    });

/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.displayRotation.addDisplayRotationChangeListener(function(rotation)
{
  console.log(mcServerInfo.name + " server display rotation changed to " + rotation);
});

/// 4. change the value of mode 360 (should trigger listener from point 3)
mcServer.displayRotation.displayRotation = "ROTATION_180"

/// 5. enable ability of server
// TODO: mcServer.abilities.displayRotation = "?"

/// sendRequest again (should trigger listener from point 1)
mcServerInfo.displayRotation.sendRequest(rotation,
  function(data, code)
  {
    console.log(
        "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
  });

Change-Id: I9c497dbaaf5e7f491c2d57c568e52581c980951d
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
5 years ago[Mediacontroller] added display mode feature 20/213720/9
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Thu, 12 Sep 2019 12:38:12 +0000 (14:38 +0200)]
[Mediacontroller] added display mode feature

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-231

[Verification] Code compiles without errors.
Basic test in chrome console works properly.

/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(type, clientName)
{
    console.log("Display mode change requested to: " + type + " by " + clientName);
    return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Not allowed"}), 13);
};
watcherId = mcServer.displayMode.addChangeRequestListener(changeListener);

/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var type = "ORIGIN_SIZE";
mcServerInfo.displayMode.sendRequest(type,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    },
    function(e)
    {
      console.log("Error executing command: " + e.message);
    });

/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.displayMode.addModeChangeListener(function(type)
{
  console.log(mcServerInfo.name + " server display mode changed to " + type);
});

/// 4. change the value of display mode (should trigger listener from point 3)
mcServer.displayMode.type = "FULL_SCREEN"

/// 4. enable ability of server
// TODO support: mcServer.abilities.displayMode.originSize = "YES"

/// sendRequest again (should trigger listener from point 1)
mcServerInfo.displayMode.sendRequest(type,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    },
    function(e)
    {
      console.log("Error executing command: " + e.message);
    });

Change-Id: Icbc98513372d8da8e111a44d873c6559dede89e9

5 years ago[Mediacontroller] added subtitles feature and related ability 23/213623/13
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Thu, 12 Sep 2019 09:40:52 +0000 (11:40 +0200)]
[Mediacontroller] added subtitles feature and related ability

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-230

[Verification] Code compiles without errors.
Basic test in chrome console works properly.

/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(enabled, clientName)
{
    console.log("Subtitles mode change requested to: " + enabled + " by " + clientName);
    return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Not allowed"}), 13);
};
watcherId = mcServer.subtitles.addChangeRequestListener(changeListener);

/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var enabled = true;
mcServerInfo.subtitles.sendRequest(enabled,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    });

/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.subtitles.addModeChangeListener(function(status)
{
  console.log(mcServerInfo.name + " server subtitles mode changed to " + status);
});

/// 4. change the value of subtitles (should trigger listener from point 3)
mcServer.subtitles.enabled = true

/// 5. enable ability of server
mcServer.abilities.subtitles = "YES"

/// sendRequest again (should trigger listener from point 1)
mcServerInfo.subtitles.sendRequest(enabled,
function(data, code)
{
  console.log(
      "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
});

/// 6. register ability change listener and trigger the update
var listener =
{
  onsimpleabilitychanged: function(server, type, ability)
  {
    console.log(type + " ability changed, server name: " + server.name + ", ability: " + ability);
  }
};
mcClient.addAbilityChangeListener(listener);

/// call updates to trigger listener
mcServer.abilities.subtitles = "NO"
mcServer.abilities.subtitles = "NO"
/// Listener should be triggered once

Change-Id: I00ad78a44b696a7d885d13499af77cf762e54c7e

5 years agoMerge "[Tools] SAM script added" into tizen
Piotr Kosko [Thu, 19 Sep 2019 09:22:50 +0000 (09:22 +0000)]
Merge "[Tools] SAM script added" into tizen

5 years agoMerge "[Mediacontroller] added mode 360 feature" into tizen
Piotr Kosko [Thu, 19 Sep 2019 09:16:31 +0000 (09:16 +0000)]
Merge "[Mediacontroller] added mode 360 feature" into tizen

5 years ago[Mediacontroller] added mode 360 feature 30/213330/19
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Thu, 5 Sep 2019 05:21:53 +0000 (07:21 +0200)]
[Mediacontroller] added mode 360 feature

[ACR] http://suprem.sec.samsung.net/jira/browse/TWDAPI-229

[Verification] Code compiles without errors.
Basic test in chrome console works properly.

/// 1. adding command listener
var mcServer = tizen.mediacontroller.createServer();
mcServer.updatePlaybackState("PLAY");
var changeListener = function(enabled, clientName)
{
    console.log("Spherical mode change requested to: " + enabled + " by " + clientName);
    return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"message": "Not allowed"}), 13);
};
watcherId = mcServer.mode360.addChangeRequestListener(changeListener);

/// 2. checking NotSupportedError when sending without enabled ability
var mcClient = tizen.mediacontroller.getClient();
var mcServerInfo = mcClient.getLatestServerInfo()
var enabled = true;
mcServerInfo.mode360.sendRequest(enabled,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    },
    function(e)
    {
      console.log("Error executing command: " + e.message);
    });

/// 3. register listener for mode changes (client side)
watcherId = mcServerInfo.mode360.addModeChangeListener(function(status)
{
  console.log(mcServerInfo.name + " server spherical mode changed to " + status);
});

/// 4. change the value of mode 360 (should trigger listener from point 3)
mcServer.mode360.enabled = true

/// 5. enable ability of server
mcServer.abilities.mode360 = "YES"

/// sendRequest again (should trigger listener from point 1)
mcServerInfo.mode360.sendRequest(enabled,
    function(data, code)
    {
      console.log(
          "Server replied with return data: " + JSON.stringify(data) + " and code: " + code);
    },
    function(e)
    {
      console.log("Error executing command: " + e.message);
    });

/// 6. register ability change listener and trigger the update
var listener =
{
  onsimpleabilitychanged: function(server, type, ability)
  {
    console.log(type + " ability changed, server name: " + server.name + ", ability: " + ability);
  }
};
mcClient.addAbilityChangeListener(listener);

/// call updates to trigger listener
mcServer.abilities.mode360 = "NO"
mcServer.abilities.mode360 = "NO"
/// Listener should be triggered once

Change-Id: I8170d56f6d5b18f053047d48d55e68d3ebbe7719

5 years agoMerge "[download] Download module exception correction" into tizen
Piotr Kosko [Thu, 19 Sep 2019 08:36:57 +0000 (08:36 +0000)]
Merge "[download] Download module exception correction" into tizen

5 years ago[Mediacontroller] Prepared templates for new features 48/213248/5
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Tue, 3 Sep 2019 08:15:12 +0000 (10:15 +0200)]
[Mediacontroller] Prepared templates for new features

This commit is prepared as a parent for several features introduced with
related native ACR http://suprem.sec.samsung.net/jira/browse/ACR-1444

Related ACRs:
http://suprem.sec.samsung.net/jira/browse/TWDAPI-229
http://suprem.sec.samsung.net/jira/browse/TWDAPI-230
http://suprem.sec.samsung.net/jira/browse/TWDAPI-231
http://suprem.sec.samsung.net/jira/browse/TWDAPI-232

Change-Id: Id23a4b53a5f9b9232224f942a2bde18940680abf

5 years agoMerge "[mediacontroller] abilities and subscriptions" into tizen
Piotr Kosko [Wed, 18 Sep 2019 09:00:24 +0000 (09:00 +0000)]
Merge "[mediacontroller] abilities and subscriptions" into tizen

5 years ago[mediacontroller] abilities and subscriptions 79/210579/23
Dawid Juszczak [Mon, 22 Jul 2019 15:17:19 +0000 (17:17 +0200)]
[mediacontroller] abilities and subscriptions

[ACR]
http://suprem.sec.samsung.net/jira/browse/TWDAPI-227

[Verification]
tested manually on chrome console
tct-mediacontroller-tizen-tests 100% PASS

Change-Id: I839c1f825e61caa828ad06d2c6b4a779ee3da320
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
5 years ago[build] Fix for incremental build 22/213822/1
Rafal Walczyna [Thu, 12 Sep 2019 10:53:26 +0000 (12:53 +0200)]
[build] Fix for incremental build

Some file were created and changed while using incremental build.
This commit makes these files invisible to git status.

Change-Id: Ic10286bc786f35644b4b9736f73ac788200a8c0b
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
5 years ago[Tools] SAM script added 24/212624/5
Rafal Walczyna [Fri, 23 Aug 2019 10:04:02 +0000 (12:04 +0200)]
[Tools] SAM script added

Added script for S/W Architecture Maturity checking

Change-Id: I87e1836e77197740935c4252699e3f4aee08f66e
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
5 years ago[download] Download module exception correction 48/206648/13
Arkadiusz Pietraszek [Wed, 22 May 2019 13:00:41 +0000 (15:00 +0200)]
[download] Download module exception correction

NotFoundError and TypeMismatchError exceptions removed from methods:
void cancel(long);
void pause(long);
void resume(long);

Change that enables resuming canceled or failed download job.
abandon() method added, to destroy download job, abandoned download can not be resumed.
ABANDONED state added to differentiate from CANCELED, which can be resumed.

[Verification] Download TCT pass rate is 100%.
New behaviour was tested manually from console.

ACR: http://suprem.sec.samsung.net/jira/browse/TWDAPI-222

Change-Id: I52f5e7fa1875f49354178b8979c92e0d20011bc2
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
5 years ago[fix][mediacontroller] add callIfPossible to listeners 57/212357/1
Dawid Juszczak [Tue, 20 Aug 2019 14:19:05 +0000 (16:19 +0200)]
[fix][mediacontroller] add callIfPossible to listeners

This commit adds callIfPossible functions to listeners to
avoid calling not set callbacks.

Change-Id: I91b36177eac0286d644fd298d9ad253e3586badb
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
5 years ago[Mediacontroller] Fixed issue with invalid name of enum 20/212320/3 accepted/tizen/unified/20190821.064558 submit/tizen/20190820.115734
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Tue, 20 Aug 2019 08:09:05 +0000 (10:09 +0200)]
[Mediacontroller] Fixed issue with invalid name of enum

[Bug]
1. wrong value of enum NONE instead of NO_CATEGORY
2. invalid parsing of empty keyword, which caused crash

[Verification] Code compiles without errors.
  Tested in chrome console with code:
var server = tizen.mediacontroller.createServer();
function searchRequestListener(clientName, request)
{
  console.log("search command received");
  return new tizen.mediacontroller.RequestReply(new tizen.Bundle({"key": "value"}), 5);
}
server.setSearchRequestListener(searchRequestListener);
server.updatePlaybackState("PLAY");

/* Client-side code */
var client = tizen.mediacontroller.getClient();
var sinfo = client.getLatestServerInfo();

var query = [
  new tizen.mediacontroller.SearchFilter("MUSIC")
];

sinfo.sendSearchRequest(query, function(reply)
{
  console.log("reply status: " + reply.code);
  console.log("reply data: " + reply.data);
});

Change-Id: Ie522f07286bf4604fe43428b716d6d808abbea07

5 years ago[version] 2.49 41/212041/1 accepted/tizen/unified/20190814.065037 submit/tizen/20190813.123515
Piotr Kosko/Native/Web API (PLT) /SRPOL/Engineer/삼성전자 [Tue, 13 Aug 2019 12:34:18 +0000 (14:34 +0200)]
[version] 2.49

Change-Id: I87d61cdefe4c22a85147329cb14e698cee59308e

5 years ago[formatting] Code auto-formatting. 23/212023/1
Michal Michalski [Tue, 13 Aug 2019 09:46:43 +0000 (11:46 +0200)]
[formatting] Code auto-formatting.

Executed ./code_format script on the repository to fix invalid formatting.

Change-Id: Ieb8d825c4525dedc740319a3729ffd54280fef71
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
5 years agoMerge "[mediacontroller] New implementation for sendCommand()," into tizen
Piotr Kosko [Tue, 13 Aug 2019 09:21:14 +0000 (09:21 +0000)]
Merge "[mediacontroller] New implementation for sendCommand()," into tizen

5 years agoMerge "Use bundle_init_byte_array instead of bundle_add_byte_array" into tizen
Piotr Kosko [Tue, 13 Aug 2019 05:47:28 +0000 (05:47 +0000)]
Merge "Use bundle_init_byte_array instead of bundle_add_byte_array" into tizen

5 years agoUse bundle_init_byte_array instead of bundle_add_byte_array 71/211571/2
Hwankyu Jhun [Tue, 6 Aug 2019 23:14:26 +0000 (08:14 +0900)]
Use bundle_init_byte_array instead of bundle_add_byte_array

The bundle_add_byte_array function will be changed.

Requires:
 - https://review.tizen.org/gerrit/#/c/platform/core/base/bundle/+/211570/

Change-Id: I1465f336564da1fe3081dc02e09637422849ca7e
Signed-off-by: Hwankyu Jhun <h.jhun@samsung.com>
5 years ago[mediacontroller] New implementation for sendCommand(), 52/211252/9
Michal Michalski [Wed, 31 Jul 2019 11:09:35 +0000 (13:09 +0200)]
[mediacontroller] New implementation for sendCommand(),

http://suprem.sec.samsung.net/jira/browse/TWDAPI-226

+ sendCommand() accepts both object and tizen.Bundle as data argument.
+ Command listener can now return both RequestReply object, tizen.Bundle and object.

[Verification] Tested with custom javascript test cases.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I357e5b398724bdfada48684fb5bbc8f11be52f20

5 years ago[mediacontroller][common][webapi-plugins.spec][tizen] Implementation for search API. 66/201566/38
Michal Michalski [Wed, 3 Apr 2019 10:49:20 +0000 (12:49 +0200)]
[mediacontroller][common][webapi-plugins.spec][tizen] Implementation for search API.

http://suprem.sec.samsung.net/jira/browse/TWDAPI-208

Implementation for search API.

[Verification] Manual API testing.
tct-mediacontroller-tizen-tests 100% pass
tct-messageport-tizen-tests 100% pass

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I47cb4b3234e212db77ed20c4f899f4b5bed2d662

5 years ago[tests][mediacontroller] tests for new sendCommand implementation. 51/211251/9
Michal Michalski [Wed, 31 Jul 2019 11:00:36 +0000 (13:00 +0200)]
[tests][mediacontroller] tests for new sendCommand implementation.

This testcases define expected behavior of sendCommand() method
after implementation is changed.

[Verification] Tests are passing with working version of new implementation.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I5923e45bb0ddc2013b1fe81951a3966413a3e4b6

5 years ago[tizen][utils][mediacontroller] Rewrite js tests using mochajs. 24/211324/9
Michal Michalski [Mon, 22 Jul 2019 10:59:36 +0000 (12:59 +0200)]
[tizen][utils][mediacontroller] Rewrite js tests using mochajs.

JS tests for the implementation of search API.

Tests for mediacontroller search api and tizen.Bundle have
been rewritten using mochajs library.

[Verification] Tests pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I22d5b5bd518b709f8d4aa94149906439390b4e28

5 years ago[version] 2.48 49/211449/1 accepted/tizen/unified/20190805.104346 submit/tizen/20190805.070446
Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 [Mon, 5 Aug 2019 07:02:52 +0000 (09:02 +0200)]
[version] 2.48

Change-Id: I7a5c9eb27b5c115f9c5c1b29c9720a9883b26408

5 years ago[Alarm] Fixed the behaviour change introduced during SVACE issues fixing 43/211443/2
Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 [Mon, 5 Aug 2019 05:53:03 +0000 (07:53 +0200)]
[Alarm] Fixed the behaviour change introduced during SVACE issues fixing

[Bug] Issue was introduced in commit 1b4d5c8e8e760140c3e5c93e59ff23bde99f9862
https://review.tizen.org/gerrit/#/c/platform/core/api/webapi-plugins/+/207226/

Alarm TCT - 12 fails

[Verification] Alarm TCT after fix - 100% (tizen-unified_20190804.1_mobile-wayland-armv7l-tm1)

Change-Id: I343bf2d20d2f88f6d3ac37eb2631a0db395daecb

5 years agoMerge "[tests][common][webapi-plugins.spec] Changed common unit tests files structure...
Piotr Kosko [Thu, 1 Aug 2019 10:03:07 +0000 (10:03 +0000)]
Merge "[tests][common][webapi-plugins.spec] Changed common unit tests files structure." into tizen

5 years ago[tests][common][webapi-plugins.spec] Changed common unit tests files structure. 42/211142/5
Michal Michalski [Tue, 30 Jul 2019 09:30:12 +0000 (11:30 +0200)]
[tests][common][webapi-plugins.spec] Changed common unit tests files structure.

New structure allows better modularization of unit tests.

[Verification] webapi_common_tests are built successfully and pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Icad5cca7739716bde7c09092f4d1d73fca1972a0

5 years ago[utils][tests] Add mochajs and chaijs libraries sources. 50/211250/3
Michal Michalski [Wed, 31 Jul 2019 10:56:48 +0000 (12:56 +0200)]
[utils][tests] Add mochajs and chaijs libraries sources.

They can be used to write tests for js code.
It is required to add them to the debugging application.
After you have application with this libraries, you can
than run tests from chrome snippets in remote debugger.

[Verification] I have tested this setup in my test application
and it seems to be working.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ide535ee8ce29b4a735351f2fb9cbde36cc7c935e

5 years agoMerge "Merge branch 'tizen_5.0' into tizen" into tizen
Piotr Kosko [Wed, 31 Jul 2019 12:19:36 +0000 (12:19 +0000)]
Merge "Merge branch 'tizen_5.0' into tizen" into tizen

5 years ago[common] Fix JsonToBundle implementation. 70/211170/2
Michal Michalski [Tue, 30 Jul 2019 14:54:12 +0000 (16:54 +0200)]
[common] Fix JsonToBundle implementation.

Broken implemenation has slipped through unspotted.
While testing previous change in JsonToBundle the API
installed on device probably has not been updated.

[Verification] UTs were failing and now they are passing.

Change-Id: I6c871ff03a79417a630da1db50f2f7300fca9ca8
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
5 years ago[tizen] Add copy ctor to tizen.Bundle. 45/211145/3
Michal Michalski [Tue, 30 Jul 2019 10:08:57 +0000 (12:08 +0200)]
[tizen] Add copy ctor to tizen.Bundle.

This will simplify the implementation of API methods which
need to accept both plain json object and tizen.Bundle.
In example: function sendCommand(..., data) { var d = new tizen.Bundle(data); }
instead of manually having to check if data is a tizen.Bundle or object.

[Verification] Added new test case for this constructor, all existing tests passes.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I4c880dbf8889c88bb20a4029b5cbb8fa2941eb1d

5 years ago[mediacontroller][common] Support for null values in Json-Bundle conversions. 78/210678/4
Michal Michalski [Tue, 23 Jul 2019 15:00:26 +0000 (17:00 +0200)]
[mediacontroller][common] Support for null values in Json-Bundle conversions.

JsonToBundle and BundleToJson functions didn't support null values. Manually
handling them every time was cumbersome, hence this commit adds support for null values.

[Verification] + bundle c++ unittests 100% pass
+ bundle js tests 100% pass
+ tct-mediacontroller-tizen-tests 20190722 tct package 100% pass.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I1315899d8ebb66935ea9b10791b5dba82341af45

5 years agoMerge branch 'tizen_5.0' into tizen 50/211050/1
Arkadiusz Pietraszek [Mon, 29 Jul 2019 08:30:43 +0000 (10:30 +0200)]
Merge branch 'tizen_5.0' into tizen

Change-Id: I5d9b8f0a57450b051a5c56bfb1b4c704ac0121a5
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
5 years ago[tizen][mediacontroller] Change toJSON implementation to simplify serialization. 69/210769/2 accepted/tizen/unified/20190730.112003 submit/tizen/20190730.074817
Michal Michalski [Wed, 24 Jul 2019 08:38:45 +0000 (10:38 +0200)]
[tizen][mediacontroller] Change toJSON implementation to simplify serialization.

Before this commit, in order to send Bundle object to the C++ layer
it was necessary to call Bundle.toString() method, and than picojson::parse()
in C++ to deserialize it. This commit removes the need for both this steps.
They will be done implicitly by the framework.

[Verification] bundle js tests 100% pass rate.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I89b11bc634b56b720dd8a5ecea8537ef1ce51b24

5 years agoMerge branch 'tizen_4.0' into tizen_5.0 32/210632/1
Arkadiusz Pietraszek [Mon, 22 Jul 2019 12:48:41 +0000 (14:48 +0200)]
Merge branch 'tizen_4.0' into tizen_5.0

Change-Id: Id7abc98f999b2bfb8dc0b49692f688f1b4c9ee9f

5 years agoMerge "[Application] Fixed path of getAppSharedURI" into tizen
Piotr Kosko [Mon, 22 Jul 2019 12:30:17 +0000 (12:30 +0000)]
Merge "[Application] Fixed path of getAppSharedURI" into tizen

5 years agoMerge "[Application] Fixed path of getAppSharedURI" into tizen_5.0
Piotr Kosko [Mon, 22 Jul 2019 12:30:05 +0000 (12:30 +0000)]
Merge "[Application] Fixed path of getAppSharedURI" into tizen_5.0

5 years agoMerge "[Project][code_formatter] Fix JS files formatting error" into tizen
Piotr Kosko [Mon, 22 Jul 2019 12:27:39 +0000 (12:27 +0000)]
Merge "[Project][code_formatter] Fix JS files formatting error" into tizen

5 years ago[Application] Fixed path of getAppSharedURI 71/210571/1
Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 [Mon, 22 Jul 2019 09:21:02 +0000 (11:21 +0200)]
[Application] Fixed path of getAppSharedURI

Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy

New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner  users        4096 Jul 18 13:06 .
drwxr-xr-x 5 owner  users        4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner  system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw         58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner  users        4096 Jul 18 13:06 trusted

Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res

[Verification] Checked manually in chrome console
  TCT Application 100% passrate

Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09

5 years ago[Application] Fixed path of getAppSharedURI 70/210570/1
Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 [Mon, 22 Jul 2019 09:21:02 +0000 (11:21 +0200)]
[Application] Fixed path of getAppSharedURI

Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy

New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner  users        4096 Jul 18 13:06 .
drwxr-xr-x 5 owner  users        4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner  system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw         58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner  users        4096 Jul 18 13:06 trusted

Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res

[Verification] Checked manually in chrome console
  TCT Application 100% passrate

Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09

5 years ago[Application] Fixed path of getAppSharedURI 69/210569/1
Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 [Mon, 22 Jul 2019 09:21:02 +0000 (11:21 +0200)]
[Application] Fixed path of getAppSharedURI

Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy

New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner  users        4096 Jul 18 13:06 .
drwxr-xr-x 5 owner  users        4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner  system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw         58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner  users        4096 Jul 18 13:06 trusted

Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res

[Verification] Checked manually in chrome console
  TCT Application 100% passrate

Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09

5 years ago[Application] Fixed path of getAppSharedURI 58/210558/5
Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 [Mon, 22 Jul 2019 09:21:02 +0000 (11:21 +0200)]
[Application] Fixed path of getAppSharedURI

Application should return path to the 'shared' directory which follows
the description of 'shared' directory content available here:
https://developer.tizen.org/development/training/native-application/understanding-tizen-programming/file-system-directory-hierarchy

New application returns the path like:
sh-3.2# ls -al /opt/usr/home/owner/apps_rw/org.example.basic/shared/
total 20
drwxr-xr-x 4 owner  users        4096 Jul 18 13:06 .
drwxr-xr-x 5 owner  users        4096 Jul 18 13:06 ..
drwxrwsr-x 2 owner  system_share 4096 Jul 18 13:06 data
lrwxrwxrwx 1 app_fw app_fw         58 Jul 18 13:06 res -> /opt/usr/globalapps/org.example.basic/shared/res
drwxr-xr-x 2 owner  users        4096 Jul 18 13:06 trusted

Instead of the previous result:
sh-3.2# ls -al /opt/usr/globalapps/org.example.basic/shared/
total 12
drwxr-xr-x 3 tizenglobalapp root 4096 Jul 18 13:06 .
drwxr-xr-x 6 tizenglobalapp root 4096 Jul 18 13:06 ..
drwxr-xr-x 2 tizenglobalapp root 4096 Jul 18 13:06 res

[Verification] Checked manually in chrome console
  TCT Application 100% passrate

Change-Id: I0032c10bf2d98487117cd0049103767f9c7f1d09

5 years agoMerge "[Project][Coverity] Some static analysis problems were corrected." into tizen
Piotr Kosko [Mon, 22 Jul 2019 11:35:30 +0000 (11:35 +0000)]
Merge "[Project][Coverity] Some static analysis problems were corrected." into tizen

5 years ago[Project][code_formatter] Fix JS files formatting error 63/210563/3
Rafal Walczyna [Mon, 22 Jul 2019 10:55:38 +0000 (12:55 +0200)]
[Project][code_formatter] Fix JS files formatting error

Due to a bug, js files were not formatting.

Tested manually - js formatting works.

Change-Id: I5a4e2f2dc05241e15c85815f8380563303fa7ed1
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
5 years ago[Project][Coverity] Some static analysis problems were corrected. 26/207226/9
Arkadiusz Pietraszek [Thu, 30 May 2019 13:31:03 +0000 (15:31 +0200)]
[Project][Coverity] Some static analysis problems were corrected.

Those Coverity issues were fixed:
CHECKED_RETURN 835501 - Messageport
CHECKED_RETURN 835504 - Download
CHECKED_RETURN 835505 - Messaging Email
CHECKED_RETURN 835506 - Download
CHECKED_RETURN 1064913 - Common
CHECKED_RETURN 1064914 - Common
CHECKED_RETURN 1064915 - Alarm
CHECKED_RETURN 1074834 - Application
CHECKED_RETURN 1074835 - Application

In Alarm module there is fix of Exception message.
There is also correction of logs in Archive module to bring consistency.
Some files was changed only by cude_format script.

[Verification] Coverity was run, and fixed issues are not on a list anymore.
http://10.113.170.22:8810/download/16062/artifacts/analysis_report_I6ddb03_coverity-2017.07.html
TCT pass rate of changed modules is 100%.

Change-Id: I6ddb030c071166d688a902849c9f979cfbae62d6
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
5 years ago[5.5][package] Change deprecated enum to new ones 81/210481/3
Dawid Juszczak [Fri, 19 Jul 2019 09:58:40 +0000 (11:58 +0200)]
[5.5][package] Change deprecated enum to new ones

changed every occurrence of enum values to new ones

native ACR with related changes:
http://suprem.sec.samsung.net/jira/browse/ACR-1419

[Verification]
tct-application-tizen-tests 100% PASS
tct-package-tizen-tests 100% PASS

Change-Id: I2d4898411efeb18a8526f497d4b837b8d2bb2387
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
5 years agoMerge remote-tracking branch 'origin/tizen_3.0' into tizen_4.0 30/206830/3
Arkadiusz Pietraszek [Fri, 12 Jul 2019 11:47:35 +0000 (13:47 +0200)]
Merge remote-tracking branch 'origin/tizen_3.0' into tizen_4.0

[Verification] TCT passrate 100%.

Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
Change-Id: Id004158e62f5d0b6f2c09eeee5cf300d461a9d9f

5 years ago[Project][code_formatter] Fix multiple errors in shell scripts: 21/209221/3
Ernest Borowski [Wed, 3 Jul 2019 12:30:15 +0000 (14:30 +0200)]
[Project][code_formatter] Fix multiple errors in shell scripts:

- Use null character as path delimiter in git and find commands.
  It allows file path to contain newlines and other white space characters.
- Add quotes when needed to prevent globbing and word splitting.
- Simplify logic.

Change-Id: I58de7a3bd1e2e3165ada8b7650b2863e1fc95c15
Signed-off-by: Ernest Borowski <e.borowski@partner.samsung.com>
5 years ago[version] 2.47 74/210074/1 accepted/tizen/unified/20190716.111308 submit/tizen/20190715.124605
Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 [Mon, 15 Jul 2019 12:44:19 +0000 (14:44 +0200)]
[version] 2.47

Change-Id: I37a5ea2a5100290b0bed1e7c19baef26e384ea54

5 years ago[mediacontroller][bundle] fixing custom command 64/209964/5
Dawid Juszczak [Fri, 12 Jul 2019 13:45:22 +0000 (15:45 +0200)]
[mediacontroller][bundle] fixing custom command

Refactored some functions to use tizen.Bundle
and formated code with format script

Changed implementation of functions:
+ MediaControllerInstance::MediaControllerServerReplyCommand
+ MediaControllerInstance::MediaControllerServerInfoSendCommand

+ MediaControllerServer::OnCommandReceived
+ MediaControllerServer::CommandReply

+ MediaControllerClient::OnCommandReply
+ MediaControllerClient::SendCommand

[Verified]
tct-mediacontroller-tizen-tests - 100% passed
also tested manually on chrome console

Change-Id: I9d072d10a5fc272c54d17731f33ae9b733009412
Signed-off-by: Dawid Juszczak <d.juszczak@samsung.com>
5 years ago[tizen] Update bundle js tests after fix. 63/210063/1
Michal Michalski [Mon, 15 Jul 2019 10:02:03 +0000 (12:02 +0200)]
[tizen] Update bundle js tests after fix.

+ Added tests for regular arrays and Uint8Arrays.
+ Updated toJSON test after method modification.
+ Added tests for toString method.

[Verification] Tests pass for fixed bundle.

Change-Id: Idd9298b311fee56c4387c5f9c9fbd2b4984944b0
Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
5 years ago[tizen] Fix issue with regular arrays in Bundle. 00/209900/4
Michal Michalski [Mon, 15 Jul 2019 10:01:08 +0000 (12:01 +0200)]
[tizen] Fix issue with regular arrays in Bundle.

Bundle now stored byte streams as Uint8Arrays and converts regular arrays with
octet values to Uint8Arrays in Bundle::set() method.

toString() method now prints Uint8Arrays in the same way as regular arrays
using "[1,2,3]" format, instead of the "{0: 0, 1: 1, 2: 2}" format which is the
default behavior of toString() method on typed arrays.

[Verification] Modified tests passed.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I9eeca40d9760413c81888f4980146c8025d227d2

5 years agoMerge "[tizen] Bundle constructor fix." into tizen accepted/tizen/unified/20190715.223901 submit/tizen/20190715.093630
Piotr Kosko [Thu, 11 Jul 2019 10:56:15 +0000 (10:56 +0000)]
Merge "[tizen] Bundle constructor fix." into tizen

5 years ago[tizen] Bundle constructor fix. 27/209827/1
Michal Michalski [Thu, 11 Jul 2019 10:13:53 +0000 (12:13 +0200)]
[tizen] Bundle constructor fix.

xwalk.utils.validator replaced with xwalk.utils.type.

[Verification] All tests passed.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I2a7a8d4c1c2fb81ab8750a122596378d3af975f3

5 years ago[version] 2.46 43/209643/1 accepted/tizen/unified/20190717.115233 submit/tizen/20190709.123714
Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 [Tue, 9 Jul 2019 12:35:15 +0000 (14:35 +0200)]
[version] 2.46

Change-Id: I5347699a9a3eab4210560a5e96ac212886954a53
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
5 years ago[UT][SPEC] Fixed passing tizen_ut_build defined value 06/209606/2
Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 [Tue, 9 Jul 2019 08:41:31 +0000 (10:41 +0200)]
[UT][SPEC] Fixed passing tizen_ut_build defined value

[Bug] Build fails when building different profile than mobile

[Verification] Build successfully for unified build and each profile

Change-Id: I37b2f9e8517e7cd9db7956812c39bb57bdff5a42

5 years ago[common][tizen][utils] Common Bundle implementation. 29/207729/21
Michal Michalski [Thu, 4 Jul 2019 14:16:05 +0000 (16:16 +0200)]
[common][tizen][utils] Common Bundle implementation.

http://suprem.sec.samsung.net/jira/browse/TWDAPI-225

Unified the way native bundle objects are used
by WebAPI plugins.

[Verification] unittests pass rate 100%.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I501880daee29f878e4af9fb9b20e386905fbdc0c

5 years ago[Project][Filesystem] Fix needed after code formating of tizen_3.0 branch 86/209486/2
Arkadiusz Pietraszek [Mon, 8 Jul 2019 08:20:14 +0000 (10:20 +0200)]
[Project][Filesystem] Fix needed after code formating of tizen_3.0 branch

Prietter code formatter treated obiect properties named 'null' and 'undefined' as keywords that should not be in apostrophes and removed those apostrophes.
This change has been reverted and //prettier-ignore tags has been added.

Change-Id: I78d502b9f674397f01c959031ad37fa139dd0b16
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
5 years ago[utils][webapi-plugins.spec][common][tizen-wrt.gyp][tizen] Common bundle tests. 02/208802/3
Michal Michalski [Fri, 28 Jun 2019 11:23:21 +0000 (13:23 +0200)]
[utils][webapi-plugins.spec][common][tizen-wrt.gyp][tizen] Common bundle tests.

http://suprem.sec.samsung.net/jira/browse/TWDAPI-225

Tests for common Bundle implementation.

[Verification] Pass rate 100%.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ib8ae4415b45f018efc3406c071115782920798f9

5 years ago[version] 2.45 77/209277/1 accepted/tizen/unified/20190704.115630 submit/tizen/20190704.075556
Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 [Thu, 4 Jul 2019 07:54:16 +0000 (09:54 +0200)]
[version] 2.45

Change-Id: I6272b2f933c4bd97e2c7963938a6356afb1cc1f3
Signed-off-by: Piotr Kosko/Native/Web API (PLT) /SRPOL/Professional/삼성전자 <p.kosko@samsung.com>
5 years ago[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener. 17/209217/1
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.

Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
5 years agoMerge "[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListene...
Piotr Kosko [Wed, 3 Jul 2019 09:00:58 +0000 (09:00 +0000)]
Merge "[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener." into tizen_3.0

5 years ago[MediaController] Fix for custom command without data 15/208815/1
Rafal Walczyna [Fri, 28 Jun 2019 06:37:13 +0000 (08:37 +0200)]
[MediaController] Fix for custom command without data

If custom command was sent without additional data then
command was not parsed at all.

[Verification] Tested manually

Change-Id: Id35a5852a7fa61aff48fc181926e77ee01f65ff8
Signed-off-by: Rafal Walczyna <r.walczyna@samsung.com>
5 years ago[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener. 14/208814/1
Arkadiusz Pietraszek [Thu, 27 Jun 2019 12:12:21 +0000 (14:12 +0200)]
[Mediacontroller] Added callIfPossible safeguards in ServerPlaybackInfoListener.

[verification] TCT 100% passrate

Change-Id: Ic77f57e39b73acc77c67c3f1cff0352a94315206
Signed-off-by: Arkadiusz Pietraszek <a.pietraszek@partner.samsung.com>
5 years ago[mediacontroller] Declare MediaControllerContentType enum. 13/208813/1
Michal Michalski [Fri, 10 May 2019 10:09:45 +0000 (12:09 +0200)]
[mediacontroller] Declare MediaControllerContentType enum.

Extracted into separate commit from adding ContentType WebAPI
because it is needed by Search API implementation as well.

[Verification] Code compiles. Both ContentType API implementation and Search API
implementation compile as well with this commit as a parent.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: I1f140bb8dd608887b90a1d7b5a202c493e5fd3e4

5 years ago[mediacontroller][common] Use PlatformEnum in MediaController. 12/208812/1
Michal Michalski [Tue, 7 May 2019 08:59:32 +0000 (10:59 +0200)]
[mediacontroller][common] Use PlatformEnum in MediaController.

Refactor enums in MediaController module using PlatformEnum
template class.

[Verification] Code compiles + MC TCT passed.

Signed-off-by: Michal Michalski <m.michalski2@partner.samsung.com>
Change-Id: Ie861d1c0aca7651a2f9ce45b966773082abf6045