James Berry [Mon, 27 Feb 2012 19:41:43 +0000 (14:41 -0500)]
bugfix: use oxcf width/height for reinit check
use oxcf instead of common in check to Reinit the
lookahead buffer if the frame size changes
prior behavior would cause assertion fail/crash
first observed in:
support changing resolution with vpx_codec_enc_config_set
Change-Id: Ib669916ca9b4f206d4cc3caab5107e49d39a36aa
Yunqing Wang [Mon, 27 Feb 2012 19:06:13 +0000 (11:06 -0800)]
Merge "Fix skippable evaluation in mode decision"
John Koleszar [Mon, 27 Feb 2012 17:59:14 +0000 (09:59 -0800)]
Merge "vpxenc: initial implementation of multistream support"
John Koleszar [Mon, 27 Feb 2012 17:58:29 +0000 (09:58 -0800)]
Merge "decoder: reset segmentation map on keyframes"
Yunqing Wang [Mon, 27 Feb 2012 17:45:12 +0000 (12:45 -0500)]
Fix skippable evaluation in mode decision
Yaowu fixed the skippable evaluation by correcting 2nd order
block's eob.
Change-Id: Id47930cbc74a90a046c0c0e324efb03477639ee0
James Berry [Thu, 23 Feb 2012 16:50:36 +0000 (08:50 -0800)]
Merge "Add unit tests for idctllm_test and idctllm_mmx"
Jim Bankoski [Thu, 23 Feb 2012 16:38:44 +0000 (08:38 -0800)]
Merge "Remove the frame rate factor for key frame size."
Marco Paniconi [Wed, 22 Feb 2012 22:39:17 +0000 (14:39 -0800)]
Remove the frame rate factor for key frame size.
When temporal layers is used (i.e., number_of_layers > 1),
we don't use the frame rate boost for setting the key
frame target size. The factor was forcing the target size to be
always at its minimum (2* per_frame_bandwidth) for low frame rates
(i.e., base layer frame rate).
Generally we should modify or remove this frame rate factor;
for now we turn if off for number_of_layers > 1.
Change-Id: Ia5acf406c9b2f634d30ac2473adc7b9bf2e7e6c6
Scott LaVarnway [Tue, 21 Feb 2012 19:59:05 +0000 (14:59 -0500)]
Eliminated vp8mt_build_intra_predictors_mbuv_s
Reworked the code to use vp8_build_intra_predictors_mbuv_s
instead. This is WIP with the goal of eliminating all
functions in reconintra_mt.h
Change-Id: I61c4a132684544b24a38c4a90044597c6ec0dd52
James Berry [Tue, 21 Feb 2012 16:57:14 +0000 (11:57 -0500)]
Add unit tests for idctllm_test and idctllm_mmx
add unit tests for vp8_short_idct4x4llm_c
Change-Id: I472b7c0baa365ba25dc99a3f6efccc816d27c941
John Koleszar [Tue, 21 Feb 2012 18:09:23 +0000 (10:09 -0800)]
Merge changes I0341554f,I64e110c8
* changes:
Consolidate C version of token packing functions
Multithreaded encoder, late sync loopfilter
Scott LaVarnway [Tue, 21 Feb 2012 17:51:02 +0000 (09:51 -0800)]
Merge "Remove redundant init of segment_counts in vp8_encode_frame"
John Koleszar [Tue, 21 Feb 2012 17:48:26 +0000 (09:48 -0800)]
Merge "Update encoder mb_skip_coeff and prob_skip_false calculation"
Johann [Fri, 17 Feb 2012 20:24:44 +0000 (12:24 -0800)]
Refine offset pattern
When compiling with -ggdb3 the output includes an extraneous EQU from
vpx_ports/asm_offsets.h
https://trac.macports.org/ticket/33285
Change-Id: Iba93ddafec414c152b87001a7542e7a894781231
John Koleszar [Fri, 17 Feb 2012 19:14:17 +0000 (11:14 -0800)]
Merge changes Idf1a05f3,If227b29b,Iac784d39
* changes:
vpxenc: factor out input open/close
vpxenc: add warning()/fatal() helpers
vpxenc: factor out global config options
Johann [Fri, 17 Feb 2012 18:53:19 +0000 (10:53 -0800)]
Merge "OS X shell is incompatible with echo -n"
Yunqing Wang [Fri, 17 Feb 2012 18:43:05 +0000 (10:43 -0800)]
Merge "Fix incorrect use of uv eobs in intra modes"
Yunqing Wang [Fri, 17 Feb 2012 14:15:08 +0000 (09:15 -0500)]
Fix incorrect use of uv eobs in intra modes
In vp8_rd_pick_inter_mode(), if total of eobs is zero, rate needs
to be adjusted since there are no non-zero coefficients for
transmission. The uv intra eobs calculated in
rd_pick_intra_mbuv_mode() need to be saved before they are
overwritten by inter-mode eobs.
Change-Id: I41dd04fba912e8122ef95793d4d98a251bc60e58
Attila Nagy [Fri, 17 Feb 2012 09:50:33 +0000 (11:50 +0200)]
Update encoder mb_skip_coeff and prob_skip_false calculation
mode_info_context->mbmi.mb_skip_coeff has to always reflect the
existence or not of coeffs for a certain MB. The loopfilter needs this
info.
mb_skip_coeff is either set by the vp8_tokenize_mb or has to be set to
1 when the MB is skipped by mode selection. This has to be done
regardless of the mb_no_coeff_skip value.
prob_skip_false is needed just when mb_no_coeff_skip is 1. No need to
keep count of both skip_false and skip_true as they are complementary
(skip_true+skip_false = total_mbs)
Change-Id: I3c74c9a0ee37bec10de7bb796e408f3e77006813
Attila Nagy [Fri, 17 Feb 2012 07:31:53 +0000 (09:31 +0200)]
Remove redundant init of segment_counts in vp8_encode_frame
segment_counts was zero init twice in the beginning of vp8_encode_frame.
Change-Id: Ibc29f6896dabd9aab1d0993f3941cf6876022e70
Johann [Fri, 27 Jan 2012 19:44:01 +0000 (11:44 -0800)]
Clarify 'max_sad' usage
Depending on implementation the optimized SAD functions may return early
when the calculated SAD exceeds max_sad.
Change-Id: I05ce5b2d34e6d45fb3ec2a450aa99c4f3343bf3a
Johann [Thu, 16 Feb 2012 22:20:44 +0000 (14:20 -0800)]
OS X shell is incompatible with echo -n
Built in echo in 'sh' on OS X does not support -n (exclude trailing
newline). It's not necessary so just leave it off. Fixes issue 390.
Build include guard using 'symbol' so that it is more likely to be
unique.
Change-Id: I4bc6aa1fc5e02228f71c200214b5ee4a16d56b83
Fritz Koenig [Thu, 16 Feb 2012 20:38:17 +0000 (12:38 -0800)]
Include path fix for building against Android NDK.
cpu-features.h is not in the common paths, add
to the cflags for Android.
Change-Id: Icbafc7600d72f6b59ffb030f6ab80ee6860332bb
John Koleszar [Wed, 15 Feb 2012 20:39:38 +0000 (12:39 -0800)]
vpxenc: initial implementation of multistream support
Add the ability to specify multiple output streams on the command line.
Streams are delimited by --, and most parameters inherit from previous
streams.
In this implementation, resizing streams is still not supported. It
does not make use of the new multistream support in the encoder either.
Two pass support runs all streams independently, though it's
theoretically possible that we could combine firstpass runs in the
future. The logic required for this is too tricky to do as part of this
initial implementation. This is mostly an effort to get the parameter
passing and independent streams working from the application's
perspective, and a later commit will add the rescaling and
multiresolution support.
Change-Id: Ibf18c2355f54189fc91952c734c899e5c072b3e0
John Koleszar [Tue, 14 Feb 2012 20:30:17 +0000 (12:30 -0800)]
vpxenc: factor out input open/close
Simplify some of the file I/O for later commits which will add multistream
support
Change-Id: Idf1a05f3a29c95331d0c4a6ea5960904e4897fd4
John Koleszar [Tue, 14 Feb 2012 17:37:44 +0000 (09:37 -0800)]
vpxenc: add warning()/fatal() helpers
Cosmetic. Allows exiting with an error message without opening a new
scope.
Change-Id: If227b29b825f0241acea79dd38f19e524552ee18
John Koleszar [Thu, 16 Feb 2012 19:15:11 +0000 (11:15 -0800)]
decoder: reset segmentation map on keyframes
Refactoring some of the mode decoding logic introduced a bug where
the segmentation maps would not be properly reset on keyframes.
http://code.google.com/p/webm/issues/detail?id=378
The text of the bug is somewhat misleading as I initially read it to
imply the bug was present in v0.9.7-p1 (Cayuga), but note the text
"master", which indicates this was something subsequent. This issue
bisects back to v0.9.7-p1-84-ga99c20c, so unfortunately it was broken
during the Duclair release.
Thanks to Alexei Leonenko for investigating the root cause.
Change-Id: I9713c9f070eb37b31b3b029d9ef96be9b6ea2def
Makoto Kato [Sun, 12 Feb 2012 04:57:13 +0000 (13:57 +0900)]
Support Android x86 NDK build
On Android NDK, rand() is inlined function. But, on our SSE optimization,
we need symbol for rand()
Change-Id: I42ab00e3255208ba95d7f9b9a8a3605ff58da8e1
Scott LaVarnway [Thu, 16 Feb 2012 18:36:46 +0000 (13:36 -0500)]
Simplify mb_to_x_edge calculation during mode decoding
Change-Id: Ibcb35c32bf24c1d241090e24c5e2320e4d3ba901
Scott LaVarnway [Thu, 16 Feb 2012 17:33:59 +0000 (09:33 -0800)]
Merge "decodemv cleanup/improvements"
Scott LaVarnway [Thu, 16 Feb 2012 16:38:33 +0000 (11:38 -0500)]
decodemv cleanup/improvements
Removed unnecessary variables, unrolled functions, eliminated
unnecessary mv bounds checks and branches.
Change-Id: I02d034c70cd97b65025d59dd67c695e1db529f0b
Attila Nagy [Thu, 16 Feb 2012 08:51:29 +0000 (10:51 +0200)]
Consolidate C version of token packing functions
Replace inner loops of pack_mb_row_tokens_c and
pack_tokens_into_partitions_c with a call to pack_tokens_c.
Change-Id: I0341554fb154a14a5dadb63f8fc78010724c2c33
Attila Nagy [Fri, 16 Sep 2011 10:54:06 +0000 (13:54 +0300)]
Multithreaded encoder, late sync loopfilter
Second shot at this...
Sync with loopfilter thread as late as possible, usually just at the
beginning of next frame encoding. This returns control to application
faster and allows a better multicore scaling.
When PSNR packets are generated the final filtered frame is needed
imediatly so we cannot delay the sync. Same has to be done when
internal frame is previewed.
Change-Id: I64e110c8b224dd967faefffd9c93dd8dbad4a5b5
John Koleszar [Tue, 14 Feb 2012 00:52:18 +0000 (16:52 -0800)]
vpxenc: factor out global config options
This is a first step towards specifying multiple output streams
with one command line.
Change-Id: Iac784d3911bf553694d024bbd0c3d547261e914b
Fritz Koenig [Wed, 15 Feb 2012 23:23:04 +0000 (15:23 -0800)]
Fix rtcd build process for Android.mk
Add a dependency so ndk-build will
generate the needed vpx_rtcd.h file.
Change-Id: I92c82e0996943dd0403c9956e1ba60e92e2837a9
John Koleszar [Sat, 11 Feb 2012 00:18:00 +0000 (16:18 -0800)]
Merge "support changing resolution with vpx_codec_enc_config_set"
Johann [Fri, 10 Feb 2012 19:07:33 +0000 (11:07 -0800)]
Missed some variance casts
Change-Id: I9fb510f9421fb3c317a8e32e3058cee977ddf9fa
Johann [Fri, 10 Feb 2012 18:28:00 +0000 (10:28 -0800)]
Merge "max_sad check is not always implemented"
Johann [Fri, 10 Feb 2012 00:19:10 +0000 (16:19 -0800)]
max_sad check is not always implemented
As an optimization some architectures use the max_sad argument to break
out early from the SAD. Pass in INT_MAX instead of 0 to prevent this.
Change-Id: I653c476834b97771578d63f231233d445388629d
Scott LaVarnway [Thu, 9 Feb 2012 21:49:34 +0000 (16:49 -0500)]
x_motion_minq table reduction
Reduced by 4080 bytes.
Change-Id: I037b55bc9684bf4a54bce238be00e8c4db3f643e
Johann [Thu, 9 Feb 2012 20:38:31 +0000 (12:38 -0800)]
Fix variance overflow
In the variance calculations the difference is summed and later squared.
When the sum exceeds sqrt(2^31) the value is treated as a negative when
it is shifted which gives incorrect results.
To fix this we cast the result of the multiplication as unsigned.
The alternative fix is to shift sum down by 4 before multiplying.
However that will reduce precision.
For 16x16 blocks the maximum sum is 65280 and sqrt(2^31) is 46340 (and
change).
PPC change is untested.
Change-Id: I1bad27ea0720067def6d71a6da5f789508cec265
John Koleszar [Wed, 8 Feb 2012 19:00:55 +0000 (11:00 -0800)]
Merge "Add OS/2 supports"
KO Myung-Hun [Fri, 3 Feb 2012 04:31:11 +0000 (13:31 +0900)]
Add OS/2 supports
Change-Id: I792d5236451905eb20a8ebe444ef5b2274e4f7a4
John Koleszar [Wed, 8 Feb 2012 01:07:49 +0000 (17:07 -0800)]
support changing resolution with vpx_codec_enc_config_set
Allow the application to change the frame size during encoding. This
is only supported when not using lagged compress.
Change-Id: I89b585d703d5fd728a9e3dedf997f1b595d0db0f
John Koleszar [Tue, 7 Feb 2012 18:26:48 +0000 (10:26 -0800)]
Align internal mfqe framebuffer dimensions
MFQE postproc crashed with stream dimensions not a multiple of 16.
The buffer was memset unconditionally, so if the buffer allocation
fails we end up trying to write to NULL.
This patch traps an allocation failure with vpx_internal_error(),
and aligns the buffer dimensions to what vp8_yv12_alloc_frame_buffer()
expects.
Change-Id: I3915d597cd66886a24f4ef39752751ebe6425066
Adrian Grange [Mon, 6 Feb 2012 23:02:33 +0000 (15:02 -0800)]
Fixed bug in 5-layer multi-layer encode
The 5-layer encode must have a keyframe every 16 frames.
The KF flag was being reset after the encode of the first
frame, which it should not do for the 5-layer case
(mode=6).
Change-Id: I207d6e689d347fe3fd1075b97a817e82f7ad53b9
Adrian Grange [Mon, 6 Feb 2012 22:45:33 +0000 (14:45 -0800)]
Merge "Added 2 temporal patterns with new parameters"
Yunqing Wang [Mon, 6 Feb 2012 21:58:11 +0000 (13:58 -0800)]
Merge "Allow to skip highest-resolution encoding in multi-resolution encoder"
Yunqing Wang [Thu, 2 Feb 2012 19:27:04 +0000 (14:27 -0500)]
Allow to skip highest-resolution encoding in multi-resolution encoder
Sometimes, a user doesn't have enough bandwidth to send high-resolution
(i.e. HD) video even though the camera catches HD video. This change
allowed users to skip highest-resolution encoding by setting that level's
target bit rate to 0.
To test it, modify the following line in vp8_multi_resolution_encoder.c.
unsigned int target_bitrate[NUM_ENCODERS]={1400, 500, 100};
To skip the highest-resolution level, change it to
unsigned int target_bitrate[NUM_ENCODERS]={0, 500, 100};
To skip the first and second highest resolution levels, change it to
unsigned int target_bitrate[NUM_ENCODERS]={0, 0, 100};
This change also fixed a small problem in mapping, which slightly helped
quality and performance.
Change-Id: I977bae9a9fbfba85c8be4bd5af01539f2b84bc81
Scott LaVarnway [Thu, 2 Feb 2012 18:40:08 +0000 (13:40 -0500)]
Moved ref_frame_cost from MACROBLOCKD to MACROBLOCK
Change-Id: I05788522e9cde4322cfb12032483bdbf184bdf0b
Scott LaVarnway [Thu, 2 Feb 2012 18:34:13 +0000 (13:34 -0500)]
Removed frames_till_alt_ref_frame from MACROBLOCKD
Change-Id: Ieb05270ac332a4cc38ec4b7b995fc0150e0fffdf
Scott LaVarnway [Thu, 2 Feb 2012 18:28:41 +0000 (13:28 -0500)]
Removed frames_since_golden from MACROBLOCKD
Change-Id: I10efa441d663fceb6bc97a3bfad518cd3d9a5128
Scott LaVarnway [Tue, 31 Jan 2012 18:43:49 +0000 (10:43 -0800)]
Merge "Improved uv mv calculations in build inter predictor"
Scott LaVarnway [Fri, 20 Jan 2012 18:52:16 +0000 (13:52 -0500)]
BLOCKD structure cleanup
Removed redundancies. All of the information can be
found in the MACROBLOCKD structure.
Change-Id: I7556392c6f67b43bef2a5e9932180a737466ef93
John Koleszar [Mon, 30 Jan 2012 20:55:45 +0000 (12:55 -0800)]
RTCD: remove unimplemented vp8_short_walsh4x4_mmx
This function does not exist.
Change-Id: I84b72fb17d572d5cccee92220467b84c15842d4d
John Koleszar [Fri, 13 Jan 2012 00:55:44 +0000 (16:55 -0800)]
RTCD: finalize removal of old RTCD system
This is the final commit in the series converting to the new RTCD
system. It removes the encoder csystemdependent files and the remaining
global function pointers that didn't conform to the old RTCD system.
Change-Id: I9649706f1bb89f0cbf431ab0e3e7552d37be4d8e
John Koleszar [Fri, 13 Jan 2012 00:55:44 +0000 (16:55 -0800)]
RTCD: add arnr functions
This commit continues the process of converting to the new RTCD
system. It removes the last of the VP8_ENCODER_RTCD struct references.
Change-Id: I2a44f52d7cccf5177e1ca98a028ead570d045395
John Koleszar [Fri, 13 Jan 2012 00:55:44 +0000 (16:55 -0800)]
RTCD: add motion search functions
This commit continues the process of converting to the new RTCD
system.
Change-Id: Ia5828b7ecc80db55b21916704aa3d54cbb98f625
John Koleszar [Fri, 13 Jan 2012 00:55:44 +0000 (16:55 -0800)]
RTCD: add block subtraction functions
This commit continues the process of converting to the new RTCD
system.
Change-Id: Id8a287fdd4bd050ea4452e1582ad85520f3081be
John Koleszar [Fri, 13 Jan 2012 00:55:44 +0000 (16:55 -0800)]
RTCD: add quantizer functions
This commit continues the process of converting to the new RTCD
system.
Change-Id: Iba9df4c03a508e51c37201c621be43523fae87d9
John Koleszar [Fri, 13 Jan 2012 00:55:44 +0000 (16:55 -0800)]
RTCD: add FDCT functions
This commit continues the process of converting to the new RTCD
system.
Change-Id: I3f9c07db65eb206f6363d21bdb80e871570da767
John Koleszar [Fri, 13 Jan 2012 00:55:44 +0000 (16:55 -0800)]
RTCD: add variance functions
This commit continues the process of converting to the new RTCD
system.
Change-Id: Ie5c1aa480637e98dc3918fb562ff45c37a66c538
John Koleszar [Fri, 13 Jan 2012 00:55:44 +0000 (16:55 -0800)]
RTCD: add subpixel functions
This commit continues the process of converting to the new RTCD
system.
Change-Id: I6c519ab61e4f4e0ebcc796f2df061f945c48cefe
John Koleszar [Fri, 13 Jan 2012 00:55:44 +0000 (16:55 -0800)]
RTCD: add postproc functions
This commit continues the process of converting to the new RTCD
system.
Change-Id: If54eb5cb5d1b0cac6c4c0633a9e99c93ca860ba2
John Koleszar [Fri, 13 Jan 2012 00:55:44 +0000 (16:55 -0800)]
RTCD: add recon functions
This commit continues the process of converting to the new RTCD
system.
Change-Id: I9bfcf9bef65c3d4ba0fb9a3e1532bad1463a10d6
John Koleszar [Fri, 13 Jan 2012 00:55:44 +0000 (16:55 -0800)]
RTCD: add remaining IDCT functions
This commit continues the process of converting to the new RTCD
system.
Change-Id: I03c4dbf30dfd3558b0e256ff9d3ff4c012aadc80
John Koleszar [Fri, 13 Jan 2012 00:15:42 +0000 (16:15 -0800)]
RTCD: add loopfilter functions
This commit continues the process of converting to the new RTCD
system.
Change-Id: Ic8a4047d72ff3a54ec98977dd90e70c13213db71
John Koleszar [Fri, 19 Aug 2011 18:06:00 +0000 (14:06 -0400)]
New RTCD implementation
This is a proof of concept RTCD implementation to replace the current
system of nested includes, prototypes, INVOKE macros, etc. Currently
only the decoder specific functions are implemented in the new system.
Additional functions will be added in subsequent commits.
Overview:
RTCD "functions" are implemented as either a global function pointer
or a macro (when only one eligible specialization available).
Functions which have RTCD specializations are listed using a simple
DSL identifying the function's base name, its prototype, and the
architecture extensions that specializations are available for.
Advantages over the old system:
- No INVOKE macros. A call to an RTCD function looks like an ordinary
function call.
- No need to pass vtables around.
- If there is only one eligible function to call, the function is
called directly, rather than indirecting through a function pointer.
- Supports the notion of "required" extensions, so in combination with
the above, on x86_64 if the best function available is sse2 or lower
it will be called directly, since all x86_64 platforms implement
sse2.
- Elides all references to functions which will never be called, which
could reduce binary size. For example if sse2 is required and there
are both mmx and sse2 implementations of a certain function, the
code will have no link time references to the mmx code.
- Significantly easier to add a new function, just one file to edit.
Disadvantages:
- Requires global writable data (though this is not a new requirement)
- 1 new generated source file.
Change-Id: Iae6edab65315f79c168485c96872641c5aa09d55
John Koleszar [Fri, 27 Jan 2012 22:08:27 +0000 (14:08 -0800)]
Merge Duclair release into master branch
Change-Id: Ibf577972e8cd10488d44385ff74f136a07466c0c
John Koleszar [Fri, 27 Jan 2012 19:31:35 +0000 (11:31 -0800)]
Merge "Hook up VP8D_GET_LAST_REF_USED"
John Koleszar [Mon, 23 Jan 2012 17:21:55 +0000 (09:21 -0800)]
Update CHANGELOG for v1.0.0 (Duclair) release
Change-Id: I64472f717e5ef3672e1032b7ee24e73c4d0fff1f
John Koleszar [Mon, 23 Jan 2012 17:19:06 +0000 (09:19 -0800)]
Update AUTHORS
Change-Id: I5b0578f126308b4ec65d72553cc247b8e29c21a9
John Koleszar [Mon, 23 Jan 2012 17:18:21 +0000 (09:18 -0800)]
Update .mailmap
Change-Id: Ie7d94a884c81fab4d5dc48833a57ec2283e61fc2
John Koleszar [Fri, 27 Jan 2012 18:13:20 +0000 (10:13 -0800)]
Hook up VP8D_GET_LAST_REF_USED
Commit
892e23a5b introduced support for the VP8D_GET_LAST_REF_USED,
but missed the mapping of the control id to the underlying function,
so it was unavailable to applications.
In addition, the underlying function vp8_references_buffer() is
moved from common/postproc.c to decoder/onyxd_if.c as postproc.c is
not built in all configurations.
Change-Id: I426dd254e7e6c4c061b70d729b69a6c384ebbe44
Adrian Grange [Fri, 27 Jan 2012 00:50:15 +0000 (16:50 -0800)]
Added 2 temporal patterns with new parameters
Added new 2 and 3 layer prediction frame patterns to
vp8_scalable_patterns.c and modified the coding
parameters.
Change-Id: I18798fd7326a79d2ad1e1d5b6c26f5516b6d247f
John Koleszar [Thu, 26 Jan 2012 22:33:28 +0000 (14:33 -0800)]
Merge changes I17e1a348,Iad710941
* changes:
Correct clamping in use of vp8_find_near_mvs()
Revert "Multithreaded encoder, late sync loopfilter"
John Koleszar [Wed, 25 Jan 2012 22:55:49 +0000 (14:55 -0800)]
Correct clamping in use of vp8_find_near_mvs()
Commit
e06c242ba introduced a change to call vp8_find_near_mvs() only
once instead of once per reference frame by observing that the only
effect that the frame had was on the bias applied to the motion
vector. By keeping track of the sign_bias value, the mv to use could
be flip-flopped by multiplying its components by -1.
This behavior was subtley wrong in the case when clamping was applied
to the motion vectors found by vp8_find_near_mvs(). A motion vector
could be in-bounds with one sign bias, but out of bounds after
inverting the sign, or vice versa. The clamping must match that done
by the decoder.
This change modifies vp8_find_near_mvs() to remove the clamping from
that function. The vp8_pick_inter_mode() and vp8_rd_pick_inter_mode()
functions instead track the correctly clamped values for both bias
values, switching between them by simple assignment. The common
clamping and inversion code is in vp8_find_near_mvs_bias()
Change-Id: I17e1a348d1643497eca0be232e2fbe2acf8478e1
Attila Nagy [Thu, 26 Jan 2012 07:42:15 +0000 (09:42 +0200)]
Rename save_neon_reg.asm as save_reg_neon.asm
Easier to filter out all NEON asm.
Change-Id: I0022dae8321a9608e864b09d4181414c5fff4610
John Koleszar [Tue, 24 Jan 2012 23:32:08 +0000 (15:32 -0800)]
Revert "Multithreaded encoder, late sync loopfilter"
This commit is incomplete, as it does not synchronize the loop filter
before returning a handle to the reconstructed frame in
vpx_codec_get_preview_frame(), which can cause (false?) failures
when running the test_reconstruct_buffer test.
This may be related to a bug that does cause visible artifacts, which
is also under investigation.
This reverts commit
380d64ecb19984a1466e727244a41445ae919060.
Change-Id: Iad710941e7731d44fc2bde63bc63d6763cc4629e
Fritz Koenig [Mon, 23 Jan 2012 19:13:33 +0000 (11:13 -0800)]
Merge "Disconnect ARM tgt_isa from dsp extensions"
Scott LaVarnway [Mon, 23 Jan 2012 16:34:43 +0000 (11:34 -0500)]
Improved uv mv calculations in build inter predictor
Changed calculations to use shifts instead of if-then-else.
Eliminates branches.
Change-Id: I11b75e8bb305301ffd9cb577fb7df059a3cf9ea4
Fritz Koenig [Thu, 19 Jan 2012 23:18:31 +0000 (15:18 -0800)]
Disconnect ARM tgt_isa from dsp extensions
A processor with ARMv7 instructions does not
necessarily have NEON dsp extensions. This CL
has the added side effect of allowing the ability
to enable/disable the dsp extensions cleanly.
Change-Id: Ie1e879b8fe131885bc3d4138a0acc9ffe73a36df
Deb Mukherjee [Fri, 20 Jan 2012 16:45:42 +0000 (08:45 -0800)]
Merge "Overhauling the thresholds and mixing proportions for mfqe postprocessor."
Deb Mukherjee [Fri, 20 Jan 2012 03:06:55 +0000 (19:06 -0800)]
Overhauling the thresholds and mixing proportions for mfqe postprocessor.
Makes the thresholds for the multiframe quality enhancement module
depend on the difference between the base quantizers. Also modifies
the mixing function to weigh the current low quality frame less if
the difference in quantizer is large. With the above modifications
mfqe works well for both scalable patterns as well as low quality
key frames.
Change-Id: If24e94f63f3c292f939eea94f627e7ebfb27cb75
Jeff Faust [Thu, 19 Jan 2012 05:14:51 +0000 (21:14 -0800)]
Merge "Simplify an assignment statement"
John Koleszar [Thu, 19 Jan 2012 00:04:51 +0000 (16:04 -0800)]
Merge "Remove duplicate line in parameter parsing."
John Koleszar [Wed, 18 Jan 2012 22:22:55 +0000 (14:22 -0800)]
Merge "get_plane_pointers: use u/v planes consistently"
John Koleszar [Wed, 18 Jan 2012 20:50:06 +0000 (12:50 -0800)]
get_plane_pointers: use u/v planes consistently
The prior commit accidentally used the u plane where it should have
used the v plane.
Change-Id: Ib6c8443b99061536389f05ac25b8e0a307ace637
Jeff Faust [Wed, 18 Jan 2012 02:15:05 +0000 (18:15 -0800)]
Simplify an assignment statement
Separated a double assignment that looked suspiciously like an
assignment and equality typo.
Change-Id: I7813979e9d7ea2539afb3c8ae6074f9df5ebdf52
Fritz Koenig [Wed, 18 Jan 2012 19:28:40 +0000 (11:28 -0800)]
Merge "Add makefile for building libvpx for Android."
Jim Bankoski [Wed, 18 Jan 2012 19:12:37 +0000 (11:12 -0800)]
Merge "vp8d - valgrind warnings in mb post processor"
Fritz Koenig [Fri, 6 Jan 2012 19:50:05 +0000 (11:50 -0800)]
Add makefile for building libvpx for Android.
Android.mk file for using the Android NDK build
system to compile. Adds option for SDK path to
use the compiler that comes with android for testing
compiler compliance.
Change-Id: I5fd17cb76e3ed631758d3f392e62ae1a050d0d10
John Koleszar [Wed, 18 Jan 2012 17:30:46 +0000 (09:30 -0800)]
Merge changes I1ebe76aa,Ia079b52b
* changes:
rdopt/pickinter: factor out some common setup
rdopt: remove unused frame_lf_or_gf
Deb Mukherjee [Wed, 18 Jan 2012 17:15:24 +0000 (09:15 -0800)]
Merge "Modifying the base q propagation in the mfqe post processing filter in a way such that when there is a single bad frame, the post-processing is applied not only to just that frame but a few subsequent frames as well."
Jim Bankoski [Wed, 18 Jan 2012 01:27:39 +0000 (17:27 -0800)]
vp8d - valgrind warnings in mb post processor
Solved by extending the border in the postproc buffer as necessary
Change-Id: Ic3f61397fe5bc8e4db6fc78050b0b160bd0aee86
Fritz Koenig [Wed, 18 Jan 2012 01:11:32 +0000 (17:11 -0800)]
Remove duplicate line in parameter parsing.
resize_down_thresh was parsed and set twice.
Change-Id: I2685a6c3c825371f79ae94d305bcb50185a12dac
Deb Mukherjee [Tue, 17 Jan 2012 17:23:28 +0000 (09:23 -0800)]
Modifying the base q propagation in the mfqe post processing
filter in a way such that when there is a single bad frame, the
post-processing is applied not only to just that frame but a
few subsequent frames as well.
Change-Id: Iba5d9896eed77244eb76b4a74692a93f8ecff634
Adrian Grange [Fri, 13 Jan 2012 22:09:40 +0000 (14:09 -0800)]
Fixed bugs in multi-layer code related to changing params
When running multi-layer (ML) encodes and dynamically
changing coding parameters on the fly (e.g. frame
duration/rate, bandwidths allocated to each layer)
the encoder would not produce sensible output.
In certain cases the rate targeting would be
hideously inaccurate.
These fixes make it possible to change these coding
parameters correctly and to maintain accurate control
of the rate targeting.
I also added the specification of the input timebase
into the test program, vp8_scalable_patterns.c.
Patch 2: Moved declaration to appease MS compiler)
Change-Id: Ic8bb5a16daa924bb64974e740696e040d07ae363
John Koleszar [Wed, 11 Jan 2012 22:38:58 +0000 (14:38 -0800)]
rdopt/pickinter: factor out some common setup
Add new get_predictor_pointers() and get_reference_search_order()
functions for code shared between the two implementations.
Change-Id: I1ebe76aa8f168b1f5cfabc00d05d8f19a0d4d207
John Koleszar [Wed, 11 Jan 2012 21:02:19 +0000 (13:02 -0800)]
rdopt: remove unused frame_lf_or_gf
This flag was set but unused.
Change-Id: Ia079b52b88ffbe3b16fdbde4b84e2b87304eaa13