deepti [Tue, 5 Mar 2019 10:52:52 +0000 (16:22 +0530)]
coverity error handling
This patch initializes uninitialized member variable.
Coverity:107447 , 110284
Reference: https://review.tizen.org/gerrit/#/c/platform/framework/web/crosswalk-tizen/+/174707/
Change-Id: I80b37a13c7d41fa5a60a6c2ab324ecfa53d839e0
Signed-off-by: deepti <d.saraswat@samsung.com>
guneet khosla [Tue, 28 Aug 2018 08:50:18 +0000 (14:20 +0530)]
Set |is_window_inactive| to false when |do_reset| is true.
|is_window_inactive| is set to false when |do_reset|
is true so as to call window_->Show() and
window_->Active() in onRendered().Hence a suspended
application is showed and resumed.
Change-Id: Id9b0b0c6805a8f3bb5c40c4c7dc0e95d78fc646c
Signed-off-by: guneet khosla <g.khosla@samsung.com>
surya.kumar7 [Thu, 28 Jun 2018 13:14:45 +0000 (18:44 +0530)]
Defer showing window when appcontrol-reset is being done
In Appcontrol-reload case, if window is shown before frame rendered,
expired content is visible for a considerable time. Avoid it by
showing the window only after frame has been rendered
Change-Id: I1f126e5480e4c992b68320320763d0f9883a74c5
Signed-off-by: surya.kumar7 <surya.kumar7@samsung.com>
mallikarjun82 [Wed, 21 Mar 2018 12:55:20 +0000 (18:25 +0530)]
coverity error handling
This patch initialized member variable in constructor.
Coverity:107274
Change-Id: Ibd5504d169dd9671d35ff5905385eecbbaca54da
Signed-off-by: mallikarjun82 <vm.arjun@samsung.com>
surya.kumar7 [Wed, 28 Feb 2018 07:30:23 +0000 (13:00 +0530)]
Print dlerror() for debugging
dlopen() fails for numerous reasons and returns NULL in such cases.
Logging the error will be useful for inspecting the failure reason.
Change-Id: Idc21de1165537160baf1c7dfbb76a2b3c3cfe2d8
Signed-off-by: surya.kumar7 <surya.kumar7@samsung.com>
deepti [Wed, 14 Feb 2018 06:45:06 +0000 (12:15 +0530)]
[compatibility]
1)Don't show window in suspend state
2)Show window object if there's delay in receiving frame rendered event
1)Window is shown even after app is suspended
Window is shown on receiving frame,rendered call back. frame,rendered call back is invoking for every frame load Measure:
Maintain a state variable for suspend. In suspended state don't show window on frame,rendered call back
2)xwalk shows window object once frame rendered callback is
received. For this app, before frame rendered step is reached, alert
function (synchronized job) is used which suspends the engine and frame
rendered event is never emitted
Provide a fallback mechanism from xwalk side to show the window irrespectively after a certain time
[Reference]
http://slp-info.sec.samsung.net/gerrit/#/c/3062458/
http://slp-info.sec.samsung.net/gerrit/#/c/3105521/
signed-off-by: deepti <d.saraswat@samsung.com>
Change-Id: I3d8fb6b1a421a46ce135d14e754b2549fec05f7f
Guneet K [Thu, 1 Feb 2018 13:38:51 +0000 (19:08 +0530)]
[compatibility] Implemented window resize for non circular apps
Apps with 320x320 and square apps are not displayed properly.
View is truncated.
Resize the view to 320x320 so that maximum
possible view is displayed in visible area.
These kind of apps are identified by profile
tag.
---------------------------------------------
| SlNo| Profile | Value | Display |
---------------------------------------------
| 1 | Not Present | NA | 320x320 |
| 2 | Present | mobile | 320x320 |
| 3 | Present | NULL | 320x320 |
| 4 | Present | wearable | 360x360 |
---------------------------------------------
[Reference] http://slp-info.sec.samsung.net/gerrit/#/c/3119525/
Change-Id: I3b60cc73910b462becfa04e9112fe39f15203511
Signed-off-by: Guneet K <g.khosla@samsung.com>
Signed-off-by: deepti <d.saraswat@samsung.com>
Guneet K [Mon, 5 Feb 2018 11:30:00 +0000 (17:00 +0530)]
[compatibility] Set background color as black for wearable web apps
Call ewk_view_bg_color_set to set background color as black
for web apps.
Background color is set as black only for watchfaces.
Hence default bg color for web apps is white.
[Reference] http://slp-info.sec.samsung.net/gerrit/#/c/3106551
Change-Id: Iec328524219b009701e394aa71bb8cb588e8378b
Signed-off-by: Guneet K <g.khosla@samsung.com>
Guneet K [Mon, 5 Feb 2018 06:08:58 +0000 (11:38 +0530)]
Set background color as black for wearable web apps
[Model] COMMON
[BinType] AP
[Customer]
[Issue#] P170609-03650
[Request] N/A
[Occurrence Version] DayR765AUC_20170607.002
[Problem] White background displayed for KA Stock App instead of
black background
[Cause & Measure] Cause: Background color is set as black only for
watchfaces. Hence default bg color for web apps is
white
Measure: Call ewk_view_bg_color_set to set background
color as black for web apps
[Checking Method] 1. Build and install crosswalk-tizen rpm
2. Install KA Stock web app
3. Background color of web app should be black
Change-Id: I50f8c24f9f735ebb0ef24f49d9e8a1ebdbb11999
Signed-off-by: Guneet K <g.khosla@samsung.com>
min7.choi [Tue, 9 Jan 2018 06:46:31 +0000 (15:46 +0900)]
Remove Ecore-wayland dependency
In Tizen 5.0, upgrading EFL to opensource EFL 1.20 version.
Upstream has deprecated ecore-wayland and changed its policy to use ecore-wl2.
In crosswalk, there is one api with an ecore-wayland dependency(ecore_wl_screen_size_get()).
This can be replaced by elm_win_screen_size_get() api.
So removed the ecore-wayland dependency and used elm_win_screen_size_get()
Change-Id: I7083eec69a98f0cae5fe1406d1544fc2f1557cac
Signed-off-by: min7.choi <min7.choi@samsung.com>
Sunmin Lee [Mon, 11 Sep 2017 03:03:51 +0000 (12:03 +0900)]
Remove old update script
RW update script for Tizen 2.4 (to 3.0) is not necessary in Tizen 4.0.
Remove this file to avoid being executed during Tizen 4.0 update.
Change-Id: I1ced307959fb9637ee4f484077244313e00db42d
jaekuk, lee [Fri, 11 Aug 2017 09:46:58 +0000 (18:46 +0900)]
Add ASLR to wrt-loader and wrt-upgrade
Change-Id: Ib16832362f941d15cb68c894ea815512cfb086b1
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
Pawel Niemirski [Wed, 12 Jul 2017 12:13:09 +0000 (14:13 +0200)]
Support swipe to refresh feature
Enable the feature if config.xml has following metadata:
<tizen:metadata key="enable-swipe-to-refresh">
Bug: http://suprem.sec.samsung.net/jira/browse/RWASP-1534
Change-Id: Id430ea44a3bb344a2836e841f5103a1bb1f55141
Signed-off-by: Pawel Niemirski <p.niemirski@samsung.com>
min7.choi [Mon, 10 Jul 2017 01:39:10 +0000 (10:39 +0900)]
Remove caps due to security issue & apply caps directly in security-config
Change-Id: I70b6f0e2b4c1fb65c2bbecb5bd741c737ac020ed
Signed-off-by: min7.choi <min7.choi@samsung.com>
Pawel Niemirski [Wed, 28 Jun 2017 10:11:50 +0000 (12:11 +0200)]
Register service worker on PWA launch
Start the registration if config.xml has following metadata:
<tizen:metadata key="service-worker-url" value="...">
Bug: http://suprem.sec.samsung.net/jira/browse/RWASP-1583
Change-Id: I9ada897e7b654b4a72596935b3d6dc4a53ce13c8
Signed-off-by: Pawel Niemirski <p.niemirski@samsung.com>
jaekuk, lee [Tue, 20 Jun 2017 05:21:01 +0000 (14:21 +0900)]
Implemented progressbar for web application
issue : http://suprem.sec.samsung.net/jira/browse/MPR-1117
Hosted web app such as YouTube displays a white screen until the page finishes loading.
Modified WRT to display progressbar until the page finishes loading if progressbar-presence is enabled in config.xml.
Change-Id: I114d69543caea76161d0ace22cf57ae052c8f099
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Thu, 15 Jun 2017 06:12:39 +0000 (15:12 +0900)]
Changed a string to a variable
"fullscreen" => kViewmodeTypeFullscreen
"windowed" => kViewmodeTypeWindowed
Change-Id: I354ce4c9fa84745c9c18d208faf570a9b16e970b
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Wed, 24 May 2017 01:47:59 +0000 (10:47 +0900)]
Changed the header file of appcore-watch from appcore-watch.h to watch_app.h
Change-Id: Ib676f08863f8ec72eedd448c9fa6df20f12b4298
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Tue, 23 May 2017 12:16:36 +0000 (21:16 +0900)]
[release 0.3.2]tizen porting
Change-Id: I75ab917767be3406d23e01e6c162a5a281ed3145
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
Youngcheol Kang [Wed, 10 May 2017 08:10:21 +0000 (17:10 +0900)]
fixup! Implement Fullscreen API
In tizen 2.4 environment, WRT calls the ewk_view_fullscreen_exit()
API and exits the event handler when pressing hardware back key
if it's fullscreen mode in only "Software key" mode or "windowed"
view mode.
However above two conditions(software key and windowed view modes)
were omitted in tizen 3.0, so the ewk_view_fullscreen_exit() API
was always called when pressing hardware back key in fullscreen mode.
This CL fixes these problem.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-3201
Change-Id: I4dda2d78be7af8cf75df72875aa2d7e94bbe2da9
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Suyeon Hwang [Fri, 14 Apr 2017 01:49:25 +0000 (10:49 +0900)]
Add codes to enable web voice touch
This commit adds codes to enable web voice touch.
Web voice touch is enabled by the vconfkey value.
To use web voice touch, vc-webview module must be needed.
Change-Id: I082c537423e6d3a7b1c0943ae2119f69aabb93fe
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
jaekuk, lee [Wed, 19 Apr 2017 05:03:07 +0000 (14:03 +0900)]
Changed the order of elm_exit() and elm_shutdown()
Change-Id: Id8699768ee55faa3da46c677675d5ece135457ba
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Tue, 11 Apr 2017 08:29:26 +0000 (17:29 +0900)]
Initialized constructor
Following members are initialized.
=> main_loop, session_counter
Change-Id: Ibbea601f7dd087eb01a498fca97199c1f253ef4a
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Mon, 3 Apr 2017 06:22:40 +0000 (15:22 +0900)]
Bringup with updated chromium-efl(m56.0.2924)
--------------------------------------------------------------------------------
This patch supports the working of WebApp and WebTCT with
new updated chromium-efl(m56.0.2924).
- Changed the codes related to including 'ewk_chromium.h' from 'EWebkit.h'
- Changed the codes related to dependency of V8 in chromium-efl
Bug: http://suprem.sec.samsung.net/jira/browse/RWASP-253
Change-Id: Iee178f03e9926b13d972c975b1e53a9fa20be576
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
-------------------------------------------------------------------------------
Change-Id: I2f4ccb603b5b6e3fabebcef6eeae9f06106163bd
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Fri, 24 Mar 2017 08:26:30 +0000 (17:26 +0900)]
Explicitly specify that this supports M56
Change-Id: If8d7536bee39f176c8c2ba175a5b3688ef42a1e2
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Thu, 23 Mar 2017 01:14:27 +0000 (10:14 +0900)]
Use a macro of %license to add a license in spec file
Change-Id: I7189983a3af50498a4aedd641826873f9a90c5ca
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Wed, 22 Mar 2017 08:58:39 +0000 (17:58 +0900)]
Revert "Bringup with updated chromium-efl(m56.0.2924)"
Change-Id: I1deb2e97e4a52a24f99622cc2ffc6902c9565609
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Tue, 21 Mar 2017 06:44:10 +0000 (15:44 +0900)]
Merge branch 'tizen' of ssh://review.tizen.org:29418/platform/framework/web/crosswalk-tizen into tizen_40
jaekuk, lee [Wed, 15 Mar 2017 01:09:31 +0000 (10:09 +0900)]
Reverted from ewk_chromium.h to EWebkit.h
Change-Id: I00faba169c121cb858a69b8271b3246be828089d
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
Youngsoo Choi [Tue, 14 Mar 2017 08:26:15 +0000 (17:26 +0900)]
Disable missing ewk api just until chromium-efl bringup is completed
This CL disables ewk additional feature api call using
the macro |DENABLE_CHROMIUM_EWK_FEATURE|.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-3168
Change-Id: I75564e3ab594f6f8b8ab6fe3f5daff0ef867df64
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngcheol Kang [Thu, 8 Dec 2016 11:27:22 +0000 (20:27 +0900)]
Bringup with updated chromium-efl(m56.0.2924)
This patch supports the working of WebApp and WebTCT with
new updated chromium-efl(m56.0.2924).
- Changed the codes related to including 'ewk_chromium.h' from 'EWebkit.h'
- Changed the codes related to dependency of V8 in chromium-efl
Bug: http://suprem.sec.samsung.net/jira/browse/RWASP-253
Change-Id: Iee178f03e9926b13d972c975b1e53a9fa20be576
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Bartlomiej Kunikowski [Mon, 13 Feb 2017 10:34:37 +0000 (11:34 +0100)]
Changes that are related to changes in LaunchScreenData structure
Change-Id: I556c4443df06cdbd55588447c00082b9219d6ebd
nke94 [Thu, 2 Mar 2017 13:52:47 +0000 (22:52 +0900)]
Add initialization member variable of instance_id_
Change-Id: Ibeba04f755dec4c4b0a238045ad0fd6a09303c24
Signed-off-by: nke94 <nke94@samsung.com>
nke94 [Thu, 2 Mar 2017 13:40:04 +0000 (22:40 +0900)]
Just For Enabling build until chromium engine bring up complete
Temporary ewk additional feature api call is disabled with
(DENABLE_CHROMIUM_EWK_FEATURE) macro
Change-Id: I2a7867d4cd4d084ca4e8f99771c1efbebb8f347a
Signed-off-by: nke94 <nke94@samsung.com>
MyungJoo Ham [Thu, 10 Nov 2016 07:14:58 +0000 (16:14 +0900)]
Remove Model-Build-Features
- This is for Tizen 4.0
- The maintainer needs to create a JIRA-TRE issue when SR-ing:
- Add crosswalk-tizen-extension-circle for wearable profile's circle displays.
- Model-build-features is going to be phased out.
Change-Id: I30de7d6bb214862838b64f322cc145823057fde9
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
MyungJoo Ham [Wed, 9 Nov 2016 07:21:59 +0000 (16:21 +0900)]
Create profile-common binary for unified environment.
In Tizen 4.0, supporting "Configurability / Building Blocks",
a package is highly recommended to have a single common binary
for every profile.
If the behavior is different per profile,
1. (highly recommended) probe the profile at init/run time.
2. (highly recommended) distinguish at install time.
3. (not so recommended, but acceptable) create multiple binaries and choose one at install time;
the spec file becomes extremely messy and build time does not become shorter.
4. (CANNOT accept), different external headers (devel package) per profile.
To create an example of case 1, I've updated crosswalk-tizen.
Because there are other packages in case 4 and there are buildrequires cannot be met in some profiles,
this commit targets the future "unified" OBS project only. For the conventional profiles, the
common-ness with case 1 is limited.
To maintainer: PLEASE remove model_build_features soon. Replace it with some vconf/capi values as it is done
for other features with common/platform_info.h
- Update at patch set 3:
: Added workaround due to chromium-efl's devel package issue (header contents different per profile for Tizen internal packages)
Change-Id: I17f2be3107e4085373af644330b5d971fce1cdd7
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
jaekuk, lee [Mon, 6 Feb 2017 05:47:44 +0000 (14:47 +0900)]
Merge branch 'tizen_30' into tizen_40
jaekuk lee [Mon, 6 Feb 2017 05:39:32 +0000 (21:39 -0800)]
Merge "Terminate properly when triggering hardware back key event" into tizen_3.0
Youngsoo Choi [Mon, 6 Feb 2017 04:09:15 +0000 (13:09 +0900)]
Terminate properly when triggering hardware back key event
Termination should not be done when there are multiple webviews and
hardware back key event is triggered for page navigation.
The termination needs to be done only if there is one webview on view stack.
This CL adds condition for the checking webview count.
PLM: P170125-05834
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2951
Change-Id: I6d4056c46a0c9999d068d1dd4c14d4f4793457a0
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
jaekuk, lee [Mon, 6 Feb 2017 03:52:15 +0000 (12:52 +0900)]
Merge branch 'tizen_30' into tizen_40
jaekuk, lee [Mon, 6 Feb 2017 03:47:42 +0000 (12:47 +0900)]
Add a code to check module_system
To prevent decreasing "plugin_session_count",
because the context is not created if it is a remote URL.
Change-Id: I5a85ee2794bcb3b454ec937859435e62cd12d6ff
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Mon, 6 Feb 2017 03:47:42 +0000 (12:47 +0900)]
Add a code to check module_system
Change-Id: I5a85ee2794bcb3b454ec937859435e62cd12d6ff
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
Youngcheol Kang [Thu, 2 Feb 2017 02:41:25 +0000 (11:41 +0900)]
fixup! fixup! Refactor call of terminator
This patch fixes the following build problem in original patch.
error : No package 'appcore-watch' found
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2906
Change-Id: I31ec4f3654f800944f2c3af8478f08d65c73d5fe
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Thu, 2 Feb 2017 01:17:27 +0000 (10:17 +0900)]
fixup! Refactor call of terminator
This patch fixes the following build problem in original patch.
error: watch_app_exit was not declared in this scope
watch_app_exit();
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2906
Change-Id: Iaa9028fe0851a0fd8f93d29d779e92a1ef7a56e2
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngsoo Choi [Thu, 26 Jan 2017 06:32:15 +0000 (15:32 +0900)]
Apply session counter only for product tv
There hasn't been any issue on public profiles regarding session count.
So, the session counter is not needed for the public profiles.
Also this CL adds the codes for preventing white screen issue
during the termination of web application.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2867
Change-Id: I2418669eb7000f57d56fdca27437a11e5d59d09b
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Sungsik Han [Thu, 26 Jan 2017 06:35:07 +0000 (22:35 -0800)]
Merge "Implement notification onclick event" into tizen_3.0
Youngsoo Choi [Thu, 26 Jan 2017 06:21:07 +0000 (15:21 +0900)]
Implement notification onclick event
This CL enables notification onclick event.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2866
Change-Id: Iecb07daaacea6d82abc2824cabcc9941c33f70d1
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Srinivasarao Javvadi [Thu, 19 Jan 2017 07:44:12 +0000 (13:14 +0530)]
Web app is not launching in user binary
[Model] Pride Z250F
[BinType] AP
[Customer] N/A
[Issue#] P170109-05747
[Request] N/A
[Occurrence Version]
[Problem] Window show & active are not being called
[Cause & Measure] Cause: lang_changed_mode_ is not initialized
in WebApplication object which is created using overloaded WebApplication
constructor using Ewk_context.
During frame rendered callback, window show & active will not be called
upon language call back.
Measure: Initialize lang_changed_mode_ to false in WebApplication object
[Checking Method]
Web application window should be shown on launching the app
[Team] Web Run Time
[Developer] Srinivasarao J
[Solution company] Samsung
[Change Type] N/A
Change-Id: I0eb5acb7cafcee695bf8c6735baa6b41c1f6a91d
Youngcheol Kang [Fri, 13 Jan 2017 07:07:21 +0000 (16:07 +0900)]
Hide the window object during termination of webapp
This white screen is shown because the webview is deleted and
window object remains. This patch fixes this issue using
evas_object_hide() API for preventing the white screen issue
during the termination of web application.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2790
Change-Id: Ie697d4285d957ccc830518e78d3135c3770801c2
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngsoo Choi [Wed, 18 Jan 2017 05:29:29 +0000 (14:29 +0900)]
Refactor call of terminator
The terminator has been registered by Runtime.
It makes a dependency from WebApplication to Runtime and does not assure
the existence of the Runtime instance.
Bug:
DF170116-01203
Url: http://suprem.sec.samsung.net/jira/browse/TWF-2805
Change-Id: I700bddab8fb392dca131ab5d3a913ed63e45b792
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Mon, 16 Jan 2017 03:51:12 +0000 (12:51 +0900)]
Prevent duplicated call of |Terminate|
There will be duplicated call of |Terminate| in following case.
When pressing back key multiple times,
h/w key events emit multiple |Terminate| as they are pressed.
The |Terminate| needs to be processed once.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2801
Change-Id: I16745993d60df78c04e354352066a7db7181e303
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Mon, 16 Jan 2017 03:51:12 +0000 (12:51 +0900)]
Do not create extended main loop for termination by |Terminate|
There are two types of termination sequences.
The first one is terminated by |Terminate| and another one is
terminated by |OnTerminate| triggered by application framework.
In case of termination by |OnTerminate|, app f/w emits elm_shutdown that
quits main loop so extended main loop is needed to finish termination sequence.
Btw, in case of termination by |Terminate|, app f/w does not interrupt current
main loop so it is stll alive and extended main loop is not needed.
This CL introduces not to create extended main loop for the termination
by |Terminate|.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2804
Change-Id: I15147c9d07ec768bdb7f8acf92e18886ec2c100d
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Tue, 17 Jan 2017 05:07:27 +0000 (14:07 +0900)]
Add elementary APIs for running web app without wrt-loader
The |elm_init| and |elm_config_cache_flush_enabled_set| are missing
when launching web app without wrt-loader.
bug: http://suprem.sec.samsung.net/jira/browse/TWF-2800
Change-Id: I5effca0e67561b9ed1e900e6d5b86087143dfc81
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Thu, 12 Jan 2017 05:52:13 +0000 (14:52 +0900)]
Locate ewk_view_page_close in extended main loop
Sometimes, closing page callbkack is missing when the callback comes
between terminating main loop and creating extended main loop.
In that case, deadlock situation happens.
To avoid the issue, the ewk_view_page_close needs to be called
in extended main loop to assure receiving the callback.
Also, evas object needs to be deleted when it's valid.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2782
Change-Id: I7a86121bc7c78225b54bb6fe22b934f62615a46d
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Tue, 10 Jan 2017 05:52:26 +0000 (14:52 +0900)]
Remove unused varialbe is_on_terminate_called
Since the termination sequence was unified using context session,
the variable is_on_terminate_called hasn't been used.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2769
Change-Id: Ie30e501d1c9ed1934c9cea560922c69efe79b810
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
jaekuk, lee [Mon, 9 Jan 2017 15:22:27 +0000 (00:22 +0900)]
Merge branch 'tizen_30' into tizen_40
Youngsoo Choi [Wed, 4 Jan 2017 09:01:10 +0000 (18:01 +0900)]
Assure proper termination using context session
Current main loop quits when closing window callback is called.
Btw, it does not assure proper termination of changing watch face
because context session stops too early and callback can not be called
and then dead lock happens.
So, this CL extends the main loop until all the context sessions are finished
and covers following termination scenarios.
* h/w back key
* exit pop up menu
* exit command |pkgcmd -k|
* uninstall command |pkgcmd -u| while webapp runs
* changing watch face
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2765
Change-Id: I1767ef5f14e393ffc59668b0b9925d781abfd2f5
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
jaekuk, lee [Mon, 9 Jan 2017 13:55:28 +0000 (22:55 +0900)]
Merge branch 'tizen_30' into tizen_40
ws29.jung [Mon, 9 Jan 2017 12:23:32 +0000 (21:23 +0900)]
Prevent duplicated eventcallback call
Unexpectly, there is some case which calls same function twice.
To prevent these case, it is proper to set eventlistener to NULL
when webview is pop/erased from view stack.
Bug: http://suprem.sec.samsung.net/jira/browse/TSAM-12508
Change-Id: Ie1931bc9d20e3db0c3dde04f640b82e8b3fa17dc
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
ws29.jung [Mon, 9 Jan 2017 05:25:07 +0000 (14:25 +0900)]
Disable autotextsizing with 2.4 compatible app
When app is launching, wrt check compatibiliy then
disable autotextsizing setting with 2.4 compatibl webapp
This patch is made to resolve different app appearance issue
between 2.4 and 3.0.
Bug: P161227-02523
Change-Id: Ib358d7aa0241a4fd462d362ce9a4f80f3477d4e9
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
Sungsik Han [Fri, 6 Jan 2017 07:42:42 +0000 (23:42 -0800)]
Merge "Refactor for unifying fragmented termination sequences" into tizen_3.0
Youngsoo Choi [Wed, 4 Jan 2017 09:01:10 +0000 (18:01 +0900)]
Refactor for unifying fragmented termination sequences
There have been fragmented termination sequences of following exit scenarios.
* h/w back key
* exit pop up menu
* exit command |pkgcmd -k|
* uninstall command |pkgcmd -u| while webapp runs
This CL makes those termination sequences go through a extended main loop.
Also, removing view stacks is only handled from closing window callback and
then the extended main loop quits to terminate webapp.
The extneded main loop provides enough time for termination of renderer thread
and prevents dead lock.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2765
Change-Id: I0f6e8092bd092c07a841c6cab20be22c67fe4928
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
jaekuk lee [Thu, 5 Jan 2017 07:22:50 +0000 (23:22 -0800)]
Merge "Check web app's view mode when exiting fullscreen" into tizen_3.0
jaekuk, lee [Thu, 5 Jan 2017 04:46:05 +0000 (13:46 +0900)]
Merge branch 'tizen_30' into tizen_40
jaekuk, lee [Thu, 5 Jan 2017 04:44:40 +0000 (13:44 +0900)]
Merge branch 'tizen_3.0' of ssh://review.tizen.org:29418/platform/framework/web/crosswalk-tizen into tizen_30
jaekuk, lee [Thu, 5 Jan 2017 03:32:33 +0000 (12:32 +0900)]
Modify prefix and suffix checking the allowed domain
[P161229-05961]login page runs in browser
Change-Id: I960af6fd8254fcf071516f43f53f9650f0c357b2
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Thu, 5 Jan 2017 04:41:07 +0000 (13:41 +0900)]
Merge branch 'tizen_3.0' of ssh://review.tizen.org:29418/platform/framework/web/crosswalk-tizen into tizen_30
jaekuk lee [Thu, 5 Jan 2017 04:40:49 +0000 (20:40 -0800)]
Merge "Fix Hardware Key action when popup is on" into tizen_3.0
ws29.jung [Thu, 5 Jan 2017 04:22:04 +0000 (13:22 +0900)]
Fix Hardware Key action when popup is on
This patch fix hardware key handling when popup is shown.
Before this patch, hardware key handled in wrt before popup action is done
when key is repidly tabbed.
Now when popup is on, wrt will not trigger event.
Bug: http://suprem.sec.samsung.net/jira/browse/TSAM-12331
Change-Id: I7b620e4f4349e8c54849ee9d24a66c0ccbe062f7
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
Sungsik Han [Thu, 5 Jan 2017 04:18:38 +0000 (20:18 -0800)]
Merge "Change UserMedia popup message" into tizen_3.0
Sungsik Han [Thu, 5 Jan 2017 04:16:58 +0000 (20:16 -0800)]
Merge "Fix URI scheme parsing" into tizen_3.0
Youngmin Yoo [Thu, 5 Jan 2017 03:58:18 +0000 (12:58 +0900)]
Fix URI scheme parsing
IP/Host on the internet
ex) http://user:password@www.tizen.org:8080/market/Item?12345
url_ = http://user:password@www.tizen.org:8080/market/Item?12345
scheme_ = http
domain_ = www.tizen.org
user_ = user
password_ = password
Link : https://www.w3.org/Addressing/rfc1738.txt
Bug : P161229-04063
Bug : http://suprem.sec.samsung.net/jira/browse/TWF-2753
Change-Id: I71fbc95c5b71cd36c370c3ed34fe6d8176cb21a7
Signed-off-by: Youngmin Yoo <youngmin.yoo@samsung.com>
jaekuk, lee [Thu, 5 Jan 2017 03:37:16 +0000 (12:37 +0900)]
Merge branch 'tizen_3.0' of ssh://review.tizen.org:29418/platform/framework/web/crosswalk-tizen into tizen_30
jaekuk, lee [Thu, 5 Jan 2017 03:32:33 +0000 (12:32 +0900)]
Modify prefix and suffix checking the allowed domain
Change-Id: I960af6fd8254fcf071516f43f53f9650f0c357b2
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Wed, 4 Jan 2017 03:32:27 +0000 (12:32 +0900)]
Merge branch 'tizen_30' into tizen_40
jaekuk, lee [Wed, 4 Jan 2017 02:13:00 +0000 (11:13 +0900)]
Add a api of tizen version when creating new web view and when receiving a event of appcontrol.
Change-Id: Ica6df4f23e4a6637ae448e95080fcfb882add280
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Wed, 4 Jan 2017 02:13:00 +0000 (11:13 +0900)]
Add a api of tizen version when creating new web view.
Change-Id: Ica6df4f23e4a6637ae448e95080fcfb882add280
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
jaekuk, lee [Wed, 4 Jan 2017 02:17:26 +0000 (11:17 +0900)]
Merge branch 'tizen_30' into tizen_40
jaekuk, lee [Wed, 4 Jan 2017 02:13:00 +0000 (11:13 +0900)]
Add a api of tizen version when creating new web view.
Change-Id: Ica6df4f23e4a6637ae448e95080fcfb882add280
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
Sanjana Venkatachalam [Fri, 30 Dec 2016 09:21:29 +0000 (14:51 +0530)]
Check web app's view mode when exiting fullscreen
[Issue#] PLM P161223-02573
[Problem] Indicator is visible when user exits fullscreen after watching a video in
Hotstar web app even if viewmodes="fullscreen" is mentioned in config.xml
[Cause] When exit fullscreen callback is received, indicator is shown even if viewmode
of webapp is fullscreen
[Solution] Indicator is not shown if viewmode of webapp is fullscreen
[Verification]
1) Build and install crosswalk-tizen rpm
2) Launch Hotstar webapp and play any video
3) Open fullscreen mode and exit fullscreen
4) Indicator should not be visible
Change-Id: Ic7452d3da8f7e53ef4768b3f8ed619504fbc208e
Youngsoo Choi [Tue, 3 Jan 2017 04:10:51 +0000 (13:10 +0900)]
Reply to javascript dialog when exiting by command |pkgcmd|
There's an issue not to kill web app when javascript dialog is opened
even if the command |pkgcmd -k -n <pkgid>| is executed to kill the web app.
To prevent the issue, this CL replies to the dialog to close it
right before the termination.
Bug: TSAM-11809, TSAM-11813
Url: http://suprem.sec.samsung.net/jira/browse/TSAM-11809
Url: http://suprem.sec.samsung.net/jira/browse/TSAM-11813
Change-Id: I4757f45b3731d25cb57876f12c7b2e52b9f62af7
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngsoo Choi [Mon, 2 Jan 2017 13:33:48 +0000 (22:33 +0900)]
Refactor ClosePageFromOnTerminate
The view stack needs to be handled in class WebApplication.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2743
Change-Id: Ide43a3d254da9d1746b5235a97ed401aa24ea7b8
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Youngmin Yoo [Thu, 29 Dec 2016 02:01:33 +0000 (11:01 +0900)]
Change UserMedia popup message
3.0 UserMedia popup message has wrong mapping.
BUG : http://suprem.sec.samsung.net/jira/browse/TWF-2729
Change-Id: Id74ea20f780f00ac35123975f661715653c2fae3
Signed-off-by: Youngmin Yoo <youngmin.yoo@samsung.com>
jaekuk, lee [Tue, 27 Dec 2016 15:22:46 +0000 (00:22 +0900)]
Merge branch 'tizen_30' into tizen_40
Youngcheol Kang [Tue, 27 Dec 2016 07:09:11 +0000 (16:09 +0900)]
Reply to javascript dialog before closing webview
In order to prevent crash/fress issue, this patch adds
the codes which call the ewk_view_javascript_alert_reply()
when internal popup was opened.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2715
Change-Id: I029f0cbc4ffc5b8bb9cdf2dc35d40e0f69c9338f
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngsoo Choi [Mon, 26 Dec 2016 15:23:50 +0000 (00:23 +0900)]
Defer main loop until window is completely closed
When uninstalling a webapp is performed while running the webapp,
there's no enough time for termination of render thread by |OnTerminate|.
In that case, the life-cycle of main loop needs to be guaranteed
until closing window callback is called.
So, this CL defers main loop until window is completely closed
and removes previously implemented timer for the termination.
Bug: TSAM-12072
Url: http://suprem.sec.samsung.net/jira/browse/TSAM-12072
Change-Id: I095d522f70d1c1759d07f697a179986fea7ebab5
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Sungsik Han [Tue, 27 Dec 2016 08:59:29 +0000 (00:59 -0800)]
Merge "Improve privilege checker." into tizen_3.0
Youngmin Yoo [Thu, 22 Dec 2016 05:15:49 +0000 (14:15 +0900)]
Improve privilege checker.
Privilege check:
- given default privilege when application installed.
- added privilege in config.xml by Application developer.
Bug: P161214-04760
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2681
Change-Id: Ic21058964aa98ca26460b6717dca063aaf406043
Signed-off-by: Youngmin Yoo <youngmin.yoo@samsung.com>
Youngcheol Kang [Tue, 27 Dec 2016 06:15:41 +0000 (15:15 +0900)]
Apply the suspend before closing webview
In order to prevent crash/freeze issue, the webview should be
suspended before closing.
Bug: http://suprem.sec.samsung.net/jira/browse/TWF-2711
Change-Id: I0e69d0ccc12c41eae58b5989aeca317babcee780
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngmin Yoo [Mon, 26 Dec 2016 08:30:48 +0000 (17:30 +0900)]
fixup! Support the orientation lock for Tizen 2.4 compatibility.
This patch fixes parsed tizen verion.
Change-Id: If1b2ba0b78a76f0eee0b6e896c1e705e26f5cf68
Signed-off-by: Youngmin Yoo <youngmin.yoo@samsung.com>
Sungsik Han [Mon, 26 Dec 2016 07:29:05 +0000 (23:29 -0800)]
Merge "Support the orientation lock for Tizen 2.4 compatibility." into tizen_3.0
Youngmin Yoo [Thu, 22 Dec 2016 04:29:37 +0000 (13:29 +0900)]
Support the orientation lock for Tizen 2.4 compatibility.
In Tizen 2.4 WebKit locking screen orientation was possible with WebAPI
screen.lockOrientation(). This WebAPI was deprecated and replaced with
screen.orientation.lock(). But for compatibility case Web Engine needs to support
old API.
So WRT also need to support the orientation lock for backward compatibility.
Releted web engine patch:
https://review.tizen.org/gerrit/#/c/106159/
https://review.tizen.org/gerrit/#/c/105156/
Bug : http://suprem.sec.samsung.net/jira/browse/TWF-2640
Bug : http://suprem.sec.samsung.net/jira/browse/TWF-2698
Change-Id: I4542929c731a4c5218cfccba3592562720d21e89
Signed-off-by: Youngmin Yoo <youngmin.yoo@samsung.com>
Sungsik Han [Mon, 26 Dec 2016 00:25:45 +0000 (16:25 -0800)]
Merge "Fix the terminate routine to avoid deadlock in ewk_shutdown" into tizen_3.0
jaekuk, lee [Fri, 23 Dec 2016 08:15:55 +0000 (17:15 +0900)]
Merge branch 'tizen_30' into tizen_40
Youngcheol Kang [Fri, 23 Dec 2016 07:53:05 +0000 (16:53 +0900)]
fixup! Code refactoring about checking the EventListener of WebView class
This patch fixes the -fpermissive error about return-statement.
Change-Id: Id845258c1ee328f2d98cce50e1cfc21aeb9ec2a5
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
jaekuk, lee [Fri, 23 Dec 2016 02:57:49 +0000 (11:57 +0900)]
Merge branch 'tizen_30' into tizen_40
jaekuk, lee [Fri, 23 Dec 2016 02:38:02 +0000 (11:38 +0900)]
Modify not to do symlink when upgrading wrt
Change-Id: I65bd183b3dff314b2fa5212fd2a166c7ebbeca6f
Signed-off-by: jaekuk, lee <juku1999@samsung.com>
Youngcheol Kang [Wed, 21 Dec 2016 11:31:11 +0000 (20:31 +0900)]
fixup! Apply mime_override_callback for specific mimetype
When the mime is empty, the callback should be released to prevent
the crash issue.
Bug: http://suprem.sec.samsung.net/jira/browse/TSAM-11333
Change-Id: Iaec07731e0c4a092cce161f3d39dc4bac18c2d22
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Youngcheol Kang [Thu, 22 Dec 2016 16:12:55 +0000 (01:12 +0900)]
Fix the terminate routine to avoid deadlock in ewk_shutdown
If ewk_shutdown is called when renderer thread works,
the deadlock happens while exiting the web application.
In order to prevent this deadlock problem, crosswalk don't
terminate the web application directly, it terminate
the web application using ewk_view_page_close API.
By using ewk_view_page_close API, crosswalk can receive
the callback that renderer thread was terminated.
After then crosswalk call the ewk_shutdown.
Bug: http://suprem.sec.samsung.net/jira/browse/TSAM-11982
Change-Id: I0d6279be0a03835ab58e2bf21443dcbba286f823
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
jaekuk lee [Wed, 21 Dec 2016 07:57:19 +0000 (23:57 -0800)]
Merge "Code refactoring about checking the EventListener of WebView class" into tizen_3.0