Lennart Poettering [Sun, 16 Aug 2015 12:34:36 +0000 (14:34 +0200)]
Merge pull request #932 from kaysievers/bus
sd-bus: do not connect to dbus-1 socket when kdbus is available
Ronny Chevalier [Sat, 15 Aug 2015 12:21:42 +0000 (14:21 +0200)]
Merge pull request #968 from alkino/master
zsh completion: update busctl
Nicolas Cornu [Sat, 15 Aug 2015 11:58:05 +0000 (13:58 +0200)]
zsh completion: update busctl
Daniel Mack [Fri, 14 Aug 2015 11:31:36 +0000 (13:31 +0200)]
Merge pull request #948 from phomes/master
logind: actually fail on OOM
Lennart Poettering [Fri, 14 Aug 2015 10:44:13 +0000 (12:44 +0200)]
update TODO
Thomas Hindoe Paaboel Andersen [Thu, 13 Aug 2015 21:36:08 +0000 (23:36 +0200)]
logind: actually fail on OOM
Since
dacd6cee76a08331b8c8616c5f30f70ee49aa2f9 the two OOM's are
ignored as the value of r will be overwritten and we only log in
the fail section anyway.
This patch jumps to fail on OOM.
Note that this is different behavior compared to both the current
code and previous to
dacd6cee76a08331b8c8616c5f30f70ee49aa2f9. Before
that commit we would log that saving the inhibit data failed, but
still write the file, though without the WHO/WHY section.
CID# 1313545
Lennart Poettering [Thu, 13 Aug 2015 18:54:56 +0000 (21:54 +0300)]
Merge pull request #907 from keszybz/sd-daemon-badf
sd-daemon: return EBADF for invalid fd numbers
Daniel Mack [Thu, 13 Aug 2015 15:57:09 +0000 (17:57 +0200)]
Merge pull request #941 from phomes/master
hwdb: add DPI for a few more mice
Thomas Hindoe Paaboel Andersen [Wed, 12 Aug 2015 20:25:10 +0000 (22:25 +0200)]
hwdb: add DPI for a few more mice
Kay Sievers [Wed, 12 Aug 2015 14:08:18 +0000 (16:08 +0200)]
Merge pull request #938 from tblume/fix-kexec-force-reboot
support reboot -f for kexec kernel
Tom Gundersen [Wed, 12 Aug 2015 13:19:23 +0000 (15:19 +0200)]
Merge pull request #939 from karelzak/smatch
treewide: trivial issues detected by smatch
Kay Sievers [Wed, 12 Aug 2015 12:37:42 +0000 (14:37 +0200)]
Merge pull request #935 from teg/gpt-fixes
gpt-auto-generator: minor fixes
Thomas Blume [Wed, 12 Aug 2015 06:11:15 +0000 (08:11 +0200)]
support reboot -f for kexec kernel
Fix error message:
-->--
Code should not be reached 'Unknown action.' at
src/systemctl/systemctl.c:6382, function halt_now(). Aborting.
Aborted
--<--
when executing 'reboot -f' from a system running a kexec kernel.
Tom Gundersen [Tue, 11 Aug 2015 16:22:59 +0000 (18:22 +0200)]
gpt-auto-generator: warn on ambiguous blkid probe
Tom Gundersen [Tue, 11 Aug 2015 14:29:10 +0000 (16:29 +0200)]
gpt-auto-generator: don't warn on !ENABLE_EFI
add_automount() was only used on EFI systems, compile it conditionally
to avoid the warning.
Kay Sievers [Tue, 11 Aug 2015 18:46:05 +0000 (20:46 +0200)]
sd-bus: do not connect to dbus-1 socket when kdbus is available
We should not fall back to dbus-1 and connect to the proxy when kdbus
returns an error that indicates that kdbus is running but just does not
accept new connections because of quota limits or something similar.
Using is_kdbus_available() in libsystemd/ requires it to move from
shared/ to libsystemd/.
Based on a patch from David Herrmann:
https://github.com/systemd/systemd/pull/886
Daniel Mack [Tue, 11 Aug 2015 11:39:27 +0000 (13:39 +0200)]
Merge pull request #929 from kaysievers/gpt
gpt-auto-generator: apply partition-type flags only to specific parti…
Kay Sievers [Tue, 11 Aug 2015 11:07:25 +0000 (13:07 +0200)]
gpt-auto-generator: apply partition-type flags only to specific partition-types
The partition-type flags are defined independently for every partition-type. Apply
them only to the types where they are defined, and not to the ESP, which does not
appear to share the same set of flags.
https://github.com/systemd/systemd/issues/920
Daniel Mack [Sat, 8 Aug 2015 11:34:32 +0000 (13:34 +0200)]
Merge pull request #916 from reverendhomer/patch-3
libsystemd-network: fix memory leak
reverendhomer [Sat, 8 Aug 2015 11:24:11 +0000 (14:24 +0300)]
libsystemd-network: fix memory leak
Daniel Mack [Sat, 8 Aug 2015 09:07:05 +0000 (11:07 +0200)]
Merge pull request #914 from reverendhomer/patch-2
Coverity #1299013
Daniel Mack [Sat, 8 Aug 2015 09:05:20 +0000 (11:05 +0200)]
Merge pull request #913 from reverendhomer/patch-1
Coverity #1299015
reverendhomer [Sat, 8 Aug 2015 06:54:10 +0000 (09:54 +0300)]
Coverity #1299013
event cannot be NULL due to assert
reverendhomer [Sat, 8 Aug 2015 06:49:39 +0000 (09:49 +0300)]
Coverity #1299015
bus can never be NULL due to assert
Zbigniew Jędrzejewski-Szmek [Fri, 7 Aug 2015 15:30:18 +0000 (11:30 -0400)]
sd-daemon: return EBADF for invalid fd numbers
This matches what open(2) and other system functions do.
Zbigniew Jędrzejewski-Szmek [Fri, 7 Aug 2015 15:20:18 +0000 (11:20 -0400)]
Merge pull request #906 from jnpkrn/core-typo-fix
core: s/reexection/reexecution/ typo fix
Jan Pokorný [Fri, 7 Aug 2015 15:13:15 +0000 (17:13 +0200)]
core: s/reexection/reexecution/ typo fix
Signed-off-by: Jan Pokorný <jpokorny@redhat.com>
Daniel Mack [Fri, 7 Aug 2015 05:32:19 +0000 (07:32 +0200)]
Merge pull request #904 from keszybz/load-fragment-fix
Load fragment fix
Zbigniew Jędrzejewski-Szmek [Fri, 7 Aug 2015 04:06:15 +0000 (00:06 -0400)]
man: clarify that unknown escapes must be escaped
https://bugzilla.redhat.com/show_bug.cgi?id=1251334
is about a unit file which has
Environment=TERM=linux PS1=system-upgrade:\w\$\x20
We used to allow that, but after recent tightening of parsing
rules, we barf. Make it clear that this is intentional.
Zbigniew Jędrzejewski-Szmek [Fri, 7 Aug 2015 03:47:46 +0000 (23:47 -0400)]
load-fragment: fix segv on parse error
https://bugzilla.redhat.com/show_bug.cgi?id=1251334
Zbigniew Jędrzejewski-Szmek [Fri, 7 Aug 2015 00:16:23 +0000 (20:16 -0400)]
build-sys: line-wrap message about google servers
This way it is more readable in a wall of configure output.
Daniel Mack [Thu, 6 Aug 2015 14:13:22 +0000 (16:13 +0200)]
Merge pull request #898 from poettering/machined-fix-reload
Fix for #376, plus some other fixes
Lennart Poettering [Thu, 6 Aug 2015 13:50:54 +0000 (16:50 +0300)]
machined: rework state tracking logic for machines
This splits up the stopping logic for machines into two steps: first on
machine_stop() we begin with the shutdown of a machine by queuing the
stop method call for it. Then, in machine_finalize() we actually remove
the rest of its runtime context. This mimics closely how sessions are
handled in logind.
This also reworks the GC logic to strictly check the current state of
the machine unit, rather than shortcutting a few cases, like for example
assuming that UnitRemoved really means a machine is gone (which it isn't
since Reloading might trigger it, see #376).
Fixes #376.
Lennart Poettering [Thu, 6 Aug 2015 13:50:02 +0000 (16:50 +0300)]
machine: drop state variable from Machine object
We never made use of it, let's get rid of it.
Lennart Poettering [Thu, 6 Aug 2015 13:48:17 +0000 (16:48 +0300)]
logind,machined: various smaller cleanups
Use mfree() where we can.
Drop unnecessary {}.
Drop unnecessary variable declarations.
Cast syscall invocations where explicitly don't care for the return
value to (void).
Reword a comment.
Lennart Poettering [Thu, 6 Aug 2015 13:46:16 +0000 (16:46 +0300)]
machined,logind: don't generate errors on signal match functions
If we get a weird signal, then we should log about it, but not return an
error, since sd-bus will not call us again then anymore, but for these
signals we match here we actually do want to be called on the next
invocation.
Tom Gundersen [Thu, 6 Aug 2015 12:56:47 +0000 (14:56 +0200)]
Merge pull request #897 from poettering/sd-bus-ignore-bloom-filter
sd-bus: ignore BLOOM_FILTER kdbus items
Lennart Poettering [Thu, 6 Aug 2015 12:48:33 +0000 (15:48 +0300)]
sd-bus: ignore BLOOM_FILTER kdbus items
The kernel nowadays sends these along, and that's OK, hence don't even
debug log about it, but completely ignore it.
Tom Gundersen [Thu, 6 Aug 2015 12:34:12 +0000 (14:34 +0200)]
Merge pull request #896 from poettering/runtimedir-exec
execute: don't fail if we create the runtime directory from two proce…
Karel Zak [Thu, 6 Aug 2015 11:59:38 +0000 (13:59 +0200)]
bootctl: fix path in log message
Lennart Poettering [Thu, 6 Aug 2015 11:53:15 +0000 (14:53 +0300)]
execute: don't fail if we create the runtime directory from two processes simultaneously
If a service has both ExecStart= and ExecStartPost= set with
Type=simple, then it might happen that we have two children create the
runtime directory of a service (as configured with RuntimeDirectory=) at
the same time. Previously we did this with mkdir_safe() which will
create the dir only if it is missing, but if it already exists will at
least verify the access mode and ownership to match the right values.
This is problematic in this case, since it creates and then adjusts the
settings, thus it might happen that one child creates the directory with
root owner, another one then verifies it, and only afterwards the
directory ownership is fixed by the original child, while the second
child already failed.
With this change we'll now always adjust the access mode, so that we
know that it is right. In the worst case this means we adjust the
mode/ownership even though its unnecessary, but this should have no
negative effect.
https://bugzilla.redhat.com/show_bug.cgi?id=1226509
Karel Zak [Thu, 6 Aug 2015 11:46:49 +0000 (13:46 +0200)]
udev: variable dereferenced before check 'cmsg'
Kay Sievers [Thu, 6 Aug 2015 11:45:46 +0000 (13:45 +0200)]
bus-proxy: add comment to remove -EPERM check
Karel Zak [Thu, 6 Aug 2015 11:32:07 +0000 (13:32 +0200)]
libsystemd: fix RTNL_CONTAINER_DEPTH assert
The m->n_containers is index and has to be smaller than the array
size.
Kay Sievers [Thu, 6 Aug 2015 11:01:13 +0000 (13:01 +0200)]
Merge pull request #895 from zonque/unit-fix
core: unit: remove bus slot after calling unit_done()
Daniel Mack [Thu, 6 Aug 2015 10:53:06 +0000 (12:53 +0200)]
core: unit: remove bus slot after calling unit_done()
The ->done callback in the unit's vtable might call into
unit_unwatch_bus_name() and corrupt memory by that.
Move the call down, and clean up the bus slot in case it hasn't been done
yet.
Lennart Poettering [Thu, 6 Aug 2015 10:44:02 +0000 (13:44 +0300)]
update TODO
David Herrmann [Thu, 6 Aug 2015 09:42:40 +0000 (11:42 +0200)]
bus-proxy: fix error code for invalid reply-slots
The kernel may return EBADSLT if a reply slot cannot be found. Make sure
to ignore it just like we ignore EPERM (the comment still applies).
Lennart Poettering [Thu, 6 Aug 2015 08:25:31 +0000 (11:25 +0300)]
Merge pull request #894 from zonque/name-owner-changed-v2
core: dbus: track bus names per unit (v2)
Daniel Mack [Wed, 5 Aug 2015 15:47:45 +0000 (17:47 +0200)]
core: dbus: track bus names per unit
Currently, PID1 installs an unfiltered NameOwnerChanged signal match, and
dispatches the signals itself. This does not scale, as right now, PID1
wakes up every time a bus client connects.
To fix this, install individual matches once they are requested by
unit_watch_bus_name(), and remove the watches again through their slot in
unit_unwatch_bus_name().
If the bus is not available during unit_watch_bus_name(), just store
name in the 'watch_bus' hashmap, and let bus_setup_api() do the installing
later.
Lennart Poettering [Thu, 6 Aug 2015 07:18:57 +0000 (10:18 +0300)]
Merge pull request #888 from keszybz/completions-optional
build-sys: allow skipping installation of completions
Lennart Poettering [Thu, 6 Aug 2015 07:08:40 +0000 (10:08 +0300)]
Merge pull request #890 from fsateler/special-docs-v2
man: Clarify the difference between sysinit.target and basic.target
Lennart Poettering [Thu, 6 Aug 2015 07:06:15 +0000 (10:06 +0300)]
Merge pull request #893 from zonque/networkd
libsystemd-network: plug memory leak
Daniel Mack [Thu, 6 Aug 2015 06:53:24 +0000 (08:53 +0200)]
libsystemd-network: plug memory leak
Coverity #1315324
Zbigniew Jędrzejewski-Szmek [Thu, 6 Aug 2015 01:15:17 +0000 (21:15 -0400)]
Merge pull request #889 from keszybz/man-systemctl-quiet
man: update description of --quiet
Zbigniew Jędrzejewski-Szmek [Thu, 6 Aug 2015 01:01:06 +0000 (21:01 -0400)]
Merge branch 'hostnamectl-dot-v2'
Manual merge of https://github.com/systemd/systemd/pull/751.
Zbigniew Jędrzejewski-Szmek [Tue, 28 Jul 2015 02:37:52 +0000 (22:37 -0400)]
hostname-util: ignore case when checking if hostname is localhost
Zbigniew Jędrzejewski-Szmek [Tue, 28 Jul 2015 02:36:36 +0000 (22:36 -0400)]
hostname-util: get rid of unused parameter of hostname_cleanup()
All users are now setting lowercase=false.
Zbigniew Jędrzejewski-Szmek [Tue, 28 Jul 2015 02:30:06 +0000 (22:30 -0400)]
hostnamectl: allow trailing dot on fqdn
When the user requests to set hostname, and we are setting both
pretty and static hostnames, and the name is a valid FQDN, we
use it as the static hostname, and unset the pretty hostname.
The change is that a FQDN with a trailing dot is accepted and ignored.
https://bugzilla.redhat.com/show_bug.cgi?id=1238246
Lowercasing of the static name is not done anymore.
$ hostnamectl set-hostname Foobar.
=> static is "Foobar", pretty is "Foobar."
$ hostnamectl set-hostname Foobar.org.
=> static is "Foobar.org", pretty is unset
$ hostnamectl set-hostname Foobar.org..
=> static is "Foobar.org", pretty is "Foobar.org.."
Zbigniew Jędrzejewski-Szmek [Tue, 28 Jul 2015 02:21:07 +0000 (22:21 -0400)]
networkd: allow trailing dot on fqdn in config file
Zbigniew Jędrzejewski-Szmek [Tue, 28 Jul 2015 02:20:46 +0000 (22:20 -0400)]
firstboot: allow a trailing dot on fqdn
Zbigniew Jędrzejewski-Szmek [Tue, 28 Jul 2015 02:15:26 +0000 (22:15 -0400)]
hostname-util: add relax parameter to hostname_is_valid
Tests are modified to check behaviour with relax and without relax.
New tests are added for hostname_cleanup().
Tests are moved a new file (test-hostname-util) because there's
now a bunch of them.
New parameter is not used anywhere, except in tests, so there should
be no observable change.
Felipe Sateler [Tue, 28 Jul 2015 00:23:41 +0000 (21:23 -0300)]
man: Clarify difference between basic.target and sysinit.target
Felipe Sateler [Mon, 27 Jul 2015 22:34:19 +0000 (19:34 -0300)]
man: Clarify that basic.target does not pull in remote filesystems
Also note /var, /tmp or /var/tmp as special cases, should either of
those be a remote filesystem.
Zbigniew Jędrzejewski-Szmek [Thu, 6 Aug 2015 00:19:57 +0000 (20:19 -0400)]
man: update description of --quiet
This description should provide the general rule, without
listing all the subcommands, which is bound to get out of date
too often.
https://github.com/systemd/systemd/issues/216
Zbigniew Jędrzejewski-Szmek [Thu, 6 Aug 2015 00:10:02 +0000 (20:10 -0400)]
build-sys: allow skipping installation of completions
./configure --with-bashcompletiondir=no or --without-bashcompletiondir
now works as expected. Similarly for zsh.
https://github.com/systemd/systemd/issues/533
Daniel Mack [Thu, 6 Aug 2015 00:13:37 +0000 (02:13 +0200)]
Merge pull request #885 from keszybz/logitech-g500
hwdb: add Logitech G500 (another version)
Zbigniew Jędrzejewski-Szmek [Wed, 5 Aug 2015 23:15:05 +0000 (19:15 -0400)]
hwdb: add Logitech G500 (another version)
https://github.com/systemd/systemd/issues/562
Daniel Mack [Wed, 5 Aug 2015 23:13:21 +0000 (01:13 +0200)]
Merge pull request #881 from jrobeson/remove-fedup-todos
TODO: remove obsolete fedup related todos
Daniel Mack [Wed, 5 Aug 2015 23:12:45 +0000 (01:12 +0200)]
Merge pull request #883 from phomes/bool_vs_error_codes
tree-wide: do not return error codes as bool
Daniel Mack [Wed, 5 Aug 2015 23:12:05 +0000 (01:12 +0200)]
Merge pull request #882 from phomes/indentation
tree-wide: fix indentation
Thomas Hindoe Paaboel Andersen [Wed, 5 Aug 2015 22:32:25 +0000 (00:32 +0200)]
tree-wide: do not return error codes as bool
Thomas Hindoe Paaboel Andersen [Wed, 5 Aug 2015 22:31:09 +0000 (00:31 +0200)]
tree-wide: fix indentation
Johnny Robeson [Wed, 5 Aug 2015 21:28:29 +0000 (17:28 -0400)]
TODO: remove obsolete fedup related todos
Fedup is being replaced by a dnf plugin that relies on systemd offline
updates as per
https://fedoraproject.org/wiki/Changes/DNF_System_Upgrades
Tom Gundersen [Wed, 5 Aug 2015 20:58:55 +0000 (22:58 +0200)]
Merge pull request #878 from poettering/network-dhcp-array-fix
network: make enough space for string
Lennart Poettering [Wed, 5 Aug 2015 19:25:12 +0000 (22:25 +0300)]
network: make enough space for string
Follow-up for PR #877.
Lennart Poettering [Wed, 5 Aug 2015 19:20:36 +0000 (22:20 +0300)]
Merge pull request #877 from crawford/dhcp-private-options-v4
networkd: save private-zone DHCP options
Kay Sievers [Wed, 5 Aug 2015 18:33:48 +0000 (20:33 +0200)]
udev: uaccess - do not log error when device node disappears
https://github.com/systemd/systemd/issues/875
Alex Crawford [Sat, 1 Aug 2015 04:48:47 +0000 (21:48 -0700)]
networkd: clean up duplicate code
Alex Crawford [Sat, 1 Aug 2015 03:18:51 +0000 (20:18 -0700)]
networkd: serialize the private options
Save the private options along side the rest of the options in the lease
files.
Alex Crawford [Sat, 1 Aug 2015 03:02:22 +0000 (20:02 -0700)]
networkd: add private options to lease struct
This stores private-zone DHCP options inside of their respective DHCP
lease. These options aren't used by networkd (what would it do with
them?), but saving them will allow other programs to query the values.
To improve performance, the options are stored in ascending order by
tag.
Lennart Poettering [Wed, 5 Aug 2015 15:48:45 +0000 (18:48 +0300)]
Merge pull request #876 from zonque/logind
logind: switch to sd_bus_track helper
Daniel Mack [Wed, 5 Aug 2015 13:58:39 +0000 (15:58 +0200)]
logind: switch to sd_bus_track helper
Let logind use the sd_bus_track helper object to track the controllers of
sessions. This does not only remove quite some code but also kills the
unconditional matches for all NameOwnerChanged signals.
The latter is something we should never ever do, as it wakes up the daemon
every time a client connects, which doesn't scale.
Lennart Poettering [Wed, 5 Aug 2015 12:11:27 +0000 (15:11 +0300)]
Merge pull request #874 from richardmaw-codethink/doc-nspawn-machine-search-path-v2
man: Reference the canonical location of the search path in systemd-nspawn's documentation of the --machine option. (v2)
Richard Maw [Wed, 5 Aug 2015 08:40:36 +0000 (08:40 +0000)]
man: point nspawn --machine to machinectl search-path
The --machine option used to describe searching for machines in
/var/lib/machines, which is not the whole story, so let's link to where
it's described in more detail.
Daniel Mack [Wed, 5 Aug 2015 09:09:48 +0000 (11:09 +0200)]
Merge pull request #871 from poettering/journald-meta-fields
journald: fix count of object meta fields
Lennart Poettering [Wed, 5 Aug 2015 08:40:34 +0000 (11:40 +0300)]
Merge pull request #864 from phomes/master
hwdb: add Logitech LX8 DPI and wheel click settings
Lennart Poettering [Wed, 5 Aug 2015 08:31:52 +0000 (11:31 +0300)]
journald: fix count of object meta fields
There are 12 object meta fields created in dispatch_message_real(), but
we only allocated space for 11. Fix this.
Fixes #866.
Daniel Mack [Wed, 5 Aug 2015 08:12:29 +0000 (10:12 +0200)]
Merge pull request #869 from poettering/tmpfiles-enoent
sysctl: reword warning message a bit
Lennart Poettering [Wed, 5 Aug 2015 08:02:24 +0000 (11:02 +0300)]
sysctl: reword warning message a bit
Let's make this less dramatic, in order to not confuse people too much
making them think that this was something to actually fix.
Lennart Poettering [Wed, 5 Aug 2015 07:58:54 +0000 (10:58 +0300)]
Merge pull request #868 from jsynacek/jsynacek/sysctl
sysctl: bump loglevel when attempting to write invalid values [v2]
Jan Synacek [Tue, 4 Aug 2015 13:46:34 +0000 (15:46 +0200)]
sysctl: bump loglevel when attempting to write invalid values
Daniel Mack [Wed, 5 Aug 2015 05:38:08 +0000 (07:38 +0200)]
Merge pull request #865 from mattst88/alpha-getxpid
Use getxpid syscall on alpha for raw_getpid()
Matt Turner [Tue, 4 Aug 2015 21:47:01 +0000 (14:47 -0700)]
Use getxpid syscall on alpha for raw_getpid()
Alpha does not have a getpid syscall, but rather has getxpid to match
OSF/1.
Lennart Poettering [Tue, 4 Aug 2015 21:13:27 +0000 (00:13 +0300)]
Merge pull request #855 from richardmaw-codethink/machinectl-copy-to-from-relative-paths-v2
Allow relative paths in `machinectl copy-{from,to}` (v2)
Thomas Hindoe Paaboel Andersen [Tue, 4 Aug 2015 20:36:21 +0000 (22:36 +0200)]
gpt-auto-generator: remove unused variable
Thomas Hindoe Paaboel Andersen [Tue, 4 Aug 2015 20:12:35 +0000 (22:12 +0200)]
hwdb: add Logitech LX8 DPI and wheel click settings
Kay Sievers [Tue, 4 Aug 2015 15:26:20 +0000 (17:26 +0200)]
Merge pull request #857 from dvdhrm/proxy-reload
bus-proxy: add ExecReload=
Daniel Mack [Tue, 4 Aug 2015 12:27:09 +0000 (14:27 +0200)]
Merge pull request #860 from walyong/smack_v11
Smack v11: set only the default smack process label if the command path has no execute label
Daniel Mack [Tue, 4 Aug 2015 12:23:17 +0000 (14:23 +0200)]
Merge pull request #858 from dvdhrm/proxy-env
bus-proxy: discard invalid environment updates