piotaixr [Tue, 28 Oct 2014 15:10:42 +0000 (08:10 -0700)]
Override SkCanvas::drawImage[Rect]() in SkProxyCanvas
BUG=skia:2947
Review URL: https://codereview.chromium.org/
679293002
joshualitt [Tue, 28 Oct 2014 14:54:54 +0000 (07:54 -0700)]
Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
84c94c0dfd1e12e97d8a835882dda575f36e41d2
Review URL: https://codereview.chromium.org/
678073005
robertphillips [Tue, 28 Oct 2014 14:21:44 +0000 (07:21 -0700)]
Alter layer hoisting to only hoist layers for one canvas at a time
This CL alters layer hoisting to defer creation of the free floating layers until they are actually needed (rather than creating _all_ the hoisted layers at the start).
It also fixes a pre vs. post Concat bug with how matrices were being accumulated.
BUG=skia:2315
Review URL: https://codereview.chromium.org/
657383004
junov [Tue, 28 Oct 2014 14:14:58 +0000 (07:14 -0700)]
Add SK_API to global scope operators of SkMatrix
Review URL: https://codereview.chromium.org/
678153002
reed [Tue, 28 Oct 2014 14:12:37 +0000 (07:12 -0700)]
not a failure if we didn't load the test file
BUG=skia:
Review URL: https://codereview.chromium.org/
687453005
egdaniel [Tue, 28 Oct 2014 14:06:36 +0000 (07:06 -0700)]
Add Geometry processor to srcAlphaWillBeOne check.
BUG=skia:
Review URL: https://codereview.chromium.org/
681333002
djsollen [Tue, 28 Oct 2014 13:53:08 +0000 (06:53 -0700)]
Update the Android NDK to r10c
Review URL: https://codereview.chromium.org/
687603002
halcanary [Tue, 28 Oct 2014 13:33:07 +0000 (06:33 -0700)]
Replace color_wheel.* with beautiful versions I made with Skia.
NOTRY=true
Review URL: https://codereview.chromium.org/
683113002
hcm [Tue, 28 Oct 2014 04:43:30 +0000 (21:43 -0700)]
Revert of Use approximate scratch textures for image filters. (patchset #2 id:20001 of https://codereview.chromium.org/
679113004/)
Reason for revert:
Continued GM failures
Original issue's description:
> Use approximate scratch textures for image filters.
>
> Committed: https://skia.googlesource.com/skia/+/
96c60686eef6fc514feba6136f1b475f71dbf3ec
>
> Committed: https://skia.googlesource.com/skia/+/
50a140563c5960acb2479d2be7c437d146963b3f
TBR=senorblanco@google.com,senorblanco@chromium.org,bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
681183002
hcm [Tue, 28 Oct 2014 03:55:01 +0000 (20:55 -0700)]
Revert of Fix bounds computation of all 0-input filters. (patchset #2 id:20001 of https://codereview.chromium.org/
681643003/)
Reason for revert:
try again
Original issue's description:
> Fix bounds computation of all 0-input filters.
>
> The SkRectShaderImageFilter had the same bug as previously fixed for
> SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste
> the implementation, this change makes all filters with 0 inputs return
> their source bounds, instead of returning false.
>
> BUG=427251
>
> Committed: https://skia.googlesource.com/skia/+/
ba036cc82b5a543a13cafd11a19ba0e3087fca38
TBR=bsalomon@google.com,senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=427251
Review URL: https://codereview.chromium.org/
678273002
hcm [Tue, 28 Oct 2014 03:53:25 +0000 (20:53 -0700)]
Revert of Rebaseline imagemagnifier and dropshadowimagefilter tests. (patchset #3 id:40001 of https://codereview.chromium.org/
685523002/)
Reason for revert:
Getting to revert for failures on image filter tests in Skia and Blink
Original issue's description:
> Rebaseline imagemagnifier and dropshadowimagefilter tests.
>
> BUG=skia:
> TBR=hcm@google.com
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/
0fc71ea432d3895ede198a24080f877e607cd264
TBR=senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
678043003
hcm [Tue, 28 Oct 2014 03:48:57 +0000 (20:48 -0700)]
Revert of Re-add suppressions for magnifier and dropshadow GMs. (patchset #1 id:1 of https://codereview.chromium.org/
686573002/)
Reason for revert:
Trying to get revert of patchset potentially causing failures on image filter tests
Original issue's description:
> Re-add suppressions for magnifier and dropshadow GMs.
>
> Brian's change has invalidated the new baselines, so they'll need
> to be rebaselined again once his changed has worked its way through.
>
> TBR=bsalomon
> NOTRY=true
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
fa4689d56384da5bb264a480e636fac126fb93ca
TBR=bsalomon@google.com,senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
679413002
Ravi Mistry [Tue, 28 Oct 2014 01:21:16 +0000 (21:21 -0400)]
Whitespace change to trigger builds
joshualitt [Tue, 28 Oct 2014 00:56:18 +0000 (17:56 -0700)]
Revert of Patch to remove constant attributes (patchset #6 id:100001 of https://codereview.chromium.org/
678073005/)
Reason for revert:
Breaks the K1
Original issue's description:
> Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
84c94c0dfd1e12e97d8a835882dda575f36e41d2
TBR=bsalomon@google.com,egdaniel@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
679363002
joshualitt [Mon, 27 Oct 2014 22:33:33 +0000 (15:33 -0700)]
Working patch to remove constant attributes. This may cause some gm mismatches, I will rebaseline tonight.
BUG=skia:
Review URL: https://codereview.chromium.org/
678073005
piotaixr [Mon, 27 Oct 2014 22:31:34 +0000 (15:31 -0700)]
Reenable assertions that were reported failing in tests/CanvasTest.cpp
BUG=skia:498,skia:499
Review URL: https://codereview.chromium.org/
670403002
joshualitt [Mon, 27 Oct 2014 21:51:01 +0000 (14:51 -0700)]
Scissor rect on drawinfo
BUG=skia:
Review URL: https://codereview.chromium.org/
678683005
senorblanco [Mon, 27 Oct 2014 21:26:26 +0000 (14:26 -0700)]
Re-add suppressions for magnifier and dropshadow GMs.
Brian's change has invalidated the new baselines, so they'll need
to be rebaselined again once his changed has worked its way through.
TBR=bsalomon
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
686573002
senorblanco [Mon, 27 Oct 2014 21:12:57 +0000 (14:12 -0700)]
Rebaseline imagemagnifier and dropshadowimagefilter tests.
BUG=skia:
TBR=hcm@google.com
NOTRY=true
Review URL: https://codereview.chromium.org/
685523002
bsalomon [Mon, 27 Oct 2014 20:56:20 +0000 (13:56 -0700)]
Use approximate scratch textures for image filters.
Committed: https://skia.googlesource.com/skia/+/
96c60686eef6fc514feba6136f1b475f71dbf3ec
Review URL: https://codereview.chromium.org/
679113004
senorblanco [Mon, 27 Oct 2014 20:38:12 +0000 (13:38 -0700)]
Fix bounds computation of all 0-input filters.
The SkRectShaderImageFilter had the same bug as previously fixed for
SkBitmapSource and SkPictureImageFilter. Rather than copy-and-paste
the implementation, this change makes all filters with 0 inputs return
their source bounds, instead of returning false.
BUG=427251
Review URL: https://codereview.chromium.org/
681643003
bsalomon [Mon, 27 Oct 2014 19:59:03 +0000 (12:59 -0700)]
Revert of Use approximate scratch textures for image filters. (patchset #1 id:1 of https://codereview.chromium.org/
679113004/)
Reason for revert:
Images change on some machines. Mostly look OK but not sure about imagefiltersbase on N5.
Old"
http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/imagefiltersbase/
11449357083048653160.png
New:
http://chromium-skia-gm.commondatastorage.googleapis.com/gm/bitmap-64bitMD5/imagefiltersbase/
14279906119350384263.png
Original issue's description:
> Use approximate scratch textures for image filters.
>
> Committed: https://skia.googlesource.com/skia/+/
96c60686eef6fc514feba6136f1b475f71dbf3ec
TBR=senorblanco@google.com,senorblanco@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
664823003
bsalomon [Mon, 27 Oct 2014 19:53:08 +0000 (12:53 -0700)]
stuff
BUG=skia:
Review URL: https://codereview.chromium.org/
655913003
bsalomon [Mon, 27 Oct 2014 19:41:45 +0000 (12:41 -0700)]
Use approximate scratch textures for image filters.
Review URL: https://codereview.chromium.org/
679113004
bungeman [Mon, 27 Oct 2014 18:51:58 +0000 (11:51 -0700)]
Match language tags by prefix on Android.
A request for 'zh' should match 'zh-Hans' and 'zh-Hant'.
Review URL: https://codereview.chromium.org/
681823003
halcanary [Mon, 27 Oct 2014 17:32:18 +0000 (10:32 -0700)]
add gm: filterbitmap_image_color_wheel
BUG=skia:3061
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/
633333004
humper [Mon, 27 Oct 2014 17:32:06 +0000 (10:32 -0700)]
Fix the way we patch up the matrix for scaled images that aren't
clamp/clamp
BUG=skia:2904
TBR=reed
Review URL: https://codereview.chromium.org/
675823002
mtklein [Mon, 27 Oct 2014 17:27:10 +0000 (10:27 -0700)]
Cut down SkBBH API more.
- The expected case is now a single bulk-load insert() call instead of N;
- reserve() and flushDeferredInserts() can fold into insert() now;
- SkBBH subclasses may take ownership of the bounds
This appears to be a performance no-op on both my Mac and N5. I guess
even the simplest indirect branch predictor ("same as last time") can predict
the repeated virtual calls to SkBBH::insert() perfectly.
BUG=skia:
Review URL: https://codereview.chromium.org/
670213002
jcgregorio [Mon, 27 Oct 2014 17:27:01 +0000 (10:27 -0700)]
Start moving to the new canvas structure.
Adds DrawingMethods with some of the methods it defines. Context is now
an implementation of DrawingMethods.
The sample.js file now shows how the context is used.
Not much new code here, that's mostly in DrawingMethods::DrawPath, most everything else is a code move.
BUG=skia:
Review URL: https://codereview.chromium.org/
676423002
scroggo [Mon, 27 Oct 2014 15:43:12 +0000 (08:43 -0700)]
Allow index sources to be unpremul.
This only affects the PNG image decoder, where we have already created
the color table without premultiplication. Since the RowProcChooser is
just providing a proc that chooses indices into the color table, it can
just return the same RowProc.
Update test_row_proc_choice. It was testing to ensure that we hadn't
changed the behavior from the original version of setPrefConfigTable.
In this case, we deliberately changed the behavior, so we need to
change the test.
BUG=b/
12024301
Review URL: https://codereview.chromium.org/
657863005
joshualitt [Mon, 27 Oct 2014 15:39:00 +0000 (08:39 -0700)]
Clip mask manager sets stencil on draw type
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
7afb5aa201e4b59397cbd8480e121d7501a227e7
Review URL: https://codereview.chromium.org/
676983003
sugoi [Mon, 27 Oct 2014 15:03:56 +0000 (08:03 -0700)]
Adding color cube to fuzzer
BUG=skia:
Review URL: https://codereview.chromium.org/
677713003
jvanverth [Mon, 27 Oct 2014 14:58:30 +0000 (07:58 -0700)]
Update perspective GM expectations after disabling some DF paths
BUG=skia:3066
TBR=hcm@google.com
Review URL: https://codereview.chromium.org/
680913003
joshualitt [Mon, 27 Oct 2014 14:38:01 +0000 (07:38 -0700)]
Revert of Clip mask manager sets stencil on draw type (patchset #3 id:40001 of https://codereview.chromium.org/
676983003/)
Reason for revert:
seems to cause a gm issue on windows.
Original issue's description:
> Clip mask manager sets stencil on draw type
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
7afb5aa201e4b59397cbd8480e121d7501a227e7
TBR=bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
678843003
jcgregorio [Mon, 27 Oct 2014 14:19:44 +0000 (07:19 -0700)]
Fixup references to the js files from the HTML files in SkV8Example.
BUG=skia:
Review URL: https://codereview.chromium.org/
680053002
joshualitt [Mon, 27 Oct 2014 14:17:17 +0000 (07:17 -0700)]
Clip mask manager sets stencil on draw type
BUG=skia:
Review URL: https://codereview.chromium.org/
676983003
halcanary [Mon, 27 Oct 2014 14:06:47 +0000 (07:06 -0700)]
In SkPDFDocumentToBitmap, use SkCreateDataProviderFromStream
CGDataProviderCreateWithData to SkCreateDataProviderFromStream in
SkPDFDocumentToBitmap
Review URL: https://codereview.chromium.org/
678763003
rmistry [Mon, 27 Oct 2014 13:42:11 +0000 (06:42 -0700)]
Fix ability to capture archives in webpages_playback.py
Updated all page sets to match the file name. This is to make it easier to call record_wpr with the page set class name.
Also updated the wait time for baidu to 60 seconds.
BUG=skia:3049
Review URL: https://codereview.chromium.org/
683473002
halcanary [Mon, 27 Oct 2014 13:24:11 +0000 (06:24 -0700)]
Use MacOS's CoreGraphics PDF Rasterizer in DM
BUG=3061
Review URL: https://codereview.chromium.org/
650323004
skia-deps-roller [Mon, 27 Oct 2014 11:26:56 +0000 (04:26 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
682573002
halcanary [Sun, 26 Oct 2014 12:23:53 +0000 (05:23 -0700)]
add gm: colorwheel
BUG=skia:3061
Review URL: https://codereview.chromium.org/
680533002
reed [Sun, 26 Oct 2014 03:44:40 +0000 (20:44 -0700)]
add saveLayer to lua
BUG=skia:
TBR=
Review URL: https://codereview.chromium.org/
679903002
robertphillips [Sat, 25 Oct 2014 03:02:31 +0000 (20:02 -0700)]
Move .js files to their own directory
Review URL: https://codereview.chromium.org/
677133002
joshualitt [Fri, 24 Oct 2014 22:02:11 +0000 (15:02 -0700)]
bug fix for k1
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
675213003
egdaniel [Fri, 24 Oct 2014 22:00:50 +0000 (15:00 -0700)]
Add gpu support for glVertexAttrb1f, 2fv, and 3fv
BUG=skia:
Review URL: https://codereview.chromium.org/
662583003
halcanary [Fri, 24 Oct 2014 19:54:53 +0000 (12:54 -0700)]
Add `SkIRect bounds()` convenience method to SkImageInfo and SkBitmap.
Review URL: https://codereview.chromium.org/
646213003
jvanverth [Fri, 24 Oct 2014 19:53:01 +0000 (12:53 -0700)]
Update GM expectations for https://codereview.chromium.org/
677463002/
BUG=skia:2935
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/
677123002
jcgregorio [Fri, 24 Oct 2014 19:49:17 +0000 (12:49 -0700)]
Doing the "using namespace" penance by adding in v8:: everywhere, like I should have to begin with.
Also:
- SkWindow now has createSurface, not createCanvas.
- Add the platform init code v8 now seems to require.
- Fix library linkage.
- Call isolate->Enter(); because it doesn't look
like v8 starts with a default isolate to begin with.
BUG=skia:
Review URL: https://codereview.chromium.org/
673223002
bsalomon [Fri, 24 Oct 2014 19:46:56 +0000 (12:46 -0700)]
Delete unused method aliases and texture flag.
Committed: https://skia.googlesource.com/skia/+/
7fdffe41494cbd78a8ee2a6ef0509e46ec77039f
Review URL: https://codereview.chromium.org/
672753002
bsalomon [Fri, 24 Oct 2014 19:42:51 +0000 (12:42 -0700)]
When bmp is not cached don't upload as index8 format.
Review URL: https://codereview.chromium.org/
673883002
jvanverth [Fri, 24 Oct 2014 19:41:32 +0000 (12:41 -0700)]
Add some more volatile paths.
Some clip paths were not marked as volatile, and ending up in the
distance field path renderer when they shouldn't.
BUG=skia:3066
Review URL: https://codereview.chromium.org/
680543002
Thiago Farina [Fri, 24 Oct 2014 19:21:41 +0000 (17:21 -0200)]
tools: Remove reference to svndiff.
svndiff script was archived by commit
https://skia.googlesource.com/skia/+/
70242ace3b2ed06b33ee5ea5c9ac3aedea89b194
R=borenet@google.com
Review URL: https://codereview.chromium.org/
658923002
joshualitt [Fri, 24 Oct 2014 18:26:03 +0000 (11:26 -0700)]
Added varying struct
TBR=
BUG=skia:
Committed: https://skia.googlesource.com/skia/+/
852ae80b9c3c6fd53f993ac35133d80863993cbe
Review URL: https://codereview.chromium.org/
671023002
reed [Fri, 24 Oct 2014 18:16:19 +0000 (11:16 -0700)]
move c api into include
BUG=skia:
Review URL: https://codereview.chromium.org/
665203004
mtklein [Fri, 24 Oct 2014 17:43:15 +0000 (10:43 -0700)]
Remove a pointless use of SkWeakRefCnt.
Can't quite get rid of SkWeakRefCnt yet... SkFontMgr_indirect uses it to cache
SkTypefaces, and I don't quite understand it enough yet to cut out the weak refs.
BUG=skia:3065
Review URL: https://codereview.chromium.org/
664173003
bsalomon [Fri, 24 Oct 2014 17:40:50 +0000 (10:40 -0700)]
Print GPU cache stats in nanobench/dm with veryVerbose
Review URL: https://codereview.chromium.org/
680553002
mtklein [Fri, 24 Oct 2014 17:20:22 +0000 (10:20 -0700)]
Add harfbuzz to DEPS
https://skia.googlesource.com/third_party/harfbuzz/
BUG=skia:3067
Review URL: https://codereview.chromium.org/
679733002
jvanverth [Fri, 24 Oct 2014 16:40:43 +0000 (09:40 -0700)]
Ignore simpleaaclip_path on Win7-gpu for now.
BUG=skia:3066
TBR=mtklein@google.com
Review URL: https://codereview.chromium.org/
646523005
bsalomon [Fri, 24 Oct 2014 16:34:41 +0000 (09:34 -0700)]
Build gpu stats tracking in dev builds.
Fix cache stats, add more info.
BUG=skia:2889
Review URL: https://codereview.chromium.org/
655263005
Hal Canary [Fri, 24 Oct 2014 16:18:46 +0000 (12:18 -0400)]
add color wheel to validate decoding colors
BUG=skia:3061
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
681433002
joshualitt [Fri, 24 Oct 2014 15:24:08 +0000 (08:24 -0700)]
Revert of Added varying struct (patchset #9 id:160001 of https://codereview.chromium.org/
671023002/)
Reason for revert:
may have caused gm change on arm
Original issue's description:
> Added varying struct
>
> TBR=
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
852ae80b9c3c6fd53f993ac35133d80863993cbe
TBR=bsalomon@google.com,joshualitt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
675193002
tfarina [Fri, 24 Oct 2014 15:07:05 +0000 (08:07 -0700)]
Add isScale() helper function to SkMatrix44.
This will be used later in Chromium to cleanup gfx::Transform::IsScale2d().
BUG=408710,skia:997
TEST=None
R=bsalomon@google.com,danakj@chromium.org
Review URL: https://codereview.chromium.org/
676583002
mtklein [Fri, 24 Oct 2014 15:05:58 +0000 (08:05 -0700)]
rebaseline for new shaderproc
BUG=skia:
Review URL: https://codereview.chromium.org/
674123003
joshualitt [Fri, 24 Oct 2014 14:56:04 +0000 (07:56 -0700)]
Added varying struct
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
671023002
bsalomon [Fri, 24 Oct 2014 14:26:00 +0000 (07:26 -0700)]
Rebaseline lots of images, associate some with bug 3063.
TBR=
NOTRY=true
Review URL: https://codereview.chromium.org/
661323003
jvanverth [Fri, 24 Oct 2014 14:12:51 +0000 (07:12 -0700)]
Set temporary paths volatile so we don't cache them.
Any path that is generated frame-to-frame should not be rendered by using the
DistanceFieldPathRenderer, because generating the initial distance field,
uploading it and rendering it takes longer than the SoftwarePathRenderer.
BUG=skia:2935
Review URL: https://codereview.chromium.org/
677463002
scroggo [Fri, 24 Oct 2014 13:55:07 +0000 (06:55 -0700)]
Add test for new FrontBufferedStream behavior.
Test for https://skia.googlesource.com/skia/+/
dd5a1e094c19fa10202c37c50a1f799e5af5dac0
Verify that FrontBufferedStream does not attempt to read beyond the
end of its underlying stream.
Make SkStreamToCGImageSource handle an empty stream better.
Review URL: https://codereview.chromium.org/
641813009
scroggo [Fri, 24 Oct 2014 13:49:57 +0000 (06:49 -0700)]
Don't read random data in ICO check.
Check to ensure SkStream::read succeeds before checking the result.
Review URL: https://codereview.chromium.org/
656673005
jcgregorio [Fri, 24 Oct 2014 12:57:37 +0000 (05:57 -0700)]
Re-add in v8 to DEPS.
BUG=skia:
Review URL: https://codereview.chromium.org/
673713004
skia-deps-roller [Fri, 24 Oct 2014 12:47:24 +0000 (05:47 -0700)]
Update SKP version
Automatic commit by the RecreateSKPs bot.
TBR=
Review URL: https://codereview.chromium.org/
679693002
joshualitt [Fri, 24 Oct 2014 01:23:32 +0000 (18:23 -0700)]
Possible optimization to SkString
BUG=skia:
Review URL: https://codereview.chromium.org/
679433003
tfarina [Fri, 24 Oct 2014 00:47:18 +0000 (17:47 -0700)]
Cleanup: Turn GrReducedClip into a class with a static function.
Clean up namespace usage.
Similar to what was done in
https://skia.googlesource.com/skia/+/
a5414c4a8efc3119ee20fcee96c0bf68a04909c7
BUG=None
TEST=None
R=bsalomon@google.com
Review URL: https://codereview.chromium.org/
653393003
scroggo [Thu, 23 Oct 2014 22:42:11 +0000 (15:42 -0700)]
Add flag to skimage for decoding into unpremul.
Review URL: https://codereview.chromium.org/
666073006
mtklein [Thu, 23 Oct 2014 22:24:11 +0000 (15:24 -0700)]
squelch filterindiabox too
TBR=bsalomon@google.com
BUG=skia:
Review URL: https://codereview.chromium.org/
677463003
senorblanco [Thu, 23 Oct 2014 22:00:10 +0000 (15:00 -0700)]
Fix imagemagnifier GM quality and speed.
The imagemagnifier GM was applying the filter both to a saveLayer()
restore() around the whole scene, as well as to each individual
text draw.
Applying the filter only in the saveLayer() makes it run ~20x faster
on my Linux box, and the quality is improved as well (since the
primitives are not double-filtered).
BUG=skia:
Review URL: https://codereview.chromium.org/
637283009
mtklein [Thu, 23 Oct 2014 21:35:01 +0000 (14:35 -0700)]
Revert "Revert of create shaderproc for nofilter-opaque-dx (patchset #7 id:120001 of https://codereview.chromium.org/
664783004/)"
This reverts commit
430b795cc8a1cdbddd8fdc5511a3a523348937f7 and adds suppressions.
BUG=skia:
Review URL: https://codereview.chromium.org/
673023002
bsalomon [Thu, 23 Oct 2014 21:17:46 +0000 (14:17 -0700)]
Don't use MIP filter mode on compressed textures
Add compressed texture image downsample GMs
BUG=chromium:426331
Review URL: https://codereview.chromium.org/
672863003
senorblanco [Thu, 23 Oct 2014 21:01:38 +0000 (14:01 -0700)]
Remove test expectations from ignored-tests.txt.
TBR=mtklein@google.com
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
659393006
sugoi [Thu, 23 Oct 2014 20:59:52 +0000 (13:59 -0700)]
Adding an option to render only the shadow in SkDropShadowImageFilter
This is basically how blink uses the filter. Currently, I can't use it for "ShadowOnly" mode with the filter at all, but instead of copying the code and risking to have the codepaths diverge, I'm simply going to add the option here.
BUG=skia:
Review URL: https://codereview.chromium.org/
646213004
senorblanco [Thu, 23 Oct 2014 20:50:54 +0000 (13:50 -0700)]
Rebaselines for tests affected by image filter PDF change.
(aka https://codereview.chromium.org/
644323006/)
TBR=mtklein@google.com
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
671303003
pavel [Thu, 23 Oct 2014 20:18:50 +0000 (13:18 -0700)]
Add utils to better quantize grayscale values to three bit indices while
compressing coverage masks.
Signed-off-by: Pavel Krajcevski <pavel@cs.unc.edu>
BUG=skia:
Review URL: https://codereview.chromium.org/
669243003
caryclark [Thu, 23 Oct 2014 20:08:56 +0000 (13:08 -0700)]
add float equivalent in dumpHex output as comment
R=reed@google.com,bsalomon@google.com
Review URL: https://codereview.chromium.org/
676803002
mtklein [Thu, 23 Oct 2014 19:44:39 +0000 (12:44 -0700)]
Revert of create shaderproc for nofilter-opaque-dx (patchset #7 id:120001 of https://codereview.chromium.org/
664783004/)
Reason for revert:
Many GMs fixed. Needs rebaseline, perhaps layout test rebaselines.
Original issue's description:
> create shaderproc for nofilter-opaque-dx
>
>
> speedup nofilter
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/
a40a276bcee2246439dcf816273c1307f5c3c69f
TBR=djsollen@google.com,reed@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Review URL: https://codereview.chromium.org/
656913005
reed [Thu, 23 Oct 2014 19:42:46 +0000 (12:42 -0700)]
use SkMaskCache inside SkBlurMaskFilter
depends on https://codereview.chromium.org/
670063004/
BUG=skia:
Review URL: https://codereview.chromium.org/
669993003
bungeman [Thu, 23 Oct 2014 19:25:29 +0000 (12:25 -0700)]
Correct typo in SkRemotableFontMgr_win_dw.cpp.
New code was introduced behind a flag, but in that code there is a comma
before a parameter name instead of after.
Review URL: https://codereview.chromium.org/
646323003
reed [Thu, 23 Oct 2014 19:22:40 +0000 (12:22 -0700)]
create shaderproc for nofilter-opaque-dx
speedup nofilter
BUG=skia:
Review URL: https://codereview.chromium.org/
664783004
mtklein [Thu, 23 Oct 2014 19:08:03 +0000 (12:08 -0700)]
Revert of Add test for new FrontBufferedStream behavior. (patchset #1 id:1 of https://codereview.chromium.org/
641813009/)
Reason for revert:
Test is SkASSERTing on Macs, e.g:
http://chromegw.corp.google.com/i/client.skia/builders/Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Debug/builds/257/steps/dm/logs/stdio
210 tasks left 1737M peak 1ms test FrontBufferedStream../../src/ports/SkImageDecoder_CG.cpp:43: failed assertion "data"
Signal 11:
_sigtramp (+0x1a)
SkStreamToCGImageSource(SkStream*) (+0x62)
SkImageDecoder_CG::onDecode(SkStream*, SkBitmap*, SkImageDecoder::Mode) (+0x2e)
SkImageDecoder::decode(SkStream*, SkBitmap*, SkColorType, SkImageDecoder::Mode) (+0x81)
SkImageDecoder::DecodeStream(SkStreamRewindable*, SkBitmap*, SkColorType, SkImageDecoder::Mode, SkImageDecoder::Format*) (+0xff)
SkImageDecoder::DecodeStream(SkStreamRewindable*, SkBitmap*) (+0x31)
test_ShortFrontBufferedStream(skiatest::Reporter*) (+0x97)
skiatest::ShortFrontBufferedStreamClass::onRun(skiatest::Reporter*) (+0x19)
skiatest::Test::run() (+0x7c)
DM::CpuTestTask::draw() (+0x5a)
DM::CpuTask::run() (+0x9e)
non-virtual thunk to DM::CpuTask::run() (+0x1c)
(anonymous namespace)::ThreadPool::Loop(void*) (+0xf4)
thread_start(void*) (+0x54)
_pthread_start (+0x14b)
Original issue's description:
> Add test for new FrontBufferedStream behavior.
>
> Test for https://skia.googlesource.com/skia/+/
dd5a1e094c19fa10202c37c50a1f799e5af5dac0
>
> Verify that FrontBufferedStream does not attempt to read beyond the
> end of its underlying stream.
>
> Committed: https://skia.googlesource.com/skia/+/
da59f05c6738dbb9a92cad21c608cdfae53a76b2
TBR=reed@google.com,scroggo@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
649553003
jvanverth [Thu, 23 Oct 2014 18:57:12 +0000 (11:57 -0700)]
Allocate only the vertices we need for text.
This restructures the vertex allocation for text rendering to compute
the max number of vertices we would need for a line of text, and then
only allocate that much. If this number exceeds the quad index limit,
then it will allocate for the max number of quads, and reallocate for
the rest later.
Review URL: https://codereview.chromium.org/
663423003
joshualitt [Thu, 23 Oct 2014 18:34:07 +0000 (11:34 -0700)]
updating k1 expectations
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
642543003
piotaixr [Thu, 23 Oct 2014 17:59:07 +0000 (10:59 -0700)]
Removed simple tests steps from CanvasTest.
CanvasTest only checks if the state of the different canvas
implementations are consistent with the one of the default
implementation.
Because most of the draw calls are stateless and already tested in GMs
the test steps that exercices them are not useful.
BUG=skia:3054
Review URL: https://codereview.chromium.org/
672273002
djsollen [Thu, 23 Oct 2014 17:23:07 +0000 (10:23 -0700)]
Remove android specific genID from SkPaint.
Review URL: https://codereview.chromium.org/
677453002
scroggo [Thu, 23 Oct 2014 17:21:28 +0000 (10:21 -0700)]
Add test for new FrontBufferedStream behavior.
Test for https://skia.googlesource.com/skia/+/
dd5a1e094c19fa10202c37c50a1f799e5af5dac0
Verify that FrontBufferedStream does not attempt to read beyond the
end of its underlying stream.
Review URL: https://codereview.chromium.org/
641813009
mtklein [Thu, 23 Oct 2014 17:13:21 +0000 (10:13 -0700)]
This return_false is now only used on Android. Squelch a warning.
BUG=skia:
Review URL: https://codereview.chromium.org/
659393004
borenet [Thu, 23 Oct 2014 15:08:23 +0000 (08:08 -0700)]
Rename Nexus9 expectations
BUG=skia:3047
TBR=djsollen
Review URL: https://codereview.chromium.org/
652003003
qiankun.miao [Thu, 23 Oct 2014 14:58:17 +0000 (07:58 -0700)]
Add SkMaskCache
BUG=skia:
Review URL: https://codereview.chromium.org/
670063004
bsalomon [Thu, 23 Oct 2014 14:41:29 +0000 (07:41 -0700)]
Revert of Delete unused method aliases and texture flag. (patchset #1 id:1 of https://codereview.chromium.org/
672753002/)
Reason for revert:
Need to remove one more reference to this in blink before relanding.
Original issue's description:
> Delete unused method aliases and texture flag.
>
> Committed: https://skia.googlesource.com/skia/+/
7fdffe41494cbd78a8ee2a6ef0509e46ec77039f
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/
671203002
bungeman [Thu, 23 Oct 2014 14:08:05 +0000 (07:08 -0700)]
Update fontMgr to take list of bcp47 language tags.
This will enable clients to pass more than one bcp47 tag to ensure
that the most appropriate font is selected.
BUG=chromium:422180
Review URL: https://codereview.chromium.org/
670243002
bsalomon [Thu, 23 Oct 2014 13:56:55 +0000 (06:56 -0700)]
Delete unused method aliases and texture flag.
Review URL: https://codereview.chromium.org/
672753002
joshualitt [Thu, 23 Oct 2014 03:53:24 +0000 (20:53 -0700)]
fix memory leak
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
668333005
joshualitt [Thu, 23 Oct 2014 03:23:07 +0000 (20:23 -0700)]
some more expectations, update ignores
TBR=
BUG=skia:
Review URL: https://codereview.chromium.org/
668393002