commit-bot@chromium.org [Thu, 8 May 2014 18:13:23 +0000 (18:13 +0000)]
store map ptr in GrGeometryBuffer base class
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
272503009
git-svn-id: http://skia.googlecode.com/svn/trunk@14652
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 18:13:15 +0000 (18:13 +0000)]
Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.
Chrome/Blink doesn't use any of the legacy methods behind this flag any more.
BUG=skia:2187
R=reed@google.com
Author: dominikg@chromium.org
Review URL: https://codereview.chromium.org/
265973002
git-svn-id: http://skia.googlecode.com/svn/trunk@14651
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 18:13:07 +0000 (18:13 +0000)]
Fix rendering artifacts in pull-saveLayers-forward mode
This CL fixes 2 bugs in the pre-rendering of saveLayers:
1) The drawBitmapRect call wasn't occurring in device space so could sometimes be double transformed
2) The BBH op skipping in SkPicturePlayback could sometimes mess up the SkPictureStateTree's state
It also reduces the number of layers that are pre-rendered when a BBH is not in use.
R=bsalomon@google.com, reed@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
267293007
git-svn-id: http://skia.googlecode.com/svn/trunk@14650
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 16:23:56 +0000 (16:23 +0000)]
Revert of extract some common code from PictureRenderer (https://codereview.chromium.org/
273703006/)
Reason for revert:
breaking the android debug builds. It seems to be the result of android using shared libs and not lumping everything into one big static lib or executable. So we have more than one copy of SkString which is the root of the issue.
Original issue's description:
> extract some common code from PictureRenderer
>
> Committed: http://code.google.com/p/skia/source/detail?r=14638
R=borenet@google.com, epoger@google.com
TBR=borenet@google.com, epoger@google.com
NOTREECHECKS=true
NOTRY=true
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
274463004
git-svn-id: http://skia.googlecode.com/svn/trunk@14649
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:40:06 +0000 (15:40 +0000)]
rebaseline_server: add link to other result sets from main UI
BUG=skia:2529
NOTREECHECKS=True
NOTRY=True
(SkipBuildbotRuns)
R=caryclark@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
267363010
git-svn-id: http://skia.googlecode.com/svn/trunk@14648
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:29:57 +0000 (15:29 +0000)]
Fix Moz2D build
BUG=skia:2221
R=george@mozilla.com, reed@google.com
Author: borenet@google.com
Review URL: https://codereview.chromium.org/
277593003
git-svn-id: http://skia.googlecode.com/svn/trunk@14647
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:27:52 +0000 (15:27 +0000)]
Revert of Improved x86 SSE build and run-time checks. (https://codereview.chromium.org/
272503006/)
Reason for revert:
Windows builders breaking. :(
Original issue's description:
> Improved x86 SSE build and run-time checks.
>
> Replaces the current build/run-time checks for SSE level in
> opts_check_x86.cpp with a simpler and more future-proof version.
> Also adds SSE versions 4.1 and 4.2 to the config file.
>
> Author: henrik.smiding@intel.com
>
> Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
>
> Committed: http://code.google.com/p/skia/source/detail?r=14644
R=reed@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com, henrik.smiding@intel.com
TBR=djsollen@google.com, henrik.smiding@intel.com, joakim.landberg@intel.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
277593004
git-svn-id: http://skia.googlecode.com/svn/trunk@14646
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:27:02 +0000 (15:27 +0000)]
Greenify bench bot Perf-Android-Nexus7-Tegra3-Arm7-Release at build 2816
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
275593002
git-svn-id: http://skia.googlecode.com/svn/trunk@14645
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:17:50 +0000 (15:17 +0000)]
Improved x86 SSE build and run-time checks.
Replaces the current build/run-time checks for SSE level in
opts_check_x86.cpp with a simpler and more future-proof version.
Also adds SSE versions 4.1 and 4.2 to the config file.
Author: henrik.smiding@intel.com
Signed-off-by: Henrik Smiding <henrik.smiding@intel.com>
R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com, joakim.landberg@intel.com
Author: henrik.smiding@intel.com
Review URL: https://codereview.chromium.org/
272503006
git-svn-id: http://skia.googlecode.com/svn/trunk@14644
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:14:57 +0000 (15:14 +0000)]
Greenify bench bot Perf-Android-Nexus4-Adreno320-Arm7-Release at build 1643
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
279533002
git-svn-id: http://skia.googlecode.com/svn/trunk@14643
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Thu, 8 May 2014 15:13:52 +0000 (15:13 +0000)]
Fix some references to Makefiles in gyp_skia.
BUG=None
TEST=None, no functional changes. Just updating documentation.
R=epoger@google.com
Review URL: https://codereview.chromium.org/
263083006
git-svn-id: http://skia.googlecode.com/svn/trunk@14642
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:12:43 +0000 (15:12 +0000)]
Remove global SkRandoms from ChartBench.
TSAN picked them up while running DM.
BUG=skia:1792
R=bsalomon@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
278523005
git-svn-id: http://skia.googlecode.com/svn/trunk@14641
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 15:00:24 +0000 (15:00 +0000)]
Greenify bench bot Perf-Android-Nexus7-Tegra3-Arm7-Release at build 2818
R=bsalomon@google.com, bensong@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
273593009
git-svn-id: http://skia.googlecode.com/svn/trunk@14640
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 14:57:58 +0000 (14:57 +0000)]
Greenify bench bot Perf-Android-Nexus4-Adreno320-Arm7-Release at build 1644
R=bsalomon@google.com, bensong@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
277563005
git-svn-id: http://skia.googlecode.com/svn/trunk@14639
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 14:48:44 +0000 (14:48 +0000)]
extract some common code from PictureRenderer
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
273703006
git-svn-id: http://skia.googlecode.com/svn/trunk@14638
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 04:57:58 +0000 (04:57 +0000)]
Greenify bench bot Perf-Win7-ShuttleA-HD2000-x86-Release at build 2207
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
276593004
git-svn-id: http://skia.googlecode.com/svn/trunk@14637
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Thu, 8 May 2014 03:05:29 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14636
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Thu, 8 May 2014 02:25:44 +0000 (02:25 +0000)]
bench rebase after 37f6e62
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
270593005
git-svn-id: http://skia.googlecode.com/svn/trunk@14635
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 22:59:38 +0000 (22:59 +0000)]
Move paints to the front of draw structs.
The order of arguments in these structs is arbitrary, so we might as well arrange them to optimize something. Putting the paints at the front means the logic to find the paint is a lot more concise: it's usually just ptr+0, or *(ptr+0) when the SkPaint is optional.
This considerably reduces the size of the jump table in IsDraw::operator().
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
272673002
git-svn-id: http://skia.googlecode.com/svn/trunk@14634
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 22:26:37 +0000 (22:26 +0000)]
add localmatrix-shader
BUG=skia:
R=scroggo@google.com, dominikg@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
272593002
git-svn-id: http://skia.googlecode.com/svn/trunk@14633
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Wed, 7 May 2014 21:31:09 +0000 (21:31 +0000)]
First pass at pre-rendering saveLayers for GPU
https://codereview.chromium.org/
261663003/
git-svn-id: http://skia.googlecode.com/svn/trunk@14632
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 21:16:09 +0000 (21:16 +0000)]
Convert all SkRecordPattern matchers into SkRecord mutators.
- Allow any return type from SkRecord mutators and visitors;
- update existing calls to mutate and visit;
- convert match to operator() in SkRecordPattern;
- tidy up a few inelegant bits of old code in tests.
The net result is that the generated code is much clearer. All the mutate() calls
inline as you'd hope, and you can now actually follow along with the disassembly.
BUG=skia:2378
R=fmalita@chromium.org, bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
273643007
git-svn-id: http://skia.googlecode.com/svn/trunk@14631
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 7 May 2014 20:56:08 +0000 (20:56 +0000)]
Some small cleanups for image filter code.
Use the 2-param flavour of mapVector instead of the 3-param, where possible.
Add an SkMatrixImageFilter test case to the tiling unit test.
R=junov@chromium.org
Review URL: https://codereview.chromium.org/
277543002
git-svn-id: http://skia.googlecode.com/svn/trunk@14630
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Wed, 7 May 2014 20:54:58 +0000 (20:54 +0000)]
remove SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE
git-svn-id: http://skia.googlecode.com/svn/trunk@14629
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 20:51:05 +0000 (20:51 +0000)]
Rename from "(un)lock" to "(un)map" for geometry buffers.
This better reflects OpenGL terminology and is less overloaded ("lock" is used w.r.t. the resource cache).
R=robertphillips@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
275493004
git-svn-id: http://skia.googlecode.com/svn/trunk@14628
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Wed, 7 May 2014 20:00:04 +0000 (20:00 +0000)]
Fix for SkDisplacementMap::onFilterBounds().
Two problems: we were not applying the CTM to the scale parameter when
modifying clip bounds, and the recursion for onFilterBounds() must be done
in the reverse order.
BUG=370914
R=junov@chromium.org
Review URL: https://codereview.chromium.org/
272643003
git-svn-id: http://skia.googlecode.com/svn/trunk@14627
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 19:56:27 +0000 (19:56 +0000)]
Statically initialize those zero-size singletons.
This way GCC/Clang don't generate the magic static code to call the
pointless T::T() once in a threadsafe way. = {} is plenty initialized.
BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14623
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
270353003
git-svn-id: http://skia.googlecode.com/svn/trunk@14626
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 19:33:41 +0000 (19:33 +0000)]
Revert of Statically initialize those zero-size singletons. (https://codereview.chromium.org/
270353003/)
Reason for revert:
breaks windows bots
Original issue's description:
> Statically initialize those zero-size singletons.
>
> This way GCC/Clang don't generate the magic static code to call the
> pointless T::T() once in a threadsafe way. = {} is plenty initialized.
>
> BUG=skia:2378
>
> Committed: http://code.google.com/p/skia/source/detail?r=14623
R=bungeman@google.com, mtklein@chromium.org
TBR=bungeman@google.com, mtklein@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2378
Author: mtklein@google.com
Review URL: https://codereview.chromium.org/
270363005
git-svn-id: http://skia.googlecode.com/svn/trunk@14625
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 19:29:03 +0000 (19:29 +0000)]
make compare_rendered_pictures_test.py run end-to-end test
1. generate test SKPs using skpmaker
2. render those SKPs using render_pictures
3. compare results using compare_rendered_pictures.py
BUG=skia:1942,skia:2230
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
274623002
git-svn-id: http://skia.googlecode.com/svn/trunk@14624
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 19:15:01 +0000 (19:15 +0000)]
Statically initialize those zero-size singletons.
This way GCC/Clang don't generate the magic static code to call the
pointless T::T() once in a threadsafe way. = {} is plenty initialized.
BUG=skia:2378
R=bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
270353003
git-svn-id: http://skia.googlecode.com/svn/trunk@14623
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 18:01:57 +0000 (18:01 +0000)]
Partially restore small-T optimization for very small (empty) T.
This is particularly helpful for SkRecord::replace<NoOp>, which now doesn't go
off and allocate a pointless byte.
BUG=skia:2378
R=fmalita@chromium.org, bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
269543025
git-svn-id: http://skia.googlecode.com/svn/trunk@14622
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 17:50:03 +0000 (17:50 +0000)]
New GM for testing circle blur optimization
BUG=skia:
R=bsalomon@google.com, mtklein@google.com
Author: humper@google.com
Review URL: https://codereview.chromium.org/
276453002
git-svn-id: http://skia.googlecode.com/svn/trunk@14621
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 17:35:05 +0000 (17:35 +0000)]
Fix Dash Effect readback calc for fPhase from old skps
BUG=skia:
R=reed@google.com, bsalomon@google.com
Author: egdaniel@google.com
Review URL: https://codereview.chromium.org/
270223003
git-svn-id: http://skia.googlecode.com/svn/trunk@14620
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Wed, 7 May 2014 17:22:36 +0000 (17:22 +0000)]
Disable broken GMs on Nexus 4.
BUG=skia:2528
R=humper@google.com
Review URL: https://codereview.chromium.org/
272633002
git-svn-id: http://skia.googlecode.com/svn/trunk@14619
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 17:17:48 +0000 (17:17 +0000)]
save-draw*-restore -> noop-draw*-noop
save-drawA-drawB-drawC-restore always means drawA-drawB-drawC,
no matter what flags we use for save().
This one triggers all over the silk SKPs and in several of the bot SKPs, typically as save-drawBitmap-restore.
BUG=skia:2378
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
267793006
git-svn-id: http://skia.googlecode.com/svn/trunk@14618
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 17:12:55 +0000 (17:12 +0000)]
GameBench: curCell doesn't need to be extra state.
We're using a static curCell to loop around the atlas. We can just use i.
Noticed this when TSAN complained about it. Parallel invocations of the
game bench were stomping on each other's curCell.
BUG=skia:1792
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
270273006
git-svn-id: http://skia.googlecode.com/svn/trunk@14617
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 16:17:26 +0000 (16:17 +0000)]
if SK_DEBUG -> ifdef SK_DEBUG
Should unbreak Chrome canary bots.
BUG=skia:
R=mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
272623002
git-svn-id: http://skia.googlecode.com/svn/trunk@14616
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 15:46:56 +0000 (15:46 +0000)]
Fix warning
BUG=skia:2526
R=caryclark@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
270253006
git-svn-id: http://skia.googlecode.com/svn/trunk@14615
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 15:31:40 +0000 (15:31 +0000)]
When solving the cubic line intersection directly fails, use binary search as a fallback.
The cubic line intersection math empirically works 99.99% of the time (fails 3100 out of 1B random tests) but when it fails, an intersection may be missed altogether.
The binary search is may not find a solution if the cubic line failed to find any solutions at all, but so far that case hasn't arisen.
BUG=skia:2504
TBR=reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
266063003
git-svn-id: http://skia.googlecode.com/svn/trunk@14614
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 15:27:10 +0000 (15:27 +0000)]
4x allocation in PipeController is probably overkill.
When verylargebitmap GM runs in cross-process pipe mode, we're
requestBlock()ing ~200M to carry the bitmaps. The current
implementation ends up allocating ~800M, which is a bit wasteful.
SkGPipeWrite already rounds up to 16K, so just rely on that.
This change exposed several bugs in pipe:
- we don't reserve enough space in drawVertices
- we don't reserve enough space for factory names in cross-process mode
- we don't quite have the right check in needOpBytes to see if we needed to send off the current block and allocate a new one
SETUP_NOTIFY and generally calling doNotify() more often than necessary made things hard to debug and understand. Now the pipe always waits to send off its current block until it needs more space than that block can provide, or it's the final block. We can put these back if we need the proactive flushing, but it seems not necessary?
Removed an assert in DeferredCanvasTest, which is somtimes 2 (Debug), sometimes 3 (Release). It seemed like the other asserts were more essential, and this one was more of a white-box assertion. Still sound if we remove it?
BUG=skia:2478
R=scroggo@google.com, mtklein@google.com, reed@google.com, junov@chromium.org
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
267863002
git-svn-id: http://skia.googlecode.com/svn/trunk@14613
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 15:08:48 +0000 (15:08 +0000)]
Disallow Android from calling getTotalClip.
Remove the define that lets the function live on.
R=reed@google.com
Author: scroggo@google.com
Review URL: https://codereview.chromium.org/
268333002
git-svn-id: http://skia.googlecode.com/svn/trunk@14612
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 15:05:34 +0000 (15:05 +0000)]
remove dead mipmap code from SkBitmap
BUG=skia:
R=fmalita@google.com, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
271693002
git-svn-id: http://skia.googlecode.com/svn/trunk@14611
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 14:47:44 +0000 (14:47 +0000)]
Add SaveLayer-Draw-Restore optimization.
This is like SkPictureRecord's remove_save_layer1 but works with all draw calls.
Interesting patterns removed:
SaveLayer-DrawRect-Restore: Silk SKPs, desk_weather
SaveLayer-DrawPath-Restore: desk_carsvg, desk_wowwiki, tabl_androidpolice
SaveLayer-DrawPosTextH-Restore: tabl_android_police
There may be others, but I stopped looking.
BUG=skia:2378
R=robertphillips@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
269813010
git-svn-id: http://skia.googlecode.com/svn/trunk@14610
2bbb7eff-a529-9590-31e7-
b0007b416f81
tfarina@chromium.org [Wed, 7 May 2014 14:46:35 +0000 (14:46 +0000)]
Remove the old Makefile.
Building through this hand-made Makefile is not really supported
anymore and this file is also not maintained by the core team.
BUG=None
TEST=None
R=epoger@google.com
Review URL: https://codereview.chromium.org/
267353002
git-svn-id: http://skia.googlecode.com/svn/trunk@14609
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 14:33:57 +0000 (14:33 +0000)]
Split CPU and GPU DeferredCanvas tests
Nothing important, just happened to notice this and figured it was good hygiene.
DEF_TESTs run in parallel, while DEF_GPUTESTs run all run serially.
BUG=skia:
Committed: http://code.google.com/p/skia/source/detail?r=14603
R=junov@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
271483002
git-svn-id: http://skia.googlecode.com/svn/trunk@14608
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 12:33:02 +0000 (12:33 +0000)]
Revert of Split CPU and GPU DeferredCanvas tests (https://codereview.chromium.org/
271483002/)
Reason for revert:
breaking the run tests steps on ChromeOS. See http://108.170.220.120:10117/builders/Test-ChromeOS-Alex-GMA3150-x86-Debug/builds/1669
Original issue's description:
> Split CPU and GPU DeferredCanvas tests
>
> Nothing important, just happened to notice this and figured it was good hygiene.
> DEF_TESTs run in parallel, while DEF_GPUTESTs run all run serially.
>
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=14603
R=junov@chromium.org, mtklein@google.com, mtklein@chromium.org
TBR=junov@chromium.org, mtklein@chromium.org, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:
Author: djsollen@google.com
Review URL: https://codereview.chromium.org/
270283003
git-svn-id: http://skia.googlecode.com/svn/trunk@14607
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Wed, 7 May 2014 03:57:56 +0000 (03:57 +0000)]
Revert "remove unneeded SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE"
This reverts commit
95b03ce59986ecee5e4188da630a563efca3afe8.
NOTRY=True
TBR=fmalita@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
274513002
git-svn-id: http://skia.googlecode.com/svn/trunk@14606
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Wed, 7 May 2014 03:04:15 +0000 (03:04 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14605
2bbb7eff-a529-9590-31e7-
b0007b416f81
senorblanco@chromium.org [Tue, 6 May 2014 22:52:55 +0000 (22:52 +0000)]
Fix for empty saveLayer() with a filter which affects transparent black.
If an saveLayer()/restore() is recorded, tilegrid/rtree will cull them
out and not draw anything. This is correct for most cases, but if the
paint in the saveLayer() is one that affects transparent black (e.g.,
it contains a color filter or image filter which affects transparent
black), this is incorrect: the filter should be applied.
Fixed by adding a no-op between the saveLayer() and restore(), and
adding a bbox node pointing at that node with the saveLayer()'s bounds.
This exposed a bug in SkPictureRecord.cpp's match(), where it would
assert if the NOOP was the last op seen. Fixed with an early-out before
calling peek_op_and_size().
BUG=skia:2254
Review URL: https://codereview.chromium.org/
262363007
git-svn-id: http://skia.googlecode.com/svn/trunk@14604
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 21:43:37 +0000 (21:43 +0000)]
Split CPU and GPU DeferredCanvas tests
Nothing important, just happened to notice this and figured it was good hygiene.
DEF_TESTs run in parallel, while DEF_GPUTESTs run all run serially.
BUG=skia:
R=junov@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
271483002
git-svn-id: http://skia.googlecode.com/svn/trunk@14603
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 21:32:19 +0000 (21:32 +0000)]
SaveLayer is not a draw.
Will keep thinking about the best way to handle this:
- leave as-is
- tag the records
- some range check on T::kType
- just list all Draw* in IsDraw
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
269543023
git-svn-id: http://skia.googlecode.com/svn/trunk@14602
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Tue, 6 May 2014 21:00:01 +0000 (21:00 +0000)]
remove unneeded SK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE
git-svn-id: http://skia.googlecode.com/svn/trunk@14601
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 20:38:24 +0000 (20:38 +0000)]
Add dump_record to make inspecting before/after SkRecordOptimize easy.
E.g.
dump_record -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 Save
6 ClipRect
7 Restore
8 Save
9 ClipRect
10 Restore
11 Restore
dump_record -O -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 NoOp
6 NoOp
7 NoOp
8 NoOp
9 NoOp
10 NoOp
11 Restore
(Reitveld sadly eats my kickass indentation.)
BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14596
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
265983007
git-svn-id: http://skia.googlecode.com/svn/trunk@14600
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 19:48:02 +0000 (19:48 +0000)]
DM: test SkRecord with and without optimization.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
271443007
git-svn-id: http://skia.googlecode.com/svn/trunk@14598
2bbb7eff-a529-9590-31e7-
b0007b416f81
djsollen@google.com [Tue, 6 May 2014 19:47:07 +0000 (19:47 +0000)]
Temporarily disable NEON on Android framework builds.
The GCC 4.8 compiler has an AARCH64 bug that generated non-PIC output
that fails to link.
R=scroggo@google.com
Review URL: https://codereview.chromium.org/
266883011
git-svn-id: http://skia.googlecode.com/svn/trunk@14597
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 19:45:18 +0000 (19:45 +0000)]
Add dump_record to make inspecting before/after SkRecordOptimize easy.
E.g.
dump_record -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 Save
6 ClipRect
7 Restore
8 Save
9 ClipRect
10 Restore
11 Restore
dump_record -O -r http___groupcloned_com_test_plain_list_animation_simple_html_layer_109.skp
0 Save
1 DrawRect
2 DrawRect
3 DrawRect
4 DrawRect
5 NoOp
6 NoOp
7 NoOp
8 NoOp
9 NoOp
10 NoOp
11 Restore
(Reitveld sadly eats my kickass indentation.)
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
265983007
git-svn-id: http://skia.googlecode.com/svn/trunk@14596
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 18:31:09 +0000 (18:31 +0000)]
Run Android make script from any directory
R=djsollen@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
260743003
git-svn-id: http://skia.googlecode.com/svn/trunk@14594
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 18:29:28 +0000 (18:29 +0000)]
Fix android_install_apk script to work with changes from a137675
(http://crrev.com/
223613004). See http://crrev.com/
256413006 or
http://crrev.com/
262053007 for similar changes.
R=djsollen@google.com, mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
266373005
git-svn-id: http://skia.googlecode.com/svn/trunk@14593
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 17:16:03 +0000 (17:16 +0000)]
add local-matrix to shader::context
BUG=skia:
R=scroggo@google.com, dominikg@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
263293005
git-svn-id: http://skia.googlecode.com/svn/trunk@14592
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 15:31:31 +0000 (15:31 +0000)]
make compare_rendered_pictures process render_pictures's new JSON output format
BUG=skia:1942,skia:2230
NOTRY=True
R=borenet@google.com
Author: epoger@google.com
Review URL: https://codereview.chromium.org/
265793013
git-svn-id: http://skia.googlecode.com/svn/trunk@14591
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 15:20:53 +0000 (15:20 +0000)]
Whitespace change to test skia CQ.
BUG=none
R=borenet@chromium.org, borenet@google.com
Author: phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/
263923005
git-svn-id: http://skia.googlecode.com/svn/trunk@14590
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 13:43:22 +0000 (13:43 +0000)]
Fix memory leak in GPU Picture optimization
R=jvanverth@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
265763008
git-svn-id: http://skia.googlecode.com/svn/trunk@14589
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 13:43:17 +0000 (13:43 +0000)]
don't leak the bitmapShader
BUG=skia:
R=fmalita@google.com, robertphillips@google.com, fmalita@chromium.org
Author: reed@google.com
Review URL: https://codereview.chromium.org/
269163004
git-svn-id: http://skia.googlecode.com/svn/trunk@14588
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 13:04:35 +0000 (13:04 +0000)]
Square pixels on zoom.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
270073004
git-svn-id: http://skia.googlecode.com/svn/trunk@14587
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 12:02:22 +0000 (12:02 +0000)]
Infrastructure changes to support pull-saveLayers-forward task
This is split out of (First pass at pre-rendering saveLayers for GPU - https://codereview.chromium.org/
261663003/).
It mainly:
Moves NeedsDeepCopy to somewhere more accessible (so GrPictureUtils.cpp can use it)
Moves ComputeAccelDataKey somewhere more accessible (so GPUPicture test can use it)
Adds unit test for picture saveLayer analysis (done in EXPERIMENTAL_optimize)
Adds new fields to SaveLayerInfo that are needed to pull forward layers
Committed: http://code.google.com/p/skia/source/detail?r=14571
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
266203003
git-svn-id: http://skia.googlecode.com/svn/trunk@14586
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Tue, 6 May 2014 04:49:13 +0000 (04:49 +0000)]
Relaxes bench range upper bound by a bit.
BUG=skia:
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
263373002
git-svn-id: http://skia.googlecode.com/svn/trunk@14585
2bbb7eff-a529-9590-31e7-
b0007b416f81
skia.committer@gmail.com [Tue, 6 May 2014 03:06:53 +0000 (03:06 +0000)]
Sanitizing source files in Housekeeper-Nightly
git-svn-id: http://skia.googlecode.com/svn/trunk@14584
2bbb7eff-a529-9590-31e7-
b0007b416f81
bungeman@google.com [Mon, 5 May 2014 22:33:45 +0000 (22:33 +0000)]
Initialize the SkFontConfigInterface singleton with SkOnce.
BUG=chromium:369257
R=mtklein@google.com
Review URL: https://codereview.chromium.org/
269143002
git-svn-id: http://skia.googlecode.com/svn/trunk@14583
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 21:59:52 +0000 (21:59 +0000)]
Add pattern matchers for SkRecord
This is a mid-level library for finding patterns of commands in an SkRecord. At the API level, it's a bit regex inspired. Some examples:
- Pattern1<Is<DrawRect>> matches a single DrawRect
- Pattern1<Star<Is<DrawRect>>> matches 0 or more DrawRects
- Pattern2<Is<ClipRect>, Is<DrawRect>> matches a single clip rect followed by a single draw rect
- Pattern3<Is<Save>, Star<IsDraw>, Is<Restore>> matches a single Save, followed by any number of Draws, followed by Restore
- Pattern1<Or<Is<DrawRect>, Is<ClipRect>>> matches a DrawRect or a ClipRect
- Pattern1<Not<Is<ClipRect>>> matches a command that's notClipRect.
Once you have a pattern, you can call .search() on it to step through ranges of matching commands. This means patterns can replace most of the custom iteration logic for optimization passes: the generic pattern searching steps through all the optimization candidates, which optimization-specific code further inspects and mutates.
SkRecordTraits is now unused. Bye bye!
Generated code and performance of SkRecordOpts is very similar to what it was before. (I had to use SK_ALWAYS_INLINE in a few places to make this so.)
BUG=skia:2378
R=fmalita@chromium.org, bungeman@google.com, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
263063002
git-svn-id: http://skia.googlecode.com/svn/trunk@14582
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 21:35:09 +0000 (21:35 +0000)]
fix TriColorShader to respect the paint's alpha
results can be seen in new gm: vertices_80
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
270023002
git-svn-id: http://skia.googlecode.com/svn/trunk@14581
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 5 May 2014 20:41:21 +0000 (20:41 +0000)]
new vertices gm to test alpha
git-svn-id: http://skia.googlecode.com/svn/trunk@14580
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 5 May 2014 19:37:22 +0000 (19:37 +0000)]
suppress new composeshader gm for quilt testing
git-svn-id: http://skia.googlecode.com/svn/trunk@14579
2bbb7eff-a529-9590-31e7-
b0007b416f81
robertphillips@google.com [Mon, 5 May 2014 19:24:23 +0000 (19:24 +0000)]
Revert r14571 (Infrastructure changes to support pull saveLayers forward task - https://codereview.chromium.org/
266203003) due to breaking Android unit tests
git-svn-id: http://skia.googlecode.com/svn/trunk@14578
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 19:21:16 +0000 (19:21 +0000)]
Allow custom resources in the GrContext's cache
Adds methods to GrContext for client code to store custom resources in
the cache.
BUG=skia:
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
261593009
git-svn-id: http://skia.googlecode.com/svn/trunk@14577
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 19:09:13 +0000 (19:09 +0000)]
Adds a mechanism for GrCacheable objects to notify the resource cache
when their size has changed. GrResourceCacheEntry now holds a
reference to the cache, and a cached value of the resource's most
recent size.
Also utilizes this new functionality for mipmaps, and adds a test for
changing resource sizes.
R=bsalomon@google.com, robertphillips@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
257093002
git-svn-id: http://skia.googlecode.com/svn/trunk@14576
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 18:43:16 +0000 (18:43 +0000)]
Fix an issue with FireFox where it blurs when copying from a smaller to a
larger canvas. Work around that by drawing a rect for each pixel.
Also, add a drop shadow to the hex display so you can see it on a dark background color.
BUG=skia:
R=mtklein@google.com
Author: jcgregorio@google.com
Review URL: https://codereview.chromium.org/
261303002
git-svn-id: http://skia.googlecode.com/svn/trunk@14575
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 18:40:15 +0000 (18:40 +0000)]
Fix android_perf script to work with changes from a137675
(http://crrev.com/
223613004). See http://crrev.com/
256413006
for a similar change.
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
262053007
git-svn-id: http://skia.googlecode.com/svn/trunk@14574
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 18:39:18 +0000 (18:39 +0000)]
Remove SkShader virtual method validContext
patch from issue
267923005
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
261773005
git-svn-id: http://skia.googlecode.com/svn/trunk@14573
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 18:23:54 +0000 (18:23 +0000)]
change composeshader_alpha to exercise srcover as well
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
263083011
git-svn-id: http://skia.googlecode.com/svn/trunk@14572
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 18:06:14 +0000 (18:06 +0000)]
Infrastructure changes to support pull-saveLayers-forward task
This is split out of (First pass at pre-rendering saveLayers for GPU - https://codereview.chromium.org/
261663003/).
It mainly:
Moves NeedsDeepCopy to somewhere more accessible (so GrPictureUtils.cpp can use it)
Moves ComputeAccelDataKey somewhere more accessible (so GPUPicture test can use it)
Adds unit test for picture saveLayer analysis (done in EXPERIMENTAL_optimize)
Adds new fields to SaveLayerInfo that are needed to pull forward layers
R=bsalomon@google.com
Author: robertphillips@google.com
Review URL: https://codereview.chromium.org/
266203003
git-svn-id: http://skia.googlecode.com/svn/trunk@14571
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 17:09:05 +0000 (17:09 +0000)]
Update tests/RecordOptsTest.cpp
- use REPORTER_ASSERT;
- assert the type first, then the pointer != NULL. This helps explain why ptr == NULL;
- add a simpler NoopSaveRestore test case, which can help debugging failures of the larger test case.
BUG=skia:2378
R=fmalita@chromium.org, mtklein@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
264043012
git-svn-id: http://skia.googlecode.com/svn/trunk@14570
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 16:45:01 +0000 (16:45 +0000)]
fix composeshader to respect the paint's alpha
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
265163008
git-svn-id: http://skia.googlecode.com/svn/trunk@14569
2bbb7eff-a529-9590-31e7-
b0007b416f81
reed@google.com [Mon, 5 May 2014 16:32:16 +0000 (16:32 +0000)]
fix double->float warning
git-svn-id: http://skia.googlecode.com/svn/trunk@14568
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 16:19:08 +0000 (16:19 +0000)]
new gm for composeshader, exercising alpha
BUG=skia:
R=scroggo@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
262193004
git-svn-id: http://skia.googlecode.com/svn/trunk@14567
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 16:04:42 +0000 (16:04 +0000)]
add rounding-using-doubles methods on SkScalar and SkRect
Inspired by the excellent repro case for https://crbug.com/364224
patch from issue
265933010
BUG=skia:
R=bungeman@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
267003002
git-svn-id: http://skia.googlecode.com/svn/trunk@14566
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 13:30:06 +0000 (13:30 +0000)]
Spelling fix, comments explaining script.
R=mtklein@google.com
Author: halcanary@google.com
Review URL: https://codereview.chromium.org/
261913006
git-svn-id: http://skia.googlecode.com/svn/trunk@14565
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 12:32:37 +0000 (12:32 +0000)]
Add support for glMapBufferRange. Use glMapBufferRange and glMapBufferSubData.
BUG=skia:2402
Committed: http://code.google.com/p/skia/source/detail?r=14533
R=robertphillips@google.com, djsollen@google.com
Author: bsalomon@google.com
Review URL: https://codereview.chromium.org/
243413002
git-svn-id: http://skia.googlecode.com/svn/trunk@14564
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Mon, 5 May 2014 09:51:09 +0000 (09:51 +0000)]
Greenify bench bot Perf-Android-Nexus7-Tegra3-Arm7-Release at build 2774
R=bsalomon@google.com
TBR=bsalomon@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
269813005
git-svn-id: http://skia.googlecode.com/svn/trunk@14563
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 4 May 2014 18:08:27 +0000 (18:08 +0000)]
Revert of fix the error that path is inversed for stroke and strokeAndFill styles (https://codereview.chromium.org/
183683010/)
R=bsalomon@google.com, reed@google.com, yunchao.he@intel.com
TBR=reed@google.com
NOTRY=True
Reason for revert:
broke unittests
Original issue's description:
> fix the error that path is inversed for stroke and strokeAndFill styles.
>
> However, because hairline stroke + fill = fill (see src/core/SkStrokeRec.cpp), strokeAndFill will be thought as fill style when paint.getStrokeWidth() <= 0, this edge case can be inverse-filled.
>
> BUG=skia:2222
>
> Committed: http://code.google.com/p/skia/source/detail?r=14561
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
269903002
git-svn-id: http://skia.googlecode.com/svn/trunk@14562
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 4 May 2014 03:43:20 +0000 (03:43 +0000)]
fix the error that path is inversed for stroke and strokeAndFill styles.
However, because hairline stroke + fill = fill (see src/core/SkStrokeRec.cpp), strokeAndFill will be thought as fill style when paint.getStrokeWidth() <= 0, this edge case can be inverse-filled.
BUG=skia:2222
R=bsalomon@google.com, reed@google.com
Author: yunchao.he@intel.com
Review URL: https://codereview.chromium.org/
183683010
git-svn-id: http://skia.googlecode.com/svn/trunk@14561
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 4 May 2014 01:26:19 +0000 (01:26 +0000)]
fix size_t/int warnings
TBR=caryclark@google.com
Author: reed@chromium.org
Review URL: https://codereview.chromium.org/
265163003
git-svn-id: http://skia.googlecode.com/svn/trunk@14560
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sun, 4 May 2014 00:46:50 +0000 (00:46 +0000)]
eliminate mac xcode 5 only warning
on os x 10.9.2 unistd.h defines sysconf as
long sysconf(int);
R=mtklein@google.com, reed@google.com
Author: caryclark@google.com
Review URL: https://codereview.chromium.org/
261673004
git-svn-id: http://skia.googlecode.com/svn/trunk@14559
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 3 May 2014 19:46:58 +0000 (19:46 +0000)]
bench rebase after d06ee45
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
264043002
git-svn-id: http://skia.googlecode.com/svn/trunk@14558
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 3 May 2014 16:45:50 +0000 (16:45 +0000)]
bench rebase after d06ee45
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
265163002
git-svn-id: http://skia.googlecode.com/svn/trunk@14557
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 3 May 2014 13:03:48 +0000 (13:03 +0000)]
Fixes lower/upper typo.
BUG=skia:
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
266023005
git-svn-id: http://skia.googlecode.com/svn/trunk@14556
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 3 May 2014 12:58:59 +0000 (12:58 +0000)]
Use a separate error parameter for lower bound.
BUG=skia:
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
268883002
git-svn-id: http://skia.googlecode.com/svn/trunk@14555
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Sat, 3 May 2014 12:40:14 +0000 (12:40 +0000)]
further adjust bench lower bounds to cope with downside flakiness.
BUG=skia:2225
R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRY=true
Author: bensong@google.com
Review URL: https://codereview.chromium.org/
268643004
git-svn-id: http://skia.googlecode.com/svn/trunk@14554
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 21:38:22 +0000 (21:38 +0000)]
Split GrResource into GrCacheable/GrGpuObject
Before this change, an object needed to inherit from GrResource (and
thus be a GPU object) in order to live in the GrResourceCache. That
was a problem for caching items that weren't GPU objects themselves,
but owned GPU objects.
This change splits GrResource into two classes:
1. GrCacheable: The base class for objects that can live in the
GrResourceCache.
2. GrGpuObject, which inherits from GrCacheable: The base class for
objects that get tracked by GrGpu.
This change is purely a refactor; there is no change in functionality.
Change-Id: I3e8daeb1f123041f414aa306c1366e959ae9e39e
BUG=skia:
R=bsalomon@google.com
Author: cdalton@nvidia.com
Review URL: https://codereview.chromium.org/
251013002
git-svn-id: http://skia.googlecode.com/svn/trunk@14553
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 21:24:22 +0000 (21:24 +0000)]
add release-mode checks for null, at least for a while
BUG=skia:
R=bungeman@google.com
Author: reed@google.com
Review URL: https://codereview.chromium.org/
263883006
git-svn-id: http://skia.googlecode.com/svn/trunk@14552
2bbb7eff-a529-9590-31e7-
b0007b416f81
commit-bot@chromium.org [Fri, 2 May 2014 21:23:52 +0000 (21:23 +0000)]
Remove setLocalMatrix calls from picture shader GM.
This makes all --skr tests pass for me. Enabling it by default in DM.
BUG=skia:2378
Committed: http://code.google.com/p/skia/source/detail?r=14549
R=reed@google.com, mtklein@google.com, fmalita@google.com
Author: mtklein@chromium.org
Review URL: https://codereview.chromium.org/
260863007
git-svn-id: http://skia.googlecode.com/svn/trunk@14551
2bbb7eff-a529-9590-31e7-
b0007b416f81