Paul [Wed, 31 Jul 2019 17:26:36 +0000 (02:56 +0930)]
Fix to Build fails with 'error MSB3073' when run from folder containing space (dotnet/corefx#39885)
* Fix to Build fails with 'error MSB3073' when run from folder containing a space
https://github.com/dotnet/corefx/issues/39840
* Update ApiCompat.proj
Indent fix
Commit migrated from https://github.com/dotnet/corefx/commit/
d77ce06711bbf4c91eaac5690a709dc9c352e720
Stephen Toub [Wed, 31 Jul 2019 13:19:00 +0000 (09:19 -0400)]
Add TrailingHeaders to HttpResponseMessage.ToString output (dotnet/corefx#39902)
Commit migrated from https://github.com/dotnet/corefx/commit/
a7c542f257f58e7ae41d5274a02a5e823d4492c0
Stephen Toub [Wed, 31 Jul 2019 12:04:33 +0000 (08:04 -0400)]
Re-enable CA1823 (unused private fields) (dotnet/corefx#39899)
Commit migrated from https://github.com/dotnet/corefx/commit/
e5d38a54cf21f6427ae4fe99c3841c8067139e75
Cory Nelson [Tue, 30 Jul 2019 21:36:59 +0000 (14:36 -0700)]
Fix DynamicTableSizeUpdate_Exceeds_Settings_Throws (dotnet/corefx#39880)
* Update test to read different exception structure.
Resolves dotnet/corefx#39876.
Commit migrated from https://github.com/dotnet/corefx/commit/
175c4b7467f4da173c732f9aaf95882b3c426665
Tomas Weinfurt [Tue, 30 Jul 2019 20:43:57 +0000 (13:43 -0700)]
improve handling of 100continue for H2 (dotnet/corefx#39869)
* improve handling of 100continue for H2
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
556792fdc3f76af238e3955b3d5716ede558d42f
Eirik Tsarpalis [Tue, 30 Jul 2019 18:28:02 +0000 (19:28 +0100)]
HttpStress: Add duplex operation that disposes response content (dotnet/corefx#39860)
HttpStress: add duplex operation that disposes response content
Commit migrated from https://github.com/dotnet/corefx/commit/
5b6a74d8455aab11f64377f3200ace1df71110ea
Levi Broderick [Tue, 30 Jul 2019 17:40:47 +0000 (10:40 -0700)]
Defense-in-depth: Web encoders should escape BOM U+FEFF (dotnet/corefx#39815)
As a defense-in-depth mechanism, HtmlEncoder and related types should always encode the Unicode Byte Order Mark (U+FEFF), even if the caller passes a bitmap that lists this as an allowed code point. This helps provide protection for misbehaving clients which incorrectly strip the Byte Order Mark from input sequences.
Commit migrated from https://github.com/dotnet/corefx/commit/
9d6729a940952dcc14dc8683218684f4da29198a
Hugh Bellamy [Tue, 30 Jul 2019 17:18:48 +0000 (17:18 +0000)]
Consolidate Metafile unix/windows code (dotnet/corefx#39758)
* Fix tests locally
* Consolidate Metafile code
Commit migrated from https://github.com/dotnet/corefx/commit/
915a36ce8132070d79661e39f1f1e616215756b2
Stephen Toub [Tue, 30 Jul 2019 15:33:36 +0000 (11:33 -0400)]
Re-enable netfx testing for Microsoft.VisualBasic.Core (dotnet/corefx#39871)
Commit migrated from https://github.com/dotnet/corefx/commit/
da0ebf17b2c0e7e707e4555242f170e2146d98be
Stephen Toub [Tue, 30 Jul 2019 12:45:39 +0000 (08:45 -0400)]
Re-enable xunit warning 2005 (dotnet/corefx#39866) (dotnet/corefx#39864)
Commit migrated from https://github.com/dotnet/corefx/commit/
9142b477f9355ed184df326d7cd1de4963631228
Ben Adams [Tue, 30 Jul 2019 04:34:51 +0000 (05:34 +0100)]
Use ArrayPool for oversized allocations (dotnet/corefx#39643)
* Use ArrayPool for oversized allocations
Commit migrated from https://github.com/dotnet/corefx/commit/
e7134de2b56bd1c4af0b5c58fe6e2cfdb8b72e5a
Stephen Toub [Tue, 30 Jul 2019 03:03:46 +0000 (23:03 -0400)]
Update FxCopAnalyzers to 2.9.4 (dotnet/corefx#39868)
Commit migrated from https://github.com/dotnet/corefx/commit/
b2ff0db61cc9348775d73a8934ad80218ded8bc0
Stephen Toub [Tue, 30 Jul 2019 02:35:49 +0000 (22:35 -0400)]
Fix Utf8JsonWriter.Dispose{Async} after failed Stream Write{Async} (dotnet/corefx#39836)
* Fix Utf8JsonWriter.Dispose{Async} after failed Stream Write{Async}
By the time the `Utf8JsonWriter` writes to the underlying `Stream` as part of `Flush{Async}` it has already `Advance`'d the `_arrayBufferWriter`, but it hasn't reset `BytesPending` to 0. If the write to the stream throws an exception then, we end up in an inconsistent state where `BytesPending` != 0 but there's no corresponding pending bytes to `Advance` the `_arrayBufferWriter`. When we then `Dispose` the `Utf8JsonWriter`, we attempt to `Advance` the `_arrayBufferWriter` and fail. Since `Utf8JsonWriter` will often be used in a `using` block, an exception from a `Write`/`Flush{Async}` call inside the `using` will then be masked as the `using`'s call to `Dispose` ends up failing and throwing a secondary exception.
* Address PR feedback
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
c38f2327e2d4e159acba06e23f38daed24661652
Stephen Toub [Tue, 30 Jul 2019 00:56:50 +0000 (20:56 -0400)]
Re-enable xunit warning 2018 (dotnet/corefx#39865)
Commit migrated from https://github.com/dotnet/corefx/commit/
fec76b0fc06b4fce9e4ac28b9a2bf1101209d984
Stephen Toub [Tue, 30 Jul 2019 00:56:11 +0000 (20:56 -0400)]
Re-enable xunit warning 2005 (dotnet/corefx#39866)
Commit migrated from https://github.com/dotnet/corefx/commit/
7b013c44b8d38df51f3ec8db64bdcb1f83a8b421
Matt Galbraith [Tue, 30 Jul 2019 00:49:35 +0000 (17:49 -0700)]
Fix Fedora 29 Helix Docker Image
Commit migrated from https://github.com/dotnet/corefx/commit/
0081b0fb4da0c9d74f63338d29eaa660b0387699
Stephen Toub [Tue, 30 Jul 2019 00:28:49 +0000 (20:28 -0400)]
Disable DynamicTableSizeUpdate_Exceeds_Settings_Throws test (dotnet/corefx#39877)
Commit migrated from https://github.com/dotnet/corefx/commit/
eb44b1ffe5f9aeb9852beee0fc123add3fe47492
Stephen Toub [Mon, 29 Jul 2019 20:10:36 +0000 (16:10 -0400)]
Fix WriteLargeKeyOrValue System.Text.Json test (dotnet/corefx#39857)
When the Utf8JsonWriter is disposed in the first part of the test, it flushes the WriteStartObject token to the ArrayBufferWriter, such that the output.WrittenCount is already 1 when the second part of the test starts, and then the Assert.Equal(0, output.WrittenCount) is doomed to fail.
Commit migrated from https://github.com/dotnet/corefx/commit/
9e994a5923d426f0e64ed3b8f9b93df6f214a42a
Stephen Toub [Mon, 29 Jul 2019 19:11:19 +0000 (15:11 -0400)]
Re-enable xunit warning 2006 (dotnet/corefx#39848)
Commit migrated from https://github.com/dotnet/corefx/commit/
395db04daa4d76999036b3fb75ef2d431bcddfba
Cory Nelson [Mon, 29 Jul 2019 17:46:49 +0000 (10:46 -0700)]
HTTP2: Validate dynamic table size updates (dotnet/corefx#39669)
* Validate dynamic table size updates.
* Set dynamic table size to 0, to reduce a per-connection ~2048 byte allocation to a ~0 byte allocation.
Resolves dotnet/corefx#39666
Commit migrated from https://github.com/dotnet/corefx/commit/
14b604c5fe52e0022881a0866bf39f344d247fd7
Clinton Ingram [Mon, 29 Jul 2019 16:30:22 +0000 (09:30 -0700)]
fix Matrix4x4 + and - operator bugs (dotnet/corefx#39838)
* fix Matrix4x4 + and - operator bugs
* fix Add() and Subtract() tests
Commit migrated from https://github.com/dotnet/corefx/commit/
b5e931082053692c5414c830b0477766ea803206
Stephen Toub [Mon, 29 Jul 2019 15:54:37 +0000 (11:54 -0400)]
Re-enable CA2207 (value type declares a static cctor) (dotnet/corefx#39858)
Commit migrated from https://github.com/dotnet/corefx/commit/
7e93ad2cd22832060851ba0e18fcb55129564e2c
Stephen Toub [Mon, 29 Jul 2019 13:42:13 +0000 (09:42 -0400)]
Re-enable xunit warning 2009 (dotnet/corefx#39847)
Commit migrated from https://github.com/dotnet/corefx/commit/
6737565ccbb8ceb484d349bd6844f7470bf23248
Ahson Khan [Mon, 29 Jul 2019 04:17:28 +0000 (21:17 -0700)]
Use relaxed JavascriptEncoder in S.T.JSON specific tests to improve coverage. (dotnet/corefx#39560)
* Use relaxed JavascriptEncoder in S.T.JSON specific tests to improve
coverage.
* Add control characters as well as part of the test data.
* Add JsonElement.WriteTo test and make sure all Utf8JsonWriter in tests
are disposed.
* Fix spacing/formatting.
* Fix call to AssertEquals since it moved to JsonTestHelper.
Commit migrated from https://github.com/dotnet/corefx/commit/
74d26be704117139e9ef081c9e287740fde5d002
Ahson Khan [Mon, 29 Jul 2019 04:06:03 +0000 (21:06 -0700)]
Fix validation check within Utf8JsonWriter for writing a primitive value after another complete value has been written. (dotnet/corefx#39796)
* Fix validation check within Utf8JsonWriter for writing a primitive
value.
* Update the unit test to pass in JsonValueKind as an inlinedata option.
* Test cleanup.
* Remove use of _isNotPrimitive as that is redundant and unnecessary.
* Some more test clean up - validate bytespending moves.
* More test clean up - ensure bytespending remains as is when we throw.
* Invert check order to rely on short-circuiting.
* Address feedback and add comment related tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
47c35fe385c18d5f0a4ceacea381f790db472ba2
Stephen Toub [Mon, 29 Jul 2019 02:34:44 +0000 (22:34 -0400)]
Re-enable xunit warning 1010 (dotnet/corefx#39846)
Commit migrated from https://github.com/dotnet/corefx/commit/
e36291288fc182e94a919f45e61a8924f953c3cd
Tarek Mahmoud Sayed [Sun, 28 Jul 2019 22:50:55 +0000 (15:50 -0700)]
Add tests for edge cases in ToLocalTIme (dotnet/corefx#39833)
For dotnet/coreclrdotnet/corefx#25658: Added conditional tests for ToLocalTIme() to test its behavior with DateTime.MinValue, DateTime.MaxValue, and ambiguous DST time.
Fixed duplicate theory parameter for Subtract_DateTimeOffset.
Commit migrated from https://github.com/dotnet/corefx/commit/
72fe15dce2875229722bf6bddd409856d0b47ce1
Ganbarukamo41 [Sun, 28 Jul 2019 22:47:52 +0000 (07:47 +0900)]
Enable analyzer for xUnit2000 (Constants and literals should be the expected argument) (dotnet/corefx#39842)
* Enable xUnit2000 analyzer
This commit enables xUnit2000 (Constants and literals should be the expected argument) and apply fixes for the existing violating codes.
* a Massive commit fixing xUnit2000
* fixing some 2003 errors
* Fix mistakes
* Fix missed errors for unix
Commit migrated from https://github.com/dotnet/corefx/commit/
93d7aa1c1737b6da29d04b78557215e18eb786d4
Geoff Kizer [Sun, 28 Jul 2019 04:25:40 +0000 (21:25 -0700)]
Merge pull request dotnet/corefx#39834 from geoffkizer/fixendstreamrace
HTTP2: Ensure we never send EndStream after RST_STREAM
Commit migrated from https://github.com/dotnet/corefx/commit/
57df8b38e4e70fc25aabe3d061cd1745cff0b26b
Geoff Kizer [Sat, 27 Jul 2019 22:37:42 +0000 (15:37 -0700)]
ensure we never send EndStream after RST_STREAM
Commit migrated from https://github.com/dotnet/corefx/commit/
9389088720e38b9d4f1d126d9daaa3461ad158e8
Aaron Schiff [Sat, 27 Jul 2019 22:15:41 +0000 (17:15 -0500)]
Add tests for edge cases in ToLocalTIme
For dotnet/coreclrdotnet/corefx#25658: Added conditional tests for ToLocalTIme() to test its behavior with DateTime.MinValue, DateTime.MaxValue, and ambiguous DST time.
Fixed duplicate theory parameter for Subtract_DateTimeOffset.
Commit migrated from https://github.com/dotnet/corefx/commit/
dc8e5eb91bb8493f4a6ef6b1e3cd492d3a9a85e3
Stephen Toub [Sat, 27 Jul 2019 11:39:18 +0000 (07:39 -0400)]
Remove bogus asserts in DataSet tests (dotnet/corefx#39827)
Commit migrated from https://github.com/dotnet/corefx/commit/
610b0eb6e5e058f2c9eb04b4dc62778dc8e062d0
Stephen Toub [Sat, 27 Jul 2019 02:24:39 +0000 (22:24 -0400)]
Fix SendAsync_SuppressedGlobalStaticPropagationNoListenerAppCtx test (dotnet/corefx#39795)
Commit migrated from https://github.com/dotnet/corefx/commit/
8a6389529afdc0dd53d4c94fe665695ec54c21af
Krzysztof Wicher [Fri, 26 Jul 2019 23:43:12 +0000 (16:43 -0700)]
Debian 10/Win8.1 fixes: Allow explicitly using SSLv3, TLS1.0/1.1 (dotnet/corefx#39579)
* debian 10 fixes
* Fix Windows 8.1 (product issue)
* expand SSL_CTX_set_min/max_proto_version macro in attempt to fix the build
* define SSL_CTRL_SET_MIN/MAX_PROTO_VERSION when not defined
* Apply Win8.1 fix to all platforms in attempt to fix OSX
* check if failing test with excluded SSL2 passes on OSX
* Filter out incompatible protocols at the source instead of each callsite
* Remove ResetProtocolRestrictions from header file
* Update src/System.Net.Security/src/System/Net/Security/SslAuthenticationOptions.cs
Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
* revert files with only whitespace changes
Commit migrated from https://github.com/dotnet/corefx/commit/
d5b91dc5e2b1c4bc73c4ba2070fd7cb8f7013b49
Steve Molloy [Fri, 26 Jul 2019 22:26:43 +0000 (15:26 -0700)]
Merge pull request dotnet/corefx#39556 from ericstj/Runtime.Caching.NETStandard
Make System.Runtime.Caching's implementation NETStandard based
Commit migrated from https://github.com/dotnet/corefx/commit/
5db03196f0f51f9c1765b383de48a82434bbe8f0
Eirik Tsarpalis [Fri, 26 Jul 2019 21:05:57 +0000 (22:05 +0100)]
Merge pull request dotnet/corefx#39774 from eiriktsarpalis/httpserver-add-echo-header-endpoint
HttpStress: Add randomized request headers
Commit migrated from https://github.com/dotnet/corefx/commit/
3ebfae3ed729af13e59c0525e7b794327bfd227f
Dan Moseley [Fri, 26 Jul 2019 21:00:30 +0000 (14:00 -0700)]
Update to MatchEvaluator NRE change (dotnet/corefx#39813)
* Update to MatchEvaluator NRE change
* lowercase
Commit migrated from https://github.com/dotnet/corefx/commit/
c4e71057d8f2d9717316939584ef046147cefe2f
Eirik Tsarpalis [Fri, 26 Jul 2019 20:40:48 +0000 (21:40 +0100)]
take HttpClient.BaseAddress into account when bounding request uri sizes
Commit migrated from https://github.com/dotnet/corefx/commit/
d5a0fb96a026447dcf201dc7c19b0b8d41be60f5
Tomas Weinfurt [Fri, 26 Jul 2019 20:31:37 +0000 (13:31 -0700)]
throw for unknown or unsupported AddressFamily on Windows (dotnet/corefx#39785)
* throw for unknown or unsupported SocketAddress on Windows
* feedback from review
Commit migrated from https://github.com/dotnet/corefx/commit/
f0a0eca0242cb072acdd940d98d08e43d6adfe28
Eirik Tsarpalis [Fri, 26 Jul 2019 20:08:57 +0000 (21:08 +0100)]
maxRequestLineSize -> MaxRequestUriSize
Commit migrated from https://github.com/dotnet/corefx/commit/
920292cf7c763a6963119e7cb7cd2faa149a1cb1
Eirik Tsarpalis [Fri, 26 Jul 2019 19:44:31 +0000 (20:44 +0100)]
respect kestrel request line size
Commit migrated from https://github.com/dotnet/corefx/commit/
261ff104b73439fda85a950e2dfb3f5bc8e23c5b
Steve Harter [Fri, 26 Jul 2019 17:20:30 +0000 (12:20 -0500)]
Allow JsonConverterAttribute to be applied to an Enum (dotnet/corefx#39790)
Commit migrated from https://github.com/dotnet/corefx/commit/
de61fb206e61f105f657ca01b1244580cc9e1e77
Steve Harter [Fri, 26 Jul 2019 16:53:37 +0000 (11:53 -0500)]
Fix FormatException if an invalid JsonConverter attribute is specified (dotnet/corefx#39789)
Commit migrated from https://github.com/dotnet/corefx/commit/
dfe3ab2f0205436e23b93c369ee0b2e41a4973e0
Eirik Tsarpalis [Fri, 26 Jul 2019 14:49:09 +0000 (15:49 +0100)]
merge headers and echo headers operations
Commit migrated from https://github.com/dotnet/corefx/commit/
e22fbde5ebe4000d682bcb679a3a372050c2bc16
Zoey McCullough [Fri, 26 Jul 2019 13:58:06 +0000 (06:58 -0700)]
Re-enable xunit warning 2002 dotnet/corefx#39696 (dotnet/corefx#39706)
* Removed null checks on value types and enabled xunit 2002
* Updated Fill_OpenDataReader_Throws to use range check
Updated Fill_OpenDataReader_Throws to use range check for passing path
* Removed uneeded asserts and updated others
- Removed any assert for a valuetype where it was succeeded by a value type assertion (e.g. Assert.Equal(1, 1))
- Updated reflection tests to check flags for the specified scenario
* Update src/Microsoft.VisualBasic.Core/tests/FileSystemTests.cs
Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
* Update src/System.Reflection/tests/AssemblyNameTests.cs
Co-Authored-By: Jeremy Barton <jbarton@microsoft.com>
* Fixed failing reflection tests and removed Assert.NotNull for enum
* Pulled ruleset up from master to merge
* Cleaned up assert ordering for TestGuid
* Updated TestResponseWithoutContentEvents
- Asserted for 200 OK based on response from DefaultAzureServer + EmptyContentHandler
Commit migrated from https://github.com/dotnet/corefx/commit/
c96e389f803b043753558878fefb575f3f85c934
Eirik Tsarpalis [Fri, 26 Jul 2019 13:12:26 +0000 (14:12 +0100)]
address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
b32c61aa4741668d6f4009649412ff80f5d64f85
Dan Moseley [Fri, 26 Jul 2019 05:27:18 +0000 (22:27 -0700)]
Fix NRE when MatchEvaluator returns null (dotnet/corefx#39779)
* Fix NRE when MatchEvaluator returns null
* Update Regex.Replace.Tests.cs
* Use fancy syntax
Commit migrated from https://github.com/dotnet/corefx/commit/
98227597b152076cb02c55bb695c572c14284e32
Stephen Toub [Fri, 26 Jul 2019 02:04:39 +0000 (22:04 -0400)]
Re-enable CA1200 (avoid cref tag prefixes) (dotnet/corefx#39773)
* Re-enable CA1200 (avoid cref tag prefixes)
Specifying the prefix prevents the compiler from validating what comes after it.
* Fix netfx build
Commit migrated from https://github.com/dotnet/corefx/commit/
58a4d24eb808936f7dc61e68265e968291470b42
Stephen Toub [Fri, 26 Jul 2019 02:02:21 +0000 (22:02 -0400)]
Re-enable CA1802 (use consts instead of readonly statics) (dotnet/corefx#39782)
* Re-enable CA1802 (use consts instead of readonly statics)
I enabled it only for privates and internals, as we've previously violated this in public surface area, and as everything goes through API review moving forward, didn't seem worthwhile fighting it and adding suppressions in various places.
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
318b5941ba4e713155d82c674c7f5bd0e68faf7b
Koundinya Veluri [Thu, 25 Jul 2019 22:21:00 +0000 (15:21 -0700)]
Relax a mutex test condition (dotnet/corefx#39786)
Fixes https://github.com/dotnet/corefx/issues/39694
- When doing a `WaitAny()` with mutexes that are expected to be abandoned and an event that is signaled, it has been seen in the CI on Windows that sometimes the `WaitAny()` may succeed due to event rather than identifying an abandoned mutex. The CLR doesn't do anything special and just delegates to the OS, the only way that could happen is if there could be a delay between the thread exiting and the mutex being released and abandoned. I haven't been able to repro that behavior or the test failure on my machine, it may not be easy to repro, even in the CI it fails only occasionally.
- It's not a bug as long as the mutex eventually gets released and abandoned. Relaxed the condition for `WaitAny()` with an event following a mutex to account for a delay.
Commit migrated from https://github.com/dotnet/corefx/commit/
97d5957fc71853961082e22873d926269b291b92
Eirik Tsarpalis [Thu, 25 Jul 2019 20:54:15 +0000 (21:54 +0100)]
address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
88de39071ec291e67f1c5829ea7e9dd30c913da1
Steve Harter [Thu, 25 Jul 2019 20:24:44 +0000 (15:24 -0500)]
Reduce memory usage of tests and fix asserts for escaped size (dotnet/corefx#39751)
Commit migrated from https://github.com/dotnet/corefx/commit/
3e36efc9a3c3f22b87c5f33a25c0ad5dbfeb9396
William Godbe [Thu, 25 Jul 2019 19:18:53 +0000 (12:18 -0700)]
Exclude System.Numerics.Tensors Symbol package from publishing (dotnet/corefx#39772)
Commit migrated from https://github.com/dotnet/corefx/commit/
83a6ce4e0ec24791277be6de3ca23d7fdfb56fe1
Geoff Kizer [Thu, 25 Jul 2019 19:07:05 +0000 (12:07 -0700)]
Merge pull request dotnet/corefx#39745 from geoffkizer/requesterrorfix
HTTP2: fix race between request failure and response body read
Commit migrated from https://github.com/dotnet/corefx/commit/
64a9e2ccf5e590e0a3a3d6dc9c2a7c828850c912
Eirik Tsarpalis [Thu, 25 Jul 2019 17:21:30 +0000 (18:21 +0100)]
HttpStress: add randomized header operation
Aguments the stress suite with an "Echo Header" operation
which sends and receives a randomly generated set of headers.
Additionally expands random string to full alphanumeric or ascii range.
Fixes a bug where `n - 1` workers were being initialized.
Commit migrated from https://github.com/dotnet/corefx/commit/
ac3e0d6f35dfccdd70bacfc09941fef791192da5
Charles Stoner [Thu, 25 Jul 2019 15:09:17 +0000 (08:09 -0700)]
Add [Obsolete] to vbNewLine (dotnet/corefx#39753)
Commit migrated from https://github.com/dotnet/corefx/commit/
75c4a6ee39219480cfeb372c68fd72df90d63c86
Jeremy Barton [Thu, 25 Jul 2019 14:46:11 +0000 (07:46 -0700)]
Change the default symmetric encryption algorithm for EnvelopedCms
.NET Framework upgraded this for 4.8, .NET Core should for 3.0
Commit migrated from https://github.com/dotnet/corefx/commit/
64b72f0474555e5039e22a399dbcac289368f68a
Eirik Tsarpalis [Thu, 25 Jul 2019 11:12:15 +0000 (12:12 +0100)]
Merge pull request dotnet/corefx#39632 from eiriktsarpalis/httpstress-segregate-client-server
HttpStress: Allow standalone client and server processes
Commit migrated from https://github.com/dotnet/corefx/commit/
b5483cb5280235a94b534c93e678e647cfcecd0c
Stephen Toub [Thu, 25 Jul 2019 08:45:20 +0000 (04:45 -0400)]
Re-enable xUnit1025 (duplicate InlineData) (dotnet/corefx#39737)
Commit migrated from https://github.com/dotnet/corefx/commit/
47d96f89df41ce18d3ba77b38007ec68f7f66fc6
Ahson Khan [Thu, 25 Jul 2019 03:44:48 +0000 (20:44 -0700)]
Auto-generate the reference assemblies to normalize them (dotnet/corefx#39681)
* Update Microsoft.VisualBasic.Core ref
* Update System.Collections.Concurrent ref
* Update System.Collections.Immutable ref
* Update System.Collections ref
* Update System.ComponentModel.Composition ref
* Update System.Data.Common ref
* Update System.Data.OleDb ref
* Update System.Data.SqlClient ref for netcoreapp
* Update System.Diagnostics.DiagnosticSource ref and DiagnosticSourceActivity.cs
* Update System.IO.Packaging ref for netcoreapp
* Update System.IO.Pipelines ref
* Update System.Linq ref
* Update System.Net.Http ref
* Update System.Net.Security ref
* Update System.Numerics.Tensors ref
* Update System.Reflection.Emit for netcore
* Update System.Security.AccessControl ref
* Update System.Security.Permissions ref
* Update System.ServiceModel.Syndication ref
* Update System.Text.Encodings.Web ref
* Update System.Threading.Channels ref for netcoreapp
* Update System.Utf8String.Experimental ref
* Update System.Utf8String.Experimental csproj to reference new file.
* Upat eSystem.Runtime ref and Manual ref
* Update Microsoft.Bcl.AsyncInterfaces ref
* Disable warning CS8617 for missing nullability annotations within
explicit interface methods.
* Revert System.Runtime.cs back to what's in master.
* Update System.Runtime ref (single change - System.Char -> char).
* Revert System.Collections.Immutable back to what's in master (keep
readonly on private fields).
* Update System.Runtime ref and add comment in Manual ref file for
TypedReference.
Commit migrated from https://github.com/dotnet/corefx/commit/
bdd0814360d4c3a58860919f292a306242f27da1
Viktor Hofer [Thu, 25 Jul 2019 02:03:09 +0000 (04:03 +0200)]
Enable xunit2007 analyzer (dotnet/corefx#39740)
Commit migrated from https://github.com/dotnet/corefx/commit/
619f140e2f0e722a17f3797d532b21ace774ec2e
Stephen Toub [Thu, 25 Jul 2019 01:58:45 +0000 (21:58 -0400)]
Re-enable xUnit2008 (Assert.True with regex) (dotnet/corefx#39739)
Commit migrated from https://github.com/dotnet/corefx/commit/
e091ee920b211b28a9d8a7928ca3b15294789d82
Stephen Toub [Thu, 25 Jul 2019 00:46:54 +0000 (20:46 -0400)]
Re-enable xUnit1016 (public MemberDatas) (dotnet/corefx#39738)
Commit migrated from https://github.com/dotnet/corefx/commit/
306fe9d60cc6db02a69d8ea6b88dde2b98fe8a7c
Anirudh Agnihotry [Thu, 25 Jul 2019 00:46:40 +0000 (17:46 -0700)]
Only removing logs which throw invalid parameters exception from eventLogs (dotnet/corefx#39705)
* only removing logs which throw invalid parametert exception from eventlogs
* using ordinalIgnoreCase, const name and improving comment
Commit migrated from https://github.com/dotnet/corefx/commit/
70aeda2b5b7110ead0ea69dc83f3f47e5728db06
Anirudh Agnihotry [Thu, 25 Jul 2019 00:45:38 +0000 (17:45 -0700)]
parameter name corrected (dotnet/corefx#39744)
Commit migrated from https://github.com/dotnet/corefx/commit/
32d791286263d58e84a587b4a8be0d7d1e667f05
William Godbe [Wed, 24 Jul 2019 23:22:54 +0000 (16:22 -0700)]
Mark System.Numerics.Tensors package as nonshipping (dotnet/corefx#39743)
* Mark System.Numerics.Tensors package as nonshipping
* Consolidate ItemGroup definition
Commit migrated from https://github.com/dotnet/corefx/commit/
a5026415f84efec9c4a51efb6a654be1c4a86070
Geoff Kizer [Wed, 24 Jul 2019 20:58:28 +0000 (13:58 -0700)]
fix race between request failure and response body read
Commit migrated from https://github.com/dotnet/corefx/commit/
a327d792c1590bd9ef744c197dfbb311961d5eef
Stephen Toub [Wed, 24 Jul 2019 17:14:01 +0000 (13:14 -0400)]
Re-emable CA1507 (use nameof) (dotnet/corefx#39731)
Commit migrated from https://github.com/dotnet/corefx/commit/
c265373119bc0449d347862862b43de35a95b186
Viktor Hofer [Wed, 24 Jul 2019 16:20:57 +0000 (18:20 +0200)]
Enable xunit2012 analyzer (dotnet/corefx#39730)
Commit migrated from https://github.com/dotnet/corefx/commit/
722ab9b7303ef14db74a1d09d464d180f18f512b
Stephen Toub [Wed, 24 Jul 2019 14:50:31 +0000 (10:50 -0400)]
Add comment descriptions to remaining xunit analyzer suppressions (dotnet/corefx#39725)
Commit migrated from https://github.com/dotnet/corefx/commit/
c1dae31100118f358ac8bf8707a9017c17576356
Stephen Toub [Wed, 24 Jul 2019 14:42:39 +0000 (10:42 -0400)]
Re-enable CA1825 (zero-length array allocations) (dotnet/corefx#39708)
Commit migrated from https://github.com/dotnet/corefx/commit/
d0fc0a2b193d11645acc0fe72bbf1b97678a5161
Stephen Toub [Wed, 24 Jul 2019 11:33:20 +0000 (07:33 -0400)]
Re-enable CA2200 (rethrowing exceptions in catch blocks) (dotnet/corefx#39700)
Commit migrated from https://github.com/dotnet/corefx/commit/
7b142543ce066ba684303837c2e9723b9e140d39
Viktor Hofer [Wed, 24 Jul 2019 11:25:58 +0000 (13:25 +0200)]
Enable xunit2015 analyzer (dotnet/corefx#39714)
Commit migrated from https://github.com/dotnet/corefx/commit/
a7fa4b58be0b266d8fe680de34f9b1a3dab8523a
Geoff Kizer [Wed, 24 Jul 2019 09:28:18 +0000 (02:28 -0700)]
Merge pull request dotnet/corefx#39638 from geoffkizer/streamshutdownfixes4
HTTP2: Rework shutdown handling
Commit migrated from https://github.com/dotnet/corefx/commit/
ca3fe6738ae6afc56e1f8fb5477a57a8dc2e183c
Geoff Kizer [Wed, 24 Jul 2019 07:47:35 +0000 (00:47 -0700)]
address review feedback and fix test issue
Commit migrated from https://github.com/dotnet/corefx/commit/
d6e6f52c928f56b424b08fcf6e08ea84a74748ab
Stephen Toub [Wed, 24 Jul 2019 07:45:28 +0000 (03:45 -0400)]
Re-enable CA1401 (public P/Invoke methods) (dotnet/corefx#39710)
Commit migrated from https://github.com/dotnet/corefx/commit/
28e0be5f236b57027b66395fcef87d3c58e31424
Stephen Toub [Wed, 24 Jul 2019 07:44:54 +0000 (03:44 -0400)]
Re-enable CA2008 (tasks without a TaskScheduler) (dotnet/corefx#39707)
Commit migrated from https://github.com/dotnet/corefx/commit/
9958740c24865cad40dd84bcd8c416cea927e3cc
Stephen Toub [Wed, 24 Jul 2019 07:42:36 +0000 (03:42 -0400)]
Re-enable CA1821 (remove empty finalizers) (dotnet/corefx#39709)
Commit migrated from https://github.com/dotnet/corefx/commit/
4cdbbd9430a3e080eb0926f612c89ffe74ed6e7e
Ahson Khan [Wed, 24 Jul 2019 06:28:07 +0000 (23:28 -0700)]
Update dummy fields within the ref by auto-generating them from the source assembly. (dotnet/corefx#39687)
* Update dummy fields within the ref by auto-generating them from the
source assembly.
* Address feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
c50b758727a041aec2dc959ee5ca2df5614a3c16
Stephen Toub [Wed, 24 Jul 2019 03:10:17 +0000 (23:10 -0400)]
Upgrade Roslyn analyzers (dotnet/corefx#39703)
* Upgrade analyzer versions
We were years behind.
* Fix nameof warnings in System.ComponentModel.Annotations
* Disable all rules with failures
* Enable CA2007 (ConfigureAwait)
* Enable CA5373, 5379, 5384, and 5385 (weak crypto)
* Remove stale nuget analyzer packages consumed into main package
* Enable CA2002
Commit migrated from https://github.com/dotnet/corefx/commit/
0f1fa092672a344b92c4bc440f3ab6232614a7f4
Santiago Fernandez Madero [Fri, 19 Jul 2019 22:48:01 +0000 (15:48 -0700)]
Update package testing to test for 5.0 and use the SDK targeting pack for 3.0
Commit migrated from https://github.com/dotnet/corefx/commit/
e733500d11ae73f5ddba17b75127f1b3033c470c
Stephen Toub [Tue, 23 Jul 2019 21:05:15 +0000 (17:05 -0400)]
Re-enable xunit warning 2004 (dotnet/corefx#39698)
* Replace "Assert.Equal(true, " with "Assert.True("
* Replace "Assert.Equal(false, " with "Assert.False("
And fix a few Assert.Equal(true cases that deal with objects and thus need to be reverted.
* Replace "Assert.StrictEqual(true, " with "Assert.True("
* Revert a few changes where true/false was being compared to object
* Address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
1296bc8386a7283e319ddf723282f16651f9ea5f
Geoff Kizer [Tue, 23 Jul 2019 20:18:56 +0000 (13:18 -0700)]
fix race in request body completion
Commit migrated from https://github.com/dotnet/corefx/commit/
29328b71b65abe3a199f0daf62f6ee71ca916e78
Geoff Kizer [Tue, 23 Jul 2019 08:10:16 +0000 (01:10 -0700)]
fix race with _requestBodyCancellationSource creation
Commit migrated from https://github.com/dotnet/corefx/commit/
7394185c0fc8a52bebf384b933b07c1eb1fba360
Geoff Kizer [Tue, 23 Jul 2019 05:15:05 +0000 (22:15 -0700)]
rework SendHeadersAsync to address various issues
Commit migrated from https://github.com/dotnet/corefx/commit/
2d5a9555d4888c82c653a9d7ad8368bc94adfdf2
Geoff Kizer [Tue, 23 Jul 2019 03:25:59 +0000 (20:25 -0700)]
address review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
752c1c8d8a01d22d52b1a320f9ed082049494045
Geoff Kizer [Sat, 20 Jul 2019 17:02:45 +0000 (10:02 -0700)]
combine into single Cancel method on stream, and ensure Dispose cancels properly when response is not read to end
Commit migrated from https://github.com/dotnet/corefx/commit/
5973d1ee6f3b616d2af2bc80527bdf8fe76ee210
Geoff Kizer [Fri, 12 Jul 2019 11:41:05 +0000 (04:41 -0700)]
rework shutdown handling
Commit migrated from https://github.com/dotnet/corefx/commit/
0cd73b77e1f31d48037b56deb0206f4e56b4232e
Stephen Toub [Tue, 23 Jul 2019 19:49:33 +0000 (15:49 -0400)]
Re-enable xunit warning 2003 (dotnet/corefx#39696)
* Replace "Assert.Equal(null, " with "Assert.Null("
* Replace "Assert.NotEqual(null, " with "Assert.NotNull("
* Replace "Assert.Same(null, " with "Assert.Null("
* Replace "Assert.StrictEqual(null, " with "Assert.Null("
Commit migrated from https://github.com/dotnet/corefx/commit/
6de660a02e335eefebfcc3c81ecb0013e2a8148e
Eirik Tsarpalis [Tue, 23 Jul 2019 17:43:46 +0000 (18:43 +0100)]
Merge pull request dotnet/corefx#39693 from eiriktsarpalis/add-dockerignore
Add .dockerignore file to the root of the repo
Commit migrated from https://github.com/dotnet/corefx/commit/
e6a5951fb68a09598f1fc1826a94de212385c649
Egor Bogatov [Tue, 23 Jul 2019 14:25:37 +0000 (17:25 +0300)]
Make AsciiToLower ReadOnlySpan<byte> (dotnet/corefx#39678)
Commit migrated from https://github.com/dotnet/corefx/commit/
794bde4b8eb26047b6495af09a428e03e81e7e81
Eirik Tsarpalis [Tue, 23 Jul 2019 13:59:02 +0000 (14:59 +0100)]
add license notice to new source files
Commit migrated from https://github.com/dotnet/corefx/commit/
930dc991ca17b759d675c5015cd9c61bc8a725be
Stephen Toub [Tue, 23 Jul 2019 13:09:51 +0000 (09:09 -0400)]
Disable SendAsync_SuppressedGlobalStaticPropagationNoListenerAppCtx test (dotnet/corefx#39692)
Commit migrated from https://github.com/dotnet/corefx/commit/
687f36489c19072cd5a19d48c099f53bbc871c4d
Stephen Toub [Tue, 23 Jul 2019 06:39:47 +0000 (02:39 -0400)]
Re-enable xunit warning 1006 (dotnet/corefx#39685)
Regex search and replace for [InlineData()] with [Theory].
Commit migrated from https://github.com/dotnet/corefx/commit/
b58a866ba8709d66eed52bb8ecb13966b7436a1d
Stephen Toub [Mon, 22 Jul 2019 20:56:01 +0000 (16:56 -0400)]
Re-enable all DisableXUnitAnalyzer test projects (dotnet/corefx#39674)
* Re-enable all DisableXUnitAnalyzer test projects
* Remove TODO comment
Commit migrated from https://github.com/dotnet/corefx/commit/
16f3eef83d6df4c9dbc0e2992dafbc9553db363d
Stephen Toub [Mon, 22 Jul 2019 20:45:03 +0000 (16:45 -0400)]
Re-enable ~20 xunit analyzers (dotnet/corefx#39671)
* Re-enable ~20 xunit analyzers
All but one of these had no associated warnings firing. I fixed one warning to be able to re-enable another analyzer.
* Fix netfx build failures
Commit migrated from https://github.com/dotnet/corefx/commit/
c60b8172cfcd1e7f0d8104872f279781fd288b68
buyaa-n [Mon, 22 Jul 2019 18:43:03 +0000 (11:43 -0700)]
Custom converter contravariant test coverage (dotnet/corefx#39558)
* Custom converter contravariant test coverage
Commit migrated from https://github.com/dotnet/corefx/commit/
27228368037aeaa27fc5220d7d12c0550a2ef9c3
Stephen Toub [Mon, 22 Jul 2019 18:06:56 +0000 (14:06 -0400)]
Update breaking changes doc with a few clarifications (dotnet/corefx#39665)
Commit migrated from https://github.com/dotnet/corefx/commit/
f25b89e05594b0e56e1bea7080c935908142e960
Stephen Toub [Mon, 22 Jul 2019 16:32:21 +0000 (12:32 -0400)]
Add missing fields to BrotliEncoder/Decoder ref (dotnet/corefx#39653)
Without these, we can end up with corrupt encoder/decoder state due to uninitialized fields.
Commit migrated from https://github.com/dotnet/corefx/commit/
3c3b9ceee6e1416db6f1ddbc1ab0d0ffb67c16fa
Stephen Toub [Mon, 22 Jul 2019 16:30:03 +0000 (12:30 -0400)]
Remove unnecessary empty try { } blocks (dotnet/corefx#39664)
Unnecessary in .NET Core code. I didn't modify additional instances in libraries that target netstandard/netfx.
Commit migrated from https://github.com/dotnet/corefx/commit/
ca795a928d210c78c6bbd3fa10eb35f4c093a5a4