Simon Pilgrim [Mon, 24 Jan 2022 11:15:45 +0000 (11:15 +0000)]
[X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs
D111986 added the generic `__builtin_elementwise_abs()` intrinsic with the same integer absolute behaviour as the SSE/AVX instructions (abs(INT_MIN) == INT_MIN)
This patch removes the `__builtin_ia32_pabs*` intrinsics and just uses `__builtin_elementwise_abs` - the existing tests see no changes:
```
__m256i test_mm256_abs_epi8(__m256i a) {
// CHECK-LABEL: test_mm256_abs_epi8
// CHECK: [[ABS:%.*]] = call <32 x i8> @llvm.abs.v32i8(<32 x i8> %{{.*}}, i1 false)
return _mm256_abs_epi8(a);
}
```
This requires us to add a `__v64qs` explicitly signed char vector type (we already have `__v16qs` and `__v32qs`).
Differential Revision: https://reviews.llvm.org/D117791
Bjorn Pettersson [Tue, 18 Jan 2022 18:50:50 +0000 (19:50 +0100)]
[DAGCombiner] Adjust some checks in DAGCombiner::reduceLoadWidth
In code review for D117104 two slightly weird checks were found
in DAGCombiner::reduceLoadWidth. They were typically checking
if BitsA was a mulitple of BitsB by looking at (BitsA & (BitsB - 1)),
but such a comparison actually only make sense if BitsB is a power
of two.
The checks were related to the code that attempted to shrink a load
based on the fact that the loaded value would be right shifted.
Afaict the legality of the value types is checked later (typically in
isLegalNarrowLdSt), so the existing checks were both overly
conservative as well as being wrong whenever ExtVTBits wasn't a
power of two. The latter was a situation triggered by a number of
lit tests so we could not just assert on ExtVTBIts being a power of
two).
When attempting to simply remove the checks I found some problems,
that seems to have been guarded by the checks (maybe just out of
luck). A typical example would be a pattern like this:
t1 = load i96* ptr
t2 = srl t1, 64
t3 = truncate t2 to i64
When DAGCombine is visiting the truncate reduceLoadWidth is called
attempting to narrow the load to 64 bits (ExtVT := MVT::i64). Then
the SRL is detected and we set ShAmt to 64.
In the past we've bailed out due to i96 not being a multiple of 64.
If we simply remove that check then we would end up replacing the
load with a new load that would read 64 bits but with a base pointer
adjusted by 64 bits. So we would read 32 bits the wasn't accessed by
the original load.
This patch will instead utilize the fact that the logical left shift
can be folded away by using a zextload. Thus, the pattern above will
now be combined into
t3 = load i32* ptr+offset, zext to i64
Another case is shown in the X86/shift-folding.ll test case:
t1 = load i32* ptr
t2 = srl i32 t1, 8
t3 = truncate t2 to i16
In the past we bailed out due to the shift count (8) not being a
multiple of 16. Now the narrowing kicks in and we get
t3 = load i16* ptr+offset
Differential Revision: https://reviews.llvm.org/D117406
Bjorn Pettersson [Tue, 18 Jan 2022 18:48:35 +0000 (19:48 +0100)]
Pre-commit test case for trunc+lshr+load folds
This is a pre-commit of test cases relevant for D117406.
@srl_load_narrowing1 is showing a pattern that could be folded into
a more narrow load.
@srl_load_narrowing2 is showing a similar pattern that happens to
be optimized already, but that happens in two steps (first triggering
a combine based on SRL and later another combine based on TRUNCATE).
Differential Revision: https://reviews.llvm.org/D117588
David Spickett [Mon, 24 Jan 2022 11:16:34 +0000 (11:16 +0000)]
[lldb] Update release notes with non-address bit handling changes
This adds the "memory find" (https://reviews.llvm.org/D117299)
and "memory tag" (https://reviews.llvm.org/D117672) commands
and puts them all in one list.
Fraser Cormack [Tue, 18 Jan 2022 14:13:13 +0000 (14:13 +0000)]
[RISCV][VP] Lower VP_MERGE to RVV instructions
This patch adds lowering of the llvm.vp.merge.* intrinsic
(ISD::VP_MERGE) to RVV vmerge/vfmerge instructions. It introduces a
special pseudo form of vmerge which allows a tied merge operand,
allowing us to specify the tail elements as being equal to the "on
false" operand, using a tied-def constraint and a "tail undisturbed"
policy.
While this strategy allows us to often lower the intrinsic to just one
instruction, it may be less efficient in fixed-vector types as the
number of tail elements may extend far beyond the length of the fixed
vector. Another strategy could be to use a vmerge/vfmerge instruction
with an AVL equal to the length of the vector type, and manipulate the
condition operand such that mask elements greater than the operation's
EVL are false.
I've also observed inefficient codegen in which our 'VF' patterns don't
match raw floating-point SPLAT_VECTORs, which occur in scalable-vector
code.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D117561
Fraser Cormack [Thu, 20 Jan 2022 14:46:28 +0000 (14:46 +0000)]
[RISCV] Match VF variants for masked VFRDIV/VFRSUB
This patch follows up on D117697 to help the simple binary operations
behave similarly in the presence of masks.
It also enables CGP sinking support for vp.fdiv and vp.fsub intrinsics,
now that VFRDIV and VFRSUB are consistently matched with a LHS splat for
masked and unmasked variants.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D117783
Simon Pilgrim [Mon, 24 Jan 2022 11:08:13 +0000 (11:08 +0000)]
[X86] getVectorMaskingNode - fix indentation. NFC.
clang-format
Abinav Puthan Purayil [Mon, 24 Jan 2022 10:54:54 +0000 (16:24 +0530)]
[AMDGPU][GlobalISel] Remove the post ':' part of vreg operands in fsh combine tests.
Andrzej Warzynski [Tue, 11 Jan 2022 13:16:03 +0000 (13:16 +0000)]
[flang] Update the description of `!fir.coordinate_of`
This change was suggested in one of the comments for
https://reviews.llvm.org/D115333. Basically, the following usage is
valid, but the current wording suggests otherwise:
```
%1 = fir.coordinate_of %a, %k : (!fir.ref<!fir.array<10 x 10 x i32>>, index) -> !fir.ref<!fir.array<10 x i32>>
```
A test is also added to better document this particular case.
Differential revision: https://reviews.llvm.org/D115929
David Spickett [Thu, 13 Jan 2022 16:54:04 +0000 (16:54 +0000)]
[lldb] Ignore non-address bits in "memory find" arguments
This removes the non-address bits before we try to use
the addresses.
Meaning that when results are shown, those results won't
show non-address bits either. This follows what "memory read"
has done. On the grounds that non-address bits are a property
of a pointer, not the memory pointed to.
I've added testing and merged the find and read tests into one
file.
Note that there are no API side changes because "memory find"
does not have an equivalent API call.
Reviewed By: omjavaid
Differential Revision: https://reviews.llvm.org/D117299
Jay Foad [Fri, 21 Jan 2022 17:18:03 +0000 (17:18 +0000)]
[AMDGPU][GlobalISel] Add more sign/zero/any-extension tests
Add s1 to s16 cases, and for sgprs s1 to s64 and s32 to s64.
Jay Foad [Fri, 21 Jan 2022 17:03:03 +0000 (17:03 +0000)]
[AMDGPU][GlobalISel] Regenerate checks in inst-select-*ext.mir
Peter Smith [Fri, 21 Jan 2022 16:19:22 +0000 (16:19 +0000)]
[LLD][ELF][AArch64] Update test with incorrect REQUIRES line [NFC]
D54759 introduced aarch64-combined-dynrel.s and
aarch64-combined-dynrel-ifunc.s . Unfortunately the requires line
at the top was AArch64 instead of aarch64 which means they were never
run. Update the tests to use aarch64 and fix to match current lld output.
Differential Revision: https://reviews.llvm.org/D117896
Nikita Popov [Fri, 21 Jan 2022 09:32:21 +0000 (10:32 +0100)]
[AArch64][GlobalISel] Support returned argument with multiple registers
The call lowering code assumed that a returned argument could only
consist of one register. Pass an ArrayRef<Register> instead of
Register to make sure that all parts get assigned.
Fixes https://github.com/llvm/llvm-project/issues/53315.
Differential Revision: https://reviews.llvm.org/D117866
Nikita Popov [Mon, 17 Jan 2022 14:48:01 +0000 (15:48 +0100)]
[SDAG] Don't move DBG_VALUE instructions after insertion point during scheduling (PR53243)
EmitSchedule() shouldn't be touching instructions after the provided
insertion point. The change introduced in D83561 performs a scan to
the end of the block, and thus may move unrelated instructions. In
particular, this ends up moving instructions that have been produced
by FastISel and will later be deleted. Moving them means that more
instructions than intended are removed.
Fix this by stopping the iteration when the insertion point is
reached.
Fixes https://github.com/llvm/llvm-project/issues/53243.
Differential Revision: https://reviews.llvm.org/D117489
Sander de Smalen [Wed, 19 Jan 2022 14:40:22 +0000 (14:40 +0000)]
[ISEL] Canonicalise constant splats to RHS.
SelectionDAG::getNode() canonicalises constants to the RHS if the
operation is commutative, but it doesn't do so for constant splat
vectors. Doing this early helps making certain folds on vector types,
simplifying the code required for target DAGCombines that are enabled
before Type legalization.
Somewhat to my surprise, DAGCombine doesn't seem to traverse the
DAG in a post-order DFS, so at the time of doing some custom fold where
the input is a MUL, DAGCombiner::visitMUL hasn't yet reordered the
constant splat to the RHS.
This patch leads to a few improvements, but also a few minor regressions,
which I traced down to D46492. When I tried reverting this change to see
if the changes were still necessary, I ran into some segfaults. Not sure
if there is some latent bug there.
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D117794
Andrzej Warzynski [Tue, 11 Jan 2022 13:16:03 +0000 (13:16 +0000)]
[flang][examples] Add missing CMake dependencies
Currently, everything that includes "flang/Parser/parse-tree.h" in Flang
depends on the `gen_acc` and `gen_omp` CMake targets (these targets
generate include files that are used in "parse-tree.h"). The examples in
Flang do use this header file and hence also depend on
`gen_acc`/`gen_omp`. This patch updates relevant CMake scripts
accordingly.
I've also taken the liberty to rename some of the example files so that
their names follow LLVM's coding guidelines.
Differential Revision: https://reviews.llvm.org/D117016
Nikita Popov [Fri, 21 Jan 2022 11:01:18 +0000 (12:01 +0100)]
[Attributor] Use MemoryLocation to get pointer operand and accessed type (NFCI)
This relies on existing APIs and avoids accessing the pointer
element type. The alternative would be to extend getPointerOperand()
to also return the accessed type, but I figured going through
MemoryLocation would be cleaner.
Differential Revision: https://reviews.llvm.org/D117868
Nikita Popov [Fri, 21 Jan 2022 11:48:31 +0000 (12:48 +0100)]
[OpaquePtrs] Add getNonOpaquePointerElementType() method (NFC)
This method is intended for use in places that cannot be reached
with opaque pointers, or part of deprecated methods. This makes
it easier to see that some uses of getPointerElementType() don't
need further action.
Differential Revision: https://reviews.llvm.org/D117870
Timm Bäder [Fri, 21 Jan 2022 08:48:43 +0000 (09:48 +0100)]
[clang][tests] Fix a c++/libc++ -stdlib value typo
"c++" is not usually a valid value for -stdlib.
Differential Revision: https://reviews.llvm.org/D117862
Timm Bäder [Tue, 4 Jan 2022 12:38:10 +0000 (13:38 +0100)]
[clang][sema] Add missing diagnostic parameter
The test case otherwise fails an assertion in Diagnostic::getArgKind().
Differential Revision: https://reviews.llvm.org/D116595
Chenbing.Zheng [Mon, 24 Jan 2022 08:48:39 +0000 (08:48 +0000)]
[RISCV] Add patterns of SET[U]LT_VI for STECC forms
This patch optmizes "li a0, 5
vmsgt[u].vx v10, v8, a0"
-> "vmsgt[u].vi v10, v8, 5"
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D118014
Marek Kurdej [Mon, 24 Jan 2022 08:28:11 +0000 (09:28 +0100)]
[clang-format] Assert Line->First and State.NextToken->Previous. NFC.
Cf. scan-build reports:
* https://llvm.org/reports/scan-build/report-FormatToken.cpp-precomputeFormattingInfos-35-93e1e1.html#EndPath
* https://llvm.org/reports/scan-build/report-ContinuationIndenter.cpp-addTokenOnCurrentLine-15-dfdc6d.html#EndPath
Lorenzo Chelini [Mon, 24 Jan 2022 08:07:20 +0000 (09:07 +0100)]
[MLIR][Presburger] Silence -Wdangling-else warning (NFC)
gcc suggests explicit braces to avoid ambiguous ‘else’.
Jim Lin [Mon, 24 Jan 2022 05:31:23 +0000 (13:31 +0800)]
[Hexagon] Use llvm::Register instead of unsigned in HexagonConstExtenders.cpp. NFC.
Reviewed By: kparzysz
Differential Revision: https://reviews.llvm.org/D117851
Marek Kurdej [Mon, 24 Jan 2022 07:48:14 +0000 (08:48 +0100)]
[clang-format] Assert Line->First. NFC.
Cf. scan-build reports:
* https://llvm.org/reports/scan-build/report-AffectedRangeManager.cpp-nonPPLineAffected-34-16c04b.html#EndPath
* https://llvm.org/reports/scan-build/report-SortJavaScriptImports.cpp-parseModuleReferences-34-96a7f8.html#EndPath
* https://llvm.org/reports/scan-build/report-TokenAnnotator.cpp-setCommentLineLevels-26-77bdba.html#EndPath
* https://llvm.org/reports/scan-build/report-AffectedRangeManager.cpp-nonPPLineAffected-31-714434.html#EndPath
* https://llvm.org/reports/scan-build/report-TokenAnnotator.cpp-setCommentLineLevels-16-bd39d0.html#EndPath
* https://llvm.org/reports/scan-build/report-UnwrappedLineFormatter.cpp-format-90-668b2d.html#EndPath
Nimish Mishra [Mon, 24 Jan 2022 04:32:58 +0000 (10:02 +0530)]
Added OpenMP 5.0 specification based semantic checks for atomic update construct
Marek Kurdej [Mon, 24 Jan 2022 07:34:24 +0000 (08:34 +0100)]
[clang-format] Remove unused assignment. NFC.
Fixes scan-build reported warning: https://llvm.org/reports/scan-build/report-QualifierAlignmentFixer.cpp-analyzeRight-55-191910.html#EndPath.
Qiu Chaofan [Mon, 24 Jan 2022 07:23:28 +0000 (15:23 +0800)]
[PowerPC] Emit warning for ieeelongdouble on older GNU toolchain
GCC 12 should have proper support for IEEE-754 compliant 128-bit
floating point in libstdc++. So warning is needed when linking against
older libstdc++ versions or LLVM libc++.
Glibc starts supporting float128 in both header and libraries since
2.32.
Reviewed By: jsji
Differential Revision: https://reviews.llvm.org/D112906
jacquesguan [Fri, 21 Jan 2022 06:35:20 +0000 (14:35 +0800)]
[RISCV] Decouple Zve* extensions and the V extension.
According to the spec, there are some difference between V and Zve64d. For example, the vmulh integer multiply variants that return the high word of the product (vmulh.vv, vmulh.vx, vmulhu.vv, vmulhu.vx, vmulhsu.vv, vmulhsu.vx) are not included for EEW=64 in Zve64*, but V extension does support these instructions. So we should decouple Zve* extensions and the V extension.
Differential Revision: https://reviews.llvm.org/D117854
Kazu Hirata [Mon, 24 Jan 2022 06:53:15 +0000 (22:53 -0800)]
[Target] Use range-based for loops (NFC)
Wu Xinlong [Mon, 24 Jan 2022 04:00:09 +0000 (12:00 +0800)]
[RISCV] Initially support the K-extension instructions on the LLVM MC layer
This commit is currently implementing supports for scalar cryptography extension for LLVM according to version v1.0.0 of [K Ext specification](https://github.com/riscv/riscv-crypto/releases)(scala crypto has been ratified already). Currently, we are implementing the MC (Machine Code) layer of his extension and the majority of work is done under `llvm/lib/Target/RISCV` directory. There are also some test files in `llvm/test/MC/RISCV` directory.
Remove the subfeature of Zbk* which conflict with b extensions to reduce the size of the patch.
(Zbk* will be resubmit after this patch has been merged)
**Co-author:**@ksyx & @VincentWu & @lihongliang & @achieveartificialintelligence
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D98136
Julian Lettner [Mon, 24 Jan 2022 06:01:48 +0000 (22:01 -0800)]
[TSan] Mark test unsupported on Darwin
David Blaikie [Mon, 24 Jan 2022 05:24:05 +0000 (21:24 -0800)]
Rough guess at fixing lldb tests to handle Clang defaulting to DWARFv5
Abinav Puthan Purayil [Mon, 3 Jan 2022 10:15:52 +0000 (15:45 +0530)]
[GlobalISel] Fold or of shifts with constant amount to funnel shift.
This change folds (or (shl x, C0), (lshr y, C1)) to funnel shift iff C0
and C1 are constants where C0 + C1 is the bit-width of the shift
instructions.
Differential Revision: https://reviews.llvm.org/D116529
David Blaikie [Mon, 24 Jan 2022 05:10:16 +0000 (21:10 -0800)]
Add missing function implementation from DWARF default change
Fix for
d3b26dea16108c427b19b5480c9edc76edf8f5b4
David Blaikie [Mon, 24 Jan 2022 04:45:25 +0000 (20:45 -0800)]
Clang: Change the default DWARF version to 5
(except on platforms that already opt in to specific versions - SCE,
Android, and Darwin using DWARFv4 explicitly, for instance)
Kazu Hirata [Mon, 24 Jan 2022 04:32:56 +0000 (20:32 -0800)]
[Analysis] Use default member initialization (NFC)
Identified with modernize-use-default-member-init.
Kazu Hirata [Mon, 24 Jan 2022 04:32:54 +0000 (20:32 -0800)]
[Vectorize] Remove unused variables (NFC)
Kazu Hirata [Mon, 24 Jan 2022 04:32:52 +0000 (20:32 -0800)]
Add modernize-use-default-member-init.UseAssignment to .clang-tidy
Chuanqi Xu [Mon, 24 Jan 2022 03:03:12 +0000 (11:03 +0800)]
[NFC] [Coroutines] Rename tests in coro-align
This is required by ychen. See https://reviews.llvm.org/D117542
Jim Lin [Mon, 24 Jan 2022 02:20:16 +0000 (10:20 +0800)]
[RISCV][NFC] Remove tailing whitespaces in RISCVInstrInfoVSDPatterns.td and RISCVInstrInfoVVLPatterns.td
Chuanqi Xu [Mon, 24 Jan 2022 02:22:33 +0000 (10:22 +0800)]
[C++20] [Module] fix bug 47716 and implement [module.interface]/p6
This fixes bug 47716.
According to [module.interface]p2, it is meaningless to export an entity
which is not in namespace scope.
The reason why the compiler crashes is that the compiler missed
ExportDecl when the compiler traverse the subclass of DeclContext. So
here is the crash.
Also, the patch implements [module.interface]p6 in
Sema::CheckRedeclaration* functions.
Reviewed By: aaron.ballman, urnathan
Differential Revision: https://reviews.llvm.org/D112903
David Blaikie [Mon, 24 Jan 2022 00:07:43 +0000 (16:07 -0800)]
DebugInfo: Include template parameters for simplified template decls in type units
LLVM DebugInfo CodeGen synthesizes type declarations in type units when
referencing types that are not in type units. When those synthesized
types are templates and simplified template names (or mangled simplified
template names) are in use, the template arguments must be attached to
those declarations.
A deeper fix (with a CU or DICompositeType flag) that would also support
other uses of clang's -debug-forward-template-args (such as Sony's
platform) could/should be implemented to fix this more broadly.
Simon Pilgrim [Sun, 23 Jan 2022 22:48:26 +0000 (22:48 +0000)]
[X86] Add some basic tests for PR46809
David Blaikie [Sat, 22 Jan 2022 04:20:39 +0000 (20:20 -0800)]
DebugInfo: Don't put types in type units if they reference internal linkage types
Doing this causes a declaration of the internal linkage (anonymous
namespace) type to be emitted in the type unit, which would then be
ambiguous as to which internal linkage definition it refers to (since
the name is only valid internally).
It's possible these internal linkage types could be resolved relative to
the unit the TU is referred to from - but that doesn't seem ideal, and
there's no reason to put the type in a type unit since it can only be
defined in one CU anyway (since otherwise it'd be an ODR violation) & so
avoiding the type unit should be a smaller DWARF encoding anyway.
This also addresses an issue with Simplified Template Names where the
template parameter could not be rebuilt from the declaration emitted
into the TU (specifically for an enum non-type template parameter, where
looking up the enumerators is necessary to rebuild the full template
name)
Kazu Hirata [Sun, 23 Jan 2022 22:00:03 +0000 (14:00 -0800)]
[Analysis] Remove a redundant const from a return type (NFC)
Identified with readability-const-return-type.
Kazu Hirata [Sun, 23 Jan 2022 22:00:01 +0000 (14:00 -0800)]
[Sema] Fix a bugprone argument comment (NFC)
Identified with bugprone-argument-comment.
Kazu Hirata [Sun, 23 Jan 2022 21:59:59 +0000 (13:59 -0800)]
[mlir] Ensure a newline at the end of a file (NFC)
Craig Topper [Sun, 23 Jan 2022 21:37:33 +0000 (13:37 -0800)]
[RISCV] Add tests that do a bitreverse before or after a bswap. NFC
We don't optimize this as well as we could. Bitreverse is always
expanded to bswap and a shift/and/or sequence to swap bits within a
byte. The newly created bswap will either becomes a shift/and/or
sequence or rev8 instruction. We don't always realize the bswap is
redundant with another bswap before or after the bitreverse.
Found while thinking about the brev8 instruction from the
Cryptography extension. It's equivalent to bswap(bitreverse(x)) or
bitreverse(bswap(x)).
Craig Topper [Sun, 23 Jan 2022 17:42:18 +0000 (09:42 -0800)]
[RISCV] Add bitreverse tests to bswap-ctlz-cttz-ctpop.ll. Add Zbb command lines. NFC
Rename to include bitreverse. Add additional tests and Zbb command lines.
There's some overlapping tests with rv32zbb.ll and rv64zbb.ll. Maybe
I'll clean that up in a future patch.
Simon Pilgrim [Sun, 23 Jan 2022 21:34:55 +0000 (21:34 +0000)]
[X86] LowerFunnelShift - always lower vXi8 fshl by constant amounts as unpack(y,x) << zext(z)
This can always be lowered as PMULLW+PSRLWI+PACKUSWB
Kazu Hirata [Sun, 23 Jan 2022 21:28:06 +0000 (13:28 -0800)]
[clang] Remove unused forward declarations (NFC)
Kazu Hirata [Sun, 23 Jan 2022 21:28:04 +0000 (13:28 -0800)]
[clang] Forward-declare DynTypedNode (NFC)
This patch adds a forward declaraiton of DynTypedNode.
DumpAST.h is relying on the forward declaration of DynTypedNode in
ASTContext.h, which is undesirable.
Kazu Hirata [Sun, 23 Jan 2022 21:28:02 +0000 (13:28 -0800)]
[clang] Move the definition of ASTDiff (NFC)
This patch moves the definition of ASTDiff later within the header
file.
Without this patch, the header depends on the forward decalrations of
SyntaxTree and ComparisonOptions from another header file, which is
not desirable. Since SyntaxTree and ComparisonOptions are defined in
ASTDiff.h, we can move the definition of ASTDiff later and stop
relying on the forward declarations from another header file.
Simon Pilgrim [Sun, 23 Jan 2022 21:13:58 +0000 (21:13 +0000)]
[X86] LowerFunnelShift - use supportedVectorShiftWithBaseAmnt to check for supported scalar shifts
Allows us to reuse the ISD shift opcode instead of a mixture of ISD/X86ISD variants
Craig Topper [Sun, 23 Jan 2022 17:42:18 +0000 (09:42 -0800)]
[RISCV] Adjust the header comment in RISCVInstrInfoZb.td to better integrate Zbk* extensions.
The Zbk* extensions have some overlap with Zb so have been placed in this file.
Reviewed By: VincentWu
Differential Revision: https://reviews.llvm.org/D117958
Groverkss [Sun, 23 Jan 2022 19:38:54 +0000 (01:08 +0530)]
[MLIR][Presburger] Clean PresburgerSet identifier interface to match IntegerPolyhedron's interface
This patch changes names of identifiers and their corresponding getters in
PresburgerSet to match those of IntegerPolyhedron.
Reviewed By: arjunp
Differential Revision: https://reviews.llvm.org/D117998
Kazu Hirata [Sun, 23 Jan 2022 19:07:16 +0000 (11:07 -0800)]
[Object] Remove a redundant return statement (NFC)
Identified with readability-redundant-control-flow.
Kazu Hirata [Sun, 23 Jan 2022 19:07:14 +0000 (11:07 -0800)]
[Commands] Remove redundant member initialization (NFC)
Identified with readability-redundant-member-init.
Kazu Hirata [Sun, 23 Jan 2022 19:07:12 +0000 (11:07 -0800)]
[llvm] Fix header guards (NFC)
Identified with llvm-header-guard.
Nuno Lopes [Sun, 23 Jan 2022 19:06:21 +0000 (19:06 +0000)]
[NewGVN][NFC] precommit tests for PR53277
Fangrui Song [Sun, 23 Jan 2022 18:35:44 +0000 (10:35 -0800)]
[Support] Simplify parallelForEach{,N}
* Merge parallel_for_each into parallelForEach (this removes 1 `Fn(...)` call)
* Change parallelForEach to use parallelForEachN
* Move parallelForEachN into Parallel.cpp
My x86-64 `lld` executable is 100KiB smaller.
No noticeable difference in performance.
Reviewed By: lattner
Differential Revision: https://reviews.llvm.org/D117510
Casey Carter [Thu, 30 Dec 2021 00:02:00 +0000 (16:02 -0800)]
[libcxx][test] Make MSVC `<charconv>` test compile when testing MSVC
<meme>How many layers of irony are you on?</meme>
Differential Revision: https://reviews.llvm.org/D117967
Simon Pilgrim [Sun, 23 Jan 2022 18:03:12 +0000 (18:03 +0000)]
[InstCombine] Add test coverage for PR48683
D108992 added self-multiply handling to KnownBits::mul but we don't use it yet..
Craig Topper [Sun, 23 Jan 2022 07:05:19 +0000 (23:05 -0800)]
[RISCV] Merge some rvv intrinsic test cases that only differ by XLen type.
Instead of having a test for i32 XLen and i64 XLen, use sed to
replace iXLen with i32/i64 before running llc.
This change covers all of the floating point tests.
Simon Pilgrim [Sun, 23 Jan 2022 16:36:18 +0000 (16:36 +0000)]
[DAG] Fold (X & Y) != 0 --> zextOrTrunc(X & Y) iff everything but LSB is known zero (PR51312)
Fixes parity codegen issue where we know all but the lowest bit is zero, we can replace the ICMPNE with 0 comparison with a ext/trunc
Differential Revision: https://reviews.llvm.org/D117983
LLVM GN Syncbot [Sun, 23 Jan 2022 16:30:34 +0000 (16:30 +0000)]
[gn build] Port
d2e8fb331835
Simon Pilgrim [Sun, 23 Jan 2022 16:28:38 +0000 (16:28 +0000)]
Revert rG7c66aaddb128dc0f342830c1efaeb7a278bfc48c "[DAG] Fold (X & Y) != 0 --> zextOrTrunc(X & Y) iff everything but LSB is known zero (PR51312)"
Noticed a typo in the getBooleanContents call just after I pressed commit :(
Richard [Sun, 2 Jan 2022 05:47:22 +0000 (22:47 -0700)]
[clang-tidy] Add readability-duplicate-include check
Looks for duplicate includes and removes them.
Every time an include directive is processed, check a vector of filenames
to see if the included file has already been included. If so, it issues
a warning and a replacement to remove the entire line containing the
duplicated include directive.
When a macro is defined or undefined, the vector of filenames is cleared.
This enables including the same file multiple times, but getting
different expansions based on the set of active macros at the time of
inclusion. For example:
#undef NDEBUG
#include "assertion.h"
// ...code with assertions enabled
#define NDEBUG
#include "assertion.h"
// ...code with assertions disabled
Since macros are redefined between the inclusion of assertion.h,
they are not flagged as redundant.
Differential Revision: https://reviews.llvm.org/D7982
Sanjay Patel [Sun, 23 Jan 2022 16:11:26 +0000 (11:11 -0500)]
[IR] document and update ctlz/cttz intrinsics to optionally return poison rather than undef
The behavior in Analysis (knownbits) implements poison semantics already,
and we expect the transforms (for example, in instcombine) derived from
those semantics, so this patch changes the LangRef and remaining code to
be consistent. This is one more step in removing "undef" from LLVM.
Without this, I think https://github.com/llvm/llvm-project/issues/53330
has a legitimate complaint because that report wants to allow subsequent
code to mask off bits, and that is allowed with undef values. The clang
builtins are not actually documented anywhere AFAICT, but we might want
to add that to remove more uncertainty.
Differential Revision: https://reviews.llvm.org/D117912
Simon Pilgrim [Sun, 23 Jan 2022 16:20:34 +0000 (16:20 +0000)]
[DAG] Fold (X & Y) != 0 --> zextOrTrunc(X & Y) iff everything but LSB is known zero (PR51312)
Fixes parity codegen issue where we know all but the lowest bit is zero, we can replace the ICMPNE with 0 comparison with a ext/trunc
Differential Revision: https://reviews.llvm.org/D117983
Ayke van Laethem [Sun, 16 Jan 2022 07:42:48 +0000 (08:42 +0100)]
[AVR] Make use of the constant value 0 in R1
The register R1 is defined to have the constant value 0 in the avr-gcc
calling convention (which we follow). Unfortunately, we don't really
make use of it. This patch replaces `LDI 0` instructions with a copy
from R1.
This reduces code size: my AVR build of compiler-rt goes from 50660 to
50240 bytes of code size, which is a 0.8% reduction. Presumably it will
also improve execution speed, although I didn't measure this.
Differential Revision: https://reviews.llvm.org/D117425
Ayke van Laethem [Thu, 20 Jan 2022 20:50:26 +0000 (21:50 +0100)]
[AVR] Remove regalloc workaround for LDDWRdPtrQ
Background: https://github.com/avr-rust/rust-legacy-fork/issues/126
In short, this workaround was introduced to fix a "ran out of registers
during regalloc" issue. The root cause has since been fixed in
https://reviews.llvm.org/D54218 so this workaround can be removed.
There is one test that changes a little bit, removing a single
instruction. I also compiled compiler-rt before and after this patch but
didn't see a difference. So presumably the impact is very low. Still,
it's nice to be able to remove such a workaround.
Differential Revision: https://reviews.llvm.org/D117831
Carlos Galvez [Fri, 21 Jan 2022 07:59:27 +0000 (07:59 +0000)]
[clang-tidy] Remove gsl::at suggestion from cppcoreguidelines-pro-bounds-constant-array-index
Currently the fix hint is hardcoded to gsl::at(). This poses
a problem for people who, for a number of reasons, don't want
or cannot use the GSL library (introducing a new third-party
dependency into a project is not a minor task).
In these situations, the fix hint does more harm than good
as it creates confusion as to what the fix should be. People
can even misinterpret the fix "gsl::at" as e.g. "std::array::at",
which can lead to even more trouble (e.g. when having guidelines
that disallow exceptions).
Furthermore, this is not a requirement from the C++ Core Guidelines.
simply that array indexing needs to be safe. Each project should
be able to decide upon a strategy for safe indexing.
The fix-it is kept for people who want to use the GSL library.
Differential Revision: https://reviews.llvm.org/D117857
Simon Pilgrim [Sun, 23 Jan 2022 15:34:41 +0000 (15:34 +0000)]
[X86] Add vector signbit parity checks for non-popcnt targets
Noticed while looking at D117983 - we miss some parity patterns with/without popcnt
Arthur O'Dwyer [Sat, 22 Jan 2022 20:24:53 +0000 (15:24 -0500)]
[libc++] Fix LWG3437 "__cpp_lib_polymorphic_allocator is in the wrong header"
https://cplusplus.github.io/LWG/issue3437
Differential Revision: https://reviews.llvm.org/D117963
Arthur O'Dwyer [Sat, 22 Jan 2022 18:06:05 +0000 (13:06 -0500)]
[libc++] Mark LWG3541 as "Complete". NFC.
Differential Revision: https://reviews.llvm.org/D117956
Simon Pilgrim [Sun, 23 Jan 2022 15:14:10 +0000 (15:14 +0000)]
Fix "not all control paths return a value" warning. NFC.
Simon Pilgrim [Sun, 23 Jan 2022 15:12:44 +0000 (15:12 +0000)]
[lldb] TerminalState::Save - fix unused variable warning
Non-POSIX target builds don't use the file descriptor
Simon Pilgrim [Sun, 23 Jan 2022 15:11:08 +0000 (15:11 +0000)]
[lldb] PdbAstBuilder - use cast<> instead of dyn_cast<> to avoid dereference of nullptr
The pointers are dereferenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Sun, 23 Jan 2022 15:10:33 +0000 (15:10 +0000)]
[lldb] CxxModuleHandler - use cast<> instead of dyn_cast<> to avoid dereference of nullptr
The pointer is dereferenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Sun, 23 Jan 2022 13:24:36 +0000 (13:24 +0000)]
[clangd] Use castAs<> instead of getAs<> to avoid dereference of nullptr
The pointer is dereferenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Sun, 23 Jan 2022 12:57:12 +0000 (12:57 +0000)]
[clang-tidy] Use cast<>/castAs<> instead of dyn_cast<>/getAs<> to avoid dereference of nullptr
The pointer is dereferenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Sun, 23 Jan 2022 12:50:12 +0000 (12:50 +0000)]
[llvm-objdump] Use cast<> instead of dyn_cast<> to avoid dereference of nullptr
The pointer is dereferenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Sun, 23 Jan 2022 12:47:52 +0000 (12:47 +0000)]
[CodeGenPrepare] Use dyn_cast result to check for null pointers
Simplifies logic and helps the static analyzer correctly check for nullptr dereferences
Simon Pilgrim [Sun, 23 Jan 2022 12:45:12 +0000 (12:45 +0000)]
[llvm-objdump] Use cast<> instead of dyn_cast<> to avoid dereference of nullptr
The pointers are always dereferenced immediately, so assert the cast is correct instead of returning nullptr
Simon Pilgrim [Sun, 23 Jan 2022 11:34:25 +0000 (11:34 +0000)]
[X86] Regenerate avx512-mask-op.ll
Noticed on D86578 - several of the test cases were missing checks as they didn't start on a newline so the update script couldn't see them
Alex Brachet [Sun, 23 Jan 2022 09:44:09 +0000 (09:44 +0000)]
[llvm-objcopy][MachO] Implement --update-section
Implements `--update-section` which is currently supported for ELF for Mach-O as well
Reviewed By: alexander-shaposhnikov
Differential Revision: https://reviews.llvm.org/D117281
Craig Topper [Sat, 22 Jan 2022 21:41:30 +0000 (13:41 -0800)]
[RISCV] Use FP ABI for some RVV intrinsic tests. NFC
Removes moves from GPR to FPR and improves f64 tests on RV32.
Differential Revision: https://reviews.llvm.org/D117969
Craig Topper [Sat, 22 Jan 2022 20:10:57 +0000 (12:10 -0800)]
[RISCV] Merge some rvv intrinsic test cases that only differ by XLen type.
Instead of having a test for i32 XLen and i64 XLen, use sed to
replace iXLen with i32/i64 before running llc.
This change updates tests for intrinsics that operate exclusively
on mask values. It removes over 4000 lines worth of test content.
More merging will come in future changes.
Differential Revision: https://reviews.llvm.org/D117968
eopXD [Fri, 21 Jan 2022 08:39:23 +0000 (00:39 -0800)]
[RISCV] Remove experimental prefix from rvv-related extensions.
Extensions affected: +v, +zve*, +zvl*
Reviewed By: craig.topper
Differential Revision: https://reviews.llvm.org/D117860
Joe Loser [Wed, 19 Jan 2022 20:16:15 +0000 (15:16 -0500)]
[libc++] Implement LWG3549: view_interface need not inherit from view_base
Implement LWG3549 by making `view_interface` not inherit from `view_base`. Types
are still views if they have a public and unambiguous derivation from
`view_interface`, so adjust the `enable_view` machinery as such to account for
that.
Differential Revision: https://reviews.llvm.org/D117714
Phoebe Wang [Sun, 23 Jan 2022 01:14:58 +0000 (09:14 +0800)]
[X86][MS] Change the alignment of f80 to 16 bytes on Windows 32bits to match with ICC
MSVC currently doesn't support 80 bits long double. ICC supports it when
the option `/Qlong-double` is specified. Changing the alignment of f80
to 16 bytes so that we can be compatible with ICC's option.
Reviewed By: rnk, craig.topper
Differential Revision: https://reviews.llvm.org/D115942
Dave [Sun, 23 Jan 2022 01:30:27 +0000 (17:30 -0800)]
[docs] [clang] Small documentation change for compilation databases
We have an page dedicated to compliation databases including
various ways to generate them, but we don't mention that clang
has a built in method to do this. This addresses that.
Reviewed By: joerg
Differential Revision: https://reviews.llvm.org/D116882
Malhar Jajoo [Sat, 22 Jan 2022 22:05:38 +0000 (22:05 +0000)]
[openmp] Allow x87 fp functions only in Openmp runtime for x86.
This patch allows Openmp runtime atomic functions operating on x87 high-precision
to be present only in Openmp runtime for x86 architectures
The functions affected are:
__kmpc_atomic_10
__kmpc_atomic_20
__kmpc_atomic_cmplx10_add
__kmpc_atomic_cmplx10_div
__kmpc_atomic_cmplx10_mul
__kmpc_atomic_cmplx10_sub
__kmpc_atomic_float10_add
__kmpc_atomic_float10_div
__kmpc_atomic_float10_mul
__kmpc_atomic_float10_sub
__kmpc_atomic_float10_add_fp
__kmpc_atomic_float10_div_fp
__kmpc_atomic_float10_mul_fp
__kmpc_atomic_float10_sub_fp
__kmpc_atomic_float10_max
__kmpc_atomic_float10_min
Differential Revision: https://reviews.llvm.org/D117473
John Ericson [Sun, 16 Jan 2022 05:52:22 +0000 (05:52 +0000)]
[clang-tools-extra][cmake] Use `GNUInstallDirs` to support custom installation dirs.
This is the original patch in my GNUInstallDirs series, now last to merge as the final piece!
It arose as a new draft of D28234. I initially did the unorthodox thing of pushing to that when I wasn't the original author, but since I ended up
- Using `GNUInstallDirs`, rather than mimicking it, as the original author was hesitant to do but others requested.
- Converting all the packages, not just LLVM, effecting many more projects than LLVM itself.
I figured it was time to make a new revision.
I have used this patch series (and many back-ports) as the basis of https://github.com/NixOS/nixpkgs/pull/111487 for my distro (NixOS), which was merged last spring (2021). It looked like people were generally on board in D28234, but I make note of this here in case extra motivation is useful.
---
As pointed out in the original issue, a central tension is that LLVM already has some partial support for these sorts of things. Variables like `COMPILER_RT_INSTALL_PATH` have already been dealt with. Variables like `LLVM_LIBDIR_SUFFIX` however, will require further work, so that we may use `CMAKE_INSTALL_LIBDIR`.
These remaining items will be addressed in further patches. What is here is now rote and so we should get it out of the way before dealing more intricately with the remainder.
Reviewed By: #libunwind, #libc, #libc_abi, compnerd
Differential Revision: https://reviews.llvm.org/D99484
Sanjay Patel [Sat, 22 Jan 2022 17:36:12 +0000 (12:36 -0500)]
[InstCombine] try to fold binop with phi operands
This is an alternate version of D115914 that handles/tests all binary opcodes.
I suspect that we don't see these patterns too often because -simplifycfg
would convert the minimal cases into selects rather than leave them in phi form
(note: instcombine has logic holes for combining the select patterns too though,
so that's another potential patch).
We only create a new binop in a predecessor that unconditionally branches to
the final block.
https://alive2.llvm.org/ce/z/C57M2F
https://alive2.llvm.org/ce/z/WHwAoU (not safe to speculate an sdiv for example)
https://alive2.llvm.org/ce/z/rdVUvW (but it is ok on this path)
Differential Revision: https://reviews.llvm.org/D117110
Craig Topper [Sat, 22 Jan 2022 19:55:13 +0000 (11:55 -0800)]
[RISCV] Don't Custom legalize f16/f32/f64 bitcasts if those types aren't Legal.
John Ericson [Sat, 22 Jan 2022 06:33:49 +0000 (01:33 -0500)]
[openmp][cmake] Use `GNUInstallDirs` to support custom installation dirs
I am breaking apart D99484 so the cause of build failures is easier to
understand.
Differential Revision: https://reviews.llvm.org/D117945