platform/upstream/libSkiaSharp.git
11 years agoAdd NOOP "command" to picture format
robertphillips@google.com [Fri, 15 Feb 2013 17:19:15 +0000 (17:19 +0000)]
Add NOOP "command" to picture format

https://codereview.appspot.com/7343044/

git-svn-id: http://skia.googlecode.com/svn/trunk@7752 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agobench_graph_svg self-test: add non-tile bench data
epoger@google.com [Fri, 15 Feb 2013 16:42:21 +0000 (16:42 +0000)]
bench_graph_svg self-test: add non-tile bench data
TBR=benchen
Review URL: https://codereview.appspot.com/7317048

git-svn-id: http://skia.googlecode.com/svn/trunk@7750 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotools/tests/run.sh: download test bench data from Google Storage rather than SVN
epoger@google.com [Fri, 15 Feb 2013 15:50:23 +0000 (15:50 +0000)]
tools/tests/run.sh: download test bench data from Google Storage rather than SVN
Review URL: https://codereview.appspot.com/7343045

git-svn-id: http://skia.googlecode.com/svn/trunk@7749 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for skp chunk sizes when clips are used outside of any save
robertphillips@google.com [Fri, 15 Feb 2013 15:13:27 +0000 (15:13 +0000)]
Fix for skp chunk sizes when clips are used outside of any save

https://codereview.appspot.com/7342047/

git-svn-id: http://skia.googlecode.com/svn/trunk@7748 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNow store chunk size in skp file format
robertphillips@google.com [Fri, 15 Feb 2013 13:47:37 +0000 (13:47 +0000)]
Now store chunk size in skp file format

https://codereview.appspot.com/7308087/

git-svn-id: http://skia.googlecode.com/svn/trunk@7747 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 15 Feb 2013 07:16:57 +0000 (07:16 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7746 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agobench_graph_svg: more sorting to get deterministic results
epoger@google.com [Thu, 14 Feb 2013 20:13:32 +0000 (20:13 +0000)]
bench_graph_svg: more sorting to get deterministic results
TBR=benchen
Review URL: https://codereview.appspot.com/7333045

git-svn-id: http://skia.googlecode.com/svn/trunk@7745 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agobench_graph_svg: generate output in consistently sorted order, to make diffs more...
epoger@google.com [Thu, 14 Feb 2013 18:58:05 +0000 (18:58 +0000)]
bench_graph_svg: generate output in consistently sorted order, to make diffs more useful
TBR=benchen
Review URL: https://codereview.appspot.com/7330044

git-svn-id: http://skia.googlecode.com/svn/trunk@7744 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodebug dump functions for mathematica visualization
humper@google.com [Thu, 14 Feb 2013 18:57:59 +0000 (18:57 +0000)]
debug dump functions for mathematica visualization

BUG=

Review URL: https://codereview.appspot.com/7322078

git-svn-id: http://skia.googlecode.com/svn/trunk@7743 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoprint a useful message when assert fails on the mac
humper@google.com [Thu, 14 Feb 2013 18:56:22 +0000 (18:56 +0000)]
print a useful message when assert fails on the mac

BUG=

Review URL: https://codereview.appspot.com/7314100

git-svn-id: http://skia.googlecode.com/svn/trunk@7742 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotry precompiling regexps to speed up bench_graph_svg.py
epoger@google.com [Thu, 14 Feb 2013 18:35:17 +0000 (18:35 +0000)]
try precompiling regexps to speed up bench_graph_svg.py
Review URL: https://codereview.appspot.com/7336043

git-svn-id: http://skia.googlecode.com/svn/trunk@7741 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodisable new bench_graph_svg test in tools/tests/run.sh that fails on housekeeper
epoger@google.com [Thu, 14 Feb 2013 15:35:23 +0000 (15:35 +0000)]
disable new bench_graph_svg test in tools/tests/run.sh that fails on housekeeper
TBR=bensong
Review URL: https://codereview.appspot.com/7303092

git-svn-id: http://skia.googlecode.com/svn/trunk@7739 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Thu, 14 Feb 2013 15:29:11 +0000 (15:29 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7738 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove unused texture coordinate flags.
jvanverth@google.com [Thu, 14 Feb 2013 15:25:44 +0000 (15:25 +0000)]
Remove unused texture coordinate flags.

Currently we support 5 texture stages, each with 5 possible texture coordinate attributes.
However, we only ever use one explicit texture coordinate. This change removes all but one
(now named just "aTexCoord") of the possible explicit texture coordinates.

Review URL: https://codereview.appspot.com/7308094/

git-svn-id: http://skia.googlecode.com/svn/trunk@7737 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse CGL rather than AGL on the Mac.
bsalomon@google.com [Thu, 14 Feb 2013 15:10:59 +0000 (15:10 +0000)]
Use CGL rather than AGL on the Mac.
Review URL: https://codereview.appspot.com/7307106

git-svn-id: http://skia.googlecode.com/svn/trunk@7736 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotools/tests/run.sh: add self-test for bench_graph_svg.py
epoger@google.com [Thu, 14 Feb 2013 15:10:24 +0000 (15:10 +0000)]
tools/tests/run.sh: add self-test for bench_graph_svg.py
Review URL: https://codereview.appspot.com/7319044

git-svn-id: http://skia.googlecode.com/svn/trunk@7735 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdded SK_DEVELOPER wrapper's around toString calls in debugger's SkObjectParser
robertphillips@google.com [Thu, 14 Feb 2013 14:40:27 +0000 (14:40 +0000)]
Added SK_DEVELOPER wrapper's around toString calls in debugger's SkObjectParser

unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@7733 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove SkPaint::toString from debugger to SkPaint
robertphillips@google.com [Thu, 14 Feb 2013 13:53:53 +0000 (13:53 +0000)]
Move SkPaint::toString from debugger to SkPaint

https://codereview.appspot.com/7314092/

git-svn-id: http://skia.googlecode.com/svn/trunk@7732 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for Gorilla test
jvanverth@google.com [Thu, 14 Feb 2013 13:20:35 +0000 (13:20 +0000)]
Fix for Gorilla test

My implementation of the Gorilla random number test had a bug in the code used
to track the random strings -- it was masking 6 bits instead of 5, which was
throwing off the counts. No idea how this worked on every platform except
Android.

git-svn-id: http://skia.googlecode.com/svn/trunk@7731 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Thu, 14 Feb 2013 07:01:34 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7730 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoScript to plot tile vs. viewport comparison for given platform and revision.
bensong@google.com [Wed, 13 Feb 2013 23:22:29 +0000 (23:22 +0000)]
Script to plot tile vs. viewport comparison for given platform and revision.
Currently viewport bot data are only available for Android bots.
Please go to http://go/skia-buildbot to pick a green revision (-r) for an Android platform (-p). This can take a few minutes because Google Storage stores files in a flat structure instead of in directories.
Alternatively, download the bot data of interest into a local directory (or generate them from your machine) and set the script to read from there (-d).
Review URL: https://codereview.appspot.com/7093065

git-svn-id: http://skia.googlecode.com/svn/trunk@7729 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd animated line chart sample
bsalomon@google.com [Wed, 13 Feb 2013 21:22:13 +0000 (21:22 +0000)]
Add animated line chart sample

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7307117

git-svn-id: http://skia.googlecode.com/svn/trunk@7727 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove checked-in moc_* files
borenet@google.com [Wed, 13 Feb 2013 21:06:01 +0000 (21:06 +0000)]
Remove checked-in moc_* files

No longer needed since we generate these at build time.
Review URL: https://codereview.appspot.com/7322073

git-svn-id: http://skia.googlecode.com/svn/trunk@7726 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix moc generation with SK_SUPPORT_GPU defined
robertphillips@google.com [Wed, 13 Feb 2013 20:12:21 +0000 (20:12 +0000)]
Fix moc generation with SK_SUPPORT_GPU defined

https://codereview.appspot.com/7305088/

git-svn-id: http://skia.googlecode.com/svn/trunk@7725 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm: Add ability to compare against checksums (as opposed to image files)
epoger@google.com [Wed, 13 Feb 2013 18:14:48 +0000 (18:14 +0000)]
gm: Add ability to compare against checksums (as opposed to image files)
Review URL: https://codereview.appspot.com/7306071

git-svn-id: http://skia.googlecode.com/svn/trunk@7724 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse SkMWRandom in GLPrograms test.
bsalomon@google.com [Wed, 13 Feb 2013 16:31:19 +0000 (16:31 +0000)]
Use SkMWRandom in GLPrograms test.

R=jvanverth@google.com
Review URL: https://codereview.appspot.com/7306097

git-svn-id: http://skia.googlecode.com/svn/trunk@7721 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agor7719 was an exact reland of r7713. This CL is fix.
bsalomon@google.com [Wed, 13 Feb 2013 16:13:13 +0000 (16:13 +0000)]
r7719 was an exact reland of r7713. This CL is fix.

git-svn-id: http://skia.googlecode.com/svn/trunk@7720 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAttempt to reland r7713 with fix.
bsalomon@google.com [Wed, 13 Feb 2013 16:03:51 +0000 (16:03 +0000)]
Attempt to reland r7713 with fix.

git-svn-id: http://skia.googlecode.com/svn/trunk@7719 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r7713 until GM changes are understood.
bsalomon@google.com [Wed, 13 Feb 2013 15:54:38 +0000 (15:54 +0000)]
Revert r7713 until GM changes are understood.

git-svn-id: http://skia.googlecode.com/svn/trunk@7718 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove view matrix flush to GrGLPrograms.
bsalomon@google.com [Wed, 13 Feb 2013 13:53:29 +0000 (13:53 +0000)]
Move view matrix flush to GrGLPrograms.
Review URL: https://codereview.appspot.com/7322064

git-svn-id: http://skia.googlecode.com/svn/trunk@7713 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix filter optimizations to take the paint's alpha into account
robertphillips@google.com [Wed, 13 Feb 2013 13:27:44 +0000 (13:27 +0000)]
Fix filter optimizations to take the paint's alpha into account

https://codereview.appspot.com/7312083/

git-svn-id: http://skia.googlecode.com/svn/trunk@7711 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAllow debugger to be compiled without Ganesh
robertphillips@google.com [Wed, 13 Feb 2013 13:26:13 +0000 (13:26 +0000)]
Allow debugger to be compiled without Ganesh

https://codereview.appspot.com/7311084/

git-svn-id: http://skia.googlecode.com/svn/trunk@7710 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove code that builds GrGLProgram::Desc to GrGLProgram. Move color and coverage flush...
bsalomon@google.com [Tue, 12 Feb 2013 21:45:24 +0000 (21:45 +0000)]
Move code that builds GrGLProgram::Desc to GrGLProgram. Move color and coverage flush to GrGLProgram.
Review URL: https://codereview.appspot.com/7322058

git-svn-id: http://skia.googlecode.com/svn/trunk@7708 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove blend optimization functions to GrDrawState.
bsalomon@google.com [Tue, 12 Feb 2013 16:47:41 +0000 (16:47 +0000)]
Move blend optimization functions to GrDrawState.
Review URL: https://codereview.appspot.com/7300089

git-svn-id: http://skia.googlecode.com/svn/trunk@7703 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocall through to to the virtual drawPath from drawOval, for subclasses (e.g. pdf)
reed@google.com [Tue, 12 Feb 2013 15:44:10 +0000 (15:44 +0000)]
call through to to the virtual drawPath from drawOval, for subclasses (e.g. pdf)
that don't choose to override drawOval.

git-svn-id: http://skia.googlecode.com/svn/trunk@7701 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd custom implementation for drawBitmapRect to shield from changes in SkDevice
edisonn@google.com [Tue, 12 Feb 2013 01:06:38 +0000 (01:06 +0000)]
add custom implementation for drawBitmapRect to shield from changes in SkDevice

git-svn-id: http://skia.googlecode.com/svn/trunk@7696 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomirror of https://codereview.appspot.com/7312060/
reed@google.com [Mon, 11 Feb 2013 19:56:20 +0000 (19:56 +0000)]
mirror of https://codereview.appspot.com/7312060/

git-svn-id: http://skia.googlecode.com/svn/trunk@7694 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTurn off per-iteration tile time reporting
borenet@google.com [Mon, 11 Feb 2013 18:42:43 +0000 (18:42 +0000)]
Turn off per-iteration tile time reporting

It's overloading the bench graph generator.
Review URL: https://codereview.appspot.com/7300088

git-svn-id: http://skia.googlecode.com/svn/trunk@7691 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Sat, 9 Feb 2013 07:05:02 +0000 (07:05 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7688 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoArgv[0] isn't the first argument to anything.
reed@google.com [Fri, 8 Feb 2013 22:45:11 +0000 (22:45 +0000)]
Argv[0] isn't the first argument to anything.

git-svn-id: http://skia.googlecode.com/svn/trunk@7687 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding comments based on review https://codereview.appspot.com/7300072/
junov@chromium.org [Fri, 8 Feb 2013 21:56:16 +0000 (21:56 +0000)]
Adding comments based on review https://codereview.appspot.com/7300072/

git-svn-id: http://skia.googlecode.com/svn/trunk@7686 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCorrect default value for GR_STATIC_RECT_VB
bsalomon@google.com [Fri, 8 Feb 2013 21:45:47 +0000 (21:45 +0000)]
Correct default value for GR_STATIC_RECT_VB

git-svn-id: http://skia.googlecode.com/svn/trunk@7685 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomatch chromium's approach for locating the most appropriate macos SDK to use
humper@google.com [Fri, 8 Feb 2013 21:45:33 +0000 (21:45 +0000)]
match chromium's approach for locating the most appropriate macos SDK to use

By doing this, the ninja generator for gyp works great on macos, resulting in faster (I think) and much, much terser builds.

BUG=

Review URL: https://codereview.appspot.com/7142047

git-svn-id: http://skia.googlecode.com/svn/trunk@7684 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert 7625 until after M26 due to a mix of perf changes.
bsalomon@google.com [Fri, 8 Feb 2013 21:22:44 +0000 (21:22 +0000)]
Revert 7625 until after M26 due to a mix of perf changes.

git-svn-id: http://skia.googlecode.com/svn/trunk@7683 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix uninitialized Render Target origin issue in debugger
robertphillips@google.com [Fri, 8 Feb 2013 21:22:09 +0000 (21:22 +0000)]
Fix uninitialized Render Target origin issue in debugger

https://codereview.appspot.com/7314066/

git-svn-id: http://skia.googlecode.com/svn/trunk@7682 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoClean up some out of order initialization warnings.
scroggo@google.com [Fri, 8 Feb 2013 21:16:19 +0000 (21:16 +0000)]
Clean up some out of order initialization warnings.

Review URL: https://codereview.appspot.com/7321043

git-svn-id: http://skia.googlecode.com/svn/trunk@7681 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding option to SkTileGrid for specifying border pixels.
junov@chromium.org [Fri, 8 Feb 2013 21:03:30 +0000 (21:03 +0000)]
Adding option to SkTileGrid for specifying border pixels.

The purpose of this patch is to make it possible for the chromium compositor to
generate a TileGrid structure that is better suited for scaled playback.
Review URL: https://codereview.appspot.com/7300072

git-svn-id: http://skia.googlecode.com/svn/trunk@7680 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRe-enabled performance checking on Windows
robertphillips@google.com [Fri, 8 Feb 2013 20:09:56 +0000 (20:09 +0000)]
Re-enabled performance checking on Windows

https://codereview.appspot.com/7309065/

git-svn-id: http://skia.googlecode.com/svn/trunk@7679 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOptimize building gradient cache for when we know alpha is always 0xFF.
reed@google.com [Fri, 8 Feb 2013 19:48:12 +0000 (19:48 +0000)]
Optimize building gradient cache for when we know alpha is always 0xFF.
remove old build guard for dithering.
Review URL: https://codereview.appspot.com/7309064

git-svn-id: http://skia.googlecode.com/svn/trunk@7678 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd support for using ANGLE in bench_pictures.
scroggo@google.com [Fri, 8 Feb 2013 19:38:21 +0000 (19:38 +0000)]
Add support for using ANGLE in bench_pictures.

BUG=https://code.google.com/p/skia/issues/detail?id=1012

Other cleanups:
Remove setDeviceType from PictureBenchmark, since it is unnecessary.
Dereference PictureRenderer::fGrContext when done with it.
Make PictureRenderer::fGrContext and PictureRenderer::fGrContextFactory private, since they are not used by subclasses.

Review URL: https://codereview.appspot.com/7314063

git-svn-id: http://skia.googlecode.com/svn/trunk@7677 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemoves redundant and wrong check.
bensong@google.com [Fri, 8 Feb 2013 19:02:21 +0000 (19:02 +0000)]
Removes redundant and wrong check.
Review URL: https://codereview.appspot.com/7308072

git-svn-id: http://skia.googlecode.com/svn/trunk@7676 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixes indentation error.
bensong@google.com [Fri, 8 Feb 2013 18:53:24 +0000 (18:53 +0000)]
Fixes indentation error.
Review URL: https://codereview.appspot.com/7307077

git-svn-id: http://skia.googlecode.com/svn/trunk@7674 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixes a bug that didn't address new perfdata location.
bensong@google.com [Fri, 8 Feb 2013 18:47:02 +0000 (18:47 +0000)]
Fixes a bug that didn't address new perfdata location.
Review URL: https://codereview.appspot.com/7299070

git-svn-id: http://skia.googlecode.com/svn/trunk@7673 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agofix build on Macos
humper@google.com [Fri, 8 Feb 2013 18:44:27 +0000 (18:44 +0000)]
fix build on Macos

BUG=

Review URL: https://codereview.appspot.com/7320043

git-svn-id: http://skia.googlecode.com/svn/trunk@7672 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for Mac compile warnings. Temporarily removed random gorilla test.
jvanverth@google.com [Fri, 8 Feb 2013 18:28:47 +0000 (18:28 +0000)]
Fix for Mac compile warnings. Temporarily removed random gorilla test.

Unreviewed

git-svn-id: http://skia.googlecode.com/svn/trunk@7671 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd Random unit tests.
jvanverth@google.com [Fri, 8 Feb 2013 17:13:09 +0000 (17:13 +0000)]
Add Random unit tests.

https://codereview.appspot.com/7306066/

git-svn-id: http://skia.googlecode.com/svn/trunk@7670 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd .swp files to gitignore.
scroggo@google.com [Fri, 8 Feb 2013 16:59:59 +0000 (16:59 +0000)]
Add .swp files to gitignore.

Make git ignore .swp files (generated while editing in vim).

Review URL: https://codereview.appspot.com/7309059

git-svn-id: http://skia.googlecode.com/svn/trunk@7669 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a bench for SkBicubicImageFilter.
senorblanco@chromium.org [Fri, 8 Feb 2013 16:40:14 +0000 (16:40 +0000)]
Add a bench for SkBicubicImageFilter.

Review URL: https://codereview.appspot.com/7312056

git-svn-id: http://skia.googlecode.com/svn/trunk@7668 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Fri, 8 Feb 2013 07:16:45 +0000 (07:16 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7659 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove compile time option to use different types for text vertices.
bsalomon@google.com [Thu, 7 Feb 2013 22:00:29 +0000 (22:00 +0000)]
Remove compile time option to use different types for text vertices.
Review URL: https://codereview.appspot.com/7309060

git-svn-id: http://skia.googlecode.com/svn/trunk@7658 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTemporarily disable new GL error checking in ~SkGLContext
robertphillips@google.com [Thu, 7 Feb 2013 21:16:41 +0000 (21:16 +0000)]
Temporarily disable new GL error checking in ~SkGLContext

https://codereview.appspot.com/7308064/

git-svn-id: http://skia.googlecode.com/svn/trunk@7657 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GR_DISABLE_DRAW_BUFFERING, replace with RTConf variable.
bsalomon@google.com [Thu, 7 Feb 2013 21:02:36 +0000 (21:02 +0000)]
Remove GR_DISABLE_DRAW_BUFFERING, replace with RTConf variable.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7312061

git-svn-id: http://skia.googlecode.com/svn/trunk@7656 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAddress google3 compiler warning
robertphillips@google.com [Thu, 7 Feb 2013 21:02:23 +0000 (21:02 +0000)]
Address google3 compiler warning

https://codereview.appspot.com/7308063/

git-svn-id: http://skia.googlecode.com/svn/trunk@7655 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCleanup debugger's handling of bad input files
robertphillips@google.com [Thu, 7 Feb 2013 20:39:40 +0000 (20:39 +0000)]
Cleanup debugger's handling of bad input files

https://codereview.appspot.com/7308062/

git-svn-id: http://skia.googlecode.com/svn/trunk@7654 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoonly take the vertical special-case for gradients when dx is exactly 0, as a
reed@google.com [Thu, 7 Feb 2013 20:28:49 +0000 (20:28 +0000)]
only take the vertical special-case for gradients when dx is exactly 0, as a
zoomed gradient can have a very small dx, but be no where near to vertical.

http://code.google.com/p/skia/issues/detail?id=1101
Review URL: https://codereview.appspot.com/7310059

git-svn-id: http://skia.googlecode.com/svn/trunk@7653 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GR_DUMP_TEXTURE_UPLOADS
bsalomon@google.com [Thu, 7 Feb 2013 20:21:39 +0000 (20:21 +0000)]
Remove GR_DUMP_TEXTURE_UPLOADS

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7300062

git-svn-id: http://skia.googlecode.com/svn/trunk@7652 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoOnly turn on one gpu timer in PictureBenchmark tool
robertphillips@google.com [Thu, 7 Feb 2013 20:20:27 +0000 (20:20 +0000)]
Only turn on one gpu timer in PictureBenchmark tool

https://codereview.appspot.com/7310060/

git-svn-id: http://skia.googlecode.com/svn/trunk@7651 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GR_AGGRESSIVE_SHADER_OPTS build option.
bsalomon@google.com [Thu, 7 Feb 2013 19:53:49 +0000 (19:53 +0000)]
Remove GR_AGGRESSIVE_SHADER_OPTS build option.

R=robertphillips@google.com
Review URL: https://codereview.appspot.com/7312058

git-svn-id: http://skia.googlecode.com/svn/trunk@7650 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse SkBits2Float in SkRandom
bsalomon@google.com [Thu, 7 Feb 2013 19:52:30 +0000 (19:52 +0000)]
Use SkBits2Float in SkRandom

https://codereview.appspot.com/7266044/

git-svn-id: http://skia.googlecode.com/svn/trunk@7648 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoEnhance GL error checking for non-Ganesh GL calls
robertphillips@google.com [Thu, 7 Feb 2013 19:45:46 +0000 (19:45 +0000)]
Enhance GL error checking for non-Ganesh GL calls

https://codereview.appspot.com/7312057/

git-svn-id: http://skia.googlecode.com/svn/trunk@7647 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix errors when compiling with -Wall -Werror on Android.
djsollen@google.com [Thu, 7 Feb 2013 18:58:35 +0000 (18:58 +0000)]
Fix errors when compiling with -Wall -Werror on Android.

This CL also turns those features on by default on Android

Review URL: https://codereview.appspot.com/7313049

git-svn-id: http://skia.googlecode.com/svn/trunk@7645 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore fixes for ios build.
bsalomon@google.com [Thu, 7 Feb 2013 17:01:39 +0000 (17:01 +0000)]
More fixes for ios build.

git-svn-id: http://skia.googlecode.com/svn/trunk@7643 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAttempt to fix iOS build.
bsalomon@google.com [Thu, 7 Feb 2013 16:23:58 +0000 (16:23 +0000)]
Attempt to fix iOS build.

git-svn-id: http://skia.googlecode.com/svn/trunk@7642 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTemporary patch to BenchPictures gpu timing problem
robertphillips@google.com [Thu, 7 Feb 2013 16:21:22 +0000 (16:21 +0000)]
Temporary patch to BenchPictures gpu timing problem

https://codereview.appspot.com/7311059/

git-svn-id: http://skia.googlecode.com/svn/trunk@7641 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove legacy names no longer referenced in Chrome and WebKit.
bsalomon@google.com [Thu, 7 Feb 2013 14:43:04 +0000 (14:43 +0000)]
Remove legacy names no longer referenced in Chrome and WebKit.
Review URL: https://codereview.appspot.com/7311055

git-svn-id: http://skia.googlecode.com/svn/trunk@7640 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoshape ops work in progress
caryclark@google.com [Thu, 7 Feb 2013 13:13:41 +0000 (13:13 +0000)]
shape ops work in progress

git-svn-id: http://skia.googlecode.com/svn/trunk@7637 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix a perf regression introduced by r7594: when computing a texture cache key, use...
senorblanco@chromium.org [Thu, 7 Feb 2013 00:35:25 +0000 (00:35 +0000)]
Fix a perf regression introduced by r7594:  when computing a texture cache key, use the resolved (Top or Bottom) surface origin, never Default, otherwise we never get a cache hit.

Covered by polygon, path benches.  See also:  https://code.google.com/p/chromium/issues/detail?id=174749.

Review URL: https://codereview.appspot.com/7299059

git-svn-id: http://skia.googlecode.com/svn/trunk@7635 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixed warning/error in PictureRenderer.cpp
robertphillips@google.com [Thu, 7 Feb 2013 00:13:34 +0000 (00:13 +0000)]
Fixed warning/error in PictureRenderer.cpp

TBR by scroggo@google.com

git-svn-id: http://skia.googlecode.com/svn/trunk@7634 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIn picture rendering tools, draw the entire scaled image.
scroggo@google.com [Wed, 6 Feb 2013 22:32:57 +0000 (22:32 +0000)]
In picture rendering tools, draw the entire scaled image.

If --scale is used, limit the size of the image drawn to the
scaled picture size, rather than the original picture size.

BUG=https://code.google.com/p/skia/issues/detail?id=1095

Review URL: https://codereview.appspot.com/7307054

git-svn-id: http://skia.googlecode.com/svn/trunk@7633 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix function not predeclared warning on Mac.
bsalomon@google.com [Wed, 6 Feb 2013 21:44:21 +0000 (21:44 +0000)]
Fix function not predeclared warning on Mac.

TBR=robertphillips@google.com
Review URL: https://codereview.appspot.com/7314048

git-svn-id: http://skia.googlecode.com/svn/trunk@7632 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agorver r7626, might trigger for some strange reason a heap corruption
edisonn@google.com [Wed, 6 Feb 2013 21:42:34 +0000 (21:42 +0000)]
rver r7626, might trigger for some strange reason a heap corruption

git-svn-id: http://skia.googlecode.com/svn/trunk@7631 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixes a bug introduced by the new per-tile bench log format.
bensong@google.com [Wed, 6 Feb 2013 20:59:14 +0000 (20:59 +0000)]
Fixes a bug introduced by the new per-tile bench log format.
Review URL: https://codereview.appspot.com/7301056

git-svn-id: http://skia.googlecode.com/svn/trunk@7630 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdates gen_skp_ranges.py on recent changes of bench names, storage locations, etc.
bensong@google.com [Wed, 6 Feb 2013 20:51:55 +0000 (20:51 +0000)]
Updates gen_skp_ranges.py on recent changes of bench names, storage locations, etc.
Sample command: bench/gen_skp_ranges.py -r 7621:7621
It is slow due to cloud storage slowness. You can download the bench logs using gsutil and set the -d flag to make it super fast.
Review URL: https://codereview.appspot.com/7307052

git-svn-id: http://skia.googlecode.com/svn/trunk@7629 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for sign mismatch warning/error
robertphillips@google.com [Wed, 6 Feb 2013 20:42:14 +0000 (20:42 +0000)]
Fix for sign mismatch warning/error

git-svn-id: http://skia.googlecode.com/svn/trunk@7628 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd overdraw visualization to the debugger
robertphillips@google.com [Wed, 6 Feb 2013 20:13:54 +0000 (20:13 +0000)]
Add overdraw visualization to the debugger

https://codereview.appspot.com/7267043/

git-svn-id: http://skia.googlecode.com/svn/trunk@7627 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a true Set class. Current use case is to be used with Pdf generator.
edisonn@google.com [Wed, 6 Feb 2013 18:54:13 +0000 (18:54 +0000)]
Add a true Set class. Current use case is to be used with Pdf generator.
Review URL: https://codereview.appspot.com/6749054

git-svn-id: http://skia.googlecode.com/svn/trunk@7626 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove GR_STATIC_RECT_VB
bsalomon@google.com [Wed, 6 Feb 2013 18:53:12 +0000 (18:53 +0000)]
Remove GR_STATIC_RECT_VB
Review URL: https://codereview.appspot.com/7304055

git-svn-id: http://skia.googlecode.com/svn/trunk@7625 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agogm self-tests: generate JSON expectations, in addition to image expectations
epoger@google.com [Wed, 6 Feb 2013 18:41:04 +0000 (18:41 +0000)]
gm self-tests: generate JSON expectations, in addition to image expectations
Review URL: https://codereview.appspot.com/7310050

git-svn-id: http://skia.googlecode.com/svn/trunk@7624 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix WritePixels test on ANGLE.
bsalomon@google.com [Wed, 6 Feb 2013 18:17:50 +0000 (18:17 +0000)]
Fix WritePixels test on ANGLE.

Don't upload BGRA to RGBA if not supported (ES2 w/ EXT BGRA extension).

R=senorblanco@chromium.org
Review URL: https://codereview.appspot.com/7305046

git-svn-id: http://skia.googlecode.com/svn/trunk@7622 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTurn --timeIndividualTiles back on in bench_pictures
borenet@google.com [Wed, 6 Feb 2013 16:27:38 +0000 (16:27 +0000)]
Turn --timeIndividualTiles back on in bench_pictures
Review URL: https://codereview.appspot.com/7299049

git-svn-id: http://skia.googlecode.com/svn/trunk@7620 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to trigger builds after master restart
borenet@google.com [Wed, 6 Feb 2013 16:08:05 +0000 (16:08 +0000)]
Whitespace change to trigger builds after master restart

git-svn-id: http://skia.googlecode.com/svn/trunk@7618 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSet vertex layout prior to setVertexSourceToBuffer for GR_STATIC_RECT_VB
jvanverth@google.com [Wed, 6 Feb 2013 13:45:11 +0000 (13:45 +0000)]
Set vertex layout prior to setVertexSourceToBuffer for GR_STATIC_RECT_VB

git-svn-id: http://skia.googlecode.com/svn/trunk@7612 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSmall code cleaup: remove redundant if
edisonn@google.com [Wed, 6 Feb 2013 13:43:58 +0000 (13:43 +0000)]
Small code cleaup: remove redundant if
unreviewd, comment from previous cl

git-svn-id: http://skia.googlecode.com/svn/trunk@7611 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocheck for self-assignment in operator=
reed@google.com [Wed, 6 Feb 2013 12:47:14 +0000 (12:47 +0000)]
check for self-assignment in operator=

git-svn-id: http://skia.googlecode.com/svn/trunk@7610 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Skia_Periodic_House_Keeping
skia.committer@gmail.com [Wed, 6 Feb 2013 07:01:54 +0000 (07:01 +0000)]
Sanitizing source files in Skia_Periodic_House_Keeping

git-svn-id: http://skia.googlecode.com/svn/trunk@7608 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agotweak to spacing, to trigger build
mike@reedtribe.org [Wed, 6 Feb 2013 03:43:57 +0000 (03:43 +0000)]
tweak to spacing, to trigger build

git-svn-id: http://skia.googlecode.com/svn/trunk@7607 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoIf the stack is too deep we could get Stack Overflow in pdf's ContentEntry's destructor.
edisonn@google.com [Tue, 5 Feb 2013 23:13:39 +0000 (23:13 +0000)]
If the stack is too deep we could get Stack Overflow in pdf's ContentEntry's destructor.
Review URL: https://codereview.appspot.com/7313045

git-svn-id: http://skia.googlecode.com/svn/trunk@7605 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix calls to setVertexSourceToBuffer
robertphillips@google.com [Tue, 5 Feb 2013 22:55:18 +0000 (22:55 +0000)]
Fix calls to setVertexSourceToBuffer

git-svn-id: http://skia.googlecode.com/svn/trunk@7604 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix bench crash (calling method on NULL object).
bsalomon@google.com [Tue, 5 Feb 2013 21:32:06 +0000 (21:32 +0000)]
Fix bench crash (calling method on NULL object).
Review URL: https://codereview.appspot.com/7305048

git-svn-id: http://skia.googlecode.com/svn/trunk@7603 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReinstate r7546: fix unused variable warning
jvanverth@google.com [Tue, 5 Feb 2013 21:05:04 +0000 (21:05 +0000)]
Reinstate r7546: fix unused variable warning

https://codereview.appspot.com/7309051

git-svn-id: http://skia.googlecode.com/svn/trunk@7602 2bbb7eff-a529-9590-31e7-b0007b416f81