Zbigniew Jędrzejewski-Szmek [Mon, 15 Jan 2018 09:28:14 +0000 (13:28 +0400)]
Merge pull request #7872 from mineo/coredumpctl-zsh-completion
Fix the ZSH completion on `coredumpctl gdb <tab>`
Wieland Hoffmann [Sat, 13 Jan 2018 14:23:28 +0000 (15:23 +0100)]
zsh/coredumpctl: Never sort the completion candidates
That way, they're always sorted by date. I do not know how to make ZSH sort
them by PID through some option, but that doesn't seem very useful in the first
place.
Wieland Hoffmann [Sat, 13 Jan 2018 12:43:28 +0000 (13:43 +0100)]
zsh/coredumpctl: Fix the completion
An output from coredumpctl list is like
> TIME PID UID GID SIG COREFILE EXE
> Sun 2016-05-29 18:44:03 CEST 14578 1000 1000 6 none /tmp/pacaurtmp-wieland/python33/src/Python-3.3.6/python
^1 ^2 ^3 ^4 ^5
, but the previous sub() command turns that into
> TIMEPID UID GID SIG COREFILE EXE
> Sun2016-05-29 18:44:03 CEST 14578 1000 1000 6 none /tmp/pacaurtmp-wieland/python33/src/Python-3.3.6/python
^1 ^2 ^3 ^4 ^5
so the whole pipeline generated entries like
$UID:$DESCRIPTION
but that's not useful and probably not what was supposed to happen.
This now generates entries like
$PID:$DESCRIPTION
which make everything work.
Note that with this commmit, the completions will be sorted by PID by
ZSH.
0xAX [Fri, 12 Jan 2018 23:48:53 +0000 (00:48 +0100)]
dbus-execute: define bus_set_transient_errno() only if HAVE_SECCOMP (#7869)
in other way we will get a warning during build:
../src/core/dbus-util.h:55:13: warning: ‘bus_set_transient_errno’
defined but not used [-Wunused-function]
int bus_set_transient_##function(
Max Harmathy [Fri, 12 Jan 2018 13:16:43 +0000 (14:16 +0100)]
login: avoid external process call
Use a shell builtin of posix shells insteaf of calling 'which'.
See also http://stackoverflow.com/a/677212
Michal Sekletar [Fri, 12 Jan 2018 12:05:48 +0000 (13:05 +0100)]
process-util: make our freeze() routine do something useful
When we crash we freeze() our-self (or possibly we reboot the machine if
that is configured). However, calling pause() is very unhelpful thing to
do. We should at least continue to do what init systems being doing
since 70's and that is reaping zombies. Otherwise zombies start to
accumulate on the system which is a very bad thing. As that can prevent
admin from taking manual steps to reboot the machine in somewhat
graceful manner (e.g. manually stopping services, unmounting data
volumes and calling reboot -f).
Fixes #7783
Lennart Poettering [Fri, 12 Jan 2018 16:24:56 +0000 (17:24 +0100)]
Merge pull request #7865 from fbuihuu/restore-termination-of-bus-connection-first
Restore termination of bus connection first
Franck Bui [Fri, 12 Jan 2018 15:20:36 +0000 (16:20 +0100)]
Comment the fact that some tools need to termintate their bus connect first
Franck Bui [Fri, 12 Jan 2018 15:11:46 +0000 (16:11 +0100)]
mount: make sure we terminate the bus connection first, and then close the pager
See
cf647b69baee4c478d3909c327e3d917e1563f44 commit message for details.
Franck Bui [Fri, 12 Jan 2018 15:09:21 +0000 (16:09 +0100)]
Revert "tree-wide: use _cleanup_(sd_bus_flush_close_unrefp) at various appropriate places"
This reverts commit
0b3c84eb7da3a8c28ac248a68228f6a7edbb2e19.
The removal of _cleanup_() usages was done on purpose, see
cf647b69baee4c478d3909c327e3d917e1563f44.
Fixes: #3543
Matthew Thode [Thu, 11 Jan 2018 16:48:43 +0000 (10:48 -0600)]
support LZMA concatenated files
The xz format supports concatenated files, images are sometimes created
and shipped with it to increase compression.
https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1742744 is
the source bug for this issue.
Lennart Poettering [Thu, 11 Jan 2018 22:37:04 +0000 (23:37 +0100)]
Merge pull request #7851 from msekletar/dbus-error-logging
dbus: propagate errors from bus_init_system() and bus_init_api()
winnerman-pythian [Thu, 11 Jan 2018 17:01:57 +0000 (12:01 -0500)]
bootctl: add newline after printf (#7856)
Upon error condition, a newline is not printed, leading to the shell prompt jamming against this line.
Lennart Poettering [Thu, 11 Jan 2018 16:14:49 +0000 (17:14 +0100)]
Merge pull request #7833 from keszybz/netdev-relaxed
Avoid spurious warnings about unknown sections in .netdev files
Susant Sahani [Tue, 2 Jan 2018 09:20:15 +0000 (14:50 +0530)]
networkd: initcwn/initwnd use the right parsers
Closes #7765
Samuel Dionne-Riel [Wed, 27 Dec 2017 20:42:38 +0000 (15:42 -0500)]
hwdb: Add accelerometer orientation entry for Asus TP300LA
Michal Sekletar [Wed, 10 Jan 2018 16:22:12 +0000 (17:22 +0100)]
dbus: propagate errors from bus_init_system() and bus_init_api()
The aim of this change is to make sure that we properly log about all
D-Bus connection problems. After all, we only ever attempt to get on the
bus if dbus-daemon is around, so any failure in the process should be
treated as an error.
bus_init_system() is only called from bus_init() and in
bus_init() we have a bool flag which governs whether we should attempt
to connect to the system bus or not.
Hence if we are in bus_init_system() then it is clear we got called from
a context where connection to the bus is actually required and therefore
shouldn't be treated as the "best effort" type of operation. Same
applies to bus_init_api().
We make use of those error codes in bus_init() and log high level
message that informs admin about what is going on (and is easy to spot
and makes sense to an end user).
Also "retrying later" bit is actually a lie. We won't retry unless we
are explicitly told to reconnect via SIGUSR1 or re-executed. This is
because bus_init() is always called from the context where dbus-daemon
is already around and hence bus_init() won't be called again from
unit_notify().
Fixes #7782
Zbigniew Jędrzejewski-Szmek [Thu, 4 Jan 2018 14:28:57 +0000 (15:28 +0100)]
bus-socket: slight simplification in bus_get_peercred()
Zbigniew Jędrzejewski-Szmek [Tue, 9 Jan 2018 13:32:44 +0000 (14:32 +0100)]
netdev: use "relaxed" parsing
We parse each netdev file twice: once to determine the type and match conditions,
and then the second time properly. In
bcde742e78ac3b8e8ea348cfb022c820c11800e2
the flags for the first parsing were (inadvertently I assume) were changed to
emit warnings. But this first pass is called with only [Match] and [NetDev] sections,
so we'd get warnings about all other section types. The obvious solution would be
to remove CONFIG_PARSE_WARN again, but I think it's better to keep the warnings
and set CONFIG_PARSE_RELAXED: we do want to get warnings about malformed lines and
such, and _RELAXED is enough to kill warnings about unknown sections.
Dimitri John Ledkov [Mon, 11 Dec 2017 18:27:49 +0000 (18:27 +0000)]
resolved.service: set DefaultDependencies=no
On systems that only use resolved for name resolution, there are usecases that
require resolved to be started before sysinit target, such that network name
resolution is available before network-online/sysinit targets. For example,
cloud-init for some datasources hooks into the boot process ahead of sysinit
target and may need network name resolution at that point already.
systemd-resolved already starts pretty early in the process, thus starting it
slightly earlier should not have negative side effects.
However, this depends on resolved ability to connect to system DBus once that
is up.
Split7fire [Sun, 24 Dec 2017 14:20:07 +0000 (21:20 +0700)]
Fix Mount Matrix for Chuwi HiBook
Samuel Dionne-Riel [Wed, 27 Dec 2017 22:49:14 +0000 (17:49 -0500)]
hwdb: Add accelerometer orientation entry for Chuwi Hi10 Pro
Michal Koutný [Thu, 11 Jan 2018 11:28:32 +0000 (12:28 +0100)]
test-dnssec: Allow builds without libgcrypt (#7850) (#7850)
Fixes: #7845
Marek Čermák [Thu, 11 Jan 2018 10:41:35 +0000 (11:41 +0100)]
Integration of Travis CI and Coverity Scan Analysis (#7691)
- Coverity scan analysis tasks run as scheduled cron jobs
- Stage separation for Build, Test and Coverity scan phase
- Travis CI now uses Fedora container to build and run tests
- Containers are accessible from Docker Hub and failed builds
can be reproduced and examined
- coverity.sh: separate build and upload
Franck Bui [Wed, 10 Jan 2018 22:28:44 +0000 (23:28 +0100)]
tmpfiles: consider /etc uninitialized also when /etc/machine-id is present but empty (#7849)
Zbigniew Jędrzejewski-Szmek [Wed, 10 Jan 2018 19:18:51 +0000 (20:18 +0100)]
Merge pull request #7846 from poettering/nobody-getenv
some assorted fixes and additions, in particular a way to turn off "nobody" synthesizing on a specific system
Lennart Poettering [Wed, 10 Jan 2018 19:08:18 +0000 (20:08 +0100)]
sd-netlink: let's make things compile on certain old glibc's and kernel headers again (#7848)
Let's include netinet/in.h instead of linux/in6.h, as the former is the
official libc location for these definitions, and the latter is a
linux-specific version that conflicts.
This hopefully makes systemd compile on current Semaphore again.
This takes
e410b07d2aa64a653bc0e93b77856af41297b84d into consideration,
but makes us use glibc rather than kernel headers.
While we are at it, let's also sort our #include lines. Since kernel
headers are notoriously crappy we won't strictly order them globally,
but first include non-kernel headers in a sorted way, and then include
kernel headers in a somewhat sorted way (i.e. generic stuff first and
somewhat alphabetical, and specific stuff last)
Jan Klötzke [Wed, 10 Jan 2018 18:00:20 +0000 (19:00 +0100)]
shutdown: make kill timeout configurable (#7835)
By default systemd-shutdown will wait for 90s after SIGTERM was sent
for all processes to exit. This is way too long and effectively defeats
an emergency watchdog reboot via "reboot-force" actions. Instead now
use DefaultTimeoutStopSec which is configurable.
Lennart Poettering [Wed, 10 Jan 2018 17:59:14 +0000 (18:59 +0100)]
Merge pull request #7843 from hbakken/work/old-kernel-support
Work/old kernel support
Lennart Poettering [Wed, 10 Jan 2018 17:37:54 +0000 (18:37 +0100)]
util: minor tweaks to disable_core_dumps()
First, let's rename it to disable_coredumps(), as in the rest of our
codebase we spell it "coredump" rather than "core_dump", so let's stick
to that.
However, also log about failures to turn off core dumpling on LOG_DEBUG,
because debug logging is always a good idea.
Lennart Poettering [Wed, 10 Jan 2018 17:28:42 +0000 (18:28 +0100)]
manager: rework manager_clean_environment()
Let's rename it manager_sanitize_environment() which is a more precise
name. Moreover, sort the environment implicitly inside it, as all our
callers do that anyway afterwards and we can save some code this way.
Also, update the list of env vars to drop, i.e. the env vars we manage
ourselves and don't want user code to interfear with. Also sort this
list to make it easier to update later on.
Lennart Poettering [Wed, 10 Jan 2018 17:26:03 +0000 (18:26 +0100)]
nss-systemd,user-util: add a way how synthesizing "nobody" can be turned off
This is quite ugly, but provides us with an avenue for moving
distributions to define the "nobody" user properly without breaking legacy
systems that us the name for other stuff.
The idea is basically, that the distribution adopts the new definition
of "nobody" (and thus recompiles systemd with it) and then touches
/etc/systemd/dont-synthesize-nobody on legacy systems to turn off
possibly conflicting synthesizing of the nobody name by systemd.
Lennart Poettering [Wed, 10 Jan 2018 16:28:03 +0000 (17:28 +0100)]
tmpfiles: modernize load_unix_sockets() a bit
Let's log in case of error.
Let's use read_line() instead of a fixed-size buffer
Let's make use of set_free_free()'s return value.
Lennart Poettering [Wed, 10 Jan 2018 16:21:15 +0000 (17:21 +0100)]
util-lib: save/restore errno in cleanup calls
We should be careful with errno in cleanup functions, and not alter it
under any circumstances. In the safe_close cleanup handlers we are
already safe in that regard, but let's add similar protections on other
cleanup handlers that invoke system calls.
Why bother? Cleanup handlers insert code at function return in
non-obvious ways. Hence, code that sets errno and returns should not be
confused by us overrding the errno from a cleanup handler.
This is a paranoia fix only, I am not aware where this actually mattered
in real-life situations.
Lennart Poettering [Wed, 10 Jan 2018 16:11:19 +0000 (17:11 +0100)]
cocci: use strempty() at more places
This shortens the code by a few lines.
Lennart Poettering [Wed, 10 Jan 2018 14:15:07 +0000 (15:15 +0100)]
Merge pull request #7836 from jkloetzke/shutdown-no-coredumps
shutdown: prevent core dumps in final shutdown stage
Lennart Poettering [Wed, 10 Jan 2018 14:13:07 +0000 (15:13 +0100)]
Merge pull request #7837 from yuwata/coverity-
20170110
fix defects reported by Coverity Scan
Yu Watanabe [Wed, 10 Jan 2018 02:27:15 +0000 (11:27 +0900)]
timesync: fix typo
Yu Watanabe [Wed, 10 Jan 2018 01:25:32 +0000 (10:25 +0900)]
exec-util: cast to void when return value is ignored
CID 1384262.
Yu Watanabe [Wed, 10 Jan 2018 01:24:06 +0000 (10:24 +0900)]
test: free after use
CID 1384238.
Yu Watanabe [Wed, 10 Jan 2018 01:22:35 +0000 (10:22 +0900)]
process-util: initialize block_signals
CID 1384240.
Hans-Christian Noren Egtvedt [Mon, 25 Sep 2017 14:39:32 +0000 (16:39 +0200)]
sd-radv: avoid redefinition of struct in6_addr
Both netinet/icmp6.h and linux/in6.h will define struct in6_addr, and in
user space we want to use the netinet/icmp6.h variant.
Fixes build problem:
In file included from src/libsystemd-network/sd-radv.c:23:0:
/home/hegtvedt/work/os/product/sunrise/root/_build/v2/include/linux/in6.h:30:8:
error: redefinition of 'struct in6_addr'
Hans-Christian Noren Egtvedt [Wed, 11 Oct 2017 08:48:39 +0000 (10:48 +0200)]
missing: add bpf() define for ARM definition
Zbigniew Jędrzejewski-Szmek [Wed, 10 Jan 2018 10:35:00 +0000 (11:35 +0100)]
timesyncd: avoid signed/unsigned comparison (#7842)
be32toh() returns uint32_t, and m->trans_time.tv_nsec is defined as long in struct timespec.
Let's add a cast to avoid the warning.
Fixes #7789.
Hans-Christian Noren Egtvedt [Tue, 17 Oct 2017 07:11:44 +0000 (09:11 +0200)]
missing: fix bpf() define for Tilera
__NR_bpf syscall uses the default generic value for Tilera, e.g. 280.
Jan Klötzke [Mon, 23 Oct 2017 06:57:09 +0000 (08:57 +0200)]
shutdown: prevent core dumps in final shutdown stage
If the system is finally shutting down it makes no sense to write core
dumps as the last remaining processes are terminated / killed. This is
especially significant in case of a "force reboot" where all processes
are hit concurrently with a SIGTERM and no orderly shutdown of
processes takes place.
Jan Klötzke [Wed, 10 Jan 2018 09:36:14 +0000 (10:36 +0100)]
tree-wide: introduce disable_core_dumps helper and port existing users
Changes the core_pattern to prevent any core dumps by the kernel. Does
nothing if we're in a container environment as this is system wide
setting.
Ewout van Mansom [Tue, 9 Jan 2018 15:42:54 +0000 (15:42 +0000)]
hwdb: Add workaround for backslash hardware issue in Purism Librem 13 V2 (#7826)
Zbigniew Jędrzejewski-Szmek [Tue, 9 Jan 2018 13:01:05 +0000 (14:01 +0100)]
Merge pull request #7191 from Mic92/systemd
The change in netdev.c done in the merge is necessary to avoid crashing in
cleanup. This is a follow-up for
f3c33b234d9f0256805722f02c7b4c4b59fd6de6.
Jörg Thalheim [Mon, 18 Dec 2017 14:20:34 +0000 (15:20 +0100)]
networkd: add support for wireguard interface type
More information may be found at wireguard.com.
Jörg Thalheim [Mon, 18 Dec 2017 14:17:06 +0000 (15:17 +0100)]
sd-netlink: add generic netlink support
This also adds the ability to incorporate arrays into netlink messages
and to determine when a netlink message is too big, used by some generic
netlink protocols.
Susant Sahani [Tue, 9 Jan 2018 08:13:06 +0000 (13:43 +0530)]
networkd: call link_set_routing_policy_rule before setting routes (#7815)
commit 7715629 (networkd: Fix race condition in [RoutingPolicyRule] handling (#7615)).
Does not fix race. Still there is a race in case of bride because the
bride goes down and up .
calling route_configure then link_set_routing_policy_rule and the
link_check_ready makes a race between routing_policy_rule_messages and route_messages.
While bride comes up and we call the call again route_configure if finds
it self in the callback function LINK_STATE_CONFIGURED networkd dies.
Let's handle first routing policy rules then route_configure. This fixes
the crash.
Closes #7797
Lennart Poettering [Mon, 8 Jan 2018 14:15:57 +0000 (15:15 +0100)]
Merge pull request #7740 from yuwata/fix-7676
sd-device: support the case that /sys is a symlink
Peter Hutterer [Mon, 8 Jan 2018 05:26:21 +0000 (15:26 +1000)]
hwdb: add touchpad override for Asus F3Sg
https://bugs.freedesktop.org/show_bug.cgi?id=104469
Thomas Huth [Mon, 8 Jan 2018 09:49:15 +0000 (10:49 +0100)]
rules: Mark the kvm device as static_node (for s390x and ppc64) (#7795)
On s390x and ppc64, the permissions of the /dev/kvm device are currently
not right as long as the kvm kernel module has not been loaded yet. The
kernel module is using MODULE_ALIAS("devname:kvm") there, so the module
will be loaded on the first access to /dev/kvm. In that case, udev needs
to apply the permission to the static node already (which was created via
devtmpfs), i.e. we have to specify the option "static_node=kvm" in the
udev rule.
Note that on x86, the kvm kernel modules are loaded early instead (via the
MODULE_DEVICE_TABLE(x86cpu, ...) feature checking), so that the right module
is loaded for the Intel or AMD hypervisor extensions right from the start.
Thus the "static_node=kvm" is not required on x86 - but it also should not
hurt here (and using it here even might be more future proof in case the
module loading is also done delayed there one day), so we just add the new
option to the rule here unconditionally.
Yu Watanabe [Sun, 7 Jan 2018 16:36:08 +0000 (01:36 +0900)]
sd-device: support the case that /sys is a symlink
When /sys is a symlink to the sysfs mountpoint, e.g. /path/to/sysfs.
Then, device->syspath was set to like /path/to/sysfs/devices/foo/baz.
This converts the path to /sys/devices/foo/baz.
Fixes #7676.
Yu Watanabe [Sun, 7 Jan 2018 16:35:44 +0000 (01:35 +0900)]
sd-device: use chase_symlinks()
Zbigniew Jędrzejewski-Szmek [Fri, 5 Jan 2018 18:46:38 +0000 (19:46 +0100)]
Merge pull request #7714 from poettering/sd-bus-watch-connect
many sd-bus improvements
rkolchmeyer [Fri, 5 Jan 2018 18:28:23 +0000 (10:28 -0800)]
core: Fix edge case when processing /proc/self/mountinfo (#7811)
Currently, if there are two /proc/self/mountinfo entries with the same
mount point path, the mount setup flags computed for the second of
these two entries will overwrite the mount setup flags computed for
the first of these two entries. This is the root cause of issue #7798.
This patch changes mount_setup_existing_unit to prevent the
just_mounted mount setup flag from being overwritten if it is set to
true. This will allow all mount units created from /proc/self/mountinfo
entries to be initialized properly.
Fixes: #7798
Lennart Poettering [Thu, 4 Jan 2018 10:36:58 +0000 (11:36 +0100)]
networkd: fix memory corruption
When loading .netdev files we parse them twice: first we do one parsing
iteration to figure out their "kind", and then we do it again to parse
out the kind's parameters. The first iteration is run with a "short"
NetDev structure, that only covers the generic NetDev properties. Which
should be enough, as we don't parse the per-kind properties. However,
before this patch we'd still try to destruct the per-kind properties
which resulted in memory corruption. With this change we distuingish the
two iterations by the state field, so that the destruction only happens
when the state signals we are running with a full NetDev structure.
Since this is not obvious, let's add a lot of comments.
Lennart Poettering [Thu, 4 Jan 2018 10:36:35 +0000 (11:36 +0100)]
logind: fix user_object_find()
The logic was completely borked since
e4d2984bf8514ab576a66d5ac1f1cde746bb32a3, correct that.
CID #1384234
Lennart Poettering [Wed, 20 Dec 2017 18:48:23 +0000 (19:48 +0100)]
update TODO
Lennart Poettering [Wed, 20 Dec 2017 15:31:58 +0000 (16:31 +0100)]
man: document all the new APIs we added
Lennart Poettering [Wed, 20 Dec 2017 11:51:14 +0000 (12:51 +0100)]
meson: resurrect API documentation target
We had this functionality back in Automake times, let's resurrect it.
Lennart Poettering [Wed, 20 Dec 2017 18:48:39 +0000 (19:48 +0100)]
sd-bus: remove 'hint_sync_call' parameter from various function calls
This is unused since kdbus is gone, hence remove this too. This permits
us to get rid of sd_bus_send_internal() and just implement sd_bus_send()
directly.
Lennart Poettering [Wed, 20 Dec 2017 18:43:05 +0000 (19:43 +0100)]
pid1: set org.freedesktop.systemd1 as sender service name for direct connections
This way, clients can install the very same match on direct and broker
connections as in both cases the messages will originate from the o.f.s1
service.
Lennart Poettering [Wed, 20 Dec 2017 18:41:06 +0000 (19:41 +0100)]
sd-bus: add API to optionally set a sender field on all outgoing messages
This is useful on direct connections to generate messages with valid
sender fields.
This is particularly useful for services that are accessible both
through direct connections and the broker, as it allows clients to
install matches on the sender service name, and they work the same in
both cases.
Lennart Poettering [Wed, 20 Dec 2017 18:38:15 +0000 (19:38 +0100)]
verbs: suppress debug log message if SYSTEMD_OFFLINE is not set
If SYSTEMD_OFFLINE is not set getenv_bool() for it will return -ENXIO,
which is nothing we should log about, not even at LOG_DEBUG level.
Lennart Poettering [Wed, 20 Dec 2017 17:13:23 +0000 (18:13 +0100)]
test: fix condition test if there are no controllers
As an optimization cg_mask_to_string() returns NULL if there are no
controllers available. We need to handle that.
Lennart Poettering [Wed, 20 Dec 2017 17:02:16 +0000 (18:02 +0100)]
sd-bus: drop some unused fields from the sd_bus_message structure
Lennart Poettering [Wed, 20 Dec 2017 15:40:47 +0000 (16:40 +0100)]
tree-wide: make the Subscribe() method calls asynchronous too
Lennart Poettering [Wed, 20 Dec 2017 18:45:09 +0000 (19:45 +0100)]
sd-bus: accept NULL callbacks in sd_bus_call_async()
This way sd_bus_call_method_async() (which is just a wrapper around
sd_bus_call_async()) can be used to put method calls together that
expect no reply.
Lennart Poettering [Wed, 20 Dec 2017 11:50:43 +0000 (12:50 +0100)]
sd-bus: log about bus state changes
Let's unify all state changes in a new helper function, from which we
can then debug log all state changes
Lennart Poettering [Tue, 19 Dec 2017 14:54:30 +0000 (15:54 +0100)]
networkd,resolved: make use of watch_bind feature to connect to the bus
The changes both networkd and resolved to make use of the watch_bind
feature of sd-bus to connect to the system bus. This way, both daemons
can be started during early boot, and automatically and instantly
connect to the system bus as it becomes available.
This replaces prior code that used a time-based retry logic to connect
to the bus.
Lennart Poettering [Tue, 19 Dec 2017 14:50:05 +0000 (15:50 +0100)]
sd-bus: add new sd_bus_set_connected_signal() API
With this new API sd-bus can synthesize a local "Connected" signal when
the connection is fully established. It mirrors the local "Disconnected"
signal that is already generated when the connection is terminated. This
is useful to be notified when connection setup is done, in order to
start method calls then, in particular when using "slow" connection
methods (for example slow TCP, or most importantly the "watch_bind"
inotify logic).
Note that one could also use hook into the initial NameAcquired signal
received from the bus broker, but that scheme works only if we actually
connect to a bus. The benefit of "Connected" OTOH is that it works with
any kind of connection.
Ideally, we'd just generate this message unconditionally, but in order
not to break clients that do not expect this message it is opt-in.
Lennart Poettering [Tue, 19 Dec 2017 14:47:09 +0000 (15:47 +0100)]
sd-bus: add new sd_bus_is_ready() API
This new call is much light sd_bus_is_open(), but returns true only if
the connection is fully set up, i.e. after we finished with the
authentication and Hello() phase. This API is useful for clients in
particular when using the "watch_bind" feature, as that way it can be
determined in advance whether it makes sense to sync on some operation.
Lennart Poettering [Tue, 19 Dec 2017 14:45:30 +0000 (15:45 +0100)]
sd-bus: modernize how we generate the match string in sd-bus-track
strjoina() FTW!
Lennart Poettering [Tue, 19 Dec 2017 14:41:58 +0000 (15:41 +0100)]
sd-bus: drop references to legacy /var/run D-Bus socket
Let's directly reference /run instead, so that we can work without /var
being around, or with /var/run being incorrectly set up.
Note that we keep the old socket path in place when referencing the
system bus of containers, as they might be foreign operating systems,
that still don't have adopted /run, and where it makes sense to use the
standardized name instead. On local systems, we insist on /run being set
up properly however, hence this limitation does not apply.
Also, get rid of the UNIX_SYSTEM_BUS_ADDRESS and
UNIX_USER_BUS_ADDRESS_FMT defines. They had a purpose when we still did
kdbus, as we then had to support two different backends. But since
that's gone, we don't need this indirection anymore, hence settle on a
one define only.
Lennart Poettering [Tue, 19 Dec 2017 14:39:44 +0000 (15:39 +0100)]
man: let's drop references to /var/run in public man pages
/var/run is a legacy compatibility feature, let's avoid mentioning it.
Lennart Poettering [Tue, 19 Dec 2017 11:29:04 +0000 (12:29 +0100)]
tree-wide: install matches asynchronously
Let's remove a number of synchronization points from our service
startups: let's drop synchronous match installation, and let's opt for
asynchronous instead.
Also, let's use sd_bus_match_signal() instead of sd_bus_add_match()
where we can.
Lennart Poettering [Mon, 18 Dec 2017 21:10:11 +0000 (22:10 +0100)]
tree-wide: make name requesting asynchronous in all our services
This optimizes service startup a bit, and makes it less prone to
deadlocks.
Lennart Poettering [Mon, 18 Dec 2017 20:58:14 +0000 (21:58 +0100)]
sd-bus: when disconnecting a slot, also reset its memory
Yes, we aren#t accessing this anymore after, but it's still nicer if
this is actually guaranteed.
Lennart Poettering [Mon, 18 Dec 2017 20:52:50 +0000 (21:52 +0100)]
sd-bus: add new API sd_bus_match_signal() + sd_bus_match_signal_asnyc()
These are convenience helpers that hide the match string logic (which we
probably should never have exposed), and instead just takes regular C
arguments.
Lennart Poettering [Mon, 18 Dec 2017 20:37:03 +0000 (21:37 +0100)]
sd-bus: add asynchronous version of sd_bus_match()
We usually enqueue a number of these calls on each service
initialization. Let's do this asynchronously, and thus remove
synchronization points. This improves both performance behaviour and
reduces the chances to deadlock.
Lennart Poettering [Mon, 18 Dec 2017 19:50:26 +0000 (20:50 +0100)]
sd-bus: when removing a server-side match, do so in "fire and forget" fashion
We currently wait for the RemoveMatch() reply, but then ignore what it
actually says. Let's optimize this a bit, and not even ask for an answer
back: just enqueue the RemoveMatch() operation, and do not request not
wait for any answer.
Lennart Poettering [Mon, 18 Dec 2017 19:45:35 +0000 (20:45 +0100)]
sd-bus: remove bus_remove_match_by_string() helper which is unused
Lennart Poettering [Mon, 18 Dec 2017 19:34:21 +0000 (20:34 +0100)]
sd-bus: drop unused parameters from bus_add_match_internal()
We don't need the match components anymore, since kdbus is gone, hence
drop it.
Lennart Poettering [Mon, 18 Dec 2017 19:10:13 +0000 (20:10 +0100)]
sd-bus: add APIs to request/release names asynchronously
They do the same thing as their synchronous counterparts, but only
enqueue the operation, thus removing synchronization points during
service initialization.
If the callback function is passed as NULL we'll fallback to generic
implementations of the reply handlers, that terminate the connection if
the requested name cannot be acquired, under the assumption that not
being able to acquire the name is a technical problem.
Lennart Poettering [Mon, 18 Dec 2017 13:48:16 +0000 (14:48 +0100)]
bus-control: remove kdbus indirection cruft
When kdbus was still around we always had two implementations of the
various control calls: one for dbus1 and one for kdbus. Let'sget rid of
this, simplify things, and just merge the wrappers that used to
multiplex this with the implementations.
No change in behaviour, just some merging of functions
Lennart Poettering [Mon, 18 Dec 2017 13:21:34 +0000 (14:21 +0100)]
sd-bus: get rid of kdbus flags cruft
We only need three bits from the old kdbus flags cruft, hence let's make
them proper booleans.
Lennart Poettering [Fri, 15 Dec 2017 21:19:34 +0000 (22:19 +0100)]
busctl: add a new --watch-bind switch
This is useful for testing, and early-boot scripting.
Lennart Poettering [Mon, 18 Dec 2017 12:53:12 +0000 (13:53 +0100)]
sd-bus: start reply callback timeouts only when the connection is established
Currently, reply callback timeouts are started the instant the method
calls are enqueued, which can be very early on. For example, the Hello()
method call is enqueued right when sd_bus_start() is called, i.e. before
the socket connection and everything is established.
With this change we instead start the method timeout the moment we
actually leave the authentication phase of the connection. This way, the
timeout the kernel applies on socket connecting, and we apply on the
authentication phase no longer runs in parallel to the Hello() method
call, but all three run serially one after the other, which is
definitely a cleaner approach.
Moreover, this makes the "watch bind" feature a lot more useful, as it
allows enqueuing method calls while we are still waiting for inotify
events, without them timeouting until the connection is actually
established, i.e. when the method call actually has a chance of being
actually run.
This is a change of behaviour of course, but I think the new behaviour
is much better than the old one, since we don't race timeouts against
each other anymore...
Lennart Poettering [Fri, 15 Dec 2017 21:24:52 +0000 (22:24 +0100)]
sd-bus: optionally, use inotify to wait for bus sockets to appear
This adds a "watch-bind" feature to sd-bus connections. If set and the
AF_UNIX socket we are connecting to doesn't exist yet, we'll establish
an inotify watch instead, and wait for the socket to appear. In other
words, a missing AF_UNIX just makes connecting slower.
This is useful for daemons such as networkd or resolved that shall be
able to run during early-boot, before dbus-daemon is up, and want to
connect to dbus-daemon as soon as it becomes ready.
Lennart Poettering [Wed, 27 Dec 2017 17:22:31 +0000 (18:22 +0100)]
bus: touch() the AF_UNIX sockets we listen() on after the fact
We'd like to use inotify to get notified when AF_UNIX sockets become
connectable. That happens at the moment of listen(), but this is doesn't
necessarily create in a watchable inotify event. Hence, let's synthesize
one whenever we generically create a socket, or when we know we created
it for a D-Bus server.
Ideally we wouldn't have to do this, and the kernel would generate an
event anyway for this. Doing this explicitly isn't too bad however, as
the event is still nicely associated with the AF_UNIX socket node, and
we generate all D-Bus sockets in our code hence it's safe.
Lennart Poettering [Wed, 27 Dec 2017 16:18:02 +0000 (17:18 +0100)]
socket-util: explicitly ensure there's one trailing NUL byte on AF_UNIX socket addresses
AF_UNIX socket addresses aren't necessarily NUL terminated, however
they are usually used as strings which are assumed to be NUL terminated.
Let's hence add an extra byte to the end of the sockaddr_un structure,
that contains this NUL byte, simply for safety reasons.
Note that actually this patch changes exactly nothing IRL, as the other
sockaddr structures already are large enough to accomodate for an extra
NUL byte. The size of the union hence doesn't change at all by doing
this. The entire value of this patch is hence in the philosophical
feeling of safety, and by making something explicit that before was
implicit.
Lennart Poettering [Wed, 27 Dec 2017 16:02:36 +0000 (17:02 +0100)]
socket-util: use parse_ip_port() for parsing IP ports
Let's unify some code here, and also use parse_ip_port() for all our IP
port parsing needs in socket_address_parse().
Lennart Poettering [Wed, 27 Dec 2017 15:59:44 +0000 (16:59 +0100)]
socket-label: tweak socket_address_listen() a bit
This changes two things when binding to AF_UNIX file system sockets:
1. When wethe socket already exists in the fs, and unlink() on it fails,
don't bother to bind() a second time: since nothing changed it won't
work either.
2. Also use SELinux-aware bind() for the second attempt.
Lennart Poettering [Wed, 27 Dec 2017 15:50:24 +0000 (16:50 +0100)]
socket-label: simplify things a bit by using socket_address_get_path()
Let's make this more generic and descriptive, and let's reuse our
existing utility functions.
Lennart Poettering [Wed, 27 Dec 2017 15:20:28 +0000 (16:20 +0100)]
fs-util: rework touch_file() so that it can touch socket file nodes
Let's rework touch_file() so that it works correctly on sockets, fifos,
and device nodes: let's open an O_PATH file descriptor first and operate
based on that, if we can. This is usually the better option as it this
means we can open AF_UNIX nodes in the file system, and update their
timestamps and ownership correctly. It also means we can correctly touch
symlinks and block/character devices without triggering their drivers.
Moreover, by operating on an O_PATH fd we can make sure that we
operate on the same inode the whole time, and it can't be swapped out in
the middle.
While we are at it, rework the call so that we try to adjust as much as
we can before returning on error. This is a good idea as we call the
function quite often without checking its result, and hence it's best to
leave the files around in the most "correct" fashion possible.
Lennart Poettering [Fri, 15 Dec 2017 21:24:16 +0000 (22:24 +0100)]
sd-bus: when attached to an sd-event loop, disconnect on processing errors
If we can't process the bus for some reason we shouldn't just disable
the event source, but log something and give up on the connection. Hence
do that, and disconnect.