platform/upstream/libSkiaSharp.git
10 years agoManual revert of https://code.google.com/p/skia/source/detail?r=13353 due to perf...
commit-bot@chromium.org [Tue, 4 Mar 2014 22:37:29 +0000 (22:37 +0000)]
Manual revert of https://code.google.com/p/skia/source/detail?r=13353 due to perf regression.

BUG=344020
R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/187023002

git-svn-id: http://skia.googlecode.com/svn/trunk@13662 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix error in barelinux_make build script
commit-bot@chromium.org [Tue, 4 Mar 2014 22:32:49 +0000 (22:32 +0000)]
Fix error in barelinux_make build script

R=borenet@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/187093002

git-svn-id: http://skia.googlecode.com/svn/trunk@13661 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFactor out a BaseContext from JsContext.
commit-bot@chromium.org [Tue, 4 Mar 2014 20:44:32 +0000 (20:44 +0000)]
Factor out a BaseContext from JsContext.

BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/186783004

git-svn-id: http://skia.googlecode.com/svn/trunk@13660 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew baselines for imagefiltersclipped, imagefiltersscaled GMs.
senorblanco@chromium.org [Tue, 4 Mar 2014 19:22:43 +0000 (19:22 +0000)]
New baselines for imagefiltersclipped, imagefiltersscaled GMs.

Required after r13637.

TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/186933002

git-svn-id: http://skia.googlecode.com/svn/trunk@13659 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoThe motivation for this CL is to de-clutter SkPicture's beginRecording method.
commit-bot@chromium.org [Tue, 4 Mar 2014 19:08:57 +0000 (19:08 +0000)]
The motivation for this CL is to de-clutter SkPicture's beginRecording method.

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/186813003

git-svn-id: http://skia.googlecode.com/svn/trunk@13658 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoStart prototyping what DisplayList support will look like.
commit-bot@chromium.org [Tue, 4 Mar 2014 19:05:50 +0000 (19:05 +0000)]
Start prototyping what DisplayList support will look like.

None of the new codepaths get executed yet since DisplayList doesn't exist, but that will happening in the new few CLs.

BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/183883017

git-svn-id: http://skia.googlecode.com/svn/trunk@13657 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoApply the CTM to the offset in the slow SkOffsetImageFilter path.
senorblanco@chromium.org [Tue, 4 Mar 2014 19:05:25 +0000 (19:05 +0000)]
Apply the CTM to the offset in the slow SkOffsetImageFilter path.

This was being done in the fast path, but not the slow path.

Since I had to rebaseline the offsetimagefilter GM anyway (to accomodate
the new test case), I added a red border around the intersection
of the (transformed) crop rect and clip rect in each sample, beyond
which no pixels should be drawn.

Chrome bug: https://code.google.com/p/chromium/issues/detail?id=346362

BUG=skia:
R=sugoi@google.com

Review URL: https://codereview.chromium.org/186643003

git-svn-id: http://skia.googlecode.com/svn/trunk@13656 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMake rrects.cpp compile in no-gpu mode
bsalomon@google.com [Tue, 4 Mar 2014 16:52:20 +0000 (16:52 +0000)]
Make rrects.cpp compile in no-gpu mode
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/186663004

git-svn-id: http://skia.googlecode.com/svn/trunk@13655 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: better reporting for bad URL fetch
commit-bot@chromium.org [Tue, 4 Mar 2014 16:46:22 +0000 (16:46 +0000)]
rebaseline_server: better reporting for bad URL fetch

context: https://codereview.chromium.org/183763025/ ('vm_run_skia_try/write_json_summary: run skpdiff within imagediffdb, not on its own')

NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry

Author: epoger@google.com

Review URL: https://codereview.chromium.org/183833019

git-svn-id: http://skia.googlecode.com/svn/trunk@13654 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd GM that directly tests GrRRectEffect and add inverse fill version of effect.
commit-bot@chromium.org [Tue, 4 Mar 2014 16:25:34 +0000 (16:25 +0000)]
Add GM that directly tests GrRRectEffect and add inverse fill version of effect.

BUG=skia:
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/176843016

git-svn-id: http://skia.googlecode.com/svn/trunk@13653 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew baselines for perspective switch
commit-bot@chromium.org [Tue, 4 Mar 2014 14:41:52 +0000 (14:41 +0000)]
New baselines for perspective switch

BUG=skia:2245
R=epoger@google.com, bsalomon@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/186563004

git-svn-id: http://skia.googlecode.com/svn/trunk@13652 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 4 Mar 2014 03:02:32 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13651 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: keep going on exception in ImagePair.__init__()
commit-bot@chromium.org [Tue, 4 Mar 2014 00:58:21 +0000 (00:58 +0000)]
rebaseline_server: keep going on exception in ImagePair.__init__()

BUG=skia:2247
NOTREECHECKS=True
NOTRY=True
R=borenet@google.com
TBR=borenet

Author: epoger@google.com

Review URL: https://codereview.chromium.org/184103022

git-svn-id: http://skia.googlecode.com/svn/trunk@13650 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoThis adds cull rect visualization to the debugger's "mega" visualization mode.
commit-bot@chromium.org [Mon, 3 Mar 2014 23:25:41 +0000 (23:25 +0000)]
This adds cull rect visualization to the debugger's "mega" visualization mode.

R=fmalita@google.com, fmalita@chromium.org

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/177423013

git-svn-id: http://skia.googlecode.com/svn/trunk@13649 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDon't emit declaration of gl_FragPos unless also changing the origin.
commit-bot@chromium.org [Mon, 3 Mar 2014 23:25:26 +0000 (23:25 +0000)]
Don't emit declaration of gl_FragPos unless also changing the origin.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/182003002

git-svn-id: http://skia.googlecode.com/svn/trunk@13648 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agobench rebase after skp update.
commit-bot@chromium.org [Mon, 3 Mar 2014 22:50:13 +0000 (22:50 +0000)]
bench rebase after skp update.

BUG=skia:2163
NOTRY=true
R=rmistry@google.com
TBR=rmistry@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/182443005

git-svn-id: http://skia.googlecode.com/svn/trunk@13647 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCleanup patch to move all of SkImageFilterUtils into SkImageFilter.
senorblanco@chromium.org [Mon, 3 Mar 2014 22:13:56 +0000 (22:13 +0000)]
Cleanup patch to move all of SkImageFilterUtils into SkImageFilter.

This was a utility class that dates from before GPU code was allowed
in core. Now that it is, there's no reason not to have this
functionality in SkImageFilter.

Covered by existing tests.

R=reed@google.com

Review URL: https://codereview.chromium.org/185973003

git-svn-id: http://skia.googlecode.com/svn/trunk@13646 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBaselines for skia:2146
commit-bot@chromium.org [Mon, 3 Mar 2014 19:31:08 +0000 (19:31 +0000)]
Baselines for skia:2146

BUG=skia:2146
R=epoger@google.com, bsalomon@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/180253004

git-svn-id: http://skia.googlecode.com/svn/trunk@13645 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRename test files to end with Test.cpp.
commit-bot@chromium.org [Mon, 3 Mar 2014 19:23:28 +0000 (19:23 +0000)]
Rename test files to end with Test.cpp.

DM builds all of {bench,gm,test}/*.cpp.  A Windows build warned us that we were
trying to link typeface.obj twice.  This must have something to do with there
existing gm/typeface.cpp and tests/Typeface.cpp.  To be safe, make sure tests
have a Test.cpp suffix to disambiguate.

BUG=skia:
R=rmistry@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/185923002

git-svn-id: http://skia.googlecode.com/svn/trunk@13644 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoGenerating the 1M skps frequently yields truncated skps. This tool is intended to...
commit-bot@chromium.org [Mon, 3 Mar 2014 19:18:39 +0000 (19:18 +0000)]
Generating the 1M skps frequently yields truncated skps. This tool is intended to help automate weeding these out.

Please see skbug:1057

rmistry for tools, gyp
mtklein for src\core & include\core

BUG=skia:1057
R=rmistry@google.com, mtklein@google.com, reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/176863004

git-svn-id: http://skia.googlecode.com/svn/trunk@13643 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoroll_deps: Return a tuple even when returning early
commit-bot@chromium.org [Mon, 3 Mar 2014 17:57:41 +0000 (17:57 +0000)]
roll_deps: Return a tuple even when returning early

This fixes the bot going red when DEPS is already up-to-date.

BUG=skia:
R=halcanary@google.com

Author: borenet@google.com

Review URL: https://codereview.chromium.org/185413012

git-svn-id: http://skia.googlecode.com/svn/trunk@13642 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd the ability to select bbh type, and include quadtree support.
commit-bot@chromium.org [Mon, 3 Mar 2014 17:51:12 +0000 (17:51 +0000)]
Add the ability to select bbh type, and include quadtree support.
This is a breaking change to tileGridSize flag added in 184543003, as it now defaults to a sensible value but does not implicitly turn on the tile grid bbh.

BUG=skia:2242
R=tomhudson@google.com, mtklein@google.com, skyostil@chromium.org, skyostil@google.com

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/183763022

git-svn-id: http://skia.googlecode.com/svn/trunk@13641 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoThe new "mega" viz mode both adds visualization and forces all drawing to the visible...
commit-bot@chromium.org [Mon, 3 Mar 2014 16:32:17 +0000 (16:32 +0000)]
The new "mega" viz mode both adds visualization and forces all drawing to the visible canvas (by replacing the active saveLayers with saves).

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/185293007

git-svn-id: http://skia.googlecode.com/svn/trunk@13640 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDM: tweak output.
commit-bot@chromium.org [Mon, 3 Mar 2014 15:44:56 +0000 (15:44 +0000)]
DM: tweak output.
Show task name in verbose mode only, and add task runtime.

BUG=skia:
R=reed@google.com, bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/185233004

git-svn-id: http://skia.googlecode.com/svn/trunk@13639 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDM: fix -w/-r problems stemming from PM/UPM conversions.
commit-bot@chromium.org [Mon, 3 Mar 2014 15:43:56 +0000 (15:43 +0000)]
DM: fix -w/-r problems stemming from PM/UPM conversions.

DM will now read and write a custom image format, which begins first with a
normal PNG, but also includes the bitmap's raw pixels.  Most tools (file
browser, Preview, Chrome, Skia image decoder) will read the file as PNG.  DM
skips the encoded PNG and reads the raw pixels instead.

This scheme allows perfect pixel comparisons that never go through PM -> UPM or
UPM -> PM conversions, as long as you compare on a machine with the same native
pixel format as the machine which generated the images.  Since we've only ever
used this to do same-machine comparisons, that's more than good enough for now.
We could convert as needed to a standardized PM pixel format if we find we want
these files to be portable.

DM -w output now does increase to ~1.3G.  If that turns out to be annoyingly
big, I'm sure I can come up with a simple pixelwise RLE instead of writing
uncompressed pixels.

BUG=skia:
R=reed@google.com, bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/185343002

git-svn-id: http://skia.googlecode.com/svn/trunk@13638 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix CTM scaling and clipping of SkRectShaderImageFilter.
senorblanco@chromium.org [Mon, 3 Mar 2014 14:58:09 +0000 (14:58 +0000)]
Fix CTM scaling and clipping of SkRectShaderImageFilter.

Pass the CTM as part of the local matrix passed by
SkRectShaderImageFilter. Teach SkPerlinNoiseShader to respect the local
matrix. Embiggen imagefiltersscaled GM size to accommodate the new test
cases.

Note: will require rebaselines of imagefiltersscaled and imagefiltersclipped

R=sugoi@chromium.org
BUG=skia:

Review URL: https://codereview.chromium.org/184973007

git-svn-id: http://skia.googlecode.com/svn/trunk@13637 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoNew approach for GPU font atlas
commit-bot@chromium.org [Mon, 3 Mar 2014 14:30:25 +0000 (14:30 +0000)]
New approach for GPU font atlas

In the previous code, each GrTextStrike had exclusive access to one or more GrPlots in the texture atlas. This led to poor packing when only a few glyphs were used. This change allows GrTextStrikes to share GrPlots, thereby getting much better utilization of the entire texture.

BUG=skia:2224
R=robertphillips@google.com, bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/177463003

git-svn-id: http://skia.googlecode.com/svn/trunk@13636 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdding code to calculate Underline Thickness from Font Metrics, this will be useful...
commit-bot@chromium.org [Sat, 1 Mar 2014 20:12:26 +0000 (20:12 +0000)]
Adding code to calculate Underline Thickness from Font Metrics, this will be useful when Skia is used with Blink/Chrome. Blink changes are uploaded with code change in patch https://codereview.chromium.org/147703002/

BUG=skia:
R=reed@android.com, edisonn@google.com, reed@google.com, mtklein@google.com, mtklein@chromium.org, bungeman@google.com

Author: h.joshi@samsung.com

Review URL: https://codereview.chromium.org/152073003

git-svn-id: http://skia.googlecode.com/svn/trunk@13635 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 1 Mar 2014 03:02:09 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13634 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline convexclip2_aa gpu on win7
bsalomon@google.com [Fri, 28 Feb 2014 22:21:29 +0000 (22:21 +0000)]
Rebaseline convexclip2_aa gpu on win7

Review URL: https://codereview.chromium.org/184993004

git-svn-id: http://skia.googlecode.com/svn/trunk@13633 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDM: make GPU tasks multithreaded again. Big refactor.
commit-bot@chromium.org [Fri, 28 Feb 2014 20:31:31 +0000 (20:31 +0000)]
DM: make GPU tasks multithreaded again.  Big refactor.

The main meat of things is in SkThreadPool.  We can now give SkThreadPool a
type for each thread to create and destroy on its local stack.  It's TLS
without going through SkTLS.

I've split the DM tasks into CpuTasks that run on threads with no TLS, and
GpuTasks that run on threads with a thread local GrContextFactory.

The old CpuTask and GpuTask have been renamed to CpuGMTask and GpuGMTask.

Upshot: default run of out/Debug/dm goes from ~45 seconds to ~20 seconds.

BUG=skia:
R=bsalomon@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/179233005

git-svn-id: http://skia.googlecode.com/svn/trunk@13632 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDM: don't crash on Mac.
commit-bot@chromium.org [Fri, 28 Feb 2014 20:28:59 +0000 (20:28 +0000)]
DM: don't crash on Mac.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/177053005

git-svn-id: http://skia.googlecode.com/svn/trunk@13631 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCleanup GrGLInterface after Chromium changes
commit-bot@chromium.org [Fri, 28 Feb 2014 20:28:50 +0000 (20:28 +0000)]
Cleanup GrGLInterface after Chromium changes

Depends on landing https://codereview.chromium.org/143263014

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/149533002

git-svn-id: http://skia.googlecode.com/svn/trunk@13630 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoImage rebaselines for r13627 (add new onClip* methods to SkCanvas)
robertphillips@google.com [Fri, 28 Feb 2014 20:02:20 +0000 (20:02 +0000)]
Image rebaselines for r13627 (add new onClip* methods to SkCanvas)

https://codereview.chromium.org/179123006/

git-svn-id: http://skia.googlecode.com/svn/trunk@13629 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdding flag to switch bench_record into tilegrid mode
commit-bot@chromium.org [Fri, 28 Feb 2014 19:25:11 +0000 (19:25 +0000)]
Adding flag to switch bench_record into tilegrid mode

BUG=skia:
R=tomhudson@google.com, mtklein@google.com, skyostil@google.com, skyostil@chromium.org

Author: iancottrell@google.com

Review URL: https://codereview.chromium.org/184543003

git-svn-id: http://skia.googlecode.com/svn/trunk@13628 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd new onClip* methods to SkCanvas
robertphillips@google.com [Fri, 28 Feb 2014 18:19:39 +0000 (18:19 +0000)]
add new onClip* methods to SkCanvas

https://codereview.chromium.org/183453002/

git-svn-id: http://skia.googlecode.com/svn/trunk@13627 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdates to the Android.mk writer.
commit-bot@chromium.org [Fri, 28 Feb 2014 17:24:32 +0000 (17:24 +0000)]
Updates to the Android.mk writer.

Keeping up with changes made to the Android.mk file that is
currently checked in.

R=djsollen@google.com, epoger@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/183953002

git-svn-id: http://skia.googlecode.com/svn/trunk@13626 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_DEEPCOPYTO_CONFIG
reed@google.com [Fri, 28 Feb 2014 16:30:45 +0000 (16:30 +0000)]
remove SK_SUPPORT_DEEPCOPYTO_CONFIG

git-svn-id: http://skia.googlecode.com/svn/trunk@13625 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpdates to gyp files for building Android.mk
commit-bot@chromium.org [Fri, 28 Feb 2014 16:07:39 +0000 (16:07 +0000)]
Updates to gyp files for building Android.mk

R=djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/180873012

git-svn-id: http://skia.googlecode.com/svn/trunk@13624 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoremove SK_SUPPORT_LEGACY_LAYERDRAWLOOPER_PAINTFLAGS -- not needed
reed@google.com [Fri, 28 Feb 2014 15:38:22 +0000 (15:38 +0000)]
remove SK_SUPPORT_LEGACY_LAYERDRAWLOOPER_PAINTFLAGS -- not needed

BUG=skia:
R=scroggo@google.com

Review URL: https://codereview.chromium.org/180483004

git-svn-id: http://skia.googlecode.com/svn/trunk@13623 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of r13620 (add new onClip* methods to SkCanvas - https://codereview.chromium...
robertphillips@google.com [Fri, 28 Feb 2014 15:28:02 +0000 (15:28 +0000)]
Revert of r13620 (add new onClip* methods to SkCanvas - https://codereview.chromium.org/183453002/) due to broken Chrome Canary and failing tests.

git-svn-id: http://skia.googlecode.com/svn/trunk@13622 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMake GrConvexPolyEffect support inverse fills and non-AA rects
commit-bot@chromium.org [Fri, 28 Feb 2014 14:43:26 +0000 (14:43 +0000)]
Make GrConvexPolyEffect support inverse fills and non-AA rects

BUG=skia:2151
R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/183833003

git-svn-id: http://skia.googlecode.com/svn/trunk@13621 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd new onClip* methods to SkCanvas
robertphillips@google.com [Fri, 28 Feb 2014 14:35:45 +0000 (14:35 +0000)]
add new onClip* methods to SkCanvas

https://codereview.chromium.org/183453002/

git-svn-id: http://skia.googlecode.com/svn/trunk@13620 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 28 Feb 2014 03:02:05 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13619 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoModify how gpu.gyp includes angle.gyp.
commit-bot@chromium.org [Thu, 27 Feb 2014 20:40:31 +0000 (20:40 +0000)]
Modify how gpu.gyp includes angle.gyp.

Instead of including dependencies on angle.gyp and then removing
them if skia_angle is not true, only include angle.gyp to begin
with skia_angle is true.

This allows gyp_to_android.py to work when run in the Android tree,
where we don't have third_party/externals (since we do only a git
merge, and no gclient sync.

R=djsollen@google.com, robertphillips@google.com, bsalomon@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/178223015

git-svn-id: http://skia.googlecode.com/svn/trunk@13618 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd SkCanvas::NewRaster factory -- a very common use-case in chrome
commit-bot@chromium.org [Thu, 27 Feb 2014 20:32:51 +0000 (20:32 +0000)]
add SkCanvas::NewRaster factory -- a very common use-case in chrome

BUG=skia:
R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/183533004

git-svn-id: http://skia.googlecode.com/svn/trunk@13617 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd GrSet class built on top of RedBlackTree
commit-bot@chromium.org [Thu, 27 Feb 2014 20:23:22 +0000 (20:23 +0000)]
Add GrSet class built on top of RedBlackTree

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/176903003

git-svn-id: http://skia.googlecode.com/svn/trunk@13616 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRename Path to Path2D
commit-bot@chromium.org [Thu, 27 Feb 2014 20:20:21 +0000 (20:20 +0000)]
Rename Path to Path2D

BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/177963005

git-svn-id: http://skia.googlecode.com/svn/trunk@13615 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUse chromium's gyp if third_party is not available.
commit-bot@chromium.org [Thu, 27 Feb 2014 18:58:51 +0000 (18:58 +0000)]
Use chromium's gyp if third_party is not available.

This is for building Android.mk inside an Android tree where there
is no third_party directory.

R=djsollen@google.com, epoger@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/177073022

git-svn-id: http://skia.googlecode.com/svn/trunk@13614 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoreplace gm_fprintf() calls with SkDebugf()
commit-bot@chromium.org [Thu, 27 Feb 2014 18:45:26 +0000 (18:45 +0000)]
replace gm_fprintf() calls with SkDebugf()

BUG=skia:1221
R=bsalomon@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/181933002

git-svn-id: http://skia.googlecode.com/svn/trunk@13613 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: fix "Results current as of <timestamp>" banner
commit-bot@chromium.org [Thu, 27 Feb 2014 18:13:07 +0000 (18:13 +0000)]
rebaseline_server: fix "Results current as of <timestamp>" banner

(SkipBuildbotRuns)
BUG=skia:2232
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry

Author: epoger@google.com

Review URL: https://codereview.chromium.org/183523002

git-svn-id: http://skia.googlecode.com/svn/trunk@13612 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCulling API
commit-bot@chromium.org [Thu, 27 Feb 2014 17:40:13 +0000 (17:40 +0000)]
Culling API

*** SKP format breaking change ***

Adding a couple of culling primitives: pushCull(SkRect) & popCull().

These are currently only plumbed for SKP playback quickreject.

At record time, we perform a couple of optimizations to trim down the
number of redundant culls:

  * collapse empty pushCull/popCull pairs
  * skip pushCull/popCull pairs nested within an identical cull rect

Things still missing/to consider:

  * use an inlineable, simplified quickreject (Mike's old prototype)
  * debugger visualization for cull boxes
  * BBH integration: the initial prototype had some minimal BBH support,
    but since the optimizations required expensive rewinds and culling
    is expected to be a BBH alternative, it got dropped.

R=bsalomon@google.com, reed@google.com, robertphillips@google.com, caryclark@google.com, tomhudson@google.com, iancottrell@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/138013009

git-svn-id: http://skia.googlecode.com/svn/trunk@13611 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUse SkTLazy to hold path in SkClipStack::Element
commit-bot@chromium.org [Thu, 27 Feb 2014 17:39:46 +0000 (17:39 +0000)]
Use SkTLazy to hold path in SkClipStack::Element

R=reed@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/178583002

git-svn-id: http://skia.googlecode.com/svn/trunk@13610 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoMove SkV8Example to SkSurface
commit-bot@chromium.org [Thu, 27 Feb 2014 17:39:40 +0000 (17:39 +0000)]
Move SkV8Example to SkSurface

BUG=skia:
R=robertphillips@google.com

Author: jcgregorio@google.com

Review URL: https://codereview.chromium.org/148523019

git-svn-id: http://skia.googlecode.com/svn/trunk@13609 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoWhitespace change to verify build fix
commit-bot@chromium.org [Thu, 27 Feb 2014 15:24:06 +0000 (15:24 +0000)]
Whitespace change to verify build fix

R=rmistry@google.com
TBR=rmistry
NOTREECHECKS=true
NOTRY=true

Author: borenet@google.com

Review URL: https://codereview.chromium.org/180843013

git-svn-id: http://skia.googlecode.com/svn/trunk@13608 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agotry to deprecate fFlagsMask from SkLayerDrawLooper
reed@google.com [Thu, 27 Feb 2014 14:27:44 +0000 (14:27 +0000)]
try to deprecate fFlagsMask from SkLayerDrawLooper

We think we want to move around how flags/fields like linearText and strikeThru
are specified. SkPaint has helpers for nearly all of these, but LayerInfo in
the draw looper just exposes the raw bitfield.

On survey of chrome/android, it appears that no one uses those, so it may be
safe to just remove the feature entirely from the looper.

R=bungeman@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/181433009

git-svn-id: http://skia.googlecode.com/svn/trunk@13607 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoWhitespace change to test CQ
commit-bot@chromium.org [Thu, 27 Feb 2014 12:29:36 +0000 (12:29 +0000)]
Whitespace change to test CQ

(SkipBuildbotRuns)
TBR=
BUG=skia:
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/183073002

git-svn-id: http://skia.googlecode.com/svn/trunk@13606 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFactory methods for heap-allocated SkAnnotation objects.
commit-bot@chromium.org [Thu, 27 Feb 2014 11:47:36 +0000 (11:47 +0000)]
Factory methods for heap-allocated SkAnnotation objects.

This is part of an effort to ensure that all SkPaint effects can only be
allocated on the heap.

This patch makes the constructors of SkAnnotation non-public and instead
provides factory methods for creating these objects on the heap.

BUG=skia:2187
R=reed@google.com, mtklein@google.com, scroggo@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/181703003

git-svn-id: http://skia.googlecode.com/svn/trunk@13605 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Thu, 27 Feb 2014 03:02:34 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13604 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDM: also run benches once.
commit-bot@chromium.org [Wed, 26 Feb 2014 23:01:57 +0000 (23:01 +0000)]
DM: also run benches once.

Also:
  - make GrMemoryPoolBenches threadsafe
  - some tweaks to various DM code
  - rename GM::shortName() to getName() to match benches and tests

On my desktop, (289 GMs, 617 benches) x 4 configs, 227 tests takes 46s in Debug, 14s in Release.  (Still minutes faster than running tests && bench && gm.)  GPU singlethreading is definitely the limiting factor again; going to reexamine whether that's helpful to thread it again.

BUG=skia:
R=reed@google.com, bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/178473006

git-svn-id: http://skia.googlecode.com/svn/trunk@13603 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBlendTest: implicit casts -> explicit casts
commit-bot@chromium.org [Wed, 26 Feb 2014 21:40:07 +0000 (21:40 +0000)]
BlendTest: implicit casts -> explicit casts

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13595

R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/181503003

git-svn-id: http://skia.googlecode.com/svn/trunk@13602 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd point count to lua SkPath.
commit-bot@chromium.org [Wed, 26 Feb 2014 21:38:47 +0000 (21:38 +0000)]
Add point count to lua SkPath.

Add some scripts for classifying rrects and counting complex clip combinations.

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/181843004

git-svn-id: http://skia.googlecode.com/svn/trunk@13601 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoUpstream changes from Android
commit-bot@chromium.org [Wed, 26 Feb 2014 21:35:17 +0000 (21:35 +0000)]
Upstream changes from Android

R=scroggo@google.com, reed@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/176963003

git-svn-id: http://skia.googlecode.com/svn/trunk@13600 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert "Revert of Add getReducedClipStack to lua canvas (https://codereview.chromium...
bsalomon@google.com [Wed, 26 Feb 2014 20:22:32 +0000 (20:22 +0000)]
Revert "Revert of Add getReducedClipStack to lua canvas (https://codereview.chromium.org/180283004/)"

This reverts commit efded03a38d6147caaf2d951638d27fdd47eed64.

Fixes builds

Review URL: https://codereview.chromium.org/181903002

git-svn-id: http://skia.googlecode.com/svn/trunk@13599 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline_server: use new intermediate JSON format as described in https://goto...
commit-bot@chromium.org [Wed, 26 Feb 2014 19:05:20 +0000 (19:05 +0000)]
rebaseline_server: use new intermediate JSON format as described in https://goto.google.com/ChangingRbsJson

There are still some places in the frontend (HTML+Javascript) code where
we assume we are handling expectations vs actuals, but there are just a few
and we should be able to remove them easily in a coming CL.
At that point, the frontend will work just as well for displaying any set
of image pairs.

BUG=skia:1919
NOTRY=True
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/178253010

git-svn-id: http://skia.googlecode.com/svn/trunk@13598 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Add getReducedClipStack to lua canvas (https://codereview.chromium.org...
commit-bot@chromium.org [Wed, 26 Feb 2014 18:32:44 +0000 (18:32 +0000)]
Revert of Add getReducedClipStack to lua canvas (https://codereview.chromium.org/180283004/)

Reason for revert:
breaking a bunch of builds

Original issue's description:
> Add getReducedClipStack to lua canvas
>
> Committed: http://code.google.com/p/skia/source/detail?r=13594

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/181653004

git-svn-id: http://skia.googlecode.com/svn/trunk@13597 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix SampleApp build
bsalomon@google.com [Wed, 26 Feb 2014 18:12:11 +0000 (18:12 +0000)]
Fix SampleApp build

TBR=reed@google.com

Review URL: https://codereview.chromium.org/181833002

git-svn-id: http://skia.googlecode.com/svn/trunk@13596 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBlendTest: implicit casts -> explicit casts
commit-bot@chromium.org [Wed, 26 Feb 2014 17:51:00 +0000 (17:51 +0000)]
BlendTest: implicit casts -> explicit casts

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/181503003

git-svn-id: http://skia.googlecode.com/svn/trunk@13595 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd getReducedClipStack to lua canvas
commit-bot@chromium.org [Wed, 26 Feb 2014 17:50:08 +0000 (17:50 +0000)]
Add getReducedClipStack to lua canvas

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/180283004

git-svn-id: http://skia.googlecode.com/svn/trunk@13594 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoupdate comments within expectations/gm/ignored-tests.txt
commit-bot@chromium.org [Wed, 26 Feb 2014 17:30:43 +0000 (17:30 +0000)]
update comments within expectations/gm/ignored-tests.txt

(SkipBuildbotRuns)
NOTREECHECKS=True
NOTRY=True
R=reed@android.com
TBR=reed

Author: epoger@google.com

Review URL: https://codereview.chromium.org/179023004

git-svn-id: http://skia.googlecode.com/svn/trunk@13593 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoLet DM run unit tests.
commit-bot@chromium.org [Wed, 26 Feb 2014 16:31:22 +0000 (16:31 +0000)]
Let DM run unit tests.
  - refactor GYPs and a few flags
  - make GPU tests grab a thread-local GrContextFactory when needed as we do in DM for GMs
  - add a few more UI features to make DM more like tests

I believe this makes the program 'tests' obsolete.

It should be somewhat faster to run the two sets together than running the old binaries serially:
  - serial: tests 20s (3m18s CPU), dm 21s (3m01s CPU)
  - together: 27s (6m21s CPU)

Next up is to incorporate benches.  I'm only planning there on a single-pass sanity check, so that won't obsolete the program 'bench' just yet.

Tested: out/Debug/tests && out/Debug/dm && echo ok
BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13586

R=reed@google.com, bsalomon@google.com, mtklein@google.com, tfarina@chromium.org

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/178273002

git-svn-id: http://skia.googlecode.com/svn/trunk@13592 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdjusts one Win7 bench expectation (googlespreadsheetdashed, scalar1.1_gpu).
commit-bot@chromium.org [Wed, 26 Feb 2014 16:19:21 +0000 (16:19 +0000)]
Adjusts one Win7 bench expectation (googlespreadsheetdashed, scalar1.1_gpu).

BUG=skia:2163
NOTRY=true
R=rmistry@google.com
TBR=rmistry@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/178363012

git-svn-id: http://skia.googlecode.com/svn/trunk@13591 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBuilder class for SkLayerRasterizer.
commit-bot@chromium.org [Wed, 26 Feb 2014 13:27:37 +0000 (13:27 +0000)]
Builder class for SkLayerRasterizer.

Provide builder class to make SkLayerRasterizer immutable. We have to keep the
addLayer() methods for now because they are used in Chrome. They will be removed
once this changed has been rolled into Chrome.
An added benefit of this is that this class can only be allocated on the heap.

BUG=skia:2187
R=reed@google.com, scroggo@google.com, mtklein@google.com

Author: dominikg@chromium.org

Review URL: https://codereview.chromium.org/176873004

git-svn-id: http://skia.googlecode.com/svn/trunk@13590 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 26 Feb 2014 03:02:00 +0000 (03:02 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13589 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoCheck in today's exhaustive blend experiments.
commit-bot@chromium.org [Tue, 25 Feb 2014 21:31:03 +0000 (21:31 +0000)]
Check in today's exhaustive blend experiments.

BUG=skia:
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/179733005

git-svn-id: http://skia.googlecode.com/svn/trunk@13588 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRevert of Let DM run unit tests. (https://codereview.chromium.org/178273002/)
commit-bot@chromium.org [Tue, 25 Feb 2014 20:02:09 +0000 (20:02 +0000)]
Revert of Let DM run unit tests. (https://codereview.chromium.org/178273002/)

Reason for revert:
broke tests

Original issue's description:
> Let DM run unit tests.
>   - refactor GYPs and a few flags
>   - make GPU tests grab a thread-local GrContextFactory when needed as we do in DM for GMs
>   - add a few more UI features to make DM more like tests
>
> I believe this makes the program 'tests' obsolete.
>
> It should be somewhat faster to run the two sets together than running the old binaries serially:
>   - serial: tests 20s (3m18s CPU), dm 21s (3m01s CPU)
>   - together: 27s (6m21s CPU)
>
> Next up is to incorporate benches.  I'm only planning there on a single-pass sanity check, so that won't obsolete the program 'bench' just yet.
>
> Tested: out/Debug/tests && out/Debug/dm && echo ok
> BUG=skia:
>
> Committed: http://code.google.com/p/skia/source/detail?r=13586

R=bsalomon@google.com, mtklein@google.com, tfarina@chromium.org, mtklein@chromium.org
TBR=bsalomon@google.com, mtklein@chromium.org, mtklein@google.com, tfarina@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: reed@google.com

Review URL: https://codereview.chromium.org/179403010

git-svn-id: http://skia.googlecode.com/svn/trunk@13587 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoLet DM run unit tests.
commit-bot@chromium.org [Tue, 25 Feb 2014 19:32:15 +0000 (19:32 +0000)]
Let DM run unit tests.
  - refactor GYPs and a few flags
  - make GPU tests grab a thread-local GrContextFactory when needed as we do in DM for GMs
  - add a few more UI features to make DM more like tests

I believe this makes the program 'tests' obsolete.

It should be somewhat faster to run the two sets together than running the old binaries serially:
  - serial: tests 20s (3m18s CPU), dm 21s (3m01s CPU)
  - together: 27s (6m21s CPU)

Next up is to incorporate benches.  I'm only planning there on a single-pass sanity check, so that won't obsolete the program 'bench' just yet.

Tested: out/Debug/tests && out/Debug/dm && echo ok
BUG=skia:
R=reed@google.com, bsalomon@google.com, mtklein@google.com, tfarina@chromium.org

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/178273002

git-svn-id: http://skia.googlecode.com/svn/trunk@13586 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoChange comment for inverse_paths GM in ignored-tests.txt
bsalomon@google.com [Tue, 25 Feb 2014 18:54:34 +0000 (18:54 +0000)]
Change comment for inverse_paths GM in ignored-tests.txt

BUG=skia:2222

Review URL: https://codereview.chromium.org/180213002

git-svn-id: http://skia.googlecode.com/svn/trunk@13585 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline extractbitmap GMs, as the test itself changed
commit-bot@chromium.org [Tue, 25 Feb 2014 18:28:53 +0000 (18:28 +0000)]
rebaseline extractbitmap GMs, as the test itself changed

NOTRY=True
TBR=bsalomon

Author: reed@google.com

Review URL: https://codereview.chromium.org/180153002

git-svn-id: http://skia.googlecode.com/svn/trunk@13584 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoEnable the SSSE3 files to be built for Android when SSSE3 is not present.
commit-bot@chromium.org [Tue, 25 Feb 2014 18:14:08 +0000 (18:14 +0000)]
Enable the SSSE3 files to be built for Android when SSSE3 is not present.

Committed: http://code.google.com/p/skia/source/detail?r=13547

R=reed@google.com, mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/169753004

git-svn-id: http://skia.googlecode.com/svn/trunk@13583 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoallow skia flags to be specified in a skia file, but reference by chrome's skia_commo...
reed@google.com [Tue, 25 Feb 2014 18:13:22 +0000 (18:13 +0000)]
allow skia flags to be specified in a skia file, but reference by chrome's skia_common.gypi

in support of https://codereview.chromium.org/180083002/ which will land after this CL is visible in Chrome

R=bungeman@google.com

Review URL: https://codereview.chromium.org/180063003

git-svn-id: http://skia.googlecode.com/svn/trunk@13582 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agorebaseline rrect gms
bsalomon@google.com [Tue, 25 Feb 2014 18:10:18 +0000 (18:10 +0000)]
rebaseline rrect gms

Review URL: https://codereview.chromium.org/180113002

git-svn-id: http://skia.googlecode.com/svn/trunk@13581 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix valgrind bot errors introduced in f84722e4777.
commit-bot@chromium.org [Tue, 25 Feb 2014 18:01:37 +0000 (18:01 +0000)]
Fix valgrind bot errors introduced in f84722e4777.

NOTREECHECKS=true
NOTRY=true
R=robertphillips@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/179843003

git-svn-id: http://skia.googlecode.com/svn/trunk@13580 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for https://codereview.chromium.org/177963003/
commit-bot@chromium.org [Tue, 25 Feb 2014 16:46:25 +0000 (16:46 +0000)]
Rebaselines for https://codereview.chromium.org/177963003/

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
NOTRY=true
NOTREECHECKS=true
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/179723004

git-svn-id: http://skia.googlecode.com/svn/trunk@13579 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaseline canvas-layer-state (PDF only).
senorblanco@chromium.org [Tue, 25 Feb 2014 15:49:07 +0000 (15:49 +0000)]
Rebaseline canvas-layer-state (PDF only).
Remove expectations for now-passing tests.

TBR=reed@google.com

Review URL: https://codereview.chromium.org/179403007

git-svn-id: http://skia.googlecode.com/svn/trunk@13578 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoARM Skia NEON patches - 25 - S32A_D565_Opaque_Dither clean/bugfix/speed
commit-bot@chromium.org [Tue, 25 Feb 2014 10:54:32 +0000 (10:54 +0000)]
ARM Skia NEON patches - 25 - S32A_D565_Opaque_Dither clean/bugfix/speed

BlitRow565: S32A_D565_Opaque_Dither: some improvements

    - Supports ARGB and ABGR
    - Less magic numbers
    - Reduced instruction count : 5-25% speedup
    - Fixed indentation, removed some commented and useless code

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/177963003

git-svn-id: http://skia.googlecode.com/svn/trunk@13577 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 25 Feb 2014 03:05:18 +0000 (03:05 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@13576 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoThis is intended to make it easier for us to be backwards compatible.
commit-bot@chromium.org [Tue, 25 Feb 2014 02:16:10 +0000 (02:16 +0000)]
This is intended to make it easier for us to be backwards compatible.

R=reed@google.com, bsalomon@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/178383003

git-svn-id: http://skia.googlecode.com/svn/trunk@13575 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd SK_API to GrGLExtensions
commit-bot@chromium.org [Tue, 25 Feb 2014 02:14:57 +0000 (02:14 +0000)]
Add SK_API to GrGLExtensions

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/177653007

git-svn-id: http://skia.googlecode.com/svn/trunk@13574 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoSimplify GM-as-bench code.
commit-bot@chromium.org [Mon, 24 Feb 2014 23:25:49 +0000 (23:25 +0000)]
Simplify GM-as-bench code.

Tested: bench --match GM
running bench [870 540] GM:convex_poly_clip

BUG=skia:
R=bsalomon@google.com, mtklein@google.com, brian@thesalomons.net

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/178893002

git-svn-id: http://skia.googlecode.com/svn/trunk@13573 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd some SkPath lua functions
commit-bot@chromium.org [Mon, 24 Feb 2014 21:59:29 +0000 (21:59 +0000)]
Add some SkPath lua functions

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/178243002

git-svn-id: http://skia.googlecode.com/svn/trunk@13572 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoFix ChromeOS build broken in f84722e4777
commit-bot@chromium.org [Mon, 24 Feb 2014 21:39:01 +0000 (21:39 +0000)]
Fix ChromeOS build broken in f84722e4777

NOTREECHECKS=true
NOTRY=true
R=scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/178413003

git-svn-id: http://skia.googlecode.com/svn/trunk@13571 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoBuild Skia for a bare-bones embedded Linux system.
commit-bot@chromium.org [Mon, 24 Feb 2014 20:22:34 +0000 (20:22 +0000)]
Build Skia for a bare-bones embedded Linux system.

Motivation:

    I have downloaded a barebones Linux system built for 64-bit ARM
    from linaro.org and a ARMv8 Foundation Model from arm.com to run
    it on.  This will let us build and test Skia on ARM64 before we
    aquire hardware to allow that.  This CL introduces the changes to
    the build files necessary to build Skia on a barebones embedded
    Linux system.  I tested it with the aarch64 GCC compiler provided
    by linaro.org.

Changes:

    Add a "barelinux" target_os for the DEPS file.  Add an optional
    git download of zlib.

    Changes to gyp files: these changes abstract out libpng, libz, and
    giflib so that images.gyp doesn't know whether they are static or
    dynamically linked.  I also add the variables skia_giflib_static,
    skia_libpng_static, skia_zlib_static, and skia_freetype_static,
    all of which default to false but when set to true will override
    the behavior of the giflib, libpng, zlib, and freetype build
    targets to require them to build statically.  Also, the
    skia_no_fontconfig variable turns off use of the fontconfig service.

Scripts in platform_tools/barelinux/bin:

    arm64_download - this script downloads the Linaro's ARMv8 Aarch64
toolchain and minimal embedded Linux system as well as ARM's
foundation model.  The required files are mirrored on Google
Cloud.  The script then starts a emulated Arm64 Linux system in
the background.  After the boot is complete, you can SSH into the
system at port 8022 via user@localhost.  The SSH key will be
downloaded into the working directery as well.

download_deps - Uses gclient to download Skia's dependencies for a
    bare Linux system (the normal dependecies plus giflib, libpng, and
    zlib.)

barelinux_make - this script builds a version of skia that does
    not depend on external libraries, perfect for putting in an
    embedded system running Linux.  Assumes you have run download_deps
    first.

To test:
    To build a barelinux target, use the barelinux_make script.

    To build for a armv8 system: skia_arch_type=arm arm_neon=0 armv7=1
    armv8=1 arm_thumb=0 skia_arch_width=64 and set the CC and CXX
    variables to point at the cross-compiler downloaded by
    arm64_download.

R=djsollen@google.com, scroggo@google.com, borenet@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/152513007

git-svn-id: http://skia.googlecode.com/svn/trunk@13570 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoRebaselines for https://codereview.chromium.org/158973002/
djsollen@google.com [Mon, 24 Feb 2014 19:53:45 +0000 (19:53 +0000)]
Rebaselines for https://codereview.chromium.org/158973002/

This catches the remaining configs for the GPU that were not caught
with the original rebaseline.

R=robertphillips@google.com

Review URL: https://codereview.chromium.org/177373005

git-svn-id: http://skia.googlecode.com/svn/trunk@13569 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadd isClipEmpty() -- encourage clients to call this rather than checking clipFoo...
reed@google.com [Mon, 24 Feb 2014 19:38:20 +0000 (19:38 +0000)]
add isClipEmpty() -- encourage clients to call this rather than checking clipFoo() results

BUG=skia:
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/177073006

git-svn-id: http://skia.googlecode.com/svn/trunk@13568 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd getClipStack method to lua SkCanvas
commit-bot@chromium.org [Mon, 24 Feb 2014 18:59:48 +0000 (18:59 +0000)]
Add getClipStack method to lua SkCanvas

R=reed@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/177933003

git-svn-id: http://skia.googlecode.com/svn/trunk@13567 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoDo not define SK_SUPPORT_DEEPCOPYTO_CONFIG in Skia.
commit-bot@chromium.org [Mon, 24 Feb 2014 18:51:43 +0000 (18:51 +0000)]
Do not define SK_SUPPORT_DEEPCOPYTO_CONFIG in Skia.
Clean up our callers who depend on the deprecated function.

R=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/178003003

git-svn-id: http://skia.googlecode.com/svn/trunk@13566 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoAdd DRRect to debugger
commit-bot@chromium.org [Mon, 24 Feb 2014 17:28:55 +0000 (17:28 +0000)]
Add DRRect to debugger

R=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/177683003

git-svn-id: http://skia.googlecode.com/svn/trunk@13565 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoI believe this makes it clearer what is going on; namely:
commit-bot@chromium.org [Mon, 24 Feb 2014 17:24:15 +0000 (17:24 +0000)]
I believe this makes it clearer what is going on; namely:
saveLayers cause their enclosing MC state to become a prefix for their child canvas calls. In such cases we don't want to inadvertently close the nesting MC state but when we do (i.e., when the saveLayer's restore is seen) we want to also restore the nesting MC state to be the current one.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/176413002

git-svn-id: http://skia.googlecode.com/svn/trunk@13564 2bbb7eff-a529-9590-31e7-b0007b416f81

10 years agoadjust one mac bench range.
commit-bot@chromium.org [Mon, 24 Feb 2014 16:37:45 +0000 (16:37 +0000)]
adjust one mac bench range.

BUG=skia:2163
NOTRY=true
R=robertphillips@google.com
TBR=robertphillips@google.com

Author: bensong@google.com

Review URL: https://codereview.chromium.org/177533004

git-svn-id: http://skia.googlecode.com/svn/trunk@13563 2bbb7eff-a529-9590-31e7-b0007b416f81