Piotr Szawdyński [Thu, 8 Jan 2015 16:39:55 +0000 (17:39 +0100)]
[M34-Merge] Attempt to gracefully handle renderer process crashes
The current chromium-efl tries to handle renderer process crashes by
invoking "webprocess,crashed" EFL callback on the EWebView. The callback
is expected to set the value of event_info to true and delete the
EWebView instance for which the crash did happen. After the callback is
invoked the crashed EWebView would be in an unusable state. Using it
would immediately cause the UI process to crash.
The problem with the current approach is only efl_webview_app actually
implements the callback. Other applications like mini_browser,
com.samsung.browser or com.samsung.email do not even register it. The
end result is webprocess crashes can actually bring down the entire app.
This defeats the purpose of chromium multi-process architecture.
This patch solves the problem by re-creating WebContents after the
renderer crash. The "webprocess,crashed" is now only used as a
notification mechanism. The embedder handling it is only responsible for
informing the user about the fact and possibly loading another page. If
it does not handle the callback the engine will show a simple error
page. The behaviour aligns chromium-efl with WebKitEfl behaviour.
Original patches:
1) "Attempt to gracefully handle renderer process crashes" by Piotr Tworek
http://165.213.202.130:8080/#/c/69203
2) "Handle rendenrer crashes in efl_webview_app properly" by Piotr Tworek
http://165.213.202.130:8080/#/c/69448
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10194
Reviewed by: Janusz Majnert, Min-Soo Koo
Change-Id: I52407fbcd672f7726fb34bb83e911e6a784a149c
Signed-off-by: Piotr Szawdyński <p.szawdynski@samsung.com>
Piotr Sieduszewski [Fri, 9 Jan 2015 15:49:56 +0000 (16:49 +0100)]
Test for ewk_geolocation_permission_reply
This test check accept and reject to access to localization data.
This test will fail if GPS is off or no received signal.
This is a cherry-pick from http://165.213.202.130:8080/73122
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9556
Reviewed by: Janusz Majnert, Min-Soo Koo, Piotr Tworek, commitbot
Change-Id: I1d69d8a5dca48c4741f5b8a41af2ce8ed0e03e9b
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Piotr Tworek [Fri, 9 Jan 2015 16:31:18 +0000 (17:31 +0100)]
Hide content_shell URL bar when running in test mode
A couple of layout tests fail because they expect the web contents to
have the a size of 800x600 px. This value is given to the application
during init stage, but EFL shell uses it as the size of the application
window. It means the value is divided between the webview and URL bar.
The size of the URL bar depends on the current EFL theme so we can't
easilt resize the window to compensate for the difference.
Fortunately the URL bar is not actually needed by the tests themselves.
We can simply disable it, when running them. To detect such situation
--dump-render-tree flag is used. Chromium always specifies it when
running layout tests. In fact the flag is used to enable layout
test specific code paths in the upstream content_shell code.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9684
Reviewed by: Antonio Gomes, Min-Soo Koo
Change-Id: I99f25b8ccd2f73677db94270ea4093f8d1d57dcf
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Wojciech Bielawski [Thu, 8 Jan 2015 13:10:05 +0000 (14:10 +0100)]
Refactor implementation for ewk_certificate_policy_decision* API
_Ewk_Certificate_Policy_Decision objects shall be destroyed after the user
takes decision with adequate API. Since policy decision may be suspended,
lifetime of _Ewk_Certificate_Policy_Decision needs to be passed over to API
functions. Similar behavior is needed for other API visible objects such as
_Ewk_Geolocation_Permission_Request, that's why common implementation is
provided in Ewk_Suspendable_Object class.
Modified tests:
utc_blink_ewk_certificate_policy_decision_ceritificate_pem_get_func
utc_blink_ewk_certificate_policy_decision_suspend_func
utc_blink_ewk_certificate_policy_decision_url_get_func
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9518
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek
Change-Id: I80608c70247ebd02aac7b3bf1785b048143a3dcc
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Piotr Sieduszewski [Tue, 30 Dec 2014 10:57:52 +0000 (11:57 +0100)]
fixup! TC utc_blink_ewk_view_app_name_user_agent_set_func refactoring.
In case the 2nd argument is an empty string (not NULL)
ewk_view_application_name_for_user_aget_set should return EINA_TRUE.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9327
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek
Change-Id: I39256561b5c54fc91f1095e0ec03b814b5e8b69b
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Wojciech Bielawski [Wed, 7 Jan 2015 13:47:29 +0000 (14:47 +0100)]
Implementation of unit tests for ewk_view_main_frame_get
New test added:
utc_blink_ewk_view_main_frame_get_func
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9577
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek
Change-Id: Ib5ce656323fc0892f1b83853a956e25b3112e598
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Piotr Sieduszewski [Fri, 9 Jan 2015 12:30:01 +0000 (13:30 +0100)]
Test for ewk_autofill_profile_id_get
This test create 2 profiles, and check a id of it.
This reverts http://165.213.202.130:8080/71877
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9542
Reviewed by: Janusz Majnert, Piotr Tworek, SeungSeop Park, commitbot
Change-Id: Id958bf3a108b1a6b74d424f7e3a87166ab9015eb
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Piotr Tworek [Thu, 18 Dec 2014 13:07:35 +0000 (14:07 +0100)]
Minor improvements of desktop build scripts.
This is a collection of small fixes I've recently made while playing
with chromium-efl build_desktop.sh script. Those are:
1. Improve argument parsing. Previous code needed 2 forks and a pipe to
parse every single argument passed to the script. The same
functionality can be achieved by only using shell built-in commands.
It's more efficient and IMO easier to read.
2. Use integer comparison operations for variables which are supposed to
have only integer values.
3. Clean-up script help message.
4. Use find instead of inefficient for loop to find files newer than
jhbuild stamp.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9215
Reviewed by: Antonio Gomes, Kamil Klimek
Change-Id: If390100b05a362f4ac33a63684210d7990533068
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Yi Shen [Fri, 7 Nov 2014 19:22:13 +0000 (11:22 -0800)]
[Tizen][Dev] Enable favicon path in WebContentsDelegateEfl::DidFinishLoad
This patch 1) enables favicon path in DidFinishLoad() since no crash observed
anymore; 2) validates favicon before starting downloading it.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7883
Reviewed by: Antonio Gomes, Piotr Tworek, commitbot
Change-Id: I89f9c0ebac94fefd72f23a13aecd23ef7caa3bd8
Signed-off-by: Yi Shen <yi.shen@samsung.com>
msu.koo [Thu, 8 Jan 2015 07:18:23 +0000 (16:18 +0900)]
Revert "[Tizen][MM][Webrtc] Enable H/W accelerated H.264 support for WebRTC on Tizen"
To reflect the landed commit on dev, this commit is reverted.
This reverts commit
021c7e8a3f463970ea425eb28715c165160bc56a.
Together with: I561e35cb4ea2626a12b8d2a42f04f01bd12f9378
Reviewed by: Min-Soo Koo, Vinod Keshav
Change-Id: I98dbeed585f45fb57b36e38cbe5ead78193d7a01
Signed-off-by: msu.koo <msu.koo@samsung.com>
Balazs Kelemen [Wed, 10 Sep 2014 15:49:34 +0000 (11:49 -0400)]
Add support for cross-compilation
crosscompile is useful for development purposes. I do not intend to replace
gbs with this, just to help developers (including myself) doing their job quicker.
The idea is that once you built with gbs you can use it's build root together
with the tizen sdk to crosscompile for mobile.
Co-authored by Balazs Kelemen and Tomasz Olszak.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6110
Reviewed by: Balazs Kelemen, Piotr Tworek, SeungSeop Park
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Iff75f7e0917aa7141fb075d46a3734c94cbf5a8b
Signed-off-by: Balazs Kelemen <b.kelemen@samsung.com>
Signed-off-by: Tomasz Olszak <t.olszak@samsung.com>
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Tomasz Czekala [Wed, 7 Jan 2015 14:35:15 +0000 (15:35 +0100)]
Remove Memory Sampler
Patch removes Memory Sampler EWK interface and mocks it's implementation.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9553
Reviewed by: Antonio Gomes, Janusz Majnert
Change-Id: I2ab75cd46034efb8c646e7eef0db369d926920c7
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Piotr Sieduszewski [Wed, 7 Jan 2015 08:00:00 +0000 (09:00 +0100)]
Implement EWK web context inspector APIs
Implementation of:
- ewk_context_inspector_server_start
- ewk_context_inspector_server_stop
Classes WebContext and EWebContest implement methods for starting and
stopping debug tools supported by a class DevToolsDelegateEfl
TC for ewk_context_inspector_server_start try start inspector server on:
- specified port and open url
- unspecified port and open url with returned port
- used port
TC for ewk_context_inspector_server_stop try:
- stop WebInspector without start (expexted fail).
- start WebInspector on port 11111 TCP and stop it.
To see if it's stopped:
- try open page on this port, and
- run WebInspector on the same port again.
This patch contains following patches:
http://165.213.202.130:8080/68795
http://165.213.202.130:8080/69030
http://165.213.202.130:8080/69486
http://165.213.202.130:8080/69059
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9549
Reviewed by: Janusz Majnert, Kamil Klimek, Min-Soo Koo, Piotr Tworek
Change-Id: Ib769a0d27fb45b4f90a8f8afa1722955f5c77eb4
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Filip Piechocki [Tue, 16 Dec 2014 14:03:40 +0000 (15:03 +0100)]
Fixed UTC for ewk_view_add_with_session_data.
The test was expecting that the webview won't be created
for the NULL session data, while according to WebKit-EFL code,
this should create empty webview. Current implementation
does exactly this, so the test case had to be fixed.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9537
Reviewed by: Piotr Tworek, SeungSeop Park
Reviewed by: Janusz Majnert, Piotr Tworek, SeungSeop Park, commitbot
Change-Id: I50d64f7083457c834aba4bd2338d22dfdf48c056
Signed-off-by: Filip Piechocki <f.piechocki@samsung.com>
Wojciech Bielawski [Thu, 11 Dec 2014 15:50:30 +0000 (16:50 +0100)]
[M34-Merge] Implementation of properties required by ewk_settings_extra_feature_get/set API
Default properties values were taken from webkit-efl implementation.
Note that none of these properties is used so in fact they do not change
behaviour of webview. They're simply stored for future reference.
This is a cherry-pick from: http://165.213.202.130:8080/#/c/68642/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9531
Reviewed by: Kamil Klimek, Piotr Tworek, SeungSeop Park
Change-Id: Ia0a1d08cbd0f5701b859325bde393a6a10d3a820
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Tomasz Czekala [Mon, 22 Dec 2014 16:17:22 +0000 (17:17 +0100)]
Add support for error domain in Ewk_Error
This patch is a merge of the following patches:
http://suprem.sec.samsung.net/gerrit/#/c/4951/ by Kamil Klimek
http://165.213.202.130:8080/#/c/72583/ by Wojciech Bielawski
http://165.213.202.130:8080/#/c/70134/ by Piotr Tworek
http://165.213.202.130:8080/#/c/69708/ by Nguyen Van Canh
And fixes required for migrating to m40
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9850
Reviewed by: Janusz Majnert, Min-Soo Koo, Piotr Tworek
Change-Id: If8ad47e247a6909d08c67fd4830e0bf15065322e
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Lukasz Krok [Fri, 19 Dec 2014 14:46:29 +0000 (15:46 +0100)]
Changing way of test page loading in utc_blink_ewk_view_contents_pdf_get test
Loading google.com page by ewk_view_url_set() resulted with error:
"Unsafe attempt to load URL from frame with URL
http://www.google.pl/?gfe_rd=cr&ei=qzWUVKGhG4jBVLOZgsAP.
Domains, protocols and ports must match"
It looks like google.com page changed recently
and made cross-domain call in the test.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9539
Reviewed by: Janusz Majnert, Min-Soo Koo
Change-Id: I05d84269fe1885060bb62188086a8cd35bf0ff6a
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
Filip Piechocki [Tue, 9 Dec 2014 15:33:12 +0000 (16:33 +0100)]
Improving ewk_shutdown and ewk_view_add to avoid potential crashes.
EwkGlobalData instance pointer was deleted in ewk_shutdown()
but not NULLed, so it was not reinitialized after calling
EwkGlobalData::Ensure() which may lead to crash. There was
not EINA_SAFETY_CHECK on Evas pointer in ewk_view_add which
may lead to invalid object creation and crash.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9253
Reviewed by: Antonio Gomes, Min-Soo Koo, Piotr Tworek, commitbot
Change-Id: I2a3ebeabd0f2141cb71eafb0304d83bcbbde9f5a
Signed-off-by: Filip Piechocki <f.piechocki@samsung.com>
Piotr Sieduszewski [Thu, 18 Dec 2014 13:34:32 +0000 (14:34 +0100)]
fixup! Allow local git clone in sync_repos.sh
It add exit error code to sync_reps.sh if it can't rebase,
for example when a file in src/ was modified.
Reviewed by: Antonio Gomes, Janusz Majnert, Piotr Tworek, SeungSeop Park (OOO ~ 4/Jan/2015), commitbot
Change-Id: I6a128283b69e6cb16906439880d1c3535e3c9e2c
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
ws29.jung [Tue, 9 Dec 2014 10:16:07 +0000 (19:16 +0900)]
Implementation of Web Speech Feature
Issue: Migration of Web Speech Feature from M34 to M40
This patch enable the tts Web Speech feature in M40.
This structure is same as other platform's Web Speech Feature,
but it didn't have implemented speech synthesiszer object.
Also Tizen has it's own tts engine so we need to have class
that communicate with tts engine.
M34 Patch lists:
http://165.213.202.130:8080/#/c/71224/
http://165.213.202.130:8080/#/c/71751/
http://165.213.202.130:8080/#/c/72468/
Initialy it was implemented under src/ and impl/ folders,
but now everything has been moved into impl/.
However, this patch only enable M40 mobile feature, not TV.
Cherry-picked from merged code (M40 dev)
http://165.213.202.130:8080/#/c/72994/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9648
Reviewed by: Piotr Tworek, Viatcheslav Ostapenko
Reviewed by: Piotr Tworek, Viatcheslav Ostapenko, commitbot
Change-Id: I0b89b0490e2552c28c248808994bc396806c0e69
Signed-off-by: ws29.jung <ws29.jung@samsung.com>
Daniel Waślicki [Mon, 15 Dec 2014 10:30:28 +0000 (11:30 +0100)]
Scroll and zoom to focused editable element
Scroll to focused editable element on text input state changed.
It will cause that when input field is focused, page will be
scrolled and zoomed to this element.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9614
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park (OOO ~ 4/Jan/2015)
Change-Id: If4887013e97eba381112109295ec65aba751f6b6
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
SeungSeop Park [Fri, 19 Dec 2014 05:14:36 +0000 (14:14 +0900)]
Add owners for tizen beta/ branch.
Change-Id: I9baa7965ae6019fd27df2ec029230fd51e7d1a08
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Tomasz Czekala [Wed, 17 Dec 2014 09:22:37 +0000 (10:22 +0100)]
fixup! Add Tizen-platform implementation of RenderViewObserver
Adds internal pointer validation for WebNode objects.
In file render_view_observer_efl.cc, object WebNode is intensively used.
Its methods call is usually using corresponding calls of internal Node pointer.
Since class WebNode has default constructor it can have this internal pointer
uninitialized. It was the main cause of the crash in taping cases. Adding
validation of this internal Node pointer in function DoHitTest() (using
WebNode::isNull() method), solved problem.
This is a cherry-pick of the following patch:
http://165.213.202.130:8080/#/c/68604/ by Sergiy Prutskov
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9525
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: Ib623ae17bb658c9871c20a40545f83de292a5038
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
SeungSeop Park [Fri, 12 Dec 2014 09:22:17 +0000 (18:22 +0900)]
[M40 Beta] Setup Tizen Beta branch beta/m40_2214_t
Base chromium version is 40.0.2214.38 from linux beta channel.
Downstream patches have been rebased onto it.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9805
Change-Id: I7bfb0545f8f77cd1eaa893833ad6d4cd20ba9c08
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Kamil Lysik [Mon, 8 Dec 2014 15:46:35 +0000 (16:46 +0100)]
Enable ewk_settings_text_* API
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9535
Change-Id: Ib806bc6427a0a1bf0283e853d71a41b7e503b8fe
Signed-off-by: Kamil Lysik <k.lysik@samsung.com>
Piotr Grad [Mon, 8 Dec 2014 14:03:52 +0000 (15:03 +0100)]
[Tizen][M34-Merge] Refactoring Implementation of Edge Effect
Current implementation for settings getter in edge effect was not working
at all because its dependencies were removed. With this patch settings are
taken directly from ewebview, also code in edge effect is refactored to
not double the code.
Original patch: http://suprem.sec.samsung.net/gerrit/#/c/5824/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8943
Change-Id: I30a5cb696b6334b4a222388c7e4b0c627df771cb
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Michał Pakuła vel Rutka [Wed, 10 Dec 2014 11:21:00 +0000 (12:21 +0100)]
[M-34 Merge] Fix remember passwords option
Chromium didn't respect remembering passwords setting from browser.
Control of remembering passwords function has been divided into
two parts: Auto filling and Saving.
Now user can turn off saving passwords (via Remember passwords from
browser settings), so he won't get popup with Question to save password,
but he will still get previously saved passwords auto filled.
This auto filling is controlled independetly by Auto fill forms setting
from Browser Settings.
Currently, Auto fill component didn't respect Remember form data setting from browser.
It seems that Blink engine haven't got an option to switch off saving form data
without switching off autofilling form data at all. This patch adds such functionality.
Chromium has a function to autofill forms with previously
created profiles in browser. On click on one of form
fields, popup shows up with suggestions which profile data
may be insterted. Our port showed only information regarding
specific clicked field. This kind of information may be
insufficient for e.g. when we have two profiles with the
same name. Now it also shows label what allows to detect
which profile is suggested more precisely. The same labels
are also used in generic chromium.
This is a combination of three commits:
Fixed remember password option
http://165.213.202.130:8080/#/c/70377/
Fixed remember form data option
http://165.213.202.130:8080/#/c/70753/
by Michał Obrembski, and
Added labels to autofill popup suggestions.
http://165.213.202.130:8080/#/c/70459/
by Daniel Waślicki.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9544
Change-Id: I51f745401814bd84f7c19519fe91e22ceee5345f
Signed-off-by: Michał Pakuła vel Rutka <m.pakula@samsung.com>
hh4813.kim [Wed, 10 Dec 2014 07:22:06 +0000 (16:22 +0900)]
[M34-Merge] Implement Form Navigation
Implement Form Navigation for Tizen
Original Patch:
1) Implement to form Navigation. by Dongjun Kim
http://suprem.sec.samsung.net/gerrit/#/c/6615/
2) Patch for form navigation by Dongjun Kim
http://165.213.202.130:8080/#/c/69920/
Together with: Iba2f5fbb8cd6b6dcb636cfe633dc708c3897229d
Together with: Ib8ef1740109f1163ef979ab7cfb4bb9fcaea6935
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9255
Change-Id: I1f80a50a73266510b1abded5d287e6e4afbd42bc
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Piotr Sieduszewski [Mon, 8 Dec 2014 12:45:14 +0000 (13:45 +0100)]
Add virtual ConsoleMessage in class utc_blink_ewk_base
This method makes it easier to catch console message in unit tests
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9556
Change-Id: Ie690042643c605b2f075c2041278dc2a9fbd73b0
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Filip Piechocki [Wed, 10 Dec 2014 09:45:35 +0000 (10:45 +0100)]
Improving ewk_shutdown to avoid potential crashes.
EwkGlobalData instance pointer was deleted in ewk_shutdown()
but not NULLed, so it was not reinitialized after calling
EwkGlobalData::Ensure() which may lead to crash.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9253
Change-Id: I0dcc8eb8b8066908c54e399df4e75a7c8e42cac2
Signed-off-by: Filip Piechocki <f.piechocki@samsung.com>
Kamil Klimek [Thu, 13 Nov 2014 08:39:56 +0000 (09:39 +0100)]
Implement content_shell app on top of chromium-efl library.
This is an uglier, but faster solution to get content_shell
running on top of EFL chromium port. Instead of splitting
EFL port into content-EFL/EWK implementation parts it
it creates an efl specific content_shell_efl target that
depends on both original content_shell_lib and chromium-efl.
In essence it builds content_shell on top of both EFL content
API port and EWK specific content implementations.
Although the solution abuses chromium module boundaries and
introduces a lot of potentially invalid objects into
content_shell app it allows content_shell to work
with current M34 code base without refactoring it. The main
goal is to get something working fast without breaking
chromim-efl.
Long term, the EFL specific implementations of internal content
interfaces (RenderWidgetHostView, WebContentsView) should be
separated from EWK specific parts, moved into content module or
it's dependencies and original content_shell app should be used.
As it is right now the EWK specific objects like EWebView or
EWebContext will be invalid in cases where the content API is
initialized by content_shell app.
Added M40 Fixes
Original patch: http://165.213.202.130:8080/#/c/68602/
Original author: Piotr Tworek <p.tworek@samsung.com>
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5594
Change-Id: Ifc8c3ba660245d8637a49643239f111ecd3f0480
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
Kamil Klimek [Wed, 19 Nov 2014 10:56:28 +0000 (11:56 +0100)]
Remove Aura dependencies from EFL port
The goal of the patch is to remove last remaining dependencies
on Aura toolkit from the EFL port. Aura and EFL/Elementary are
both UI toolkits with very similar feature set. There should
be no need for both of them in one chromium port.
Original patch: http://165.213.202.130:8080/#/c/68601/
Original author: Piotr Tworek <p.tworek@samsung.com>
Change-Id: I7fffcb4e7e44e8cc4d56ee48d66584bfe7ade341
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
msu.koo [Wed, 12 Nov 2014 12:01:26 +0000 (21:01 +0900)]
[Tizen][MM][Webrtc] Enable H/W accelerated H.264 support for WebRTC on Tizen
- Implemented TizenVideoDecodeAccelerator.
- Implemented TizenVideoEncodeAccelerator.
Current implementation uses xvimagesink without linking with Surface.
Surface adaptaion is on progress at
http://107.108.218.239/bugzilla/show_bug.cgi?id=9181
Together with: If40fcf90a2faba576bd3f975e10eb0e5820f92ff
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8362
Change-Id: I22bc491d2f70354ecbdc18cce8a2bd68bfd2e999
Signed-off-by: msu.koo <msu.koo@samsung.com>
Karol Furmaniak [Fri, 5 Dec 2014 09:55:28 +0000 (10:55 +0100)]
Fix ewk_view_not_found_error_page_load api.
[Problem]: Error page is not loading properly in mini_browser,
when ewk_view_not_found_error_page_load api is used.
[Solution]: Invoke LoadNotFoundErrorPage IPC message
on ewk_view_not_found_error_page_load.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8777
Change-Id: I769d43a13579150e25f6bd399eba341f79808ce7
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
Grzegorz Spryszynski [Thu, 4 Dec 2014 14:01:05 +0000 (15:01 +0100)]
Wrong output on double tap
[Problem] After double tap there is no zoom in/out.
[Solution] Enable double tap feature and proper handle
TAP_DOWN event.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8947
Change-Id: I090ba2058f91e110db16fcc0c6155bbdc7288cc4
Signed-off-by: Grzegorz Spryszynski <g.spryszynsk@samsung.com>
Piotr Sieduszewski [Tue, 2 Dec 2014 12:58:50 +0000 (13:58 +0100)]
Fixup! Implementation "unfocus,direction" callback
unknown escape sequence: '\>'
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9483
Change-Id: I28e0f3e1bc468377b66e5aaacf0bed6405b02f39
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Piotr Sieduszewski [Thu, 27 Nov 2014 09:39:24 +0000 (10:39 +0100)]
Script to run ITC and UTC
It expand script to build and run ITC and UTC test.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9483
Change-Id: I0a3c79fb5a6338692966bec9fb6a7f8a4908fd5e
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Piotr Sieduszewski [Thu, 27 Nov 2014 11:26:36 +0000 (12:26 +0100)]
Script to run all internal EWK unit tests
This script:
- build EFL and EWK test
- prepare mobile device
- install EFL and EWK test
- run all test by one (restart device at 50 tests)
Results is put to test_log/log.htm (It redirect to file with name of last commit title (first line))
This html file have a tests results, and links to html files with history of results for selected the test.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9483
Change-Id: Iace9a61cc9e79d4e31e97d490c3c3403ade1b528
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Wojciech Bielawski [Wed, 3 Dec 2014 13:11:56 +0000 (14:11 +0100)]
Implementation of ewk_home_directory_set API.
In this patch there are two APIs implemented - set(public) & get(private).
This is because 'get' API is necessary in tests for 'set' API.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=4994
This is a cherry-pick from: http://165.213.202.130:8080/#/c/69072/
This is a cherry-pick from: http://165.213.202.130:8080/#/c/69454/2
Change-Id: I14fdb472855e5ed733507afb55eb4a9c645e16a8
Signed-off-by: Wojciech Bielawski <w.bielawski@samsung.com>
Youngsoo Choi [Wed, 3 Dec 2014 14:22:51 +0000 (23:22 +0900)]
[Hotfix] Enabling feature of finding text and zooming for VD Demo
This patch is for VD Demo.
The feature of finding text and zooming is enabled.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9607
Change-Id: I2e5c5eac8a6e57cfee62b77f1bf7e36e77c19291
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Dongjun Kim [Thu, 30 Oct 2014 12:57:01 +0000 (21:57 +0900)]
Bringup SelectPicker (multiple and single)
Currently SelectPicker is only enabled in Android and Mac. This patch
will bring it up in Tizen with some issue fixes.
Original patches:
1) Patch for selectpicker(single type)
http://suprem.sec.samsung.net/gerrit/#/c/3801
2) Implement SelectPicker (multi type)
http://suprem.sec.samsung.net/gerrit/#/c/4007
3) fixup! Implement SelectPicker (multi type) by Piotr Tworek
http://165.213.202.130:8080/#/c/68998
4) Added check for null pointer (popupPicker) by Daniel Waslicki
http://165.213.202.130:8080/#/c/69229
5) Select picker refactoring by Mateusz Kacprzak
http://165.213.202.130:8080/#/c/69196
6) fixup! Patch for selectpicker(single type) by Mateusz Kacprzak
http://165.213.202.130:8080/#/c/69576
7) Hightlight item selected with radio button. by Daniel Waslicki
http://165.213.202.130:8080/#/c/70605
8) Wrong item selected in multiple select picker. by Karol Furmaniak
http://165.213.202.130:8080/#/c/70803
9) fixup! Hightlight item selected with radio button. by Daniel Waslicki
http://165.213.202.130:8080/#/c/70868
10) Remove clearing pointer to WebExternalPopupMenu by Daniel Waslicki
http://165.213.202.130:8080/#/c/70751
11) Hotfix to item list in popup picker. by Kamil Lysik
http://165.213.202.130:8080/#/c/71275
12) Add conversion of dropdown list label to efl markup. by Karol Furmaniak
http://165.213.202.130:8080/#/c/71924
Together with: I95836747247529064cc59267a58f656f45c7e7d4
Together with: I9e8451a037e9669feabd543f222ca9173546c50c
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=4833
Change-Id: I4abfc20de4637e48e91f4406ecde803da26dff4e
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Shanmuga Pandi M [Wed, 3 Dec 2014 09:57:21 +0000 (18:57 +0900)]
Added kWaitForFrameComplete switch to enable glFinish call for rendering current frame.
This switch is required for enabling glFinish call for rendering
current frame, related commit:
http://165.213.202.130:8080/#/c/72671/
Original Author: m.nataraj
Original Patch: http://165.213.202.130:8080/#/c/72740/1
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9098
Change-Id: I3ab7f74432809af63ce5d11ab611365fde5ca728
Signed-off-by: m.nataraj <m.nataraj@samsung.com>
Signed-off-by: Shanmuga Pandi M <shanmuga.m@samsung.com>
Youngcheol Kang [Wed, 3 Dec 2014 01:55:04 +0000 (10:55 +0900)]
Added codes for working Media Element with CAPI-MEDIA-PLAYER
- Enabled the CAPI-MEDIA-PLAYER instead of the Gstreamer
- Enabled the Native Pixmap instead of the Appsink
- Added codes for working Media Element on Tizen TV
- Updated the Prehawk binary version 1018.5 which recommended by VD.
Current patch depends on the below,
- [Original ME/MSE Patchset]
: http://165.213.202.130:8080/#/c/72298/9 (#9)
- [NATIVE PIXMAP Patchset]
: http://165.213.202.130:8080/#/c/72689/5 (#5)
Change-Id: If31c3c72205cfc1b8adcbb19e10b22b2d91e9f00
Signed-off-by: Youngcheol Kang <ychul.kang@samsung.com>
Sergey Stepantsov [Wed, 12 Nov 2014 06:06:42 +0000 (15:06 +0900)]
Porting of async snapshot functionality for Tizen platform
This method works for direct rendering mode.
Browser process requests snapshot image from the render process through
IPC message ViewMsg_GetSnapshotFromRender
and render process takes pixel data from required region and returns
it through IPC ViewHostMsg_SnapshotDataReceived.
Together with: Ie5939e2923be0ad8baec93afc8410ca6bdd1d4d1
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7698
Signed-off-by: Sergey Stepantsov <s.stepantsov@samsung.com>
Change-Id: Ic96f41818001017a195f730ea7051e570ca3e636
shads.bc [Wed, 19 Nov 2014 12:00:13 +0000 (17:30 +0530)]
Upmerge of ME & MSE with in impl/
Basic MediaElement(ME) and MediaSourceExtension(MSE) works with this patch.
This patch involves impl side changes.
Able to see video for ME and MSE on Mobile using Pixamp backend.
Original base patches(M34)-Merged
ME-Initial patch: http://suprem.sec.samsung.net/gerrit/#/c/478/
MSE-Initial patch: http://suprem.sec.samsung.net/gerrit/#/c/6471/
ME-Pixmap initial patch: http://suprem.sec.samsung.net/gerrit/#/c/6078/
Together with: If5a6d59312062d2c245e75698467c745f34a0fb3
Together with: I32fd39b3c9fb8a62bda5d8cf565b10a656a380de
Together with: I5a1640a96738c7f0c8249d19f73e7087b03fbcd3
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7920
Change-Id: I11879b88dbc2c3057559d7357b0c3d4640183523
Signed-off-by: shads.bc <shads.bc@samsung.com>
uzair.jaleel [Thu, 27 Nov 2014 14:44:38 +0000 (20:14 +0530)]
Support for rendering video frame of type NATIVE PIXMAP(PATCH 2) 1)Implementation for creating,binding and destroying egl image for each tile. 2)Utility functions for creating efl pixmap,DRI2 drawables and native buffer manager support.
http://107.108.218.239/bugzilla/show_bug.cgi?id=4908
Original author: Prashant Kisanrao Nevase
Change-Id: I5a1640a96738c7f0c8249d19f73e7087b03fbcd3
Signed-off-by: uzair.jaleel <uzair.jaleel@samsung.com>
Dongjun Kim [Fri, 21 Nov 2014 05:52:16 +0000 (14:52 +0900)]
[Tizen][M34-Merge] Bringup Inputpicker (Color, Date picker)
Patches for bringup "input-picker" already merged to M40 from M34_beta.
But it does not sufficiently complete. Color picker is still crashed
and date picker is not shown up. And we resolved crash issue using
patch for "crash in color picker", but date picker still have a problem.
This patch for bug fix in color and date picker.
Detail list of bugs and description of solution are below.
1. Crash in color picker.
[Problem] Crash was occured when click the color picker.
"elm_layout_add()" and "elm_datetime_add()" functions are need to
evas object when click the input picker. We sent evas object using
elm_object_parent_widget_get() in latest code and it returned to NULL.
So, elm_ctxpopup_add() was crashed by NULL object.
[Solution] We change to "m_ewkView" instead of
"elm_object_parent_widget_get(m_ewkView)".
2. Showing up black-screen in "date, week, month, time".
[Problem] Control of data picker is consist of next 6 element.
"date, week, month, time, datetime, datime-local"
In previous, it used different logic while creating the popup.
"datetime, datetime-local" does work and it used elm_layout_add()
when creating. "date, week, month, time" doesn't work and
it doen't used elm_layout_add().
[Solution] Change to use same logic in date picker.
3. Always set to "1900-01-01" in date picker.
[Problem] Parsing logic for input parameter is completely wrong
in date picker. It always set to "1900-01-01" regardless of paramter.
[Solution] Implement parsing logic for input parameter.
4. Clean-up the code.
- 80 characters per line.
- Change function name.
- Remove unused code.
Original patches:
1) fixup! fix for color picker crash by Robert Jadczak
http://165.213.202.130:8080/#/c/68840/
2) Fixed displaying HTML5 control popups by Piotr Szawdyński
http://165.213.202.130:8080/#/c/69160/
3) Correcting InputPicker implementation by Lukasz Krok
http://165.213.202.130:8080/#/c/70036
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8765
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I47c0bad9e770f1b1eead43fc245c9a2eeb80335c
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
Kamil Lysik [Thu, 4 Dec 2014 11:18:58 +0000 (12:18 +0100)]
Ewk_Frame_Ref refactoring. ewk_frame_is_main_frame implementation.
Refactored Ewk_Frame_Ref to not use void* in forward declaration.
Now Ewk_Frame_Ref is pointer to _Ewk_Frame, which inherits from
tizen_webview::Frame.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9523
Reviewed by: Antonio Gomes, SeungSeop Park
Signed-off-by: Kamil Lysik <k.lysik@samsung.com>
Change-Id: I199a830bd4aa2c72c8fd2d3aacc7d40e2b86ce1a
Lukasz Krok [Wed, 10 Dec 2014 11:50:12 +0000 (12:50 +0100)]
ewk_view_contents_pdf_get API was not working
The ewk_view_contents_pdf_get API and coresponding unit test failed.
After enabling two flags and removing macros surrounding pieces of code,
the functionality starts to work.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9539
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: Id1ed3f0d7dc1009aade86e9266c54601d81fe2a7
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
Piotr Sieduszewski [Tue, 9 Dec 2014 13:47:26 +0000 (14:47 +0100)]
Add test ewk_view_geolocation_permission_callback_set to gypi file
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9571
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: I76436980a4f8201613e9bc7e5014aafe675df3d3
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Michał Pakuła vel Rutka [Wed, 9 Jul 2014 15:33:08 +0000 (17:33 +0200)]
[M34-Merge] ewk_view_url_request_set should load URL along with the given header and body of the HTTP request
Implemented API for POST and GET methods. HEAD, PUT and DELETE cannot
be easily implemented in chromium and, from what we know, are not used
by any application using this API. This function implementation passes
the Tizen Compatibility Tests.
Null pointers were passed to std::string constructor and raised an exception
This is a combination of two commits:
http://165.213.202.130:8080/#/c/71637/ by Piotr An Nguyen and
http://165.213.202.130:8080/#/c/71717/ by Kamil Klimek
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8268
Reviewed by: Antonio Gomes, Kamil Klimek
Change-Id: Ib6a28c86699a13653af30ef613f7af79089614ff
Signed-off-by: Michał Pakuła vel Rutka <m.pakula@samsung.com>
Tomasz Czekala [Wed, 10 Dec 2014 16:12:50 +0000 (17:12 +0100)]
Changed policy decision mechanism to use content resource throttle API
Handling decision in NetworkDelegateEfl::OnHeadersReceived caused
a lot of troubles due to insufficient amount of information needed
to distinguish between page resources and downloadable files.
This patch replaces the original mechanism used with resource throttles.
It allows us to make better decisions regarding how to handle the
content we're dealing with.
Removed unnecessary code duplicating existing engine functionalities.
This patch contains following patches:
http://suprem.sec.samsung.net/gerrit/#/c/6663/ by Kamil Klimek
http://165.213.202.130:8080/#/c/68742/ by Michal Stefanczyk
http://165.213.202.130:8080/#/c/69608/ by Marcin Łapiński
http://165.213.202.130:8080/#/c/70054/ by Kamil Klimek
http://165.213.202.130:8080/#/c/71925/ by Maciej Skrzypkowski
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9488
Reviewed by: Kamil Klimek, Piotr Tworek, SeungSeop Park
Change-Id: I76a2799586c4902327add2e6827a05ae2b4ddd3c
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
SeungSeop Park [Thu, 11 Dec 2014 13:53:27 +0000 (22:53 +0900)]
[M41] Exclude RenderThemeChromiumLinux.cpp from the build
This is necessary for M41, where RenderThemeChromiumLinux.cpp is newly added.
Patch fixes a linking error for desktop build by excluding it.
Note that this patch can be landed into M40, because it's fine to exclude an
non-existing file in gyp.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9758
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: Iabc4cc31cb8c052d7121246fa55a499e39a654a6
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Michal Poteralski [Mon, 8 Dec 2014 14:28:25 +0000 (15:28 +0100)]
fixup! Refactor disambiguation popup
Disambiguation popup uses elm_ctxpopup_add which requires
DisambiguationPopup.edj. Unfortunately DisambiguationPopup.edc is NOT added to
chromium-efl.gyp file, hence the .edj file is not created. The patch adds
DisambiguationPopup.edc to chromium-efl.gyp file, thus the .edj file will be
created.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8939
Reviewed by: Antonio Gomes, Piotr Tworek
Change-Id: I7d98fb72ef544e9741ba7e44cc8c7cb554a4cb4e
Signed-off-by: Michal Poteralski <m.poteralski@samsung.com>
Dongjun Kim [Sun, 23 Nov 2014 14:23:20 +0000 (23:23 +0900)]
[M34-Merge] Fix crash in popup javascript windows
Crash was brought about by replacing default text display by scrolling
interface, when displayed text is too long. It seems, that there is some
fault in interface object destruction inside efl. Fix includes placing
displayed text into label in all cases (no matter how long it is). In case of
long text, this label is reused as content of scroll layout. Thus object to
display text is not recreated and replaced, like it was before. Also some
additional improvements in memory handling were added. Color of displayed
text is changed into black (instead of white on white background as it was
before).
Original patches:
1) Fix crash in popup javascript windows by Sergiy Prutskov
http://165.213.202.130:8080/#/c/69650/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6019
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I653bd0b3753e904e97c9a701ed854bb5e9466bf1
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
KANGYONG PARK [Thu, 11 Dec 2014 05:21:40 +0000 (14:21 +0900)]
Disable touchEvent and Pinch in DTV
These are unnecessary features in DTV, and not supported
in WebKit based DTV browser either.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9754
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I793e7320a446fdf1d16d75ef9bb7f31f4440fe7f
Signed-off-by: KANGYONG PARK <kaka.park@samsung.com>
Tomasz Czekala [Thu, 11 Dec 2014 11:35:54 +0000 (12:35 +0100)]
fixup! Implementn FaviconDatabase.
Database file cannot be created if directory, where it should be created,
does not exist. This patch ensures that path setting function handles
such situation and creates the directory when needed.
This is port of the following patch:
http://165.213.202.130:8080/#/c/69718/ by Filip Piechocki
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9521
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: I03d1a5fa26e275eae20e0a300d536813a3d67b57
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
Piotr Sieduszewski [Tue, 2 Dec 2014 16:29:04 +0000 (17:29 +0100)]
Change file names to be consistent with the name of tested functions
ewk_view_application_name_for_user_agent_get
ewk_view_application_name_for_user_agent_set
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9483
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park
Change-Id: Ib20b22193e16f527ec6a174450244f7a59375a2b
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Piotr Sieduszewski [Wed, 10 Dec 2014 17:57:08 +0000 (18:57 +0100)]
Rename class name to be consistent with the name of tested functions
ewk_back_forward_list_item_at_index_get
ewk_back_forward_list_n_back_items_copy
ewk_back_forward_list_n_forward_items_copy
ewk_certificate_policy_decision_certificate_pem_get
ewk_certificate_policy_decision_url_get
ewk_context_cache_disabled_set
ewk_settings_loads_images_automatically_set
ewk_user_media_permission_request_suspend
ewk_view_notification_closed
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9483
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park
Change-Id: Iebb2ad9a40d332d5b81f49601f23262278662c86
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Lukasz Krok [Thu, 23 Oct 2014 13:49:17 +0000 (15:49 +0200)]
[M34-Merge] Allow to get the UA string from environment variable.
Some TCT tests depend on specific UA string.
In order to avoid ifdefs and preparing binaries
specific for TCT tests, this patch makes it possible
to get the UA from environment variable.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8270
Reviewed by: Kamil Klimek, SeungSeop Park
Change-Id: Ife8fffabe42c091ef31c4c9ff055926ab63dea2a
Signed-off-by: Michał Pakuła vel Rutka <m.pakula@samsung.com>
Piotr Sieduszewski [Fri, 5 Dec 2014 12:03:31 +0000 (13:03 +0100)]
Rename file and class to be consistent with name of tested function
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9566
Reviewed by: Kamil Klimek, Piotr Tworek, SeungSeop Park
Change-Id: I083f5e85664e34caf76a8ca6eb0666a978364885
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
Antonio Gomes [Wed, 10 Dec 2014 19:38:55 +0000 (15:38 -0400)]
Unwanted context menu appears during text input
Whenever a text is inserted into a text field, context
menu was shown (untranslated), causing an unpleasant
user experience.
Problem was that upon any selection bounds change (which
includes caret selection), context menu was being shown.
Patch fixes this issue by not calling ::ShowContextMenu upon
selection bounds change (represented here by caret selection
changes on text insertion). Instead, context menu is shown as
a response to mouse_up events.
Original patch: http://suprem.sec.samsung.net/gerrit/#/c/6082/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9489
Reviewed by: Kamil Klimek, Viatcheslav Ostapenko
Change-Id: I369a9f1ddcf2481a4c2e63409280bba87d2baf87
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Wed, 10 Dec 2014 21:05:59 +0000 (17:05 -0400)]
Remove duplicated DEFINEs (-Dbleh) from gyp_chromiumefl.sh
All the defines patch is removing are defined with equivalent
value in gyp_chromiumefl.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9215
Reviewed by: Balazs Kelemen, Min-Soo Koo
Change-Id: I2f72b39132dee01671849e84af85e50fd253d035
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Wed, 10 Dec 2014 03:04:22 +0000 (19:04 -0800)]
Remove duplicated inclusion of chromium-efl.gypi.
chromium-efl.gypi is included from both build/gyp_chromiumefl.sh
and build/gyp_chromiumefl. Although it is harmless, we should
stick with one or another.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9215
Reviewed by: Piotr Tworek, SeungSeop Park
Change-Id: I7ca760c8fd00b6a691497531777d8016eeee09e3
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Piotr Sieduszewski [Tue, 9 Dec 2014 11:25:36 +0000 (12:25 +0100)]
Implement test for ewk_view_html_string_load
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9569
Reviewed by: Kamil Klimek, SeungSeop Park
Change-Id: I6a302bcd9f7526837034c5635eff48766fe479bc
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
dayoung.shin [Fri, 28 Nov 2014 16:40:19 +0000 (11:40 -0500)]
Override requestPermission to make connection to EWK API for geolocation
On M40, there are several changes regarding get permission from users
for HTML5's Geolocation feature. These set of changes cut the flow to
enter EWK API for Geolocation, so the feature failed to be used.
This patch fix the bug by doing following things.
- Override requestPermission function to call
GeolocationPermissionContextEfl's RequestPermission.
It's callback connect to EWK API, so that the EWK API can ask user
to use or not Geolocation feature.
- Add privilege regarding location. This makes Geolocation feature can
work on Tizen device.
* NOTE *
* Geolocation would work after applying following patch.
* http://165.213.202.130:8080/#/c/72765
*
* This patch is based on following patches.
* http://165.213.202.130:8080/#/c/72692/
* http://165.213.202.130:8080/#/c/71158/
Bug : http://107.108.218.239/bugzilla/show_bug.cgi?id=8610
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I013ae646577885ffc798c7eec5ad48c54ff9121f
Signed-off-by: dayoung.shin <dayoung.shin@samsung.com>
Dongwoo Joshua Im [Wed, 10 Dec 2014 03:09:21 +0000 (12:09 +0900)]
Add p.tworek in the S_TRUNK_OWNERS
Add the new owner of the top directory of chromium-efl
- Piotr Tworek <p.tworek@samsung.com>
Change-Id: Ic7f60cb5f617b6ccc4f46767e177617730509924
Signed-off-by: Dongwoo Joshua Im <dw.im@samsung.com>
Antonio Gomes [Tue, 9 Dec 2014 23:18:32 +0000 (15:18 -0800)]
De-duplicate DEFINEs in chromium-efl.gyp
Define them in target_defaults, and make them
available to all targets in that file.
Bug: 107.108.218.239/bugzilla/show_bug.cgi?id=9215
Reviewed by: Balazs Kelemen, SeungSeop Park
Change-Id: Icb5a5220a6df4e12c8b07704bec1d5f4f549b34b
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Marcin Krakowiak [Mon, 24 Nov 2014 15:17:10 +0000 (16:17 +0100)]
[Tizen] Implement tap sound effect
When tapping on clickable content, tap sound should be played to notify tap
operation.
This patch handles ET_GESTURE_TAP in RenderWidgetHostViewEfl::HandleGesture,
to check what context is in the tap place. When it is
TW_HIT_TEST_RESULT_CONTEXT_LINK, then sound_effect_tizen::playLinkEffect is
called. Feedback library provides functionality of playing sound.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8946
Reviewed by: Antonio Gomes, Laszlo Gombos, SeungSeop Park, Viatcheslav Ostapenko
Change-Id: I318a10f3e085be9ed1fd4d31123d7720e343cd73
Signed-off-by: Marcin Krakowiak <m.krakowiak@samsung.com>
Piotr Tworek [Mon, 8 Dec 2014 11:52:41 +0000 (12:52 +0100)]
Remove disable-web-security flag from EFL port defaults.
The presence of the flag breaks CORS tests.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9485
Reviewed by: Kamil Klimek, Min-Soo Koo, SeungSeop Park
Change-Id: I39419d8bb23939687e54d1af7ca598f74c508b0f
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
SeungSeop Park [Mon, 8 Dec 2014 04:45:01 +0000 (13:45 +0900)]
Set fetch url and remote tracking when switching to new branch in sync_repos.sh
Previously, following problems were observed in switching to newer branch:
- fetch url was not properly set up for new branch,
- remote tracking branch was not properly set up for the new branch.
As a result, a new branch in each s-* repo might not get updated on
subsequent calls of sync_repos.sh. Even worse, when "git pull" is executed
thereafter, git would try to merge old branch (which is where FETCH_HEAD
points to) into new branch, yielding a lot of merge conflicts.
Patch fixes such issues by adding fetch url for remote branch and
setting a new local branch to track the corresponding remote branch.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9666
Reviewed by: Antonio Gomes, Tomasz Olszak, Viatcheslav Ostapenko
Change-Id: If17020eeaac84854697193ffb1046b7a4ecca27d
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Kamil Lysik [Fri, 5 Dec 2014 08:53:06 +0000 (09:53 +0100)]
Fix build_desktop.sh script to building ewk unittests. Reviewed by: Antonio Gomes, Kamil Klimek, SeungSeop Park
Change-Id: Ie4f3bc6a2760767b5028da9cae1aee481c2c3063
Signed-off-by: Kamil Lysik <k.lysik@samsung.com>
dayoung.shin [Tue, 2 Dec 2014 10:34:32 +0000 (19:34 +0900)]
Enable "enable-view-port-meta" only on mobile
Some Web pages[1] are reported to have the following problems on displaying:
- Failed to use whole screen of TV
- Left aligned, rather than center aligned.
[1] naver.com, ebay.com, tumblr.com
This happens due to a bug on the implementation of viewport-meta tag
on Chromium. So the problems described above are also reproducible on
open source Chromium desktop version if #enable-viewport-meta at
chrome://flags is enabled.
Also, bug affects TV and desktop's only because Tizen mobile forces the
use of it's own viewport-meta width size regardless of the declared
viewport-meta width size by user.
Therefore, this patch fixes the bug by taking the following actions:
- Only allow AppendSwitch of kEnableViewportMeta for OS_TIZEN_MOBILE.
Bug : http://107.108.218.239/bugzilla/show_bug.cgi?id=9389
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I177a6cf97013217869fa50040e23d2a153991d40
Signed-off-by: dayoung.shin <dayoung.shin@samsung.com>
SeungSeop Park [Mon, 8 Dec 2014 04:13:35 +0000 (13:13 +0900)]
Run gclient runhooks in sync_repos.sh
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9197
Reviewed by: Antonio Gomes, Viatcheslav Ostapenko
Change-Id: I066e69164f6fc1f4b51e90083c5995c06f8176b3
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
Kamil Klimek [Tue, 25 Nov 2014 08:39:57 +0000 (09:39 +0100)]
[Tizen][M34-Merge] Fix screen size reporting.
The current EFL implementation of gfx::Screen interface is not entirely
correct. The main differences compared to Android and Aura ports are:
1. The screen size is reported in px, not in DIP.
2. Screen size is always reported in portrait mode.
As a direct result of the differences most mobile pages relying on CSS3
media queries will render incorrectly. They'll use style sheet version
designed for devices with larger screen devices that the device has.
One example of such page is http://slideshare.net.
This patch changes current gfx::Screen implementation to report proper
screen size values in DIP for both portrait and landscape orientations.
Original patch: http://165.213.202.130:8080/#/c/70582/
Original author: Piotr Tworek <p.tworek@samsung.com>
Original bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6308
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=5594
Reviewed by: Antonio Gomes, Viatcheslav Ostapenko
Change-Id: I21a7baeaf0a9b05dab7d00d255cc611589e784bf
Signed-off-by: Kamil Klimek <k.klimek@partner.samsung.com>
Dongwoo Joshua Im [Mon, 8 Dec 2014 07:53:21 +0000 (16:53 +0900)]
Mark kangil.han as INACTIVE
Introduce 'INACTIVE' into the S_TRUNK_OWNERS,
and mark kangil.han as inactive.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9643
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I3e01e9e028c06eb60e48e6e22476d39de622835a
Signed-off-by: Dongwoo Joshua Im <dw.im@samsung.com>
KANGYONG PARK [Fri, 5 Dec 2014 08:01:01 +0000 (17:01 +0900)]
fixup! Refactor disambiguation popup
Disable disambiguation popup in DTV.
It is unnecessary feature in DTV, and disambiguation
popup is not supported in DTV browser base on Webkit.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9647
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I2814d80df2d96bc874bca105f1216d56a5bd0d30
Signed-off-by: KANGYONG PARK <kaka.park@samsung.com>
Piotr Grad [Sat, 13 Sep 2014 06:02:24 +0000 (08:02 +0200)]
[M34-Merge] NULL or empty user agent string was not handled properly.
Used ContentClientEfl::GetUserAgent as it returns default user agent for tizen.
Removed EwebView::overridden_user_agent_ as ewk api should return current UA.
Removed invalid use of memory form UA getters.
The fix changes EWebView::SetUserAgent to only use
WebContents::SetUserAgentOverride API. This is what desktop chrome uses
for UA override purposes.
The patch changes the logic so that "Mobile" is always added to product
part of UA string when --use-mobile-user-agent is specified. No ifdefs
required. This way the feature can be controlled entirely from one
place, command_line_efl.cc. The flag is always specified by default for
OS_TIZEN targets, but not for desktop. On desktop the user can simply
pass it when needed, ex:
./out.x64/Debug/efl_webview_app --use-mobile-user-agent
This is a combination of 5 commits:
NULL or empty user agent string was not handled properly.
http://165.213.202.130:8080/#/c/69394/
NULL or empty user agent string was not handled properly.
http://165.213.202.130:8080/#/c/69395/
fixup! NULL or empty user agent string was not handled properly.
http://165.213.202.130:8080/#/c/69475/
by Piotr Grad, and
fixup! NULL or empty user agent string was not handled properly.
http://165.213.202.130:8080/#/c/70312/
Cleanup --use-mobile-user-agent flag handling logic.
http://165.213.202.130:8080/#/c/70313/
by Piotr Tworek.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8270
Reviewed by: Kamil Klimek, Laszlo Gombos
Change-Id: Iba6d229472afb5dd0e483f8888fea5c4659cab40
Signed-off-by: Michał Pakuła vel Rutka <m.pakula@samsung.com>
Zhang-hoon Oh [Tue, 2 Dec 2014 10:39:39 +0000 (19:39 +0900)]
Set allow_running_insecure_content to true for Tizen
[Problem]
Any MSE video from http://youtube.com/tv/ is not played.
[Solution]
This patch sets WebKit Preference |allow_running_insecure_content|
to true (in Tizen's content browser client implementation)
because some content providers such as YouTube use plain http
requests to retrieve media data chunks while running in a https
page.
[Future Work]
This pref should be disabled once all the content providers
are no longer doing that.
[Reference]
Please note that, in the open source chromecast content embedder,
this WebKit Preference is set to true, also. Please refer to:
- https://codereview.chromium.org/
223143003
[Test]
To test:
- Load http://youtube.com/tv/
- Play any video.
- Look for the JavaScript console log.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9343
Reviewed by: Antonio Gomes, Min-Soo Koo, SeungSeop Park
Change-Id: Iea6385a53f1e6999991b32f3e8b38a9b8e0bb608
Signed-off-by: Zhang-hoon Oh <dennis.oh@samsung.com>
Youngsoo Choi [Mon, 1 Dec 2014 06:32:45 +0000 (15:32 +0900)]
[Hotfix][M40] Alternative to deprecated 'ViewMsg_OrientationChangeEvent'
[Issue]
Note that, In M40, IPC message 'ViewMsg_OrientationChangeEvent' has
been deprecated, to use IPC message 'ViewMsg_Resize' instead.
IPC message 'ViewMsg_Resize' delivers current orientation information
and triggers orientation changed event on renderer side.
[Resolve]
To keep that way, followings are applied.
1) Deprecated 'ViewMsg_OrientationChangeEvent'
Sending IPC message 'ViewMsg_OrientationChangeEvent' or arbitrarily
triggering IPC message 'ViewMsg_Resize' is against M40 architecture.
2) Shipping orientation information
When device rotation is changed, the orientation information needs
to be set before IPC message 'ViewMsg_Resize' is sent.
The changes of 'mini_browser.c' guarantee of current orientation
information to be always contained within IPC message 'ViewMsg_Resize'.
3) New method 'SetOrientation' and 'GetOrientation'
Those two methods are needed to send the orientation information from
rotation callback to resized callback fired by platform.
4) EWK API issue
As of now, the name of EWK API 'ewk_view_orientation_send' is not
changed although it does not send orientation event to renderer,
for supporting EWK API compatibility.
This issue will be discussed further and the API needs to be refactored.
FIXME: http://107.108.218.239/bugzilla/show_bug.cgi?id=9514
The EWK API 'ewk_view_orientation_send' may need to be deprecated,
or can be changed to something like 'ewk_view_orientation_set' later
because in M40 there is no way to directly send orientation changed
event to renderer side any more, without IPC message 'ViewMsg_Resize'.
This patch meets following WCS test cases:
>> WCS-TC-97 (JS properties on launching time)
>> WCS-TC-98 (JS properties on rotation)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9254
Reviewed by: Antonio Gomes, Min-Soo Koo
Change-Id: If2b4e5af10998b4fecef48b2fe185fdaa66b16bf
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
Dongwoo Joshua Im [Mon, 1 Dec 2014 00:54:42 +0000 (09:54 +0900)]
Revisit the owner list
Revisit the owner list due to structural changes.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9468
Reviewed by: Antonio Gomes, Kangil Han, SeungSeop Park, mohan reddy
Change-Id: Ia4e2a917fce5447bf21f70a46c104d27f2882b8f
Signed-off-by: Dongwoo Joshua Im <dw.im@samsung.com>
Taeho Kim [Fri, 5 Dec 2014 02:08:02 +0000 (11:08 +0900)]
Add Samsung Electronics BSD LICENSE
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9639
Reviewed by: Antonio Gomes, Laszlo Gombos, SeungSeop Park
Change-Id: Ia129ff04f9c15f0e1101f74cc02c0f3093910868
Signed-off-by: Taeho Kim <th81.kim@samsung.com>
msu.koo [Wed, 12 Nov 2014 10:06:02 +0000 (15:36 +0530)]
[Tizen][MM][Webrtc] Video Capture Port using CAPI
This commit is to enable the video capture port on Tizen.
- Implemented VideoCaptureDeviceFactoryTizen.
- Implemented VideoCaptureDeviceTizen using Tizen CAPI.
Together with:I9c48580455d73821b11ae0b358b43544d24bdf1e
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7942
Reviewed by: Laszlo Gombos, Min-Soo Koo, Viatcheslav Ostapenko
Change-Id: I6883a136e2ab253c31f0a0051bf108bfe598da8e
Signed-off-by: msu.koo <msu.koo@samsung.com>
Antonio Gomes [Wed, 26 Nov 2014 20:38:01 +0000 (16:38 -0400)]
Remove build/patches/webrtc.diff
This is not needed after src/third_party/webrtc got fixed:
https://webrtc-codereview.appspot.com/
27859004
"
Fix double backslashes in incoming_video_stream.cc
Originally uploaded in https://codereview.appspot.com/
149160043/.
"
Reviewed by: Balazs Kelemen, SeungSeop Park
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9215
Change-Id: I37ec2d3fba90d97262faf78b756b993e49ed67db
SeungSeop Park [Wed, 3 Dec 2014 01:24:12 +0000 (10:24 +0900)]
Add option --clean to sync_repos.sh
If this option is passed, sync_repos.sh will clean up all untracked files and
directories that are not listed in .gitigore file. However, if an untracked
diretory is managed by a different Git repository, it's not removed.
Note that the operation is applied for not only in s-* but chromium-efl repo.
The intended client for this option is, but not confined to, the buildbot.
WARNING: Be careful when using this option outside of buildbot context,
since it can blow up your local changes.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9584
Reviewed by: Antonio Gomes, Tomasz Olszak, Viatcheslav Ostapenko, mohan reddy
Change-Id: Ic2172925edd691aa3bbfc35fd035c10a0f4f2cea
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
KANGYONG PARK [Wed, 26 Nov 2014 14:16:10 +0000 (23:16 +0900)]
[Tizen] Implement tizen specific battery status manager.
This is required to have working HTML5 battery API on tizen.
This commit implements to call battery status in device.
And the status will be updated in chromium, when it is changed in device.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8614
Reviewed by: Antonio Gomes, Min-Soo Koo, SeungSeop Park
Change-Id: Ie3130646107395abe7151977b3f05c6e78402dd3
Signed-off-by: KANGYONG PARK <kaka.park@samsung.com>
Piotr Sieduszewski [Wed, 26 Nov 2014 18:02:47 +0000 (19:02 +0100)]
Refactoring ewk_view_application_name_for_user_agent_get / set
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9327
Reviewed by: Antonio Gomes, Kamil Klimek
Change-Id: I55a8fe891c66d2cc0ee655dd07a71aefc5ecaff9
Signed-off-by: Piotr Sieduszewski <p.sieduszews@samsung.com>
KANGYONG PARK [Fri, 31 Oct 2014 02:40:04 +0000 (11:40 +0900)]
[Tizen] Implementation "zoom,finished"
Implementation "zoom,finished" callback.
It is related to pinchZoom.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7719
The original author was p.sieduszews@samsung.com.
M34 patches are reorganized.
Reviewed by: Balazs Kelemen, SeungSeop Park
Change-Id: I446a481b7e4adc4eef312c28fd97072f6a33a27d
Signed-off-by: KANGYONG PARK <kaka.park@samsung.com>
Michal Poteralski [Thu, 6 Nov 2014 15:39:04 +0000 (16:39 +0100)]
[M34-Merge] Implementation and TCs for ewk_settings_scripts_can_open_windows_* and ewk_settings_scripts_window_open_*
Patch implements ewk_settings_scripts_can_open_windows_* and
and ewk_settings_scripts_window_open_* API based on webkit-efl implementation.
Implementation uses IPC so decision about opening window is made on
renderer side not browser side. I didn't add implementation in
ContentBrowserClientEfl::CanCreateWindow because this API is not called
on UI thread. It's called (by design) on IO thread and taking UI objects
(EWebView) outside UI thread is not safe. Also I didn't use
WebPreferences::javascript_can_open_windows_automatically because this
property is not used anywhere inside chromium code. Toggling this
variable has no effect.
Original commits:
http://165.213.202.130:8080/#/c/69592
http://165.213.202.130:8080/#/c/68833/
http://165.213.202.130:8080/#/c/69947/
(by Kamil Klimek <k.klimek@partner.samsung.com>)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8248
Reviewed by: Kamil Klimek, SeungSeop Park
Change-Id: Ib0cbf7777c55562dfc30e8bb9ce6e847a3b40b96
Signed-off-by: Michal Poteralski <m.poteralski@samsung.com>
Viatcheslav Ostapenko [Wed, 26 Nov 2014 00:38:12 +0000 (19:38 -0500)]
Implement Chromium Theme for Tizen.
Original patch:
1) Patch for selectpicker(single type)
http://suprem.sec.samsung.net/gerrit/#/c/3801
2) Implement SelectPicker (multi type)
http://suprem.sec.samsung.net/gerrit/#/c/4007
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=4833
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: Id659a3d17a41e6d6cccd030c8a7f6de2402bd382
Signed-off-by: Viatcheslav Ostapenko <sl.ostapenko@samsung.com>
Arnaud Renevier [Wed, 26 Nov 2014 01:28:09 +0000 (17:28 -0800)]
Do not crash when using a non attached context
Since http://165.213.202.130:8080/#/c/69045/ , browser_context_ and
web_cache_manager_ are not set at EWebContext creation anymore. This
results in a crash if we call a method that uses those members just
after creation.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9337
Reviewed by: Antonio Gomes, Viatcheslav Ostapenko
Change-Id: I10e49dc3a05d2a8fa9efdfab8319f1dd220f4ffa
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
Yi Shen [Tue, 2 Dec 2014 18:37:38 +0000 (10:37 -0800)]
[Tizen][M34-Merge] export v8 headers in devel package
This is necessary because WRT code is dependent on v8 headers.
Also added corresponding include path and CFLAGS to chromium-efl.pc.
Original gerrit: http://165.213.202.130:8080/#/c/69503/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=6096
Reviewed by: Antonio Gomes, Balazs Kelemen
Change-Id: Id370c8882619933399d38b8ff15c88426f10282c
Signed-off-by: Yi Shen <yi.shen@samsung.com>
m.nataraj [Sat, 15 Nov 2014 12:35:17 +0000 (18:05 +0530)]
Avoiding vertex attribute copy from CPU to GPU for each frame.
This is the migration patch from m34 beta to m40 dev branch. The patch
required modification in the texture coordinates as the contents were
rendered flipped both horizontally and vertically. This patch avoid
copying geometry data from cpu to gpu by creating vertex buffer objects.
Original commit: http://suprem.sec.samsung.net/gerrit/#/c/7063/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8766
Reviewed by: SeungSeop Park, Viatcheslav Ostapenko
Change-Id: I0e55e81797a649804e390243e6dce9d27d89c022
Signed-off-by: m.nataraj <m.nataraj@samsung.com>
Antonio Gomes [Tue, 30 Sep 2014 07:52:49 +0000 (09:52 +0200)]
[M34-Merge] Implement 2 geolocation APIs
Patch implements missing Geolocation APIs needed by
the com.samsung.browser application:
* ewk/efl_integration/public/ewk_geolocation.cc/h:
* ewk/efl_integration/public/ewk_view.cc/h:
Add ewk_geolocation_permission_reply and ewk_view_geolocation_permission_callback_set APIs.
When user replies to a geolocation permission request,
the callback function set in ewk_view_geolocation_permission_callback_set
is called. The ewk_geolocation_permission_reply API is
for propagating the result about geolocation permission
from client apps (e.g. WRT and Browser) back to the
browser engine. In other words, application calls this
API after getting user action.
Also, patch marks ewk_geolocation_permission_request_set as
"deprecate" given that in the browser side, its use is replaced
by ewk_geolocation_permission_reply (being added by this patch).
As seen in the patch, part of the ewk_geolocation_permission_request_set
is moved down in the pipeline to _Ewk_Geolocation_Permission_Request
class (see below).
Note that the existing code in ewk/efl_integration/public/ewk_geolocation.cc
violates various coding style conventions. To keep
consistency within the same file, I choose to follow
what is already being used.
* impl/API/ewk_geolocation_private.cc:
Implement ::SetDecision (partially moved from ewk_geolocation_permission_request_set)
and ::Suspended methods.
* impl/API/ewk_geolocation_private.h:
Make it a proper class, with getters and setters,instead of a POD.
* impl/browser/geolocation/geolocation_permission_context_efl.cc
Fix geolocation permission callback. Old smart callback based geolocation.
Original work: 165.213.202.130:8080/#/c/70204/ (Kamil Klimek)
165.213.202.130:8080/#/c/70053/ (Piotr Sieduszewski)
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8498
Reviewed by: Kamil Klimek, SeungSeop Park
Change-Id: I937e5e8713c7db095d9da901059100e3e25175b0
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Tue, 2 Dec 2014 03:26:54 +0000 (19:26 -0800)]
Bring ewk_context_memory_sampler_* back.
These APIs were wrongly removed in [1]. In order to build
t-mobile-browser app out of the box for chromium-efl/beta,
chromium-efl/dev and webkit-efl, this patch brings it back.
They are only stub APIs.
Patch reverts [1] partially.
[1] http://165.213.202.130:8080/#/c/71214/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8497
Reviewed by: Kamil Klimek, SeungSeop Park
Change-Id: I7674f8d40187db95ecca25a2ea5cf4805c922235
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
kapil.kumar [Mon, 1 Dec 2014 10:07:04 +0000 (15:37 +0530)]
[MM][WEBRTC] Allow User Media request for Camera/Mic, automatically for EFLWebViewApp.
As EFLWebViewApp doesnt have any UI dialogs to ask user,
for allowing/denying media permission requested by webpage.
So its allowed by default in webview application.
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=9477
Reviewed by: Antonio Gomes, Min-Soo Koo
Change-Id: I06d7ceb42fad8186da901e73cf45f61d21c9b134
Signed-off-by: kapil.kumar <kapil.kumar@samsung.com>
Antonio Gomes [Mon, 6 Oct 2014 04:52:50 +0000 (13:52 +0900)]
[M34-Merge] Rename ewk_context_form_password_data_clear to ewk_context_form_password_data_delete_all
API was changed in webkit-efl, and this is a chromium-efl catch up.
This is also reflected in the browser side, as per commit
deab57b0 (by junghwan.kang).
Original work: http://165.213.202.130:8080/#/c/70359/ (join.yoon)
Bug : http://107.108.218.239/bugzilla/show_bug.cgi?id=9464
Reviewed by: Antonio Gomes, Kamil Klimek, SeungSeop Park
Change-Id: I88184023f4f87e64d8b1f30aad171eaa232b6eca
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Antonio Gomes [Fri, 26 Sep 2014 11:56:27 +0000 (13:56 +0200)]
[M34-Merge] Rename ewk_context_form_candidate_data_clear() to ewk_context_form_candidate_data_delete_all()
API was changed in webkit-efl, and this is a chromium-efl catch up.
This is also reflected in the browser side, as per commit
deab57b0 (by junghwan.kang).
Original work: http://165.213.202.130:8080/#/c/70014/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8496
Reviewed by: Kamil Klimek, SeungSeop Park
Change-Id: Id70ef37703d888da2290a136e481cc9dd87a3a25
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Tomasz Czekala [Fri, 28 Nov 2014 10:00:57 +0000 (11:00 +0100)]
[M34-Merge] Support for incognito mode implementation
In chromium incognito mode works in different manner than in WebKit. In
WebKit we could toggle incognito mode for view, in chromium we must
create view in incognito mode and this option can't be toggled.
This is a merge of the following patch:
http://165.213.202.130:8080/#/c/70246/
Ieb8b70dcd73f7d589de91c4805476a20d8fc5cf5
by Kamil Klimek
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8249
Reviewed by: Kamil Klimek, SeungSeop Park
Change-Id: Ice68463efb572327074c49f78094fb258a37177d
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
chaoren.li [Tue, 21 Oct 2014 03:08:06 +0000 (11:08 +0800)]
[M34-Merge] Implementation of "geolocation,valid" smart callback
Patch implements "geolocation,valid" smart callback.
This allows the browser to grant a given webview
permission to start off the geolocation path before
GeolocationPermissionRequest object is created.
This is code migration from m34 beta to DEV.
Original patch : http://suprem.sec.samsung.net/gerrit/#/c/6962/
Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=7871
Reviewed by: Antonio Gomes, SeungSeop Park
Change-Id: I26ffb8ebf54b3ea4eb7cdfb6f7c38912ee5e8d2f
Signed-off-by: chaoren.li <chaoren.li@samsung.com>