Michal Bloch [Tue, 8 Mar 2022 17:05:56 +0000 (18:05 +0100)]
dlog_logger: rearrange readers (no logic change)
Preparation for a refactoring of the reader code.
Move subreaders away from the Android Logger reader
files since they're going to be generic.
Change-Id: I00fe88e86db1871886a3a0993b141db56101e84c
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Thu, 24 Feb 2022 06:46:37 +0000 (07:46 +0100)]
Refactor NULL check in logmetrics
While the original check was (I think) correct, it was a bit confusing,
and we got a bug report from static analysis.
Change-Id: I54a904d441a4b67434da027fb9c50fcbbbcc8e59
Karol Lewandowski [Tue, 15 Feb 2022 16:03:50 +0000 (17:03 +0100)]
Add generator for logger.ko device dependencies
This will dynamically generate needed systemd unit dependencies when logger.ko
devices are available (/dev/log_* devices are assumed to be used when these are
available due to backend autodetection).
Change-Id: I1b280d3878e6c4db5261f410722d3de84c583b60
Michal Bloch [Wed, 9 Feb 2022 18:03:46 +0000 (19:03 +0100)]
Tests: add minor overflow check
Change-Id: I1dd3280bc6499a855caf436940bd5fb756345080
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Fri, 21 Jan 2022 13:24:01 +0000 (13:24 +0000)]
Merge "Move to linux-tizen-modules-headers" into tizen
Mateusz Majewski [Wed, 19 Jan 2022 09:31:24 +0000 (10:31 +0100)]
Add timestamp correctness test
We had a bug where Android Logger kernel module accidentally returned
monotonic time instead of realtime time on some kernel versions. This
test checks whether the timestamp of a new log is somewhat close to
actual time in order to detect such bugs more easily.
Change-Id: Icd7ea0d774a15a30c1ef61860648328983f11adf
Mateusz Majewski [Wed, 19 Jan 2022 13:13:50 +0000 (14:13 +0100)]
Fix buffer usage printing in dlogutil
Without converting to unsigned long long, the calculation would overflow
when the buffer usage would get higher than around 42 MB. This doesn't
really happen, since the buffer capacity currently is not even close to
that value. However, there's no reason not to fix this.
Change-Id: Ib1a440b08ac01a1996f1542719070271d0936f79
Mateusz Majewski [Wed, 19 Jan 2022 12:20:19 +0000 (13:20 +0100)]
Fix some invalid function names in dlogutil.h documentation
Change-Id: I50a44e3b27fd913c3d4a15ac9ee14f5e2fbcdb2d
Mateusz Majewski [Thu, 20 Jan 2022 06:56:14 +0000 (07:56 +0100)]
Move gcov directory
Change-Id: Ic89cfac8f8f0ab08aafd15072edac558bc53c62c
Mateusz Majewski [Fri, 14 Jan 2022 18:49:41 +0000 (19:49 +0100)]
Move to linux-tizen-modules-headers
Change-Id: I8a981836b29ddf2c1935a7b8a2b650a71db7ab96
Michal Bloch [Mon, 10 Jan 2022 13:08:23 +0000 (14:08 +0100)]
dlogutil: better error message for disabled kmsg
Shows a hint about the 'handle_kmsg' config entry.
Change-Id: I35e748580dbb22b071bb22088dfa49ee0b5c09e1
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Wed, 29 Dec 2021 08:29:39 +0000 (09:29 +0100)]
Replace a custom loop with a simple strnlen
Change-Id: Ie7fc0a2523a770ecad436be9922325ef01923d7a
Mateusz Majewski [Wed, 29 Dec 2021 07:13:15 +0000 (08:13 +0100)]
Document auto-quit
Change-Id: I4d29565a1c769582a5dc7281acf14069b13d99bf
Karol Lewandowski [Thu, 30 Dec 2021 13:28:45 +0000 (14:28 +0100)]
Release 7.0.1
Additionally, provide a bit more information to the user why dlog_logger
process is terminating on its own.
Change-Id: Ie4e6e80960be2481b8a9dc82dc19ae7d77fc1cb0
Mateusz Majewski [Thu, 16 Dec 2021 12:41:27 +0000 (13:41 +0100)]
Terminate the daemon if it's not needed
Change-Id: Icf8d83ff134ea84c8aa3c7a869bd8394f6c2685e
Karol Lewandowski [Thu, 18 Nov 2021 13:36:36 +0000 (14:36 +0100)]
Release 7.0.0
Change-Id: I39e79ac903c29e9aaaaf14340cc304849af08b78
Michal Bloch [Fri, 19 Nov 2021 11:21:35 +0000 (12:21 +0100)]
Document the autodetector
Change-Id: I44da738539a56fd47f43513c4649d62718790042
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Fri, 19 Nov 2021 09:21:17 +0000 (10:21 +0100)]
Add autodetection integration test
Change-Id: I0bdf9dca347c9996c8b46d6ab8c469b64609349e
Mateusz Majewski [Thu, 18 Nov 2021 17:19:49 +0000 (18:19 +0100)]
Add some prose on backend autodetection
Change-Id: Ibc37f99cba8f51a3bdd40007928b469c733242eb
Karol Lewandowski [Tue, 16 Nov 2021 16:02:20 +0000 (17:02 +0100)]
Autodetect backend
Rely on backend autodetection if it's not specified explicitly in config.
Logger (/dev/log_main) driver is preferred, pipe is used as second choice.
Additionally, dlog-config-logger-backend package is integrated into regular
dlog package to always have complete configuration available.
Change-Id: I1f76b754db1adfec579b5de577c6f5eafc2ec4ed
Mateusz Majewski [Wed, 17 Nov 2021 08:40:57 +0000 (09:40 +0100)]
Disable problematic tests causing ASAN failures
One of them doesn't match the current implementation at all, but it
works outside of ASAN by accident. The other returns no ASAN issues, but
instead the results change when ASAN is enabled.
Both of these are something we should actually fix, but also something
complex and not really urgent. Let's fix these later, and just disable
them for now.
Change-Id: I643d02f34f35a9d1fab9521fda0d28ebb996a2bb
Mateusz Majewski [Wed, 17 Nov 2021 08:37:25 +0000 (09:37 +0100)]
Add ASAN build flag
Change-Id: I121e3145dd9a2a208c159363b69ef3035cb489ce
Mateusz Majewski [Fri, 12 Nov 2021 13:05:01 +0000 (14:05 +0100)]
Fix fdi_logger_wrap ASAN issue
The wrapped function -- as the name suggests -- is supposed to open the
file, but also returns its path. The tests used to only return the path
conditionally, but the tested function checks the path length, which
might fail if the path is left uninitialized. The solution is to write
the path to the buffer unconditionally.
Change-Id: Iffe4e323c258834fe7f63f2d719ce3c12fd7c60a
Mateusz Majewski [Tue, 2 Nov 2021 18:24:30 +0000 (19:24 +0100)]
Clarify a bit the entry verification
Change-Id: Ie56b714754b983ac35b1fcf224bab5c18669ae62
Mateusz Majewski [Tue, 2 Nov 2021 08:05:07 +0000 (09:05 +0100)]
Hotfix the long log condition
Change-Id: I835d43c905f0f8eb3895f86f606b39f6d17ba6a4
Michal Bloch [Fri, 15 Oct 2021 16:44:21 +0000 (18:44 +0200)]
Add some fuzz tests against garbage logs
Change-Id: Icaa353a0d6b7a9e66edc96e09dd104a79c5a6dfa
Mateusz Majewski [Thu, 28 Oct 2021 10:28:51 +0000 (12:28 +0200)]
Extend the persistent logging tests a bit
Change-Id: Ia55d584b87a0a670a854c72f3c0ab8d51af49590
Mateusz Majewski [Thu, 28 Oct 2021 07:53:04 +0000 (09:53 +0200)]
Fix the persistent log bug
Change-Id: I31a5a2c5266ccfa7d7ab19d02f4ab789f4553851
Michal Bloch [Wed, 29 Sep 2021 18:48:34 +0000 (20:48 +0200)]
Fix the handling of over/undersized logs
Change-Id: Ibdc31f97dd0fd541b4f49f3eea89f8d5888f3737
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Tue, 12 Oct 2021 07:41:08 +0000 (09:41 +0200)]
Make error reporting more accurate in logger configuration parsing
Change-Id: I0748813c458213574c6338c1ca7dd03c6a804bfb
Mateusz Majewski [Wed, 29 Sep 2021 11:04:49 +0000 (13:04 +0200)]
Replace strcpy with memcpy in tests
... as strcpy is banned in the Tizen codebase.
Change-Id: I895ad9bdb5ab806fd2f3a8579fa2767661bc8b6b
Mateusz Majewski [Mon, 27 Sep 2021 12:40:01 +0000 (14:40 +0200)]
Hotfix a pipe backend request length issue
The previous patch (and to be exact our modifications and not Hubert's
code) has caused some of the integration tests to fail. This is because
we forgot to count one of the characters. This patch fixes that.
Change-Id: Ia1fa9e2da67de755c363142aaae03c0ba8f5c69b
Hubert Kowalski [Tue, 14 Sep 2021 13:36:15 +0000 (15:36 +0200)]
Enlarged MAX_LOGGER_REQUEST_LEN to 65535 bytes
Also buffer sizes are variable and calculated a priori.
This means that buffer is as small as possible.
Change-Id: Ib26bb02bdb46e85da71a7ef13d87aa462914f4b2
Mateusz Majewski [Thu, 23 Sep 2021 06:55:37 +0000 (08:55 +0200)]
Candidate fix for the nanosecond issue
Change-Id: I768c98f1cb8c7b3b2aebcbf3c62975aaaabfc945
Hubert Kowalski [Fri, 10 Sep 2021 11:33:13 +0000 (13:33 +0200)]
Added additional pointer tests.
Additional tests have been added to libdlogutil_neg.c to check whether
a bad pointer affects dlogutil_config_connect(...).
Change-Id: I52e716bdb1b437ffbeca65ea929a91160f6f1dad
Michal Bloch [Thu, 9 Sep 2021 18:31:00 +0000 (20:31 +0200)]
Candidate fix for the zero-payload log issue
The stdout redirection mode for Android Logger can apparently produce
zero payload logs. Add a check to guard against this and also some
other cases as a safety measure.
Change-Id: I20ea6c9a49ae6b17d902b1cd21e208a949ae409f
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Hubert Kowalski [Thu, 2 Sep 2021 09:34:27 +0000 (11:34 +0200)]
Moved test from test_libdlogutil.c to libdlogutil_neg.c.
negative_main test was moved to libdlogutil_neg as this test didn't really
test anything related to integration. Essentialy it was a misplaced unit test.
So it is moved where it belongs.
Change-Id: Idc8b4b005e7d3cc5a07a771915600d559994abd1
Mateusz Majewski [Mon, 19 Jul 2021 12:59:51 +0000 (14:59 +0200)]
Reduce compiler complaints by adding helpful asserts
Change-Id: I3975c8399cfde2718aa3711d8ad1df46124bd842
Michal Bloch [Tue, 3 Aug 2021 19:11:44 +0000 (21:11 +0200)]
Mark a ton of static vars as such
Change-Id: I9bdd8fde2ee206ea017664f8a286c44bf1956023
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 3 Aug 2021 18:09:43 +0000 (20:09 +0200)]
Remove some janky unit test code
It was disabled anyway and for good reasons.
Change-Id: Id4f3f8447f1121181b4a50c22c2ee3078fc58a94
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 30 Jul 2021 11:41:12 +0000 (13:41 +0200)]
Handle timestamp fetching failure on printing
Change-Id: I81dd4ad1893fb50b12a1ce792eded08a9989f955
Michal Bloch [Thu, 5 Aug 2021 14:58:05 +0000 (16:58 +0200)]
Microoptimize a getpid call out of empty QoS check
Change-Id: Id4119faa5cefcf7e4cded2d97c55aa475b2001f2
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Hubert Kowalski [Mon, 9 Aug 2021 06:54:59 +0000 (08:54 +0200)]
Added deep_copy_dlogutil_entry_s() function and tests for it.
The deep_copy_dlogutil_entry_s function was made in effort
to create abstraction layer. Thus make code more readable.
Change-Id: If48246c3aefda46d77cbfbfb66337b7b18787da6
Mateusz Majewski [Tue, 10 Aug 2021 09:09:24 +0000 (11:09 +0200)]
Clarify overview.rst a bit
Change-Id: I63db978712631508dd75b60cfb1df1957d14944f
Mateusz Majewski [Thu, 8 Jul 2021 05:54:23 +0000 (07:54 +0200)]
Enable more redirection tests on logger
Change-Id: I8611ef19184d3c0dd68a874e57f916ed60882724
Michal Bloch [Tue, 20 Jul 2021 20:49:57 +0000 (22:49 +0200)]
Daemon write socket: rename to "conn"
Including socket paths from ".wr" to ".conn", this is done to reduce
confusion because the socket isn't actually the final writing target.
Change-Id: Ief187209ac54eb76cd404c89b208b4a8da7f795e
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Mon, 5 Jul 2021 12:04:23 +0000 (14:04 +0200)]
Fix some resource leaks.
One was O(1) and the other only happened on failure,
so not too impactful, but to be fixed nevertheless.
Change-Id: I069baabbf557934d20ab99ef5fcff9231d3d477e
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
INSUN PYO [Mon, 12 Jul 2021 01:53:49 +0000 (10:53 +0900)]
Rework dlogutil_state_init
Change-Id: I724514b7d9aeca85a3becf55a66cd4f416986879
Mateusz Majewski [Tue, 6 Jul 2021 08:18:22 +0000 (10:18 +0200)]
Add test for multiple dlog_connect_fd calls
Change-Id: I6454d95e5ee3cc7f5269bfcc9d6d670e128cfa8a
Mateusz Majewski [Thu, 1 Jul 2021 11:13:21 +0000 (13:13 +0200)]
Do not create state->enabled if DLOGUTIL_MODE_NONPRINTING
This would be just an array of all 1s, a waste of memory and a worthless
syscall.
Change-Id: I9ef737bcf417547573d0ec264c1607318381b9c4
Hyotaek Shim [Tue, 22 Jun 2021 06:22:53 +0000 (15:22 +0900)]
Remove unused connect_dlog()
Change-Id: Ie88190a9788b3eda5a7d5ce136073ca5f512f0e7
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Mateusz Majewski [Fri, 26 Mar 2021 14:20:36 +0000 (15:20 +0100)]
Make the limiter a self-contained struct
Change-Id: Ic2abf2da2b9e51b596e5612d9ac65044cf4540c4
Mateusz Majewski [Fri, 7 May 2021 10:41:27 +0000 (12:41 +0200)]
Add more useful performance measurements to dlog_cpu
Change-Id: I72353a79666359daf15f5459e7af41284960f716
Mateusz Majewski [Fri, 7 May 2021 10:41:11 +0000 (12:41 +0200)]
Implement stdout benchmark
Change-Id: Ia0fdf1abfbe24db49f65c4ce8b24d1e7fd65279c
Co-authored-by: Michał Bloch <m.bloch@samsung.com>
Mateusz Majewski [Fri, 16 Apr 2021 09:52:01 +0000 (11:52 +0200)]
Allow no fallback mode in dlog_redirect_stdout
Change-Id: Iaeb8a4bda937e3ec696269604de45d65e4702a28
Mateusz Majewski [Wed, 21 Apr 2021 13:13:23 +0000 (15:13 +0200)]
Streamline limiter initialization
Change-Id: I36595e3bca15817b64cfc3ecd2292ac1b15e252a
Mateusz Majewski [Fri, 21 May 2021 12:27:44 +0000 (14:27 +0200)]
Remove an obsolete TODO
This is now done in lines 127-128.
Change-Id: Ida251a29f8e50b635d47fa0856ae360ac9d4cdcc
Mateusz Majewski [Tue, 25 May 2021 09:11:00 +0000 (11:11 +0200)]
Clean up in one place more in dlog_test
Change-Id: If9ba3fdbe27b944f6ed22041b9cb066f6ec89612
Michal Bloch [Wed, 12 May 2021 13:54:53 +0000 (15:54 +0200)]
Remove `libcap` from build requirements
Change-Id: I162a000d65bfb2b0251f83acd1ea3f4048f33004
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 11 May 2021 15:02:14 +0000 (17:02 +0200)]
Fix a use-after-free issue
Change-Id: I96e85f2a8965068108b00f56ed63b2855ac35f6a
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 30 Apr 2021 10:22:40 +0000 (12:22 +0200)]
Release 6.5.8
Coverage collection; misc fixes
Change-Id: I4e05562d7505832759ff71b36d07c56d2f639883
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Fri, 30 Apr 2021 10:22:02 +0000 (12:22 +0200)]
Remove a redundant piece of code
Change-Id: Ida0b53328dc51b3ed3653b47cbd1e12ead3c329f
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Thu, 29 Apr 2021 23:14:53 +0000 (01:14 +0200)]
gcov: Adjust build to Tizen:Gcov OBS project
Change-Id: I080b79f25ce6567cc680dd643a52c9f75e480994
Mateusz Majewski [Fri, 26 Mar 2021 15:56:42 +0000 (16:56 +0100)]
Add '\0'-related stdout redirection tests
Change-Id: Ic5d4432b7d855ca495dd86c66ae166663dd82b36
Mateusz Majewski [Fri, 12 Mar 2021 15:47:03 +0000 (16:47 +0100)]
Add stdout redirection state info to logctl
Change-Id: I776ee15e8d16dd9a8b2b4afe3f9529ae6cc1e8bc
Mateusz Majewski [Tue, 27 Apr 2021 08:06:28 +0000 (10:06 +0200)]
Stop caching the timestamp in the server
Caching the timestamp makes the recv timestamps in the logs slightly
less useful, and the performance gains are questionable.
Change-Id: I71300325622ccc51bfef3cb548ce6e8a725b8429
Mateusz Majewski [Fri, 23 Apr 2021 07:54:35 +0000 (09:54 +0200)]
Fix gcov build error
Change-Id: I09b18f45fa82e0dd68ce2518b16949d47b51f5d7
Michal Bloch [Mon, 19 Apr 2021 10:43:34 +0000 (12:43 +0200)]
Address some static analysis complaints
Change-Id: I365afab682da1f86edde0a59b3e309e951c503be
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Hyotaek Shim [Mon, 12 Apr 2021 11:20:53 +0000 (20:20 +0900)]
[ACR-1631] Add tizen.org/privilege/log, platform-level privilege
Change-Id: Id32ad30218b9a513d7d7302790ea14ca18d8bc11
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Karol Lewandowski [Fri, 16 Apr 2021 08:59:34 +0000 (10:59 +0200)]
Release 6.5.7: Bring back libdlog-devel
It seems moving .pc files between packages (from libdlog to dlog-devel)
causes problems for OBS, so bring back original package name to workaround
this problem.
Change-Id: I945fade0101fdd7cf655b6bb578e7ac865ee67b1
Michal Bloch [Thu, 15 Apr 2021 14:11:36 +0000 (16:11 +0200)]
Release 6.5.6
Fixes stdout redirection newlines; new release for build process issues
Change-Id: If1d21ad260312637684a4282b3f2c9597d29ac83
Michal Bloch [Thu, 15 Apr 2021 13:01:15 +0000 (15:01 +0200)]
Replace "DLOG_ERROR_NOMSG" with an empty message
Change-Id: I279aa7913fc368599439c37b80bf94ca18f5fb61
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 13 Apr 2021 17:22:40 +0000 (19:22 +0200)]
Release 6.5.5
Further development of the stdout redirection feature
Change-Id: I97eb5775d9227ff37a0ce64f816ab629470cbe8e
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Michal Bloch [Tue, 13 Apr 2021 14:23:30 +0000 (16:23 +0200)]
Update Android Logger stdout tag setting
Kernel-side development changed the expected data format; conform.
Change-Id: I107b55b195cb9247fcccec7e7d48e646eeb09af8
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Tue, 13 Apr 2021 14:14:27 +0000 (14:14 +0000)]
Merge "Decrease an array in tests for Coverity" into tizen
Mateusz Majewski [Tue, 13 Apr 2021 10:18:12 +0000 (12:18 +0200)]
Decrease an array in tests for Coverity
Change-Id: Ia9ecae92608f6ac15754aa6c349145c8fdeac1e6
Mateusz Majewski [Mon, 12 Apr 2021 09:17:32 +0000 (11:17 +0200)]
Replace () with (void) in function prototypes
In C, argumentless functions are declared as receiving (void). It is,
however, more natural to declare them as receiving (). But this means
that the function can receive any number of arguments. This is bad.
We don't want this. We could miss some calls when adding arguments in
a refactor, leading to stack garbage/corruption.
Change-Id: I94732497663937fd3f9d30cea71a2eb966d6f439
Mateusz Majewski [Fri, 9 Apr 2021 10:33:02 +0000 (12:33 +0200)]
Add some basic latency data to logmetrics
To be exact: minimum, maximum, and average difference between sent and
recv timestamps.
Change-Id: Iecd98c2168059924fd986530f3c0de2080110e60
Karol Lewandowski [Mon, 12 Apr 2021 11:26:15 +0000 (13:26 +0200)]
Release 6.5.4
Change-Id: I3065f916ad8cadd78517859e8b568f393b6a3d8e
Michal Bloch [Mon, 12 Apr 2021 10:22:39 +0000 (12:22 +0200)]
Type safety for redirection tags
This was supposed to be self-documenting but it's fairly obvious that
the extra byte is for the terminator and I'm very worried about weird
things that can happen to the char (int promotions or something).
Change-Id: Ib33404db86055fb1840f5942e9740cbf6199d7c3
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Mon, 12 Apr 2021 11:51:34 +0000 (13:51 +0200)]
libdlog: Do not export private functions
Change-Id: Iffbf96204be08a5f0d71de8ce93bcfdaf962d056
Karol Lewandowski [Mon, 12 Apr 2021 11:25:02 +0000 (13:25 +0200)]
log-redirect: Deprecate connect_dlog()
connect_dlog() does not use library prefix and is potentially going
to cause name conflict.
Let's remove it when possible.
Change-Id: Ib9769737d33a4cae3d19f1cd49440ea9515c7aea
Michal Bloch [Thu, 8 Apr 2021 12:09:24 +0000 (14:09 +0200)]
Introduce dlog_is_fd_redirected
Checks whether given FD is redirected to dlog.
Change-Id: I71bc905d9c377c5ff6791d39955459d41923a29a
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Wed, 7 Apr 2021 12:51:33 +0000 (14:51 +0200)]
Simplify dlog packaging
This commit reduces number of packages by combining
- all libraries - into libdlog package
- all development files - into dlog-devel package
- common files - into 'dlog' package
It does not seem the fine-grained "one library per package"
scheme is useful in Tizen.
Change-Id: I1e0dff4cfb836d5c4872faa9491fdd8b5128dcb3
Michal Bloch [Tue, 6 Apr 2021 12:36:59 +0000 (14:36 +0200)]
Increase config entry field lengths
32 is not enough for limiter rules for long tags.
Examples: CAPI_APPFW_APPLICATION, SAMSUNG_CONNECT_SERVICE.
Change-Id: I296ece081595316f83894e48f28cfe9679f6cecc
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Karol Lewandowski [Fri, 2 Apr 2021 08:06:52 +0000 (10:06 +0200)]
Release 6.5.2
Change-Id: I1c0297c20053d5bcda26c2d4ba86b29ae33102e8
Karol Lewandowski [Fri, 2 Apr 2021 10:39:20 +0000 (12:39 +0200)]
dlog_redirect_stdout: Use internal library
Change-Id: Id54c7df7a5ccbfbe6b2cd8167943b08ea3347080
Mateusz Majewski [Fri, 2 Apr 2021 08:16:49 +0000 (10:16 +0200)]
Rename toggle request to a better name
Change-Id: I6fdeded8caea015c71c7190d7500ec7dae027edf
Mateusz Majewski [Tue, 30 Mar 2021 12:40:50 +0000 (14:40 +0200)]
Move stdout toggle operation to control socket
We put it in the write socket, but this seems to have been a mistake.
Change-Id: I01a483a14b9a87a8b93c530c38af9d4221061541
Karol Lewandowski [Fri, 2 Apr 2021 08:04:31 +0000 (10:04 +0200)]
Use named pipes when creating pipes for clients
Change-Id: I8652af5c2ad623ca39bdba5b77a52ccb29c4cfd3
Karol Lewandowski [Thu, 1 Apr 2021 11:49:16 +0000 (13:49 +0200)]
redirect-stdout: Ensure lines are line buffered
Change-Id: Ibbd677e3680900f94e7431c4c7dd1bb29e76a98b
Karol Lewandowski [Thu, 1 Apr 2021 21:10:52 +0000 (23:10 +0200)]
redirect-stdout: Perform sanity check on paramters passed to public API
Change-Id: I060c05cb88fd834dbf6151e32e0e08056b9e9e9d
Mateusz Majewski [Wed, 31 Mar 2021 11:24:39 +0000 (13:24 +0200)]
Fix a dumb mistake
:hah:
Change-Id: I9cf19dba4dcfadb33eb50f2f046bfa3951004a10
Hyotaek Shim [Tue, 30 Mar 2021 05:44:37 +0000 (14:44 +0900)]
Add extern "C" to dlog-redirect-stdout.h
Change-Id: I331b3db0955909c9f6808c4096fad6da97e04b4b
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Michal Bloch [Mon, 22 Mar 2021 15:06:39 +0000 (16:06 +0100)]
Release 6.5.1
Improvements to stdout redirection, incl. support for Android Logger
Change-Id: I7964d2170b86b6fe5803bca41e438a534e6cd695
Karol Lewandowski [Mon, 22 Mar 2021 21:22:35 +0000 (22:22 +0100)]
packaging: Move dlog_redirect_stdout utility to dlogutil package
This is where other utilities are.
Change-Id: I08b1152411d61ce514078df43d8806e72b414888
Michal Bloch [Fri, 19 Mar 2021 12:29:33 +0000 (13:29 +0100)]
Add nominal support for Android Logger in the redirector
Change-Id: I80e2d092723951c4c22b6a47e5e6b81ebb801420
Signed-off-by: Michal Bloch <m.bloch@samsung.com>
Mateusz Majewski [Fri, 19 Mar 2021 13:58:21 +0000 (14:58 +0100)]
Simplify stdout redirection logic a bit
The pipe backend is supposed to provide sent timestamps, ie. timestamps
that are as close to log sending time as possible. In libdlog this is
done by taking a timestamp in the sending process and attaching it to
the sent log. Of course stdout redirection can't do this.
Originally, we decided that the best solution is to not attach the sent
timestamps. This would however invalidate some internal assumptions,
which would make some functionality unusable. We were forced to add a
flag which allows users to assert that they won't be using redirection,
which would allow them to continue to use that functionality.
However, there is a simpler solution, which, not unlike magic according
to Penn Jillette (see https://www.youtube.com/watch?v=pd3_HFvQeXQ),
involves lying, cheating, and swindling. In particular, we just make up
a sent timestamp by copying it from the receive timestamp (which is a
timestamp captured in the daemon). This completely ruins the whole point
of the sent timestamp. However, it's still somewhat close to the one we
would get, and the redirection logic gets a tad bit simpler.
Change-Id: I11c6b389ddda88f067a7458e8dac596715fb4cac
Mateusz Majewski [Mon, 22 Mar 2021 09:21:02 +0000 (10:21 +0100)]
Make stdout redirection tests less racey
Those tests are inherently racey: unlike libdlog, stdout redirection
doesn't wait until logs are stored. Therefore, if we launch a redirected
library and then quickly fetch logs, we might see only a part of the
logs. Waiting a second between those two fixes the issue.
Change-Id: I6fed704c4455cfe7cd2ff00a62e8330dfdc0d88e
Michal Bloch [Mon, 15 Mar 2021 11:25:38 +0000 (11:25 +0000)]
Merge "logger: extract signal setup" into tizen