platform/upstream/gstreamer.git
2 years agomeson: default to gpl=disabled for gst-plugins-bad and -ugly
Tim-Philipp Müller [Wed, 20 Oct 2021 23:33:06 +0000 (00:33 +0100)]
meson: default to gpl=disabled for gst-plugins-bad and -ugly

This will only affect individual/tarball module builds, as the
options yield to the parent project which was set to gpl=disabled
by default already. We kept it as auto in the original commit
to accommodate the need to update cerbero as well, which had to
be done separately after the initial commit.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1217>

2 years agoassrender: Do not iterate over mimetypes without filename
Rafał Dzięgiel [Wed, 20 Jan 2021 12:38:03 +0000 (13:38 +0100)]
assrender: Do not iterate over mimetypes without filename

No point spending time on iterating and comparing strings if we
are going to reject the value due to missing filename anyway.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1206>

2 years agoassrender: Fix mimetype detection
Rafał Dzięgiel [Wed, 20 Jan 2021 10:46:17 +0000 (11:46 +0100)]
assrender: Fix mimetype detection

Previously gst_structure_has_name was used to get a string to compare with supported mimetypes.
This is incorrect as above function returns a user defined structure name which is
not the structure mimetype value.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1206>

2 years agomatroska: Set image/attachment structure mimetype
Rafał Dzięgiel [Wed, 20 Jan 2021 10:53:51 +0000 (11:53 +0100)]
matroska: Set image/attachment structure mimetype

Set structure mimetype to fix data detection by mimetype in other plugins.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1205>

2 years agomatroska: Treat non-image structure as attachment
Rafał Dzięgiel [Wed, 20 Jan 2021 10:33:39 +0000 (11:33 +0100)]
matroska: Treat non-image structure as attachment

Otherwise each structure is named as GstTagImageInfo even if
it does not contain any images which is misleading.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1205>

2 years agortpbin: fix leak of pad when a fec encoder and aux sender a created
Matthew Waters [Thu, 21 Oct 2021 09:32:05 +0000 (20:32 +1100)]
rtpbin: fix leak of pad when a fec encoder and aux sender a created

The ghost sink pad retrieved by rtpbin from the aux sender was not freed
when there was a previous element (fec encoder) in the chain.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1222>

2 years agoci: gstreamer-full: remove static build
Stéphane Cerveau [Wed, 20 Oct 2021 15:56:49 +0000 (17:56 +0200)]
ci: gstreamer-full: remove static build

The gstreamer-full jobs act as
static builds,  no need to perform it twice.

gstreamer-full-minimal can be nodebug.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1215>

2 years agoREADME: Remove outdated Windows ARM64 related comment
Seungha Yang [Thu, 21 Oct 2021 09:25:47 +0000 (18:25 +0900)]
README: Remove outdated Windows ARM64 related comment

We bumped required meson version which contains the mentioned
meson patch already.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1221>

2 years agovulkan/swapper: add some debug logging for surface size and present modes
Matthew Waters [Thu, 21 Oct 2021 08:17:18 +0000 (19:17 +1100)]
vulkan/swapper: add some debug logging for surface size and present modes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1219>

2 years agointerlace: Replace custom lock with object lock
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:28:25 +0000 (00:28 +0200)]
interlace: Replace custom lock with object lock

The object lock is sufficient for the task of protecting against
object property data races.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

2 years agointerlace: Protect all properties with the lock
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:37:47 +0000 (00:37 +0200)]
interlace: Protect all properties with the lock

Avoid blatant data races here.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

2 years agointerlace: Reset src_fps_d together with src_fps_n
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:36:47 +0000 (00:36 +0200)]
interlace: Reset src_fps_d together with src_fps_n

These fields belong together.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

2 years agointerlace: Clear stored_fields together with stored_frame
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:35:00 +0000 (00:35 +0200)]
interlace: Clear stored_fields together with stored_frame

These fields belong together.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

2 years agointerlace: Reset after changing state to READY
Jan Alexander Steffens (heftig) [Wed, 20 Oct 2021 22:31:24 +0000 (00:31 +0200)]
interlace: Reset after changing state to READY

Trying to reset before the pads have been deactivated races with the
streaming thread. There was also a buggy buffer clear leaving a dangling
`stored_frame` pointer around. Use `gst_interlace_reset` so this happens
properly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1039>

2 years agonvh264enc: add constrained-baseline to the caps profiles
Mathieu Duponchelle [Wed, 20 Oct 2021 12:34:42 +0000 (14:34 +0200)]
nvh264enc: add constrained-baseline to the caps profiles

In practice, when baseline is requested from the encoder it
produces constrained baseline, and it is already reflected
in the profile-iop flags.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1213>

2 years agomediafoundation: Fix for UWP build
Seungha Yang [Wed, 20 Oct 2021 16:47:07 +0000 (01:47 +0900)]
mediafoundation: Fix for UWP build

We don't support D3D11 interop for UWP because some APIs
(specifically MFTEnum2) are desktop application only.
However, the code for symbol loading is commonly used by both UWP and WIN32.
Just link GModule unconditionally which is UWP compatible, and simply don't
try to load any library/symbol dynamically when D3D11 interop is unavailable.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1216>

2 years agoRevert "ci: Split base and core valgrind on different runners"
Thibault Saunier [Wed, 20 Oct 2021 12:09:33 +0000 (09:09 -0300)]
Revert "ci: Split base and core valgrind on different runners"

Those job are not the ones that take most time in normal run (they
where when running with --n-runs) and that leads to using more runners
which might be a problem at this point.

This reverts commit 4ad22b05a15056b9e85468af266bacc7d3758ee9.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1212>

2 years agodocs: remove mms plugin from symbol index
Tim-Philipp Müller [Wed, 20 Oct 2021 00:06:12 +0000 (01:06 +0100)]
docs: remove mms plugin from symbol index

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1211>

2 years agomms: remove mmssrc plugin
Tim-Philipp Müller [Tue, 19 Oct 2021 23:54:26 +0000 (00:54 +0100)]
mms: remove mmssrc plugin

Doubtful that anyone still needs that or there are even
any streams left out there.

MMS was deprecated in 2003 (in favour of RTSP) and support for
it was dropped with Microsoft Media Services 2008.

https://en.wikipedia.org/wiki/Microsoft_Media_Server
https://sdp.ppona.com/news2008.html

Fixes https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/issues/821

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1211>

2 years agostreamsynchronizer: set running time offset on events
Guillaume Desmottes [Wed, 20 Oct 2021 09:56:32 +0000 (11:56 +0200)]
streamsynchronizer: set running time offset on events

It's cleaner and more generic than overriding the qos events.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1210>

2 years agoconcat: fix qos event handling
Guillaume Desmottes [Wed, 20 Oct 2021 09:20:13 +0000 (11:20 +0200)]
concat: fix qos event handling

We were shadowing the sinkpad variable resulting in:
- the QoS event to be send to all sink pads instead of the active one
- the pad to be leaked

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1208>

2 years agodoc: update meson version in README.md
Brad Hards [Wed, 20 Oct 2021 09:28:27 +0000 (20:28 +1100)]
doc: update meson version in README.md

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1209>

2 years agomeson: va, msdk: simplify dep.get_variable() use
Tim-Philipp Müller [Tue, 19 Oct 2021 17:18:25 +0000 (18:18 +0100)]
meson: va, msdk: simplify dep.get_variable() use

With recent Meson versions we can just write dep.get_variable('foo')
instead of dep.get_variable(pkgconfig: 'driverdir', internal: 'driverdir').

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

2 years agomeson: fix use of deprecated meson api external_program.path()
Tim-Philipp Müller [Mon, 18 Oct 2021 15:55:14 +0000 (16:55 +0100)]
meson: fix use of deprecated meson api external_program.path()

Just using .full_path() instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

2 years agomeson: fix use of deprecated meson api meson.has_exe_wrapper()
Tim-Philipp Müller [Mon, 18 Oct 2021 15:51:37 +0000 (16:51 +0100)]
meson: fix use of deprecated meson api meson.has_exe_wrapper()

Use meson.can_run_host_binaries() instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

2 years agomeson: update for meson.build_root() and .build_source() deprecation
Tim-Philipp Müller [Mon, 18 Oct 2021 14:47:00 +0000 (15:47 +0100)]
meson: update for meson.build_root() and .build_source() deprecation

-> use meson.project_build_root() or .global_build_root() instead.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

2 years agomeson: update for dep.get_pkgconfig_variable() deprecation
Tim-Philipp Müller [Sun, 17 Oct 2021 23:40:14 +0000 (00:40 +0100)]
meson: update for dep.get_pkgconfig_variable() deprecation

... in favour of dep.get_variable('foo', ..) which in some
cases allows for further cleanups in future since we can
extract variables from pkg-config dependencies as well as
internal dependencies using this mechanism.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

2 years agomeson: clean up conditional paths after version bump
Tim-Philipp Müller [Sun, 17 Oct 2021 23:03:47 +0000 (00:03 +0100)]
meson: clean up conditional paths after version bump

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1183>

2 years agoassrender: fix smooth scaling by disabling hinting
Rafał Dzięgiel [Thu, 19 Nov 2020 17:03:11 +0000 (18:03 +0100)]
assrender: fix smooth scaling by disabling hinting

When ass hinting value is set to anything other than NONE,
subtitles cannot use smooth scaling, thus all animations will jitter.

The libass author warns about possibility of breaking some scripts when it is enabled,
so lets do what is recommended and disable it to get the smooth scaling working.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1201>

2 years agodiscoverer: Set number to stream infos
Thibault Saunier [Tue, 9 Feb 2021 22:56:49 +0000 (19:56 -0300)]
discoverer: Set number to stream infos

The idea is that we can reference to streams using this unique number,
within the context of that discoverer info. That number should always
be usable to reference the streams for a specific stream.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/897>

2 years agodiscoverer: Don't ref NULL taglist
Edward Hervey [Wed, 20 Oct 2021 07:37:40 +0000 (09:37 +0200)]
discoverer: Don't ref NULL taglist

Fixes warning introduced in 064f7bbbfac9610fd391c45091e35391b80e1212

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1200>

2 years agointegration/ges: Ignore GstStream for validate tests
Edward Hervey [Tue, 19 Oct 2021 15:11:24 +0000 (17:11 +0200)]
integration/ges: Ignore GstStream for validate tests

Requires the ges runner to be configured in such a way that the resulting
stream-id is consistent (and therefore can be checked)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1187>

2 years agostream: Set the object name to the stream id
Edward Hervey [Fri, 28 May 2021 05:54:32 +0000 (07:54 +0200)]
stream: Set the object name to the stream id

Makes it more meaningful in debug logs (instead of streamNNNNN)

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1187>

2 years agodocs: remove mention of mms from docs and mmssrc from tutorials
Tim-Philipp Müller [Wed, 20 Oct 2021 00:03:26 +0000 (01:03 +0100)]
docs: remove mention of mms from docs and mmssrc from tutorials

Prerequisite for our removing it from the cerbero build, see
https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/760

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1199>

2 years agortphdrext-clientaudiolevel: Rename RFC 6464 element
Olivier Crête [Wed, 15 Sep 2021 18:19:06 +0000 (14:19 -0400)]
rtphdrext-clientaudiolevel: Rename RFC 6464 element

Multiplying elements named after RFC numbers is confusing,
so let's give them meaningful names.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1125>

2 years agoci: gstreamer-full: reenable build
Stéphane Cerveau [Tue, 19 Oct 2021 11:11:01 +0000 (13:11 +0200)]
ci: gstreamer-full: reenable build

The gstreamer-full job should be run
during the integrate stage always.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1190>

2 years agosubprojects: Update ogg and vorbis wraps
Seungha Yang [Tue, 19 Oct 2021 15:28:33 +0000 (00:28 +0900)]
subprojects: Update ogg and vorbis wraps

... to 1.3.5-2 and 1.3.7-2, respectively. Specifically to fix
ogg/vorbis plugin loading on Windows devenv environment.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1196>

2 years agoRevert "meson: Link to objects instea of static helper library"
Xavier Claessens [Tue, 19 Oct 2021 14:24:42 +0000 (10:24 -0400)]
Revert "meson: Link to objects instea of static helper library"

This reverts commit b19de413b94d228b1460b0899f9b41b2b5233943.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1194>

2 years agoRevert "audio: Merge simd libs into the main one"
Xavier Claessens [Tue, 19 Oct 2021 14:07:55 +0000 (10:07 -0400)]
Revert "audio: Merge simd libs into the main one"

This reverts commit 4d3a200358439e6c76c5dd1be2daae0cceb0e44a.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1194>

2 years agoAdd initial meson devenv support
Xavier Claessens [Sun, 21 Feb 2021 15:20:15 +0000 (10:20 -0500)]
Add initial meson devenv support

There is still a few things missing compared to gst-env.py, but it is
functional.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1162>

2 years agovideo-overlay-composition: Fix constructor guard to actually allow NULL as parameter
Sebastian Dröge [Tue, 19 Oct 2021 14:07:37 +0000 (17:07 +0300)]
video-overlay-composition: Fix constructor guard to actually allow NULL as parameter

And don't use a NULL rectangle later.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1195>

2 years agogl/eagl: fix eagl display creation
Matthew Waters [Tue, 19 Oct 2021 08:46:48 +0000 (19:46 +1100)]
gl/eagl: fix eagl display creation

The GstGLDisplayType of the display was win32 instead of the required eagl.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1188>

2 years agoqtdemux: Add support for wvtt (WebVTT) subtitles.
Jan Schmidt [Fri, 4 Jun 2021 17:13:52 +0000 (03:13 +1000)]
qtdemux: Add support for wvtt (WebVTT) subtitles.

WebVTT in ISO MP4 is specified in ISO 14496-30,
and needed for DASH support. It's stored in an
mp4 specific format. To handle it compatibly,
the wvtt boxes are converted back into WebVTT text
and pushed as application/x-subtitle-vtt

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>

2 years agoisomp4: Split buffer process functions.
Jan Schmidt [Fri, 27 Aug 2021 12:45:18 +0000 (22:45 +1000)]
isomp4: Split buffer process functions.

Split the different handling for closed captions, VobSub subpicture
and timed text samples into separate simplified process functions.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>

2 years agoisomp4: Use a function pointer for buffer splitting.
Jan Schmidt [Fri, 27 Aug 2021 11:58:25 +0000 (21:58 +1000)]
isomp4: Use a function pointer for buffer splitting.

Swap the `need_process` boolean check on qtdemux streams
for a direct function pointer to the splitting function,
so we can stop adding extra cases to the single growing
`gst_qtdemux_process_buffer()` function.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1182>

2 years agosrt: Plug leak of headers
Jan Alexander Steffens (heftig) [Fri, 7 May 2021 09:11:31 +0000 (11:11 +0200)]
srt: Plug leak of headers

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1040>

2 years agotests/rtp/payload: add test for shrinking extension data
Matthew Waters [Tue, 31 Aug 2021 06:21:09 +0000 (16:21 +1000)]
tests/rtp/payload: add test for shrinking extension data

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1146>

2 years agortp: also support shrinking the extension data
Matthew Waters [Tue, 24 Aug 2021 11:26:54 +0000 (21:26 +1000)]
rtp: also support shrinking the extension data

Currently the extension data length specified in the RTP header would
say it was shorter then the data serialised to a packet. When
combining the resulting buffer, the underlying memory would still
contain the extra (now 0-filled) padding data.

This would mean that parsing the resulting RTP packet would potentially
start with a number of 0-filled bytes which many RTP formats are not
expecting.

Such usage is found by e.g. RTP header extension when allocating the
maximum buffer (which may be larger than the written size) and shrinking
to the required size the data once all the rtp header extension data has
been written.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1146>

2 years agompegtsmux: Avoid crash when best pad gets flushed
Jan Alexander Steffens (heftig) [Mon, 31 Aug 2020 15:17:56 +0000 (17:17 +0200)]
mpegtsmux: Avoid crash when best pad gets flushed

The 'best' pad might receive a flush event between us picking it and us
popping the buffer. In this case, the buffer will be missing.

Similar to https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/merge_requests/711

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1042>

2 years agovorbisdec: don't emit g_warning() on malformed input data
Tim-Philipp Müller [Sun, 17 Oct 2021 12:14:38 +0000 (13:14 +0100)]
vorbisdec: don't emit g_warning() on malformed input data

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agotheoradec: don't emit g_warning() on malformed input stream
Tim-Philipp Müller [Sun, 17 Oct 2021 12:12:11 +0000 (13:12 +0100)]
theoradec: don't emit g_warning() on malformed input stream

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agosubparse: don't use g_warning() for malformed input
Tim-Philipp Müller [Sun, 17 Oct 2021 12:04:14 +0000 (13:04 +0100)]
subparse: don't use g_warning() for malformed input

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agotools: Define G_LOG_DOMAIN for various tools as well
Tim-Philipp Müller [Sun, 17 Oct 2021 10:39:57 +0000 (11:39 +0100)]
tools: Define G_LOG_DOMAIN for various tools as well

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agortsp-server: define G_LOG_DOMAIN
Tim-Philipp Müller [Fri, 1 Oct 2021 14:32:58 +0000 (15:32 +0100)]
rtsp-server: define G_LOG_DOMAIN

Fixes #634

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agogst-plugins-bad: define G_LOG_DOMAIN for all libraries
Tim-Philipp Müller [Fri, 1 Oct 2021 14:31:18 +0000 (15:31 +0100)]
gst-plugins-bad: define G_LOG_DOMAIN for all libraries

Fixes #634

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agogst-plugins-base: define G_LOG_DOMAIN for all libraries
Tim-Philipp Müller [Fri, 1 Oct 2021 14:30:27 +0000 (15:30 +0100)]
gst-plugins-base: define G_LOG_DOMAIN for all libraries

Fixes #634

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agogstreamer: define G_LOG_DOMAIN for all libraries
Tim-Philipp Müller [Fri, 1 Oct 2021 14:29:36 +0000 (15:29 +0100)]
gstreamer: define G_LOG_DOMAIN for all libraries

And get rid of weird way the define was done for core.

Fixes #634

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agolibs: check: handle criticals and warnings for new gstreamer log domains
Tim-Philipp Müller [Wed, 6 Oct 2021 00:30:03 +0000 (01:30 +0100)]
libs: check: handle criticals and warnings for new gstreamer log domains

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1009>

2 years agoaes: specify the required OpenSSL version
Antonio Ospite [Wed, 6 Oct 2021 11:38:35 +0000 (13:38 +0200)]
aes: specify the required OpenSSL version

The code in the aes elements assumes OpenSSL >= 1.1.0:

  - implicit library initialization;
  - version retrieved with OpenSSL_version(OPENSSL_VERSION);

and it fails to build with older versions.

Specify the required OpenSSL version explicitly in meson.build so that
the elements are excluded on older systems (e.g. Ubuntu 16.04) and the
rest of GStreamer can still build.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1067>

2 years agoci: fix plugins cache diffs directory
Mathieu Duponchelle [Mon, 18 Oct 2021 22:19:58 +0000 (00:19 +0200)]
ci: fix plugins cache diffs directory

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/867>

2 years agoaudio/video aggregator: make use of new aggregator inactive pad API
Mathieu Duponchelle [Sat, 14 Aug 2021 23:36:14 +0000 (01:36 +0200)]
audio/video aggregator: make use of new aggregator inactive pad API

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/867>

2 years agoaggregator: expose API for ignoring inactive pads
Mathieu Duponchelle [Mon, 18 Oct 2021 13:56:31 +0000 (15:56 +0200)]
aggregator: expose API for ignoring inactive pads

An inactive pad is a pad which, in live mode, hasn't yet received
a first buffer, but has been waited on at least once.

Exposing API to support this behaviour allows users of aggregator
subclasses to request pads, and not start pushing data on those
immediately, while avoiding systematic timeouts.

Subclasses must check in explicitly to this behavior, most likely
by exposing a user-facing property, and must check whether a pad
needs ignoring when aggregating. That is because by design,
aggregator subclasses don't get a list of "ready" pads, but instead
directly iterate element->sinkpads.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/867>

2 years agodocs: tutorial 1: error out if an error occurred in Hello World tutorial
Tim-Philipp Müller [Mon, 18 Oct 2021 17:20:10 +0000 (18:20 +0100)]
docs: tutorial 1: error out if an error occurred in Hello World tutorial

Very confusing if it just exits silently with exit code 0 on error.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1185>

2 years agodiscoverer: Advertise container-specific tags with a new API
Philippe Normand [Sun, 10 Oct 2021 16:07:33 +0000 (17:07 +0100)]
discoverer: Advertise container-specific tags with a new API

Since commit a55dafe341ac7398e7c37c30d8b760228296da92, stream-scoped tags no
longer appeared as top-level tags, introducing a behaviour regression, specially
for MP3 files.

The `gst_discoverer_info_get_tags()` API now returns all tags detected for the
given media, as documented.

A new API is introduced to get container-specific tags,
`gst_discoverer_container_info_get_tags()`. The discoverer tool was adapted to
use it. `gst_discoverer_info_get_tags()` is now deprecated in favor of
`gst_discoverer_container_info_get_tags()` and
`gst_discoverer_stream_info_get_tags()`.

Fixes #759

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1107>

2 years agovadeinterlace: Accept ANY feature.
Víctor Manuel Jáquez Leal [Mon, 11 Oct 2021 11:05:24 +0000 (13:05 +0200)]
vadeinterlace: Accept ANY feature.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agovadeinterlace: Fixate interlace-mode and framerate accordingly.
Víctor Manuel Jáquez Leal [Mon, 11 Oct 2021 11:04:19 +0000 (13:04 +0200)]
vadeinterlace: Fixate interlace-mode and framerate accordingly.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agovapostproc: Accept ANY feature.
Víctor Manuel Jáquez Leal [Thu, 14 Oct 2021 05:03:26 +0000 (07:03 +0200)]
vapostproc: Accept ANY feature.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agovapostproc: Traverse caps features in gst_va_vpp_caps_remove_fields()
Víctor Manuel Jáquez Leal [Wed, 13 Oct 2021 17:27:41 +0000 (19:27 +0200)]
vapostproc: Traverse caps features in gst_va_vpp_caps_remove_fields()

The previous code had a potential failure for multiple caps features. Now
each caps feature in each structure is reviewed, and if it has a supported
feature, the structure is processed.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agovapostproc: Refactor gst_va_vpp_complete_caps_features()
Víctor Manuel Jáquez Leal [Wed, 13 Oct 2021 15:08:12 +0000 (17:08 +0200)]
vapostproc: Refactor gst_va_vpp_complete_caps_features()

gst_va_vpp_complete_caps_features() now receives the @feature_name to
add and return if @caps doesn't provide it.

So, instead of two nested loops, now the function is a single loop,
traversing @caps to find if each structure already contains the requested
@features_name.

It's important to add missing caps features with @caps, in order to
not lost information.

The function caller does the external loop by calling per each
available caps feature.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agovapostproc: Split caps transform in two phases.
Víctor Manuel Jáquez Leal [Mon, 11 Oct 2021 16:57:48 +0000 (18:57 +0200)]
vapostproc: Split caps transform in two phases.

In order to make more readable the caps transformation, the operation
was split in two phases:

1. Rangify the supported caps structures.
2. Add the missing (and supported) caps features.

Step 1 modified its logic, by copying any unrecognized structure.
It's a previous step required for allowing ANY caps feature as
passthrough.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1024>

2 years agotsdemux: Change many GST_{DEBUG, LOG, etc} into _OBJECT
Vivia Nikolaidou [Fri, 8 Oct 2021 09:38:04 +0000 (12:38 +0300)]
tsdemux: Change many GST_{DEBUG, LOG, etc} into _OBJECT

Log files with several demuxers running at once can otherwise get
confusing

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1096>

2 years agotsdemux: Issue GST_ELEMENT_WARNING for continuity errors
Vivia Nikolaidou [Fri, 8 Oct 2021 09:36:58 +0000 (12:36 +0300)]
tsdemux: Issue GST_ELEMENT_WARNING for continuity errors

The application might want to make use of these.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1096>

2 years agoci: install newer meson via pip in documentation job
Tim-Philipp Müller [Mon, 18 Oct 2021 14:48:09 +0000 (15:48 +0100)]
ci: install newer meson via pip in documentation job

Since updating the existing image seems difficult and efforts
to redo the setup are still work in progress.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1084>

2 years agomeson: bump meson requirement to >= 0.59
Tim-Philipp Müller [Thu, 14 Oct 2021 17:38:26 +0000 (18:38 +0100)]
meson: bump meson requirement to >= 0.59

For monorepo build and ugly/bad, for advanced feature
option API like get_option('xyz').required(..) which
we use in combination with the 'gpl' option.

For rest of modules for consistency (people will likely
use newer features based on the top-level requirement).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1084>

2 years agomeson: add 'gpl' option and only build plugins with (A)GPL deps if explicitly enabled
Tim-Philipp Müller [Sat, 18 Sep 2021 23:55:34 +0000 (00:55 +0100)]
meson: add 'gpl' option and only build plugins with (A)GPL deps if explicitly enabled

Require explicit opt-in to build plugins with (A)GPL dependencies.

Keep ugly/bad options on 'auto' for now so cerbero doesn't fail.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1084>

2 years agobasetsmux: Support for caps changes
Vivia Nikolaidou [Fri, 30 Oct 2020 14:02:22 +0000 (16:02 +0200)]
basetsmux: Support for caps changes

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/981>

2 years agobasetsmux: Clean up gst_base_ts_mux_create_stream
Jan Alexander Steffens (heftig) [Thu, 12 Nov 2020 11:17:14 +0000 (12:17 +0100)]
basetsmux: Clean up gst_base_ts_mux_create_stream

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/981>

2 years agompegtsbase: Search SCTE-35 DRF_ID_CUEI in multiple registration descriptors
Vivia Nikolaidou [Tue, 31 Aug 2021 13:35:06 +0000 (16:35 +0300)]
mpegtsbase: Search SCTE-35 DRF_ID_CUEI in multiple registration descriptors

There are streams in the wild that have to add a SCTE-35 trigger in
another e.g. GA94 stream. Most encoders would replace the GA94
descriptor ID with the CUEI one temporarily, but there are some that
will add two registration ID descriptors, one with GA94 and one with
CUEI.

Failing to parse the CUEI registration ID in that case would return
FALSE in _stream_is_private_section , therefore setting it as known PES
and pushing packets downstream instead of calling handle_psi.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/979>

2 years agosmartencoder: Force reencoding of vp9 for profiles can't support
Thibault Saunier [Fri, 15 Oct 2021 02:02:36 +0000 (23:02 -0300)]
smartencoder: Force reencoding of vp9 for profiles can't support

If the input file is in a profile we won't be able to output (1 or 3 in BGR
format), simply reencode everything for now.

Once we add support for that case we can remove that code

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agoencoding-profile: ignore more fields when creating for discover info
Thibault Saunier [Fri, 15 Oct 2021 01:55:35 +0000 (22:55 -0300)]
encoding-profile: ignore more fields when creating for discover info

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agosmartencoder: Always plug a vp9parse when encoding vp9
Thibault Saunier [Fri, 15 Oct 2021 01:29:19 +0000 (22:29 -0300)]
smartencoder: Always plug a vp9parse when encoding vp9

This way we know that all relevant fields about video format are
added and we avoid renegotiation issues.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agoqtmux: Allow more fields changes renegotiating h264
Thibault Saunier [Tue, 5 Oct 2021 15:28:22 +0000 (12:28 -0300)]
qtmux: Allow more fields changes renegotiating h264

And consider interlace-mode=progress as equivalent to the field not
being specified.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agomatroskamux: Ignore some fields when renegotiating
Thibault Saunier [Tue, 5 Oct 2021 13:50:32 +0000 (10:50 -0300)]
matroskamux: Ignore some fields when renegotiating

Those values are never used in the muxer so we should not fail the
negotiation if those are changing.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agosmartencoder: Fix renegotiating when reencoding parts of the stream with vpx
Thibault Saunier [Tue, 5 Oct 2021 13:46:26 +0000 (10:46 -0300)]
smartencoder: Fix renegotiating when reencoding parts of the stream with vpx

In the encoded streams we might not have all the information about the
raw video stream, but when reencoding they end up being specified, even
if those are default values.

As vp8 decoders always output frames in some YUV color space we can
ensure that when upstream doesn't specify any value in its caps we
use the default one which is what we end up doing when decoding/reencoding
anyway, so this way downstream (matroskamux in that case) doesn't need
to be able to renegotiate (which it doesn't).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1062>

2 years agotsdemux: Improve gap detection
Edward Hervey [Fri, 1 Oct 2021 12:36:48 +0000 (14:36 +0200)]
tsdemux: Improve gap detection

We should also take into account whether data is currently pending when checking
for gap on streams. It could very well be that some streams have very low
bitrate (and spread out) data. For those we don't want to push out a gap event.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>

2 years agotsdemux: Handle "negative" timestamps
Edward Hervey [Sun, 5 Sep 2021 09:57:18 +0000 (11:57 +0200)]
tsdemux: Handle "negative" timestamps

This is only enabled in push time mode. Furthermore it's only enabled for now if
PCR is to be ignored.

The problem is dealing with streams where the initial PTS/DTS observation might
be greater than following ones (from other PID for example). Before this patch,
this would result in sending buffers without any timestamp which would cause a
wide variety of issues.

Instead, pad segment and buffer timestamps with an extra
value (packetizer->extra_shift, default to 2s), to ensure that we can get valid
timestamps on outgoing buffers (even if that means they are before the segment
start).

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>

2 years agotsdemux: Handle streams with bogus PTS vs DTS
Edward Hervey [Sun, 5 Sep 2021 09:55:55 +0000 (11:55 +0200)]
tsdemux: Handle streams with bogus PTS vs DTS

PTS and DTS should be within a reasonable distance of each other.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>

2 years agotsdemux: Handle PTS->TS at wraparound
Edward Hervey [Sun, 5 Sep 2021 09:53:05 +0000 (11:53 +0200)]
tsdemux: Handle PTS->TS at wraparound

This has been a FIXME for ages.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1179>

2 years agowebrtcbin: fix prevention of webrtcbin deletion due to ref held by probe callback
Rob Agar [Thu, 14 Oct 2021 13:07:07 +0000 (14:07 +0100)]
webrtcbin: fix prevention of webrtcbin deletion due to ref held by probe callback

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/810

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1150>

2 years agod3d11: d3d11{convert,scale}: Add add-borders property
Seungha Yang [Sat, 16 Oct 2021 10:01:27 +0000 (19:01 +0900)]
d3d11: d3d11{convert,scale}: Add add-borders property

Functionally identical to that of videoscale element.

When disabled, d3d11convert or d3d11scale element will scale
image without adding borders, meaning that display aspect ratio
will not be preserved.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1170>

2 years agovapostproc: Add add-borders property to keep dar
Víctor Manuel Jáquez Leal [Sat, 16 Oct 2021 08:58:53 +0000 (10:58 +0200)]
vapostproc: Add add-borders property to keep dar

Just as videoscale, it enables add-borders property (FALSE by default)
in vapostproc to add border, if necessary, to keep the display aspect
ratio from the original image.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1169>

2 years agovapostproc: Fix early fixation.
Víctor Manuel Jáquez Leal [Sat, 16 Oct 2021 08:51:57 +0000 (10:51 +0200)]
vapostproc: Fix early fixation.

First copy missing fields and then fixate all remaining fields.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1169>

2 years agoofa: remove ofa audio fingerprinting plugin
Tim-Philipp Müller [Thu, 14 Oct 2021 18:08:49 +0000 (19:08 +0100)]
ofa: remove ofa audio fingerprinting plugin

I think the MusicIP database for this has been defunct for years,
so I can't imagine this plugin is particularly useful or still
used by anyone.

See https://musicbrainz.org/doc/Fingerprinting#PUID

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1153>

2 years agomeson: Define cpp_std in the top-level project()
Nirbheek Chauhan [Wed, 13 Oct 2021 08:05:51 +0000 (13:35 +0530)]
meson: Define cpp_std in the top-level project()

Due to a bug, meson ignores ${lang}_std settings in default_options
for subprojects: https://github.com/mesonbuild/meson/issues/1889

This causes build failures when a subproject requires c++11 or c++14,
etc. Compilers that support those cpp_stds are very common, and all
the toolchains that we support include c++ compilers, so we can
add cpp_std=c++14 to the top-level.

This fixes the webrtc-audio-processing build on Linux, and harfbuzz on
macOS.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1133>

2 years agomeson: wasapi2,mediafoundation: Work around Windows SDK header issue
Seungha Yang [Sat, 16 Oct 2021 13:43:32 +0000 (22:43 +0900)]
meson: wasapi2,mediafoundation: Work around Windows SDK header issue

Some SDK headers are not standard compliant, so MSVC will
complain when such headers are in use with "/permissive-" compile
option. Use "/Zc:twoPhase-" to work around the issue as documented in
https://docs.microsoft.com/en-us/cpp/build/reference/permissive-standards-conformance?view=msvc-160#windows-header-issues

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1174>

2 years agolame:meson: Avoid using fallback when we could use system install
Thibault Saunier [Sun, 17 Oct 2021 04:59:35 +0000 (01:59 -0300)]
lame:meson: Avoid using fallback when we could use system install

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1176>

2 years agosubprojects: update vorbis wrap to 1.3.7 and add fallback url
Tim-Philipp Müller [Sat, 16 Oct 2021 22:53:04 +0000 (23:53 +0100)]
subprojects: update vorbis wrap to 1.3.7 and add fallback url

The Windows CI runners complain about self-signed certificates
with the download.xiph.org urls.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1175>

2 years agosubprojects: update ogg wrap to 1.3.5 and add fallback url
Tim-Philipp Müller [Sat, 16 Oct 2021 22:50:51 +0000 (23:50 +0100)]
subprojects: update ogg wrap to 1.3.5 and add fallback url

The windows ci runners complain about a self-signed certificate
with the download.xiph.org urls.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1175>

2 years agovalidate:known_issues:rtsp: Mark error message on bus as known
Thibault Saunier [Sat, 16 Oct 2021 14:32:53 +0000 (11:32 -0300)]
validate:known_issues:rtsp: Mark error message on bus as known

See https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/814

And reindent file.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1171>

2 years agomeson: Mark newly fdkaac/ogg/vorbis as allow fallback
Thibault Saunier [Sat, 16 Oct 2021 12:29:28 +0000 (09:29 -0300)]
meson: Mark newly fdkaac/ogg/vorbis as allow fallback

This way when the dep is `auto` we will fallback if the system
dependency is not available.

And use https to get libvorbis

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/1171>