ojan@chromium.org [Fri, 23 Sep 2011 20:32:18 +0000 (20:32 +0000)]
refactor RenderFlexibleBox to use flex-flow aware methods
https://bugs.webkit.org/show_bug.cgi?id=68665
Reviewed by Tony Chang.
This is just a refactor. Just move the all the code that needs to
be flow aware into helper functions. Actually making them flow-aware
can be done in a followup patch.
* rendering/RenderBlock.cpp:
* rendering/RenderBlock.h:
Moved setLogicalLocationForChild into RenderFlexibleBox since that was the only caller.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::hasOrthogonalFlow):
(WebCore::RenderFlexibleBox::isHorizontalFlow):
(WebCore::RenderFlexibleBox::isLeftToRightFlow):
(WebCore::RenderFlexibleBox::setFlowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeightForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalWidthForChild):
(WebCore::RenderFlexibleBox::flowAwareLogicalHeight):
(WebCore::RenderFlexibleBox::flowAwareContentLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareAvailableLogicalWidth):
(WebCore::RenderFlexibleBox::flowAwareBorderStart):
(WebCore::RenderFlexibleBox::flowAwareBorderBefore):
(WebCore::RenderFlexibleBox::flowAwareBorderAfter):
(WebCore::RenderFlexibleBox::flowAwarePaddingStart):
(WebCore::RenderFlexibleBox::flowAwarePaddingBefore):
(WebCore::RenderFlexibleBox::flowAwarePaddingAfter):
(WebCore::RenderFlexibleBox::flowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginBeforeForChild):
(WebCore::RenderFlexibleBox::flowAwareMarginAfterForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginStartForChild):
(WebCore::RenderFlexibleBox::setFlowAwareMarginEndForChild):
(WebCore::RenderFlexibleBox::setFlowAwareLogicalLocationForChild):
(WebCore::RenderFlexibleBox::logicalBorderAndPaddingWidthForChild):
(WebCore::RenderFlexibleBox::logicalScrollbarHeightForChild):
(WebCore::RenderFlexibleBox::marginStartStyleForChild):
(WebCore::RenderFlexibleBox::marginEndStyleForChild):
(WebCore::RenderFlexibleBox::preferredLogicalContentWidthForFlexItem):
(WebCore::RenderFlexibleBox::layoutInlineDirection):
(WebCore::RenderFlexibleBox::logicalPositiveFlexForChild):
(WebCore::RenderFlexibleBox::logicalNegativeFlexForChild):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::setLogicalOverrideSize):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
* rendering/RenderFlexibleBox.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Fri, 23 Sep 2011 20:25:11 +0000 (20:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68719
Push through multiple regions when an object doesn't fit in any of them. Unlike with pages and
columns, when regions have a non-uniform height, we may need to push through multiple regions
in order to find one that fits.
Added an optimization for quickly noticing if regions do have a uniform height so that we can
treat them like columns and pages if so.
Also fixed the end line matchup to properly null out endLine when no next line box exists. The new
layout tests I wrote to cover this feature exposed this crasher, so fixing it in order to land
the new tests.
Reviewed by Anders Carlsson.
Source/WebCore:
Added new tests in fast/regions.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::pushToNextPageWithMinimumLogicalHeight):
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::matchedEndLine):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
* rendering/RenderFlowThread.h:
LayoutTests:
* fast/regions/webkit-flow-float-pushed-to-last-region.html: Added.
* fast/regions/webkit-flow-float-unable-to-push.html: Added.
* platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 23 Sep 2011 20:21:41 +0000 (20:21 +0000)]
PutScopedVar nodes should report that it has a var number
https://bugs.webkit.org/show_bug.cgi?id=68721
Reviewed by Anders Carlsson.
Another assertion fix.
* dfg/DFGNode.h:
(JSC::DFG::Node::hasVarNumber):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Sep 2011 20:11:05 +0000 (20:11 +0000)]
Move WebHitTestResult files to Shared/ in the Xcode project
https://bugs.webkit.org/show_bug.cgi?id=68718
Reviewed by Sam Weinig.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Fri, 23 Sep 2011 19:56:21 +0000 (19:56 +0000)]
Redrawing dirty parts of a large table is very slow
https://bugs.webkit.org/show_bug.cgi?id=64546
Patch by Konstantin Scheglov <scheglov@google.com> on 2011-09-23
Reviewed by David Hyatt.
Source/WebCore:
Move CollapsedBorderValues into RenderTable.h.
Calculate collapsed borders only once and re-use during paintObject().
Invalidate cache when cell, row, row group, col, col group or table border is changed.
Tests: fast/table/border-collapsing/cached-cell-append.html
fast/table/border-collapsing/cached-cell-remove.html
fast/table/border-collapsing/cached-change-cell-border-color.html
fast/table/border-collapsing/cached-change-cell-border-width.html
fast/table/border-collapsing/cached-change-col-border-color.html
fast/table/border-collapsing/cached-change-col-border-width.html
fast/table/border-collapsing/cached-change-colgroup-border-color.html
fast/table/border-collapsing/cached-change-colgroup-border-width.html
fast/table/border-collapsing/cached-change-row-border-color.html
fast/table/border-collapsing/cached-change-row-border-width.html
fast/table/border-collapsing/cached-change-table-border-color.html
fast/table/border-collapsing/cached-change-table-border-width.html
fast/table/border-collapsing/cached-change-tbody-border-color.html
fast/table/border-collapsing/cached-change-tbody-border-width.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::styleDidChange): Invalidate cache on border change.
(WebCore::RenderTable::layout): Invalidate cache if layout changed.
(WebCore::RenderTable::recalcCollapsedBorders): Ensures that cache is valid.
(WebCore::RenderTable::paintObject): Use cached collapsed borders.
* rendering/RenderTable.h:
(WebCore::RenderTable::invalidateCollapsedBorders): Accessor to mark cache invalid.
(WebCore::RenderTable::currentBorderValue): Rename to use word "value".
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleDidChange): If border changed, invalidate cache.
Rename to use word "value".
(WebCore::addBorderStyle):
(WebCore::RenderTableCell::collectBorderValues):
(WebCore::compareBorderValuesForQSort):
(WebCore::RenderTableCell::sortBorderValues):
(WebCore::RenderTableCell::paintCollapsedBorder):
* rendering/RenderTableCell.h:
If border changed, invalidate cache.
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::styleDidChange):
* rendering/RenderTableCol.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::styleDidChange):
LayoutTests:
Tests for invalidating collapsed borders cache.
* fast/table/border-collapsing/cached-cell-append-expected.png: Added.
* fast/table/border-collapsing/cached-cell-append-expected.txt: Added.
* fast/table/border-collapsing/cached-cell-append.html: Added.
* fast/table/border-collapsing/cached-cell-remove-expected.png: Added.
* fast/table/border-collapsing/cached-cell-remove-expected.txt: Added.
* fast/table/border-collapsing/cached-cell-remove.html: Added.
* fast/table/border-collapsing/cached-change-cell-border-color-expected.png: Added.
* fast/table/border-collapsing/cached-change-cell-border-color-expected.txt: Added.
* fast/table/border-collapsing/cached-change-cell-border-color.html: Added.
* fast/table/border-collapsing/cached-change-cell-border-width-expected.png: Added.
* fast/table/border-collapsing/cached-change-cell-border-width-expected.txt: Added.
* fast/table/border-collapsing/cached-change-cell-border-width.html: Added.
* fast/table/border-collapsing/cached-change-col-border-color-expected.png: Added.
* fast/table/border-collapsing/cached-change-col-border-color-expected.txt: Added.
* fast/table/border-collapsing/cached-change-col-border-color.html: Added.
* fast/table/border-collapsing/cached-change-col-border-width-expected.png: Added.
* fast/table/border-collapsing/cached-change-col-border-width-expected.txt: Added.
* fast/table/border-collapsing/cached-change-col-border-width.html: Added.
* fast/table/border-collapsing/cached-change-colgroup-border-color-expected.png: Added.
* fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt: Added.
* fast/table/border-collapsing/cached-change-colgroup-border-color.html: Added.
* fast/table/border-collapsing/cached-change-colgroup-border-width-expected.png: Added.
* fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt: Added.
* fast/table/border-collapsing/cached-change-colgroup-border-width.html: Added.
* fast/table/border-collapsing/cached-change-row-border-color-expected.png: Added.
* fast/table/border-collapsing/cached-change-row-border-color-expected.txt: Added.
* fast/table/border-collapsing/cached-change-row-border-color.html: Added.
* fast/table/border-collapsing/cached-change-row-border-width-expected.png: Added.
* fast/table/border-collapsing/cached-change-row-border-width-expected.txt: Added.
* fast/table/border-collapsing/cached-change-row-border-width.html: Added.
* fast/table/border-collapsing/cached-change-table-border-color-expected.png: Added.
* fast/table/border-collapsing/cached-change-table-border-color-expected.txt: Added.
* fast/table/border-collapsing/cached-change-table-border-color.html: Added.
* fast/table/border-collapsing/cached-change-table-border-width-expected.png: Added.
* fast/table/border-collapsing/cached-change-table-border-width-expected.txt: Added.
* fast/table/border-collapsing/cached-change-table-border-width.html: Added.
* fast/table/border-collapsing/cached-change-tbody-border-color-expected.png: Added.
* fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt: Added.
* fast/table/border-collapsing/cached-change-tbody-border-color.html: Added.
* fast/table/border-collapsing/cached-change-tbody-border-width-expected.png: Added.
* fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt: Added.
* fast/table/border-collapsing/cached-change-tbody-border-width.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 23 Sep 2011 19:48:26 +0000 (19:48 +0000)]
Add a bunch of unhandled node types to the propagator
https://bugs.webkit.org/show_bug.cgi?id=68716
Reviewed by Darin Adler.
Remove the ASSERT_NOT_REACHED() default for debug builds in the
prediction propagator, this way unhandled nodes will just cause
compile time failures rather than failing at some point in the
future.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 23 Sep 2011 19:46:50 +0000 (19:46 +0000)]
update layout_tests to account for new default of use_skia=1
https://bugs.webkit.org/show_bug.cgi?id=68698
Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
(Chromium-on-Mac now uses the Skia graphics library instead of
Core Graphics).
Also updates layout_test code to work with that change.
Patch by Elliot Poger <epoger@google.com> on 2011-09-23
Reviewed by Mihai Parparita.
Source/WebKit/chromium:
* DEPS:
Tools:
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Fri, 23 Sep 2011 19:40:09 +0000 (19:40 +0000)]
Add static version of JSCell::visitChildren
https://bugs.webkit.org/show_bug.cgi?id=68404
Reviewed by Darin Adler.
.:
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
* Source/autotools/symbols.filter:
Source/JavaScriptCore:
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
* API/JSCallbackObject.h:
(JSC::JSCallbackObject::visitChildrenVirtual):
(JSC::JSCallbackObject::visitChildren):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::visitChildrenVirtual):
(JSC::DebuggerActivation::visitChildren):
* debugger/DebuggerActivation.h:
* heap/MarkStack.cpp:
(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::drain):
* runtime/Arguments.cpp:
(JSC::Arguments::visitChildrenVirtual):
(JSC::Arguments::visitChildren):
* runtime/Arguments.h:
* runtime/Executable.cpp:
(JSC::EvalExecutable::visitChildrenVirtual):
(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildrenVirtual):
(JSC::ProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildrenVirtual):
(JSC::FunctionExecutable::visitChildren):
* runtime/Executable.h:
* runtime/GetterSetter.cpp:
(JSC::GetterSetter::visitChildrenVirtual):
(JSC::GetterSetter::visitChildren):
* runtime/GetterSetter.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildrenVirtual):
(JSC::JSActivation::visitChildren):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::visitChildrenVirtual):
(JSC::JSArray::visitChildren):
* runtime/JSArray.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::visitChildrenVirtual):
(JSC::JSBoundFunction::visitChildren):
* runtime/JSBoundFunction.h:
* runtime/JSCell.h:
(JSC::JSCell::visitChildrenVirtual):
(JSC::JSCell::visitChildren):
* runtime/JSFunction.cpp:
(JSC::JSFunction::visitChildrenVirtual):
(JSC::JSFunction::visitChildren):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::visitChildrenVirtual):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildrenVirtual):
(JSC::JSObject::visitChildren):
* runtime/JSObject.h:
(JSC::JSObject::visitChildrenDirect):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::visitChildrenVirtual):
(JSC::JSPropertyNameIterator::visitChildren):
* runtime/JSPropertyNameIterator.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::visitChildrenVirtual):
(JSC::JSStaticScopeObject::visitChildren):
* runtime/JSStaticScopeObject.h:
* runtime/JSWrapperObject.cpp:
(JSC::JSWrapperObject::visitChildrenVirtual):
(JSC::JSWrapperObject::visitChildren):
* runtime/JSWrapperObject.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::visitChildrenVirtual):
(JSC::NativeErrorConstructor::visitChildren):
* runtime/NativeErrorConstructor.h:
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::visitChildrenVirtual):
(JSC::RegExpObject::visitChildren):
* runtime/RegExpObject.h:
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::visitChildrenVirtual):
(JSC::ScopeChainNode::visitChildren):
* runtime/ScopeChain.h:
* runtime/Structure.cpp:
(JSC::Structure::visitChildrenVirtual):
(JSC::Structure::visitChildren):
* runtime/Structure.h:
* runtime/StructureChain.cpp:
(JSC::StructureChain::visitChildrenVirtual):
(JSC::StructureChain::visitChildren):
* runtime/StructureChain.h:
Source/JavaScriptGlue:
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
* UserObjectImp.cpp:
(UserObjectImp::visitChildrenVirtual):
(UserObjectImp::visitChildren):
* UserObjectImp.h:
Source/WebCore:
No new tests.
In this patch we just extract the bodies of the virtual visitChildren methods
throughout the JSCell inheritance hierarchy out into static methods, which are
now called from the virtual methods. This is an intermediate step in trying to
move the virtual-ness of visitChildren into our own custom vtable stored in
ClassInfo. We need to convert the methods to static methods in order to be
able to more easily store and refer to them in our custom vtable since normal
member methods store some implicit information in their types, making it
impossible to store them generically in ClassInfo.
* WebCore.exp.in:
* bindings/js/JSAttrCustom.cpp:
(WebCore::JSAttr::visitChildrenVirtual):
(WebCore::JSAttr::visitChildren):
* bindings/js/JSAudioContextCustom.cpp:
(WebCore::JSAudioContext::visitChildrenVirtual):
(WebCore::JSAudioContext::visitChildren):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::JSCSSRule::visitChildrenVirtual):
(WebCore::JSCSSRule::visitChildren):
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::visitChildrenVirtual):
(WebCore::JSCSSStyleDeclaration::visitChildren):
* bindings/js/JSCanvasRenderingContextCustom.cpp:
(WebCore::JSCanvasRenderingContext::visitChildrenVirtual):
(WebCore::JSCanvasRenderingContext::visitChildren):
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildrenVirtual):
(WebCore::JSDOMGlobalObject::visitChildren):
* bindings/js/JSDOMGlobalObject.h:
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitChildrenVirtual):
(WebCore::JSDOMWindow::visitChildren):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::visitChildrenVirtual):
(WebCore::JSDOMWindowShell::visitChildren):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSJavaScriptAudioNodeCustom.cpp:
(WebCore::JSJavaScriptAudioNode::visitChildrenVirtual):
(WebCore::JSJavaScriptAudioNode::visitChildren):
* bindings/js/JSMessageChannelCustom.cpp:
(WebCore::JSMessageChannel::visitChildrenVirtual):
(WebCore::JSMessageChannel::visitChildren):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::visitChildrenVirtual):
(WebCore::JSMessagePort::visitChildren):
* bindings/js/JSNamedNodeMapCustom.cpp:
(WebCore::JSNamedNodeMap::visitChildrenVirtual):
(WebCore::JSNamedNodeMap::visitChildren):
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::visitChildrenVirtual):
(WebCore::JSNode::visitChildren):
* bindings/js/JSNodeFilterCustom.cpp:
(WebCore::JSNodeFilter::visitChildrenVirtual):
(WebCore::JSNodeFilter::visitChildren):
* bindings/js/JSNodeIteratorCustom.cpp:
(WebCore::JSNodeIterator::visitChildrenVirtual):
(WebCore::JSNodeIterator::visitChildren):
* bindings/js/JSSVGElementInstanceCustom.cpp:
(WebCore::JSSVGElementInstance::visitChildrenVirtual):
(WebCore::JSSVGElementInstance::visitChildren):
* bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorker::visitChildrenVirtual):
(WebCore::JSSharedWorker::visitChildren):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::JSStyleSheet::visitChildrenVirtual):
(WebCore::JSStyleSheet::visitChildren):
* bindings/js/JSTreeWalkerCustom.cpp:
(WebCore::JSTreeWalker::visitChildrenVirtual):
(WebCore::JSTreeWalker::visitChildren):
* bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::visitChildrenVirtual):
(WebCore::JSWebGLRenderingContext::visitChildren):
* bindings/js/JSWorkerContextCustom.cpp:
(WebCore::JSWorkerContext::visitChildrenVirtual):
(WebCore::JSWorkerContext::visitChildren):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::visitChildrenVirtual):
(WebCore::JSXMLHttpRequest::visitChildren):
* bindings/js/JSXPathResultCustom.cpp:
(WebCore::JSXPathResult::visitChildrenVirtual):
(WebCore::JSXPathResult::visitChildren):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::visitChildrenVirtual):
(WebCore::JSTestObj::visitChildren):
* bindings/scripts/test/JS/JSTestObj.h:
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtRuntimeObject::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeObject::visitChildren):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::visitChildrenVirtual):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
* bridge/qt/qt_runtime.h:
* workers/WorkerContext.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Sep 2011 19:31:31 +0000 (19:31 +0000)]
Axe WebImageRendererFactory
https://bugs.webkit.org/show_bug.cgi?id=68715
Reviewed by Darin Adler.
../..:
Remove WebImageRendererFactory.m from the Xcode project.
* WebKit.xcodeproj/project.pbxproj:
../../mac:
Remove WebImageRendererFactory, it was used by Safari 3, many a moon ago.
* WebCoreSupport/WebImageRendererFactory.m: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Sep 2011 19:24:34 +0000 (19:24 +0000)]
Add OVERRIDE to a bunch of virtual member functions on clients
https://bugs.webkit.org/show_bug.cgi?id=68712
Reviewed by Sam Weinig.
../..:
* WebKit.xcodeproj/project.pbxproj:
../../mac:
* Configurations/Base.xcconfig:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebContextMenuClient.h:
* WebCoreSupport/WebDeviceOrientationClient.h:
* WebCoreSupport/WebDragClient.h:
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameNetworkingContext.h:
* WebCoreSupport/WebGeolocationClient.h:
* WebCoreSupport/WebIconDatabaseClient.h:
* WebCoreSupport/WebInspectorClient.h:
* WebCoreSupport/WebPlatformStrategies.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 23 Sep 2011 19:19:33 +0000 (19:19 +0000)]
Node propagation doesn't handle PutScopedVar
https://bugs.webkit.org/show_bug.cgi?id=68713
Reviewed by Sam Weinig.
This was causing assertion failures.
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Fri, 23 Sep 2011 19:19:03 +0000 (19:19 +0000)]
Clarify wording in cross origin XSL tests and enable on all platforms
https://bugs.webkit.org/show_bug.cgi?id=68683
The condition for passing the test should be more clear now. Also, since the redirect case works on all platforms, the regular case should also work on all platforms.
Reviewed by Alexey Proskuryakov.
* http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* http/tests/security/cross-origin-xsl-BLOCKED.html:
* http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* http/tests/security/cross-origin-xsl-redirect-BLOCKED.html:
* platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/chromium-cg-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/chromium-mac/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/chromium-win/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/gtk/Skipped:
* platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/gtk/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/mac-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/qt-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/qt-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/win-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
* platform/win-wk2/http/tests/security/cross-origin-xsl-redirect-BLOCKED-expected.txt:
* platform/wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Sep 2011 19:17:15 +0000 (19:17 +0000)]
Make sure to define OVERRIDE and FINAL for older builds of clang.
* wtf/Compiler.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 23 Sep 2011 19:07:18 +0000 (19:07 +0000)]
Mark two more tests as flaky.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 23 Sep 2011 18:52:19 +0000 (18:52 +0000)]
Implement op_resolve_global in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=68704
Reviewed by Oliver Hunt.
This is performance neutral, but increases coverage.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::resolveInfoIndex):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Fri, 23 Sep 2011 18:51:04 +0000 (18:51 +0000)]
[GTK] Remove extra space at the beginning of the last line.
https://bugs.webkit.org/show_bug.cgi?id=68710
Reviewed by Gustavo Noronha Silva.
* platform/network/soup/SocketStreamHandleSoup.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 23 Sep 2011 18:41:33 +0000 (18:41 +0000)]
Mark a test as flaky.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Fri, 23 Sep 2011 18:24:20 +0000 (18:24 +0000)]
2011-09-23 Mario Sanchez Prada <msanchez@igalia.com>
[GTK] Fix coding style issues in ResourceRequestSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=68707
Reviewed by Xan Lopez.
This patch fixes some issues as reported by check-webkit-style.
* platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateFromSoupMessage):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Sep 2011 18:07:33 +0000 (18:07 +0000)]
Add OVERRIDE to overrides of virtual member functions in client classes
https://bugs.webkit.org/show_bug.cgi?id=68702
Reviewed by Darin Adler.
Disable the warning in Xcode and VS2005 for using override and final when compiling as C++98,
and remove WebEditorClient::isEditable, WebChromeClient::formDidFocus,
WebChromeClient::formDidBlur and WebFrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest since
they have been removed from their respective base classes.
* Configurations/Base.xcconfig:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebContextMenuClient.h:
* WebProcess/WebCoreSupport/WebDatabaseManager.h:
* WebProcess/WebCoreSupport/WebDragClient.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebCoreSupport/WebGeolocationClient.h:
* WebProcess/WebCoreSupport/WebInspectorClient.h:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
* WebProcess/WebCoreSupport/WebPopupMenu.h:
* WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
* win/WebKit2Common.vsprops:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 23 Sep 2011 17:46:51 +0000 (17:46 +0000)]
Define BUILDING_ON_LION / TARGETING_LION when appropriate in Platform.h.
* wtf/Platform.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 23 Sep 2011 17:46:46 +0000 (17:46 +0000)]
Fix the build.
* TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
the WTF namespace.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ademar.reis@openbossa.org [Fri, 23 Sep 2011 17:38:27 +0000 (17:38 +0000)]
Unreviewed: [Qt] Workaround MSVC2010 problems when linking QtWebKit
Include MSVC2010 in the list of compilers where incremental
build is disabled (INCREMENTAL:NO).
Change suggested by Simo Falt <simo.falt@nokia.com>, already present
in the Qt-4.8 repository where the problem was identified.
* WebCore.pri:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 23 Sep 2011 17:03:31 +0000 (17:03 +0000)]
Unreviewed. Normalize test names.
* inspector/performance/resources/first-open-elements.html:
* inspector/performance/resources/first-open-resources.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 23 Sep 2011 16:59:51 +0000 (16:59 +0000)]
Try to fix warning seen in some 32-bit builds.
* rendering/RenderBoxModelObject.cpp:
(WebCore::backgroundRectAdjustedForBleedAvoidance):
Use an explicit cast for the conversion from a double to a LayoutUnit.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Sep 2011 16:49:08 +0000 (16:49 +0000)]
We should add support for OVERRIDE and FINAL annotations
https://bugs.webkit.org/show_bug.cgi?id=68654
Reviewed by David Hyatt.
Add OVERRIDE and FINAL macros for compilers that support them.
* wtf/Compiler.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 23 Sep 2011 16:47:26 +0000 (16:47 +0000)]
Fix typo in file name from trac.webkit.org/changeset/95813.
Unreviewed.
* platform/gtk/media/video-playing-and-pause-actual.txt: Removed.
* platform/gtk/media/video-playing-and-pause-expected.txt: Copied from LayoutTests/platform/gtk/media/video-playing-and-pause-actual.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 23 Sep 2011 16:39:31 +0000 (16:39 +0000)]
Rebaseline after trac.webkit.org/changeset/95799
Unreviewed.
* platform/mac-wk2/media/video-playing-and-pause-expected.txt: Added.
* platform/mac/media/video-playing-and-pause-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 23 Sep 2011 16:19:51 +0000 (16:19 +0000)]
Rebaseline after trac.webkit.org/changeset/95799
Unreviewed.
* platform/gtk/media/video-playing-and-pause-actual.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Fri, 23 Sep 2011 16:10:58 +0000 (16:10 +0000)]
2011-09-23 Xan Lopez <xlopez@igalia.com>
[GTK] Skip crashing test fast/workers/storage/interrupt-database.html
https://bugs.webkit.org/show_bug.cgi?id=68700
Unreviewed.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 23 Sep 2011 15:57:13 +0000 (15:57 +0000)]
Web Inspector: Clicking on error doesn't point on the correct line if user searched something
https://bugs.webkit.org/show_bug.cgi?id=68627
Reviewed by Yury Semikhatsky.
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.disableSearchUntilExplicitAction):
* inspector/front-end/inspector.js:
(WebInspector._showAnchorLocationInPanel):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 23 Sep 2011 15:22:35 +0000 (15:22 +0000)]
Web Inspector: InspectorStyleSheet should use stylesheet's original url, not final one.
https://bugs.webkit.org/show_bug.cgi?id=68631
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: http/tests/inspector/styles/styles-redirected-css.html
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::resourceStyleSheetText):
LayoutTests:
* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.getElementStylePropertyTreeItem):
(initialize_ElementTest.InspectorTest.getMatchedStylePropertyTreeItem):
(initialize_ElementTest.InspectorTest.getFirstPropertyTreeItemForSection):
* http/tests/inspector/styles/resources/styles-redirected-css.css: Added.
(div):
* http/tests/inspector/styles/resources/styles-redirected-css.php: Added.
* http/tests/inspector/styles/styles-redirected-css-expected.txt: Added.
* http/tests/inspector/styles/styles-redirected-css.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 23 Sep 2011 15:08:09 +0000 (15:08 +0000)]
Web Inspector: XHRs requests with the same url as main resource should have correct category.
https://bugs.webkit.org/show_bug.cgi?id=68646
Reviewed by Yury Semikhatsky.
Source/WebCore:
Test: http/tests/inspector/network/network-xhr-same-url-as-main-resource.html
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveResponse):
LayoutTests:
* http/tests/inspector/network/network-xhr-same-url-as-main-resource-expected.txt: Added.
* http/tests/inspector/network/network-xhr-same-url-as-main-resource.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jesus@webkit.org [Fri, 23 Sep 2011 15:06:36 +0000 (15:06 +0000)]
[Qt][WK2] QtFileDownloader ctor shouldn't call QtFileDownloader::onReadyRead()
https://bugs.webkit.org/show_bug.cgi?id=68696
Reviewed by Andreas Kling.
Instead of connecting signals and calling QtFileDownloader::onReadyRead()
on its constructor, QtFileDownloader will now handle this in start().
* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::start):
* WebProcess/Downloads/qt/QtFileDownloader.cpp:
(WebKit::QtFileDownloader::QtFileDownloader):
(WebKit::QtFileDownloader::start):
* WebProcess/Downloads/qt/QtFileDownloader.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bulach@chromium.org [Fri, 23 Sep 2011 14:58:30 +0000 (14:58 +0000)]
[chromium] Update expectation for pservers-grad-14-b.svg on snowleopard
https://bugs.webkit.org/show_bug.cgi?id=68697
Unreviewed rebaseline.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 23 Sep 2011 14:35:07 +0000 (14:35 +0000)]
Web Inspector: Add context menu action to navigate from resources panel resource to network panel.
https://bugs.webkit.org/show_bug.cgi?id=68657
Reviewed by Yury Semikhatsky.
* English.lproj/localizedStrings.js:
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.showAnchorLocation):
(WebInspector.NetworkPanel.prototype.revealAndHighlightResource):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.FrameResourceTreeElement.prototype._handleContextMenuEvent):
(WebInspector.FrameResourceTreeElement.prototype._appendOpenInNetworkPanelAction):
* inspector/front-end/inspector.js:
(WebInspector.openInNetworkPanelLabel):
(WebInspector.openRequestInNetworkPanel):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Sep 2011 14:14:01 +0000 (14:14 +0000)]
[Gtk] Title attribute is not respected on option elements.
https://bugs.webkit.org/show_bug.cgi?id=68615
Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-23
Reviewed by Martin Robinson.
Set tooltip on PopupMenuGtk items created from GtkActions.
* platform/gtk/GtkPopupMenu.cpp:
(WebCore::GtkPopupMenu::appendItem): Added a call to gtk_widget_set_tooltip_text()
to set the tooltip on menuitem. Tooltip text is retrieved from GtkAction.
* platform/gtk/PopupMenuGtk.cpp:
(WebCore::PopupMenuGtk::createGtkActionForMenuItem): Pass the tooltip text
from client when creating a GtkAction.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 23 Sep 2011 14:03:46 +0000 (14:03 +0000)]
[Qt][Gtk] Wrong state when pausing a video in the "playing" event handler
https://bugs.webkit.org/show_bug.cgi?id=68589
Reviewed by Philippe Normand.
Source/WebCore:
Test: media/video-playing-and-pause.html
As suggested by Alexis Menard on IRC, query gstreamer's state instead of using a cached value
in MediaPlayerGstreamerPrivate::paused().
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::paused):
LayoutTests:
* media/video-playing-and-pause.html: Added.
* media/video-paint-test.js:
* platform/qt/media/video-playing-and-pause-expected.txt: Added.
* platform/qt/media/video-playing-and-pause-expected.png: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bulach@chromium.org [Fri, 23 Sep 2011 13:48:37 +0000 (13:48 +0000)]
[chromium, gtk, qt] Rebaseline following r95726
https://bugs.webkit.org/show_bug.cgi?id=68694
Unreviewed rebaseline.
* css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.txt.
* css2.1/
20110323/abspos-replaced-width-margin-000-expected.txt: Renamed from LayoutTests/platform/gtk/css2.1/
20110323/abspos-replaced-width-margin-000-expected.txt.
* platform/chromium/css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
* platform/chromium/css2.1/
20110323/abspos-replaced-width-margin-000-expected.png: Added.
* platform/qt/css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.txt: Removed.
* platform/qt/css2.1/
20110323/abspos-replaced-width-margin-000-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 23 Sep 2011 13:17:49 +0000 (13:17 +0000)]
Web Inspector: skip overlapping scripts when displaying concatenated content.
https://bugs.webkit.org/show_bug.cgi?id=68144
Source/WebCore:
Dynamically appended script tags have wrong offsets and cause troubles building concatenated content.
Reviewed by Pavel Feldman.
* inspector/front-end/SourceFile.js:
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent.appendChunk):
(WebInspector.ConcatenatedScriptsContentProvider.prototype._concatenateScriptsContent):
LayoutTests:
Reviewed by Pavel Feldman.
* inspector/debugger/content-providers-expected.txt:
* inspector/debugger/content-providers.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Fri, 23 Sep 2011 13:04:46 +0000 (13:04 +0000)]
2011-09-23 Xan Lopez <xlopez@igalia.com>
[GTK] Rebaseline following r95745, r95725
Unreviewed rebaseline.
* platform/gtk/editing/deleting/merge-whitespace-pre-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bulach@chromium.org [Fri, 23 Sep 2011 12:43:31 +0000 (12:43 +0000)]
[chromium] Rebaseline following r95745, r95725
https://bugs.webkit.org/show_bug.cgi?id=68685
Unreviewed rebaseline.
* platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 23 Sep 2011 12:06:15 +0000 (12:06 +0000)]
Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312
Reviewed by Yury Semikhatsky.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createFileSelector):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 23 Sep 2011 11:43:30 +0000 (11:43 +0000)]
Unreviewed, rolling out r95383.
http://trac.webkit.org/changeset/95383
https://bugs.webkit.org/show_bug.cgi?id=68690
It broke WebInspector.Timeline.LoadFromFile feature.
(Requested by loislo on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-23
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createFileSelector):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 23 Sep 2011 10:59:59 +0000 (10:59 +0000)]
Web Inspector: UI performance test for Scripts panel first open experience.
https://bugs.webkit.org/show_bug.cgi?id=68541
The test's body has dummy scripts section copied from inspector-test.jss
Reviewed by Yury Semikhatsky.
* inspector/performance/resources/first-open-scripts.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Sep 2011 10:56:23 +0000 (10:56 +0000)]
use after free in WebCore::SVGTRefElement::updateReferencedText
https://bugs.webkit.org/show_bug.cgi?id=67555
Patch by Rob Buis <rbuis@rim.com> on 2011-09-23
Reviewed by Nikolas Zimmermann.
Source/WebCore:
Event listeners can outlive the tref element that created them when
the tref is cloned and then garbage collected, causing a dangling pointer to the
tref. To fix this do not install event listener until the tref is inserted into the document.
Test: svg/custom/tref-clone-crash.html
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::svgAttributeChanged):
(WebCore::SVGTRefElement::insertedIntoDocument):
* svg/SVGTRefElement.h:
LayoutTests:
Test that cloned tref does not cause a crash.
* svg/custom/tref-clone-crash-expected.txt: Added.
* svg/custom/tref-clone-crash.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 23 Sep 2011 10:46:54 +0000 (10:46 +0000)]
ASSERTION FAILED: documentLoader in WebKit/Source/WebCore/inspector/InspectorInstrumentation.cpp(597)
https://bugs.webkit.org/show_bug.cgi?id=68291
Reviewed by Tony Chang.
* dom/Document.cpp:
(WebCore::Document::finishedParsing):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::domContentLoadedEventFiredImpl):
(WebCore::InspectorInstrumentation::loadEventFiredImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::domContentLoadedEventFired):
(WebCore::InspectorInstrumentation::loadEventFired):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::dispatchLoadEvent):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Fri, 23 Sep 2011 10:35:28 +0000 (10:35 +0000)]
2011-09-23 Xan Lopez <xlopez@igalia.com>
Crash on editing/pasteboard/drag-drop-input-in-svg.svg
https://bugs.webkit.org/show_bug.cgi?id=68686
Unreviewed, skip crashing test.
* platform/gtk/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Fri, 23 Sep 2011 09:19:32 +0000 (09:19 +0000)]
plugins/mouse-click-iframe-to-plugin.html should not use flash plugin
https://bugs.webkit.org/show_bug.cgi?id=68601
Use the test plugin that we always have.
* platform/qt-wk2/Skipped: Unskip the test.
* plugins/mouse-click-iframe-to-plugin.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 23 Sep 2011 07:18:48 +0000 (07:18 +0000)]
Source/JavaScriptCore: GetScopedVar should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=68676
Patch by Filip Pizlo <fpizlo@apple.com> on 2011-09-22
Reviewed by Oliver Hunt.
Added GetScopedVar value profiling and predictin propagation.
Added GetScopeChain to CSE.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasPrediction):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getScopeChainLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_scoped_var):
LayoutTests: [Qt] Unreviewed gardening, update expected file after r95745.
Patch by Csaba Osztrogonác <ossy@webkit.org> on 2011-09-22
* platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
* platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 23 Sep 2011 06:59:38 +0000 (06:59 +0000)]
GetScopedVar should have value profiling
https://bugs.webkit.org/show_bug.cgi?id=68676
Reviewed by Oliver Hunt.
Added GetScopedVar value profiling and predictin propagation.
Added GetScopeChain to CSE.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasPrediction):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::getScopeChainLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_scoped_var):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 23 Sep 2011 05:58:55 +0000 (05:58 +0000)]
[Qt] Unreviewed gardening, update expected file after r95745.
* platform/qt/editing/deleting/merge-whitespace-pre-expected.png:
* platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 23 Sep 2011 05:53:32 +0000 (05:53 +0000)]
Unreviewed fix after r95764, update expected fail to expected pass.
* ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 23 Sep 2011 04:54:42 +0000 (04:54 +0000)]
implement -webkit-flex-order
https://bugs.webkit.org/show_bug.cgi?id=67432
Reviewed by Ojan Vafai.
Source/WebCore:
flex-order can be an int (including negative), but we disallow the two
smallest values so we can put the numbers into a hash set.
Also, create two iterators: one that goes in render tree order (we use
this for the first pass and to collect the possible flex order values)
and one that goes in flex order.
Test: css3/flexbox/flex-order.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* rendering/RenderFlexibleBox.cpp:
(WebCore::FlexOrderHashTraits::emptyValue):
(WebCore::FlexOrderHashTraits::constructDeletedValue):
(WebCore::FlexOrderHashTraits::isDeletedValue):
(WebCore::RenderFlexibleBox::TreeOrderIterator::TreeOrderIterator): A simple iterator
that goes in render tree order.
(WebCore::RenderFlexibleBox::TreeOrderIterator::next):
(WebCore::RenderFlexibleBox::TreeOrderIterator::reset):
(WebCore::RenderFlexibleBox::TreeOrderIterator::flexOrderValues):
(WebCore::RenderFlexibleBox::FlexOrderIterator::FlexOrderIterator): An iterator that
goes in flex-order order. Creating this involves sorting, so only create it once
and pass it around.
(WebCore::RenderFlexibleBox::FlexOrderIterator::first):
(WebCore::RenderFlexibleBox::FlexOrderIterator::next):
(WebCore::RenderFlexibleBox::FlexOrderIterator::reset):
(WebCore::RenderFlexibleBox::layoutHorizontalBlock):
(WebCore::RenderFlexibleBox::computePreferredLogicalWidth):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithmInlineDirection):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildrenInlineDirection):
* rendering/RenderFlexibleBox.h:
LayoutTests:
* css3/flexbox/flex-order-expected.png: Added.
* css3/flexbox/flex-order-expected.txt: Added.
* css3/flexbox/flex-order.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 23 Sep 2011 04:10:24 +0000 (04:10 +0000)]
Use AffineTransform scale functions in ShadowBlur::adjustBlurRadius
https://bugs.webkit.org/show_bug.cgi?id=68667
Reviewed by Simon Fraser.
* platform/graphics/ShadowBlur.cpp:
(WebCore::ShadowBlur::adjustBlurRadius): Use AffineTransform::xScale and
AffineTransform::yScale instead of the custom code here that seems to do
the same thing.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Fri, 23 Sep 2011 04:00:18 +0000 (04:00 +0000)]
enable NRWT for run-webkit-tests on Lion
https://bugs.webkit.org/show_bug.cgi?id=68673
Reviewed by Eric Seidel.
* Scripts/run-webkit-tests:
(useNewRunWebKitTests):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Sep 2011 03:35:15 +0000 (03:35 +0000)]
Rebaseline for bug 65583 (path based border radius drawing on skia) part 6
https://bugs.webkit.org/show_bug.cgi?id=68671
Patch by Ben Wells <benwells@chromium.org> on 2011-09-22
Reviewed by James Robinson.
* platform/chromium-linux/tables/mozilla/marvin/: 9 changes
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/: 14 changes
* platform/chromium-linux/transforms/svg-vs-css-expected.png:
* platform/chromium-win/tables/mozilla/marvin/: 9 changes
* platform/chromium-win/tables/mozilla_expected_failures/marvin/: 14 changes
* platform/chromium-win/transforms/svg-vs-css-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 23 Sep 2011 03:27:40 +0000 (03:27 +0000)]
PPC build fix, part 3.
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForConstructInternal):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 23 Sep 2011 03:21:12 +0000 (03:21 +0000)]
Remove unneeded type conversion from background bleed code
https://bugs.webkit.org/show_bug.cgi?id=68669
Reviewed by Geoffrey Garen.
* rendering/RenderBoxModelObject.cpp:
(WebCore::backgroundRectAdjustedForBleedAvoidance): Use ceil instead of ceilf
and eliminate superflous conversion to float and use of FloatSize. Also added
a "why" comment.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 23 Sep 2011 03:00:38 +0000 (03:00 +0000)]
Refactor checks for antialiasing lines to share a single function
https://bugs.webkit.org/show_bug.cgi?id=68666
Reviewed by Dan Bernstein.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules): Call shouldAntialiasLines.
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintBorder): Ditto.
(WebCore::RenderBoxModelObject::shouldAntialiasLines): Added.
* rendering/RenderBoxModelObject.h: Added shouldAntialiasLines function.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::paintOutlineForLine): Call shouldAntialiasLines.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintCollapsedBorder): Ditto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Sep 2011 02:41:55 +0000 (02:41 +0000)]
Remove unused members from LayerChromium.
These members are never set, and never used.
Other members that are set but not used have been left (we may use them
later, e.g. m_opaque).
https://bugs.webkit.org/show_bug.cgi?id=68297
Patch by Antoine Labour <piman@chromium.org> on 2011-09-22
Reviewed by James Robinson.
No functional change, no new test needed.
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
annacc@chromium.org [Fri, 23 Sep 2011 02:40:16 +0000 (02:40 +0000)]
Adding testTracks() function to video-test.js
https://bugs.webkit.org/show_bug.cgi?id=68643
Reviewed by Eric Carlson.
* media/video-test.js:
(testTracks):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Sep 2011 02:28:31 +0000 (02:28 +0000)]
Make XSSAuditor extract meaningful snippet from script blocks for comparison
against the URL when checking for reflection. Avoids getting caugh up in
trailing comments.
https://bugs.webkit.org/show_bug.cgi?id=68094
Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-22
Reviewed by Adam Barth.
Source/WebCore:
Tests: http/tests/security/xssAuditor/script-tag-with-trailing-comment.html
http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html
http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
(WebCore::XSSAuditor::extractCodeFragment):
* html/parser/XSSAuditor.h:
LayoutTests:
* http/tests/security/xssAuditor/resources/echo-intertag.pl:
* http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-trailing-comment.html: Added.
* http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-trailing-comment2.html: Added.
* http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-trailing-comment3.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Sep 2011 02:27:59 +0000 (02:27 +0000)]
[Qt] TouchWebView load test not running
https://bugs.webkit.org/show_bug.cgi?id=68620
Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-22
Reviewed by Chang Shu.
Load test was not executed since it was missing in pro file. Added tst_load.qml to qmltests.pro
* UIProcess/API/qt/tests/qmltests/qmltests.pro:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 23 Sep 2011 02:16:00 +0000 (02:16 +0000)]
Another PPC build fix.
* runtime/Executable.cpp:
* runtime/Executable.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Sep 2011 01:56:59 +0000 (01:56 +0000)]
Rebaseline for bug 65583 (path based border radius drawing on skia) part 5
https://bugs.webkit.org/show_bug.cgi?id=68608
Patch by Ben Wells <benwells@chromium.org> on 2011-09-22
Reviewed by James Robinson.
* platform/chromium-linux/css2.1/: 14 changes
* platform/chromium-linux/editing/execCommand/5138441-expected.png:
* platform/chromium-linux/editing/inserting/editing-empty-divs-expected.png:
* platform/chromium-linux/editing/selection/transformed-selection-rects-expected.png:
* platform/chromium-linux/fast/: 9 changes
* platform/chromium-win/css2.1/: 14 changes
* platform/chromium-win/editing/execCommand/5138441-expected.png:
* platform/chromium-win/editing/inserting/editing-empty-divs-expected.png:
* platform/chromium-win/editing/selection/transformed-selection-rects-expected.png:
* platform/chromium-win/fast/: 10 changes
* platform/chromium/test_expectations.txt:
* platform/win-xp/editing/selection/transformed-selection-rects-expected.txt: Renamed from LayoutTests/platform/win-wk2/editing/selection/transformed-selection-rects-expected.txt.
* platform/win/editing/selection/transformed-selection-rects-expected.txt: Renamed from LayoutTests/platform/chromium-win/editing/selection/transformed-selection-rects-expected.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Sep 2011 01:42:34 +0000 (01:42 +0000)]
Add unit test for existing StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=67080
Patch by Xianzhu Wang <wangxianzhu@chromium.org> on 2011-09-22
Reviewed by Darin Adler.
* TestWebKitAPI/TestWebKitAPI.gypi:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
(operator<<):
(TestWebKitAPI::expectBuilderContent):
(TestWebKitAPI::expectEmpty):
(TestWebKitAPI::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dslomov@google.com [Fri, 23 Sep 2011 01:29:20 +0000 (01:29 +0000)]
Updated expectations and filed WK68674.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Fri, 23 Sep 2011 01:12:38 +0000 (01:12 +0000)]
Remove didReceiveAuthenticationChallenge() from SubresourceLoaderClient.
Instead, add a load-specific policy for showing the user authentication
challenge down to ResourceLoaderOptions and enforce it in ResourceLoader.
https://bugs.webkit.org/show_bug.cgi?id=65330
Reviewed by Alexey Proskuryakov.
No new tests, refactor only.
* loader/DocumentThreadableLoader.cpp:
* loader/DocumentThreadableLoader.h:
* loader/MainResourceLoader.cpp:
* loader/NetscapePlugInStreamLoader.cpp:
* loader/ResourceLoadScheduler.h:
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveAuthenticationChallenge):
For resource types that always send a challenge to the embedder,
this patch doesn't change anything. For those that don't, we will
always try to continue without credentials when they are forbidden
and the platform supports it.
When continuing without credentials was initially implemented in
DocumentThreadableLoader, we sent the ThreadableLoaderClient a didFail(),
then canceled the SubresourceLoader. This was necessary because of the
quirks of ThreadableLoader cancellation (we sever the client/loader connections
before the load actually cancels), but a simple didFail() should suffice at
the ResourceLoader layer.
* loader/ResourceLoaderOptions.h:
* loader/SubresourceLoader.cpp:
* loader/SubresourceLoader.h:
* loader/SubresourceLoaderClient.h:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResourceLoader.cpp:
* loader/cache/CachedResourceLoader.h:
* loader/icon/IconLoader.cpp: The ResourceLoader implementation of
didReceiveAuthenticationChallege means that IconLoader will now
try to continue with credentials on platforms that support it,
rather than just canceling outright. We still will never prompt
for authentication for icons.
* loader/icon/IconLoader.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Sep 2011 00:43:07 +0000 (00:43 +0000)]
[EFL] Use ewk_view to navigate in history instead of ewk_history.
https://bugs.webkit.org/show_bug.cgi?id=68455
Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-22
Reviewed by Antonio Gomes.
BackForwardItem::invoke() was using ewk_history functions to navigate
in history; however, this will only call WebCore::BackForwardListImpl
and not move between pages at all. We now call ewk_view_navigate and
its siblings to make sure the navigation actually happens.
This should make tests like fast/dom/navigation-type-back-forward.html
stop timing out.
* DumpRenderTree/efl/WorkQueueItemEfl.cpp:
(BackForwardItem::invoke):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 23 Sep 2011 00:38:03 +0000 (00:38 +0000)]
Add ENABLE_CSS_FILTERS
https://bugs.webkit.org/show_bug.cgi?id=68652
Reviewed by Simon Fraser.
* Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:
* Source/WebCore/Configurations/FeatureDefines.xcconfig:
* Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:
* Source/WebKit2/Configurations/FeatureDefines.xcconfig:
* WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops:
* WebKitLibraries/win/tools/vsprops/FeatureDefinesCairo.vsprops:
* Tools/Scripts/build-webkit:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 23 Sep 2011 00:02:02 +0000 (00:02 +0000)]
Make sure to update scrollbars in ScrollView::setFrameRect
https://bugs.webkit.org/show_bug.cgi?id=68663
Reviewed by Sam Weinig.
Call updateScrollbars after setting the frame rect. This was previously done by the
call to setBoundsSize from RenderWidget::setWidgetGeometry but setBoundsSize was removed
completely in http://trac.webkit.org/changeset/95725.
* platform/ScrollView.cpp:
(WebCore::ScrollView::setFrameRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 22 Sep 2011 23:57:01 +0000 (23:57 +0000)]
Function.prototype.bind.length shoudl be 1.
Rubber stamped by Olier Hunt.
Source/JavaScriptCore:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
LayoutTests:
* fast/js/function-bind-expected.txt:
* fast/js/script-tests/function-bind.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 22 Sep 2011 23:24:26 +0000 (23:24 +0000)]
PPC build fix.
* bytecode/CodeBlock.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 22 Sep 2011 23:22:02 +0000 (23:22 +0000)]
Windows build fix pt. 2
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 22 Sep 2011 23:05:39 +0000 (23:05 +0000)]
Windows build fix pt. 1
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Sep 2011 22:58:42 +0000 (22:58 +0000)]
[Qt][Mac]Unreviewed gardening.
New Qt specific results were added by r95723, but they fail on Qt-Mac platform
* platform/qt-mac/Skipped: Skip css3/selectors3 tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 22 Sep 2011 22:49:55 +0000 (22:49 +0000)]
Add APIObjects for Size, Point, Rect
https://bugs.webkit.org/show_bug.cgi?id=68644
Reviewed by Sam Weinig.
Make APIObjects for size, point and rect so that they can be
used in WKArrayRefs.
Make some inline helper methods to create WKSize, WKPoint and WKRect
types.
* GNUmakefile.am:
* Shared/API/c/WKBase.h:
* Shared/API/c/WKGeometry.cpp: Copied from Source/WebKit2/Shared/API/c/WKGeometry.h.
(WKSizeGetTypeID):
(WKPointGetTypeID):
(WKRectGetTypeID):
(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):
(WKSizeGetValue):
(WKPointGetValue):
(WKRectGetValue):
* Shared/API/c/WKGeometry.h:
(WKPoint::WKPointMake):
(WKPoint::WKSizeMake):
(WKPoint::WKRectMake):
* Shared/API/c/WKSharedAPICast.h:
* Shared/APIObject.h:
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebGeometry.h: Added.
(WebKit::WebSize::create):
(WebKit::WebSize::size):
(WebKit::WebSize::WebSize):
(WebKit::WebSize::type):
(WebKit::WebPoint::create):
(WebKit::WebPoint::point):
(WebKit::WebPoint::WebPoint):
(WebKit::WebPoint::type):
(WebKit::WebRect::create):
(WebKit::WebRect::rect):
(WebKit::WebRect::WebRect):
(WebKit::WebRect::type):
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebKit2API.pri:
* win/WebKit2.vcproj:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 22 Sep 2011 22:42:54 +0000 (22:42 +0000)]
DFG JIT does not support to_primitive or strcat
https://bugs.webkit.org/show_bug.cgi?id=68582
Reviewed by Darin Adler.
This adds functional support for to_primitive and strcat. It focuses
on minimizing the amount of code emitted on to_primitive (if we know
that it is a primitive or can speculate cheaply, then we omit the
slow path) and on keeping the implementation of strcat simple while
leveraging whatever optimizations we have already. In particular,
unlike the Call and Construct nodes which require extending the size
of the DFG's callee registers, StrCat takes advantage of the fact
that no JS code can run while StrCat is in progress and uses a
scratch buffer, rather than the register file, to store the list of
values to concatenate. This was done mainly to keep the code simple,
but there are probably other benefits to keeping call frame sizes
down. Essentially, this patch ensures that the presence of an
op_strcat does not mess up any other optimizations we might do while
ensuring that if you do execute it, it'll work about as well as you'd
expect.
When combined with the previous patch for integer division, this is a
14% speed-up on Kraken. Without it, it would have been a 2% loss.
* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::TrustedImmPtr::TrustedImmPtr):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::callOperation):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGNode.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):
* runtime/JSGlobalData.h:
(JSC::JSGlobalData::scratchBufferForSize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Thu, 22 Sep 2011 22:35:21 +0000 (22:35 +0000)]
Progress control gets cropped on the bottom
https://bugs.webkit.org/show_bug.cgi?id=68302
<rdar://problem/
10069915>
Reviewed by Kent Tamura.
As it turns out the smaller control type does not get rendered either, so this patch
fixes both.
* manual-tests/dom/progressbar.html: Altered to show both sizes of controls
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm: Added methods to inflate the drawing rect
(WebCore::RenderThemeMac::progressBarSizes):
(WebCore::RenderThemeMac::progressBarMargins):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::paintProgressBar): Inflate the rect based on minimum desired
control height and glow margin.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 22 Sep 2011 22:28:21 +0000 (22:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68658
Make matchedEndLine smart enough to not match lines that have moved to new
regions with different available content logical widths. When this happens, we go ahead and treat
the line as failing to match.
Reviewed by Anders Carlsson.
Source/WebCore:
Added new tests in fast/regions.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
* rendering/RenderBlock.h:
Enhanced to take an optional delta, so that you can check a new position without having to move
the line box.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
New function that refactors checking for line width changes from region movement as well as the
float checks. Since the float checks were duplicated twice, this is a nice refactoring.
(WebCore::RenderBlock::matchedEndLine):
Changed to call the new helper function that will check both floats and pagination.
LayoutTests:
* fast/regions/webkit-flow-inlines-dynamic.html: Added.
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-inlines-dynamic-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Sep 2011 22:13:32 +0000 (22:13 +0000)]
EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
https://bugs.webkit.org/show_bug.cgi?id=68660
Reviewed by Adam Barth.
* WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseUp):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Thu, 22 Sep 2011 22:02:24 +0000 (22:02 +0000)]
DFG JIT should support integer division
https://bugs.webkit.org/show_bug.cgi?id=68597
Reviewed by Darin Adler.
This adds support for ArithDiv speculating integer, and speculating
that the result is integer (i.e. remainder = 0).
This is a 4% win on Kraken and a 1% loss on V8.
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::makeDivSafe):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasArithNodeFlags):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateArithNodeFlags):
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_div):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 22 Sep 2011 21:55:07 +0000 (21:55 +0000)]
Implement put_scoped_var in the DFG jit
https://bugs.webkit.org/show_bug.cgi?id=68653
Reviewed by Gavin Barraclough.
Naive implementation of put_scoped_var. Same story as the
get_scoped_var implementation, although I've hoisted scope
object acquisition into a separate dfg node. Ideally in the
future we would reuse the resolved scope chain object, but
for now we don't.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 22 Sep 2011 21:43:31 +0000 (21:43 +0000)]
Skip test that need new baselines.
* platform/mac/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 22 Sep 2011 21:22:17 +0000 (21:22 +0000)]
Implement Function.prototype.bind
https://bugs.webkit.org/show_bug.cgi?id=26382
Reviewed by Sam Weinig.
Source/JavaScriptCore:
This patch provides a basic functional implementation
for Function.bind. It should (hopefully!) be fully
functionally correct, and the bound functions can be
called to quickly (since they are a subclass of
JSFunction, not InternalFunction), but we'll probably
want to follow up with some optimization work to keep
bound calls in JIT code.
* JavaScriptCore.JSVALUE32_64only.exp:
* JavaScriptCore.JSVALUE64only.exp:
* JavaScriptCore.exp:
* JavaScriptCore.xcodeproj/project.pbxproj:
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* jsc.cpp:
(GlobalObject::addFunction):
* runtime/CommonIdentifiers.h:
* runtime/ConstructData.h:
* runtime/Executable.h:
(JSC::NativeExecutable::NativeExecutable):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
(JSC::functionProtoFuncBind):
* runtime/FunctionPrototype.h:
* runtime/JSBoundFunction.cpp: Added.
(JSC::boundFunctionCall):
(JSC::boundFunctionConstruct):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::hasInstance):
(JSC::JSBoundFunction::getOwnPropertySlot):
(JSC::JSBoundFunction::getOwnPropertyDescriptor):
(JSC::JSBoundFunction::JSBoundFunction):
(JSC::JSBoundFunction::finishCreation):
* runtime/JSBoundFunction.h: Added.
(JSC::JSBoundFunction::targetFunction):
(JSC::JSBoundFunction::boundThis):
(JSC::JSBoundFunction::boundArgs):
(JSC::JSBoundFunction::createStructure):
* runtime/JSFunction.cpp:
(JSC::JSFunction::create):
(JSC::JSFunction::finishCreation):
(JSC::createDescriptorForThrowingProperty):
(JSC::JSFunction::getOwnPropertySlot):
* runtime/JSFunction.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::boundFunctionStructure):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
Source/WebCore:
Test: fast/js/function-bind.html
* bindings/js/JSDOMBinding.cpp:
(WebCore::objectToStringFunctionGetter):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::nonCachingStaticFunctionGetter):
* bindings/js/JSHistoryCustom.cpp:
(WebCore::nonCachingStaticBackFunctionGetter):
(WebCore::nonCachingStaticForwardFunctionGetter):
(WebCore::nonCachingStaticGoFunctionGetter):
* bindings/js/JSLocationCustom.cpp:
(WebCore::nonCachingStaticReplaceFunctionGetter):
(WebCore::nonCachingStaticReloadFunctionGetter):
(WebCore::nonCachingStaticAssignFunctionGetter):
- Function::create no longer requires functionStructure() to be passed.
LayoutTests:
We now pass Function.bind tests.
* fast/js/Object-getOwnPropertyNames-expected.txt:
* fast/js/basic-strict-mode-expected.txt:
* fast/js/function-bind-expected.txt: Added.
* fast/js/function-bind.html: Added.
* fast/js/mozilla/strict/15.3.4.5-expected.txt:
* fast/js/script-tests/function-bind.js: Added.
* ietestcenter/Javascript/15.2.3.3-4-38-expected.txt:
* ietestcenter/Javascript/15.3.4.5-0-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-0-2-expected.txt:
* ietestcenter/Javascript/15.3.4.5-13.b-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-13.b-2-expected.txt:
* ietestcenter/Javascript/15.3.4.5-13.b-3-expected.txt:
* ietestcenter/Javascript/15.3.4.5-13.b-4-expected.txt:
* ietestcenter/Javascript/15.3.4.5-13.b-5-expected.txt:
* ietestcenter/Javascript/15.3.4.5-15-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-15-2-expected.txt:
* ietestcenter/Javascript/15.3.4.5-16-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-2-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-3-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-4-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-5-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-6-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-7-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-8-expected.txt:
* ietestcenter/Javascript/15.3.4.5-2-9-expected.txt:
* ietestcenter/Javascript/15.3.4.5-8-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-8-2-expected.txt:
* ietestcenter/Javascript/15.3.4.5-9-1-expected.txt:
* ietestcenter/Javascript/15.3.4.5-9-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 22 Sep 2011 20:50:41 +0000 (20:50 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68650
Make determineStartPosition smart enough to not skip over clean lines that have moved to a new
region with a different available content logical width. When this happens, we go ahead and treat
the line as dirty.
Reviewed by Sam Weinig.
Source/WebCore:
Covered by existing fast/regions tests.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
Disable region fitting if we detect that the regions all have uniform widths. In this case we know
the content width can't vary, so there's no reason to waste time worrying about it.
(WebCore::RenderBlock::computeLogicalLocationForFloat):
Pull the content width checking code into computeLogicalLocationForFloat, since we've incorporated
region fitting into the fixed offsets now rather than the line functions.
(WebCore::RenderBlock::positionNewFloats):
Changed because more code moved from here into computeLogicalLocationForFloat.
(WebCore::RenderBlock::adjustForRegionFittingIfNeeded):
No changes. Just moved the function above the left offset function.
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
Added. These new functions give the fixed left and right offsets for lines in a particular region.
When no regions are present or when all the regions have a uniform width, they are identical
to the versions of the functions that take no arguments.
(WebCore::RenderBlock::logicalRightOffsetForLine):
Changed to no longer do region fitting, since that's built into logicalRightOffsetForContent now.
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
New function that takes a root line box and compares its cached old content width with the width
available at the line's new location.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
Modified to call the logicalXXXOffsetForContent functions that take a block direction position.
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
Added the new functions that take a position so that they can fit to the correct region.
(WebCore::RenderBlock::availableLogicalWidthForContent):
New helper function that calls right - left (similar to the corresponding line function that includes
floats).
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::determineStartPosition):
Patched to check if a line has moved to a place with a different available content width. If so, the line
is dirtied so that line layout can re-run.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
Sets the paginated line width from the current block logical height.
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):
Fixed paginationStrut to be LayoutUnit instead of int.
(WebCore::RootInlineBox::paginatedLineWidth):
(WebCore::RootInlineBox::setPaginatedLineWidth):
Added paginatedLineWidth getter/setter for caching the content width for a given root line.
LayoutTests:
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png:
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt:
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png:
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Sep 2011 20:37:34 +0000 (20:37 +0000)]
Remove Widget::beforeMouseDown and Widget::afterMouseDown
https://bugs.webkit.org/show_bug.cgi?id=68570
Reviewed by Darin Adler.
These two member functions were originally added to avoid crashes due to removing NSViews while they were
being tracked by AppKit. Since they were added, we've moved away from NSViews for form controls, and the bugs in
AppKit that lead to crashes have been fixed.
This patch was rolled out in r95743 because it broke a bunch of tests. The patch accidentally removed setting back
m_sendingEventToSubview to false.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* platform/Widget.h:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):
* rendering/RenderWidget.cpp:
Change widgetHierarchyUpdateSuspendCount to be an unsigned integer instead of a size_t.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 22 Sep 2011 19:41:00 +0000 (19:41 +0000)]
[WK2] UIProcess should check that WebProcess isn't sending unexpected file: URLs to it
https://bugs.webkit.org/show_bug.cgi?id=68573
Reviewed by Anders Carlsson.
Re-landing with a slightly less aggressive check.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 22 Sep 2011 19:38:17 +0000 (19:38 +0000)]
Platform-specific results for test introduced by r95726
* platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
* platform/mac/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
* platform/qt/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 22 Sep 2011 19:25:54 +0000 (19:25 +0000)]
Unreviewed, rolling out r95335 and r95645.
http://trac.webkit.org/changeset/95335
http://trac.webkit.org/changeset/95645
https://bugs.webkit.org/show_bug.cgi?id=68649
Wrong fix (Requested by rniwa on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-22
Source/WebCore:
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::saveTypingStyleState):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::removeStyleAddedByNode):
* editing/EditingStyle.h:
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):
* editing/markup.h:
LayoutTests:
* editing/deleting/merge-paragraph-from-address-expected.txt: Removed.
* editing/deleting/merge-paragraph-from-address.html: Removed.
* editing/deleting/merge-paragraph-from-h6-expected.txt: Removed.
* editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Removed.
* editing/deleting/merge-paragraph-from-h6-with-style.html: Removed.
* editing/deleting/merge-paragraph-from-h6.html: Removed.
* editing/deleting/merge-paragraph-from-listing-expected.txt: Removed.
* editing/deleting/merge-paragraph-from-listing.html: Removed.
* editing/deleting/merge-paragraph-from-p-with-style-expected.txt: Removed.
* editing/deleting/merge-paragraph-from-p-with-style.html: Removed.
* editing/deleting/merge-paragraph-into-h1-expected.txt: Removed.
* editing/deleting/merge-paragraph-into-h1-style-expected.txt: Removed.
* editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Removed.
* editing/deleting/merge-paragraph-into-h1-with-style.html: Removed.
* editing/deleting/merge-paragraph-into-h1.html: Removed.
* editing/deleting/merge-paragraph-into-pre-expected.txt: Removed.
* editing/deleting/merge-paragraph-into-pre.html: Removed.
* platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
* platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Thu, 22 Sep 2011 19:14:20 +0000 (19:14 +0000)]
Unreviewed, update expected results after r95726
* platform/chromium-win/css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.png:
* platform/chromium-win/css2.1/
20110323/abspos-replaced-width-margin-000-expected.png:
* platform/gtk/css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.txt:
* platform/gtk/css2.1/
20110323/abspos-replaced-width-margin-000-expected.txt:
* platform/qt/css2.1/
20110323/abspos-non-replaced-width-margin-000-expected.txt:
* platform/qt/css2.1/
20110323/abspos-replaced-width-margin-000-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95744
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 22 Sep 2011 18:55:35 +0000 (18:55 +0000)]
Revert r95673 since it caused hundreds of tests to fail on Leopard / Snow Leopard.
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::passMouseDownEventToWidget):
* platform/Widget.h:
* platform/mac/WidgetMac.mm:
(WebCore::Widget::Widget):
(WebCore::Widget::removeFromSuperview):
(WebCore::Widget::beforeMouseDown):
(WebCore::Widget::afterMouseDown):
* rendering/RenderWidget.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 22 Sep 2011 18:51:02 +0000 (18:51 +0000)]
Implement get_scoped_var in the DFG
https://bugs.webkit.org/show_bug.cgi?id=68640
Reviewed by Gavin Barraclough.
Naive implementation of get_scoped_var in the DFG. Essentially this
is the bare minimum required to get correct behaviour, so there's no
load/store coalescing or type profiling involved, even though these
would be wins. No impact on SunSpider or V8.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasVarNumber):
(JSC::DFG::Node::hasScopeChainDepth):
(JSC::DFG::Node::scopeChainDepth):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 22 Sep 2011 18:31:10 +0000 (18:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68645
Fix the layout test fast/regions directory. Remove platform-specific results that were
incorrectly checked in to cross-platform locations and add missing pixel test results.
Reviewed by Beth Dakin.
* fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Removed.
* fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
* fast/regions/flows-dependency-same-flow-expected.txt: Removed.
* fast/regions/render-region-renderer-expected.txt: Removed.
* fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
* fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
* fast/regions/webkit-flow-renderer-expected.txt: Removed.
* fast/regions/webkit-flow-renderer-layer-expected.txt: Removed.
* fast/regions/webkit-flow-renderer-nested-expected.txt: Removed.
* platform/mac/fast/regions/content-flowed-into-regions-dynamically-added-expected.png: Added.
* platform/mac/fast/regions/content-flowed-into-regions-dynamically-inserted-expected.txt: Added.
* platform/mac/fast/regions/content-flowed-into-regions-dynamically-removed-expected.png: Added.
* platform/mac/fast/regions/content-flowed-into-regions-expected.png: Added.
* platform/mac/fast/regions/content-flowed-into-regions-with-dyn-index-expected.png: Added.
* platform/mac/fast/regions/content-flowed-into-regions-with-index-dom-expected.png: Added.
* platform/mac/fast/regions/content-flowed-into-regions-with-index-expected.png: Added.
* platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.png: Added.
* platform/mac/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* platform/mac/fast/regions/flows-dependency-same-flow-expected.png: Added.
* platform/mac/fast/regions/flows-dependency-same-flow-expected.txt: Added.
* platform/mac/fast/regions/no-split-line-box-expected.png: Added.
* platform/mac/fast/regions/render-region-renderer-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Added.
* platform/mac/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-renderer-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-renderer-layer-expected.txt: Added.
* platform/mac/fast/regions/webkit-flow-renderer-nested-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 22 Sep 2011 18:12:20 +0000 (18:12 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68638
Make RenderFlowThread cache whether or not it has regions of varying widths. This will
be relevant for performance as we begin adding code to do custom block painting and
layout based off regions not having the same width.
Reviewed by Dan Bernstein and Adam Roben.
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
* rendering/RenderFlowThread.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Sep 2011 18:01:01 +0000 (18:01 +0000)]
FrameView::invalidateRect and FrameView::setFrameRect shouldn't take LayoutRects
https://bugs.webkit.org/show_bug.cgi?id=68639
Reviewed by David Hyatt.
FrameView::invalidateRect and FrameView::setFrameRect override Widget and ScrollView
member functions that take IntRects, and Widget coordinates are currently defined in terms of
IntRects (and probably always should since we want them to be pixel-aligned).
* page/FrameView.cpp:
(WebCore::FrameView::invalidateRect):
(WebCore::FrameView::setFrameRect):
* page/FrameView.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy_horton@apple.com [Thu, 22 Sep 2011 17:52:44 +0000 (17:52 +0000)]
Unreviewed build fix (fixes warning about too many parens).
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Sep 2011 17:51:19 +0000 (17:51 +0000)]
Widget::frameRect shouldn't be virtual
https://bugs.webkit.org/show_bug.cgi?id=68637
Reviewed by Sam Weinig.
Nobody overrides Widget::frameRect and nobody should.
* platform/Widget.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 22 Sep 2011 17:48:45 +0000 (17:48 +0000)]
Remove FindSafari
It isn't used or built anymore.
Fixes <http://webkit.org/b/68628>
Reviewed by Darin Adler.
* FindSafari: Removed this directory and its contents.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 22 Sep 2011 17:48:18 +0000 (17:48 +0000)]
Remove FindSafari from all our .sln files
It isn't used anymore, so there's no point in building it.
Part of <http://webkit.org/b/68628> Remove FindSafari
Reviewed by Steve Falkenburg.
Source/JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore.sln:
Source/WebKit/win:
* WebKit.vcproj/WebKit.sln: Also relinearized the build order while I was at it.
Tools:
* DumpRenderTree/DumpRenderTree.sln:
* WebKitTestRunner/WebKitTestRunner.sln:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc