Armin Novak [Wed, 12 Feb 2020 10:55:47 +0000 (11:55 +0100)]
Added missing WINPR_*_DIGEST_LENGTH definitions.
Armin Novak [Thu, 5 Mar 2020 10:27:33 +0000 (11:27 +0100)]
Consume all TPKT data reading new/upgrade license
Armin Novak [Thu, 5 Mar 2020 10:18:43 +0000 (11:18 +0100)]
rdp_recv_tpkt_pdu verbose debug parsing issues
Print out parsing issues found in MCS Channel 1003 parsing.
Armin Novak [Thu, 5 Mar 2020 10:16:56 +0000 (11:16 +0100)]
tpkt_ensure_stream_consumed now more verbose.
tpkt_ensure_stream_consumed now writes the function it was called
from to the log. This should help identify areas the check failed.
Martin Fleisz [Thu, 5 Mar 2020 07:26:34 +0000 (08:26 +0100)]
Merge pull request #5944 from akallabeth/fragmented_packet_length_check_fix
Fragmented packet length check fix
Armin Novak [Wed, 4 Mar 2020 13:59:27 +0000 (14:59 +0100)]
Added clarifications in freerdp_channel_process
Armin Novak [Wed, 4 Mar 2020 13:52:19 +0000 (14:52 +0100)]
Fixed arguments for peer->ReceiveChannelData
Armin Novak [Wed, 4 Mar 2020 13:42:42 +0000 (14:42 +0100)]
Fixed conversion and return checks.
* Fix some missing argument checks for function pointer implementations
* Fix broken return value check for client->SendChannelData
* Updated const correctness for function pointer implementations
Armin Novak [Wed, 4 Mar 2020 13:34:28 +0000 (14:34 +0100)]
Fixed function pointer const correctness.
Armin Novak [Wed, 4 Mar 2020 13:26:41 +0000 (14:26 +0100)]
Fixed freerdp_channel_process length checks
Fragmented data was not handled properly.
Armin Novak [Wed, 4 Mar 2020 13:23:17 +0000 (14:23 +0100)]
Added freerdp_channels_data argument checks.
Norbert Federa [Wed, 4 Mar 2020 10:41:01 +0000 (11:41 +0100)]
Merge pull request #5942 from akallabeth/gfx_cache_evict
Fix GFX cache eviction, use 1 based indexing.
Armin Novak [Wed, 4 Mar 2020 10:00:54 +0000 (11:00 +0100)]
Fix GFX cache eviction, use 1 based indexing.
Armin Novak [Thu, 27 Feb 2020 08:02:41 +0000 (09:02 +0100)]
X11 XEvent handling use const arguments
Armin Novak [Thu, 27 Feb 2020 07:51:14 +0000 (08:51 +0100)]
X11 XEvent disp refactored to use const arguments
Armin Novak [Thu, 27 Feb 2020 07:50:04 +0000 (08:50 +0100)]
X11 XEvent refactored input
* Use proper types and const arguments where appropriate
Armin Novak [Thu, 27 Feb 2020 07:42:14 +0000 (08:42 +0100)]
X11 XEvent refactored floatbar
* Use const event pointers of correct type where appropriate
Armin Novak [Thu, 27 Feb 2020 07:28:52 +0000 (08:28 +0100)]
X11 XEvent clipboard processing cleanup
* Use const X*Event where possible
* Helper functions use the actual type as argument
Armin Novak [Thu, 27 Feb 2020 07:27:56 +0000 (08:27 +0100)]
X11: Lock display during event processing
* Added a X11 lock debug messages for incorrect locking.
* Lock X11 display during XEvent processing
Martin Fleisz [Wed, 4 Mar 2020 08:36:49 +0000 (09:36 +0100)]
Merge pull request #5939 from akallabeth/scaling_patch
Reverted minimum scaling diff
Martin Fleisz [Wed, 4 Mar 2020 08:34:51 +0000 (09:34 +0100)]
Merge pull request #5941 from akallabeth/clang_fixes
Fixed clang scanbuild warnings.
Martin Fleisz [Wed, 4 Mar 2020 08:31:52 +0000 (09:31 +0100)]
Merge pull request #5932 from nfedera/fix_gfx_bitmapcache_indexing
Fix RDPEGFX bitmap cache indexing
Armin Novak [Wed, 4 Mar 2020 08:15:31 +0000 (09:15 +0100)]
Fixed clang scanbuild warnings.
David Fort [Wed, 4 Mar 2020 07:45:47 +0000 (08:45 +0100)]
Merge pull request #5940 from akallabeth/pretty_print_signals
Improve signal handler printout.
Armin Novak [Wed, 4 Mar 2020 07:22:31 +0000 (08:22 +0100)]
Improve signal handler printout.
Norbert Federa [Tue, 3 Mar 2020 17:18:00 +0000 (18:18 +0100)]
dynvc/client: fix and improve channel closing code
- fixed and consolitate the duplicated code for sending the
CLOSE_REQUEST_PDU to the server into dvcman_close_channel
- call dvcman_close_channel if a dynamic channel plugin fails
to process the received channel data
- rdpegfx: don't try to remove a non-existing cache entry,
return an error instead which now will close the channel, as
expected by Microsoft's windows protocols test suite
Armin Novak [Wed, 4 Mar 2020 07:00:54 +0000 (08:00 +0100)]
Reverted minimum scaling diff
Revert to the diff value from @volth
Norbert Federa [Tue, 3 Mar 2020 12:26:16 +0000 (13:26 +0100)]
Merge pull request #5935 from akallabeth/shadow_server_mstsc_fix
Fixed shadow server with mstsc as client.
Armin Novak [Tue, 3 Mar 2020 12:10:24 +0000 (13:10 +0100)]
Fixed reading suppress output pdu
Optional rectangle must be read from PDU
Armin Novak [Tue, 3 Mar 2020 12:02:22 +0000 (13:02 +0100)]
Removed function pointer casts for shadow.
Armin Novak [Tue, 3 Mar 2020 11:27:01 +0000 (12:27 +0100)]
Fixed shadow server with mstsc as client.
Norbert Federa [Tue, 3 Mar 2020 10:27:06 +0000 (11:27 +0100)]
Merge pull request #5934 from akallabeth/urbdrc_close_fix
URBDRC: Only mark closed if control is closed.
Armin Novak [Tue, 3 Mar 2020 10:09:27 +0000 (11:09 +0100)]
URBDRC: Only mark closed if control is closed.
David Fort [Tue, 3 Mar 2020 08:18:27 +0000 (09:18 +0100)]
Merge pull request #5933 from akallabeth/autodetect_consume_stream
Consume stream data in autoconnect
Armin Novak [Mon, 2 Mar 2020 12:54:10 +0000 (13:54 +0100)]
Consume stream data in autoconnect
TPKT checks failed due to payload data not consumed in autodetect.
xie.kunming [Sun, 1 Mar 2020 08:48:36 +0000 (16:48 +0800)]
wf_cliprdr.c forget OleUninitialize if create_cliprdr_window failed
Armin Novak [Fri, 21 Feb 2020 08:17:00 +0000 (09:17 +0100)]
Fixed tpkt header length checks.
TPKT header length and consumption of data was not consistently
checked. This adds checks after each packet processed and fixes
any inconsistencies found.
Armin Novak [Thu, 20 Feb 2020 09:38:04 +0000 (10:38 +0100)]
Fixed warnings in capabilities.c
Armin Novak [Thu, 20 Feb 2020 07:40:47 +0000 (08:40 +0100)]
Fixed compiler warnings in info.c
Armin Novak [Thu, 20 Feb 2020 07:22:19 +0000 (08:22 +0100)]
Added tpkt header length plausibility checks.
Armin Novak [Thu, 20 Feb 2020 07:07:35 +0000 (08:07 +0100)]
Added fallbacks for primitives auto detection.
When using primitives auto detection it was possible that no
primitive implementation was chosen at all.
This now skips broken implementations and falls back to generic
primitives if no other implementation does work.
Armin Novak [Wed, 19 Feb 2020 16:00:36 +0000 (17:00 +0100)]
Check length of TPKT header for plausibility.
Armin Novak [Mon, 2 Mar 2020 07:40:40 +0000 (08:40 +0100)]
Implemented del_device by vid/pid
Armin Novak [Fri, 28 Feb 2020 12:45:26 +0000 (13:45 +0100)]
Cleaned up USB redirection
* Removed obsolete searchman
* Unified device add and virtual channel add
* Unified device id generation
Armin Novak [Wed, 26 Feb 2020 11:24:25 +0000 (12:24 +0100)]
Fix #5910: USB hotplug added device wrong
When a USB device was added via hotplug add_device was called
with wrong arguments.
Norbert Federa [Mon, 2 Mar 2020 08:54:35 +0000 (09:54 +0100)]
rdpegfx: rename MaxCacheSlot to MaxCacheSlots
Although Microsoft uses 1-based numbering on the wire for indexing the
GFX bitmap cache entries, the code in FreeRDP uses 0-based numbering and
therefore the name MaxCacheSlots is less confusing.
Norbert Federa [Thu, 27 Feb 2020 15:43:01 +0000 (16:43 +0100)]
rdpegfx: use 1-based indexing for bitmap cache
Weird but Microsoft uses 1-based indexing in the RDPGFX bitmap
cache PDU's.
This does not seem to be documented but can be deducted from the
RDP client test code in Microsoft's "Windows Protocol Test Suites"
GitHub repository and the observation that mstsc aborts with a
protocol error if the cacheSlot index value 0 is used in e.g. a
GFX surface to cache PDU.
David Fort [Mon, 2 Mar 2020 08:09:15 +0000 (09:09 +0100)]
Merge pull request #5931 from akallabeth/rpm_nightly_fix
Disable GSS/KRB5 support
Armin Novak [Mon, 2 Mar 2020 07:43:59 +0000 (08:43 +0100)]
Disable GSS/KRB5 support
Kerberos support in FreeRDP is not working, deactivate it. Fixes #5930
Martin Fleisz [Fri, 28 Feb 2020 10:22:36 +0000 (11:22 +0100)]
Fix possible NULL pointer access crash
Armin Novak [Thu, 27 Feb 2020 15:54:17 +0000 (16:54 +0100)]
Updated CMake channel detection
* Now both, dynamic and static channel entries can be defined by
a single channel.
* Added better logging to distinguish between static and dynamic
channel messages.
Martin Fleisz [Thu, 27 Feb 2020 11:12:20 +0000 (12:12 +0100)]
Add dynamic channel part for rdpsnd channel
Martin Fleisz [Fri, 28 Feb 2020 10:50:40 +0000 (11:50 +0100)]
Merge pull request #5920 from akallabeth/rdpsnd_crash_fix
Fix #5885: Check for division by zero
Martin Fleisz [Fri, 28 Feb 2020 08:55:29 +0000 (09:55 +0100)]
Merge pull request #5922 from akallabeth/channel_drdynvc_fi
Replaced CMake list find with loop to fix build issues.
Mark Karpeles [Thu, 27 Feb 2020 15:21:29 +0000 (00:21 +0900)]
fix FindFFmpeg.cmake: locating avcodec not using pkgconfig variable
Armin Novak [Thu, 27 Feb 2020 09:10:04 +0000 (10:10 +0100)]
Fix #5885: Check for division by zero
Armin Novak [Thu, 27 Feb 2020 10:18:54 +0000 (11:18 +0100)]
Replaced CMake list find with loop to fix build issues.
Bernhard Miklautz [Thu, 27 Feb 2020 09:29:29 +0000 (10:29 +0100)]
Merge pull request #5921 from akallabeth/nightly_optimise
Revert to RelWithDebInfo for debian.
Armin Novak [Thu, 27 Feb 2020 08:39:09 +0000 (09:39 +0100)]
Revert to RelWithDebInfo for debian.
Martin Fleisz [Wed, 26 Feb 2020 15:18:46 +0000 (16:18 +0100)]
Merge pull request #5907 from akallabeth/cmake_channel_dependency_fix
Cmake channel dependency fix
Armin Novak [Wed, 26 Feb 2020 13:35:45 +0000 (14:35 +0100)]
Deactivated URBDRC for mac and windows builds.
Martin Fleisz [Wed, 26 Feb 2020 13:48:41 +0000 (14:48 +0100)]
Merge pull request #5915 from akallabeth/gfx_versions
Updated RDPGFX_CAPVERSION_106 according to errata 2018-12-10
Martin Fleisz [Wed, 26 Feb 2020 13:41:46 +0000 (14:41 +0100)]
Merge pull request #5906 from akallabeth/tsmf_disable_for_good
Made CHANNEL_TSMF optional and deprecated.
Armin Novak [Wed, 26 Feb 2020 13:09:53 +0000 (14:09 +0100)]
Updated RDPGFX_CAPVERSION_106 according to errata 2018-12-10
Norbert Federa [Wed, 26 Feb 2020 11:24:21 +0000 (12:24 +0100)]
egfx: the gfx reset grahics pdu is optional
Since the EGFX Reset Graphics PDU seems to be optional,
the graphicsReset variable (which is updated in that PDU's handler)
should be removed from the rdp_gdi struct with the next change
in public headers (as in freerdp v3).
There are still some clients that expect and check it and therefore
we keep it for now, initialized with TRUE.
sdas
Armin Novak [Tue, 25 Feb 2020 14:21:16 +0000 (15:21 +0100)]
Made CHANNEL_TSMF optional and deprecated.
Armin Novak [Wed, 26 Feb 2020 12:53:25 +0000 (13:53 +0100)]
Deactivate USB redirection for IOS and ANDROID by default.
Ondrej Holy [Wed, 26 Feb 2020 10:12:46 +0000 (11:12 +0100)]
Do not advertise /usb in help output if the channel is not built
The help output advertise an option and an example for usb redirection
regardless of the fact whether the urbdrc channel was built or not.
This is confusing for people. Let's do not show /usb in help if it is
not built.
Kobi Mizrachi [Mon, 3 Feb 2020 08:44:25 +0000 (10:44 +0200)]
server: proxy: client: change ClientFree->ContextFree
Kobi Mizrachi [Sun, 2 Feb 2020 13:15:28 +0000 (15:15 +0200)]
server: proxy: support static vc passthrough
Kobi Mizrachi [Sun, 2 Feb 2020 13:01:38 +0000 (15:01 +0200)]
core: channels: add API to get channel name/id
Armin Novak [Tue, 25 Feb 2020 16:36:26 +0000 (17:36 +0100)]
drdynvc: reorder filepaths when adding channels
Armin Novak [Tue, 25 Feb 2020 15:38:31 +0000 (16:38 +0100)]
Promoted usb, printer and smartcard dependencies to recommended
Armin Novak [Tue, 25 Feb 2020 15:17:47 +0000 (16:17 +0100)]
Fixed CMake channel dependencies for variables.
Martin Fleisz [Tue, 25 Feb 2020 14:56:07 +0000 (15:56 +0100)]
Merge pull request #5905 from akallabeth/pulse_audin_fix
audin pulse log states by name
Armin Novak [Tue, 25 Feb 2020 10:29:09 +0000 (11:29 +0100)]
audin pulse log states by name
Martin Fleisz [Tue, 25 Feb 2020 13:50:51 +0000 (14:50 +0100)]
Merge pull request #5707 from akallabeth/kbd_codepage
Added KeyboardCodePage option
Armin Novak [Mon, 24 Feb 2020 11:28:11 +0000 (12:28 +0100)]
Updated RDP_KEYBOARD_LAYOUT_TABLE
Regenerated with new fetch_language_identifiers.py, less manual
postprocessing required.
Armin Novak [Mon, 24 Feb 2020 11:12:26 +0000 (12:12 +0100)]
Fixed keyboard lang struct generation
* Fixed length hex strings
* Fill in missing elements with last valid
Armin Novak [Fri, 8 Nov 2019 14:42:05 +0000 (15:42 +0100)]
Added keyboard language codepages and listing option
Martin Fleisz [Fri, 21 Feb 2020 10:36:49 +0000 (11:36 +0100)]
Merge pull request #5732 from akallabeth/floatbar_button_fix
Fixed #5730: Decoupled floatbar button focus from click events.
Martin Fleisz [Fri, 21 Feb 2020 08:05:47 +0000 (09:05 +0100)]
Merge pull request #5901 from nfedera/add_connstate_active_timeout
core: fix endless loops waiting for activation
Norbert Federa [Thu, 20 Feb 2020 16:26:27 +0000 (17:26 +0100)]
core: fix endless loops waiting for activation
There are two loops polling the transport pdu receiver in non-blocking mode
when waiting for reaching CONNECTION_STATE_ACTIVE rdp state.
In case of an invalid pdu size in the tpkt header this leaded to an endless
loop, utilizing 100% of a cpu core.
Added a sleep and limited the max loop time to the tcp ack timout value.
Martin Fleisz [Thu, 20 Feb 2020 07:32:50 +0000 (08:32 +0100)]
Merge pull request #5899 from akallabeth/respect_abort_connect
End connection before user callbacks if aborted.
Armin Novak [Wed, 19 Feb 2020 15:44:42 +0000 (16:44 +0100)]
End connection before user callbacks if aborted.
If somewhere in freerdp_connect freerdp_abort_connect was called
the user callbacks Authenticate, GatewayAuthenticate and
Verify[Changed|X509]Certificate[Ex] must not be called.
Martin Fleisz [Wed, 19 Feb 2020 15:03:54 +0000 (16:03 +0100)]
Merge pull request #5898 from akallabeth/timezone_update_20200219
Updated timezones 2020-02-19
Armin Novak [Wed, 19 Feb 2020 14:24:16 +0000 (15:24 +0100)]
Updated timezones 2020-02-19
Martin Fleisz [Wed, 19 Feb 2020 09:54:02 +0000 (10:54 +0100)]
Merge pull request #5896 from akallabeth/cast_warning_fixes
Fixed #5895: cast warnings.
Martin Fleisz [Wed, 19 Feb 2020 09:50:41 +0000 (10:50 +0100)]
Merge pull request #5897 from akallabeth/flatpak_update
Updated flatpak build manifest
Armin Novak [Wed, 19 Feb 2020 09:28:46 +0000 (10:28 +0100)]
Updated flatpak build manifest
* Use platform 19.08
* Remove shared-modules, no longer required (udev is now part of the
platform)
* Switch PCSC source to github to avoid rate limitations.
Armin Novak [Wed, 19 Feb 2020 09:09:32 +0000 (10:09 +0100)]
Fixed #5895: cast warnings.
Armin Novak [Tue, 18 Feb 2020 10:54:28 +0000 (11:54 +0100)]
Fixed #5889: Only add descriptors wanted to select
Sergey Bronnikov [Tue, 18 Feb 2020 11:52:42 +0000 (14:52 +0300)]
Fix markup
Martin Fleisz [Tue, 18 Feb 2020 10:14:58 +0000 (11:14 +0100)]
Merge pull request #5890 from akallabeth/sample_client_install
Install sample client binary.
Armin Novak [Tue, 3 Dec 2019 13:51:13 +0000 (14:51 +0100)]
Fix channel linking for built in channels
Armin Novak [Tue, 3 Dec 2019 13:50:07 +0000 (14:50 +0100)]
Added some callbacks to dynamic channel
* Allow listener removal of channel during runtime
* Allow retrieval of channel name
Armin Novak [Mon, 16 Dec 2019 07:34:42 +0000 (08:34 +0100)]
working progressive Original Method DWT
Implemented decoding utilizing Original Method DWT
(See [MS-RDPEGFX] 3.2.8.1.2.2 Reduce-Extrapolate Method)
Armin Novak [Tue, 10 Dec 2019 15:19:20 +0000 (16:19 +0100)]
Refactored progressive codec.
Armin Novak [Tue, 18 Feb 2020 10:02:43 +0000 (11:02 +0100)]
Install sample client binary.
Sergey Bronnikov [Mon, 17 Feb 2020 11:22:56 +0000 (14:22 +0300)]
client: remove unused variable