platform/upstream/mesa.git
2 years agodocs/panfrost: Add web chat link
Alyssa Rosenzweig [Tue, 21 Sep 2021 18:50:39 +0000 (14:50 -0400)]
docs/panfrost: Add web chat link

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Suggested-by: Git Lab <gh6h56j85ihg@protonmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12380>

2 years agodocs/panfrost: We're conformant now!
Alyssa Rosenzweig [Tue, 21 Sep 2021 18:45:35 +0000 (14:45 -0400)]
docs/panfrost: We're conformant now!

See https://www.khronos.org/conformance/adopters/conformant-products/opengles#submission_949

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12965>

2 years agointel/fs: Handle required subgroup sizes specified in the SPIR-V
Jason Ekstrand [Mon, 14 Sep 2020 18:44:42 +0000 (13:44 -0500)]
intel/fs: Handle required subgroup sizes specified in the SPIR-V

Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12959>

2 years agospirv: Handle the SubgroupSize execution mode
Jason Ekstrand [Mon, 14 Sep 2020 18:39:47 +0000 (13:39 -0500)]
spirv: Handle the SubgroupSize execution mode

Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12959>

2 years agosvga: fix render target views leak
Charmaine Lee [Mon, 20 Sep 2021 21:48:33 +0000 (14:48 -0700)]
svga: fix render target views leak

Use create_backed_surface_view helper function to create/reuse
alternate surface view when the to-be-bound surface view was created
in a different context. This fixes render target views leak running gazebo.

Cc: mesa-stable
Reviewed-by: Neha Bhende <bhenden@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12952>

2 years agodocs: update calendar and link releases notes for 21.2.2
Dylan Baker [Tue, 21 Sep 2021 17:23:35 +0000 (10:23 -0700)]
docs: update calendar and link releases notes for 21.2.2

I've also adjusted the calender to account for missed releases

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12963>

2 years agodocs/relnotes/21.2.2: Add SHA256 sum
Dylan Baker [Tue, 21 Sep 2021 17:14:30 +0000 (10:14 -0700)]
docs/relnotes/21.2.2: Add SHA256 sum

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12963>

2 years agodocs: add release notes for 21.2.2
Dylan Baker [Tue, 21 Sep 2021 16:52:15 +0000 (09:52 -0700)]
docs: add release notes for 21.2.2

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12963>

2 years agofreedreno/a5xx+: Set the IJ_LINEAR_* request bits if we need the regs.
Emma Anholt [Mon, 20 Sep 2021 21:55:56 +0000 (14:55 -0700)]
freedreno/a5xx+: Set the IJ_LINEAR_* request bits if we need the regs.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12949>

2 years agofreedreno/a5xx+: Rename GRAS_CNTL/RB_RENDER_CONTROL0 IJ_LINEAR_* bits.
Emma Anholt [Mon, 20 Sep 2021 21:48:15 +0000 (14:48 -0700)]
freedreno/a5xx+: Rename GRAS_CNTL/RB_RENDER_CONTROL0 IJ_LINEAR_* bits.

This is what they actually enable.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12949>

2 years agopanvk: Implement vkCmdUpdateBuffer()
Boris Brezillon [Fri, 10 Sep 2021 09:38:00 +0000 (11:38 +0200)]
panvk: Implement vkCmdUpdateBuffer()

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Implement vkCmdFillBuffer()
Boris Brezillon [Fri, 10 Sep 2021 09:37:33 +0000 (11:37 +0200)]
panvk: Implement vkCmdFillBuffer()

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Implement vkCmdCopyBuffer()
Boris Brezillon [Wed, 8 Sep 2021 08:17:03 +0000 (10:17 +0200)]
panvk: Implement vkCmdCopyBuffer()

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Implement vkCmdCopyImageToBuffer()
Boris Brezillon [Wed, 8 Sep 2021 08:14:21 +0000 (10:14 +0200)]
panvk: Implement vkCmdCopyImageToBuffer()

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Implement vkCmdCopyBufferToImage()
Boris Brezillon [Wed, 8 Sep 2021 08:12:32 +0000 (10:12 +0200)]
panvk: Implement vkCmdCopyBufferToImage()

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Implement vkCmdCopyImage()
Boris Brezillon [Wed, 8 Sep 2021 08:02:11 +0000 (10:02 +0200)]
panvk: Implement vkCmdCopyImage()

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Implement vkCmdClear{DepthStencil,Color}Image()
Boris Brezillon [Tue, 7 Sep 2021 16:24:11 +0000 (18:24 +0200)]
panvk: Implement vkCmdClear{DepthStencil,Color}Image()

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Issue a fragment job if at least one target is cleared
Boris Brezillon [Thu, 9 Sep 2021 16:12:19 +0000 (18:12 +0200)]
panvk: Issue a fragment job if at least one target is cleared

This way clear meta helpers don't have to allocate fragment job
themselves.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Stop dereferencing the subpass in panvk_cmd_close_batch()
Boris Brezillon [Thu, 9 Sep 2021 13:04:56 +0000 (15:04 +0200)]
panvk: Stop dereferencing the subpass in panvk_cmd_close_batch()

So we can call this function from the meta helpers which won't bind
a subpass to the cmd state.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Add a panvk_cmd_prepare_tiler_context() helper
Boris Brezillon [Tue, 7 Sep 2021 17:19:43 +0000 (19:19 +0200)]
panvk: Add a panvk_cmd_prepare_tiler_context() helper

So we can create tiler contexts from meta helpers.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Make panvk_cmd_alloc_tls_desc() more generic
Boris Brezillon [Tue, 7 Sep 2021 17:18:24 +0000 (19:18 +0200)]
panvk: Make panvk_cmd_alloc_tls_desc() more generic

panvk_cmd_alloc_tls_desc() will soon be called from meta helpers which
don't bind a pipeline to the cmdbuf state. Let's pass the gfx/compute
info directly.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Don't check the bind_point in panvk_cmd_prepare_fragment_job()
Boris Brezillon [Tue, 7 Sep 2021 17:15:41 +0000 (19:15 +0200)]
panvk: Don't check the bind_point in panvk_cmd_prepare_fragment_job()

We are about to call panvk_cmd_close_batch() from meta helpers, and
those don't bind a pipeline, so let's drop the check in
panvk_cmd_prepare_fragment_job().

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Don't use the subpass to calculate the FB descriptor size
Boris Brezillon [Tue, 7 Sep 2021 16:22:44 +0000 (18:22 +0200)]
panvk: Don't use the subpass to calculate the FB descriptor size

This way we will be able to re-use panvk_cmd_alloc_fb_desc() for
meta stuff.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Get rid of panvk_emit_fragment_job()
Boris Brezillon [Tue, 7 Sep 2021 15:41:47 +0000 (17:41 +0200)]
panvk: Get rid of panvk_emit_fragment_job()

Now that we have a valid pan_fb_info attached to the state, we can
use pan_emit_fragment_job() directly.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Move blit/resolve stubs to a separate file
Boris Brezillon [Wed, 8 Sep 2021 07:37:50 +0000 (09:37 +0200)]
panvk: Move blit/resolve stubs to a separate file

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Move copy stubs to a separate file
Boris Brezillon [Wed, 8 Sep 2021 07:34:20 +0000 (09:34 +0200)]
panvk: Move copy stubs to a separate file

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Move CmdClear* impl to a separate file
Tomeu Vizoso [Wed, 28 Jul 2021 07:08:39 +0000 (09:08 +0200)]
panvk: Move CmdClear* impl to a separate file

In preparation for adding implementations of more meta commands, add
panvk_meta_clear.c.

Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Merge identical BO entries before submitting a job
Boris Brezillon [Fri, 3 Sep 2021 13:26:53 +0000 (15:26 +0200)]
panvk: Merge identical BO entries before submitting a job

This should ideally be filtered when BOs are attached to a batch, but
let's do it in the submit path until then.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Preload FB attachments when required
Boris Brezillon [Mon, 6 Sep 2021 14:06:49 +0000 (16:06 +0200)]
panvk: Preload FB attachments when required

There are at least three situations where we need to preload FBs:

1. The attachment is flagged VK_ATTACHMENT_LOAD_OP_LOAD and has not been
   accessed in previous subpasses

2. The batch is implicitly split (e.g. too many jobs queued to the
   batch, wait/set events queued, ...)

3. The attachment has been written by a previous subpass

With those changes, we can get rid of panvk_emit_fb() and call
pan_emit_fbd() directly (fb_info is initialized when starting a subpass
and updated when an implicit split happens).

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopanvk: Initialize the blend shader logic
Boris Brezillon [Wed, 8 Sep 2021 07:54:58 +0000 (09:54 +0200)]
panvk: Initialize the blend shader logic

The blitter logic rely on blend shaders when formats are not blendable.
We need to initialize the blend shader logic before we can use the
blitter.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopan/blit: Extend pan_preload_fb() to return emitted jobs
Boris Brezillon [Wed, 2 Jun 2021 08:07:40 +0000 (10:07 +0200)]
pan/blit: Extend pan_preload_fb() to return emitted jobs

The vulkan driver needs to patch job headers when re-issuing batches.
Extend pan_preload_fb() so it can return the emitted tiler jobs.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Acked-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopan/blit: Fix a NULL dereference in the preload path
Boris Brezillon [Wed, 19 May 2021 08:56:49 +0000 (10:56 +0200)]
pan/blit: Fix a NULL dereference in the preload path

The ZS view can be NULL if a stencil-only buffer is attached to the FB.

Fixes: 1de393fec539 ("panfrost: Fix ZS reloading on Bifrost v6")
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopan/bi: Allow passing RT conversion descriptors to fragment shaders
Boris Brezillon [Wed, 2 Jun 2021 08:23:06 +0000 (10:23 +0200)]
pan/bi: Allow passing RT conversion descriptors to fragment shaders

The Vulkan copy shaders sometimes need to partially write a texel and
issue a load on the FRAGOUT variable in that case, but they do know
the format of the tile buffer in advance in that case. Let's not add an
RT_CONVERSION sysval if we can avoid it.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Acked-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agopan/bi: Relax check on 8bit swizzles
Boris Brezillon [Wed, 2 Jun 2021 08:17:55 +0000 (10:17 +0200)]
pan/bi: Relax check on 8bit swizzles

Allow extracting components Y, Z or W from an 8bit vector.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@collabora.com>
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12095>

2 years agoradv: do not store meta shaders to the default shader disk cache
Samuel Pitoiset [Mon, 20 Sep 2021 15:09:41 +0000 (17:09 +0200)]
radv: do not store meta shaders to the default shader disk cache

Meta shaders are already stored in a different shader cache file.
Storing them in two places wastes disk space and they are never
loaded from the default shader disk cache anyways.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12937>

2 years agowgl: fix 32 bits mingw exports
Michel Zou [Mon, 20 Sep 2021 16:52:38 +0000 (18:52 +0200)]
wgl: fix 32 bits mingw exports

closes #5349

Reviewed-by: Jesse Natalie <jenatali@microsoft.com>
Reviewed-by: Jose Fonseca <jfonseca@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12940>

2 years agoradv: do not use a different disk cache key for LLVM
Samuel Pitoiset [Mon, 20 Sep 2021 15:33:52 +0000 (17:33 +0200)]
radv: do not use a different disk cache key for LLVM

The driver already adds a pipeline hash for LLVM which is redundant.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12938>

2 years agoRevert "intel/dev: Add display_ver and set adl-p to 13"
Jordan Justen [Tue, 21 Sep 2021 10:39:31 +0000 (03:39 -0700)]
Revert "intel/dev: Add display_ver and set adl-p to 13"

This reverts commit c81acd365ed2a965741a828504d4a1498eaa3d3a.

2 years agoRevert "iris: Disable I915_FORMAT_MOD_Y_TILED_GEN12* on adl-p/display 13"
Jordan Justen [Tue, 21 Sep 2021 10:39:27 +0000 (03:39 -0700)]
Revert "iris: Disable I915_FORMAT_MOD_Y_TILED_GEN12* on adl-p/display 13"

This reverts commit 4961f4c50fe29e4b3e6145bfafae7e5026027d12.

2 years agoiris: Disable I915_FORMAT_MOD_Y_TILED_GEN12* on adl-p/display 13
Jordan Justen [Thu, 16 Sep 2021 22:40:21 +0000 (15:40 -0700)]
iris: Disable I915_FORMAT_MOD_Y_TILED_GEN12* on adl-p/display 13

Cc: mesa-stable
Fixes: e435511b580 ("intel/dev: Add device info for ADL GT2")
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12908>

2 years agointel/dev: Add display_ver and set adl-p to 13
Jordan Justen [Thu, 16 Sep 2021 22:39:11 +0000 (15:39 -0700)]
intel/dev: Add display_ver and set adl-p to 13

Cc: mesa-stable
Fixes: e435511b580 ("intel/dev: Add device info for ADL GT2")
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12908>

2 years agofreedreno, turnip: Set TPL1_DBG_ECO_CNTL better
Connor Abbott [Mon, 20 Sep 2021 12:16:55 +0000 (14:16 +0200)]
freedreno, turnip: Set TPL1_DBG_ECO_CNTL better

Match the blob better here. Note that the value of 0x1000000 for a650
comes from the Vulkan blob, and it's required to fix cubic filtering
even though the GLES driver doesn't set it (and doesn't support cubic
filtering).

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5261
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12929>

2 years agofreedreno/a6xx: Name TPL1_DBG_ECO_CNTL
Connor Abbott [Mon, 20 Sep 2021 11:53:14 +0000 (13:53 +0200)]
freedreno/a6xx: Name TPL1_DBG_ECO_CNTL

This is a guess, but an informed guess, since every other block with a
known DBG_ECO_CNTL register has it at the very beginning immediately
followed by ADDR_MODE_CNTL.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12929>

2 years agolima: Remove depth near/far workaround
Andreas Baierl [Mon, 20 Sep 2021 15:07:00 +0000 (17:07 +0200)]
lima: Remove depth near/far workaround

because this is fixed now.

Reviewed-by: Erico Nunes <nunes.erico@gmail.com>
Signed-off-by: Andreas Baierl <ichgeh@imkreisrum.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12804>

2 years agolima: Expose GL_EXT_clip_control
Andreas Baierl [Fri, 10 Sep 2021 12:33:55 +0000 (14:33 +0200)]
lima: Expose GL_EXT_clip_control

Reviewed-by: Erico Nunes <nunes.erico@gmail.com>
Signed-off-by: Andreas Baierl <ichgeh@imkreisrum.de>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12804>

2 years agoradeonsi/test: use -t for deqp tests
Pierre-Eric Pelloux-Prayer [Mon, 20 Sep 2021 14:58:30 +0000 (16:58 +0200)]
radeonsi/test: use -t for deqp tests

deqp-runner added support for this.

Acked-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12899>

2 years agoradeonsi/test: don't require a folder name
Pierre-Eric Pelloux-Prayer [Mon, 20 Sep 2021 14:58:02 +0000 (16:58 +0200)]
radeonsi/test: don't require a folder name

Generate a temp one if the user didn't supply one.

Acked-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12899>

2 years agoradeonsi/sqtt: add si_se_is_disabled
Pierre-Eric Pelloux-Prayer [Thu, 16 Sep 2021 15:04:12 +0000 (17:04 +0200)]
radeonsi/sqtt: add si_se_is_disabled

Based on radv_se_is_disabled.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12899>

2 years agoradeonsi/sqtt: export wave size and scratch size
Pierre-Eric Pelloux-Prayer [Thu, 16 Sep 2021 14:39:16 +0000 (16:39 +0200)]
radeonsi/sqtt: export wave size and scratch size

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12899>

2 years agoradeonsi/test: update expected results
Pierre-Eric Pelloux-Prayer [Thu, 16 Sep 2021 14:38:49 +0000 (16:38 +0200)]
radeonsi/test: update expected results

These tests were fixed in piglit.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12899>

2 years agoradeonsi/test: fix typo in the test script
Pierre-Eric Pelloux-Prayer [Thu, 16 Sep 2021 14:38:17 +0000 (16:38 +0200)]
radeonsi/test: fix typo in the test script

glcts results were copied over deqp results.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12899>

2 years agoradv: remove useless assertions in the SQTT path
Samuel Pitoiset [Wed, 3 Mar 2021 08:35:18 +0000 (09:35 +0100)]
radv: remove useless assertions in the SQTT path

The driver aborts when the chip class is older than GFX8.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12854>

2 years agoradv: make the SQTT BO a resident buffer
Samuel Pitoiset [Wed, 3 Mar 2021 08:32:55 +0000 (09:32 +0100)]
radv: make the SQTT BO a resident buffer

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12854>

2 years agoradv: replicate THREAD_TRACE_CTRL config when stopping SQTT
Samuel Pitoiset [Tue, 2 Mar 2021 15:13:17 +0000 (16:13 +0100)]
radv: replicate THREAD_TRACE_CTRL config when stopping SQTT

This seems missed and it might be important.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12854>

2 years agoradv: Experimentally enable RT extensions.
Bas Nieuwenhuizen [Sat, 13 Mar 2021 23:44:06 +0000 (00:44 +0100)]
radv: Experimentally enable RT extensions.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add caching for RT pipelines.
Bas Nieuwenhuizen [Fri, 27 Aug 2021 02:20:59 +0000 (04:20 +0200)]
radv: Add caching for RT pipelines.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add support for setting a dynamic stack size.
Bas Nieuwenhuizen [Mon, 23 Aug 2021 23:40:09 +0000 (01:40 +0200)]
radv: Add support for setting a dynamic stack size.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Combine all the parts together with a main loop for an RT pipeline.
Bas Nieuwenhuizen [Fri, 27 Aug 2021 00:19:45 +0000 (02:19 +0200)]
radv: Combine all the parts together with a main loop for an RT pipeline.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add ray traversal loop.
Bas Nieuwenhuizen [Fri, 27 Aug 2021 00:17:19 +0000 (02:17 +0200)]
radv: Add ray traversal loop.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add pass to lower anyhit shader into an intersection shader.
Bas Nieuwenhuizen [Fri, 27 Aug 2021 00:09:51 +0000 (02:09 +0200)]
radv: Add pass to lower anyhit shader into an intersection shader.

So we avoid having yet another shader calling loop. Such a thing
is not needed since neither shader types do recursion.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add helper to parse raytracing stages.
Bas Nieuwenhuizen [Fri, 27 Aug 2021 00:09:08 +0000 (02:09 +0200)]
radv: Add helper to parse raytracing stages.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add helper to inline shaders into the main shader.
Bas Nieuwenhuizen [Fri, 27 Aug 2021 00:07:57 +0000 (02:07 +0200)]
radv: Add helper to inline shaders into the main shader.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add main loop variables.
Bas Nieuwenhuizen [Wed, 25 Aug 2021 00:11:49 +0000 (02:11 +0200)]
radv: Add main loop variables.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add scaffolding for RT pipeline compilation incl libraries.
Bas Nieuwenhuizen [Tue, 24 Aug 2021 00:36:21 +0000 (02:36 +0200)]
radv: Add scaffolding for RT pipeline compilation incl libraries.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Make some pipeline functions non-static.
Bas Nieuwenhuizen [Tue, 24 Aug 2021 00:00:00 +0000 (02:00 +0200)]
radv: Make some pipeline functions non-static.

Want to put the rt stuff in its own file. radv_pipeline.c is pretty
large already.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add raytracing pipeline properties.
Bas Nieuwenhuizen [Mon, 22 Mar 2021 02:52:13 +0000 (03:52 +0100)]
radv: Add raytracing pipeline properties.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add group info to pipeline.
Bas Nieuwenhuizen [Sun, 15 Aug 2021 22:04:30 +0000 (00:04 +0200)]
radv: Add group info to pipeline.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add pipeline type.
Bas Nieuwenhuizen [Sat, 31 Jul 2021 21:42:32 +0000 (23:42 +0200)]
radv: Add pipeline type.

I want to keep pointers that need to be freed in the union and need
to figure out the type a destruction time. This seems more reliable
than checking the shader array in case we destroy mid-creation (i.e.
on failure).

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add RT cache flushes.
Bas Nieuwenhuizen [Sat, 15 May 2021 20:27:39 +0000 (22:27 +0200)]
radv: Add RT cache flushes.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Support nir_intrinsic_load_global_constant.
Bas Nieuwenhuizen [Sat, 24 Jul 2021 10:12:11 +0000 (12:12 +0200)]
radv: Support nir_intrinsic_load_global_constant.

SPIR-V parsing can result in some direct constant usage for shader
records. Lower this early to a global based intrinsic so that it
doesn't interfere with the later 32-bit offset based constants
for scratch usage.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agonir: Support ray launch size in divergence analysis.
Bas Nieuwenhuizen [Sun, 11 Apr 2021 13:45:27 +0000 (15:45 +0200)]
nir: Support ray launch size in divergence analysis.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoaco: Add support for ray launch size.
Bas Nieuwenhuizen [Sat, 10 Apr 2021 23:06:11 +0000 (01:06 +0200)]
aco: Add support for ray launch size.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add support for ray launch size.
Bas Nieuwenhuizen [Sat, 10 Apr 2021 23:04:42 +0000 (01:04 +0200)]
radv: Add support for ray launch size.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agonir: Add AMD rt intrinsics.
Bas Nieuwenhuizen [Wed, 31 Mar 2021 00:53:33 +0000 (02:53 +0200)]
nir: Add AMD rt intrinsics.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Implement NULL accel struct descriptor write.
Bas Nieuwenhuizen [Mon, 26 Jul 2021 10:06:05 +0000 (12:06 +0200)]
radv: Implement NULL accel struct descriptor write.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Do more meta shader lowering.
Bas Nieuwenhuizen [Sun, 11 Apr 2021 14:01:40 +0000 (16:01 +0200)]
radv: Do more meta shader lowering.

Need this to clean up our generated RT pipeline.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Refactor some nir_channels usage to use nir_channel.
Bas Nieuwenhuizen [Mon, 26 Jul 2021 09:01:38 +0000 (11:01 +0200)]
radv: Refactor some nir_channels usage to use nir_channel.

cleanup, nir_channels wasn't needed as these were only accessing a
single channel.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoaco: Implement call scope.
Bas Nieuwenhuizen [Mon, 26 Jul 2021 10:05:38 +0000 (12:05 +0200)]
aco: Implement call scope.

Since we do no repacking yet, just use invocation.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Modify load_sbt_amd intrinsic to get the descriptor.
Bas Nieuwenhuizen [Mon, 19 Jul 2021 23:21:11 +0000 (01:21 +0200)]
radv: Modify load_sbt_amd intrinsic to get the descriptor.

That way we can get the address to the entry, which is needed for
some nir builtins because extra data in the entry can be used as
shader input.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add bvh node definitions to a header.
Bas Nieuwenhuizen [Wed, 11 Aug 2021 00:24:01 +0000 (02:24 +0200)]
radv: Add bvh node definitions to a header.

So that we can avoid some magic numbers in the pipeline creation.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add optimized CPU BVH builds.
Bas Nieuwenhuizen [Sun, 1 Aug 2021 12:47:20 +0000 (14:47 +0200)]
radv: Add optimized CPU BVH builds.

This trivial sorting helps speed up bad cases (like in CTS significantly).

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add more acceleration structure formats.
Bas Nieuwenhuizen [Sat, 31 Jul 2021 01:43:52 +0000 (03:43 +0200)]
radv: Add more acceleration structure formats.

These are required ...

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Add accel struct build support for the object-to-world matrix.
Bas Nieuwenhuizen [Wed, 28 Jul 2021 01:04:18 +0000 (03:04 +0200)]
radv: Add accel struct build support for the object-to-world matrix.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Fix arrayOfPointers for instances in accel struct build.
Bas Nieuwenhuizen [Sat, 24 Jul 2021 12:07:17 +0000 (14:07 +0200)]
radv: Fix arrayOfPointers for instances in accel struct build.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agoradv: Fix CPU AABB build.
Bas Nieuwenhuizen [Thu, 24 Jun 2021 23:23:12 +0000 (01:23 +0200)]
radv: Fix CPU AABB build.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12592>

2 years agomeson: introduce option vmware-mks-stats controlling the instrumentations of gallium...
Martin Krastev [Tue, 30 Mar 2021 15:56:47 +0000 (18:56 +0300)]
meson: introduce option vmware-mks-stats controlling the instrumentations of gallium svga driver

The new boolean option controls the instrumentations of gallium svga driver for mksGuestStats.

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Reviewed-by: Zack Rusin <zackr@vmware.com>
Reviewed-by: Brian Paul <brianp@vmware.com>
Reviewed-by: Charmaine Lee <charmainel@vmware.com>
(cherry picked from commit 57760b7fe4eeb80acc8d6cd8bf6ec609a11a11dc)
(cherry picked from commit 12aed00f08bd95afd605cab34c833e81a4957dbd)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12873>

2 years agosvga: enable DRM mks-stats via hooking to the corresponding DRM ioctls
Martin Krastev [Sun, 31 Jan 2021 13:34:36 +0000 (15:34 +0200)]
svga: enable DRM mks-stats via hooking to the corresponding DRM ioctls

SVGA DRM stat calls were situated but did not actually register with the mks-stats
mechanism due to absence of corresponding ioctls. The employed new ioctls in vmwgfx
are DRM_VMW_MKSSTAT_ADD and DRM_VMW_MKSSTAT_REMOVE, subject to version check.

Reviewed-by: Charmaine Lee <charmainel@vmware.com>
(cherry picked from commit be47c077cc927c27a8c36342b47697aa81719677)
(cherry picked from commit 0388afc67b830f6ab916d0839c33eb1d91d6353f)

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12873>

2 years agobuild: fix nine compilation with only zink enabled as a gallium driver
Mike Blumenkrantz [Mon, 20 Sep 2021 18:59:38 +0000 (14:59 -0400)]
build: fix nine compilation with only zink enabled as a gallium driver

fixes #5360

Reviewed-by: Dylan Baker <dylan@pnwbakers.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12943>

2 years agozink: fix regex syntax from previous ci commit
Mike Blumenkrantz [Mon, 20 Sep 2021 22:31:31 +0000 (18:31 -0400)]
zink: fix regex syntax from previous ci commit

argh

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12948>

2 years agozink: disable miplevel tests in ci completely for now
Mike Blumenkrantz [Mon, 20 Sep 2021 22:00:49 +0000 (18:00 -0400)]
zink: disable miplevel tests in ci completely for now

I still can't repro, and I'm running these regularly on multiple platforms,
so they're not going to get any worse for the time being

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12947>

2 years agoetnaviv: add mov for direct depth store output from load input
Philipp Zabel [Wed, 15 Sep 2021 16:19:02 +0000 (18:19 +0200)]
etnaviv: add mov for direct depth store output from load input

If the fragment shader writes fragment depth from an ALU instruction,
the register allocator makes sure that the instruction is pointed to the
correct register and write mask (t0.__z_).
If there is no instruction emitted because the source is an input
load intrinsic, or if the source instruction does not support swizzle
and write mask, we have to add a mov instruction for this to work.

Fixes piglit test spec@glsl-1.10@execution@glsl-1.10-fragdepth.

Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12891>

2 years agonir_to_tgsi: Remove the abs on fcsel's bool src.
Emma Anholt [Sat, 18 Sep 2021 02:50:12 +0000 (19:50 -0700)]
nir_to_tgsi: Remove the abs on fcsel's bool src.

While the nir fcsel opcode specifies src0 != 0.0, as the comment says,
it's only ever used on bools-as-floats, so we know that src0 is
non-negative.  This saves an instruction per CMP on i915.

Reviewed-by: Zoltán Böszörményi <zboszor@gmail.com>
Reviewed-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12921>

2 years agoci/freedreno: Update restricted trace sha1s.
Emma Anholt [Mon, 20 Sep 2021 17:46:45 +0000 (10:46 -0700)]
ci/freedreno: Update restricted trace sha1s.

Rendering changed slightly recently, but the diffs look fine.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12939>

2 years agoci/baremetal: Retry if our network device spontaneously fails.
Emma Anholt [Mon, 20 Sep 2021 17:07:40 +0000 (10:07 -0700)]
ci/baremetal: Retry if our network device spontaneously fails.

Seen in https://gitlab.freedesktop.org/mesa/mesa/-/jobs/13824132.  It's
unlikely that graphics would kill the network, so just assume it's not our
fault and keep going.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12939>

2 years agoci/freedreno: Add some cubearray piglit flakes on a630 I noticed.
Emma Anholt [Mon, 20 Sep 2021 17:04:08 +0000 (10:04 -0700)]
ci/freedreno: Add some cubearray piglit flakes on a630 I noticed.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12939>

2 years agofreedreno: Assert to check for the previous regression.
Emma Anholt [Mon, 20 Sep 2021 18:13:44 +0000 (11:13 -0700)]
freedreno: Assert to check for the previous regression.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12942>

2 years agofreedreno: Fix autotune regression since batch-cache rework.
Emma Anholt [Mon, 20 Sep 2021 18:11:30 +0000 (11:11 -0700)]
freedreno: Fix autotune regression since batch-cache rework.

I freed the key that autotune needed a little early.

Fixes: b2349a46715e ("freedreno: Move the batch cache to the context.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12942>

2 years agoturnip: Fix a6xx gen4 compute shaders
Rob Clark [Tue, 14 Sep 2021 17:06:06 +0000 (10:06 -0700)]
turnip: Fix a6xx gen4 compute shaders

Port of 74d10525374 freedreno/a6xx: ("Fix a6xx gen4 compute shaders")

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5354
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12856>

2 years agoturnip: Rast updates for a6xx gen4
Rob Clark [Tue, 14 Sep 2021 16:11:38 +0000 (09:11 -0700)]
turnip: Rast updates for a6xx gen4

Port of 219e12b7f39 ("freedreno/a6xx: Rast updates for a6xx gen3")

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12856>

2 years agoturnip: Fix unitialized cs->device
Rob Clark [Tue, 14 Sep 2021 18:16:59 +0000 (11:16 -0700)]
turnip: Fix unitialized cs->device

Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12856>