peter klausler [Tue, 30 Oct 2018 23:25:10 +0000 (16:25 -0700)]
[flang] allow array constructors in all expressions
Original-commit: flang-compiler/f18@
6dd5431cd9a0da203f098487a7d5db379c64b3ea
Reviewed-on: https://github.com/flang-compiler/f18/pull/225
Tree-same-pre-rewrite: false
peter klausler [Tue, 30 Oct 2018 22:24:35 +0000 (15:24 -0700)]
[flang] represent array constructors
Original-commit: flang-compiler/f18@
74ccff6b39972ada3d344ae8ee72d4c18842d35c
Reviewed-on: https://github.com/flang-compiler/f18/pull/225
Tree-same-pre-rewrite: false
peter klausler [Tue, 30 Oct 2018 20:30:56 +0000 (13:30 -0700)]
[flang] Clean up Designator and GetSymbol()
Original-commit: flang-compiler/f18@
61c0af323c13f7ad97521332603497d21638e2f9
Reviewed-on: https://github.com/flang-compiler/f18/pull/225
Tree-same-pre-rewrite: false
peter klausler [Tue, 30 Oct 2018 19:44:09 +0000 (12:44 -0700)]
[flang] Make all Expr<> instances derived from ExpressionBase
Original-commit: flang-compiler/f18@
f7d1a21532a51dc10aa7a8fd775e3404320986a6
Reviewed-on: https://github.com/flang-compiler/f18/pull/225
Tree-same-pre-rewrite: false
peter klausler [Mon, 29 Oct 2018 22:25:35 +0000 (15:25 -0700)]
[flang] Address TODO: define IsAssumedRank predicate, use it
Original-commit: flang-compiler/f18@
f75c3e0ccfc763644afc3b0fe37861e3a5adcdd9
Reviewed-on: https://github.com/flang-compiler/f18/pull/225
Tree-same-pre-rewrite: false
jeanPerier [Thu, 8 Nov 2018 10:37:53 +0000 (11:37 +0100)]
[flang] Merge pull request flang-compiler/f18#222 from flang-compiler/jpr0
C interoperability: Fixes CFI_CDESC_T macro and CFI_establish function
Original-commit: flang-compiler/f18@
e104912ef1f146817b411162e8a657e504a8fc82
Reviewed-on: https://github.com/flang-compiler/f18/pull/222
Jean Perier [Wed, 7 Nov 2018 10:27:04 +0000 (02:27 -0800)]
[flang] Simplified C++ CFI_CDESC_T implem. Added local namespace around
Original-commit: flang-compiler/f18@
456f5a09949701b74b02834668f161bbb5d68009
Reviewed-on: https://github.com/flang-compiler/f18/pull/222
Jean Perier [Tue, 6 Nov 2018 17:06:10 +0000 (09:06 -0800)]
[flang] Changed CFI_CDESC_T macro in C++. Cleaned related tests.
Original-commit: flang-compiler/f18@
752f8eefa0cdf310afcdab50241885a644ea2fb4
Reviewed-on: https://github.com/flang-compiler/f18/pull/222
Tree-same-pre-rewrite: false
Jean Perier [Mon, 5 Nov 2018 15:07:18 +0000 (07:07 -0800)]
[flang] Fixed CFI_establish. Improved and renamed related test suit
Original-commit: flang-compiler/f18@
b75d858e4f96c21da67a8c7ecc4d4bdbcc9c8498
Reviewed-on: https://github.com/flang-compiler/f18/pull/222
Tree-same-pre-rewrite: false
Jean Perier [Fri, 2 Nov 2018 16:42:35 +0000 (09:42 -0700)]
[flang] Fixed CFI_DESC_T macro. Started unit test for C interop
Original-commit: flang-compiler/f18@
f29b80c7582f6b5f18ca26f6fd9466da56479664
Reviewed-on: https://github.com/flang-compiler/f18/pull/222
Tree-same-pre-rewrite: false
Tim Keith [Wed, 7 Nov 2018 20:43:56 +0000 (12:43 -0800)]
[flang] Merge pull request flang-compiler/f18#223 from flang-compiler/tsk5
Resolve expressions in symbols
Original-commit: flang-compiler/f18@
6f253b5514740198bf732aa2e269e97de34d2888
Reviewed-on: https://github.com/flang-compiler/f18/pull/223
Tim Keith [Wed, 7 Nov 2018 20:41:52 +0000 (12:41 -0800)]
[flang] Address review comments
Change `const Symbol *` to `const Symbol &`.
Simplify expression for `Assumed()` and `Deferred()` in `ParamValue`.
Original-commit: flang-compiler/f18@
b3e76706ca72b5d324c96bee4db8efae34e3135e
Reviewed-on: https://github.com/flang-compiler/f18/pull/223
Tim Keith [Wed, 7 Nov 2018 01:18:06 +0000 (17:18 -0800)]
[flang] Resolve expressions in symbols
Add `LazyExpr` class to represent expressions in the symbol table.
Initially they contain a pointer to an expression in the parse tree.
After name resolution is complete and symbols are filled in in the parse
tree, `LazyExpr`s are resolved to `evaluate::Expr<evaluate::SomeType>`.
This is done by `ResolveSymbolExprs()`.
Change `Bound` and `ParamValue` to save their value as a `LazyExpr`.
Change `ObjectEntityDetails` and `TypeParamDetails` to save the initial
value as a `LazyExpr`.
Eliminate `IntExpr` and `IntConst` classes, which were just place-holders.
Add `Clone()` to `ShapeSpec`, `Bound`, `LazyExpr`. Normally they should
be moved but in `ObjectEntityDetails::set_shape()` we need to make copies.
Save type parameter values in `derivedTypeSpec_`. `typeParamValue_` is
not needed.
Write out initial values, type parameter values, and bounds to .mod files.
Evaluate parameter values in expressions.
Make some errors non-fatal so that tests can continue to pass.
Original-commit: flang-compiler/f18@
b90cadfc53c6e31c5f289eadc382bc3908811b86
Reviewed-on: https://github.com/flang-compiler/f18/pull/223
Tree-same-pre-rewrite: false
Tim Keith [Wed, 7 Nov 2018 01:12:02 +0000 (17:12 -0800)]
[flang] Remove include of symbol.h from variable.h
This include will lead to circularities when semantics/type.h needs
include evaluate/expression.h. There will probably be a different
long-term solution.
Original-commit: flang-compiler/f18@
c7fa8150368f7d3a9bb200fc5502ece0a99a8631
Reviewed-on: https://github.com/flang-compiler/f18/pull/223
Tree-same-pre-rewrite: false
Tim Keith [Mon, 5 Nov 2018 23:03:46 +0000 (15:03 -0800)]
[flang] Use forward declarations to reduce includes
Original-commit: flang-compiler/f18@
384af49342fbf767d63fe2a6eb8fa8a9a790f91d
Reviewed-on: https://github.com/flang-compiler/f18/pull/223
Tree-same-pre-rewrite: false
Tim Keith [Mon, 5 Nov 2018 22:36:11 +0000 (14:36 -0800)]
[flang] Move Details rather than copying
We don't need to copy the various Details classes. We will be adding
expressions to some of them (e.g. for bounds or initial values) and they
should generally be moved as well.
In check-do-concurrent.cc, put pointers to Symbols in the symbol
collections rather than copies.
Original-commit: flang-compiler/f18@
cdedfc9b3ee554bf6b1f94adbbb92f8a515e1cbd
Reviewed-on: https://github.com/flang-compiler/f18/pull/223
Tree-same-pre-rewrite: false
Peter Klausler [Thu, 1 Nov 2018 22:06:22 +0000 (15:06 -0700)]
[flang] Merge pull request flang-compiler/f18#221 from flang-compiler/pmk0
Document various pointer-like abstractions
Original-commit: flang-compiler/f18@
11b472741de3465a3ecd915276b3f6517baa0bbf
Reviewed-on: https://github.com/flang-compiler/f18/pull/221
peter klausler [Thu, 1 Nov 2018 22:06:01 +0000 (15:06 -0700)]
[flang] address review comment
Original-commit: flang-compiler/f18@
b5da6b44928d08befaf8a1a1bd6b88cda59e7b21
Reviewed-on: https://github.com/flang-compiler/f18/pull/221
peter klausler [Thu, 1 Nov 2018 20:43:24 +0000 (13:43 -0700)]
[flang] document pointer variations
Original-commit: flang-compiler/f18@
4c718f56646b8522584dd2d3c23defcaf0c82c25
Reviewed-on: https://github.com/flang-compiler/f18/pull/221
Tree-same-pre-rewrite: false
peter klausler [Thu, 1 Nov 2018 20:18:28 +0000 (13:18 -0700)]
[flang] document pointer variations
Original-commit: flang-compiler/f18@
70c55eb1eb75e73165a62821f2666c31270235de
Reviewed-on: https://github.com/flang-compiler/f18/pull/221
Tree-same-pre-rewrite: false
Peter Klausler [Mon, 29 Oct 2018 16:56:25 +0000 (09:56 -0700)]
[flang] Merge pull request flang-compiler/f18#219 from flang-compiler/pmk0
A refactoring of folding
Original-commit: flang-compiler/f18@
a056aaabbbb78e64432393467404d84e253a9ece
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
peter klausler [Mon, 29 Oct 2018 16:26:33 +0000 (09:26 -0700)]
[flang] readability improvement from Tim
Original-commit: flang-compiler/f18@
14179ead7c3aa5a3b26c14b636d78f9f12523529
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
peter klausler [Fri, 26 Oct 2018 23:31:20 +0000 (16:31 -0700)]
[flang] Back out needless macro change that led to clang-format grief
Original-commit: flang-compiler/f18@
5a6e55df1163348b3800e088b4dd0dacd01c1973
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Fri, 26 Oct 2018 22:55:28 +0000 (15:55 -0700)]
[flang] clean up comments, put out for review
Original-commit: flang-compiler/f18@
26a3221fc40ca0c3047c11b731426d270e072880
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Fri, 26 Oct 2018 22:13:30 +0000 (15:13 -0700)]
[flang] prepare for merge
Original-commit: flang-compiler/f18@
5d2490b1c8af0870ad1d399fce7c500f5d07e6be
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Fri, 26 Oct 2018 22:10:24 +0000 (15:10 -0700)]
[flang] Complete refactor of Fold() - checkpoint
Original-commit: flang-compiler/f18@
5061171268ef6a4552aa365642d3f5ad120f871f
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Wed, 24 Oct 2018 21:54:53 +0000 (14:54 -0700)]
[flang] merge
Original-commit: flang-compiler/f18@
d0cd9544f54e8fc841bb16d00841b6ace2f548ad
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Wed, 24 Oct 2018 21:06:46 +0000 (14:06 -0700)]
[flang] complete new Fold
Original-commit: flang-compiler/f18@
4d1726778f193c8813a8cc63fad0b46faf8d2fec
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Wed, 24 Oct 2018 17:43:30 +0000 (10:43 -0700)]
[flang] dodge gcc 7.2.0 build hiccup
Original-commit: flang-compiler/f18@
4a9e862d74f134241a0e1a9cd3fc3562041b3f74
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Wed, 24 Oct 2018 00:05:24 +0000 (17:05 -0700)]
[flang] merge with master
Original-commit: flang-compiler/f18@
53f15da06aab657e94ecea342ef77a07e5e38a27
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Tue, 23 Oct 2018 23:48:06 +0000 (16:48 -0700)]
[flang] new refactored Fold
Original-commit: flang-compiler/f18@
061868fd857b255f8c1b49f3cb300666f5e1edda
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Mon, 22 Oct 2018 22:20:42 +0000 (15:20 -0700)]
[flang] start refactoring of Constant and Fold
Original-commit: flang-compiler/f18@
53f7174c3dddd743146e1cff9ffcde0db4c89b6b
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Thu, 18 Oct 2018 20:03:51 +0000 (13:03 -0700)]
[flang] Refactor some lib/evaluate headers for sanity
Original-commit: flang-compiler/f18@
9530378c39d0206a93eafd7d19b7f52c82e8f904
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Thu, 18 Oct 2018 17:50:55 +0000 (10:50 -0700)]
[flang] rearrange arguments into dummy argument order
Original-commit: flang-compiler/f18@
3bab0f55de1b66d38bd15a841459c3a36cf29d30
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Wed, 17 Oct 2018 22:09:48 +0000 (15:09 -0700)]
[flang] refactor a bit, and rearrange actual arguments into dummy order on intrinsic calls
Original-commit: flang-compiler/f18@
1f50ace68b00a7db4b75ebce5616032501e48457
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
peter klausler [Tue, 16 Oct 2018 23:36:43 +0000 (16:36 -0700)]
[flang] Use Attrs for intrinsic results rather than flags.
Original-commit: flang-compiler/f18@
14c9199718138dee4b8cf1e673935f794c366ac1
Reviewed-on: https://github.com/flang-compiler/f18/pull/219
Tree-same-pre-rewrite: false
Tim Keith [Fri, 26 Oct 2018 18:58:13 +0000 (11:58 -0700)]
[flang] Merge pull request flang-compiler/f18#218 from flang-compiler/tsk2
More name resolution for submodules
Original-commit: flang-compiler/f18@
f574667aaad4fe1135d3427df6a21b8b0adcbb12
Reviewed-on: https://github.com/flang-compiler/f18/pull/218
Tim Keith [Fri, 26 Oct 2018 18:57:08 +0000 (11:57 -0700)]
[flang] Address review comments
Original-commit: flang-compiler/f18@
c3597a1984811900ef8da55f15374417373f5492
Reviewed-on: https://github.com/flang-compiler/f18/pull/218
Tim Keith [Fri, 26 Oct 2018 14:34:50 +0000 (07:34 -0700)]
[flang] Process SeparateModuleSubprogram during name resolution
When a SeparateModuleSubprogram is encountered, check that there is a
corresponding declaration in the current module/submodule or an ancestor.
When it's the current program unit, special handling is required to
avoid trying to declare it again.
Module subprograms with the `MODULE` prefix are handled similarly.
The `hasModulePrefix` flag is passed in to `BeginSubprogram` to
distinguish this case.
Extract common part of `Post(SubroutineStmt)` and `Post(FunctionStmt)` into
`PostSubprogramStmt`. Add code there to ensure that separate module
procedures do not have `EXTERNAL` set. This requires a fix to `ModFileWriter`
to correctly decide when a subprogram is declared in an interface block.
Extract `WalkSubprogramPart` into a separate function. It walks the
internal or module subprograms collecting their names. It is needed to
handle separate module subprograms.
Original-commit: flang-compiler/f18@
339b65f2517cebc115eba4ce91c1d8b304802939
Reviewed-on: https://github.com/flang-compiler/f18/pull/218
Tree-same-pre-rewrite: false
Tim Keith [Wed, 24 Oct 2018 00:13:59 +0000 (17:13 -0700)]
[flang] Reformat and add comment
Original-commit: flang-compiler/f18@
524f224adc98472ce33afa38dc9513b4b26f1f93
Reviewed-on: https://github.com/flang-compiler/f18/pull/218
Tree-same-pre-rewrite: false
Tim Keith [Wed, 24 Oct 2018 00:09:26 +0000 (17:09 -0700)]
[flang] Fix failure to resolve submodule name.
If we have `SUBMODULE(m:s1) s2` and `s1` is already in memory (i.e. does
not need to be read from the `m-s1.mod` file), we still need to record
the fact that the name is a reference to that module symbol.
Original-commit: flang-compiler/f18@
4bb42ed6a4f7da9772903bd411146b989aff8367
Reviewed-on: https://github.com/flang-compiler/f18/pull/218
Tree-same-pre-rewrite: false
Tim Keith [Wed, 24 Oct 2018 00:05:12 +0000 (17:05 -0700)]
[flang] Fix bug with popping scopes.
Processing a SUBMODULE can cause any number of scopes to be pushed on
the scope stack. We don't know how many to pop at the end, so add
`ClearScopes()` to reset the scope stack to its original state.
Original-commit: flang-compiler/f18@
0be4cebd66b81281bfa07016eb2b1393cf271e69
Reviewed-on: https://github.com/flang-compiler/f18/pull/218
Tree-same-pre-rewrite: false
jeanPerier [Fri, 26 Oct 2018 09:18:57 +0000 (11:18 +0200)]
[flang] Merge pull request flang-compiler/f18#217 from flang-compiler/namespace-comment-removal
Format Style Change: Removed namespace comments after closing brace
Original-commit: flang-compiler/f18@
dcca71aae29def7d7db6a1a787a273a6fb393b23
Reviewed-on: https://github.com/flang-compiler/f18/pull/217
Jean Perier [Thu, 25 Oct 2018 12:55:23 +0000 (05:55 -0700)]
[flang] Changed .clang-format so that it will not add a comment after the closing brace of each namespace. Removed all such previous comments from all .cc and .h files
Original-commit: flang-compiler/f18@
aa7f55e15f78909ba8401f85e023ee4c3eaa923f
Reviewed-on: https://github.com/flang-compiler/f18/pull/217
Tim Keith [Thu, 25 Oct 2018 18:44:37 +0000 (11:44 -0700)]
[flang] Merge pull request flang-compiler/f18#216 from flang-compiler/tsk4
Fix bug in rewriting function reference
Original-commit: flang-compiler/f18@
22f25eadc7e0849bba3601a53ac331903ef5c203
Reviewed-on: https://github.com/flang-compiler/f18/pull/216
Tim Keith [Wed, 24 Oct 2018 20:38:45 +0000 (13:38 -0700)]
[flang] Fix bug in rewriting function reference
`a(i)` is parsed as a function reference and needs to be converted to an
array element reference when `a` is an object entity. That determination
was wrong if the symbol for `a` was a symbol representing host-association
or use-association. In that case we need to get to the original symbol
by calling `GetUltimate()` on the symbol.
This was causing symbol09.f90 to get a compilation error because an
array element reference looked like a call to a non-pure function, which
is prohibited inside a DO CONCURRENT.
Original-commit: flang-compiler/f18@
221e6c52c5460edfbec28904ebe1774ff787fc45
Reviewed-on: https://github.com/flang-compiler/f18/pull/216
Eric Schweitz [Wed, 24 Oct 2018 19:22:42 +0000 (12:22 -0700)]
[flang] Merge pull request flang-compiler/f18#196 from flang-compiler/eas6
DO CONCURRENT semantic constraints checking
Original-commit: flang-compiler/f18@
304c6f65482fc04d460abed7b8341dbc9df4fb53
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Eric Schweitz [Wed, 24 Oct 2018 18:10:20 +0000 (11:10 -0700)]
[flang] Fix conflicts
Fix more rotten bits
Fix the tests to reflect merges
Original-commit: flang-compiler/f18@
b9a1a8b809e579819e8a7f67699b1897f3e600d4
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Eric Schweitz [Thu, 11 Oct 2018 23:01:04 +0000 (16:01 -0700)]
[flang] add openmp simd test
Original-commit: flang-compiler/f18@
c31bb0d1440198491c80b29b4ba3645ef9c2425e
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Thu, 11 Oct 2018 22:19:38 +0000 (15:19 -0700)]
[flang] minor changes
Move functions out of FindDoConcurrentLoops
tweak comments
Original-commit: flang-compiler/f18@
713c7e8f9ea292b4660ab989eb87ded4f1389cc1
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Wed, 10 Oct 2018 23:52:06 +0000 (16:52 -0700)]
[flang] add C1120, C1122 and placehokders for C1006, C1121, and C1123
add a new test for C1120
Fix new test's CHECKs
More contraints hacking
Original-commit: flang-compiler/f18@
197e5fd75083d0ca9773b2f75df54fba0ada9dc8
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Wed, 10 Oct 2018 18:44:15 +0000 (11:44 -0700)]
[flang] Add OpenMP annotated loops example as a test
Original-commit: flang-compiler/f18@
d0177b8cc6126e567a646bee3ee663702f50e0f0
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Wed, 10 Oct 2018 15:36:58 +0000 (08:36 -0700)]
[flang] enable the IEEE_GET_FLAG test
Original-commit: flang-compiler/f18@
3f95b388a1c6b8bd8e25da6c7f4c0c11a407e550
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Tue, 9 Oct 2018 23:20:01 +0000 (16:20 -0700)]
[flang] More review changes
Original-commit: flang-compiler/f18@
48f34e66c8e3d47eec59bc677bc4885d19599dcf
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Tue, 9 Oct 2018 22:50:44 +0000 (15:50 -0700)]
[flang] Global replace identifier names.
Original-commit: flang-compiler/f18@
93303cd50de3a150802ac61f249e19b9965512c6
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Tue, 9 Oct 2018 22:33:15 +0000 (15:33 -0700)]
[flang] Incorperate review comments
Original-commit: flang-compiler/f18@
33ff57e3208a5637a28917af7413dce8c00e6442
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Tue, 9 Oct 2018 21:18:16 +0000 (14:18 -0700)]
[flang] Add more constraint checking for DO CONCURRENT.
Add some more tests.
Original-commit: flang-compiler/f18@
e65f755fe1ee4efea8e95713d03bad6842236ff4
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Tue, 9 Oct 2018 17:41:49 +0000 (10:41 -0700)]
[flang] add another resolve-label test for misplaced end do statement.
Original-commit: flang-compiler/f18@
17fa8c1ebf399219febfec659de39a5b558e4b6b
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Wed, 3 Oct 2018 17:24:07 +0000 (10:24 -0700)]
[flang] Cleanup some cruft and tweaks per review comments.
Added a negative test, to check that semantics are not applied bogusly
to loops that are not DO CONCURRENT.
Original-commit: flang-compiler/f18@
d8de45e994de0ff1c4977ded82b1f9918ff83e52
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Tue, 18 Sep 2018 00:19:27 +0000 (17:19 -0700)]
[flang] DO CONCURRENT semantic constraints checking
Add tests for DO CONCURRENT
Original-commit: flang-compiler/f18@
0b40fe1ce4fab86ce08fd89f71f9bb01f0eb7ffa
Reviewed-on: https://github.com/flang-compiler/f18/pull/196
Tree-same-pre-rewrite: false
Eric Schweitz [Wed, 24 Oct 2018 18:03:49 +0000 (11:03 -0700)]
[flang] Merge pull request flang-compiler/f18#185 from flang-compiler/eas5
Improved error messages:
Original-commit: flang-compiler/f18@
f11ceaa7c9df03fe5ad8cd68e5ebb9b5e1853595
Reviewed-on: https://github.com/flang-compiler/f18/pull/185
Eric Schweitz [Wed, 24 Oct 2018 17:53:11 +0000 (10:53 -0700)]
[flang] rename sayLabel SayLabel
Original-commit: flang-compiler/f18@
040af06134945d841331ee21385f7c1a1e2b6803
Reviewed-on: https://github.com/flang-compiler/f18/pull/185
Eric Schweitz [Mon, 15 Oct 2018 19:33:56 +0000 (12:33 -0700)]
[flang] Tweak the error messages to not use "here" like gcc does.
Original-commit: flang-compiler/f18@
cb5da3d4e42a0e62493e5db9a1c33813956f04bf
Reviewed-on: https://github.com/flang-compiler/f18/pull/185
Tree-same-pre-rewrite: false
Eric Schweitz [Thu, 13 Sep 2018 23:11:41 +0000 (16:11 -0700)]
[flang] Improved error messages:
Update the tests to reflect new message
Improved error messages to show both source and destination of mismatches.
Use CharBlock::size.
Original-commit: flang-compiler/f18@
bf79d77d3c0a6982d7e54841d4856c4cf3f8182b
Reviewed-on: https://github.com/flang-compiler/f18/pull/185
Tree-same-pre-rewrite: false
Tim Keith [Tue, 23 Oct 2018 21:35:57 +0000 (14:35 -0700)]
[flang] Merge pull request flang-compiler/f18#215 from flang-compiler/tsk2
Refactoring: add SemanticsContext class
Original-commit: flang-compiler/f18@
99b6ac0ddc4304d9e900c9acf7c31ef607334528
Reviewed-on: https://github.com/flang-compiler/f18/pull/215
Tim Keith [Tue, 23 Oct 2018 21:35:13 +0000 (14:35 -0700)]
[flang] Rename PushLocation() to SetLocation().
Original-commit: flang-compiler/f18@
1b5593c12b23442b5f9fb2ea0a600f1efd5b168d
Reviewed-on: https://github.com/flang-compiler/f18/pull/215
Tim Keith [Mon, 22 Oct 2018 23:41:26 +0000 (16:41 -0700)]
[flang] Add FoldingContext to SemanticsContext
FoldingContext is now part of SemanticsContext. It is created at the
beginning with a default-constructed CharBlock as the location in its
ContextualMessages.
Add PushLocation() to ContextualMessages to remember the previous source
location and set a new one. The old one is restored when the returned
object goes out of scope.
SemanticsContext is now the only state passed in to class ExprAnalyzer,
class Mutator, AnalyzeExpr(), AnalyzeExpressions().
Add Say() convenience functions for reporting errors to ExprAnalyzer.
Original-commit: flang-compiler/f18@
70c499ffc4a1f09a680d636f59938f42ec451ef3
Reviewed-on: https://github.com/flang-compiler/f18/pull/215
Tree-same-pre-rewrite: false
Tim Keith [Mon, 22 Oct 2018 14:37:38 +0000 (07:37 -0700)]
[flang] Refactoring: add SemanticsContext class
The new SemanticsContext holds the state of semantics whose lifetime
spans all of the compilations. It contains the scope tree (and so all
symbols), the intrinsics table, messages, and the state of options that
affect semantics (default kinds, search directories, etc.)
Original-commit: flang-compiler/f18@
f04ceab81f383fa51d76e643066be251d6433ef2
Reviewed-on: https://github.com/flang-compiler/f18/pull/215
Tree-same-pre-rewrite: false
Tim Keith [Thu, 18 Oct 2018 18:07:47 +0000 (11:07 -0700)]
[flang] Merge pull request flang-compiler/f18#214 from flang-compiler/tsk2
More name resolution for construct entities
Original-commit: flang-compiler/f18@
848b067be81a6267c04b2b1fb9ab3163f85141c0
Reviewed-on: https://github.com/flang-compiler/f18/pull/214
Tim Keith [Thu, 18 Oct 2018 14:55:48 +0000 (07:55 -0700)]
[flang] More name resolution for construct entities
Push a new scope for constructs and statements that require one
(DataStmt, DO CONCURRENT, ForallConstruct, ForallStmt -- there are more
to do). Currently we use the Block kind of scope because there is no
difference. Perhaps that kind should be renamed to Construct, though it
does apply to statements as well as constructs.
Add DeclareConstructEntity to create a construct or statement entity.
When the type is not specified it can come from the type of a symbol in
the enclosing scope with the same name. Change DeclareObjectEntity et al.
to return the symbol declared, for the benefit of DeclareConstructEntity.
Use DeclareConstructEntity for DO CONCURRENT index-name, LOCAL, and
LOCAL_INIT variables and the data-i-do-variable in DataImpliedDo
Names in SHARED locality spec need special handling: create a new kinds
of symbol with HostAssocDetails to represent the host-association of the
shared variables within the construct scope. That symbol gets the
LocalityShared flag without affecting the symbol in the outer scope.
HostAssoc symbols may be useful in other contexts, e.g. up-level
references to local variables.
Add parser::DoConstruct::IsDoConcurrent() because DO CONCURRENT loops
introduce a construct scope while other DO loops do not.
Move CanonicalizeDo to before name resolution so that name resolution
doesn't have to deal with labeled DO CONCURRENT loops.
Allow for type of index name to be specified in ConcurrentHeader.
Resolve the derived type name in an AllocateStmt, StructureConstructor
Original-commit: flang-compiler/f18@
bc7b9891367f3174c9b5018ce5636a36a5a76c1c
Reviewed-on: https://github.com/flang-compiler/f18/pull/214
Tim Keith [Mon, 15 Oct 2018 21:44:01 +0000 (14:44 -0700)]
[flang] Simplify unparse-with-symbols.cc
Change it so that the first time a symbol is referenced, its full
definition is emitted, prefixed by "DEF:", and subsequent references
are prefixed with "REF:".
This doesn't give exactly the same results as before but it is
sufficient for testing and is simpler and easier to maintain.
The expected results need to be tweaked accordingly.
Original-commit: flang-compiler/f18@
27b5d082a80f5e98b1e85a503518e7aa8c806af7
Reviewed-on: https://github.com/flang-compiler/f18/pull/214
Tree-same-pre-rewrite: false
Peter Klausler [Tue, 16 Oct 2018 22:31:55 +0000 (15:31 -0700)]
[flang] Merge pull request flang-compiler/f18#213 from flang-compiler/pmk1
Fully parameterize default kinds of intrinsic types
Original-commit: flang-compiler/f18@
f9da6f129ac6b547bb6e0019c7d2e177ce455f37
Reviewed-on: https://github.com/flang-compiler/f18/pull/213
peter klausler [Tue, 16 Oct 2018 21:42:22 +0000 (14:42 -0700)]
[flang] Add -i8, -r8, &c. options to f18 development driver
Original-commit: flang-compiler/f18@
ff7f338126562ce539879a59d3da5707c76ae11a
Reviewed-on: https://github.com/flang-compiler/f18/pull/213
peter klausler [Tue, 16 Oct 2018 20:24:57 +0000 (13:24 -0700)]
[flang] Eliminate DefaultInteger
Original-commit: flang-compiler/f18@
1760b9ccc5d8c6b56e2e85f05a00e90edbb4771b
Reviewed-on: https://github.com/flang-compiler/f18/pull/213
Tree-same-pre-rewrite: false
peter klausler [Tue, 16 Oct 2018 00:11:24 +0000 (17:11 -0700)]
[flang] Eliminating old default type declarations
Original-commit: flang-compiler/f18@
10e4a3385a8e36f535c57284b328483876ec398d
Reviewed-on: https://github.com/flang-compiler/f18/pull/213
Tree-same-pre-rewrite: false
peter klausler [Mon, 15 Oct 2018 22:28:47 +0000 (15:28 -0700)]
[flang] Extract IntrinsicTypeDefaultKinds, move it into semantics
Original-commit: flang-compiler/f18@
dd819b4727219010b30dcfc63e2bf0a894a0a7c9
Reviewed-on: https://github.com/flang-compiler/f18/pull/213
Tree-same-pre-rewrite: false
Peter Klausler [Mon, 15 Oct 2018 21:09:41 +0000 (14:09 -0700)]
[flang] Merge pull request flang-compiler/f18#212 from flang-compiler/pmk0
Intrinsic function tables
Original-commit: flang-compiler/f18@
795f790e93fd937decfab6d51eaa0f68a4f3cba1
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
peter klausler [Mon, 15 Oct 2018 20:39:51 +0000 (13:39 -0700)]
[flang] review comments
Original-commit: flang-compiler/f18@
daaf080dbcc3c6a051aa9444cd141077890b0472
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
peter klausler [Mon, 15 Oct 2018 19:17:30 +0000 (12:17 -0700)]
[flang] improve naming, silence bogus warnings
Original-commit: flang-compiler/f18@
f884fcb2c5f55871cbe7b472ca1145e9ffad0fe2
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Fri, 12 Oct 2018 23:25:39 +0000 (16:25 -0700)]
[flang] more unit testing, fix a bug
Original-commit: flang-compiler/f18@
70189119df6ae84f995d6dd1fbdb6d03c784c723
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Fri, 12 Oct 2018 23:01:55 +0000 (16:01 -0700)]
[flang] unit testing, better error messages
Original-commit: flang-compiler/f18@
f3876008d03751fff5d9490cbb1c7b7539e5c095
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Fri, 12 Oct 2018 00:01:31 +0000 (17:01 -0700)]
[flang] begin unit testing
Original-commit: flang-compiler/f18@
c8b691a4ae7f911363831896ec95684838af19c8
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Thu, 11 Oct 2018 21:51:14 +0000 (14:51 -0700)]
[flang] finish most intrinsic table entries
Original-commit: flang-compiler/f18@
134bd885af5c67ae7fc2291778397546a3d1c189
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Wed, 10 Oct 2018 23:45:17 +0000 (16:45 -0700)]
[flang] a few more intrinsics and some style guide comments
Original-commit: flang-compiler/f18@
b6696ef9236a79ebe13a8695b87061cff19cb3c8
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Wed, 10 Oct 2018 17:48:12 +0000 (10:48 -0700)]
[flang] more intrinsics
Original-commit: flang-compiler/f18@
2e7210be5b2db80c8aa446c4313c8b8df697fac0
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Tue, 9 Oct 2018 19:07:29 +0000 (12:07 -0700)]
[flang] remove arg->intValue field
Original-commit: flang-compiler/f18@
721dc920227378d09d89758903c50538b61ffec3
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Mon, 8 Oct 2018 22:35:19 +0000 (15:35 -0700)]
[flang] debug initial intrinsic table probes
Original-commit: flang-compiler/f18@
dce9a1e1734f6bbc4aff110ac943649f7dcc066a
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Fri, 5 Oct 2018 18:32:54 +0000 (11:32 -0700)]
[flang] error messages
Original-commit: flang-compiler/f18@
392a7330736a8fd444ef92ed5c8ef7dcbc94d461
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Fri, 5 Oct 2018 16:57:53 +0000 (09:57 -0700)]
[flang] checkpoint
Original-commit: flang-compiler/f18@
e103152671f6f1a03417a265bbf581ec50b42d81
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Thu, 4 Oct 2018 20:43:33 +0000 (13:43 -0700)]
[flang] intrinsic pattern matching
Original-commit: flang-compiler/f18@
ca0ee1660a6449c34c7276284e5e63b90ae97540
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Mon, 1 Oct 2018 18:27:45 +0000 (11:27 -0700)]
[flang] buildable checkpoint before merging with master
Original-commit: flang-compiler/f18@
78c5b8c4110bac9ce93c0845569e5ebbe47f596a
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
peter klausler [Sat, 29 Sep 2018 00:02:11 +0000 (17:02 -0700)]
[flang] initial intrinsics table
Original-commit: flang-compiler/f18@
8b5c3adf887cf88752937a4fa5507c0d66051d3b
Reviewed-on: https://github.com/flang-compiler/f18/pull/212
Tree-same-pre-rewrite: false
Tim Keith [Fri, 12 Oct 2018 14:06:18 +0000 (07:06 -0700)]
[flang] Merge pull request flang-compiler/f18#210 from flang-compiler/tsk2
More name resolution
Original-commit: flang-compiler/f18@
f54c7b87597835d17254e077c21b0d94d3979abe
Reviewed-on: https://github.com/flang-compiler/f18/pull/210
Tim Keith [Wed, 10 Oct 2018 23:20:46 +0000 (16:20 -0700)]
[flang] More miscellaneous name resolution
Resolve the index name in a FORALL, DO, or DO CONCURRENT.
Handle pointer-stmt. Add DeclareUnknownEntity() to declare an entity
that is not yet know to be an object or procedure. This is used in the
EntityDecl and PointerDecl cases.
When an array element assignment is mistakenly parsed as a statement
function, ensure the index names are resolved.
Detect erroneous use-association with local name that matches the name
of the containing subprogram.
Cleanup: Eliminate GetVariableName() and CheckImplicitSymbol() in favor
of using the Resolve* functions consistently. Add ResolveName() to do
what CheckImplicitSymbol() used to do.
Disable warnings about unresolved names for some categories of
constructs that are not yet implemented: common blocks, namelist
statements, etc. These will be turned back on when they are implemented.
Original-commit: flang-compiler/f18@
9a41bf37fd1f5ac3f1ec10f9e4f8945cb5ded1f5
Reviewed-on: https://github.com/flang-compiler/f18/pull/210
Tim Keith [Tue, 25 Sep 2018 15:53:53 +0000 (08:53 -0700)]
[flang] Check conflicting construct names
Check that construct names don't conflict with other construct names or
entities in the same scoping unit.
This requires adding symbols for them. MiscDetails was added for cases
like this where we don't need to save much information about the symbol.
References to construct names are recorded too, so those names are now
expected to be resolved and no longer are exceptions in rewrite-parse-tree.cc
Checking that construct names match is still done in resolve-labels.cc.
Original-commit: flang-compiler/f18@
0ad79ff029f6f3001778e2fd6f00153906effec8
Reviewed-on: https://github.com/flang-compiler/f18/pull/210
Tree-same-pre-rewrite: false
Peter Klausler [Wed, 10 Oct 2018 23:03:36 +0000 (16:03 -0700)]
[flang] Merge pull request flang-compiler/f18#209 from flang-compiler/pmk2
Undef HUGE for issue#202, remove some obsolete casts, clean up a little
Original-commit: flang-compiler/f18@
498df684cf9e166cc636e8cea758854b55f13941
Reviewed-on: https://github.com/flang-compiler/f18/pull/209
peter klausler [Wed, 10 Oct 2018 22:27:17 +0000 (15:27 -0700)]
[flang] Prep for review
Original-commit: flang-compiler/f18@
a9439ee83cce0f698471e6647ff2371f73374502
Reviewed-on: https://github.com/flang-compiler/f18/pull/209
peter klausler [Wed, 10 Oct 2018 21:40:32 +0000 (14:40 -0700)]
[flang] Remove some obsolete casts now that Integer has a better constructor
Original-commit: flang-compiler/f18@
f9a4a8bdda34df696c997750cf2bacb3a28e2151
Reviewed-on: https://github.com/flang-compiler/f18/pull/209
Tree-same-pre-rewrite: false
peter klausler [Wed, 10 Oct 2018 21:29:35 +0000 (14:29 -0700)]
[flang] Fix issue#202 by avoiding clang+BSD/Darwin header bug
Original-commit: flang-compiler/f18@
1bdefe528a8a72483c4a5a3b152db76ffc93e17c
Reviewed-on: https://github.com/flang-compiler/f18/pull/209
Tree-same-pre-rewrite: false
Peter Klausler [Wed, 10 Oct 2018 21:59:06 +0000 (14:59 -0700)]
[flang] Merge pull request flang-compiler/f18#208 from flang-compiler/pmk1
Removed obsolete comments and conversions
Original-commit: flang-compiler/f18@
4bd13039b3594e2f6b1c90617a77ac55b6e6b1eb
Reviewed-on: https://github.com/flang-compiler/f18/pull/208