Father Chrysostomos [Mon, 23 Apr 2012 05:32:09 +0000 (22:32 -0700)]
[perl #111000] Let hv_store work on hint hashes
Magic attached to hash elements has its key stored differently depend-
ing on how it was supplied to hv_common. hv_store passes a string/
length pair to hv_common, while hv_store_ent passes an SV.
magic_clearhint wasn’t able to handle string/length pairs, and only
worked with SVs, resulting in assertion failures or crashes.
This commit fixes magic_clearhint, so that XS code can use hv_store on
hint hashes.
Father Chrysostomos [Mon, 23 Apr 2012 05:27:50 +0000 (22:27 -0700)]
mg.c:magic_clearhint: remove redundant PERL_UNUSED_ARG
Father Chrysostomos [Mon, 23 Apr 2012 05:06:57 +0000 (22:06 -0700)]
XS-APItest/t/hash.t: comment typo
Father Chrysostomos [Mon, 23 Apr 2012 05:05:24 +0000 (22:05 -0700)]
Increase $XS::APItest::VERSION to 0.39
Father Chrysostomos [Mon, 23 Apr 2012 03:35:43 +0000 (20:35 -0700)]
pp_ctl.c:pp_goto: Don’t repeat yourself
No need to say DIE three times.
Father Chrysostomos [Mon, 23 Apr 2012 03:34:24 +0000 (20:34 -0700)]
Produce the right error for goto "\0"
Since we have supported for embedded nulls in strings, we shouldn’t
be using if(*label) to see whether label has a non-zero length.
It’s probably not possible to get a null into a label, but we should
still say ‘can’t find’ rather than ‘must have’ in that case.
Father Chrysostomos [Mon, 23 Apr 2012 03:19:15 +0000 (20:19 -0700)]
[perl #111794] Make goto "" like goto ${\""}
The logic was written in such a way that goto "" just happened to slip
past all the checks and cause pp_goto to return NULL for the next op,
which means the end of the program.
goto ${\""} dies with ‘goto must have label’, so goto ""
should as well.
This also adds other tests for that error, which was apparently
untested till now.
Father Chrysostomos [Mon, 23 Apr 2012 03:00:14 +0000 (20:00 -0700)]
Teach B::Concise about UTF8 labels
Father Chrysostomos [Mon, 23 Apr 2012 02:58:26 +0000 (19:58 -0700)]
Increase $B::Concise::VERSION to 0.90
Father Chrysostomos [Sun, 22 Apr 2012 22:47:38 +0000 (15:47 -0700)]
Corrections to AUTHORS should go to perlbug
Father Chrysostomos [Sun, 22 Apr 2012 06:28:51 +0000 (23:28 -0700)]
regen/opcodes: Rmv evalonce comment
This goes all the way back to when perl 5.0 was being polished up.
The idea behind evalonce is that eval "constant string" should be
optimisable by being compiled ahead of time, just like eval { ... }.
But this could never work properly, because BEGIN blocks would only
fire once. Also, eval '$x .. $y' is an easy way to create two separ-
ate flip-flops. There are undoubtedly many other reasons why this
could never work.
So there is no reason to keep this comment any longer, as it is not
(or should not be) a to-do item.
Father Chrysostomos [Sun, 22 Apr 2012 06:25:33 +0000 (23:25 -0700)]
pp_hot.c:pp_entersub: Rmv comment about setting PL_compcv
PL_compcv is meant to point to the currently compiling sub, even dur-
ing an eval’s run time. (See commit 676a678.) Therefore, this com-
ment’s suggestion is incorrect.
Alan Haggai Alavi [Tue, 28 Feb 2012 15:48:58 +0000 (21:18 +0530)]
Removed a redundant 'once'
Father Chrysostomos [Mon, 21 May 2012 22:59:37 +0000 (15:59 -0700)]
Fix non-GCC compilation
I mistakenly thought XPUSHs(...) was an expression. Now it is.
Father Chrysostomos [Mon, 21 May 2012 18:35:34 +0000 (11:35 -0700)]
[Merge] Filetest refactoring
This changes the way filetests handle the stack, allowing for sig-
nificant simplification of the code. It also fixes a bug with ‘-t
bareword’ writing one past the end of the stack.
Father Chrysostomos [Thu, 29 Mar 2012 22:58:56 +0000 (15:58 -0700)]
pp_sys.c:S_try_amagic_ftest: Remove SPAGAIN
Overloading pushes a new stack to prevent the need for this.
Father Chrysostomos [Thu, 29 Mar 2012 22:58:12 +0000 (15:58 -0700)]
pp_sys.c: Remove SPAGAIN after my_(l)stat_flags
As of the previous commit, these two functions no longer affect
the stack.
Father Chrysostomos [Thu, 29 Mar 2012 22:55:22 +0000 (15:55 -0700)]
Move stack extension into FT_* macros
Every filetest operator with the OPf_REF flag set has to extend the
stack for the argument. One operator was missing it until the previ-
ous commit. Since we have special return macros for these operators,
put the stack extension there, to avoid a repeat of this type of mis-
take and reduce repetitiveness.
Father Chrysostomos [Thu, 29 Mar 2012 21:52:45 +0000 (14:52 -0700)]
Make -t BAREWORD extend the stack
It appears always to have been this way. It was writing past the end
of the stack.
Father Chrysostomos [Thu, 29 Mar 2012 21:50:45 +0000 (14:50 -0700)]
pp.h: Missing macro parentheses
This wasn’t affecting anything, but was a bug waiting to happen.
Father Chrysostomos [Thu, 29 Mar 2012 21:49:58 +0000 (14:49 -0700)]
Make filetest ops fiddle the stack less
See commits
8db8f6b697e and
d6642e439 for the background.
Instead of sometimes popping items off the stack for filetest operat-
ors and sometimes not, just leave the item on the stack and use SETs
to return the value (which the overload code was doing already any-
way). This simplifies the code and allows
d6642e439 to be reverted.
It also makes things theoretically faster, simply because there is
less stuff happening.
Karl Williamson [Mon, 21 May 2012 13:53:50 +0000 (07:53 -0600)]
mktables: Defer accepting Unicode's BELL character
As soon as 5.17 started, this created a failing test, which was to
remind us that the deprecation cycle was over, and that the name BELL
should be now used for U+1F514 instead of U+0007. See commit messages
for
3ffed8c228f4a59b1527ae7ed584ca21386420f7 and
10914c783fe2ea3ee73a870599f30cedb7de96d0
This change puts off the failure unless we try to ship a 5.18 without
dealing with the issue. I'm not quite ready to deal with it, but will
do so shortly, long before 5.18.
Ricardo Signes [Mon, 21 May 2012 13:03:13 +0000 (09:03 -0400)]
update the release schedule: 5.16 is 2012-2013
Ricardo Signes [Mon, 21 May 2012 00:47:49 +0000 (20:47 -0400)]
update the release schedule for 5.16, 5.17, 5.18
Ricardo Signes [Mon, 21 May 2012 00:40:52 +0000 (20:40 -0400)]
there are no longer any scheduled 5.12 releases
Ricardo Signes [Mon, 21 May 2012 00:15:36 +0000 (20:15 -0400)]
add the 5.17 feature bundle
Ricardo Signes [Mon, 21 May 2012 00:13:22 +0000 (20:13 -0400)]
uconfig regen needed after version bump!
Ricardo Signes [Sun, 20 May 2012 23:32:57 +0000 (19:32 -0400)]
bump version to 5.17.0
Ricardo Signes [Sun, 20 May 2012 23:25:54 +0000 (19:25 -0400)]
create the new perldelta for 5.17.0
Ricardo Signes [Sun, 20 May 2012 23:10:11 +0000 (19:10 -0400)]
include some more data in new-perldelta output
Ricardo Signes [Sun, 20 May 2012 23:04:47 +0000 (19:04 -0400)]
add the 5.16.0 epigraph
Ricardo Signes [Sun, 20 May 2012 22:35:59 +0000 (18:35 -0400)]
perlhist: add the perl-5.16.0 and -RC2 dates
Ricardo Signes [Sun, 20 May 2012 12:53:02 +0000 (08:53 -0400)]
remove the RC2; this will be the real perl 5.16.0
Ricardo Signes [Sun, 20 May 2012 12:35:04 +0000 (08:35 -0400)]
perldelta: fix the example of lvalue ref from substr
reported by Shlomi Fish
Ricardo Signes [Sat, 19 May 2012 13:34:15 +0000 (09:34 -0400)]
perldelta: update acknowledgements with new contributors
Breno G. de Oliveira [Sat, 19 May 2012 13:29:11 +0000 (09:29 -0400)]
minor tag consistency fixes for perldelta.pod
Ricardo Signes [Sat, 19 May 2012 13:15:46 +0000 (09:15 -0400)]
perldelta: note the removal of the perl4 core .pl files
Mistakenly omitted (somehow) from a patch originally from Reini
Urban
Andy Dougherty [Wed, 16 May 2012 11:31:58 +0000 (07:31 -0400)]
[perl #112924] [PATCH] Clarify test instructions in INSTALL
While trying to track down a failed test, I found the instructions in
the INSTALL file to be less than optimal.
This patch re-orders the suggestions to put the ones most likely to work
first, clarifies which directory you should be in, and moves a "see-also"
type reference to where it is more likely to be useful.
The catalyst for this was that
./perl -MTestInit cpan/Archive-Extract/t/01_Archive-Extract.t
fails because it can't find strict.pm. (See [perl #1122926].) Since it's
probably not the only such case, I thought it useful and prudent to
advise using t/harness instead as a first recourse.
Tom Hukins [Wed, 16 May 2012 01:42:48 +0000 (21:42 -0400)]
perldelta: fix bad references to "unicode_strings"
The documentation written for
2e2b2571 erroneously mentions
"unicode_semantics" instead of "unicode_strings".
Ricardo Signes [Wed, 16 May 2012 01:34:00 +0000 (21:34 -0400)]
prevent PERL_UNICODE from affecting t/mro/package_aliases_utf8.t
Ricardo Signes [Wed, 16 May 2012 01:22:21 +0000 (21:22 -0400)]
perldelta: known issue: t/op/filetest.t
Andy Dougherty [Wed, 16 May 2012 01:16:45 +0000 (21:16 -0400)]
note the gcc -O2 and link-time-optimization problem
Ricardo Signes [Wed, 16 May 2012 01:13:08 +0000 (21:13 -0400)]
our next release is RC2
Ricardo Signes [Tue, 15 May 2012 21:59:48 +0000 (17:59 -0400)]
perldelta: Americanise spellings
Ricardo Signes [Tue, 15 May 2012 11:41:36 +0000 (07:41 -0400)]
reflect Socket update in Module::CoreList
Tony Cook [Tue, 15 May 2012 09:22:30 +0000 (19:22 +1000)]
Update Socket to CPAN version 2.001
2.001 CHANGES:
* Apply (modified) patch from ppisar@redhat.com to fix memory
addressing bug with Zero() - RT76067
* Document that inet_pton() doesn't work on hostnames, only textual
addresses - RT76010
* Ignore any existing-but-undefined hints hash members to
getaddrinfo()
Done for the critical RT76067 fix.
Ricardo Signes [Tue, 15 May 2012 11:27:17 +0000 (07:27 -0400)]
perldelta typo fixes (from mauke)
Father Chrysostomos [Tue, 15 May 2012 20:53:29 +0000 (13:53 -0700)]
Revert part of
34d9f36f9
I was going to apply this after code freeze, but I made a mistake
when switching branches locally and ended up combining it with
another commit.
Father Chrysostomos [Tue, 15 May 2012 20:51:47 +0000 (13:51 -0700)]
AUTHORS: Shirataka -> Shirakata
Father Chrysostomos [Tue, 15 May 2012 20:39:22 +0000 (13:39 -0700)]
perldelta: extraneous double spaces
Tom Christiansen [Tue, 15 May 2012 20:38:09 +0000 (13:38 -0700)]
v5.16 RC0 perldelta cleanup
Below is a patch with some simple typo and verbosity cleanup in
the current pod/perldelta.pod in blead as of ~30 minutes ago.
Shirakata Kentaro [Tue, 15 May 2012 20:02:50 +0000 (13:02 -0700)]
[perl #112944] perldelta: typo
Father Chrysostomos [Tue, 15 May 2012 19:58:42 +0000 (12:58 -0700)]
Add Shirataka Kentaro to AUTHORS
Ricardo Signes [Tue, 15 May 2012 02:59:38 +0000 (22:59 -0400)]
add 5.16.0-RC0 and -RC1 to perlhist
Ricardo Signes [Tue, 15 May 2012 01:52:47 +0000 (21:52 -0400)]
minor grammar correction
thanks, Jim Keenan!
Ricardo Signes [Tue, 15 May 2012 01:49:01 +0000 (21:49 -0400)]
add Daniel Kahn Gillmor to AUTHORS
Ricardo Signes [Tue, 15 May 2012 01:22:06 +0000 (21:22 -0400)]
document the yet-explained Win32 test hanging
We will ship with this unfixed unless someone comes up with the
cure in the next week.
Ricardo Signes [Tue, 15 May 2012 00:53:50 +0000 (20:53 -0400)]
perldelta: fix a noun/verb number agreement
reported by mauke
Ricardo Signes [Tue, 15 May 2012 00:15:59 +0000 (20:15 -0400)]
skip t/win32/runenv.t unless -DPERL_IMPLICIT_SYS
this test fails without PERL_IMPLICIT_SYS, as reported by Steve
Hay in <CADED=K4EqXkJa2uC13wVYY_=uGDCx=uQ_rXu3Me4+3FvVM8D+g@mail.gmail.com>
Ricardo Signes [Mon, 14 May 2012 19:49:27 +0000 (15:49 -0400)]
Revert fixes for [rt.cpan.org #61577]
These changes introduced some test failures on AIX and other platforms,
and rather than dig around for more failing platforms during the RCx
period, we will revert this to reapply later when it is more tested.
This reverts commit
01b71c89216c9f447494638a5d108e13c45c3863.
This reverts commit
b6903614db213f07401367249dc84c896eb099b7.
This reverts commit
271d04eee1933df0971f54f7bf9a5ca3575e7e6a.
Ricardo Signes [Mon, 14 May 2012 16:26:36 +0000 (12:26 -0400)]
next release will be RC1
Ricardo Signes [Mon, 14 May 2012 16:26:24 +0000 (12:26 -0400)]
perldelta: fix version named in acknowledgements
Nicholas Clark [Mon, 14 May 2012 09:17:06 +0000 (10:17 +0100)]
In the Linux hints, invoke gcc with LANG and LC_ALL set to "C".
The output of gcc -print-search-dirs is subject to localisation, which means
that the literal text "libraries" will not be present if the user has a
non-English locale, and we won't determine the correct path for libraries
such as -lm, breaking the build. Problem diagnosed by Alexander Hartmaier.
Paul Johnson [Mon, 14 May 2012 08:45:10 +0000 (09:45 +0100)]
Don't test that errno is still 0 after POSIX::f?pathconf
I think the best we can do with respect to the f?pathconf tests is to
make sure that the perl call doesn't die, and that the system call
doesn't fail. And it's arguable we should only be testing the former.
But since we've been testing more that this anyway, it's probably safe
to test both.
With respect to the sysconf call, I think we shouldn't test more than
that perl doesn't die. Any further testing would require different
tests based the argument being passed in. Before doing that, it's
probably worth considering the purpose of the tests. I don't think we
really want to test that POSIX has been implemented correctly, only that
our layer over it is correctly implemented.
This fixes RT #112866.
Karl Williamson [Mon, 14 May 2012 15:47:36 +0000 (09:47 -0600)]
perldelta: Remove duplicate paragraph
Ricardo Signes [Fri, 11 May 2012 22:00:03 +0000 (18:00 -0400)]
study as no-op is a bugfix, not performance enhancement
Father Chrysostomos [Fri, 11 May 2012 16:55:09 +0000 (09:55 -0700)]
perldelta: Add ‘(5.14.2)’ markers
Father Chrysostomos [Fri, 11 May 2012 16:50:20 +0000 (09:50 -0700)]
perldelta: Explain the ‘(5.14.1)’ markers
Father Chrysostomos [Fri, 11 May 2012 16:48:49 +0000 (09:48 -0700)]
perldelta: Use single quotes in C<>
C<> renders as "..." in nroff, so C<... "..." ...> ends up looking weird.
Karl Williamson [Fri, 11 May 2012 16:44:10 +0000 (10:44 -0600)]
perldelta: Use L<> to link to changed module pods
Spotted by Vincent Pit
Karl Williamson [Fri, 11 May 2012 16:35:13 +0000 (10:35 -0600)]
perldelta: Reorder to avoid pronoun confusion
Spotted by Zsbán Ambrus
Karl Williamson [Fri, 11 May 2012 16:29:31 +0000 (10:29 -0600)]
perldelta: typo
Spotted by Zsbán Ambrus
Karl Williamson [Fri, 11 May 2012 16:25:15 +0000 (10:25 -0600)]
perldelta: Add future deprecation text about \Q
Father Chrysostomos [Fri, 11 May 2012 16:30:25 +0000 (09:30 -0700)]
perldelta: misuse of commas
Father Chrysostomos [Fri, 11 May 2012 16:27:08 +0000 (09:27 -0700)]
perldelta: typo
Father Chrysostomos [Fri, 11 May 2012 16:26:43 +0000 (09:26 -0700)]
perldelta: [rt.cpan.org #0], not RT 0
Father Chrysostomos [Fri, 11 May 2012 16:24:14 +0000 (09:24 -0700)]
Rmv second ‘version’ in upgrade notices
Some of these were like this:
...from version 123 to version 456.
and some like this:
...from version 123 to 456.
Since the former is wordy, I’ve used the latter throughout.
Father Chrysostomos [Fri, 11 May 2012 16:20:46 +0000 (09:20 -0700)]
perldelta: Consistent fullstops for ‘upgraded from x to x’
Father Chrysostomos [Fri, 11 May 2012 16:18:44 +0000 (09:18 -0700)]
perldelta: consistent spaces after dots
Father Chrysostomos [Fri, 11 May 2012 16:17:10 +0000 (09:17 -0700)]
perldelta: consistent semicolons in CGI example
Father Chrysostomos [Fri, 11 May 2012 16:16:43 +0000 (09:16 -0700)]
perldelta: grammar
Father Chrysostomos [Fri, 11 May 2012 16:16:11 +0000 (09:16 -0700)]
perldelta: fix capitalisation
Karl Williamson [Fri, 11 May 2012 15:40:20 +0000 (09:40 -0600)]
perldelta: Mention 5.14.0, not 5.13.6
Karl Williamson [Fri, 11 May 2012 15:37:37 +0000 (09:37 -0600)]
perldelta: Correct statement
It was pointed out to me after I wrote the text in an earlier perldelta
that this one is extracted from, that it is extremely unlikely to run
out of memory; I had not bothered to really do the math.
Karl Williamson [Fri, 11 May 2012 15:36:45 +0000 (09:36 -0600)]
perldelta: correct statement
Karl Williamson [Fri, 11 May 2012 15:33:04 +0000 (09:33 -0600)]
perldelta: grammar
Ricardo Signes [Fri, 11 May 2012 14:06:39 +0000 (10:06 -0400)]
perldelta: slightly expand and clarify policy note
Ricardo Signes [Fri, 11 May 2012 12:18:05 +0000 (08:18 -0400)]
perldelta: break Pod:: deprecations onto two items
Ricardo Signes [Fri, 11 May 2012 12:07:25 +0000 (08:07 -0400)]
Revert "perl5160delta: The coreargs opcode is undeserving of mention"
This reverts commit
1061b56a7b2cc84a8ac96a405e5b8c185936605c.
This is a reversion of a reversion. The reversion in
1061b56a7b2cc was
a bizarre mistake made during merging some blead/release conflicts, and
rjbs sincerely apologizes!
Ricardo Signes [Fri, 11 May 2012 12:04:55 +0000 (08:04 -0400)]
add long-form keys for newer versions in CoreList
Dave Rolsky [Fri, 11 May 2012 07:28:33 +0000 (02:28 -0500)]
Various small grammar fixes in perldelta
Ricardo Signes [Fri, 11 May 2012 02:36:37 +0000 (22:36 -0400)]
perldelta: update "Updated Modules" with highlights
Ricardo Signes [Fri, 11 May 2012 01:24:47 +0000 (21:24 -0400)]
bump the CoreList version in CoreList for 5.16
Ricardo Signes [Thu, 10 May 2012 20:56:40 +0000 (16:56 -0400)]
skip the porting/utils.t unless in a git checkout
Today I tried to build 5.16.0-RC0 on my Linode and I got this:
ok 78 # skip utils/cpanp-run-perl executes code in a BEGIN block which fails for
empty @ARGV
not ok 79 - utils/cpanp compiles
# Failed test 79 - utils/cpanp compiles at porting/utils.t line 81
# got "defined(%hash) is deprecated at /usr/local/lib/perl5/site_perl/5.10.
0/Locale/Maketext/Lexicon.pm line 307.\n\t(Maybe you should just omit the define
d()?)\nutils/cpanp syntax OK\n"
# expected "utils/cpanp syntax OK\n"
Ugh. We really don't want this to happen to somebody else, because this
test is "do not let the developer break stuff" not "make sure the install
works."
Ricardo Signes [Thu, 10 May 2012 19:08:21 +0000 (15:08 -0400)]
add a changes_between function in Module::CoreList
Ricardo Signes [Thu, 10 May 2012 18:47:18 +0000 (14:47 -0400)]
point out "corelist --diff" in perldelta
Ricardo Signes [Tue, 1 May 2012 22:28:43 +0000 (18:28 -0400)]
add the --diff option to corelist
Ricardo Signes [Thu, 10 May 2012 18:37:22 +0000 (14:37 -0400)]
update Module::CoreList for 5.16.0
Ricardo Signes [Thu, 10 May 2012 18:34:27 +0000 (14:34 -0400)]
allow for .tgz dists in the CoreList updater
Ricardo Signes [Thu, 10 May 2012 18:17:04 +0000 (14:17 -0400)]
perldelta: the acknowledgements section!