platform/upstream/libSkiaSharp.git
11 years agoRestyle SkPDFImageShader and support tiling bitmaps outside clip bounds
commit-bot@chromium.org [Wed, 21 Aug 2013 23:10:45 +0000 (23:10 +0000)]
Restyle SkPDFImageShader and support tiling bitmaps outside clip bounds

BUG=chromium:99458
R=edisonn@google.com, vandebo@chromium.org

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22884013

git-svn-id: http://skia.googlecode.com/svn/trunk@10870 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBetter error reporting when dynamic loading fails with DirectWrite.
bungeman@google.com [Wed, 21 Aug 2013 22:41:05 +0000 (22:41 +0000)]
Better error reporting when dynamic loading fails with DirectWrite.

git-svn-id: http://skia.googlecode.com/svn/trunk@10869 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix android doubly defined empty string due to static lib and shared lib thing.
bsalomon@google.com [Wed, 21 Aug 2013 20:50:50 +0000 (20:50 +0000)]
Fix android doubly defined empty string due to static lib and shared lib thing.

git-svn-id: http://skia.googlecode.com/svn/trunk@10868 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCreate new target to hold gpu test code, enable direct testing of GrEffects in GM.
commit-bot@chromium.org [Wed, 21 Aug 2013 19:27:48 +0000 (19:27 +0000)]
Create new target to hold gpu test code, enable direct testing of GrEffects in GM.

R=robertphillips@google.com, jvanverth@google.com, egdaniel@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23352003

git-svn-id: http://skia.googlecode.com/svn/trunk@10866 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoexpectations for radial_gradient2
mtklein@google.com [Wed, 21 Aug 2013 19:18:47 +0000 (19:18 +0000)]
expectations for radial_gradient2

BUG=

Review URL: https://codereview.chromium.org/23144005

git-svn-id: http://skia.googlecode.com/svn/trunk@10865 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate expectations for Mac PDF
vandebo@chromium.org [Wed, 21 Aug 2013 18:04:09 +0000 (18:04 +0000)]
Update expectations for Mac PDF

R=epoger@google.com, vandebo@chromium.org

Review URL: https://codereview.chromium.org/22865029

git-svn-id: http://skia.googlecode.com/svn/trunk@10863 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd skia_clang_build gyp define, add -Wstring-conversion flag
borenet@google.com [Wed, 21 Aug 2013 18:02:50 +0000 (18:02 +0000)]
Add skia_clang_build gyp define, add -Wstring-conversion flag

If you want the warning, you have to specify skia_clang_build=1

R=djsollen@google.com

Review URL: https://codereview.chromium.org/23038014

git-svn-id: http://skia.googlecode.com/svn/trunk@10861 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate references to buildbot globals deprecated by r10856
epoger@google.com [Wed, 21 Aug 2013 17:35:59 +0000 (17:35 +0000)]
Update references to buildbot globals deprecated by r10856

R=borenet@google.com

Review URL: https://codereview.chromium.org/23011035

git-svn-id: http://skia.googlecode.com/svn/trunk@10860 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd new baselines for arcofzorro GM
robertphillips@google.com [Wed, 21 Aug 2013 17:29:37 +0000 (17:29 +0000)]
Add new baselines for arcofzorro GM

git-svn-id: http://skia.googlecode.com/svn/trunk@10859 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding new baselines for blurquickreject GM
robertphillips@google.com [Wed, 21 Aug 2013 17:21:16 +0000 (17:21 +0000)]
Adding new baselines for blurquickreject GM

git-svn-id: http://skia.googlecode.com/svn/trunk@10858 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd an empty typeface as a default-default.
bungeman@google.com [Wed, 21 Aug 2013 17:20:57 +0000 (17:20 +0000)]
Add an empty typeface as a default-default.

R=reed@google.com

Review URL: https://codereview.chromium.org/22861017

git-svn-id: http://skia.googlecode.com/svn/trunk@10857 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd new "bleed" GM baselines
robertphillips@google.com [Wed, 21 Aug 2013 16:53:52 +0000 (16:53 +0000)]
Add new "bleed" GM baselines

git-svn-id: http://skia.googlecode.com/svn/trunk@10855 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: code cleanup - add licence on files, make replace __DEFINE__foo with foo_D...
edisonn@google.com [Wed, 21 Aug 2013 16:31:37 +0000 (16:31 +0000)]
pdfviewer: code cleanup - add licence on files, make replace __DEFINE__foo with foo_DEFINED to match skia project

Review URL: https://codereview.chromium.org/23361009

git-svn-id: http://skia.googlecode.com/svn/trunk@10854 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoBleed cleanup (remove nocolorbleed GM & enable bleed in game bench)
robertphillips@google.com [Wed, 21 Aug 2013 16:30:39 +0000 (16:30 +0000)]
Bleed cleanup (remove nocolorbleed GM & enable bleed in game bench)

https://codereview.chromium.org/23264014/

git-svn-id: http://skia.googlecode.com/svn/trunk@10853 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoImplement SkEmptyFontMgr::onLegacyCreateTypeface and make pure virtual.
bungeman@google.com [Wed, 21 Aug 2013 16:28:26 +0000 (16:28 +0000)]
Implement SkEmptyFontMgr::onLegacyCreateTypeface and make pure virtual.

R=reed@google.com

Review URL: https://codereview.chromium.org/22849025

git-svn-id: http://skia.googlecode.com/svn/trunk@10852 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoallow both GDI and DW fontmgrs at the same time
bungeman@google.com [Wed, 21 Aug 2013 15:20:43 +0000 (15:20 +0000)]
allow both GDI and DW fontmgrs at the same time

BUG=
R=bungeman@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10718

Committed: https://code.google.com/p/skia/source/detail?r=10788

Review URL: https://codereview.chromium.org/23058002

git-svn-id: http://skia.googlecode.com/svn/trunk@10851 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAvoid getLength in ico decoder.
scroggo@google.com [Wed, 21 Aug 2013 15:01:48 +0000 (15:01 +0000)]
Avoid getLength in ico decoder.

Only call getLength() if hasLength() returned true. Otherwise, copy the
stream into an SkDynamicMemoryWStream and copy it into alloc'ed space.

Share common code between bmp and ico.

BUG=https://b.corp.google.com/issue?id=8432093
R=djsollen@google.com

Review URL: https://codereview.chromium.org/23330002

git-svn-id: http://skia.googlecode.com/svn/trunk@10850 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake BMP decoder not depend on call to getLength.
scroggo@google.com [Wed, 21 Aug 2013 14:59:03 +0000 (14:59 +0000)]
Make BMP decoder not depend on call to getLength.

If the decoder does not have a length, use an SkDynamicMemoryStream
to copy it to contiguous memory, to be passed to BmpDecoderHelper.

BUG=https://b.corp.google.com/issue?id=8432093
R=djsollen@google.com

Review URL: https://codereview.chromium.org/22877020

git-svn-id: http://skia.googlecode.com/svn/trunk@10849 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove dependency on getLength from webp decoder.
scroggo@google.com [Wed, 21 Aug 2013 14:56:09 +0000 (14:56 +0000)]
Remove dependency on getLength from webp decoder.

In webp_parse_header, continue reading until end of stream is reached,
or we have read WEBP_VP8_HEADER_SIZE bytes. Do not check to see if the
stream was too short, since it may not have a way to report its length,
and WEBP_VP8_HEADER_SIZE is padded slightly. Instead, depend on
WebPGetFeatures to report that the stream did not have enough data.

In webp_idecode, only check length if it is available.

BUG=https://b.corp.google.com/issue?id=8432093
R=djsollen@google.com, vikasa@google.com

Review URL: https://codereview.chromium.org/22841005

git-svn-id: http://skia.googlecode.com/svn/trunk@10848 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate DirectWrite code so that it is loadable on XP.
bungeman@google.com [Wed, 21 Aug 2013 14:53:59 +0000 (14:53 +0000)]
Update DirectWrite code so that it is loadable on XP.

This change delay loads GetUserDefaultLocaleName since it is available
in Vista+.

R=reed@google.com

Review URL: https://codereview.chromium.org/23380002

git-svn-id: http://skia.googlecode.com/svn/trunk@10847 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdding new baseline image for Nexus7 fontscaler GM
robertphillips@google.com [Wed, 21 Aug 2013 14:08:47 +0000 (14:08 +0000)]
Adding new baseline image for Nexus7 fontscaler GM

git-svn-id: http://skia.googlecode.com/svn/trunk@10846 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRecognize that ES3 supports texture storage. Add workaround for apparent Adreno bug.
commit-bot@chromium.org [Wed, 21 Aug 2013 14:01:56 +0000 (14:01 +0000)]
Recognize that ES3 supports texture storage. Add workaround for apparent Adreno bug.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22856006

git-svn-id: http://skia.googlecode.com/svn/trunk@10845 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChromium staging for SkDevice refactoring
robertphillips@google.com [Wed, 21 Aug 2013 13:54:44 +0000 (13:54 +0000)]
Chromium staging for SkDevice refactoring

https://codereview.chromium.org/23332009/

git-svn-id: http://skia.googlecode.com/svn/trunk@10844 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNexus 7 Performance trigger rebaselines
robertphillips@google.com [Wed, 21 Aug 2013 12:08:18 +0000 (12:08 +0000)]
Nexus 7 Performance trigger rebaselines

git-svn-id: http://skia.googlecode.com/svn/trunk@10843 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Wed, 21 Aug 2013 07:01:29 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10842 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSupport multiple PDF rendering backends in the GM
vandebo@chromium.org [Tue, 20 Aug 2013 23:08:40 +0000 (23:08 +0000)]
Support multiple PDF rendering backends in the GM

R=epoger@google.com, vandebo@chromium.org

Review URL: https://codereview.chromium.org/21669004

git-svn-id: http://skia.googlecode.com/svn/trunk@10841 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChromium's clang bots do not like the SkASSERT(!"foo") construct
robertphillips@google.com [Tue, 20 Aug 2013 21:41:15 +0000 (21:41 +0000)]
Chromium's clang bots do not like the SkASSERT(!"foo") construct

git-svn-id: http://skia.googlecode.com/svn/trunk@10840 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd validation check that linewidth func is present (we already call it on ES).
commit-bot@chromium.org [Tue, 20 Aug 2013 20:54:08 +0000 (20:54 +0000)]
Add validation check that linewidth func is present (we already call it on ES).

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22842008

git-svn-id: http://skia.googlecode.com/svn/trunk@10839 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agocreate a macro for testing if skcolor and skpmcolor have same shift values
djsollen@google.com [Tue, 20 Aug 2013 20:28:03 +0000 (20:28 +0000)]
create a macro for testing if skcolor and skpmcolor have same shift values

R=reed@google.com

Review URL: https://codereview.chromium.org/22799015

git-svn-id: http://skia.googlecode.com/svn/trunk@10838 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUse ES3 texture swizzling.
commit-bot@chromium.org [Tue, 20 Aug 2013 20:22:52 +0000 (20:22 +0000)]
Use ES3 texture swizzling.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23128009

git-svn-id: http://skia.googlecode.com/svn/trunk@10837 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd perf benchmarks and more unit tests for matrix inversion
commit-bot@chromium.org [Tue, 20 Aug 2013 20:15:24 +0000 (20:15 +0000)]
Add perf benchmarks and more unit tests for matrix inversion

R=jvanverth@google.com, reed@google.com

Author: shawnsingh@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22886010

git-svn-id: http://skia.googlecode.com/svn/trunk@10836 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10830 (Split SkDevice out of SkRasterDevice) until we can get Chromium ready.
robertphillips@google.com [Tue, 20 Aug 2013 20:06:40 +0000 (20:06 +0000)]
Revert r10830 (Split SkDevice out of SkRasterDevice) until we can get Chromium ready.

git-svn-id: http://skia.googlecode.com/svn/trunk@10835 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: check in pdfapi classes
edisonn@google.com [Tue, 20 Aug 2013 18:56:49 +0000 (18:56 +0000)]
pdfviewer: check in pdfapi classes

Review URL: https://codereview.chromium.org/22900010

git-svn-id: http://skia.googlecode.com/svn/trunk@10834 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd libpoppler for PDF rendering, take 2
commit-bot@chromium.org [Tue, 20 Aug 2013 18:57:01 +0000 (18:57 +0000)]
Add libpoppler for PDF rendering, take 2

R=vandebo@chromium.org, edisonn@google.com

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23301009

git-svn-id: http://skia.googlecode.com/svn/trunk@10833 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMove gpu conic calculations to GrPathUtils
commit-bot@chromium.org [Tue, 20 Aug 2013 17:55:43 +0000 (17:55 +0000)]
Move gpu conic calculations to GrPathUtils

BUG=
R=bsalomon@google.com, jvanverth@google.com

Author: egdaniel@google.com

Review URL: https://chromiumcodereview.appspot.com/22865023

git-svn-id: http://skia.googlecode.com/svn/trunk@10832 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd a GM to test the clipping of canvas layers.
djsollen@google.com [Tue, 20 Aug 2013 17:54:33 +0000 (17:54 +0000)]
Add a GM to test the clipping of canvas layers.

R=tomhudson@google.com

Review URL: https://codereview.chromium.org/22815012

git-svn-id: http://skia.googlecode.com/svn/trunk@10831 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSplit SkDevice out of SkBitmapDevice
robertphillips@google.com [Tue, 20 Aug 2013 17:49:04 +0000 (17:49 +0000)]
Split SkDevice out of SkBitmapDevice

https://codereview.chromium.org/22978012/

git-svn-id: http://skia.googlecode.com/svn/trunk@10830 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: remove text for pdf spec, in preparation to check-in only the PDF API.
edisonn@google.com [Tue, 20 Aug 2013 17:33:08 +0000 (17:33 +0000)]
pdfviewer: remove text for pdf spec, in preparation to check-in only the PDF API.

Review URL: https://codereview.chromium.org/22865024

git-svn-id: http://skia.googlecode.com/svn/trunk@10829 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "The CL adds libpoppler to DEPS and adds a libpoppler-cpp gyp target for Linux...
vandebo@chromium.org [Tue, 20 Aug 2013 17:06:22 +0000 (17:06 +0000)]
Revert "The CL adds libpoppler to DEPS and adds a libpoppler-cpp gyp target for Linux, Windows, and Mac. This does not currently change the GM tool to use poppler - that will be a refactor job in a separate CL."

This reverts commit r10823
TBR=richardlin@chromium.org

Review URL: https://codereview.chromium.org/23190020

git-svn-id: http://skia.googlecode.com/svn/trunk@10828 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoCHECK -> SKTDYNAMICHASH_CHECK, to avoid collision with CHECK in Chrome logging.
mtklein@google.com [Tue, 20 Aug 2013 17:03:02 +0000 (17:03 +0000)]
CHECK -> SKTDYNAMICHASH_CHECK, to avoid collision with CHECK in Chrome logging.

BUG=
R=robertphillips@google.com

Review URL: https://codereview.chromium.org/23172014

git-svn-id: http://skia.googlecode.com/svn/trunk@10827 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThird (and hopefully final) change to support bleed flag in Ganesh
robertphillips@google.com [Tue, 20 Aug 2013 16:51:20 +0000 (16:51 +0000)]
Third (and hopefully final) change to support bleed flag in Ganesh

https://codereview.chromium.org/23172013/

git-svn-id: http://skia.googlecode.com/svn/trunk@10826 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agouse SkTDynamicHash in picture recording
mtklein@google.com [Tue, 20 Aug 2013 16:48:47 +0000 (16:48 +0000)]
use SkTDynamicHash in picture recording

cleaned up SkPictureFlat.h quite a bit while working on this.

bench --match picture_record_ shows some improvement:
compare.sh bench --match picture_record_ --repeat 100
master -> usehash
N=3 p=0.001000 (corrected to 0.000333)
sig? rel. speed  bench
  y      1.0x  picture_record_dictionaries
  y      1.5x  picture_record_recurring_paint_dictionary
  y      3.8x  picture_record_unique_paint_dictionary
Overall relative speed:   1.9x

bench_pictures --record is pretty much neutral:
compare.sh bench_pictures -r ../skp --mode record --repeat 30
master -> usehash
N=63 p=0.001000 (corrected to 0.000016)
sig? rel. speed  bench
  n      0.9x  desk_pokemonwiki.skp
  y      0.9x  desk_googlespreadsheet.skp
  y      0.9x  tabl_pravda.skp
  y      1.0x  desk_googlespreadsheetdashed.skp
  n      1.0x  tabl_onlinewsj.skp
  n      1.0x  tabl_nytimes.skp
  n      1.0x  desk_googlehome.skp
  y      1.0x  desk_techcrunch.skp
  n      1.0x  tabl_slashdot.skp
  n      1.0x  tabl_techmeme.skp
  n      1.0x  desk_googleplus.skp
  n      1.0x  desk_sfgate.skp
  n      1.0x  tabl_transformice.skp
  n      1.0x  desk_espn.skp
  n      1.0x  desk_baidu.skp
  n      1.0x  tabl_worldjournal.skp
  n      1.0x  desk_chalkboard.skp
  n      1.0x  tabl_frantzen.skp
  n      1.0x  desk_gws.skp
  n      1.0x  tabl_androidpolice.skp
  n      1.0x  desk_linkedin.skp
  n      1.0x  mobi_wikipedia.skp
  n      1.0x  desk_wowwiki.skp
  n      1.0x  desk_css3gradients.skp
  n      1.0x  desk_gmailthread.skp
  n      1.0x  desk_yahoogames.skp
  n      1.0x  desk_facebook.skp
  n      1.0x  desk_wordpress.skp
  n      1.0x  tabl_vnexpress.skp
  n      1.0x  desk_br337.skp
  n      1.0x  tabl_engadget.skp
  n      1.0x  tabl_theverge.skp
  n      1.0x  desk_amazon.skp
  n      1.0x  desk_ebay.skp
  n      1.0x  tabl_hsfi.skp
  n      1.0x  tabl_sahadan.skp
  n      1.0x  desk_weather.skp
  n      1.0x  tabl_digg.skp
  n      1.0x  desk_youtubetvbrowse.skp
  n      1.0x  tabl_culturalsolutions.skp
  n      1.0x  tabl_ukwsj.skp
  n      1.0x  desk_youtube.skp
  n      1.0x  tabl_googlecalendar.skp
  y      1.0x  desk_yahooanswers.skp
  n      1.0x  desk_blogger.skp
  n      1.0x  desk_yahoonews.skp
  y      1.0x  desk_yahoosports.skp
  y      1.0x  tabl_mercurynews.skp
  n      1.0x  desk_youtubetvvideo.skp
  y      1.0x  tabl_gspro.skp
  y      1.1x  tabl_googleblog.skp
  y      1.1x  tabl_cnet.skp
  y      1.1x  tabl_mlb.skp
  y      1.1x  tabl_cuteoverload.skp
  y      1.1x  desk_booking.skp
  y      1.1x  tabl_deviantart.skp
  y      1.1x  desk_twitter.skp
  y      1.1x  tabl_cnn.skp
  y      1.1x  tabl_gamedeksiam.skp
  y      1.1x  tabl_gmail.skp
  y      1.1x  tabl_nofolo.skp
  y      1.1x  tabl_mozilla.skp
  y      1.1x  desk_pinterest.skp
Overall relative speed:   1.0x

(I'd take this to mean that the microbenches are probably drifting away from relevance.)
BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/21564008

git-svn-id: http://skia.googlecode.com/svn/trunk@10825 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThe CL adds libpoppler to DEPS and adds a libpoppler-cpp gyp target for Linux, Window...
commit-bot@chromium.org [Tue, 20 Aug 2013 16:34:34 +0000 (16:34 +0000)]
The CL adds libpoppler to DEPS and adds a libpoppler-cpp gyp target for Linux, Windows, and Mac. This does not currently change the GM tool to use poppler - that will be a refactor job in a separate CL.

Several third-party libraries are pulled in, and platform-specific headers are included under third_party/(library name). Chromium style READMEs containing a description of the library, as well as a LICENSE file are also included in that directory. (is there a Skia-specific style for these?)

R=vandebo@chromium.org, edisonn@google.com, djsollen@chromium.org, bungeman@chromium.org, open-source-third-party-reviews@google.com, thestig@chromium.org

Author: richardlin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/20220002

git-svn-id: http://skia.googlecode.com/svn/trunk@10823 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoTweak Matrix44 test so it'll pass on ChromeOS
commit-bot@chromium.org [Tue, 20 Aug 2013 16:28:42 +0000 (16:28 +0000)]
Tweak Matrix44 test so it'll pass on ChromeOS

BUG=
R=robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/23093008

git-svn-id: http://skia.googlecode.com/svn/trunk@10822 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove base-* directories from gm expected/actual paths; just use platform names
epoger@google.com [Tue, 20 Aug 2013 16:21:55 +0000 (16:21 +0000)]
Remove base-* directories from gm expected/actual paths; just use platform names
BUG=skia:1512

The buildbot master continues to set gm_image_subdir, but the slaves no longer
use that component when building GM paths (they just use builder_name instead).
But gm_image_subdir is still used for SKP storage paths under
gs://chromium-skia-gm/playback/gm-actual , for now...

Immediately before committing this CL, I will copy the actual-results.json files
from their old locations to their new locations (within the skia-autogen repo)
so that both old and new versions of rebaseline.py will be able to retrieve
actual results, like so:

svn cp base-android-galaxy-nexus/Test-Android-GalaxyNexus-SGX540-Arm7-Debug/base-android-galaxy-nexus Test-Android-GalaxyNexus-SGX540-Arm7-Debug
svn cp base-android-galaxy-nexus/Test-Android-GalaxyNexus-SGX540-Arm7-Release/base-android-galaxy-nexus Test-Android-GalaxyNexus-SGX540-Arm7-Release
svn cp base-android-nexus-10/Test-Android-Nexus10-MaliT604-Arm7-Debug/base-android-nexus-10 Test-Android-Nexus10-MaliT604-Arm7-Debug
...
svn cp base-shuttle-win7-intel-float/Test-Win7-ShuttleA-HD2000-x86-Debug/base-shuttle-win7-intel-float Test-Win7-ShuttleA-HD2000-x86-Debug
svn cp base-shuttle-win7-intel-float/Test-Win7-ShuttleA-HD2000-x86-Release/base-shuttle-win7-intel-float Test-Win7-ShuttleA-HD2000-x86-Release

Once we see this CL land successfully, I will delete the actual-results.json
files from their OLD location within skia-autogen, like so:

svn rm base-android-galaxy-nexus
svn rm base-android-nexus-10
...
svn rm base-shuttle-win7-intel-directwrite
svn rm base-shuttle-win7-intel-float

R=borenet@google.com, rmistry@google.com

Review URL: https://codereview.chromium.org/23120002

git-svn-id: http://skia.googlecode.com/svn/trunk@10821 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate renderable configs for ES3
commit-bot@chromium.org [Tue, 20 Aug 2013 15:25:21 +0000 (15:25 +0000)]
Update renderable configs for ES3

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23301008

git-svn-id: http://skia.googlecode.com/svn/trunk@10819 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake SkMatrix44::invert() check for finite 1/det instead of magic value
commit-bot@chromium.org [Tue, 20 Aug 2013 15:25:04 +0000 (15:25 +0000)]
Make SkMatrix44::invert() check for finite 1/det instead of magic value

Previously we were checking to see if the magnitude of
determinant of the matrix to be inverted was less than
1.0e-8, which is a magic number possibly plucked from
Graphics Gems. After some discussion, it's been determined
(ha) that we can simply check to see if 1/det is finite and
if so proceed.

BUG=222926

Committed: http://code.google.com/p/skia/source/detail?r=10758

R=reed@google.com, shawnsingh@chromium.org

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/22904003

git-svn-id: http://skia.googlecode.com/svn/trunk@10818 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRe-enable fontscaler GM for Android
commit-bot@chromium.org [Tue, 20 Aug 2013 15:24:27 +0000 (15:24 +0000)]
Re-enable fontscaler GM for Android

R=bsalomon@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/22262002

git-svn-id: http://skia.googlecode.com/svn/trunk@10817 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix stack buffer read overflow in GrConvolutionEffect::TestCreate.
bungeman@google.com [Tue, 20 Aug 2013 15:20:34 +0000 (15:20 +0000)]
Fix stack buffer read overflow in GrConvolutionEffect::TestCreate.

BUG=skia:1532
R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/23340003

git-svn-id: http://skia.googlecode.com/svn/trunk@10816 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange comments about size internal formats
commit-bot@chromium.org [Tue, 20 Aug 2013 15:12:01 +0000 (15:12 +0000)]
Change comments about size internal formats

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22912007

git-svn-id: http://skia.googlecode.com/svn/trunk@10815 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd direct bezier cubic support for GPU shaders
commit-bot@chromium.org [Tue, 20 Aug 2013 14:45:45 +0000 (14:45 +0000)]
Add direct bezier cubic support for GPU shaders

BUG=
R=bsalomon@google.com, jvanverth@google.com, robertphillips@google.com

Author: egdaniel@google.com

Review URL: https://chromiumcodereview.appspot.com/22900007

git-svn-id: http://skia.googlecode.com/svn/trunk@10814 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10788 (allow both GDI and DW fontmgrs at the same time) due to Chromium XP...
robertphillips@google.com [Tue, 20 Aug 2013 14:36:59 +0000 (14:36 +0000)]
Revert r10788 (allow both GDI and DW fontmgrs at the same time) due to Chromium XP bot failures

git-svn-id: http://skia.googlecode.com/svn/trunk@10813 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFinal rebaselines for r10769.
jvanverth@google.com [Tue, 20 Aug 2013 14:31:59 +0000 (14:31 +0000)]
Final rebaselines for r10769.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10812 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Changed rules about sized internal formats on GLES3."
bsalomon@google.com [Tue, 20 Aug 2013 13:48:33 +0000 (13:48 +0000)]
Revert "Changed rules about sized internal formats on GLES3."

This reverts commit r10806.

git-svn-id: http://skia.googlecode.com/svn/trunk@10811 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix merge problem between r10805 and 10803
robertphillips@google.com [Tue, 20 Aug 2013 12:28:23 +0000 (12:28 +0000)]
Fix merge problem between r10805 and 10803

git-svn-id: http://skia.googlecode.com/svn/trunk@10810 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd correctness test to bbh_shootout.
commit-bot@chromium.org [Tue, 20 Aug 2013 12:23:18 +0000 (12:23 +0000)]
Add correctness test to bbh_shootout.

R=caryclark@google.com, reed@google.com

Author: sglez@google.com

Review URL: https://chromiumcodereview.appspot.com/23121002

git-svn-id: http://skia.googlecode.com/svn/trunk@10809 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace uses of GR_API by SK_API.
commit-bot@chromium.org [Tue, 20 Aug 2013 12:23:06 +0000 (12:23 +0000)]
Replace uses of GR_API by SK_API.

R=bsalomon@google.com, robertphillips@google.com

Author: tfarina@chromium.org

Review URL: https://chromiumcodereview.appspot.com/22881005

git-svn-id: http://skia.googlecode.com/svn/trunk@10808 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agodefault to device type of last build if no device type is given
djsollen@google.com [Tue, 20 Aug 2013 12:22:57 +0000 (12:22 +0000)]
default to device type of last build if no device type is given

R=borenet@google.com

Review URL: https://codereview.chromium.org/22929006

git-svn-id: http://skia.googlecode.com/svn/trunk@10807 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChanged rules about sized internal formats on GLES3.
commit-bot@chromium.org [Tue, 20 Aug 2013 12:22:48 +0000 (12:22 +0000)]
Changed rules about sized internal formats on GLES3.

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22823006

git-svn-id: http://skia.googlecode.com/svn/trunk@10806 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix name of "bleed" flag
robertphillips@google.com [Tue, 20 Aug 2013 12:13:48 +0000 (12:13 +0000)]
Fix name of "bleed" flag

https://codereview.chromium.org/22812014/

git-svn-id: http://skia.googlecode.com/svn/trunk@10805 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix for nested rect drawing bug
robertphillips@google.com [Tue, 20 Aug 2013 12:11:31 +0000 (12:11 +0000)]
Fix for nested rect drawing bug

https://codereview.chromium.org/22824016/

git-svn-id: http://skia.googlecode.com/svn/trunk@10804 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUpdate tiled bitmap path to respect bleed flag
robertphillips@google.com [Tue, 20 Aug 2013 12:09:32 +0000 (12:09 +0000)]
Update tiled bitmap path to respect bleed flag

https://codereview.chromium.org/23261003/

git-svn-id: http://skia.googlecode.com/svn/trunk@10803 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Tue, 20 Aug 2013 07:01:14 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10802 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRemove unused typedef.
bungeman@google.com [Mon, 19 Aug 2013 21:28:18 +0000 (21:28 +0000)]
Remove unused typedef.

git-svn-id: http://skia.googlecode.com/svn/trunk@10801 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix size_t to int conversion warning on Win64 in SkRTConf.h.
bungeman@google.com [Mon, 19 Aug 2013 20:05:38 +0000 (20:05 +0000)]
Fix size_t to int conversion warning on Win64 in SkRTConf.h.

Review URL: https://codereview.chromium.org/23213004

git-svn-id: http://skia.googlecode.com/svn/trunk@10800 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRefer to the correct file for rebaselining benches.
scroggo@google.com [Mon, 19 Aug 2013 18:51:32 +0000 (18:51 +0000)]
Refer to the correct file for rebaselining benches.

The file has moved, so update the instructions in the
expectations file.

R=bensong@google.com

Review URL: https://codereview.chromium.org/23033009

git-svn-id: http://skia.googlecode.com/svn/trunk@10799 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoadd new GM to try to reproduce a bug
mtklein@google.com [Mon, 19 Aug 2013 18:43:34 +0000 (18:43 +0000)]
add new GM to try to reproduce a bug

BUG=7671058
R=djsollen@google.com

Review URL: https://codereview.chromium.org/23299004

git-svn-id: http://skia.googlecode.com/svn/trunk@10798 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoskia: Added SkDiscardableMemory interface.
scroggo@google.com [Mon, 19 Aug 2013 18:38:08 +0000 (18:38 +0000)]
skia: Added SkDiscardableMemory interface.

Chrome's implementation of SkDiscardableMemory is provided here:
https://codereview.chromium.org/23206002. SkDiscardableMemory is
intended to be used for image caching.

R=reed@google.com, scroggo@google.com, hclam@chromium.org, jamesr@chromium.org
BUG=229120

Author=ernstm@chromium.org

Submitted on behalf of ernstm@chromium.org due to commit queue bug.

Review URL: https://codereview.chromium.org/22950012

git-svn-id: http://skia.googlecode.com/svn/trunk@10797 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAdd libraries to fix Ubuntu13 Clang build
borenet@google.com [Mon, 19 Aug 2013 18:26:04 +0000 (18:26 +0000)]
Add libraries to fix Ubuntu13 Clang build

R=bungeman@google.com, djsollen@google.com

Review URL: https://codereview.chromium.org/23281003

git-svn-id: http://skia.googlecode.com/svn/trunk@10796 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test bots
borenet@google.com [Mon, 19 Aug 2013 17:30:50 +0000 (17:30 +0000)]
Whitespace change to test bots

Review URL: https://codereview.chromium.org/23331002

git-svn-id: http://skia.googlecode.com/svn/trunk@10794 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWhitespace change to test the new master.
rmistry@google.com [Mon, 19 Aug 2013 13:35:47 +0000 (13:35 +0000)]
Whitespace change to test the new master.

git-svn-id: http://skia.googlecode.com/svn/trunk@10793 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Sat, 17 Aug 2013 07:01:54 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10790 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoReplace uses of GrAssert by SkASSERT.
tfarina@chromium.org [Sat, 17 Aug 2013 00:02:59 +0000 (00:02 +0000)]
Replace uses of GrAssert by SkASSERT.

R=bsalomon@google.com

Review URL: https://codereview.chromium.org/22850006

git-svn-id: http://skia.googlecode.com/svn/trunk@10789 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoallow both GDI and DW fontmgrs at the same time
bungeman@google.com [Fri, 16 Aug 2013 20:31:11 +0000 (20:31 +0000)]
allow both GDI and DW fontmgrs at the same time

BUG=
R=bungeman@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10718

Review URL: https://codereview.chromium.org/23058002

git-svn-id: http://skia.googlecode.com/svn/trunk@10788 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoWin7 performance trigger rebaseline
robertphillips@google.com [Fri, 16 Aug 2013 19:48:40 +0000 (19:48 +0000)]
Win7 performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10787 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFixes for factory GM.
commit-bot@chromium.org [Fri, 16 Aug 2013 19:18:12 +0000 (19:18 +0000)]
Fixes for factory GM.

Skip cross process pipe playback in gm/factory.cpp. Add a new flag to
gm.h to skip only this form of pipe playback.

In gmmain.cpp, use a bitmap encoder function for serialization that
stores the encoded data if present, and use a bitmap decoder on
deserialization. This allows gm/factory to work through serialization.
Also respect the new pipe skipping flag.

BUG=https://code.google.com/p/skia/issues/detail?id=1231
R=borenet@google.com

Author: scroggo@google.com

Review URL: https://chromiumcodereview.appspot.com/23192004

git-svn-id: http://skia.googlecode.com/svn/trunk@10786 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAlways support NPOT tiling/MIPs on ES3
commit-bot@chromium.org [Fri, 16 Aug 2013 18:13:48 +0000 (18:13 +0000)]
Always support NPOT tiling/MIPs on ES3

R=jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22887022

git-svn-id: http://skia.googlecode.com/svn/trunk@10784 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: remove one #include to STL, that is not needed
edisonn@google.com [Fri, 16 Aug 2013 17:37:31 +0000 (17:37 +0000)]
pdfviewer: remove one #include to STL, that is not needed

Review URL: https://codereview.chromium.org/23082004

git-svn-id: http://skia.googlecode.com/svn/trunk@10783 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore rebaselines for r10769.
jvanverth@google.com [Fri, 16 Aug 2013 17:07:20 +0000 (17:07 +0000)]
More rebaselines for r10769.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10782 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: fix typo in sample app
edisonn@google.com [Fri, 16 Aug 2013 17:01:24 +0000 (17:01 +0000)]
pdfviewer: fix typo in sample app

Review URL: https://codereview.chromium.org/22861007

git-svn-id: http://skia.googlecode.com/svn/trunk@10781 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: update interface of derived canvas and device, to reflect lastest changes...
edisonn@google.com [Fri, 16 Aug 2013 16:30:02 +0000 (16:30 +0000)]
pdfviewer: update interface of derived canvas and device, to reflect lastest changes in the interfaces.

Review URL: https://codereview.chromium.org/23048006

git-svn-id: http://skia.googlecode.com/svn/trunk@10780 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: (cleanup) put the gyp for library code in a separate file
edisonn@google.com [Fri, 16 Aug 2013 16:13:44 +0000 (16:13 +0000)]
pdfviewer: (cleanup) put the gyp for library code in a separate file

Review URL: https://codereview.chromium.org/23038004

git-svn-id: http://skia.googlecode.com/svn/trunk@10779 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoAlways support pack/unpack row length on ES3. Add support for NV_pack_subimage extension.
commit-bot@chromium.org [Fri, 16 Aug 2013 16:12:23 +0000 (16:12 +0000)]
Always support pack/unpack row length on ES3. Add support for NV_pack_subimage extension.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/23003009

git-svn-id: http://skia.googlecode.com/svn/trunk@10778 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoChange Atlas recycling to track current flush count and recycle if Atlas not used...
commit-bot@chromium.org [Fri, 16 Aug 2013 15:53:46 +0000 (15:53 +0000)]
Change Atlas recycling to track current flush count and recycle if Atlas not used in current flush.

BUG=
R=bsalomon@google.com, robertphillips@google.com

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/23120004

git-svn-id: http://skia.googlecode.com/svn/trunk@10777 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSupport VAO when on ES3.
commit-bot@chromium.org [Fri, 16 Aug 2013 15:53:33 +0000 (15:53 +0000)]
Support VAO when on ES3.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://chromiumcodereview.appspot.com/22909015

git-svn-id: http://skia.googlecode.com/svn/trunk@10776 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMore rebaselines for r10769.
jvanverth@google.com [Fri, 16 Aug 2013 15:44:52 +0000 (15:44 +0000)]
More rebaselines for r10769.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10775 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFirst set of rebaselines for r10769.
jvanverth@google.com [Fri, 16 Aug 2013 15:32:23 +0000 (15:32 +0000)]
First set of rebaselines for r10769.

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10774 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agopdfviewer: code cleanup - remove STL usage
edisonn@google.com [Fri, 16 Aug 2013 15:05:08 +0000 (15:05 +0000)]
pdfviewer: code cleanup - remove STL usage

Review URL: https://codereview.chromium.org/23258004

git-svn-id: http://skia.googlecode.com/svn/trunk@10772 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoUbuntu flaky performance trigger rebaseline
robertphillips@google.com [Fri, 16 Aug 2013 15:01:03 +0000 (15:01 +0000)]
Ubuntu flaky performance trigger rebaseline

(SkipBuildbotRuns)

git-svn-id: http://skia.googlecode.com/svn/trunk@10770 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoFix hairline pathrenderer for Nexus-10. Switches to using additional
jvanverth@google.com [Fri, 16 Aug 2013 14:51:51 +0000 (14:51 +0000)]
Fix hairline pathrenderer for Nexus-10. Switches to using additional
geometry and passing in the coverage value instead.

BUG=

Committed: http://code.google.com/p/skia/source/detail?r=10640

Committed: http://code.google.com/p/skia/source/detail?r=10707

R=bsalomon@google.com, robertphillips@google.com

Review URL: https://codereview.chromium.org/22486003

git-svn-id: http://skia.googlecode.com/svn/trunk@10769 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agomore rebaselines of convexpaths
bsalomon@google.com [Fri, 16 Aug 2013 13:16:01 +0000 (13:16 +0000)]
more rebaselines of convexpaths

git-svn-id: http://skia.googlecode.com/svn/trunk@10766 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis CL plumbs in the drawBitmapRectToRect "bleed" flag and makes it live on the...
commit-bot@chromium.org [Fri, 16 Aug 2013 10:24:37 +0000 (10:24 +0000)]
This CL plumbs in the drawBitmapRectToRect "bleed" flag and makes it live on the simplest GPU path.

R=bsalomon@google.com, reed@google.com, edisonn@google.com, scroggo@google.com, jvanverth@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/20806003

git-svn-id: http://skia.googlecode.com/svn/trunk@10765 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoSanitizing source files in Housekeeper-Nightly
skia.committer@gmail.com [Fri, 16 Aug 2013 07:01:49 +0000 (07:01 +0000)]
Sanitizing source files in Housekeeper-Nightly

git-svn-id: http://skia.googlecode.com/svn/trunk@10764 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoPatch for r10762
robertphillips@google.com [Fri, 16 Aug 2013 01:01:01 +0000 (01:01 +0000)]
Patch for r10762

git-svn-id: http://skia.googlecode.com/svn/trunk@10763 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis CL addresses "SkCanvas::save flags are not respected by GPU backend" (https...
commit-bot@chromium.org [Fri, 16 Aug 2013 00:53:34 +0000 (00:53 +0000)]
This CL addresses "SkCanvas::save flags are not respected by GPU backend" (https://code.google.com/p/skia/issues/detail?id=1503).

R=reed@google.com, bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/22947003

git-svn-id: http://skia.googlecode.com/svn/trunk@10762 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoThis bench attempts to recreate Chromium's Canvas_putImageData performance test to...
commit-bot@chromium.org [Fri, 16 Aug 2013 00:40:34 +0000 (00:40 +0000)]
This bench attempts to recreate Chromium's Canvas_putImageData performance test to track down https://code.google.com/p/chromium/issues/detail?id=270649.

Cranking the repitition count up to 500 on a MacPro yields:

WITHOUT 10624:
running bench [640 480]            writepix_rgba_UPM  8888: cmsecs = 748.25   GPU: cmsecs = 225.95 gmsecs = 244.80
running bench [640 480]             writepix_rgba_PM  8888: cmsecs =  54.12   GPU: cmsecs = 225.77 gmsecs = 244.59

WITH 10624:
running bench [640 480]            writepix_rgba_UPM  8888: cmsecs = 747.70   GPU: cmsecs = 230.30 gmsecs = 249.51
running bench [640 480]             writepix_rgba_PM  8888: cmsecs =  55.05   GPU: cmsecs = 230.13 gmsecs = 249.38

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://chromiumcodereview.appspot.com/22895012

git-svn-id: http://skia.googlecode.com/svn/trunk@10761 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert "Make SkMatrix44::invert() check for finite 1/det instead of magic value"
scroggo@google.com [Thu, 15 Aug 2013 23:53:11 +0000 (23:53 +0000)]
Revert "Make SkMatrix44::invert() check for finite 1/det instead of magic value"

This reverts commit f109b4ac6ef21ccb8b76891e50e63dae820af116.

git-svn-id: http://skia.googlecode.com/svn/trunk@10760 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoRevert r10718 to unblock roll
robertphillips@google.com [Thu, 15 Aug 2013 22:42:54 +0000 (22:42 +0000)]
Revert r10718 to unblock roll

git-svn-id: http://skia.googlecode.com/svn/trunk@10759 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoMake SkMatrix44::invert() check for finite 1/det instead of magic value
commit-bot@chromium.org [Thu, 15 Aug 2013 21:56:38 +0000 (21:56 +0000)]
Make SkMatrix44::invert() check for finite 1/det instead of magic value

Previously we were checking to see if the magnitude of determinant of the
matrix to be inverted was less than 1.0e-8, which is a magic number possibly
plucked from Graphics Gems. After some discussion, it's been determined (ha)
that we can simply check to see if 1/det is finite and if so proceed.

BUG=222926
R=reed@google.com, shawnsingh@chromium.org

Author: jvanverth@google.com

Review URL: https://chromiumcodereview.appspot.com/22904003

git-svn-id: http://skia.googlecode.com/svn/trunk@10758 2bbb7eff-a529-9590-31e7-b0007b416f81

11 years agoNobody defines SK_SUPPORT_HINTING_SCALE_FACTOR any more, so remove it.
mtklein@google.com [Thu, 15 Aug 2013 21:20:14 +0000 (21:20 +0000)]
Nobody defines SK_SUPPORT_HINTING_SCALE_FACTOR any more, so remove it.

I left the dummy value in the flattened paint.  I'm hoping to do an overhaul of
the paint serialization format which will need a picture version bump anyway,
so it can all go together.  If that doesn't pan out we can remove this on its
own later.

BUG=
R=reed@google.com

Review URL: https://codereview.chromium.org/23056005

git-svn-id: http://skia.googlecode.com/svn/trunk@10757 2bbb7eff-a529-9590-31e7-b0007b416f81