Martin Fleisz [Wed, 12 Feb 2020 09:16:54 +0000 (10:16 +0100)]
Merge pull request #5857 from akallabeth/scanbuild_fixes
Scanbuild fixes
Martin Fleisz [Tue, 11 Feb 2020 11:58:10 +0000 (12:58 +0100)]
Merge pull request #5877 from akallabeth/urbdrc_export_symbol_fix
Urbdrc export symbol fix
Armin Novak [Tue, 11 Feb 2020 11:41:07 +0000 (12:41 +0100)]
Exporting URBDRC symbols used by helper library
When building the usb channel with different shared libraries some
necessary symbols were not exported.
David Fort [Mon, 10 Feb 2020 13:57:46 +0000 (14:57 +0100)]
Merge pull request #5875 from akallabeth/smartcard_missing_null_check
Fix #5847: Missing length check to trace smartcard buffers.
Kobi Mizrachi [Tue, 4 Feb 2020 12:51:47 +0000 (14:51 +0200)]
core: server: fix a bad free in channel->queue cleanup
Armin Novak [Mon, 10 Feb 2020 13:28:38 +0000 (14:28 +0100)]
Fix #5847: Missing length check to trace smartcard buffers.
Martin Fleisz [Mon, 10 Feb 2020 11:08:55 +0000 (12:08 +0100)]
Merge pull request #5865 from akallabeth/write_cancelled_leak
Fix #5852: handle CHANNEL_EVENT_WRITE_CANCELLED
Martin Fleisz [Mon, 10 Feb 2020 09:40:55 +0000 (10:40 +0100)]
Merge pull request #5869 from llyzs/winmm_fixes
rdpsnd/winmm: fix some memory issues.
Kobi Mizrachi [Tue, 28 Jan 2020 13:36:21 +0000 (15:36 +0200)]
server: proxy: improve logs
David Fort [Fri, 7 Feb 2020 13:11:00 +0000 (14:11 +0100)]
Merge pull request #5830 from akallabeth/smartcard_updates
Smartcard updates
Vic Lee [Tue, 4 Feb 2020 09:56:07 +0000 (17:56 +0800)]
rdpsnd/winmm: fix some memory issues.
Armin Novak [Wed, 29 Jan 2020 07:52:25 +0000 (08:52 +0100)]
Fix #5852: handle CHANNEL_EVENT_WRITE_CANCELLED
When channels are cleaned up OpenHandle is most of the time
already 0. Ignore the argument checks for
CHANNEL_EVENT_WRITE_CANCELLED and CHANNEL_EVENT_WRITE_COMPLETE
only check where actually required (CHANNEL_EVENT_DATA_RECEIVED)
Armin Novak [Thu, 16 Jan 2020 10:31:13 +0000 (11:31 +0100)]
FreeRDP_WTSVirtualChannelOpen unify channel new/free
Kobi Mizrachi [Thu, 16 Jan 2020 09:25:43 +0000 (11:25 +0200)]
server: make sure all messages in channel->queue are freed when queue is freed
Kobi Mizrachi [Mon, 27 Jan 2020 06:23:28 +0000 (08:23 +0200)]
server: proxy: show indicative log on bind failure.
Armin Novak [Fri, 24 Jan 2020 12:41:27 +0000 (13:41 +0100)]
Added unified NDR pointer reading.
Armin Novak [Fri, 24 Jan 2020 12:23:40 +0000 (13:23 +0100)]
Fixed missing length checks for smartcard IRP read.
Martin Fleisz [Thu, 23 Jan 2020 14:39:28 +0000 (15:39 +0100)]
Merge pull request #5859 from mfleisz/multi_trans_fix
core: Always send CS_MULTITRANSPORT PDU to server
Martin Fleisz [Thu, 23 Jan 2020 14:16:14 +0000 (15:16 +0100)]
core: Always send CS_MULTITRANSPORT PDU to server
This PDU is required by Microsoft servers in order for bandwidth
management to work correctly. Even if we do not support multi-transport
for now we should just send a PDU with flags set to 0 to enable correct
handing of bandwidth measurement PDUs.
Armin Novak [Thu, 23 Jan 2020 09:50:37 +0000 (10:50 +0100)]
Fixed rdpei unused function warning.
Armin Novak [Thu, 23 Jan 2020 09:39:43 +0000 (10:39 +0100)]
Fixed smartcard type mismatches.
Armin Novak [Thu, 23 Jan 2020 08:21:22 +0000 (09:21 +0100)]
Fixed type of index variables.
Armin Novak [Thu, 23 Jan 2020 08:21:06 +0000 (09:21 +0100)]
Fixed type of index variable.
Armin Novak [Thu, 23 Jan 2020 08:20:33 +0000 (09:20 +0100)]
Fixed unused variable warning.
Armin Novak [Thu, 23 Jan 2020 08:20:08 +0000 (09:20 +0100)]
Fixed copy of opaque data
do not use strcncpy for opaque data.
Armin Novak [Thu, 23 Jan 2020 08:19:48 +0000 (09:19 +0100)]
Fixed unused argument warnings.
Armin Novak [Thu, 23 Jan 2020 08:09:35 +0000 (09:09 +0100)]
Added NULL checks to silence clang-scanbuild.
Armin Novak [Thu, 23 Jan 2020 08:06:19 +0000 (09:06 +0100)]
Fixed NULL dereference.
Armin Novak [Thu, 23 Jan 2020 07:55:47 +0000 (08:55 +0100)]
Fixed NULL dereference.
Armin Novak [Thu, 23 Jan 2020 07:53:40 +0000 (08:53 +0100)]
Fixed NULL dereference.
Armin Novak [Thu, 23 Jan 2020 09:07:54 +0000 (10:07 +0100)]
Unified smartcart multistring conversion.
Armin Novak [Thu, 23 Jan 2020 08:48:20 +0000 (09:48 +0100)]
Fixed type mismatches on allocation.
Armin Novak [Thu, 23 Jan 2020 08:32:34 +0000 (09:32 +0100)]
Fixed smartcard_SetAttrib_Decode call type
Martin Fleisz [Thu, 23 Jan 2020 07:30:11 +0000 (08:30 +0100)]
Merge pull request #5856 from akallabeth/neon_ycocg
Fixed #5855: YCoCg to RGB conversion color order
Armin Novak [Wed, 22 Jan 2020 16:28:22 +0000 (17:28 +0100)]
Fixed #5855: YCoCg to RGB conversion color order
Martin Fleisz [Wed, 22 Jan 2020 12:13:51 +0000 (13:13 +0100)]
core: Fix and extend populate rdp file from settings
This PR contains the following changes:
- Get rid of unused SettingsModified array (kept in the settings struct for ABI
compatibility)
- Fix and extend freerdp_client_populate_rdp_file_form_settings (wrote <null> strings to the rdp file, missed a lot of settings)
- Set KeyboardHook default value to 2 (hook in fullscreen) just as mstsc
does
Kobi Mizrachi [Tue, 21 Jan 2020 12:56:49 +0000 (14:56 +0200)]
server: proxy: specify which modules to load in config
Kobi Mizrachi [Tue, 21 Jan 2020 12:55:55 +0000 (14:55 +0200)]
cmdline: export CommandLineParseCommaSeparatedValues
Martin Fleisz [Tue, 21 Jan 2020 14:19:10 +0000 (15:19 +0100)]
Merge pull request #5851 from akallabeth/multi_disconnect_crash_fix
Fixed missing NULL set of pointer after free
Armin Novak [Tue, 21 Jan 2020 13:40:33 +0000 (14:40 +0100)]
Fixed missing NULL set of pointer after free
Due to this double free was possible if disconnect_and_clear was
called multiple times.
Kobi Mizrachi [Tue, 21 Jan 2020 09:02:12 +0000 (11:02 +0200)]
server: proxy: add an indicative log listener->Open fails. fixes #5850
Kobi Mizrachi [Mon, 20 Jan 2020 10:27:01 +0000 (12:27 +0200)]
server: proxy: pf_client.c: remove unused includes
Kobi Mizrachi [Sun, 19 Jan 2020 09:51:34 +0000 (11:51 +0200)]
server: proxy: disconnect all active sessions on shutdown
Kobi Mizrachi [Sun, 19 Jan 2020 09:03:27 +0000 (11:03 +0200)]
Revert "core: rdp: reset rdp->nla in rdp_reset"
This reverts commit
205b0fba7fb92b4db7bb0fbdac7550564e48cd0e.
Kobi Mizrachi [Tue, 21 Jan 2020 07:15:46 +0000 (09:15 +0200)]
server: proxy: modules_init: create modules dir if not exists
Kobi Mizrachi [Tue, 21 Jan 2020 07:15:11 +0000 (09:15 +0200)]
server: proxy: update config.ini
Martin Fleisz [Fri, 17 Jan 2020 12:02:31 +0000 (13:02 +0100)]
rdpsnd: Add synchronization to winmm backend
Martin Fleisz [Thu, 16 Jan 2020 14:46:17 +0000 (15:46 +0100)]
Merge pull request #5844 from akallabeth/gfx_fix
Gfx fix disconnect reorder
Armin Novak [Thu, 16 Jan 2020 14:30:33 +0000 (15:30 +0100)]
Fixed #5843 wrong header length for pdu
@boom1 reported encomsp_send_change_participant_control_level_pdu
fails due to wrong length.
Armin Novak [Thu, 16 Jan 2020 14:23:35 +0000 (15:23 +0100)]
Fixed accidental reorder of surface delete and disconnect
Martin Fleisz [Wed, 15 Jan 2020 12:04:25 +0000 (13:04 +0100)]
rdpsnd: Fix possible crash and deadlock in winmm backend
Martin Fleisz [Wed, 15 Jan 2020 10:23:59 +0000 (11:23 +0100)]
audin: Fix possible crash in winmm backend
Martin Fleisz [Thu, 16 Jan 2020 09:17:10 +0000 (10:17 +0100)]
Merge pull request #5841 from akallabeth/vaapi_fixes
Vaapi fixes
Martin Fleisz [Thu, 16 Jan 2020 09:13:26 +0000 (10:13 +0100)]
Merge pull request #5836 from kubistika/proxy/fix_rail_and_update_issues
fixes: rail and update issues
Martin Fleisz [Thu, 16 Jan 2020 09:02:15 +0000 (10:02 +0100)]
Merge pull request #5783 from akallabeth/gfx_mask_arg
Added /gfx and /gfx-h264 option mask=<value>
Armin Novak [Thu, 16 Jan 2020 08:53:57 +0000 (09:53 +0100)]
Fixed #5839: Use correct pointer to cast.
Armin Novak [Thu, 16 Jan 2020 08:53:39 +0000 (09:53 +0100)]
Add CMake config option for VAAPI
Kobi Mizrachi [Thu, 16 Jan 2020 07:07:50 +0000 (09:07 +0200)]
core: rdp: reset rdp->nla in rdp_reset
Alexander Volkov [Wed, 15 Jan 2020 11:32:08 +0000 (14:32 +0300)]
client/X11: Avoid crash in XGetDeviceButtonMapping()
XOpenDevice() may fail and return NULL, so try to find the first
pointer device that can be opened, and ensure that ptr_dev argument
is not NULL before passing it to XGetDeviceButtonMapping().
David Fort [Wed, 15 Jan 2020 12:56:00 +0000 (13:56 +0100)]
Merge pull request #5750 from akallabeth/encomsp_auto
Encomsp automatic input control && cleanups
Kobi Mizrachi [Wed, 15 Jan 2020 11:51:05 +0000 (13:51 +0200)]
rdpsnd: server: fix leak in rdpsnd_server_context_free
Kobi Mizrachi [Wed, 15 Jan 2020 10:11:24 +0000 (12:11 +0200)]
server: update: made functions static
Kobi Mizrachi [Wed, 15 Jan 2020 09:20:54 +0000 (11:20 +0200)]
update: update_send_new_or_existing_window: fix signed/unsigned according to spec
Kobi Mizrachi [Wed, 15 Jan 2020 09:18:45 +0000 (11:18 +0200)]
server: update: call update_check_flush whenever using the reused update buffer
David Fort [Wed, 15 Jan 2020 09:49:53 +0000 (10:49 +0100)]
Merge pull request #5831 from akallabeth/drdynvc_error_tolerance
Ignore dynamic virtual channel errors
David Fort [Wed, 15 Jan 2020 09:49:09 +0000 (10:49 +0100)]
Merge pull request #5835 from akallabeth/planar_chroma_subsample
Implemented chroma subsampling for planar non RLE
Kobi Mizrachi [Wed, 15 Jan 2020 09:15:06 +0000 (11:15 +0200)]
server: proxy: fix race condition when between client thread and server update thread
Armin Novak [Tue, 14 Jan 2020 16:46:13 +0000 (17:46 +0100)]
Fixed remaining issues with chroma subsampling.
Armin Novak [Tue, 14 Jan 2020 16:45:20 +0000 (17:45 +0100)]
Fixed inverted color formats in YCoCgRToRGB_8u_AC4R
Armin Novak [Tue, 14 Jan 2020 14:14:40 +0000 (15:14 +0100)]
Fixed planar size checks.
Armin Novak [Tue, 14 Jan 2020 13:23:43 +0000 (14:23 +0100)]
Enabled YCoCg for planar.
Armin Novak [Tue, 14 Jan 2020 12:22:45 +0000 (13:22 +0100)]
Added planar RLE chroma subsampling.
Armin Novak [Tue, 14 Jan 2020 11:17:12 +0000 (12:17 +0100)]
Implemented chroma subsampling for planar non RLE
Planar frames that are not RLE encoded can now be decoded if
chroma subsampling is enabled. Partly fixes #5822
Kobi Mizrachi [Tue, 14 Jan 2020 09:02:04 +0000 (11:02 +0200)]
server: proxy: fix pf_modules_init
David Fort [Tue, 14 Jan 2020 09:17:13 +0000 (10:17 +0100)]
Merge pull request #5796 from akallabeth/rdp_10_7_large_pointers
Added RDP 10.7 large pointer support
Kobi Mizrachi [Mon, 13 Jan 2020 10:30:09 +0000 (12:30 +0200)]
server: proxy: do not compile modules by default
Kobi Mizrachi [Tue, 31 Dec 2019 13:52:33 +0000 (15:52 +0200)]
server: proxy: shutdown gracefully
Kobi Mizrachi [Tue, 31 Dec 2019 09:16:12 +0000 (11:16 +0200)]
server: proxy: rewrite modules API
* Add support for C++ plugins.
* Seperate between a "module" and a "plugin": a module is a shared
library that exposes a function called "proxy_module_entry_point". This
function gets a parameter to `proxyPluginsManager*`, which can be used to
register plugins.
* Refine the API of the modules infrastructure:
* use proxyData* instead of rdpContext* when firing a hook or calling a filter.
* use clearer names.
* Instead of having to specify a path for each module to be loaded in
the configuration, the proxy now loads modules from specificed
directory, using the CMAKE variable PROXY_PLUGINDIR.
* Add an option to specify required plugins: plugins that the proxy
wouldn't start without having them fully loaded.
Kobi Mizrachi [Tue, 31 Dec 2019 11:15:00 +0000 (13:15 +0200)]
winpr: collections: add ArrayList_ForEach
Kobi Mizrachi [Mon, 30 Dec 2019 08:08:26 +0000 (10:08 +0200)]
rail/server: rename rdpContext to rdpcontext
Fixes a compilation error when mixing c++ and c code.
Armin Novak [Mon, 16 Dec 2019 06:53:35 +0000 (07:53 +0100)]
Added /gfx and /gfx-h264 option mask=<value>
With this new option the gfx capability set can be masked to only
announce older versions of the protocol if required.
(Fixes #5771)
Martin Fleisz [Mon, 13 Jan 2020 14:41:59 +0000 (15:41 +0100)]
Merge pull request #5832 from akallabeth/libusb_doc_misleading
Libusb doc misleading
Armin Novak [Mon, 13 Jan 2020 14:23:57 +0000 (15:23 +0100)]
Added fallback for libusb < 1.0.19
we use stream_id functions which were introduced with 1.0.19
Armin Novak [Mon, 13 Jan 2020 14:13:35 +0000 (15:13 +0100)]
Fixed LIBUSB_HOTPLUG_NO_FLAGS definition
libusb documentation is a bit misleading, this flag was
introduced with 1.0.20
Kobi Mizrachi [Sun, 5 Jan 2020 05:54:26 +0000 (07:54 +0200)]
rdpgfx: client: fix leak when using rdpgfx_client_context_new API
Kobi Mizrachi [Thu, 2 Jan 2020 13:48:13 +0000 (15:48 +0200)]
server: fix leak in WTSCloseServer
make sure every pending message that wouldn't be handled because the
server is closing, will be free()ed as expected.
Kobi Mizrachi [Tue, 31 Dec 2019 13:47:03 +0000 (15:47 +0200)]
fix memory leaks in disp server and gfx.c
Kobi Mizrachi [Thu, 2 Jan 2020 13:19:08 +0000 (15:19 +0200)]
server: proxy: fix leak in pf_context_copy_settings
David Fort [Fri, 10 Jan 2020 16:11:50 +0000 (17:11 +0100)]
winpr: don't close file descriptor if we set it again to the same file
Martin Fleisz [Mon, 13 Jan 2020 11:26:31 +0000 (12:26 +0100)]
Merge pull request #5752 from akallabeth/manpage_no_err
Allow to generate docbook with 0 length.
Armin Novak [Mon, 13 Jan 2020 11:23:30 +0000 (12:23 +0100)]
Ignore dynamic virtual channel errors
If a dynamic virtual channel can not process a message, ignore it.
Armin Novak [Mon, 13 Jan 2020 09:51:22 +0000 (10:51 +0100)]
Implement missing functions for new smartcard
Newer smartcard channel behaviour expects a lot more callbacks
being implemented. This change provides them.
Armin Novak [Mon, 13 Jan 2020 09:50:14 +0000 (10:50 +0100)]
Added command line option client-build-number
The smartcard channel behaviour is influenced by what build number
is announced, expose this setting to modify by interested users.
Armin Novak [Mon, 13 Jan 2020 09:49:22 +0000 (10:49 +0100)]
Fix smartcard structs, conform to [MS-RDPESC]
Martin Fleisz [Fri, 10 Jan 2020 11:00:24 +0000 (12:00 +0100)]
Merge pull request #5827 from akallabeth/nightly_fix
Extend LIBUSB_API_VERSION check
Armin Novak [Fri, 10 Jan 2020 09:52:23 +0000 (10:52 +0100)]
Extend LIBUSB_API_VERSION check
The define exists since 1.0.13, so to compensate for older also
check if the variable is defined.
Martin Fleisz [Fri, 10 Jan 2020 09:42:56 +0000 (10:42 +0100)]
Merge pull request #5824 from akallabeth/ntstatus_helper
Added NtStatus2Tag function to stringify NTSTATUS
Armin Novak [Thu, 9 Jan 2020 15:14:44 +0000 (16:14 +0100)]
Added NtStatus2Tag function to stringify NTSTATUS
For higher level applications it is easier to translate known
strings instead of error codes. this function allows
to retrieve known string identifiers that can be translated.
Signed-off-by: Armin Novak <armin.novak@thincast.com>
Martin Fleisz [Thu, 9 Jan 2020 13:53:07 +0000 (14:53 +0100)]
Merge pull request #5823 from akallabeth/set_transport_err
Set transport error on close
Armin Novak [Thu, 9 Jan 2020 09:35:49 +0000 (10:35 +0100)]
Setting optional last error on transport close
Signed-off-by: Armin Novak <armin.novak@thincast.com>