Kai Harms [Tue, 7 Nov 2017 10:11:29 +0000 (10:11 +0000)]
FreeRDP multimonitor: Use first command line element, then primary, then fallback to 0,0
David Fort [Mon, 6 Nov 2017 13:23:50 +0000 (14:23 +0100)]
Merge pull request #4210 from akallabeth/nla_errors_extended
Added additional NLA error mappings.
David Fort [Mon, 6 Nov 2017 10:25:48 +0000 (11:25 +0100)]
Merge pull request #4053 from akallabeth/ffmpeg_encoder
Implemented FFMPEG based encoder.
akallabeth [Mon, 6 Nov 2017 09:22:37 +0000 (10:22 +0100)]
Merge pull request #4200 from cedrozor/upstream-master
Windows client: refresh only updated region(s) instead of whole screen
akallabeth [Mon, 6 Nov 2017 09:02:07 +0000 (10:02 +0100)]
Merge pull request #4187 from hardening/multimon_fix
Multimonitor fix
Armin Novak [Mon, 6 Nov 2017 08:49:03 +0000 (09:49 +0100)]
Added additional NLA error mappings.
David Fort [Fri, 3 Nov 2017 20:34:18 +0000 (21:34 +0100)]
Merge pull request #4206 from akallabeth/x_window_title
X11 window title fix
Armin Novak [Tue, 31 Oct 2017 17:00:15 +0000 (18:00 +0100)]
X11 window title fix
Martin Fleisz [Tue, 31 Oct 2017 16:17:43 +0000 (17:17 +0100)]
Merge pull request #4205 from akallabeth/WIN32_FIND_DATA
Fixed #4199: ConvertFindDataAToW string length
Armin Novak [Tue, 31 Oct 2017 11:02:29 +0000 (12:02 +0100)]
Fixed #4199: ConvertFindDataAToW string length
akallabeth [Tue, 31 Oct 2017 14:36:22 +0000 (15:36 +0100)]
Merge pull request #4159 from aleksei-klv/dex
Optimized aFreeRDP for Samsung DeX
Martin Fleisz [Tue, 31 Oct 2017 10:42:58 +0000 (11:42 +0100)]
Merge pull request #4179 from akallabeth/android_cleanup_fix
[android] Ensure native session is disconnected before resource free.
Martin Fleisz [Tue, 31 Oct 2017 08:55:43 +0000 (09:55 +0100)]
Merge pull request #4204 from lunixoid/master
Fixed twice assigned values
Roman Kalashnikov [Mon, 30 Oct 2017 21:11:25 +0000 (00:11 +0300)]
Fixed twice assigned values
Mike Gilbert [Mon, 30 Oct 2017 16:29:58 +0000 (12:29 -0400)]
Merge pull request #4203 from floppym/mkdir-error
winpr: _IoCreateDeviceEx: fix mkdir error check
Mike Gilbert [Mon, 30 Oct 2017 00:26:53 +0000 (20:26 -0400)]
winpr: _IoCreateDeviceEx: fix mkdir error check
The mkdir(2) function returns 0 on success, and -1 on error.
This resolves an error in TestIoDevice when /tmp/.device/ does not
exist.
Bug: https://bugs.gentoo.org/635838
akallabeth [Mon, 30 Oct 2017 14:47:02 +0000 (15:47 +0100)]
Merge pull request #4201 from kakaroto/listener-unlink-bugfix
Do not delete the listener socket right after creating it.
David Fort [Sun, 29 Oct 2017 16:52:19 +0000 (17:52 +0100)]
Merge pull request #4202 from lunixoid/master
Static analyser issues
Roman Kalashnikov [Sat, 28 Oct 2017 08:59:23 +0000 (11:59 +0300)]
Update semaphore.c
Roman Kalashnikov [Fri, 27 Oct 2017 22:48:41 +0000 (01:48 +0300)]
Fixed Expression 'pComm != NULL' is always true
pComm was checked earlier in 1363 string:
`if (pComm == NULL)`
Roman Kalashnikov [Fri, 27 Oct 2017 22:46:06 +0000 (01:46 +0300)]
Fixed duplicated assigne
Youness Alaoui [Fri, 27 Oct 2017 18:38:35 +0000 (14:38 -0400)]
Do not delete the listener socket right after creating it.
The listener server socket file needs to be deleted before we bind it
otherwise it's an "address already in use" error. But it was getting
deleted after the bind, causing the file to disappear, and preventing
anyone from connecting to the listener socket since the socket stops
existing.
This is caused by commit
884e87fde4ece132c3b7bdf947de044ecb3d4b14
cedrozor [Fri, 27 Oct 2017 12:30:00 +0000 (14:30 +0200)]
fixed hdc initialization into wf_begin_paint so the region invalidation into wf_end_paint applies to the same hdc
the objective is that only the updated region(s) are refreshed instead of the whole screen
it's not much a problem for normal FreeRDP usage but becomes a serious issue if the display is processed, forwarded and rendered remotely, as done by web gateways such as Guacamole, FreeRDP-WebConnect and Myrtille (I'm the author of the latter)
Aleksei Kliuev [Thu, 26 Oct 2017 12:36:53 +0000 (15:36 +0300)]
remove temporary hack
David Fort [Wed, 25 Oct 2017 22:17:03 +0000 (00:17 +0200)]
Merge pull request #4198 from akallabeth/nla_error_fix
Added better error mapping for NEGO results.
Armin Novak [Wed, 25 Oct 2017 07:56:39 +0000 (09:56 +0200)]
Added better error mapping for NEGO results.
Armin Novak [Mon, 23 Oct 2017 07:48:52 +0000 (09:48 +0200)]
Fixed possible race condition on resource cleanup.
David Fort [Thu, 19 Oct 2017 11:15:04 +0000 (13:15 +0200)]
Merge pull request #4195 from nfedera/fix-sse3-yuv444pixel
primitives/yuv: fix endianess issue
Norbert Federa [Thu, 19 Oct 2017 09:55:13 +0000 (11:55 +0200)]
primitives/yuv: fix endianess issue
Norbert Federa [Wed, 18 Oct 2017 08:24:35 +0000 (10:24 +0200)]
Merge pull request #4190 from akallabeth/media_foundation_fix_win7
Removed unused function pointer
Armin Novak [Wed, 18 Oct 2017 07:52:41 +0000 (09:52 +0200)]
Removed unused function pointer
The function was breaking windows 7 compatibility.
Norbert Federa [Tue, 17 Oct 2017 19:33:16 +0000 (21:33 +0200)]
Merge pull request #4189 from nfedera/fix-h264-init
codec/h264: fix potential segfault and mf_init
Norbert Federa [Tue, 17 Oct 2017 17:28:54 +0000 (19:28 +0200)]
codec/h264: fix potential segfault and mf_init
David Fort [Tue, 17 Oct 2017 12:31:11 +0000 (14:31 +0200)]
multimon: flag the primary monitor according to the /monitors option
The first monitor of the list is considered like the primary monitor.
David Fort [Tue, 17 Oct 2017 12:07:23 +0000 (14:07 +0200)]
multimon: correctly set the primary monitor
According to the spec the primary monitor is supposed to be in (0,0) and other monitors
to be given relative to this one.
Armin Novak [Tue, 17 Oct 2017 07:12:27 +0000 (09:12 +0200)]
Added default return if instance not in list.
akallabeth [Mon, 16 Oct 2017 15:21:35 +0000 (17:21 +0200)]
Merge pull request #4177 from rjcorrig/tabfix
Android: Fix tab key mapping for hardware keyboard
Armin Novak [Fri, 13 Oct 2017 11:13:33 +0000 (13:13 +0200)]
Ensure native session is disconnected before resource free.
Robert Corrigan [Thu, 12 Oct 2017 16:56:34 +0000 (12:56 -0400)]
Fix tab key mapping for hardware keyboard
Martin Fleisz [Thu, 12 Oct 2017 10:12:43 +0000 (12:12 +0200)]
Merge pull request #4175 from akallabeth/time_fix
Fixed file timestamps.
Martin Fleisz [Thu, 12 Oct 2017 10:12:08 +0000 (12:12 +0200)]
Merge pull request #4172 from hardening/egfx_cache
egfx: fix disconnection caused by invalid cache entries due to wrong announced cache size
Armin Novak [Thu, 12 Oct 2017 09:27:32 +0000 (11:27 +0200)]
Fixed file timestamps.
David Fort [Tue, 10 Oct 2017 15:12:16 +0000 (17:12 +0200)]
egfx: fix disconnection caused by invalid cache entries due to wrong announced cache size
Added some checks so that when setting a cache entry fails, we close connection (or
we fail later when trying to use that empty entry).
The small cache egfx capability has also been fixed.
Martin Fleisz [Mon, 9 Oct 2017 11:25:41 +0000 (13:25 +0200)]
Merge pull request #4164 from akallabeth/ak/mac_audio_refactor
Pause playback on queue empty, free buffers on close.
akallabeth [Mon, 9 Oct 2017 07:19:19 +0000 (09:19 +0200)]
Merge pull request #4167 from bmiklautz/buildversion
feat: add support for .source_version
Bernhard Miklautz [Fri, 6 Oct 2017 13:02:46 +0000 (15:02 +0200)]
feat freerdp-nighlty/deb: create .source_version
Bernhard Miklautz [Fri, 6 Oct 2017 11:52:10 +0000 (13:52 +0200)]
feat: add support for .source_version
When building packages, especially when source packages are used, git is
not necessarily available or the source isn't provided in git. In those
cases it wasn't possible to set the GIT_REVISION and --version shows
"n/a" for the git revision.
If the file .source_version is available now the content of it is used
as GIT_REVISION. Packagers might want to add a .source_version file
when they don't build the packages from git.
Possible breaking change:
The variable PRODUCT_VERSION isn't available anymore. Use GIT_REVISION
instead.
Bernhard Miklautz [Thu, 5 Oct 2017 13:13:30 +0000 (15:13 +0200)]
Merge pull request #4162 from hardening/misc_fix2
Misc fix and improvements for the DR channel
Armin Novak [Thu, 5 Oct 2017 10:05:09 +0000 (12:05 +0200)]
Pause playback on queue empty, free buffers on close.
David Fort [Mon, 2 Oct 2017 19:28:02 +0000 (21:28 +0200)]
Add checks for DR channel
David Fort [Mon, 2 Oct 2017 18:57:27 +0000 (20:57 +0200)]
Fix for #4161
The checks were wrong, fix them.
Aleksei Kliuev [Tue, 19 Sep 2017 12:50:35 +0000 (15:50 +0300)]
fix crashing app in dex mode
Aleksei Kliuev [Mon, 11 Sep 2017 14:54:19 +0000 (17:54 +0300)]
fix right click
Aleksei Kliuev [Mon, 11 Sep 2017 11:23:28 +0000 (14:23 +0300)]
revert gradle
Aleksei Kliuev [Mon, 11 Sep 2017 11:03:30 +0000 (14:03 +0300)]
Add Samsung DeX support
akallabeth [Wed, 27 Sep 2017 12:56:21 +0000 (14:56 +0200)]
Merge pull request #4154 from hardening/misc_fixes
Fix raw surfaces displaying + misc other changes
akallabeth [Wed, 27 Sep 2017 09:14:39 +0000 (11:14 +0200)]
Merge pull request #4144 from bmiklautz/clipboardon
Enable clipboard channel per default
Bernhard Miklautz [Sat, 23 Sep 2017 13:16:17 +0000 (15:16 +0200)]
Enable clipboard channel per default
David Fort [Tue, 26 Sep 2017 07:21:28 +0000 (09:21 +0200)]
Fix displaying of raw surfaces
David Fort [Tue, 26 Sep 2017 07:20:38 +0000 (09:20 +0200)]
Check return value of malloc
David Fort [Tue, 26 Sep 2017 11:52:37 +0000 (13:52 +0200)]
Merge pull request #4156 from akallabeth/test_connect_extend_timeout
Added delay for connect abort
Armin Novak [Tue, 26 Sep 2017 10:03:57 +0000 (12:03 +0200)]
Added delay for connect abort
The connection abort must be called after freerdp_connect.
Ensure that this function is already running by waiting
a second.
David Fort [Tue, 26 Sep 2017 09:26:35 +0000 (11:26 +0200)]
Merge pull request #4155 from akallabeth/test_connect_extend_timeout
TestConnect: Extend timeout, only listen locally
Armin Novak [Tue, 26 Sep 2017 08:52:13 +0000 (10:52 +0200)]
TestConnect: Extend timeout, only listen locally
David Fort [Tue, 26 Sep 2017 07:40:30 +0000 (09:40 +0200)]
Merge pull request #4152 from akallabeth/dynamic_channel_test_fix
Dynamic channel test fix
Armin Novak [Mon, 25 Sep 2017 11:30:05 +0000 (13:30 +0200)]
Fixed TestConnect with dynamic channels.
Armin Novak [Mon, 25 Sep 2017 11:29:23 +0000 (13:29 +0200)]
Fixed client context setup with default initializer.
Armin Novak [Mon, 25 Sep 2017 11:28:16 +0000 (13:28 +0200)]
Fixed resizing of PubSub
David Fort [Mon, 25 Sep 2017 11:17:32 +0000 (13:17 +0200)]
Merge pull request #4150 from akallabeth/server_file_handle_leak
Unlink file after binding to it.
Armin Novak [Mon, 25 Sep 2017 08:35:24 +0000 (10:35 +0200)]
Unlink file after binding to it.
When unlinking the file before binding, a new entry is created
in the file system after binding. This is not desireable, so
unlink it after binding to remove the temporary file after the process
closes.
Bernhard Miklautz [Mon, 25 Sep 2017 07:35:49 +0000 (09:35 +0200)]
extend /size to allow width or height percentages (#4146)
If the size parameter is used with a percentages like /size:50% now
an additional 'w' or 'h' can be appended (like /size:50%w) to specify
where the percentage should be applied. If both or none are set the
behavior is like it was before and the percentage is applied to width
and height.
David Fort [Mon, 25 Sep 2017 07:33:58 +0000 (09:33 +0200)]
Merge pull request #4060 from akallabeth/icu_support
Using ICU instead of custom unicode conversion.
David Fort [Mon, 25 Sep 2017 07:12:35 +0000 (09:12 +0200)]
Merge pull request #4142 from bmiklautz/macOS
Fix build on macOS
David Fort [Mon, 25 Sep 2017 07:09:55 +0000 (09:09 +0200)]
Merge pull request #4143 from bmiklautz/pass_is_sc_pin
Add support for "password is pin"
Jukka-Pekka Virtanen [Sat, 23 Sep 2017 12:26:38 +0000 (14:26 +0200)]
Expose PasswordIsSmartcardPin settings from cmdline via password-is-pin arg
Jukka-Pekka Virtanen [Thu, 14 Sep 2017 10:34:09 +0000 (13:34 +0300)]
Using PasswordIsSmartcardPin option when sending TS_INFO_PACKET
Bernhard Miklautz [Sat, 23 Sep 2017 12:08:05 +0000 (14:08 +0200)]
macOS: add a README file
Add a README file containing some notes about building FreeRDP on macOS
related to openssl.
Bernhard Miklautz [Sat, 23 Sep 2017 11:57:57 +0000 (13:57 +0200)]
winpr/makecert: fix linking against libcrypto
Use OPENSSL_CRYPTO_LIBRARIES instead of linking against crypto directly.
Bernhard Miklautz [Sat, 23 Sep 2017 11:31:34 +0000 (13:31 +0200)]
macOS: add a workaround to build with newer SDKs
SDK 10.13 (and possibly olders as well) need HAVE_UNISTD_H to be set to
a value if available otherwise the following error is thrown:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk/usr/include/dispatch/dispatch.h:38:45:
error: expected value in expression #if !defined(HAVE_UNISTD_H) || HAVE_UNISTD_H
Bernhard Miklautz [Fri, 22 Sep 2017 15:22:00 +0000 (17:22 +0200)]
Merge pull request #4045 from akallabeth/drive_fixes_overlayfs
Drive fixes overlayfs
David Fort [Fri, 22 Sep 2017 07:52:27 +0000 (09:52 +0200)]
Merge pull request #4136 from tditsch/master
Fixed endless loop when RDP Server sends SERVER_DENIED_CONNECTION
Bernhard Miklautz [Thu, 21 Sep 2017 12:50:34 +0000 (14:50 +0200)]
Merge pull request #4116 from ChickenPeanut/patch-1
Fixed BadValue with XCreateWindow
Martin Fleisz [Tue, 19 Sep 2017 11:51:09 +0000 (13:51 +0200)]
Merge pull request #4138 from akallabeth/ak/nla_free_fix
Check and invalidate handles on free.
Armin Novak [Tue, 19 Sep 2017 10:33:33 +0000 (12:33 +0200)]
Check and invalidate handles on free.
tditsch [Tue, 19 Sep 2017 08:18:41 +0000 (10:18 +0200)]
refactored Bugfix
tditsch [Mon, 18 Sep 2017 15:29:16 +0000 (17:29 +0200)]
Fixed endless loop when RDP Server sends SERVER_DENIED_CONNECTION
Ondrej Holy [Mon, 18 Sep 2017 08:47:56 +0000 (10:47 +0200)]
Fix colors on big endian (#4135)
* client/x11: Fix colors on big endian
The bitmaps are recieved in little endian byte order (LSBFirst in terms
of X11). This is a problem on systems, where bitmaps are expected in big
endian byte order (MSBFirst). X11 client tries to handle this situation
by different color formats (e.g. RGBX vs. BGRX), but this doesn't work.
BGRX is not MSBFirst variant of RGBX, it should be XRGB. But this would
work only for 32/24 depths, where color channels matches bytes. Let's
say to the XServer that all the bitmaps are in LSBFirst encoding instead
of changing the color formats on big endian systems.
https://github.com/FreeRDP/FreeRDP/issues/2520
* client/x11: Fix cursor color on big endian
The cursor color is wrong on big endian systems. It is not probably
possible to force bitmap_order for XcursorImage as it is possible for
XImage. Fortunately, cursors are always 32 bit so we can use ABGR
instead of BGRA to deal with.
https://github.com/FreeRDP/FreeRDP/issues/2520
* client/x11: Fix comment indentation
The comment has wrong indentation for some reason, let's fix it.
* client/x11: Fix BGR vs. RGB detection
The BGR vs. RGB detection code is leftover from history and I am conviced
that it is wrong with the current color handling, where invert flag is TRUE
by default. However, I suppose that the detection still makes sense and
XServer may use the inverted formats in some cases. Maybe we can force XServer
to use our masks somehow, but let's just fix the value to FALSE now.
* client/x11: Remove unused color shifts
The color shifts are lefover from history and are not used in current
code. Let's remove them.
David Fort [Mon, 18 Sep 2017 08:17:43 +0000 (10:17 +0200)]
Merge pull request #4121 from ondrejholy/setsurface-segfault-fix
Various fixes from #4117
David Fort [Tue, 12 Sep 2017 21:16:39 +0000 (23:16 +0200)]
Merge pull request #4052 from akallabeth/mac_fixes
Mac drive fixes
MartinHaimberger [Mon, 11 Sep 2017 14:34:24 +0000 (16:34 +0200)]
Merge pull request #4127 from mfleisz/avc420
channels: Don't send gfx capversion 10 if AVC420 is requested
Martin Fleisz [Mon, 11 Sep 2017 10:05:03 +0000 (12:05 +0200)]
channels: Don't send gfx capversion 10 if AVC420 is requested
Ondrej Holy [Tue, 5 Sep 2017 08:25:15 +0000 (10:25 +0200)]
cache: Use Bitmap_Free instead of free
Bitmap_Alloc is used to allocate memory of bitmap, Bitmap_Free should
be used to release that memory. Let's change free to Bitmap_Free.
https://github.com/FreeRDP/FreeRDP/issues/4117
Ondrej Holy [Tue, 5 Sep 2017 07:56:00 +0000 (09:56 +0200)]
orders: Fix OFFSCREEN_DELETE_LIST allocation size
The size of OFFSCREEN_DELETE_LIST list allocation was incorrectly changed
by commit 99b1481 and consequently fixed incorrectly by commit
8a0fe086.
Let's count the allocation size based on new size and not based on current
size in order to prevent some memory issues.
https://github.com/FreeRDP/FreeRDP/issues/4117
Ondrej Holy [Tue, 5 Sep 2017 06:58:37 +0000 (08:58 +0200)]
orders: Fix ORDER_TYPE_GDIPLUS_END check
Commit 6fd03ab introduced security checks for orders, but
ORDER_TYPE_GDIPLUS_END check fails in case of success and vice versa.
Let's add the missing question mark.
https://github.com/FreeRDP/FreeRDP/issues/4117
Ondrej Holy [Mon, 4 Sep 2017 16:48:25 +0000 (18:48 +0200)]
cache: Check return value from offscreen_cache_get
Currently, SetSurface is called regardless of return value from
offscreen_cache_get. It may happen that bitmap is not found in a
cache from some reason, which may lead to segfaults. Let's check
the returned value before use.
https://github.com/FreeRDP/FreeRDP/issues/4117
Ondrej Holy [Mon, 4 Sep 2017 16:22:49 +0000 (18:22 +0200)]
client/X11: Check arguments in xf_Bitmap_SetSurface
Arguments of xf_Bitmap_SetSurface are not checked before use currently
which may lead to segfaults. It may happen if bitmap is not found in a
cache from some reason. Let's check the arguments before use similarly
as it is done in client/Windows/wf_graphics.c in order to avoid segfaults.
https://github.com/FreeRDP/FreeRDP/issues/4117
ChickenPeanut [Sun, 3 Sep 2017 22:52:34 +0000 (18:52 -0400)]
Fixed BadValue with XCreateWindow
xf_FixWindowCoordinates occasionally set the dimensions of the window to invalid values (0) because the minimum value check was done at the beginning of the method rather than at the end
David Fort [Thu, 31 Aug 2017 08:22:43 +0000 (10:22 +0200)]
Merge pull request #4079 from akallabeth/channel_pubsub_fix
Dynamic channel signal disconnect after the fact.
Armin Novak [Thu, 31 Aug 2017 07:57:49 +0000 (09:57 +0200)]
Removed unused variable.
Armin Novak [Thu, 31 Aug 2017 07:06:59 +0000 (09:06 +0200)]
Unified dynamic channel cleanup code.