sanghyeok.oh [Fri, 24 Apr 2020 06:16:54 +0000 (15:16 +0900)]
udev: Fix SIGABRT when receiving EventStop dbus call
fd from udev monitor has closed by deviced,
after that, udev_monitor_unref() tries to close it once more.
Change-Id: If18b828943961053ed2c2c463f4b66e848ba394f
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
sanghyeok.oh [Thu, 23 Apr 2020 11:44:19 +0000 (20:44 +0900)]
Remove ineffective function call
static const char *prev; maybe initialized with NULL value.
clean_lowbat_noti() at lowbat-notification.c just return with error log
if prev is NULL.
Change-Id: I6184fce01554c0cf404ba72d8879d4df6b3409a6
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Fri, 24 Apr 2020 01:21:50 +0000 (10:21 +0900)]
Fix to apply transit effect only for actual AOD
AOD screen might have been turned off by clock-viewer even though
ambient mode is enabled. (e.g. AOD screen is on while charging ->
battery state changes to full -> clock-viewer turns off AOD screen)
So apply brightness transit effect on LCDON only when AOD screen is
actually displayed.
Change-Id: Ib2e1f54c6caee3e23df23e5df1ee98a7da7e9aaa
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Fri, 24 Apr 2020 05:14:00 +0000 (14:14 +0900)]
Revert lcd off flag setting for ambient mode
Change-Id: I6ce0209fdaf1bd08dad0492a660fc97aca16b38a
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 22 Apr 2020 06:43:01 +0000 (15:43 +0900)]
Add charging threshold for aod brightness
Change-Id: I53ce24e65bb67bf7bf6dc7690748bcc7c6a5bf88
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 22 Apr 2020 03:42:13 +0000 (12:42 +0900)]
Handle duplicate request for autobrightnesschanged
Change-Id: Iea05470d925c3bb4cad6be355c914714056ea33e
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Tue, 26 May 2020 08:30:47 +0000 (17:30 +0900)]
Add missing condition
Change-Id: I13991f6a8ef4aad88f4805e2e4069e943ad7433e
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
lokilee73 [Wed, 20 May 2020 07:09:19 +0000 (16:09 +0900)]
Add lcddim in dbus_unlockstate
lcddim has to be added for mobile profile
Change-Id: I9b9a46abf233bfb33248d02ff8e3f9d2165924e5
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
lokilee73 [Mon, 20 Apr 2020 08:19:26 +0000 (17:19 +0900)]
Comment out code that doesn't work
battery.status_s is updated by uevent, POWER_SUPPLY_STATUS.
And it's always "Full" after target is fully charged,
Even though the target internally repeats charging and discharging.
So, to compare old_battery.status_s and battery.status_s is meaningless.
Change-Id: I5e8db11553c07be05b8dd9d0451b77c27e39745a
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
Youngjae Cho [Thu, 16 Apr 2020 04:15:43 +0000 (13:15 +0900)]
Support silent boot (Only for mobile)
Silent boot mode:
1. Prevent LCDON until booting done.
2. Prevent touchscreen to be enabled until booting done.
Silent boot condition is provided by device api, device_get_reboot_mode().
1. prevent LCDON
Reuse is_display_detached() to prevent lcdon in silent boot mode.
This function is originally intended to check lcd detachment not to
turn on lcd during it is detached.
Rename: is_display_detached() -> is_lcdon_blocked()
Now this function checks the additional condition - silent boot mode.
2. prevent enabling touchscreen
Do not enable touchscreen in touchscreen_start when silent boot mode
until booting done.
Change-Id: I2b46fd7f5d266f653e918f30f12a723c6b2acae7
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
lokilee73 [Wed, 8 Apr 2020 12:34:52 +0000 (21:34 +0900)]
Modify auto test related code to fix below issues.
1. Misc was not tested. So, add misc to test lists.
2. Add battery-monitor to all profile.
3. Add 's' to fix unmatched signature problem for power_supply
4. Change definition of PM_STATE_LOG_FILE to /var/log/pm_state.log.
5. Remove profile ivi from conf file. because it's not supported.
6. Change DD_LIST_FOREACH to DD_LIST_FOREACH_SAFE for safety.
7. Block not supported function, set_display_refreshrate.
8. Change test_battery_monitor_generate_many_sessions to fix corner case.
Change-Id: I356eca0042db8ef15bcd818a4ad5ceeb13edaf6e
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
Youngjae Cho [Thu, 9 Apr 2020 09:42:09 +0000 (18:42 +0900)]
Make notify BOOTING_DONE only once
Change-Id: I63e2c2536cc99b9399d6ad5432cb0ce6641e78ef
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Fri, 3 Apr 2020 04:55:35 +0000 (13:55 +0900)]
Separate lowbat noti into battery plugin
Lowbattery notification is used only for mobile. Separate this into
mobile battery plugin.
Change-Id: Iadbcc0beb986e13289719d4e43373551278fad2e
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Mon, 6 Apr 2020 09:59:14 +0000 (18:59 +0900)]
Fix memory leak
Change-Id: Ie6867273e859f2b8bf107d39afa62fad2cc19097
lokilee73 [Thu, 2 Apr 2020 12:48:18 +0000 (21:48 +0900)]
change g_variant_get() to dh_get_param_from_var()
to check data verification for below cases.
1. Returned value after dbus method sync
2. Received data via dbus signal
Change-Id: Ie6460d10567220a121fa532f3f294305dd9c0443
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
Youngjae Cho [Mon, 6 Apr 2020 01:47:00 +0000 (10:47 +0900)]
Fix build warning
Change-Id: Ie4bc28cc357ce5cc549dcf28708e2c2aed615896
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Sun, 5 Apr 2020 23:57:21 +0000 (08:57 +0900)]
Remove duplicaded code
Change-Id: I44e78fdbe0c033ce2972787a52392a48ba6fb91c
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Fri, 3 Apr 2020 04:23:18 +0000 (13:23 +0900)]
Locate right place for the DEVICE_NOTIFIER_LCD_OFF_COMPLETE
Change-Id: Iac31485f0cad441902dc05424b0d4bc8e234e5bd
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 1 Apr 2020 06:20:38 +0000 (15:20 +0900)]
Fix condition of battery charging noti
On battery changed, always call power_supply_noti depends on
changed charge_status. Repeated same power_supply_noti() call will
be ignored by power_supply_noti() itself. As a reusult, it works
only for the battery_status changing.
Change-Id: Ic49979cafe1f33a36f91f4831edcdcbb8f5ed839
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 2 Apr 2020 09:03:28 +0000 (18:03 +0900)]
Ignore lowbat_process before battery initializtion
Change battery.capacity initialization from -1 to 0 makes lowbat_process
unable to filter uninitialized battery state.
(refer:
a8338b3892e68e7ef046b76b7486cd9a329575ba)
Uninitialized state can be checked using
battery.online == POWER_SUPPLY_TYPE_UNKNOWN
Change-Id: I78a5843c1b615aeeabbe6f168c4fc036d885d720
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Hyotaek Shim [Wed, 1 Apr 2020 10:30:01 +0000 (19:30 +0900)]
Fix build errors with new linux-glibc-devel
Change-Id: Iff40ebb4e8e6b1dd3c1597a74dd80adc25682305
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Youngjae Cho [Wed, 1 Apr 2020 04:07:03 +0000 (13:07 +0900)]
Use format specifier %#x for hexadecimal value
%#x automatically prefixes '0x' to a hexadecimal value
Change-Id: If9b8a872008dce81f3a18dd03cc250f889ea21f2
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 1 Apr 2020 03:25:54 +0000 (12:25 +0900)]
Add '0x' prefix to hexadecimal log
Change-Id: Iff3032390ea5e9d58a693852764091084b2c627d
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 1 Apr 2020 00:52:57 +0000 (09:52 +0900)]
Move homescreen signal handler
display-dbus.c -> ambient-mode.c
Change-Id: I297a17cbe7fcdd44ea36f5051603304bdfe69eb5
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Tue, 31 Mar 2020 08:21:32 +0000 (17:21 +0900)]
Battery level vconf should be updated regardless of capacity
Change-Id: I71bdbd4423d87d7bc3277d7761c6f08f294ab477
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Tue, 31 Mar 2020 07:48:22 +0000 (16:48 +0900)]
Add shutdown scenario for lowbat during charging
If the battery continues to run out even though it is being charged for
a certain period of time, turn off the device.
Change-Id: Ieebd03bf43202201d3f1e619f553ec77d3928332
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Mon, 30 Mar 2020 07:46:08 +0000 (16:46 +0900)]
Fix abnormal battery popup to be started every 1 min
Change-Id: Ie654d19b921d3e3dc1f4536b418046498961ee21
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Fri, 27 Mar 2020 07:16:25 +0000 (16:16 +0900)]
Turn on display on changing Battery state Full->Charging
AOD should be turned on when charging. To turn on AOD, turning on
display must be preceded.
Change-Id: I15daafd02892be97a8d2403dbf0deb83ee68a4ac
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Mon, 30 Mar 2020 09:18:03 +0000 (18:18 +0900)]
Fix PMQOS dbus initialization error
Move dbus_handle_add_dbus_object() from booting_done() to pmqos_init().
As booting_done is called twice, dbus_handle_add_dbus_object() is called
twice too, and it causes error.
E/DEVICED ( 336): pmqos.c: booting_done(471) > Failed to init dbus method: -1
Change-Id: I5c91a5b1e8725d79f7bcec6d23b23013f8184687
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Tue, 31 Mar 2020 02:00:54 +0000 (11:00 +0900)]
Fix late_booting_done timer: milisecond->second
Change-Id: I735148a5cf1cfdbcfc581f893dbd6ccad0996b88
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
lokilee73 [Mon, 30 Mar 2020 05:06:47 +0000 (14:06 +0900)]
Add devicectl command to set lcd on/off for internal purpose
ex) devicectl display state lcdon/lcdoff
Change-Id: I6f2acfeb48c30650245dbebf53433efe2aedf5fe
Signed-off-by: lokilee73 <changjoo.lee@samsung.com>
Youngjae Cho [Mon, 30 Mar 2020 07:21:02 +0000 (16:21 +0900)]
Remove lowbat scenario: critical -> warning
When battery capacity increases from 5% to 6%, lowbat scenario launches
lowbat warning popup. This is somewhat weird as this popup occurs while
charging state. So remove this scenario.
Change-Id: I31b6b1040c8274f6b9fb907e605a6cc32e08e493
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 26 Mar 2020 05:52:06 +0000 (14:52 +0900)]
Fix DUMP_MODE_WAITING_TIME
Change-Id: I3afe10aca08030bc2ca20f37d98a8e7f641d51de
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 26 Mar 2020 05:26:56 +0000 (14:26 +0900)]
Fix timeout unit to match up with timer function
Change-Id: I7e99c58a8c09f196b86c818729307198aef39616
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 26 Mar 2020 03:30:55 +0000 (12:30 +0900)]
Fix g_timeout_add_seconds with double type timeout
Use g_timeout_add instead with milisecond scale.
Change-Id: I60630308cf2e1588d2ec7b0c78202d483f8d96b8
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 26 Mar 2020 01:21:46 +0000 (10:21 +0900)]
Add vconf set for charger type
Change-Id: I83a35de22a2e5df90b2921be6077d49033ff1ddc
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Sun, 22 Mar 2020 23:30:36 +0000 (08:30 +0900)]
Remove unused sources
It has been moved to libsyscommon.
Change-Id: I8f9241b359905ae71caf935803f083f040f21a3c
Hyotaek Shim [Wed, 25 Mar 2020 06:15:12 +0000 (15:15 +0900)]
Do not apply GrayScale during UltraPowerSaving
Change-Id: Icc2c412cfeed9c5afd7688ff10cbd790c21c4305
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Youngjae Cho [Wed, 25 Mar 2020 05:23:47 +0000 (14:23 +0900)]
Fix AutoBrightnessChanged considering interaction with AOD
Change-Id: I5fb69c70dc75b28b83e438fb37f5d781089c6d2a
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Tue, 24 Mar 2020 05:42:16 +0000 (14:42 +0900)]
Fix build warning
Change-Id: I0bd73a9473bd4fd6763a8f16b24d0995707a0d7b
Youngjae Cho [Tue, 24 Mar 2020 06:10:52 +0000 (15:10 +0900)]
Add signal broadcast on display detach
Path : /Org/Tizen/System/DeviceD/Display
Interface : org.tizen.system.deviced.display
Signal name : display_detach
Change-Id: I31b38b6c389565ccd0df27d26578c28971c5d5eb
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Mon, 23 Mar 2020 04:12:13 +0000 (13:12 +0900)]
Fix build warning
Change-Id: Ib52902400185d7ea9ed6c7b2094e9c8eee441f13
sanghyeok.oh [Fri, 6 Dec 2019 13:02:19 +0000 (22:02 +0900)]
auto-test: init test for battery-monitor
Change-Id: I273cfb7c15da79b82ee60cb81df83aff49c4a66c
Signed-off-by: sanghyeok.oh <sanghyeok.oh@samsung.com>
Hyotaek Shim [Fri, 20 Mar 2020 08:21:33 +0000 (08:21 +0000)]
Merge "Apply dbus sync call to devicectl (Dumpmode, SaveLog)" into tizen
Youngjae Cho [Fri, 20 Mar 2020 01:26:16 +0000 (10:26 +0900)]
Initialize battery.capacity to 0
Change-Id: If36d9691a98be9e32907602cce26ffaca77baffa
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Hyotaek Shim [Fri, 20 Mar 2020 04:04:11 +0000 (13:04 +0900)]
Apply dbus sync call to devicectl (Dumpmode, SaveLog)
Change-Id: Id13ffd344c7600068da351fb0d9b0c09303b37f8
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Youngjae Cho [Fri, 20 Mar 2020 03:37:04 +0000 (12:37 +0900)]
Change log priority
Change-Id: I769f74865d18961d2806426b940e2760e2bdae5a
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 19 Mar 2020 09:24:14 +0000 (18:24 +0900)]
Remove unused code: sim_signal_hanlder()
Change-Id: I1e33a45f8f0150e8f671152da1a1b05c38218538
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 19 Mar 2020 08:43:26 +0000 (17:43 +0900)]
Move PM_DEFAULT_BRIGHTNESS into display_conf
All profiles have used PM_DEFAULT_BRIGHTNESS as a same value of 80,
but now the wearable profile is changed to use 70. So move this
information into each profile's display_conf and delete the macro.
And fixed related code.
Change-Id: I4207bb88173aee3f6769c8c64ec616799f1c1b48
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Thu, 12 Mar 2020 23:55:50 +0000 (08:55 +0900)]
Move battery status backup after checking is done
Sometimes, battery status is changed quickly, previous status does
not stored at backup structure. so move them after checking is done.
Change-Id: I0ee56f035a74eadea40b5747aff0ac8e3896deea
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Wed, 18 Mar 2020 03:27:45 +0000 (12:27 +0900)]
Add poweroff stage to clarify poweroff sequence
POWEROFF_DEFAULT
- Default stage, poweroff has not been triggered
POWEROFF_TRIGGERED
- Poweroff is triggered. Wait timer can be added up to this stage
POWEROFF_WAIT_OTHERS
- Wait for other processes to clean up their resources
Change-Id: Iaf744a624c230a3d0ffc588aa60138264f184c72
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Semun Lee [Tue, 17 Mar 2020 08:10:10 +0000 (17:10 +0900)]
remove unused code
It creates unncessary noise in static analyzers
Change-Id: I269efd772f54794b584c99eb224a4f1ba502f2e2
Signed-off-by: Semun Lee <semun.lee@samsung.com>
INSUN PYO [Mon, 16 Mar 2020 08:48:27 +0000 (17:48 +0900)]
Modify usb debug message
Change-Id: I0a3c558221010674a489d9d196db76b0f3d7a96a
Youngjae Cho [Mon, 16 Mar 2020 08:00:18 +0000 (17:00 +0900)]
Fix display plugin load error
Add dummy is_display_detached() for mobile, iot, tv to resolve undefined
symbol error.
Change-Id: I4ed5eb1565a5afff119e9d7c40a2b385744ad92c
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Mon, 16 Mar 2020 03:54:43 +0000 (12:54 +0900)]
Fix SIGCHLD handling
Don't treat ECHILD as an error case as it means this SIGCHLD had
already been handled somewhere else.
Change-Id: I115c942b5ec616bf21873e806b6f97add959f054
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Yunmi Ha [Thu, 12 Mar 2020 07:30:35 +0000 (16:30 +0900)]
Fix sound issue when wireless charger is attached
Change-Id: I683c51ff038d283afcd626021c4fd14c535b638a
Signed-off-by: Yunmi Ha <yunmi.ha@samsung.com>
Youngjae Cho [Fri, 6 Mar 2020 05:50:16 +0000 (14:50 +0900)]
Prohibit turning on display when display has been detached
Kernel set lcd_power node to 5 when display is detached. If the node's
value is 5, deviced should ignore lcd on request. To this end, add
return statement at the point that can be the entry of the LCDON
procedure. Below are the functions that can be a beginning of LCDON.
- __pm_change_internal
- default_trans
- default_action
- lcd_on_direct
- lcd_on_procedure
- dbus_changestatebyreason
- dbus_changestate
- dbus_customlcdon
- switch_on_lcd
Change-Id: Ibee6139dede213dbcde715c928a2df64c3757324
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Thu, 12 Mar 2020 03:11:18 +0000 (12:11 +0900)]
Remove unused gloable variable info
Change-Id: I01f584f4ea75afa96fc8d628d9d8f0812442faf9
INSUN PYO [Wed, 11 Mar 2020 23:43:19 +0000 (08:43 +0900)]
Fixed using NULL string in gvariant
$ dbus-send --type=method_call --print-reply --reply-timeout=1000 --system --dest=org.tizen.system.deviced /Org/Tizen/System/DeviceD/Board org.tizen.system.deviced.Board.GetSerial
method return time=
946688500.085742 sender=:1.56 -> destination=:1.107 serial=39 reply_serial=2
string "[Invalid UTF-8]"
int32 -95
Change-Id: Iff775727ee31278c445929477217457c67b7a7da
INSUN PYO [Tue, 10 Mar 2020 04:19:18 +0000 (13:19 +0900)]
Fix memory leak
Change-Id: Ieff593d532ec1522849af8c27f119e235b6d68f6
Hyotaek Shim [Wed, 11 Mar 2020 11:15:53 +0000 (20:15 +0900)]
Fix lowbat_execute() timer to keep the last one
Change-Id: I434fb580ff90e2b5bcdd78d6fc7bede495954eb3
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Youngjae Cho [Wed, 11 Mar 2020 05:06:16 +0000 (14:06 +0900)]
Add timer to ignore discharging signal from kernel
Change-Id: Ib6e495c4515fe193b2e38332d818621e8d03a26a
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Wed, 11 Mar 2020 04:42:24 +0000 (13:42 +0900)]
Remove the duplicated usb_client->disable() function.
Change-Id: Idf5a5e321facd206f3f7cac3e1b9cf8509f8b9b9
Youngjae Cho [Tue, 10 Mar 2020 09:02:20 +0000 (18:02 +0900)]
Introduce 3 level AOD brightness
Change-Id: Iae0ca878f7702e72cccf9ff54f26da59e3b3e78e
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Hyotaek Shim [Tue, 10 Mar 2020 11:58:45 +0000 (20:58 +0900)]
Remove VCONFKEY_SETAPPL_AMBIENT_MODE_BOOL
replaced by "db/starter/always_on_display"
Change-Id: Ie2b756eb9ed5e963ea6127a3d4000eeb99fde61b
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Youngjae Cho [Tue, 10 Mar 2020 05:36:27 +0000 (14:36 +0900)]
Change vconfkey about ambient condition
Change-Id: I8411394a2f2317374a503349a0bea095b78051d4
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Tue, 10 Mar 2020 02:22:01 +0000 (11:22 +0900)]
Move checking current usb mode to usb_change_mode
Change-Id: I96cab5ebc7647cadda4e93c5f7b6ce025b4caafb
Youngjae Cho [Tue, 10 Mar 2020 01:36:25 +0000 (10:36 +0900)]
Change bezel state when vconf changes in LCDOFF
Change-Id: I3209c2b1c797d47420acffe4e2dbc93426662dc3
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Tue, 10 Mar 2020 01:49:41 +0000 (10:49 +0900)]
Improve handling of the usb debug mode
debug on + rndis on : USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_RNDIS
debug on + rndis off : USB_FUNCTION_MTP | USB_FUNCTION_ACM | USB_FUNCTION_SDB
debug off + rndis on : USB_FUNCTION_RNDIS
debug off + rndis off : USB_FUNCTION_MTP | USB_FUNCTION_ACM
Change-Id: I917efe98e4ed0e722efb938cb809116cba8001d9
INSUN PYO [Tue, 10 Mar 2020 00:36:48 +0000 (09:36 +0900)]
Improve handling of the usb tethering mode
On: Use predefined mode (USB_FUNCTION_ACM | USB_FUNCTION_SDB | USB_FUNCTION_RNDIS)
Off: Use predefined mode (USB_FUNCTION_MTP | USB_FUNCTION_ACM) + USB_FUNCTION_SDB(conditional)
Caution: If usb debug menu was enabled, add USB_FUNCTION_SDB to new mode to use.
When tethering is enabled, additionally enable usb debug(USB_FUNCTION_SDB) unconditionally.
Since usb debug is always enabled when you turn off usb tethering, there is no way to know if usb debug was enabled or not.
So before enabling usb tethering, save the previous state.
This saved value is used to check if the debug menu was enabled or not when you turn off usb tethering.
In addition, if someone changes the usb mode while tethering on,
use the latest usb mode to determine the usb debug mode instead of using the saved value.
Change-Id: I20cf762f4d45b96cd7142cf3e6e43a402213a415
Youngjae Cho [Mon, 9 Mar 2020 09:28:44 +0000 (18:28 +0900)]
Add additional conditions for bezel wakeup
(UX improvement for DND mode)
If every or either of the two vconf keys below is true,
- VCONFKEY_SETAPPL_THEATER_MODE_ENABLE
- VCONFKEY_SETAPPL_GOODNIGHT_MODE_ENABLE
disables bezel wakeup even if bezel wakeup is turned on.
Change-Id: I96d40593dd5ca6ae6e2bb7d7fa9feb13ad59568c
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Fri, 6 Mar 2020 11:07:56 +0000 (20:07 +0900)]
Fix dbus_getbrightness to consider pm_cur_state
Change-Id: I52ba74786246d399ddd915e90e03bf089a205817
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Fri, 6 Mar 2020 07:19:54 +0000 (16:19 +0900)]
Rearrange the send_usb_state_changed_event code when usb_change_mode is called
Change-Id: I5b890d82c78b1739a93e55880f0ae7e59135e7db
Youngjae Cho [Thu, 5 Mar 2020 08:26:14 +0000 (17:26 +0900)]
Turn off display when display is detached
Change-Id: I09a203694da1af7bb564cf4faa5839c119839b21
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Thu, 5 Mar 2020 23:50:32 +0000 (08:50 +0900)]
Fixed the vconf values in usb debug mode and usb selected mode to always match
1. When usb mode is changed, debug mode should be 1 if sdb is enabled and 0 if disabled.
2. If sdb is enabled in selected mode when deviced starts, enable debug mode; otherwise disable.
Change-Id: I8b85bc2d31c0febfccf844619b6ad53a160161ac
INSUN PYO [Thu, 5 Mar 2020 03:51:49 +0000 (12:51 +0900)]
Fix to shutdown usb0 interface when USB cable is disconnected in rndis mode
When the usb cable is disconnected, it just disables the gadget, but keeps the gadget's configuration.
So usb0 is left and rndis.service fails the next time you plug the usb cable.
Change-Id: I4245f4cbfcc71b6f42dd9332de2b6e7f564e1358
INSUN PYO [Wed, 4 Mar 2020 07:44:13 +0000 (16:44 +0900)]
Remove duplicate code and clean up in usb module
usb_config_init and usb_change_gadget are duplicated with the exact same code.
Change-Id: Ie3899df4ccb8d2c861b9af80ed4e652e7bb7a489
Hyotaek Shim [Wed, 4 Mar 2020 07:55:51 +0000 (16:55 +0900)]
Fix critical log for long lasting lock
Change-Id: Ibd9d1e8bbf5e0409f5879614d46f90f795c5b68a
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
Hyotaek Shim [Wed, 4 Mar 2020 07:43:06 +0000 (16:43 +0900)]
Add is_app() as a common api
Change-Id: I5d195ffea25602af85276145a41a4d849696e7d8
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Wed, 4 Mar 2020 06:17:33 +0000 (15:17 +0900)]
Rearrange display lock and unlock in the usb module
If an error occurs during usb enable, do not acquire display lock.
Target may enter sleep mode with the USB cable is connected
To prevent this situation, acquire the lock when usb cable is connected,
and release the lock when usb cable is disconnected.
Change-Id: I9850e593957e182a415298eeb63361d09c21dc3a
INSUN PYO [Wed, 4 Mar 2020 04:53:53 +0000 (13:53 +0900)]
Refactoring usb_state_update_state #5
Reimplemented by separating change_usb_state_notification_handler() from usb_state_update_state().
A change_usb_state_notification_handler() is only changed when the usb gadget is enabled or disabled.
Change-Id: I58a30bf3a41abe082ed5f91da2cddd232ed0c6e4
INSUN PYO [Wed, 4 Mar 2020 03:25:48 +0000 (12:25 +0900)]
Refactoring usb_state_update_state #4
Reimplemented by separating send_usb_state_changed_event() from usb_state_update_state().
USB_DISCONNECTED : VCONFKEY_SYSMAN_USB_DISCONNECTED
USB_CONNECTED + USB_FUNCTION_NONE : VCONFKEY_SYSMAN_USB_CONNECTED
USB_CONNECTED + USB_FUNCTION_OOOO : VCONFKEY_SYSMAN_USB_AVAILABLE
When connecting the usb cable : "disconnected"(previous value) -> "connected" -> "available"
When disconnecting the usb cable : "available"(previous value) -> "dosconnected"
When changing usb mode : "available"(previous value) -> "connected" -> "available"
When USB cable is connected but USB initialization fails : It stays "connected" without going to "available"
Change-Id: I8a9d84884388bb0dcf24f44735224c695d2f10ec
Youngjae Cho [Tue, 3 Mar 2020 08:34:04 +0000 (17:34 +0900)]
Add critical-log for long lasting lock
Check locks every 10 minutes. (disp_plgn.lockcheck_timeout = 600)
Change-Id: I6cee6df8e46f947131a30c46c373332d456134dd
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Tue, 3 Mar 2020 06:57:59 +0000 (06:57 +0000)]
Revert "Add more robust usb error handling"
This reverts commit
982e0040a8ed197ea2a35c05052ae3bacd2f6068.
Change-Id: I634d301d2b22a905e8c2d014076f847eb1b3fa73
INSUN PYO [Tue, 3 Mar 2020 06:02:40 +0000 (15:02 +0900)]
Refactoring usb_state_update_state #3
Reimplemented by separating usb_state_set_current_mode() from usb_state_update_state().
A usb_state_set_current_mode() is olny changed when the usb gadget is enabled or disabled.
Change-Id: I0baaf031f52d2417d9aef84d56ff4b0e4c394b5f
Youngjae Cho [Tue, 3 Mar 2020 05:36:40 +0000 (14:36 +0900)]
Delete critical-log for pmlock/unlock
Change-Id: Ia09f99ad4a94adc5e2272cf6650c7832910e07a2
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Tue, 3 Mar 2020 05:09:39 +0000 (14:09 +0900)]
Refactoring usb_state_update_state #2
Reimplemented by separating usb_state_set_connection() from usb_state_update_state().
A usb_state_set_connection() is olny changed when the usb cable is connected or disconnected.
Change-Id: Ib2f9ca0eb12cb60e9f50f5badcedacaa71f8663b
INSUN PYO [Tue, 3 Mar 2020 02:42:50 +0000 (11:42 +0900)]
Add usb configuration exception handling code
If an error occurs during usb configuration, change the usb current mode to USB_FUNCTION_NONE.
The meaning of usb current mode is that usb is working correctly.
If any error occurs, USB operation is not guaranteed.
The value of usb current mode should not have a meaningless value and should have USB_FUNCTION_NONE.
Change-Id: Ia882f517fe696a03cf1a39f97b382383d970e9d5
INSUN PYO [Tue, 3 Mar 2020 00:06:06 +0000 (09:06 +0900)]
Add more robust usb error handling
The extcon uvent handler usb_state_changed() handles errors for usb connect/disconnect,
but adds additional exception handling code for more robust usb error handling.
Change-Id: I6c79fa99078ec71a19a2a72a94d28d31c8b9571f
Youngjae Cho [Fri, 28 Feb 2020 04:07:25 +0000 (13:07 +0900)]
Add pmqos for WirelessSendFile
Change-Id: I6d721794f937d99dee51d22e200691b4c3abdf5e
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Wed, 26 Feb 2020 10:32:25 +0000 (19:32 +0900)]
Cleanup usb code
Change-Id: I6bee810fb808b2caf6de69bcd17db2a9ea4b8677
Hyotaek Shim [Wed, 26 Feb 2020 10:15:22 +0000 (19:15 +0900)]
Fix SVACE
After having been compared to NULL value at bezel.c:111,
pointer 'bezel_dev->set_sw_state' is dereferenced at bezel.c:128
Change-Id: I7bf465007fffe6f373621ac3ca16e0df0117929a
Signed-off-by: Hyotaek Shim <hyotaek.shim@samsung.com>
INSUN PYO [Wed, 26 Feb 2020 09:57:06 +0000 (18:57 +0900)]
Fixed to use default usb sel mode(MTP + ACM) for invalid vocnf value #2
Change-Id: I304abc9eef84328887f7ec6da282ae8aa43a2f6b
Youngjae Cho [Wed, 26 Feb 2020 04:45:44 +0000 (13:45 +0900)]
Fix wearable_mode() related code according to profile
Leave one of 'if' or 'else' statement related to wearable_mode()
according to profile.
Change-Id: I378ce12d334444dcfc4643dafb256eca4abc16cb
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Wed, 26 Feb 2020 05:38:25 +0000 (14:38 +0900)]
Refactoring usb_state_update_state
Since these four functions are handled in one function, they must be separated.
1. add and remove usb state notification handler
2. change usb connection state
3. send usb state changed event: event, vconf, dbus signal
4. change usb current mode
Change-Id: I202a069f36b7feb5a7c0db38e2d2e15f805802aa
Youngjae Cho [Tue, 25 Feb 2020 05:38:22 +0000 (14:38 +0900)]
Add delay to set_brightness_level() when AOD is on
When display state changes from AOD to LCDON, brightness change
effect seems sluggish because of heavy load of jobs for turning on
display. So delay this brightness change a bit to avoid this
heavy loaded time and therefore make it change smoothly.
Change-Id: Ie59e572becbb4bfc204634d5720818531d43121e
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Wed, 26 Feb 2020 03:30:53 +0000 (12:30 +0900)]
Fixed to use default usb sel mode(MTP + ACM) for invalid vocnf value
Deviced must never run in USB_FUNCTION_NONE mode.
So if vconf value is invalid, deviced uses the default usb mode internally.
Keep the problematic vconf values in order to define the problem correctly.
Change-Id: Iaeda7d02accbdc3576acb173f4c60cbe38f33519
Youngjae Cho [Tue, 25 Feb 2020 05:56:34 +0000 (14:56 +0900)]
Fix build warning
Change-Id: Ie04008f348ccb3c2b23fffcaeab0ec53651e7045
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
Youngjae Cho [Mon, 24 Feb 2020 03:06:33 +0000 (12:06 +0900)]
Add software bezel control
Change-Id: I1c1625892c7d04531d88079fdb70ab404a9c6065
Signed-off-by: Youngjae Cho <y0.cho@samsung.com>
INSUN PYO [Mon, 24 Feb 2020 03:10:01 +0000 (12:10 +0900)]
Remove is_emulator() on usb
Deviced only uses three functions in usb_client hal: disable, enable and reconfigure_gadget.
If emulator's usb_client hal provides these three functions as dummy,
deviced can be used on both the emulator and target as a single code.
Change-Id: Ie2f32403e9767f65d4166ab8be6c83b68891b452