commit-queue@webkit.org [Mon, 16 Apr 2012 18:27:42 +0000 (18:27 +0000)]
[BlackBerry] Increase padding for text element
https://bugs.webkit.org/show_bug.cgi?id=83903
Patch by Yongxin Dai <yodai@rim.com> on 2012-04-16
Reviewed by Antonio Gomes.
PR 125888
Increase the padding value for focused text element to make selection handle
at least partially visible when the user is dragging at edge of viewport
in in-region scoll mode.
Reviewed internally by Mike Fenton.
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Mon, 16 Apr 2012 18:27:03 +0000 (18:27 +0000)]
[Chromium] Marking css3/filters/huge-region.html and composited version MISSING, CRASH.
Unreviewed.
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
scheib@chromium.org [Mon, 16 Apr 2012 18:12:25 +0000 (18:12 +0000)]
Adding Contributors Brian Salomon and Tom Hudson to committers.py.
Unreviewed.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 16 Apr 2012 18:06:00 +0000 (18:06 +0000)]
Try to fix a flaky JS test.
Use a URL that's allowed to load so the resource load delegate won't randomly complain about it depending on
if the load starts before the Audio object is garbage collected (that's my guess anyway).
* fast/js/custom-constructors-expected.txt:
* fast/js/script-tests/custom-constructors.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 16 Apr 2012 18:01:30 +0000 (18:01 +0000)]
<rdar://problem/
11249336> and https://bugs.webkit.org/show_bug.cgi?id=84050 WebKit2 back/forward items in the page cache are never removed when the page is closed
Reviewed by Jessie Berlin and unofficially reviewed by Jon Lee.
Source/WebCore:
* WebCore.exp.in: Export PageCache::remove()
Source/WebKit2:
Individual WebBackForwardListProxy's had no idea which items are associated with them.
This adds that association and makes sure the proxy removes all associated items from the PageCache when it closes.
* WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::removeItem): Remove the item from the PageCache in case it was in it.
(WebKit::WebBackForwardListProxy::addItem): Add the item ID to this back/forward list's set of associated IDs.
(WebKit::WebBackForwardListProxy::close): Remove each associated item from the PageCache.
* WebProcess/WebPage/WebBackForwardListProxy.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Apr 2012 17:51:18 +0000 (17:51 +0000)]
Unreviewed, GTK build fix after r114269.
* GNUmakefile.list.am:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 17:43:23 +0000 (17:43 +0000)]
Fix bug in WebPluginContainer::isRectTopmost() which gave the incorrect result for a scrolled window.
https://bugs.webkit.org/show_bug.cgi?id=80606
Patch by Raymes Khoury <raymes@chromium.org> on 2012-04-16
Reviewed by Darin Fisher.
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 16 Apr 2012 17:41:52 +0000 (17:41 +0000)]
Fix COMMANDLINE_TYPEDARRAYS build
https://bugs.webkit.org/show_bug.cgi?id=84051
Reviewed by Gavin Barraclough.
Update for new putByIndex API and wtf changes.
* JSCTypedArrayStubs.h:
(JSC):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Apr 2012 17:30:21 +0000 (17:30 +0000)]
Unreviewed, GTK test_expectations update.
* platform/gtk/test_expectations.txt: Turns out those frame
flattening tests are still flaky.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 16 Apr 2012 17:25:26 +0000 (17:25 +0000)]
Web Inspector: timeline. Range selection works incorrect with right click
https://bugs.webkit.org/show_bug.cgi?id=83870
Reviewed by Pavel Feldman.
- only start window dragging upon mousedown with left button (right will cause a context menu and we won't see mouseup)
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewWindow.prototype._dragWindow):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 16 Apr 2012 17:23:18 +0000 (17:23 +0000)]
Web Inspector: rename heap profiler files and classes DetailedHeapshot* ->HeapSnapshot*
https://bugs.webkit.org/show_bug.cgi?id=84038
A bunch of renames "detailed heapshot" -> "heap snapshot".
Reviewed by Pavel Feldman.
PerformanceTests:
* inspector/detailed-heapshots-smoke-test.html:
Source/WebCore:
Tests: inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-comparison-show-all.html
inspector/profiler/heap-snapshot-comparison-show-next.html
inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-comparison-sorting.html
inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-containment-show-all.html
inspector/profiler/heap-snapshot-containment-show-next.html
inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-containment-sorting.html
inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-dominators-show-all.html
inspector/profiler/heap-snapshot-dominators-show-next.html
inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-dominators-sorting.html
inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html
inspector/profiler/heap-snapshot-summary-show-all.html
inspector/profiler/heap-snapshot-summary-show-next.html
inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html
inspector/profiler/heap-snapshot-summary-sorting.html
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/HeapSnapshotGridNodes.js: Renamed from Source/WebCore/inspector/front-end/DetailedHeapshotGridNodes.js.
(WebInspector.HeapSnapshotGridNode):
(WebInspector.HeapSnapshotGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotGridNode.prototype.createCell):
(WebInspector.HeapSnapshotGridNode.prototype.dispose):
(WebInspector.HeapSnapshotGridNode.prototype.hasHoverMessage.false.queryObjectContent):
(WebInspector.HeapSnapshotGridNode.prototype._toPercentString):
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
(WebInspector.HeapSnapshotGridNode.prototype._populate.sorted):
(WebInspector.HeapSnapshotGridNode.prototype._populate):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.callSerialize):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved.notify):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
(WebInspector.HeapSnapshotGridNode.prototype._saveChildren):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort.afterPopulate):
(WebInspector.HeapSnapshotGridNode.prototype.sort.afterSort):
(WebInspector.HeapSnapshotGridNode.prototype.sort):
(WebInspector.HeapSnapshotLazyGridNode):
(WebInspector.HeapSnapshotLazyGridNode.prototype.ensureContentCreated):
(WebInspector.HeapSnapshotLazyGridNode.prototype.createCells):
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.createCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent.else.formatResult):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.queryObjectContent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _retainedSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.isWindow):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.updateHasChildren):
(WebInspector.HeapSnapshotObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotObjectNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotObjectNode.prototype._emptyData):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
(WebInspector.HeapSnapshotObjectNode.prototype._prefixObjectCell):
(WebInspector.HeapSnapshotInstanceNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._createChildNode):
(WebInspector.HeapSnapshotInstanceNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotInstanceNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
(WebInspector.HeapSnapshotInstanceNode.prototype._emptyData):
(WebInspector.HeapSnapshotInstanceNode.prototype._enhanceData):
(WebInspector.HeapSnapshotInstanceNode.prototype.get isDeletedNode):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.createCell):
(WebInspector.HeapSnapshotConstructorNode.prototype._createChildNode):
(WebInspector.HeapSnapshotConstructorNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotConstructorNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _countPercent):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _retainedSizePercent):
(WebInspector.HeapSnapshotConstructorNode.prototype.get _shallowSizePercent):
(WebInspector.HeapSnapshotIteratorsTuple):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.dispose):
(WebInspector.HeapSnapshotIteratorsTuple.prototype.sortAndRewind):
(WebInspector.HeapSnapshotDiffNode):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.diffCalculated):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.baseIdsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype.calculateDiff.idsReceived):
(WebInspector.HeapSnapshotDiffNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider.createProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._createNodesProvider):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDiffNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDiffNode.prototype.comparator):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren.else.firstProviderPopulated):
(WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
(WebInspector.HeapSnapshotDiffNode.prototype._signForDelta):
(WebInspector.HeapSnapshotDiffNode.prototype.get data):
(WebInspector.HeapSnapshotDominatorObjectNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createChildNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._createProvider):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._childHashForEntity):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._childHashForNode):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotDominatorObjectNode.prototype._emptyData):
(MixInSnapshotNodeFunctions):
* inspector/front-end/HeapSnapshotView.js: Renamed from Source/WebCore/inspector/front-end/DetailedHeapshotView.js.
(WebInspector.HeapSnapshotSortableDataGrid):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.dispose):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.resetSortingCache):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged.SortByTwoFields):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.updateVisibleNodes):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.onResize):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._onScroll):
(WebInspector.HeapSnapshotSortableDataGrid.prototype._performSorting):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingEnter):
(WebInspector.HeapSnapshotSortableDataGrid.prototype.recursiveSortingLeave):
(WebInspector.HeapSnapshotContainmentDataGrid):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute.nextStep.else.afterExpand):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype._defaultPopulateCount.100.expandRoute):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotContainmentDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.reset):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._defaultPopulateCount.100._sortFields):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._filterSelectIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._defaultPopulateCount.50._sortFields):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype._baseProfileIndexChanged):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.setBaseDataSource):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived.addNodeIfNonZeroDiff):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren.baseAggregatesReceived.aggregatesReceived):
(WebInspector.HeapSnapshotDiffDataGrid.prototype.populateChildren):
(WebInspector.HeapSnapshotDominatorsDataGrid):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype._defaultPopulateCount.25.setDataSource):
(WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
(WebInspector.HeapSnapshotView.profileCallback):
(WebInspector.HeapSnapshotView):
(WebInspector.HeapSnapshotView.prototype.dispose):
(WebInspector.HeapSnapshotView.prototype.get statusBarItems):
(WebInspector.HeapSnapshotView.prototype.get profile):
(WebInspector.HeapSnapshotView.prototype.get profileWrapper):
(WebInspector.HeapSnapshotView.prototype.get baseProfile):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback1):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback2):
(WebInspector.HeapSnapshotView.prototype.wasShown):
(WebInspector.HeapSnapshotView.prototype.willHide):
(WebInspector.HeapSnapshotView.prototype.onResize):
(WebInspector.HeapSnapshotView.prototype.searchCanceled):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesById):
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesQuery):
(WebInspector.HeapSnapshotView.prototype.performSearch):
(WebInspector.HeapSnapshotView.prototype.jumpToFirstSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToLastSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToNextSearchResult):
(WebInspector.HeapSnapshotView.prototype.jumpToPreviousSearchResult):
(WebInspector.HeapSnapshotView.prototype.showingFirstSearchResult):
(WebInspector.HeapSnapshotView.prototype.showingLastSearchResult):
(WebInspector.HeapSnapshotView.prototype._jumpToSearchResult):
(WebInspector.HeapSnapshotView.prototype.refreshVisibleData):
(WebInspector.HeapSnapshotView.prototype._changeBase):
(WebInspector.HeapSnapshotView.prototype._changeFilter):
(WebInspector.HeapSnapshotView.prototype._createToolbarWithClassNameFilter):
(WebInspector.HeapSnapshotView.prototype._changeNameFilter):
(WebInspector.HeapSnapshotView.prototype._profiles):
(WebInspector.HeapSnapshotView.prototype._loadProfile):
(WebInspector.HeapSnapshotView.prototype._loadProfileByIndex):
(WebInspector.HeapSnapshotView.prototype.isDetailedSnapshot):
(WebInspector.HeapSnapshotView.prototype.processLoadedSnapshot):
(WebInspector.HeapSnapshotView.prototype._selectionChanged):
(WebInspector.HeapSnapshotView.prototype._inspectedObjectChanged):
(WebInspector.HeapSnapshotView.prototype._setRetainmentDataGridSource):
(WebInspector.HeapSnapshotView.prototype._mouseDownInContentsGrid):
(WebInspector.HeapSnapshotView.prototype.changeView.sortingComplete):
(WebInspector.HeapSnapshotView.prototype.changeView):
(WebInspector.HeapSnapshotView.prototype._changeView):
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):
(WebInspector.HeapSnapshotView.prototype._resolveObjectForPopover):
(WebInspector.HeapSnapshotView.prototype._helpClicked.appendHelp):
(WebInspector.HeapSnapshotView.prototype._helpClicked):
(WebInspector.HeapSnapshotView.prototype._startRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._retainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._endRetainersHeaderDragging):
(WebInspector.HeapSnapshotView.prototype._updateRetainmentViewHeight):
(WebInspector.HeapSnapshotView.prototype._updateBaseOptions):
(WebInspector.HeapSnapshotView.prototype._updateFilterOptions):
(WebInspector.HeapSnapshotProfileType):
(WebInspector.HeapSnapshotProfileType.prototype.get buttonTooltip):
(WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
(WebInspector.HeapSnapshotProfileType.prototype.get treeItemTitle):
(WebInspector.HeapSnapshotProfileType.prototype.get description):
(WebInspector.HeapSnapshotProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createView):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/heapProfiler.css:
(.heap-snapshot-view):
(.heap-snapshot-view.visible):
(.heap-snapshot-view .view):
(.heap-snapshot-view .view.visible):
(.heap-snapshot-view .data-grid tr:empty):
(.heap-snapshot-view .data-grid):
(.heap-snapshot-view .data-grid td.count-column):
(.heap-snapshot-view .data-grid td.addedCount-column):
(.heap-snapshot-view .data-grid td.removedCount-column):
(.heap-snapshot-view .data-grid td.countDelta-column):
(.heap-snapshot-view .data-grid td.addedSize-column):
(.heap-snapshot-view .data-grid td.removedSize-column):
(.heap-snapshot-view .data-grid td.sizeDelta-column):
(.heap-snapshot-view .data-grid td.shallowSize-column):
(.heap-snapshot-view .data-grid td.retainedSize-column):
(.heap-snapshot-view .data-grid td.distanceToWindow-column):
(.heap-snapshot-view .data-grid span.percent-column):
(.heap-snapshot-view .console-formatted-object, .console-formatted-node):
(.heap-snapshot-view .console-formatted-string):
(.heap-snapshot-view .console-formatted-id):
(.heap-snapshot-view .data-grid tr.selected *):
(.heap-snapshot-view .data-grid:focus tr.selected *):
(.heap-snapshot-view .delimiter):
(.heap-snapshot-view .views-container):
(.heap-snapshot-view .views-container .view):
(.heap-snapshot-view .retaining-paths-view):
(.heap-snapshot-view .class-view-grid):
(.heap-snapshot-view .class-view-toolbar):
(.heap-snapshot-view .class-view-toolbar input.class-name-filter):
(.heap-snapshot-view .retainers-view-header):
(.heap-snapshot-view .retainers-view-header .title > span):
(.heap-snapshot-view tr:not(.selected) td.object-column span.highlight):
(.heap-snapshot-view td.object-column span.grayed):
(.heap-snapshot-help-status-bar-item .glyph):
(table.heap-snapshot-help):
* inspector/front-end/inspector.html:
LayoutTests:
* inspector/profiler/detailed-heapshots-test.js: Removed.
* inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt.
* inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting.html.
* inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt.
* inspector/profiler/heap-snapshot-comparison-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-all.html.
* inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt.
* inspector/profiler/heap-snapshot-comparison-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-show-next.html.
* inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt.
* inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting.html.
* inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt.
* inspector/profiler/heap-snapshot-comparison-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-comparison-sorting.html.
* inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt.
* inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting.html.
* inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt.
* inspector/profiler/heap-snapshot-containment-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-all.html.
* inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt.
* inspector/profiler/heap-snapshot-containment-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-show-next.html.
* inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt.
* inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting.html.
* inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt.
* inspector/profiler/heap-snapshot-containment-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-containment-sorting.html.
* inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt.
* inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting.html.
* inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt.
* inspector/profiler/heap-snapshot-dominators-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-all.html.
* inspector/profiler/heap-snapshot-dominators-show-next-actual.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next-actual.txt.
* inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt.
* inspector/profiler/heap-snapshot-dominators-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-show-next.html.
* inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt.
* inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting.html.
* inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt.
* inspector/profiler/heap-snapshot-dominators-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-dominators-sorting.html.
* inspector/profiler/heap-snapshot-inspect-dom-wrapper.html:
* inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt.
* inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting.html.
* inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt.
* inspector/profiler/heap-snapshot-summary-show-all.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-all.html.
* inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt.
* inspector/profiler/heap-snapshot-summary-show-next.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-show-next.html.
* inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt.
* inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting.html.
* inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt.
* inspector/profiler/heap-snapshot-summary-sorting.html: Renamed from LayoutTests/inspector/profiler/detailed-heapshots-summary-sorting.html.
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.InspectorTest.startProfilerTest.detailedHeapProfilesEnabled):
(initialize_HeapSnapshotTest.InspectorTest.completeProfilerTest):
(initialize_HeapSnapshotTest.InspectorTest.runHeapSnapshotTestSuite.runner):
(initialize_HeapSnapshotTest.InspectorTest.runHeapSnapshotTestSuite):
(initialize_HeapSnapshotTest):
(initialize_HeapSnapshotTest.):
* platform/chromium/inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-expansion-preserved-when-sorting-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-comparison-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-all-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-comparison-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-show-next-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-shown-node-count-preserved-when-sorting-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-comparison-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-comparison-sorting-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-expansion-preserved-when-sorting-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-containment-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-show-all-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-containment-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-show-next-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-shown-node-count-preserved-when-sorting-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-containment-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-containment-sorting-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-dominators-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-expansion-preserved-when-sorting-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-dominators-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-all-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-dominators-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-show-next-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-dominators-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-shown-node-count-preserved-when-sorting-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-dominators-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-dominators-sorting-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-expansion-preserved-when-sorting-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-summary-show-all-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-show-all-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-summary-show-next-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-show-next-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-shown-node-count-preserved-when-sorting-expected.txt.
* platform/chromium/inspector/profiler/heap-snapshot-summary-sorting-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/profiler/detailed-heapshots-summary-sorting-expected.txt.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 16 Apr 2012 17:18:53 +0000 (17:18 +0000)]
Web Inspector: touch pad is pain to use in lower pane of Timeline panel due two two-axis scrolling
https://bugs.webkit.org/show_bug.cgi?id=83946
Reviewed by Pavel Feldman.
Remove delegation of mousewheel events from lower timeline pane to the timeline overview. This disables
support for moving overview window with horizontal swype over lower timeline pane, thus removing
an irritating situation when we try to both change overview window and scroll lower timeline pane
upon a single touchpad gesture. Those willing to move timeline window now would need to position
mouse over overview.
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewWindow.prototype._onMouseWheel):
(WebInspector.TimelineOverviewWindow.prototype._zoom):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Apr 2012 17:14:12 +0000 (17:14 +0000)]
[GStreamer] HRTFDatabaseLoader conflicts with AudioFileReader
https://bugs.webkit.org/show_bug.cgi?id=78095
Reviewed by Martin Robinson.
Moved the GStreamer initialization logic to a new
GStreamerUtilities module, used by the MediaPlayer and the
AudioContext. I also removed the static variables as
gst_init_check already handles cases where it's called multiple
times.
* GNUmakefile.list.am:
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::constructCommon):
* platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus):
* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF):
(WTF::GstElementFactory):
* platform/graphics/gstreamer/GRefPtrGStreamer.h:
(WTF):
* platform/graphics/gstreamer/GStreamerUtilities.cpp: Added.
(WebCore):
(WebCore::initializeGStreamer):
* platform/graphics/gstreamer/GStreamerUtilities.h: Added.
(WebCore):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::doGstInit):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 17:06:14 +0000 (17:06 +0000)]
Update GraphicsContext3DOpenGLES.cpp and fix some issues to build with GLES.
https://bugs.webkit.org/show_bug.cgi?id=83982
Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-04-16
Reviewed by Martin Robinson.
GL_BGRA is not defined in GLESv2, so it causes build-break at readRenderingResults.
To resolve this, a helper function readPixelsAndConvertToBGRAIfNecessary is added
in GC3DOpenGL.cpp & GC3DOpenGLES.cpp and it's used in GC3DOpenGLCommon.cpp.
And some other issues to build with GLES are gone with this patch.
No new tests, since no new feature.
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::readRenderingResults):
* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore):
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Mon, 16 Apr 2012 17:03:42 +0000 (17:03 +0000)]
[chromium] wrong justification for arabic/persian page in cr-win.
https://bugs.webkit.org/show_bug.cgi?id=83227
Reviewed by Kent Tamura.
Source/WebCore:
Disable kashida justification if using Skia to draw.
Test: fast/text/international/arabic-justify.html
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::justify):
LayoutTests:
* fast/text/international/arabic-justify.html: Added.
* platform/chromium-win/fast/text/international/arabic-justify-expected.png: Added.
* platform/chromium-win/fast/text/international/arabic-justify-expected.txt: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/text/international/arabic-justify-expected.txt: Added.
* platform/mac-snowleopard/fast/text/international/arabic-justify-expected.png: Added.
* platform/mac-snowleopard/fast/text/international/arabic-justify-expected.txt: Added.
* platform/mac/fast/text/international/arabic-justify-expected.txt: Added.
* platform/qt/fast/text/international/arabic-justify-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jpu@apple.com [Mon, 16 Apr 2012 16:59:21 +0000 (16:59 +0000)]
Build fix.
Change set 114220 broke OS X internal build. Change set 114231 attempted to fix it, but isn't entirely
correct. This patch amends change set 114231.
* WebCore.exp.in:
* editing/DictationAlternative.cpp:
(WebCore::DictationAlternative::DictationAlternative):
* editing/DictationAlternative.h:
(DictationAlternative):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 16 Apr 2012 16:37:10 +0000 (16:37 +0000)]
REGRESSION (r104445): Style is not recomputed on serenaandlily.com
https://bugs.webkit.org/show_bug.cgi?id=83663
Source/WebCore:
Reviewed by Andreas Kling.
CSS class and id selectors are case insensitive in non-strict modes. The code
that invalidated the scope elements used getElementByID() which is case
sensitive in all modes. As a result we would fail to invalidate elements
that would match a style rule but used different case in id.
The new code invalidates by crawling the DOM tree. This often (when there are classes)
actually faster than the existing code as we can now handle everything in a single pass.
Each class scope required a crawl with the old code.
The code uses the same functions as the selector matching code to get the same behavior.
The maximum class limit is lifted as number of classes does not affect complexity anymore.
Test: fast/css/id-or-class-before-stylesheet-strict.html
* css/SelectorChecker.h:
(WebCore::SelectorChecker::elementMatchesSelectorScopes):
(WebCore):
* dom/Document.cpp:
(WebCore::Document::testAddedStylesheetRequiresStyleRecalc):
(WebCore):
LayoutTests:
Reviewed by Andreas Kling.
Update the existing test with case insensitive comparisons and add a strict mode test.
* fast/css/id-or-class-before-stylesheet-expected.txt:
* fast/css/id-or-class-before-stylesheet-strict-expected.txt: Added.
* fast/css/id-or-class-before-stylesheet-strict.html: Added.
* fast/css/id-or-class-before-stylesheet.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Apr 2012 15:56:42 +0000 (15:56 +0000)]
Unreviewed, GTK test_expectations update.
* platform/gtk/test_expectations.txt: Unflag frame flattening
tests fixed in r114262.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 15:53:15 +0000 (15:53 +0000)]
[BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
https://bugs.webkit.org/show_bug.cgi?id=84031
Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-04-16
Reviewed by Rob Buis.
Source/WebKit/blackberry:
Added the interface function didReceivedAuthenticaitonChallenge()
in interface class DumpRenderTreeClient;
Called m_dumpRenderTree->didReceiveAuthenticationChallenge() in
WebPagePrivate::authenticationChallenge() when DRT is enabled.
Test: reuse existing test cases:
http/tests/loading/basic-credentials-sent-automatically.html
http/tests/loading/basic-auth-resend-wrong-credentials.html
* Api/DumpRenderTreeClient.h:
(WebCore):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
Tools:
Implemented interface function didReceiveAuthenticationChallenge in class
DumpRenderTree.
* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(drtCredentialDescription):
(BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
(WebKit):
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(WebCore):
(DumpRenderTree):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 15:51:07 +0000 (15:51 +0000)]
[Qt] LayoutTest: Replace setTimeout with synchronous layout for frame flattening where possible.
https://bugs.webkit.org/show_bug.cgi?id=84028
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-16
Reviewed by Kenneth Rohde Christiansen.
It's safer (and faster) to force synchronous layout, than expecting a layout before setTimout(0) hits.
* fast/frames/flattening/crash-svg-document.html: Remove extra line so that non-svg builds don't report failure.
* fast/frames/flattening/frameset-flattening-advanced.html:
* fast/frames/flattening/frameset-flattening-grid.html:
* fast/frames/flattening/frameset-flattening-subframesets.html:
* fast/frames/flattening/iframe-flattening-fixed-height.html:
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-with-js-forced-layout.html:
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling.html:
* fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html:
* fast/frames/flattening/iframe-flattening-fixed-width.html:
* fast/frames/flattening/iframe-flattening-nested.html:
* fast/frames/flattening/iframe-flattening-offscreen.html:
* fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout.html:
* fast/frames/flattening/iframe-flattening-out-of-view.html:
* fast/frames/flattening/iframe-flattening-selection-crash.html:
* fast/frames/flattening/iframe-flattening-simple.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 15:36:24 +0000 (15:36 +0000)]
CSS3 Selectors failures on css3test.com
https://bugs.webkit.org/show_bug.cgi?id=83885
Patch by Uday Kiran <udaykiran@motorola.com> on 2012-04-16
Reviewed by Zoltan Herczeg.
Source/WebCore:
Parsing fix for CSS3 selectors :nth-child(), :nth-last-child() :nth-of-type() :nth-last-of-type()
with values -n-b and n-b as they are of valid form an+b where a and b are integers.
http://www.w3.org/TR/selectors/#structural-pseudos
Descriptors of form n-b or -n-b, where b is number, are valid CSS identifiers.
However, in NthChildMode we need to check whether this identifier is a valid nth child descriptor.
The original code only checked this if the string was n- or -n- but this is not enough.
We need to check everything which starts with an n- or -n- prefix.
Test: css3/parsing-css3-nthchild.html
* css/CSSParser.cpp:
(WebCore::CSSParser::lex):
LayoutTests:
* css3/parsing-css3-nthchild-expected.txt: Added.
* css3/parsing-css3-nthchild.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Apr 2012 15:35:30 +0000 (15:35 +0000)]
[GTK] GStreamer 1.0 support in configure.ac
https://bugs.webkit.org/show_bug.cgi?id=84029
Reviewed by Martin Robinson.
The GStreamer version was recently changed to 1.0 in the git
repositories of the project so we need to reflect this change in
configure.ac.
* configure.ac:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Apr 2012 15:33:45 +0000 (15:33 +0000)]
Unreviewed, GTK test_expectations update.
* platform/gtk/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Mon, 16 Apr 2012 15:18:48 +0000 (15:18 +0000)]
ASSERT in notifyChildInserted when HTMLMediaElement is removed from tree
https://bugs.webkit.org/show_bug.cgi?id=83949
Reviewed by Antti Koivisto.
No new tests. I was not able to create a reproducible test case, but I have been unable
to reproduce the ASSERT that occassionally fired in existing tests since I have been
living on these changes.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::insertedIntoDocument): Call configureMediaControls.
(WebCore::HTMLMediaElement::removedFromDocument): Ditto.
(WebCore::HTMLMediaElement::configureMediaControls): Don't show controls when the
media element is not in a Document.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 15:15:37 +0000 (15:15 +0000)]
build-webkit --gtk --no-webkit2 builds WK2
https://bugs.webkit.org/show_bug.cgi?id=83977
Patch by Philippe Normand <pnormand@igalia.com> on 2012-04-16
Reviewed by Martin Robinson.
* Scripts/build-webkit: Fixup ./configure option to disable
WebKit2 build.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Mon, 16 Apr 2012 15:13:25 +0000 (15:13 +0000)]
Layout Test media/track/track-delete-during-setup.html is hitting an ASSERT_NOT_REACHED
https://bugs.webkit.org/show_bug.cgi?id=82269
Reviewed by Antti Koivisto.
Source/WebCore:
No new tests, already tested by media/track/track-delete-during-setup.html.
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::insertedIntoDocument): Don't notify the media element until/unless
the track element is inserted into the document.
* html/HTMLTrackElement.h:
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mhahnenberg@apple.com [Mon, 16 Apr 2012 15:10:08 +0000 (15:10 +0000)]
GC in the middle of JSObject::allocatePropertyStorage can cause badness
https://bugs.webkit.org/show_bug.cgi?id=83839
Reviewed by Geoffrey Garen.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* jit/JITStubs.cpp: Making changes to use the new return value of growPropertyStorage.
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::growPropertyStorage): Renamed to more accurately reflect that we're
growing our already-existing PropertyStorage.
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::setPropertyStorage): "Atomically" sets the new property storage
and the new structure so that we can be sure a GC never occurs when our Structure
info is out of sync with our PropertyStorage.
(JSC):
(JSC::JSObject::putDirectInternal): Moved the check to see if we should
allocate more backing store before the actual property insertion into
the structure.
(JSC::JSObject::putDirectWithoutTransition): Ditto.
(JSC::JSObject::transitionTo): Ditto.
* runtime/Structure.cpp:
(JSC::Structure::suggestedNewPropertyStorageSize): Added to keep the resize policy
for property backing stores contained within the Structure class.
(JSC):
* runtime/Structure.h:
(JSC::Structure::shouldGrowPropertyStorage): Lets clients know if another insertion
into the Structure would require resizing the property backing store so that they can
preallocate the required storage.
(Structure):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 14:49:35 +0000 (14:49 +0000)]
[EFL][DRT] Create baselines for CSS cases related to Ahem font
https://bugs.webkit.org/show_bug.cgi?id=83265
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16
* platform/efl/fast/css/caption-width-absolute-position-expected.png: Added.
* platform/efl/fast/css/caption-width-absolute-position-expected.txt: Added.
* platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.png: Added.
* platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt: Added.
* platform/efl/fast/css/caption-width-fixed-position-expected.png: Added.
* platform/efl/fast/css/caption-width-fixed-position-expected.txt: Added.
* platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.png: Added.
* platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt: Added.
* platform/efl/fast/css/caption-width-relative-position-expected.png: Added.
* platform/efl/fast/css/caption-width-relative-position-expected.txt: Added.
* platform/efl/fast/css/caption-width-relative-position-offset-top-expected.png: Added.
* platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt: Added.
* platform/efl/fast/css/min-width-with-spanned-cell-expected.png: Added.
* platform/efl/fast/css/min-width-with-spanned-cell-expected.txt: Added.
* platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.png: Added.
* platform/efl/fast/css/min-width-with-spanned-cell-fixed-expected.txt: Added.
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 14:43:17 +0000 (14:43 +0000)]
[EFL][WK2] Fix build break in PageClientImpl.cpp.
https://bugs.webkit.org/show_bug.cgi?=id=84034
Reviewed by Kenneth Rohde Christiansen.
Fixes typo in didChangeViewportProperites definition.
* UIProcess/API/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::didChangeViewportProperties):
Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-04-16
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 14:33:25 +0000 (14:33 +0000)]
[EFL][DRT] SVG rebaseline for tests affected by SVGEllipse and SVG shadow root changes
https://bugs.webkit.org/show_bug.cgi?id=84027
Unreviewed, EFL gardening.
Updating txt baselines for tests affected by r109097 and r112806,
creating pixel test results.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16
* platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Added.
* platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
* platform/efl/svg/batik/paints/patternRegionA-expected.png: Added.
* platform/efl/svg/batik/paints/patternRegionA-expected.txt:
* platform/efl/svg/batik/paints/patternRegions-expected.png: Added.
* platform/efl/svg/batik/paints/patternRegions-expected.txt:
* platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.png: Added.
* platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt:
* platform/efl/svg/carto.net/button-expected.png: Added.
* platform/efl/svg/carto.net/button-expected.txt:
* platform/efl/svg/carto.net/colourpicker-expected.png: Added.
* platform/efl/svg/carto.net/colourpicker-expected.txt:
* platform/efl/svg/carto.net/slider-expected.png: Added.
* platform/efl/svg/carto.net/slider-expected.txt:
* platform/efl/svg/carto.net/window-expected.png: Added.
* platform/efl/svg/carto.net/window-expected.txt:
* platform/efl/svg/clip-path/clip-in-mask-expected.png: Added.
* platform/efl/svg/clip-path/clip-in-mask-expected.txt:
* platform/efl/svg/clip-path/clip-path-child-clipped-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-child-clipped-expected.txt:
* platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.txt:
* platform/efl/svg/clip-path/clip-path-css-transform-1-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-css-transform-1-expected.txt:
* platform/efl/svg/clip-path/clip-path-css-transform-2-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-css-transform-2-expected.txt:
* platform/efl/svg/clip-path/clip-path-evenodd-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-evenodd-expected.txt:
* platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-evenodd-nonzero-expected.txt:
* platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-nonzero-evenodd-expected.txt:
* platform/efl/svg/clip-path/clip-path-nonzero-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-nonzero-expected.txt:
* platform/efl/svg/clip-path/clip-path-pixelation-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-pixelation-expected.txt:
* platform/efl/svg/clip-path/clip-path-text-and-shape-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt:
* platform/efl/svg/clip-path/clip-path-transform-1-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-transform-1-expected.txt:
* platform/efl/svg/clip-path/clip-path-use-as-child2-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-use-as-child2-expected.txt:
* platform/efl/svg/clip-path/clip-path-use-as-child3-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-use-as-child3-expected.txt:
* platform/efl/svg/clip-path/clip-path-use-as-child4-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-use-as-child4-expected.txt:
* platform/efl/svg/clip-path/clip-path-use-as-child5-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-use-as-child5-expected.txt:
* platform/efl/svg/clip-path/clip-path-with-container-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-with-container-expected.txt:
* platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.txt:
* platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.txt:
* platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.txt:
* platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.png: Added.
* platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt:
* platform/efl/svg/clip-path/clipper-placement-issue-expected.png: Added.
* platform/efl/svg/clip-path/clipper-placement-issue-expected.txt:
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.png: Added.
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt:
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.png: Added.
* platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt:
* platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.png: Added.
* platform/efl/svg/clip-path/nested-clip-in-mask-image-based-clipping-expected.txt:
* platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.png: Added.
* platform/efl/svg/clip-path/nested-clip-in-mask-path-and-image-based-clipping-expected.txt:
* platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.png: Added.
* platform/efl/svg/clip-path/nested-clip-in-mask-path-based-clipping-expected.txt:
* platform/efl/svg/css/clippath-with-shadow-expected.png: Added.
* platform/efl/svg/css/clippath-with-shadow-expected.txt:
* platform/efl/svg/css/mask-with-shadow-expected.png: Added.
* platform/efl/svg/css/mask-with-shadow-expected.txt:
* platform/efl/svg/css/shadow-changes-expected.png: Added.
* platform/efl/svg/css/shadow-changes-expected.txt:
* platform/efl/svg/hixie/cascade/001-broken-expected.png: Added.
* platform/efl/svg/hixie/cascade/001-broken-expected.txt:
* platform/efl/svg/hixie/cascade/002-expected.png: Added.
* platform/efl/svg/hixie/cascade/002-expected.txt:
* platform/efl/svg/hixie/error/001-expected.png: Added.
* platform/efl/svg/hixie/error/001-expected.txt:
* platform/efl/svg/hixie/error/003-expected.png: Added.
* platform/efl/svg/hixie/error/003-expected.txt:
* platform/efl/svg/hixie/error/017-expected.png: Added.
* platform/efl/svg/hixie/error/017-expected.txt:
* platform/efl/svg/hixie/perf/001-expected.png: Added.
* platform/efl/svg/hixie/perf/001-expected.txt: Added.
* platform/efl/svg/hixie/perf/002-expected.png: Added.
* platform/efl/svg/hixie/perf/002-expected.txt: Added.
* platform/efl/svg/hixie/rendering-model/001-expected.png: Added.
* platform/efl/svg/hixie/rendering-model/001-expected.txt:
* platform/efl/svg/hixie/rendering-model/002-expected.png: Added.
* platform/efl/svg/hixie/rendering-model/002-expected.txt:
* platform/efl/svg/hixie/transform/001-expected.png: Added.
* platform/efl/svg/hixie/transform/001-expected.txt:
* platform/efl/svg/hixie/use/001-expected.png: Added.
* platform/efl/svg/hixie/use/001-expected.txt:
* platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.png: Added.
* platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt:
* platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.png: Added.
* platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt:
* platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Added.
* platform/efl/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
* platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.png: Added.
* platform/efl/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Added.
* platform/efl/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 14:17:33 +0000 (14:17 +0000)]
[EFL] [DRT] Feeding key events with invalid keyName
https://bugs.webkit.org/show_bug.cgi?id=83797
Tools:
Keep the keyName valid within scope of KeyEventInfo to avoid
feeding key events with invalid keyName.
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-16
Reviewed by Philippe Normand.
* DumpRenderTree/efl/EventSender.cpp:
(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):
LayoutTests:
Unskip fast/frames/iframe-window-focus.html
Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-04-16
Reviewed by Philippe Normand.
* platform/efl/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Mon, 16 Apr 2012 14:05:42 +0000 (14:05 +0000)]
[Qt][WK2] Fixed elements position is wrong after zooming.
https://bugs.webkit.org/show_bug.cgi?id=83981
Reviewed by Kenneth Rohde Christiansen.
.:
* ManualTests/remove-add-fixed-position.html: Added.
Source/WebCore:
When setFixedVisibleContentRect is called we mark all fixed elements in the frame for layout.
In order to find these elements, RenderView maintains a list of fixed elements.
They are added and removed at the same time that they are added and removed from their parent RenderBlock.
The idea is taken from the iOS5.1 branch, at opensource.apple.com.
Added a manual test that allows removing and adding fixed elements at will.
* page/FrameView.cpp:
(WebCore::FrameView::setFixedVisibleContentRect):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
* rendering/RenderView.cpp:
(WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
(WebCore):
(WebCore::RenderView::insertFixedPositionedObject):
(WebCore::RenderView::removeFixedPositionedObject):
* rendering/RenderView.h:
(RenderView):
Source/WebKit2:
Turn on the flag setFixedElementsLayoutRelativeToFrame. This causes fixed elements position to be calculated based on
visibleWidth and visibleHeight. When zoom level grows, the visibleWidth and visibleHeight become smaller.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setResizesToContentsUsingLayoutSize):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
toyoshim@chromium.org [Mon, 16 Apr 2012 13:59:12 +0000 (13:59 +0000)]
Unreviewed, skip crash test in chromium-mac.
https://bugs.webkit.org/show_bug.cgi?id=84024
* platform/chromium/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Mon, 16 Apr 2012 13:38:27 +0000 (13:38 +0000)]
[Qt] Clean up how the interaction engine is making use of ViewportAttributes
https://bugs.webkit.org/show_bug.cgi?id=83895
Reviewed by Simon Hausmann.
Refactor how the interaction engine is using the ViewportAttributes
and get rid of the Contraints subclass.
Push the ViewportAttributes through to the QQuickWebViewPrivate class
and add some default values in the case the Legacy view is used.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewLegacyPrivate::QQuickWebViewLegacyPrivate):
(QQuickWebViewFlickablePrivate::didChangeViewportProperties):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
* UIProcess/API/qt/qwebviewportinfo.cpp:
(QWebViewportInfo::QWebViewportInfo):
(QWebViewportInfo::~QWebViewportInfo):
(QWebViewportInfo::currentScale):
(QWebViewportInfo::devicePixelRatio):
(QWebViewportInfo::initialScale):
(QWebViewportInfo::minimumScale):
(QWebViewportInfo::maximumScale):
(QWebViewportInfo::isScalable):
(QWebViewportInfo::layoutSize):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::cssScaleFromItem):
(WebKit::QtViewportInteractionEngine::itemScaleFromCSS):
(WebKit::QtViewportInteractionEngine::itemCoordFromCSS):
(WebKit::QtViewportInteractionEngine::innerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::outerBoundedCSSScale):
(WebKit::QtViewportInteractionEngine::zoomToAreaGestureEnded):
(WebKit::QtViewportInteractionEngine::setCSSScaleBounds):
(WebKit::QtViewportInteractionEngine::setCSSScale):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
(WebKit::QtViewportInteractionEngine::pinchGestureRequestUpdate):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):
(WebKit::QtViewportInteractionEngine::hadUserInteraction):
(WebKit::QtViewportInteractionEngine::setAllowsUserScaling):
(WebKit::QtViewportInteractionEngine::setContentToDevicePixelRatio):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pierre.rossi@gmail.com [Mon, 16 Apr 2012 13:19:41 +0000 (13:19 +0000)]
[Qt] Unreviewed gardening after QRawFont change.
Missed this one earlier. We now use primaryFontHasGlyphForCharacter from
FontFastPath.cpp, resulting in a different DRT output.
* platform/qt-5.0/Skipped: unskip
* platform/qt-5.0/svg/as-image/img-preserveAspectRatio-support-1-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 16 Apr 2012 12:58:08 +0000 (12:58 +0000)]
[Qt] Replace QtXmlPatterns usage with libxslt dependency
https://bugs.webkit.org/show_bug.cgi?id=76820
Unreviewed gardening. Skip new failing tests after r114240 until fix.
* platform/qt-5.0/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 12:53:21 +0000 (12:53 +0000)]
[EFL][DRT] Gardening CSS Regions & Exclusions
https://bugs.webkit.org/show_bug.cgi?id=84011
Skipping CSS regions and exclusions tests for now,
waiting for feature to complete.
Unreviewed, EFL gardening.
Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-04-16
* platform/efl/Skipped:
* platform/efl/test_expectations.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Apr 2012 12:41:40 +0000 (12:41 +0000)]
Unreviewed, GTK gardening.
* platform/gtk/test_expectations.txt: Flag two failing media tests.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 11:50:54 +0000 (11:50 +0000)]
[BlackBerry] Accelerated compositing layers fail to render in direct rendering mode
https://bugs.webkit.org/show_bug.cgi?id=83933
Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-16
Reviewed by Adam Treat.
RIM PR: 149609
This was because I accidentally dropped an exclamation mark when
upstreaming the patch for PR 136381 (bug #83131). Fixed by adding back
the exclamation mark.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 16 Apr 2012 11:46:56 +0000 (11:46 +0000)]
Web Inspector: extract ContentProvider into its own file, make NetworkRequest, Resoruce and others implement it.
https://bugs.webkit.org/show_bug.cgi?id=83922
Reviewed by Yury Semikhatsky.
Source/WebCore:
We have two different types of requestContent methods: one on the source mapping level and one on the resource level.
There are also adapters between the two. I'm aligning it all to a single requestContent method declared in ContentProvider.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didRequestContent):
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
* inspector/front-end/ContentProvider.js: Added.
(WebInspector.ContentProvider):
(WebInspector.ContentProvider.prototype.contentURL):
(WebInspector.ContentProvider.prototype.requestContent):
(WebInspector.ContentProvider.prototype.searchInContent):
(WebInspector.ContentProvider.SearchMatch):
* inspector/front-end/ContentProviders.js:
(WebInspector.ScriptContentProvider.prototype.contentURL):
(WebInspector.ScriptContentProvider.prototype.requestContent):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.contentURL):
(WebInspector.ConcatenatedScriptsContentProvider.prototype.requestContent):
(WebInspector.CompilerSourceMappingContentProvider.prototype.contentURL):
(WebInspector.CompilerSourceMappingContentProvider.prototype.requestContent):
(WebInspector.StaticContentProvider.prototype.contentURL):
(WebInspector.StaticContentProvider.prototype.requestContent):
* inspector/front-end/DebuggerPresentationModel.js:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._getResourceContent):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.requestContent):
* inspector/front-end/NetworkItemView.js:
(WebInspector.RequestContentView.prototype._ensureInnerViewShown.callback):
(WebInspector.RequestContentView.prototype._ensureInnerViewShown):
* inspector/front-end/NetworkRequest.js:
(WebInspector.NetworkRequest.prototype.contentURL):
(WebInspector.NetworkRequest.prototype.requestContent):
(WebInspector.NetworkRequest.prototype.searchInContent):
(WebInspector.NetworkRequest.prototype.populateImageSource):
(WebInspector.NetworkRequest.prototype._innerRequestContent.onResourceContent):
(WebInspector.NetworkRequest.prototype._innerRequestContent):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createContentProvider):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype.contentURL):
(WebInspector.Resource.prototype.requestContent):
(WebInspector.Resource.prototype._innerRequestContent.callback):
(WebInspector.Resource.prototype._innerRequestContent):
(WebInspector.ResourceRevision.prototype.contentURL):
(WebInspector.ResourceRevision.prototype.requestContent.callbackWrapper):
(WebInspector.ResourceRevision.prototype.requestContent):
(WebInspector.ResourceRevision.prototype.searchInContent):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceSourceFrame.prototype.requestContent):
(WebInspector.ResourceSourceFrame.prototype._contentChanged):
(WebInspector.ResourceRevisionSourceFrame.prototype.requestContent):
* inspector/front-end/ScriptFormatter.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.requestVisibleScriptOutline):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.setContent):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype._didRequestContent):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
LayoutTests:
* http/tests/inspector/compiler-script-mapping.html:
* inspector/debugger/content-providers-expected.txt:
* inspector/debugger/content-providers.html:
* inspector/debugger/raw-source-code.html:
* inspector/debugger/ui-source-code.html:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 16 Apr 2012 11:44:41 +0000 (11:44 +0000)]
[Qt] Replace QtXmlPatterns usage with libxslt dependency
<https://bugs.webkit.org/show_bug.cgi?id=76820>
Patch by Andras Piroska <pandras@inf.u-szeged.hu> on 2012-04-16
Reviewed by Simon Hausmann.
The features.prf file was modified, in order to use libxml and libxslt by default.
This modification only work at Qt5.
* qmake/config.tests/libxml2/libxml2.cpp: Added.
(main):
* qmake/config.tests/libxml2/libxml2.pro: Added.
* qmake/config.tests/libxslt/libxslt.cpp: Added.
(main):
* qmake/config.tests/libxslt/libxslt.pro: Added.
* qmake/mkspecs/features/features.prf:
* qmake/sync.profile:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
toyoshim@chromium.org [Mon, 16 Apr 2012 11:32:13 +0000 (11:32 +0000)]
Unreviewed, fix a wrong expected.txt
https://bugs.webkit.org/show_bug.cgi?id=84014
* fast/canvas/webgl/shader-precision-format-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 11:20:27 +0000 (11:20 +0000)]
[EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
https://bugs.webkit.org/show_bug.cgi?id=83862
Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-04-16
Reviewed by Kenneth Rohde Christiansen.
EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
It doesn't work properly because of wrong parameter order in function call.
* EWebLauncher/main.c:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 16 Apr 2012 10:13:00 +0000 (10:13 +0000)]
[Qt] Unreviewed gardening, skip failing tests, because less tests means less problems.
* platform/qt-5.0/Skipped:
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Apr 2012 09:24:29 +0000 (09:24 +0000)]
Unreviewed, GTK rebaseline after r114200.
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 09:04:39 +0000 (09:04 +0000)]
[BlackBerry] Missing readyState 2 when a XMLHttpRequest calls xmlhttp.open("HEAD","notExist.html",true).
https://bugs.webkit.org/show_bug.cgi?id=83866
Source/WebCore:
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-16
Reviewed by George Staikos.
We receive 404 for a XMLHttpRequest which calls open("HEAD", "notExist.html", true).
There are no data received because its method is HEAD.
This case shouldn't be treated as a failure.
Test: http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleNotifyClose):
LayoutTests:
Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-04-16
Reviewed by George Staikos.
* http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404-expected.txt: Added.
* http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 16 Apr 2012 08:56:56 +0000 (08:56 +0000)]
[Chromium] Rebaseline for date-appearance.html.
* platform/chromium-linux/fast/forms/date/date-appearance-expected.png:
* platform/chromium-linux/fast/forms/date/date-appearance-expected.txt:
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-expected.txt: Removed.
* platform/chromium-mac/fast/forms/date/date-appearance-expected.png:
* platform/chromium-mac/fast/forms/date/date-appearance-expected.txt:
* platform/chromium-win/fast/forms/date/date-appearance-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 16 Apr 2012 08:42:52 +0000 (08:42 +0000)]
[Qt]REGRESSION(r114217): It broke fast/repaint/line-flow-with-floats-in-regions.html
https://bugs.webkit.org/show_bug.cgi?id=84013
Unreviewed gardening, skip a failing test to paint the bot green. (Less tests, less problem.)
* platform/qt/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Apr 2012 08:32:00 +0000 (08:32 +0000)]
Unreviewed, GTK baselines for tests added in r114162.
* platform/gtk/ietestcenter/css3/grid/display-grid-001-expected.txt: Added.
* platform/gtk/ietestcenter/css3/grid/display-grid-002-expected.txt: Added.
* platform/gtk/ietestcenter/css3/grid/grid-column-001-expected.txt: Added.
* platform/gtk/ietestcenter/css3/grid/grid-column-002-expected.txt: Added.
* platform/gtk/ietestcenter/css3/grid/grid-column-003-expected.txt: Added.
* platform/gtk/ietestcenter/css3/grid/grid-columns-001-expected.txt: Added.
* platform/gtk/ietestcenter/css3/grid/grid-items-001-expected.txt: Added.
* platform/gtk/ietestcenter/css3/grid/grid-items-002-expected.txt: Added.
* platform/gtk/ietestcenter/css3/grid/grid-items-003-expected.txt: Added.
* platform/gtk/ietestcenter/css3/grid/grid-items-004-expected.txt: Added.
* platform/gtk/ietestcenter/css3/grid/grid-items-005-expected.txt: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jonlee@apple.com [Mon, 16 Apr 2012 08:16:13 +0000 (08:16 +0000)]
Build fix.
* WebCore.exp.in:
* editing/DictationAlternative.cpp:
(WebCore::DictationAlternative::DictationAlternative):
* editing/DictationAlternative.h:
(DictationAlternative):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos@webkit.org [Mon, 16 Apr 2012 08:11:26 +0000 (08:11 +0000)]
Fix signed/unsigned mismatch warning for BlackBerry debug builds.
https://bugs.webkit.org/show_bug.cgi?id=80790
Reviewed by Rob Buis.
* platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::removeCookieAtIndex):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Apr 2012 07:42:36 +0000 (07:42 +0000)]
Unreviewed, GTK gardening.
* platform/gtk/test_expectations.txt: Skip svg failures, unskip
ietestcenter for rebaseline and unflag a flaky media/track test.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Mon, 16 Apr 2012 07:26:27 +0000 (07:26 +0000)]
Unreviewed, GTK gardening.
* Scripts/run-gtk-tests:
(TestRunner): Skip /webkit/atk/textChangedNotifications.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Mon, 16 Apr 2012 07:14:28 +0000 (07:14 +0000)]
Make NullPtr.h compile with clang -std=c++11 and libstdc++4.2
https://bugs.webkit.org/show_bug.cgi?id=83999
Reviewed by Sam Weinig.
Before this patch, NullPtr.h assumed that a working |nullptr| implied
a working |std::nullptr_t| as well. With clang and libstdc++4.2, this
is not true.
I tested (-stdlib=libc++, -stdlib=libstdc++) x (-std=c++11, -std=c++03)
with clang.
* wtf/NullPtr.h:
(std):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 16 Apr 2012 06:37:41 +0000 (06:37 +0000)]
[GTK] Use GRefPtr to delete the default web context in WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=83752
Reviewed by Martin Robinson.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(createDefaultWebContext):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 16 Apr 2012 06:23:51 +0000 (06:23 +0000)]
[Qt] Unreviewed morning gardening.
* platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
* platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
* platform/qt-5.0-wk2/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
* platform/qt-5.0/fast/dom/Window/window-properties-expected.txt: Updated after r114150.
* platform/qt-5.0/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114200.
* platform/qt/Skipped: Skip a test after r114150, because of missing layoutTestController.setBackingScaleFactor().
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt: Updated after r114150.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 16 Apr 2012 06:12:05 +0000 (06:12 +0000)]
WebCore::weekDayShortLabels() for ICU always returns the fallback labels
https://bugs.webkit.org/show_bug.cgi?id=83991
Reviewed by Hajime Morita.
We need to specfiy 1-based index to udat_getSymbols() with
UDAT_SHORT_WEEKDAYS. Also, udat_countSymbols() with UDAT_SHORT_WEEKDAYS
returns 8.
No new tests because this behavior depends on locale setting.
* platform/text/LocalizedCalendarICU.cpp:
(WebCore::createLabelVector): Add startIndex argument.
(WebCore::createMonthLabels):
Pass UDAT_JANUARRY(0) as startIndex to createLabelVector().
(WebCore::createWeekDayShortLabels):
Pass UDAT_SUNDAY(1) as startIndex to createLabelVector().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Mon, 16 Apr 2012 05:21:58 +0000 (05:21 +0000)]
Introduce MenuItemID to autofill popup
https://bugs.webkit.org/show_bug.cgi?id=83777
Introducing MenuItemIDs because we want to add multiple separators and
need to identify non-autofill menu items without resorting to the separator position.
Reviewed by Kent Tamura.
* public/WebAutofillClient.h:
(WebKit::WebAutofillClient::didAcceptAutofillSuggestion): Changed uniqueID to itemID because they aren't unique.
(WebKit::WebAutofillClient::didSelectAutofillSuggestion):
* public/WebView.h:
(WebView):
* src/AutofillPopupMenuClient.cpp:
(WebKit::AutofillPopupMenuClient::AutofillPopupMenuClient):
(WebKit::AutofillPopupMenuClient::getSuggestionsCount):
(WebKit::AutofillPopupMenuClient::getSuggestion):
(WebKit::AutofillPopupMenuClient::getLabel):
(WebKit::AutofillPopupMenuClient::getIcon):
(WebKit::AutofillPopupMenuClient::removeSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::canRemoveSuggestionAtIndex):
(WebKit::AutofillPopupMenuClient::valueChanged):
(WebKit::AutofillPopupMenuClient::selectionChanged):
(WebKit::AutofillPopupMenuClient::itemIsSeparator):
(WebKit::AutofillPopupMenuClient::itemIsWarning):
(WebKit::AutofillPopupMenuClient::initialize):
(WebKit::AutofillPopupMenuClient::setSuggestions):
* src/AutofillPopupMenuClient.h: Removed m_separatorIndex because now we use itemID to identify separators.
Added m_useLegacyBehavior which is true when it is initialized with a valid separator index. This is to keep
the autofill working even when the chromium side hasn't been updated yet.
(AutofillPopupMenuClient):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::applyAutofillSuggestions):
* src/WebViewImpl.h:
(WebViewImpl):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 16 Apr 2012 04:13:59 +0000 (04:13 +0000)]
Unreviewed attempt to chromium-win build fix.
* editing/DictationAlternative.h:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Mon, 16 Apr 2012 03:54:27 +0000 (03:54 +0000)]
Align JSC/V8 bindings canvas.toDataURL() code flows
https://bugs.webkit.org/show_bug.cgi?id=84003
Reviewed by Eric Seidel.
Align JSC/V8 bindings canvas.toDataURL() code flow so that the binding
code implementations read alike.
No new tests. Covered by existing cnavas toDataURL tests.
* bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::toDataURL):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jpu@apple.com [Mon, 16 Apr 2012 03:05:06 +0000 (03:05 +0000)]
Introducing DictationCommand.
https://bugs.webkit.org/show_bug.cgi?id=83549
Reviewed by Hajime Morita.
No new tests. This patch doesn't introduce any change of new functionality. It prepares for
additional changes which will inlude tests.
On OS X, alternative dictation results need to be stored as document markers. This patch introduces
following changes to achieve this:
1. Added DictationMarkDetails to store non-string type maker detail.
2. Introduce DictationCommand, which is similor to TypingCommand, but allows inserting text with
attached markers.
3. Added Editor::insertDictatedText as interaface to WebKit and WebKit2.
4. Added struct DictationAlternative to pass dictation related info from WebKit to WebCore.
Several fragments of code in TypingCommand can be also used by DictationCommand. So this patch
introduced a new class, TextInsertionBaseCommand. It's a subclass of CompositeEditCommmand, and
base class of both TypingCommand and DictationCommand.
This patch also extends InsertTextCommand class. Its constructor will take an TextInsertionMarkerSupplier
object. After text is inserted to a node, InsertTextCommand would give marker supplier a chance to
add document markers to the inserted text.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/Document.cpp:
(WebCore::eventTargetNodeForDocument): Moved this function from EventHandler so that it can be used
by AlternativeTextController.
(WebCore):
* dom/Document.h:
(WebCore):
* dom/DocumentMarker.cpp:
(WebCore::DocumentMarker::DocumentMarker): New constructor that takes a pointer to DocumentMarkerDetails object.
(WebCore):
* dom/DocumentMarker.h:
(WebCore::DocumentMarker::AllMarkers::AllMarkers):
(DocumentMarker):
* dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addMarker):
(WebCore):
* dom/DocumentMarkerController.h:
(DocumentMarkerController):
* dom/TextEvent.cpp:
(WebCore::TextEvent::createForDictation):
(WebCore):
(WebCore::TextEvent::TextEvent):
* dom/TextEvent.h: Added member variable for dictation alternatives.
(TextEvent):
(WebCore::TextEvent::isDictation):
(WebCore::TextEvent::dictationAlternatives):
* dom/TextEventInputType.h:
* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::AlternativeTextController):
(WebCore::AlternativeTextController::insertDictatedText): Used by Editor::insertDictatedText().
(WebCore):
* editing/AlternativeTextController.h:
(WebCore):
(DictationMarkerDetails):
(WebCore::DictationMarkerDetails::create):
(WebCore::DictationMarkerDetails::originalText):
(WebCore::DictationMarkerDetails::dictationContext):
(WebCore::DictationMarkerDetails::DictationMarkerDetails):
(AlternativeTextController):
* editing/CompositeEditCommand.h:
(WebCore::CompositeEditCommand::isDictationCommand):
* editing/DictationAlternative.cpp: Added.
(WebCore):
(WebCore::DictationAlternative::DictationAlternative):
* editing/DictationAlternative.h: Added. Data structure for passing dictation related data from WebKit to WebCore.
(DictationAlternative):
(WebCore):
* editing/DictationCommand.cpp: Added.
(WebCore):
(DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::DictationCommandLineOperation):
(WebCore::DictationCommandLineOperation::operator()):
(DictationMarkerSupplier):
(WebCore::DictationMarkerSupplier::create):
(WebCore::DictationMarkerSupplier::addMarkersToTextNode):
(WebCore::DictationMarkerSupplier::DictationMarkerSupplier):
(WebCore::DictationCommand::DictationCommand):
(WebCore::DictationCommand::insertText):
(WebCore::DictationCommand::doApply):
(WebCore::DictationCommand::insertTextRunWithoutNewlines):
(WebCore::DictationCommand::insertParagraphSeparator):
(WebCore::DictationCommand::collectDictationAlternativesInRange):
* editing/DictationCommand.h: Added.
(WebCore):
(DictationCommand):
(WebCore::DictationCommand::isDictationCommand):
(WebCore::DictationCommand::create):
* editing/EditingAllInOne.cpp:
* editing/Editor.cpp:
(WebCore::Editor::insertDictatedText): Main interface that allows WebKit passes in text with attached dictation information.
(WebCore):
(WebCore::Editor::insertTextWithoutSendingTextEvent):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
* editing/Editor.h:
(Editor):
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::InsertTextCommand):
(WebCore):
(WebCore::InsertTextCommand::doApply):
* editing/InsertTextCommand.h:
(WebCore):
(TextInsertionMarkerSupplier): Interface to allow caller of InsertTextCommand to add document markers to inserted text.
(WebCore::TextInsertionMarkerSupplier::~TextInsertionMarkerSupplier):
(WebCore::TextInsertionMarkerSupplier::TextInsertionMarkerSupplier):
(WebCore::InsertTextCommand::createWithMarkerSupplier):
(InsertTextCommand):
* editing/TextInsertionBaseCommand.cpp: Added. This class contains functions shared by TypingCommand and DictationCommand.
(WebCore):
(WebCore::TextInsertionBaseCommand::TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::applyTextInsertionCommand):
(WebCore::dispatchBeforeTextInsertedEvent):
(WebCore::canAppendNewLineFeedToSelection):
* editing/TextInsertionBaseCommand.h: Added.
(WebCore):
(TextInsertionBaseCommand):
(WebCore::TextInsertionBaseCommand::~TextInsertionBaseCommand):
(WebCore::forEachLineInString):
* editing/TypingCommand.cpp:
(TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::TypingCommandLineOperation):
(WebCore::TypingCommandLineOperation::operator()):
(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparator):
* editing/TypingCommand.h:
* page/EventHandler.cpp:
* rendering/InlineTextBox.cpp:
(WebCore::lineStyleForMarkerType):
(WebCore::InlineTextBox::paintDocumentMarker): Renamed existing function to reflect new funcationality.
(WebCore::InlineTextBox::paintDocumentMarkers):
* rendering/InlineTextBox.h:
(InlineTextBox):
* testing/Internals.cpp:
(WebCore::markerTypesFrom):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Mon, 16 Apr 2012 02:49:53 +0000 (02:49 +0000)]
[chromium] Unreviewed rebaselines for various compositing tests.
* platform/chromium-linux-x86/compositing/reflections/animation-inside-reflection-expected.png: Removed.
* platform/chromium-linux-x86/compositing/reflections/nested-reflection-animated-expected.png: Removed.
* platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
* platform/chromium-linux/compositing/geometry/fixed-position-composited-page-scale-expected.png:
* platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
* platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-linux/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-linux/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-linux/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Added.
* platform/chromium-linux/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Added.
* platform/chromium-mac-leopard/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-leopard/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac-snowleopard/compositing/reflections/animation-inside-reflection-expected.txt: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-mac/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-mac/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-mac/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png.
* platform/chromium-win-vista/compositing/reflections/animation-inside-reflection-expected.png: Removed.
* platform/chromium-win-vista/compositing/reflections/nested-reflection-animated-expected.png: Removed.
* platform/chromium-win-xp/compositing/reflections/animation-inside-reflection-expected.txt: Removed.
* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.png: Removed.
* platform/chromium-win-xp/compositing/reflections/nested-reflection-animated-expected.txt: Added.
* platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-composited-page-scale-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.png:
* platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.png:
* platform/chromium-win/compositing/repaint/newly-composited-repaint-rect-expected.png: Copied from LayoutTests/platform/chromium-win/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 16 Apr 2012 02:44:42 +0000 (02:44 +0000)]
[chromium] LayerRendererChromium shouldn't know anything about CCLayerImpl
https://bugs.webkit.org/show_bug.cgi?id=83415
Patch by James Robinson <jamesr@chromium.org> on 2012-04-15
Reviewed by Adrienne Walker.
Source/WebCore:
This removes all knowledge of CCLayerImpl from LayerRendererChromium. The most significant move code-wise is
moving the HUD up to live on CCLayerTreeHostImpl, since it's aware of the layer tree. This involves two changes.
First, CCHeadsUpDisplay is in charge of populating a ManagedTexture but the actual drawing code now lives in
LayerRendererChromium. Second, since we don't recreate CCLayerTreeHostImpl on a lost context, the font atlas
ownership is much simpler. Now a CCFontAtlas is created on the main thread if needed and passed asynchronously
to the CCHeadsUpDisplay which takes ownership of the atlas.
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::beginDrawingFrame):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::swapBuffers):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromiumClient):
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::CCHeadsUpDisplay):
(WebCore::CCHeadsUpDisplay::setFontAtlas):
(WebCore):
(WebCore::CCHeadsUpDisplay::enabled):
(WebCore::CCHeadsUpDisplay::showPlatformLayerTree):
(WebCore::CCHeadsUpDisplay::draw):
(WebCore::CCHeadsUpDisplay::drawHudContents):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.h:
(WebCore):
(WebCore::CCHeadsUpDisplay::create):
(CCHeadsUpDisplay):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initialize):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::~CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::canDraw):
(WebCore::CCLayerTreeHostImpl::calculateRenderPasses):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::CCLayerTreeHostImpl::drawLayers):
(WebCore::CCLayerTreeHostImpl::swapBuffers):
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
(WebCore::CCLayerTreeHostImpl::setFullRootLayerDamage):
(WebCore::CCLayerTreeHostImpl::layerTreeAsText):
(WebCore):
(WebCore::CCLayerTreeHostImpl::setFontAtlas):
(WebCore::CCLayerTreeHostImpl::dumpRenderSurfaces):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::rootLayer):
* platform/graphics/chromium/cc/CCProxy.h:
(WebCore):
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::recreateContext):
(WebCore::CCSingleThreadProxy::setFontAtlas):
(WebCore):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeLayerRendererOnImplThread):
(WebCore::CCThreadProxy::setFontAtlas):
(WebCore):
(WebCore::CCThreadProxy::setFontAtlasOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
Source/WebKit/chromium:
Add an explicit rootLayer getter to the test implementation of LayerRendererChromium since there isn't one on
the base class any more.
* tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromiumClient::rootLayer):
(FakeLayerRendererChromiumClient):
(TEST_F):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Mon, 16 Apr 2012 02:40:23 +0000 (02:40 +0000)]
Capture CSS parser context
https://bugs.webkit.org/show_bug.cgi?id=83998
Source/WebCore:
Reviewed by Andreas Kling.
Currently the CSS parser calls to the Document and StyleSheetInternal objects to get settings, base URL etc.
The required information should be passed in on parser construction instead. The parser should not need to
know about the document at all.
The patch adds CSSParserContext struct that captures the parsing context. StyleSheetInternal saves the
parsing context and reuses it for any further parsing.
If the same stylesheet source is parsed with an identical context then the resulting stylesheet structure will
be identical. This will allow sharing parsed stylesheets in the future.
* css/CSSGrammar.y:
* css/CSSImportRule.cpp:
(WebCore::StyleRuleImport::setCSSStyleSheet):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::insertRule):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText):
* css/CSSParser.cpp:
(WebCore):
(WebCore::strictCSSParserContext):
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseKeyframeRule):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseSelector):
(WebCore::CSSParser::completeURL):
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseAttr):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseFontFaceSrcURI):
(WebCore::CSSParser::parseFontFaceSrc):
(WebCore::CSSParser::parseBorderImage):
(WebCore::CSSParser::parseImageSet):
(WebCore::CSSParser::parseCustomFilter):
(WebCore::CSSParser::parseFilter):
(WebCore::CSSParser::cssRegionsEnabled):
(WebCore::CSSParser::parseFlowThread):
(WebCore::CSSParser::createMediaRule):
(WebCore::CSSParser::createStyleRule):
(WebCore::CSSParser::createFontFaceRule):
(WebCore::CSSParser::createPageRule):
(WebCore::CSSParser::createKeyframe):
* css/CSSParser.h:
(CSSParser):
(WebCore::CSSParser::inStrictMode):
(WebCore::CSSParser::inQuirksMode):
(WebCore::CSSParser::validUnit):
* css/CSSParserMode.h:
(WebCore):
(CSSParserContext):
* css/CSSRule.h:
(WebCore::CSSRule::parserContext):
(CSSRule):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
* css/CSSStyleSheet.cpp:
(WebCore::StyleSheetInternal::StyleSheetInternal):
(WebCore::StyleSheetInternal::parseString):
(WebCore::StyleSheetInternal::parseStringAtLine):
(WebCore):
(WebCore::StyleSheetInternal::updateBaseURL):
(WebCore::StyleSheetInternal::completeURL):
(WebCore::CSSStyleSheet::insertRule):
* css/CSSStyleSheet.h:
(StyleSheetInternal):
(WebCore::StyleSheetInternal::parserContext):
(WebCore::StyleSheetInternal::charset):
(WebCore::StyleSheetInternal::setFinalURL):
(WebCore::StyleSheetInternal::baseURL):
* css/CSSValuePool.cpp:
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::parseDeclaration):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::insertRule):
* dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
(WebCore::Document::pageUserSheet):
(WebCore::Document::pageGroupUserSheets):
* dom/Element.cpp:
(WebCore::Element::webkitMatchesSelector):
* dom/Node.cpp:
(WebCore::Node::querySelector):
(WebCore::Node::querySelectorAll):
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::parseStyleSheet):
* dom/StyleElement.cpp:
(WebCore::StyleElement::createSheet):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
* html/shadow/ContentSelectorQuery.cpp:
(WebCore::ContentSelectorQuery::ContentSelectorQuery):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
(WebCore::InspectorStyleSheet::reparseStyleSheet):
(WebCore::InspectorStyleSheet::ensureSourceData):
(WebCore::InspectorStyleSheetForInlineStyle::getStyleAttributeRanges):
LayoutTests:
Reviewed by Andreas Kling.
Modify the tests so that they don't expect settings changes to apply to already existing stylesheets.
* css3/filters/script-tests/custom-filter-property-parsing.js:
* fast/regions/script-tests/css-regions-disabled.js:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Mon, 16 Apr 2012 02:14:07 +0000 (02:14 +0000)]
[Cairo] Separate image encoding from dataURL construction
https://bugs.webkit.org/show_bug.cgi?id=83975
Reviewed by Martin Robinson.
Remove the implicit assumption that a dataURL is the only desired output format
of the image encoding phase.
No new tests. Covered by existing canvas toDataURL tests.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::writeFunction): Rename closure to output.
(WebCore::encodeImage): Output the encoded image to the provided Vector<char>.
PNG format is only supported per the Cairo encoding MIMETypeRegistry.
(WebCore):
(WebCore::ImageBuffer::toDataURL): Refactor to use encodeImage().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yutak@chromium.org [Mon, 16 Apr 2012 01:43:40 +0000 (01:43 +0000)]
Leak in WebSocketChannel with workers/worker-reload.html (part 2)
https://bugs.webkit.org/show_bug.cgi?id=83749
Reviewed by David Levin.
Source/WebCore:
Second attempt to remove leaks around WorkerThreadableWebSocketChannel.
No new tests, as this patch does not impose any functional change.
* Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::ThreadableWebSocketChannelClientWrapper):
(WebCore::ThreadableWebSocketChannelClientWrapper::failedWebSocketChannelCreation):
(WebCore::ThreadableWebSocketChannelClientWrapper::setFailedWebSocketChannelCreation):
* Modules/websockets/ThreadableWebSocketChannelClientWrapper.h:
Add a boolean flag indicating whether Bridge::initialize() has exited without receiving
a pointer to the peer object.
* Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::create):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::WorkerContextDidInitializeTask):
(WebCore::WorkerThreadableWebSocketChannel::WorkerContextDidInitializeTask::performTask):
Kick mainThreadDestroy() to delete the peer if the bridge has failed to receive
a pointer to the peer (waitForMethodCompletion() exited due to message queue's
termination).
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
* Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WorkerThreadableWebSocketChannel):
Make WorkerContextDidInitializeTask an inner class of WorkerThreadableWebSocketChannel
so it can refer WorkerThreadableWebSocketChannel's static member function (mainThreadDestroy()).
Source/WebKit/chromium:
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::postTaskForModeToWorkerContext):
Correctly propagate the return value of postTaskForModeToWorkerContext().
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sun, 15 Apr 2012 23:15:15 +0000 (23:15 +0000)]
Chromium perf bots should not build
https://bugs.webkit.org/show_bug.cgi?id=83641
Reviewed by Eric Seidel.
Don't build on perf bots to improve the cycle time.
* BuildSlaveSupport/build.webkit.org-config/config.json:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Sun, 15 Apr 2012 15:23:06 +0000 (15:23 +0000)]
Remove empty directory.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rakuco@webkit.org [Sun, 15 Apr 2012 15:21:14 +0000 (15:21 +0000)]
[EFL] Gardening. Skip fast/regions tests.
SVN r90067 skipped fast/regions for many ports, but EFL's skipped
list was added later. Skip all tests there and remove existing
baselines.
* platform/efl/Skipped:
* platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
* platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Removed.
* platform/efl/fast/regions/flow-content-basic-vertical-expected.png: Removed.
* platform/efl/fast/regions/flow-content-basic-vertical-expected.txt: Removed.
* platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.png: Removed.
* platform/efl/fast/regions/flow-content-basic-vertical-rl-expected.txt: Removed.
* platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.png: Removed.
* platform/efl/fast/regions/flows-dependency-dynamic-remove-expected.txt: Removed.
* platform/efl/fast/regions/flows-dependency-same-flow-expected.png: Removed.
* platform/efl/fast/regions/flows-dependency-same-flow-expected.txt: Removed.
* platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Removed.
* platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
* platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed.
* platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
* platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt: Removed.
* platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Removed.
* platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt: Removed.
* platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Removed.
* platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.txt: Removed.
* platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Removed.
* platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.txt: Removed.
* platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.txt: Removed.
* platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Removed.
* platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.txt: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/efl/fast/regions/text-region-split-small-pagination-expected.png: Removed.
* platform/efl/fast/regions/text-region-split-small-pagination-expected.txt: Removed.
* platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
* platform/efl/fast/regions/top-overflow-out-of-second-region-expected.txt: Removed.
* platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
* platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
* platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
* platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.txt: Removed.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.txt: Removed.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
* platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eae@chromium.org [Sun, 15 Apr 2012 03:51:21 +0000 (03:51 +0000)]
Fix pixelSnapping for CalendarPicker, MediaControl and ScrollbarPart
https://bugs.webkit.org/show_bug.cgi?id=83929
Reviewed by Eric Seidel.
Update CalendarPickerElement and MediaControlElements to use
pixelSnappedSize in preparation for turning on subpixel support.
Update RenderScrollbarPart to pixel snap rect before painting to ensure
that it is painted on device pixel boundaries.
No new tests, no change in functionality.
* html/shadow/CalendarPickerElement.cpp:
(WebCore::CalendarPickerElement::openPopup):
* html/shadow/MediaControlElements.cpp:
(WebCore::RenderMediaVolumeSliderContainer::layout):
* rendering/RenderScrollbarPart.cpp:
(WebCore::RenderScrollbarPart::paintIntoRect):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Sun, 15 Apr 2012 03:31:43 +0000 (03:31 +0000)]
Day of week labels are wrong if WebCore::firstDayOfWeek() is not 0
https://bugs.webkit.org/show_bug.cgi?id=83990
Reviewed by Kentaro Hara.
We passed the "weekStartDay" property value as a
string. CalendarPickerElement::writeDocument() created:
weekStartDay: "1",
and the JavaScript code used it in the following code:
dayLabels[(weekStartDay + i) % 7]
If weekStartDay was "1", the expression (weekStartDay + i)
produced "10", "11", "12", ... We expected "1", "2", "3", ...
We need to pass the "weekStartDay" property as a number.
No new tests because we have no ways to test this for now. We'll
introduce tests for the calendar picker later.
* html/shadow/CalendarPickerElement.cpp:
(WebCore::addProperty): Add addProperty() function for a number.
(WebCore::CalendarPickerElement::writeDocument):
Pass a number, not a serialized number.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sun, 15 Apr 2012 00:43:38 +0000 (00:43 +0000)]
Harden WTF::ByteArray::create()
https://bugs.webkit.org/show_bug.cgi?id=83318
Reviewed by Maciej Stachowiak.
* wtf/ByteArray.cpp:
(WTF::ByteArray::create):
Add overflow check. I don't believe there is anyway to trigger this currently,
hence no tests, so this should be considered hardening.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 21:29:05 +0000 (21:29 +0000)]
Viewport-percentage Length units does not work for Replaced elements size
https://bugs.webkit.org/show_bug.cgi?id=83425
Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.
Added the support for viewport-percentage length units while calculating the width/height of replaced elements.
Source/WebCore:
Tests: css3/viewport-percentage-lengths/viewport-percentage-image-size.html
* platform/Length.h:
(WebCore::Length::isSpecified):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
LayoutTests:
* css3/viewport-percentage-lengths/resources: Added.
* css3/viewport-percentage-lengths/resources/colorsquare.png: Added.
* css3/viewport-percentage-lengths/viewport-percentage-image-size-expected.html: Added.
* css3/viewport-percentage-lengths/viewport-percentage-image-size.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 21:05:00 +0000 (21:05 +0000)]
CSSStyleDeclaration.getPropertyValue() for 'border-radius' returns null when value is set
https://bugs.webkit.org/show_bug.cgi?id=80736
Patch by Joe Thomas <joethomas@motorola.com> on 2012-04-14
Reviewed by Antti Koivisto.
Added support for fetching the value of 'border-radius' CSS property which was missing.
Source/WebCore:
Test: fast/css/border-radius-property-value.html
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
LayoutTests:
* fast/css/border-radius-property-value-expected.txt: Added.
* fast/css/border-radius-property-value.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 18:29:17 +0000 (18:29 +0000)]
[WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
https://bugs.webkit.org/show_bug.cgi?id=81945
Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-04-14
Reviewed by Dan Bernstein.
Tools:
WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
PageCache to be functional.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):
LayoutTests:
Re-enable 2 tests where WebKitUsesPageCachePreferenceKey is set.
* platform/mac-wk2/Skipped:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 14 Apr 2012 18:15:47 +0000 (18:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=83826
Wrong Font code path was chosen after r114032. The TextRun constructor has an additional argument that
needs to be included if rounding hacks are mentioned.
Reviewed by Dan Bernstein.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::paintItemForeground):
* rendering/break_lines.cpp:
(WebCore::nextBreakablePosition):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
noel.gordon@gmail.com [Sat, 14 Apr 2012 09:34:27 +0000 (09:34 +0000)]
[Cairo] ImageBuffer::toDataURL(): improve error handling, add mimeType ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=83569
Reviewed by Eric Seidel.
No new tests. Covered by exiting fast/canvas/*toDataURL* tests.
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::writeFunction): Return write success or failure with the appropriate
cairo status code per http://cairographics.org/manual/cairo-PNG-Support.html
(WebCore::ImageBuffer::toDataURL): Add mimeType ASSERT()s. <canvas> ensures that
a valid mimeType (supported by the port) is sent to toDataURL() calls. Check for
encoding failure and return "data:," if so.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 06:02:08 +0000 (06:02 +0000)]
[Chromium] Avoid unnecessary full tile updates for checkerboard tiles.
https://bugs.webkit.org/show_bug.cgi?id=83804
Patch by David Reveman <reveman@chromium.org> on 2012-04-13
Reviewed by James Robinson.
Source/WebCore:
Cleanup code that determines if we need to use a buffered update and
avoid buffering of tiles that are not in use by the impl thread.
Tests: CCLayerTreeHostTestAtomicCommitWithPartialUpdate.runMultiThread
TiledLayerChromiumTest.partialUpdates
* platform/graphics/chromium/TiledLayerChromium.cpp:
(UpdatableTile):
(WebCore::UpdatableTile::UpdatableTile):
(WebCore::TiledLayerChromium::pushPropertiesTo):
(WebCore::TiledLayerChromium::tileOnlyNeedsPartialUpdate):
(WebCore::TiledLayerChromium::tileNeedsBufferedUpdate):
(WebCore::TiledLayerChromium::updateTiles):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::bufferedUpdates):
(WebCore):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):
Source/WebKit/chromium:
* tests/CCLayerTreeHostTest.cpp:
(WTF::setLayerPropertiesForTesting):
(WTF):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::beginTest):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::layout):
(WTF::setTestLayerPropertiesForTesting):
(WTF::CCLayerTreeHostTestLayerOcclusion::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestManySurfaces::beginTest):
* tests/TiledLayerChromiumTest.cpp:
(WTF::TEST):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Sat, 14 Apr 2012 03:32:40 +0000 (03:32 +0000)]
[chromium] Cleanup texture memory eviction when LayerTreeHost becomes invisible
https://bugs.webkit.org/show_bug.cgi?id=83899
Reviewed by Adrienne Walker.
When a LTH becomes invisible, the texture eviction is spread out across
two different functions and is not entirely clear. We move all the logic
together into a single place in didBecomeInvisibleOnImplThread() and
make the consequences of the current code more clear.
Covered by existing tests.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::deleteContentsTexturesOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Sat, 14 Apr 2012 03:07:21 +0000 (03:07 +0000)]
[chromium] There is no Color(float, float, float) constructor, fix an attempt to call it.
https://bugs.webkit.org/show_bug.cgi?id=83920
Reviewed by James Robinson.
Found by clang:
third_party/WebKit/Source/WebKit/chromium/tests/LayerChromiumTest.cpp:508:89:error: implicit conversion turns literal floating-point number into integer: 'float' to 'int' [-Werror,-Wliteral-conversion]
EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer->setBackgroundColor(Color(0.4f, 0.4f, 0.4f)));
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
* tests/LayerChromiumTest.cpp:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 03:06:50 +0000 (03:06 +0000)]
Unreviewed, rolling out r114036.
http://trac.webkit.org/changeset/114036
https://bugs.webkit.org/show_bug.cgi?id=83969
Breaks gmail.com causing it to never finish loading (Requested
by danakj on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
Source/WebCore:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::createPrototype):
* bindings/scripts/test/JS/JSTestObj.h:
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8BindingPerContextData.cpp:
(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):
* bindings/v8/V8BindingPerContextData.h:
(V8BindingPerContextData):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/WrapperTypeInfo.h:
(WrapperTypeInfo):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):
* dom/NodeList.idl:
LayoutTests:
* fast/dom/HTMLSelectElement/named-options-expected.txt:
* fast/dom/HTMLSelectElement/script-tests/named-options.js:
* fast/dom/NodeList/node-list-array-class-expected.txt: Removed.
* fast/dom/NodeList/node-list-array-class.html: Removed.
* fast/dom/NodeList/nodelist-item-call-as-function-expected.txt:
* fast/dom/everything-to-string-expected.txt:
* fast/dom/prototype-inheritance-2-expected.txt:
* fast/js/recursion-limit-equal-expected.txt:
* inspector/console/command-line-api-expected.txt:
* inspector/console/console-dir-expected.txt:
* inspector/console/console-format-collections-expected.txt:
* jquery/traversing-expected.txt:
* platform/chromium/fast/dom/HTMLSelectElement/named-options-expected.txt: Removed.
* platform/chromium/fast/dom/everything-to-string-expected.txt: Removed.
* platform/chromium/inspector/console/command-line-api-expected.txt: Removed.
* platform/chromium/inspector/console/console-dir-expected.txt:
* platform/chromium/inspector/console/console-format-collections-expected.txt:
* platform/chromium/jquery/traversing-expected.txt: Removed.
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 03:02:00 +0000 (03:02 +0000)]
[chromium] Add null pointer check to animatePageScale
https://bugs.webkit.org/show_bug.cgi?id=83940
Patch by Alexandre Elias <aelias@google.com> on 2012-04-13
Reviewed by James Robinson.
Add null pointer check to startPageScaleAnimation.
If the root scroll layer goes away in the middle of a page scale
animation, there can be a null pointer access here.
No new tests.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::animatePageScale):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Sat, 14 Apr 2012 02:33:09 +0000 (02:33 +0000)]
Two lineboxcontain tests are failing
https://bugs.webkit.org/show_bug.cgi?id=82742
Reviewed by Ojan Vafai.
* platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
* platform/mac/fast/block/lineboxcontain/glyphs-expected.txt:
Rebaselined.
* platform/mac/Skipped:
* platform/mac/test_expectations.txt:
Unskip some tests that are either rebaselined or now passing due to
r112582 re-adding some of the RenderLayers removed by r110072.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Sat, 14 Apr 2012 01:58:23 +0000 (01:58 +0000)]
[chromium] Replicas should be included in the computed occlusion
https://bugs.webkit.org/show_bug.cgi?id=82262
Reviewed by Adrienne Walker.
Source/WebCore:
When merging a surface's occlusion up to its target, make a copy of it
where the replica will be as well, and make sure that occlusion from a
RenderSurface does not leave its clipRect.
Unit test: CCOcclusionTrackerTestReplicaDoesOcclude
CCOcclusionTrackerTestReplicaWithClipping
CCOcclusionTrackerTestSurfaceChildOfSurface
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::hasReplica):
(WebCore):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::transformSurfaceOpaqueRegion):
(WebCore::::leaveToTargetRenderSurface):
Source/WebKit/chromium:
* tests/CCOcclusionTrackerTest.cpp:
(CCOcclusionTrackerTestReplicaDoesOcclude):
(WebKitTests::CCOcclusionTrackerTestReplicaDoesOcclude::runMyTest):
(WebKitTests):
(CCOcclusionTrackerTestReplicaWithClipping):
(WebKitTests::CCOcclusionTrackerTestReplicaWithClipping::runMyTest):
(CCOcclusionTrackerTestSurfaceChildOfSurface):
(WebKitTests::CCOcclusionTrackerTestSurfaceChildOfSurface::runMyTest):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 01:30:36 +0000 (01:30 +0000)]
Add layout test case for JavaScriptAudioNode.
https://bugs.webkit.org/show_bug.cgi?id=83747
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.
* webaudio/javascriptaudionode-expected.txt: Added.
* webaudio/javascriptaudionode.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 01:29:00 +0000 (01:29 +0000)]
Unreviewed, rolling out r114185.
http://trac.webkit.org/changeset/114185
https://bugs.webkit.org/show_bug.cgi?id=83967
Broke a bunch of JavaScript related tests (Requested by
andersca on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-13
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
* runtime/CommonIdentifiers.h:
* tests/mozilla/ecma/Array/15.4.4.2.js:
(getTestCases):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 01:27:13 +0000 (01:27 +0000)]
convolution-mono-mono test passes now
https://bugs.webkit.org/show_bug.cgi?id=83793
Patch by Raymond Toy <rtoy@google.com> on 2012-04-13
Reviewed by Eric Seidel.
* platform/chromium/test_expectations.txt: Delete entry.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 01:25:30 +0000 (01:25 +0000)]
AudioContext createChannelMerger() method should have optional argument for number of inputs.
https://bugs.webkit.org/show_bug.cgi?id=83759
Patch by Raymond Liu <raymond.liu@intel.com> on 2012-04-13
Reviewed by Chris Rogers.
Check https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html for the optional argument.
Source/WebCore:
Test: webaudio/audiochannelmerger-basic.html
* Modules/webaudio/AudioChannelMerger.cpp:
(WebCore):
(WebCore::AudioChannelMerger::create):
(WebCore::AudioChannelMerger::AudioChannelMerger):
* Modules/webaudio/AudioChannelMerger.h:
(AudioChannelMerger):
* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::createChannelMerger):
(WebCore):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/AudioContext.idl:
LayoutTests:
* webaudio/audiochannelmerger-basic-expected.txt: Added.
* webaudio/audiochannelmerger-basic.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Sat, 14 Apr 2012 01:20:33 +0000 (01:20 +0000)]
Don't rely on fixed offsets to patch calls
https://bugs.webkit.org/show_bug.cgi?id=83966
Rubber stamped by Oliver Hunt.
These aren't being used anywhere!
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
danakj@chromium.org [Sat, 14 Apr 2012 00:42:00 +0000 (00:42 +0000)]
[chromium] Remove viewport memory restrictions
https://bugs.webkit.org/show_bug.cgi?id=83316
Reviewed by Adrienne Walker.
We remove the memory restriction on web pages based on viewport size
on desktop. This is causing pages that have complex use of layers to
end up hitting our memory limits, and moreso when the window is small.
Page complexity is not really a function of the viewport size.
We drop the mininum memory limit entirely, and just evict all
unprotected textures instead.
Covered by existing tests.
* platform/graphics/chromium/TextureManager.cpp:
(WebCore::TextureManager::highLimitBytes):
(WebCore::TextureManager::reclaimLimitBytes):
* platform/graphics/chromium/TextureManager.h:
(TextureManager):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::beginCommitOnImplThread):
(WebCore::CCLayerTreeHost::setVisible):
(WebCore::CCLayerTreeHost::didBecomeInvisibleOnImplThread):
(WebCore::CCLayerTreeHost::updateLayers):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 00:38:25 +0000 (00:38 +0000)]
Optimize tracking of intruding floats being removed from RenderBlock during layout
https://bugs.webkit.org/show_bug.cgi?id=82928
Patch by Ken Buchanan <kenrb@chromium.org> on 2012-04-13
Reviewed by David Hyatt.
Performance tweaks in RenderBlock layout as a follow up to r112935.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloats):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Sat, 14 Apr 2012 00:36:10 +0000 (00:36 +0000)]
[CSSRegions]Implement NamedFlow::contentNodes attribute
https://bugs.webkit.org/show_bug.cgi?id=80134
Reviewed by David Hyatt.
Source/WebCore:
The named flow content nodes collection contains those nodes with webkitFlowInto property set to 'flow'.
In the list, the nodes are placed in document order. Nodes with display:none are also part of the list.
The list of nodes is returned as a static node list.
The content nodes are stored in RenderNamedFlowThread. The content nodes are added to the list in NodeRenderingContext::moveToFlowThreadIfNeeded
and removed from the list in Element::detach. When an element -webkit-flow-into property is changed, the element is detached and attached.
I have also added a bit in NodeFlags to mark that an element is part of a named flow (and the corresponding inNamedFlow/setInNamedFlow/clearInNamedFlow functions).
Test: fast/regions/webkit-named-flow-content-nodes.html
* dom/Document.cpp:
(WebCore::Document::webkitGetFlowByName):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::detach):
* dom/Node.h:
(WebCore::Node::inNamedFlow):
(WebCore::Node::setInNamedFlow):
(WebCore::Node::clearInNamedFlow):
(Node):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
* dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::contentNodes):
(WebCore):
* dom/WebKitNamedFlow.h:
(WebKitNamedFlow):
* dom/WebKitNamedFlow.idl:
* rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::registerNamedFlowContentNode):
(WebCore):
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
* rendering/FlowThreadController.h:
(FlowThreadController):
* rendering/RenderNamedFlowThread.cpp:
(WebCore):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentNode):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentNode):
* rendering/RenderNamedFlowThread.h:
(WebCore):
(RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::contentNodes):
(WebCore::RenderNamedFlowThread::hasContentNode):
LayoutTests:
* fast/regions/webkit-named-flow-content-nodes-expected.txt: Added.
* fast/regions/webkit-named-flow-content-nodes.html: Added.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Sat, 14 Apr 2012 00:34:19 +0000 (00:34 +0000)]
Remove the calls to CRASH() from ResourceLoader.cpp.
https://bugs.webkit.org/show_bug.cgi?id=83962
Reviewed by Alexey Proskuryakov.
They were added in r91316 to aid debugging for the issue fixed in r105556 and r106130.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::willSendRequest):
(WebCore::ResourceLoader::didSendData):
(WebCore::ResourceLoader::didReceiveResponse):
(WebCore::ResourceLoader::didReceiveData):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):
(WebCore::ResourceLoader::shouldUseCredentialStorage):
(WebCore::ResourceLoader::willCacheResponse):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Sat, 14 Apr 2012 00:33:09 +0000 (00:33 +0000)]
REGRESSION(r102190) [chromium] text rendering (font and font size) in some Arabic/Persian page is wrong
when using certain fonts
https://bugs.webkit.org/show_bug.cgi?id=83523
Reviewed by Kent Tamura.
Revert r102190.
Convert characters being treatAsSpace to white space.
* platform/graphics/chromium/UniscribeHelper.cpp:
(WebCore::UniscribeHelper::fillRuns):
(WebCore::UniscribeHelper::adjustSpaceAdvances):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 00:27:34 +0000 (00:27 +0000)]
[chromium] Remove fallback code for "Missing plug-in" string.
https://bugs.webkit.org/show_bug.cgi?id=81907
Patch by Bernhard Bauer <bauerb@google.com> on 2012-04-13
Reviewed by Adam Barth.
* src/LocalizedStrings.cpp:
(WebCore::missingPluginText):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 14 Apr 2012 00:26:25 +0000 (00:26 +0000)]
Array.prototype.toString and Array.prototype.toLocaleString should be generic
https://bugs.webkit.org/show_bug.cgi?id=81588
Patch by Hojong Han <hojong.han@samsung.com> on 2012-04-13
Reviewed by Gavin Barraclough.
* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToString):
(JSC::arrayProtoFuncToLocaleString):
* runtime/CommonIdentifiers.h:
* tests/mozilla/ecma/Array/15.4.4.2.js:
(getTestCases.array.item.new.TestCase):
(getTestCases):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sat, 14 Apr 2012 00:11:16 +0000 (00:11 +0000)]
Change how the Web Insector is installed on Mac builds.
<rdar://problem/
10857918>
Reviewed by Mark Rowe.
* WebCore.xcodeproj/project.pbxproj: Updated Copy Inspector Resources
and Streamline Inspector Source build phases.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 13 Apr 2012 23:44:25 +0000 (23:44 +0000)]
Don't rely on fixed offsets to patch method checks
https://bugs.webkit.org/show_bug.cgi?id=83958
Reviewed by Oliver Hunt.
* bytecode/StructureStubInfo.h:
- Add fields for the method check info.
* jit/JIT.cpp:
(JSC::PropertyStubCompilationInfo::copyToStubInfo):
- Store the offsets on the stub info, instead of asserting.
* jit/JIT.h:
- Delete all the method check related offsets.
* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
- Use the offset from the stubInfo.
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- Pass the stubInfo to patchMethodCallProto.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 13 Apr 2012 23:44:05 +0000 (23:44 +0000)]
Rebaseline some compositing tests. Some were affected by the colorspace of
the sample image changing.
* compositing/images/direct-pdf-image-expected.png:
* compositing/repaint/newly-composited-repaint-rect-expected.png:
* compositing/visibility/visibility-image-layers-expected.png:
* compositing/visibility/visibility-simple-video-layer-expected.png:
* platform/mac/compositing/reflections/reflection-in-composited-expected.png:
* platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 13 Apr 2012 23:43:01 +0000 (23:43 +0000)]
fast/dom/Window/window-property-descriptors.html is too much work to maintain
https://bugs.webkit.org/show_bug.cgi?id=83915
Reviewed by Alexey Proskuryakov.
The goal of this test is to remind us whenever we add something to the
global scope. In practice, however, this test is a lot of work to
maintain because every port has different features enabled, which means
every port has a different list of things in the global scope. It's
very difficult to make changes without causing this test to go red on a
number of bots.
Rather than use this test to monitor the global scope, we're better off
paying attention to the IDL files. If folks are interested in changes
to what is exposed to JavaScript, they can subscribe to IDL changes
using a watchlist. (That's what I do, and it works pretty well.)
* fast/dom/Window/script-tests/window-property-descriptors.js: Removed.
* fast/dom/Window/window-property-descriptors.html: Removed.
* platform/chromium/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/efl/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Removed.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt: Removed.
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@114181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc