Amitesh Singh [Sat, 19 Aug 2017 07:32:08 +0000 (16:32 +0900)]
elm segment control: delete event cbs on obj delete.
@fix
Derek Foreman [Fri, 18 Aug 2017 19:13:11 +0000 (14:13 -0500)]
wayland: Tick like a boss
Instead of the clever but awful manual_render_set hack, actually do ticks
based on frame callbacks.
Fix T5850
Derek Foreman [Thu, 17 Aug 2017 20:43:50 +0000 (15:43 -0500)]
ecore_wl2: Send configure complete when windows don't need configure
The intent of the "configure complete" event is to indicate that the
window is configured and ready to receive buffers.
For "windows" like mouse cursors, that's immediate - let them know.
Derek Foreman [Thu, 17 Aug 2017 20:42:41 +0000 (15:42 -0500)]
ecore_wl2: Refactor out code to send window configure complete event
Derek Foreman [Thu, 17 Aug 2017 20:20:44 +0000 (15:20 -0500)]
wayland_egl: Call ecore_wl2_window_buffer_attach
This lets ecore_wl2 know that there's a buffer attached - even if we don't
know what it is because it's hidden by gl.
Derek Foreman [Thu, 17 Aug 2017 20:12:57 +0000 (15:12 -0500)]
wayland_shm: Use ecore_wl2_window_buffer_attach
No longer calling wl_surface_attach directly.
Derek Foreman [Thu, 17 Aug 2017 20:12:19 +0000 (15:12 -0500)]
wayland_shm: Don't attach null buffers from surface_post
This is protected against elsewhere.
Derek Foreman [Thu, 17 Aug 2017 20:10:59 +0000 (15:10 -0500)]
ecore_wl2: Add ecore_wl2_window_buffer_attach API
Let ecore_wl2 track some buffer related state so we can more easily sync
things between ecore_evas and the evas_engines.
Derek Foreman [Mon, 14 Aug 2017 23:50:15 +0000 (18:50 -0500)]
wayland_egl: Add ecore_wl2_window_commit
Use ecore_wl2_window_commmit() in addition to eglSwapBuffers in order
to set up a frame callback and handle pending update tracking.
Derek Foreman [Mon, 14 Aug 2017 23:48:58 +0000 (18:48 -0500)]
wayland: Switch to ecore_wl2_window_commit()
Use ecore_wl2_window_commit() instead of directly calling wl_surface_commit
Derek Foreman [Mon, 14 Aug 2017 23:21:22 +0000 (18:21 -0500)]
wayland_shm: Remove direct access to wl_surface
Querying it through Ecore_Wl2_Window now
Derek Foreman [Mon, 14 Aug 2017 22:46:49 +0000 (17:46 -0500)]
ecore_wl2: Add new APIs ecore_wl2_window_frame_callback_add/del()
Abstract frame callbacks through ecore_wl2_window so we can add them in
multiple places without having the wayland compositor generate more than
one.
Also allows us to keep a callback registered over hide/unhide of a window
easily.
Derek Foreman [Mon, 14 Aug 2017 22:45:41 +0000 (17:45 -0500)]
ecore_wl2: Add API ecore_wl2_window_pending_get()
Lets us test if a commit has been requested but the compositor hasn't
yet told use to draw new content for it.
Derek Foreman [Mon, 14 Aug 2017 22:44:13 +0000 (17:44 -0500)]
ecore_wl2: Add API ecore_wl2_window_commit()
Abstract wl_surface commits in ecore_wl2_window.
Derek Foreman [Mon, 14 Aug 2017 22:07:31 +0000 (17:07 -0500)]
wayland: Put Ecore_Wl2_Win instead of wl_surface into the engines
We'll need to track some state in a common way, so attaching it to the
window seems like a good idea.
Derek Foreman [Mon, 14 Aug 2017 21:27:24 +0000 (16:27 -0500)]
wayland: Make the wayland evas engines dependent on ecore_wl2
Seems like the best place to put some common code.
Mike Blumenkrantz [Fri, 18 Aug 2017 19:24:51 +0000 (15:24 -0400)]
wayland: fix num/caps lock handling in events
locks are not the same as modifiers, and the corresponding event flag must
be set based on whichever value(s) are set instead of yolo mixing and matching
@fix
ref T5737
Mike Blumenkrantz [Fri, 18 Aug 2017 19:24:51 +0000 (15:24 -0400)]
theme: handle e dialog sizing when no buttons are present
@fix
Mike Blumenkrantz [Fri, 18 Aug 2017 19:24:51 +0000 (15:24 -0400)]
evas: make top object returning functions return the top object
this previously just returned the top clipper at the specified points
@fix
Bryce Harrington [Fri, 18 Aug 2017 13:48:59 +0000 (09:48 -0400)]
ecore_sdl: Add API doc for ecore_sdl_feed_events
Reviewers: cedric, devilhorns
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5097
Bryce Harrington [Fri, 18 Aug 2017 13:47:45 +0000 (09:47 -0400)]
examples: Improve error message text from Evas examples
Reviewers: cedric, devilhorns
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5103
Bryce Harrington [Fri, 18 Aug 2017 13:46:48 +0000 (09:46 -0400)]
examples/evas: Fix sp. of 'Coult' in warning
Reviewers: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5102
Jean-Philippe Andre [Fri, 18 Aug 2017 07:36:50 +0000 (16:36 +0900)]
elm_color_class: Save all cc overlays
It seems that cc overlays that didn't change got lost in the process of
saving elm_config and then reloading it (automatically happens because
the file changed... which we just wrote to).
Fixes T3682
Jean-Philippe Andre [Fri, 18 Aug 2017 07:48:56 +0000 (16:48 +0900)]
colorselector: Fix invalid API (orient vs. dir)
Jean-Philippe Andre [Fri, 18 Aug 2017 07:10:36 +0000 (16:10 +0900)]
vieet: Add read-only mode
Really ugly scripting right there.
Jean-Philippe Andre [Fri, 18 Aug 2017 06:50:24 +0000 (15:50 +0900)]
elm_config: Add env var to skip profile save
This only skips writing the profile name to
~/.elementary/config/profile.cfg
This allows easier testing of elementaryt apps (and E) with custom
profiles.
export ELM_PROFILE_NOSAVE=1
Jean-Philippe Andre [Fri, 18 Aug 2017 06:00:27 +0000 (15:00 +0900)]
elm_test: Fail nicely if plug can't connect
This makes sure that
elementary_test -to "Window Plug"
exits nicely (with the exit policy on all window close) instead of
hanging forever with an invisible window.
@fix
Jean-Philippe Andre [Fri, 18 Aug 2017 05:53:20 +0000 (14:53 +0900)]
ecore_evas_extn: Fix socket & plug windows
Socket & Plug were broken after
38e6780262906ffd8f6ad8de7c8a4286.
Multiple problems here:
- The invalid path was used for the lock file.
- The invalid buffer ID was used for unlock in render_post. That's
because the buffer was switched during output_flush which happens
before render_post. So the buffer would remain locked forever on the
server side (unless maybe some animation was happening there).
@fix
Cedric BAIL [Thu, 17 Aug 2017 22:02:11 +0000 (15:02 -0700)]
evas: do not double include interface.
This lead to unproperly defined symbol (as they should be build in libefl) on
windows with actually no need for it.
Bryce Harrington [Thu, 17 Aug 2017 14:45:35 +0000 (10:45 -0400)]
evas: Fix spelling/grammar errors
Summary:
Fixes some basic punctuation and grammar errors, corrects spelling and
word order/choice in various places.
Reviewers: devilhorns
Reviewed By: devilhorns
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5098
Bryce Harrington [Thu, 17 Aug 2017 14:44:05 +0000 (10:44 -0400)]
evas: Drop excessive use of 'just' and 'which'
Reviewers: cedric, devilhorns
Reviewed By: devilhorns
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5099
Bryce Harrington [Thu, 17 Aug 2017 14:43:08 +0000 (10:43 -0400)]
evas_rectangle_main: Whitespace cleanup
Summary: Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>
Reviewers: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5100
Bryce Harrington [Thu, 17 Aug 2017 14:41:26 +0000 (10:41 -0400)]
elput: Fix @brief's in docs
Summary:
It is not necessary to specify @brief since the first line will
automatically be used, but if it is used it should be only for the brief
description, not the detailed description.
Also reformat other docs in this file to follow convention for the brief
docs.
Reviewers: cedric
Subscribers: jpeg
Differential Revision: https://phab.enlightenment.org/D5101
Guilherme Iscaro [Wed, 16 Aug 2017 14:12:47 +0000 (11:12 -0300)]
Elm Examples: Fix undefined function references.
They were renamed by
599bb616ec5
Signed-off-by: Jean-Philippe Andre <jp.andre@samsung.com>
Jean-Philippe Andre [Wed, 16 Aug 2017 11:04:07 +0000 (20:04 +0900)]
evas: Fix auto-show of EO objects
Objects show should happen as early as possible during the render cycle,
as it affects smart objects calculation and everything else.
Thanks @JackDanielZ for the report!
Fixes T5880
Thiep Ha [Thu, 17 Aug 2017 00:53:30 +0000 (09:53 +0900)]
ui.box: add aspect ratio support
Adding support for aspect ratio.
ref T5487
Thiep Ha [Wed, 16 Aug 2017 22:56:23 +0000 (07:56 +0900)]
ui.box: Add handling for weight + align
Issue: If the item has weight and non-filled align, item is not resized.
This patch fixes this issue.
Test: elementary_test -> ui.box -> Equal weight. Buttons Btn1, BtnA, B, C
do not resize when resize the window.
ref T5487
Jean-Philippe Andre [Wed, 16 Aug 2017 05:06:51 +0000 (14:06 +0900)]
evas: Fix crash with filters
Since the EO APIs are defined as weak symbols, invalid definitions of
EAPI lead to runtime crashes on non-public APIs. This is a fix following
a series of changes wrt. EAPI definitions.
Gustavo Sverzut Barbieri [Tue, 15 Aug 2017 21:59:50 +0000 (18:59 -0300)]
value size is stored in type, no need to manually specify them.
Vincent Torri [Tue, 15 Aug 2017 14:42:13 +0000 (16:42 +0200)]
ector: fix EAPI on Windows
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Cedric BAIL [Tue, 15 Aug 2017 20:46:38 +0000 (13:46 -0700)]
eina: remove tests and benchmark for long dead mempool.
Cedric BAIL [Tue, 15 Aug 2017 20:46:38 +0000 (13:46 -0700)]
eina: add tests for from.
Cedric BAIL [Tue, 15 Aug 2017 20:46:37 +0000 (13:46 -0700)]
eina: add support for from in pass through
Cedric BAIL [Tue, 15 Aug 2017 20:46:37 +0000 (13:46 -0700)]
eina: add support for from in one big.
Cedric BAIL [Tue, 15 Aug 2017 20:46:36 +0000 (13:46 -0700)]
eina: add support for from in chained mempool.
Cedric BAIL [Tue, 15 Aug 2017 20:46:34 +0000 (13:46 -0700)]
eina: add an API to check if a pointer is a valid element of a mempool.
Vincent Torri [Mon, 14 Aug 2017 13:50:03 +0000 (15:50 +0200)]
eio: fix correct stat structure on Windows 32 bits
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Mon, 14 Aug 2017 05:07:05 +0000 (07:07 +0200)]
build: don't pass -fPIC on Windows
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Sun, 13 Aug 2017 21:21:39 +0000 (23:21 +0200)]
ecore_evas: win32 module - fix possibly uninitialized variables
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Sun, 13 Aug 2017 19:11:02 +0000 (21:11 +0200)]
evas: move EAPI undef to the correct place
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Sun, 13 Aug 2017 19:10:33 +0000 (21:10 +0200)]
evas: undef EAPI properly.
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Vincent Torri [Sun, 13 Aug 2017 19:08:53 +0000 (21:08 +0200)]
evas GDI engine: improve speed
expedite mean value goes from ~125 to ~205
Signed-off-by: Cedric BAIL <cedric@osg.samsung.com>
Derek Foreman [Mon, 14 Aug 2017 16:23:26 +0000 (11:23 -0500)]
wayland: bump wayland protocol version requirement
We need a newer version for recent dmabuf changes.
Mike Blumenkrantz [Mon, 14 Aug 2017 11:24:48 +0000 (07:24 -0400)]
efl: add EFL_VERSION_1_21
indicate that features from this version can be used
Amitesh Singh [Mon, 14 Aug 2017 00:55:38 +0000 (09:55 +0900)]
Efl.ui.panes: move legacy APIs at bottom of file
Cedric Bail [Sat, 12 Aug 2017 17:27:01 +0000 (10:27 -0700)]
Revert "evas: we should be able to access this data during an object being destroyed."
This reverts commit
207cab086f290878cd584e6c61b3cd2696c5fd88.
Better make efl_data_scope_safe_get work during EFL_EVENT_DEL.
Cedric Bail [Sun, 13 Aug 2017 20:14:31 +0000 (13:14 -0700)]
eo: only return NULL when the object is destructed.
There is a problem with the previous version. The object can still be
alive due to the use of manual_free in evas. So you wouldn't be able
for example to remove a callback from an object that hasn't been
destroyed yet. If that callback is triggered by the destruction
of the object, you would end up with an unexpected and impossible to
prevent effect of access after free on a callback that you had removed.
Not sure if that still solve the original problem that the code was
trying to prevent in Ecore_Evas.
Marcel Hollerbach [Sat, 12 Aug 2017 13:19:45 +0000 (15:19 +0200)]
ecore_evas: define the predefine for wl2 instead of wayland
Jihoon Kim [Sat, 12 Aug 2017 01:23:01 +0000 (10:23 +0900)]
ecore_imf/wayland: Check the return value of memory allocation function
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
efl-wl: max size of 0x0 from shell is -1x-1 in efl
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
efl-wl: initialize seat keymap fd to -1
@fix
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
ecore: always set delete_me before removing fd from poll
ensure bad fds don't immediately get re-added to polling
@fix
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
efl-wl: handle case where eglBindWaylandDisplay fails
@fix
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
efl-wl: always dismiss popups on hide
@fix
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
elm_widget: do not reparent subobjs to top widget for non-elm objects
this breaks handling of non-elm objects and makes it impossible to safely manage
object lifetimes
ref D3957
ref
62cf70034de38b17f2025e08f81b5758b3d6d6e3
@fix
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
efl-wl: use correct accessor method for keyboard resource hash
@fix
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
wayland: set min/max size hints to surface before show
with deferred surface creation the first canvas change of hints may not
be able to trigger protocol methods for size hints, so ensure that hints are
set
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
efl-wl: add functionality for extracting surfaces for external use
@feature
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
efl-wl: add EFL_WL_DEBUG env variable for enabling wayland debug
@feature
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
wayland: remove xdg5 support
this has not been used or tested since last year and there are no major
compositors which lack xdg6 support
Mike Blumenkrantz [Fri, 11 Aug 2017 22:43:15 +0000 (18:43 -0400)]
wayland: fix xdg-shell popup windows
@fix
Derek Foreman [Fri, 11 Aug 2017 22:02:23 +0000 (17:02 -0500)]
ecore_evas_drm: Tick from the animator registration callback
If we're not ticking already when a new animator is started then we have
to wait for a vblank to get a tick. That's not great.
If we can, use the time of the last vblank to generate an immediate tick
to avoid this latency.
Derek Foreman [Fri, 11 Aug 2017 19:51:30 +0000 (14:51 -0500)]
ecore_evas_drm: Let ecore_drm2 track pending page flips
Since the engines can call the flip functions, we need to protect the
ticker from missing those flips. Thus, we let ecore_drm2, which obviously
sees all flips, track them.
Derek Foreman [Fri, 11 Aug 2017 19:48:41 +0000 (14:48 -0500)]
ecore_drm2: Add query for pending pageflip
We've been tracking this in ecore_evas, but ecore_evas isn't the only
caller, and it doesn't know about flips initiated by the evas engines.
Al Poole [Fri, 11 Aug 2017 18:10:10 +0000 (13:10 -0500)]
makefile_evas: fix includes when openjpeg 1.5 and 2.0 are installed.
Reviewers: vtorri
Subscribers: ManMower, cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5084
Cedric Bail [Fri, 11 Aug 2017 17:15:14 +0000 (10:15 -0700)]
evas: we should be able to access this data during an object being destroyed.
So, this is maybe not the best fix. The question is should we be able to
get efl_data_scope_safe_get return the object private data, when we are
currently executing the object EFL_EVENT_DEL callbacks. Right now we don't
and this lead to bug where we wouldn't have been able to destroy a callback
and get that callback triggered later on destroyed data (I had a crash in
terminology). I have switched back to the not _safe_ version which doesn't
enforce this, but that might not be the only place that need a fix.
Vincent Torri [Fri, 11 Aug 2017 08:51:29 +0000 (17:51 +0900)]
evas tests - add Jpeg2000 tests
add tests for loading jp2k files correctly and the images
Marcel Hollerbach [Fri, 11 Aug 2017 08:31:30 +0000 (10:31 +0200)]
efl_ui_focus_manager_calc: fix the class check of the redirect
this came up with a huge load of errors, i havent noticed them last
night. Sorry.
Amitesh Singh [Fri, 11 Aug 2017 05:32:13 +0000 (14:32 +0900)]
Efl.Ui.Panes: rename min_split_ratio to split_ratio_min
Amitesh Singh [Fri, 11 Aug 2017 05:27:27 +0000 (14:27 +0900)]
Efl.Ui.Panes: rename allow_user_size_hints to hint_min_allow
thanks to raster for suggestion.
Thiep Ha [Fri, 11 Aug 2017 05:17:58 +0000 (14:17 +0900)]
common3d: correct converting number to float
Jeonghyun Yun [Fri, 11 Aug 2017 04:55:22 +0000 (13:55 +0900)]
elm_scroller: focus_direction should not be called when scroller focusable and no focusable child
Summary:
when scroller can have focus and scroller's child can't have focus,
there is a problem that scroller is always selected to next focus object.
In this case, it should not enter into _elm_scroller_elm_widget_focus_direction()
Reviewers: woohyun
Subscribers: cedric, jpeg
Differential Revision: https://phab.enlightenment.org/D5085
Sungtaek Hong [Fri, 11 Aug 2017 04:50:56 +0000 (13:50 +0900)]
Cast to double before division during region/coord calculation.
Summary:
int var devided by int is cast to double after devision.
This might cause wrong calculation result.
Reviewers: cedric, jpeg, Jaehyun_Cho
Reviewed By: Jaehyun_Cho
Differential Revision: https://phab.enlightenment.org/D5079
Jean-Philippe Andre [Fri, 11 Aug 2017 01:24:54 +0000 (10:24 +0900)]
win: Prevent crash inside ecore evas callbacks
After any complex call on the window, a foreign evas/efl callback may be
triggered that could delete the window object. This leads to crashes in
queued jobs or even immediately after said callback (right now EO
prevents immediate memory free using eina_freeq or eina_trash so the
effects aren't immediate).
Funnily enough, this was a known issue according to some comments, but
no one bothered fixing it...
In this particular instance, a focus_out job was crashing while trying
to access now-invalid sd data.
I believe some uses of ELM_WIN_DATA_GET() may still be slightly unsafe
but most look like they should be the result of an EO call on the object
(eg. a call to efl_event_callback_call), which ensures the object is
alive.
Fixes T5869
Jean-Philippe Andre [Fri, 11 Aug 2017 01:58:56 +0000 (10:58 +0900)]
eo: Check refs in efl_data_scope_safe_get
This makes sure the object is actually still alive and kicking before
returning any data. Otherwise the "safe" word is a bit of an abuse...
Ref T5869
@fix
Amitesh Singh [Fri, 11 Aug 2017 00:20:21 +0000 (09:20 +0900)]
Efl.Ui.Panes: don't use edje restrict cal to calculate min size
Marcel Hollerbach [Tue, 18 Jul 2017 10:40:17 +0000 (12:40 +0200)]
efl_ui_focus_manager: make focus a property
Marcel Hollerbach [Wed, 5 Jul 2017 10:48:52 +0000 (12:48 +0200)]
efl_ui_focus_manager: split this of tinto a class and a interface
it turns out to be very handy to have a interface for the moving and
border elements, that is unconnected to the way of how widgets are
registering themself.
This for example enables us to get a simple focus manager that just
redirects the call into a internal 2 dimensional data struct
Felipe Magno de Almeida [Thu, 10 Aug 2017 18:52:25 +0000 (15:52 -0300)]
eolian-cxx: Add workaround for clang removing const from parameters
Derek Foreman [Thu, 10 Aug 2017 16:36:38 +0000 (11:36 -0500)]
efl_wl: Update to latest dmabuf protocol version
Weston's dmabuf code continues to be modular enough that we can pull
it in with little change.
This updates us to version 3 of the protocol.
Currently only contains stubs for format queries.
Daniel Kolesa [Thu, 10 Aug 2017 12:10:52 +0000 (14:10 +0200)]
eolian cxx: fix the remaining type errors
Daniel Kolesa [Thu, 10 Aug 2017 11:38:38 +0000 (13:38 +0200)]
eolian cxx: fix build after eolian type api change
Daniel Kolesa [Thu, 10 Aug 2017 10:53:14 +0000 (12:53 +0200)]
ecore, ecore_con: fix const on Eina.Slice
Fixes TODOs from
dd5cdda64b5fd3966718af62d417117942e2f323
after fixing T5024.
Daniel Kolesa [Thu, 10 Aug 2017 10:47:56 +0000 (12:47 +0200)]
eolian: fix tests
Daniel Kolesa [Thu, 10 Aug 2017 10:41:03 +0000 (12:41 +0200)]
eolian: implement proper return type serialization
This accounts for const so that you can't generate functions
that return const values, as that makes no sense.
@fix T5024
Daniel Kolesa [Thu, 10 Aug 2017 10:17:10 +0000 (12:17 +0200)]
elua: update eolian bindings with c type serialization change
Daniel Kolesa [Thu, 10 Aug 2017 10:12:38 +0000 (12:12 +0200)]
eolian: change C type serialization API to account for returns
This will allow proper handling of const.
Amitesh Singh [Thu, 10 Aug 2017 07:48:46 +0000 (16:48 +0900)]
elm test: rename efl.ui.panes test case
Amitesh Singh [Thu, 10 Aug 2017 07:43:30 +0000 (16:43 +0900)]
Efl.Ui.Image: use internal func to detect legacy usage
Amitesh Singh [Thu, 10 Aug 2017 07:29:50 +0000 (16:29 +0900)]
Efl.Ui.Panes: use internal func to detect legacy usage
Ref T5359