Chandramouleswaran [Sun, 31 May 2020 22:06:11 +0000 (15:06 -0700)]
Fix ActivitySource to log the right amount of stopped (#37211)
* Fix ActivitySource to log the right amount of stopped
* Fix test and typo
Co-authored-by: Chandramouleswaran Ravichandran <chandramouleswaranravichandran@Chandramouleswarans-MacBook-Pro.local>
Steven Yeh [Sun, 31 May 2020 21:17:52 +0000 (16:17 -0500)]
Add Or int? (#37225)
Viktor Hofer [Sun, 31 May 2020 20:42:01 +0000 (22:42 +0200)]
Update Directory.Build.props (#37218)
Remove workaround for https://github.com/microsoft/msbuild/issues/4474.
Zoltan Varga [Sun, 31 May 2020 20:26:12 +0000 (16:26 -0400)]
[wasm] Include the pinvoke table into a separate file, so the generated declarations don't conflict with the ones in the header files included by driver.c. (#37202)
* [wasm] Include the pinvoke table into a separate file, so the generated declarations don't conflict with the ones in the header files included by driver.c.
Same as https://github.com/mono/mono/pull/19853.
* Update src/mono/wasm/runtime/pinvoke.c
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Zoltan Varga [Sun, 31 May 2020 19:54:23 +0000 (15:54 -0400)]
Use the wasm version of System.Console on wasm. (#37221)
Miha Zupan [Sun, 31 May 2020 19:15:45 +0000 (21:15 +0200)]
Reduce Uri ctor overhead (#36915)
* Optimize UriHelper.EscapedAscii
* Contains > IndexOf
* Join CheckForUnicode and CheckForEscapedUnreserved into 1 function
* Rename EscapedAscii to DecodeHexChars
Bruce Forstall [Sun, 31 May 2020 17:49:58 +0000 (10:49 -0700)]
Fix bad documentation links (#37222)
Also, don't make documentation specific to CoreCLR.
Viktor Hofer [Sun, 31 May 2020 17:44:26 +0000 (19:44 +0200)]
Update coverlet version to fix coverage exceptions (#37217)
* Update coverlet version to fix coverage FNFEs
Changelog: https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/Changelog.md#release-date-2020-05-30
-Fix 'The process cannot access the file...because it is being used by another process' due to double flush for collectors driver #https://github.com/coverlet-coverage/coverlet/pull/835
* Update dotnet-tools.json
Bruce Forstall [Sun, 31 May 2020 17:30:19 +0000 (10:30 -0700)]
Reduce duplication in Linux build instructions (#37175)
All the Docker information was duplicated in two places; remove
that duplication.
Stephen Toub [Sun, 31 May 2020 14:19:39 +0000 (10:19 -0400)]
Add SslStream test for zero-byte reads (#37128)
* Add SslStream test for zero-byte reads
We have higher-level tests for libraries like WebSockets that validate the behavior of zero-byte reads, but we don't currently have one in System.Net.Security's tests. Adding one.
* Address PR feedback
Zoltan Varga [Sun, 31 May 2020 13:49:00 +0000 (09:49 -0400)]
Define TargetsUnix for wasm. (#37207)
Egor Bogatov [Sun, 31 May 2020 13:28:47 +0000 (16:28 +0300)]
[mono] Enable parallel mode for xunit on Android by default (#37058)
dotnet-maestro[bot] [Sat, 30 May 2020 23:53:16 +0000 (16:53 -0700)]
[master] Update dependencies from dotnet/arcade Microsoft/vstest (#37200)
* Update dependencies from https://github.com/dotnet/arcade build
20200528.4
Microsoft.DotNet.XUnitExtensions , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.ApiCompat , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk , Microsoft.DotNet.Build.Tasks.TargetFramework.Sdk , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.XUnitConsoleRunner
From Version 5.0.0-beta.20261.9 -> To Version 5.0.0-beta.20278.4
* Update dependencies from https://github.com/microsoft/vstest build
20200529-01
Microsoft.NET.Test.Sdk
From Version 16.7.0-preview-
20200521-01 -> To Version 16.7.0-preview-
20200529-01
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Eugene Rozenfeld [Sat, 30 May 2020 23:34:19 +0000 (16:34 -0700)]
Fix fast tail calls on Windows ARM64. (#37192)
LowerFastTailCall has code that looks for incoming stack arguments
that may be overwritten by outgoing stack arguments and copies
them to a temp. The logic was incorrect for Windows Arm64 because it was
assuming shadow space, which only exists in Windows x64 abi.
Fixes #31729.
Fixes #36911.
Jan Kotas [Sat, 30 May 2020 19:20:18 +0000 (12:20 -0700)]
Delete unused file (#37201)
Filip Navara [Sat, 30 May 2020 17:15:58 +0000 (19:15 +0200)]
LowLevelLifoSemaphore: Fix incorrect field offset (#37076)
Fixes #37075
lindexi [Sat, 30 May 2020 17:13:05 +0000 (01:13 +0800)]
Init dictionary with clear count (#37041)
Marek Safar [Sat, 30 May 2020 16:04:26 +0000 (18:04 +0200)]
Use nuint for bytes counter inside SafeBuffer (#37173)
* Use nuint for bytes counter inside SafeBuffer
* One more place to update
Zoltan Varga [Sat, 30 May 2020 15:09:38 +0000 (11:09 -0400)]
Reformat WasmAppBuilder to conform to the coding conventions. NFC. (#37199)
Alexander Köplinger [Sat, 30 May 2020 08:02:50 +0000 (10:02 +0200)]
Bump to updated WebAssembly runner from xharness (#37178)
David Mason [Sat, 30 May 2020 06:36:02 +0000 (23:36 -0700)]
Allow GetReJITIDs calls with NULL to get number of IDs (#37187)
Anton Lapounov [Sat, 30 May 2020 03:39:02 +0000 (20:39 -0700)]
Replace CoreClr issue numbers with Runtime issue links. (#37188)
Also replace tabs with spaces and remove a duplicate entry.
Aaron Robinson [Sat, 30 May 2020 00:59:37 +0000 (17:59 -0700)]
Remove ObsoleteAttribute and EditorBrowsableAttribute (#37184)
Johan Lorensson [Sat, 30 May 2020 00:52:53 +0000 (02:52 +0200)]
Fix Mono C++ build. (#37153)
Jeremy Koritzinsky [Sat, 30 May 2020 00:37:12 +0000 (17:37 -0700)]
Remove built-in WinRT support from the runtime (#36715)
Maoni Stephens [Fri, 29 May 2020 23:57:43 +0000 (16:57 -0700)]
fixed a bug in updating the gen0 budget for AllocateUninitializedArray (#37148)
For AllocateUninitializedArray, we don't consume all the memory we get
from the gen0 budget but we are not putting back the part we don't consume.
This artificial consumption in budget can mean we trigger a GC way too early
when we haven't actually allocated that much.
Youssef Victor [Fri, 29 May 2020 22:35:04 +0000 (00:35 +0200)]
Make H3StaticTable class static (#36222)
* Make class as static
* Update H3StaticTable.cs
* Update H3StaticTable.cs
* Update H3StaticTable.cs
Tarek Mahmoud Sayed [Fri, 29 May 2020 22:28:26 +0000 (15:28 -0700)]
Add activity Ids and Context to log scopes (#37092)
* Add activity Ids and Context to log scopes
* Fix name casing
* Address the feedback
* Address the feedback
* Validate ActivityTrackingOptions input and add test
Vlad Brezae [Fri, 29 May 2020 22:09:11 +0000 (01:09 +0300)]
[interp] Remove assertions from release and add more to debug builds (#37160)
* [interp] Remove some assertions from hot path
We can keep them only for debug builds, where in the future we can add more verbose assertions, like ones for stack overflows.
* [interp] Add more assertions on debug build
Most of the weird interp bugs are due to overflows in the interp stacks. Since we now test interp on CI with debug build, try to catch them early.
Kevin Jones [Fri, 29 May 2020 21:58:04 +0000 (17:58 -0400)]
Fix fixed dictionary sizes in apple crypto key generation
Both dictionaries had a fixed size of two, however three items were being added to it.
This is undefined behavior in the documentation.
Vitek Karas [Fri, 29 May 2020 21:15:46 +0000 (14:15 -0700)]
Allow DynamicallyAccessedMembersAttribute on methods (#36340)
Allow DynamicallyAccessedMembersAttribute on methods
Eric Erhardt [Fri, 29 May 2020 21:09:22 +0000 (16:09 -0500)]
Remove AnonymousType ILLinkTrim entry for EventSource (#37083)
Instead of using an anonymous type to do the logging, just pass the string directly.
Contributes to #35199
dotnet-maestro[bot] [Fri, 29 May 2020 20:46:22 +0000 (20:46 +0000)]
Update dependencies from https://github.com/mono/linker build
20200529.1 (#37157)
Microsoft.NET.ILLink.Tasks
From Version 5.0.0-preview.3.20278.2 -> To Version 5.0.0-preview.3.20279.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Kenneth Pouncey [Fri, 29 May 2020 20:35:37 +0000 (22:35 +0200)]
[browser][wasm] Add initial webassembly instructions document. (#37123)
Aleksey Kliger (λgeek) [Fri, 29 May 2020 19:30:41 +0000 (15:30 -0400)]
[mono] Remove some dead code from Delegate.DynamicInvoke (#37085)
* [mono] Remove some dead code from System.Delegate.DynamicInvokeImpl
Remove some dead code from `System.Delegate.DynamicInvoke`. It should be the
case that `Method` is non-`null` when we call `DynamicInvoke` - the delegate
method should be known at the time of the invoke, and it should not be picked
based on the arguments.
Fixes https://github.com/dotnet/runtime/issues/37008
Dan Moseley [Fri, 29 May 2020 19:27:55 +0000 (12:27 -0700)]
Update area-owners.md (#37171)
Swaroop Sridhar [Fri, 29 May 2020 18:22:43 +0000 (11:22 -0700)]
Merge pull request #37147 from swaroop-sridhar/publishhost
Publish singlefilehost on Linux, Osx, FreeBSD
Bruce Forstall [Fri, 29 May 2020 18:09:05 +0000 (11:09 -0700)]
Fix Linux requirements document (#37145)
Update linux-requirements.md
Fix copy/paste error, update wording related to LLVM APT feed.
John Salem [Fri, 29 May 2020 16:36:18 +0000 (09:36 -0700)]
Add more verbose logging (#37089)
* log out stdout/stderr of subprocess
* instead of using Process.Kill, gracefully exit
Next Turn [Fri, 29 May 2020 10:13:51 +0000 (18:13 +0800)]
Define _FILE_OFFSET_BITS=64 (#33266)
* Define _FILE_OFFSET_BITS=64
* Set unconditionally for all hosts
* Move forward
Swaroop Sridhar [Fri, 29 May 2020 07:09:42 +0000 (00:09 -0700)]
Publish singlefilehost on Linux,Osx,FreeBSD
singlefilehost is currently only published in the microsoft.netcore.app.host.win-x64
Add it to host packages for other platforms.
Alexis Christoforides [Fri, 29 May 2020 02:58:14 +0000 (22:58 -0400)]
[mono] Implement AssemblyBuilder.GetSatelliteAssembly (#36589)
[mono] Implement AssemblyBuilder.GetSatelliteAssembly
Contributes to https://github.com/mono/mono/issues/14788
Immo Landwerth [Thu, 28 May 2020 23:18:36 +0000 (16:18 -0700)]
Merge pull request #37098 from terrajobst/api-review-process
Add information about API review schedule
Immo Landwerth [Thu, 28 May 2020 23:17:47 +0000 (16:17 -0700)]
Reword section
Immo Landwerth [Thu, 28 May 2020 23:14:47 +0000 (16:14 -0700)]
Update docs/project/api-review-process.md
Co-authored-by: Eric StJohn <ericstj@microsoft.com>
Santiago Fernandez Madero [Thu, 28 May 2020 22:57:36 +0000 (15:57 -0700)]
Disable BackgroundWorkerTests.TestFinalization on mono interpreter mode (#37137)
Steve Pfister [Thu, 28 May 2020 22:26:24 +0000 (18:26 -0400)]
Adding arm64 as a platform for the interpreter tests (#37133)
Co-authored-by: Steve Pfister <steve.pfister@microsoft.com>
Alexis Christoforides [Thu, 28 May 2020 22:15:33 +0000 (18:15 -0400)]
[mono] Implement AssemblyBuilder.GetReferencedAssemblies (#36346)
[mono] Implement AssemblyBuilder.GetReferencedAssemblies
Aaron Robinson [Thu, 28 May 2020 20:34:28 +0000 (13:34 -0700)]
GCCoverageInfo support 32-bit Tiered compilation (#37116)
* GCCoverageInfo support 32-bit Tiered compilation
Update the GC coverage info code path to respect Tiered compilation
on a 32-bit platform.
Stephen Toub [Thu, 28 May 2020 20:12:22 +0000 (16:12 -0400)]
Reduce ConcurrentDictionary.TryGetValue overhead (#37081)
* Clean up style in ConcurrentDictionary
No functional changes.
* Optimize ConcurrentDictionary for no comparer as well as value type keys
* Special-case StringComparer.Ordinal in ConcurrentDictionary
* Store repeatedly used fields into locals
* Use FastMod in ConcurrentDictionary
* Allow atomic writes of {U}IntPtr
From ECMA 335:
"The native size types (native int, native unsigned int, and &) are always naturally aligned (4 bytes or 8 bytes, depending on the architecture)"
and
"A conforming CLI shall guarantee that read and write access to properly aligned memory locations no larger than the native word size (the size of type native int) is atomic (see §I.12.6.2) when all the write accesses to a location are the same size. "
* Address PR feedback
Steve Pfister [Thu, 28 May 2020 19:18:00 +0000 (15:18 -0400)]
Add mono interpreter test leg to CI (#35568)
This change enables the interpreter on CI as well as providing an option for the local test run.
Ryan Lucia [Thu, 28 May 2020 19:01:05 +0000 (15:01 -0400)]
[runtime] Fix Mono BStr marshaling, cleanup IL generation (#35804)
* [COM] Set and free BSTR size correctly
Apparently, while the previous 4 bytes contain the size, the actual allocation is either 4 or 8 bytes depending on the platform! See https://github.com/dotnet/runtime/blob/
fcd862e06413a000f9cafa9d2f359226c60b9b42/src/coreclr/tests/src/Common/Platform/platformdefines.cpp#L418
* [meta] Cleanup string marshalling and support additional conversions
* [COM] Align BSTR creation to 16 bytes
* Enable test
* Feedback
* Fix offset
* Add support for AnsiBStr and TBStr marshalling
Also makes BStr changes netcore-only and enables AnsiBStr test. No TBStr test appears to exist.
* String marshaling IL gen refactoring
* Fix Windows build
* Feedback
Taylor Southwick [Thu, 28 May 2020 18:48:08 +0000 (11:48 -0700)]
Use dictionary to track PackageRelationships instead of searching a list (#35978)
This change adds an OrderedDictionary<TKey,TValue> type to System.IO.Packaging to keep a list of relationships that have been added, while ensuring that the ids are unique with decent performance characteristics. The current implementation searches a list which gets really slow with large numbers of relationships. A Dictionary by itself does not work for this as the order of addition is important. Thus, this combines a LinkedList to track the order, while a Dictionary is used to for quick look up of existing items.
Tomas Weinfurt [Thu, 28 May 2020 18:36:42 +0000 (11:36 -0700)]
remove some old Sierra craft in ping test (#36987)
Co-authored-by: Tomas Weinfurt <furt@Shining.local>
Layomi Akinrinade [Thu, 28 May 2020 17:15:29 +0000 (13:15 -0400)]
Support async KeyValuePair (de)serialization (#36607)
* Support async KeyValuePair (de)serialization
* Address review feedback
* Fix up test
Eirik Tsarpalis [Thu, 28 May 2020 16:20:08 +0000 (17:20 +0100)]
[CBOR] Add Bugfixes, XML Documentation and other refinements (#36770)
* Remove buffer pooling and IDisposable implementation from CborWriter
* rename CborWriter.GetEncoding()/TryWriteEncoding() to Encode()/TryEncode()
* move exception messages to resource file
* rebase on top of latest cbor changes
* move writer exception messages to resource strings
* fix failing tests
* Implement a CborWriter.Reset() method
* remove clearArray argument from Reset() function
* add XML docs for shared CBOR types
* tolerate invalid utf8 encodings in lax conformance levels
* flip default validateConformance value in SkipValue() method
* tidy up CborReader internal state; add more comments
* more CborReader internal state tidying up
* fix strict conformance level rollback bug
* Deprecate CborReader.BytesRemaining property
* Change return type of CborReader.ReadEncodedValye() to ReadOnlySpan<byte>
* factor CborReaderState to a separate file, add xml docs
* Add xml docs for CborReader.cs and CborReader.Integer.cs
* string reader should not throw OverflowException on large indefinite-length
* simplify integer decoding implementation
* add xml docs for CborReader.String.cs
* add missing docs to CborReader.cs
* clean up CborReader.String.cs and add more code comments
* add xml docs for array and map readers
* refine CborReader.PeekTag() error semantics & add xml docs
* add CborReader.Simple.cs xml docs
* add xml docs for CborReader.SkipValue.cs
* remove unnecessary usings
* rename encodeIndefiniteLengths parameter to convertIndefiniteLengthEncodings and change default value.
* add xml docs to CborWriter.cs
* Render major types using their numeric values in exception messages
* fix handling of root-level break bytes when multiple root-level items are permitted
* add xml docs to CborWriter.Integer.cs
* Cleanup CborReader.Simple.cs
* add xml docs to CborWriter.String.cs
* add xml docs for CborWriter array and map methods
* add xmldocs for CborWriter.Tag.cs
* add xmldocs for CborWriter.Simple.cs; refine behaviour and add tests
* add conformance level tests for CborWriter.WriteEncodedValue()
* Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Simple.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborReader.Map.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* address PR feedback
* Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* Update src/libraries/System.Security.Cryptography.Encoding/tests/Cbor/CborWriter.cs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
* address feedback
* have lax conformance level tolerate reserved simple value encodings
* fix xmldoc issues
* minor docs fixes
* add more docs fixes
* remove redundant <see> elements in xml docs
* Remove more <see> elements from <summary> docs
Co-authored-by: Jeremy Barton <jbarton@microsoft.com>
Kevin Jones [Thu, 28 May 2020 16:14:37 +0000 (12:14 -0400)]
Use friendly name in exception if OID value is null. (#37110)
dotnet-maestro[bot] [Thu, 28 May 2020 16:13:49 +0000 (12:13 -0400)]
Update dependencies from https://github.com/mono/linker build
20200528.2 (#37126)
Microsoft.NET.ILLink.Tasks
From Version 5.0.0-preview.3.20276.2 -> To Version 5.0.0-preview.3.20278.2
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Andy Ayers [Thu, 28 May 2020 16:13:39 +0000 (09:13 -0700)]
JIT: some small improvements to tail duplication (#37038)
1. Allow duplicating when predecessor is BBJ_NONE
2. Require that predecessor and successor reference the same local
3. Make sure that local is not address exposed
4. Check up to two statements in predecessor for local reference
5. Require successor to compare local to constant, or local to local
Changes inspired by #36649 but don't actually improve CQ for that case (yet).
Also, add morph to post-phase whitelist because it seems odd not
to dump the IR after morph.
Zoltan Varga [Thu, 28 May 2020 16:07:01 +0000 (12:07 -0400)]
[runtime] Implement the many argument version of the Vector128.Create () intrinsic. (#37036)
Steve Harter [Thu, 28 May 2020 15:12:32 +0000 (10:12 -0500)]
Fix namespace for Nullable converters (#37019)
monojenkins [Thu, 28 May 2020 14:43:51 +0000 (10:43 -0400)]
[wasm] Fix the handling of i8/u8 in get_wrapper_shared_type_full (). (#37056)
Fixes https://github.com/mono/mono/issues/19837.
<!--
Thank you for your Pull Request!
If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed.
Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number
-->
Co-authored-by: vargaz <vargaz@users.noreply.github.com>
Koundinya Veluri [Thu, 28 May 2020 13:32:31 +0000 (09:32 -0400)]
Move thread pool initialization to native side (#36789)
Move thread pool initialization to native side
- Following up from https://github.com/dotnet/runtime/pull/36697. Currently the initialization occurs when a static variable is accessed before calling into the VM, and after thinking about it some more the intent and need to initialize the thread pool can be a bit unclear
- The initialization is specific to this implementation and the managed side doesn't necessarily need to know about it
- Moved the initialization to the native side similarly to other thread pool APIs
- Added some more assertions to relevant managed-to-native entry point paths to ensure that they are not called before the thread pool is initialized
- This adds a non-volatile check when requesting a worker thread, which is already a very slow path. I ran into some issues with testing on the arm64 machine with updated locally built libcoreclr.so, so wasn't able to test that. I looked at the baseline profile and looking at time spent exclusively in ThreadPoolNative::RequestWorkerThread() and what it already does, I don't think the change would result in any significant perf difference.
Zoltan Varga [Thu, 28 May 2020 09:35:18 +0000 (05:35 -0400)]
[wasm] Test runner improvements. (#37097)
* Fix the test runner script.
* Add a ExtraFiles property to the wasm app builder.
* Add helper make targets.
* Bump sdk version to pick up wasm support.
* Fix make targets.
* Compile wasm runtime with --enable-minimal=threads.
Jeremy Koritzinsky [Thu, 28 May 2020 05:36:55 +0000 (22:36 -0700)]
Update Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk. (#36889)
* Update Microsoft.DotNet.Build.Tasks.SharedFramework.Sdk.
Unblocks #36715
* Enable creating the LightCommand package drop to fix MSI creation.
* Update shared framework sdk to 20277.7
Santiago Fernandez Madero [Thu, 28 May 2020 01:45:56 +0000 (18:45 -0700)]
Add linux arm/arm64 libraries checked coreclr test runs (#36910)
* Add linux arm/arm64 libraries checked coreclr test runs
* Add linux_musl_arm64
* Disable BitmapTests on linux checked coreclr
Kunal Pathak [Thu, 28 May 2020 01:04:17 +0000 (18:04 -0700)]
ARM/ARM64: Optimize virtual call stub for R2R and JIT (#36817)
Optimize virtual call stub for R2R ARM/ARM64 scenarios
Layomi Akinrinade [Wed, 27 May 2020 23:59:48 +0000 (19:59 -0400)]
Loosen property name collision detection involving hidden properties (#36936)
* Loosen property name collision detection involving hidden properties
* Delay ignored prop cache creation; add more tests
* Clarify comments
Santiago Fernandez Madero [Wed, 27 May 2020 23:37:44 +0000 (16:37 -0700)]
Add ICU App-Local support on Mono (#37037)
* Add ICU App-Local support on Mono
* PR Feedback
Carol Eidt [Wed, 27 May 2020 22:02:47 +0000 (15:02 -0700)]
Fix multi-reg copy (#37062)
Also, fix dump for multi-reg copy.
Fix #37059
Immo Landwerth [Wed, 27 May 2020 21:45:06 +0000 (14:45 -0700)]
Add information about API review schedule
dotnet-maestro[bot] [Wed, 27 May 2020 17:11:49 +0000 (17:11 +0000)]
[master] Update dependencies from mono/linker dotnet/xharness (#37051)
* Update dependencies from https://github.com/mono/linker build
20200526.2
Microsoft.NET.ILLink.Tasks
From Version 5.0.0-preview.3.20271.1 -> To Version 5.0.0-preview.3.20276.2
* Update dependencies from https://github.com/dotnet/xharness build
20200527.1
Microsoft.DotNet.XHarness.Tests.Runners
From Version 1.0.0-prerelease.20275.1 -> To Version 1.0.0-prerelease.20277.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Tomas Weinfurt [Wed, 27 May 2020 16:46:41 +0000 (09:46 -0700)]
uddate Ubuntu and Alpine RID (#37031)
Co-authored-by: Tomas Weinfurt <furt@DESKTOP-0J9757E.corp.microsoft.com>
Tomas Weinfurt [Wed, 27 May 2020 16:35:05 +0000 (09:35 -0700)]
Improve test ALPN detection (#36928)
* Improve test ALPN detection
* feedback from review
* add tvos
* update casing
Kirill Frolov [Wed, 27 May 2020 15:30:20 +0000 (18:30 +0300)]
Fix build with FEATURE_GDBJIT enabled (#37054)
This commit fixes broken build in case when following arguments added to
build.sh script: --cmakeargs -DFEATURE_GDBJIT=true
Fan Yang [Wed, 27 May 2020 15:21:49 +0000 (11:21 -0400)]
Enable jumps4 tests, since the issue has been fixed via mono/mono PR #19809 (#37015)
Zoltan Varga [Wed, 27 May 2020 14:37:31 +0000 (10:37 -0400)]
Add a BundleTestWasmApp target to build wasm test apps for libraries. (#36739)
Beginning of a BundleTestWasmApp target to build wasm test apps for libraries.
Viktor Hofer [Wed, 27 May 2020 13:59:38 +0000 (15:59 +0200)]
Update the -vs switch and add docs for it (#37026)
* Remove testhost DOTNET_ROOT from vs switch
We don't need to point to the testhost folder anymore for libraries for
supporting VS Test Explorer.
* Update docs
* Fix verbosity alias
Egor Bogatov [Wed, 27 May 2020 13:57:20 +0000 (16:57 +0300)]
Reduce app size for iOS (#36902)
We did the same mistake for Android - `libmonosgen-2.0.dylib` shouldn't be copied to bundle (we already have a mono runtime there)
Egor Bogatov [Wed, 27 May 2020 13:56:10 +0000 (16:56 +0300)]
Make ApkBuilder less verbose (#37050)
The output is still pretty useful and x4 times less verbose.
Kenneth Pouncey [Wed, 27 May 2020 09:12:39 +0000 (11:12 +0200)]
[browser][wasm] InteropServices.JavaScript backing code. (#37044)
Vlad Brezae [Wed, 27 May 2020 08:57:58 +0000 (11:57 +0300)]
[interp] Remove return value indirection (#37004)
* [interp] Remove return value indirection
When returning from a method we used to save the return value into frame->retval. We would then have separate opcodes for normal and void call and, depending on the type of call, we would access the retval and push it on the stack. In case of valuetype returns, the value is not returned in the proper space so we have an additional MINT_VTRESULT that copies the return around in the caller frame. In addition to this we had retval, is_void locals, saved as part of the current frame state which just make things confusing and are not needed.
This commit simplifies the call procedure by completely moving the responsability of the return to the called method. Simply put, once a method is ready for the call, it will leave its stack and vtstack to the state after pop-ing the arguments. The called method will then directly push the result to the parent frame's stack/vtstack. This means the calling code doesn't care about the type of the return anymore, the IL instructions after the call will just expect the return on the stack, if any, and use it naturally.
We still make use of frame->retval for interp entry frames (since we don't have a parent frame to push to), for pinvoke and jit_call frames out of convenience, but we should consider removing this variable to further trim down InterpFrame.
* [interp] Remove call opcodes that are no longer necessary
* [interp] Split up CALL and CALLVIRT opcodes
MINT_CALLVIRT is soon to be removed while MINT_CALL is the most common call opcode.
* [interp] Fix jit calls done through MINT_CALLVIRT
The callee should push the vt stack if there is a vt return, except when we are calling out of the interpreter, in which case the calling opcodes handle the push explicitly. We weren't handling the case of exiting the interpreter when doing a jit call through MINT_CALLVIRT. In order to keep the same structure for MINT_CALLVIRT, which doesn't need to know about the vt_res_size, we handle the vtstack change when doing a jit call by caching the return size in the InterpMethod, together with other jit_call information. Maybe we can refactor this later.
* [interp] Cleanup call opcode emitting
Add the opcode and set its data in the same place, making the code
easier to follow.
* [interp] Split up MINT_CALL_NAT in 2 opcodes
This opcode had two different cases embedded in it. Clean up the code,
split the opcode in two, removing also a dirty recursive call.
* [tests] Disable a few tests that fail with this PR due to false pinning
There are over a hundred tests calling GC.WaitForPendingFinalizers and potentially flaky with mono. We might have to disable all of them or tweak them to be mono friendly.
Stephen Toub [Wed, 27 May 2020 08:29:11 +0000 (04:29 -0400)]
Avoid HttpClientHandler.ServerCertificateCustomValidationCallback keeping first request message alive (#37021)
Egor Bogatov [Wed, 27 May 2020 05:52:18 +0000 (08:52 +0300)]
RuyJIT: `Array.Length / cns` can be converted to unsigned div (mod) (#32368)
* Optimize `array.Length / cns` and `array.Length % cns` if cns is positive
* Address feedback
Carol Eidt [Wed, 27 May 2020 04:56:16 +0000 (21:56 -0700)]
Fix a couple of bugs in multi-reg stores (#36994)
* Fix a couple of bugs in multi-reg stores
Fix #36912
Tanner Gooding [Wed, 27 May 2020 03:48:14 +0000 (20:48 -0700)]
Ensure Vector3 inequality doesn't use the hidden 4th element (#36953)
* Renable Vector3InequalityTest
* Fixing ARM64 LowerHWIntrinsicCmpOp to always treat the extra element of a TYP_SIMD12 as equivalent
* Adding a regression test for Vector3InequalityTest
* Update src/coreclr/src/jit/lowerarmarch.cpp
Co-authored-by: Carol Eidt <carol.eidt@microsoft.com>
* Applying formatting patch
Co-authored-by: Carol Eidt <carol.eidt@microsoft.com>
Anton Lapounov [Wed, 27 May 2020 03:44:23 +0000 (20:44 -0700)]
Align assembler mnemonics and operands in R2RDump (#37034)
* Align assembler mnemonics and operands in R2RDump.
* For ARM64 images dump instruction bytes as 4-byte hexadecimal integers.
* Fix incorrect usage of _methods.Count.
* Fix the corrupted R2RFormat.png file.
Santiago Fernandez Madero [Wed, 27 May 2020 03:02:09 +0000 (20:02 -0700)]
Disable AddThresholdTest in all archs (#37032)
Eric Erhardt [Wed, 27 May 2020 02:55:46 +0000 (21:55 -0500)]
Use nint instead of IntPtr in _RegisterFrozenSegment. (#37029)
Anirudh Agnihotry [Wed, 27 May 2020 00:43:37 +0000 (17:43 -0700)]
rearrange tfms for intellisense (#37027)
Andy Ayers [Tue, 26 May 2020 23:26:53 +0000 (16:26 -0700)]
Simple sideloaded profile guided optimization support (#36887)
1. Add code so the runtime can read profile data from a text file and then
make this data available to the jit, so it will be easier to test the jit's
behavior when profile data is available.
2. Add code so the runtime can create profile text files by telling the jit
to insert probes into jitted code that write into a persistent buffer, which
is saved to text at shutdown. This is mainly intended to make creation of the
sideloaded profile data files easier, since their internal structure must
exactly match artifacts from jitted methods.
3. Add a mode where jit-instrumented Tier0 code can feed counts into Tier1
jitting. This is an experiment to see what benefit, if any, might accrue from
having profile data available for Tier1 jitting.
External format is text so it can be edited by hand or checked into the repo
alongside tests. Binary format would be more compact but opaque.
In all cases the jit internally sees a profile buffer identical to the one it
sees with IBC; the only minor changes in the jit are to initialize the count
field of each probe entry to zero and to only emit the entry helper call for
prejitted IBC.
Only root methods are instrumented, and only root method blocks are given
profile weights. Broadening to handle inlinees is future work, facilitated by
the new capabilites added here.
Sung Yoon Whang [Tue, 26 May 2020 23:13:47 +0000 (16:13 -0700)]
Update runtime providers' context object on EventPipe rundown (#36733)
* Disable EventPipeProvider Context for runtime providers on EventPipe rundown
* Add comments per code review feedback
* fix GCC build
Santiago Fernandez Madero [Tue, 26 May 2020 23:13:15 +0000 (16:13 -0700)]
Add dotnet.js to sign exclusion list (#37033)
Jeremy Koritzinsky [Tue, 26 May 2020 22:03:11 +0000 (15:03 -0700)]
Fix bad refcount management in ComWrappers WeakReference test. (#37022)
Sung Yoon Whang [Tue, 26 May 2020 21:55:51 +0000 (14:55 -0700)]
merge with master
Anirudh Agnihotry [Tue, 26 May 2020 21:46:02 +0000 (14:46 -0700)]
Porting some patches from sourcebuild to runtime (#36861)
* porting some patches from sourcebuild to runtime
* Update src/installer/Directory.Build.props
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
* lowercase or
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Sung Yoon Whang [Tue, 26 May 2020 21:32:15 +0000 (14:32 -0700)]
fix GCC build
Eugene Rozenfeld [Tue, 26 May 2020 21:18:21 +0000 (14:18 -0700)]
Optimization to remove redundant zero initializations. (#36918)
* Optimization to remove redundant zero initializations.
This change adds a phase iterates over basic blocks starting with
the first basic block until there is no unique basic block successor
or until it detects a loop. It keeps track of local nodes it encounters.
When it gets to an assignment to a local variable or a local field,
it checks whether the assignment is the first reference to the local
(or to the parent of the local field), and, if so, it may do one of two
optimizations:
1. If the following conditions are true:
the local is untracked,
the rhs of the assignment is 0,
the local is guaranteed to be fully initialized in the prolog,
then the explicit zero initialization is removed.
2. If the following conditions are true:
the assignment is to a local (and not a field),
the local is not lvLiveInOutOfHndlr or no exceptions can be thrown
between the prolog and the assignment,
either the local has no gc pointers or there are no gc-safe points
between the prolog and the assignment,
then the local is marked with lvHasExplicitInit, which tells the codegen
not to insert zero initialization for this local in the prolog.
This addresses one of the examples in #2325 and 5 examples in #1007.
Jan Kotas [Tue, 26 May 2020 21:12:51 +0000 (14:12 -0700)]
Bump crossgen2 dependencies (#37017)
Unify on the latest version of System.CommandLine
Swaroop Sridhar [Tue, 26 May 2020 21:08:48 +0000 (14:08 -0700)]
Single-File: Run from Bundle (#36052)
* Single-File: Run from Bundle
This change implements:
* Runtime changes necessary to load assemblies directly from the bundle:
* Design notes about [Load from Bundle](https://github.com/dotnet/designs/blob/master/accepted/2020/single-file/design.md#peimage-loader)
* Most of these changes are directly from https://github.com/dotnet/coreclr/pull/26504 and https://github.com/dotnet/coreclr/pull/26904
* Hostpolicy change to not add bundled assemblies to TPA list:
* Design notes about [Dependency Resolution](https://github.com/dotnet/designs/blob/master/accepted/2020/single-file/design.md#dependency-resolution)
* TBD (separately) items: Fix for hammer servicing #36031
Fixes #32822
* Address some code review feedback
* Address futher review feedback
* Fix Assembly.ni.dll and Assembly.dll path usage.
* Remove unused full-path computation for corelib when loading from bundle.
* Add tracing when loading from bundle.
* Add bundle-probing for satellite assemblies.
* Adapt the BundleRename test to the .net5 scenario where assemblies are loaded from bundle.