Fixes zlib dependency

Components: Framework

Change-Id: I70c130a367afa7d3eb2cbd81dd1662331c6723b8
(cherry picked from commit 188db4918e48556a330814d9e09ec305e4497227)
(cherry picked from commit dfa2928ab87d8d7a05df918ec18833223519de14)
(cherry picked from commit 740a7028359cd99c30a96de911afb8062a224d05)
(cherry picked from commit f1522bd9a9222d0f99570194fbca2736a69542ae)

Fix valid usage violation in vkFreeDescriptorSets

The descriptor pool used in vkFreeDescriptorSets was not created with
the VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT flag, resulting a
valid usage check failed in the driver. Adding the flags fixes the
issue.

Affects:
dEQP-VKSC.sc.device_object_reservation.limits.request_count.*

Componnets:
VulkanSC

Change-Id: Id5ecff4c58478c13aaf035eaff07554c3260abf0

Fixed YCbCr conversion tests in Vulkan SC

Main process was skipping calls to uploadImage/fillImageMemory that
create an additional VkCommandPool that wasn't accounted for in the
subprocess memory reservation.

Affects:

dEQP-VKSC.ycbcr.conversion.*

Change-Id: If438ff06af67895209a08f8b0eaeb3fc46514a29

Check format features for both formats in LoadStoreTests

These tests unconditionally create both images with STORAGE usage,
so they need to check for support for both formats.

Components: Vulkan, VulkanSC
Affects Tests: dEQP-VK.image.*

Change-Id: If37e375a9e5942d684d5a74325c0dffaedb3b824

skip non-compresed 3D views of compressed images

dEQP-VKSC.image.texel_view_compatible.graphic.*.3d_image.texture_read
tests violate VUID-VkImageViewCreateInfo-image-04739 - "If image was
created with the VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT flag
and format is a non-compressed format, viewType must not be
VK_IMAGE_VIEW_TYPE_3D"

Components: Vulkan, VulkanSC
Affected Tests:
dEQP-VKSC.image.texel_view_compatible.graphic.*.3d_image.texture_read.*

Change-Id: I48512da1cdedbaecc73ac1ae1289cbbb4bc2f70c

Fix Zlib depedency

Use newer version of Zlib as older is no longer available to download from the zlib.net page

Components: Framework

Affects:

None

VK-GL-CTS Issue: 3587

Change-Id: Ie166dc897b0d1318c1ae73434bfa19687b579691
(cherry picked from commit ec1804831b654ac55bd2a7a5dd27a556afe05030)

Fix robustness2 shaders

Remove ifdef that was allowing nonsensical test cases to be
generated (e.g. 'cubemap buffer' tests).

Fix an out of bounds memory access during shader generation.
This caused shader sources to be nondeterministic, and you'd
sometimes get mismatches between the main process and subprocess.

Component: VulkanSC

Affects tests: dEQP-VKSC.robustness.robustness2.*

Change-Id: I40b340ec1bb0060c62dd3732cceadfe6c6ae28e5

Fix multithreaded object counting in internally_synchronized_objects.*

Copy the barrier code from vktApiObjectManagementTests.cpp and do a
barrier on each iteration in the main process. This guarantees that
CTS will reserve the maximum number of pipeline pool slots we might
need.

Component: VulkanSC

Affects tests: dEQP-VKSC.synchronization.internally_synchronized_objects.*

Change-Id: Icf2ac519076c80803adb3833814e4ab290761105

Only request timeline semaphore extension if it's not in core

Component: VulkanSC

Affects tests: dEQP-VKSC.*timeline*

Change-Id: Ic05ea877a654a965796b80ecf5875ea32d602729

Remove duplicated VkPhysicalDeviceVulkanSC10Features structure

Removed one pipeline cache test due to latest changes in specification.
Added mention about deqp-command-buffer-min-size command line option to documentation.

Removed tests:
dEQP-VKSC.sc.pipeline_cache.zero_initial_data_size

Affects tests:
dEQP-VKSC.*

Components:
Framework VulkanSC

VK-GL-CTS Issue: 3497
VK-GL-CTS Issue: 3498
VK-GL-CTS Issue: 3506

Change-Id: Id51d00e3c7661c0e906c2ad7e075940bedb8d341

Add limit verification for two fields in Vulkan SC

Missing fields in VkPhysicalDeviceVulkanSC10Properties : maxCommandPoolCommandBuffers and maxCommandBufferSize.

New tests:
dEQP-VKSC.sc.command_pool_memory_reservation.memory_consumption.cb_min_limit.*
dEQP-VKSC.sc.command_pool_memory_reservation.memory_consumption.cb_above_min_limit.*

Removed tests:
dEQP-VKSC.api.device_init.create_instance_invalid_api_version

Affects tests:
dEQP-VKSC.api.info.vulkan1p2_limits_validation.general
dEQP-VKSC.sc.command_pool_memory_reservation.memory_consumption.*.size_big.*

Components:
Framework VulkanSC

VK-GL-CTS Issue: 3491

Change-Id: I62328a8b7caa6f774bc733636910050fe594defd

Fix subprocess count handling and releaseId logging

Additional work on server logging corectness.

Affects tests:
dEQP-VKSC.*

Components:
Framework VulkanSC

VK-GL-CTS Issue: 2947
VK-GL-CTS Issue: 3453
VK-GL-CTS Issue: 3456

Change-Id: I452feed03817292b94e8d2ce68211313f5113206

Update CTS to VulkanSC header version 1.0.8

Updated JSON generation and parsing files from
gitlab.khronos.org:vulkansc/vulkansc.git sc_main@14cd0818123436f84713fb0f7ee297ced5876607
CTS variants of scripts can be found under <gen>/out/json/cts

To activate the CTS TLS WAR - please define USE_THREAD_LOCAL_WAR

Removed tests:

dEQP-VKSC.api.command_buffers.pool_reset_release_res
dEQP-VKSC.api.command_buffers.pool_reset_reuse
dEQP-VKSC.pipeline.derivative.compute.derivative_by_handle
dEQP-VKSC.pipeline.derivative.compute.derivative_by_index

Components: VulkanSC Framework

VK-GL-CTS issue: 3436

Change-Id: I78654c7977fdfbe79fa24909403279e25f3c1620

Support DEQP_VULKAN_LIBRARY_PATH for Linux based platforms

VK-GL-CTS Issue: 3458

Use DEQP_VULKAN_LIBRARY_PATH in framework/platform/lnx/tcuLnxVulkanPlatform.cpp
to enable overriding the vulkan library at build-time for Linux-based platforms.

Components: Framework, Vulkan

Change-Id: I5d1e97b5b8cf90b97110e6a1102a47c683788139

Improve coverage of MSAA copies

This commit adds tests for copying with separate layers
along with tests for copying multiple regions.
Cherry picking to Vulkan SC CTS.

New tests:

dEQP-VKSC.api.copy_and_blit.*.resolve_image.copy_with_regions_before_resolving.*
dEQP-VKSC.api.copy_and_blit.*.resolve_image.layer_copy_before_resolving.*

Affects:

dEQP-VKSC.api.copy_and_blit.*.resolve_image.*

Components: Vulkan Vulkan SC

VK-GL-CTS issue: 3071
VK-GL-CTS issue: 3421

Change-Id: Ibee933bdfe9d59d760fc3600104a8b264d3ba63b

Various modifications and fixes required by Vulkan SC CTS.

Additionally documentation has been extended by information
about adding file pointed out by --deqp-subprocess-cfg-file
command line parameter to submission package.

Affects tests:
dEQP-VKSC.api.object_management.*.pipeline_cache
dEQP-VKSC.api.object_management.*.graphics_pipeline
dEQP-VKSC.synchronization.internally_synchronized_objects.*

Components:
Framework VulkanSC

VK-GL-CTS Issue: 3408
VK-GL-CTS Issue: 3417

Change-Id: I4e7b836d3e641b75855ab0df429fd9c75598ec34

Add command line parameter deqp-subprocess-cfg-file

Default subprocess test count is defined by command line parameter
deqp-subprocess-test-count. New parameter ( deqp-subprocess-cfg-file )
may be used to modify default value for test subtrees.

Affects tests:
dEQP-VKSC.*

Components:
Framework VulkanSC

VK-GL-CTS Issue: 3320

Change-Id: Ic36e569f73f93e360f55cbfbe048160cce87f6cf

Final modifications and corrections for Vulkan SC

Updated Vulkan SC specification version to 1.0.7.
Updated documentation in external/vulkancts/README.md

Components:
Framework VulkanSC

Affects tests:
dEQP-VKSC.*

Change-Id: I7a71c41be887122f0ee1dbdf7210c1d93b58032f

Implement reference offline pipeline compiler

Offline pipeliner compiler is a reference implementation that uses
normal Vulkan API functions to create pipeline cache.

Components:
Framework VulkanSC

Affects tests:
dEQP-VKSC.*

Change-Id: I6fc3cd78edbecc27250cca9d4f93260cdbd0377b

Merge branch 'master' into 'vulkan-sc-cts-dev'

Change-Id: I98db637e40b3caf8a590c35b38183222f6efcffb

Add compute test with zero dispatch size

Add a few tests that check vkCmdDispatch works properly even if one of
the sizes is zero.

New tests:
dEQP-VK.compute.basic.empty_workgroup_*

Components: Vulkan
VK-GL-CTS issue: 3183

Change-Id: I689469e3d0bd87a3fd92616e5ef482009e3461dd

Test contradictory parameters on swapchain creation

This commit adds new tests that check the implementation properly
ignores queueFamilyIndexCount and pQueueFamilyIndices on swapchain
creation when imageSharingMode is set to VK_SHARING_MODE_EXCLUSIVE, by
providing a null pointer in pQueueFamilyIndices and a nonzero
queueFamilyIndexCount.

In addition, swapchain creation tests using VK_SHARING_MODE_EXCLUSIVE
will no longer pass 1 in queueFamilyIndexCount and a list of
surface-compatible queues in pQueueFamilyIndices, setting
queueFamilyIndexCount to 0 and passing a null pointer instead.

Finally, the commit adds de::arrayLength as a more modern and constexpr
way of obtaining the size of statically-sized arrays, similar to
DE_LENGTH_OF_ARRAY, which can be used with static_assert.

New tests:
dEQP-VK.*exclusive_nonzero_queues

Affected tests:
dEQP-VK.*.swapchain.create.*

Components: Framework, Vulkan
VK-GL-CTS issue: 3244

Change-Id: I631aba22ac18d1fe6a2fcc8bf41890b2e8a2cc91

Revert "Exclude cov-function-with-nested-loops-called-from-nested-loops"

This reverts commit b0c3e7ba7d99a3e9e2052a498569cea0721dfb09.

Components: Vulkan

Affects:
dEQP-VK.graphicsfuzz.cov-function-with-nested-loops-called-from-nested-loops

VK-GL-CTS Issue: 3171

Change-Id: I590db29c6d57b68bd76478140fef798ea6127f91

Add buffer feature check for depth/stencil formats

Tests that check the drivers are not exposing undesired format
features for depth/stencil formats.

Components: Vulkan

VK-GL-CTS Issue: 3155

New tests: dEQP-VK.api.buffer.invalid_buffer_features.*

Change-Id: I7cc72f19ff58899e087ee0365780a5a0f50b3a47

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master

Change-Id: I1fcf5038213aacef0a7fe7c1d3e4cc5e04e80e64

Fix memory requirements tests for sparse images

When memory requirements tests are executed for sparse images
we need to check sparse image format properties first.

VK-GL-CTS issue: 3201

Components: Vulkan

Affects:
dEQP-VK.memory.requirements.*.image.sparse*

Change-Id: I058d6dd6c4eeabce89c3f6835fbc16e4386712d5

Fix image requirements according to its usage

VK-GL-CTS issue: 3090

Components: Vulkan

Affects:
dEQP-VK.sparse_resources.shader_intrinsics.*

Change-Id: If6c8e55be75fd3a9a170c7d0d413dc658d40adfa

Initialise new member of ImageTestParams struct

This doesn't appear to be used in the tests, but without this it
generates compiler warnings on some of our platforms.

Components: Vulkan
VK-GL-CTS issue: 3240
Affects: dEQP-VK.memory.requirements.*

Change-Id: I5c4dfd0443f0f318d45e89ae22d5103a1dae198e

Ensure the vertex shader matches the vertex input definition

When doing the "reversed" variants of the extended dynamic
state tests, the vertex input attribute and binding information
was reversed, but the vertex shaders were not. The meant that
in some tests the vertex shader may try to fetch from unbound
or undefined vertex attributes or vertex attribute data.

This commit fixes the issue by swapping vertex shaders for the
affected variants.

Affects:
dEQP-VK.pipeline.extended_dynamic_state.*

Components: Vulkan
VK-GL-CTS issue: 3111

Change-Id: I7d9abbe7dab0b44127f6b194ee5da79755f7658c
Co-authored-by: Ricardo Garcia <rgarcia@igalia.com>
(cherry picked from commit aebbea7b29507dfb24fb204697671ad7b4ac4fc1)

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ib53ac9424d4263b3114e46c532f28b55f522cf2c

Update SPIRV-Headers

The SPIRV-Headers version for vulkan-cts-1.2.6 was ahead of 1.2.7. This
change brings SPIRV-Headers in 1.2.7 up to the same version.

Components: Vulkan
Change-Id: Ifff93c5251183d3a6ee3ef3f508e88274332116f

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I7535fbad6813c7a6dfec1324a2656329de792ebe

Remove 64-bit int usage in dynamic_indexing test shaders

- "OpCapability Int64" is not a mandatory extension
- Replace with v2i32

Components: Vulkan

VK-GL-CTS Issue: 3205

Affected tests:
dEQP-VK.ray_tracing_pipeline.acceleration_structures.dynamic_indexing.dynamic_indexing
dEQP-VK.ray_query.acceleration_structures.dynamic_indexing.dynamic_indexing

Change-Id: I04b7cf6309b42ef4572e5c79c8e9233aee2edec7

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I8a9f12e6adc0daf962a4f6f05d28216db4880ee8

Check shaderInt64 in workgroup memory explicit layout alias tests

A few workgroup memory explicit layout alias tests were not checking
shaderInt64 while using 64-bit integers in shaders.

Affected tests:
dEQP-VK.compute.workgroup_memory_explicit_layout.alias.*u64*array*
dEQP-VK.compute.workgroup_memory_explicit_layout.alias.*array*u64*

Components: Vulkan
VK-GL-CTS issue: 3131

Change-Id: I1911018c471e9548603d5de987625163bb356eb9

Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master

Change-Id: I3e4f47adf9a8446556351175e63b2cf3f1e8a399

Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7

Change-Id: Ibee0d474561af951a4ef33db864aaa4993ca38d5

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I54315f34095f396294bab85b0da4a1e3cf38aac8

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: I2f2be91bd696c7de227f804202f9a8eb222cab03

Fix VK_KHR_shader_clock feature checks

The shader clock tests were not checking if the implementation supported
64-bit integers for tests that required the feature and they were
checking supported features at test instance creation time instead of
the specific checkSupport method for test cases.

Affected tests:
dEQP-VK.glsl.shader_clock.*

Components: Vulkan
VK-GL-CTS issue: 3187

Change-Id: I0dc86a4fae619c0d27628d97f0ac11c5def5ff4f

Fix dEQP-VK.tessellation.geometry_interaction.limits.output_required_max_geometry validation error

Adjust numSliceNodesComponentLimit in order to keep
m_numGeometryPrimitivesPerInvocation within minimum limits defined in
the spec.

Components: Vulkan

VK-GL-CTS Issue: 3180

Affects:
dEQP-VK.tessellation.geometry_interaction.limits.output_required_max_geometry

Change-Id: I72ca43bec27256cb75a11d75aab91b9b565be9ab

Move log prints from test-ctor to test-inst-ctor

Some of the tesselation tests were printing values into the output log
from the test constructor, which meant that said prints end up in more
or less random place in the log. Moved those prints to the test instance
instead, so the information now resides within the test output.

The prints were also done in the amber-verify run mode.

Affects:
dEQP-VK.tessellation.geometry_interaction.scatter.*
dEQP-VK.tessellation.geometry_interaction.limits.*

Components: Vulkan
VK-GL-CTS issue: 3057

Change-Id: Ic5b2ce59369d1c20f25b8dc1c6cb594baac74f8f

x11_egl: only append library path if it's not empty

Pkg-config will strip out any -L if they match the default search
directory, so we ended up with a -L and no arguments to it, that would
consume whatever came next.

Components: EGL

VK-GL-CTS issue: 2726

Change-Id: Iba0f7d8e0a4ab66e5fd369f60e4d04ac5420df65

Add tests verifying Vulkan SC API

New tests verifying Vulkan SC API specifics,
VkDeviceObjectReservationCreateInfo struct,
VkPipelineIdentifierInfo struct, fault handling capabilities
and VK_KHR_object_refresh extension.

Components:
Framework Vulkan VulkanSC

Affects tests:
dEQP-VKSC.api.info.vulkan1p2_limits_validation.general
dEQP-VK.*

New tests:
dEQP-VKSC.sc.api.*
dEQP-VKSC.sc.device_object_reservation.*
dEQP-VKSC.sc.pipeline_identifier.*
dEQP-VKSC.sc.pipeline_cache.*
dEQP-VKSC.sc.fault_handling.*
dEQP-VKSC.sc.command_pool_memory_reservation.*
dEQP-VKSC.sc.object_refresh.*

Change-Id: Iafa03bfa91d0d17a0c0abb834c09a7cb148699e8

Split multiple interpolation tests using the sample decoration

This commit separates the multiple interpolation tests in two groups,
one including the sample decoration in the set and another one excluding
it. The goal is to avoid requiring the sampleRateShading feature in all
tests, which is mandatory when using the sample decoration.

In addition, this commit makes sure the sampleRateShading feature is
required for those cases.

New tests:
dEQP-VK.draw.multiple_interpolation.*.no_sample_decoration.*

Affected tests:
dEQP-VK.draw.multiple_interpolation.*

Components: Vulkan
VK-GL-CTS issue: 3129

Change-Id: I8c190c70db9e7fef7505dc31bbf8b6626161f60e

Allow EGL tests to use ES3 with EGL_KHR_create_context

Previously EGL tests that relied on ES3 required EGL 1.5. Now
these are also run when EGL_KHR_create_context is supported.

VK-GL-CTS Issue: 3122

Affects:

dEQP-EGL.functional.image.create.gles3*

Components: EGL
Change-Id: I05fe87a0d2e321310b28df9a998006867115e0f0

Cover vkGetBufferMemoryRequirements*() routines tests

New tests:
dEQP-VK.api.buffer_memory_requirements.*

Components: Vulkan

VK-GL-CTS issue: 3163

Change-Id: I806d8a420e1e6d204061b3b740500736609263f8

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master

Change-Id: I2aaf2dbd77937a00f045727d428fc45437ca96df

Fix multisample_with_fragment_shading_rate tests

Two tests in multisample group are added with helper
function addFunctionCaseWithPrograms. When those tests
were repeated for FSR then they were executed without
checking if required features are supported. This
change fixes that by reusing existing function
checkFragmentShadingRateRequirements (it was slightly
modified to work also with those two tests).

VK-GL-CTS issue: 3220

Components: Vulkan

Affects:
dEQP-VK.pipeline.multisample_with_fragment_shading_rate.*

Change-Id: I8dcbc09ac4a1d8d3c53eb95da591b916ded2f5b9

dEQP-VK.renderpass*.load_store_op_none.* tests depth-stencil format support check

In this test case, depth stencil format is set to VK_FORMAT_D24_UNORM_S8_UINT by default without checking if it is supported or not. If this format is not supported, then the test case crashes without even giving "Not Supported" result.

In this update I defined a set of depth stencil formats, and added a separate test case for each depth_stencil format. If the depth_stencil format is not supported, "Not Supported" is returned.

Affects: dEQP-VK.renderpass*.load_store_op_none.*

Components: Vulkan
VK-GL-CTS issue: 3049

Change-Id: Ifea5d0955a8325ecbed7f27296da4120e473d463
(cherry picked from commit 79c44fc79b7d17b8c70d2469e113c764011c51c6)

Increase tolerance for matrix precision tests

On hardware with a RTZ rounding mode the tolerance required in these
tests was too low and valid implementations of the functions would
fail the tests.

Increase the tolerance allowed to allow RTZ hardware to pass these
tests.

Affects:
dEQP-VK.glsl.builtin.precision*.determinant.*
dEQP-VK.glsl.builtin.precision*.inverse.*

Components: Vulkan

VK-GL-CTS issue: 3182

Change-Id: I83845aec8faa01aec0820852219b6b8c4326da4e
(cherry picked from commit 0593bd63803c16159db7553d8ca5191fd42126cc)

Fix incorrect shader output format

For test variants that write to a stencil buffer, the final attachment
will be R8_UINT. For these tests ensure the fragment shader is
outputing to this attachment as a uint.

Affects: dEQP-VK.synchronization2.none_stage.*

Components: Vulkan

VK-GL-CTS issue: 3177

Change-Id: Ia7e185c8c8486c8b0e76e11038e0a5108770f21f
(cherry picked from commit 4dbc15461d925429b6545bd162c97a86ba3f8a73)

Slightly increase tolerance for fp64 determinant test

VK-GL-CTS issue: 3229

Components: Vulkan

Affects:
dEQP-VK.glsl.builtin.precision_double.determinant.compute.mat3

Change-Id: I2e4d239a33e4c82e328a3df90e7a6c38056db4d8

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: Ic672c22814f2196db26725b7b2794629bbe130b6

Update drivers ids

From last version of Vulkan-Docs.

Components: Framework
VK-GL-CTS issue: 3173

Change-Id: I39aeb4f16d3bf19291a5a266595b215681ef2c83
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Merge vk-gl-cts/opengl-es-cts-3.2.7 into vk-gl-cts/master

Change-Id: I11af39aa7fcbecb367a721b7fe3a39b67cbf8550

Remove invalid reserved keywords tests

These identifiers are not listed as reserved in any spec that I can
find.

Components: OpenGLES
Removed Tests: dEQP-GLES3.functional.shaders.keywords.reserved_keywords.image*Shadow_*

Change-Id: I444d9a8a49d3dda7402faa50b79859aaef0ee690
(cherry picked from commit 99df4bc28a2e9f755467fd0c6a88702ee2428232)

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I6f96b469518264e53fdd142f445187f8eb091c6d

Relax get_frame_timestamps

To prevent power side effect from legacy platform. We tend to relax the
deqp criteria from 3 vsyncs to 4 vsyncs. And verify timestamp 6 frames
ago.

Cherry pick from AOSP.

Original commit:
https://android.googlesource.com/platform/external/deqp/+/db1f80ba923b9e89177562203c21192f8e7340c3
https://android-review.googlesource.com/c/platform/external/deqp/+/918914
Submitted on behalf of a third-party: barry.ko@mediatek.com

Component: EGL

Affected tests:
dEQP-EGL.functional.get_frame_timestamps.*

BUG: 123203074
Change-Id: I214b410d2ab8f0d6d4b3f9d6752c1c1d756cc28f

Make renderdoc build-time integration optional

In some environments (Android Q CTS), renderdoc headers will not be
available.

Cherry pick from AOSP.

Original commit:
https://android.googlesource.com/platform/external/deqp/+/7e79367bd8fa1430c0ea161a36f62d7b8edc6803

Components: Vulkan, Framework

Bug: b/123431604

Change-Id: I7d4e36074e4f89a81f55dde83a217920653ad173

Merge vk-gl-cts/opengl-cts-4.6.1 into vk-gl-cts/master

Change-Id: I5779863db87742a103772ea394a08dc7e50fcb83

Merge vk-gl-cts/opengl-es-cts-3.2.6 into vk-gl-cts/opengl-es-cts-3.2.7

Change-Id: Ice7060c4fcd3e60ccd8b0bb76d65bfb409c3120b

Merges vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I1cbb115f9efbb2df6de81b0b133723b15e367427

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I6873657c378b02b383da36905a31886806519459

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: I67159d811b780fc975c41a18043c177bceba6da7

Use GL_FRAMEBUFFER instead of GL_[DRAW|READ]_FRAMEBUFFER with GLES2

Affects:
KHR-GLES2.texture_3d.copy_sub_image.negative
KHR-GLES2.texture_3d.copy_sub_image.rgba

Components: OpenGL
VK-GL-CTS issue: 3133

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Change-Id: Ia32e16e6231b53c9f58e99d85e6178dca5b7f012

Fix zx_handle_t typedef

Change from signed to unsigned 32-bit integer to match zircon/types.h.

Components: Framework, Vulkan

VK-GL-CTS issue: 3214

Change-Id: Ic887e90adc1583cfcd1518e21831d330e0f89b17

Fix tessellation SPIR-V tests use of Restrict

Their usage of Restrict violates the SPIR-V spec which requires that it
only got on variables, not types or struct members.

Affected tests:
dEQP-VK.tessellation.*

Components: Vulkan
VK-GL-CTS issue: 2975

Change-Id: Ifbde1b493bf56d1ee6454a4ab54e98bcd05f839b

Allowing spirv1.4 shaders compilation

Components: Vulkan

VK-GL-CTS Issue: 2560

Affects: dEQP-VK.spirv_assembly.instruction.spirv1p4.*

Change-Id: Icbfe3ad623da98968eee401d08df5ed6b3b2db1e
(cherry picked from commit c96d524d079fdada26b3548effd1539174415be6)

Add tcu::Nothing to improve tcu::Maybe usability

When using tcu::Maybe<T>, tcu::just and tcu::nothing can create these
objects. However, while tcu::just can deduce type T from its arguments,
tcu::nothing cannot as it has no arguments. The type needs to be written
explicitly.

To avoid having to do that and to ease using tcu::Maybe, this commit
creates a new type tcu::Nothing_T and a global constexpr tcu::Nothing
following the same rules as std::nullopt_t and std::nullopt from C++17,
which allow using tcu::Nothing to initialize a tcu::Maybe<T> without the
need to write type T.

No test result should be affected by these changes.

Components: Framework
VK-GL-CTS issue: 3126

Change-Id: I093bbe6f1b77018aedc6e602a2893a4e7d5859a8

Add basic signaled fence tests

Add a couple of tests that verify creating signaled fences works and
they can be immediately waited on.

New tests:
dEQP-VK.synchronization.basic.fence.*signaled

Components: Vulkan
VK-GL-CTS issue: 3181

Change-Id: I235e6eed68fb9253db614592924f6061008cfa98

Attachment rate tests

Adds tests where shading rate values are setup in various ways.
Adds a test where two different shading rate attachments
are used in two-subpass render pass.

VK-GL-CTS issue: 2397

Components: Vulkan

Affects:
dEQP-VK.fragment_shading_rate.attachment_rate.*

Change-Id: If6d37028ebef7ac3d3c31fab8076338e1e928de1

Merge vk-gl-cts/vulkan-cts-1.2.8 into vk-gl-cts/master

Change-Id: I26f3ac1627ccd632426b7bd15461dfb2de9d2094

Add custom border color swizzle tests

New set of tests to check component swizzling with different border
colors, including custom border colors.

Note the tests currently suppose swizzling is applied to custom border
colors following the operation order in the "Texel Input Operations"
section.

Note that testing of opaque black and custom border colors with
non-identity swizzles is skipped unless VK_EXT_border_color_swizzle is
supported which has defined behavior for these combinations.

New tests:
dEQP-VK.pipeline.sampler.border_swizzle.*

Affected tests:
dEQP-VK.info.device_mandatory_features

Components: Vulkan
VK-GL-CTS issue: 2714

Change-Id: I5259744bbfa65db0386e94decb633b582d2fb17f

Fix depth_different_ranges tests

Two multiview tests use depth that is outside of <0;1> range
but don't check/enable VK_EXT_depth_range_unrestricted. This
change fixes that.

VK-GL-CTS issue: 3206

Components: Vulkan

Affects:
dEQP-VK.multiview.depth_different_ranges.3_6_12_9_6_12_9_3_6_12_9_3
dEQP-VK.multiview.renderpass2.depth_different_ranges.3_6_12_9_6_12_9_3_6_12_9_3

Change-Id: Iba472af84e23ea197281a1ab88d0ac6c74e845bf

Merge vk-gl-cts/vulkan-cts-1.2.7 into vk-gl-cts/vulkan-cts-1.2.8

Change-Id: I5d3d073763a72c7f6ec0fca08d030ef64b4457a4

Add check for shaderImageGatherExtended

There were validation errors in the tests when running them
through devsim layer and vulkan 1.0 spec minimum profile:

"VUID-RuntimeSpirv-OpImage-06376(ERROR / SPEC): msgNum: 70978435 -
Validation Error: [ VUID-RuntimeSpirv-OpImage-06376 ] Object 0: handle
= 0x66d3840, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0x43b0b83 |
vkCreateShaderModule(): Shader uses OpImageGather with offset (-8)
less than VkPhysicalDeviceLimits::minTexelGatherOffset (0). The Vulkan
spec states: If an OpImage*Gather operation has an image operand of
Offset, ConstOffset, or ConstOffsets the offset value must be greater
than or equal to minTexelGatherOffset"

Components: Vulkan
VK-GL-CTS issue: 3186

Affects:

   dEQP-VK.glsl.texture_gather.offset.*

Change-Id: I1c58d751a86dbe7a1a285a32daae19955b5b4582
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Fix missing self-subpass dependency

Self-subpass dependency required for read-after-write operation, in test
cases where the attachment is written using load-op-load at the start
of subpass and then the values are read inside the fragment shader.

Affects:

dEQP-
VK.renderpass.suballocation.subpass_dependencies.separate_channels.*
dEQP-
VK.renderpass2.suballocation.subpass_dependencies.separate_channels.*

Components: Vulkan

VK-GL-CTS issue: 3216

Change-Id: I6c72b81dccfb7526ec4607b255ff4872b13c4d22

Fix workgroup_memory_explicit_layout tests SPIR-V validation errors

Components: Vulkan
VK-GL-CTS issue: 3195

Affects:

   dEQP-VK.compute.workgroup_memory_explicit_layout.*

Change-Id: I2ac798965d9a3518bc45cfe52e43f34facf4ccf4
Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>

Verify line-stipple both with and without carry-over

The Vulkan spec specifies that carrying over the fractional parts of a
line is optional. Let's test both with and without, so we accept either.

Components: Vulkan, Framework

Public Issue: 280

Affected Tests: dEQP-VK.rasterization.primitives.static_stipple.*
dEQP-VK.rasterization.primitives_multisample_4_bit.*

Change-Id: Iaae3397ebfa1db7fbccefd479bd98c1ad8471ff8

Merge vk-gl-cts/vulkan-cts-1.2.6 into vk-gl-cts/vulkan-cts-1.2.7

Change-Id: I02d8c267d85372b375fcdcb1df69f2c6dc97796c

Add memoryBarrier before buffer map verify

OpenGL ES 3.2 Specification Section 7.11.2:

Shader Memory Access Synchronization ...

"Explicit syncronization is required to ensure the effects of buffer and
texture data stores performed by shaders will be visible to subsequent
operations using the same objects..."

Many of the ES3.1 compute tests lack a memory barrier before mapping and
verifiying buffer contents.  This can lead to flaky test failures when
the buffer has not been completely written to by the dispatchCompute
command. Specifically, chromeos and it's android arc++ has seen
consistent, yet flaky failures in es31fSynchronizationTests.inter_invocation.

It is unclear why this test should fail when similar tests, which also
lack explicit synchronization, do not.

Cherry pick from AOSP.

Original commit:
https://android.googlesource.com/platform/external/deqp/+/30c710319864b9e952daaaaf098df20845c2f70d
https://android-review.googlesource.com/c/platform/external/deqp/+/854112

TEST=chromeos caroline-arcnext (skylake)
Affects: dEQP-GLES31.functional.synchronization.*
Components: AOSP
Google Bug: b/85161472

Change-Id: I5093e7e206996e7c13c8c3615ee01ebbadc42f58
Signed-off-by: Joe M. Kniss <djmk@google.com>

Update Android test lists and Android files

Update Android test lists and other files to match AOSP
android12-tests-dev. Some tests are excluded from Android test lists and
some are moved between different Android test lists, but the tests
themselves do not change.

Components: AOSP
Change-Id: I28fdab5eb0b3fa75604f525a34fe843091836e75

Update Android test lists and Android files

Update Android test lists and other files to match AOSP
android12-tests-dev. Some tests are excluded from Android test lists and
some are moved between different Android test lists, but the tests
themselves do not change.

Components: AOSP
Change-Id: I28fdab5eb0b3fa75604f525a34fe843091836e75

EXT_multisampled_render_to_texture test

Detects a bug where ReadPixels fails on multisampled textures.
See http://crbug.com/890002

Cherry pick from AOSP.

Original commit:
https://android.googlesource.com/platform/external/deqp/+/accf1be52e32153c757cd84864607ee9c47dfe9a
https://android-review.googlesource.com/c/platform/external/deqp/+/796566
Submitted on behalf of a third-party: jdarpinian@chromium.org

Components: OpenGL

New test:
dEQP-GLES2.functional.multisampled_render_to_texture.readpixels

Bug: chromium:890002
Change-Id: I6e5e5d1fa3aa15daee69271339962a0b3ffc1927

Increase tolearance for dithering tests

For small dimension render targets, gradient tests
require more tolerance, as variance in adjacent pixels
will be more compared to bigger render targets.

Cherry pick from AOSP.

Original commit:
https://android.googlesource.com/platform/external/deqp/+/8dc015fa12e41a380b81c1b8fcc63a04bf34311a
https://android-review.googlesource.com/c/platform/external/deqp/+/971506
Submitted on behalf of a third-party: quic_spvasu@quicinc.com

Components: OpenGL

Affected tests:
dEQP-GLES3.functional.dither.*

Bug: 132146940
Change-Id: Ie48e119d164acf5763aa7956c3ff91da20ff9f38

Add watchdog touches to descriptor_pool test

On some low-end devices, this test would hit the dEQP watchdog. Add some
watchdog touches to avoid this.

Cherry pick.

Original commit:
123de98482b779ca242f9498701508b12e9a5f01
https://gerrit.khronos.org/c/vk-gl-cts/+/3197

Affected tests:
dEQP-VK.api.descriptor_pool.*

Google Bug: b/116847904
Component: Vulkan
Signed-off-by: Pierre Couillaud <pierre@broadcom.com>
VK-GL-CTS Issue: 1464

Change-Id: I18181aa274ab1dc191b5f0acbb58b41465b5cdad

Check fragment shader stores in frag shader side effect tests

Fragment shader side effect tests were using storage buffer store
operations in fragment shaders without checking support for the
fragmentStoresAndAtomics feature.

In addition, the tests were verifying the implementation supported the
color attachment and transfer features for the VK_FORMAT_R8G8B8A8_UNORM
format, but they are mandatory by the spec. The checks can be safely
removed.

Affected tests:
dEQP-VK.rasterization.frag_side_effects.*

Components: Vulkan
VK-GL-CTS issue: 3208

Change-Id: I5d28b18dd6aedbbfb1ea3ce4b40b3ba82737c27b

Use the correct view type in no_position tests

Multilayer no_position tests were creating image views with multiple
layers and the VK_IMAGE_VIEW_TYPE_2D type. When the number of layers is
greater than one, the type should be VK_IMAGE_VIEW_TYPE_2D_ARRAY.

Affected tests:
dEQP-VK.pipeline.no_position.*

Components: Vulkan
VK-GL-CTS issue: 3200

Change-Id: I9d24062c4f1ac80f12ac5dd1fe0e454ffade2f32

Check fragment shader stores in robustness tests

Some robustness tests were using fragment shader stores without checking
for the fragmentStoresAndAtomics feature.

Affected tests:
dEQP-VK.robustness.*.frag

Components: Vulkan
VK-GL-CTS issue: 3209

Change-Id: I8032bd19f7de4f2d87d642542c2b7aaec20965b8

Check cube array support in robustness tests

Some robustness tests were using VK_IMAGE_VIEW_TYPE_CUBE_ARRAY image
views without checking support for the imageCubeArray feature.

Affected tests:
dEQP-VK.robustness.*cube_array*

Components: Vulkan
VK-GL-CTS issue: 3210

Change-Id: Iafd363a6423251413a1093e15ae94aa50850af32

Merge vk-gl-cts/vulkan-cts-1.2.5 into vk-gl-cts/vulkan-cts-1.2.6

Change-Id: I64019cfcae5bcedae55f3e343bc94f51b62aa877

Merge vk-gl-cts/vulkan-cts-1.2.4 into vk-gl-cts/vulkan-cts-1.2.5

Change-Id: I0abe7100c16a273d62463b916957255150d344d0

Merge vk-gl-cts/vulkan-cts-1.2.3 into vk-gl-cts/vulkan-cts-1.2.4

Change-Id: Ib23f14c29d67945839ab3763968963d7dcc91464

Fix validation errors with unnormalized coordinates samplers

Components: Vulkan
VK-GL-CTS issue: 3190

Affects:

   dEQP-VK.pipeline.sampler.*unnormalized*

Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Change-Id: I1dde344fe39289b945a434eab7276dc58deab881

Fix descriptor indexing test dependency

The UBO and SSBO non-uniform indexing tests use runtimeDescriptorArray,
so this needs to be included in the checkSupport condition.

Components: Vulkan
Affects: dEQP-VK.ubo.*
         dEQP-VK.ssbo.*

Change-Id: I54edb2d06135a8d1d549a42ac97014dabc80c9dd

Check resource limits properly

The tests were not checking the resource limits per stage when
creating the shaders, which could create potential issues on
some drivers. Specially the random generated tests.

Affected tests:

   dEQP-VK.ssbo.layout.*

Components: Vulkan
VK-GL-CTS issue: 2953

Signed-off-by: Samuel Iglesias Gonsálvez <siglesias@igalia.com>
Change-Id: I7509dce38b849a0dd26f9e47d7f74e637930d897

Merge vk-gl-cts/vulkan-cts-1.2.2 into vk-gl-cts/vulkan-cts-1.2.3

Change-Id: Id485bc8ae929179e7786039966a233dd6fa57cdc

Add a batch of GraphicsFuzz coverage tests

This commit adds a batch of GraphicsFuzz coverage tests.

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.cov-copy-output-color-swizzle-array-indexing
dEQP-VK.graphicsfuzz.cov-do-while-loop-until-uniform-lt-itself
dEQP-VK.graphicsfuzz.cov-fract-trunc-always-zero
dEQP-VK.graphicsfuzz.cov-function-find-lsb-ivec2-one
dEQP-VK.graphicsfuzz.cov-function-unpack-unorm-2x16-one
dEQP-VK.graphicsfuzz.cov-global-loop-counter-texture-sample-loop-condition-set-array-element
dEQP-VK.graphicsfuzz.cov-ivec-shift-right-by-large-number
dEQP-VK.graphicsfuzz.cov-large-int-array-nested-loops-set-ivec-index-component-sum
dEQP-VK.graphicsfuzz.cov-min-negative-constant-always-below-one
dEQP-VK.graphicsfuzz.cov-nested-functions-loop-assign-global-array-element
dEQP-VK.graphicsfuzz.cov-nested-loops-global-loop-counter-fragcoord-negative-always-false

Change-Id: I78c78c2b681e4ea5a7b05fb787a6a6fe8f589f22

Add a batch of GraphicsFuzz coverage tests

This commit adds a batch of GraphicsFuzz coverage tests.

Components: Vulkan

New Tests:

dEQP-VK.graphicsfuzz.cov-for-loop-condition-one-shift-right-integer-comparison-break
dEQP-VK.graphicsfuzz.cov-for-loop-start-negative-increment-variable
dEQP-VK.graphicsfuzz.cov-global-loop-counter-exhaust-calling-function-twice
dEQP-VK.graphicsfuzz.cov-global-loop-counter-read-past-matrix-size-never-executed
dEQP-VK.graphicsfuzz.cov-if-true-float-bits-to-int-one
dEQP-VK.graphicsfuzz.cov-index-array-using-uniform-bitwise-or-one
dEQP-VK.graphicsfuzz.cov-loop-increment-integer-findmsb-minus-uniform
dEQP-VK.graphicsfuzz.cov-loop-struct-array-field-set-value-self-dependency
dEQP-VK.graphicsfuzz.cov-nested-loop-initializer-value-increased-inside
dEQP-VK.graphicsfuzz.cov-nested-loops-clamp-ivec-push-constant-increment-global-counter

Change-Id: Id2bb89247693464600142ef6988d070f03f7d70e