platform/core/csapi/xsf.git
4 years ago[Tizen]Update StaticRegistrar (#8676)
Rui Marinho [Tue, 26 Nov 2019 18:29:04 +0000 (18:29 +0000)]
[Tizen]Update StaticRegistrar (#8676)

4 years ago[Tizen] Provides Static Registrar (#8642)
Kangho Hur [Tue, 26 Nov 2019 16:21:04 +0000 (08:21 -0800)]
[Tizen] Provides Static Registrar (#8642)

* [Tizen] Provides Static Registrar

* Adds Lookup handler instead of fallback mechanism

4 years ago[Tizen] Add CarouselViewRenderer (#8081)
sung-su.kim [Tue, 26 Nov 2019 15:54:42 +0000 (00:54 +0900)]
[Tizen] Add CarouselViewRenderer (#8081)

* [Tizen] Add CarouselViewRenderer

* [Tizen] Fix item size

* Move ItemSizingStrategy property to StructuredItemsView

4 years agoImplement CollectionView Scrolled event on UWP (#8549)
Javier Suárez Ruiz [Tue, 26 Nov 2019 09:13:21 +0000 (10:13 +0100)]
Implement CollectionView Scrolled event on UWP (#8549)

fixes #8508

4 years agoMerge branch '4.3.0' into 4.4.0
shane [Sat, 23 Nov 2019 04:05:36 +0000 (21:05 -0700)]
Merge branch '4.3.0' into 4.4.0

# Conflicts:
# Xamarin.Forms.Platform.iOS/Renderers/ShellSectionRootHeader.cs

4 years agoAdded IndicatorsView (#7465)
Andrei [Sat, 23 Nov 2019 01:09:32 +0000 (04:09 +0300)]
Added IndicatorsView  (#7465)

* Added IndicatorsView

* removed static ctor

* refused plural in naming

* opened ItemsSource property

* followed code convention

* renamed IndicatorView (removed plural)

* made Color.Default as initial value

* updated IndicatorSize initial value

* Added IndicatorViewExtensions

* naming changes

* fix build

* small cleanup

* refactored control to templatedView

* added UIPageControl renderer for iOS

* moved extensions class to separate file

* removed useless private methods

* local vars name refactoring

* tapGesture naming update

* avoided linq

* code styling

* fixed default indicator colors for iOS

* added experimental flag

* [Core]Update api naming for IndicatorView

* Update IndicatorView.cs

* [Core] Add forms visual

* Revert "[Core] Add forms visual"

This reverts commit 380f36684ebf1d90ce8df074c13f70f8549ba8db.

* Revert "Revert "[Core] Add forms visual""

This reverts commit 6619e9e758970de3c11672ed2fb181dc37fe6ad0.

* [Gallery]Revert changes to gallery

* [Android] Export default renderer for FormsVisual

* [iOS] Handle FormsVisual for IndicatorView

* [iOS] Update Position from native renderer

* [iOS] IndicatorVIewRendederer updates and dispose

* [Controls] Fix merge

* Added IndicatorView Core Gallery sample

* Add  IndicatorSample

* Update Xamarin.Forms.Controls.csproj

* [Core] Fix FormsVisual check

* [iOS] Fix FormsVisual check

* [Controls] Fix Indicator Gallery sample

* [Core] Cleanup IndicatorView

* [Core]Fix toogle between template and shapes on FormsVisual

* [Controls] Fix indicators samples

* [Controls] Fix IndicatorTemplate

* [Core] Add ItemsSourceBy xaml option

* [iOS,Android,Core] Add IndicatorStacklayout

* [Android] Remove extra renderer for FormsVisual

* [Controls] Remove Visual from Indicator sample

* [Core, iOS, Android] Fix bug on IndcatorView

* - remove forms visual

* - remove extra shared

* - remove forms visual

* - remove disposable

* - remove renderer from tizen

4 years agoSwipeView (#7603)
Javier Suárez Ruiz [Sat, 23 Nov 2019 00:47:01 +0000 (01:47 +0100)]
SwipeView (#7603)

* Implemented SwipeView Spec

* Fixed close SwipeView when scrolling ScrollView in iOS

* Removed unnecessary SwipeItemInvokedEventArgs

* Separate ISwipeItem in a new file

* Changed BaseSwipeEventArgs to be abstract

* Changed SwipeView SwipeItems properties to use OneWay BindingMode

* SwipeDirectionHelpers is now no EditorBrowsable

* Removed unnecessary ContextItem

* Changed SwipeItems base type from BO to Element

* Added defaultValueCreator for SwipeItems (and new sample)

* Changes in UWP SwipeViewRenderer to change some SwipeItems validations

* Renamed CustomSwipeItem to SwipeItemView
Added Close method
Added new SwipeView sample in Core Gallery
Propagate BindingContext from SwipeView to SwipeItems
Fixed bug in Android where occasionally was not rendering the SwipeItem (BindableLayout)

* Moved command execution from the renderers to the abstraction

* Implemented Close method on UWP
Fixed issue to notify SwipeItems changes (add/remove) on UWP
Implemented Uri IconSource (fix SwipeItem using an Url on UWP)

* Updated CustomSwipeItem samples

* Fixed issue on Android (not rendering SwipeItem occasionally)

* Avoid use MessagingCenter to close the SwipeView when scrolling

* Added new Core Gallery sample using custom size SwipeItems
Fixed icon position on Android with big SwipeItems
Fixed custom SwipeItem size issue

* Fixed vertical swipe threshold calc

* Created ISwipeViewController
Moved SwipeItemView to a new class
Moved SwipeEventArgs to a new class
Changes in touch events in Android to have the same behavior as in Android

* Unsubscribe CollectionChanged from the OldElement on UWP renderer

* Allow open the swipeView if the width of the SwipeItems exceeds the width of the SwipeView
Fixed Android SwipeItem icon position calc issue

* Updated SwipeItems to use ISwipeViewController

* Fixed typo

* Fixed typo

* - remove EditorBrowsable

* Changed SwipeTransitionMode enum values

* - fix samsung fussiness

* - fix compile error for UAP

4 years agofix threadpool when compiling for 14393 (#8628)
Shane Neuville [Fri, 22 Nov 2019 21:06:14 +0000 (14:06 -0700)]
fix threadpool when compiling for 14393 (#8628)

4 years ago#3533 Bring back uap10.0/netstandard1.4 support (#7079) fixes #3533
Jiarui Guo [Fri, 22 Nov 2019 16:57:21 +0000 (08:57 -0800)]
#3533 Bring back uap10.0/netstandard1.4 support (#7079) fixes #3533

* target netstandard 1.4 for supporting rs2

* multi targeting

* initial tests

* - set a couple libraries to NS1.0

* - ns1.4

* - fix gallery project

* - fix min targets

* - fix target

* - remove sdk

* - buildControlsPath

* - nuget restore

* - controls path

* - uwp version

* - add generic

* - fix xbf

* - add tuple nuget

* - set max target to 16299

* - proj fixes

4 years agoUpdate LabelRenderer.cs (#8571) fixes #7019
Gerald Versluis [Fri, 22 Nov 2019 14:51:22 +0000 (15:51 +0100)]
Update LabelRenderer.cs (#8571) fixes #7019

4 years ago[UWP] Fix MDP Button "Padding" issue (#8610)
Gerald Versluis [Fri, 22 Nov 2019 03:04:10 +0000 (04:04 +0100)]
[UWP] Fix MDP Button "Padding" issue (#8610)

* Update MasterDetailControlStyle.xaml

* Added comments

* Update MasterDetailControlStyle.xaml

4 years ago[C] avoid calling ChangeVisualState twice (#8381)
Stephane Delcroix [Fri, 22 Nov 2019 00:25:32 +0000 (01:25 +0100)]
[C] avoid calling ChangeVisualState twice (#8381)

4 years agoRelativeSource Binding Bug Fixes (Gh8450) (#8541)
Peter Moore [Fri, 22 Nov 2019 00:21:33 +0000 (18:21 -0600)]
RelativeSource Binding Bug Fixes (Gh8450) (#8541)

* RelativeSource Binding Bug FIxes

(1) Fix RelativeSource-FindAncestorBindingContext bindings not re-applying on ancestor BindingContext or ancestry changes;
(2) fix incorrect interpretation of AncestorLevel;
(3) much more robust unit tests for RelativeSource ancestor-type binding (#4)

* Update Xamarin.Forms.Core.UnitTests/RelativeSourceBindingTests.cs

Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
Fixes #8450

4 years ago[iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command p… (#8544)
Brian Runck [Thu, 21 Nov 2019 23:49:05 +0000 (18:49 -0500)]
[iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command p… (#8544)

* iOS] Fix Issue #8529 - Shell BackButtonBehavior crashing on Command property binding on non-Xamarin.Forms.Command ICommand implementations

* Changes after code review

* - add ui test to android

4 years agoRemove ItemSizingStrategy from CarouselView (#8588)
E.Z. Hart [Thu, 21 Nov 2019 15:53:39 +0000 (08:53 -0700)]
Remove ItemSizingStrategy from CarouselView (#8588)

* Move ItemSizingStrategy

* Fix tests

* Fix Android

* Fix Tizen

* Fix iOS

4 years ago[iOS] Fix top tab highlighting (#8599)
Shane Neuville [Thu, 21 Nov 2019 15:33:05 +0000 (08:33 -0700)]
[iOS] Fix top tab highlighting (#8599)

* Let UICollectionViewCell handle state itself (#7884)

Fixes #7416

* [iOS] Fix top tab highlighting

4 years agoFix [Android] Can not set Entry cursor position by tapping if ClearButtonVisibility...
melimion [Thu, 21 Nov 2019 15:22:40 +0000 (18:22 +0300)]
Fix [Android] Can not set Entry cursor position by tapping if ClearButtonVisibility=WhenEditing (#8429)

* repro

* fix

* set _clearBtn to null in Dispose

* comment removed

4 years agoslow down gesture scroll for ui test and let it retry (#8591)
Shane Neuville [Thu, 21 Nov 2019 06:02:30 +0000 (23:02 -0700)]
slow down gesture scroll for ui test and let it retry (#8591)

4 years agoGif Animation Support (#7330)
Shane Neuville [Thu, 21 Nov 2019 05:52:52 +0000 (22:52 -0700)]
Gif Animation Support (#7330)

* Add image animation API.

* Add animated image tests.

* Add animated image UWP implementation.

* Add animated image IOS implementation.

* Add animated image Android implementation.

Also include GIF image parser base class + android parser sub class.

* Add animation finished playing event to Android/IOS for image.

* Add fallback when loading none GIF as animation image.

* Adding a couple of additional tests for animated images.

* Adjusting image animation support based on PR feedback.

* Add support to reload as animated image on StartAnimation call.

* Add UITest and activity indicator when loading from source for Issue1704.

* Reduce number of temporary bitmaps when scaling.

* Implemented review feedback.

* Animation problems related to Android API level 19 and earlier
due to a couple of bugs and changed behavior in AnimationDrawable class.
Implemented a couple of fixes and workaround related to these bugs, fixing
the animation issues on devices before Android Lollipop.

* Moved a couple of methods implemented in FormsAnimationDrawable into an
interface that is used to hide implementation details. Enables possibility
to factor different implementations of animation support going forward.

* Fixed review feedback and comments.

* Notify IOS to redraw control when changing animation layer.

* - android rebase fixes

* - first set of iOS changes for gifs

* - uwp Gif changes

* - clean up android gif code and enable gif for ImageButtons

* - cleanup iOS gif implementation

* - fix imagebutton and other sources

* - add imagebutton to tests

* - getting rid of start/stop and just using IsAnimationPlaying

* - image button

* - adding animation handler for android

* - replace gifs

* - fix rebase issues

* Added gif samples in Core Gallery

* Updated gif Core Gallery sample

* Fixed UWP gif samples path

* - remove auto play
- fix uwp so it plays correctly on load

* Added support to Url gifs on Android

* - fix rebase

* - fix NRE and iOS repeat

* - fix android loop counter

* - fix animation stopped on ios

* - fix removed ImageHandler interface Android

* - add top margin so ui tests can click button

4 years agoShell Navigation Bar Has Shadow property (#8408)
Shane Neuville [Wed, 20 Nov 2019 11:51:30 +0000 (04:51 -0700)]
Shell Navigation Bar Has Shadow property (#8408)

* add shadow api for shell nav bar

* - ios fixes

* - ios fixes

* - name fix android and simplify types on ios

* - change to listener

* - cleanup

* - remove toolbar

* - fix ios to propagate nav bar on page push

* - fix android crash

4 years agoFix NRE on iOS 10 when navigating away from a page with a grouped CollectionView...
E.Z. Hart [Tue, 19 Nov 2019 19:19:14 +0000 (12:19 -0700)]
Fix NRE on iOS 10 when navigating away from a page with a grouped CollectionView (#8496)

4 years agoExpose top tab creation methods (#8441) fixes #7808 fixes #8428
Shane Neuville [Tue, 19 Nov 2019 14:19:57 +0000 (07:19 -0700)]
Expose top tab creation methods (#8441) fixes #7808 fixes #8428

4 years agoUpdate MacDeviceInfo.cs (#8561) fixes #8559
Gerald Versluis [Tue, 19 Nov 2019 11:05:18 +0000 (12:05 +0100)]
Update MacDeviceInfo.cs (#8561) fixes #8559

4 years agoFix crash using the CarouselView and EmptyView (#8430)
Javier Suárez Ruiz [Tue, 19 Nov 2019 10:24:53 +0000 (11:24 +0100)]
Fix crash using the CarouselView and EmptyView (#8430)

4 years agoFix Bug 7823 - Frame corner radius (#8032)
Felipe Baltazar [Tue, 19 Nov 2019 10:09:16 +0000 (07:09 -0300)]
Fix Bug 7823 - Frame corner radius (#8032)

* Fix Bug 7823

* Code review

Co-Authored-By: Gerald Versluis <github@geraldversluis.nl>
* Code review ♻

* Code review ♻

* revert 7f93346a3d1d3261d05843084d1934d5201b0c75

* Revert d9ad8f31507e8373a2db1f4b9eb737b256dcf6ad

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

* Update Xamarin.Forms.Controls.Issues.Shared.projitems

* rebase 4.4.0 fixes

* fix rebase 4.4.0

* fix rebase 4.4.0

* Fix test 7823

* Fixes api 19 test

4 years agoMerge branch '4.3.0' into 4.4.0
Shane Neuville [Tue, 19 Nov 2019 01:31:25 +0000 (18:31 -0700)]
Merge branch '4.3.0' into 4.4.0

# Conflicts:
# Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj
# build.cake

4 years agoMerge branch '4.2.0' into 4.3.0
Shane Neuville [Tue, 19 Nov 2019 00:58:28 +0000 (17:58 -0700)]
Merge branch '4.2.0' into 4.3.0

# Conflicts:
# azure-pipelines.yml

4 years agoAdd export method for transform string on UI Tests (#8532)
Shane Neuville [Tue, 19 Nov 2019 00:54:56 +0000 (17:54 -0700)]
Add export method for transform string on UI Tests (#8532)

* export transform string

* - add missing renderers to performance tracker

* Update Xamarin.Forms.ControlGallery.iOS/PerformanceTrackerRenderer.cs

4 years agoImplement FormsStack and FormsQueue internally for VS 2017 Compatibility (#8403)
Shane Neuville [Mon, 18 Nov 2019 17:10:14 +0000 (10:10 -0700)]
Implement FormsStack and FormsQueue internally for VS 2017 Compatibility  (#8403)

* FormsStack and FormsQueue for VS 2017 Compat

* - sync stable vs mac versions

* - mono version

* - gtk

* - fix mono provision

* Update Xamarin.Forms.Platform.Android/Xamarin.Forms.Platform.Android.csproj

* - remove uwp changes

* - add 2019 back in

* Update azure-pipelines.yml

4 years agoKeep tab image collapsed if no datasource is available (#8050) fixes #6757
Glenn Versweyveld [Mon, 18 Nov 2019 14:38:35 +0000 (15:38 +0100)]
Keep tab image collapsed if no datasource is available (#8050) fixes #6757

4 years agoMerge branch '4.3.0' into 4.4.0
Stephane Delcroix [Mon, 18 Nov 2019 10:39:51 +0000 (11:39 +0100)]
Merge branch '4.3.0' into 4.4.0

4 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 18 Nov 2019 10:38:36 +0000 (11:38 +0100)]
Merge branch '4.2.0' into 4.3.0

4 years agoDisable packager for CollectionView on UWP (#8404)
E.Z. Hart [Mon, 18 Nov 2019 09:19:50 +0000 (02:19 -0700)]
Disable packager for CollectionView on UWP (#8404)

* Reproduce issue 8366

* Clean up old comments

* Turn off packaging for the CollectionView on UWP
Fixes #8366

4 years agoFix 7361 - [UWP] Stepper buttons not becoming enabled again, when disabled more than...
Jon Robinson Levy [Fri, 15 Nov 2019 13:54:35 +0000 (14:54 +0100)]
Fix 7361 - [UWP] Stepper buttons not becoming enabled again, when disabled more than once. (#8191)

* Adding test class Issue7361

* Adding checks to prevent PseudoDisable from being called once _plus- or _minusStateCache is set.

* Improving Instructions in Issue7361 test page.

4 years ago[Build] Update version numbers to ship from yaml (#8437)
Rui Marinho [Wed, 13 Nov 2019 23:44:47 +0000 (23:44 +0000)]
[Build] Update version numbers to ship from yaml (#8437)

* Update version numbers

* Update Version.targets

* Fix variables

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* Update azure-pipelines.yml

* Update azure-pipelines.yml

4 years ago[X] FontSizeConverter on FontImageExtension (#8375)
Stephane Delcroix [Wed, 13 Nov 2019 15:09:43 +0000 (16:09 +0100)]
[X] FontSizeConverter on FontImageExtension (#8375)

fixes https://github.com/xamarin/Xamarin.Forms/pull/7887#issuecomment-549437276

4 years ago[Tizen] Enables SwipeGestureHandler (#8456)
Kangho Hur [Tue, 12 Nov 2019 11:04:43 +0000 (03:04 -0800)]
[Tizen] Enables SwipeGestureHandler (#8456)

4 years agoReset transformation properly on UWP (#7385) (#7386)
Philippe Leybaert [Mon, 11 Nov 2019 18:50:53 +0000 (12:50 -0600)]
Reset transformation properly on UWP (#7385) (#7386)

4 years agoMerge branch '4.3.0' into 4.4.0
Shane Neuville [Fri, 8 Nov 2019 20:33:32 +0000 (13:33 -0700)]
Merge branch '4.3.0' into 4.4.0

4 years agoMake character spacing work for UWP Picker without breaking ItemsSource (#8356)
E.Z. Hart [Fri, 8 Nov 2019 19:44:08 +0000 (12:44 -0700)]
Make character spacing work for UWP Picker without breaking ItemsSource (#8356)

* Make character spacing work for UWP Picker without breaking ItemsSource
Fixes #8177

* Add test instructions

4 years agoEnsure that ParentSet fires before OnAppearing (#8242)
Shane Neuville [Wed, 6 Nov 2019 10:28:01 +0000 (03:28 -0700)]
Ensure that ParentSet fires before OnAppearing (#8242)

4 years ago[Android] Fix API usage on Android19 (#8378)
Rui Marinho [Wed, 6 Nov 2019 10:12:42 +0000 (10:12 +0000)]
[Android] Fix API usage on Android19  (#8378)

* [Android] Check api usage for set color on image drawable

* [Android] Add missing brackets

4 years ago[Android] Fix Switch Thumb wrong color (#7777) fixes #7249
Javier Suárez Ruiz [Tue, 5 Nov 2019 14:56:17 +0000 (15:56 +0100)]
[Android] Fix Switch Thumb wrong color (#7777) fixes #7249

4 years agoAdded defensive code (#8324)
Gerald Versluis [Tue, 5 Nov 2019 09:53:34 +0000 (10:53 +0100)]
Added defensive code (#8324)

4 years agoAdd missing null check on ItemsSource when IsGrouped is true; fixes #8269 (#8273)
E.Z. Hart [Mon, 4 Nov 2019 21:21:59 +0000 (14:21 -0700)]
Add missing null check on ItemsSource when IsGrouped is true; fixes #8269 (#8273)

4 years agoFix UWP Toolbar icons (#8147)
Gerald Versluis [Mon, 4 Nov 2019 20:37:28 +0000 (21:37 +0100)]
Fix UWP Toolbar icons (#8147)

* Added demo and fix

* Update Issue7505.cs

* Update Platform.cs

* Fixed AsyncValue

4 years agoFix crash using an object that implements IEnumerable and INotifyCollectionChanged...
Javier Suárez Ruiz [Mon, 4 Nov 2019 20:08:43 +0000 (21:08 +0100)]
Fix crash using an object that implements IEnumerable and INotifyCollectionChanged (#8283) fixes #8200

4 years agoMerge branch '4.3.0' into 4.4.0
Rui Marinho [Mon, 4 Nov 2019 13:26:25 +0000 (13:26 +0000)]
Merge branch '4.3.0' into 4.4.0

4 years agoMerge branch '4.2.0' into 4.3.0
Rui Marinho [Mon, 4 Nov 2019 13:10:00 +0000 (13:10 +0000)]
Merge branch '4.2.0' into 4.3.0

4 years ago[Android] Fix API21 usage on shell (#8335)
Rui Marinho [Fri, 1 Nov 2019 20:58:47 +0000 (20:58 +0000)]
[Android] Fix API21 usage on shell (#8335)

* [Android] Fix API21 usage

* [Android] Remove extra usings

4 years agoPrevent UWP error/crash when updating binding off the main thread; fixes #8167 (...
E.Z. Hart [Fri, 1 Nov 2019 20:20:32 +0000 (14:20 -0600)]
Prevent UWP error/crash when updating binding off the main thread; fixes #8167 (#8311)

4 years ago[iOS] Fix scroll to does not scroll to end (#8241)
Konrad Müller [Fri, 1 Nov 2019 18:50:32 +0000 (19:50 +0100)]
[iOS] Fix scroll to does not scroll to end (#8241)

* Fix scroll to does not scroll to end

* Remove private modifier

4 years ago[Build] Clean repos, update vs image (#8339)
Rui Marinho [Thu, 31 Oct 2019 17:06:42 +0000 (17:06 +0000)]
[Build] Clean repos, update vs image (#8339)

4 years agoRevert "[GTK] Fix visibility of hidden pages in the stack (#8096)
Samantha Houts [Thu, 31 Oct 2019 00:31:13 +0000 (17:31 -0700)]
Revert "[GTK] Fix visibility of hidden pages in the stack (#8096)

4 years agochange accessibility modifiers (#8264)
adrianknight89 [Wed, 30 Oct 2019 21:15:20 +0000 (16:15 -0500)]
change accessibility modifiers (#8264)

4 years agoFix 8222 - [UWP] Make text in Editor control top aligned (#8280)
Jon Robinson Levy [Wed, 30 Oct 2019 15:49:37 +0000 (16:49 +0100)]
Fix 8222 - [UWP] Make text in Editor control top aligned (#8280)

* Adding test case page for Issue 8222.

* Adding top alignment to text by setting VerticalContentAlignment = Verticalalignment.Top in the internal FormsTextBox. Fixes Issue 8222.

* Removing version file added by mistake

* Removing version file added by mistake

* Removing version file added by mistake

* Removing version file added by mistake

4 years agoimplement placeholder text alignment (#8292)
Konrad Müller [Wed, 30 Oct 2019 12:00:42 +0000 (13:00 +0100)]
implement placeholder text alignment (#8292)

4 years agoImplement fix (#8281)
Gerald Versluis [Wed, 30 Oct 2019 10:50:09 +0000 (11:50 +0100)]
Implement fix (#8281)

4 years agoMerge branch '4.3.0' into 4.4.0
Rui Marinho [Tue, 29 Oct 2019 23:50:57 +0000 (23:50 +0000)]
Merge branch '4.3.0' into 4.4.0

4 years ago[Android] Make sure we use the right Context (#8196)
Rui Marinho [Tue, 29 Oct 2019 13:08:11 +0000 (13:08 +0000)]
[Android] Make sure we use the right Context (#8196)

4 years ago[Android, Shell] Don't double dispose the more sheet (#8212) fixes #8145
Samantha Houts [Tue, 29 Oct 2019 11:18:34 +0000 (04:18 -0700)]
[Android, Shell] Don't double dispose the more sheet (#8212) fixes #8145

* Add test case for issue 8145

* [Android] Don't double dispose the more sheet

fixes #8145

4 years agoBetter detect IsCollapsed state/changes on master (#8181)
Shane Neuville [Tue, 29 Oct 2019 00:42:11 +0000 (18:42 -0600)]
Better detect IsCollapsed state/changes on master (#8181)

4 years ago[UWP] Delay RequestRefresh until Loaded (#8190)
Shane Neuville [Tue, 29 Oct 2019 00:41:14 +0000 (18:41 -0600)]
[UWP] Delay RequestRefresh until Loaded (#8190)

fixes #8186

4 years agoOccasionally clean up WeakReferences in Styles whose targets have been collected...
E.Z. Hart [Thu, 24 Oct 2019 17:47:05 +0000 (11:47 -0600)]
Occasionally clean up WeakReferences in Styles whose targets have been collected (#8124)

4 years ago[X] resolve indexers on generic types (#8226)
Stephane Delcroix [Mon, 28 Oct 2019 18:25:35 +0000 (19:25 +0100)]
[X] resolve indexers on generic types (#8226)

The lovely #7837 is trying to be smarter at identifying which indexer to invoke,
by checking the parametertype. Of course, it wasn't tested on generic types...

So this is definitely a regression, I apologize for it.

- fixes #8221

4 years agoFix Flyout behavior so it propagates from templated Content Page once it's created...
Shane Neuville [Mon, 28 Oct 2019 17:26:55 +0000 (11:26 -0600)]
Fix Flyout behavior so it propagates from templated Content Page once it's created (#8135) fixes #7985

* Centralize SendAppearanceChanged call

* - Appearance Change UI tests

* - remove extra button and add better messaging

* - make sure there is space to swipe

* - fix rebase

* - only call appearance change if display page changes

* - process appearance changes before page has fully popped

4 years ago[Build] Remove duplicated compile items
Rui Marinho [Mon, 28 Oct 2019 12:21:29 +0000 (12:21 +0000)]
[Build] Remove duplicated compile items

4 years ago[Build] Fix merge
Rui Marinho [Mon, 28 Oct 2019 11:42:23 +0000 (11:42 +0000)]
[Build] Fix merge

4 years agoMerge 4.3.0 to 4.4.0
Rui Marinho [Mon, 28 Oct 2019 11:18:20 +0000 (11:18 +0000)]
Merge 4.3.0 to 4.4.0

4 years agoDisable packager in iOS ItemsViewRenderer (#8189)
E.Z. Hart [Fri, 25 Oct 2019 22:25:22 +0000 (16:25 -0600)]
Disable packager in iOS ItemsViewRenderer (#8189)

* fix collectionview renderering weirdness

* add ui test

* include in projitems

* Disable the VisualElementPackager for the ItemsView

4 years agoStore references to local variable so it's not collected (#8205)
Shane Neuville [Fri, 25 Oct 2019 14:38:53 +0000 (08:38 -0600)]
Store references to local variable so it's not collected (#8205)

4 years agoiOS Cell default bgcolor to transparent (#7903) fixes #7680 fixes #7850
Gerald Versluis [Fri, 25 Oct 2019 14:07:07 +0000 (16:07 +0200)]
iOS Cell default bgcolor to transparent (#7903) fixes #7680 fixes #7850

* Update CellRenderer.cs

* Update CellRenderer.cs

* Update CellRenderer.cs

4 years agouse support libs for DrawableWrapper (#8106) fixes #6291
Alan Grgic [Fri, 25 Oct 2019 11:37:46 +0000 (06:37 -0500)]
use support libs for DrawableWrapper (#8106) fixes #6291

4 years agoforeground color fix (#8149)
melimion [Thu, 24 Oct 2019 18:24:51 +0000 (21:24 +0300)]
foreground color fix (#8149)

fixes #8148

4 years agoOccasionally clean up WeakReferences in Styles whose targets have been collected...
E.Z. Hart [Thu, 24 Oct 2019 17:47:05 +0000 (11:47 -0600)]
Occasionally clean up WeakReferences in Styles whose targets have been collected (#8124)

4 years agoRebase and Clean Up (#8107)
Brian Macomber [Thu, 24 Oct 2019 10:11:24 +0000 (05:11 -0500)]
Rebase and Clean Up (#8107)

4 years agoAdded instructions and changed the test for Issue2241 (#8080) fixes #2274
adrianknight89 [Thu, 24 Oct 2019 09:56:06 +0000 (04:56 -0500)]
Added instructions and changed the test for Issue2241 (#8080) fixes #2274

* added instructions

* cache old centerY

* Revert "cache old centerY"

This reverts commit cd75d74654d23359cf3ab72d601cb4109a94cda0.

4 years agoSet correct MinWidth for CheckBox style (#7978)
Glenn Versweyveld [Thu, 24 Oct 2019 09:50:46 +0000 (11:50 +0200)]
Set correct MinWidth for CheckBox style (#7978)

Fixes #7048

# Conflicts:
# Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems

4 years ago[Android] Null checks (#7941) fixes #7939
Gerald Versluis [Thu, 24 Oct 2019 09:43:27 +0000 (11:43 +0200)]
[Android] Null checks (#7941) fixes #7939

4 years agoFix bug 7581 - UWP Map not moving to location when map hidden then shown (#7960)
Konrad Müller [Thu, 24 Oct 2019 07:49:25 +0000 (09:49 +0200)]
Fix bug 7581 - UWP Map not moving to location when map hidden then shown (#7960)

* Add repro

* Set region on layout when move to region failed before

4 years ago[Enhancement] Batch updates via "using" statement (#7807)
Andrei [Thu, 24 Oct 2019 00:27:09 +0000 (03:27 +0300)]
[Enhancement] Batch updates via "using" statement (#7807)

* Added batch object

* updated unit tests

4 years ago[iOS] Fix iOS ScrollToAsync not completing when scrolling to current location (#7979)
Oliver Brown [Wed, 23 Oct 2019 23:09:55 +0000 (00:09 +0100)]
[iOS] Fix iOS ScrollToAsync not completing when scrolling to current location (#7979)

* Add test case for scroll completed.

* Check iOS scrollview for scrolling to the same place.
fixes #7972

4 years agoRevert "[GTK] Fix visibility of hidden pages in the stack (#3904) (#8096)
Andres G. Aragoneses [Wed, 23 Oct 2019 23:02:59 +0000 (07:02 +0800)]
Revert "[GTK] Fix visibility of hidden pages in the stack (#3904) (#8096)

* Revert "[GTK] Fix visibility of hidden pages in the stack (#3904)"

This reverts commit b5b9404bda761e7e5941da7ff26f1d42dd62d1b2.

# Conflicts:
# Xamarin.Forms.Platform.GTK/Controls/Page.cs

* Added test sample for #6663
Fixes #6663

4 years ago[macOs] implements Frame CornerRadius (#8168)
melimion [Wed, 23 Oct 2019 23:01:52 +0000 (02:01 +0300)]
[macOs] implements Frame CornerRadius (#8168)

* implement CornerRadius in FrameRenderer

* add CornerRadius to FrameCoreGalleryPage

* CornerRadius added to Frame enum in TestAttributes

4 years ago[Android] Fix Material button renderer setbackgroundcolor (#8089) fixes #5747 fixes...
Ravinder Jangra [Wed, 23 Oct 2019 18:50:10 +0000 (00:20 +0530)]
[Android] Fix Material button renderer setbackgroundcolor (#8089) fixes #5747 fixes #7002

4 years agoFix System.OverflowException for Hsl with double in invariant string (#8114) fixes...
Bohdan Benetskyi [Wed, 23 Oct 2019 18:22:27 +0000 (20:22 +0200)]
Fix System.OverflowException for Hsl with double in invariant string (#8114) fixes #8113

4 years agoAdding instructions to the UI Test (issue #38770) (#8062)
Mikolaj Kieres [Wed, 23 Oct 2019 18:06:24 +0000 (05:06 +1100)]
Adding instructions to the UI Test (issue #38770) (#8062)

4 years agoFix android scrollbar visibility issue (#8090) fixes #7629 #8015
Ravinder Jangra [Wed, 23 Oct 2019 12:07:00 +0000 (17:37 +0530)]
Fix android scrollbar visibility issue (#8090) fixes #7629 #8015

4 years agoDon't force the Master page closed on disappear if it's set to always visible (#8164)
Shane Neuville [Wed, 23 Oct 2019 10:37:02 +0000 (04:37 -0600)]
Don't force the Master page closed on disappear if it's set to always visible (#8164)

* Don't force master closed when on split

* - fix UI tests to correctly test for tablet

* - remove extra code

* - fix issue with rotation from Modal

4 years agoAutomating bugzilla issue 33870 (#7968)
Mikolaj Kieres [Wed, 23 Oct 2019 08:15:16 +0000 (19:15 +1100)]
Automating bugzilla issue 33870 (#7968)

* Automating bugzilla issue #33870

* Adding UITest category

* Fixing a typo

4 years agoIn Android : Reverse layout only when default layout direction is the… (#7809)
Elashi [Tue, 22 Oct 2019 16:50:36 +0000 (19:50 +0300)]
In Android : Reverse layout only when default layout direction is the… (#7809)

* In Android : Reverse layout only when default layout direction is the opposite of the user settings (#7393)

* - remove ReverseLayout and just rely on LayoutDirection

* - fix formatting

4 years agoFix random test failures (#8083)
Rui Marinho [Tue, 22 Oct 2019 09:54:50 +0000 (10:54 +0100)]
Fix random test failures (#8083)

* [UITEsts] Ignore vertical test

* [UITests] Ignore 5766 uitest

* [UITests] Ignore UITest 1342

4 years agoUnregister effects on dispose (#8109)
Andrei [Tue, 22 Oct 2019 09:52:35 +0000 (12:52 +0300)]
Unregister effects on dispose (#8109)

4 years agoSet MinimumWidth to the correct value on grid calc (#7318)
Shane Neuville [Mon, 21 Oct 2019 19:50:47 +0000 (13:50 -0600)]
Set MinimumWidth to the correct value on grid calc (#7318)

fixes #7303

4 years agoopacity mask added to FrameRenderer (#7828)
melimion [Mon, 21 Oct 2019 19:49:46 +0000 (22:49 +0300)]
opacity mask added to FrameRenderer (#7828)

fixes #7825

4 years agoset XF Verions File to be hidden (#8128)
Shane Neuville [Mon, 21 Oct 2019 19:03:27 +0000 (13:03 -0600)]
set XF Verions File to be hidden (#8128)

4 years ago[Android] Use AppCompat AlertDialog (#8046)
Joe Manke [Mon, 21 Oct 2019 10:16:17 +0000 (05:16 -0500)]
[Android] Use AppCompat AlertDialog (#8046)

* Change Android ControlGallery theme to inherit from Theme.AppCompat.DayNight to test GitHub issue #8029

* Use AppCompat AlertDialog in Android PopupManager

* Apply style to both default and AppCompat dialogs for comparison.

4 years agoMerge branch '4.3.0'
Stephane Delcroix [Mon, 21 Oct 2019 08:45:57 +0000 (10:45 +0200)]
Merge branch '4.3.0'

4 years agoMerge branch '4.2.0' into 4.3.0
Stephane Delcroix [Mon, 21 Oct 2019 08:40:15 +0000 (10:40 +0200)]
Merge branch '4.2.0' into 4.3.0

4 years agoFix ListView.ScrollTo does not work in WPF (#7947)
melimion [Fri, 18 Oct 2019 17:28:29 +0000 (20:28 +0300)]
Fix ListView.ScrollTo does not work in WPF (#7947)

* ScrollTo implementation added

* ScrollToPosition.Center implemented

* animation implemented