platform/upstream/libSkiaSharp.git
10 years agoRebaseline R11 and ASTC bitmap GMs
krajcevski [Thu, 14 Aug 2014 14:24:52 +0000 (07:24 -0700)]
Rebaseline R11 and ASTC bitmap GMs

TBR=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/471723002

10 years agorebaseline_server: include setA/setB descriptions in output JSON
epoger [Thu, 14 Aug 2014 14:12:46 +0000 (07:12 -0700)]
rebaseline_server: include setA/setB descriptions in output JSON

This is needed for rebaselining using the shared rebaseline_server instance:
by telling the client which git revision was used to fetch expectations, we
allow the client to pass that back along with new baselines (so the server
knows which revision to patch).

This is also handy in that it allows the server to tell the client more about the
different result sets (which files they were generated from).

BUG=skia:1918
NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/474813002

10 years agoRemove SkPaintOptionsAndroid
djsollen [Thu, 14 Aug 2014 13:29:02 +0000 (06:29 -0700)]
Remove SkPaintOptionsAndroid

Committed: https://skia.googlesource.com/skia/+/f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b

R=reed@google.com, mtklein@google.com, tomhudson@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/447873003

10 years agorebaseline_server UI: add link to raw JSON
epoger [Thu, 14 Aug 2014 02:29:49 +0000 (19:29 -0700)]
rebaseline_server UI: add link to raw JSON

patchset 3 from https://codereview.chromium.org/467843002

NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana

Author: epoger@google.com

Review URL: https://codereview.chromium.org/475623002

10 years agorebaseline_server: move more code into common path for GET_live_results and GET_prefe...
epoger [Thu, 14 Aug 2014 02:23:33 +0000 (19:23 -0700)]
rebaseline_server: move more code into common path for GET_live_results and GET_prefetch_results

patchset 1 from issue 467843002

BUG=skia:1918
NOTREECHECKS=true
NOTRY=true
R=stephana@google.com
TBR=stephana

Author: epoger@google.com

Review URL: https://codereview.chromium.org/465143004

10 years agoThis is a bit of a hack, but will work. I have a cleaner fix ready (but still need...
stephana [Thu, 14 Aug 2014 02:12:57 +0000 (19:12 -0700)]
This is a bit of a hack, but will work. I have a cleaner fix ready (but still need to fix some broken tests).

BUG=skia:
NOTRY=true
R=epoger@google.com

Author: stephana@google.com

Review URL: https://codereview.chromium.org/472703002

10 years agoFix typo in ignored-tests.txt
Brian Salomon [Wed, 13 Aug 2014 22:31:03 +0000 (18:31 -0400)]
Fix typo in ignored-tests.txt

BUG=skia:

Review URL: https://codereview.chromium.org/475583002

10 years agoRevert of Remove SkPaintOptionsAndroid (patchset #5 of https://codereview.chromium...
bsalomon [Wed, 13 Aug 2014 22:18:46 +0000 (15:18 -0700)]
Revert of Remove SkPaintOptionsAndroid (patchset #5 of https://codereview.chromium.org/447873003/)

Reason for revert:
Breaks the Chromium build: http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-DRT/builds/2469/steps/BuildContentShell_1/logs/stdio

Original issue's description:
> Remove SkPaintOptionsAndroid
>
> Committed: https://skia.googlesource.com/skia/+/f32331ffdb5de0440bb337aa7cbdd6f33e9ff23b

R=reed@google.com, mtklein@google.com, tomhudson@google.com, djsollen@google.com
TBR=djsollen@google.com, mtklein@google.com, reed@google.com, tomhudson@google.com
NOTREECHECKS=true
NOTRY=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/473543004

10 years agoStart tracking the CTM while filling the BBH in SkRecordDraw.
mtklein [Wed, 13 Aug 2014 20:33:49 +0000 (13:33 -0700)]
Start tracking the CTM while filling the BBH in SkRecordDraw.

Depends on https://codereview.chromium.org/475473002/

BUG=skia:
R=robertphillips@google.com, reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/468193003

10 years agoRemove SkPaintOptionsAndroid
djsollen [Wed, 13 Aug 2014 20:09:49 +0000 (13:09 -0700)]
Remove SkPaintOptionsAndroid

R=reed@google.com, mtklein@google.com, tomhudson@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/447873003

10 years agoStart filling BBH in SkRecordDraw.
mtklein [Wed, 13 Aug 2014 19:58:45 +0000 (12:58 -0700)]
Start filling BBH in SkRecordDraw.

This starts with a skeleton of how to calculate bounds for ops which don't have
their own bounds.  For any given Save/Restore block, we'll find the union of the
bounds of all the draws inside it (including other Save/Restore blocks), then say
those are the bounds of all non-draws in the block, including the Save and Restore.

To implement this, we keep a stack of active Save blocks.  Any time we hit a
non-drawing op ("control"), we'll add it to that Save block (implemented with a
separate stack of indices and a count of control ops in the entry on the Save
stack).  Save and SaveLayer push onto the stack, and Restore pops the stack, at
which point we can fill in the bounds for all the control ops in the block.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/475473002

10 years agoroll common deps
epoger [Wed, 13 Aug 2014 19:51:57 +0000 (12:51 -0700)]
roll common deps

NOTRY=true
R=borenet@google.com
TBR=borenet

Author: epoger@google.com

Review URL: https://codereview.chromium.org/469043003

10 years agoAdd runtime flag to turn compressed alpha masks on
krajcevski [Wed, 13 Aug 2014 19:06:26 +0000 (12:06 -0700)]
Add runtime flag to turn compressed alpha masks on

R=bsalomon@google.com, robertphillips@google.com, mtklein@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/468293002

10 years agoBaseline Android-Reference-Unknown-Arm64
mtklein [Wed, 13 Aug 2014 18:59:53 +0000 (11:59 -0700)]
Baseline Android-Reference-Unknown-Arm64

BUG=skia:
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/474563002

10 years agoUpdate path to Android font config file
tomhudson [Wed, 13 Aug 2014 18:06:43 +0000 (11:06 -0700)]
Update path to Android font config file

In version LMP, Android is expected to change the path to their font
configuration file (and condense several files into one), as well as
changing the format (qv http://crrev.com/446473003/). This patch tries
the new path before falling back to the old path.

The new fonts are incompatible with assumptions made by the old
SkFontConfigInterfaceAndroid, so this patch MUST NOT land until
https://crrev.com/462073002/ or the equivalent has turned on the
new SkFontManager.

BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com, tomhudson@google.com

Committed: https://skia.googlesource.com/skia/+/94fa4b99e2a53e997a90c7808cc5263f1bf40c9f

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/458543002

10 years agoAdd entry point for passing options to the GrContextFactory
krajcevski [Wed, 13 Aug 2014 17:46:31 +0000 (10:46 -0700)]
Add entry point for passing options to the GrContextFactory

R=bsalomon@google.com, mtklein@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/465073002

10 years agoAdd support for new drawPicture entry point to debugger
robertphillips [Wed, 13 Aug 2014 17:46:23 +0000 (10:46 -0700)]
Add support for new drawPicture entry point to debugger

R=fmalita@google.com, fmalita@chromium.org

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/464063003

10 years agoDelete the old font management implementation based on SkFontConfigInterface, now...
tomhudson [Wed, 13 Aug 2014 17:41:25 +0000 (10:41 -0700)]
Delete the old font management implementation based on SkFontConfigInterface, now that SkFontMgr_Android is live.

BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/445143002

10 years agoDon't leak the shader in PatchBench.
mtklein [Wed, 13 Aug 2014 17:41:16 +0000 (10:41 -0700)]
Don't leak the shader in PatchBench.

BUG=skia:
R=dandov@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/465083003

10 years agogit cl land# Enter a description of the change.
Brian Salomon [Wed, 13 Aug 2014 17:37:45 +0000 (13:37 -0400)]
git cl land# Enter a description of the change.
Even more tests to ignored-tests for gpu rect changes

BUG=skia:

Review URL: https://codereview.chromium.org/468223003

10 years agoAdd override to force bitmap rendering
krajcevski [Wed, 13 Aug 2014 17:36:18 +0000 (10:36 -0700)]
Add override to force bitmap rendering

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/462203002

10 years agoThis eliminates the need to copy the generated images from a temporary directory...
stephana [Wed, 13 Aug 2014 17:36:06 +0000 (10:36 -0700)]
This eliminates the need to copy the generated images from a temporary directory to the directory that is served by the rebaseline_server.

BUG=skia:2815, skia:2818
R=epoger@google.com

Author: stephana@google.com

Review URL: https://codereview.chromium.org/457203003

10 years agoUpdating expectations for matrix convolution
joshualitt [Wed, 13 Aug 2014 17:31:04 +0000 (10:31 -0700)]
Updating expectations for matrix convolution

R=bsalomon@chromium.org
BUG=skia:

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/464913003

10 years agoDM: Replace --pathOpsVerbose with --veryVerbose
halcanary [Wed, 13 Aug 2014 17:30:57 +0000 (10:30 -0700)]
DM: Replace --pathOpsVerbose with --veryVerbose

R=caryclark@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/468963002

10 years agorebaseline_server: add some live-view.html links to index.html
epoger [Wed, 13 Aug 2014 16:38:22 +0000 (09:38 -0700)]
rebaseline_server: add some live-view.html links to index.html

NOTREECHECKS=true
NOTRY=true
R=stephana@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/463213002

10 years agoadd expectations for Test-Android-Reference-Unknown-Arm64-{Debug,Release}
epoger [Wed, 13 Aug 2014 16:36:46 +0000 (09:36 -0700)]
add expectations for Test-Android-Reference-Unknown-Arm64-{Debug,Release}

BUG=skia:2828
NOTREECHECKS=true
NOTRY=true
R=mtklein@google.com
TBR=mtklein

Author: epoger@google.com

Review URL: https://codereview.chromium.org/468243002

10 years agofix win compiler div/zero
halcanary [Wed, 13 Aug 2014 16:20:08 +0000 (09:20 -0700)]
fix win compiler div/zero

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/474433002

10 years agoAdd additional tests to ignored-tests
Brian Salomon [Wed, 13 Aug 2014 16:08:01 +0000 (12:08 -0400)]
Add additional tests to ignored-tests

BUG=skia:

Review URL: https://codereview.chromium.org/463993003

10 years agoFlate Test tests if compression works
halcanary [Wed, 13 Aug 2014 15:07:38 +0000 (08:07 -0700)]
Flate Test tests if compression works
-   Produce a compressable stream.
-   Assert compression ratio > 1
-   In verbose mode, print compression ratio.

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/464373002

10 years agoMark fallback fonts in new Android font config parser
tomhudson [Wed, 13 Aug 2014 14:53:48 +0000 (07:53 -0700)]
Mark fallback fonts in new Android font config parser

The new Android fonts.xml format doesn't explicitly tag fallback
fonts, or separate them from system fonts by putting them in a
separate file. We're assuming that any nameless font is a fallback
font.

Adds a unit test to track that we see as many fallback fonts as
expected when parsing a file.

BUG=chromium:400801
R=bungeman@google.com, djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/468893002

10 years agoUse combined color/coverage attribute when possible in aa rect renderer.
bsalomon [Wed, 13 Aug 2014 14:15:29 +0000 (07:15 -0700)]
Use combined color/coverage attribute when possible in aa rect renderer.

Also restore the is_irect test to detect AA rects that are integer aligned.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/466873002

10 years agoFix Flate Test, also cleanup
halcanary [Wed, 13 Aug 2014 14:14:36 +0000 (07:14 -0700)]
Fix Flate Test, also cleanup

-   Remove SkData double-unref to fix assert.
-   Re-enable the test with DEBUG (was disabled due to double-unref assert).
-   SkRandom instead of rand() for thread-safety.
-   General clean up of the test for readability.

Motivation: I am investigating turning on SkFlate::HaveFlate on Windows.

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/464333002

10 years agoAdd stephana@ to the list of Skia CQ commiters.
rmistry [Wed, 13 Aug 2014 13:11:09 +0000 (06:11 -0700)]
Add stephana@ to the list of Skia CQ commiters.

Note: This will take effect only after the Skia CQ is restarted

NOTRY=True
(SkipBuildbotRuns)

R=epoger@google.com

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/469753002

10 years agoWhitespace change to test the CQ commit message
rmistry [Wed, 13 Aug 2014 12:36:43 +0000 (05:36 -0700)]
Whitespace change to test the CQ commit message

(SkipBuildbotRuns)
TBR=
BUG=chromium:308792
NOTRY=true

Author: rmistry@google.com

Review URL: https://codereview.chromium.org/470603002

10 years agoAdd a parameter GR_ALWAYS_ALLOCATE_ON_HEAP to allow for only ever creating temporary...
george [Wed, 13 Aug 2014 01:00:47 +0000 (18:00 -0700)]
Add a parameter GR_ALWAYS_ALLOCATE_ON_HEAP to allow for only ever creating temporary buffers on the heap instead of allowing stack allocation

Unfortunately this can't be a GR_GL_* config like we'd discussed because there are SkAutoSMalloc buffers that are built outside of gl/

R=bsalomon@google.com, bsalomon
BUG=skia:

Author: george@mozilla.com

Review URL: https://codereview.chromium.org/459263003

10 years agoProposal for the mesh gradient interface. Implemented as a grid of
dandov [Wed, 13 Aug 2014 00:14:57 +0000 (17:14 -0700)]
Proposal for the mesh gradient interface. Implemented as a grid of
patches and uses 4 private arrays to store the values of the control points and
colors. When it needs a patch at a certain position of the grid it just
builds it using the corresponding values of the array and the
grid coordinates provided. Details on implementation are documented in the corresponding classes' comments.

Also added a gm for mesh gradients.

BUG=skia:
R=egdaniel@google.com, reed@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/451723003

10 years agowhitespace
borenet [Tue, 12 Aug 2014 20:02:26 +0000 (13:02 -0700)]
whitespace

BUG=skia:
TBR=bungeman

Author: borenet@google.com

Review URL: https://codereview.chromium.org/461123002

10 years agoTurn off pedantic blit rect
krajcevski [Tue, 12 Aug 2014 19:48:18 +0000 (12:48 -0700)]
Turn off pedantic blit rect

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/460253003

10 years agoAdd missing DRAW_PICTURE_MATRIX_PAINT paint offset.
fmalita [Tue, 12 Aug 2014 19:24:17 +0000 (12:24 -0700)]
Add missing DRAW_PICTURE_MATRIX_PAINT paint offset.

Also remove explicit gPaintOffsets sizing to make the existing compile
time size check effective.

R=reed@google.com, robertphillips@google.com

Author: fmalita@chromium.org

Review URL: https://codereview.chromium.org/467683003

10 years agoUpdate path to Android font config file
tomhudson [Tue, 12 Aug 2014 18:05:29 +0000 (11:05 -0700)]
Update path to Android font config file

In version LMP, Android is expected to change the path to their font
configuration file (and condense several files into one), as well as
changing the format (qv http://crrev.com/446473003/). This patch tries
the new path before falling back to the old path.

The new fonts are incompatible with assumptions made by the old
SkFontConfigInterfaceAndroid, so this patch MUST NOT land until
https://crrev.com/462073002/ or the equivalent has turned on the
new SkFontManager.

BUG=chromium:400801
R=djsollen@google.com, bungeman@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/458543002

10 years agoTurn on FontMgr for Android
tomhudson [Tue, 12 Aug 2014 17:55:09 +0000 (10:55 -0700)]
Turn on FontMgr for Android

Minimal change for activating the SkFontMgr on Android, broken out
of http://crrev.com/445143002/.

BUG=chromium:400801
R=bungeman@google.com, djsollen@google.com, tomhudson@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/462073002

10 years agoUpdate tools for use of picture stats in GPU optimization decision
robertphillips [Tue, 12 Aug 2014 17:12:40 +0000 (10:12 -0700)]
Update tools for use of picture stats in GPU optimization decision

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/466733004

10 years agoReplace LLU with ULL to make VS2012 work again.
halcanary [Tue, 12 Aug 2014 16:28:57 +0000 (09:28 -0700)]
Replace LLU with ULL to make VS2012 work again.

R=bungeman@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/458663004

10 years agoRevert of SkImage::NewFromGenerator(SkImageGenerator*), and a unit test. (https:...
halcanary [Tue, 12 Aug 2014 16:07:08 +0000 (09:07 -0700)]
Revert of SkImage::NewFromGenerator(SkImageGenerator*), and a unit test. (https://codereview.chromium.org/465823003/)

Reason for revert:
Mac bots are failing

Original issue's description:
> SkImage::NewFromGenerator(SkImageGenerator*), and a unit test.
>
> Committed: https://skia.googlesource.com/skia/+/186f7b04956a1742f185a4ca69b44b52bc50e7fc

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/453723003

10 years agoMigrate SkRTConfRegistry test to DEF_TEST().
tfarina [Tue, 12 Aug 2014 16:03:16 +0000 (09:03 -0700)]
Migrate SkRTConfRegistry test to DEF_TEST().

BUG=None
TEST=dm --tests=true --gms=false
R=mtklein@google.com, bsalomon@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/444303002

10 years agoSkCanvas::drawPatch param SkPoint[12]
dandov [Tue, 12 Aug 2014 15:34:29 +0000 (08:34 -0700)]
SkCanvas::drawPatch param SkPoint[12]

drawPatch now receives as parameter const SkPoint cubics[12]

Adjusted derived classes and serialization.

Ajusted GM's and benches that take into account combinations of optional
parameters, the scale of the patch and 4 different types of patches.

Planning on adding the extra functionality of SkPatch in another CL.

BUG=skia:
R=egdaniel@google.com, reed@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/463493002

10 years agorebaseline_server: periodically log tasks_queue size
epoger [Tue, 12 Aug 2014 15:30:09 +0000 (08:30 -0700)]
rebaseline_server: periodically log tasks_queue size

Without this, it's hard to tell whether the server is stuck (or why it's taking so long).

NOTRY=true
R=stephana@google.com, rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/454953002

10 years agochange setA/setB labels if viewing actuals vs expectations
epoger [Tue, 12 Aug 2014 15:29:05 +0000 (08:29 -0700)]
change setA/setB labels if viewing actuals vs expectations

NOTRY=true
R=rmistry@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/451053004

10 years agoMark degeneratesegments GM as flakly on nvpr/ubuntu/debug
Brian Salomon [Tue, 12 Aug 2014 15:19:54 +0000 (11:19 -0400)]
Mark degeneratesegments GM as flakly on nvpr/ubuntu/debug

BUG=skia:2826

Review URL: https://codereview.chromium.org/456653005

10 years agoRebaseline current failures and those ignored for GPU rect change.
Brian Salomon [Tue, 12 Aug 2014 15:10:35 +0000 (11:10 -0400)]
Rebaseline current failures and those ignored for GPU rect change.

BUG=skia:

Review URL: https://codereview.chromium.org/460343003

10 years agoSkImage::NewFromGenerator(SkImageGenerator*), and a unit test.
halcanary [Tue, 12 Aug 2014 15:04:58 +0000 (08:04 -0700)]
SkImage::NewFromGenerator(SkImageGenerator*), and a unit test.

R=reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/465823003

10 years agofix pathops skp-derived bugs; add more failing tests
caryclark [Tue, 12 Aug 2014 14:46:33 +0000 (07:46 -0700)]
fix pathops skp-derived bugs; add more failing tests

TBR=

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/463883002

10 years agoFix lower-casing error in font config parser
tomhudson [Tue, 12 Aug 2014 14:42:16 +0000 (07:42 -0700)]
Fix lower-casing error in font config parser

The Android font config parser was missing some SkAutoAsciiToLC
instantiations; this was discovered in https://crrev.com/458543002/
but should land independently.

BUG=chromium:400801
R=bungeman@google.com

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/465973002

10 years agoChange GR_COMPRESS_ALPHA_MASK from compile-time flag to run-time. We do this by intro...
krajcevski [Tue, 12 Aug 2014 14:26:25 +0000 (07:26 -0700)]
Change GR_COMPRESS_ALPHA_MASK from compile-time flag to run-time. We do this by introducing an Options struct to be passed to a GrContext on creation.

R=robertphillips@google.com, bsalomon@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/459033002

10 years agoSkTileGrid: store insertion order, return results sorted by that.
mtklein [Tue, 12 Aug 2014 14:01:25 +0000 (07:01 -0700)]
SkTileGrid: store insertion order, return results sorted by that.

This removes the need to assume the void* are SkPictureStateTree::Data*.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/466503002

10 years agoMake comment ASCII in GrDrawTarget.h
bsalomon [Tue, 12 Aug 2014 13:58:16 +0000 (06:58 -0700)]
Make comment ASCII in GrDrawTarget.h

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTRYS=true

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/458383004

10 years agoRevert of SkImage_Codec is Lazy (https://codereview.chromium.org/460823002/)
halcanary [Tue, 12 Aug 2014 13:53:28 +0000 (06:53 -0700)]
Revert of SkImage_Codec is Lazy (https://codereview.chromium.org/460823002/)

Reason for revert:
breaks chromium - no SkDecodingImageGenerator::Create

Original issue's description:
> SkImage_Codec is Lazy
>
> Committed: https://skia.googlesource.com/skia/+/e36f499110da8c2e2aa05227bee6deb967309ead

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/461043002

10 years agore-add samplerstress gm, but use blurmaskfilter instead (std filter)
reed [Tue, 12 Aug 2014 13:53:09 +0000 (06:53 -0700)]
re-add samplerstress gm, but use blurmaskfilter instead (std filter)

BUG=skia:
R=robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/468483002

10 years agoSkImage_Codec is Lazy
halcanary [Tue, 12 Aug 2014 13:37:21 +0000 (06:37 -0700)]
SkImage_Codec is Lazy

R=reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/460823002

10 years agoremove SkStippleMaskFilter - no external clients
reed [Tue, 12 Aug 2014 12:50:10 +0000 (05:50 -0700)]
remove SkStippleMaskFilter - no external clients

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/462013002

10 years agorelax quadratic binary search test
caryclark [Tue, 12 Aug 2014 12:49:37 +0000 (05:49 -0700)]
relax quadratic binary search test

Extreme implicit quartic equations solve to roots that are different
enough that they appear to have failed. In this case, fall back on
binary searching to find an intersection.

Relax the condition when this happens; don't give up just because the
computed implicit root points aren't remotely the same.

TBR=reed
BUG=skia:2808

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/456383003

10 years agoAdd layer counting to SkPictureRecord
robertphillips [Tue, 12 Aug 2014 12:35:58 +0000 (05:35 -0700)]
Add layer counting to SkPictureRecord

This will be used for a SkPicture::suitableForOptimization entry point.

Committed: https://skia.googlesource.com/skia/+/4a2b2e8ed2e35171bf98bad68a69daaced11ec7c

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/464433002

10 years agoLet skia build with clang's integrated assembler.
thakis [Mon, 11 Aug 2014 22:27:24 +0000 (15:27 -0700)]
Let skia build with clang's integrated assembler.

1. vuzpq is a gcc instruction. Replace it with the equivalent vuzp
   (see http://llvm.org/PR20423)

2. .func / .endfunc only have an effect with -gstabs, which we don't
   use. As it's unused and clang doesn't support it, remove
   .func / .endfunc (also see http://llvm.org/20424)

BUG=chromium:124610
R=mtklein@google.com

Author: thakis@chromium.org

Review URL: https://codereview.chromium.org/461693004

10 years agoRevert of Add layer counting to SkPictureRecord (https://codereview.chromium.org...
mtklein [Mon, 11 Aug 2014 22:20:23 +0000 (15:20 -0700)]
Revert of Add layer counting to SkPictureRecord (https://codereview.chromium.org/464433002/)

Reason for revert:
DM's all segfaulty

http://108.170.220.120:10117/builders/Test-Mac10.7-MacMini4.1-GeForce320M-x86_64-Debug/builds/3866/steps/RunDM/logs/stdio

Original issue's description:
> Add layer counting to SkPictureRecord
>
> This will be used for a SkPicture::suitableForOptimization entry point.
>
> Committed: https://skia.googlesource.com/skia/+/4a2b2e8ed2e35171bf98bad68a69daaced11ec7c

R=bsalomon@google.com, robertphillips@google.com
TBR=bsalomon@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/452673003

10 years agoAdd layer counting to SkPictureRecord
robertphillips [Mon, 11 Aug 2014 21:45:38 +0000 (14:45 -0700)]
Add layer counting to SkPictureRecord

This will be used for a SkPicture::suitableForOptimization entry point.

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/464433002

10 years agoConsider index8 a compressed config.
bsalomon [Mon, 11 Aug 2014 21:19:09 +0000 (14:19 -0700)]
Consider index8 a compressed config.

R=krajcevski@google.com, robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/457333004

10 years agoWrap NV_path_rendering API with GrGLPathRendering
cdalton [Mon, 11 Aug 2014 21:05:05 +0000 (14:05 -0700)]
Wrap NV_path_rendering API with GrGLPathRendering

Adds a GrGLPathRendering class that wraps the NV_path_rendering
extension and manages its various API versions. It also provides
backup implementations when certain NVpr methods from later API
versions are not present on the current system.

BUG=skia:
R=bungeman@google.com, bsalomon@google.com, kkinnunen@nvidia.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/444223002

10 years ago2D kernel initial wiring for Guassian
joshualitt [Mon, 11 Aug 2014 20:55:34 +0000 (13:55 -0700)]
2D kernel initial wiring for Guassian

BUG=skia:
R=senorblanco@chromium.org, bsalomon@chromium.org, bsalomon@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/418223009

10 years agoAdd BlitRect to SkTCompressedAlphaBlitter
krajcevski [Mon, 11 Aug 2014 20:34:22 +0000 (13:34 -0700)]
Add BlitRect to SkTCompressedAlphaBlitter

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/456873003

10 years agoclean up render_pdfs:
halcanary [Mon, 11 Aug 2014 20:08:27 +0000 (13:08 -0700)]
clean up render_pdfs:
     Remove unused headers
     replace dynamic memory wstream with null wstream.
     Use SkAutoTDelete when appropriate.
     Replace PdfRenderer class with short function: pdf_to_stream.
     Collapse render_pdf, process_input, tool_main_core functions
     Split out process_input_files function.
     Don't crash when no arguments given.
     print out max rss on each skp.
     prettier output

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/463603002

10 years agomark all SkImage methods const, so we can make it thread-safe
reed [Mon, 11 Aug 2014 20:03:55 +0000 (13:03 -0700)]
mark all SkImage methods const, so we can make it thread-safe

BUG=skia:
R=mtklein@google.com, halcanary@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/453613003

10 years agoFix crash in nvpr text after abandoning context
cdalton [Mon, 11 Aug 2014 19:43:28 +0000 (12:43 -0700)]
Fix crash in nvpr text after abandoning context

Don't implement GlyphPathRange::onAbandon/onRelease. Its path range is
also a GrGpuResource, registered with the gpu, and will automatically
handle abandoning and releasing the actual GL objects. Don't delete
the path range early, it is assumed to be a valid pointer throughout
the entire lifetime of GlyphPathRange.

BUG=skia:
R=bsalomon@google.com, kkinnunen@nvidia.com

Author: cdalton@nvidia.com

Review URL: https://codereview.chromium.org/452273003

10 years agoMark convex_poly_clip as flaky on msaa16/win8 bots. Add more tests to ignored_tests...
Brian Salomon [Mon, 11 Aug 2014 19:36:43 +0000 (15:36 -0400)]
Mark convex_poly_clip as flaky on msaa16/win8 bots. Add more tests to ignored_tests.txt after GPU rect change.

BUG=skia:

Review URL: https://codereview.chromium.org/460023002

10 years agoMore SkTileGrid refactoring.
mtklein [Mon, 11 Aug 2014 19:05:59 +0000 (12:05 -0700)]
More SkTileGrid refactoring.

I've rearranged the code a bit more and added more notes.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/463593003

10 years agoProcess Statistics header, add max RSS to render_pdfs
halcanary [Mon, 11 Aug 2014 18:33:51 +0000 (11:33 -0700)]
Process Statistics header, add max RSS to render_pdfs

Committed: https://skia.googlesource.com/skia/+/6274baae7fe82ce6481da367687aa6168356e1e1

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/448993003

10 years agoParses sample code provided by Android project. Attempts to keep FontFamily data...
tomhudson [Mon, 11 Aug 2014 18:28:00 +0000 (11:28 -0700)]
Parses sample code provided by Android project. Attempts to keep FontFamily data structures produced consistent with expectations of previous versions of Skia.

R=bungeman@google.com, djsollen@google.com, palmer@chromium.org, reed@google.com, hcm@google.com, tomhudson@google.com
BUG=400801

Committed: https://skia.googlesource.com/skia/+/07544757c9fcf0f359f1686a3779eb2e75dd5b36

Author: tomhudson@chromium.org

Review URL: https://codereview.chromium.org/446473003

10 years agoAlways use both a color and coverage attribute in GrAARectRenderer.
bsalomon [Mon, 11 Aug 2014 18:07:48 +0000 (11:07 -0700)]
Always use both a color and coverage attribute in GrAARectRenderer.

R=robertphillips@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/435743002

10 years agoActually use test configuration in SkFontMgr on Android.
bungeman [Mon, 11 Aug 2014 17:53:29 +0000 (10:53 -0700)]
Actually use test configuration in SkFontMgr on Android.

BUG=chromium:401954
R=tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/461673002

10 years agoDe-parameterize SkNextDatumFunction.
mtklein [Mon, 11 Aug 2014 17:09:34 +0000 (10:09 -0700)]
De-parameterize SkNextDatumFunction.

Just a simple refactor to make it clear we're only using this
one method and this one type.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/465523002

10 years agoReplace a pre-UAL instruction with its modern form.
thakis [Mon, 11 Aug 2014 16:52:32 +0000 (09:52 -0700)]
Replace a pre-UAL instruction with its modern form.

See the notes in the Chromium bug, and http://llvm.org/20427

BUG=chromium:124610,skia:900
R=djsollen@google.com, mtklein@google.com

Author: thakis@chromium.org

Review URL: https://codereview.chromium.org/455903002

10 years agoCleaning up SkPicture-related classes
robertphillips [Mon, 11 Aug 2014 16:50:11 +0000 (09:50 -0700)]
Cleaning up SkPicture-related classes

R=mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/459043002

10 years agoadd localMatrix to gradient Descriptor
reed [Mon, 11 Aug 2014 15:28:24 +0000 (08:28 -0700)]
add localMatrix to gradient Descriptor

this consolidation will also help transisition to new flattening pattern, where we want to
have a flatten/unflatten method on all of the common gradient params (i.e. Descriptor).

BUG=skia:
R=egdaniel@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/461643002

10 years agoRemove bleed test from ignored-tests.txt
Brian Salomon [Mon, 11 Aug 2014 15:21:25 +0000 (11:21 -0400)]
Remove bleed test from ignored-tests.txt

BUG=skia:

Review URL: https://codereview.chromium.org/463503004

10 years agoPlumbing for using a BBH in SkRecordDraw.
mtklein [Mon, 11 Aug 2014 15:08:43 +0000 (08:08 -0700)]
Plumbing for using a BBH in SkRecordDraw.

For now this only creates a degenerate bounding box hierarchy where all ops
just have maximal bounds.  I will flesh out FillBounds in future CL(s).

Not quite sure why QuadTree and TileGrid aren't drawing right---haven't even
looked at the diffs yet---so I've disabled those test modes for now.  RTree
seems fine, so that'll at least get us coverage for all this new plumbing.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/454123003

10 years agoRebase convex_poly_clip test on Win8 msaa16
Brian Salomon [Mon, 11 Aug 2014 14:22:10 +0000 (10:22 -0400)]
Rebase convex_poly_clip test on Win8 msaa16

BUG=skia:

Review URL: https://codereview.chromium.org/458243002

10 years agoFix string assert and dead code which caused it.
bungeman [Mon, 11 Aug 2014 14:19:56 +0000 (07:19 -0700)]
Fix string assert and dead code which caused it.

Running tools with a '--' parameter caused SkString to assert here
incorrectly. SkString::remove should allow the entire contents of a
string to be removed.

The code in the flags parser which caused this call is dead and should
be removed.

R=mtklein@google.com, reed@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/453333002

10 years agoRevert of Revert of remove (now unneeded) legacy onDrawPicture variant (https://coder...
reed [Mon, 11 Aug 2014 13:35:48 +0000 (06:35 -0700)]
Revert of Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/457253002/)

Reason for revert:
webkit has been updated, so re-landing

Original issue's description:
> Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/456203002/)
>
> Reason for revert:
> still need to update ProfilingCanvas in blink
>
> Original issue's description:
> > remove (now unneeded) legacy onDrawPicture variant
> >
> > TBR=fmalita@google.com
> >
> > Committed: https://skia.googlesource.com/skia/+/2e69d292e5a389db7d9264eb66172376692de8ca
>
> TBR=
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://skia.googlesource.com/skia/+/47f9bdcc3d741a63935c52bfe85db44ab13f66f2

R=reed@chromium.org
TBR=reed@chromium.org
NOTREECHECKS=true
NOTRY=true

Author: reed@google.com

Review URL: https://codereview.chromium.org/460693002

10 years agoRemove Matrix/Clip State collapse code
robertphillips [Mon, 11 Aug 2014 13:03:42 +0000 (06:03 -0700)]
Remove Matrix/Clip State collapse code

Given recent & upcoming changes (e.g., removal of save flags & SkRecord picture backend) this will have to be reimplemented.

R=fmalita@google.com, fmalita@chromium.org

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/453133003

10 years agoRevert of remove (now unneeded) legacy onDrawPicture variant (https://codereview...
reed [Mon, 11 Aug 2014 02:04:01 +0000 (19:04 -0700)]
Revert of remove (now unneeded) legacy onDrawPicture variant (https://codereview.chromium.org/456203002/)

Reason for revert:
still need to update ProfilingCanvas in blink

Original issue's description:
> remove (now unneeded) legacy onDrawPicture variant
>
> TBR=fmalita@google.com
>
> Committed: https://skia.googlesource.com/skia/+/2e69d292e5a389db7d9264eb66172376692de8ca

TBR=
NOTREECHECKS=true
NOTRY=true

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/457253002

10 years agoremove (now unneeded) legacy onDrawPicture variant
reed [Sun, 10 Aug 2014 18:28:46 +0000 (11:28 -0700)]
remove (now unneeded) legacy onDrawPicture variant

TBR=fmalita@google.com

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/456203002

10 years agoFix S32A_D565_Opaque for RGBA on arm64
kevin.petit [Sat, 9 Aug 2014 18:22:54 +0000 (11:22 -0700)]
Fix S32A_D565_Opaque for RGBA on arm64

Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
BUG=skia:2813
R=halcanary@google.com, djsollen@google.com, mtklein@google.com

Author: kevin.petit@arm.com

Review URL: https://codereview.chromium.org/458453002

10 years agoadd drawPicture variant that takes a matrix and paint
reed [Sat, 9 Aug 2014 18:08:05 +0000 (11:08 -0700)]
add drawPicture variant that takes a matrix and paint

will need some staging strategy, since chrome and blink have overrides of onDrawPicture

R=robertphillips@google.com, fmalita@google.com, bsalomon@google.com, mtklein@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/448793004

10 years agomanual bench rebase after 8d9153f, adjusted with e530eb370c084336b584a6dff5a9e6974d932dfa
bensong [Sat, 9 Aug 2014 17:19:22 +0000 (10:19 -0700)]
manual bench rebase after 8d9153f, adjusted with e530eb370c084336b584a6dff5a9e6974d932dfa

TBR=bungeman@google.com

Bypassing trybots:
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/451293002

10 years agomanual bench rebase after 8d9153f
bensong [Fri, 8 Aug 2014 22:59:30 +0000 (15:59 -0700)]
manual bench rebase after 8d9153f

R=bungeman@google.com
TBR=bungeman@google.com

Bypassing trybots:
NOTRY=true
BUG=skia:2819

Author: bensong@google.com

Review URL: https://codereview.chromium.org/454223002

10 years agoRestore bench_util.py
Mike Klein [Fri, 8 Aug 2014 21:28:53 +0000 (17:28 -0400)]
Restore bench_util.py

BUG=skia:2819

Review URL: https://codereview.chromium.org/450253003

10 years agoadd dummy onDrawPicture to allow migration for chrome overrides
reed [Fri, 8 Aug 2014 19:51:24 +0000 (12:51 -0700)]
add dummy onDrawPicture to allow migration for chrome overrides

after this lands in chrome, land these two CLs
https://codereview.chromium.org/454993002/
https://codereview.chromium.org/454143003

then land this skia CL
https://codereview.chromium.org/448793004/

then remove the onDrawPicture overrides from chrome

R=fmalita@google.com, robertphillips@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/457753002

10 years agoadd an animated test to verify that high-quality identity scaling doesn't change...
humper [Fri, 8 Aug 2014 19:11:33 +0000 (12:11 -0700)]
add an animated test to verify that high-quality identity scaling doesn't change the image

BUG=skia:
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/454913002

10 years agoBlink layout tests all assume it can provide custom font configuration files on every...
bungeman [Fri, 8 Aug 2014 19:06:51 +0000 (12:06 -0700)]
Blink layout tests all assume it can provide custom font configuration files on every platform. In moving Android to the font manager, we broke those.

They're ugly, but this patch reinstates them.

R=tomhudson@google.com, djsollen@google.com, reed@google.com
TBR=reed@google.com
BUG=chromium:401954

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/451093002

10 years agoshort circuit high quality scales that are actually the identity
humper [Fri, 8 Aug 2014 19:06:13 +0000 (12:06 -0700)]
short circuit high quality scales that are actually the identity
transform

BUG=skia:
R=reed@google.com

Author: humper@google.com

Review URL: https://codereview.chromium.org/456843002

10 years agoMake BBH::search() const.
mtklein [Fri, 8 Aug 2014 18:49:39 +0000 (11:49 -0700)]
Make BBH::search() const.

I'd like to have SkRecordDraw() work with a const SkBBoxHierarchy*, but
can't quite today.  The only interesting change here is no longer flushing
if needed in RTree; instead we assert we've been flushed already.

BUG=skia:
R=robertphillips@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/452233002