Ebrahim Byagowi [Tue, 23 Oct 2018 05:53:48 +0000 (09:23 +0330)]
[ci] Disable llvm-gcc
#define Null(Type) Null<typename hb_remove_const<typename hb_remove_reference<Type>::value>::value>()
raises:
hb-blob.cc: In function 'hb_blob_t* hb_blob_get_empty()':
hb-blob.cc:194: error: using 'typename' outside of template
hb-blob.cc:194: error: using 'typename' outside of template
Removing "typename"s fixes the issue but makes newer compiler fail apparently.
Probably downstream can patch that locally till we get a solution.
Behdad Esfahbod [Tue, 23 Oct 2018 04:49:42 +0000 (21:49 -0700)]
Unbreak builds
Behdad Esfahbod [Tue, 23 Oct 2018 04:33:18 +0000 (21:33 -0700)]
Add hb_array<>() specialization for UnsizedArrayOf
Related https://github.com/harfbuzz/harfbuzz/issues/1301
Behdad Esfahbod [Tue, 23 Oct 2018 04:27:45 +0000 (21:27 -0700)]
Add hb_array<>()
Simplifies transient object creation.
Fixes https://github.com/harfbuzz/harfbuzz/issues/1301
Behdad Esfahbod [Tue, 23 Oct 2018 04:22:25 +0000 (21:22 -0700)]
[color] Use Index for colorIdx
Doesn't matter, but matches the description.
Behdad Esfahbod [Tue, 23 Oct 2018 04:18:27 +0000 (21:18 -0700)]
Remove const and references when binding Null()
Fixes https://github.com/harfbuzz/harfbuzz/issues/1299
Removes anomaly I was seeing in cpal table trying to use implicit Null(NameID).
Behdad Esfahbod [Tue, 23 Oct 2018 01:20:57 +0000 (18:20 -0700)]
[color] Add HB_COLOR
Normally I would have added to_string / from_string like other types
have. But since we don't use hb_color_t much, I'm not going to do that.
Although, if we did, we could use it in hb-view to parse colors...
Behdad Esfahbod [Mon, 22 Oct 2018 23:55:12 +0000 (16:55 -0700)]
[color] Finish reviewing / revamping CPAL
Now to hb_color_t.
Behdad Esfahbod [Mon, 22 Oct 2018 23:35:03 +0000 (16:35 -0700)]
[color] Minor
Behdad Esfahbod [Mon, 22 Oct 2018 23:30:30 +0000 (16:30 -0700)]
[color] Rely on CPALV1Tail Null object
Behdad Esfahbod [Mon, 22 Oct 2018 23:18:34 +0000 (16:18 -0700)]
Remove const from hb_array_t details
Will come in through <T> if desired.
Behdad Esfahbod [Mon, 22 Oct 2018 23:16:21 +0000 (16:16 -0700)]
[color] Use hb_array_t in CPAL
Doesn't work though, ouch :(. Need to figure out if it's unreasonable
to expect Null(T) inside hb_array_t<T> to see the later specialization
of Null for NameID.
Behdad Esfahbod [Mon, 22 Oct 2018 21:54:55 +0000 (14:54 -0700)]
[color] Check for null CPAL arrays
We cannot use a nullable offset here though.
Behdad Esfahbod [Mon, 22 Oct 2018 21:51:40 +0000 (14:51 -0700)]
[color] More CPAL rename
Behdad Esfahbod [Mon, 22 Oct 2018 21:46:21 +0000 (14:46 -0700)]
[color] More CPAL rename
Behdad Esfahbod [Mon, 22 Oct 2018 21:43:12 +0000 (14:43 -0700)]
[color] Rename vars in CPAL
Ebrahim Byagowi [Mon, 22 Oct 2018 22:03:45 +0000 (01:33 +0330)]
Adopt dump-emoji with latest unreleased APIs changes (#1297)
Behdad Esfahbod [Mon, 22 Oct 2018 20:02:04 +0000 (13:02 -0700)]
[color] Revamp palette API
Behdad Esfahbod [Mon, 22 Oct 2018 19:40:38 +0000 (12:40 -0700)]
[color] Rewrite colr access
COLR table has one function: return layers for a glyph, and we expose exactly
that, so should just wire it through. Also use sub_array() for verifiable
safety.
Also, BaseGlyphRecord's null object is enough. We don't need to special-case
the not-found.
Behdad Esfahbod [Mon, 22 Oct 2018 17:29:01 +0000 (10:29 -0700)]
[colr] Add hb_ot_color_layer_t
We never return parallel arrays from functions. That's inconvenient
and hard to bind.
Behdad Esfahbod [Mon, 22 Oct 2018 02:23:11 +0000 (19:23 -0700)]
[color] Rename / reorder a bit
Implement has_data() for realz.
Behdad Esfahbod [Mon, 22 Oct 2018 02:08:25 +0000 (19:08 -0700)]
[cpal] Touch up palette flags
Behdad Esfahbod [Mon, 22 Oct 2018 02:02:47 +0000 (19:02 -0700)]
[color] Rename "gid" to "glyph"
We don't expose "gid" in API.
Behdad Esfahbod [Mon, 22 Oct 2018 00:43:29 +0000 (17:43 -0700)]
[colr] Move sanitize
Ebrahim Byagowi [Mon, 22 Oct 2018 18:37:59 +0000 (22:07 +0330)]
Add chromacheck Emoji test fonts and minor preparations (#1294)
Behdad Esfahbod [Mon, 22 Oct 2018 00:42:51 +0000 (17:42 -0700)]
[colr] Move compare function into a static
Not sure if MSVC would be unhappy about this.
Behdad Esfahbod [Mon, 22 Oct 2018 00:41:49 +0000 (17:41 -0700)]
[colr] Minor
Behdad Esfahbod [Mon, 22 Oct 2018 00:39:39 +0000 (17:39 -0700)]
[colr] Move sanitize() to right place
Sanitize always comes just before data member definitions, so
it's easy to cross-check.
Behdad Esfahbod [Mon, 22 Oct 2018 00:39:00 +0000 (17:39 -0700)]
[colr] Touch up a bit
When a struct is plain old data with no references, etc, it's okay
to mark its members public.
Khaled Hosny [Sun, 21 Oct 2018 11:29:40 +0000 (13:29 +0200)]
[color] Fix documentation a bit
Ebrahim Byagowi [Sun, 21 Oct 2018 08:16:51 +0000 (11:46 +0330)]
Minor
Ebrahim Byagowi [Sun, 21 Oct 2018 06:47:34 +0000 (10:17 +0330)]
Remove _palette_entry_count as can be done with _palette_colors
Ebrahim Byagowi [Sun, 21 Oct 2018 06:21:15 +0000 (09:51 +0330)]
[test] Test hb_ot_color_has_{colr,cpal}_data
Ebrahim Byagowi [Sun, 21 Oct 2018 06:14:16 +0000 (09:44 +0330)]
[CPAL] Add palette entry and enable palette flag API
Ebrahim Byagowi [Sun, 21 Oct 2018 05:18:07 +0000 (08:48 +0330)]
Add API test for hb_ot_color_get_color_layers
Ebrahim Byagowi [Sun, 21 Oct 2018 04:56:40 +0000 (08:26 +0330)]
Address COLR/CPAL reviews and revive cpal_v1 tests
Ebrahim Byagowi [Sat, 20 Oct 2018 14:20:39 +0000 (17:50 +0330)]
[color] Fix alpha channel value and adjust spaces
Ebrahim Byagowi [Fri, 19 Oct 2018 21:01:04 +0000 (00:31 +0330)]
[dump-emoji] Formatting
Ebrahim Byagowi [Fri, 19 Oct 2018 15:00:01 +0000 (18:30 +0330)]
[test] Use hb_test_open_font_file
Ebrahim Byagowi [Fri, 19 Oct 2018 14:53:42 +0000 (18:23 +0330)]
Add three macros for separating color channels
Ebrahim Byagowi [Fri, 19 Oct 2018 14:14:06 +0000 (17:44 +0330)]
Make ot-color tests pass
Khaled Hosny [Tue, 1 May 2018 15:16:46 +0000 (17:16 +0200)]
[color] Minimal API for COLR/CPAL
Ebrahim Byagowi [Mon, 22 Oct 2018 07:21:37 +0000 (10:51 +0330)]
[fuzz] Add a found hb-subset testcase
Ebrahim Byagowi [Sun, 21 Oct 2018 21:14:28 +0000 (00:44 +0330)]
[ci] Disable flaky -windows-x64 and add a comment for iOS
Ebrahim Byagowi [Sun, 21 Oct 2018 08:07:38 +0000 (11:37 +0330)]
[fuzz] Add more testcases
Fixed already but better to have anyway.
One didn't have minimized but it was only 164 B, so
Ebrahim Byagowi [Sun, 21 Oct 2018 08:06:41 +0000 (11:36 +0330)]
Merge pull request #1290 from ebraminio/testopenfont
[test] Unify font file opening across the tests
Ebrahim Byagowi [Sun, 21 Oct 2018 07:37:17 +0000 (11:07 +0330)]
[test] Unify font file opening across the tests
Behdad Esfahbod [Sun, 21 Oct 2018 03:39:56 +0000 (20:39 -0700)]
[fuzzing] Add more font
Behdad Esfahbod [Sat, 20 Oct 2018 23:56:06 +0000 (16:56 -0700)]
[docs] Minor
Behdad Esfahbod [Sat, 20 Oct 2018 23:52:55 +0000 (16:52 -0700)]
[docs] More fixes
Behdad Esfahbod [Sat, 20 Oct 2018 23:50:39 +0000 (16:50 -0700)]
[docs] Fix for hb-version.h being in src tree
Behdad Esfahbod [Sat, 20 Oct 2018 23:49:16 +0000 (16:49 -0700)]
[docs] Fix warning
Fixes https://github.com/harfbuzz/harfbuzz/issues/1260
Behdad Esfahbod [Sat, 20 Oct 2018 21:56:28 +0000 (14:56 -0700)]
[kerx] Implement tuple-kerning in Format0
Behdad Esfahbod [Sat, 20 Oct 2018 20:14:07 +0000 (13:14 -0700)]
2.0.2
Ebrahim Byagowi [Sat, 20 Oct 2018 19:53:32 +0000 (23:23 +0330)]
[test] Fix -Wunused-parameter on test-font.c
Behdad Esfahbod [Sat, 20 Oct 2018 19:09:41 +0000 (12:09 -0700)]
[kerx] Fix sanitize of KerxSubtableFormat2::array read
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11033
Behdad Esfahbod [Sat, 20 Oct 2018 19:04:51 +0000 (12:04 -0700)]
[aat] Fix LookupFormat10 sanitize
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11060
Behdad Esfahbod [Sat, 20 Oct 2018 18:56:30 +0000 (11:56 -0700)]
[test] Fix leak
Ebrahim Byagowi [Sat, 20 Oct 2018 17:43:25 +0000 (21:13 +0330)]
[TODO] Remove BCP 47 language handling item
Closes https://github.com/harfbuzz/harfbuzz/issues/1286
Ebrahim Byagowi [Sat, 20 Oct 2018 08:50:30 +0000 (12:20 +0330)]
[fuzzing] Add new testcases
Ebrahim Byagowi [Sat, 20 Oct 2018 04:15:46 +0000 (07:45 +0330)]
Merge pull request #1283 from khaledhosny/cygwin
Cygwin fixes and CI build
Ebrahim Byagowi [Sat, 20 Oct 2018 04:09:18 +0000 (07:39 +0330)]
Run valgrind on run-shape-fuzzer only when RUN_VALGRIND is set (#1285)
Behdad Esfahbod [Sat, 20 Oct 2018 03:00:36 +0000 (20:00 -0700)]
Minor
Behdad Esfahbod [Sat, 20 Oct 2018 02:59:41 +0000 (19:59 -0700)]
Oops. Fix build
Behdad Esfahbod [Sat, 20 Oct 2018 02:47:27 +0000 (19:47 -0700)]
[test-map] Cosmetic
Behdad Esfahbod [Sat, 20 Oct 2018 02:37:46 +0000 (19:37 -0700)]
2.0.1
Bruce Mitchener [Sat, 20 Oct 2018 01:09:52 +0000 (08:09 +0700)]
Make more 'coords' params const.
Behdad Esfahbod [Sat, 20 Oct 2018 02:12:33 +0000 (19:12 -0700)]
[font] Fix parallel funcs passing to eachover in infinite-loop
Fixes test just added.
Behdad Esfahbod [Sat, 20 Oct 2018 02:01:01 +0000 (19:01 -0700)]
[font] Add failing test amongst font-func parallels infinite-looping
Reported by Nona while updating Android to HarfBuzz 2.0.0.
Khaled Hosny [Fri, 19 Oct 2018 22:18:36 +0000 (00:18 +0200)]
Add Cygwin CI build
Fixes https://github.com/harfbuzz/harfbuzz/issues/1274
Behdad Esfahbod [Fri, 19 Oct 2018 23:06:54 +0000 (16:06 -0700)]
[kerx] Implement variation-kerning tables (without the variation part)
SFSNDisplay uses these. We just apply the default kern without
variations right now. But at least makes the default kern work.
Behdad Esfahbod [Fri, 19 Oct 2018 22:23:49 +0000 (15:23 -0700)]
[aat] Implement LookupFormat10
Khaled Hosny [Fri, 19 Oct 2018 20:21:39 +0000 (22:21 +0200)]
Use g_strdup instead of strdup
Cygwin does not seem to have strdup.
Khaled Hosny [Fri, 19 Oct 2018 20:04:56 +0000 (22:04 +0200)]
Use O_BINARY instead of _O_BINARY
Cygwin does not seem to have the later
Behdad Esfahbod [Fri, 19 Oct 2018 18:20:14 +0000 (11:20 -0700)]
[trak] Fix test for previous fix
Behdad Esfahbod [Fri, 19 Oct 2018 18:15:35 +0000 (11:15 -0700)]
[RELEASING] Post-mortem
Re https://github.com/harfbuzz/harfbuzz/issues/1271
Behdad Esfahbod [Fri, 19 Oct 2018 18:00:20 +0000 (11:00 -0700)]
[trak] Fix extrapolation at end side
Behdad Esfahbod [Fri, 19 Oct 2018 16:58:45 +0000 (09:58 -0700)]
[kerx] Whitespace
Ebrahim Byagowi [Fri, 19 Oct 2018 08:35:26 +0000 (12:05 +0330)]
Fix hb_map_is_empty logic
This needs reviewing
Ebrahim Byagowi [Fri, 19 Oct 2018 08:34:47 +0000 (12:04 +0330)]
Add API tests for hb_map_t
Ebrahim Byagowi [Fri, 19 Oct 2018 06:50:16 +0000 (10:20 +0330)]
[test] cosmetic, use g_assert_cmpint
Ebrahim Byagowi [Fri, 19 Oct 2018 06:44:25 +0000 (10:14 +0330)]
Don't report deprecated symbols as unused symbols
Ebrahim Byagowi [Fri, 19 Oct 2018 06:43:53 +0000 (10:13 +0330)]
Add test for hb_set_del
Bruce Mitchener [Fri, 19 Oct 2018 15:12:25 +0000 (22:12 +0700)]
Remove redundant return at end of void-returning function.
Ebrahim Byagowi [Fri, 19 Oct 2018 15:16:41 +0000 (18:46 +0330)]
[ci] Run valgrind on test/api
run-shape-fuzzer-tests.py automatically runs valgrind if see available
but test/api runs it by request, we probably should normalize the approaches
later
Bruce Mitchener [Thu, 18 Oct 2018 15:18:42 +0000 (22:18 +0700)]
Use bool literals instead of 0/1.
Bruce Mitchener [Fri, 19 Oct 2018 15:49:21 +0000 (22:49 +0700)]
Fix typos.
Ebrahim Byagowi [Fri, 19 Oct 2018 05:54:21 +0000 (09:24 +0330)]
Enable valgrind and dedicate a bot to it
Ebrahim Byagowi [Fri, 19 Oct 2018 05:36:42 +0000 (09:06 +0330)]
Minor, tweak spaces on hb-shape-fuzzer.cc
Ebrahim Byagowi [Fri, 19 Oct 2018 04:39:53 +0000 (08:09 +0330)]
[fuzz] Add more found cases (#1275)
Behdad Esfahbod [Thu, 18 Oct 2018 12:58:17 +0000 (05:58 -0700)]
2.0.0
Behdad Esfahbod [Thu, 18 Oct 2018 12:58:04 +0000 (05:58 -0700)]
[test] Don't use newer glib API
Ebrahim Byagowi [Thu, 18 Oct 2018 07:36:37 +0000 (11:06 +0330)]
[ubsan] Use unsigned int instead enum where needed (#1270)
Actually the check is right,
On -myanmar.hh, on that particular switch, OT_C is indic_category_t
but OT_D is myanmar_category_t so we are mixing the types in one variable.
And on -arabic.cc, step can goes one number higher than step_t enum in the
loop so we are actually using it as an unsinged int.
Behdad Esfahbod [Thu, 18 Oct 2018 07:35:01 +0000 (00:35 -0700)]
[AUTHORS] Add Ebrahim and Khaled
Behdad Esfahbod [Thu, 18 Oct 2018 06:06:53 +0000 (23:06 -0700)]
More warning fix
Okay, let's see if the gods are happy now...
Behdad Esfahbod [Thu, 18 Oct 2018 06:06:37 +0000 (23:06 -0700)]
Fix build
Behdad Esfahbod [Thu, 18 Oct 2018 05:58:43 +0000 (22:58 -0700)]
Fix warning
Behdad Esfahbod [Thu, 18 Oct 2018 05:42:47 +0000 (22:42 -0700)]
Kick bots
Behdad Esfahbod [Thu, 18 Oct 2018 05:37:34 +0000 (22:37 -0700)]
Fix some wierdness...
Behdad Esfahbod [Thu, 18 Oct 2018 05:34:16 +0000 (22:34 -0700)]
[aat] Fix sanitize slowdown
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11034