platform/framework/web/chromium-efl.git
5 years agoAllow building content shell when xwalk directory is absent
Arnaud Renevier [Thu, 12 Mar 2015 17:52:40 +0000 (10:52 -0700)]
Allow building content shell when xwalk directory is absent

Currently, it's not possible to build anything if xwalk directory is not
present. It would be great if we could, because xwalk is on a separate
repository, and might not always be available.

This patch sources gyp xwalk related files only if they are to be used.
Instead of passing xwalk.gyp path to gyp_chromiumefl, a flag --xwalk is
now passed. If and only if set, gyp_chromiumefl will source xwalk.gyp
and other xwalk related gyp files.

Change-Id: I872985cbe25a684cb8e325173e21a1a09cff313b
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years agoWrong values are shown in inputpicker
Dongjun Kim [Wed, 4 Mar 2015 17:24:39 +0000 (02:24 +0900)]
Wrong values are shown in inputpicker

It has some problem with conversion from string to double.
Even, some values are omitted while conversion.

We need to change for solving this problem.
1. Change mechanism of date conversion.
2. Change to "String" which type of date parameter from renderer.

Together with: If769a0500f0a58f6b4457bf4bc62c107ead4486f

BUG: http://168.219.209.56/jira/browse/TNEF-531
Reviewed by: Hyunhak Kim, Jaesik Chang, Piotr Grad

Change-Id: I12ea9fdee6dad8e505e6c4df852f5609f30e7659
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
5 years agoRestore run-layout-test script into working condition.
Piotr Tworek [Thu, 12 Mar 2015 14:56:14 +0000 (15:56 +0100)]
Restore run-layout-test script into working condition.

We shuld probably start caring about running layout tests. This commit
makes it possible to do it one again after the refactoring branch
changes. It also makes sure tools needed by layout tests are build
togeter with content_shell app.

Change-Id: Id5db5b72ece5e547684bf0e932349352a039355a
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoFix paths_efl.cc build warnings
Piotr Tworek [Thu, 12 Mar 2015 13:50:49 +0000 (14:50 +0100)]
Fix paths_efl.cc build warnings

The kDataPath, kExePath, kLocalePath vars are only used when OS_TIZEN is
defined so also keep their declarations in the same ifdef.

Change-Id: I5ce4e68d5f783eae2ffe5f1df96d732cdfce639d
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoFix favicon_commands.h clang build warnings.
Piotr Tworek [Thu, 12 Mar 2015 13:48:18 +0000 (14:48 +0100)]
Fix favicon_commands.h clang build warnings.

Chromium coding style requires overriding methods to be marked with
override keyword. Clang chromium-style also complains about. Let's add
it to make our lives easier.

Change-Id: I87ff1cc77742a7e8e20f10c6dbba792c3ee590f8
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoSwitch to TV 3.0 as the default target for build_tv.sh
Piotr Tworek [Thu, 12 Mar 2015 13:47:05 +0000 (14:47 +0100)]
Switch to TV 3.0 as the default target for build_tv.sh

Since this is the main target we care about lets use it by default. This
way we won't have to specify -P tztv_v3.0 flag when using the script.

Change-Id: I0be0eef27c79657ed517d4d5da6f7e6e335e4d44
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoEnable support for chromium extensions.
Piotr Tworek [Thu, 12 Mar 2015 13:44:45 +0000 (14:44 +0100)]
Enable support for chromium extensions.

This is required by crosswalk. Without the feature enabled the app fails
to compile.

Change-Id: I67d2c5aa206a66b7b654123fde28d493113bd338
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoMake EWK use WebContentsViewDelegate for SetPageTitle handling.
hh4813.kim [Thu, 12 Mar 2015 14:14:44 +0000 (23:14 +0900)]
Make EWK use WebContentsViewDelegate for SetPageTitle handling.

This patch makes EWK to set page title via WebContentsViewDelegate::SetPageTitle fucntion.

Change-Id: I88d4011bb946d78515ff0e4d67a27a9e42f44d25
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
5 years agoGet rid of old and dead event handling code.
Piotr Tworek [Wed, 11 Mar 2015 14:36:29 +0000 (15:36 +0100)]
Get rid of old and dead event handling code.

Majority of EWK even handling code has been reimplemented inside RWHV.
Right now EWebView should not even care about mouse/touch/keyboard/focus
events. Remove the old and unnecessary code.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12028
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=12031

Change-Id: I027fa0ef4675f1f2caa14d44bd80a2859d61cbd5
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoRemove tw_security_origin.h
Arnaud Renevier [Wed, 11 Mar 2015 22:25:09 +0000 (15:25 -0700)]
Remove tw_security_origin.h

Use _Ewk_Security_Origin struct directly instead of
tizen_webview::Security_Origin

Change-Id: I44c08d968288af28edd14e60834eb1236a024d8c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years agoUse WebcontentViewDelegate for show context menu
yh106.jung [Thu, 12 Mar 2015 13:29:03 +0000 (22:29 +0900)]
Use WebcontentViewDelegate for show context menu

Make EWK uses WebcontentViewDelegate for show context menuK

Change-Id: I06fdffcb019f648164187d970e06d27c110bba87
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
5 years agofixup! remove tw_wrt.h
yh106.jung [Thu, 12 Mar 2015 13:25:47 +0000 (22:25 +0900)]
fixup! remove tw_wrt.h

remove tw_wrt.h|cc from gypi file

Change-Id: Ife5dea2ae2600665619d913b3feaceabd90d3e4a
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
5 years agofixup! Merge efl-port POC code into tizen_src
Piotr Tworek [Wed, 11 Mar 2015 14:18:04 +0000 (15:18 +0100)]
fixup! Merge efl-port POC code into tizen_src

Wno-extern-c-compat flag is only used by clang, gcc does not care about
it and actually complains this flag does not exist.

Change-Id: Ib4d46a0f4a9a1e169d5503364e4999abc23cb194
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoUse 3.0 rpm feed from 27.02.2015 as all the newer ones are broken
Piotr Tworek [Wed, 11 Mar 2015 12:23:05 +0000 (13:23 +0100)]
Use 3.0 rpm feed from 27.02.2015 as all the newer ones are broken

It seems newer feeds provide EFL 1.13 which breaks both the refactoring
branch and beta/m40. Since fixing it is a separate task not really
related to refactoring let's use a known good snapshot for now.

Please keep in mind that we should also use odroid images matching the
package feed.

Change-Id: I05219e1536cb355a57abcfaac60962f826911167
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoMake EWK use WebContentsViewDelegate for popup menu handling.
Piotr Tworek [Wed, 11 Mar 2015 12:02:20 +0000 (13:02 +0100)]
Make EWK use WebContentsViewDelegate for popup menu handling.

Apps wishing to show custom popup menus should implement
WebContentsViewDelegate::ShowPopupMenu function. This patch does it for
EWK.

Change-Id: Id587ac954c3d016c5a0717eca365610aec1e2a82
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoUse WebContentsViewDelegate to delegate popup handling to the app
Piotr Tworek [Wed, 11 Mar 2015 11:59:34 +0000 (12:59 +0100)]
Use WebContentsViewDelegate to delegate popup handling to the app

We can't use the old code which expected it always got EFL version of
WebContentsDelegate class. We can however use WebContentsViewDelegate
which with an additional patch to src/ gains support for informing the
app about the need for a popup menu.

Change-Id: I7df5e53ebdc6db1be93388c3db8d82db5b3a9050
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Merge efl-port POC code into tizen_src
Piotr Tworek [Wed, 11 Mar 2015 09:35:10 +0000 (10:35 +0100)]
fixup! Merge efl-port POC code into tizen_src

Drop SHELL_USE_CUSTOM_JS_DIALOG_MANAGER define since it's no longer used
by the content_shell patch from chromium src. Right now default
content_shell JavaScriptDialogManager is always disabled when USE_EFL is
defined.

Change-Id: I96bb79e05ae46b4a2338ecabee06441751b70077
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoIntegrate crosswalk build with chromium-ewk build scripts
Piotr Tworek [Tue, 10 Mar 2015 15:27:52 +0000 (16:27 +0100)]
Integrate crosswalk build with chromium-ewk build scripts

The goal of the patch is simple, it should be possible to build
crosswalk for both desktop and tizen using the same scripts as we use
for chromium-ewk. The actual change is simple, but we have to take into
account the fact that we do configure chromium sligtly different than
crosswalk does. I does not seems to matter much for crosswalk, but it
means we'll have to test such setup at some point. Still this is the
only way to go if we intent to ship chromium code as a shared library
used by both xwalk binary and chromium-ewk lib at some point.

Change-Id: I212a38093b67ccb2f99b423177ad17599df3f7bf
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
5 years agoRemove tizen_webview/public/tw_url.h and tizen_webview/public/tw_misc.*
Arnaud Renevier [Wed, 11 Mar 2015 22:23:35 +0000 (15:23 -0700)]
Remove tizen_webview/public/tw_url.h and tizen_webview/public/tw_misc.*

With this patch, we don't use tw::URL but instead, we use directly GURL

Change-Id: Ic2ebb9f86c8e9479f787f4abc614bf15ba5aeb2e
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years agoRemove tw_notification.h
Arnaud Renevier [Wed, 11 Mar 2015 17:58:23 +0000 (10:58 -0700)]
Remove tw_notification.h

Use Ewk_Notification struct directly instead of tizen_webview::Notification

Change-Id: Ib0c2d43b839b58675f106f70ddbf0d6e93b08c83
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years agoRemove tw_wrt.h
Arnaud Renevier [Mon, 9 Mar 2015 23:47:19 +0000 (16:47 -0700)]
Remove tw_wrt.h

Use Ewk_Wrt_Message_Data struct directly instead of
tizen_webview::WrtIpcMessageData

Change-Id: I5070dd261e72ca1dccd947f4ba2606840598f035
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years agoMake EWK buildable again for Tizen Mobile (part II)
Antonio Gomes [Sun, 8 Mar 2015 12:58:43 +0000 (05:58 -0700)]
Make EWK buildable again for Tizen Mobile (part II)

Patch adds some missing dependencies so that Tizen
mobile builds succeed. Namely, the following dependencies
were missing:
- ui-gadget
- efl-assist
- capi-system-device
- capi-system-sensor
- capi-media-camera

Also some extra code is guarded under EWK_REFACTOR.

Change-Id: I8d406ed9e067241a3ce06582734befb1162dd3e4

5 years agoEnable SetTouchEventsEnabled, SetMouseEventsEnabled
yh106.jung [Tue, 10 Mar 2015 12:22:18 +0000 (21:22 +0900)]
Enable SetTouchEventsEnabled, SetMouseEventsEnabled

This commit enables SetTouchEventsEnabled, SetMouseEventsEnabled in EWebView

Change-Id: Ibc4ce41ec6588f2433d52bf6761aa89c467d5fa9
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
5 years agofixup! Make sure we compile chromium code with the same defines as chromium-efl
Piotr Tworek [Tue, 10 Mar 2015 07:53:29 +0000 (08:53 +0100)]
fixup! Make sure we compile chromium code with the same defines as chromium-efl

The USE_DL_PREFIX define is used only by dlmalloc shipped with
native_client code. Chromium does not support shipping nacl with
prefixed malloc so the define actually breaks NaCl support in crosswalk.
Get rid of the extra unnecessary define.

Change-Id: I875c2afc95c051cdfbb0985e43b457be74e93f82
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoMake EWK buildable again for Tizen Mobile
Antonio Gomes [Sun, 8 Mar 2015 12:45:24 +0000 (05:45 -0700)]
Make EWK buildable again for Tizen Mobile

Fix some code guarded by OS_TIZEN_MOBILE of
various small bugs: incomplete include patch,
extensions of EWK_REFACTOR, etc.

Change-Id: I90dbcda1404272b7208b833f83829892efe33ee7

5 years agofixup! Move EWK implementation code into ewk/ directory where it belongs.
Antonio Gomes [Sun, 8 Mar 2015 11:59:54 +0000 (04:59 -0700)]
fixup! Move EWK implementation code into ewk/ directory where it belongs.

Fix the gcc 4.6 check.

One step towards building Tizen 2.4 / mobile
on the refator branch.

Change-Id: I8a83e71582838d5db920abdb9307a2673869d1fb

5 years agoDeclare/define ewk_bringup in supplyment.gyp
Antonio Gomes [Sun, 8 Mar 2015 11:57:35 +0000 (04:57 -0700)]
Declare/define ewk_bringup in supplyment.gyp

That way, it is visible to all targets.

One step towards building Tizen 2.4 / mobile
on the refator branch.

Change-Id: Ib5f68f2969d49822857196b4bece8dd44e8f100d

5 years agoMake ubrowser script executable
yh106.jung [Mon, 9 Mar 2015 06:54:19 +0000 (15:54 +0900)]
Make ubrowser script executable

Change-Id: Idacc23b754f28808eb3bff75d5ef3be0957fc954
Signed-off-by: yh106.jung <yh106.jung@samsung.com>
5 years agofixup! Merge efl-port POC code into tizen_src
Piotr Tworek [Fri, 6 Mar 2015 11:34:18 +0000 (20:34 +0900)]
fixup! Merge efl-port POC code into tizen_src

It seems the previous patch for tizen stylesheet generation issue did
not really take care of the problem. The problem was still reproducible
on build server with 80 cores. The root cause seems to be in a fact that
in generic blink we do actually have 2 targets for the autogenerated
files. One generates it, while the other is supposed to build it. Lets
follow that approach.

Change-Id: I35b391ba2674829a4e36e46d6084ef6dc9fd6c5a
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Merge efl-port POC code into tizen_src
Piotr Tworek [Fri, 6 Mar 2015 09:15:57 +0000 (18:15 +0900)]
fixup! Merge efl-port POC code into tizen_src

Get rid of tabs.

Change-Id: Id30d833cf6e45db865322a5c6541a4b0992d42ee
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoMake EWK buildable again for TV 3.0
Piotr Tworek [Fri, 6 Mar 2015 06:24:04 +0000 (15:24 +0900)]
Make EWK buildable again for TV 3.0

With this patch and the previous one for our build scripts the
build_tv.sh -P tztv_v3.0 shoule once again produce working packages for
3.0 odroid target.

Change-Id: I750c2437f35b9417eb7fc036468052aa4d6d9a70
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Move EWK implementation code into ewk/ directory where it belongs.
Piotr Tworek [Fri, 6 Mar 2015 04:09:59 +0000 (13:09 +0900)]
fixup! Move EWK implementation code into ewk/ directory where it belongs.

Add EWK_BRINGUP guards around kForceAccelerated2dCanvas command line
switch. It seems this flag was added by one of the patches for src/.

Change-Id: Ic6caebaf290a529a0ebd89d626a2b053727e6603
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoMake build_tv.sh script usable again.
Piotr Tworek [Fri, 6 Mar 2015 04:07:20 +0000 (13:07 +0900)]
Make build_tv.sh script usable again.

Since chromium-efl sources are now storred in tizen_src subdirectory of
chromium the build script and spec file need to be adjusted.

Change-Id: I0dfa0af256447a496938b21b4569afa24aa09045
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Move EWK implementation code into ewk/ directory where it belongs.
Piotr Tworek [Fri, 6 Mar 2015 03:05:08 +0000 (12:05 +0900)]
fixup! Move EWK implementation code into ewk/ directory where it belongs.

Fix building EWK unit tests. Some trivial gyp changes make the code
buildable once again.

Change-Id: Id6077020d4c4ebb863087a7294284f06e42b15a0
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Merge efl-port POC code into tizen_src
Piotr Tworek [Fri, 6 Mar 2015 03:03:22 +0000 (12:03 +0900)]
fixup! Merge efl-port POC code into tizen_src

Make sure we don't need to specify building_for_tizen_mobile gyp flag.
The default value of 0 should be used when the user does not define the
flag.

Change-Id: I142514d399d8c5157012ab37095e7de6e33b2c19
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Move EWK implementation code into ewk/ directory where it belongs.
Piotr Tworek [Fri, 6 Mar 2015 03:02:26 +0000 (12:02 +0900)]
fixup! Move EWK implementation code into ewk/ directory where it belongs.

Adjust EWK code to new multimedia related code naming scheme.

Change-Id: If3e96b010ab4a954dd31d6e117b002c7840bd779
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Migrate multimedia support code to new chromium_impl structure.
Piotr Tworek [Fri, 6 Mar 2015 03:00:52 +0000 (12:00 +0900)]
fixup! Migrate multimedia support code to new chromium_impl structure.

Trivial mistake in header include guard.

Change-Id: I24b2c9330b46ba8c7045fbb057e12be9cc4a9c9b
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Merge efl-port POC code into tizen_src
Piotr Tworek [Fri, 6 Mar 2015 02:23:21 +0000 (11:23 +0900)]
fixup! Merge efl-port POC code into tizen_src

It seems actions defined by our webcore_generated injection target
sometimes did not get executed before ninja started building
webcore_rendering target. Not a nicest solution but adding explicit
dependency on webcore_generated to content_renderer makes sure the tizen
specific files are generated before we start compiling blink code.

Change-Id: I9f83b8e40f57b1554ea3b1eb6962898d4701cc52
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Move EWK implementation code into ewk/ directory where it belongs.
Piotr Tworek [Thu, 5 Mar 2015 11:41:00 +0000 (20:41 +0900)]
fixup! Move EWK implementation code into ewk/ directory where it belongs.

Make sure our message filters use EwkMsgStart ID instead of
ChromeMsgStart. This fixes problems with running RWK in multiprocess mode,
--single-process flag should no longer be required to run ubrowser or
efl_webview_app.

Change-Id: If6f839d757c218d83d71e51973e0b11f7ece6d5b
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoReuse efl initialization code from chromium_impl in ewk
Piotr Tworek [Thu, 5 Mar 2015 11:36:08 +0000 (20:36 +0900)]
Reuse efl initialization code from chromium_impl in ewk

AppendPortParams is supposed to contain the necesary minimum to
bootstrap working EFL version of chromium. CommandLineEfl should only
append extra flags which are supposed to activate additional, non
critical functionality. The idea is xwalk and EWK can configure chromium
differently, but they should share some base flags.

Change-Id: I2c1ea27c9054b228c078d0ddd6a708b1e3fdb3dc
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Merge efl-port POC code into tizen_src
Piotr Tworek [Thu, 5 Mar 2015 11:35:08 +0000 (20:35 +0900)]
fixup! Merge efl-port POC code into tizen_src

Andjust tizen_src code to fixup from:
http://165.213.202.130:8080/#/c/76146/

Change-Id: Ie2d9fcc32b7edaa3b926dce8c5f6fc2616a79420
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoFix EWK content rendering support.
Piotr Tworek [Thu, 5 Mar 2015 10:41:39 +0000 (19:41 +0900)]
Fix EWK content rendering support.

With this patch in place it's possible to get a working ubrowser build
that both renders the content, reacts to input and can handle a lot of
EWK API calls.

Note: For the app to work --single-process flag still needs to be
      specified. I'm still looking why it's needed.

Change-Id: I4a585ecd5a8b3a14260386d5c76b3082d6fc6608
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Move EWK implementation code into ewk/ directory where it belongs.
Piotr Tworek [Thu, 5 Mar 2015 09:44:28 +0000 (18:44 +0900)]
fixup! Move EWK implementation code into ewk/ directory where it belongs.

Re-enable building of various resources EWK needs from chrome.

Change-Id: I6c9ad25d92e82f502ff37ee74d8d1108174604e2
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoMake sure we compile chromium code with the same defines as chromium-efl
Piotr Tworek [Thu, 5 Mar 2015 09:39:02 +0000 (18:39 +0900)]
Make sure we compile chromium code with the same defines as chromium-efl

Apparently some of them are needed to ship chromium code in shared
library. Would be good to investigate them and explain what they
actually do.

Change-Id: I459ba1458fced5ddaaeb6a133f0d13f79149d252
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoMove EWK implementation code into ewk/ directory where it belongs.
Piotr Tworek [Wed, 4 Mar 2015 11:02:47 +0000 (20:02 +0900)]
Move EWK implementation code into ewk/ directory where it belongs.

Around 3/4 of the code from impl is responsible for implementing EWK API
specifics. This code belongs in ewk/ directory of tizen_src. This patch
performs the move and ajusts the build system and chromium_impl code to
make EWK buildable again. With this patch in place it's possible to
build crosswalk, content_shell and EWK apps once again on desktop. All
of the apps should run, but rendering is still broken in EWK. This will
be handlled in a separate commit.

Change-Id: I28bcbbd4c142c6db25e0efbbabfc69d79e2542ca
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoMigrate chromium-efl device_sensors provider into chromium_impl
Piotr Tworek [Tue, 3 Mar 2015 09:04:37 +0000 (18:04 +0900)]
Migrate chromium-efl device_sensors provider into chromium_impl

It implements generic chromium interface. The code should be reusable by
both EWK and content apps line xwalk or content_shell.

Change-Id: I952f6a5a284cf4c1a37c1d8bad28859a038e03de
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoMigrate chromium speech synthesizer code (TTS) to chormium_impl
Piotr Tworek [Tue, 3 Mar 2015 08:06:45 +0000 (17:06 +0900)]
Migrate chromium speech synthesizer code (TTS) to chormium_impl

Can't test it properly now as I don't have a tizen mobile device, but
the code belongs in chromium_impl, not ewk directory.

Change-Id: I85318e6a175ddfa23169cf938c9f540e2e7d8cbb
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoMigrate tizen battery API provider implementation to new dir structure
Piotr Tworek [Tue, 3 Mar 2015 08:48:40 +0000 (17:48 +0900)]
Migrate tizen battery API provider implementation to new dir structure

Generic code, should be usable for both xwalk and EWK, move to
chromium_impl.

Change-Id: Ie912672308462056653ee7b85324843bd940bf16
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoMigrate multimedia support code to new chromium_impl structure.
Piotr Tworek [Tue, 3 Mar 2015 06:19:04 +0000 (15:19 +0900)]
Migrate multimedia support code to new chromium_impl structure.

The code implements internal chromium interfaces so it belongs in
chromium part of new project structure. The expectation is it'll be
possible to use it from both xwalk/content_shell and EWK.

Due to the fact that xwalk gyp files
(xwalk/build/xwalk_filename_rules.gypi) exclude files with tizen in
their path from build if tizen gyp variable is set to 0 the code had to
be renamed. These files were renamed to have the "efl" suffix instead, given
that there were no Tizen specific (desktop build also builds them).
This way we still keep the ability to build and test the code on desktop.

Change-Id: Ic967fb97131152494520ac9232b986126918c969
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
Signed-off-by: Taeho Kim <th81.kim@samsung.com>
5 years agoMerge efl-port POC code into tizen_src
Piotr Tworek [Sat, 28 Feb 2015 03:30:44 +0000 (12:30 +0900)]
Merge efl-port POC code into tizen_src

This commit merges code from efl-port POC into tizen_src directory
structure. With this commit in place it's possible to build xwalk and
content_shell on top of cgromium using EFL toolkit. On desktop it should
be as simple as (from top level directory):

$ ./xwalk/gyp_xwalk -Duse_aura=0 -Duse_efl=1 -Dbuilding_for_tizen_mobile=0
$ ninja -C out/Debug content_shell xwalk

Running:
$ ./out/Debug/xwalk <some link>
or:
$ ./out/Debug/content_shell --no-sandbox <some link>

Building the code for Tizen 3.0 is handled by crosswalk-efl.spec file in
xwalk repo.

Building EWK code is currently not possible. EWK will be fixed by future
commits.

Change-Id: I53862b74202c36eb531204f155153b8a9b18deb0
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! [Crosswalk] Switch repositories to CT and bgerrit.
hh4813.kim [Wed, 4 Feb 2015 13:48:11 +0000 (22:48 +0900)]
fixup! [Crosswalk] Switch repositories to CT and bgerrit.

Change-Id: Ifa76de51a64e7b6c5ed7cc26943b04ca1a8d0041
Signed-off-by: hh4813.kim <hh4813.kim@samsung.com>
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years ago[Crosswalk] Switch repositories to CT and bgerrit.
Antonio Gomes [Fri, 23 Jan 2015 21:49:43 +0000 (13:49 -0800)]
[Crosswalk] Switch repositories to CT and bgerrit.

Change-Id: I4b40b5c9f902869ba848297a64bfab1ddd10e423
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agofixup! Implement Chromium Theme for Tizen.
Antonio Gomes [Thu, 22 Jan 2015 20:51:57 +0000 (12:51 -0800)]
fixup! Implement Chromium Theme for Tizen.

Change-Id: Iafb891a4aab335614f763e2ab850f71b984bbdde
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years ago[Crosswalk] Move away from custom_hooks needs in .gclient.
Antonio Gomes [Mon, 15 Dec 2014 21:14:22 +0000 (13:14 -0800)]
[Crosswalk] Move away from custom_hooks needs in .gclient.

Patch adds a DEPS file in tizen_src where 'xwalk' is specified
as a hard dependency. It allows us to greatly simplify
our suggested .gclient.

Our 'custom_hooks' also got to be declared as 'hooks' in DEPS.

Change-Id: I21d55ed5b7730bed1100abcd9efee2d272d9720c
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years ago[Crosswalk] Move away from sync_repos.sh.
Antonio Gomes [Mon, 15 Dec 2014 19:01:08 +0000 (11:01 -0800)]
[Crosswalk] Move away from sync_repos.sh.

Patch implements a fully gclient based featch solution,
moving away from sync_repos.sh completely.

The following actions are done (README.md updated):
- The custom_hook associated to sync_repos.sh in .gclient is removed
- Chromium and WebKit are pulled directly from EFL forks via .gclient-xwalk.
- Crosswalk is pulled as a separate "solition" in .gclient.
- The needed custom hooks are overriden.

Change-Id: Ifeb4060ea0152d8c373235003a4a5020b0b17fcc
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years ago[Crosswalk] Fetch from the proper crosswalk repository
Antonio Gomes [Fri, 5 Dec 2014 22:22:36 +0000 (14:22 -0800)]
[Crosswalk] Fetch from the proper crosswalk repository

Change-Id: I5ddf18c2fafa15a2501f9ec1f7a08fd28df726fa
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years ago[Crosswalk] Update README.md
Taeho Kim [Mon, 24 Nov 2014 14:38:37 +0000 (23:38 +0900)]
[Crosswalk] Update README.md

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8505

Change-Id: I75c911517b8b8531dba70b3ed283494246e5c8c8
Signed-off-by: Taeho Kim <th81.kim@samsung.com>
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years ago[Crosswalk] Suppress linker warnings as errors.
Abhijeet Gopalrao Kandalkar [Wed, 3 Dec 2014 14:54:54 +0000 (06:54 -0800)]
[Crosswalk] Suppress linker warnings as errors.

Change-Id: I8c54a3fccda76c5ae81dcab01111e33ef46b4b47
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years ago[Crosswalk] Define building_for_tizen_{mobile,tv} when building xwalk.
Antonio Gomes [Thu, 6 Nov 2014 17:46:56 +0000 (09:46 -0800)]
[Crosswalk] Define building_for_tizen_{mobile,tv} when building xwalk.

Change-Id: Id84b02cdd17bfdd66194453e8caf7a8d7e8efb2c
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years ago[Crosswalk] Add extra EWK_BRINGUP guards for unsupported calls.
Antonio Gomes [Mon, 10 Nov 2014 04:03:15 +0000 (20:03 -0800)]
[Crosswalk] Add extra EWK_BRINGUP guards for unsupported calls.

Change-Id: I1a9392cdeb447d5709ea6f67572878f098589721
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years ago[Crosswalk] Integrate with Crosswalk gclient machinary.
Antonio Gomes [Wed, 3 Dec 2014 14:07:33 +0000 (06:07 -0800)]
[Crosswalk] Integrate with Crosswalk gclient machinary.

Crosswalk first pulls itself (into src/xwalk) and then re-run
gclient in order to pull src and all its dependencies.

Patch makes it possible to pull in a custom src and blink code
by forking and adapting src/walk/DEPS.xwalk and src/xwalk/generate_gclient-xwalk.py.
(see script/xwalk). Patch also reintroduces sync_repos.sh, adapted
to crosswalk's integration needs.

Patch also adapts our build system to have .gclient as entry point.

Precedure:

$ create .gclient file (as below)
$ gclient sync

Details:

1) Gclient pulls chromium-efl into "src/tizen_src".
2) The it runs 3 custom hooks in order to get the rest of the source:
*) fetch-src-blink: src/tizen_src/sync_repos.sh is called and
   pulls in src and src/third_party/WebKit from a pre-defined locations.
*) generate-gclient-xwalk: .gclient-xwalk is created by running
   src/tizen_src/scripts/xwalkgenerate_gclient-xwalk.py (this is a fork
   of the same script in xwalk repository).
4) 'fetch-deps': actually fetches all depedencies in .gclient-xwalk.

.gclient content:

solutions = [
  { "name"        : "src/tizen_src",
    "url"         : "<chromium_efl_clone_url@branch>",
    "deps_file"   : "DEPS",
    "managed"     : True,
    "custom_hooks": [
      {
        # fetch custom src and blink repositories.
        "name": "fetch-src-blink",
        "pattern": ".",
        "action": ["src/tizen_src/sync_repos.sh"],
      },
      {
        # Generate .gclient-xwalk for Crosswalk's dependencies.
        "name": "generate-gclient-xwalk",
        "pattern": ".",
        "action": ["python", "src/tizen_src/scripts/xwalk/generate_gclient-xwalk.py"],
      },
      {
        # Fetch Crosswalk dependencies.
        "name": "fetch-deps",
        "pattern": ".",
        "action": ["python", "src/xwalk/tools/fetch_deps.py", "-v"],
      },
      {
        # At some point, we will integrate to gyp_xwalk. Not now...
        "name": "gyp-xwalk",
      }
    ],
    "safesync_url": "",
  },
]
cache_dir = None

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8505

Change-Id: I6d189daa1eae37a963422e0e0aa9102d871c667c
Signed-off-by: Piotr Tworek <p.tworek@samsung.com>
5 years agoDelete default context in ewk
Arnaud Renevier [Fri, 27 Feb 2015 23:02:36 +0000 (15:02 -0800)]
Delete default context in ewk

Default Web context is managed by ewk. So it makes more sense to delete
it in ewk layer than in efl.

This will allow us to get rid of WebContext::defaultContext in a
followup patch.
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: I6ada8f2e46d2cf19ccacf072d384fd11008c3433
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years agofixup! If click link, appear IME keyboad in moved page.
hyunjune.kim [Wed, 25 Feb 2015 05:33:52 +0000 (14:33 +0900)]
fixup! If click link, appear IME keyboad in moved page.

By mini_browser implementation, when click <a href ... target="_blank">
element a popup window appears to ask user whether to open a new window
or not. However, when this popup window is closed, the focus goes to url
bar, which in turn opens IME keyboard.

This patch fixes it by forcibly giving focus to webview inside two callbacks
(correspond to open/cancel button) that close the popup window.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11530
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: I74f2f15c1c4ab5620880a8d15fcad303e1d53515
Signed-off-by: hyunjune.kim <hyunjune.kim@samsung.com>
5 years agotizen_webview removal: remove tw_view_mode.h
Arnaud Renevier [Thu, 26 Feb 2015 19:41:15 +0000 (11:41 -0800)]
tizen_webview removal: remove tw_view_mode.h

This is a first step toward removal of tizen_webview layer.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11619
Reviewed by: Antonio Gomes, Balazs Kelemen

Change-Id: Ia0a52ea1f3577fdeed51cf0ae29f18d64abbf870
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years agoRemove tw_input_type.h
Arnaud Renevier [Sat, 28 Feb 2015 05:32:48 +0000 (21:32 -0800)]
Remove tw_input_type.h

This patch remove tw_input_type.h. We can easily use ui::TextInputType
instead.
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: I2072200f74cbada0618674f43da31445f1708d68
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years agoRemove redundant install -d "%{buildroot}"%{_bindir}
Arnaud Renevier [Wed, 25 Feb 2015 23:26:56 +0000 (15:26 -0800)]
Remove redundant install -d "%{buildroot}"%{_bindir}

The command 'install -d "%{buildroot}"%{_bindir}' is present twice in
packaging/chromium-efl.spec. This patch removes a superfluous line.
Reviewed by: Antonio Gomes, Piotr Tworek, SeungSeop Park

Change-Id: I558bf6ba7711b3c71c0d8bb2b7c65a677bcebd19
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years ago[MM]EME implementation using EncryptedMediaPlayerSupport.
sangdeug.kim [Wed, 21 Jan 2015 10:58:31 +0000 (19:58 +0900)]
[MM]EME implementation using EncryptedMediaPlayerSupport.

SHA:aaaae22e commit is included to fix crash issue.
(Refactor MediaSourceDelegate destruction.)
https://codereview.chromium.org/605013002

Together with: I0e3d41130d1b66e32e248a2ac6495c5d52cd9e8f

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=8682
Reviewed by: Min-Soo Koo, SeungSeop Park, Venugopal S M

Change-Id: I9c065ae4a9b442bf5141011e66aa7f4135cc8b65
Signed-off-by: sangdeug.kim <sangdeug.kim@samsung.com>
5 years agoEnable static asserts for enumerated values
Tomasz Czekala [Thu, 26 Feb 2015 09:36:08 +0000 (10:36 +0100)]
Enable static asserts for enumerated values

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=10791
Reviewed by: Laszlo Gombos, Piotr Grad, Piotr Tworek

Change-Id: Idb53a8ffb7ca8a3fcec30b2380a91cb3f9ef42a7
Signed-off-by: Tomasz Czekala <t.czekala@partner.samsung.com>
5 years agoReplace build/prebuild/ninja-linux64 by a statically linked equivalent.
Antonio Gomes [Fri, 27 Feb 2015 18:22:19 +0000 (10:22 -0800)]
Replace build/prebuild/ninja-linux64 by a statically linked equivalent.

That will allow ninja-linux64 to be used by both
x64-86 and ARM64 builds.
Otherwise, when using the currently dynamically linked
version in ARM64 builds, the follow error happens:

[XXs] + build/prebuild/ninja-linux64 -j16 -Cout.tv.i386/Release <target list>
[XXs] line 85: build/prebuild/ninja-linux64: No such file or directory

NOTE: Binary is the same available in dev/master branch made
by Piotr Tworek <p.tworek@samsung.com>. For more information,
check http://165.213.202.130:8080/#/c/73132/.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11564
Reviewed by: Balazs Kelemen, arno renevier

Change-Id: I0f9069c2d9b9f51c519f97ca782426b878255af1
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
5 years agoIME is not occured in prompt popup
Dongjun Kim [Fri, 27 Feb 2015 07:24:29 +0000 (16:24 +0900)]
IME is not occured in prompt popup

Regarding latest code, prompt popup was added by elm_popup_add().
In this case, IME is not shown with prompt popup.
Because of that IME only works on elm_conformant.

We need to adding elm_conformant_add() on top window.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11624
Reviewed by: Antonio Gomes, Hyunhak Kim, Piotr Tworek

Change-Id: Iffad198e60bcd79ee4862c0db4b03256b192f934
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
5 years agofixup! Hide Selection Handle when not in visible rect.
Antonio Gomes [Fri, 27 Feb 2015 06:16:27 +0000 (22:16 -0800)]
fixup! Hide Selection Handle when not in visible rect.

This method has no need to be target-only. By making it
ifdef-free, we make it possible to easier selection handles
shown on desktop builds similarly to target builds.

Reviewed by: Piotr Grad, SeungSeop Park
Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=10692
Change-Id: I9082c3561106513a5e8947e9abfc37b92901b158

5 years agoexport ewk_ipc_wrt_* API as C linkage
SeungSeop Park [Thu, 26 Feb 2015 14:12:23 +0000 (23:12 +0900)]
export ewk_ipc_wrt_* API as C linkage

This is necessary due to merged commit http://165.213.202.130:8080/#/c/75191/,
which is to minimize memory size by restricting symbol export as ewk prefixed
ones. Without this patch, wrt package build fails with undefined symbol error.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11607
Reviewed by: Antonio Gomes, Janusz Majnert, Min-Soo Koo, Piotr Tworek

Change-Id: I590eff2c4b529c3ec46cac427377c6828c52df7d
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
5 years agoubrowser: Add support for file URI scheme
Michał Pakuła vel Rutka [Thu, 26 Feb 2015 07:48:18 +0000 (08:48 +0100)]
ubrowser: Add support for file URI scheme

Currently ubrowser converts all URLs 'http://' with exception of ones
starting '/', 'http' and 'about'. This commit adds an exception for adresses
starting with 'file' or 'https' so they won't be converted to 'http://'
Reviewed by: Antonio Gomes, Piotr Grad, Piotr Tworek, Tomasz Weglarski

Change-Id: I537a21a882abca76bbc4e0ef7bc1c369bd9d7ec9
Signed-off-by: Michał Pakuła vel Rutka <m.pakula@samsung.com>
5 years agoAdd a aarch64-capable version of gold linker.
Antonio Gomes [Fri, 27 Feb 2015 06:36:45 +0000 (22:36 -0800)]
Add a aarch64-capable version of gold linker.

In order to support ARM64 builds we need a version of linker
gold that actually supports aarch64. According to [1],
such support is a very recent addition to gold itself, and no
releases have been made yet.

Patch updates our statically linked binary of gold binary
off of binutils trunk [2] (SHA 9ad55e9b) which issues problems
including:

[ XXs] [131/339] SOLINK(module) libffmpegsumo.so
[ XXs] (...)/prebuild/ld: fatal error: /usr/aarch64-tizen-linux/usr/lib/../lib64/crti.o:
unsupported ELF machine number 183

[1] https://sourceware.org/ml/binutils/2014-10/msg00192.html
[2] git://sourceware.org/git/binutils-gdb.git

Patch is a step forward to support arm64 builds.
Reviewed by: Piotr Tworek, SeungSeop Park

Change-Id: I19e339354040ef9996cefad71091d62ca2ec4bc7
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
5 years agoBuild custom allocator/tcmalloc respecting 'use_allocator' flag
Antonio Gomes [Thu, 26 Feb 2015 18:01:48 +0000 (10:01 -0800)]
Build custom allocator/tcmalloc respecting 'use_allocator' flag

Right now chromium-efl builds TCMalloc unconditonally for
all targets.
However, it is known that some targets, including ARM64,
are not yet supported by TCMalloc, and should be disabled.

Patch prepares the ground for this, only building allocator
the respecting 'use_allocator' GYP define. Now, it will
always build, but soon disabled for ARM64 builds.

Bug: web.sec.samsung.net/bugzilla/show_bug.cgi?id=11564
Reviewed by: Piotr Tworek, SeungSeop Park, arno renevier

Change-Id: I3c087d9782860c3645f4f7763b6e0ae2a4cec195
Signed-off-by: Antonio Gomes <a1.gomes@samsung.com>
5 years agoHide the context_menu, when the selected text is not displayed.
ByungJun Kim [Thu, 26 Feb 2015 10:43:43 +0000 (19:43 +0900)]
Hide the context_menu, when the selected text is not displayed.

If user scrolls a WebView and selected text gets offscreen,
context_menu doesn't disappear and sometimes overlaps with the URL bar.
Patch adds some logic to hide the context_menu when the selected text
is offscreen.
Reviewed by: Antonio Gomes, DONGJUN KiM, Jaesik Chang

Change-Id: I149be40b35897ff9962f79fe877c277cd3d0dca9
Signed-off-by: ByungJun Kim <bj1987.kim@samsung.com>
5 years agoAdd size optimization GCC options
SeungSeop Park [Sat, 7 Feb 2015 04:08:51 +0000 (13:08 +0900)]
Add size optimization GCC options

Code size optimization via GCC option.

M34 patches:
- http://165.213.202.130:8080/#/c/67343/
- http://165.213.202.130:8080/#/c/67639/
- http://165.213.202.130:8080/#/c/67564/

Test result of libchromium-ewk.so size in mobile:
- Base : 35M after strip (63M before strip)
- After: 25M after strip (54M before strip)

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11607
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: I639e8a929d2b99b71687d88c4a282541319e9e56
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
5 years agoOnly export necessary symbols (EWK + v8::*) in libchromium-ewk.so
SeungSeop Park [Mon, 9 Feb 2015 09:56:20 +0000 (18:56 +0900)]
Only export necessary symbols (EWK + v8::*) in libchromium-ewk.so

Currently we are providing two shared libraries - libchromium-ewk.so and
libchromium-efl.so, as the former is relying on the latter.
Tizen applications are supposed to use only EWK api, hence would only see
libchromium-ewk.so, which uses in turn libchromium-efl.so in implementing
EWK. However, libchromium-efl.so is over-exporting symbols unnecessary to
EWK apis, resulting in large ROM size and runtime memory.

This patch does three things to fix above mentioned issues.
1. Change libchromium-efl to static library
2. export symbols required for EWK app and WRT in libchromium-ewk.so
   - ewk_ prefixed API
   - v8::*
3. Refactored efl_webprocess executable to link with libchromium-ewk.so.

Test result of .so size in mobile:
- Before: 46M after strip (76M before strip)
- After : 35M after strip (63M before strip)

The test result for runtime memory also showed over 8M reduction
in PSS code section.

Note: This is a partial commit of http://165.213.202.130:8080/#/c/75146/
which contains our effort to reduce memory footprint.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11607
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: I527135ab844428d030477d194e5e5103c5533685
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
5 years agofixup! Factor out common bits of build_mobile and build_tv scripts
Youngsoo Choi [Thu, 26 Feb 2015 10:52:00 +0000 (19:52 +0900)]
fixup! Factor out common bits of build_mobile and build_tv scripts

When building chromium-efl with tizen v3.0 profile,
The variable 'PROFILE_NAME' has been used without being set.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11596
Reviewed by: Antonio Gomes, venu musham

Change-Id: I6974f6ad6fb036c3d31181078bc806eab25f699a
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
5 years agodo not call elm_progressbar_pulse with null argument
Arnaud Renevier [Tue, 24 Feb 2015 22:59:46 +0000 (14:59 -0800)]
do not call elm_progressbar_pulse with null argument

When running the desktop UI, loading_indicator is NULL. This patch
avoids calling elm_progressbar_pulse when this is the case. This
prevents the following error: "obj_id (nil) is not pointing to a valid
object. Maybe it has already been freed."
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: Ib89a80aea2cdf684ee72e79d2f106366050ff7d8
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years agoPage is auto zoomed on tapping URL bar.
Karol Furmaniak [Thu, 26 Feb 2015 14:11:46 +0000 (15:11 +0100)]
Page is auto zoomed on tapping URL bar.

[Problem]: When input field is focused and tap UTL bar
page is zoomed in.

[Solution]: Changed checking virtual keyboard state
from IsIMFVisible to IsShow which additionaly checked
if ime is in focused state,

Bug: http://168.219.209.56/jira/browse/TNEF-164
Reviewed by: Antonio Gomes, Marcin Kolibabka, Piotr Grad

Change-Id: I1bc8a3bd0e0fc32c8151c0536a18c6cdf118b20e
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
5 years agoFix showing context menu on elements with style "-webkit-user-select:none".
Bartlomiej Gajda [Tue, 24 Feb 2015 13:37:54 +0000 (14:37 +0100)]
Fix showing context menu on elements with style "-webkit-user-select:none".

[Issue] Elements which are not selectable, should also not show context menu
  on long press.
[Problem] Redundant showContextMenu() being called whenever LongPress ended.
[Solution] Trigger context menu only when neccessary.

[Requirment] WCS TC 49,50
[SPIN JIRA] TNEF-306
Reviewed by: Antonio Gomes, Jaesik Chang, Marcin Kolibabka, Piotr Grad

Change-Id: I841075559f2a82b94d5b4e3ecbcd485b5e119553
Signed-off-by: Bartlomiej Gajda <b.gajda@samsung.com>
5 years ago[M34 Merge] Fix for the 'Reload' button not displayed on page load finish
Lukasz Krok [Wed, 25 Feb 2015 16:24:50 +0000 (17:24 +0100)]
[M34 Merge] Fix for the 'Reload' button not displayed on page load finish

[Cause] "load,started" callback was triggered more than once,
e.g when an iframe present on the page was reloaded. In a browser,
it caused the status bar to be refreshed and reload button to
be changed into cancel button. Additionally, in such case, the "load,finished"
callback was not triggered and the cancel button never changed back into
reload.

[Solution] "load,started" and "load,finished" should be called
only once, when a page is loaded.

M34-merge: http://165.213.202.130:8080/#/c/69958/
Bug: http://168.219.209.56/jira/browse/TNEF-172
Reviewed by: Antonio Gomes, Piotr Grad, SeungSeop Park

Change-Id: I4b47a3833cbf487e2473c2fe70d2340111b5c807
Signed-off-by: Lukasz Krok <l.krok@samsung.com>
5 years agoDeprecate non-ewk api usages in app.c
SeungSeop Park [Thu, 26 Feb 2015 13:35:13 +0000 (22:35 +0900)]
Deprecate non-ewk api usages in app.c

In following commit, only ewk_ prefixed symbol will be exported.
To avoid build break, this patch comments out the code using
unexported symbols such as FOR_TESTING_ewk_hit_test_*.

TODO: replace this with proper solution.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11609
Reviewed by: Antonio Gomes, Janusz Majnert

Change-Id: I6f4c9afe5d9048c6658e18a7f2090990a9e87c3a
Signed-off-by: SeungSeop Park <sns.park@samsung.com>
5 years agoFix incorrect key code in JS key press event
Piotr Grad [Fri, 20 Feb 2015 08:47:57 +0000 (09:47 +0100)]
Fix incorrect key code in JS key press event

Platform was sending ascii code instead of utf8 code.
Used cached value for utf8 code passed by platform in
ime preedit and commit callbacks.

Bug: http://168.219.209.56/jira/browse/TNEF-235
Reviewed by: Jaesik Chang, Marcin Kolibabka, Marcin Krakowiak

Change-Id: I812c4fefefe7e45ab5b762940e751ee8eec5fbc7
Signed-off-by: Piotr Grad <p.grad@samsung.com>
Signed-off-by: Tomasz Weglarski <t.weglarski@samsung.com>
5 years agoOnly show selection handles when scrolling/flinging has stopped.
Antonio Gomes [Thu, 19 Feb 2015 16:58:11 +0000 (12:58 -0400)]
Only show selection handles when scrolling/flinging has stopped.

In text selection mode, handles and magnifier glance controls
are hidden while scrolling. That involves the two main scroll cases:

- user is flinging, i.e. kinetic scrolling;
- user is panning, i.e. dragging the page content around
  without lifting his finger off the screen.

In our current implementation, the following case is broken:
- load a scrollable page and enter text selection mode (by
long press, for example).
- start kinetic scroll the page

One will notice that when he lifts off his finger from the screen
text selection controls are prematurely shown while scrolling is
still active, and it becomes junky.

This happens because when user lifts off his finger a GESTURE_END type
of event is emitted and handled by RWHVEfl::HandleGestureEnd. There,
it is assumed to mean "scroll has stopped, and text selection controls
can be shown". Although it covers the panning case well, it fails for
the flinging case.

Patch fix this by moving the panning-stop code from ::HandleGestureEnd
to ::HandleGesture, when a 'ScrollEnd' type of event is emitted.
The kinetic scrolling case is then alread properly handled by the
RenderWidgetHostView hook named 'DidStopFling'.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=8773
Reviewed by: Piotr Grad, Piotr Tworek, arno renevier

Change-Id: I2ac1569ebf3a7812c5ae71b17aa11decbf5a5c9d

5 years agofixup! fixup! After changed edit type, IME state doesn't change.
Dongjun Kim [Thu, 26 Feb 2015 07:25:30 +0000 (16:25 +0900)]
fixup! fixup! After changed edit type, IME state doesn't change.

After this patch, IME was shown up with select picker in same time.
[Reproduce step]
1. open test file(select_picker_test.html)
2. choose edit field
3. choose select picker

We need to checking "TextInputType" before updating IME state.
Reviewed by: Antonio Gomes, Hyunhak Kim, Piotr Grad

Change-Id: I926c430270272e8be7e8cf14e8144ff5d9f85e72
Signed-off-by: Dongjun Kim <djmix.kim@samsung.com>
5 years agoScroll to focused editable node when ime change geometry.
Karol Furmaniak [Thu, 26 Feb 2015 11:25:33 +0000 (12:25 +0100)]
Scroll to focused editable node when ime change geometry.

[Problem]: Sometimes when changing orientation, page is not
scrolled to focused editable node.

[Solution]: Added scroll to focused editable node when
virtual keyboard change geometry to non zero size.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11586
Reviewed by: DONGJUN KiM, Piotr Grad

Change-Id: I34a98fcf20764a6e306f01dfa2aba5735788745f
Signed-off-by: Karol Furmaniak <k.furmaniak@samsung.com>
5 years agoRemove SendOrientationChangeEventIfNeeded
Arnaud Renevier [Tue, 24 Feb 2015 00:33:43 +0000 (16:33 -0800)]
Remove SendOrientationChangeEventIfNeeded

SendOrientationChangeEventIfNeeded method is not used anymore. It has
been replaced by SetOrientation. This patch removes the unneeded method.
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: I9604cc01dc0f61d3a2489b8339ce06722daf482c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years ago[MM] Buffered data indication is incorrect for Media Element.
Venugopal S M [Wed, 25 Feb 2015 18:54:57 +0000 (00:24 +0530)]
[MM] Buffered data indication is incorrect for Media Element.

Gstreamer 1.x gives buffered range in percentage in seven digits along
with precision. This large number caused overflow of progress bar.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11544
Reviewed by: SeungSeop Park, Sharath Kamath

Change-Id: I75111ee4dc4b426e8928332ee5837b33b87437cf
Signed-off-by: Venugopal S M <sm.venugopal@samsung.com>
5 years agoTemporary disable Drag&Drop
Daniel Waślicki [Thu, 26 Feb 2015 10:00:24 +0000 (11:00 +0100)]
Temporary disable Drag&Drop

As agress with Gyuyoung Kim, Drag&Drop currently is not officaly
supported with W3C standard. Although we want to have implementation
in engine to be able to simply turn it on when it will land in
official standard. For now we will turn it off to see how things
in W3C will go.

Change-Id: Iad55c48f7be1805596978a62565c6d85bf817796
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
5 years agoBring up drag option in context menu
Daniel Waślicki [Wed, 18 Feb 2015 09:25:08 +0000 (10:25 +0100)]
Bring up drag option in context menu

This reverts commit ddc255acd3b2955c28c29af67104881f1840b52d.

Implementation of Drag&Drop was splitted into two parts. First one
implemented EFL`s port for D&D with default behavior, which is
dragging on long press. Second part changed default behavior to
starting D&D after choosing proper option from context menu. After
merge of first patch issues was raised that one cannot open context
menu for URL links. Now both parts are merged so this issue does not
occur any more.

Together with: I1b3cc3280e119ea69fa3939b51315100f512e527
Together with: I5aeff041e53f659181b85c92e2e3674beb46f0be

Change-Id: I641c466f36791c73055dae9cd20b5f0738fcc666
Signed-off-by: Daniel Waślicki <d.waslicki@samsung.com>
5 years ago[Tizen][WebRTC] Appsink implementation with fimcconvert
sonal.g1@samsung.com [Wed, 25 Feb 2015 15:37:58 +0000 (21:07 +0530)]
[Tizen][WebRTC] Appsink implementation with fimcconvert

Appsink has been implemented using fimcconvert, it will be used if
pixmap(zero-copy) is not working. It works by registering a callback with
appsink. After receiving the buffer it will send buffer to renderer process
via shared memory.
Reviewed by: Min-Soo Koo, Sharath Kamath

Change-Id: I270ad24f5ebd6ccfd8d9609a6a3259db68b25a25
Signed-off-by: sonal.g1@samsung.com <sonal.g1@samsung.com>
5 years agofixup! Added implementation of Drag&Drop for EFL port
KangYong Park [Thu, 26 Feb 2015 01:56:32 +0000 (10:56 +0900)]
fixup! Added implementation of Drag&Drop for EFL port

This is add-hoc patch for running content_shell.
When running content_shell, ewk_view_ is not initialize.
Reviewed by: Antonio Gomes, Gyuyoung Kim, Piotr Tworek

Change-Id: I6fcf3b29dd44ace8499af1a2aea1369ff95c8daf
Signed-off-by: KangYong Park <kaka.park@samsung.com>
5 years agoUse asynchronous hit test in unittests
Arnaud Renevier [Tue, 24 Feb 2015 19:59:14 +0000 (11:59 -0800)]
Use asynchronous hit test in unittests

unit tests of Ewk_Hit_Test use synchronous hit test. This patch use the
new synchronous api.
Reviewed by: Antonio Gomes, Piotr Tworek

Change-Id: I89f09ff25d7bbfb09b9d47851700185f3bfbd031
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years agoAbility to run browsers trought gdb with -g option
Arnaud Renevier [Tue, 24 Feb 2015 23:16:33 +0000 (15:16 -0800)]
Ability to run browsers trought gdb with -g option

Right now, it is not easy to run ubrowser or efl_webview_app with gdb.
This patch adds a -g option to both wrappers scripts. If they are called
with that option, the applications are launched with gdb.
Reviewed by: Piotr Tworek, SeungSeop Park

Change-Id: Icb504e12b8c286f13164ecbe41915e2e261ff07d
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>
5 years ago[MM][Tizen 3.0] Fix video corruption when video resolution is changed.
Chandan Padhi [Wed, 25 Feb 2015 09:45:56 +0000 (15:15 +0530)]
[MM][Tizen 3.0] Fix video corruption when video resolution is changed.

When the resolution of video is changed from server, video was corrupted.
This patch makes MediaSourcePlayerGstreamer handle the video resolution changes.

Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=11432

Change-Id: I0185c67e3a25785fe4b6866e9c708881b41578d7
Signed-off-by: msu.koo <msu.koo@samsung.com>
5 years agofixup! fixup! fixup! Fix ewk_view_orientation_send API Reviewed by: Piotr Tworek...
Chandan Padhi [Wed, 25 Feb 2015 13:45:38 +0000 (19:15 +0530)]
fixup! fixup! fixup! Fix ewk_view_orientation_send API Reviewed by: Piotr Tworek, venu musham

Change-Id: I8e80329d12e5b6cae84b549c860b7a0ae8743a52
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
5 years agoFix for renderer crash during video playback
Chandan Padhi [Wed, 25 Feb 2015 09:45:56 +0000 (15:15 +0530)]
Fix for renderer crash during video playback

If we scroll/zoom the page during video playback, renderer
crash is observed. Currently, invalidation of video layer
happens on the main thread in WebMediaPlayerTizen. It should
happen on the compositor thread instead. This patch ensures
that and thus avoids the crash.

Bug: http://107.108.218.239/bugzilla/show_bug.cgi?id=11278
Reviewed by: SeungSeop Park, Venugopal S M

Change-Id: I40b7fa90c467e80af06f8ce39de4d3a763f1117e
Signed-off-by: Chandan Padhi <c.padhi@samsung.com>
5 years agoUse asynchronous hit test in efl_webview_app
Arnaud Renevier [Mon, 23 Feb 2015 20:06:34 +0000 (12:06 -0800)]
Use asynchronous hit test in efl_webview_app

efl_webview_app still uses deprecated (synchronous) hit test api. This
patch fixes it.
Reviewed by: Antonio Gomes, SeungSeop Park

Change-Id: Ibe774ad8a8c798cf7a9449744a54d04d7bf17a7c
Signed-off-by: Arnaud Renevier <a.renevier@samsung.com>