Suyeon Hwang [Thu, 15 Dec 2022 06:55:30 +0000 (15:55 +0900)]
Add parameter check code
- Issue:
Some APIs describe that the API can return invalid parameter error, but
these APIs did not return invalid parameter error.
- Solution:
This patch adds parameter check code. Through this patch, some APIs will
return invalid parameter error if the parameter is not valid.
Change-Id: I1b6e24c31fc0c2aeeeb0930597d4e1069e33677b
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 13 Dec 2022 02:15:16 +0000 (11:15 +0900)]
Fix description of voice control APIs
- Issue:
Some description for APIs does not explain exact behavior of each APIs.
- Solution:
This patch fixes the description of these APIs:
- vc_set_invocation_name()
- vc_set_server_dialog()
- vc_unset_server_dialog()
- vc_request_dialog()
- vc_get_result()
- vc_unset_result_cb()
- vc_tts_set_utterance_status_cb()
- vc_mgr_specific_engine_result_cb()
- vc_mgr_get_current_commands()
- vc_mgr_set_selected_results()
- vc_mgr_set_all_result_cb()
- vc_mgr_get_error_message()
The description of these APIs did not explain exact behavior of each
APIs.
And also, this patch fixes the order of retval to follow doxygen guide.
Change-Id: I4e1f0ab1db7cb4ecd7422315a7714f053aaf7d89
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 18 Nov 2022 08:42:56 +0000 (17:42 +0900)]
Fix API behavior to match the specification
- Issue:
Some APIs did not work as specified on API's documentation.
- Solution:
This patch adds logic for checking state and parameter and also fix some
function to work as specifedd on API's documentation. Through this
patch, the APIs will properly and expectedly work.
Change-Id: I8a4c0a36806ebfa562d18da13e3673bb776dd4da
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 22 Nov 2022 09:04:08 +0000 (18:04 +0900)]
Rearrange coverage excluding scope
- Contents:
This patch fixes the comment for excluding line coverage checker.
Through this code, the code which is not covered by unit test is
excluded from line coverage checking.
Change-Id: Ib7f5b4a683e3f5bd10752d1fd0982e6cd917ad17
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 18 Nov 2022 08:34:19 +0000 (17:34 +0900)]
Add unit test cases for enhancing line coverage
- Issue:
Line coverage of unit test is too low.
- Solution:
This patch adds new test cases to cover uncovered logics in voice
control client library. Through this patch, the line coverage of unit
test will be bigger.
Change-Id: Ida10976a7bd7bb06c6378d367dfec8df06ecf953
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 17 Nov 2022 06:21:36 +0000 (15:21 +0900)]
Simplify the setup and teardown logic of tests
- Requirements:
The setup and teardown method is too complicated to change.
- Contents:
This patch simplifies the setup and teardown method for future
refactoring and adding new TCs.
Change-Id: I706e7f0fcf5b50f86546ae0c63aa8e27ff491180
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 15 Nov 2022 12:11:57 +0000 (21:11 +0900)]
Connect synchronously when app uses setting API
- Issue:
The setting API did not connect to vc server.
- Solution:
When setting API is invoked, the setting library invokes request hello
function only once. However, the request hello function uses
asynchronous connect and setting library did not waiting it. Thus,
setting API always fails to connect to vc server.
This patch changes connection function to synchronous one. Through this
patch, setting API can connect vc server properly.
Change-Id: I961dd545d2e92f0a4d644742e8b747086bd00e75
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 14 Nov 2022 12:07:00 +0000 (21:07 +0900)]
Add test case for checking callback invocation
- Issue:
There is no test case for checking whether the callbacks which are set
by manager is invoked.
- Solution:
The voice control framework provides manager API for sending pcm data as
recording data. Using this APIs, we can simulate the situation that the
user says something. Thus, we can make new test case in this situation.
And also, using app manager framework, we can make situation that the
engine is suddenly terminate.
Using these simulation, this patch creates new test cases for checking
whether the callback is invoked. Through this patch, developer can check
some callbacks are properly invoked in proper situation.
Change-Id: I42d4167c1d6dc33b67858e309264a542032f5f3e
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Tue, 22 Nov 2022 11:43:00 +0000 (20:43 +0900)]
Revert vc_mgr_set_selected_result() execution condition
- Issue:
vc_mgr_set_selected_result() should be able to invoked if
vc_mgr_all_result_cb() returns false.
- Solution:
Previous commit changes the execution condition of
vc_mgr_set_selected_result() to be invoked only in
vc_mgr_all_result_cb(). However, according to the description of
vc_mgr_all_result_cb(), vc_mgr_set_selected_result() should be able to
be invoked if vc_mgr_all_result_cb() returns false. Thus, this patch
reverts the condition of vc_mgr_set_selected_result() and fixes the
description of vc_mgr_set_selected_result().
Change-Id: I330a150187698f8179a62956b32a8092986397b4
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 14 Nov 2022 02:57:54 +0000 (11:57 +0900)]
Fix errors which are created by solving merge conflict
- Issue:
Some changes from previous commits are disappeared.
- Solution:
This patch rollbacks the some codes that disappeares by solving merge
conflict. And also this patch fixes bug that are not return error.
Change-Id: I81968cfa7cedc84aeb6d28e0f041cfe45d7190d1
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
ulgal-park [Fri, 4 Nov 2022 06:15:31 +0000 (15:15 +0900)]
Add core layer to remove extern dependency at vc_mgr_tidl
Change-Id: Iba2ad7072b8f3f79080c6e979b60e0c39d2dc060
Suyeon Hwang [Thu, 10 Nov 2022 09:40:31 +0000 (18:40 +0900)]
Add state and parameter check logic
- Issue:
Some APIs are not follow its documentation.
- Solution:
This patch adds state and parameter check logic to make each APIs
follows its documentation. Some APIs did not make error even if the API
is invoked in error situation. Through this patch, each APIs will make
error in some condition specified by documentation.
Change-Id: Ie9c92d012e8891a168a990d5e47559add0d03e49
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 10 Nov 2022 09:00:21 +0000 (18:00 +0900)]
Add cancel callback feedback thread
- Issue:
Sometimes, ecore_thread_cancel() is blocked in vc_mgr_stop_feedback().
- Solution:
In vc_mgr_stop_feedback(), ecore_thread_cancel() is used, but the cancel
callback is not set. Thus, this patch adds cancel callback and makes the
callback reset the thread variable. Through this patch, the thread
variable will be safely reset.
Change-Id: I926c52aec385b07da65dbf1f6b363eeec328acdd
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 10 Nov 2022 08:45:23 +0000 (17:45 +0900)]
Add unit test cases for internal APIs and missed APIs
- Issue:
There are some APIs those have no related TCs.
- Solution:
This patch adds new TCs for APIs those have no related TCs. Through this
patch, developer can validate all voice control manager APIs.
And also, this patch unifies the indetation to use tab.
Change-Id: I73fe6bdb0ddbf3e406b3ead170b9e770ce4670a8
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Wed, 9 Nov 2022 04:34:51 +0000 (13:34 +0900)]
Reset g_mgr_client when client is destroyed
- Issue:
App can access g_mgr_client even if vc mgr was deinitialized.
- Solution:
VC mgr client module did not assign null in g_mgr_client when
vc_mgr_client_destroy() is invoked. Thus, app still can access the
dereferenced pointer in g_mgr_client after calling
vc_mgr_deinitialized(). This patch sets null in g_mgr_client when app
invokes the vc_mgr_deinitialize(). Through this patch, the client
structure of vc mgr is properly reset.
Change-Id: I8c20e70960607257fa5e80b961c610b5aaf51f9a
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 7 Nov 2022 10:42:05 +0000 (19:42 +0900)]
Add unit tests for VC manager APIs
- Requirements:
VC manager APIs need to get test case for validation when it has to be
changed.
- Contents:
This patch adds new unit test cases for VC manager APIs. VC manager
provides only for platform certificated APIs, so it does not need to UTC
or ITC for release process. Thus, those APIs are not validated by any
test now. Through this patch, developers can validate the APIs if they
want it.
Change-Id: Iaffd992010954e330f6a0312e553e9ad04543108
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 7 Nov 2022 10:55:23 +0000 (19:55 +0900)]
Stop feedback thread only when stop is requested
- Issue:
Sometimes, the feedback thread plays the TTS feedback data for previous
request.
- Solution:
The issue is because feedback thread is exited before the engine
finishing to send TTS feedback data. Thus, some data can be remained in
feedback data queue even if thread is terminated.
This patch fixes termination logic for TTS feedback thread. Through this
patch, TTS feedback thread is terminated only when stop is requested,
and TTS feedback thread tries to consume all feedback data.
Change-Id: I8deaaab5f6b3e44e86b62d1ec3d8735e30a54780
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
ulgal-park [Fri, 4 Nov 2022 03:51:47 +0000 (12:51 +0900)]
Remove vc manager handle in vc_mgr and vc_mgr_client
Change-Id: Ie30d4b328f0e22f57d59c9c8dfdbe601fbbe34a2
wn.jang [Fri, 4 Nov 2022 04:01:17 +0000 (13:01 +0900)]
Update version to 1.70.8
Change-Id: I2bc49f92717d5515ab7d776115525a41d9b8f9ed
Suyeon Hwang [Thu, 3 Nov 2022 05:42:45 +0000 (05:42 +0000)]
Merge changes I2d2676d0,Iffc7acb7,Ibe373fd5 into tizen
* changes:
Deallocate memory before setting new value
Deallocate the list memory after using it
Use setter to set invocation name safely
Suyeon Hwang [Mon, 31 Oct 2022 06:46:54 +0000 (15:46 +0900)]
Deallocate memory before setting new value
- Issue:
Memory leak can be possible if vc_cmd_db module sets the new value in
vc_cmd_s structure.
- Solution:
The possibility of the issue is because the module did not check the
preivous value of the member. Thus, this patch adds code for checking
the member of the structure. If there is already value set, the module
will release the old value and then set new value.
Change-Id: I2d2676d08a4cacb75c32983c1a49eced28371b65
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Mon, 31 Oct 2022 06:12:28 +0000 (15:12 +0900)]
Deallocate the list memory after using it
- Issue:
Command list was note deallocated after using it.
- Solution:
vc_cmd_db module creates the command list for update commands DB, but
after using it, the module did not deallocate the list. It can occur
memory leak. Thus, this patch adds code for deallocating the list.
Change-Id: Iffc7acb78aa577fdd56a27efd1abdc2a802d05eb
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 28 Oct 2022 06:24:43 +0000 (15:24 +0900)]
Use setter to set invocation name safely
- Issue:
The invocation name previously set can be leaked.
- Solution:
The invocation name parameter is set by __vc_db_insert_commands_list()
without checking invocation itself. In most cases, invocation name is
not set by this function, but in special cases, memory leak can
occurred if use repeatedely set command list.
Thus, this patch prevents leak using setter function. The setter
function checks the invocation name paraemeter and safely changes it.
Change-Id: Ibe373fd51d5c2880ccea1d2b6699cd5614ffe49c
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
wn.jang [Thu, 13 Oct 2022 02:16:23 +0000 (11:16 +0900)]
Fix stack-buffer-overflow issue which is detected by ASAN
Cause: A buffer overflow occurs because 4 bytes access occurs
when the value is changeed as it is converted to (int*)
even though it is set as 1 byte pool variable.
Soluetion: Use bool* instead of int* is_system_cmd_valid.
This issue is described on code.sec.samsung.net/jira/browse/TSEVEN-2604
Change-Id: I4d8dae44234d4879b99c75296244018b45e85e69
wn.jang [Wed, 5 Oct 2022 00:46:53 +0000 (09:46 +0900)]
Update version to 1.70.7
Change-Id: I1f90e77141b0d188275521e2f66c466bfbd78a66
wn.jang [Tue, 4 Oct 2022 12:00:37 +0000 (21:00 +0900)]
Check if tidl_info is NULL before use when vc mgr app is terminated
Change-Id: I43a3c753eabb0ccb308545c47fbe3beaf0fc8114
sooyeon [Fri, 30 Sep 2022 02:02:36 +0000 (11:02 +0900)]
Fix coverity issues
Change-Id: Ica79c8c2c2804e9f11e45480914726085637eff7
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Thu, 22 Sep 2022 07:38:35 +0000 (16:38 +0900)]
Add NOT_SUPPORTED error description in the header
Change-Id: I5f43440efbcf00e7ec6503a345b0a5a86b36f2c0
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Thu, 22 Sep 2022 04:46:47 +0000 (13:46 +0900)]
Add permission denied error and descriptions
Change-Id: Iaf1b54300feb01f789cac0af799982a3d6492a3b
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Thu, 22 Sep 2022 01:29:22 +0000 (10:29 +0900)]
Add remarks for additional privileges
Change-Id: I3ce6765012901624f928e0c86c80a0248d0e6dea
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Mon, 8 Aug 2022 05:03:41 +0000 (14:03 +0900)]
Add and Rearrange descriptions
Change-Id: I78f52786dbcb48d34b56ffd41ba47c41a7a6316c
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Mon, 8 Aug 2022 02:44:01 +0000 (11:44 +0900)]
Add TIDL privileges in vce header description
Change-Id: Ic689323869a141bcc21d51fa695cae1e0b63574d
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
wn.jang [Wed, 28 Sep 2022 04:14:37 +0000 (13:14 +0900)]
Update version to 1.70.6
Change-Id: I10ed1ade43238e73c857acf21251d238f1412557
wn.jang [Wed, 28 Sep 2022 04:13:31 +0000 (13:13 +0900)]
Add usleep while waiting for releasing callback function
Change-Id: I3516ec0834dda1eb4d9d8af2e993671e9a89dda8
wn.jang [Wed, 28 Sep 2022 00:55:08 +0000 (09:55 +0900)]
Retry when prepare_sync is failed
Change-Id: I9a96cd1254fefd746a76e6f8bb1fe2bba255293e
wn.jang [Fri, 23 Sep 2022 07:50:49 +0000 (16:50 +0900)]
Add logic to avoid reconnetion when finalize
Cause: The on_disconnect() cb is called, even a client requtests to disconnect.
Change-Id: I463ad1321968cc86b775125b220dfc8f1ce8b9b3
Solution: Check whether ipc listening state or not when tries to reconnect.
wn.jang [Tue, 20 Sep 2022 23:46:22 +0000 (08:46 +0900)]
Add prepare_sync function to connect directly
Cause: The Web TCs were blocked and failed.
Change-Id: I5b64a3f281b59191d8c41fc60a44eacdcdd5edb3
Solution: Connect directly when web api request to prepare
wn.jang [Tue, 20 Sep 2022 11:46:23 +0000 (20:46 +0900)]
Add to disconnect rpc socket when client is finalized
Cause: __on_disconnection is called when engine is terminated due to no more clients.
Change-Id: If3cfaa9c35ce8477e3c08e7d12c211d49e622c42
Solution: To avoid reconnect by service reset, disconnect rpc socket when client is finalized.
sooyeon [Tue, 6 Sep 2022 01:52:24 +0000 (10:52 +0900)]
Fix coverity issues
Change-Id: I3db738f369e0a7a36f09e73ca1f9740a79f1b8ef
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
Seongmin Park [Fri, 26 Aug 2022 04:23:46 +0000 (04:23 +0000)]
Merge "fix issue that voice control client can not get service state update" into tizen
Seongmin Park [Fri, 26 Aug 2022 04:23:38 +0000 (04:23 +0000)]
Merge "send error to client when server disconnected" into tizen
ulgal-park [Thu, 11 Aug 2022 11:58:02 +0000 (20:58 +0900)]
Change interval and order when client connect to daemon
Change-Id: Ie6dc0b87e757171b372918d85d99637bd921f0f5
ulgal-park [Thu, 25 Aug 2022 09:50:02 +0000 (18:50 +0900)]
fix issue that voice control client can not get service state update
Change-Id: Ic2004192c199f807582b2d1a9512b396f61a0bce
ulgal-park [Thu, 25 Aug 2022 07:35:35 +0000 (16:35 +0900)]
send error to client when server disconnected
Change-Id: I8318e562a6c16c3cb8b3375de079883fcddcbb00
Seongmin Park [Mon, 8 Aug 2022 05:40:47 +0000 (05:40 +0000)]
Merge "fix vc_mgr_tidl header guards typo" into tizen
Suyeon Hwang [Fri, 5 Aug 2022 06:07:23 +0000 (15:07 +0900)]
Refactor vc_mgr_ducking module implementation
This patch includes these features:
- Use predefined macro instead of magic number
- Use error enum value instead of magic number
- Enhance log content for debugging and changed function name.
- Use cpp for implementing vc_mgr_ducking module for future
enahancement.
- Create unit functions in vc_mgr_ducking module for higher
maintainability.
- Add sound stream type for ducking TTS sound volume.
Change-Id: I0d7d7d4bbe7d8aaa89546f127eba8a853b9e45d2
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
황수연/Tizen Platform Lab(SR)/삼성전자 [Fri, 5 Aug 2022 04:38:15 +0000 (13:38 +0900)]
Fix typo
Change-Id: Ic5d0574c1ce90984bb36b1abe686b51f0e9566db
Co-authored-by: 코드리뷰봇/Quality Tool Lab(SR)/삼성전자 <reviewbot@samsung.com>
Suyeon Hwang [Fri, 5 Aug 2022 03:45:42 +0000 (12:45 +0900)]
Add vc_mgr_ducking files
This patch is cherry-picked from next commit:
https://review.tizen.org/gerrit/c/platform/core/uifw/voice-control/+/230142
Change-Id: I13d3c62eb06bdc0368b6c0b1bb3a6627dd4c70ef
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
ulgal-park [Fri, 5 Aug 2022 06:08:52 +0000 (15:08 +0900)]
fix vc_mgr_tidl header guards typo
Change-Id: I983f7144dff58f2d62a78a578c2db0204c5c8d17
sooyeon [Thu, 4 Aug 2022 07:28:51 +0000 (16:28 +0900)]
Replace the name METHOD_ERROR_TO_APP with METHOD_ERROR
Change-Id: I6ca381930becc1a6a01be55aa45b0dcac173637d
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Thu, 4 Aug 2022 04:42:54 +0000 (13:42 +0900)]
Change variable names and function names
Change-Id: I3eea6c8094a1752911243ce8e9202ecf3b256ec4
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Thu, 4 Aug 2022 02:25:29 +0000 (11:25 +0900)]
Remove unnecessary codes (get_handle, xid)
Change-Id: Ided2c548d480e7933aa0bb6ecf4312b8c84f6d8d
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Thu, 4 Aug 2022 01:31:44 +0000 (10:31 +0900)]
Remove unused codes
Change-Id: Ie4c287f6745631d386d8aa5edc387c4662c1a95d
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Wed, 3 Aug 2022 11:22:03 +0000 (20:22 +0900)]
Remove vc handle in vc and vc_client
Change-Id: I6dc961c12e2949539df54251b8a0b4a752620c3a
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Wed, 3 Aug 2022 08:35:04 +0000 (17:35 +0900)]
Remove unused functions
Change-Id: I448171a8c8076a09886c8a5b26bb85d098e34360
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Tue, 2 Aug 2022 05:55:20 +0000 (14:55 +0900)]
Remove a logic to check TIDL privileges
Change-Id: I82f566421225fd7d6e903fe45a7c30592e9fbf6c
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Mon, 1 Aug 2022 11:20:41 +0000 (20:20 +0900)]
Fix tidl error handling codes
Change-Id: I2d4662c41d486335b597d5f3930164150873f5d9
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Mon, 1 Aug 2022 06:11:23 +0000 (15:11 +0900)]
Change type casting using intptr_t
Change-Id: I596abafd51aa4af3e537b0df561b40c50cfcbc52
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Mon, 1 Aug 2022 01:46:42 +0000 (10:46 +0900)]
Update version (1.70.5)
Change-Id: Idc0ab244ddd26b049995da126cdee2c6e73deb62
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Fri, 29 Jul 2022 06:00:12 +0000 (15:00 +0900)]
Fix svace and coverity issues
Change-Id: Ic72a37bbbd082b9cbb35f8cafdf9384a6cbd60d6
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Wed, 6 Jul 2022 07:11:34 +0000 (16:11 +0900)]
Replace codes to check feature and privilege
Change-Id: I2691dbf7a1c3f4a5bcdb8e9eebb29b28cad050ce
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Wed, 6 Jul 2022 06:10:13 +0000 (15:10 +0900)]
Remove unnecessary logs
Change-Id: I7f4316fba8a62061cbe819465f2520e10e187fcb
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Wed, 6 Jul 2022 04:56:28 +0000 (13:56 +0900)]
Replace duplicated codes and Remove unnecessary logs
Change-Id: I595a15ba1e9b430e6e6f31ab84a491d60f7fc175
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Mon, 4 Jul 2022 07:55:59 +0000 (16:55 +0900)]
Fix TC issues (ignore ipc error in vce TCs and remove unnecessary codes)
Change-Id: I4944efd2ce825fc69ab6dcc86d90bc2b854f8d35
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Thu, 30 Jun 2022 09:33:26 +0000 (18:33 +0900)]
Add privilege checker for TIDL privileges
Change-Id: Iaf23e79bf61094688579297613f7e1ec3753d618
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Thu, 30 Jun 2022 08:44:12 +0000 (17:44 +0900)]
Rename function name and Rearrange codes
Change-Id: Iaa053e9004dd3aaf3e6caa99bfcab5288d73211b
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Thu, 30 Jun 2022 04:37:55 +0000 (13:37 +0900)]
Fix a minor issue (engine_appid was not saved in info handle)
Change-Id: I380beddfa0953fd21a9524158d8aa5b8f098878c
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Thu, 30 Jun 2022 02:48:50 +0000 (11:48 +0900)]
Remove unnecessary command and Fix return value in vcd_client_widget_get_foreground_pid()
Change-Id: I686738186f46907a74adccf412bc2295a1b79655
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Wed, 29 Jun 2022 08:39:17 +0000 (17:39 +0900)]
Unify bundle data in client, mgr, and widget
Change-Id: If822325a6edfcc6d6ea6fdf65229455fb8f081f6
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Wed, 29 Jun 2022 06:44:11 +0000 (15:44 +0900)]
Change return values and Fix minor issues
Change-Id: I1d10d83f58b3ec36ed3308b8906a5151b7571875
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Wed, 29 Jun 2022 01:51:11 +0000 (10:51 +0900)]
Remove files and codes related to DBus
Change-Id: I48d11a36f6551c9169d576218b9b56660de85489
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Tue, 28 Jun 2022 02:22:34 +0000 (11:22 +0900)]
Rename extern functions and Rearrange codes
Change-Id: I3da3d9e9a46b6126af91b9ddcc16b4f00ef4123f
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Tue, 28 Jun 2022 02:02:03 +0000 (11:02 +0900)]
Fix minor issues (indentation, filemod, add a checker of return values, etc)
Change-Id: I0f34be3b3fdfd659e7f47bca5d82f0c5333c1840
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Mon, 27 Jun 2022 08:12:33 +0000 (17:12 +0900)]
Replace IPC of vc_setting
Change-Id: I58f30103efd851762c01e6f2730087364c1b8cf8
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Sun, 26 Jun 2022 06:15:35 +0000 (15:15 +0900)]
Add a missing file in CMakeLists and a code to handle TTS feedback data
Change-Id: I9e8ef00e6e88a363cfc47578b9e19e7335f3f4c1
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Thu, 23 Jun 2022 01:47:28 +0000 (10:47 +0900)]
Implement functions related to auth, set_foreground, send_utterance_status
Change-Id: Ieddc83ffd9e76e75eedf28416dd21e952a6419ba
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Wed, 22 Jun 2022 09:45:50 +0000 (18:45 +0900)]
Disconnection dbus relationship
Change-Id: Ia8bfdf75fb6b8aad8bbcd49968e3185434cdfe1e
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Wed, 22 Jun 2022 09:32:41 +0000 (18:32 +0900)]
Rename functions and Implement some TODOs
Change-Id: Ic517b7bd84168c53d06dd5b752bee91d418e94a2
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Mon, 20 Jun 2022 12:05:33 +0000 (21:05 +0900)]
Add namespace(-n) option to build tidlc and Change TIDL apis
Change-Id: I1feba522be81db7567081650613e506f085d1906
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Mon, 13 Jun 2022 12:07:36 +0000 (21:07 +0900)]
Add functions related to auth and stub tidl
Change-Id: I1eded5e4c8f419de2925d30019c4c1579d013008
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
sooyeon [Fri, 3 Jun 2022 09:10:20 +0000 (18:10 +0900)]
Replace IPC (VCC) from dbus to tidl
Change-Id: Ief592a9240490c404b756b37cb7b887c3a974321
Signed-off-by: sooyeon <sooyeon.kim@samsung.com>
ulgal-park [Thu, 19 May 2022 10:39:58 +0000 (19:39 +0900)]
Change retry logic to match TIDL
Change-Id: I50b7ca2aa38904ebbc92bcdf6ba2b3390995ea69
ulgal-park [Thu, 19 May 2022 10:39:01 +0000 (19:39 +0900)]
Fix ipc sync function's return value
Change-Id: Ideac4cd335daf2de50153f96443af85bde0a0f49
ulgal-park [Thu, 19 May 2022 09:53:58 +0000 (18:53 +0900)]
Replace IPC between widget and server from dbus to tidl
Change-Id: I82d73ad71b794ab13f7bfd1a6298c531cf4805b4
ulgal-park [Fri, 13 May 2022 06:32:04 +0000 (15:32 +0900)]
Replace IPC between manager and server from dbus to tidl
Change-Id: I76e2c9aeef41f3d166fbe19feca62d3364f875bd
Suyeon Hwang [Thu, 28 Jul 2022 01:10:53 +0000 (01:10 +0000)]
Merge "Fix line coverage scope and test option" into tizen
ulgal-park [Mon, 25 Jul 2022 08:44:05 +0000 (17:44 +0900)]
Add metadata key
Change-Id: I898af8cff671a6b591360b86607c21831485d3e7
Suyeon Hwang [Mon, 25 Jul 2022 02:47:25 +0000 (11:47 +0900)]
Fix line coverage scope and test option
This patch reduces the scope for checking line coverage. The line
coverage is for checking client API, so other files in this repo is not
target of the line coverage test.
Change-Id: I677a34eb9a682a7cfd0c3d7e061fda1b7554cf17
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
wn.jang [Wed, 29 Jun 2022 05:52:08 +0000 (14:52 +0900)]
Check whether symbolic link or real file
If open a file in write mode and do not check whether the file is a symbolic link or not, the file can be overwritten unintentionally.
So, this commit will check whether the file is symbolic link or real file.
Change-Id: I9db8c0287b479ef7474a2525fc1de3bd39e47e22
Suyeon Hwang [Mon, 13 Jun 2022 08:14:53 +0000 (17:14 +0900)]
Update version (1.70.4)
Change-Id: I481f920d4592c0e7b1acfa02e40406c15f7305c8
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Fri, 10 Jun 2022 10:20:26 +0000 (19:20 +0900)]
Fix unittest for line coverage automation
Change-Id: I81ba58b22167ee07f155fc0fc0c468a4095b1989
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Suyeon Hwang [Thu, 9 Jun 2022 02:47:08 +0000 (11:47 +0900)]
Fix gcov package contents for automation
Change-Id: Ia9f42f9670c8c44d0cbfcfcffbed2d9751628829
Signed-off-by: Suyeon Hwang <stom.hwang@samsung.com>
Seongmin Park [Fri, 29 Apr 2022 07:04:49 +0000 (07:04 +0000)]
Merge "Revert "Replace IPC between manager and server from dbus to tidl"" into tizen
Seongmin Park [Fri, 29 Apr 2022 05:14:03 +0000 (05:14 +0000)]
Revert "Replace IPC between manager and server from dbus to tidl"
This reverts commit
58c72fc9dde94ee12ecae41b579b724c86269eba.
Reason for revert: this commit will be re-merged when all dbus replaced to tidl
Change-Id: Ic50ef53ff4b1e455464e587a9282f0b1989f5414
Seongmin Park [Fri, 29 Apr 2022 05:09:53 +0000 (05:09 +0000)]
Merge "Revert "Replace IPC between widget and server from dbus to tidl"" into tizen
Seongmin Park [Fri, 29 Apr 2022 02:57:40 +0000 (02:57 +0000)]
Revert "Replace IPC between widget and server from dbus to tidl"
This reverts commit
a88b50ad66a722e2b44735155623da2b8d2a75e0.
Reason for revert: <INSERT REASONING HERE>
Change-Id: I1e670df9d691736100f61edb16bf54fa349e6090
Seongmin Park [Fri, 29 Apr 2022 02:44:46 +0000 (02:44 +0000)]
Merge "Replace IPC between widget and server from dbus to tidl" into tizen
ulgal-park [Tue, 15 Mar 2022 03:04:27 +0000 (12:04 +0900)]
Replace IPC between widget and server from dbus to tidl
Change-Id: I08d104ed3511cfb0b251062e5521664105ae2cb3
wn.jang [Wed, 13 Apr 2022 10:38:09 +0000 (19:38 +0900)]
Add metadata profile xml file
Change-Id: I34c62f51fef48d29ce505c5ba010f72d7b4194ba
ulgal-park [Mon, 14 Feb 2022 10:31:00 +0000 (19:31 +0900)]
Replace IPC between manager and server from dbus to tidl
Change-Id: I0495d54c8a3ae5f89b5c38750e80760391a8e4c9
projects / platform / core / uifw / voice-control.git / log