platform/upstream/libSkiaSharp.git
10 years agoRemove ambiguous operator= on AutoCFRelease.
bungeman [Wed, 16 Jul 2014 20:46:06 +0000 (13:46 -0700)]
Remove ambiguous operator= on AutoCFRelease.

The operator= is ambiguous as to the state of the reference count.
Until we have rvalue assignment operators, just use 'reset' as the name
of the reference stealing assignment to AutoCFRelease.

R=reed@google.com, mtklein@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/400453002

10 years ago32 bpp floating point textures
joshualitt [Wed, 16 Jul 2014 20:32:56 +0000 (13:32 -0700)]
32 bpp floating point textures

This is VERY preliminary, but it was sufficient for me to get 32 bit floating point textures in a sample app

BUG=skia:
R=bsalomon@chromium.org, bsalomon@google.com

Author: joshualitt@chromium.org

Review URL: https://codereview.chromium.org/359803003

10 years agoBuffer four scanlines prior to blitting. We will eventually use this
krajcevski [Wed, 16 Jul 2014 20:31:41 +0000 (13:31 -0700)]
Buffer four scanlines prior to blitting. We will eventually use this
to blit four scanlines in a row in order to aggressively compress alpha
masks as the information comes in. This CL is only to introduce the API
and to make sure that nothing breaks in the general case.

R=reed@google.com, robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/387953005

10 years agoGeneralize mask helper a bit for compression
krajcevski [Wed, 16 Jul 2014 20:26:43 +0000 (13:26 -0700)]
Generalize mask helper a bit for compression

R=robertphillips@google.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/398603004

10 years agoAdd unique ID to GrPlot
robertphillips [Wed, 16 Jul 2014 20:26:24 +0000 (13:26 -0700)]
Add unique ID to GrPlot

This is calved off of (Add atlased layer purging - https://codereview.chromium.org/367073002/) where it is used for plot lifetime management (i.e., tracking which plots are locked).

R=jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/391153002

10 years agoChromium no longer needs the SkPicture default constructor
robertphillips [Wed, 16 Jul 2014 20:21:21 +0000 (13:21 -0700)]
Chromium no longer needs the SkPicture default constructor

With the landing of the Chromium CL (Remove use of default SkPicture constructor - https://codereview.chromium.org/387343003/) Chromium should no longer require the SK_SUPPORT_LEGACY_DEFAULT_PICTURE_CTOR flag.

R=halcanary@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/398463002

10 years agoMake gdb work for 64-bit Skia
qiankun.miao [Wed, 16 Jul 2014 20:21:15 +0000 (13:21 -0700)]
Make gdb work for 64-bit Skia

BUG=skia:
R=djsollen@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/398733002

10 years agorebaseline most dw changes
Mike Klein [Wed, 16 Jul 2014 20:20:12 +0000 (16:20 -0400)]
rebaseline most dw changes

BUG=skia:

Review URL: https://codereview.chromium.org/402443002

10 years agoFix broken android framework builds where 32-bit MIPS compilers lack 64-bit __sync...
Derek Sollenberger [Wed, 16 Jul 2014 19:51:39 +0000 (15:51 -0400)]
Fix broken android framework builds where 32-bit MIPS compilers lack 64-bit __sync operators.

R=mtklein@google.com, reed@google.com, scroggo@google.com

Review URL: https://codereview.chromium.org/398153002

10 years agoRemove yet-unused 64-bit atomic hooks.
Mike Klein [Wed, 16 Jul 2014 19:20:58 +0000 (15:20 -0400)]
Remove yet-unused 64-bit atomic hooks.

For now, I think we'll just be using sk_atomic_inc on 64-bit values, so
let's cut out the dead code for now.

NOTREECHECKS=true

BUG=skia:
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/398003004

10 years agoRemove outdated compiler restrictions.
Derek Sollenberger [Wed, 16 Jul 2014 19:20:01 +0000 (15:20 -0400)]
Remove outdated compiler restrictions.

R=scroggo@google.com

Review URL: https://codereview.chromium.org/394263002

10 years agoSkip tiling on bitmapscroll:
Mike Klein [Wed, 16 Jul 2014 18:19:54 +0000 (14:19 -0400)]
Skip tiling on bitmapscroll:
    - off by exactly one pixel when using DirectWrite
    - also at least one pixel off on ChromeOS

BUG=skia:
R=bungeman@google.com

Review URL: https://codereview.chromium.org/394243002

10 years agoReexport skia_gdi.
Mike Klein [Wed, 16 Jul 2014 17:26:19 +0000 (13:26 -0400)]
Reexport skia_gdi.

BUG=skia:

Review URL: https://codereview.chromium.org/398043004

10 years agoPut skia_directwrite back for now.
Mike Klein [Wed, 16 Jul 2014 17:11:50 +0000 (13:11 -0400)]
Put skia_directwrite back for now.

BUG=skia:

Review URL: https://codereview.chromium.org/397073002

10 years agoskia_directwrite -> skia_gdi
Mike Klein [Wed, 16 Jul 2014 17:06:04 +0000 (13:06 -0400)]
skia_directwrite -> skia_gdi

This will require lots of rebaselines and a bot CL to swap our lone direct write bot to a lone GDI bot.

BUG=skia:
R=bungeman@google.com

Review URL: https://codereview.chromium.org/394223003

10 years agoRevert of Reopened: Caching the result of readPixelsSupported (https://codereview...
bungeman [Wed, 16 Jul 2014 16:10:41 +0000 (09:10 -0700)]
Revert of Reopened: Caching the result of readPixelsSupported (https://codereview.chromium.org/364193004/)

Reason for revert:
This appears to be causing failures on Android when running tests.

Original issue's description:
> Caching the result of readPixelsSupported
>
> The call was calling GR_GL_GetIntegerv 2 times for each readPixels
> and thus was causing a loss of performance
>
> (resubmit of issue 344793008)
>
> Benchmark url: http://packages.gkny.fr/tst/index.html
>
> BUG=skia:2681
>
> Committed: https://skia.googlesource.com/skia/+/753a2964afe5661ce9b2a8ca77ca9d0aabd3173c
>
> Committed: https://skia.googlesource.com/skia/+/8339371f1ec3c57a0741932fd96bff32c53d4e54

R=junov@chromium.org, reed@chromium.org, bsalomon@chromium.org, mtklein@google.com, bsalomon@google.com, piotaixr@chromium.org
TBR=bsalomon@chromium.org, bsalomon@google.com, junov@chromium.org, mtklein@google.com, piotaixr@chromium.org, reed@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=skia:2681

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/395203002

10 years agomake gm self-tests launch python unittests automatically
epoger [Wed, 16 Jul 2014 15:28:23 +0000 (08:28 -0700)]
make gm self-tests launch python unittests automatically
(not just within the rebaseline_server subdirectory)

Generally useful, but needed asap for my work on http://skbug.com/2752 ('split existing "gpu" GM results into "gl" and "gles"')

BUG=skia:677
NOTREECHECKS=True
NOTRY=True
R=rmistry@google.com
TBR=rmistry

Author: epoger@google.com

Review URL: https://codereview.chromium.org/398043002

10 years agoRevert of Makes GrGLProgramDesc's key store the lengths as well as offsets of the...
mtklein [Wed, 16 Jul 2014 13:16:43 +0000 (06:16 -0700)]
Revert of Makes GrGLProgramDesc's key store the lengths as well as offsets of the effect keys. (https://codereview.chromium.org/379113004/)

Reason for revert:
Most likely candidate for Valgrind failures:

[21:10:08.755668] ==3036== Use of uninitialised value of size 8
[21:10:08.755753] ==3036==    at 0x734AB2: GrGpuGL::ProgramCache::getProgram(GrGLProgramDesc const&, GrEffectStage const**, GrEffectStage const**) (GrGpuGL_program.cpp:107)
[21:10:08.755788] ==3036==    by 0x734ED2: GrGpuGL::flushGraphicsState(GrGpu::DrawType, GrDeviceCoordTexture const*) (GrGpuGL_program.cpp:253)
[21:10:08.755811] ==3036==    by 0x6E81C2: GrGpu::setupClipAndFlushState(GrGpu::DrawType, GrDeviceCoordTexture const*, GrDrawState::AutoRestoreEffects*, SkRect const*) (GrGpu.cpp:350)
[21:10:08.755837] ==3036==    by 0x6E9BE8: GrGpu::onDraw(GrDrawTarget::DrawInfo const&) (GrGpu.cpp:390)
[21:10:08.755858] ==3036==    by 0x6EEECE: GrInOrderDrawBuffer::flush() (GrDrawTarget.h:506)
[21:10:08.755879] ==3036==    by 0x6D0EB4: GrContext::flush(int) (GrContext.cpp:1327)
[21:10:08.755900] ==3036==    by 0x6D3F8F: GrContext::writeTexturePixels(GrTexture*, int, int, int, int, GrPixelConfig, void const*, unsigned long, unsigned int) (GrContext.cpp:1349)
[21:10:08.755922] ==3036==    by 0x6D39D7: GrContext::writeRenderTargetPixels(GrRenderTarget*, int, int, int, int, GrPixelConfig, void const*, unsigned long, unsigned int) (GrContext.cpp:1632)
[21:10:08.755949] ==3036==    by 0x6FFDF3: GrRenderTarget::writePixels(int, int, int, int, GrPixelConfig, void const*, unsigned long, unsigned int) (GrRenderTarget.cpp:45)
[21:10:08.755978] ==3036==    by 0x735563: SkGpuDevice::onWritePixels(SkImageInfo const&, void const*, unsigned long, int, int) (SkGpuDevice.cpp:280)
[21:10:08.756003] ==3036==    by 0x57A048: SkBaseDevice::writePixels(SkImageInfo const&, void const*, unsigned long, int, int) (SkDevice.cpp:106)
[21:10:08.756025] ==3036==    by 0x56D0AE: SkCanvas::writePixels(SkImageInfo const&, void const*, unsigned long, int, int) (SkCanvas.cpp:700)
[21:10:08.756050] ==3036==    by 0x56D156: SkCanvas::writePixels(SkBitmap const&, int, int) (SkCanvas.cpp:652)
[21:10:08.756077] ==3036==    by 0x5109B6: test_WritePixels(skiatest::Reporter*, GrContextFactory*) (WritePixelsTest.cpp:464)
[21:10:08.756099] ==3036==    by 0x51114C: skiatest::WritePixelsClass::onRun(skiatest::Reporter*) (WritePixelsTest.cpp:361)
[21:10:08.756122] ==3036==    by 0x406BE8: skiatest::Test::run() (Test.cpp:107)
[21:10:08.756145] ==3036==    by 0x4064C2: SkTestRunnable::run() (skia_test.cpp:109)
[21:10:08.756167] ==3036==    by 0x405D1A: tool_main(int, char**) (skia_test.cpp:221)
[21:10:08.756189] ==3036==    by 0x405F75: main (skia_test.cpp:239)
[21:10:08.756211] ==3036==  Uninitialised value was created by a stack allocation
[21:10:08.756233] ==3036==    at 0x734CC8: GrGpuGL::flushGraphicsState(GrGpu::DrawType, GrDeviceCoordTexture const*) (GrGpuGL_program.cpp:213)

Original issue's description:
> Makes GrGLProgramDesc's key store the lengths as well as offsets of the effect keys.
>
> Makes it possible to use GrBackendEffectFactories other than GrTBEF by moving meta-key generation out of GrTBEF.
>
> Cleans up docs around GrBackendEffectFactory.
>
> Committed: https://skia.googlesource.com/skia/+/c0ea398aff8254e31152cbb94c9ab6150428e252

R=robertphillips@google.com, jvanverth@google.com, bsalomon@google.com
TBR=bsalomon@google.com, jvanverth@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: mtklein@google.com

Review URL: https://codereview.chromium.org/394213002

10 years agoLeaking CGBitmapContext in SkFontHost_mac
ljagielski [Wed, 16 Jul 2014 03:02:04 +0000 (20:02 -0700)]
Leaking CGBitmapContext in SkFontHost_mac

third_party/skia/src/ports/SkFontHost_mac.cpp: don't increase retain count of
newly assigned CFTypeRef in AutoCFRelease::reset(). Each time CFTypeRef is
assigned to AutoCFRelease, AutoCFRelease becomes its sole owner.

BUG=skia:
R=reed@google.com, bungeman@google.com, rmistry@google.com, sheyang@chromium.org

Author: ljagielski@opera.com

Review URL: https://codereview.chromium.org/393513003

10 years agoFix some issues with sfnt maxp headers.
bungeman [Wed, 16 Jul 2014 03:01:56 +0000 (20:01 -0700)]
Fix some issues with sfnt maxp headers.

The TT version was missing the second to last member,
and the names of the asserts in the CFF version were wrong.

R=mtklein@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/390203003

10 years agoremove dead code from sample
reed [Wed, 16 Jul 2014 02:56:55 +0000 (19:56 -0700)]
remove dead code from sample

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/393063002

10 years agoRemove kImageIsImmutable_Flag.
scroggo [Wed, 16 Jul 2014 02:56:48 +0000 (19:56 -0700)]
Remove kImageIsImmutable_Flag.

This flag was only used when setting or checking SkBitmap's
immutability when it did not have an SkPixelRef. Now that an
SkBitmap *must* have one in order to draw (e.g. you can no
longer have an SkBitmap that owns its pixels directly), its
immutabity without an SkPixelRef makes no sense.

Also, now that the flags are not contiguous starting from
0x01, use a more appropriate check to ensure only meaningful
flags are used.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/387083002

10 years agoUse va_list variable safely
qiankun.miao [Wed, 16 Jul 2014 02:51:41 +0000 (19:51 -0700)]
Use va_list variable safely

va_list variable will be invalid after the first call. Use va_copy to
initialize the va_list for another call.

BUG=skia:
R=djsollen@google.com, mtklein@google.com

Author: qiankun.miao@intel.com

Review URL: https://codereview.chromium.org/394763004

10 years agoMake SkTextureCompressor compile with Clang 3.5
halcanary [Wed, 16 Jul 2014 02:51:35 +0000 (19:51 -0700)]
Make SkTextureCompressor compile with Clang 3.5

kR11EACModifierPalettes moved inside #ifdef where it is used

R=mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/391113002

10 years agoAlways have GrLayer's rect be valid
robertphillips [Wed, 16 Jul 2014 02:46:35 +0000 (19:46 -0700)]
Always have GrLayer's rect be valid

This CL just makes atlasing easier/clearer since there is a separate atlased query method. Not using the rect as a signal also simplifies the rendering of the layer in SkGpuDevice.cpp.

This is calved off from (Add atlased layer purging - https://codereview.chromium.org/367073002/)

R=bsalomon@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/384233002

10 years agoFixed the bug in drawVertices when no colors or texture coordinates are provided...
dandov [Wed, 16 Jul 2014 02:46:26 +0000 (19:46 -0700)]
Fixed the bug in drawVertices when no colors or texture coordinates are provided by modifying the grprimitive to klines and adjusting the indices.

BUG=skia:2745

Committed: https://skia.googlesource.com/skia/+/612364de87cb2012239c4f6435e8e11760617fdc

R=jvanverth@google.com, bsalomon@google.com, egdaniel@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/387113002

10 years agoMakes GrGLProgramDesc's key store the lengths as well as offsets of the effect keys.
bsalomon [Wed, 16 Jul 2014 02:41:17 +0000 (19:41 -0700)]
Makes GrGLProgramDesc's key store the lengths as well as offsets of the effect keys.

Makes it possible to use GrBackendEffectFactories other than GrTBEF by moving meta-key generation out of GrTBEF.

Cleans up docs around GrBackendEffectFactory.

R=robertphillips@google.com, jvanverth@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/379113004

10 years agoCaching the result of readPixelsSupported
piotaixr [Wed, 16 Jul 2014 02:41:08 +0000 (19:41 -0700)]
Caching the result of readPixelsSupported

The call was calling GR_GL_GetIntegerv 2 times for each readPixels
and thus was causing a loss of performance

(resubmit of issue 344793008)

Benchmark url: http://packages.gkny.fr/tst/index.html

BUG=skia:2681

Committed: https://skia.googlesource.com/skia/+/753a2964afe5661ce9b2a8ca77ca9d0aabd3173c

R=junov@chromium.org, reed@chromium.org, bsalomon@chromium.org, mtklein@google.com, bsalomon@google.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/364193004

10 years agorevert timer changes
Mike Klein [Tue, 15 Jul 2014 23:17:44 +0000 (19:17 -0400)]
revert timer changes

BUG=skia:

Review URL: https://codereview.chromium.org/397843002

10 years agonanobench on Windows: try compiler barriers around timer instead.
Mike Klein [Tue, 15 Jul 2014 23:04:14 +0000 (19:04 -0400)]
nanobench on Windows: try compiler barriers around timer instead.

BUG=skia:

Review URL: https://codereview.chromium.org/391193003

10 years agoDisable LTCG for nanobench.
Mike Klein [Tue, 15 Jul 2014 22:39:49 +0000 (18:39 -0400)]
Disable LTCG for nanobench.

NOTREECHECKS=true

BUG=skia:
R=mtklein@google.com

Review URL: https://codereview.chromium.org/393953006

10 years agoTry to debug Windows infinite loops in nanobench.
Mike Klein [Tue, 15 Jul 2014 21:56:37 +0000 (17:56 -0400)]
Try to debug Windows infinite loops in nanobench.

NOTREECHECKS=true

BUG=skia:

Review URL: https://codereview.chromium.org/396753004

10 years agoKeep at most one GPU device alive at a time.
mtklein [Tue, 15 Jul 2014 21:38:53 +0000 (14:38 -0700)]
Keep at most one GPU device alive at a time.

NOTREECHECKS=true

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/392013004

10 years agoSkAutoRef seems lonely. Might as well delete it.
mtklein [Tue, 15 Jul 2014 20:29:34 +0000 (13:29 -0700)]
SkAutoRef seems lonely.  Might as well delete it.

(On the other hand, SkAutoUnref is well-used.)

NOTREECHECKS=true

BUG=skia:
R=bungeman@google.com, mtklein@google.com, reed@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/393953004

10 years agoDM: destroy contexts after each GPU task instead of before
Mike Klein [Tue, 15 Jul 2014 20:10:02 +0000 (16:10 -0400)]
DM: destroy contexts after each GPU task instead of before

This is for consistency with bench/nanobench/GM.  Haven't seen it make a difference.

BUG=skia:

Review URL: https://codereview.chromium.org/397743004

10 years agoChange SkCanvasState to use inheritance.
scroggo [Tue, 15 Jul 2014 19:34:26 +0000 (12:34 -0700)]
Change SkCanvasState to use inheritance.

The base class, SkCanvasState, now holds the version, width, and
height. These fields will always be a necessary part of the class.
(Also add in some padding.)
The other fields, which may change, have been moved into the
subclass, SkCanvasState_v1. If/when the version changes, it will
correspond to a new subclass.
In SkCanvasStateUtils::CreateFromCanvasState, check the version on
the base class, then do a static_cast to the version corresponding
to SkCanvasState::version.

Remove CANVAS_STATE_VERSION, which is redundant with the version
specified by the subclass.

Use unambiguous type for rowBytes.

Build Android with SK_SUPPORT_LEGACY_CLIPTOLAYERFLAG. This allows us
to run the full suite of CanvasState tests. It is also representative
of what will be used on Android by WebView.

Fix CanvasStateTest where it was broken inside ifdef'ed out code.

Use SkCanvas::getBaseLayerSize() instead of the deprecated
SkCanvas::getDeviceSize().

Update the comments in the header to be more clear. In particular,
an SkCanvasState can only be used to pass an SkCanvas' state to a
future version of Skia (or the same); not an older version.

NOTREECHECKS=true

BUG=b/15693384
R=reed@google.com, mtklein@google.com, djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/372003002

10 years agodestroyContexts after each bench instead of before
Mike Klein [Tue, 15 Jul 2014 17:40:19 +0000 (13:40 -0400)]
destroyContexts after each bench instead of before

BUG=skia:

Review URL: https://codereview.chromium.org/394893002

10 years agoGive windows boring bars and use 'us' for microseconds.
mtklein [Tue, 15 Jul 2014 17:30:31 +0000 (10:30 -0700)]
Give windows boring bars and use 'us' for microseconds.

NOTREECHECKS=true

BUG=skia:
R=bsalomon@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/393673006

10 years agoforce another build
Mike Klein [Tue, 15 Jul 2014 16:01:06 +0000 (12:01 -0400)]
force another build

BUG=skia:

Review URL: https://codereview.chromium.org/397493008

10 years agoForce a build for nanobench.
Mike Klein [Tue, 15 Jul 2014 15:49:58 +0000 (11:49 -0400)]
Force a build for nanobench.

BUG=skia:

Review URL: https://codereview.chromium.org/391983002

10 years agoAdd --resetGpuContext to both DM and nanobench.
mtklein [Tue, 15 Jul 2014 15:27:06 +0000 (08:27 -0700)]
Add --resetGpuContext to both DM and nanobench.

Defaulting to true to be conservative for now.

BUG=skia:

NOTREECHECKS=true
R=mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/398483005

10 years agohttps://chromiumcodereview.appspot.com/331133004/
kozyatinskiy [Tue, 15 Jul 2014 15:08:01 +0000 (11:08 -0400)]
https://chromiumcodereview.appspot.com/331133004/

patch from issue 331133004

10 years agoAnother forced run for Android bots.
Mike Klein [Tue, 15 Jul 2014 15:00:26 +0000 (11:00 -0400)]
Another forced run for Android bots.

BUG=skia:

Review URL: https://codereview.chromium.org/388683005

10 years agoforce build
Mike Klein [Tue, 15 Jul 2014 14:37:53 +0000 (10:37 -0400)]
force build

BUG=skia:

Review URL: https://codereview.chromium.org/391103002

10 years agoWhitespace change to test failures after https://skia.googlesource.com/buildbot/...
borenet [Tue, 15 Jul 2014 12:30:47 +0000 (05:30 -0700)]
Whitespace change to test failures after https://skia.googlesource.com/buildbot/+/0e977d0753ecc81fd4e45e088ebc5bc16f0b4b75 and https://skia.googlesource.com/buildbot/+/0e6fdada778ad14e38b25f8b5827a8b156674045

BUG=skia:
R=mtklein@google.com
TBR=mtklein

Author: borenet@google.com

Review URL: https://codereview.chromium.org/397613003

10 years agomanual bench rebase after f459c85, adjusted with ed458688e284508f17a0408a093d89a8b5966e32
bensong [Mon, 14 Jul 2014 23:36:06 +0000 (16:36 -0700)]
manual bench rebase after f459c85, adjusted with ed458688e284508f17a0408a093d89a8b5966e32

R=robertphillips@google.com
TBR=robertphillips@google.com

Bypassing trybots:
NOTRY=true

Author: bensong@google.com

Review URL: https://codereview.chromium.org/394673002

10 years agoRevert of drawVertices bug on gpu side (https://codereview.chromium.org/387113002/)
dandov [Mon, 14 Jul 2014 21:52:36 +0000 (14:52 -0700)]
Revert of drawVertices bug on gpu side (https://codereview.chromium.org/387113002/)

Reason for revert:
compare gms failed on 6 images, I will check them and determine if they need a rebaseline or if the output is incorrect.

Original issue's description:
> Fixed the bug in drawVertices when no colors or texture coordinates are provided by modifying the grprimitive to klines and adjusting the indices.
>
> BUG=skia:2745
>
> Committed: https://skia.googlesource.com/skia/+/612364de87cb2012239c4f6435e8e11760617fdc

R=jvanverth@google.com, bsalomon@google.com, egdaniel@google.com
TBR=bsalomon@google.com, egdaniel@google.com, jvanverth@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2745

Author: dandov@google.com

Review URL: https://codereview.chromium.org/395613002

10 years agopatch from issue 383923002
reed [Mon, 14 Jul 2014 21:39:15 +0000 (14:39 -0700)]
patch from issue 383923002

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/394603003

10 years agoFixed the bug in drawVertices when no colors or texture coordinates are provided...
dandov [Mon, 14 Jul 2014 21:26:04 +0000 (14:26 -0700)]
Fixed the bug in drawVertices when no colors or texture coordinates are provided by modifying the grprimitive to klines and adjusting the indices.

BUG=skia:2745
R=jvanverth@google.com, bsalomon@google.com, egdaniel@google.com

Author: dandov@google.com

Review URL: https://codereview.chromium.org/387113002

10 years agoFix memory leak introduced in http://crrev.com/387863005
halcanary [Mon, 14 Jul 2014 19:59:59 +0000 (12:59 -0700)]
Fix memory leak introduced in crrev.com/387863005

NOTRY=true
R=bungeman@google.com, mtklein@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/395543002

10 years agoCleanup: Remove unused/unimplemented SkTextLayout.h.
tfarina [Mon, 14 Jul 2014 19:32:47 +0000 (12:32 -0700)]
Cleanup: Remove unused/unimplemented SkTextLayout.h.

Nobody uses it in Skia, Chromium and Blink. And it does not have any
implementation either.

BUG=None
TEST=make all
R=mtklein@google.com, reed@google.com

Author: tfarina@chromium.org

Review URL: https://codereview.chromium.org/385323002

10 years agonanobench: add --runOnce.
mtklein [Mon, 14 Jul 2014 19:28:47 +0000 (12:28 -0700)]
nanobench: add --runOnce.

BUG=skia:
R=egdaniel@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/392583005

10 years agoAdd support for NEON intrinsics to speed up texture compression. We can
krajcevski [Mon, 14 Jul 2014 19:00:04 +0000 (12:00 -0700)]
Add support for NEON intrinsics to speed up texture compression. We can
now convert the time that we would have spent uploading the texture to
compressing it giving a net 50% memory savings for these things.

Committed: https://skia.googlesource.com/skia/+/bc9205be0a1094e312da098348601398c210dc5a

R=robertphillips@google.com, mtklein@google.com, kevin.petit@arm.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/390453002

10 years agonanobench: support --outResultsFile
mtklein [Mon, 14 Jul 2014 18:30:37 +0000 (11:30 -0700)]
nanobench: support --outResultsFile

BUG=skia:
R=kelvinly@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/390933002

10 years agoInclude SkTypes before using ifdefs.
scroggo [Mon, 14 Jul 2014 17:25:00 +0000 (10:25 -0700)]
Include SkTypes before using ifdefs.

Fixes Android framework build.

When building for the Android framework, we depend on SkUserConfig.h
to define things like SK_SUPPORT_GPU. So we cannot have the first
include inside a guard requring SK_SUPPORT_GPU to be defined. Include
SkTypes first, which will pull in SkUserConfig, define the flag, and
allow us to include GrContextFactory.h.

R=reed@google.com, djsollen@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/394533003

10 years agoAlphabetize defines in generated SkUserConfig.
scroggo [Mon, 14 Jul 2014 17:22:02 +0000 (10:22 -0700)]
Alphabetize defines in generated SkUserConfig.

When generating SkUserConfig.h for Android, alphabetize the defines.

This will make one merge much harder to look at, but every following
one much easier.

R=mtklein@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/388693003

10 years agoFix for saveLayer() with filters vs. the BBox Hierarchy.
senorblanco [Mon, 14 Jul 2014 17:19:54 +0000 (10:19 -0700)]
Fix for saveLayer() with filters vs. the BBox Hierarchy.

When building acceleration structures for SkPicture, we must transform
the primitive's bounds not only by its own SkPaint, but by the paints of
any saveLayer()s currently active above it.

We do this by pushing the SkPaint onto a stack on
saveLayer(), and popping them on restore(). We also push
a NULL paint in save(), so that the pushes and pops are
balanced.

BUG=skia:2734
R=mtklein@google.com, reed@google.com, robertphillips@google.com

Committed: https://skia.googlesource.com/skia/+/6ca0b6a46cbe9bef3e2b9b9db813ec864efd62de

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/380373003

10 years agoremove unused SkPixelRef constructor
reed [Mon, 14 Jul 2014 17:13:57 +0000 (10:13 -0700)]
remove unused SkPixelRef constructor

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/390893002

10 years agoremove SK_SUPPORT_LEGACY_PIXELREF_UNFLATTENABLE code
reed [Mon, 14 Jul 2014 16:21:31 +0000 (09:21 -0700)]
remove SK_SUPPORT_LEGACY_PIXELREF_UNFLATTENABLE code

TBR=

Author: reed@google.com

Review URL: https://codereview.chromium.org/387313004

10 years agoMove SkPDFStream back to SkStream to save memory.
halcanary [Mon, 14 Jul 2014 16:12:12 +0000 (09:12 -0700)]
Move SkPDFStream back to SkStream to save memory.

SkPDFStream stores data as a SkStreamRewindable to minimize
deep duplication and memory overhead.

SkStreamToStreamRewindable function to deal with fact that
SkTypeface returns a SkStream.

BUG=skia:2743
R=djsollen@google.com, mtklein@google.com, bungeman@google.com, reed@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/387863005

10 years agoRevert of Enable the SSSE3 compile time check on all platforms. (https://codereview...
halcanary [Mon, 14 Jul 2014 15:32:18 +0000 (08:32 -0700)]
Revert of Enable the SSSE3 compile time check on all platforms. (https://codereview.chromium.org/391693004/)

Reason for revert:
windows fail

Original issue's description:
> Enable the SSSE3 compile time check on all platforms.
>
> BUG=skia:2746
>
> Committed: https://skia.googlesource.com/skia/+/ee349531446ae2a8336b0903e05d0b2150d2131f

R=mtklein@google.com, djsollen@google.com
TBR=djsollen@google.com, mtklein@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2746

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/390063002

10 years agoRevert "Fix for saveLayer() with filters vs. the BBox Hierarchy." and
senorblanco [Mon, 14 Jul 2014 15:25:33 +0000 (08:25 -0700)]
Revert "Fix for saveLayer() with filters vs. the BBox Hierarchy." and
"resizeimagefiler is ok with a BBH now".

This reverts commits 6ca0b6a46cbe9bef3e2b9b9db813ec864efd62de and 8fa73202eaffbd7591ee218ad452b9afde81f505.

Apparently causing problems in SKP playback.

R=mtklein@google.com, robertphillips@google.com
TBR=mtklein, robertphillips
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/381353005

10 years agoEnable the SSSE3 compile time check on all platforms.
djsollen [Mon, 14 Jul 2014 14:58:41 +0000 (07:58 -0700)]
Enable the SSSE3 compile time check on all platforms.

BUG=skia:2746
R=mtklein@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/391693004

10 years agoRemove last SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX.
scroggo [Mon, 14 Jul 2014 14:58:34 +0000 (07:58 -0700)]
Remove last SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX.

Should have been included in https://codereview.chromium.org/379323002
but it was overlooked. As of that CL, the flag does not do anything.

BUG=skia:1976
R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/390033002

10 years agoMake SkPictureShader and SkPictureImageFilter use const SkPictures
robertphillips [Mon, 14 Jul 2014 14:53:26 +0000 (07:53 -0700)]
Make SkPictureShader and SkPictureImageFilter use const SkPictures

R=mtklein@google.com, reed@google.com
TBR=reed@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/390023002

10 years agoRemove unused kImageIsOpaque_Flag.
scroggo [Mon, 14 Jul 2014 14:53:18 +0000 (07:53 -0700)]
Remove unused kImageIsOpaque_Flag.

This flag is never set or read. We now look at the alpha type to
determine opacity.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/385943003

10 years agoMIPS: added optimization for SkRGB16_Opaque_Blitter::blitMask
djordje.pesut [Mon, 14 Jul 2014 14:48:11 +0000 (07:48 -0700)]
MIPS: added optimization for SkRGB16_Opaque_Blitter::blitMask

gaint is ~30%

R=djsollen@google.com

Author: djordje.pesut@imgtec.com

Review URL: https://codereview.chromium.org/357693002

10 years agoDeleted SkImage::newShaderClamp: not used, not implemented.
piotaixr [Mon, 14 Jul 2014 14:48:04 +0000 (07:48 -0700)]
Deleted SkImage::newShaderClamp: not used, not implemented.

Implemented SkImage::newShader.

BUG=skia:2701, 344804
R=junov@chromium.org, reed@chromium.org, bsalomon@chromium.org, reed@google.com

Author: piotaixr@chromium.org

Review URL: https://codereview.chromium.org/345463009

10 years agoReallow default SkPicture constructor for Chromium
Robert Phillips [Mon, 14 Jul 2014 13:28:15 +0000 (09:28 -0400)]
Reallow default SkPicture constructor for Chromium

This is breaking the Chromium build in:
external/chromium_org/android_webview/browser/browser_view_renderer.cc

TBR=reed@google.com

Review URL: https://codereview.chromium.org/392593002

10 years agoMake GrAtlas::removePlot static
robertphillips [Sun, 13 Jul 2014 17:09:42 +0000 (10:09 -0700)]
Make GrAtlas::removePlot static

This CL just calves off a small chunk of (Add atlased layer purging - https://codereview.chromium.org/367073002/).

R=jvanverth@google.com
TBR=jvanverth@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/388103002

10 years agoRemove Skia's use of the default SkPicture constructor and multi-clone
Robert Phillips [Sun, 13 Jul 2014 16:00:50 +0000 (12:00 -0400)]
Remove Skia's use of the default SkPicture constructor and multi-clone

This cannot be landed until (Chrome: Switch to one-at-a-time SkPicture::clone interface - https://codereview.chromium.org/380323002/) has landed.

R=mtklein@google.com
TBR=reed@google.com

Review URL: https://codereview.chromium.org/388833003

10 years agoRemove SkPicture copy constructor
robertphillips [Sun, 13 Jul 2014 14:55:53 +0000 (07:55 -0700)]
Remove SkPicture copy constructor

Given where we're heading with SkPicture why would you need to make a copy?

R=reed@google.com, mtklein@google.com

Author: robertphillips@google.com

Review URL: https://codereview.chromium.org/381133002

10 years agoAdd SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels
reed [Sun, 13 Jul 2014 11:32:32 +0000 (04:32 -0700)]
Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels

This reverts commit 651eaeadeb0b1407f5fe192aeda90db1680fa2b8.

TBR=

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/390693002

10 years agodon't draw unpremul alpha (yet)
reed [Sun, 13 Jul 2014 04:10:52 +0000 (21:10 -0700)]
don't draw unpremul alpha (yet)

without these early exits, we can treat unpremul colors as premul, generating asserts and wacky colors.

TBR=

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/386203002

10 years agoRevert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels...
reed [Sat, 12 Jul 2014 20:16:10 +0000 (13:16 -0700)]
Revert of Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels (https://codereview.chromium.org/388803007/)

Reason for revert:
still failing (randomly?) bench sometimes. need stack dump to diagnose.

Original issue's description:
> Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels
> usning it.
>
> Revert "Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)"
>
> This reverts commit d08cb905a7cc80d8fb868bbd14fffe1cd68adcce.
>
> TBR=scroggo@google.com
>
> Committed: https://skia.googlesource.com/skia/+/debba5c3d091159149f8a88ab5dcd44dd72e0dc7

R=reed@google.com
TBR=reed@google.com
NOTREECHECKS=true
NOTRY=true

Author: reed@chromium.org

Review URL: https://codereview.chromium.org/382543005

10 years agoAdd SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels
reed [Sat, 12 Jul 2014 19:26:36 +0000 (12:26 -0700)]
Add SkBitmap::readPixels() and reimplement copyTo and SkCanvas::readPixels
usning it.

Revert "Revert of add readPixels() to SkBitmap (https://codereview.chromium.org/377303002/)"

This reverts commit d08cb905a7cc80d8fb868bbd14fffe1cd68adcce.

R=reed@chromium.org
TBR=scroggo@google.com

Author: reed@google.com

Review URL: https://codereview.chromium.org/388803007

10 years agoMake SkPDFFont::fFontInfo a const pointer.
halcanary [Sat, 12 Jul 2014 02:45:23 +0000 (19:45 -0700)]
Make SkPDFFont::fFontInfo a const pointer.

BUG=skia:2742
R=djsollen@google.com, scroggo@google.com

Author: halcanary@google.com

Review URL: https://codereview.chromium.org/383063007

10 years agoRefactor SkGrFontScaler and SkGrFontKey into non-virtual versions.
jvanverth [Sat, 12 Jul 2014 02:45:16 +0000 (19:45 -0700)]
Refactor SkGrFontScaler and SkGrFontKey into non-virtual versions.

This is a pre-cleanup for another change, but has the side benefit of making
the code simpler in general.

No perf increase, despite removing virtual functions.

R=bsalomon@google.com, egdaniel@google.com

Author: jvanverth@google.com

Review URL: https://codereview.chromium.org/385263002

10 years agofix ios break
caryclark [Fri, 11 Jul 2014 20:21:17 +0000 (13:21 -0700)]
fix ios break

R=reed@android.com
TBR=reed
NOTREECHECKS=TRUE
NOTRY=TRUE

BUG=skia:

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/388933003

10 years agoRevert of Add support for NEON intrinsics to speed up texture compression. We can...
krajcevski [Fri, 11 Jul 2014 20:15:15 +0000 (13:15 -0700)]
Revert of Add support for NEON intrinsics to speed up texture compression. We can (https://codereview.chromium.org/390453002/)

Reason for revert:
Breaking chrome.

Original issue's description:
> Add support for NEON intrinsics to speed up texture compression. We can
> now convert the time that we would have spent uploading the texture to
> compressing it giving a net 50% memory savings for these things.
>
> Committed: https://skia.googlesource.com/skia/+/bc9205be0a1094e312da098348601398c210dc5a

R=robertphillips@google.com, mtklein@google.com, kevin.petit@arm.com
TBR=kevin.petit@arm.com, mtklein@google.com, robertphillips@google.com
NOTREECHECKS=true
NOTRY=true

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/384053003

10 years agoNo need to cache local matrix in picture shader.
scroggo [Fri, 11 Jul 2014 19:19:00 +0000 (12:19 -0700)]
No need to cache local matrix in picture shader.

Now that the local matrix cannot be changed, we no longer need
to keep track of it to regenerate the bitmap shader.

Depends on https://codereview.chromium.org/379323002

R=fmalita@google.com, fmalita@chromium.org

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/387043002

10 years agoios fixes
caryclark [Fri, 11 Jul 2014 19:14:51 +0000 (12:14 -0700)]
ios fixes

skia_ios.mm
Get the app's Documents directory and pass use it to set the resource path.
This is a quick hack which will be replaced by a new application that is
a tiny shim around a command line tool.

SkImageEncoder.h
SkForceLinking.cpp
SkImageDecoder_CG.cpp
Add support for FORCE_LINKING so iOS sees the PNG encoder and others.

SkFloatBits.cpp
SkPoint.cpp
Handle denormalized numbers that are floored by the iOS ARM processor.

SkImageDecoder_iOS.mm
Remove empty encoder factory.

SkTouchGesture.cpp
Return early on empty state on touch rather than aborting (crashing)

JpegTest.cpp
Hal via stackoverflow.com says partial jpegs can be gray as well.

skia_test.cpp
Remove crash handler call for now to avoid link failure.

OverwriteLine.h
Remove fancy line overwrite for iOS.

Resources.cpp
Add interface to set resource directory based on runtime query.

BUG=skia:2736 skia:2737 skia:2738
R=reed@google.com, halcanary@google.com, mtklein@google.com, tfarina@chromium.org

Author: caryclark@google.com

Review URL: https://codereview.chromium.org/373383003

10 years agoAdd support for NEON intrinsics to speed up texture compression. We can
krajcevski [Fri, 11 Jul 2014 19:12:27 +0000 (12:12 -0700)]
Add support for NEON intrinsics to speed up texture compression. We can
now convert the time that we would have spent uploading the texture to
compressing it giving a net 50% memory savings for these things.

R=robertphillips@google.com, mtklein@google.com, kevin.petit@arm.com

Author: krajcevski@google.com

Review URL: https://codereview.chromium.org/390453002

10 years agonanobench: add a cute bar chart
mtklein [Fri, 11 Jul 2014 18:57:07 +0000 (11:57 -0700)]
nanobench: add a cute bar chart

Give this a try?  Helpful, or gets in the way?

BUG=skia:
R=krajcevski@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/390483002

10 years agoRemove SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX.
scroggo [Fri, 11 Jul 2014 18:33:52 +0000 (11:33 -0700)]
Remove SK_SUPPORT_LEGACY_SHADER_LOCALMATRIX.

This is no longer needed by Android.

BUG=skia:1976
R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/379323002

10 years agoresizeimagefiler is ok with a BBH now
mtklein [Fri, 11 Jul 2014 18:27:01 +0000 (11:27 -0700)]
resizeimagefiler is ok with a BBH now

BUG=skia:
R=senorblanco@chromium.org, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/387933002

10 years agoUse unpremul for premul_and_unpremul_alpha_ bench.
scroggo [Fri, 11 Jul 2014 17:45:11 +0000 (10:45 -0700)]
Use unpremul for premul_and_unpremul_alpha_ bench.

Using the wrong color type resulted in invalid colors.

R=bsalomon@google.com, reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/382243005

10 years agoUse SkShader's localMat for SkLocalMatrixShader.
scroggo [Fri, 11 Jul 2014 17:42:12 +0000 (10:42 -0700)]
Use SkShader's localMat for SkLocalMatrixShader.

Instead of setting SkShader::fLocalMatrix to Identity and storing
a separate SkMatrix inside SkLocalMatrixShader, reuse
SkShader::fLocalMatrix.

R=reed@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/386693003

10 years agoNew Mac 10.6 x86_64 Debug baselines for perlin noise tests.
senorblanco [Fri, 11 Jul 2014 17:09:02 +0000 (10:09 -0700)]
New Mac 10.6 x86_64 Debug baselines for perlin noise tests.

R=jcgregorio@google.com
TBR=jcgregorio@google.com
NOTRY=true
NOTREECHECKS=true
BUG=skia:

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/384043002

10 years agoThis moves us towards variable length effect keys. The overall program key now allows...
bsalomon [Fri, 11 Jul 2014 17:01:02 +0000 (10:01 -0700)]
This moves us towards variable length effect keys. The overall program key now allows for it. After the header it stores an array of offsets to effect keys. This allows us to grab the effect keys to pass to effects when they generate code. It also ensures that we can't get a collision by sets of keys that are different lengths but are the same when appended  together.

R=robertphillips@google.com, jvanverth@google.com, egdaniel@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/356513003

10 years agoFix for saveLayer() with filters vs. the BBox Hierarchy.
senorblanco [Fri, 11 Jul 2014 16:56:03 +0000 (09:56 -0700)]
Fix for saveLayer() with filters vs. the BBox Hierarchy.

When building acceleration structures for SkPicture, we must transform
the primitive's bounds not only by its own SkPaint, but by the paints of
any saveLayer()s currently active above it.

We do this by pushing the SkPaint onto a stack on
saveLayer(), and popping them on restore(). We also push
a NULL paint in save(), so that the pushes and pops are
balanced.

BUG=skia:2734
R=mtklein@google.com, reed@google.com

Author: senorblanco@chromium.org

Review URL: https://codereview.chromium.org/380373003

10 years agoRevert of Remove gpu shader optimatization for solid white or trans black colors...
egdaniel [Fri, 11 Jul 2014 16:13:37 +0000 (09:13 -0700)]
Revert of Remove gpu shader optimatization for solid white or trans black colors (https://codereview.chromium.org/375823005/)

Reason for revert:
possible test and gm failures

Original issue's description:
> Remove gpu shader optimatization for solid white or trans black colors
>
> Running test on the added bench which draws a grid of all white paths, all blue paths, or alternating checkered white/blue paths.
>
> With optimization in (ms):
>          White       Blue        Checkered
> Linux    ~80         ~80         ~160
> N7       ~800        ~1100       ~1500
> Moto-e   ~830        ~1100       ~2500
>
> Without optimization in (ms):
>          White       Blue        Checkered
> Linux    ~80         ~80         ~80
> N7       ~1100       ~1100       ~1100
> Moto-e   ~1100       ~1100       ~1500
>
> BUG=skia:
>
> Committed: https://skia.googlesource.com/skia/+/5f78d2251a440443c9eaa321dad058d7a32bfef7

R=bsalomon@google.com
TBR=bsalomon@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/385163004

10 years agoRevert of Remove public_headers.gypi, unneeded by Skia. (https://codereview.chromium...
scroggo [Fri, 11 Jul 2014 16:05:32 +0000 (09:05 -0700)]
Revert of Remove public_headers.gypi, unneeded by Skia. (https://codereview.chromium.org/381633003/)

Reason for revert:
Breaking canary: http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-ToT/builds/1207/steps/Update/logs/stdio

Original issue's description:
> Remove public_headers.gypi, unneeded by Skia.
>
> This file not needed by Skia, and is almost always out of date.
> We recommend generating this inside Android WebView, where it is
> used. Generating it is relatively straightforward; here is one way:
> https://codereview.chromium.org/198063002/diff/110001/platform_tools/android/gyp_gen/gen_public_headers.py
>
> BUG=skia:2350
>
> Committed: https://skia.googlesource.com/skia/+/a3fce46f7c85eb3eb5c5373c1eaa0336d9756252

R=robertphillips@google.com
TBR=robertphillips@google.com
NOTREECHECKS=true
NOTRY=true
BUG=skia:2350

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/382153007

10 years agoRemove gpu shader optimatization for solid white or trans black colors
egdaniel [Fri, 11 Jul 2014 15:57:40 +0000 (08:57 -0700)]
Remove gpu shader optimatization for solid white or trans black colors

Running test on the added bench which draws a grid of all white paths, all blue paths, or alternating checkered white/blue paths.

With optimization in (ms):
         White       Blue        Checkered
Linux    ~80         ~80         ~160
N7       ~800        ~1100       ~1500
Moto-e   ~830        ~1100       ~2500

Without optimization in (ms):
         White       Blue        Checkered
Linux    ~80         ~80         ~80
N7       ~1100       ~1100       ~1100
Moto-e   ~1100       ~1100       ~1500

BUG=skia:
R=bsalomon@google.com

Author: egdaniel@google.com

Review URL: https://codereview.chromium.org/375823005

10 years agoroll "common" DEPS, and replace tools/pyutils with it
epoger [Fri, 11 Jul 2014 15:52:35 +0000 (08:52 -0700)]
roll "common" DEPS, and replace tools/pyutils with it

BUG=skia:2682
R=borenet@google.com

Author: epoger@google.com

Review URL: https://codereview.chromium.org/385783002

10 years agoUpdate find_name_and_attributes to take ttc index and rename to SkTypeface_FreeType...
bungeman [Fri, 11 Jul 2014 15:52:26 +0000 (08:52 -0700)]
Update find_name_and_attributes to take ttc index and rename to SkTypeface_FreeType::ScanFont.

The name 'ScanFont' is to mirror the naming convention of similar functions in FontConfig.

R=tomhudson@google.com

Author: bungeman@google.com

Review URL: https://codereview.chromium.org/382053003

10 years agoexplicitly add /data/local/tmp to the library path to support new AOSP restrictions
djsollen [Fri, 11 Jul 2014 15:47:23 +0000 (08:47 -0700)]
explicitly add /data/local/tmp to the library path to support new AOSP restrictions

BUG=skia:2660
R=tomhudson@chromium.org, tomhudson@google.com

Author: djsollen@google.com

Review URL: https://codereview.chromium.org/387893003

10 years agoRemove public_headers.gypi, unneeded by Skia.
scroggo [Fri, 11 Jul 2014 15:47:16 +0000 (08:47 -0700)]
Remove public_headers.gypi, unneeded by Skia.

This file not needed by Skia, and is almost always out of date.
We recommend generating this inside Android WebView, where it is
used. Generating it is relatively straightforward; here is one way:
https://codereview.chromium.org/198063002/diff/110001/platform_tools/android/gyp_gen/gen_public_headers.py

BUG=skia:2350
R=robertphillips@google.com

Author: scroggo@google.com

Review URL: https://codereview.chromium.org/381633003

10 years agoSlim Skia down to just one murmur3 implementation.
mtklein [Fri, 11 Jul 2014 15:42:17 +0000 (08:42 -0700)]
Slim Skia down to just one murmur3 implementation.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/6ac0037b70410ff7d5ce5788bc89314223e1a587

Committed: https://skia.googlesource.com/skia/+/67a3271f0de9ccc32d559b042b862528272047cc

Committed: https://skia.googlesource.com/skia/+/53d435990bdb4d14df78013da45a9364d0287ebe

CQ_EXTRA_TRYBOTS=tryserver.skia:Perf-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release-Trybot
R=reed@google.com, mtklein@google.com

Author: mtklein@chromium.org

Review URL: https://codereview.chromium.org/376183004

10 years agoAdd support for 64bit atomic inc/dec/cas
bsalomon [Fri, 11 Jul 2014 15:42:11 +0000 (08:42 -0700)]
Add support for 64bit atomic inc/dec/cas

R=mtklein@google.com

Author: bsalomon@google.com

Review URL: https://codereview.chromium.org/377073002