platform/upstream/xamarin-forms.git
7 years agoRemove VisualElement finalizer (#918)
E.Z. Hart [Tue, 16 May 2017 17:27:41 +0000 (11:27 -0600)]
Remove VisualElement finalizer (#918)

* [Controls] Add repo for bugzilla 55365

* Remove finalizer from VisualElement

* Remove unused using directive

* Removing test for 44074

* Update docs

7 years ago[XamlC] process symbols if DebugType is set (#925)
Stephane Delcroix [Tue, 16 May 2017 17:07:31 +0000 (19:07 +0200)]
[XamlC] process symbols if DebugType is set (#925)

7 years ago[C] fix BP declaring Types for A11y (#913)
Stephane Delcroix [Wed, 10 May 2017 18:07:37 +0000 (20:07 +0200)]
[C] fix BP declaring Types for A11y (#913)

7 years ago[All] Rename Accessibility -> AutomationProperties (#912)
Samantha Houts [Wed, 10 May 2017 17:20:57 +0000 (10:20 -0700)]
[All] Rename Accessibility -> AutomationProperties (#912)

* [All] Renamed Accessibility -> AutomationProperties

* Update docs

* Restore doc summaries

* Revert unintended csproj changes

7 years agoFix build
Rui Marinho [Wed, 10 May 2017 15:05:27 +0000 (16:05 +0100)]
Fix build

7 years ago[Core] Accessibility works with XamlC (#911)
Samantha Houts [Wed, 10 May 2017 06:50:20 +0000 (23:50 -0700)]
[Core] Accessibility works with XamlC (#911)

* Add unit tests for a11y XAML parsing

* [Core] Add Get/Set methods for XamlC

* Update docs

* Fix rogue blank line

7 years agoFix bugzilla55542 (#898)
Rui Marinho [Thu, 4 May 2017 14:27:30 +0000 (15:27 +0100)]
Fix bugzilla55542 (#898)

* [Controls] Add repo for bugzilla 55542

* [Core] Fix caching null renderer for ViewCell view

7 years ago[Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602...
Koen Hendriks [Thu, 4 May 2017 14:08:30 +0000 (16:08 +0200)]
[Android] Add null check before creating and drawing canvas bugzilla 55559 & 45602 (#899)

* [Android] Add null check before creating and drawing canvas bugzilla 55559 & bugzilla 45602.

* [Android] REFACTOR Add null check before creating and drawing canvas bugzilla 55559 & 45602 #899

7 years agoGive layouts a chance to handle touch events after passing though immediate children...
E.Z. Hart [Thu, 4 May 2017 09:51:01 +0000 (03:51 -0600)]
Give layouts a chance to handle touch events after passing though immediate children (#902)

* Repro for Bugzilla 55912

* Automate test

* Give the layout a chance to actually handle gestures before bubbling up

7 years agoAdd disposed check on FastRenderer.VisualElemen... (#888)
bentmar [Fri, 28 Apr 2017 09:27:15 +0000 (11:27 +0200)]
Add disposed check on FastRenderer.VisualElemen... (#888)

7 years ago[Android] Add disposed check on FastRenderers.LabelRenderer (#886)
bentmar [Fri, 28 Apr 2017 09:15:09 +0000 (11:15 +0200)]
[Android] Add disposed check on FastRenderers.LabelRenderer (#886)

* add disposed check on FastLabelRenderer

Description of Change

Check is the Label is dispodes on GetDesiredSize() on fast LabelRenderer

Bugs Fixed

System.ObjectDisposedException: Cannot access a disposed object.

API Changes

None

Behavioral Changes

None

* Update LabelRenderer.cs

7 years agoadd disposed check on FastRenderers.FrameRenderer (#887)
bentmar [Fri, 28 Apr 2017 09:14:42 +0000 (11:14 +0200)]
add disposed check on FastRenderers.FrameRenderer (#887)

7 years ago[iOS] Null Element before disposing trial renderers in uneven ListViews (#894)
Samantha Houts [Tue, 2 May 2017 23:18:05 +0000 (16:18 -0700)]
[iOS] Null Element before disposing trial renderers in uneven ListViews (#894)

* Add repro for 55745

* [iOS] Null Element before disposing trial renderers

7 years ago[Xaml] move ValueConverterProvider to Core (#890)
Stephane Delcroix [Fri, 28 Apr 2017 19:11:38 +0000 (21:11 +0200)]
[Xaml] move ValueConverterProvider to Core (#890)

* [Xaml] move ValueConverterProvider to Core

* [docs] fix docs

7 years ago[XamlC] support valueTypes x:Arrays (#875)
Stephane Delcroix [Thu, 27 Apr 2017 09:17:27 +0000 (11:17 +0200)]
[XamlC] support valueTypes x:Arrays (#875)

7 years agoMerge master
Jason Smith [Wed, 26 Apr 2017 17:11:46 +0000 (10:11 -0700)]
Merge master

7 years agoAdd netstandard group to nuspec (#884)
Samantha Houts [Tue, 25 Apr 2017 21:43:51 +0000 (14:43 -0700)]
Add netstandard group to nuspec (#884)

7 years agoBetter error handling for image loading errors on iOS/Android (#849)
E.Z. Hart [Tue, 25 Apr 2017 18:16:25 +0000 (12:16 -0600)]
Better error handling for image loading errors on iOS/Android (#849)

* First run at removing async void image update methods

Consistent error logging and IsLoading on Android,iOS,UWP

Move error logging into image handlers for better messages

Add demo of custom ImageRenderer error handling

Update docs

Make the test smaller so the results don't get pushed offscreen

Fix namespace error

* Update error handling for fast image renderer

* Update 37625 test to use image we control

* Add java disposed check to avoid ObjectDisposedException in async operations

* Add disposed checks to legacy renderer; null check element before SetIsLoading

* Check disposed on GetDesiredSize for fast renderer
Use local disposed member where possible for disposed check

* Check for disposal after async handlers in iOS

* Add disposal checks after async methods in Windows

* Reset linker settings on project; reduce redundant casts in ImageViewExtensions

7 years ago[XamlC] Check param type in op_Implicit (#876)
Stephane Delcroix [Tue, 25 Apr 2017 18:15:36 +0000 (20:15 +0200)]
[XamlC] Check param type in op_Implicit (#876)

7 years ago[iOS] Prevent NRE in ListView OnItemSelected (#883)
Samantha Houts [Tue, 25 Apr 2017 18:14:16 +0000 (11:14 -0700)]
[iOS] Prevent NRE in ListView OnItemSelected (#883)

* Add repro

* [iOS] Prevent NRE in ListView

* [Android] Prevent NRE in ListView

Not observed, but adding defensive check just in case

7 years ago[Xaml] OnPlatform.Default value (#873)
Stephane Delcroix [Tue, 25 Apr 2017 18:06:29 +0000 (20:06 +0200)]
[Xaml] OnPlatform.Default value (#873)

* [Xaml] OnPlatform.Default value

* docs

7 years ago[Xaml] OnPlatform.Default value (#873)
Stephane Delcroix [Tue, 25 Apr 2017 18:06:29 +0000 (20:06 +0200)]
[Xaml] OnPlatform.Default value (#873)

* [Xaml] OnPlatform.Default value

* docs

7 years ago[XamlC] support nested types type declarations (#872)
Stephane Delcroix [Thu, 20 Apr 2017 19:06:00 +0000 (21:06 +0200)]
[XamlC] support nested types type declarations (#872)

7 years ago[XamlC] allow namespaces in {x:Type} markups (#867)
Stephane Delcroix [Thu, 20 Apr 2017 18:53:13 +0000 (20:53 +0200)]
[XamlC] allow namespaces in {x:Type} markups (#867)

* [XamlC] allow namespaces in {x:Type} markups

* missing test

7 years agoMake OnElementPropertyChanged virtual on fast renderers (#870)
E.Z. Hart [Tue, 18 Apr 2017 09:28:03 +0000 (03:28 -0600)]
Make OnElementPropertyChanged virtual on fast renderers (#870)

7 years agocalling API not available in all versions (#877)
kingces95 [Wed, 19 Apr 2017 16:50:07 +0000 (12:50 -0400)]
calling API not available in all versions (#877)

7 years agocalling API not available in all versions (#877)
kingces95 [Wed, 19 Apr 2017 16:50:07 +0000 (12:50 -0400)]
calling API not available in all versions (#877)

7 years ago[Xaml][test] Passing test for Bz55343
Stephane Delcroix [Wed, 19 Apr 2017 08:37:01 +0000 (10:37 +0200)]
[Xaml][test] Passing test for Bz55343

7 years ago(Passing) test for 54977
Stephane Delcroix [Tue, 18 Apr 2017 12:47:35 +0000 (14:47 +0200)]
(Passing) test for 54977

7 years agoMake OnElementPropertyChanged virtual on fast renderers (#870)
E.Z. Hart [Tue, 18 Apr 2017 09:28:03 +0000 (03:28 -0600)]
Make OnElementPropertyChanged virtual on fast renderers (#870)

7 years agoREADME: add macOS to list of supported platforms (#871)
Andres G. Aragoneses [Tue, 18 Apr 2017 09:27:10 +0000 (17:27 +0800)]
README: add macOS to list of supported platforms (#871)

Support was added in https://github.com/xamarin/Xamarin.Forms/pull/650
(https://github.com/xamarin/Xamarin.Forms/commit/52fc04724fc163c68c54cf33a5931871f8c1ee8e)

7 years agoUpdate ListProxyTest.WeakToWeak so it works in Release mode (#866)
E.Z. Hart [Thu, 13 Apr 2017 14:40:05 +0000 (08:40 -0600)]
Update ListProxyTest.WeakToWeak so it works in Release mode (#866)

* Update ListProxyTest.WeakToWeak so it works in Release mode

* Disable CS0414 for test

7 years agoVerify FragmentContainer created when queueing fragment transaction (Android) (#865)
E.Z. Hart [Thu, 13 Apr 2017 15:11:50 +0000 (09:11 -0600)]
Verify FragmentContainer created when queueing fragment transaction (Android) (#865)

* Add check for disposed MasterDetailContainer when queueing fragment transaction

* Fix various ObjectDisposedExceptions when setting main page

* Add check for legacy renderers when querying control properties

7 years agoUpdate ListProxyTest.WeakToWeak so it works in Release mode (#866)
E.Z. Hart [Thu, 13 Apr 2017 14:40:05 +0000 (08:40 -0600)]
Update ListProxyTest.WeakToWeak so it works in Release mode (#866)

* Update ListProxyTest.WeakToWeak so it works in Release mode

* Disable CS0414 for test

7 years ago[Test]Ignore Weak reference test, failing only on release
Rui Marinho [Wed, 12 Apr 2017 18:04:55 +0000 (19:04 +0100)]
[Test]Ignore Weak reference test, failing only on release

7 years ago[UITest]Fix release build
Rui Marinho [Wed, 12 Apr 2017 16:10:18 +0000 (17:10 +0100)]
[UITest]Fix release build

7 years agoResource Manager fix for F# File Resources (Bugzilla 53515) (#825)
Rob Lyndon [Wed, 12 Apr 2017 10:57:13 +0000 (11:57 +0100)]
Resource Manager fix for F# File Resources (Bugzilla 53515) (#825)

* Resource Manager fix for F# File Resources (Bugzilla 53515)

* Changed spaces to tabs and changed the argument name in the ResourceManager.GetId() function.

* Improved the type checking in GetId().

7 years agoMap renderer extensibility (#844)
jcmanke [Tue, 11 Apr 2017 22:52:04 +0000 (17:52 -0500)]
Map renderer extensibility (#844)

* Added extensibility features to Maps

Android MapRenderer:
- Moved map initialization to protected virtual method OnMapReady, called by explicit implementation of IOnMapReady
-  Added protected virtual method CreateMarker for customization of pins

iOS MapRenderer:
- Added protected virtual method CreateAnnotation for customization of pins

Pin:
- Unsealed the Pin class
- Made Label a bindable property

* [Docs] Update docs

7 years agoMarking exposed plumbing internal only in the docs. (#863)
Mike Norman [Tue, 11 Apr 2017 22:51:14 +0000 (17:51 -0500)]
Marking exposed plumbing internal only in the docs. (#863)

* Marking exposed plumbing internal only in the docs.

* Update docs

7 years ago[C] Lookup in RD also lookup in merged RDs (#861)
Stephane Delcroix [Tue, 11 Apr 2017 18:09:06 +0000 (20:09 +0200)]
[C] Lookup in RD also lookup in merged RDs (#861)

7 years agoImplicit impl of controller ifaces (#807)
kingces95 [Tue, 11 Apr 2017 18:02:06 +0000 (14:02 -0400)]
Implicit impl of controller ifaces (#807)

* Simplify ICtrl callsites

* Rebase fix

7 years agoClean up NavigationBar code in Platform (#753)
Jimmy Garrido [Tue, 11 Apr 2017 09:48:41 +0000 (02:48 -0700)]
Clean up NavigationBar code in Platform (#753)

7 years agoSpell correction of FromattedString (#864)
Anders Rasmussen [Tue, 11 Apr 2017 09:03:07 +0000 (11:03 +0200)]
Spell correction of FromattedString (#864)

7 years agoDo not emit implict_op if from/to are same type (#862)
kingces95 [Mon, 10 Apr 2017 06:48:54 +0000 (02:48 -0400)]
Do not emit implict_op if from/to are same type (#862)

7 years ago[Xaml] Set the TargetProperty on ServiceProvider (#847)
Stephane Delcroix [Fri, 7 Apr 2017 07:48:17 +0000 (09:48 +0200)]
[Xaml] Set the TargetProperty on ServiceProvider (#847)

7 years ago[Internal] Normalize Obsolete attributes (#860)
Samantha Houts [Fri, 7 Apr 2017 07:47:33 +0000 (00:47 -0700)]
[Internal] Normalize Obsolete attributes (#860)

* [All] Normalize Obsolete attributes.

Make sure we include the version in which the member was deprecated and
consistent instructions for working around the deprecation, if
applicable.

* Update docs

7 years agoFix 52962; Cont refresh even when pullToRefresh is disabled (#810)
kingces95 [Thu, 6 Apr 2017 21:47:12 +0000 (17:47 -0400)]
Fix 52962; Cont refresh even when pullToRefresh is disabled (#810)

7 years agoMore Xaml generic support (#857)
Stephane Delcroix [Thu, 6 Apr 2017 21:37:59 +0000 (23:37 +0200)]
More Xaml generic support (#857)

* [XamlG] allow x:Name on nested generic types

* [Xaml*] fail on undeclared xmlns

* [XamlC] allow x:Arguments on generic ctors

7 years ago[Xaml[C]] supports 'using:' xmlns declarations (#851)
Stephane Delcroix [Thu, 6 Apr 2017 21:22:50 +0000 (23:22 +0200)]
[Xaml[C]] supports 'using:' xmlns declarations (#851)

7 years agoFix 54334 (#855)
Stephane Delcroix [Thu, 6 Apr 2017 21:13:49 +0000 (23:13 +0200)]
Fix 54334 (#855)

* [C] unset the FromStyle flag on manual setting

* [C] Do not reset overriden values to default

* complete the fix

7 years agoOnResume assumed that _application had been set (#859)
App Bureauet [Thu, 6 Apr 2017 21:11:05 +0000 (23:11 +0200)]
OnResume assumed that _application had been set (#859)

When OnResume is called it should not expect the _application to be set already.
I have an app where I use one activity for showing a splash screen and then it starts an intent to show the main activity containing the application.
This used to work before 2.3.4.224.

7 years agoFix NRE when RecycleElement is on and list is scrolled quickly (#856)
E.Z. Hart [Thu, 6 Apr 2017 18:55:51 +0000 (12:55 -0600)]
Fix NRE when RecycleElement is on and list is scrolled quickly (#856)

7 years ago[iOS] ActivityIndicator should not disappear when used in a ViewCell (#495)
adrianknight89 [Thu, 6 Apr 2017 18:25:47 +0000 (13:25 -0500)]
[iOS] ActivityIndicator should not disappear when used in a ViewCell (#495)

* preserve activity indicator state

* changed to using listviewrenderer

* remove whitespace

* moved message to constructor

* add sample code

* remove message sending

* changes

* remove curly braces

7 years agoAdded Section indexes when FastScrolled is enabled (#850)
James Clancey [Thu, 6 Apr 2017 17:54:00 +0000 (09:54 -0800)]
Added Section indexes when FastScrolled is enabled (#850)

* Added Section indexes when FastScrolled is enabled

* Moved the GroupListAdapater to its own file

* Renamed Setup to ValidateSectionData

7 years agoAndroid fastrenderers (#845)
Rui Marinho [Thu, 6 Apr 2017 13:19:52 +0000 (14:19 +0100)]
Android fastrenderers (#845)

* Obsolete IVisualElementRenderer.ViewGroup in favor of .View

* Fix NRE

* Changing TContainer in PlatformEffect to View

* Fix "View" type

* new VisualElementRenderer

* First attempt at a fast(er) button renderer

* Fast Label Renderer

* Let's try that again. Behold: Label Fast Renderer

* Move FrameRenderer into Fast Renderers

* Fix Disposable on VisualElementRenderer

* Simplify touch and click handlers

* Drop empty if clause

* [Android] Add initial Image fast renderer

* Split accessibility out to a separate helper class; fix tapgesture bug with label

* [Android] Small fixes to VisualElementRenderer

* Move accessiblity stuff to a separate class (which needs a good name)

* Prevent query from looking to parent for fast renderers

* [Android] ImageRenderer refactoring

* Fix elevation/z-index bugs with Button (e.g., 40173)

* Move SetLabeledBy to Accessibilitizer

* Un-break automation IDs for Labels

* Move gesture handling to its own class

* Split gesture and effect management into separate classes

* Remove unneeded packager from LabelRenderer

* LabelRenderer inherits from FormsTextView

* Batch updates to View

* Fix isOnParentRenderer check for non-Android platforms

* [Controls] Update Xamarin.Forms.ControlGallery.iOS.csproj

* [Android,IOS] Small fixes to rebase and use of Internals

* [Android] Ignroe warning for now

* Fast renderers now passing InputTransparent and IsEnabled tests

* Fast and legacy renderers now pass the Enabled and InputTransparent tests

* Change PlatformEffect back, default container to null

* Fix mangled using directives

7 years ago[Xaml] updating the unittests project to cecil .10-b5 too
Stephane Delcroix [Wed, 5 Apr 2017 11:41:02 +0000 (13:41 +0200)]
[Xaml] updating the unittests project to cecil .10-b5 too

7 years agoEarly april doc bugs (#854)
Mike Norman [Mon, 3 Apr 2017 19:31:40 +0000 (14:31 -0500)]
Early april doc bugs (#854)

* Fixed: https://github.com/xamarin/documentation/issues/2071

Pulled dated and exuberant examples.

* Fixed: https://github.com/xamarin/documentation/issues/2002

Also added content for Load method in HtmlWebViewSource.xml

* Fixed: https://github.com/xamarin/documentation/issues/1959

* Fixed: https://github.com/xamarin/documentation/issues/1866

7 years agoHide alert window before setting result (#848)
Jimmy Garrido [Fri, 31 Mar 2017 00:04:29 +0000 (17:04 -0700)]
Hide alert window before setting result (#848)

7 years ago[XamlC] update cecil to 0.10.0-beta5
Stephane Delcroix [Thu, 30 Mar 2017 11:31:27 +0000 (13:31 +0200)]
[XamlC] update cecil to 0.10.0-beta5

7 years agoAlign iOS, Android, Windows handling of tap gesture event bubbling (#842)
E.Z. Hart [Wed, 29 Mar 2017 08:52:45 +0000 (02:52 -0600)]
Align iOS, Android, Windows handling of tap gesture event bubbling (#842)

* Add test for gesture bubbling behavior on all controls;
Make Windows behavior consistent with other platforms;

* Fix the stepper test

* Make Frame on Android handle tap event bubbling like the other platforms

* Formatting changes and query syntax instead of SelectMany

7 years ago[WinRT/UWP] Enable selection in password entry (#677)
Paul DiPietro [Mon, 27 Mar 2017 17:26:56 +0000 (12:26 -0500)]
[WinRT/UWP] Enable selection in password entry (#677)

* [WinRT/UWP] Enable selection in password entry

* Remove unnecessary if

7 years ago[Docs] Fix docs Scrollview IOS Specific (#843)
Rui Marinho [Mon, 27 Mar 2017 14:52:23 +0000 (15:52 +0100)]
[Docs] Fix docs Scrollview IOS Specific (#843)

7 years agoFix 53427; Change default UAP styling for a label (#837)
kingces95 [Mon, 27 Mar 2017 10:32:18 +0000 (03:32 -0700)]
Fix 53427; Change default UAP styling for a label (#837)

7 years ago[iOS] Prevent NRE when page is switched on Appearing (#840)
Samantha Houts [Mon, 27 Mar 2017 10:31:04 +0000 (03:31 -0700)]
[iOS] Prevent NRE when page is switched on Appearing (#840)

7 years ago[Android]Refactor to use a extension method to get the drawable (#841)
Rui Marinho [Fri, 24 Mar 2017 22:11:20 +0000 (22:11 +0000)]
[Android]Refactor to use a extension method to get the drawable (#841)

* [Android]Refactor to use a extension method to get the drawable

* [Android] Use local variable on check

7 years agoBz53803 Android app crashes during initialization due to invalid cast of toolbar...
BradChase2011 [Fri, 24 Mar 2017 20:12:45 +0000 (16:12 -0400)]
Bz53803 Android app crashes during initialization due to invalid cast of toolbar TextView. (#835)

7 years ago[iOS] Platform specifics to control ScrollView content touch delay (#563)
adrianknight89 [Fri, 24 Mar 2017 19:07:59 +0000 (14:07 -0500)]
[iOS] Platform specifics to control ScrollView content touch delay (#563)

* can delay content touches optionally

* revert bug fix

* add back _tapGesture

* remove extra declaration

7 years agoSetup a ConditionalWeakTable in ListProxy to hold weak references so that a ListView...
Shane Neuville [Fri, 24 Mar 2017 18:58:28 +0000 (12:58 -0600)]
Setup a ConditionalWeakTable in ListProxy to hold weak references so that a ListView will work when connected to a Weak Source (#802)

7 years ago[Android] Still look for the normal drawable on resources (#839)
Rui Marinho [Fri, 24 Mar 2017 17:54:12 +0000 (17:54 +0000)]
[Android] Still look for the normal drawable on resources (#839)

* [Android] Still look for the normal drawable on resources

* [Android]Fix code style

7 years ago[iOS] Don't skip row height estimation for grouped lists (#838)
Samantha Houts [Fri, 24 Mar 2017 11:02:59 +0000 (04:02 -0700)]
[iOS] Don't skip row height estimation for grouped lists  (#838)

* Nest bugzilla 51536 classes for less pollution

* Add repro for 53834

* [iOS] Don't skip row height estimation for grouped lists

7 years ago[Android] ScrollView can now consume Effects (#836)
Samantha Houts [Thu, 23 Mar 2017 23:12:41 +0000 (16:12 -0700)]
[Android] ScrollView can now consume Effects (#836)

* Add repro

* [Android] Make ScrollView an IEffectControlProvider

7 years agoUI tests for InputTransparent and fixes for Android/Windows (#808)
E.Z. Hart [Thu, 23 Mar 2017 17:18:38 +0000 (11:18 -0600)]
UI tests for InputTransparent and fixes for Android/Windows (#808)

* Set up automated UI tests for InputTransparent

* Pull in Adrian's UI tests from PR 483

* Fix bugs with box/label/image gestures passing through when not transparent

* Fix disabling of layouts on Windows; fix 44096 test for iOS/Windows;

* Automate the 53445 test

7 years ago[UITests]Add Xamarin.Forms.Core.UITests.Shared (#711)
Rui Marinho [Thu, 23 Mar 2017 11:03:48 +0000 (11:03 +0000)]
[UITests]Add Xamarin.Forms.Core.UITests.Shared (#711)

* [UITests]Add Xamarin.Forms.Core.UITests.Shared

* fix

* [UITests]Use shared UITest project on macOS

* [UITests] Add correct platform queries

* [Controls] Add missing Preserve

7 years ago[Android] Fix NRE on Picker (#834)
Rui Marinho [Wed, 22 Mar 2017 19:38:19 +0000 (19:38 +0000)]
[Android] Fix NRE on Picker (#834)

7 years ago[XamlC] accept assignment of Object from unboxed value types in SetValue (#832)
Stephane Delcroix [Wed, 22 Mar 2017 16:53:24 +0000 (17:53 +0100)]
[XamlC] accept assignment of Object from unboxed value types in SetValue (#832)

7 years ago[C] Make sure all children are parented (#831)
Stephane Delcroix [Wed, 22 Mar 2017 16:09:41 +0000 (17:09 +0100)]
[C] Make sure all children are parented (#831)

* unit test

* [C] make sure all children are properly parented

7 years ago[iOS/Win] Label will not unnecessarily expand (#827)
Samantha Houts [Wed, 22 Mar 2017 10:43:17 +0000 (03:43 -0700)]
[iOS/Win] Label will not unnecessarily expand (#827)

* Add repro for 53362

* [iOS] Label will not unnecessarily expand

* [Win] Label will not unnecessarily expand

7 years agoAdd gesture disposed check to FrameRenderer (#829)
E.Z. Hart [Wed, 22 Mar 2017 10:40:15 +0000 (04:40 -0600)]
Add gesture disposed check to FrameRenderer (#829)

7 years ago[C] fix NIE in Span (#828)
Stephane Delcroix [Tue, 21 Mar 2017 16:39:01 +0000 (17:39 +0100)]
[C] fix NIE in Span (#828)

7 years agoiOS renderers now properly look up the ImageSourceHandler for FileImageSource (#826)
James Clancey [Tue, 21 Mar 2017 15:02:39 +0000 (07:02 -0800)]
iOS renderers now properly look up the ImageSourceHandler for FileImageSource (#826)

7 years ago[C] fix BP DeclaringType in TextElement[C
Stephane Delcroix [Tue, 21 Mar 2017 11:44:31 +0000 (12:44 +0100)]
[C] fix BP DeclaringType in TextElement[C

7 years agoConvert Android maps to GetMapAsync call (#824)
Jason Smith [Tue, 21 Mar 2017 10:38:36 +0000 (03:38 -0700)]
Convert Android maps to GetMapAsync call (#824)

* [A] Move map renderer to calling GetMapAsync

* [A] Make sure Map initializes correctly with Async map fetching

7 years agoMake Entry completed behavior on UWP/WinRT match Android/iOS (#747)
E.Z. Hart [Mon, 20 Mar 2017 19:09:41 +0000 (13:09 -0600)]
Make Entry completed behavior on UWP/WinRT match Android/iOS (#747)

* Make Entry completed behavior on UWP/WinRT match Android/iOS

* Accessibility test

7 years ago[iOS] Use UIButtonType.System for Button and utilize UIButton.Appearance (#554)
adrianknight89 [Mon, 20 Mar 2017 15:53:54 +0000 (10:53 -0500)]
[iOS] Use UIButtonType.System for Button and utilize UIButton.Appearance (#554)

* Change button style and use UIButton appearance

* added sample code

* change references

* setting other properties

* add comment

* refactor proxy setter

* made control states array static

* remove category declaration

* changes

* add sample code

* changes

* Fix identation

* Update ButtonRenderer.cs

7 years ago[WinRT/UWP] Open Picker dropdown when calling Focus (#762)
Paul DiPietro [Mon, 20 Mar 2017 15:48:28 +0000 (10:48 -0500)]
[WinRT/UWP] Open Picker dropdown when calling Focus (#762)

7 years agoUWP MapRenderer NRE and Location fixes (#811)
Ethan Dennis [Mon, 20 Mar 2017 15:40:04 +0000 (10:40 -0500)]
UWP MapRenderer NRE and Location fixes (#811)

* Issues:
1. If UWP MapRenderer is navigated away from, before the user location
is found, an uncaught NRE will be thrown.
2. UWP MapRenderer updates are not enforced to be on UI thread
3. Order of operations in MapRenderer would cause user location to never
be shown.

Fixes:
1. Added null checks in UpdateUserIsShowing and LoadUserPosition
methods.
2. Called map position updates on UI thread.
3. Changed order of operations in OnElementChanged to allow for user
geocoordinates to be shown.

* Fixed code formatting issues

* Fix formatting

* Deterministic null checks

* Updated null checks

7 years ago[Core] Fix internal children clear logic (#820)
wplong11 [Mon, 20 Mar 2017 12:06:20 +0000 (21:06 +0900)]
[Core] Fix internal children clear logic (#820)

* Fix InternalChildren clear logic

* Improve InternalChildren clear logic

* Add test code to verify InternalChildren clear logic

* Add missing test cases

* Improve time complexity of clear logic

* Fix the test case where InvalidOperationException occurs.

* Correct the name casing of the test case

* Modify a wrong test code

7 years agoAdopt iOS status bar visibility defaults (#822)
kingces95 [Sat, 18 Mar 2017 18:55:40 +0000 (11:55 -0700)]
Adopt iOS status bar visibility defaults (#822)

7 years agonull check effects before clearing (#821)
kingces95 [Fri, 17 Mar 2017 22:57:11 +0000 (15:57 -0700)]
null check effects before clearing (#821)

7 years agoRemaining XAML API summaries. (#813)
Mike Norman [Thu, 16 Mar 2017 21:59:29 +0000 (16:59 -0500)]
Remaining XAML API summaries. (#813)

* Remaining XAML API summaries.

* update docs

7 years agoSet the transitioning delegate. (#819)
Daniel Williamson [Thu, 16 Mar 2017 21:58:42 +0000 (08:58 +1100)]
Set the transitioning delegate. (#819)

7 years agoResource loading (#815)
Stephane Delcroix [Thu, 16 Mar 2017 19:09:22 +0000 (20:09 +0100)]
Resource loading (#815)

* Resource Loader

* Replace XamlLoader API by ResourceLoader for the Previewer

* instruct generated IL to use the resourceLoader

* [docs] update docs

* oops

* [docs] fix docs

7 years agoAdd internal XF.Registrar.RegisterAll b/c previewer needs it (#816)
kingces95 [Thu, 16 Mar 2017 16:19:35 +0000 (09:19 -0700)]
Add internal XF.Registrar.RegisterAll b/c previewer needs it (#816)

7 years agoInternal-only boilerplate for Xaml.Internals docs. (#817)
Mike Norman [Thu, 16 Mar 2017 16:19:01 +0000 (11:19 -0500)]
Internal-only boilerplate for Xaml.Internals docs. (#817)

7 years ago[test] passing test for 53318 (#818)
Stephane Delcroix [Wed, 15 Mar 2017 10:35:44 +0000 (11:35 +0100)]
[test] passing test for 53318 (#818)

7 years agoBug 53224; Disable Cell if Command IsEnabled false (#812)
kingces95 [Wed, 15 Mar 2017 10:07:48 +0000 (03:07 -0700)]
Bug 53224; Disable Cell if Command IsEnabled false (#812)

7 years agoBug 51536, initial iOS cell layout is incorrect when cell has context actions … ...
Vitaly Knyazev [Tue, 14 Mar 2017 16:22:21 +0000 (16:22 +0000)]
Bug 51536, initial iOS cell layout is incorrect when cell has context actions … (#787)

* Bug 51536, initial height is incorrect when cell has context actions or ListView is in recycle mode

* Improved fix for iOS uneven height cell layout

* Fixed indentation and added test case for issue 44525

* Fixed indentation for test case

* Added 1px room, this will fix Bugzilla31330 test, renamed test case to 51536

* Updated shared project file

7 years agoUpdate create-nuget.bat
Chris King [Tue, 14 Mar 2017 14:33:20 +0000 (07:33 -0700)]
Update create-nuget.bat

7 years agoFix MasterDetailPage event cycle (#754)
adrianknight89 [Tue, 14 Mar 2017 11:57:32 +0000 (06:57 -0500)]
Fix MasterDetailPage event cycle (#754)

sample code

add tag

change message

changes

changes 2

changes 3

changes 4

7 years ago[WinRT/UWP] Fix Opacity behavior with ProgressBar (#695)
Paul DiPietro [Tue, 14 Mar 2017 11:00:10 +0000 (06:00 -0500)]
[WinRT/UWP] Fix Opacity behavior with ProgressBar (#695)

* [WinRT/UWP] Fix Opacity behavior with ProgressBar

* Update .nuspec

* Further update .nuspec

* Adjust .csproj line to fix Mac build