Tom Gundersen [Fri, 16 May 2014 13:24:09 +0000 (15:24 +0200)]
networkd: hardcode a set of default dns servers
Similarly to NTP servers, this can be set at compile-time.
Alison Chaiken [Fri, 16 May 2014 07:25:53 +0000 (09:25 +0200)]
man: readahead: fix cmdline switch inconsistency between readahead.c and docs
Source code has "files-max" and XML has --max-files.
Lennart Poettering [Fri, 16 May 2014 15:07:51 +0000 (17:07 +0200)]
readahead: modernizations
Lennart Poettering [Fri, 16 May 2014 14:51:56 +0000 (16:51 +0200)]
man: fix some minor language typos
Lennart Poettering [Fri, 16 May 2014 14:51:42 +0000 (16:51 +0200)]
build-sys: at configure check for verifying that ln supports --relative
Lennart Poettering [Fri, 16 May 2014 13:56:44 +0000 (15:56 +0200)]
network: always create /run/systemd/network/links
This ways the networkd client library should work even if networkd is
not running.
http://lists.freedesktop.org/archives/systemd-devel/2014-May/019242.html
Tom Gundersen [Fri, 16 May 2014 12:48:58 +0000 (14:48 +0200)]
Revert "networkd: order after udev kernel socket"
This reverts commit
a555350d47c4b70d716a63424933b34902c98300.
This did not fix the problem, just made it harder to hit.
Tom Gundersen [Fri, 16 May 2014 12:47:43 +0000 (14:47 +0200)]
networkd: log the initialization status of links
Tom Gundersen [Thu, 15 May 2014 22:26:37 +0000 (00:26 +0200)]
TODO
Tom Gundersen [Thu, 15 May 2014 21:14:52 +0000 (23:14 +0200)]
networkd: fix typo
Tom Gundersen [Thu, 15 May 2014 18:10:33 +0000 (20:10 +0200)]
networkd: rename Address and Route list fields
Kay Sievers [Thu, 15 May 2014 23:27:57 +0000 (01:27 +0200)]
timesyncd: fix typo in comment
Lennart Poettering [Thu, 15 May 2014 23:33:22 +0000 (01:33 +0200)]
man: clarify that the ExecReload= command should be synchronous
http://lists.freedesktop.org/archives/systemd-devel/2014-May/019054.html
Lennart Poettering [Thu, 15 May 2014 23:15:03 +0000 (01:15 +0200)]
core: make sure to serialize jobs for all units
Previously we wouldn't serialize jobs for units that themselves have
nothing to serialize.
http://lists.freedesktop.org/archives/systemd-devel/2014-May/019051.html
Lennart Poettering [Thu, 15 May 2014 22:23:26 +0000 (00:23 +0200)]
Update TODO
Kay Sievers [Thu, 15 May 2014 18:50:02 +0000 (20:50 +0200)]
timesyncd: fix error path return value
https://bugs.freedesktop.org/show_bug.cgi?id=78752
Lennart Poettering [Thu, 15 May 2014 16:55:19 +0000 (18:55 +0200)]
timesyncd: limit capabilities to CAP_SYS_TIME
Cristian Rodríguez [Tue, 13 May 2014 23:35:20 +0000 (19:35 -0400)]
network: fix build failure, missing KMOD_XXX flags
- Add KMOD_CFLAGS and KMOD_LIBS where appropiate
- networkd now requires kmod. make --disable-kmod --enable-networkd
to raise an error.
Lennart Poettering [Thu, 15 May 2014 16:30:07 +0000 (18:30 +0200)]
logind: bring polkit policy for hibernate in line with suspend/poweroff/reboot
THere's no reason why hibernate should be better protected then
suspendor poweroff, so sync the policies.
Tom Gundersen [Thu, 15 May 2014 15:43:14 +0000 (17:43 +0200)]
networkd: logging - align messages
Tom Gundersen [Thu, 15 May 2014 13:54:28 +0000 (15:54 +0200)]
networkd: log ifindices when links and netdevs are added
Tom Gundersen [Thu, 15 May 2014 13:48:37 +0000 (15:48 +0200)]
networkd: rename NetDev variable for consistency with Link
Lennart Poettering [Thu, 15 May 2014 15:54:32 +0000 (17:54 +0200)]
sd-bus: make sure we properly handle NULL callback functions
Lennart Poettering [Thu, 15 May 2014 15:48:28 +0000 (17:48 +0200)]
selinux: fix build for non-selinux systems
Lennart Poettering [Thu, 15 May 2014 15:42:39 +0000 (17:42 +0200)]
sd-bus: fix an assert when running in kdbus mode
Lennart Poettering [Thu, 15 May 2014 15:31:14 +0000 (17:31 +0200)]
resolve: fix copy/paste error
Lennart Poettering [Thu, 15 May 2014 15:26:02 +0000 (17:26 +0200)]
sd-bus: don't hit assert when installing match
Lennart Poettering [Thu, 15 May 2014 15:25:46 +0000 (17:25 +0200)]
update TODO
Lennart Poettering [Thu, 15 May 2014 15:08:24 +0000 (17:08 +0200)]
sd-bus: always keep slot reference while dispatching callback
Also, make sure we automatically destroy reply callbacks that are
floating.
Lennart Poettering [Thu, 15 May 2014 14:34:38 +0000 (16:34 +0200)]
sd-resolve: add "floating" resolve queries
Same story as for sd-bus and sd-event: allow passing NULL to store query
in in which case the query is freed automatically.
Lennart Poettering [Wed, 14 May 2014 23:55:18 +0000 (01:55 +0200)]
sd-event: introduce concept of "floating" event sources
These are the counterpart of "floating" bus slots, i.e. event sources
that are bound to the lifetime of the event object itself, and thus
don't require an explicit reference to be kept.
Zbigniew Jędrzejewski-Szmek [Tue, 13 May 2014 21:22:13 +0000 (23:22 +0200)]
core: close socket fds asynchronously
http://lists.freedesktop.org/archives/systemd-devel/2014-April/018928.html
Zbigniew Jędrzejewski-Szmek [Thu, 24 Apr 2014 15:23:38 +0000 (17:23 +0200)]
systemctl: small cleanup
Zbigniew Jędrzejewski-Szmek [Wed, 14 May 2014 13:44:19 +0000 (09:44 -0400)]
readahead: add test to show fs_on_ssd() result
Zbigniew Jędrzejewski-Szmek [Sun, 11 May 2014 12:34:26 +0000 (08:34 -0400)]
networkd, build-sys: spelling fix
Zbigniew Jędrzejewski-Szmek [Fri, 18 Apr 2014 02:12:25 +0000 (22:12 -0400)]
Make sure that keys are properly removed from hashmap
This is a speculative fix for https://bugzilla.redhat.com/show_bug.cgi?id=1088865.
Even though I cannot find a code path that where this would be
an issue, for consistency, if we assume that cgroup_path might have
been set before we got to unit_deserialize, we should make sure that
the unit is removed from the hashmap before we free the key. This seems
to be the only place where the key could be prematurely freed, leading to
hashmap corruption.
Zbigniew Jędrzejewski-Szmek [Fri, 25 Apr 2014 11:45:15 +0000 (07:45 -0400)]
Remove unnecessary casts in printfs
No functional change expected :)
Zbigniew Jędrzejewski-Szmek [Thu, 24 Apr 2014 05:44:10 +0000 (01:44 -0400)]
Make systemctl --root look for files in the proper places
Running systemctl enable/disable/set-default/... with the --root
option under strace reveals that it accessed various files and
directories in the main fs, and not underneath the specified root.
This can lead to correct results only when the layout and
configuration in the container are identical, which often is not the
case. Fix this by adding the specified root to all file access
operations.
This patch does not handle some corner cases: symlinks which point
outside of the specified root might be interpreted differently than
they would be by the kernel if the specified root was the real root.
But systemctl does not create such symlinks by itself, and I think
this is enough of a corner case not to be worth the additional
complexity of reimplementing link chasing in systemd.
Also, simplify the code in a few places and remove an hypothetical
memory leak on error.
Zbigniew Jędrzejewski-Szmek [Mon, 21 Apr 2014 23:17:40 +0000 (19:17 -0400)]
shared/install: do not prefix created symlink with root path
Before: /var/tmp/inst1//etc/systemd/system/default.target -> /var/tmp/inst1//usr/lib/systemd/system/graphical.target
After: /var/tmp/inst1/etc/systemd/system/default.target -> /usr/lib/systemd/system/graphical.target
Eelco Dolstra [Thu, 15 May 2014 11:11:00 +0000 (13:11 +0200)]
Fix typos in systemctl manpage
Kay Sievers [Tue, 13 May 2014 22:34:49 +0000 (00:34 +0200)]
udev: do not skip the execution of RUN when renaming a network device fails
Lennart Poettering [Wed, 14 May 2014 23:15:30 +0000 (01:15 +0200)]
sd-bus: introduce sd_bus_slot objects encapsulating callbacks or vtables attached to a bus connection
This makes callback behaviour more like sd-event or sd-resolve, and
creates proper object for unregistering callbacks.
Taking the refernce to the slot is optional. If not taken life time of
the slot will be bound to the underlying bus object (or in the case of
an async call until the reply has been recieved).
Lennart Poettering [Wed, 14 May 2014 22:44:29 +0000 (00:44 +0200)]
sd-event: reorder header slightly
Lennart Poettering [Wed, 14 May 2014 22:43:44 +0000 (00:43 +0200)]
hashmap: add hashmap_remove2() to remove item from hashtable and return both value and key
Lennart Poettering [Wed, 14 May 2014 20:44:45 +0000 (22:44 +0200)]
core: no need to pass bus object to selinux access check calls anymore
Lennart Poettering [Tue, 6 May 2014 17:15:36 +0000 (19:15 +0200)]
bus: add userdata API for bus name tracker objects
Tom Gundersen [Wed, 14 May 2014 20:03:14 +0000 (22:03 +0200)]
core: sysvcompat - avoid repeated function call
Tom Gundersen [Mon, 12 May 2014 19:26:54 +0000 (21:26 +0200)]
core: sysvcompat - $network should be equivalent to network-online, rather than network target
Most likely the facility needed is actual connectivity, rather than whether or not the
network managment daemon is running.
We also need to explicitly pull in the network-online.target, as it is not active by
default.
This means {systemd-networkd,NetworkManager}-wait-online.service, can be enabled by default
as part of network-online.target, and only delay boot when some service actively pulls it in.
See: <https://bugzilla.gnome.org/show_bug.cgi?id=728965>
Cc: Pavel Šimerda <psimerda@redhat.com>
Cc: Michal Sekletar <msekleta@redhat.com>
David Herrmann [Tue, 13 May 2014 18:08:18 +0000 (20:08 +0200)]
shared: add ring buffer
New "struct ring" object that implements a basic ring buffer for arbitrary
byte-streams. A new basic runtime test is also added.
This will be needed for our pty helpers for systemd-console and friends.
David Herrmann [Tue, 13 May 2014 17:47:58 +0000 (19:47 +0200)]
shared: add ALIGN_POWER2 macro
Sounds easy, turns out to be horrible to implement: ALIGN_POWER2 returns
the next higher power of 2. clz(0) is undefined, same is true for
left-shift-overflows, yey, C rocks!
Lennart Poettering [Tue, 13 May 2014 14:40:53 +0000 (16:40 +0200)]
replace more dup() by F_DUPFD_CLOEXEC
Lennart Poettering [Tue, 13 May 2014 14:35:34 +0000 (16:35 +0200)]
pam_systemd: use F_DUPFD_CLOEXEC when dupping session fds
http://lists.freedesktop.org/archives/systemd-devel/2014-May/019034.html
Tom Gundersen [Tue, 13 May 2014 10:23:14 +0000 (12:23 +0200)]
udev: rename netif - properly break lines in kmsg
Before:
30,997,4553484,-;systemd-udevd[439]: renamed network interface wwan0 to wwp0s20u4i6systemd-udevd[439]: renamed network interface wlan0 to wlp3s0
30,998,
1175077801,c;systemd-udevd[2345]: renamed network interface wwan0 to wwp0s20u4i6
After:
30,834,4553484,-;systemd-udevd[439]: renamed network interface wwan0 to wwp0s20u4i6
30,835,4732949,-;systemd-udevd[439]: renamed network interface wlan0 to wlp3s0
30,988,
1175077801,-;systemd-udevd[2345]: renamed network interface wwan0 to wwp0s20u4i6
Tom Gundersen [Tue, 13 May 2014 07:39:03 +0000 (09:39 +0200)]
timesyncd: start after networkd
This is needed for the network monitor to work (as it requires networkd to set up the correct directories first).
Susant Sahani [Fri, 2 May 2014 17:59:56 +0000 (23:29 +0530)]
networkd-ipip-tunnel: add support ttl
Add support for ipip tunnel ttl.
Susant Sahani [Thu, 1 May 2014 10:46:55 +0000 (16:16 +0530)]
networkd: Add todo patch kernel for tunnel module alias
Add to todo :
1. Patch kernel to support module alias for tunnel device
2. Remove libkmod dependency from networkd
Tom Gundersen [Mon, 12 May 2014 15:11:13 +0000 (17:11 +0200)]
networkd: manager - don't leak kmod context
Also, keep the kmod_new internal to networkd-manager.c
Tom Gundersen [Mon, 12 May 2014 15:37:52 +0000 (17:37 +0200)]
networkd: unit - add cap to load modules
Remember to drop this when the kernel gains autoloading for all netdev kinds.
Susant Sahani [Mon, 12 May 2014 05:18:24 +0000 (10:48 +0530)]
networkd: introduce ipip tunnel
This patch enables basic ipip tunnel support.
It works with kernel module ipip
example conf:
file: ipip.netdev
[NetDev]
Name=ipip-tun
Kind=ipip
MTUBytes=1480
[Tunnel]
Local=192.168.223.238
Remote=192.169.224.239
TTL=64
file: ipip.network
[Match]
Name=em1
[Network]
Tunnel=ipip-tun
[tomegun:
- drop unused variable
- take ref when enslaving]
Michael Marineau [Mon, 12 May 2014 07:26:16 +0000 (09:26 +0200)]
job: always add waiting jobs to run queue during coldplug
commit
20a83d7bf was not equivalent to the original bug fix proposed by
Michal Sekletar <msekleta@redhat.com>. The committed version only added
the job to the run queue if the job had a timeout, which most jobs do
not have. Just re-ordering the code gets us the intended functionality
Tom Gundersen [Sun, 11 May 2014 11:58:18 +0000 (13:58 +0200)]
networkd: get preexiting addresses when a link is added
Tom Gundersen [Sat, 10 May 2014 17:39:03 +0000 (19:39 +0200)]
networkd: listen for address changes
This is proof-of-concept only, as we only log the changes but don't do anything
with it.
Tom Gundersen [Sat, 10 May 2014 18:16:10 +0000 (20:16 +0200)]
rtnl: message - fix check for broadcast messages
Tom Gundersen [Sat, 10 May 2014 18:15:52 +0000 (20:15 +0200)]
rtnl: message - read group membership of incoming messages
Tom Gundersen [Sat, 10 May 2014 17:55:00 +0000 (19:55 +0200)]
rtnl: message - verify that we read the pending message size from the kernel
Reuse the auth-checking for both the peek and the real read.
Tom Gundersen [Sat, 10 May 2014 17:40:11 +0000 (19:40 +0200)]
rtnl: message - move code around
No functional change.
Tom Gundersen [Sat, 10 May 2014 17:38:32 +0000 (19:38 +0200)]
rtnl: change from bitmask to enum for rtnl groups
The bitmask is deprecated in the kernel, so move to the new interface. At the moment
this does not make a difference for us, but it avoids having to change the API in the future.
Tom Gundersen [Sat, 10 May 2014 14:08:03 +0000 (16:08 +0200)]
networkd: link - redo flag change logging
Make the logging less verbose by only printing all the changed flags on one line,
at the same time make it more complete by supporting all flags currently supported
by the kernel.
We still fall back to printing the raw flags in case we get something we do not recognize
This may be useful when running on new kernels.
Tom Gundersen [Sat, 10 May 2014 14:06:23 +0000 (16:06 +0200)]
sd-rtnl: message - add support for getting prefixlen from address messages
Tom Gundersen [Fri, 9 May 2014 16:05:42 +0000 (18:05 +0200)]
networkd: network - fix leak
Tom Gundersen [Fri, 9 May 2014 16:02:14 +0000 (18:02 +0200)]
networkd: manager - initialize variables
Tom Gundersen [Fri, 9 May 2014 16:00:20 +0000 (18:00 +0200)]
networkd: netdev - rephrase logging message a bit
Make it fit with what is logged from the link.
Tom Gundersen [Fri, 9 May 2014 15:59:20 +0000 (17:59 +0200)]
networkd: manager - refactor link tracking a bit
Zbigniew Jędrzejewski-Szmek [Sat, 10 May 2014 01:44:25 +0000 (03:44 +0200)]
systemctl: return an error code is status fails
This got lost in the refactoring in
f74294c1dabb4.
Also make sure that the return code corresponds to the *first* failure,
not the last.
https://lists.fedoraproject.org/pipermail/devel/2014-May/199080.html
Tom Gundersen [Fri, 9 May 2014 12:23:17 +0000 (14:23 +0200)]
networkd: link - don't log errors when missing routes/addresses are dropped
We were ignoring the wrong errno.
Tom Gundersen [Fri, 9 May 2014 10:11:15 +0000 (12:11 +0200)]
networkd: link - handle links coming back to life
When enslaving devices, we may receieve DELLINK/NEWLINK for the same ifindex,
let's not be confused by this.
Tom Gundersen [Fri, 9 May 2014 10:20:21 +0000 (12:20 +0200)]
networkd: reorder bonding and bridging
A link should only ever be part of one, but if we accidentally do both, let's do it
in the right order so the failure is more obvious in the logs.
Tom Gundersen [Thu, 8 May 2014 22:26:22 +0000 (00:26 +0200)]
sd-dhcp-client: improve logging when stopping client
'Requested by user' was confusing, just drop it.
Tom Gundersen [Thu, 8 May 2014 16:55:11 +0000 (18:55 +0200)]
networkd: manager - drop links and netdevs when we receive DELLINK
Tom Gundersen [Thu, 8 May 2014 19:08:12 +0000 (21:08 +0200)]
networkd: netdev - drop if creation fails
This ensures that all links waiting to be enslaved are notified that the netdev does not exist.
Tom Gundersen [Thu, 8 May 2014 18:50:05 +0000 (20:50 +0200)]
networkd: link - introduce LINGER state and link_drop()
We need the LINGER state in case we still have references to the link after it has been dropped.
Tom Gundersen [Thu, 8 May 2014 18:42:22 +0000 (20:42 +0200)]
networkd: netdev - introduce LINGER state and netdev_drop()
We need the LINGER state in case we still have references to the netdev after it has been dropped.
Tom Gundersen [Thu, 8 May 2014 18:40:56 +0000 (20:40 +0200)]
networkd: netdev - cancel all callbacks when freeing
This notifies the link that the netdev no longer exists.
Tom Gundersen [Thu, 8 May 2014 17:46:06 +0000 (19:46 +0200)]
networkd: link - take refcounts on links
We need to take a refcount on the link whenever we expect a callback. The exceptions
are the ipv4ll/dhcp clients as their lifetimes are guaranteed to be shorter than that
of the link.
Tom Gundersen [Thu, 8 May 2014 17:28:17 +0000 (19:28 +0200)]
networkd: network - do reference counting on netdevs
Tom Gundersen [Thu, 8 May 2014 17:22:53 +0000 (19:22 +0200)]
networkd: network - merge all netdev parsing into one function
Tom Gundersen [Thu, 8 May 2014 16:54:26 +0000 (18:54 +0200)]
networkd: introduce refcounting for Links and NetDevs
Tom Gundersen [Thu, 8 May 2014 16:53:32 +0000 (18:53 +0200)]
networkd: link - clean up state files
Also keep the path to the lease file around rather than regenarating it all the time.
Zbigniew Jędrzejewski-Szmek [Fri, 9 May 2014 12:39:25 +0000 (08:39 -0400)]
man: sd_journal_send does nothing when journald is not available
https://bugzilla.redhat.com/show_bug.cgi?id=1096067
Tom Gundersen [Thu, 8 May 2014 15:32:32 +0000 (17:32 +0200)]
timesyncd: read global operational state from networkd
Tom Gundersen [Thu, 8 May 2014 15:21:37 +0000 (17:21 +0200)]
sd-network: expose global operational state
Tom Gundersen [Wed, 7 May 2014 13:26:47 +0000 (15:26 +0200)]
timesyncd: only run when the system has a carrier on a network interface
As the operational state detection in sd-network is still too primitive, timesyncd
will likely try to connect a bit early, so the first attempt will fail.
Tom Gundersen [Thu, 8 May 2014 11:14:42 +0000 (13:14 +0200)]
networkd-wait-online: flush monitor events after processing
Otherwise the event will trigger immediately again.
Tom Gundersen [Thu, 8 May 2014 11:11:23 +0000 (13:11 +0200)]
networkd-wait-online: fix false positives when checking if a link is managed by networkd
Tom Gundersen [Thu, 8 May 2014 10:32:11 +0000 (12:32 +0200)]
networkd: link - operstate is an enum, not a bitmask
Łukasz Stelmach [Thu, 8 May 2014 10:57:26 +0000 (12:57 +0200)]
core: check the right variable for failed open()
Jan Engelhardt [Wed, 7 May 2014 23:28:46 +0000 (01:28 +0200)]
doc: balance C indirections in function prototypes
Shift the asterisks in the documentation's prototypes such that they
are consistent among each other. Use the right side to match what is
used in source code.
Addendum to commit v209~82.
Jan Engelhardt [Wed, 7 May 2014 23:28:47 +0000 (01:28 +0200)]
doc: write out stdin/stdout file descriptors
"When refering to code, STDOUT/STDOUT/STDERR are replaced with
stdin/stdout/stderr, and in other places they are replaced with
normal phrases like standard output, etc."
Addendum to commit v209~127.
Jan Engelhardt [Wed, 7 May 2014 23:28:45 +0000 (01:28 +0200)]
doc: comma placement corrections and word order
Set commas where there should be some.
Some improvements to word order.
Jan Engelhardt [Wed, 7 May 2014 23:28:44 +0000 (01:28 +0200)]
doc: corrections to words and forms
This patch exchange words which are inappropriate for a situation,
deletes duplicated words, and adds particles where needed.