platform/upstream/coreclr.git
6 years agoAdd support for large number of argumets in CCW call on Arm64 (#20670)
David Wrighton [Wed, 31 Oct 2018 01:05:39 +0000 (18:05 -0700)]
Add support for large number of argumets in CCW call on Arm64 (#20670)

* Fix CCW with large numbers of arguments on arm64
- Correctly align the stack in COMToCLRDispatchHelper
- Add tests for naturally 16 byte aligned stack growth, and non-aligned growth
* New many arguments COM test
* Add support for the IL stub ETW diagnostic event

6 years agoMerge pull request #20703 from MattGal/bsd-pipebuild-tweaks
Matt Galbraith [Tue, 30 Oct 2018 23:06:29 +0000 (16:06 -0700)]
Merge pull request #20703 from MattGal/bsd-pipebuild-tweaks

Remove DotNetBootstrapCliTarPath from variables

6 years agoFix printing in `CodeGen::siEndScope`. (#20698)
Sergey Andreenko [Tue, 30 Oct 2018 23:04:24 +0000 (16:04 -0700)]
Fix printing in `CodeGen::siEndScope`. (#20698)

6 years agoFixed small typo in a comment (#20695)
lastsannin [Tue, 30 Oct 2018 23:03:00 +0000 (00:03 +0100)]
Fixed small typo in a comment (#20695)

fixed a simple typo, "co-" should contain a dash in this case.

6 years agofix detection for LLDB.h and make sos mandatory on FreeBSD (#20551)
Tomas Weinfurt [Tue, 30 Oct 2018 23:01:16 +0000 (16:01 -0700)]
fix detection for LLDB.h and make sos mandatory on FreeBSD (#20551)

* fix detection for LLDB.h and make sos mandatory on FreeBSD

* feedback from review

* feedback from review

* add llvm40 as well for completness

* fix OR condition

6 years agoRemove DotNetBootstrapCliTarPath from variables as it was getting forcibly upper...
Matt Galbraith [Tue, 30 Oct 2018 22:58:38 +0000 (15:58 -0700)]
Remove DotNetBootstrapCliTarPath from variables as it was getting forcibly upper-cased, making it useless. Instead, use the workaround of setting it explicitly before sync.sh.

6 years agoMerge pull request #20699 from MattGal/bsd-pipebuild-tweaks
Matt Galbraith [Tue, 30 Oct 2018 22:03:33 +0000 (15:03 -0700)]
Merge pull request #20699 from MattGal/bsd-pipebuild-tweaks

Add FreeBSD to official build pipelines

6 years agoadd -portablebuild=false to build.sh (affects naming)
Matt Galbraith [Tue, 30 Oct 2018 20:57:08 +0000 (13:57 -0700)]
add -portablebuild=false to build.sh (affects naming)

6 years agoFix `JitStressRegs=0x1` issue with `RefTypeUpperVectorSaveDef`. (#20623)
Sergey Andreenko [Tue, 30 Oct 2018 20:38:50 +0000 (13:38 -0700)]
Fix `JitStressRegs=0x1` issue with `RefTypeUpperVectorSaveDef`. (#20623)

* Add a repro test.

* Fix the issue.

* Add comments

6 years agoFixing build.sh args
Matt Galbraith [Tue, 30 Oct 2018 20:21:08 +0000 (13:21 -0700)]
Fixing build.sh args

6 years agoAdd freebsd flavor to CoreCLR pipebuild
Matt Galbraith [Tue, 30 Oct 2018 17:47:13 +0000 (10:47 -0700)]
Add freebsd flavor to CoreCLR pipebuild

6 years agoJIT: Fix call flag propagation for GenTreeArrElem (#20660)
Andy Ayers [Tue, 30 Oct 2018 18:24:37 +0000 (11:24 -0700)]
JIT: Fix call flag propagation for GenTreeArrElem (#20660)

Closes #20651.

Also fix up some "near miss" cases for GenTreeField and GenTreeBoundsCheck,
where we get lucky and the importer currently splits trees with temps so the
currently ignored child nodes have no interesting side effects.

Revise GenTreeField a bit to pull more of the initialization work into the
constructor. Add a missing R2R field propagation for field nodes in GtClone
(evidently also never hit in practice).

6 years agoMerge pull request #20641 from briansull/vso_707552
Brian Sullivan [Tue, 30 Oct 2018 17:03:16 +0000 (10:03 -0700)]
Merge pull request #20641 from briansull/vso_707552

Fix VSO 707552

6 years agoAdd the execution policy when running powershell in size on disk benchmarks (#20680)
Michelle McDaniel [Tue, 30 Oct 2018 16:51:40 +0000 (09:51 -0700)]
Add the execution policy when running powershell in size on disk benchmarks (#20680)

Since moving to the helix queue, we have been failing because the execution policy on the vms is not set to unrestricted. To get around this, we need to explicitly pass -ExecutionPolicy Bypass.

6 years agoDisable failing on Windows/ARM Interop/COM tests (#20675)
Egor Chesakov [Tue, 30 Oct 2018 15:30:15 +0000 (08:30 -0700)]
Disable failing on Windows/ARM Interop/COM tests (#20675)

* Interop/COM/NETClients/Primitives/NETClientPrimitives
* Interop/COM/NativeClients/Primitives
* Interop/COM/NETClients/IDispatch/NETClientIDispatch
* Interop/COM/NETClients/Aggregation/NETClientAggregation

6 years agoCorrected Typos and grammar (#20658)
Shreyas Jejurkar [Tue, 30 Oct 2018 15:05:58 +0000 (08:05 -0700)]
Corrected Typos and grammar (#20658)

* Corrected some typos and grammar as per English language guidelines.

* Reverted some of the changes

* Reverted back some changes Phase 2

6 years agoRemove unnecessary Pack directive to fix build break (#20681)
dotnet-maestro-bot [Tue, 30 Oct 2018 12:18:38 +0000 (05:18 -0700)]
Remove unnecessary Pack directive to fix build break (#20681)

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
6 years agoMerge pull request #20679 from BruceForstall/DumpTempReason
Bruce Forstall [Tue, 30 Oct 2018 06:57:11 +0000 (23:57 -0700)]
Merge pull request #20679 from BruceForstall/DumpTempReason

Dump the "reason" for a compiler temp

6 years agoDump the "reason" for a compiler temp
Bruce Forstall [Mon, 29 Oct 2018 21:49:26 +0000 (14:49 -0700)]
Dump the "reason" for a compiler temp

Compiler temps are created with a "reason" that is dumped in JitDump.
Save the reason and display it in the local variable table dump.
This is useful when trying to find a particular temp and see what
code has been generated using it.

6 years agoJIT: streamline temp usage for returns (#20640)
Andy Ayers [Mon, 29 Oct 2018 23:11:53 +0000 (16:11 -0700)]
JIT: streamline temp usage for returns (#20640)

If the jit decides it needs a return spill temp, and the return value
has already been spilled to a single-def temp, re-use the existing
for the return temp rather than creating a new one.

In conjunction with #20553 this allows late devirtualization for calls where
the object in the virtual call is the result of an inline that provides
a better type, and the objected formerly reached the call via one or more
intermediate temps.

Closes #15873.

6 years agoFix VSO 707552
Brian Sullivan [Fri, 26 Oct 2018 22:07:21 +0000 (15:07 -0700)]
Fix VSO 707552
[RyuJIT][ilgen] Assertion failed 'exp->gtOper != GT_COUNT'
Use nullptr instead of NULL

6 years agoRemove outdated GC perf test framework (#20673)
Sung Yoon Whang [Mon, 29 Oct 2018 22:04:56 +0000 (15:04 -0700)]
Remove outdated GC perf test framework (#20673)

6 years agoSome cleanup of the System.Number class (#20619)
Tanner Gooding [Mon, 29 Oct 2018 18:15:35 +0000 (11:15 -0700)]
Some cleanup of the System.Number class (#20619)

* Formatting Number.Formatting.cs and Number.Parsing.cs

* Removing some duplicated parsing code by having the Parse method call TryParse

* Moving two constants from NumberBuffer to Dragon4

* Rename FloatPrecision to SinglePrecision

* Updating the casing of the NumberBuffer fields

* Updating NumberBuffer to allow taking a custom-sized digit buffer.

* Updating the various NumberBufferLength constants to be the exact needed lengths

* Fixing DoubleNumberBufferLength and SingleNumberBufferLength to account for the rounding digit.

* Fixing TryParseNumber to use the correct maxDigCount

* Ensure the TryParseSingle out result is assigned on success

6 years agoFix typo in linux-performance-tracing (#20667)
Jesús Corrius [Mon, 29 Oct 2018 16:45:43 +0000 (17:45 +0100)]
Fix typo in linux-performance-tracing (#20667)

precomppiled -> precompiled

6 years agoUnhelpful error when Activator.CreateInstance can't find default constructor (#20491)
Andrew Au [Mon, 29 Oct 2018 16:09:48 +0000 (09:09 -0700)]
Unhelpful error when Activator.CreateInstance can't find default constructor  (#20491)

6 years agoUpdate CoreClr, CoreSetup, IbcData, PgoData to preview1-27028-04, preview1-27029...
dotnet-maestro-bot [Mon, 29 Oct 2018 12:55:12 +0000 (05:55 -0700)]
Update CoreClr, CoreSetup, IbcData, PgoData to preview1-27028-04, preview1-27029-01, master-20181029-0053, master-20181029-0054, respectively (#20662)

6 years agoUpdate CoreClr, CoreSetup, IbcData, PgoData to preview1-27028-03, preview1-27028...
dotnet-maestro-bot [Sun, 28 Oct 2018 15:46:44 +0000 (08:46 -0700)]
Update CoreClr, CoreSetup, IbcData, PgoData to preview1-27028-03, preview1-27028-01, master-20181028-0058, master-20181028-0055, respectively (#20653)

6 years agoDelete redundant CoreMangLib decimal tests (#20649)
Jan Kotas [Sat, 27 Oct 2018 17:25:09 +0000 (10:25 -0700)]
Delete redundant CoreMangLib decimal tests (#20649)

Fixes failing test obsoleted by #20638 and contributes to #12782

Delete redundant CoreMangLib decimal tests  \85

6 years agoUpdate BuildTools, CoreClr, CoreSetup, IbcData, PgoData to preview1-03326-01, preview...
dotnet-maestro-bot [Sat, 27 Oct 2018 10:33:24 +0000 (03:33 -0700)]
Update BuildTools, CoreClr, CoreSetup, IbcData, PgoData to preview1-03326-01, preview1-27027-01, preview1-27027-01, master-20181027-0055, master-20181027-0036, respectively (#20559)

6 years agoAdd IAsyncDisposable implementation to Timer (#20646)
Stephen Toub [Sat, 27 Oct 2018 05:19:45 +0000 (22:19 -0700)]
Add IAsyncDisposable implementation to Timer (#20646)

6 years agoImplement IAsyncDisposable on CancellationTokenRegistration (#20645)
Stephen Toub [Sat, 27 Oct 2018 04:19:05 +0000 (21:19 -0700)]
Implement IAsyncDisposable on CancellationTokenRegistration (#20645)

6 years agoRemove dead RESOURCE_SATELLITE_CONFIG (#20639)
Steve MacLean [Sat, 27 Oct 2018 02:57:42 +0000 (22:57 -0400)]
Remove dead RESOURCE_SATELLITE_CONFIG (#20639)

6 years agoMerge pull request #20621 from AaronRobinsonMSFT/block_tests_WindowsNano
Aaron Robinson [Fri, 26 Oct 2018 22:28:51 +0000 (15:28 -0700)]
Merge pull request #20621 from AaronRobinsonMSFT/block_tests_WindowsNano

Add a run time check for Windows.Nano to all COM related tests.

6 years agoAllow ArrayPool.Shared devirtualization (redux) (#20637)
Ben Adams [Fri, 26 Oct 2018 21:12:13 +0000 (22:12 +0100)]
Allow ArrayPool.Shared devirtualization (redux) (#20637)

6 years agoNew Decimal.Remainder implementation (#20305)
Pent Ploompuu [Fri, 26 Oct 2018 19:04:18 +0000 (22:04 +0300)]
New Decimal.Remainder implementation (#20305)

* New Decimal.Remainder implementation

* Update CoreFX.issues.json

6 years agoImplement interface dispatch to COM for ARM64 (#20618)
David Wrighton [Fri, 26 Oct 2018 18:30:55 +0000 (11:30 -0700)]
Implement interface dispatch to COM for ARM64 (#20618)

* Implement interface dispatch to COM for ARM64
- Implement missing stub (GenericComPlusCallStub)

* Re-enable IDispatch test for Arm64 (Fix issue #20580 )

6 years agoJIT: refactor how we do late devirtualization (#20553)
Andy Ayers [Fri, 26 Oct 2018 17:55:06 +0000 (10:55 -0700)]
JIT: refactor how we do late devirtualization (#20553)

Change late devirtualization to run in a postorder callback during
the tree search to update GT_RET_EXPRs, instead of shoehorning it into
the preorder callback.

This allows the jit to reconsider all calls for late devirtualization,
not just calls that are parents of particular GT_RET_EXPRs. The jit will
take advantage of this in subsequent work that does more aggressive
bottup-up type sharpening.

Reconsidering all calls for late devirt instead of just a select subset
incurs around a 0.5% throughput impact.

To mitigate this, short-circult the tree walk when we no longer see a
GTF_CALL flag. This prevents us from walking through CALL and RET_EXPR
free subtrees.

To make this work we have to make sure all node types propagate flags from
their children. This required some updates to a few node constructors.

There is also an odd quirk in the preorder callback where it may overwrite
the parent node (from GT_ASG to GT_BLK or GT_NOP). If the overwrite creates
a GT_NOP, the postorder callback may see a null tree. Tolerate this for now
by checking for that case in the postorder callback.

Also take advantage of `gtRetExprVal` to tunnel through GT_RET_EXPR chains
to the final tree to avoid needing multiple overwrites when propagating
the return expression back into the IR.

With these mitigations this change has minimal throughput impact.

6 years agofixes to build properly on FreeBSD (#20588)
Tomas Weinfurt [Fri, 26 Oct 2018 16:37:37 +0000 (09:37 -0700)]
fixes to build properly on FreeBSD (#20588)

* fixes to build properly on FreeBSD

* remove ulimit from freebsd branch

6 years agoAdd missing include guard in header file. (#20635)
Austin Wise [Fri, 26 Oct 2018 16:35:45 +0000 (09:35 -0700)]
Add missing include guard in header file. (#20635)

6 years agoRemove some dead code related to cross-appdomain exceptions. (#20634)
Austin Wise [Fri, 26 Oct 2018 16:35:09 +0000 (09:35 -0700)]
Remove some dead code related to cross-appdomain exceptions. (#20634)

6 years agoMerge pull request #20628 from stephentoub/asyncinterfaces
Stephen Toub [Fri, 26 Oct 2018 15:26:10 +0000 (08:26 -0700)]
Merge pull request #20628 from stephentoub/asyncinterfaces

Add interfaces/helper types for async iterators

6 years agoWorking towards clean-up comments /**/ in cs (#20609)
Rafael [Fri, 26 Oct 2018 07:34:32 +0000 (00:34 -0700)]
Working towards clean-up comments /**/ in cs (#20609)

* Working towards cleaning comments /**/

Cleaningup /**/ style comments - Following https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/xmldoc/recommended-tags-for-documentation-comments

#20330

* Updating tags

-Updating some <sumary> to <remarks>
-Adding missing tags

* Fixing PR comments

-Comment does not belong to the public description

* Hiding comment from public description.

* Update //***** to the prevalent // style.

6 years agoOptimize FormattingHelpers.CountHexDigits using Lzcnt.LeadingZeroCount (#19006)
Egor Bogatov [Fri, 26 Oct 2018 06:07:08 +0000 (09:07 +0300)]
Optimize FormattingHelpers.CountHexDigits using Lzcnt.LeadingZeroCount (#19006)

* Optimize CountHexDigits using Lzcnt

* shift bits instead

* use Lzcnt only on 64 bit

* Optimize Buffer.Utilities.SelectBucketIndex()

* #if HAS_INTRINSICS

* remove HAS_INTRINSICS

* remove HAS_INTRINSICS

6 years agoAdd ConfigureAwait extension method for IAsyncEnumerable
Stephen Toub [Fri, 26 Oct 2018 04:19:26 +0000 (21:19 -0700)]
Add ConfigureAwait extension method for IAsyncEnumerable

6 years agoAdd ManualResetValueTaskSourceCore
Stephen Toub [Thu, 18 Oct 2018 00:50:05 +0000 (20:50 -0400)]
Add ManualResetValueTaskSourceCore

6 years agoAdd AsyncIteratorMethodBuilder
Stephen Toub [Tue, 16 Oct 2018 02:00:16 +0000 (22:00 -0400)]
Add AsyncIteratorMethodBuilder

6 years agoAdd IAsyncEnumerable and IAsyncEnumerator
Stephen Toub [Tue, 16 Oct 2018 01:21:08 +0000 (21:21 -0400)]
Add IAsyncEnumerable and IAsyncEnumerator

6 years agoAdd IAsyncDisposable
Stephen Toub [Tue, 16 Oct 2018 01:18:18 +0000 (21:18 -0400)]
Add IAsyncDisposable

6 years agoMerge pull request #20579 from fiigii/broadcast
Carol Eidt [Fri, 26 Oct 2018 03:02:37 +0000 (03:02 +0000)]
Merge pull request #20579 from fiigii/broadcast

 Implement AVX2.BroadcastScalarToVector128/256

6 years agoMerge pull request #20611 from BruceForstall/DisableB152292
Bruce Forstall [Fri, 26 Oct 2018 00:34:42 +0000 (17:34 -0700)]
Merge pull request #20611 from BruceForstall/DisableB152292

Disable b152292 for arm32 also

6 years agoAdd a runtime check for Windows.Nano to all COM related tests.
Aaron Robinson [Fri, 26 Oct 2018 00:05:53 +0000 (17:05 -0700)]
Add a runtime check for Windows.Nano to all COM related tests.

6 years agoMerge pull request #20527 from BruceForstall/FixPspSymMove
Bruce Forstall [Thu, 25 Oct 2018 23:25:41 +0000 (16:25 -0700)]
Merge pull request #20527 from BruceForstall/FixPspSymMove

Stop attempting to move PSPSym during localloc for arm32/arm64

6 years agoStop attempting to move PSPSym during localloc for arm32/arm64
Bruce Forstall [Mon, 22 Oct 2018 23:13:07 +0000 (16:13 -0700)]
Stop attempting to move PSPSym during localloc for arm32/arm64

For arm64, this was creating a data corruption possibility, as the
calculations were done wrong.

In neither case was it necessary, as in the main function we always
access the PSPSym FP-relative, so when writing back the PSPSym, we
were always writing to exactly the same slot; nothing was actually
moving.

I can't recall or figure out why we were moving it in the first place,
or what might have changed.

Added a new variant of the localloc eh tests that has outgoing arguments,
to exercise the case where we need to re-establish the outgoing argument
space after the localloc.

6 years agoMerge pull request #20617 from AaronRobinsonMSFT/windows_nano_detection
Aaron Robinson [Thu, 25 Oct 2018 21:47:59 +0000 (14:47 -0700)]
Merge pull request #20617 from AaronRobinsonMSFT/windows_nano_detection

Add support for tests to detect Windows Nano at runtime.

6 years agoDisable b152292 for arm32 also
Bruce Forstall [Thu, 25 Oct 2018 16:40:47 +0000 (09:40 -0700)]
Disable b152292 for arm32 also

6 years agoAdd DumpDelegate sos command (#20591)
Stephen Toub [Thu, 25 Oct 2018 20:01:56 +0000 (13:01 -0700)]
Add DumpDelegate sos command (#20591)

* Add DumpDelegate sos command

Finding out what method a delegate points to today with SOS is tedious.  This PR adds a DumpDelegate command that simplifies it: give it the delegate address, and it outputs a line for each delegate that makes up the input delegate, where each line includes the target object, the method descriptor, and a friendly name.

* Address PR feedback

And fix some warnings that were showing up in CI but not locally.

6 years agoAdd support for tests to detect Windows Nano at runtime.
Aaron Robinson [Thu, 25 Oct 2018 20:01:40 +0000 (13:01 -0700)]
Add support for tests to detect Windows Nano at runtime.

6 years agoRemove debug-only file writers. (#20612)
Brian Robbins [Thu, 25 Oct 2018 19:58:56 +0000 (12:58 -0700)]
Remove debug-only file writers. (#20612)

6 years agoAdd test cases for AVX2.BroadcastScalarToVector128/256 and move Avx.Broadcast* tests...
Fei Peng [Wed, 24 Oct 2018 19:27:58 +0000 (12:27 -0700)]
Add test cases for AVX2.BroadcastScalarToVector128/256 and move Avx.Broadcast* tests to the template

6 years agoImplement AVX2.BroadcastScalarToVector128/256
Fei Peng [Wed, 24 Oct 2018 19:27:31 +0000 (12:27 -0700)]
Implement AVX2.BroadcastScalarToVector128/256

6 years agoMerge pull request #20614 from AaronRobinsonMSFT/coreclr/20601
Aaron Robinson [Thu, 25 Oct 2018 17:36:30 +0000 (10:36 -0700)]
Merge pull request #20614 from AaronRobinsonMSFT/coreclr/20601

Disable `IDispatch` test on Windows.Nano

Skipping CI verification since this is a non-code change and only impacts nightly runs.

6 years agoDisable IDispatch test on Windows.Nano
Aaron Robinson [Thu, 25 Oct 2018 17:34:26 +0000 (10:34 -0700)]
Disable IDispatch test on Windows.Nano

6 years agoDisable ExecuteInDefaultAppDomain test on *nix
Steve MacLean [Tue, 23 Oct 2018 17:29:16 +0000 (13:29 -0400)]
Disable ExecuteInDefaultAppDomain test on *nix

6 years agoExecInDefAppDom add InjectCode test
Steve MacLean [Tue, 23 Oct 2018 19:35:36 +0000 (15:35 -0400)]
ExecInDefAppDom add InjectCode test

6 years agoAdd test for ICLRRuntimeHost::ExecuteInDefaultAppDomain
Steve MacLean [Fri, 12 Oct 2018 19:10:06 +0000 (15:10 -0400)]
Add test for ICLRRuntimeHost::ExecuteInDefaultAppDomain

6 years agoAdd IID_ICLRRuntimeHost QueryInterface support
Steve MacLean [Sat, 13 Oct 2018 02:30:55 +0000 (22:30 -0400)]
Add IID_ICLRRuntimeHost QueryInterface support

6 years agoRestore ExecuteInDefaultAppDomain implementation
Steve MacLean [Wed, 10 Oct 2018 16:50:30 +0000 (12:50 -0400)]
Restore ExecuteInDefaultAppDomain implementation

Restore deleted ExecuteInDefaultAppDomain implentation
Enable for CoreCLR
Cleanup for CoreCLR

6 years agoAdd EventPipe Config File Option MultiFileSec (#20548)
Brian Robbins [Thu, 25 Oct 2018 16:47:48 +0000 (09:47 -0700)]
Add EventPipe Config File Option MultiFileSec (#20548)

6 years agoAvoid comparing capacity in StringBuilder.Equals (#20567)
Petr Onderka [Thu, 25 Oct 2018 16:21:41 +0000 (18:21 +0200)]
Avoid comparing capacity in StringBuilder.Equals (#20567)

* Avoid comparing capacity in StringBuilder.Equals

* Disabled corefx StringBuilder test

6 years agoFallback to old behavior when marshaling a non-blittable fixed buffer (#20575)
Jeremy Koritzinsky [Thu, 25 Oct 2018 15:40:15 +0000 (08:40 -0700)]
Fallback to old behavior when marshaling a non-blittable fixed buffer (#20575)

* Throw an exception only when attempting to marshal nonblittable fixed buffers to/from native instead of on all marshalling operations.

* Assert in debug and checked builds when trying to marshal a fixed buffer of a non-blittable type.

6 years agoJIT: ensure float folding is done using float precision (#20578)
Andy Ayers [Thu, 25 Oct 2018 15:17:49 +0000 (08:17 -0700)]
JIT: ensure float folding is done using float precision (#20578)

Cast float folded values back to float before assigning to the double
the jit uses for storing FP literal constants.

Fixes #20561.

No diffs on Core; exposing the original bug requires building RyuJit with
an older x86 C++ compiler that uses x87 floating point.

6 years agoFix comment Style (#20604)
Thomas Schreiner [Thu, 25 Oct 2018 15:14:18 +0000 (17:14 +0200)]
Fix comment Style (#20604)

6 years agoUse IThreadPoolWorkItem in ConcurrentExclusiveSchedulerPair (#20513)
Stephen Toub [Thu, 25 Oct 2018 15:03:37 +0000 (08:03 -0700)]
Use IThreadPoolWorkItem in ConcurrentExclusiveSchedulerPair (#20513)

ConcurrentExclusiveSchedulerPair exposes two TaskSchedulers, one for concurrent processing and one for exclusive processing, such that any tasks scheduled are executed in a corresponding fashion.  CESP does that by itself scheduling workers to an underlying scheduler, and those workers in turn process the queued tasks.  Today this always queues those workers as Tasks, but if the underlying scheduler is TaskScheduler.Default (aka the thread pool), we can avoid per-worker allocations by using the new UnsafeQueueUserWorkItem overload that takes an IThreadPoolWorkItem, and just queueing the same worker object over and over and over.

6 years agoJIT: emit debug info for locals for minopts/tier0 (#20466)
Andy Ayers [Thu, 25 Oct 2018 15:02:24 +0000 (08:02 -0700)]
JIT: emit debug info for locals for minopts/tier0 (#20466)

The jit no longer tracks locals when running at minopts. But untracked
local debug emission was tied to `cmpDebugCode. Change untracked local
debug emission to instead check if there are no tracked locals.

Fixes #20421.

Note we could improve things further in the case where there is a mixture
of tracked and untracked locals. I have opened #20465 for that as my first
attempts here had that ambition but ran into problems.

6 years agoAvoid implicit long casts in uint compares (#20511)
Ben Adams [Thu, 25 Oct 2018 05:34:10 +0000 (06:34 +0100)]
Avoid implicit long casts in uint compares (#20511)

6 years agoAvoid having DateTime.TryParse throwing (#20587)
Tarek Mahmoud Sayed [Thu, 25 Oct 2018 05:19:17 +0000 (22:19 -0700)]
Avoid having DateTime.TryParse throwing (#20587)

* Avoid having DateTime.TryParse throwing

There are some cases during the parsing which will require adding ticks to the DateTime object we are creating during the parsing.
DateTime.AddTicks can throw which will make DateTime.TryParse fail with throwing instead of just returning false.

The fix here is to avoid throwing in the first place and let DateTime.TryParse return false on such failures.

* Remove the invalid link

6 years agoAdd IsCollectible property to Assembly and necessary backing functions (#20574)
John Salem [Thu, 25 Oct 2018 03:29:40 +0000 (20:29 -0700)]
Add IsCollectible property to Assembly and necessary backing functions (#20574)

6 years agoGet the real update for Unicode 11 data (#20589)
Tarek Mahmoud Sayed [Thu, 25 Oct 2018 03:04:43 +0000 (20:04 -0700)]
Get the real update for Unicode 11 data (#20589)

In the PR #20529 we have used the old existing data when we moved the file CharunicodeInfoData.cs to shared folder.
This change is to restore the actual updated file.

6 years agoExclude IDispatch test for Windows Arm64 (#20584)
Andy Ayers [Thu, 25 Oct 2018 02:32:43 +0000 (19:32 -0700)]
Exclude IDispatch test for Windows Arm64 (#20584)

Disable for now while failures are investigated. See #20580.

6 years agoRemove support for nonexistent UnmanagedFunctionPointerAttribute.PreserveSig. (#20396)
Jeremy Koritzinsky [Wed, 24 Oct 2018 22:56:33 +0000 (15:56 -0700)]
Remove support for nonexistent UnmanagedFunctionPointerAttribute.PreserveSig. (#20396)

UnmanagedFunctionPointer doesn't have a PreserveSig attribute on framework or core, so remove the unused, confusing, and inaccurate support from the runtime.

6 years agoRun IBCMerge step for Linux on Windows (#20496)
Michelle McDaniel [Wed, 24 Oct 2018 20:53:42 +0000 (13:53 -0700)]
Run IBCMerge step for Linux on Windows (#20496)

This change does the following:

* Move the IBCOptimize step out of the Crossgen section and into the CoreLib build section of build.cmd
* Adds -ibconly which will skip building System.Private.CoreLib and only run the ibcmerge step
* Adds crossgenonly and partialngen flags to build.sh

These three changes facilitate our ability to apply IBC data to Linux assemblies on Windows and the perform the crossgen step on Linux, which will be our flow for official builds when we want to apply IBC data since IBCMerge cannot run on non-Windows platforms

6 years agoUpdate Unicode data to version 11 (#20529)
Tarek Mahmoud Sayed [Wed, 24 Oct 2018 19:58:58 +0000 (12:58 -0700)]
Update Unicode data to version 11 (#20529)

* Update Unicode data to version 11

* Move CharUnicodeInfoData.cs to the hsared folder

* Delete un-needed file

* Disable the failed test

6 years agoMove ILLink and SizeOnDisk testing to Helix Queue (#20569)
Michelle McDaniel [Wed, 24 Oct 2018 17:51:34 +0000 (10:51 -0700)]
Move ILLink and SizeOnDisk testing to Helix Queue (#20569)

6 years agoExpose EnableISA knobs in release build (#20501)
Fei Peng [Wed, 24 Oct 2018 15:06:41 +0000 (08:06 -0700)]
Expose EnableISA knobs in release build (#20501)

6 years agoMerge pull request #20497 from AaronRobinsonMSFT/additional_com_tests
Aaron Robinson [Wed, 24 Oct 2018 03:22:24 +0000 (20:22 -0700)]
Merge pull request #20497 from AaronRobinsonMSFT/additional_com_tests

Support for IDispatch

6 years agoDelete duplicate CoreFX tests (#20532)
Jan Kotas [Wed, 24 Oct 2018 02:59:39 +0000 (19:59 -0700)]
Delete duplicate CoreFX tests (#20532)

Contributes to https://github.com/dotnet/coreclr/issues/12782

6 years agoInitialize `StructReturnType` for `gtNewRefCOMfield`. (#20056)
Sergey Andreenko [Wed, 24 Oct 2018 01:06:57 +0000 (18:06 -0700)]
Initialize `StructReturnType` for `gtNewRefCOMfield`. (#20056)

The issue could be repro only on .Net Framework, because this helper is only needed for remoting, that .Net Core doesn't have.

6 years agoJIT: recover types from helper calls and more (#20447)
Andy Ayers [Wed, 24 Oct 2018 00:00:11 +0000 (17:00 -0700)]
JIT: recover types from helper calls and more (#20447)

The jit needs to recover class handles in order to devirtualize and
do other type-based optimizations. This change allows the jit to find
the type for more trees: in particular, helper calls, intrinsics, and
expanded static field accesses.

Also, annotate a few methods to control jit optimization

We don't want to optimize special methods that are used to inform crossgen
about desirable generic instantiations. `CommonlyUsedGenericInstantiations`
was already annotated but `CommonlyUsedWinRTRedirectedInterfaceStubs` wasn't.

And because `RuntimeType` is sealed calls through types are now often
devirtualized. Name lookups on types are frequent, especially on error paths.
The method `GetCachedName` looks like an attractive inline but simply expands
into a larger sequence of two other calls. So block it from being inlined.

6 years agoUse the same version of Xunit as in corefx (2.4.1 prerelease) (#20506)
Egor Chesakov [Tue, 23 Oct 2018 23:27:24 +0000 (16:27 -0700)]
Use the same version of Xunit as in corefx (2.4.1 prerelease) (#20506)

From https://xunit.github.io/releases/2.4.1-pre-4059

**xUnit.net 2.4.1 Pre-Release (build 4059)**

Core framework
* BUG: Fixed an issue with xunit.abstractions not correctly installing with older versions of Visual Studio (pre-2017).
* BUG: Fixed an issue with ByRef types with .NET Core 2.1.
* BUG: Removed an unnecessary first chance exception related to attempting to load configuration files.
* BUG: Fixed an issue where synchronous and asynchronous disposal of test classes were running in parallel. The documented behavior is that asynchronous disposal (via IAsyncLifetime) runs to completion before synchronous disposal (via IDisposable).

Console runner
* BUG: Fixed an issue with XML element order with the NUnit report.

MSBuild runner
* BUG: Fixed an issue with XML element order with the NUnit report.

6 years agoMerge pull request #20537 from BruceForstall/RemoveLocAllocSP
Bruce Forstall [Tue, 23 Oct 2018 22:54:14 +0000 (15:54 -0700)]
Merge pull request #20537 from BruceForstall/RemoveLocAllocSP

Remove the LocAllocSP slot for non-x86 platforms

6 years agoMerge pull request #20552 from fiigii/retest
Carol Eidt [Tue, 23 Oct 2018 22:52:18 +0000 (22:52 +0000)]
Merge pull request #20552 from fiigii/retest

Rewrite and re-enable some hardware intrinsic tests

6 years agoAdd PInvoke/Delegate tests (#19323)
Zeng Jiang [Tue, 23 Oct 2018 21:05:57 +0000 (05:05 +0800)]
Add PInvoke/Delegate tests (#19323)

* Add PInvoke/Delegate tests

* Initial pass to get Delegate tests building xplat and running with current infrastructure.

* Fix BOOL and NULL comparisons.

* Fix copy-paste typo

* Disable explicit offset tests off-Windows.

6 years agoRe-enable hardware intrinsic tests
Fei Peng [Tue, 23 Oct 2018 18:57:08 +0000 (11:57 -0700)]
Re-enable hardware intrinsic tests

6 years agoUpdate BuildTools, CoreClr, CoreSetup, IbcData, PgoData to preview1-03322-02, preview...
dotnet-maestro-bot [Tue, 23 Oct 2018 18:34:57 +0000 (11:34 -0700)]
Update BuildTools, CoreClr, CoreSetup, IbcData, PgoData to preview1-03322-02, preview1-27023-01, preview1-27023-01, master-20181023-0040, master-20181023-0039, respectively (master) (#20502)

* Update BuildTools, CoreClr, CoreSetup, IbcData, PgoData to preview1-03322-02, preview1-27023-01, preview1-27023-01, master-20181023-0040, master-20181023-0039, respectively

* excluding DebugTests

6 years agoAdd tests for IDispatch and Aggregation
Aaron Robinson [Mon, 1 Oct 2018 21:49:40 +0000 (14:49 -0700)]
Add tests for IDispatch and Aggregation

6 years agoAdd support for IDispatch in CoreCLR
Aaron Robinson [Fri, 19 Oct 2018 20:03:37 +0000 (13:03 -0700)]
Add support for IDispatch in CoreCLR

Reduce some TypeInfo API cruft

Throw exception on non-Windows ABIs for value types

6 years agoFix System.Diagnostics.Debug.Tests assembly name
Jan Kotas [Tue, 23 Oct 2018 15:37:57 +0000 (08:37 -0700)]
Fix System.Diagnostics.Debug.Tests assembly name

6 years agoDisable System.Diagnostics.Tests CoreFX tests
Jan Kotas [Tue, 23 Oct 2018 12:21:04 +0000 (05:21 -0700)]
Disable System.Diagnostics.Tests CoreFX tests

6 years agoRemove the LocAllocSP slot for non-x86 platforms
Bruce Forstall [Tue, 23 Oct 2018 04:39:16 +0000 (21:39 -0700)]
Remove the LocAllocSP slot for non-x86 platforms

This special local variable is only needed on x86 when a function
contains localloc.

6 years agoadd missing methods bit (#20528)
Andy Ayers [Mon, 22 Oct 2018 23:39:23 +0000 (16:39 -0700)]
add missing methods bit (#20528)