Matt Devereau [Tue, 12 Jul 2022 15:54:53 +0000 (15:54 +0000)]
[AArch64][SVE] Add ISel pattern to lower DUPLANE128 to LD1RQD
Following on from https://reviews.llvm.org/D128902, lower DUPLANE128 to LD1RQD
for integer load types from instruction selection.
Differential Revision: https://reviews.llvm.org/D130010
Simon Pilgrim [Thu, 21 Jul 2022 10:46:27 +0000 (11:46 +0100)]
[AArch64] Add i128 parity test
AArch64 has custom i128 ctpop handling, so match this in the parity tests
Added as part of triaging Issue #56531
Jay Foad [Thu, 21 Jul 2022 10:12:14 +0000 (11:12 +0100)]
[AMDGPU][GlobalISel] Fix subtarget checks for combining to v_med3_i16
Differential Revision: https://reviews.llvm.org/D130243
Alexey Lapshin [Thu, 21 Jul 2022 10:39:50 +0000 (13:39 +0300)]
Revert "[DebugInfo][llvm-dwarfutil] Combine overlapped address ranges."
This reverts commit
d2a4d6bf9c52861f3d418bf7bb7d05f6e74dfead.
Nikita Popov [Thu, 21 Jul 2022 10:10:36 +0000 (12:10 +0200)]
[MemoryBuiltins] Add getFreedOperand() function (NFCI)
We currently assume in a number of places that free-like functions
free their first argument. This is true for all hardcoded free-like
functions, but with the new attribute-based design, the freed
argument is supposed to be indicated by the allocptr attribute.
To make sure we handle this correctly once allockind(free) is
respected, add a getFreedOperand() helper which returns the freed
argument, rather than just indicating whether the call frees *some*
argument.
This migrates most but not all users of isFreeCall() to the new
API. The remaining users are a bit more tricky.
Alexey Lapshin [Tue, 19 Jul 2022 15:11:07 +0000 (18:11 +0300)]
[DebugInfo][llvm-dwarfutil] Combine overlapped address ranges.
DWARF files may contain overlapping address ranges. f.e. it can happen if the two
copies of the function have identical instruction sequences and they end up sharing.
That looks incorrect from the point of view of DWARF spec. Current implementation
of DWARFLinker does not combine overlapped address ranges. It would be good if such
ranges would be handled in some useful way. Thus, this patch allows DWARFLinker
to combine overlapped ranges in a single one.
Depends on D86539
Reviewed By: aprantl
Differential Revision: https://reviews.llvm.org/D123469
Dmitry Vyukov [Thu, 21 Jul 2022 09:44:48 +0000 (11:44 +0200)]
tsan: remove unnecessary brackets
Reviewed By: melver
Differential Revision: https://reviews.llvm.org/D130236
Nikita Popov [Thu, 21 Jul 2022 08:05:48 +0000 (10:05 +0200)]
Reapply [InstCombine] Don't check for alloc fn before fetching alloc size
Reapply the patch with getObjectSize() replaced by getAllocSize().
The former will also look through calls that return their argument,
and we'll end up placing dereferenceable attributes on intrinsics
like llvm.launder.invariant.group. While this isn't wrong, it also
doesn't seem to be particularly useful. For now, use getAllocSize()
instead, which sticks closer to the original behavior of this code.
-----
This code is just interested in the allocsize, not any other
allocator properties.
Nikita Popov [Thu, 21 Jul 2022 09:40:35 +0000 (11:40 +0200)]
[MemoryBuiltins] Default to trivial mapper in getAllocSize() (NFC)
Default getAllocSize() to use the trivial mapper. Also switch
from using std::function to function_ref.
Furthermore, update the doc comment to point out a subtle difference
between getAllocSize() and getObjectSize(): The latter may also
return something for calls that return their argument (via "returned"
attribute or special intrinsics like invariant groups).
jacquesguan [Thu, 7 Jul 2022 08:48:55 +0000 (16:48 +0800)]
recommit "[DAGCombiner] Teach scalarizeBinOpOfSplats handle scalable splat."
With fix for AArch64 and Hexgon test cases.
Nikita Popov [Thu, 21 Jul 2022 08:46:50 +0000 (10:46 +0200)]
[MemoryBuiltins] Don't query TLI for non-pointer functions (NFC)
Fetching allocation data for calls is a rather hot operation, and
TLI lookups are slow. We can greatly reduce the number of calls
for which TLI is queried by checking that they return a pointer
value first, as this is a requirement for allocation functions
anyway.
Chuanqi Xu [Thu, 21 Jul 2022 09:19:11 +0000 (17:19 +0800)]
[C++20] [Modules] Avoid inifinite loop when iterating default args
Currently, clang may meet an infinite loop in a very tricky case when it
iterates the default args. This patch tries to fix this by adding a
`fixed` check.
Andrzej Warzynski [Wed, 20 Jul 2022 17:00:50 +0000 (17:00 +0000)]
[flang][nfc] Add missing `REQUIRES: asserts` in tests
Tests that use `--mlir-pass-statistics-display=` from MLIR require the
following condition to hold: (extracted from LLVM's Statistics.h):
```
#define LLVM_ENABLE_STATS 1
```
This is normally enforced with `REQUIRES: asserts`. This patch updates
relevant Flang tests accordingly.
For "Release" builds (with assertions disabled), the affected tests will
be failing without this change.
Differential Revision: https://reviews.llvm.org/D130185
Ivan Butygin [Sun, 17 Jul 2022 16:47:22 +0000 (18:47 +0200)]
[mlir][memref] Missing type conversion in memref.reshape llvm lowering
Shape can be memref of index type, so memref::LoadOp result need to be converted into llvm type.
Differential Revision: https://reviews.llvm.org/D129965
Nikita Popov [Thu, 21 Jul 2022 08:59:12 +0000 (10:59 +0200)]
Revert "[InstCombine] Don't check for alloc fn before fetching object size"
This reverts commit
c72c22c04df992c95c5912d0075e5263c88f9fec.
This affected an Analysis test that I missed. Reverting for now.
Nikita Popov [Thu, 21 Jul 2022 08:05:48 +0000 (10:05 +0200)]
[InstCombine] Don't check for alloc fn before fetching object size
This code is just interested in the allocsize, not any other
allocator properties.
Qiu Chaofan [Thu, 21 Jul 2022 08:33:41 +0000 (16:33 +0800)]
[PowerPC] Support x86 compatible intrinsics on AIX
These headers used to be guarded only on PowerPC64 Linux or FreeBSD, but
they can also be enabled for AIX OS target since it's big-endian ready.
Reviewed By: shchenz
Differential Revision: https://reviews.llvm.org/D129461
Chen Zheng [Thu, 21 Jul 2022 08:21:12 +0000 (04:21 -0400)]
enable P10 vector builtins test on AIX 64 bit; NFC
Verify that P10 vector builtins with type `vector signed __int128`
and `vector unsigned __int128` work well on AIX 64 bit.
Iain Sandoe [Sun, 3 Jul 2022 13:27:10 +0000 (14:27 +0100)]
re-land [C++20][Modules] Update handling of implicit inlines [P1779R3]
re-land fixes an unwanted interaction with module-map modules, seen in
Greendragon testing.
This provides updates to
[class.mfct]:
Pre C++20 [class.mfct]p2:
A member function may be defined (8.4) in its class definition, in
which case it is an inline member function (7.1.2)
Post C++20 [class.mfct]p1:
If a member function is attached to the global module and is defined
in its class definition, it is inline.
and
[class.friend]:
Pre-C++20 [class.friend]p5
A function can be defined in a friend declaration of a
class . . . . Such a function is implicitly inline.
Post C++20 [class.friend]p7
Such a function is implicitly an inline function if it is attached
to the global module.
We add the output of implicit-inline to the TextNodeDumper, and amend
a couple of existing tests to account for this, plus add tests for the
cases covered above.
Differential Revision: https://reviews.llvm.org/D129045
lorenzo chelini [Thu, 21 Jul 2022 07:58:53 +0000 (09:58 +0200)]
[MLIR][SCF] Enable better bufferization for `TileConsumerAndFuseProducersUsingSCFForOp`
Replace iterators of the outermost loop with region arguments of the innermost
one. The changes avoid later `bufferization` passes to insert allocation within
the body of the innermost loop.
Reviewed By: mravishankar
Differential Revision: https://reviews.llvm.org/D130083
Haojian Wu [Thu, 21 Jul 2022 08:02:29 +0000 (10:02 +0200)]
[pseudo] Make sure we rebuild pseudo_gen tool.
Daniel Bertalan [Wed, 20 Jul 2022 08:09:58 +0000 (10:09 +0200)]
[lld-macho] Optimize rebase opcode generation
This commit reduces the size of the emitted rebase sections by
generating the REBASE_OPCODE_DO_REBASE_ADD_ADDR_ULEB and
REBASE_OPCODE_DO_REBASE_ULEB_TIMES_SKIPPING_ULEB opcodes.
With this change, chromium_framework's rebase section is a 40% smaller
197 kilobytes, down from the previous 320 kB. That is 6 kB smaller than
what ld64 produces for the same input.
Performance figures from my M1 Mac mini:
x before
+ after
N Min Max Median Avg Stddev
x 10 4.2269349 4.3300061 4.2689675 4.2690016 0.
031151669
+ 10 4.219331 4.2914009 4.2398136 4.2448277 0.
023817308
No difference proven at 95.0% confidence
Differential Revision: https://reviews.llvm.org/D130180
Zi Xuan Wu (Zeson) [Thu, 21 Jul 2022 07:48:42 +0000 (15:48 +0800)]
[CSKY] Fix the testcase error due to the verifyInstructionPredicates
- Test cases for arch only has 16-bit instruction such as ck801/ck802 need
compile with -mattr=+btst16
- Fix the GPR copy instruction with MOV16 for 16-bit only arch.
Chen Zheng [Thu, 21 Jul 2022 07:48:31 +0000 (03:48 -0400)]
enable P10 vector builtins test on AIX 64 bit; NFC
Verify that P10 vector builtins with type `vector signed __int128`
and `vector unsigned __int128` work well on AIX 64 bit.
lorenzo chelini [Thu, 21 Jul 2022 07:40:30 +0000 (09:40 +0200)]
Revert "[RFC][MLIR][SCF] Enable better bufferization for `TileConsumerAndFuseProducersUsingSCFForOp`"
This reverts commit
9e6585030533e901a8c24dcb05b38d3f0d10331f.
Nikita Popov [Thu, 21 Jul 2022 07:37:29 +0000 (09:37 +0200)]
[MemoryBuiltins] Avoid isAllocationFn() call before checking removable alloc
Alloc directly checking whether a given call is a removable
allocation, instead of first checking whether it is an allocation
first.
Rainer Orth [Thu, 21 Jul 2022 07:18:10 +0000 (09:18 +0200)]
[sanitizer_common] Support Solaris < 11.4 in GetStaticTlsBoundary
This patch, on top of D120048 <https://reviews.llvm.org/D120048>, supports
GetTls on Solaris 11.3 and Illumos that lack `dlpi_tls_modid`. It's the
same method originally used in D91605 <https://reviews.llvm.org/D91605>,
but integrated into `GetStaticTlsBoundary`.
Tested on `amd64-pc-solaris2.11`, `sparcv9-sun-solaris2.11`, and
`x86_64-pc-linux-gnu`.
Differential Revision: https://reviews.llvm.org/D120059
David Green [Thu, 21 Jul 2022 07:00:22 +0000 (08:00 +0100)]
[SelectionDAG] Fix fptoi.sat scalable vector lowering
Vector fptosi_sat and fptoui_sat were being expanded by unrolling the
vector operation. This doesn't work for scalable vector, so this patch
adds a call to TLI.expandFP_TO_INT_SAT if the vector is scalable.
Scalable tests are added for AArch64 and RISCV. Some of the AArch64
fptoi_sat operations should be legal, but that will be handled in
another patch.
Differential Revision: https://reviews.llvm.org/D130028
lorenzo chelini [Tue, 19 Jul 2022 13:25:03 +0000 (15:25 +0200)]
[RFC][MLIR][SCF] Enable better bufferization for `TileConsumerAndFuseProducersUsingSCFForOp`
Replace iterators of the outermost loop with region arguments of the innermost
one. The changes avoid later `bufferization` passes to insert allocation within
the body of the innermost loop.
Reviewed By: mravishankar
Differential Revision: https://reviews.llvm.org/D130083
Luo, Yuanke [Thu, 21 Jul 2022 06:41:34 +0000 (14:41 +0800)]
[X86] Add test case for shuffle
Congzhe Cao [Thu, 21 Jul 2022 05:35:58 +0000 (01:35 -0400)]
[LoopCacheAnalysis] Fix a type mismatch problem in cost calculation
There is a problem in loop cache analysis that the types of SCEV variables
`Coeff` and `ElemSize` in function `isConsecutive()` may not match. The
mismatch would cause SCEV failures when `Coeff` is multiplied with `ElemSize`.
The fix in this patch is to extend the type of both `Coeff` and `ElemSize` to
whichever is wider in those two variables. As a clean-up, duplicate calculations
of `Stride` in `computeRefCost()` is then removed.
Reviewed By: Meinersbur, #loopoptwg
Differential Revision: https://reviews.llvm.org/D128877
Shraiysh Vaishay [Thu, 21 Jul 2022 04:58:12 +0000 (10:28 +0530)]
[clang][OpenMP] Add IRBuilder support for taskgroup
This patch makes use of OMPIRBuilder support for codegen of taskgroup
construct in clang.
Depends on D128203
Reviewed By: Meinersbur
Differential Revision: https://reviews.llvm.org/D129992
Craig Topper [Thu, 21 Jul 2022 05:18:25 +0000 (22:18 -0700)]
[RISCV] Combine (select_cc (srl (and X, 1<<C), C), 0, eq/ne, true, fale)
(srl (and X, 1<<C), C) is the form we receive for testing bit C.
An earlier combine removed the setcc so it wasn't there to match
when we created the SELECT_CC. This doesn't happen for BR_CC because
generic DAG combine rebuilds the setcc if it is used by BRCOND.
We can shift X left by XLen-1-C to put the bit to be tested in the
MSB, and use a signed compare with 0 to test the MSB.
Ian Anderson [Tue, 19 Jul 2022 05:52:09 +0000 (22:52 -0700)]
[sanitizer] Use consistent checks for XDR
sanitizer_platform_limits_posix.h defines `__sanitizer_XDR ` if `SANITIZER_LINUX && !SANITIZER_ANDROID`, but sanitizer_platform_limits_posix.cpp tries to check it if `HAVE_RPC_XDR_H`. This coincidentally works because macOS has a broken <rpc/xdr.h> which causes `HAVE_RPC_XDR_H` to be 0, but if <rpc/xdr.h> is fixed then clang fails to compile on macOS. Restore the platform checks so that <rpc/xdr.h> can be fixed on macOS.
Reviewed By: vitalybuka
Differential Revision: https://reviews.llvm.org/D130060
esmeyi [Thu, 21 Jul 2022 05:10:09 +0000 (01:10 -0400)]
[AIX] follow-up of D124654.
Emitting the remaining aliases instead of reporting
an error to avoid SPEC2017 PEAK failures.
And mark this as a TODO.
Mahesh Ravishankar [Fri, 15 Jul 2022 20:11:23 +0000 (20:11 +0000)]
[mlir][Linalg] Deprecate `tileAndFuseLinalgOps` method and associated patterns.
The `tileAndFuseLinalgOps` is a legacy approach for tiling + fusion of
Linalg operations. Since it was also intended to work on operations
with buffer operands, this method had fairly complex logic to make
sure tile and fuse was correct even with side-effecting linalg ops.
While complex, it still wasnt robust enough. This patch deprecates
this method and thereby deprecating the tiling + fusion method for ops
with buffer semantics. Note that the core transformation to do fusion
of a producer with a tiled consumer still exists. The deprecation here
only removes methods that auto-magically tried to tile and fuse
correctly in presence of side-effects.
The `tileAndFuseLinalgOps` also works with operations with tensor
semantics. There are at least two other ways the same functionality
exists.
1) The `tileConsumerAndFuseProducers` method. This does a similar
transformation, but using a slightly different logic to
automatically figure out the legal tile + fuse code. Note that this
is also to be deprecated soon.
2) The prefered way uses the `TilingInterface` for tile + fuse, and
relies on the caller to set the tiling options correctly to ensure
that the generated code is correct.
As proof that (2) is equivalent to the functionality provided by
`tileAndFuseLinalgOps`, relevant tests have been moved to use the
interface, where the test driver sets the tile sizes appropriately to
generate the expected code.
Differential Revision: https://reviews.llvm.org/D129901
owenca [Tue, 19 Jul 2022 08:22:31 +0000 (01:22 -0700)]
[clang-format][NFC] Refactor RequiresDoesNotChangeParsingOfTheRest
Differential Revision: https://reviews.llvm.org/D129982
owenca [Wed, 20 Jul 2022 01:11:31 +0000 (18:11 -0700)]
[clang-format] Indent tokens after hash only if it starts a line
Fixes #56602.
Differential Revision: https://reviews.llvm.org/D130136
Craig Topper [Thu, 21 Jul 2022 04:07:07 +0000 (21:07 -0700)]
[RISCV] Refactor the common combines for SELECT_CC and BR_CC into a helper function.
The only difference between the combines were the calls to getNode
that include the true/false values for SELECT_CC or the chain
and branch target for BR_CC.
Wrap the rest of the code into a helper that reads LHS, RHS, and
CC and outputs new values and a bool if a new node needs to be
created.
Xi Ruoyao [Thu, 21 Jul 2022 02:33:11 +0000 (10:33 +0800)]
Port address sanitizer to LoongArch
Depends on D129371.
It survived all GCC ASan tests.
Changes are trivial and mostly "borrowed" RISC-V logics, except that a different SHADOW_OFFSET is used.
Reviewed By: SixWeining, MaskRay, XiaodongLoong
Differential Revision: https://reviews.llvm.org/D129418
jacquesguan [Wed, 20 Jul 2022 06:47:25 +0000 (14:47 +0800)]
[mlir][Math] Add constant folder for LogOp.
This patch adds constant folder for LogOp which only supports single and double precision floating-point.
Reviewed By: ftynse
Differential Revision: https://reviews.llvm.org/D130148
Chenbing Zheng [Thu, 21 Jul 2022 02:12:29 +0000 (10:12 +0800)]
[InstCombine] (ShiftValC >> Y) >s -1/<s 0 --> Y != 0/==0
We can do folds (ShiftValC >> Y) >s -1 --> Y != 0 and
(ShiftValC >> Y) <s 0 --> Y == 0, with ShiftValC < 0.
Alive2: https://alive2.llvm.org/ce/z/-PRHfD
Reviewed By: spatel
Differential Revision: https://reviews.llvm.org/D129726
Chenbing Zheng [Thu, 21 Jul 2022 01:54:43 +0000 (09:54 +0800)]
[InstCombine] add fold (X > C - 1) ^ (X < C + 1) --> X != C
Considering the correctness of this pattern, we should avoid that C - 1
is non-negative and C + 1 is negative.
Alive2: https://alive2.llvm.org/ce/z/c_rBaq
Reviewed By: spatel
Differential Revision: https://reviews.llvm.org/D129622
Vitaly Buka [Thu, 21 Jul 2022 01:56:02 +0000 (18:56 -0700)]
[NFC][asan] Clang-format a code
Vitaly Buka [Thu, 21 Jul 2022 01:09:24 +0000 (18:09 -0700)]
[NFC][memprof] Remove unused code
Vitaly Buka [Wed, 20 Jul 2022 21:40:10 +0000 (14:40 -0700)]
[NFC][asan] Use RoundDownTo
Craig Topper [Thu, 21 Jul 2022 01:11:19 +0000 (18:11 -0700)]
[RISCV] Optimize (brcond (seteq (and X, 1 << C), 0))
If C > 10, this will require a constant to be materialized for the
And. To avoid this, we can shift X left by XLen-1-C bits to put the
tested bit in the MSB, then we can do a signed compare with 0 to
determine if the MSB is 0 or 1. Thanks to @reames for the suggestion.
I've implemented this inside of translateSetCCForBranch which is
called when setcc+brcond or setcc+select is converted to br_cc or
select_cc during lowering. It doesn't make sense to do this for
general setcc since we lack a sgez instruction.
I've tested bit 10, 11, 31, 32, 63 and a couple bits betwen 11 and 31
and between 32 and 63 for both i32 and i64 where applicable. Select
has some deficiencies where we receive (and (srl X, C), 1) instead.
This doesn't happen for br_cc due to the call to rebuildSetCC in the
generic DAGCombiner for brcond. I'll explore improving select in a
future patch.
Reviewed By: reames
Differential Revision: https://reviews.llvm.org/D130203
Hui Xie [Thu, 21 Jul 2022 00:03:29 +0000 (17:03 -0700)]
[libc++] Fix proxy iterator issues that trigger an assertion in Chromium.
Crash report:
https://bugs.chromium.org/p/chromium/issues/detail?id=1346012
The triggered assertion is related sorting with `v8::internal::AtomicSlot`.
`AtomicSlot` is a proxy iterator with a proxy type `AtomicSlot::Reference`
(see https://chromium.googlesource.com/v8/v8/+/
9bcb5eb590643db0c1f688fea316c7f1f4786a3c/src/objects/slots-atomic-inl.h).
https://reviews.llvm.org/D130197 correctly spotted the issue in
`__iter_move` but doesn't actually fix the issue. The reason is that
`AtomicSlot::operator*` returns a prvalue `Reference`. After the fix in
D130197, the return type of `__iter_move` is `Reference&&`. But the
rvalue reference is bound to the temporary value returned by
`operator*`, which will be dangling after `__iter_move` returns.
The idea of the fix in this change is borrowed from C++17's move_iterator
https://timsong-cpp.github.io/cppwp/n4659/move.iterators#move.iterator-1
When the underlying reference is a prvalue, we just return it by value.
Differential Revision: https://reviews.llvm.org/D130212
LLVM GN Syncbot [Thu, 21 Jul 2022 00:53:15 +0000 (00:53 +0000)]
[gn build] Port
4fcf8434dd77
Anubhab Ghosh [Thu, 21 Jul 2022 00:32:56 +0000 (17:32 -0700)]
[ORC] Add a new MemoryMapper-based JITLinkMemoryManager implementation.
MapperJITLinkMemoryManager supports executor memory management using any
implementation of MemoryMapper to do the transfer such as InProcessMapper or
SharedMemoryMapper.
Reviewed By: lhames
Differential Revision: https://reviews.llvm.org/D129495
Slava Zakharin [Wed, 20 Jul 2022 23:56:28 +0000 (16:56 -0700)]
Revert "[flang] Run algebraic simplification optimization pass."
This reverts commit
4fbd1d6c872e8228f23a6e13914222af40ca6461.
Lang Hames [Wed, 20 Jul 2022 22:38:34 +0000 (15:38 -0700)]
[ORC] Don't try to copy from an empty segment in SimpleExecutorMemoryManager.
Since
67220c2ad72e empty SPSSequence<char>s deserialize to default-constructed
ArrayRef<char>s, which have a null data field. We need to check for this to
avoid memcpy'ing from a nullptr.
This should fix the bot failure in
https://lab.llvm.org/buildbot/#/builders/85/builds/9323
Steven Wu [Wed, 20 Jul 2022 23:45:09 +0000 (16:45 -0700)]
[Darwin toolchain] Tune the logic for finding arclite.
The heuristic used to determine where the arclite libraries are to be
found was based on the path of the `clang` executable. However, in some
scenarios the `clang` executable is within a toolchain that does not
have arclite. When this happens, derive the arclite paths from the
sysroot option.
This allows Clang to correctly derive the arclite directory in, e.g.,
Swift CI, using similar logic to what the Swift driver has been doing
for several years.
Patched by Doug Gregor.
Reviewed By: keith
Differential Revision: https://reviews.llvm.org/D130205
Slava Zakharin [Thu, 14 Jul 2022 23:50:41 +0000 (16:50 -0700)]
[flang] Run algebraic simplification optimization pass.
Flang algebraic simplification pass will run algebraic simplification
rewrite patterns for Math/Complex/etc. dialects. It is enabled
under opt-for-speed optimization levels (i.e. for O1/O2/O3; Os/Oz will not
enable it).
With this change the FIR/MLIR optimization pipeline becomes affected
by the -O* optimization level switches. Until now these switches
only affected the middle-end and back-end.
Differential Revision: https://reviews.llvm.org/D130035
River Riddle [Wed, 20 Jul 2022 08:43:07 +0000 (01:43 -0700)]
[mlir:LSP] Add a quickfix code action for inserting expected-* diagnostic checks
This allows for automatically inserting expected checks for parser and verifier
diagnostics, which simplifies the workflow when building new dialect
constructs or extending existing ones.
Differential Revision: https://reviews.llvm.org/D130152
Johannes Doerfert [Sun, 10 Jul 2022 18:49:36 +0000 (13:49 -0500)]
[Attributor] Deal with complex PHI nodes better during AAPointerInfo
We were quite conservative when it came to PHI node handling to avoid
recursive reasoning. Now we check more direct if we have seen a PHI
already or not. This allows non-recursive PHI chains to be handled.
This also exposed a bug as we did only model the effect of one loop
traversal. `phi_no_store_3` has been adapted to show how we would have
used `undef` instead of `1` before. With this patch we don't replace
it at all, which is expected as we do not argue about loop iterations
(or alignments).
Johannes Doerfert [Sun, 10 Jul 2022 18:46:42 +0000 (13:46 -0500)]
[Attributor] Only non-exact accesses require a uniform bit-pattern (=0)
If we only have exact accesses we should never require the bit-pattern
to be uniform (in this case 0). Only a non-exact access should force us
to require only 0 values.
Alexander Shaposhnikov [Wed, 20 Jul 2022 22:29:03 +0000 (22:29 +0000)]
[GlobalOpt] Enable evaluation of atomic stores
Relax the check to allow evaluation of atomic stores
(but still skip volatile stores).
Test plan:
1/ ninja check-llvm check-clang
2/ Bootstrapped LLVM/Clang pass tests
Differential revision: https://reviews.llvm.org/D129841
Teresa Johnson [Mon, 6 Jun 2022 13:57:36 +0000 (06:57 -0700)]
[MemProf] Basic metadata support and verification
Add basic support for the MemProf metadata (!memprof and !callsite)
which was initially described in "RFC: IR metadata format for MemProf"
(https://discourse.llvm.org/t/rfc-ir-metadata-format-for-memprof/59165).
The bulk of the patch is verification support, along with some tests.
There are a couple of changes to the format described in the original
RFC:
Initial measurements suggested that a tree format for the stack ids in
the contexts would be more efficient, but subsequent evaluation with
large applications showed that in fact the cost of the additional
metadata nodes required by this deduplication scheme overwhelmed the
benefit from sharing stack id nodes. Therefore, the implementation here
and in follow on patches utilizes a simpler scheme of lists of stack id
integers in the memprof profile contexts and callsite metadata. The
follow on matching patch employs context trimming optimizations to
reduce the cost.
Secondly, instead of verbosely listing all profiled fields in each
profiled context (memory info block or MIB), and deferring the
interpretation of the profile data, the profile data is evaluated and
converted into string tags specifying the behavior (e.g. "cold") during
profile matching. This reduces the verbosity of the profile metadata,
and allows additional context trimming optimizations. As a result, the
named metadata schema description is also no longer needed.
Differential Revision: https://reviews.llvm.org/D128141
Schrodinger ZHU Yifan [Wed, 20 Jul 2022 22:30:38 +0000 (15:30 -0700)]
[ThinLTO] Support aliased GlobalIFunc
Fixes https://github.com/llvm/llvm-project/issues/56290: when an ifunc is
aliased in LTO, clang will attempt to create an alias summary; however, as ifunc
is not included in the module summary, doing so will lead to crash.
Reviewed By: MaskRay
Differential Revision: https://reviews.llvm.org/D129009
Matt Arsenault [Wed, 20 Jul 2022 20:52:07 +0000 (16:52 -0400)]
llvm-reduce: Fix register mask test
This was sometimes failing with "input module no longer interesting
after counting chunks" assert.
Craig Topper [Wed, 20 Jul 2022 21:55:09 +0000 (14:55 -0700)]
[RISCV] Recognize bexti from (srl (and X, 1<<C), C).
This is the form we get for (zext (setne (and X 1<<C))). We only
had bexti patterns for the alternative form (and (srl X, C), 1).
Craig Topper [Wed, 20 Jul 2022 21:48:43 +0000 (14:48 -0700)]
[RISCV] Add test cases for failure to use bexti for (setne (and X, 1<<C))
This will get converted to (srl (and X, 1<<C), C) which we need
to isel to bexti.
Tanyo Kwok [Wed, 20 Jul 2022 19:12:41 +0000 (19:12 +0000)]
[MLIR] Add function to create Float16 array attribute
This patch adds a new function mlirDenseElementsAttrFloat16Get(),
which accepts the shaped type, the number of Float16 values, and a
pointer to an array of Float16 values, each of which is a uint16_t
value.
This commit is repeating https://reviews.llvm.org/D123981 + #761 but for Float16
Differential Revision: https://reviews.llvm.org/D130069
Slava Gurevich [Wed, 20 Jul 2022 20:32:53 +0000 (13:32 -0700)]
[LLDB][NFC][Reliability] Fix uninitialized variables from Coverity scan
Improve LLDB reliability by fixing the following "uninitialized variables" static code inspection warnings from
scan.coverity.com:
1094796 1095721 1095728 1095737 1095741
1095756 1095779 1095789 1095805 1214552
1229457 1232475 1274006 1274010 1293427
1364800 1364802 1364804 1364812 1364816
1374902 1374909 1384975 1399312 1420451
1431704 1454230 1454554 1454615 1454579
1454594 1454832 1457759 1458696 1461909
1467658 1487814 1487830 1487845
Differential Revision: https://reviews.llvm.org/D130098
Philip Reames [Wed, 20 Jul 2022 21:43:08 +0000 (14:43 -0700)]
[LV] Refresh a couple of autogen tests for naming change
These appear to just be changes in temporary identifiers; bit suprising we have so many.
Jakub Kuderski [Wed, 20 Jul 2022 21:46:11 +0000 (17:46 -0400)]
[mlir][spirv] Rename spv.ocl to spv.cl. NFC.
This is to improve the consistency within the SPIR-V dialect and to make op names a bit shorter.
Reviewed By: antiagainst
Differential Revision: https://reviews.llvm.org/D130194
Joseph Huber [Thu, 14 Jul 2022 15:46:43 +0000 (11:46 -0400)]
[HIP] Allow the new driver to compile HIP in non-RDC mode
The new driver primarily allows us to support RDC-mode compilations with
proper linking. This is not needed for non-RDC mode compilation, but we
still would like the new driver to be able to handle this mode so we can
transition away from the old driver in the future. This patch adds the
necessary code to support creating a fatbinary for HIP code generation.
Reviewed By: yaxunl
Differential Revision: https://reviews.llvm.org/D129784
Konstantin Varlamov [Wed, 20 Jul 2022 20:17:25 +0000 (13:17 -0700)]
[libc++] Fix `_IterOps::__iter_move` to support proxy iterators.
The return type was specified incorrectly for proxy iterators that
define `reference` to be a class that implicitly converts to
`value_type`. `__iter_move` would end up returning an object of type
`reference` which would then implicitly convert to `value_type`; thus,
the function will return a `value_type&&` rvalue reference to the local
temporary.
Differential Revision: https://reviews.llvm.org/D130197
Michał Górny [Wed, 20 Jul 2022 10:28:17 +0000 (12:28 +0200)]
[llvm] [cmake] Skip driver-related code unless LLVM_TOOL_LLVM_DRIVER_BUILD
Disable the code responsible for preparing object libraries
for the driver and filling LLVM_DRIVER_* properties
if LLVM_TOOL_LLVM_DRIVER_BUILD is disabled. These properties are
consumed only by tools/llvm-driver, and so they are not used at all
if LLVM_TOOL_LLVM_DRIVER_BUILD is not enabled. At the same time,
the related code breaks standalone clang builds against LLVM built
with LLVM_LINK_LLVM_DYLIB.
Differential Revision: https://reviews.llvm.org/D130158
LLVM GN Syncbot [Wed, 20 Jul 2022 20:02:41 +0000 (20:02 +0000)]
[gn build] Port
23cf42e706fb
Nikolas Klauser [Wed, 20 Jul 2022 18:24:46 +0000 (20:24 +0200)]
[libc++] Use uninitialized algorithms for vector
Reviewed By: ldionne, #libc
Spies: libcxx-commits, mgorny
Differential Revision: https://reviews.llvm.org/D128146
Joseph Huber [Wed, 20 Jul 2022 19:00:23 +0000 (15:00 -0400)]
[Libomptarget] Make libomptarget an LLVM library
This patch makes libomptarget depend on LLVM libraries to be built. The
reason for this is because we already have an implicit dependency on
LLVM headers for ELF identification and extraction as well as an
optional dependenly on the LLVMSupport library for time tracing
information. Furthermore, there are changes in the future that require
using more LLVM libraries, and will heavily simplify some future code as
well as open up the large amount of useful LLVM libraries to
libomptarget.
This will make "standalone" builds of `libomptarget' more difficult for
vendors wishing to ship their own. This will require a sufficiently new
version of LLVM to be installed on the system that should be picked up
by the existing handling for the implicit headers.
The things this patch changes are as follows:
- `libomptarget.so` links against LLVMSupport and LLVMObject
- `libomptarget.so` is a symbolic link to `libomptarget.so.15`
- If using a shared library build, user applications will depend on LLVM
libraries as well
- We can now use LLVM resources in Libomptarget.
Note that this patch only changes this to apply to libomptarget itself,
not the plugins. Additional patches will be necessary for that.
Reviewed By: JonChesterfield
Differential Revision: https://reviews.llvm.org/D129875
Arthur Eubanks [Wed, 20 Jul 2022 19:26:16 +0000 (12:26 -0700)]
[NFC] Suppress unused variable warning in non-assert builds
River Riddle [Wed, 20 Jul 2022 19:01:34 +0000 (12:01 -0700)]
[mlir:LSP] Add a doc blurb for code completion
This also gets used for the vscode extension documentation.
River Riddle [Wed, 20 Jul 2022 19:00:18 +0000 (12:00 -0700)]
[mlir:LSP] Remove several more annoying completion commit characters
These characters are annoying in that they accept completions
that weren't intended, causing user frustration.
Philip Reames [Wed, 20 Jul 2022 18:54:05 +0000 (11:54 -0700)]
[LAA] Fix latent missing check bug when mixing scalable and non-scalabe strides
Noticed via inspection; to my knowledge, impossible to hit today. In theory, we could have a fixed stride check be analyzed, then a scalable one. With the old code, the scalable one would be silently dropped, and the runtime guard would go ahead with only the fixed one. This would be a miscompile.
Konstantin Varlamov [Wed, 20 Jul 2022 08:57:13 +0000 (01:57 -0700)]
[libc++][ranges] Implement `std::ranges::partition_{point,copy}`.
Reviewed By: #libc, huixie90, ldionne
Differential Revision: https://reviews.llvm.org/D130070
Keith Smiley [Wed, 20 Jul 2022 00:03:34 +0000 (17:03 -0700)]
[lld-macho] Fold cfstrings with --deduplicate-literals
Similar to cstrings ld64 always deduplicates cfstrings. This was already
being done when enabling ICF, but for debug builds you may want to flip
this on if you cannot eliminate your instances of this, so this change
makes --deduplicate-literals also apply to cfstrings.
Differential Revision: https://reviews.llvm.org/D130134
Xiang Li [Thu, 23 Jun 2022 21:07:07 +0000 (14:07 -0700)]
[HLSL] add -I option for dxc mode.
A new option -I is added for dxc mode.
It is just alias of existing cc1 -I option.
Reviewed By: beanz
Differential Revision: https://reviews.llvm.org/D128462
Craig Topper [Tue, 19 Jul 2022 17:24:15 +0000 (10:24 -0700)]
[InstCombine] Add mul with negated power of 2 constant to canEvaluateShifted.
If we are right shifting a multiply by a negated power of 2 where
the power of 2 is the same as the shift amount, we can replace with
a negate followed by an And.
New tests have not been committed yet but the patch shows the diffs.
Let me know if you want any changes or additional tests.
Differential Revision: https://reviews.llvm.org/D130103
Craig Topper [Tue, 19 Jul 2022 17:21:03 +0000 (10:21 -0700)]
[InstCombine] Pre-commit test for D130103.
Arthur Eubanks [Wed, 20 Jul 2022 17:58:42 +0000 (10:58 -0700)]
[test] Add missing REQUIRES: arm-registered-target
Hubert Tong [Wed, 20 Jul 2022 17:55:57 +0000 (13:55 -0400)]
[NFC][tests] Remove XFAIL for AIX for passing tests
https://lab.llvm.org/buildbot/#/builders/214/builds/2425 reports these
tests as XPASS.
Arthur Eubanks [Wed, 20 Jul 2022 17:55:03 +0000 (10:55 -0700)]
[test] Remove unnecessary -verify-machineinstrs=0
Issue #38784 seems to be fixed and removing these doesn't cause any issues.
Joe Nash [Tue, 19 Jul 2022 16:49:15 +0000 (12:49 -0400)]
[AMDGPU] NFC. Assert that mask is full with VOPC DPP
VOPC DPP should not be formed when the row_mask and bank_mask are not
0xf (full) because the resulting VOP DPP would have different semantics
than the MOV DPP followed by VOP. Existing checks in GCNDPPCombine cover
this case but for different reasons, so assert the property for
future-proofing.
Reviewed By: nhaehnle
Differential Revision: https://reviews.llvm.org/D130101
Mark de Wever [Wed, 20 Jul 2022 17:26:28 +0000 (19:26 +0200)]
[libc++][format] Updates the status page.
Alex Bradbury [Wed, 20 Jul 2022 16:49:33 +0000 (17:49 +0100)]
[RISCV][test] Add tests for atomic compare exchange + branch on result
Due to the late expansion of the compare exchange sequences, there's
scope for improving codegen by folding the branches into the cmpxchg
loop (avoiding a branch-to-branch).
LLVM GN Syncbot [Wed, 20 Jul 2022 16:42:40 +0000 (16:42 +0000)]
[gn build] Port
857a78c04dee
Kazu Hirata [Wed, 20 Jul 2022 16:40:18 +0000 (09:40 -0700)]
[IPO] Restore a call to has_value (NFC)
This patch restores a call to has_value to make it clear that we are
checking the presence of an optional value, not the underlying value.
This patch partially reverts
d08f34b592ff06ccb1f36da88ec09aa926427a4d.
Differential Revision: https://reviews.llvm.org/D129453
Mark de Wever [Sat, 28 May 2022 13:30:10 +0000 (15:30 +0200)]
[libc++] Implements Unicode grapheme clustering
This implements the Grapheme clustering as required by
P1868R2 width: clarifying units of width and precision in std::format
This was omitted in the initial patch, but the paper was marked as completed. This really completes the paper.
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D126971
Tarun Prabhu [Wed, 20 Jul 2022 16:27:22 +0000 (11:27 -0500)]
[flang][nfc] Test folding of bit-population count intrinsics
Test compile-time folding of the leadz, trailz, popcnt and poppar Fortran 2008 intrinsics.
Differential Revision: https://reviews.llvm.org/D129610
Ruobing Han [Tue, 19 Jul 2022 21:39:14 +0000 (21:39 +0000)]
fix bug for useless malloc elimination in CodeGenPrepare
Put AllocationFn check before I->willReturn can allow CodeGenPrepare to remove useless malloc instruction
Differential Revision: https://reviews.llvm.org/D130126
Mark de Wever [Mon, 18 Jul 2022 18:32:39 +0000 (20:32 +0200)]
[libc++][doc] Updates the release notes.
This is a preparation for the upcoming LLVM 16 release.
Reviewed By: ldionne, #libc
Differential Revision: https://reviews.llvm.org/D130031
Alex Bradbury [Wed, 20 Jul 2022 16:08:30 +0000 (17:08 +0100)]
[RISCV][test] Add tests showing signext behaviour of cmpxchg
Kazu Hirata [Wed, 20 Jul 2022 16:09:19 +0000 (09:09 -0700)]
Use llvm::is_contained (NFC)
Kazu Hirata [Wed, 20 Jul 2022 15:56:23 +0000 (08:56 -0700)]
[flang] Use value instead of getValue (NFC)
Flang C++ Style Guide tells us to use x.value() when no presence test
is obviously protecting the reference. Since assert can be disabled,
I don't count it as "protection" here.
Differential Revision: https://reviews.llvm.org/D130144
Philip Reames [Wed, 20 Jul 2022 15:14:45 +0000 (08:14 -0700)]
[LV] Autogen a test for ease of update
Joseph Huber [Wed, 20 Jul 2022 14:18:23 +0000 (10:18 -0400)]
Revert "[Libomptarget] Make libomptarget an LLVM library"
This reverts commit
643dfd97d52e7b0c0dfbe7fd6046de9d43b3daa6.
This patch still makes the AMDGPU buildbots unhappy. Reverting for now
until the AMD folks figure it out.
Joseph Huber [Wed, 20 Jul 2022 14:17:35 +0000 (10:17 -0400)]
[Libomptarget] Fix LTO command line in test
Summary:
The test passed -offload-lto instead of -foffload-lto.