Víctor Manuel Jáquez Leal [Fri, 9 Jul 2021 09:01:14 +0000 (11:01 +0200)]
Revert "vaapi: Demote vaapidecodebin to rank NONE."
This reverts commit
7a25c5d4ec95aefeca6515ac023b23c5dd330194.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/436>
He Junyan [Wed, 23 Jun 2021 08:23:00 +0000 (16:23 +0800)]
plugins: encode: fix a deadlock because of _drain()
We call gst_vaapiencode_drain() in gst_vaapiencode_change_state(),
whose context does not hold the stream lock of the encoder. The
current gst_vaapiencode_drain inside unlock/lock pair adds a extra
lock count to the stream lock of encoder and causes hang later.
We just remove the gst_vaapiencode_drain() and expand its logic
correctly according to the lock/unlock context.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/433>
He Junyan [Tue, 29 Jun 2021 07:09:13 +0000 (15:09 +0800)]
libs: decoder: av1: Clean the film_grain_info field.
We need to clean all film_grain_info fields when the film grain
feature is not enabled. It may have random data because the picture
parameter buffer is not cleaned.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/434>
He Junyan [Thu, 3 Jun 2021 14:12:04 +0000 (22:12 +0800)]
libs: encoder: mpeg2: Add highP level for 1080@50p/60p.
The MPEG2 spec has amendment 3 to introduce a new level highP, which
is used for 1080@50p/60p streams. We need to add this level to avoid
encoding failure because of the level check.
Fix: #306
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/432>
He Junyan [Tue, 11 May 2021 08:59:07 +0000 (16:59 +0800)]
Decoder: H264: Add the support for frame packing arrangement SEI message.
Frame packing arrangement SEI message is an alternative simple stereo 3D
manner for AVC. We need to recognize that SEI message and report the correct
3D caps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/420>
Tim-Philipp Müller [Sat, 22 May 2021 17:54:49 +0000 (18:54 +0100)]
Use g_memdup2() where available and add fallback for older GLib versions
Alloc size is based on existing allocations and struct sizes.
g_memdup() is deprecated since GLib 2.68 and we want to avoid
deprecation warnings with recent versions of GLib.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/431>
Tim-Philipp Müller [Tue, 1 Jun 2021 14:29:16 +0000 (15:29 +0100)]
Back to development
Tim-Philipp Müller [Mon, 31 May 2021 23:16:31 +0000 (00:16 +0100)]
Release 1.19.1
Víctor Manuel Jáquez Leal [Fri, 23 Apr 2021 17:01:54 +0000 (19:01 +0200)]
vaapi: Demote vaapidecodebin to rank NONE.
One of the main reasons of vaapidecodebin was because it mitigated the
possible surface exhaustion. But that problem is currently
solved. Nowadays, vaapidecodebin brings more problems than it
solves. Thus this patch demotes vaapidecodebin to NONE rank while
bumping PRIMARY + 1 the most common decoders.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/426>
Víctor Manuel Jáquez Leal [Thu, 20 May 2021 08:28:05 +0000 (10:28 +0200)]
plugins: Demote rank of vaapipostproc and vaapioverlay.
Since almost all video filters have rank NONE, these both elements
should be NONE too.
This is useful for autovideoconvert and other bins, and users might
force to use these by setting the environment variable
GST_PLUGIN_FEATURE_RANK.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/429>
François Laignel [Wed, 21 Apr 2021 08:55:45 +0000 (10:55 +0200)]
Use gst_element_request_pad_simple...
Instead of the deprecated gst_element_get_request_pad.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/425>
Zhang yuankun [Fri, 23 Apr 2021 03:02:05 +0000 (11:02 +0800)]
libs: encoder: VP9: fix > 4k encode fail issue
The VP9 spec defines the MAX_TILE_WIDTH_B64(64), which is the maximum
width of a tile in units of superblocks. So the max width of one tile
should not be larger than 64x64=4096. When the width exceeds 4k, we
need to split it into multiple tiles in columns. The current vp9 encoder
does not handle this correctly.
The command such as:
gst-launch-1.0 videotestsrc ! video/x-raw,width=7680,height=4320 ! \
vaapivp9enc ! fakesink
will crash.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/424>
Haihao Xiang [Fri, 2 Apr 2021 07:43:45 +0000 (15:43 +0800)]
libs: display: drm: don't fallback to default device if explicitly specified device can't load/init
Otherwise user will be misled that the specified device is using
This fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/issues/305
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/422>
He Junyan [Mon, 22 Mar 2021 05:41:13 +0000 (13:41 +0800)]
decoder: H265: Enable cu_qp_delta_enabled_flag when ROI
If ROI is enabled, the CUs within the ROI region may have different
QP from the other part of the picture. This needs us to enable the
cu_qp_delta_enabled_flag even in the CQP mode.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/419>
Matthew Waters [Fri, 19 Mar 2021 06:42:36 +0000 (17:42 +1100)]
gst: don't use volatile to mean atomic
volatile is not sufficient to provide atomic guarantees and real atomics
should be used instead. GCC 11 has started warning about using volatile
with atomic operations.
https://gitlab.gnome.org/GNOME/glib/-/merge_requests/1719
Discovered in https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/-/issues/868
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/418>
Paul Goulpié [Wed, 24 Feb 2021 16:41:02 +0000 (17:41 +0100)]
gstvaapiencoder_h264: add ENCODER_EXPOSURE on aud propertie
forgot during the following mainline commit: https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/commit/
bc2f8fd19e924aa0e193708307326acd037691ce#
Signed-off-by: Paul Goulpié <paul.goulpie@ubicast.eu>
He Junyan [Thu, 4 Feb 2021 07:05:55 +0000 (15:05 +0800)]
plugins: postproc: Fix a problem of propose_allocation when passthrough.
We should query the downstream element to answer a precise allocation
query when the passthrough mode is enabled.
The current way still decides the allocation by the postproc itself. The
pipeline such as:
gst-launch-1.0 -v filesrc location=xxx.264 ! h264parse ! vaapih264dec ! \
vaapipostproc ! fakevideosink silent=false sync=true
will lose some info such as the GST_VIDEO_META_API_TYPE.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/413>
Haihao Xiang [Wed, 27 Jan 2021 04:05:44 +0000 (12:05 +0800)]
libs: display: drm: support gst.vaapi.app.Display context for drm backend
Attributes for drm backend:
- va-display : ponter of VADisplay
- drm-device-fd : the DRM device file descriptor
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/409>
Haihao Xiang [Wed, 13 Jan 2021 06:43:20 +0000 (14:43 +0800)]
libs: display: drm: allow user specify a drm device via an env variable
Currently the default drm device is always used on a system with
multiple drm devices. This patch allows user to specify the required
drm device via GST_VAAPI_DRM_DEVICE env variable
Example:
GST_VAAPI_DRM_DEVICE=/dev/dri/renderD129 gst-launch-1.0 videotestsrc !
vaapih264enc ! fakesink
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/409>
Haihao Xiang [Mon, 25 Jan 2021 06:45:47 +0000 (14:45 +0800)]
libs: display: drm: fix set_device_path_from_fd
drmGetBusid() (GET_UNIQUE ioctl) won't return a valid bus id when
drmSetInterfaceVersion() (SET_VERSION ioctl) hasn't been called(see[1]),
so we can't get the right device path. Running test-display will get the
error below:
** (test-display:18630): ERROR **: 10:26:00.434: could not create Gst/VA
display
Calling drmSetInterfaceVersion() before drmGetBusid() can't fix this
issue because a special permission is required for SET_VERSION ioctl.
This patch retrieves the device path from file descriptor via
g_file_read_link()
[1] https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/drm_ioctl.c#L48-L104
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/412>
Rafał Dzięgiel [Wed, 20 Jan 2021 09:42:09 +0000 (10:42 +0100)]
glx: Iterate over FBConfig and select 8 bit color size
Texture upload mechanism used by gstreamer-vaapi relies on 8 bpc.
In latest mesa versions the first fbconfig might not be 8 bit, so iterate
over it to find the correct config with supported values.
This also adds 8 bit alpha size to the framebuffer configuration which is
required to get it working properly.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/410>
Ung, Teng En [Mon, 11 Jan 2021 01:57:03 +0000 (09:57 +0800)]
vaapipostproc: fix code style.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/407>
Ung, Teng En [Mon, 21 Dec 2020 05:42:00 +0000 (05:42 +0000)]
vaapipostproc: Remove YUV to/from RGB color primary quirk since iHD driver has fixed in
https://github.com/intel/media-driver/commit/
a39fe9bc051a8c3efa8f35122a1585981ec7f816.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/407>
Ung, Teng En [Mon, 21 Dec 2020 05:36:29 +0000 (05:36 +0000)]
vaapipostproc: Added gstreamer BT2020 color standard support.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/407>
He Junyan [Sat, 9 Jan 2021 08:05:48 +0000 (16:05 +0800)]
decoder: AV1: Fix a static analysis problem of update_state().
No need to check the picture pointer after we have already dereferenced it.
Fix: #298
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/408>
He Junyan [Tue, 22 Dec 2020 15:43:52 +0000 (23:43 +0800)]
libs: decoder: Add decode_with_surface_id for AV1 film_grain.
The AV1 film_graim feature needs two surfaces the same time for
decoding. One is for recon surface which will be used as reference
later, and the other one is for display. The GstVaapiPicture should
contain the surface for display, while the vaBeginPicture() need
the recon surface as the target.
We add a gst_vaapi_picture_decode_with_surface_id API to handle this
kind of requirement.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/191>
He Junyan [Thu, 27 Aug 2020 13:46:41 +0000 (21:46 +0800)]
libs: decoder: AV1: Add the av1 decoder support.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/191>
He Junyan [Thu, 27 Aug 2020 13:39:35 +0000 (21:39 +0800)]
libs: codecobject: Add number of elements when create codec object.
One slice data may need several slice parameter buffers at one time.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/191>
Víctor Manuel Jáquez Leal [Sat, 12 Dec 2020 09:30:41 +0000 (10:30 +0100)]
vaapi: use gst_clear_object instead of g_clear_object
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/406>
He Junyan [Tue, 8 Dec 2020 05:34:35 +0000 (13:34 +0800)]
plugins: encode: unlock the stream lock before _flush()
The current encoder will hang when EOS comes. When we call the
gst_vaapi_encoder_encode_and_queue(), we should release the stream
lock, just like what we do in gst_vaapiencode_handle_frame().
The deadlock happens when: The input thread holding the stream lock
is using gst_vaapi_encoder_create_coded_buffer() to acquire a coded
buffer, while the output thread which holding the coded buffer resource
is acquiring the stream lock in _push_frame() to push the data to
down stream element.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/404>
He Junyan [Tue, 8 Dec 2020 16:04:33 +0000 (00:04 +0800)]
libs: encoder: H264: Fix one assert in get_pending_reordered().
gst_vaapi_encoder_h264_get_pending_reordered() does not consider the
case for HIERARCHICAL_B mode. The pipeline:
gst-launch-1.0 videotestsrc num-buffers=48 ! vaapih264enc prediction-type=2 \
keyframe-period=32 ! fakesink
get a assert:
ERROR:../gst-libs/gst/vaapi/gstvaapiencoder_h264.c:1996:reflist1_init_hierarchical_b:
assertion failed: (count != 0)
The last few B frames are not fetched in correct order when HIERARCHICAL_B
is enabled.
We also fix a latent bug for normal mode. The g_queue_pop_tail() of B frames
make the last several frames encoded in reverse order. The NAL of last few
frames come in reverse order in the bit stream, though it can still output
the correct image.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/405>
He Junyan [Thu, 25 Jun 2020 08:25:21 +0000 (16:25 +0800)]
libs: encoder: H265: Add screen content coding extensions support.
In scc mode, the I frame can ref to itself and it needs the L0 reference
list enabled. So we should set the I frame to P_SLICE type. We do not need
to change the ref_pic_list0/1 passed to VA driver, just need to enable the
VAEncPictureParameterBufferHEVC->pps_curr_pic_ref_enabled_flag to notify
the driver consider the current frame as reference. For bits conformance,
the NumRpsCurrTempList0 should be incremented by one to include the current
picture as the reference frame. We manually do it when packing the slice header.
Command line like:
gst-launch-1.0 videotestsrc num-buffers=10 ! \
capsfilter caps=video/x-raw,format=NV12, framerate=30/1,width=640,height=360 ! \
vaapih265enc ! capsfilter caps=video/x-h265,profile="{ (string)screen-extended-main }" ! \
filesink location=out.265
Can be used to specify that the encoder should use SCC profiles.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/379>
He Junyan [Sat, 11 Jul 2020 15:37:29 +0000 (23:37 +0800)]
plugin: encode: vp9: Implement the set_config().
We store the allowed profiles list to encoder in set_config().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/380>
He Junyan [Sat, 11 Jul 2020 15:39:40 +0000 (23:39 +0800)]
plugin: encode: vp9: Add the profile into output caps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/380>
He Junyan [Sat, 11 Jul 2020 15:27:21 +0000 (23:27 +0800)]
libs: encoder: vp9: no need to ensure_hw_profile.
Once we decide the profile and can get the valid entrypoint for
that profile, hw must already support this profile/entrypoint pair.
No need to check it again in set_context_info().
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/380>
He Junyan [Sat, 11 Jul 2020 15:22:55 +0000 (23:22 +0800)]
libs: encoder: vp9: Improve the manner to decide the profile.
We should decide the VP9 encoder's profile based on the chroma and
depth of the input format, then make sure it is included in the
allowed list.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/380>
He Junyan [Sat, 11 Jul 2020 15:17:02 +0000 (23:17 +0800)]
libs: util: vpx: add get_chroma_format_idc for VP9
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/380>
He Junyan [Sat, 11 Jul 2020 15:09:59 +0000 (23:09 +0800)]
libs: encoder: vp9: Add allowed_profiles.
We need the allowed_profiles to store the allowed profiles in down
stream's caps.
Command line like:
vaapivp9enc ! capsfilter caps=video/x-vp9,profile="{ (string)1, \
(string)3 }"
We need to store GST_VAAPI_PROFILE_VP9_1 and GST_VAAPI_PROFILE_VP9_3
in this list.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/380>
He Junyan [Mon, 30 Nov 2020 10:00:30 +0000 (18:00 +0800)]
libs: decoder: H265: Fix a typo in scc reference setting.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/402>
He Junyan [Fri, 17 Jul 2020 10:00:30 +0000 (18:00 +0800)]
libs: decoder: H265: Add MAIN_422_12 profile supporting.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/390>
He Junyan [Fri, 31 Jul 2020 06:38:42 +0000 (14:38 +0800)]
video-format: Add Y212_LE format.
It can be used as HEVC YUV_4:2:2 12bits stream's decoder output, and
also can be used as the input format for encoding HEVC YUV_4:2:2 12bits
stream.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/390>
He Junyan [Thu, 30 Jul 2020 15:21:06 +0000 (23:21 +0800)]
libs: decoder: H265: Add MAIN_444_12 profile supporting.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/390>
He Junyan [Thu, 30 Jul 2020 15:13:10 +0000 (23:13 +0800)]
video-format: Add Y412_LE format.
It can be used as HEVC YUV_4:4:4 12bits stream's decoder output, and
also can be used as the input format for encoding HEVC YUV_4:4:4 12bits
stream.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/390>
He Junyan [Thu, 17 Sep 2020 08:47:43 +0000 (16:47 +0800)]
libs: decoder: h265: fill missing predictor_palette_size field.
The predictor_palette_size of VAPictureParameterBufferHEVCScc is
forgotten and need to be filled when streams have palettes.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/396>
He Junyan [Thu, 17 Sep 2020 07:35:11 +0000 (15:35 +0800)]
libs: utils: h265: Use get_profile_from_sps to get profile.
We now use gst_h265_get_profile_from_sps() to replace the old way
of gst_h265_profile_tier_level_get_profile() to get more precise
profile. The new function consider the unstandard cases and give
a more suitable profile decision.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/395>
Víctor Manuel Jáquez Leal [Mon, 19 Oct 2020 11:46:44 +0000 (13:46 +0200)]
libs: decoder: vp9: 0xff segment pred probs if no temporal update
According to the spec (6.2.11 Segmentation params syntax)
segmentation_pred_prob[i] ast to be 0xff if not temporal_update.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/400>
Víctor Manuel Jáquez Leal [Mon, 19 Oct 2020 11:42:53 +0000 (13:42 +0200)]
libs: decoder: vp9: avoid reference rewriting
The removed code set all the reference frames to the current frame it is a key
one, but later, all the reference frames were rewritten with the decoded picture
buffers or VA_INVALID_SURFACE if they were not available.
Basically, all this time the first reference frame assignment has been ignored,
and it's not described by the spec, and this patch removes that code.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/400>
Víctor Manuel Jáquez Leal [Sun, 20 Sep 2020 07:56:40 +0000 (09:56 +0200)]
decoder: don't reply src caps query with allowed if pad is fixed
If the pad is already fixed the caps query have to be reply with the
current fixed caps. Otherwise the query has to be replied with the
autogeneratd src caps.
This path fix this by falling back to the normal caps query processing
if the pad is already fixed. Otherwise it will fetch the allowed src
pad caps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/397>
He Junyan [Mon, 14 Sep 2020 16:11:30 +0000 (00:11 +0800)]
plugins: decode: fix a DMA caps typo in ensure_allowed_srcpad_caps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/392>
Marc Leeman [Tue, 1 Sep 2020 07:31:33 +0000 (09:31 +0200)]
vaapisink: when updating the caps, reset rotation
When an element upstream changes settings (e.g. crop), new caps are sent
to vaapisink. When vaapisink was rotating the image, it needs to
re-evaluate if the sink needs to rotate the image.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/389>
Tim-Philipp Müller [Tue, 8 Sep 2020 16:31:02 +0000 (17:31 +0100)]
ci: include template from gst-ci master branch again
Tim-Philipp Müller [Tue, 8 Sep 2020 15:59:07 +0000 (16:59 +0100)]
Back to development
Tim-Philipp Müller [Mon, 7 Sep 2020 23:09:51 +0000 (00:09 +0100)]
Release 1.18.0
Sebastian Dröge [Mon, 7 Sep 2020 09:15:43 +0000 (12:15 +0300)]
Update for gst_video_transfer_function_*() function renaming
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/391>
Víctor Manuel Jáquez Leal [Sat, 22 Aug 2020 10:53:12 +0000 (12:53 +0200)]
Revert "libs: decoder: h264, h265: in context at least 16 reference surfaces"
This reverts commit
b387081a4d77d3da202da72686ab40fb9c83ee1e as discussed in
https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/commit/
b387081a4d77d3da202da72686ab40fb9c83ee1e
Tim-Philipp Müller [Thu, 20 Aug 2020 15:16:25 +0000 (16:16 +0100)]
Release 1.17.90
Víctor Manuel Jáquez Leal [Mon, 17 Aug 2020 09:43:53 +0000 (11:43 +0200)]
libs: surface: egl: guard memory type
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/384>
He Junyan [Mon, 17 Aug 2020 11:26:43 +0000 (19:26 +0800)]
plugin: decode: Fix two mem leaks because of caps.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/385>
He Junyan [Sat, 15 Aug 2020 17:57:15 +0000 (01:57 +0800)]
plugin: allocator: No need to ref allocator when create mem.
We do not need to ref the allocator when creating GstVaapiVideoMemory
kind memory, and then release it in _free(). The framework already
does it for us.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/383>
Víctor Manuel Jáquez Leal [Fri, 14 Aug 2020 08:42:51 +0000 (10:42 +0200)]
vaapiencode: h264: ignore level without breaking negotiation
Since commit
9f627ef2 if the user sets level in the encoder src caps
the caps negotiation is rejected.
But since the same commit the same encoder set the autoconfigured
level in caps. Some change in the base class might fixed the operation
order so now the caps are set and later negotiated.
This patch removes the level check.
Fixes: #273
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/382>
Víctor Manuel Jáquez Leal [Tue, 9 Jul 2019 17:17:48 +0000 (19:17 +0200)]
libs: egl: surface: export EGLImage as DMABuf if GEM not supported
This code path is used when frames are rendered as textures through
GstVideoGLTextureUploadMeta with EGL, mainly under Wayland.
Originally the EGLImage was exported as GEM, which was handled by
Intel drivers, but Gallium ones cannot create VA surfaces from
GEM buffers, only DMABuf.
This patch checks the memory types supported by VA driver to choose
the render the EGLImages from GEM or DMABuf, because GEM is still
better where supported.
DMABuf is well handled either by intel-vaapi-driver and gallium.
Fixes: #137
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/122>
Víctor Manuel Jáquez Leal [Tue, 26 May 2020 14:18:32 +0000 (16:18 +0200)]
libs: filter: gst_vaapi_filter_get_memory_types()
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/122>
Víctor Manuel Jáquez Leal [Wed, 12 Aug 2020 16:48:59 +0000 (18:48 +0200)]
plugins: remove gst_vaapi_plugin_base_get_allowed_srcpad_raw_caps()
Since nobody uses it, just remove it.
Thus extract_allowed_surface_formats() is refactored to attend only
gst_vaapi_plugin_base_get_allowed_sinkpad_raw_caps().
Now a surface is created when the image chorma is different from the
previous one. And if the driver has the quirk, it outputs all the
supported image formats without trying them.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/381>
Víctor Manuel Jáquez Leal [Wed, 12 Aug 2020 15:50:50 +0000 (17:50 +0200)]
vaapidecode: expose raw src caps with same chroma
The try-and-error approach for getting the possible image formats from
a surface has brought several problems in different drivers, from
crashes to drop in performance.
Instead of that we change the algorithm to determine the possible
image formats based in the surface chroma: only those available image
formats with same chroma are exposed as possible raw caps.
Do this is important to avoid performance degrading in raw sinks
which doesn't handle NV12 but it does YV12 or I420.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/381>
He Junyan [Fri, 10 Jul 2020 09:05:38 +0000 (17:05 +0800)]
libs: util: h265: use common parser API to get vaapi profiles.
We can reuse H265 parser's API to recognize the correct profile and
then just need to convert them to VAAPI profiles.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/356>
Víctor Manuel Jáquez Leal [Fri, 7 Aug 2020 14:41:49 +0000 (16:41 +0200)]
build: update for gl pkg-config file split
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/378>
Xu Guangxin [Thu, 6 Aug 2020 04:51:27 +0000 (12:51 +0800)]
h264dec: mark remaining frames as unreference before exec_picture_refs_modification
8.2.4.2 required this. Some clips will crash if we do not fill the reference list like this.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/376>
He Junyan [Fri, 31 Jul 2020 10:22:46 +0000 (18:22 +0800)]
libs: encoder: H265: Enable Main 12 profile support.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/375>
He Junyan [Fri, 31 Jul 2020 11:17:39 +0000 (19:17 +0800)]
video format: Fix P012_LE's chrome type typo.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/375>
Jordan Petridis [Tue, 4 Aug 2020 18:15:01 +0000 (21:15 +0300)]
gstvaapiminiobject.c: fix clang 10 warnings
the typesystem checks in g_atomic_pointer_compare_and_exchange
seem to trigger some false positives with clang 10
similar to gstreamer!584
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/377>
Michael Olbrich [Fri, 31 Jul 2020 09:07:23 +0000 (11:07 +0200)]
libs: window: wayland: destroy all wayland buffers during finalize
Some buffers and the associated FrameState state may still be pending at
that point. If the wayland connection is shared, then messages for the
buffer may still arrive. However, the associated event queue is already
deleted. So the result is a crash.
With a private connection the associated memory is leaked instead.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/342>
Michael Olbrich [Thu, 18 Jun 2020 18:25:18 +0000 (20:25 +0200)]
test: vaapicontext: fix draw callback with multiple videos
The callback is called for both windows. So make sure that
gst_video_overlay_set_render_rectangle() is called for the correct one.
Otherwise, the left video will be randomly moved behind the right video.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/342>
Michael Olbrich [Fri, 19 Jun 2020 07:23:52 +0000 (09:23 +0200)]
test: vaapicontext: support wayland display
On Wayland, The whole gtk window is one Wayland surface. So
gtk_widget_get_window() must be called on the top-level widget.
For any other widget the following gdk_window_ensure_native() may create a
new top-level Wayland surface that is never visible.
As a result, the coordinates passed to
gst_video_overlay_set_render_rectangle() must be relativ to the top-level
window. Otherwise the video is placed incorrectly.
Original-Patch-By: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/342>
Víctor Manuel Jáquez Leal [Fri, 1 Dec 2017 19:18:28 +0000 (20:18 +0100)]
test: vaapicontext: use playbin to test files
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/342>
Víctor Manuel Jáquez Leal [Wed, 29 Nov 2017 10:11:39 +0000 (11:11 +0100)]
test: vaapicontext: add PLAY and NULL buttons
They only appear when only one sink is instanciated and their purpose
is to test the NULL-PLAY use case in context sharing.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/342>
Michael Olbrich [Fri, 19 Jun 2020 19:26:52 +0000 (21:26 +0200)]
libs: wayland: update the opaque region in set_render_rect
gst_vaapi_window_wayland_set_render_rect() may be called from an arbitrary
thread. That thread may be responsible for making the window visible.
At that point another thread will block in gst_vaapi_window_wayland_sync()
because the frame callback will not be called until the window is visible.
If that happens, then acquiring the display lock in
gst_vaapi_window_wayland_set_render_rect() would result in a deadlock.
Cache the size of the opaque rectangle separately and create the opaque
region right before applying it to the surface.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/342>
Hyunjun Ko [Fri, 19 Jun 2020 07:21:16 +0000 (09:21 +0200)]
libs: window: implements gst_vaapi_window_set_render_rectangle
Implements new vmethod gst_vaapi_window_set_render_rectangle,
which is doing set the information of the rendered rectangle set by
user.
This is necessary on wayland at least to get exact information of
external surface.
And vaapisink calls this when gst_video_overlay_set_render_rectangle is
called.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/342>
Hyunjun Ko [Wed, 8 Nov 2017 04:23:39 +0000 (13:23 +0900)]
vaapisink: implements gst_vaapisink_wayland_create_window_from_handle()
Implements gst_vaapisink_wayland_create_window_from_handle() to support
using external wl_surface.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/342>
Michael Olbrich [Fri, 19 Jun 2020 07:11:20 +0000 (09:11 +0200)]
libs: wayland: implement video overlay API
The Wayland sub-surfaces API is used to embed the video into an application
window.
See Appendix A. Wayland Protocol Specification as the following.
"""
The aim of sub-surfaces is to offload some of the compositing work
within a window from clients to the compositor. A prime example is
a video player with decorations and video in separate wl_surface
objects.
This should allow the compositor to pass YUV video buffer processing to
dedicated overlay hardware when possible.
"""
Added new method gst_vaapi_window_wayland_new_with_surface()
Original-Patch-By: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
Zhao Halley <halley.zhao@intel.com>
changzhix.wei@intel.com
Hyunjun Ko <zzoon@igalia.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/342>
Michael Olbrich [Fri, 19 Jun 2020 19:54:52 +0000 (21:54 +0200)]
doc: libs: wayland: add 'transfer full' to the returnvalye of gst_vaapi_window_wayland_new
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/342>
Michael Olbrich [Thu, 11 Jun 2020 06:25:57 +0000 (08:25 +0200)]
libs: display: always call close_display()
All close_display() have their own checks for use_foreign_display and only
destroy locally created objects in that case.
Without this objects other than the actuall foreign display itself are
leaked.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/342>
He Junyan [Thu, 30 Jul 2020 15:37:10 +0000 (23:37 +0800)]
video-format: Add the missing P012_LE into GST_VAAPI_FORMATS_ALL.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/373>
Víctor Manuel Jáquez Leal [Mon, 25 May 2020 15:02:26 +0000 (17:02 +0200)]
plugins: add gst_vaapi_caps_set_width_and_height_range()
This utility function is called internally by
gst_vaapi_build_caps_from_formats() and can be used outside.
This function sets frame size and framerates ranges.
Also gst_vaapi_build_caps_from_formats() is simplified.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/374>
He Junyan [Fri, 31 Jul 2020 07:27:38 +0000 (15:27 +0800)]
libs: decoder: fix a crash issue when get_surface_formats.
Some context does not report any valid format that we can support.
For example, the HEVC 444 12 bits decoder context, all the formats
it reports is not supported now, which make the formats list a NULL
array. We should check that pointer before we use it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/372>
He Junyan [Fri, 3 Jul 2020 11:28:28 +0000 (19:28 +0800)]
libs: encoder: h265: choose the profile based on allowed list.
We can decide the profile in ensure_profile(), based on allowed list
passed by the encode. We also need to check whether the entrypoint is
available. Once it is decided, no need to check the hw entrypoint
them again.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/349>
He Junyan [Wed, 29 Jul 2020 14:05:41 +0000 (22:05 +0800)]
plugins: encode: h265: set all allowed profiles to encoder.
We should collect all allowed profiles and pass them to the inside
encoder, rather than just calculate the max profile idc.
The allowed profiles should also be supported by the HW.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/349>
He Junyan [Wed, 29 Jul 2020 14:32:55 +0000 (22:32 +0800)]
libs: display: Add a helper function to get profiles by codec.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/349>
He Junyan [Thu, 2 Jul 2020 17:28:28 +0000 (01:28 +0800)]
plugins: encode: h265: collect all allowed profiles to encoder.
We should collect all allowed profiles and pass them to the inside
encoder, rather than just calculate the max profile idc.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/349>
He Junyan [Thu, 2 Jul 2020 16:53:31 +0000 (00:53 +0800)]
libs: encoder: h265: modify set_max_profile to set_allowed_profiles.
In h265, bigger profile idc may not be compatible with the small profile
idc. And more important, there are multi profiles with the same profile
idc. Such as main-422-10, main-444 and main-444-10, they all have profile
idc 4.
So recording the max profile idc is not enough, the encoder needs to know
all allowed profiles when deciding the real profile.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/349>
He Junyan [Thu, 2 Jul 2020 15:33:31 +0000 (23:33 +0800)]
libs: encoder: h265: No need to check hw_max_profile.
In h265, higher profile idc number does not mean better compression
performance and may be not compatible with the lower profile idc.
So, it is not suitable to find the heighest idc for hw to ensure the
compatibility.
On the other side, when the entrypoint of the selected profile is valid,
it means the hw really support this profile, no need to check it again.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/349>
Víctor Manuel Jáquez Leal [Wed, 8 Apr 2020 17:41:09 +0000 (19:41 +0200)]
vaapipostproc: early return if fixate srcpad caps fails
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/371>
Víctor Manuel Jáquez Leal [Wed, 29 Jul 2020 11:39:44 +0000 (13:39 +0200)]
vaapipluginutil: simplify gst_vaapi_find_preferred_caps_feature()
Generalize the way how the preferred color format is chosen. Also
use new GStreamre API as syntatic sugar.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/370>
He Junyan [Wed, 29 Jul 2020 06:22:18 +0000 (14:22 +0800)]
libs: profile: Use get_codec_from_caps to get codec type.
There is no need to get a profile from the caps and then convert
that profile into codec type. We can get the codec type by caps's
name easily.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/358>
He Junyan [Sun, 12 Jul 2020 11:42:40 +0000 (19:42 +0800)]
libs: profile: h265: Fix return value of from_codec_data_h265.
profile_from_codec_data_h265() returns wrong GstVaapiProfile for h265.
The codec data of caps contain the profile IDC, but the mapping between
profile IDC and GstVaapiProfile is wrong.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/358>
He Junyan [Mon, 6 Jul 2020 16:46:23 +0000 (00:46 +0800)]
plugins: encode: vp9: Implement vp9's allowed_profiles() func.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/188>
He Junyan [Wed, 8 Jul 2020 08:30:17 +0000 (16:30 +0800)]
plugin: util: rename h26x_encoder_get_profiles_from_caps().
Change its name to encoder_get_profiles_from_caps(). Other codecs such
as VP9 also needs to use this function.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/188>
He Junyan [Mon, 6 Jul 2020 15:35:12 +0000 (23:35 +0800)]
libs: utils: vpx: Add utils vpx to handle VP8/9 misc things.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/188>
Víctor Manuel Jáquez Leal [Wed, 29 Jul 2020 08:17:31 +0000 (10:17 +0200)]
libs: display, context: handle broken jpeg decoder for i965 driver
JPEG decoding in i965 driver is pretty much broken, and the driver is
deprecated which mean authors only accept trivial fixes.
Surfaces for JPEG decoder context in i965 only handle IMC3[1] color
format which is not a common format in GStreamer. It can export it to
I420 at mapping raw bytes, but DMABuf exporting is problematic.
This patch artificially adds NV12 to the context format list when it's
JPEG decoder for i965 and force the usage of old VA-API for surface
creation without specifying color format. Also it artificially
disables the DMABuf announcement.
1. https://docs.microsoft.com/en-us/windows/win32/medfound/recommended-8-bit-yuv-formats-for-video-rendering#420-formats-16-bits-per-pixel
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/369>
Víctor Manuel Jáquez Leal [Wed, 29 Jul 2020 10:02:50 +0000 (12:02 +0200)]
libs: context: change function to internal code style
Instead of a getter the function `get_preferred_format()` to
`ensure_preferred_format()` which aligns to the code style.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/369>
Víctor Manuel Jáquez Leal [Tue, 28 Jul 2020 18:00:09 +0000 (20:00 +0200)]
vaapidecode: always merge profile caps in sink caps
This commit fixes a regression of
e962069d, where if the profile's
caps doesn't have a caps profile, it's ignored.
This patch add a conditional jump if the caps doesn't have a profile
field to merge it.
Fixes: #271
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/-/merge_requests/368>