Krzysztof Wicher [Thu, 27 Jun 2019 17:14:05 +0000 (10:14 -0700)]
Fix BytesConsumed when skipping single line comments (multi-segment) (dotnet/corefx#38965)
* Fix BytesConsumed when skipping single line comments (multi-segment)
* rename ret -> skipSucceeded
Commit migrated from https://github.com/dotnet/corefx/commit/
32f061ccb2d2b6a804f8040717f448d97cbf862d
Santiago Fernandez Madero [Thu, 27 Jun 2019 13:58:49 +0000 (06:58 -0700)]
Tweak custom nullable attributes based on API Review (dotnet/corefx#38977)
Commit migrated from https://github.com/dotnet/corefx/commit/
7dce7868e3b3023ee96edebb96042ca01a8ec368
Jan Kotas [Thu, 27 Jun 2019 06:29:32 +0000 (23:29 -0700)]
Update SDK to 3.0.100-preview7 (dotnet/corefx#38964)
Validate fix for dotnet/coreclrdotnet/corefx#25427
Commit migrated from https://github.com/dotnet/corefx/commit/
6d723b8e5ae3129c0a94252292322fc19673478f
David Cantu [Thu, 27 Jun 2019 01:03:44 +0000 (18:03 -0700)]
Fixed address and port formatting for TCs to use portNumber instead of i incremental (dotnet/corefx#38962)
Commit migrated from https://github.com/dotnet/corefx/commit/
488a6fca1b9f7a9b8c8a945259e8f9e92ef073d3
Jeremy Kuhne [Wed, 26 Jun 2019 23:16:42 +0000 (16:16 -0700)]
Fix array size used by LookupOverflow json test (dotnet/corefx#38961)
dotnet/corefx#37911 fixed a 2x overstimation of the possible byte size of a converted UTF-16 string. The outerloop test that was validating the code wasn't updated to match.
fixes dotnet/corefx#38221
Commit migrated from https://github.com/dotnet/corefx/commit/
7e6534becebff78b567d57c39021a9f511acf140
Frederik Carlier [Wed, 26 Jun 2019 22:32:15 +0000 (00:32 +0200)]
System.Drawing: Consolidate BitmapData class (dotnet/corefx#38838)
* Add shared BitmapData class
* Consolidate BitmapData class
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
e78cb04d339aa9206b6db8eb8224904ecc4529e1
Jeremy Barton [Wed, 26 Jun 2019 22:07:46 +0000 (15:07 -0700)]
Prevent OpenSSL unload at process exit (dotnet/corefx#38936)
* Set OPENSSL_INIT_NO_ATEXIT to prevent shutdown errors from crashing on string lookup
* Fix compilation with 1.1.0 headers
* Remove semi-redundant define of OPENSSL_INIT_NO_ATEXIT
Commit migrated from https://github.com/dotnet/corefx/commit/
324f8ee8c2b0bb5ec316421159f5d3a10f6b6908
Hugh Bellamy [Wed, 26 Jun 2019 22:02:58 +0000 (23:02 +0100)]
Remove dead remoting IUnimplemented code from TypeDescriptor (dotnet/corefx#38940)
Commit migrated from https://github.com/dotnet/corefx/commit/
def264136eb89eeb204ddd90b8781979a703dcbe
Geoff Kizer [Wed, 26 Jun 2019 21:59:38 +0000 (14:59 -0700)]
improve write buffer management and fix buffer size calculation in SendHeadersAsync (dotnet/corefx#38953)
* improve write buffer management and fix buffer size calculation in SendHeadersAsync
* review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
6c6545143ac5bd4c438fad790899124312e1ffe1
Tomáš Matoušek [Wed, 26 Jun 2019 21:30:02 +0000 (14:30 -0700)]
Remove incorrect statement from Portable PDB spec (dotnet/corefx#38963)
Commit migrated from https://github.com/dotnet/corefx/commit/
d91384ac28ecf8e3ac7bae769cd542c2e00717ed
Krzysztof Wicher [Wed, 26 Jun 2019 19:50:43 +0000 (12:50 -0700)]
Utf8JsonReader: Do not allow non-standard line endings in single-line comments (dotnet/corefx#38036)
* Fix handling comments
* Apply feedback, unify Consume and Skip for multi-segment
* address some missed comments
* micro changes
* replace tab with spaces
* apply feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
fc8bd8ec1c622dd27f96d05f1bf05909f3b3cde0
Geoff Kizer [Wed, 26 Jun 2019 19:31:58 +0000 (12:31 -0700)]
Merge pull request dotnet/corefx#38918 from geoffkizer/ignoreframesonclosedstream
ignore invalid frames on closed streams
Commit migrated from https://github.com/dotnet/corefx/commit/
b9c89c4fe2454268a5e883ab269c877287f703ed
Ahson Khan [Wed, 26 Jun 2019 19:01:47 +0000 (12:01 -0700)]
Move Comment token type within the TokenType enum. (dotnet/corefx#38950)
* Move Comment token type within the TokenType enum.
* Fix JsonTokenType to JsonValueType mapping.
* Moves Comment down after PropertyName and address feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
8e5cacf4578feea6ffc533700bcd0e3ebd99c4e3
Jose Perez Rodriguez [Wed, 26 Jun 2019 18:59:59 +0000 (11:59 -0700)]
Making Exceptions serializable (dotnet/corefx#38893)
* Making Exceptions serializable
* Remove EventLog serialization exceptions from tests since they won't work on non-Windows platforms
* Fix build and add internal exceptions as well
* Add parameter-less constructor to RethrowException
* Adding PR Feedback
* Fix allConfigurations build
Commit migrated from https://github.com/dotnet/corefx/commit/
7075587321a1b6b59248b1a6c7ea04fc803eab96
Ahson Khan [Wed, 26 Jun 2019 18:59:32 +0000 (11:59 -0700)]
Do not pass ReadOnlySequence by "in" to the Utf8JsonReader. (dotnet/corefx#38930)
* Do not pass ReadOnlySequence by "in" to the Utf8JsonReader.
* Remove in from the new ctor as well.
Commit migrated from https://github.com/dotnet/corefx/commit/
563bbef3ed9c7029238ae9dbaf61129deee3c53f
Ahson Khan [Wed, 26 Jun 2019 18:58:52 +0000 (11:58 -0700)]
Rename JsonValueType to JsonValueKind and JsonElement.Type to JsonElement.ValueKind. (dotnet/corefx#38943)
* Add JsonDocument.Write, JsonProperty.Write, and rename JsonValueTupe to
JsonValueKind.
* Add JsonDocument.Write API tests.
* Don't use GetPropertyRawBytes and add JsonProperty.Write API tests.
* Make GetPropertyRawValue private again.
* Remove the new Write APIs on JsonDocument, JsonProperty.
Commit migrated from https://github.com/dotnet/corefx/commit/
f08256cbba2b249cc1e5ca67cf4a1c074adf035b
Anirudh Agnihotry [Wed, 26 Jun 2019 18:54:06 +0000 (11:54 -0700)]
Tests for nullable reference types in Span apis (dotnet/corefx#38625)
* Some more null index checks
* adding test for ReadonlySpan overload and refactoring all overloads into a single test
* FIxing the tests with ben change and rebasing
Commit migrated from https://github.com/dotnet/corefx/commit/
96a713d3434af8d443f87874e915f5d36c47a564
Steve Harter [Wed, 26 Jun 2019 18:41:29 +0000 (11:41 -0700)]
Allow Ignore and JsonName attributes to use same property name (dotnet/corefx#38935)
* Allow Ignore and JsonName attributes to use same property name
* Merge
Commit migrated from https://github.com/dotnet/corefx/commit/
0fcf8096d10f8a4192f8ff7281f49d3ae1621b7f
Steve Harter [Wed, 26 Jun 2019 18:11:04 +0000 (11:11 -0700)]
Remove converter Write() that takes property name (dotnet/corefx#38932)
Commit migrated from https://github.com/dotnet/corefx/commit/
d33be8575490a723395f7fcce1be1fd735405406
Santiago Fernandez Madero [Wed, 26 Jun 2019 17:51:01 +0000 (10:51 -0700)]
Fix nullable annotations for EventRegistrationTokenTable<T> (dotnet/corefx#38942)
Commit migrated from https://github.com/dotnet/corefx/commit/
deb5c2bebdc7d50a9c3ef1be87aee091e56894b6
Ahson Khan [Wed, 26 Jun 2019 17:49:53 +0000 (10:49 -0700)]
Add simpler Utf8JsonReader ctors that dont require JsonReaderState or IsFinalBlock. (dotnet/corefx#38868)
* Add simpler Utf8JsonReader ctors that dont require JsonReaderState or
IsFinalBlock.
* Update ctors and add tests for simple ctor.
* Address PR feedback.
* Implement the convenience ctor over the existing one.
* Update new tests to remove the BytesConsumed, Position usage.
Commit migrated from https://github.com/dotnet/corefx/commit/
7f8333149a0f24fc3f007eefb976118cf9ab06c5
buyaa-n [Wed, 26 Jun 2019 17:37:12 +0000 (10:37 -0700)]
Check uncompressed size before decompressing a zip file. Fixes 33058 (dotnet/corefx#38314)
Account uncompressed size while decompressing a zip file. Fixes 33058
I am sure now the fix is good enough for merging, if anyone has more question/comment please let me know/comment
Commit migrated from https://github.com/dotnet/corefx/commit/
cece0df13a74d188f96b08ae5af0cd4cd60f8f76
Geoff Kizer [Wed, 26 Jun 2019 16:29:55 +0000 (09:29 -0700)]
fix connection level window accounting
Commit migrated from https://github.com/dotnet/corefx/commit/
50b8897591b64c0cecc4561b6a314c4149350bef
Cory Nelson [Wed, 26 Jun 2019 16:16:08 +0000 (09:16 -0700)]
Add HPACK integer validation to prevent wrapping and overlong encodings. (dotnet/corefx#38910)
* Add HPACK integer validation to prevent wrapping and overlong encodings. Resolves dotnet/corefx#38626.
* Improve documentation and add an assert to help avoid confusion and misuse of IntegerDecoder.StartDecode.
Commit migrated from https://github.com/dotnet/corefx/commit/
5b29cd3efe43f83bee732263e4113448ae60d4d3
Geoff Kizer [Wed, 26 Jun 2019 16:07:01 +0000 (09:07 -0700)]
ignore frame processing callbacks on aborted streams
Commit migrated from https://github.com/dotnet/corefx/commit/
281fdc6ba485126258466ea5c1486c79c46f8dbb
Krzysztof Wicher [Wed, 26 Jun 2019 15:49:50 +0000 (08:49 -0700)]
Clear plaintext when AesCcm authentication fails (dotnet/corefx#38899)
* Re-enable disabled AesCcm test cases
* Clear plaintext on failure
Commit migrated from https://github.com/dotnet/corefx/commit/
b958f70b06826095c5b0e15bb566f300b96094ce
Ahson Khan [Wed, 26 Jun 2019 15:30:30 +0000 (08:30 -0700)]
Rename JsonSerializer.Parse/ToString to Deserialize/Serialize. (dotnet/corefx#38933)
* Rename JsonSerializer.Parse/ToString to Deserialize/Serialize.
* Update the API names in source/tests.
* Update other API calls in the tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
32776a3e25aa5b47c96ea2dd588c2201ca18a048
Ahson Khan [Wed, 26 Jun 2019 15:26:34 +0000 (08:26 -0700)]
Fix typo while merging conflicting PRs (s_readerOptions was renamed to s_options) (dotnet/corefx#38934)
Commit migrated from https://github.com/dotnet/corefx/commit/
a72deda9c19ca48bc5ec81650f5b4d7da780d75f
dotnet-maestro[bot] [Wed, 26 Jun 2019 14:57:30 +0000 (14:57 +0000)]
[master] Update dependencies from dotnet/coreclr (dotnet/corefx#38929)
* Update dependencies from https://github.com/dotnet/coreclr build
20190625.3
- Microsoft.NET.Sdk.IL - 3.0.0-preview7.19325.3
- Microsoft.NETCore.ILAsm - 3.0.0-preview7.19325.3
- Microsoft.NETCore.Runtime.CoreCLR - 3.0.0-preview7.19325.3
* Adapt to ResourceManager.BaseName behavior change
Commit migrated from https://github.com/dotnet/corefx/commit/
38ac1edd43d27f8d1133156a09e91916e66f9701
Ahson Khan [Wed, 26 Jun 2019 14:35:09 +0000 (07:35 -0700)]
Remove BytesConsumed and Position from JsonReaderState. (dotnet/corefx#38928)
* Remove BytesConsumed and Position from JsonReaderState.
* Fix the tests that were not properly restoring state.
* Disable failing test that was written incorrectly, previously.
Commit migrated from https://github.com/dotnet/corefx/commit/
faa6ab48904c98147bef5754b74eac1fb5fe1af0
Ahson Khan [Wed, 26 Jun 2019 14:32:53 +0000 (07:32 -0700)]
Add JsonElement.WriteProperty that takes JsonEncodedText. (dotnet/corefx#38869)
* Add JsonElement.WriteProperty that takes JsonEncodedText.
* Add tests.
* Auto-gen the ref.
Commit migrated from https://github.com/dotnet/corefx/commit/
5134166832b430ccf2d05193cda9036d9a55356b
Ahson Khan [Wed, 26 Jun 2019 14:29:43 +0000 (07:29 -0700)]
Add JsonDocumentOptions and use that instead of JsonReaderOptions. (dotnet/corefx#38866)
* Add JsonDocumentOptions and use that instead of JsonReaderOptions.
* Address PR feedback.
* Auto-generate the reference assembly.
* Auto-gen the ref from the source.
* Explicitly mark property getters as readonly.
* Cleanup and fix converter argument name to typeToConvert.
Commit migrated from https://github.com/dotnet/corefx/commit/
e4d329737f0ab5c413c98a90ff485f91fd3f5fd0
Stephen Toub [Wed, 26 Jun 2019 14:24:55 +0000 (10:24 -0400)]
Add test for sync completion behavior with multiple awaits (dotnet/corefx#38812)
* Add test for sync completion behavior with multiple awaits
* Remove SkipOnTargetFramework for netfx
Commit migrated from https://github.com/dotnet/corefx/commit/
cf5787ca4d7a29b0f34cd103c5b8207cd74a6216
Kevin Jones [Wed, 26 Jun 2019 14:03:10 +0000 (10:03 -0400)]
Validate RSA parameters when importing to OpenSSL
This imports a key explicitly into the OpenSSL default software RSA implementation to call
`RSA_check_key` to determine that the key parameters are consistent.
After the key consistency is determined, then it imports into a second new key handle, using the
configured default (which may also be the default software RSA implementation), and returns that one.
Commit migrated from https://github.com/dotnet/corefx/commit/
5590a9172a65be8cd6f93fdd76f547e63006c837
Ahson Khan [Wed, 26 Jun 2019 13:57:12 +0000 (06:57 -0700)]
Add more Utf8JsonWriter.WritePropertyName test cases. (dotnet/corefx#38921)
* Revert "Fix build break for TestHelpers, move to common and rename to MemoryTestHelpers"
This reverts commit dotnet/corefx@
61f9b4c44336a7e32f8679e0a186a9177d384c49.
* Add more Utf8JsonWriter.WritePropertyName test cases.
Commit migrated from https://github.com/dotnet/corefx/commit/
42b4bf7af587942429fbd9775d7edc8850312dcb
Steve Harter [Wed, 26 Jun 2019 13:46:23 +0000 (06:46 -0700)]
Performance improvements on property lookup (dotnet/corefx#38902)
Commit migrated from https://github.com/dotnet/corefx/commit/
5e6c939705fd23e81d2a74c4a00e236a3d4289b5
Frederik Carlier [Wed, 26 Jun 2019 13:41:44 +0000 (15:41 +0200)]
Fix and re-enable AddFontFile_Directory_ThrowsFileNotFoundException test, rename GetAdjustedPalette_InvalidTypes_ThrowsArgumentException (dotnet/corefx#38873)
* Fix and re-enable AddFontFile_Directory_ThrowsFileNotFoundException test
* Accept Desktop exception, too.
* Avoid two unit test with the same name
Commit migrated from https://github.com/dotnet/corefx/commit/
d73a90663d15b7d80dcecb026b37d3b87267d116
Dan Moseley [Wed, 26 Jun 2019 13:36:14 +0000 (06:36 -0700)]
Disable some tests for Windows IoT (dotnet/corefx#38912)
* Disable for IoT
* IconConverter tests
* S.DS
* S.DS.AM
* typo
* Fact to Theory
Commit migrated from https://github.com/dotnet/corefx/commit/
56e68cff21c62181bb0b8d8d3302cbbbeef8eb57
Geoff Kizer [Wed, 26 Jun 2019 08:47:41 +0000 (01:47 -0700)]
ignore invalid frames on closed streams
Commit migrated from https://github.com/dotnet/corefx/commit/
10ae10869a86e0ad9dc2d789b2da0c9b9acec2c1
buyaa-n [Wed, 26 Jun 2019 07:27:55 +0000 (00:27 -0700)]
Enable fixed tests, formatting update (dotnet/corefx#38909)
Commit migrated from https://github.com/dotnet/corefx/commit/
219b67118e3a2d539afc1ff3bb2c10e1bc7b03d2
Mandar Sahasrabuddhe [Wed, 26 Jun 2019 07:27:00 +0000 (12:57 +0530)]
CoreFx dotnet/corefx#38894: Use (s)byte and (u)int16 get apis (dotnet/corefx#38905)
Commit migrated from https://github.com/dotnet/corefx/commit/
dad20ba6f801ac7089f73b828ea2296b0d1348f9
Cory Nelson [Wed, 26 Jun 2019 07:04:36 +0000 (00:04 -0700)]
Implement MaxResponseHeadersLength for HTTP2 (dotnet/corefx#38560)
Implement MaxResponseHeadersLength for HTTP2. Resolves dotnet/corefx#35528.
Implement huffman-coded header support in Http2LoopbackServer.
Move HuffmanDecodingTests from functional to unit tests to avoid reflection.
Commit migrated from https://github.com/dotnet/corefx/commit/
f0ec881bbb7945e35e3cf6862ea309b1143659f7
Dan Moseley [Wed, 26 Jun 2019 02:44:22 +0000 (19:44 -0700)]
Default distro version for tests (dotnet/corefx#38860)
* Default distro version for tests
* Move it
* typo
* typo
* Update PlatformApis.Unix.cs
Commit migrated from https://github.com/dotnet/corefx/commit/
4f0d10773ccbb4849b869b6a0a73d5938f1804bd
Anirudh Agnihotry [Wed, 26 Jun 2019 01:48:20 +0000 (18:48 -0700)]
Checking if the eventlog registry key is actually an eventlog (dotnet/corefx#38430)
* checking if the eventlog registry key is actually an eventlog
* optimising the code a little bit
* modified test
* skipping test on .net frameworj
Commit migrated from https://github.com/dotnet/corefx/commit/
18f5e7b7f9c13b309f7ac978747c828ed417e543
Ahson Khan [Tue, 25 Jun 2019 22:07:36 +0000 (15:07 -0700)]
Add WritePropertyName standlone API on the Utf8JsonWriter. (dotnet/corefx#38864)
* Add WritePropertyName standlone API on the Utf8JsonWriter.
* Fix write indented, add more tests, and more debug.asserts.
* Remove _isProperty field and rely on _tokenType ==
JsonTokenType.PropertyName
* Auto-gen the ref.
* Address PR feedback.
Commit migrated from https://github.com/dotnet/corefx/commit/
a5b35f5600b615d4f30c64183891c83fd76bf491
Jan Kotas [Tue, 25 Jun 2019 20:11:52 +0000 (13:11 -0700)]
Remove IFormattable implementations on intrinsic Vector types
Commit migrated from https://github.com/dotnet/corefx/commit/
aba8dac72c4a672305b25a1a9a05befad1a55c70
Ahson Khan [Tue, 25 Jun 2019 21:14:47 +0000 (14:14 -0700)]
Add better validation for JsonCommentHandling enum and re-order the values. (dotnet/corefx#38622)
* Add validation for JsonCommentHandling enum.
* Address PR feedback.
* Fix typos and make the checks consistent.
* Add parameter name to the argument OOR exception and update tests.
Commit migrated from https://github.com/dotnet/corefx/commit/
0691e5ffc5b569730688f0a61aa63555db2b1e47
Viktor Hofer [Tue, 25 Jun 2019 20:45:17 +0000 (22:45 +0200)]
Normalize generate ref source paths correctly (dotnet/corefx#38870)
* Normalize generate ref source paths correctly
* Trim trailing slash from RefPath
Commit migrated from https://github.com/dotnet/corefx/commit/
27411a58170810f6334a722ae73e8354601dcb85
Brennan [Tue, 25 Jun 2019 20:32:00 +0000 (13:32 -0700)]
Fix infinite loop in JsonSerializer.WriteValue (dotnet/corefx#38892)
Commit migrated from https://github.com/dotnet/corefx/commit/
98937e7f1d4882395722dedadcf57df23d0ea13f
Tanner Gooding [Tue, 25 Jun 2019 19:46:27 +0000 (12:46 -0700)]
Fixing up HandleNull in JsonSerializer.Read to reset the property for dictionaries. (dotnet/corefx#38704)
* Fixing up HandleNull in JsonSerializer.Read to reset the property for dictionaries.
* Adding regression tests for dotnet/corefx#38565
* Fixing HandleDictionary in JsonSerializer.Write to respect IgnoreNullValues
* Updating the Regression38565_Serialize test to not expect null
* Responding to PR feedback and adding a regression test for dotnet/corefx#38557
Commit migrated from https://github.com/dotnet/corefx/commit/
78e00d4b0ad5b390c9a54431c632062392c3ed7e
Tarek Mahmoud Sayed [Tue, 25 Jun 2019 19:45:33 +0000 (12:45 -0700)]
Preserve more envirnment variables during tests remote execution (dotnet/corefx#38889)
Commit migrated from https://github.com/dotnet/corefx/commit/
3b25185ca127fdb8e31fc51854ce44484c758143
Mandar Sahasrabuddhe [Tue, 25 Jun 2019 19:03:33 +0000 (00:33 +0530)]
CoreFx dotnet/corefx#36125 (Try)Get for byte sbyte short ushort (dotnet/corefx#38469)
* CoreFx dotnet/corefx#36125 (Try)Get for byte sbyte short ushort
* Init out values on failure return paths.
* APIs in JsonElement and related tests
* More test cases, test bug fixes, code fixes
Commit migrated from https://github.com/dotnet/corefx/commit/
b2af402ee9f169be00b4be09887e6db0dba2bff1
William Godbe [Tue, 25 Jun 2019 19:00:44 +0000 (12:00 -0700)]
Disable failing Process test (dotnet/corefx#38885)
Commit migrated from https://github.com/dotnet/corefx/commit/
e4d34071b2049268283676152a61d1ed2cd52879
Ahson Khan [Tue, 25 Jun 2019 18:36:15 +0000 (11:36 -0700)]
Use SpanTestHelpers from Common within StringTests rather than TestHelpers which doesn't exist (dotnet/corefx#38865)
* Revert "Fix build break for TestHelpers, move to common and rename to MemoryTestHelpers"
This reverts commit dotnet/corefx@
61f9b4c44336a7e32f8679e0a186a9177d384c49.
* Use SpanTestHelpers from Common rather than TestHelpers which doesn't
exist.
Commit migrated from https://github.com/dotnet/corefx/commit/
edbee902747970e86dbcf19727e72b8216946bb8
Tanner Gooding [Tue, 25 Jun 2019 18:11:44 +0000 (11:11 -0700)]
Adding tests covering the scenario listed in dotnet/corefx#38643 (dotnet/corefx#38696)
Commit migrated from https://github.com/dotnet/corefx/commit/
2439b9a00bd3a8c4e4714470fee4f224978b5678
Stephen Toub [Tue, 25 Jun 2019 15:39:51 +0000 (11:39 -0400)]
Disable nano in PR CI (dotnet/corefx#38883)
Commit migrated from https://github.com/dotnet/corefx/commit/
16dd0366218f18065eb31e0f59bb0c0b63b62954
Kevin Jones [Tue, 25 Jun 2019 14:45:59 +0000 (10:45 -0400)]
Support additional OIDs for SignedCms digest algorithms
If an existing CMS has a digest algorithm identifier of {Digest}withRSA, the algorithm will be treated as unknown, however this works in the Desktop .NET Framework. This adds support for those algorithm identifiers for signature verification, but not for creation.
Commit migrated from https://github.com/dotnet/corefx/commit/
e40dbeb9c4adfec29e291e11e98d92924efea673
Yoh Deadfall [Tue, 25 Jun 2019 14:18:12 +0000 (17:18 +0300)]
Added reflection emit member accessor (dotnet/corefx#38233)
Commit migrated from https://github.com/dotnet/corefx/commit/
25374d33af29283db17bab255971b3f6f17c0fbf
Jeremy Barton [Tue, 25 Jun 2019 13:47:49 +0000 (06:47 -0700)]
Fix exception type tested for in SignerIdentifierType_InvalidValues (dotnet/corefx#38847)
Commit migrated from https://github.com/dotnet/corefx/commit/
df7147a81d664c1462bfa6e7bc2042b2afca4072
Viktor Hofer [Tue, 25 Jun 2019 13:23:21 +0000 (15:23 +0200)]
Update docker images on linux (dotnet/corefx#38867)
Commit migrated from https://github.com/dotnet/corefx/commit/
c12b7dcd08eda9489d88fa808707fda28f60b24d
Stephen Toub [Tue, 25 Jun 2019 12:49:25 +0000 (08:49 -0400)]
Remove TargetSite checks from DictionaryConcurrentAccessDetection (dotnet/corefx#38856)
Commit migrated from https://github.com/dotnet/corefx/commit/
836ebdb1128a0137d7d3337a2c240856c1085e86
Stephen Toub [Tue, 25 Jun 2019 04:59:16 +0000 (00:59 -0400)]
Fix XmlLicenseTransformTest.ItDecryptsLicense test
Use a phrase that can't be valid base64.
Commit migrated from https://github.com/dotnet/corefx/commit/
60d8aa31a4c1ffa0e125bd7941aca171439a2f72
Cory Nelson [Tue, 25 Jun 2019 00:49:33 +0000 (17:49 -0700)]
Merge pull request dotnet/corefx#38854 from scalablecory/fix-ShutdownIgnoringErrorsAsync
Eat SocketException during Http2LoopbackConnection.ShutdownIgnoringErrorsAsync
Commit migrated from https://github.com/dotnet/corefx/commit/
d36898b35b10eb6f7ad07023b1fca94640e78ecc
Cory Nelson [Tue, 25 Jun 2019 00:43:41 +0000 (17:43 -0700)]
Resolve an exception affecting innerloop CI when Socket.Shutdown() fails during Http2LoopbackConnection.ShutdownIgnoringErrorsAsync()
Commit migrated from https://github.com/dotnet/corefx/commit/
e514b0fba5693da417c79f87b10211184472a970
Santiago Fernandez Madero [Tue, 25 Jun 2019 00:12:35 +0000 (19:12 -0500)]
Regenerate ref against implementation and add nullable annotations for System.Reflection.Emit (dotnet/corefx#38513)
* Regenerate reference assembly against implementation
* Add nullable annotations to ref assembly
* API review feedback
* Fix build break
Commit migrated from https://github.com/dotnet/corefx/commit/
d688b187115d70ecd6df79a9cb9a04e46b1b00e1
Santiago Fernandez Madero [Mon, 24 Jun 2019 20:29:23 +0000 (13:29 -0700)]
Fix build break for TestHelpers, move to common and rename to MemoryTestHelpers
Commit migrated from https://github.com/dotnet/corefx/commit/
61f9b4c44336a7e32f8679e0a186a9177d384c49
Marco Rossignoli [Sat, 22 Jun 2019 09:37:39 +0000 (11:37 +0200)]
update MemoryExtensions ToUpper/ToLower tests for throws on overlapping buffer
address PR feedback
update tests
Address PR feedback
address PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
3d9e91a1885577f0043884f8818c9c3c97a72298
Santiago Fernandez Madero [Fri, 21 Jun 2019 04:58:30 +0000 (21:58 -0700)]
Update StackTrace tests after nullable changes
Commit migrated from https://github.com/dotnet/corefx/commit/
4f707dc836e088d5c56ac934a0ba425d88938b37
Prashanth Govindarajan [Mon, 24 Jun 2019 22:48:12 +0000 (15:48 -0700)]
Handle Byte Order Mark in Utf8JsonReader.Read (dotnet/corefx#38470)
* Handle Byte Order Mark in Utf8JsonReader.Read
* Address feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
2366ba3fe5c2f531f7be5f4810d3829301d8d3d6
imcarolwang [Mon, 24 Jun 2019 08:30:36 +0000 (01:30 -0700)]
Test for fix of issue dotnet/corefx#3408
Commit migrated from https://github.com/dotnet/corefx/commit/
57a2750da0bf6ac6e421dda43c468f485dba8ae0
Frederik Carlier [Mon, 24 Jun 2019 21:25:32 +0000 (23:25 +0200)]
Clean up System.Drawing.Common unit tests (dotnet/corefx#38771)
* LinearGradientBrushTests: Add missing using statements
* EncoderParametersTests: Add missing using statements
* EncoderParametertests: Additional using statements
* GraphicsPathTests: Add using statements
* Add missing using statements
* RegionTests: Add missing using statements
* Fix typo
* MatrixTests: Add using statements
* GraphicsTests: Add missing using statements
* Fix ConditionalTheory -> ConditionalFact
* Clone the clip before applying a transform
* Convert Rotate1bit4bit to a theory
* SurroundColors_Null_ThrowsArgumentNullException: Theory -> Fact
* Check for a NullReferenceException instead of an ArgumentNullException
This test was previously disabled (because it was incorrectly marked as a theory instead of a fact).
This is the current behavior on NetFX.
* No parameter name to validate
* Don't use statics for disposed objects
* Invoke the finalizer during the test
* PR feedback
* PR feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
8ede3e8c930cd4c1a466d0b8209d0128cbfda89a
Stephen Toub [Mon, 24 Jun 2019 21:21:07 +0000 (17:21 -0400)]
Tweak diagnostics for Dns_GetHostEntry_HostString_Ok failures in CI (dotnet/corefx#38831)
Gather more details when Dns.GetHostEntry("") fails in CI with "Name or service not known".
Commit migrated from https://github.com/dotnet/corefx/commit/
ba5c2769a01a8480824ce1b3a3cf40408325ff94
Stephen Toub [Mon, 24 Jun 2019 21:18:01 +0000 (17:18 -0400)]
Revert "Tweak preferLocal value in System.Net.Sockets (dotnet/corefx#37369)" (dotnet/corefx#38829)
This reverts commit dotnet/corefx@
bf0fb29fb55cf4c3d9063c78e8f72fb9cd4d041b.
Commit migrated from https://github.com/dotnet/corefx/commit/
e2042dba58c522ab2dcc566a92c866b6186ce0dc
Stephen Toub [Mon, 24 Jun 2019 21:14:34 +0000 (17:14 -0400)]
Remove faulty Http2Stream asserts (dotnet/corefx#38842)
These asserts are only valid if we're still holding the lock, which we're not.
Commit migrated from https://github.com/dotnet/corefx/commit/
3c0d8436115c3d6905cd46d37fde980f73281995
Santiago Fernandez Madero [Mon, 24 Jun 2019 19:57:46 +0000 (14:57 -0500)]
API Review feedback (dotnet/corefx#38826)
Commit migrated from https://github.com/dotnet/corefx/commit/
ab249fa17463b2ea07bd43fc09b96320e84724d2
Santiago Fernandez Madero [Mon, 24 Jun 2019 19:24:43 +0000 (14:24 -0500)]
Add nullable annotations to System.Reflection.Emit.ILGeneration (dotnet/corefx#38514)
* Add nullable annotations to System.Reflection.Emit.ILGeneration
* API Review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
792bebecab6a7c5fc721939891a844d8e94df3c8
Cory Nelson [Mon, 24 Jun 2019 18:59:06 +0000 (11:59 -0700)]
Merge pull request dotnet/corefx#38832 from dotnet/stephentoub-disabletest
Disable Http2_FlowControl_ClientDoesNotExceedWindows test
Commit migrated from https://github.com/dotnet/corefx/commit/
db1ef41efc7757bc88c52f46141092611855f2b0
Stephen Toub [Mon, 24 Jun 2019 18:58:09 +0000 (14:58 -0400)]
Minor follow-ups/cleanups in Http2Connection and Http2Stream (dotnet/corefx#38817)
- Fix/adjust several uses of string interpolation in SocketsHttpHandler.
- Remove a Task.WhenAny allocation from SendAsync in the common case where there is no request content or where the request content sending completes synchronously.
- In GetWaiterTask use CT.UnsafeRegister instead of Register, as ExecutionContext, as the callback doesn't need context flowed.
- In GetWaiterTask, avoid allocating an unnecessary Task for the _waitSource if the token isn't cancelable.
- In GetWaiter task's cancellation callback, avoid allocating an OCE not associated with the wait. Instead, just complete the waiter, and then rely on the subsequent cancellation check to propagate cancellation appropriately.
- Use CompareExchange to write to _abortException so that _abortException never changes its value once it's non-null. We currently have several code paths that check the type of _abortException and then do something based on it, and that could cause issues if its type could change between the check and the action.
- Clean up HTTP2 SendAsync method, e.g. remove unnecessary tmps, remove duplicated await, use slightly more descriptive variable names, only wrap OCE with one for cancellationToken if cancellationToken has had cancellation requested.
- Replace a use of ExceptionDispatchInfo.Throw with just throw. The former should be used when and only when throwing an exception object that may previously have been thrown; in this case we're throwing a new object that was never thrown before.
- Add detailed comment describing thread-safety around Http2Stream._waitSource
- Clean up a few comments
- Add some missing .ConfigureAwait(false) in loopback servers
Commit migrated from https://github.com/dotnet/corefx/commit/
e771af6f93fe4bdc9e6172563e42422d5fdd30ff
Stephen Toub [Mon, 24 Jun 2019 18:53:53 +0000 (14:53 -0400)]
Disable Http2_FlowControl_ClientDoesNotExceedWindows test
Commit migrated from https://github.com/dotnet/corefx/commit/
99d5257629744a6683ed3724fb8fa24852a4af86
Santiago Fernandez Madero [Mon, 24 Jun 2019 18:49:43 +0000 (13:49 -0500)]
Add nullable annotations to System.Resources.ResourceManager ref assembly (dotnet/corefx#38518)
* Add nullable annotations to System.Resources.ResourceManager ref assembly
* Address API Review feedback
Commit migrated from https://github.com/dotnet/corefx/commit/
ae7b3970bb2c8d76004ea397083ce7ceb1238133
Santiago Fernandez Madero [Mon, 24 Jun 2019 18:32:36 +0000 (13:32 -0500)]
Add nullable attributes to System.Runtime ref (dotnet/corefx#38732)
Commit migrated from https://github.com/dotnet/corefx/commit/
d3d1ab1c58862ebebe09d387631393a70982fe9a
Jose Perez Rodriguez [Mon, 24 Jun 2019 18:06:01 +0000 (11:06 -0700)]
Updating System.Text.Json package description (dotnet/corefx#38691)
* Updating System.Text.Json package description
* Fix ordering and namespace
* Fix description
Commit migrated from https://github.com/dotnet/corefx/commit/
eebe43224d8994b5b47bc2906c271ea6f256728b
Jeremy Barton [Mon, 24 Jun 2019 17:44:37 +0000 (10:44 -0700)]
Fix overread when decoding X509KeyUsage extension on Windows
CryptDecodeObject on X509_KEY_USAGE always sets cbStructInfo to 32 (or 20 on x86),
reporting 8 bytes (both architectures) more than needed for the CRYPT_BIT_BLOB
structure (0 bytes more than the structure when transporting pbData=NULL).
However, that value is over-representative of the number of bytes actually
written (modified) in this case. The CRYPT_BIT_BLOB contains a cbData saying
how long the actual payload is (0 (pbData==NULL), 1, or 2 bytes), but
DecodeX509KeyUsageExtension didn't read it, just blindly read the value as a DWORD,
implicitly counting on the zero-init of arrays (and Win32's choice of values
combined with Little Endian layout).
By respecting the decoded cbData value (and not over-reading) the helper no
longer needs to manually clear the stackalloc.
Commit migrated from https://github.com/dotnet/corefx/commit/
0a05173f98493547d40b1865808481e76ede1212
Cory Nelson [Mon, 24 Jun 2019 17:43:58 +0000 (10:43 -0700)]
HTTP2: Fix InboundWindowSize_Exceeded_Throw failure under load (dotnet/corefx#38736)
* Resolves dotnet/corefx#38708. Test tegression caused by different behavior under high load.
* Improve comment explaining inconsistency of exception source.
Commit migrated from https://github.com/dotnet/corefx/commit/
6a81e6195005a9edb125d67e5865b1db1403838c
Maryam Ariyan [Mon, 24 Jun 2019 17:43:13 +0000 (10:43 -0700)]
Remove redundant tests and cleanup file (dotnet/corefx#38800)
Commit migrated from https://github.com/dotnet/corefx/commit/
b0c55b4aa644baa82f0f51b45bf3e5dc56a731ba
Tomas Weinfurt [Sun, 23 Jun 2019 21:42:52 +0000 (14:42 -0700)]
follow up on duplex operation for HTTP/2 (dotnet/corefx#38226)
* follow up on duplex operation
* updates
* add test for cancelation
* log responseHeadersTask if bodyTask fails first
* improve cancelation
* feedback from review
* update SendAsync_ConcurentSendReceive_Fail test
* feedback from review
* update SendSettingsAckAsync
* more HTTP/2 cancelation tests
* update test to accept any derivative from OperationCanceledException
* feedback from review
* roll-back changes in AcceptConnectionAsync
Commit migrated from https://github.com/dotnet/corefx/commit/
cad5159981f518f455be3528d0ee8eca2e00742a
Viktor Hofer [Sun, 23 Jun 2019 19:44:44 +0000 (21:44 +0200)]
Updated SDK and cmake version
Commit migrated from https://github.com/dotnet/corefx/commit/
4f54051ba4ceeb7ce5d05f5896378b2e8c293d2e
David Shulman [Sun, 23 Jun 2019 04:12:35 +0000 (21:12 -0700)]
Fix SslStream client auth with intermediate certificates on Linux (dotnet/corefx#38789)
On Linux, a client TLS certificate chaining to multiple intermediate certificates wasn't
sending the complete list of intermediates because the final one in the chain wasn't
trusted. This differs from Windows behavior. This was causing the application to fail
to authenticate to the payment provider in the repro.
This PR fixes SslStream so that it will send the complete list of intermediates if the
chain build operation results in a "PartialChain" instead of a fully trusted chain.
Due to the complexity of this scenario, I didn't write a standalone CI test. But I was
able to run the original repro (using a docker container) to validate the fix.
Fixes dotnet/corefx#37927
Commit migrated from https://github.com/dotnet/corefx/commit/
3b39190472c73ef0c4da485bfba0aa57f9ae3b37
Levi Broderick [Sun, 23 Jun 2019 02:48:00 +0000 (19:48 -0700)]
Remove Serialization Guard public APIs (dotnet/corefx#38739)
* Remove Serialization Guard public APIs
- Also refactors reflection helpers into separate file
* PR feedback - remove DeserializationBlockedException refs entirely
Commit migrated from https://github.com/dotnet/corefx/commit/
8b73a6dfacccefa8d160077ebff11007ff72fda3
Levi Broderick [Sun, 23 Jun 2019 00:19:02 +0000 (17:19 -0700)]
Prefer ILLinkTrim.xml over InternalsVisibleTo (System.Text.Encodings.Web) (dotnet/corefx#38787)
Commit migrated from https://github.com/dotnet/corefx/commit/
22ce0f6e236001f8280c5f8639f546a301a89a6c
Jan Vorlicek [Sat, 22 Jun 2019 22:06:44 +0000 (00:06 +0200)]
Fix helper thread stack size for Alpine (dotnet/corefx#38743)
* Fix helper thread stack size for Alpine
CoreFX creates a helper thread for handling some signals. This thread is
created using pthread API without explicit setting of stack size. That
means that on Alpine, it gets only 85kB of stack. We have hit stack
overflow in one of our coreclr tests in checked build due to that.
This change sets the default stack size of that thread to 512kB,
which should be sufficient.
* Make the stack size setting non-release build only
In release build, the stack is sufficient.
I've also spotted that in the previous commit, I've actually missed
passing the attributes to the pthread_create, so I am fixing that.
Commit migrated from https://github.com/dotnet/corefx/commit/
627c1007a297e947962c2d5269dbe20063144fbf
Ganbarukamo41 [Sat, 22 Jun 2019 22:03:40 +0000 (07:03 +0900)]
Fix multiple remarks in System.Text.Json Xml docs (dotnet/corefx#38690)
* Fix multiple remarks in System.Text.Json Xml docs
* Remove unnecessary paragraph tags
* Use returns tag instead of remarks
Commit migrated from https://github.com/dotnet/corefx/commit/
be73988bed4a904a3f1f66db752b6ae209ca28f1
Jeremy Barton [Sat, 22 Jun 2019 03:59:30 +0000 (20:59 -0700)]
Add support for NumericString to X500DistinguishedName
An X500DN which contains a valid NumericString will now not cause the
entire string to turn into the empty string; which (per the tests) matches the
Windows/NetFX behavior.
Certificates with NumericString subjects do not load on macOS, because the OS considers them invalid.
Commit migrated from https://github.com/dotnet/corefx/commit/
d7631df16a92da0e21bcb64240d5007f0dab95ed
Levi Broderick [Sat, 22 Jun 2019 03:38:05 +0000 (20:38 -0700)]
Add UTF-8 support to TextEncoder (dotnet/corefx#38356)
Commit migrated from https://github.com/dotnet/corefx/commit/
9b486c1ea7bcfe7d09206ae449bffb049754ade5
David Shulman [Fri, 21 Jun 2019 23:51:34 +0000 (16:51 -0700)]
Revert "Socket: Linux: unblock synchronous socket operations on Dispose (dotnet/corefx#37486)" (dotnet/corefx#38764)
This reverts commit dotnet/corefx@
3fac6ad5bc4576eb2216ccb24fbed2bf173d41f4.
Commit migrated from https://github.com/dotnet/corefx/commit/
42ecf717478504fd7cc072f3586c6edd1ba57daa
Andrii Siriak [Fri, 21 Jun 2019 22:25:09 +0000 (01:25 +0300)]
Switch from IndexOf(string) to Contains(string) for better readability and performance (dotnet/corefx#38757)
* Fix performance IndexOf(string) -> Contains(string)
* Make comparison ordinal
Commit migrated from https://github.com/dotnet/corefx/commit/
8e23fa839544c1d0c18e3f728b439bf66cf125f3
Jeremy Kuhne [Fri, 21 Jun 2019 21:48:31 +0000 (14:48 -0700)]
Fix nested objects in object arrays (dotnet/corefx#38527)
We weren't recognizing polymorphism for json objects nested in .NET object arrays.
This change also hides the debugger backing field for clarity.
Commit migrated from https://github.com/dotnet/corefx/commit/
8be1263dc00a0ce14b5c2dfb4077d4a92cbf6d3b
buyaa-n [Fri, 21 Jun 2019 20:02:44 +0000 (13:02 -0700)]
Improve code coverage: Struct, value type test (dotnet/corefx#38403)
Code coverage: Struct, value type tests
Commit migrated from https://github.com/dotnet/corefx/commit/
c181ec76bbaf2d85883bef1328a7f61e5cbf8016
Dan Moseley [Fri, 21 Jun 2019 17:04:56 +0000 (10:04 -0700)]
add path to assert (dotnet/corefx#38709)
Commit migrated from https://github.com/dotnet/corefx/commit/
adfa9d3fab65929262aa1419289794282de95b44
Liudmila Molkova [Fri, 21 Jun 2019 16:54:13 +0000 (09:54 -0700)]
Add Activity.SetIdFormat (dotnet/corefx#38628)
* Add Activity.SetIdFormat dotnet/corefx#36999
* separate individual tests and run ones that access statics in remote executor
* Exception messages to Resources
* Review comments
* Fix tests
Commit migrated from https://github.com/dotnet/corefx/commit/
1fa8627a53115e5244e2f17310fb3b5b8685ec7a