Marc-André Moreau [Fri, 13 Mar 2015 18:44:55 +0000 (14:44 -0400)]
Merge pull request #2466 from WarheadsSE/fix-cert-chain-validation-GH2446
libfreerdp: crypto: add certificate chain validation!
Jason Plum [Fri, 13 Mar 2015 17:50:54 +0000 (13:50 -0400)]
libfreerdp: crypto: add certificate chain validation!
Hardening [Fri, 13 Mar 2015 13:29:23 +0000 (14:29 +0100)]
Merge pull request #2463 from akallabeth/vs2010_error_fix
Fixed mixed declaration of code and variables.
Armin Novak [Fri, 13 Mar 2015 11:17:22 +0000 (12:17 +0100)]
Fixed mixed declaration of code and variables.
Marc-André Moreau [Thu, 12 Mar 2015 14:09:02 +0000 (10:09 -0400)]
Merge pull request #2447 from ivan-83/master
Fix poor sound quality with ALSA, add OSS sound system support, FreeBSD patches
Marc-André Moreau [Thu, 12 Mar 2015 11:35:39 +0000 (07:35 -0400)]
Merge pull request #2459 from akallabeth/handle_close_cb
Refactored WaitForSingleObject and CloseHandle
Marc-André Moreau [Thu, 12 Mar 2015 11:33:27 +0000 (07:33 -0400)]
Merge pull request #2456 from zhangzl2013/fix-realloc
Fix incorrect usage of realloc
Marc-André Moreau [Thu, 12 Mar 2015 11:31:11 +0000 (07:31 -0400)]
Merge pull request #2452 from bmiklautz/cmd_fix
settings: handle collection_add in detection case
Marc-André Moreau [Thu, 12 Mar 2015 11:30:40 +0000 (07:30 -0400)]
Merge pull request #2448 from eledoux/ports2
Fixed a regression on the #2333 resolution
Marc-André Moreau [Thu, 12 Mar 2015 11:27:29 +0000 (07:27 -0400)]
Merge pull request #2426 from bjcollins/master
xfreerdp fullscreen enhancements
Marc-André Moreau [Thu, 12 Mar 2015 11:25:00 +0000 (07:25 -0400)]
Merge pull request #2430 from serayrosh/master
release keys when xfreerdp is unfocused to prevent stuck keys
Marc-André Moreau [Thu, 12 Mar 2015 11:24:10 +0000 (07:24 -0400)]
Merge pull request #2458 from bmiklautz/cert_handling
crypto: use PEM as certificate store file format
Hardening [Wed, 11 Mar 2015 22:32:50 +0000 (23:32 +0100)]
Merge pull request #2457 from akallabeth/pubsub_fix
PubSub: Fixed missing loop exit condition.
Armin Novak [Wed, 11 Mar 2015 17:14:50 +0000 (18:14 +0100)]
Fixed missing return value check.
Armin Novak [Wed, 11 Mar 2015 17:09:22 +0000 (18:09 +0100)]
Initializing handles with calloc now.
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 16:57:01 +0000 (17:57 +0100)]
Using new handle cleanup structure
Armin Novak [Wed, 11 Mar 2015 14:11:20 +0000 (15:11 +0100)]
Using handle close callback now.
Armin Novak [Wed, 11 Mar 2015 14:11:17 +0000 (15:11 +0100)]
Using handle close callback now.
Armin Novak [Wed, 11 Mar 2015 14:11:14 +0000 (15:11 +0100)]
Using handle close callback now.
Armin Novak [Wed, 11 Mar 2015 14:11:11 +0000 (15:11 +0100)]
Using handle close callback now.
Armin Novak [Wed, 11 Mar 2015 14:11:08 +0000 (15:11 +0100)]
Using handle close callback now.
Armin Novak [Wed, 11 Mar 2015 14:11:03 +0000 (15:11 +0100)]
Using handle close callback now.
Armin Novak [Wed, 11 Mar 2015 14:11:00 +0000 (15:11 +0100)]
Using handle close callback now.
Armin Novak [Wed, 11 Mar 2015 14:10:52 +0000 (15:10 +0100)]
Using handle close callback now.
Armin Novak [Wed, 11 Mar 2015 11:28:07 +0000 (12:28 +0100)]
Fixed PubSub_Unsubscribe.
Bernhard Miklautz [Wed, 11 Mar 2015 11:06:52 +0000 (12:06 +0100)]
crypto: use PEM as certificate store file format
Currently the certificate format expected in FreeRDPs certificate store
is DER (ASN1). On most linux/unix systems the system certificate store
default format is PEM. Which is also the more common format used by CAs
to distribute their certificates.
Changing the default format to PEM allows the usage of system
certificates or published CA certificates without the need to convert them.
This fixes a part of issue #2446.
Armin Novak [Wed, 11 Mar 2015 10:33:17 +0000 (11:33 +0100)]
Fixed missing loop exit condition.
Zhang Zhaolong [Wed, 11 Mar 2015 08:37:28 +0000 (16:37 +0800)]
wf_cliprdr: fix potential memory leak.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 08:34:38 +0000 (16:34 +0800)]
libwinpr: check return value of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 07:04:38 +0000 (15:04 +0800)]
fix build error.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 07:00:05 +0000 (15:00 +0800)]
tool: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 06:59:56 +0000 (14:59 +0800)]
libwinpr: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 06:18:45 +0000 (14:18 +0800)]
codec: check return value of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 06:02:20 +0000 (14:02 +0800)]
keyboard_layout: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 05:55:41 +0000 (13:55 +0800)]
gdi: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 05:52:24 +0000 (13:52 +0800)]
settings: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 05:40:20 +0000 (13:40 +0800)]
core: fix incorrect usage of realloc.
realloc can handle the case that its first parameter is NULL.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 04:37:35 +0000 (12:37 +0800)]
crypto: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 04:31:50 +0000 (12:31 +0800)]
xf_cliprdr: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 04:29:37 +0000 (12:29 +0800)]
android_event: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 04:26:04 +0000 (12:26 +0800)]
cmdline: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 03:32:51 +0000 (11:32 +0800)]
common/file: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 03:27:39 +0000 (11:27 +0800)]
wf_cliprdr: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 03:17:52 +0000 (11:17 +0800)]
rail: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 03:10:28 +0000 (11:10 +0800)]
audin: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
Zhang Zhaolong [Wed, 11 Mar 2015 03:04:36 +0000 (11:04 +0800)]
tsmf: fix incorrect usage of realloc.
Signed-off-by: Zhang Zhaolong <zhangzl2013@126.com>
ivan-83 [Tue, 10 Mar 2015 23:17:45 +0000 (02:17 +0300)]
* OSS build fix on linux
Hardening [Tue, 10 Mar 2015 22:36:17 +0000 (23:36 +0100)]
Merge pull request #2455 from WarheadsSE/fix-hostname-matching
Fix case sensitive hostname comparison in tls
Jason Plum [Tue, 10 Mar 2015 20:48:35 +0000 (16:48 -0400)]
Fix case sensitive hostname comparison in tls
To do this I've swapped _strnicmp with memcmp. Seemless, but does lock it to the restrictions of that function.
Signed-off-by: Jason Plum <jplum@archlinuxarm.org>
Bernhard Miklautz [Tue, 10 Mar 2015 12:10:39 +0000 (13:10 +0100)]
settings: handle collection_add in detection case
Command line detection is run with dummy settings where not everything
is allocated. Collections (device, dynamic channel and static
channel) didn't handle this case properly.
ivan-83 [Tue, 10 Mar 2015 01:40:47 +0000 (04:40 +0300)]
* FreeBSD timezone detection patch
ivan-83 [Mon, 9 Mar 2015 22:34:15 +0000 (01:34 +0300)]
* remove OSS debug messages
ivan-83 [Mon, 9 Mar 2015 22:21:28 +0000 (01:21 +0300)]
* BSD/FreeBSD build fix
Emmanuel Ledoux [Mon, 9 Mar 2015 19:01:51 +0000 (20:01 +0100)]
winpr-comm: fixed a regression about timeouts to block of first bytes when required. Added timeouts values in the DEBUG log.
ivan-83 [Mon, 9 Mar 2015 06:31:27 +0000 (09:31 +0300)]
+ some files for OSS, missed from prev commit
ivan-83 [Mon, 9 Mar 2015 06:23:29 +0000 (09:23 +0300)]
+ add OSS support for rdpsnd
ivan-83 [Mon, 9 Mar 2015 06:11:46 +0000 (09:11 +0300)]
Fix poor sound quality with ALSA
and decrease "ALSA lib pcm.c:7339:(snd_pcm_recover) underrun occurred"
+ little code cleanup
Martin Fleisz [Fri, 6 Mar 2015 10:33:30 +0000 (11:33 +0100)]
Merge pull request #2435 from llyzs/llyzs
Add openh264 encoder support.
Martin Fleisz [Thu, 5 Mar 2015 10:15:59 +0000 (11:15 +0100)]
Merge pull request #2436 from bmiklautz/warnings
Compiler warnings
Bernhard Miklautz [Tue, 3 Mar 2015 18:36:54 +0000 (19:36 +0100)]
build: fix compiler warnings
warning: redundant redeclaration
Tested with: 4.7.2 and 3.5.0-1~exp1
Bernhard Miklautz [Tue, 3 Mar 2015 18:25:42 +0000 (19:25 +0100)]
build: enable more warnings for gcc
Enable implicit-function-declaration and redundant-decls warnings when
compiling with gcc. redundant-decl useful for exported headers.
Bernhard Miklautz [Tue, 3 Mar 2015 09:29:58 +0000 (10:29 +0100)]
Merge pull request #2433 from abergmeier/master
Added support for finding OpenSLES with CMake + Android.
Vic Lee [Mon, 16 Feb 2015 09:51:20 +0000 (17:51 +0800)]
Add openh264 encoder support.
Martin Fleisz [Mon, 2 Mar 2015 08:36:00 +0000 (09:36 +0100)]
Merge pull request #2428 from akallabeth/ios_color_fix
Fixed bitmap context for 15bit color depth
Andreas Bergmeier [Sun, 1 Mar 2015 20:16:56 +0000 (21:16 +0100)]
Added support for finding OpenSLES with CMake + Android.
Seray Rosh [Fri, 27 Feb 2015 15:02:40 +0000 (16:02 +0100)]
release keys when xfreerdp is unfocused to prevent stuck keys
Armin Novak [Thu, 26 Feb 2015 17:01:05 +0000 (18:01 +0100)]
Fixed bitmap context for 15bit color depth
Marc-André Moreau [Tue, 24 Feb 2015 14:55:44 +0000 (09:55 -0500)]
Merge pull request #2422 from akallabeth/nmake_warning_fixes
Fixes warning D9025 with NMake
bjcollins [Mon, 23 Feb 2015 17:22:28 +0000 (11:22 -0600)]
Remove override redirect flag for fullscreen with keyboard grab enabled. Window manager should always know about the main window.
Small cleanup of passing around decorations flag.
Limit PercentScreen to single monitor vs. entire desktop. IMO - this is better behavior in a multimonitor environment.
Handle fullscreen windows better:
1. Ensure that size hints are set to allow resizing before setting a window to fullscreen as some window managers do not behave properly.
2. Handle fullscreen toggles without destroying and recreating window.
3. Use NET_WM_STATE_FULLSCREEN Extended Window Manager Hint for fullscreen functionality
4. Use the NET_WM_FULLSCREEN_MONITORS Extended Window Manager Hint when appropriate
5. When a single monitor fullscreen is requested - use the current monitor(as determined from mouse location)
6. Handle cases where there is no local monitor at coordinate 0,0. The Windows server expect there to be a monitor at this location, so we maintain offset if necessary between our local primary monitor and the server side primary monitor located at 0,0.
Armin Novak [Mon, 23 Feb 2015 15:48:07 +0000 (16:48 +0100)]
Fixes warning D9025 with NMake
Norbert Federa [Mon, 23 Feb 2015 11:56:26 +0000 (12:56 +0100)]
Merge pull request #2416 from zavadovsky/transport_dead_end_fix
libfreerdp-core: fix dead-end state in transport_read_pdu()
Bernhard Miklautz [Mon, 23 Feb 2015 11:44:40 +0000 (12:44 +0100)]
Merge pull request #2415 from zavadovsky/android_fixes
Android fixes
Zavadovsky Yan [Mon, 23 Feb 2015 10:57:46 +0000 (13:57 +0300)]
libfreerdp-core: add comments for previous fix
Norbert Federa [Mon, 23 Feb 2015 10:00:06 +0000 (11:00 +0100)]
Merge pull request #2409 from bmiklautz/tcp_user_timeout
core/tcp: set TCP_USER_TIMEOUT if available
Zavadovsky Yan [Mon, 23 Feb 2015 08:50:32 +0000 (11:50 +0300)]
client/Android: fix coords calculation in previous commit
Marc-André Moreau [Mon, 23 Feb 2015 01:16:18 +0000 (20:16 -0500)]
Merge pull request #2417 from austin987/master
winpr/asn1: add ASN1_CreateDecoder/ASN1_Decode stubs
Austin English [Mon, 23 Feb 2015 01:11:11 +0000 (19:11 -0600)]
winpr/asn1: add ASN1_Decode stub
Austin English [Mon, 23 Feb 2015 01:09:58 +0000 (19:09 -0600)]
winpr/asn1: add ASN1_CreateDecoder stub
Zavadovsky Yan [Sat, 21 Feb 2015 21:07:25 +0000 (00:07 +0300)]
libfreerdp-core: fix dead-end state in transport_read_pdu()
Situation: we have fragmented TPKT PDU without two last bytes
(or one last byte - for fast-path) in network stack.
First call to transport_read_pdu() works normally, read
available bytes and exit with status 0 - no whole PDU readed.
Before second call this missed bytes arrive.
Optionally with next PDU.
In second call header parsing code unconditionally read this
two bytes(one byte) despite this is not header bytes.
And increase stream position, so stream now contains whole PDU.
This cause (pduLength - Stream_GetPosition(s)) calculation to be 0.
So transport_read_layer_bytes()-->transport_read_layer() return 0
and transport_read_pdu() exits with "not enough data is available"
status.
If next PDU isn't available next calls to transport_read_pdu()
give same result.
If next PDU arrive - (pduLength - Stream_GetPosition(s)) will be
less than 0. Stream position will grow, grow and grow on each call.
And transport_read_pdu() never signals that PDU is readed.
Caught on Android FreeRDP client with high RDP traffic (several MBytes/s).
Zavadovsky Yan [Sat, 21 Feb 2015 20:52:38 +0000 (23:52 +0300)]
client/Android: optimize android_end_paint() logic
1. Don't draw to screen if server sends begin/end paint
messages without any real updates.
2. Redraw only summary region that covers really invalidated
part of screen.
Zavadovsky Yan [Sat, 21 Feb 2015 20:49:29 +0000 (23:49 +0300)]
client/Android: fix bad realloc
Fast and long pointer moves cause app to crash.
Marc-André Moreau [Fri, 20 Feb 2015 20:48:36 +0000 (15:48 -0500)]
Merge pull request #2411 from awakecoding/master
SCardTransmit pioRecvPci Fix
Marc-André Moreau [Fri, 20 Feb 2015 20:39:51 +0000 (15:39 -0500)]
channels/smartcard: fix SCardTransmit return encoding with pioRecvPci
Bernhard Miklautz [Fri, 20 Feb 2015 12:22:01 +0000 (13:22 +0100)]
core/tcp: set TCP_USER_TIMEOUT if available
Keepalive settings are usually (depending on the implementation) only
used if the TCP connection is idle.
If the network is interrupted/disconnected/... click or keyboard input
generates outgoing traffic therefore the connection isn't idle
anymore and keepalives might not be used causing the connection to
stay open and the client to stall.
Linux 2.6.36 added a TCP_USER_TIMEOUT TCP socket option that lets a
program specify the maximum time transmitted data may remain
unacknowledged before TCP will close the corresponding connection with
ETIMEDOUT.
Setting TCP_USER_TIMEOUT allows us to detect a network problem (like
cable disconnect) even if the connection isn't idle.
Marc-André Moreau [Thu, 19 Feb 2015 21:15:35 +0000 (16:15 -0500)]
Merge pull request #2408 from dvincent-devolutions/gateway
TSGateway out channel recycling
Marc-André Moreau [Thu, 19 Feb 2015 21:06:20 +0000 (16:06 -0500)]
libfreerdp-core: improve RTS PDU receiving
Marc-André Moreau [Thu, 19 Feb 2015 20:06:57 +0000 (15:06 -0500)]
libfreerdp-core: cleanup channel recycling