Tom Hacohen [Tue, 3 Jun 2014 10:35:28 +0000 (11:35 +0100)]
Elm: Update code to use the new class names generated by eolian.
ChunEon Park [Mon, 2 Jun 2014 13:50:33 +0000 (22:50 +0900)]
examples - clean up 3d_scene_on_button_example.
se.osadchy [Mon, 2 Jun 2014 13:34:25 +0000 (22:34 +0900)]
[Examples] Add new example for evas-3d and widget.
Summary: This example shows the mechanism of scene object adding to the widget button.
Reviewers: Hermet, cedric, raster
Differential Revision: https://phab.enlightenment.org/D914
Carsten Haitzler (Rasterman) [Fri, 30 May 2014 06:41:40 +0000 (15:41 +0900)]
elm win - if no ELM_DISPLAY is set, try more engines before giving up
this should fix T1294 without needing ELM_DISPLAY set. @fix
Carsten Haitzler (Rasterman) [Fri, 30 May 2014 03:45:57 +0000 (12:45 +0900)]
theme - support new ibar icon menu signals for focus, screen etc.
Carsten Haitzler (Rasterman) [Fri, 30 May 2014 02:56:24 +0000 (11:56 +0900)]
atspi:AtspiSelection interface added
Reviewers: stanluk, m.jagiello, raster
Differential Revision: https://phab.enlightenment.org/D810
Yakov Goldberg [Thu, 29 May 2014 13:07:33 +0000 (16:07 +0300)]
Fileselector Entry: add the changed signal in the events section of fileselector_entry.eo
Carsten Haitzler (Rasterman) [Thu, 29 May 2014 08:04:16 +0000 (17:04 +0900)]
elm theme - use fastdecomp for theme as it should load faster
Anil Kumar Nahak [Thu, 29 May 2014 02:35:46 +0000 (11:35 +0900)]
fileselector: Added focus cycle feature.
Summary:
Previously there was no focus_direction & focus_next.
These functions are added in filesector winset for currect focus movement inside the winset.
Test Plan: elementary_test->"fileselector"
Reviewers: raster, seoz, nirajkr, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D913
efl [Wed, 28 May 2014 09:21:10 +0000 (18:21 +0900)]
Gengrid: Fixed _elm_gengrid_item_edge_check for ELM_FOCUS_LEFT and ELM_FOCUS_RIGHT in horizontal mode.
Summary:
1|4 _elm_gengrid_item_edge_check for ELM_FOCUS_LEFT returns EINA_FALSE for item no. 3,
2| which should return EINA_TRUE. Fixed this.
3|
1|4|7| _elm_gengrid_item_edge_check for ELM_FOCUS_RIGHT returns EINA_FALSE for item no.5,
2|5| which should return EINA_TRUE. Fixed this.
3|6|
Test Plan: elementary_test -to gengrid2
Reviewers: seoz, eagleeye, SanghyeonLee, raster
CC: seoz, raster
Differential Revision: https://phab.enlightenment.org/D846
Lukasz Stanislawski [Wed, 28 May 2014 08:12:34 +0000 (17:12 +0900)]
atspi: add accessible default relations and attributes
Summary: Tests added for accessibile interface
Differential Revision: https://phab.enlightenment.org/D900
bluezery [Wed, 28 May 2014 08:08:00 +0000 (17:08 +0900)]
elm_map: Add new elm_map_region_zoom_bring_in() API
Summary:
By using this API, we can do region show & bring in concurrently.
This needs some tuning more because some main layouting logic in map
needs to be modified to support more smooth animation.
I will spare my time to do that later.
@feature
Reviewers: Hermet, raster, stefan_schmidt
Reviewed By: raster
CC: Jaehyun
Differential Revision: https://phab.enlightenment.org/D887
Yakov Goldberg [Wed, 28 May 2014 07:09:39 +0000 (10:09 +0300)]
Entry: add the "changed", "changed,user" signals in the events section of entry.eo.
Stefan Schmidt [Tue, 27 May 2014 09:13:32 +0000 (11:13 +0200)]
autotools: Add xz as additional tarball format
If this turns out well we will remove bz2 in 1.12
Lukasz Stanislawski [Tue, 27 May 2014 07:23:13 +0000 (16:23 +0900)]
atspi: add AtspiImage interface support.
Summary: Sample implementation for elm_image added.
Reviewers: raster, seoz
Differential Revision: https://phab.enlightenment.org/D794
Andrii Kroitor [Tue, 27 May 2014 07:05:48 +0000 (16:05 +0900)]
Make *.eo files installed into eolian/include
Summary: This makes inheritance from elementary posible for widget developers
Reviewers: cedric, seoz, raster
CC: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D762
Conflicts:
src/lib/Makefile.am
Kateryna Fesyna [Tue, 27 May 2014 06:53:11 +0000 (15:53 +0900)]
Genlist: Add function to search item by string.
Summary:
This function allows user to search for item in Genlist.
It takes four search parameters:
1. pointer to function to get text of the item. It could be the same with item's
get_text function. This parameter is added to let user use the specific search key
and to avoid problems with setting item's text, that is not constant.
2. pointer to the item from which search should start.
3. search pattern.
4. fnmatch() flags.
To check it's usage the new test is added to the elementary_test (Genlist Item Search By Text)
Reviewers: cedric, seoz, raster
CC: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D566
ChunEon Park [Tue, 27 May 2014 04:38:34 +0000 (13:38 +0900)]
scroller - emits the missed signals
vbar,press, vbar,unpress, hbar,press, hbar,unpress
@fix
maxerba [Mon, 26 May 2014 19:45:11 +0000 (21:45 +0200)]
Updating galician and adding lithuanian and turkish translations
Carsten Haitzler (Rasterman) [Mon, 26 May 2014 14:28:44 +0000 (23:28 +0900)]
Revert "theme - fix non-fixed size3 complaint in theme buttons"
this fixed button complaints by unexpectedly broke hoversels
This reverts commit
9f53154bb216e8998586c2458e5f1c86d5b55011.
Daniel Juyung Seo [Mon, 26 May 2014 12:56:10 +0000 (21:56 +0900)]
genlist: fixed wrong item focus set on item_focus_set API call.
Reset the last_focused_item on _item_focus_set_hook.
This fixes the issue which sets the focus to the wrong item when the
focus is set by an API.
Reproduction step:
elementary_test -> genlist focus -> click an item (not the 2nd item) -> click "Focus 2nd
Item after 1.5 seconds" button.
Focus is not moved to the 2nd item.
@fix
Daniel Juyung Seo [Mon, 26 May 2014 13:06:23 +0000 (22:06 +0900)]
toolbar: changed internal variable types to sync with other widgets.
Changed the variable type from (Elm_Toolbar_Item *) to (Elm_Object_Item *)
for focused_item, last_focused_item, and prev_focused_item.
Stefan Schmidt [Mon, 26 May 2014 10:41:34 +0000 (12:41 +0200)]
release: Switch back to development mode
Open for 1.11 changes now.
Stefan Schmidt [Mon, 26 May 2014 09:48:53 +0000 (11:48 +0200)]
release: v1.10.0
Carsten Haitzler (Rasterman) [Mon, 26 May 2014 10:11:02 +0000 (19:11 +0900)]
fix example to follow namespace correctness in elm theme
fixes T1024
Carsten Haitzler (Rasterman) [Mon, 26 May 2014 09:35:40 +0000 (18:35 +0900)]
elm scroller - fix documentation on gravity
this fixes T1262
Carsten Haitzler (Rasterman) [Mon, 26 May 2014 09:03:44 +0000 (18:03 +0900)]
elm spiner - fix flag read to also use the right field
Carsten Haitzler (Rasterman) [Mon, 26 May 2014 09:01:45 +0000 (18:01 +0900)]
elm spinner - fix invalid struct modification when wheel event
Carsten Haitzler (Rasterman) [Mon, 26 May 2014 08:53:05 +0000 (17:53 +0900)]
theme - fix non-fixed size3 complaint in theme buttons
this fixes T1278
chinmaya [Mon, 26 May 2014 06:52:07 +0000 (15:52 +0900)]
Genlist: On focus_on_selection mode, the focus should set on item content objects of item type ELM_GENLIST_ITEM_TREE.
Summary:
On focus_on_selection set, the focus set on genlist item of type ELM_GENLIST_ITEM_TREE rather than
on item content objects.
Test Plan: elementary_test -to "genlist focus"
Reviewers: seoz, eagleeye, SanghyeonLee, raster
Reviewed By: raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D899
chinmaya [Mon, 26 May 2014 06:45:54 +0000 (15:45 +0900)]
Genlist: Focus does not move, if it is set on item content objects.
Summary:
If focus is set on item content object, it's treated as a
different object which results the focus deadlock. So, every
time whenever focus sets on item content object, we need to
unset and set the focus on genlist object. Thanks to Seoz for
the idea.
Test Plan: elementary_test -to "genlist focus"
Reviewers: seoz, SanghyeonLee, eagleeye
CC: seoz
Differential Revision: https://phab.enlightenment.org/D891
wonguk.jeong [Mon, 26 May 2014 06:25:28 +0000 (15:25 +0900)]
test_progressbar: delete timer when progressbar is destroyed.
Summary:
elementary_test -> progressbar/progressbar2 -> press start -> close window
-> annoying message is shown due to API invoking for already free'd progressbar
Test Plan: elementary_test -> progressbar/progressbar2 -> press start -> close progressbar/progressbar2 window
Reviewers: raster, seoz
CC: seoz
Differential Revision: https://phab.enlightenment.org/D888
Thiep Ha [Mon, 26 May 2014 02:28:12 +0000 (11:28 +0900)]
entry: update selection handlers' visibility when entry is hidden or shown
Summary:
Selection handlers' visibility should be updated when entry is hidden or shown
When entry has selection and hidden, the selection handlers should be hidden also.
This fix T1175.
@fix
Reviewers: seoz, woohyun, raster
Reviewed By: raster
Maniphest Tasks: T1175
Differential Revision: https://phab.enlightenment.org/D877
Simon Lees [Mon, 26 May 2014 02:10:01 +0000 (11:10 +0900)]
Fix T1269 Issues with the elementary theme if the default text is set to something other then White
Summary:
Previously in colorclasses.edc border_frame dialog_base along with other base elements were defined to the default font color "White". This means if you change the default font color there are many unrelated side effects.
To fix this issue i have added a new Color define in colorclasses.edc to be used with window related items as opposed to text related items.
Reviewers: raster
CC: seoz, stefan_schmidt
Maniphest Tasks: T1269
Differential Revision: https://phab.enlightenment.org/D879
maxerba [Fri, 23 May 2014 21:44:35 +0000 (23:44 +0200)]
Updating czech translation
WooHyun Jung [Fri, 23 May 2014 02:07:59 +0000 (11:07 +0900)]
win: set NULL to focus_highlight.prev.target when it's deleted.
Andy Williams [Thu, 22 May 2014 21:33:46 +0000 (22:33 +0100)]
Correctly emit the scroll signal when scrolling an entry @fix T1274.
As the Elm_Entry has replaced the _scroll_cb we need to emit the same signal
(that was the only function of elm_scroller's _scroll_cb)
Carsten Haitzler (Rasterman) [Thu, 22 May 2014 09:46:36 +0000 (18:46 +0900)]
default theme - make finger size 10
ChunEon Park [Wed, 21 May 2014 04:24:32 +0000 (13:24 +0900)]
image - null checking.
If the rotated image exceeds image maximum size, the data would be invalid.
ChunEon Park [Wed, 21 May 2014 03:03:23 +0000 (12:03 +0900)]
replace elipsis -> ellipsis
we recommend complete words.
Jean-Philippe Andre [Tue, 20 May 2014 03:27:29 +0000 (12:27 +0900)]
elm_test: Set PACKAGE_LIB_DIR to fix windows runtime
Carsten Haitzler (Rasterman) [Tue, 20 May 2014 07:04:41 +0000 (16:04 +0900)]
fix genlist tree expand/contract bug when switching mode
this fixes T1157 - this patch comes from yinkair.
Carsten Haitzler (Rasterman) [Tue, 20 May 2014 06:34:01 +0000 (15:34 +0900)]
fix 0 size focus region
@fix - this fixes T1205 ... or should fix it... in theory.
Jean-Philippe Andre [Tue, 20 May 2014 02:32:19 +0000 (11:32 +0900)]
elm_cnp: Fix build for windows (ecore_x)
maxerba [Mon, 19 May 2014 19:54:30 +0000 (21:54 +0200)]
Updating translations
Daniel Juyung Seo [Mon, 19 May 2014 15:54:50 +0000 (00:54 +0900)]
widget: updated internal documentation for elm_widget_item_del.
Vorobiov Vitalii [Mon, 19 May 2014 06:41:32 +0000 (15:41 +0900)]
[Fileselector] Fix double-call of callback function on clicking "Enter" key.
Summary:
This feature (Clicking on "Enter" key) was previously implemented by using "activate" signal of entry (the one for entering name of the file),
so it was looking like "ok" button was clicked by pushing "Enter" key on the keyboard.
This little feature was added in commit
4d761f3a63270c88fa516764d9288f8bf0ff4a11.
Later the huge feature that adds key binding was implemented (commit
820f3dc907250c0c08ed8431b50567e58d6dab5c for ex).
It allows to bind widgets with keys (certain function calls when certain keys is pressed on keyboard).
This feature also adds same functionality to fileselecter, doing the same as previous (with "activate" signal) one.
Because of that it was looks like "ok" button was clicked twice.
This commit fixes this behavior and removes old and outdated method of "ok" button clicking processing.
@fix
Reviewers: cedric, seoz, raster
CC: reutskiy.v.v
Differential Revision: https://phab.enlightenment.org/D864
Jaehyun Cho [Mon, 19 May 2014 04:30:04 +0000 (13:30 +0900)]
elm_map: Fix to calculate map size not to be smaller than viewport size
Summary:
Fix to calculator map size not to be smaller than viewport size when zoom mode is either fit or fill.
Previously, map size could be either smaller or larger than viewport.
@fix
Reviewers: Hermet, raster
Reviewed By: raster
Differential Revision: https://phab.enlightenment.org/D861
Daniel Juyung Seo [Sat, 17 May 2014 11:22:00 +0000 (20:22 +0900)]
example: added ellipsis: -1 to text parts which have min 1.
Daniel Juyung Seo [Sat, 17 May 2014 11:20:52 +0000 (20:20 +0900)]
focus: apply the focus API change during the development phase.
This fixes the commit
422b8717 which was pushed to master without
considering the API change.
Daniel Juyung Seo [Sat, 17 May 2014 10:43:44 +0000 (19:43 +0900)]
Revert "Revert "focus: Fixed the animation issue related to bring_in.""
This reverts commit
e4ae67535672d04eec9eb368b71c72932cc0f757.
This will be fixed in a next commit.
Carsten Haitzler (Rasterman) [Fri, 16 May 2014 10:04:37 +0000 (19:04 +0900)]
cursor test - make button expand to test window edges with cursor
Carsten Haitzler (Rasterman) [Thu, 15 May 2014 08:43:56 +0000 (17:43 +0900)]
fix visiblity of entry cursor when selections exist
this fixes T1229 - the other part about cursor visibility. @fix
SangHyeon Lee [Thu, 15 May 2014 03:13:23 +0000 (12:13 +0900)]
[Gengrid] Fix gengrid item position update bug, when item is reordered or deleted.
Summary:
When gengrid item is reordered or deleted, gengrid didn't update item's position.
This Patch update item's position when item is placed. if middle of item deleted,
every item after the deleted one, will re-postion on _item_place function, so they
will be update there position well.
Test Plan:
modify test_gengrid grid_sel fuction to print there position. so when item selected,
they print there position and it works fine both horizontal and vertical.
Reviewers: bluezery, seoz, raster
Reviewed By: raster
CC: Hermet, chinmaya061
Differential Revision: https://phab.enlightenment.org/D855
Amitesh Singh [Thu, 15 May 2014 03:09:33 +0000 (12:09 +0900)]
hoversel: Icon parent set to button.
Summary: This is an optimization over parent set to hoversel object.
Reviewers: seoz, raster
CC: seoz
Differential Revision: https://phab.enlightenment.org/D853
zmike [Wed, 14 May 2014 20:03:33 +0000 (16:03 -0400)]
fix mouse events on elm frame parts
zmike [Wed, 14 May 2014 18:30:09 +0000 (14:30 -0400)]
fix horizontal theme text sizing after @jpeg vertical fixes
Amitesh Singh [Wed, 14 May 2014 12:50:31 +0000 (21:50 +0900)]
hoversel: item-loop should happen on UP/DOWN Key in case of vertical hoversel and on LEFT/RIGHT Key in case of horizontal hoversel.
Summary:
Earlier focus was moving to top item from bottom item on LEFT key and to bottom item on RIGHT Key
in case of vertical hoversel.
@fix
Test Plan: elementary_test -to "Hoversel Focus"
Reviewers: raster, seoz
Reviewed By: seoz
CC: seoz, chinmaya061
Differential Revision: https://phab.enlightenment.org/D858
Youngbok Shin [Wed, 14 May 2014 12:26:33 +0000 (13:26 +0100)]
entry: Enable context menu with mosue down even if the entry is not editable in some case.
Summary:
Even if a entry is not editable, user can select text in the entry.
When the entry has selection, we have to support "copy" option.
@fix
Test Plan:
Precondition: Apply D852 patch for fixing a bug in elementary_test
1. elementary_test -to entry7
2. Select some text in the non-editable entry.
3. Press mouse right button.
Note: You can test it in Desktop profile.
Reviewers: tasn, woohyun, seoz
Differential Revision: https://phab.enlightenment.org/D848
nirajkr [Wed, 14 May 2014 11:50:11 +0000 (20:50 +0900)]
gengrid : Fix the issue to skip disable item in item select
Summary:
Fix to skip the item which is disabled and select the next item to the
disabled item
@fix
Reviewers: seoz, raster
CC: seoz, singh.amitesh
Differential Revision: https://phab.enlightenment.org/D700
Carsten Haitzler (Rasterman) [Wed, 14 May 2014 05:39:49 +0000 (14:39 +0900)]
update po files
Jean-Philippe Andre [Wed, 14 May 2014 06:29:02 +0000 (15:29 +0900)]
edc: Fix multibuttonentry alignments
Following the edc padding behaviour change
Jean-Philippe Andre [Tue, 13 May 2014 08:54:03 +0000 (17:54 +0900)]
edc: Also fix frame and button offsets
Since SHADOW adds one pixel padding, the whole object size
was calculated with one extra pixel. Let's add it back
to keep the overall visual balance of buttons.
A few other widgets might visually change after the edje
padding fix:
- Check (looks better)
- Naviframe (smaller height)
- E date widget
- ...
But I did not see anything "weird" that needs fixing.
Jean-Philippe Andre [Tue, 13 May 2014 07:12:22 +0000 (16:12 +0900)]
edc: Fix E titlebars after text padding changes
See EFL
5bf1f0c9187525cf40782b26d7fa49d2676f91bb:
edje_calc: Don't add padding twice to text objects
Text objects declared in Edje will see their padding added twice,
as the Evas_Object_Text itself contains the padding already.
This WILL break some EDC files. It's a bug nonetheless.
Jaehyun Cho [Wed, 14 May 2014 03:27:27 +0000 (12:27 +0900)]
elm_map: Fix to show and bring in a correct region after zooming
Summary:
Show and bring in a region which has the given latitude and longitude after zooming
@fix
Reviewers: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D851
Lukasz Stanislawski [Wed, 14 May 2014 03:02:10 +0000 (12:02 +0900)]
layout: remove sizing_eval call when layout is already destructed. @fix
Summary:
Layout's sub_object_del function calls sizing_eval even if layout's smart_del
function has already been called (Due to widget_smart_del impl).
This patch adds 'destructed_is' flag to Elm_Layout_Smart_Data and prevents unneeded
sizing_eval calls when object is already destructed.
Patch also fixes SIGSEGV in layout derived entry widget caused by calling
sizing_eval after entry_smart_del destructor.
Added entry test to avoid regression for SIGSEGV bug.
Test Plan: run tests/elm_test_entry
Reviewers: raster, seoz, tasn, cedric
Differential Revision: https://phab.enlightenment.org/D823
Mike Blumenkrantz [Tue, 13 May 2014 20:14:29 +0000 (16:14 -0400)]
more ellipsis fixes
Mike Blumenkrantz [Tue, 13 May 2014 19:45:30 +0000 (15:45 -0400)]
add ellipsis to elm theme where necessary
Youngbok Shin [Tue, 13 May 2014 06:50:05 +0000 (15:50 +0900)]
entry: Fix a test case for editable, non-editable entry.
Summary:
elm_entry_context_menu_disabled_set API is called to wrong entry.
It should be called to "en2" that added for testing the API.
@fix
Test Plan: 1. elementary -to entry7
Reviewers: woohyun, seoz, tasn
Reviewed By: seoz
CC: herdsman
Differential Revision: https://phab.enlightenment.org/D852
Carsten Haitzler (Rasterman) [Tue, 13 May 2014 02:32:00 +0000 (11:32 +0900)]
Revert "focus: Fixed the animation issue related to bring_in."
This reverts commit
422b8717660853ff099359dc3cd926e56f1b1665.
Anand [Tue, 13 May 2014 02:24:19 +0000 (11:24 +0900)]
focus: Fixed the animation issue related to bring_in.
Summary:
Calculating the coordinate of the object to retain the focus with in view port.
Earlier focus was moving out of view port.
Test Plan:
elementary_test-> "Focus 3". Enable the Focus Auto scroll bring in and use
keys to move focused item.
Reviewers: raster, seoz, singh.amitesh, nirajkr
Differential Revision: https://phab.enlightenment.org/D822
Stefan Schmidt [Mon, 12 May 2014 12:55:13 +0000 (14:55 +0200)]
release: v1.10.0 beta2
Jean-Philippe Andre [Mon, 12 May 2014 09:52:24 +0000 (18:52 +0900)]
test_dnd: Fix build for windows
There is no strndup (with our compilation flags).
Jean-Philippe Andre [Mon, 12 May 2014 06:44:18 +0000 (15:44 +0900)]
elm_map: Fix compilation warning/error
ELM_WIDGET_DATA_GET_OR_RETURN can take a VA_ARGS if the function
should return something.
Jean-Philippe Andre [Mon, 12 May 2014 06:09:03 +0000 (15:09 +0900)]
Compilation: Align EDJ, EOLIAN and EPB to CC
Jaehyun Cho [Mon, 12 May 2014 04:44:03 +0000 (13:44 +0900)]
elm_map: Fix to support customized style for elm_map
Summary: Load a map theme with a style to support customized style
@fix
Reviewers: Hermet
Reviewed By: Hermet
CC: seoz
Differential Revision: https://phab.enlightenment.org/D845
Mike Blumenkrantz [Sun, 11 May 2014 18:22:06 +0000 (14:22 -0400)]
okay, I'll be a nice guy and leave music-control theme compat
Mike Blumenkrantz [Sun, 11 May 2014 18:05:30 +0000 (14:05 -0400)]
fix music-control theme namespacing
Mike Blumenkrantz [Sun, 11 May 2014 17:57:37 +0000 (13:57 -0400)]
rename pager16 theme groups pager2 -> pager16
Mike Blumenkrantz [Sun, 11 May 2014 17:48:09 +0000 (13:48 -0400)]
remove deskmirror theme ifdef
Daniel Juyung Seo [Sun, 11 May 2014 16:04:25 +0000 (01:04 +0900)]
focus: update the focus in_theme status on each item's focus set.
As widget and widget item can have different in_theme value (since
30cada369), we need to update in_theme value whenever the widget or
widget item get the focus.
Applied this logic to genlist, gengrid, toolbar first.
List focus is not working well at the moment.
This fixes small focus highlight on the left top corner of genlist
when the genlist scroller is clicked before the genlist is focused.
Special thanks to zmike for the report.
davemds [Sun, 11 May 2014 14:13:39 +0000 (16:13 +0200)]
set expected ellipsis value for hoversel
Daniel Juyung Seo [Sun, 11 May 2014 14:06:59 +0000 (23:06 +0900)]
list: Use convenient macro ELM_RECTS_INCLUDE.
Daniel Juyung Seo [Sun, 11 May 2014 13:42:45 +0000 (22:42 +0900)]
focus: Change new API names related to focus auto scrolling.
elm_config_focus_auto_scroll_bring_in_enabled_get/set()
->
elm_config_focus_autoscroll_mode_get/set()
The main reason is that bring_in_enabled_get/set() APIs are too restricted
and thus not flexible. I got more requirements for the focus autoscrolling
such as none, wholely visible not just bring_in and show. So it is correct
to add mode_set/get() APIs for the focus auto scrolling.
Thanks god, we've found this before the release :)
@feature
Daniel Juyung Seo [Sun, 11 May 2014 08:53:00 +0000 (17:53 +0900)]
Revert "remove all scrolling changes for focused items."
This reverts commit
377179bdaf84aa1a86621cdfa64ed43613ab9d45.
The main claim of https://phab.enlightenment.org/T1205 was fixed in
the previous commit
30cada369. This code will be modifed again in the
next commit due to the api change during development life cycle.
Note: do not blindly revert this commit if you have any problem with
widget item focus. This commit is not related to any fundamental cause
of the issues. If you have a problem, please contact me first.
seojuyung2@gmail.com or SeoZ on IRC.
Thanks.
Daniel Juyung Seo [Sun, 11 May 2014 12:20:04 +0000 (21:20 +0900)]
gengrid/genlist/list/toolbar: Do not set the focus to the item on widget's first focus.
This was introduced during 1.10 development phase but this changed the
default focus behavior and got a lot of complaints. (especially from
discomfitor)
So I would like to comment this out now and make it optional on 1.11
by keeping the default behavior.
Daniel Juyung Seo [Sat, 10 May 2014 14:41:10 +0000 (23:41 +0900)]
list: added comments about an unused function.
Fixing this issue is not trivial and will bring another issues like crashing.
So it is better to fix this in a development phase by refactoring list.
To fix this issue, the following are needed:
1. it->walking concept should be adopted instead of using just sd->walking.
sd->walking was introduced in
beb418d6
2. elm_widget_item_del() should be called instead of the combination of
_elm_list_item_free() + elm_widget_item_free()
This was introduced in
f343011d
Daniel Juyung Seo [Sat, 10 May 2014 14:37:03 +0000 (23:37 +0900)]
list: initialize some internal variables on item free not item del pre.
This fixes variable initialize problems related to focus. This can be
reproduced when you enable focus highlight/animation and reuse
elm_list by clearing it.
This problem occurred because list item del pre is never been called.
This bug will be addressed in a next commit.
Daniel Juyung Seo [Sat, 10 May 2014 14:15:54 +0000 (23:15 +0900)]
elm: fixed trivial formattings.
Just found them while reading codes.
Daniel Juyung Seo [Sat, 10 May 2014 14:13:12 +0000 (23:13 +0900)]
elm: call elm_widget_item_del instead of elm_object_item_del inside elementary.
This reduces only one more function call but this makes the elm code
more consistent between widgets.
Carsten Haitzler (Rasterman) [Sun, 4 May 2014 22:41:38 +0000 (07:41 +0900)]
theme - fix e list item selecton and label
Cedric Bail [Sat, 10 May 2014 09:27:26 +0000 (11:27 +0200)]
autotools: remove dead and erroneous code.
Daniel Juyung Seo [Sat, 10 May 2014 05:07:14 +0000 (14:07 +0900)]
elm: fixed wrong internal variable name.
Unified the local variable name to ret if the ret is a return value of
another content_unset calls.
- Evas_Object *int_ret --> Evas_Object *ret
- Evas_Object *int_content --> Evas_Object *ret
- Evas_Object *content --> Evas_Object *ret
Daniel Juyung Seo [Sat, 10 May 2014 05:01:33 +0000 (14:01 +0900)]
test_naviframe: added a test for event freeze checking.
Mike Blumenkrantz [Sat, 10 May 2014 04:13:05 +0000 (00:13 -0400)]
clock theme forces visibility on date text
fix T490
Mike Blumenkrantz [Fri, 9 May 2014 19:35:50 +0000 (15:35 -0400)]
genlist theme uses scale;
Mike Blumenkrantz [Fri, 9 May 2014 19:58:03 +0000 (15:58 -0400)]
genlist theme no longer uses desc.state anywhere
Daniel Juyung Seo [Fri, 9 May 2014 16:12:20 +0000 (01:12 +0900)]
gengrid: removed build warning.
Anil Kumar Nahak [Fri, 9 May 2014 16:09:27 +0000 (01:09 +0900)]
test_gengrid: Added a checkbox for enable/disable of reorder_mode feature
Summary: reorder mode can be enable/disable by clicking "'Reorder mode enable" checkbox
Test Plan: elementary_test->"GenGrid"
Reviewers: raster, seoz, nirajkr, singh.amitesh
Reviewed By: seoz
Differential Revision: https://phab.enlightenment.org/D829
Anil Kumar Nahak [Fri, 9 May 2014 16:07:57 +0000 (01:07 +0900)]
genlist/gengrid: Use pan object geometry for focus highlight calculation
Summary: Genlist/gengrid object geometry was used before this patch but using the pan object geometry is more correct. This can be reproduced when the size of "elm.swallow.content" part is smaller then the size of scroller object, focus animtaion on items is jerky.
Reviewers: raster, seoz, singh.amitesh
CC: nirajkr
Differential Revision: https://phab.enlightenment.org/D818