Matt Ellis [Wed, 28 Jun 2017 22:33:03 +0000 (15:33 -0700)]
Update to master prerelease2 tag
release/uwp6.0 is going to use preview1 and we don't want to publish
different versions of the package with the same package identity
Pat Gavlin [Thu, 29 Jun 2017 00:15:59 +0000 (17:15 -0700)]
Merge pull request #12528 from pgavlin/NoPgoOption
Add a flag to build.{sh,cmd} to disable PGO.
Pat Gavlin [Thu, 29 Jun 2017 00:01:08 +0000 (17:01 -0700)]
Merge pull request #12534 from dotnet-bot/from-tfs
Merge changes from TFS
Pat Gavlin [Wed, 28 Jun 2017 23:04:26 +0000 (16:04 -0700)]
Merge pull request #12487 from pgavlin/GenTreeVisitor
Add a new, faster tree walker.
Bruce Forstall [Wed, 28 Jun 2017 22:21:40 +0000 (15:21 -0700)]
Merge pull request #12531 from dotnet-bot/from-tfs
Merge changes from TFS
Pat Gavlin [Wed, 28 Jun 2017 22:08:02 +0000 (15:08 -0700)]
Fix a release build break.
[tfs-changeset: 1663777]
Koundinya Veluri [Wed, 28 Jun 2017 19:07:08 +0000 (12:07 -0700)]
Move ReaderWriterLockSlim to shared partition
JC Aguilera [Wed, 28 Jun 2017 20:45:47 +0000 (13:45 -0700)]
Enable SourceBranch to be passed from the pipeline parameters
Enable SourceBranch to be passed from the pipeline parameters
Pat Gavlin [Wed, 28 Jun 2017 20:44:44 +0000 (13:44 -0700)]
Format code.
Pat Gavlin [Wed, 28 Jun 2017 20:40:40 +0000 (13:40 -0700)]
Address PR feedback.
Bruce Forstall [Wed, 28 Jun 2017 20:34:07 +0000 (13:34 -0700)]
Fix build error
[tfs-changeset: 1663755]
Pat Gavlin [Wed, 28 Jun 2017 19:59:19 +0000 (12:59 -0700)]
Fix usage style.
Steve MacLean [Wed, 28 Jun 2017 19:52:24 +0000 (15:52 -0400)]
Reduce excessive loop count in interlocked tests (#12222)
Jonghyun Park [Wed, 28 Jun 2017 18:44:18 +0000 (03:44 +0900)]
Use proper ifdef for EmitProfilerComCallXXX methods (#12502)
Jeremy Kuhne [Wed, 28 Jun 2017 18:43:54 +0000 (11:43 -0700)]
Fix debug assert (#12496)
Jonghyun Park [Wed, 28 Jun 2017 18:40:22 +0000 (03:40 +0900)]
Fix build error when FEATURE_READYTORUN_COMPILER is disabled (#12505)
Pat Gavlin [Wed, 28 Jun 2017 17:37:51 +0000 (10:37 -0700)]
Add a flag to build.{sh,cmd} to disable PGO.
This is helpful when performing JIT throughput measurements.
Hyeongseok Oh [Wed, 28 Jun 2017 18:01:18 +0000 (03:01 +0900)]
[RyuJIT/ARM32] Enable passing large split struct argument (#12050)
* [RyuJIT/ARM32] Enable passing large split struct
This enables passing split struct larger than 16 bytes.
To support splitted struct, it defines new GenTree type - GenTreePutArgSplit.
GenTreePutArgSplit is similar with GenTreePutArgStk,
but it is used for splitted struct only
and it has additional field to save register information.
GenTreePutArgSplit node is generated in lower phase.
* Apply reviews: split struct argument passing
- Fix some comments:
genPutArgSplit, GenTreePutArgStk, GenTreePutArgSplit, NuwPutArg, ArgComplete
- Add assertion check in genPutArgSplit, genCallInstruction
- Rename variable: baseReg
- Change flag for GenTreePutArgSplit: _TARGET_ARM && !LEGACY_BACKEND
- Change type of gtOtherRegs in GenTreePutArgSplit
- Remove duplicated code: NewPutArg
- Implement spill & restore flag for GenTreePutArgSplit
* Apply reviews
- Rebase
- Update managing spillFlag for split struct
- Implement spill & restore code generation
- Fix typos and rename variables
- Fix bug related to print gentree for split struct
* Fix bug and comments
- Fix bug in regset.cpp
- Add comments in morph.cpp's NYI_ARM
- Fix comments' typo in lsraarmarcp.cpp
JC Aguilera [Wed, 28 Jun 2017 17:15:58 +0000 (10:15 -0700)]
Enable SourceBranch to be passed from the pipeline parameters
sets SkipBranchAndVersionOverrides=false so SourceBranch and SourceVersion
are correctly passed through the pipeline file.
set SkipBranchAndVersionOverrides=true for the publish definitions as
they don't build from the SourceBranch and instead use a different
tools branch to do their work.
Pat Gavlin [Tue, 27 Jun 2017 22:28:26 +0000 (15:28 -0700)]
Convert lvaMarkLclRefs to a visitor.
Pat Gavlin [Tue, 27 Jun 2017 18:34:33 +0000 (11:34 -0700)]
Convert lva{Inc,Dec}RefCntsCB to a visitor.
Pat Gavlin [Tue, 27 Jun 2017 06:35:10 +0000 (23:35 -0700)]
Convert rationalize to the generic visitor.
Pat Gavlin [Tue, 27 Jun 2017 06:18:32 +0000 (23:18 -0700)]
Convert fgWalkTree{Pre,Post,} to use the new visitor.
Pat Gavlin [Tue, 27 Jun 2017 06:17:30 +0000 (23:17 -0700)]
Add a generic tree visitor.
This visitor replaces the function-pointer-based walkers with a more
modern design centered around the curiously-recurring-template pattern.
Adeel Mujahid [Wed, 28 Jun 2017 15:02:16 +0000 (18:02 +0300)]
Cleanup some instances of project.json from the repo (#12484)
* Replace ScriptGenerator project.json with csproj
* Update project.json occurrences in docs
Fix few typos.
* Remove project.json comments
Kyungwoo Lee [Wed, 28 Jun 2017 15:00:27 +0000 (08:00 -0700)]
Fix remove in list (#12497)
`remove` uses `erase` to delete the entry in list.
Since `erase` returns the next iterator, the iterator shouldn't be increased
when the entry is found and deleted.
Hugh Bellamy [Wed, 28 Jun 2017 14:59:15 +0000 (21:59 +0700)]
Remove disabled tests for Marshal.IsComObject(null) (#12359)
Ruben Ayrapetyan [Wed, 28 Jun 2017 06:16:01 +0000 (09:16 +0300)]
Partially remove relocations from Class section of NGEN-ed images (#11962)
* Remove relocations for ParamTypeDesc::m_TemplateMT.
* Remove relocations for LayoutEEClass::m_LayoutInfo.m_pFieldMarshalers.
* Prepare RelativeFixupPointer.
* Remove relocations for FieldMarshaler::m_pFD and FieldMarshaler_*::m_*.
Jonghyun Park [Wed, 28 Jun 2017 06:12:51 +0000 (15:12 +0900)]
Remove unused declaration (#12501)
Sergey Andreenko [Wed, 28 Jun 2017 00:06:59 +0000 (17:06 -0700)]
spmi add R2R field to getFieldInfo (#12498)
Ruben Ayrapetyan [Tue, 27 Jun 2017 16:22:07 +0000 (19:22 +0300)]
Fix JIT_NewArr1 8-byte alignment for ELEMENT_TYPE_R8 on x86.
Jan Kotas [Tue, 27 Jun 2017 00:10:12 +0000 (17:10 -0700)]
Fix rough edges after CLI update (dotnet/corert#3983)
* Move build-restore.cmd back to build-managed
buildpipeline needs to be updated to make this split
* Cleanup dir.props/dir.targets
* Add back VS clues
* Reformat whitespaces to match VS convention
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Atsushi Kanamori [Tue, 27 Jun 2017 18:51:28 +0000 (11:51 -0700)]
Fix bad range check in TextInfo.IndexOfStringOrdinalIgnoreCase (#12478)
Breaks:
int idx = "\uabcd".IndexOf("", 1, StringComparison.OrdinalIgnoreCase);
should return 1, returns -1 instead.
(propagated fix from CoreRT)
Ruben Ayrapetyan [Tue, 27 Jun 2017 18:31:03 +0000 (21:31 +0300)]
Implement JIT_NewArr1_R2R as R2R wrapper for JIT_NewArr1 to support both MethodTable-based and TypeDesc-based helpers. (#12475)
Related issue: #12463
Carol Eidt [Tue, 27 Jun 2017 14:36:56 +0000 (07:36 -0700)]
Merge pull request #12473 from hqueue/arm/ryujit/lsra_use_helper
[RyuJIT/ARM32][WIP] Update LSRA with helpers
Konstantin Baladurin [Tue, 27 Jun 2017 14:19:31 +0000 (17:19 +0300)]
[Linux][GDB-JIT] Fix memory leak (#12452)
Use NewArrayHolder for pVars in LocalsInfo class
Hyung-Kyu Choi [Tue, 27 Jun 2017 11:24:34 +0000 (20:24 +0900)]
[RyuJIT/ARM32] Update LSRA with new helper
- Introduce updatePreviousInterval()
- Update LSRA with helper
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Sergey Andreenko [Tue, 27 Jun 2017 06:00:59 +0000 (23:00 -0700)]
support spmi collection for r2r calls. (#12343)
* CreateAgnostic_CORINFO_SIG_INFO
Also you pSig_Index always when it is index in the buffer map,
as we do for sigInst_classInst_Index for example.
* spmi Restore_CORINFO_RESOLVED_TOKENout
delete another duplicate.
* SpmiDumpHelper
* spmi cleaning: GetFunctionEntryPoint and GetAddressOfPInvokeTarget
* support GetReadyToRunHelper and GetReadyToRunDelegateCtorHelper in spmi.
* Fix typo that annoys desktop build.
* spmi GetReadyToRunDelegateCtorHelper
* spmi: use agnostic type for GetReadyToRunDelegateCtorHelper value.
* spmi dump Agnostic_CORINFO_LOOKUP
add stubLookup to dmpGetCallInfo
* clean dmpGetMethodSig and dmpGetTailCallCopyArgsThunk
Hyung-Kyu Choi [Tue, 27 Jun 2017 05:48:33 +0000 (14:48 +0900)]
[RyuJIT/ARM32] Use helper for LSRA
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Pat Gavlin [Tue, 27 Jun 2017 05:34:53 +0000 (22:34 -0700)]
Merge pull request #12460 from pgavlin/SinglePassRationalize
Rephrase rationalize as a single IR walk.
Pat Gavlin [Tue, 27 Jun 2017 03:32:53 +0000 (20:32 -0700)]
Format code.
Carol Eidt [Tue, 27 Jun 2017 00:25:55 +0000 (17:25 -0700)]
Merge pull request #12423 from CarolEidt/ContainDoNotEnreg
Mark lvDoNotEnregister lclVars as contained
Pat Gavlin [Mon, 26 Jun 2017 23:16:27 +0000 (16:16 -0700)]
Merge pull request #12457 from pgavlin/RewriteIntrinsicsRefactor
Refactor the rationalizer's instrinsic rewriter.
Pat Gavlin [Mon, 26 Jun 2017 21:56:09 +0000 (14:56 -0700)]
Rephrase rationalize as a single IR walk.
This walk performs both pre- and post-order visits. The pre-order visit
is responsible for rewriting intrinsics as user calls where necessary;
the post-order visit is resonsible for converting HIR nodes into LIR
nodes.
Pat Gavlin [Mon, 26 Jun 2017 21:40:15 +0000 (14:40 -0700)]
Use LIR utilities in the intrinsic rewriter.
This simplifies the code a bit and prepares it for some changes to
perform single-pass rationalization.
Pat Gavlin [Mon, 26 Jun 2017 22:31:06 +0000 (15:31 -0700)]
Merge pull request #12440 from pgavlin/MaintainIsUnusedValue
Maintain `LIR::IsUnusedValue` in the backend.
Pat Gavlin [Mon, 26 Jun 2017 22:30:15 +0000 (15:30 -0700)]
Update a header comment.
Pat Gavlin [Mon, 26 Jun 2017 21:43:27 +0000 (14:43 -0700)]
Format code and address PR feedback.
Ruben Ayrapetyan [Mon, 26 Jun 2017 21:18:19 +0000 (00:18 +0300)]
Replace array type handle with method table in arguments of array allocation helpers (#12369)
* Remove direct usage of type handle in JIT_NewArr1, with except of retrieving template method table.
* Assert that array type descriptor is loaded when array object's method table is set.
* Pass template method tables instead of array type descriptors to array allocation helpers.
Pat Gavlin [Mon, 26 Jun 2017 19:58:42 +0000 (12:58 -0700)]
Refactor the rationalizer's instrinsic rewriter.
Change its two constituent static methods into instance methods.
Pat Gavlin [Mon, 26 Jun 2017 15:52:31 +0000 (08:52 -0700)]
Merge pull request #12441 from pgavlin/TryGetUseInline
Avoid the use edge iterator in `TryGetUse`.
Jan Kotas [Fri, 23 Jun 2017 01:43:00 +0000 (18:43 -0700)]
Merge pull request dotnet/corert#3969 from dotnet/nmirror
Merge nmirror to master
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Pat Gavlin [Sat, 24 Jun 2017 21:09:29 +0000 (14:09 -0700)]
Format code.
Pat Gavlin [Wed, 21 Jun 2017 17:24:27 +0000 (10:24 -0700)]
Return early in `TryGetUse` for unused nodes.
Now that `IsUnusedValue` is maintained during the first half of the
backend, `TryGetUse` can terminate early if it is set.
Note that this may return false negatives if the `IsUnusedValue` flag is
incorrectly set, but remains correct if said flag is incorrectly
cleared.
Pat Gavlin [Sat, 24 Jun 2017 00:41:06 +0000 (17:41 -0700)]
Remove an IR walk during lowering.
Now that the `IsUnusedValue` flag is maintained by decomposition and
lowering, it does not need to be recalculated before LSRA.
Pat Gavlin [Wed, 21 Jun 2017 01:22:45 +0000 (18:22 -0700)]
Maintain `LIR::IsUnusedValue` in the backend.
This flag indicates whether or not the SDSU temp produced by a node is
ever read. This information is needed by the register allocator, but is
also useful in other parts of the compiler (for example, `TryGetUse` can
return immediately if this flag is set). Setting this flag properly in
rationalize and maintaining it through decomposition and lowering allows
us to remove an IR walk immediately prior to LSRA.
Pat Gavlin [Sat, 24 Jun 2017 21:06:48 +0000 (14:06 -0700)]
Merge pull request #12439 from pgavlin/SkipDecomp
Update compLongUsed in rationalize.
sergey ignatov [Sat, 24 Jun 2017 15:57:59 +0000 (18:57 +0300)]
[CoreRT armel] fix for PINVOKE calls in CoreRT (#12373)
Pat Gavlin [Fri, 23 Jun 2017 22:31:47 +0000 (15:31 -0700)]
Avoid the use edge iterator in `TryGetUse`.
`TryGetUse` does not require the ordering semantics provided by the use
edge iterator. Replace use edge iteration with manual inspection of each
node type.
Pat Gavlin [Fri, 23 Jun 2017 16:26:42 +0000 (09:26 -0700)]
Update compLongUsed in rationalize.
This allows us to skip decompisition if long-typed values are not used by a method.
Carol Eidt [Fri, 23 Jun 2017 21:54:27 +0000 (14:54 -0700)]
Mark lvDoNotEnregister lclVars as contained
Even if a lclVar is tracked, it may not be a register candidate. When determining whether a lclVar should be contained or RegOptional, take that into account.
In the interest of making this as accurate as possible, mark lclVars early as lvDoNotEnregister when they meet criteria that will later disqualify them from a register.
Hugh Bellamy [Fri, 23 Jun 2017 22:23:50 +0000 (05:23 +0700)]
Update Windows parameter name for Normalize/IsNormalized with invalid form (#12430)
Carol Eidt [Thu, 22 Jun 2017 18:43:57 +0000 (11:43 -0700)]
# This is a combination of 2 commits.
# The first commit's message is:
Mark lvDoNotEnregister lclVars as contained
Even if a lclVar is tracked, it may not be a register candidate. When determining whether a lclVar should be contained or RegOptional, take that into account.
In the interest of making this as accurate as possible, mark lclVars early as lvDoNotEnregister when they meet criteria that will later disqualify them from a register.
# This is the commit message #2:
Formatting
Mike McLaughlin [Fri, 23 Jun 2017 22:02:36 +0000 (15:02 -0700)]
Add ELF program and section headers to core dump. (#12425)
Add ELF program and section headers to core dump.
Issue #12341
This allows the build id for the modules be extracted properly.
Add .eh_frame, .eh_frame_hdr and some other important sections to core dump.
Add managed module names to core dump so the symbol acquisition
tool can get symbol store keys for them.
Add the non memory/file backed memory regions to core dump so debuggers
like lldb can check if an address is "code" or not. Unwinding doesn't
work when there isn't a module/.so file present.
Sean Gillespie [Fri, 23 Jun 2017 21:48:41 +0000 (14:48 -0700)]
[Local GC] Remove a number of inclusions of handle table private headers from the VM (#12389)
* Remove inclusions of private handle table headers from the VM
* Add TraceRefCountedHandles to the GC handle table interface
* Fix the Unix build
* Move ValidatePinnedObject to marshalnative.h
Bruce Forstall [Fri, 23 Jun 2017 21:26:56 +0000 (14:26 -0700)]
Fix JitMinOptsTrackGCrefs for legacy x86 back-end (#12416)
Addresses #12415
William Godbe [Fri, 23 Jun 2017 19:20:56 +0000 (12:20 -0700)]
Merge pull request #12424 from wtgodbe/ArmRunsPipeline
Enable ARM test runs in Helix
Xiangyang (Mark) Guo [Fri, 23 Jun 2017 00:39:41 +0000 (17:39 -0700)]
Fix systemMask on Linux (#12387)
* fix systemMask
* code refactor
Sergey Andreenko [Thu, 22 Jun 2017 23:41:21 +0000 (16:41 -0700)]
Spmi third cleaning (#12418)
* CreateAgnostic_CORINFO_SIG_INFO
Also you pSig_Index always when it is index in the buffer map,
as we do for sigInst_classInst_Index for example.
* spmi Restore_CORINFO_RESOLVED_TOKENout
delete another duplicate.
* SpmiDumpHelper
Bruce Forstall [Thu, 22 Jun 2017 23:06:24 +0000 (16:06 -0700)]
Merge pull request #12409 from dotnet-bot/from-tfs
Merge changes from TFS
Bruce Forstall [Thu, 22 Jun 2017 21:24:23 +0000 (14:24 -0700)]
Merge pull request #12417 from sjsinju/fix_3bytes_struct
[RyuJIT/ARM32] Change the 3bytes struct to int on morph phase.
wtgodbe [Thu, 22 Jun 2017 18:59:49 +0000 (11:59 -0700)]
Enable ARM test runs in Helix
William Godbe [Thu, 22 Jun 2017 18:55:26 +0000 (11:55 -0700)]
Merge pull request #12413 from wtgodbe/ArmRuns
First step for enabling ARM test runs
Carol Eidt [Thu, 22 Jun 2017 18:35:34 +0000 (11:35 -0700)]
Merge pull request #12422 from CarolEidt/lvaSetClassDiffable
Make lvaSetClass dump diffable
Carol Eidt [Thu, 22 Jun 2017 17:35:36 +0000 (10:35 -0700)]
Make lvaSetClass dump diffable
Ravi Eda [Thu, 22 Jun 2017 17:19:59 +0000 (12:19 -0500)]
Update attribute-value in security build definition. (#12419)
sjsujinkim [Thu, 22 Jun 2017 01:52:59 +0000 (10:52 +0900)]
[RyuJIT/ARM32] Change the 3bytes struct to int on morph phase.
It is necessary that the 3bytes struct which is a local var to int on morph phase.
Related Issue : #12290 (Assertion failed 'emitTypeSizes[TypeGet(type)] > 0')
Yuri Vanin [Thu, 22 Jun 2017 04:57:25 +0000 (21:57 -0700)]
Add String.Contains overload with StringComparison (#12400)
Staging change of System.Private.CoreLib for CoreFX #20846
Sergey Andreenko [Wed, 21 Jun 2017 23:20:37 +0000 (16:20 -0700)]
Spmi second cleaning (#12402)
* don't init zero-init struct with nulls.
* Clean spmi code for GetTokenTypeAsHandle and GetCastingHelper
* Clean spmi GetVarArgsHandle and CanGetVarArgsHandle
* Clean GetCookieForPInvokeCalliSig and CanGetCookieForPInvokeCalliSig
* clean spmi GetNewHelper
* clean spmi GetArgType
* clean spmi GetArgClassValue
wtgodbe [Wed, 21 Jun 2017 22:57:10 +0000 (15:57 -0700)]
First step for enabling ARM test runs
Michelle McDaniel [Wed, 21 Jun 2017 21:34:27 +0000 (14:34 -0700)]
Merge pull request #12404 from adiaaida/changeLinuxTPAssemblies
Align Linux TP benchmarks with Windows TP benchmarks
Bruce Forstall [Wed, 21 Jun 2017 19:26:56 +0000 (12:26 -0700)]
Fix arm64 build break
[tfs-changeset: 1662444]
Jeremy Kuhne [Wed, 21 Jun 2017 18:51:36 +0000 (11:51 -0700)]
Need to pass handle to SeekCore (#12399)
We're not setting the member field until the end of construction.
Koundinya Veluri [Wed, 21 Jun 2017 18:07:01 +0000 (11:07 -0700)]
Fix event, semaphore, mutex create/open to request the maximum allowe… (#12381)
Fix event, semaphore, mutex create/open to request the maximum allowed access
Functional fix for #11306
- Ported dotnet/corert@
78fae17f5434839a8720603973ff53f27e27f916 to CoreCLR, see that commit for details on the hang during mutex creation that is also fixed by this change.
- Replaced all uses of the *_ALL_ACCESS flags relevant to events, semaphores, and mutexes
Eugene Rozenfeld [Wed, 21 Jun 2017 17:52:47 +0000 (10:52 -0700)]
Merge pull request #12395 from erozenfeld/fgMorphRecognizeBoxNullable
Fix for a bug in fgMorphRecognizeBoxNullable.
Ravi Eda [Wed, 21 Jun 2017 17:18:46 +0000 (12:18 -0500)]
Provision CodeBase and NotificationAlias variables -CoreCLR (#12403)
* Security build JSONs.
* Provision CodeBase and NotificationAlias variables.
Michelle McDaniel [Wed, 21 Jun 2017 16:55:43 +0000 (09:55 -0700)]
Align Linux TP benchmarks with Windows TP benchmarks
On Windows, we download a set of assemblies that we have uploaded to
MyGet. On Linux, we were building corefx each run to get the benchmarks.
This change updates Linux to pull down the same benchmarks Windows uses,
using curl to grab the nuget package from MyGet.
Note: after this commit, we will have data for fewer assemblies on
Linux, but we will now have the same set for both Windows and Linux.
Some data in Benchview may be affected.
Wes Haggard [Wed, 21 Jun 2017 16:19:46 +0000 (09:19 -0700)]
Merge pull request #12379 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr, CoreFx to preview1-25421-01, preview1-25421-02, respectively (master)
Carol Eidt [Wed, 21 Jun 2017 14:46:23 +0000 (07:46 -0700)]
Merge pull request #12164 from hqueue/arm/ryujit/lsra_12078_live_in
[RyuJIT/ARM32] Unassign double register properly at BB entry
Carol Eidt [Wed, 21 Jun 2017 14:43:37 +0000 (07:43 -0700)]
Merge pull request #12358 from jyoungyun/ryujit/assersion_failed_info_numslots_is_1
[RyuJIT/ARM32] Assign 2 numslots to gtLsraInfo.srcCount in TYP_DOUBLE
dotnet-maestro-bot [Wed, 21 Jun 2017 13:38:07 +0000 (13:38 +0000)]
Update CoreClr, CoreFx to preview1-25421-01, preview1-25421-02, respectively
Richard L. Jackson [Wed, 21 Jun 2017 09:33:20 +0000 (11:33 +0200)]
Please include this line to enable build (#12382)
find_path(LLDB_H "lldb/API/LLDB.h" PATHS "/usr/lib/llvm-4.0/include")
Sergey Andreenko [Wed, 21 Jun 2017 07:27:08 +0000 (00:27 -0700)]
Spmi source code cleaning (#12378)
* fix pointer names in CORINFO_RESOLVED_TOKENin
* Remove exceptionCode from Agnostic_CORINFO_RESOLVED_TOKENout
The target if to do Agnostic_CORINFO_RESOLVED_TOKEN =
Agnostic_CORINFO_RESOLVED_TOKENin + Agnostic_CORINFO_RESOLVED_TOKENout
* Agnostic_CORINFO_RESOLVED_TOKEN = Agnostic_CORINFO_RESOLVED_TOKENin + Agnostic_CORINFO_RESOLVED_TOKENout
* spmi cleaning for ResolvedToken.
It is only the first part of changes. I am trying to delete as many code
as I can, because for now it is bad pain to make changes in this files.
Eugene Rozenfeld [Tue, 20 Jun 2017 23:46:02 +0000 (16:46 -0700)]
Fix for a bug in fgMorphRecognizeBoxNullable.
fgMorphRecognizeBoxNullable doesn't work correctly when called during re-morphing. In particular it can't handle late args in the call to CORINFO_HELP_BOX_NULLABLE. The test case results in several asserts (the first one in lsra) followed by an infinite loop in the jit.
The reason the optimization is not performed during global morph is that only patterns with GT_EQ and GT_NE are handled. Some versions of csc generate
...
ldnull
cgt.un
ret
for
this C# line
null != this.value
so we get GT_GT instead.
The fix has two parts:
1. Don't attempt to perform the optimization when called during re-morph and the struct parameter is a late arg.
2. Call fgMorphRecognizeBoxNullable for GT_GT nodes with GTF_UNSIGNED set. This allows the optimization to fire during global morph.
Hyung-Kyu Choi [Wed, 21 Jun 2017 03:06:19 +0000 (12:06 +0900)]
Enable and use updateAssginedInterval() for all targets
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Daniel Podder [Wed, 21 Jun 2017 02:39:49 +0000 (19:39 -0700)]
Update trusted RHEL build Dockertag to support LTO (#12396)
The new RHEL image was generated using the same Dockerfile as the
previous, but has LLVM recompiled with gold support enabled, which is
required to do a build with -flto (a prerequisite for PGO).
Hyung-Kyu Choi [Wed, 21 Jun 2017 02:21:45 +0000 (11:21 +0900)]
Introduce LinearScan::isAssignedToInterval()
Signed-off-by: Hyung-Kyu Choi <hk0110.choi@samsung.com>
Jiyoung Yun [Wed, 21 Jun 2017 02:09:14 +0000 (11:09 +0900)]
Fix typo and formatting issues
Jiyoung Yun [Tue, 20 Jun 2017 09:43:44 +0000 (18:43 +0900)]
[RyuJIT/ARM32] Avoid assersion for double arguments
Double arguments in ARM32 uses 2 slots and it isn't a multi-reg struct.
In this case, it should avoid an assersion that checks if the slot is 1.
Jiyoung Yun [Mon, 19 Jun 2017 07:32:17 +0000 (16:32 +0900)]
[RyuJIT/ARM32] Assign 1 srcCount in TYP_DOUBLE
Even though TYP_DOUBLE uses 2 numSlots, we consume 1 srcCount in TYP_DOUBLE