Jeremy Koritzinsky [Fri, 5 Apr 2019 01:37:57 +0000 (18:37 -0700)]
Fix SystemV AMD64 Explicit structure classification (#22041)
* Don't bail out on enregistering explicit structs if there are no overlapping fields.
* Don't enregister if any unaligned fields.
* Enable passing explicit structs by-value by enregistering on systemv. Some edge cases are likely still broken, but just removing our blanket opt-out makes the current tests pass.
* Enable MarshalstructAsLayoutExp off-Windows.
* Start adding additional tests for explicit layout to try to catch edge cases in SystemV classification.
* Added a test that spans across multiple eightbytes and has an overlap in the second eightbyte.
* Change repro to use an array of floats and an int field in managed and use a float array for padding in native to force an SSE classification on the first byte.
* New algorithm to calculate eightbyte classification by going throw the structure byte-by-byte instead of field-by-field.
* Fix updating eightbyte classifications in the loop to actually used the iterated-upon variable.
* Consider each element of a fixed array as a separate field (to match native implementations).
* Implement correct SystemV classification for fixed buffers in non-blittable structures. Fixed buffers in blittable structures have the managed layout assign classifications, which still is buggy.
* Add tests.
* Correctly classify blittable fixed buffers. Move "is this field a fixed buffer" tracking into one of the unused bits in FieldDesc as code that isn't in marshalers needs to know about it.
* Handle the case where we have a struct that has no fields in an eightbyte that contains (i.e. no fields in the first eight bytes of the structure).
* PR feedback.
* Only look up FixedBufferAttribute when the type is a value class and the type of the field is a value type.
* Use heuristic to determine if a type is a fixed buffer for SystemV classification.
* Revert tracking if a field is a fixed buffer in the FieldDesc.
* Update comments.
* Classify aligned, nonoverlapping, float/double only structures as HFAs even if explicitly laid out
* Enable overlapping fields in HFAs. Update NativeType HFA to check for alignment.
I checked Godbolt to verify that HFAs for overlapping fields are allowed.
* Add HFA tests.
* Fix compile errors from HFA alignment check.
* Non-valuetypes will never have their managed layout used to classify SystemV eightbytes.
* Don't classify a struct with no zero-offset field as an HFA.
* Remove duplicate semicolon.
* PR feedback.
* Add test with 2-field double HFA.
* Clean up and add static asserts for struct size.
* Add define for static_assert_no_msg to the native test headers
* Fix build breaks.
* Remove unneeded "size = X bytes" comments. They were holdovers from the .NET Framework test tree.
* Use GetNumInstanceFieldBytes instead of GetLayoutInfo()->GetManagedSize()
* Fix build break.
* Centralize FieldMarshaler offsettting in ClassifyEightBytesWithNativeLayout.
* Fix signed/unsigned mismatch
* Fix condition to also detect arm64.
* Change ifdef to if defined.
* Remove duplicate declaration (broken in rebase)
* Add some logging in one of the unreproable OSX test failures.
* Mark System.Numerics.Vector as intrinsic and don't use the eightbyte classifier to enregister it.
* Also explicitly opt-out of HFAs for System.Numerics.Vector`1 for consistency.
* Update R2R required version to 3.0.
* Remove debugging prints.
Jan Vorlicek [Thu, 4 Apr 2019 22:36:34 +0000 (00:36 +0200)]
Merge pull request #23537 from janvorli/remove-gc-cpu-group-knowledge
Remove CPU groups notion from the gc.cpp
Egor Chesakov [Thu, 4 Apr 2019 19:07:00 +0000 (12:07 -0700)]
Run on Ubuntu.1604.Arm32.Open in pull requests and scheduled builds (#23729)
Egor Chesakov [Thu, 4 Apr 2019 19:05:34 +0000 (12:05 -0700)]
Use BYOC pools in "Publish to BAR" job (#23733)
Jeremy Koritzinsky [Thu, 4 Apr 2019 18:04:13 +0000 (11:04 -0700)]
Runtime support for upcoming .NET Core WinRT Host (#23402)
* First pass at adding winrt host entry-point.
* There's no way to specify HResult-swapping on a function called via hosted-interop so just return the HResult instead.
* Use the WindowsRuntimeMarshal class to create the activation factory and initialize it.
* Implement loading the dependent assemblies of a WinRT assembly into an isolated load context.
* PR Feedback.
* Fail to get the activation factory if the found type is not a managed type exported from a winmd.
* Rearrange parameters based on PR feedback.
* Remove unneeded include.
* Make ActivationFactoryLoader internal.
* Fix null-ref in WinRT-dependent-assembly loading
* Remove extraneous "System."
Jan Kotas [Thu, 4 Apr 2019 17:52:33 +0000 (10:52 -0700)]
Support simple assembly name in startup hook (#23517)
* Add support for specifying only assembly name for startup hook.
* Implement checking for simple assembly names in startuphook.
Also wrap load exceptions.
* Avoid global alloc
* Allow extra path separators in the startup hook variable
* Fixes for extra path separators
Jan Vorlicek [Thu, 4 Apr 2019 17:52:20 +0000 (19:52 +0200)]
Merge pull request #23721 from janvorli/fix-musl-arm64-crossbuild
Fix MUSL ARM64 cross build
Sung Yoon Whang [Thu, 4 Apr 2019 17:38:14 +0000 (10:38 -0700)]
Add Working Set runtime counter (#23717)
* Add cpu counter
* Fix windows build
* Make the counter just return current CPU usage as %
* Add Unix
* Fix unix build
* Some cleanup
* rename
* fixing some build errors
* some cleanup
* remove unused using
* more cleanup
* newline
* Add working set counter
* Remove old file
Carol Eidt [Thu, 4 Apr 2019 16:53:02 +0000 (09:53 -0700)]
Improve Upper Vector Save/Restore (#23344)
Improve Upper Vector Save/Restore
In order to avoid saving and restore the upper half of large vectors around every
call even if they are not used, separately model the upper half of large vector
lclVars, and track whether the large vector lclVar is partially-spilled, in which
case its upper half resides in its upper half Interval's location.
Fix #18144
Jeremy Koritzinsky [Thu, 4 Apr 2019 16:33:12 +0000 (09:33 -0700)]
Fix prefix of mock hostpolicy on Unix (#23692)
Fixes #23682
Carol Eidt [Thu, 4 Apr 2019 16:31:30 +0000 (09:31 -0700)]
Handle local struct pointer arithmetic (#23704)
The assert introduced in #23570 was overly aggressive, and didn't account for the fact that pointer arithmetic can exist in the IL, not just introduced by morph.
Fix #23693
Marek Safar [Thu, 4 Apr 2019 16:05:08 +0000 (18:05 +0200)]
Move parts of delegate to shared partition (#23552)
Jan Vorlicek [Thu, 4 Apr 2019 14:53:06 +0000 (07:53 -0700)]
Fix MUSL ARM64 cross build
There were two issues:
* the cross/toolchain.cmake was unconditionally setting the linker to ld.gold.
This is not wanted in general and the ld.gold cannot link arm64 MUSL stuff
correctly (it leaves a couple of TLS symbols as undefined)
* the src/vm/arm64/asmhelpers.S was referencing a global variable using absolute
relocation, which is not allowed in shared libraries on MUSL based Linux distros.
Stephen Toub [Thu, 4 Apr 2019 13:23:40 +0000 (09:23 -0400)]
Don't null out buffer in MemoryStream on Capacity reset (#23700)
Jan Vorlicek [Thu, 4 Apr 2019 10:46:33 +0000 (12:46 +0200)]
Modify affinity range config format for Windows
Each entry has to be prefixed by group number followed by comma. There
is nothing like global CPU index on Windows, all the APIs that support
more than 64 processors use group, in-group index pair. So specifying
the affinity this way matches what users are used to.
Vitek Karas [Thu, 4 Apr 2019 10:37:46 +0000 (03:37 -0700)]
Fixes for extra path separators
Vitek Karas [Thu, 4 Apr 2019 07:25:35 +0000 (00:25 -0700)]
Allow extra path separators in the startup hook variable
Sergey Andreenko [Thu, 4 Apr 2019 05:01:22 +0000 (22:01 -0700)]
Merge pull request #23706 from sandreenko/runCoreFXbaseileDaily
Run CoreFX baseline arm/arm64 Windows/Ubuntu daily.
Sung Yoon Whang [Thu, 4 Apr 2019 03:40:50 +0000 (20:40 -0700)]
Add CPU runtime counter (#23680)
* Add cpu counter
* Fix windows build
* Make the counter just return current CPU usage as %
* Add Unix
* Fix unix build
* Some cleanup
* rename
* fixing some build errors
* some cleanup
* remove unused using
* more cleanup
* newline
* Address PR feedback
* more pr feedback
* More feedback
David Wrighton [Thu, 4 Apr 2019 02:11:00 +0000 (19:11 -0700)]
Fix resource loading (#23714)
- Some resources are generated without setting a Major/Minor version in the resource directory
- This is legal, and we shouldn't skip parsing the resource
Filip Navara [Thu, 4 Apr 2019 01:02:15 +0000 (03:02 +0200)]
Move null check into separate method to prevent unnecessary conversion of null into ReadOnlySpan (#23616)
Fei Peng [Thu, 4 Apr 2019 00:15:45 +0000 (17:15 -0700)]
Fix GitHub23672 (#23674)
Sergey Andreenko [Wed, 3 Apr 2019 23:15:14 +0000 (16:15 -0700)]
Run CoreFX baseline arm/arm64 Windows/Ubuntu daily.
David Wrighton [Wed, 3 Apr 2019 22:54:05 +0000 (15:54 -0700)]
Remove ADID and ADIndex from CoreCLR (#23588)
- Remove concept of AppDomain from object api in VM
- Various infrastructure around entering/leaving appdomains is removed
- Add small implementation of GetAppDomain for use by DAC (to match existing behavior)
- Simplify finalizer thread operations
- Eliminate AppDomain::Terminate
- Remove use of ADID from stresslog
- Remove thread enter/leave tracking from AppDomain
- Remove unused asm constants across all architectures
- Re-order header inclusion order to put gcenv.h before handletable
- Remove retail only sync block code involving appdomain index
vitek-karas [Tue, 2 Apr 2019 14:55:35 +0000 (07:55 -0700)]
Avoid global alloc
vitek-karas [Tue, 2 Apr 2019 13:28:09 +0000 (06:28 -0700)]
Implement checking for simple assembly names in startuphook.
Also wrap load exceptions.
Vitek Karas [Thu, 28 Mar 2019 12:12:47 +0000 (05:12 -0700)]
Add support for specifying only assembly name for startup hook.
Carol Eidt [Wed, 3 Apr 2019 21:33:58 +0000 (14:33 -0700)]
Fix Arm64 intrinsic lookup (#23673)
Fix #23669
Andy Ayers [Wed, 3 Apr 2019 21:22:07 +0000 (14:22 -0700)]
Fix interop test cases to pass doubles for native varargs. (#23690)
Remove these tests from the windows exclude list. Also move one
other exclude entry from its own section into the general exclude list.
Closes #22974
Jeremy Koritzinsky [Wed, 3 Apr 2019 21:08:06 +0000 (14:08 -0700)]
Change Auto charset to mean UTF-8 off-Windows (#23664)
Match Mono's behavior by changing the Auto character set to mean UTF-8 on non-Windows platforms (new behavior) and UCS-2/UTF-16 on Windows (current behavior).
Fixes #23464
Fixes dotnet/corefx#32442
Impact of breaking change: It is highly unlikely that anyone is actively using current behavior since it is inconsistent with Mono and doesn't match any native system APIs on non-Windows platforms (they're all UTF-8 based).
We will need to update our documentation to reflect this updated behavior.
Bruce Forstall [Wed, 3 Apr 2019 20:06:18 +0000 (13:06 -0700)]
Merge pull request #23671 from BruceForstall/ImproveJitFunctionTraceOutput
Improve COMPlus_JitFunctionTrace
Jan Vorlicek [Wed, 3 Apr 2019 18:02:18 +0000 (20:02 +0200)]
Fix flipped error codes
Jan Vorlicek [Tue, 2 Apr 2019 21:35:09 +0000 (23:35 +0200)]
Use the GCHeapAffinitizeRanges / GCHeapAffinitizeMask exclusively
The GCHeapAffinitizeRanges are now used only when CPU groups are enabled
and the GCHeapAffinitizeMask when CPU groups are disabled.
Jan Vorlicek [Fri, 29 Mar 2019 11:46:55 +0000 (12:46 +0100)]
Reflect PR feedback
Jan Vorlicek [Mon, 25 Mar 2019 19:52:07 +0000 (20:52 +0100)]
Remove CPU groups handling from the gc.cpp
This change removes all explicit manipulation and handling of CPU groups
from the gc.cpp and hides it behind the GCToOSInterface. This is a step
to prepare for removing the CPU groups emulation on Unix. In fact, I've
already updated the standalone Unix GC to be able to affinitize GC
threads to any subset of CPUs and added previously missing support for
the affinity setting itself. The NUMA support still remains missing there.
It also adds a new way to specify GC thread affinitization that is not
limited to 64 threads. Instead of affinity mask stored in 64 bit
integer, we now use a bitset that can contain as many processors as
GC can support. And there is a new GC config to specify the affinity in
a form of a range list.
Egor Chesakov [Wed, 3 Apr 2019 19:09:09 +0000 (12:09 -0700)]
Fix typo in zapimage.cpp (#23698)
Jan Vorlicek [Wed, 3 Apr 2019 18:13:39 +0000 (20:13 +0200)]
Merge pull request #23553 from janvorli/fix-accidental-non-collectible-alc-unloading
Fix accidental non-collectible context unloading
Bruce Forstall [Wed, 3 Apr 2019 17:02:27 +0000 (10:02 -0700)]
Merge pull request #23670 from BruceForstall/FixArmAltjitAsmDiffs
Fix arm altjit asm diffs
Brian Robbins [Wed, 3 Apr 2019 15:48:26 +0000 (08:48 -0700)]
Emit event for calls to ReadyToRunInfo::GetEntryPoint. (#23662)
dotnet-maestro[bot] [Wed, 3 Apr 2019 15:32:08 +0000 (08:32 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190402.14 (#23688)
- Microsoft.NETCore.App - 3.0.0-preview4-27602-14
dotnet-maestro-bot [Wed, 3 Apr 2019 15:31:52 +0000 (08:31 -0700)]
Update CoreClr to preview4-27603-71 (#23679)
dotnet-maestro[bot] [Wed, 3 Apr 2019 14:06:02 +0000 (10:06 -0400)]
Update dependencies from https://github.com/dotnet/arcade build
20190402.13 (#23686)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19202.13
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19202.13
Koundinya Veluri [Wed, 3 Apr 2019 13:51:43 +0000 (06:51 -0700)]
[Preview 4] Disable tier 0 JIT (quick JIT) by default, rename config option (#23599)
Disable tier 0 JIT (quick JIT) by default, rename config option
- Tier 0 JIT is being called quick JIT in config options, renamed DisableTier0Jit to StartupTierQuickJit
- Disabled quick JIT by default, the current plan is to do that for preview 4
- Concerns were that code produced by quick JIT may be slow, may allocate more, may use more stack space, and may be much larger than optimized code, and there there may be many cases where these things lead to regressions when the span of time between startup and steady-state is important
- The thought was that with quick JIT disabled, tiering overhead from call counting and backgorund jitting with optimizations would be less, and perf during any point in time would be closer to 2.x releases
- This mostly loses the startup perf gains from tiering. It may also be slightly slower compared with tiering off due to some overhead. When quick JIT is disabled for the startup tier, made a change to disable tiered compilation for methods in modules that are not R2R'ed since they will not be tiered currently anyway. The overhead and regression in R2R'ed modules will be looked into separately to see if it can be reduced.
Fixes https://github.com/dotnet/coreclr/issues/22998
Fixes https://github.com/dotnet/coreclr/issues/19751
Jeremy Koritzinsky [Wed, 3 Apr 2019 11:21:16 +0000 (04:21 -0700)]
Treat WinMDs as having been loaded in the default ALC for AssemblyLoadContext.GetLoadContext (#23678)
Jan Kotas [Tue, 2 Apr 2019 21:41:49 +0000 (14:41 -0700)]
Avoid unnecessary SetLastError on PInvokes (dotnet/corefx#36544)
These console PInvokes are used in nearly every app. Omitting unnecessary SetLastError
will save us from generating marshalling stub for them.
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Brian Sullivan [Wed, 3 Apr 2019 00:57:00 +0000 (17:57 -0700)]
Merge pull request #23668 from briansull/pipeline-work
Remove a few Check builds and Check tests for PullRequests
Tanner Gooding [Wed, 3 Apr 2019 00:06:27 +0000 (17:06 -0700)]
Updating the HWIntrinsic x86 codegen to handle indir nodes. (#23629)
* Updating the SimpleBinOpTest.template to cover some additional containment scenarios
* Regenerating the x86 HWIntrinsic tests from their templates
* Updating the HWIntrinsic x86 codegen to handle indir nodes.
Egor Chesakov [Tue, 2 Apr 2019 23:57:20 +0000 (16:57 -0700)]
Disable *.Arm32.Open in PullRequest and remove two queues from scheduled builds (#23677)
Jeremy Koritzinsky [Tue, 2 Apr 2019 23:39:11 +0000 (16:39 -0700)]
Change tests to not modify Core_Root (#23470)
Redesign tests that needed to modify Core_Root to no longer do so.
- Loader.FromNativePaths: Use `CORE_LIBRARIES` instead of `COREROOT`
- Loader.AssemblyDependencyResolver: Split out the invalid hosting test that needs hostpolicy to not be preloaded. Have `CoreRun` and `CoreShim` preload hostpolicy when a path to a hostpolicy is specified in the `MOCK_HOSTPOLICY` environment variable.
- Add a `CLRTest.MockHosting.targets` file that is imported when a test requires hostpolicy. It adds the reference to the mock hostpolicy and ensures that the `MOCK_HOSTPOLICY` environment variable is correctly set in the test scripts.
Fixes #23429.
Carol Eidt [Tue, 2 Apr 2019 22:54:26 +0000 (15:54 -0700)]
Fix spill check for struct lclVars (#23570)
* Fix spill check for struct lclVars
With the 1st class struct changes, the `SPILL_APPEND` check for the case of an assignment to a lclVar needs to handle block ops as well as lclVar lhs.
Fix #23545
Bruce Forstall [Tue, 2 Apr 2019 22:27:29 +0000 (15:27 -0700)]
Improve COMPlus_JitFunctionTrace
Indicated if the generated function was generated by altjit.
This helps when there is code generated by both altjit and non-altjit.
Bruce Forstall [Tue, 2 Apr 2019 22:22:17 +0000 (15:22 -0700)]
Fix arm altjit asm diffs
At shutdown, the VM iterates over generated code as part of ETW
"rundown". This currently includes altjit generated code. It calls
functions which interprets the code as native code, e.g., arm32
GC info as x86 GC info.
The fix is to make a call to BackoutJitData(), which was already
suggested in the comments. This removes the altjit generated code
from the "nibble map", and hence from the iteration.
Fixes #23393
Jan Vorlicek [Tue, 2 Apr 2019 22:08:58 +0000 (00:08 +0200)]
Merge pull request #23521 from k15tfu/fix-issue-20784
Move C/C++ and platform headers to pal/inc/rt/cpp folder
dotnet-maestro[bot] [Tue, 2 Apr 2019 21:49:27 +0000 (14:49 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20190401.12 (#23652)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19201.12
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19201.12
Brian Sullivan [Tue, 2 Apr 2019 21:46:27 +0000 (14:46 -0700)]
Reduce Check build and Check tests for PullRequest to
- Linux_arm
- Linux_arm64
- Linux_musl_x64
- Linux_x64
- OSX_x64
- Windows_NT_arm
- Windows_NT_arm64
- Windows_NT_x64
- Windows_NT_x86
Brian Sullivan [Tue, 2 Apr 2019 21:05:16 +0000 (14:05 -0700)]
Merge pull request #23565 from briansull/pipeline-work
Move to outerloop - several azure-pipeline jobs
William Godbe [Tue, 2 Apr 2019 18:22:19 +0000 (11:22 -0700)]
Merge pull request #23601 from dotnet-maestro-bot/master-UpdateDependencies
Update CoreClr to preview4-27602-71 (master)
Fadi Hanna [Tue, 2 Apr 2019 17:41:49 +0000 (10:41 -0700)]
Output error messages to stderr. This provides a better integration with the .NET SDK (#23658)
dotnet-maestro[bot] [Tue, 2 Apr 2019 16:18:24 +0000 (12:18 -0400)]
Update dependencies from https://github.com/dotnet/corefx build
20190401.9 (#23653)
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19201.9
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19201.9
Andy Ayers [Tue, 2 Apr 2019 16:06:32 +0000 (09:06 -0700)]
JIT: prolog zeroing accounting changes (#23498)
Stop double-counting some locals when computing how many slots need to be
zeroed in the prolog.
Bump threshold for rep stosb style init from 16 bytes to 32 bytes on x64.
José Rivero [Tue, 2 Apr 2019 14:06:42 +0000 (07:06 -0700)]
[EventPipe] Streaming events out-of-proc using IPC (#23448)
- There was a race condition on EventPipe::Disable where we deallocated the s_pSession and set it to NULL, but there was still a thread waiting to write and dereference the null pointer. Now, we check that the session is not null.
- Added a new attach event to be handled to the Diagnostic server: Add streaming functionality (Syncronus) #23299
- On Linux, IPC was failing when delete was invoked because we were using new (std::nothrow) instead of new (nothrow) when allocating the newly connected clients/streams. I have replaced the call with new. This fixed #23580
- Move multiFileTraceLengthInSeconds out of the EventPipeSession.
- Unlink previously existing socket.
- EventPipeBlock: _ASSERTE was updated not to fail when data is not aligned if an error has already occurred.
- Update _ASSERTE in fastserializer.cpp to take into account the the write operation could have failed.
dotnet-maestro-bot [Tue, 2 Apr 2019 13:19:22 +0000 (06:19 -0700)]
Update CoreClr to preview4-27602-71
Michal Strehovský [Tue, 2 Apr 2019 12:48:47 +0000 (14:48 +0200)]
Remove test exclusion for 23262 (#23405)
The commit that added the test was rolled back.
Ilia K [Thu, 28 Mar 2019 17:28:47 +0000 (20:28 +0300)]
Move C/C++ and platform headers to pal/inc/rt/cpp folder
Affected files: assert.h, emmintrin.h, and xmmintrin.h
Bug: 20784
Krzysztof Wicher [Tue, 2 Apr 2019 00:43:06 +0000 (17:43 -0700)]
PermissionSet: follow netfx more in order to avoid workarounds with nullable (#23637)
Egor Chesakov [Tue, 2 Apr 2019 00:37:53 +0000 (17:37 -0700)]
Use join function in yaml for defining Helix queues and scenarios (#23367)
* Enable Ubuntu.1804.Arm32.Open (running on Ubuntu.1604.Arm32.Open) against PRs
* Restrict Ubuntu.1404.Arm32.Open to running against CI (commit validation) only
* Enable Debian.9.Arm32.Open, Ubuntu.1604.Arm32.Open and Ubuntu.1804.Arm32.Open (running on Ubuntu.1604.Arm32.Open) against scheduled runs
* Enable Debian.9.Arm32, Ubuntu.1604.Arm32 and Ubuntu.1804.Arm32 (running on Ubuntu.1604.Arm32) in internal project (FYI, we haven't had any Linux arm32 testing in internal so far)
* Enable Debian.9.Arm64.Open (running on Ubuntu.1604.Arm64.Docker.Open) against scheduled runs
* Enable Alpine.38.Arm64 (running on Ubuntu.1604.Arm64.Docker) in internal project
Krzysztof Wicher [Mon, 1 Apr 2019 23:23:52 +0000 (16:23 -0700)]
Change PermissionSet.SyncRoot to return this instead of null (#23631)
Jan Kotas [Mon, 1 Apr 2019 23:20:55 +0000 (16:20 -0700)]
Match BOX idioms early in the importer (#23550)
Brian Sullivan [Mon, 1 Apr 2019 23:03:50 +0000 (16:03 -0700)]
revert comment change:
# Checked test builds
Steve MacLean [Mon, 1 Apr 2019 22:09:41 +0000 (18:09 -0400)]
Disable load byte array (#23638)
* Disable AssemblyLoadByteArrayName test
* Fix typo
Steve MacLean [Mon, 1 Apr 2019 21:52:51 +0000 (17:52 -0400)]
Disable AssemblyLoadByteArrayName test (#23635)
Levi Broderick [Mon, 1 Apr 2019 21:25:55 +0000 (14:25 -0700)]
Fix bad Debug.Assert statements in UTF-8 processing (#23627)
Jan Vorlicek [Mon, 1 Apr 2019 21:12:04 +0000 (23:12 +0200)]
Remove s_isProcessExiting and Clear of ALC list at exit
Carol Eidt [Mon, 1 Apr 2019 20:33:12 +0000 (13:33 -0700)]
LSRA cleanup (#23617)
* LSRA cleanup
These are zero-diff changes. Some cleanup, some in preparation for improvemetns to save/restore of upper vectors.
Acid Chicken (硫酸鶏) [Mon, 1 Apr 2019 19:53:10 +0000 (04:53 +0900)]
Add new era in Japan called "Reiwa" (#23614)
* Add new era in Japan called "Reiwa"
* Update Japanese eras English names
refs: <https://github.com/dotnet/coreclr/pull/23614#issuecomment-
478680005>
dotnet-maestro[bot] [Mon, 1 Apr 2019 19:32:01 +0000 (12:32 -0700)]
[master] Update dependencies from dotnet/corefx (#23593)
- Microsoft.NETCore.Platforms - 3.0.0-preview4.19181.2
- Microsoft.Private.CoreFx.NETCoreApp - 4.6.0-preview4.19181.2
Fadi Hanna [Mon, 1 Apr 2019 19:07:47 +0000 (12:07 -0700)]
Enable R2R compilation/inlining of PInvoke stubs where no marshalling is required (#22560)
* These changes enable the inlining of some PInvokes that do not require any marshalling. With inlined pinvokes, R2R performance should become slightly better, since we'll avoid jitting some of the pinvoke IL stubs that we jit today for S.P.CoreLib. Performance gains not yet measured.
* Added JIT_PInvokeBegin/End helpers for all architectures. Linux stubs not yet implemented
* Add INLINE_GETTHREAD for arm/arm64
* Set CORJIT_FLAG_USE_PINVOKE_HELPERS jit flag for ReadyToRun compilations
* Updating R2RDump tool to handle pinvokes
Brian Sullivan [Mon, 1 Apr 2019 17:33:46 +0000 (10:33 -0700)]
Merge branch 'master' into pipeline-work
Jan Kotas [Mon, 1 Apr 2019 15:37:03 +0000 (08:37 -0700)]
Enable negative type-check results in CoreLib version bubble (#23549)
This negative type-check results are necessary to generate good code for AsyncTaskMethodBuilder.AwaitUnsafeOnCompleted
Jan Vorlicek [Mon, 1 Apr 2019 10:07:35 +0000 (12:07 +0200)]
Deliver Unload event at exit for all ALCs
Sending it just for collectible ALCs is not correct at process exit.
Carol Eidt [Mon, 1 Apr 2019 00:02:38 +0000 (17:02 -0700)]
re-add test exclusion for #23545 (#23598)
Jan Kotas [Sat, 30 Mar 2019 15:03:14 +0000 (08:03 -0700)]
Update dependencies from https://github.com/dotnet/core-setup build
20190329.11 (#23594)
- Microsoft.NETCore.App - 3.0.0-preview4-27529-11
dotnet-maestro[bot] [Sat, 30 Mar 2019 15:02:49 +0000 (08:02 -0700)]
Update dependencies from https://github.com/dotnet/arcade build
20190329.2 (#23592)
- Microsoft.DotNet.Arcade.Sdk - 1.0.0-beta.19179.2
- Microsoft.DotNet.Helix.Sdk - 2.0.0-beta.19179.2
Fei Peng [Sat, 30 Mar 2019 14:43:38 +0000 (07:43 -0700)]
Fix ARM64 isFullyImplementedIsa (#23590)
dotnet-maestro [Sat, 30 Mar 2019 12:57:35 +0000 (12:57 +0000)]
Update dependencies from https://github.com/dotnet/core-setup build
20190329.11
- Microsoft.NETCore.App - 3.0.0-preview4-27529-11
Ganbarukamo41 [Sat, 30 Mar 2019 02:10:00 +0000 (02:10 +0000)]
Implement IEquatable to Memory and ReadOnlyMemory (#23586)
Steve MacLean [Sat, 30 Mar 2019 01:51:39 +0000 (21:51 -0400)]
Clean up AssemblyLoadContext30Extensions test (#23581)
Build test against corefx ref facade
Enable Assembly.Load(byte[], ...) test
Sergey Andreenko [Sat, 30 Mar 2019 00:18:44 +0000 (17:18 -0700)]
Merge pull request #23579 from sandreenko/removeFedoraRuns
Remove Fedora runs.
Sergey Andreenko [Fri, 29 Mar 2019 23:45:31 +0000 (16:45 -0700)]
Increase GCStress test timeouts. (#23576)
New machines are slower that we had before, so increate the timeout for the longest runs.
Sergey Andreenko [Fri, 29 Mar 2019 23:45:06 +0000 (16:45 -0700)]
Make tracelogging GCStressIncompatible. (#23578)
Brian Bohe [Fri, 29 Mar 2019 23:38:53 +0000 (16:38 -0700)]
A new way of tracking variables (#23373)
* Defining VariableLiveRange class
* Adding some typedefs to avoid rewriting
* Defining VariableLiveDescriptor class
* Initializing VariableLiveRange structures before BasicBlock code is being generated
* Getting a siVarLoc for variable homes from a given LclVarDsc and stack level
* Defining VariableLiveKeeper class
* Reporting VariableLiveRanges on changes of variable livenesss or variable homes
* Adding USING_VARIABLE_LIVE_RANGE flag to enable disable VariableLiveRange
* Send VariableLiveRanges to debugger
* Reporting variable homes on prolog
* Wrong argument
* Miss to change variable homes count before sending them to debugger
* Adding dumper of VariableLiveRanges for each blocks and end of code generation
* Close all open VaribleLiveRanges on last BasicBlock
* Changing order of properties initialization on VariableLiveRange constructor
* Type error on assignation
* Rephrasing comments, moving dumps and fixing typos
* Changing const VARSET_TP* for VARSET_VALARG_TP on args
* Variable home was variable location in VariableLiveRange context
* Rephrase and rename of VariableLiveKeeper properties
* Missing some renames
* Adding const where BasicBlock should not be modified
* siBeginBlock and siInit have support for debug code for VariableLiveRange and siScope info
* Adding USING_VARIABLE_LIVE_RANGE flags on methods definition.
* Variable home -> variable location
* Renaming and rephrasing names and uses of VariableLiveRange
* Moving LiveRangeDumper ctor to class declation
* Removing destructors
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Removing blank spaces and reordering functions inside class definition
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Miss to increment the index after refactoring
* Logic for keeping the last BasicBlock end IL offset is shared between siScope and VariableLiverange for debug code
* Missing to print on debug the last block VariableLiveRanges
* Avoid updating VariableLiveRange when unspilling and dying at the same assembly instruction
* Rephrasing #ifs and #ifdefs
* Calling VariableLiveKeeper in one line
* Avoid copying siVarLoc on genSetScopeInfo
* Removing unused args from eeSetLVinfo
* Changing VariableLiveKeeper ctor
* Typo
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Updating VariableLiveDescriptor ctor
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Error on first argument
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Changing reference for pointer
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Renaming assembly offset -> native offset
* removing unnecesary comments and asserts
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Update VariableLiveRange dump message
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Moving VariableLiveRanges classes inside VariableLiveKeeper
* Wrong flag name
* Adding documentation about how we track variables for debug info
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Adding opened issues to doc file
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Changing dump tittle
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Renaming VariableLiveKeeper property
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Update documentation
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Updating comments on flags
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
* Setting Scope Info as default way of tracking variables for debug info
Signed-off-by: Brian Bohe <brianbohe@gmail.com>
Carol Eidt [Fri, 29 Mar 2019 23:35:09 +0000 (16:35 -0700)]
Fix HW intrinsic containment bugs (#23558)
* Fix HW intrinsic containment bugs
For the Fma case (#23430), fix the handling of contained 3-operand HW intrinsic nodes.
For the Bmi case (#23534), fix a bad assert placement, and re-enable the Bmi tests.
Fix #23530
Fix #23534
* Add guard for Fma test
Steve MacLean [Fri, 29 Mar 2019 23:33:37 +0000 (19:33 -0400)]
Assembly.Load ALC name (#23574)
Use normalized path for ALC name
Sergey Andreenko [Fri, 29 Mar 2019 23:28:19 +0000 (16:28 -0700)]
Remove Fedora runs.
GCStress fails there because it can't use external disasembler when it is available in CoreRoot.
Brian Sullivan [Fri, 29 Mar 2019 23:14:20 +0000 (16:14 -0700)]
Merge pull request #23533 from briansull/Issue_23441
Fix for issue 23411
Sergey Andreenko [Fri, 29 Mar 2019 22:31:28 +0000 (15:31 -0700)]
Increase GCStress test timeouts.
New machines are slower that we had before, so increate the timeout for the longest runs.
Brian Sullivan [Fri, 29 Mar 2019 22:20:13 +0000 (15:20 -0700)]
Rework Debug/Release builds
Revert Check build changes
Sergey Andreenko [Fri, 29 Mar 2019 22:17:37 +0000 (15:17 -0700)]
Use GenTreeStmt* where it is implied. (#22963)
* Extract `impAppendStmt` and `impExtractLastStmt`.
* Delete `BEG_STMTS` fake stmt.
Use new functions to keep the list updated.
* Retype `impTreeList` and `impTreeLast` as statements.
Rename `impTreeList` and `impTreeLast` to show that they are statements.
* Fix fields that have to be stmt.
* Start using GenTreeStmt.
Change `optVNAssertionPropCurStmt` to use GenTreeStmt.
Replace `GenTree* stmt = block->bbTreeList` with `GenTreeStmt* stmt = block->firstStmt()`.
Save results of `FirstNonPhiDef` as `GenTreeStmt`.
* Replace do-while with for loop.
* Change type inside VNAssertionPropVisitorInfo.
* Delete unused args fron `optVNConstantPropOnTree`.
* Update fields to be stmt.
Update optVNConstantPropCurStmt to use Stmt.
Change `lvDefStmt` to stmt.
Update LoopCloning structs.
Update `optDebugLogLoopCloning`.
Make `compCurStmt` a statement.
Update declaration name in `BuildNode`.
* Clean simple cpp files.
Clean valuenum.
Clean ssabuilder.
Clean simd.
Clean optcse.
Clean loopcloning.
Clean copyprop.
Clean optimizer part1.
* Start cleaning importer, morph, flowgraph, gentree.
* Continue clean functons.
Clean assertionprop.
Clean morph.
Clean gentree.
Clean flowgraph.
Clean compiler.
Clean rangecheck.
Clean indirectcalltransofrmer.
Clean others.
* Create some temp stmt.
* Delete unnecessary noway_assert and casts.
* Init `impStmtList` and `impLastStmt` in release.
* Response review 1.
Fei Peng [Fri, 29 Mar 2019 21:28:30 +0000 (14:28 -0700)]
Simplify and unify Vector64/128/256 platform-agnostic intrinsic handling (#23028)
* Simplify and unify Vector64/128/256 platform-agnostic intrinsic handling
* Removed unsupported ISAs
Brian Sullivan [Fri, 29 Mar 2019 21:13:00 +0000 (14:13 -0700)]
Rework the if statements