Armin Novak [Wed, 1 Feb 2017 10:00:24 +0000 (11:00 +0100)]
Fixed GDI color decoding issues.
akallabeth [Tue, 31 Jan 2017 08:54:50 +0000 (09:54 +0100)]
Merge pull request #3729 from chipitsine/master
remove redundant assignment
Ilya Shipitsin [Mon, 30 Jan 2017 10:09:36 +0000 (15:09 +0500)]
remove redundant assignment
[client/Windows/wf_cliprdr.c:575]: (warning) Redundant assignment of 'clipboard' to itself.
Martin Fleisz [Mon, 30 Jan 2017 09:08:48 +0000 (10:08 +0100)]
Merge pull request #3728 from chipitsine/master
removed redundant condition
Ilya Shipitsin [Sat, 28 Jan 2017 07:36:08 +0000 (12:36 +0500)]
removed redundant condition:
[winpr/libwinpr/synch/semaphore.c:131] -> [winpr/libwinpr/synch/semaphore.c:136]: (warning) Either the condition 'if(semaphore)' is redundant or there is possible null pointer dereference: semaphore.
[winpr/libwinpr/synch/semaphore.c:132] -> [winpr/libwinpr/synch/semaphore.c:136]: (warning) Either the condition 'if(semaphore)' is redundant or there is possible null pointer dereference: semaphore.
[winpr/libwinpr/synch/semaphore.c:133] -> [winpr/libwinpr/synch/semaphore.c:136]: (warning) Either the condition 'if(semaphore)' is redundant or there is possible null pointer dereference: semaphore.
[winpr/libwinpr/synch/semaphore.c:134] -> [winpr/libwinpr/synch/semaphore.c:136]: (warning) Either the condition 'if(semaphore)' is redundant or there is possible null pointer dereference: semaphore.
akallabeth [Fri, 27 Jan 2017 17:49:35 +0000 (18:49 +0100)]
Merge pull request #3725 from chipitsine/master
make cppcheck even more happier
Martin Fleisz [Fri, 27 Jan 2017 10:42:50 +0000 (11:42 +0100)]
Merge pull request #3726 from hardening/add_const
Added missing const modifiers for source pointers in codecs
David Fort [Fri, 27 Jan 2017 10:23:08 +0000 (11:23 +0100)]
Added missing const modifiers for source pointers in codecs
Martin Fleisz [Thu, 26 Jan 2017 10:10:17 +0000 (11:10 +0100)]
Merge pull request #3715 from akallabeth/reproducible_build
Reproducible build
Martin Fleisz [Thu, 26 Jan 2017 10:09:16 +0000 (11:09 +0100)]
Merge pull request #3722 from akallabeth/ccache_support
Added CCACHE detection and option to disable.
Ilya Shipitsin [Thu, 26 Jan 2017 09:44:19 +0000 (14:44 +0500)]
make cppcheck even more happier:
[channels/tsmf/client/gstreamer/tsmf_X11.c:317] -> [channels/tsmf/client/gstreamer/tsmf_X11.c:322]: (warning) Either the condition '!decoder' is redundant or there is possible null pointer dereference: decoder.
[channels/tsmf/client/gstreamer/tsmf_X11.c:470] -> [channels/tsmf/client/gstreamer/tsmf_X11.c:475]: (warning) Either the condition '!decoder' is redundant or there is possible null pointer dereference: decoder.
[channels/tsmf/client/gstreamer/tsmf_X11.c:472] -> [channels/tsmf/client/gstreamer/tsmf_X11.c:475]: (warning) Either the condition '!decoder' is redundant or there is possible null pointer dereference: decoder.
[channels/tsmf/client/tsmf_media.c:179] -> [channels/tsmf/client/tsmf_media.c:181]: (warning) Either the condition '!stream' is redundant or there is possible null pointer dereference: stream.
[client/Windows/wf_cliprdr.c:2219] -> [client/Windows/wf_cliprdr.c:2222]: (warning) Either the condition '!formatDataResponse' is redundant or there is possible null pointer dereference: formatDataResponse
[client/Windows/wf_cliprdr.c:2445] -> [client/Windows/wf_cliprdr.c:2448]: (warning) Either the condition '!fileContentsResponse' is redundant or there is possible null pointer dereference: fileContentsResponse.
[client/X11/xf_cliprdr.c:911] -> [client/X11/xf_cliprdr.c:913]: (warning) Either the condition '!clipboard' is redundant or there is possible null pointer dereference: clipboard.
[client/X11/xf_graphics.c:504] -> [client/X11/xf_graphics.c:506]: (warning) Either the condition '!xfc' is redundant or there is possible null pointer dereference: xfc.
[libfreerdp/core/transport.c:861] -> [libfreerdp/core/transport.c:863]: (warning) Either the condition '!transport' is redundant or there is possible null pointer dereference: transport.
[server/shadow/shadow_server.c:777] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
[server/shadow/shadow_server.c:778] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
[server/shadow/shadow_server.c:779] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
[server/shadow/shadow_server.c:781] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
[server/shadow/shadow_server.c:782] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
[server/shadow/shadow_server.c:783] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
[server/shadow/shadow_server.c:784] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
[server/shadow/shadow_server.c:785] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
[server/shadow/shadow_server.c:787] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
[server/shadow/shadow_server.c:789] -> [server/shadow/shadow_server.c:791]: (warning) Either the condition '!server' is redundant or there is possible null pointer dereference: server.
Armin Novak [Wed, 25 Jan 2017 15:00:29 +0000 (16:00 +0100)]
Added CCACHE support for android OpenH264 build.
akallabeth [Wed, 25 Jan 2017 14:36:02 +0000 (15:36 +0100)]
Merge pull request #3724 from chipitsine/master
make cppcheck a bit happier
Armin Novak [Wed, 25 Jan 2017 14:19:31 +0000 (15:19 +0100)]
Added CCACHE support for OpenSSL builds.
Ilya Shipitsin [Wed, 25 Jan 2017 12:09:25 +0000 (17:09 +0500)]
make cppcheck a bit happier:
[channels/printer/client/printer_cups.c:103]: (error) Resource leak: fp
[server/Mac/mf_event.c:195]: (error) Memory leak: event_queue
[server/shadow/shadow_capture.c:233]: (error) Memory leak: capture
[winpr/libwinpr/sspi/test/TestSchannel.c:440]: (error) Memory leak: lpTokenIn
[winpr/libwinpr/thread/argv.c:198]: (error) Memory leak: lpEscapedChars
[winpr/libwinpr/utils/sam.c:312]: (error) Memory leak: entry
akallabeth [Wed, 25 Jan 2017 11:51:04 +0000 (12:51 +0100)]
Merge pull request #3723 from chipitsine/master
trivial issue found by cppcheck:
Ilya Shipitsin [Wed, 25 Jan 2017 10:48:49 +0000 (15:48 +0500)]
trivial issue found by cppcheck:
[uwac/libuwac/uwac-display.c:73]: (error) va_list 'args' was opened but not closed by va_end().
Martin Fleisz [Wed, 25 Jan 2017 08:27:08 +0000 (09:27 +0100)]
Merge pull request #3721 from akallabeth/x11_color_fix
X11 color conversion fix
Armin Novak [Wed, 25 Jan 2017 08:05:27 +0000 (09:05 +0100)]
Added CCACHE detection and option to disable.
Armin Novak [Wed, 25 Jan 2017 07:33:36 +0000 (08:33 +0100)]
Fixed conversion to XColor.
Armin Novak [Wed, 25 Jan 2017 07:33:04 +0000 (08:33 +0100)]
Fixed stride for XCreateImage.
Armin Novak [Mon, 23 Jan 2017 10:25:29 +0000 (11:25 +0100)]
Use CMake TIMESTAMP, remove newline from TODAY
akallabeth [Mon, 23 Jan 2017 16:00:07 +0000 (17:00 +0100)]
Merge pull request #3718 from bmiklautz/fix/nightly-pkgs
Fix nightly packages
Bernhard Miklautz [Mon, 23 Jan 2017 15:43:00 +0000 (16:43 +0100)]
Fix nightly packages
Man pages weren't installed or wrong path was used.
Bernhard Miklautz [Mon, 23 Jan 2017 14:47:39 +0000 (15:47 +0100)]
Merge pull request #3708 from akallabeth/termination_fixes
Client channel shutdown fixes
Armin Novak [Mon, 23 Jan 2017 13:18:19 +0000 (14:18 +0100)]
Fixed channel connected status.
Bernhard Miklautz [Mon, 23 Jan 2017 12:49:25 +0000 (13:49 +0100)]
Merge pull request #3664 from realjiangms/fix_gfx_ack
Server/shadow: Fix handling for gfx acknowledge according to spec
Bernhard Miklautz [Mon, 23 Jan 2017 12:44:18 +0000 (13:44 +0100)]
Merge pull request #3716 from akallabeth/planar_warning_fix
Fixed uninitialized variable warning.
Armin Novak [Mon, 23 Jan 2017 12:27:30 +0000 (13:27 +0100)]
Fixed uninitialized variable warning.
Martin Fleisz [Mon, 23 Jan 2017 10:59:52 +0000 (11:59 +0100)]
Merge pull request #3710 from akallabeth/local_16bpp_fixes
Local 16bpp fixes
Armin Novak [Mon, 23 Jan 2017 08:26:56 +0000 (09:26 +0100)]
Fixed alpha channel for color formats without.
Armin Novak [Thu, 19 Jan 2017 16:16:25 +0000 (17:16 +0100)]
Fixed staging surface scanline.
Armin Novak [Thu, 19 Jan 2017 16:14:16 +0000 (17:14 +0100)]
Fixed color format selection for 16bpp
Armin Novak [Thu, 19 Jan 2017 16:13:07 +0000 (17:13 +0100)]
Fixed planar with if local framebuffer is 16bpp
Armin Novak [Thu, 19 Jan 2017 15:40:58 +0000 (16:40 +0100)]
Fixed scanline for RFX.
Bernhard Miklautz [Mon, 23 Jan 2017 09:39:02 +0000 (10:39 +0100)]
Merge pull request #3703 from akallabeth/prim_optimize
[PERFORMANCE] Inlined heavily used functions
Bernhard Miklautz [Mon, 23 Jan 2017 09:02:14 +0000 (10:02 +0100)]
Merge pull request #3711 from hardening/monitor_layout
Misc fixes and improvements
Bernhard M. Wiedemann [Sun, 22 Jan 2017 16:54:24 +0000 (16:54 +0000)]
make build reproducible
by allowing build systems to use a constant date instead of the current one
see https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable
This call is designed to work with GNU date. If BSD support is a concern, it can be added.
David Fort [Thu, 19 Jan 2017 16:59:54 +0000 (17:59 +0100)]
Add a callback that allows to adjust monitors layout
This callback is useful in server mode when you want to adjust the monitor
layout just before the server monitor layout PDU is built and sent.
David Fort [Thu, 19 Jan 2017 16:57:44 +0000 (17:57 +0100)]
Treat the result of the Capabilities callback
The result was ignored. Plus return the correct value in case of licence error (-1
instead of FALSE).
Bernhard Miklautz [Thu, 19 Jan 2017 11:05:26 +0000 (12:05 +0100)]
Merge pull request #3705 from akallabeth/android_openssl_1_1
Android openssl 1 1
Armin Novak [Wed, 18 Jan 2017 15:52:52 +0000 (16:52 +0100)]
Disabled OpenH264 in default android build.
Armin Novak [Wed, 18 Jan 2017 15:41:02 +0000 (16:41 +0100)]
Progressive structs to private header for tests.
Armin Novak [Wed, 18 Jan 2017 15:16:29 +0000 (16:16 +0100)]
Progressive struct now opaque.
Armin Novak [Wed, 18 Jan 2017 14:41:50 +0000 (15:41 +0100)]
Fixed missing return.
Armin Novak [Wed, 18 Jan 2017 14:25:24 +0000 (15:25 +0100)]
Progressive conversion and speed fixes
* Using destination color format and precomputed tile stride
* Using preallocated logger
Armin Novak [Mon, 16 Jan 2017 11:40:39 +0000 (12:40 +0100)]
Removed obsolete primitive usage.
Armin Novak [Mon, 16 Jan 2017 11:40:25 +0000 (12:40 +0100)]
Optimized functions, removed duplicates.
Armin Novak [Mon, 16 Jan 2017 11:39:34 +0000 (12:39 +0100)]
Inlined shift operations.
Armin Novak [Mon, 16 Jan 2017 10:45:53 +0000 (11:45 +0100)]
Inlined freerdp_image_copy helpers.
Armin Novak [Mon, 16 Jan 2017 10:39:55 +0000 (11:39 +0100)]
Inlined interleaved helper functions.
Armin Novak [Mon, 16 Jan 2017 10:36:35 +0000 (11:36 +0100)]
Optimized freerdp_image_fill
Armin Novak [Mon, 16 Jan 2017 09:54:01 +0000 (10:54 +0100)]
Optimized general_YUV444ToRGB_8u_P3AC4R for BGRX
Armin Novak [Mon, 16 Jan 2017 09:25:12 +0000 (10:25 +0100)]
Inlined heavy used functions.
Armin Novak [Mon, 16 Jan 2017 09:13:35 +0000 (10:13 +0100)]
Optimized general_RGBToRGB_16s8u_P3AC4R for BGRX
Armin Novak [Mon, 16 Jan 2017 09:01:51 +0000 (10:01 +0100)]
Optimized general_yCbCrToRGB_16s8u_P3AC4R for BGRX
Armin Novak [Wed, 18 Jan 2017 13:30:06 +0000 (14:30 +0100)]
Fixed broken variable declaration.
Bernhard Miklautz [Wed, 18 Jan 2017 13:28:27 +0000 (14:28 +0100)]
Merge pull request #3702 from akallabeth/clear_reset_fix
ClearCodec fix #3642
Bernhard Miklautz [Wed, 18 Jan 2017 12:45:34 +0000 (13:45 +0100)]
Merge pull request #3707 from akallabeth/AMV007-patch-2
Rebased #2541
Armin Novak [Wed, 18 Jan 2017 11:39:40 +0000 (12:39 +0100)]
Fixed warnings due to API changes.
Martin Fleisz [Tue, 17 Jan 2017 18:14:56 +0000 (19:14 +0100)]
Merge pull request #3704 from bmiklautz/versioning
Library naming and man pages
Armin Novak [Tue, 17 Jan 2017 15:27:56 +0000 (16:27 +0100)]
Return OK in case of channel not connected.
Armin Novak [Tue, 17 Jan 2017 15:02:13 +0000 (16:02 +0100)]
Checks, return value fixes
* Added missing argument checks
* Use opened drdynvc->log where possible
* Fix drdynvc_send return in case channel not connected.
Armin Novak [Tue, 17 Jan 2017 15:00:51 +0000 (16:00 +0100)]
Do not terminate channel disconnect if one fails.
Armin Novak [Tue, 17 Jan 2017 15:00:24 +0000 (16:00 +0100)]
Decreased log verbosity.
Armin Novak [Tue, 17 Jan 2017 14:59:50 +0000 (15:59 +0100)]
Fixed audio termination code.
Bernhard Miklautz [Tue, 17 Jan 2017 12:25:47 +0000 (13:25 +0100)]
Fix typos in man pages.
Armin Novak [Tue, 17 Jan 2017 12:17:25 +0000 (13:17 +0100)]
Fixed SONAME
Armin Novak [Tue, 17 Jan 2017 09:03:05 +0000 (10:03 +0100)]
Merge branch 'patch-2' of https://github.com/AMV007/FreeRDP into AMV007-patch-2
Conflicts:
channels/tsmf/client/tsmf_ifman.c
channels/tsmf/client/tsmf_media.c
Norbert Federa [Mon, 16 Jan 2017 17:18:43 +0000 (18:18 +0100)]
Merge pull request #3669 from xhaakon/master
Limit MultifragMaxRequestSize in server mode
Armin Novak [Mon, 16 Jan 2017 17:08:07 +0000 (18:08 +0100)]
Updated library names after change in #3704
Armin Novak [Mon, 16 Jan 2017 15:40:06 +0000 (16:40 +0100)]
Updated gradle settings.
Armin Novak [Mon, 16 Jan 2017 15:39:06 +0000 (16:39 +0100)]
Renamed OpenSSL library
To avoid collisions with system provided OpenSSL use
a different (unique) library name for android builds.
Armin Novak [Mon, 16 Jan 2017 14:23:11 +0000 (15:23 +0100)]
Added android release build configurations.
Armin Novak [Mon, 16 Jan 2017 13:57:28 +0000 (14:57 +0100)]
Updated android build scripts for OpenSSL 1.1
Bernhard Miklautz [Mon, 16 Jan 2017 10:34:32 +0000 (11:34 +0100)]
Install man pages
* man pages are only build/installed if WITH_MANPAGES is enabled
* create a new cmake function install_freerdp_man to unified install man
pages
* install all man pages using the new function
* update the nightly packages accordingly
Bernhard Miklautz [Mon, 16 Jan 2017 10:09:26 +0000 (11:09 +0100)]
wlfreerdp: add initial man page
Bernhard Miklautz [Mon, 16 Jan 2017 08:25:58 +0000 (09:25 +0100)]
shadow-cli: add initial man page
Bernhard Miklautz [Mon, 16 Jan 2017 07:58:04 +0000 (08:58 +0100)]
shadow server: add more error messages
Bernhard Miklautz [Thu, 12 Jan 2017 15:33:36 +0000 (16:33 +0100)]
cmdline: fix wlog man page reference
It's wlog(7) now.
Bernhard Miklautz [Thu, 12 Jan 2017 15:25:25 +0000 (16:25 +0100)]
winpr-makecert: add initial man page
Bernhard Miklautz [Thu, 12 Jan 2017 14:46:13 +0000 (15:46 +0100)]
makecert: fix a regression with > 2048 bit
When certificates with more than 2048 bits were generated and written to
file the read function used a erroneous calculated length causing the
used buffer to overflow.
Bernhard Miklautz [Thu, 12 Jan 2017 10:04:34 +0000 (11:04 +0100)]
winpr-makecert: use sha256 and update command line
* use sha256 instead of sha1 as default hash algorithm
* fix command line parser
* mark not implemented command line switches as unsupported
Bernhard Miklautz [Wed, 11 Jan 2017 14:28:18 +0000 (15:28 +0100)]
winpr-hash: cleanup cmd line and add man page
* add a initial man page
* clean up the command line a little bit (basically error messages)
Bernhard Miklautz [Wed, 11 Jan 2017 14:24:49 +0000 (15:24 +0100)]
utils: remove unnecessary debug message.
Change the level from info to debug as it's nothing a regular users
would have interest in.
Bernhard Miklautz [Wed, 21 Dec 2016 14:25:03 +0000 (15:25 +0100)]
Include major version number in library names
Currently it is not possible to cleanly install multiple major version
of FreeRDP concurrently as some of the development libraries (.so files)
files can conflict.
This change renames all libraries to include the major version number in
the library name to fix this limitation.
The list of changed libraries:
libwinpr-tools.so -> libwinpr-tools2.so
libwinpr.so -> libwinpr2.so
libfreerdp.so -> libfreerdp2.so
libfreerdp-client.so -> libfreerdp-client2.so
libfreerdp-shadow.so -> libfreerdp-shadow2.so
libfreerdp-server.so -> libfreerdp-server2.so
libfreerdp-shadow-subsystem.so -> libfreerdp-shadow-subsystem2.so
libuwac.so -> libuwac0.so
As the library names have changed, projects that use FreeRDP will need to
update their dependencies. -
If pkg-config or cmake find modules are used, reconfiguration might be
sufficient.
Fixes #3460
Martin Fleisz [Mon, 16 Jan 2017 09:36:28 +0000 (10:36 +0100)]
Merge pull request #3701 from akallabeth/progressive_inlined
[performance] Progressive inlined
Armin Novak [Fri, 13 Jan 2017 10:14:30 +0000 (11:14 +0100)]
Do not reset V-Bar storage.
Norbert Federa [Fri, 13 Jan 2017 08:46:14 +0000 (09:46 +0100)]
Merge pull request #3665 from realjiangms/fix_ssl_add_all_digests
Winpr/openssl: Fix digests initialization in multi-thread
Martin Fleisz [Fri, 13 Jan 2017 08:24:52 +0000 (09:24 +0100)]
Merge pull request #3694 from akallabeth/avc420_black_artifact_fix
Fixed solid fill command.
Martin Fleisz [Thu, 12 Jan 2017 16:27:05 +0000 (17:27 +0100)]
Merge pull request #3688 from akallabeth/clear_codec_buffer_resize_fix
Clear codec buffer resize fix
Martin Fleisz [Thu, 12 Jan 2017 15:04:57 +0000 (16:04 +0100)]
Merge pull request #3696 from akallabeth/gdi_stride_init
Initializing gdi.stride on resize.
Armin Novak [Thu, 12 Jan 2017 14:31:25 +0000 (15:31 +0100)]
Inlined progressive helper functions.
Armin Novak [Thu, 12 Jan 2017 14:30:06 +0000 (15:30 +0100)]
Unified clipping of byte values.
akallabeth [Thu, 12 Jan 2017 11:04:10 +0000 (12:04 +0100)]
Merge pull request #3698 from rjcorrig/kb3203884
winpr: Updates time zone data to December 2016
Robert Corrigan [Wed, 11 Jan 2017 21:56:34 +0000 (16:56 -0500)]
Update timezone data to Dec 2016
Jakub Adam [Sun, 1 Jan 2017 18:45:50 +0000 (19:45 +0100)]
Allow custom MultifragMaxRequestSize in server mode
FreeRDP calculates default request size in server mode based upon
the desktop resolution. In practice, however, I've found clients (namely
MS Lync 2013) which would show only a black screen when the value is
greater than 0x3EFFFF.
This change allows to override the default in such special cases by
assigning a different value to server->settings->MultifragMaxRequestSize
after the shadow server structure is initialized in shadow_server_new().
akallabeth [Wed, 11 Jan 2017 15:31:15 +0000 (16:31 +0100)]
Merge pull request #3622 from khvMX/master
Ungrab keyboard feature for X11
Armin Novak [Tue, 10 Jan 2017 13:15:53 +0000 (14:15 +0100)]
Unified clear internal buffer resize.
Internal datastructures now opaque.
Armin Novak [Tue, 10 Jan 2017 09:23:49 +0000 (10:23 +0100)]
Removed duplicated format variable.